gdb/ChangeLog

   1 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * regcache.c (pid_ptid_regcache_map): New type.
   4         (target_ptid_regcache_map): Remove.
   5         (target_pid_ptid_regcache_map): New type.
   6         (regcaches): Change type to target_pid_ptid_regcache_map.
   7         (get_thread_arch_aspace_regcache): Update.
   8         (regcache_thread_ptid_changed): Update, handle pid-like ptid
   9         case.
  10         (regcaches_size): Update.
  11         (regcache_count): Update.
  12         (registers_changed_ptid_target_pid_test): New.
  13         (_initialize_regcache): Register new test.
  14
  15 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
  16
  17         * regcache.c (regcache_count): New.
  18         (struct regcache_test_data): New.
  19         (regcache_test_data_up): New.
  20         (populate_regcaches_for_test): New.
  21         (regcaches_test): Remove.
  22         (get_thread_arch_aspace_regcache_test): New.
  23         (registers_changed_ptid_all_test): New.
  24         (registers_changed_ptid_target_test): New.
  25         (registers_changed_ptid_target_ptid_test): New.
  26         (regcache_thread_ptid_changed): Remove regcache_count lambda.
  27         (_initialize_regcache): Register new tests.
  28
  29 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * regcache.c (test_get_thread_arch_aspace_regcache): Rename to...
  32         (get_thread_arch_aspace_regcache_and_check): ... this.  Remove
  33         gdbarch and aspace parameter.  Use current inferior's aspace.
  34         Validate regcache's arch value.
  35         (regcaches_test): Update.
  36
  37 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
  38
  39         * regcache.c (regcaches_test): Call registers_changed.
  40
  41 2020-08-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  42
  43         * infrun.c (process_event_stop_test): Fix typo "breapoint".
  44
  45 2020-08-19  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
  46
  47         * amd64-tdep.c (amd64_skip_prologue): Using symbol table
  48         to find the end of prologue for flang compiled binaries.
  49         * arm-tdep.c (arm_skip_prologue): Likewise.
  50         * i386-tdep.c (i386_skip_prologue): Likewise.
  51         * producer.c (producer_is_llvm): New function.
  52         (producer_parsing_tests): Added new tests for clang/flang.
  53         * producer.h (producer_is_llvm): New declaration.
  54
  55 2020-08-18  Simon Marchi  <simon.marchi@efficios.com>
  56
  57         * linux-nat.c (linux_nat_debug_printf): New function.
  58         (linux_nat_debug_printf_1): New macro.  Use throughout the file.
  59
  60 2020-08-18  Aaron Merey  <amerey@redhat.com>
  61
  62         * Makefile.in (DEBUGINFOD_CFLAGS, DEBUGINFOD_LIBS): New variables.
  63         (INTERNAL_CFLAGS_BASE): Add DEBUGINFOD_CFLAGS.
  64         (CLIBS): Add DEBUGINFOD_LIBS.
  65
  66 2020-08-17  Sergei Trofimovich  <siarheit@google.com>
  67
  68         * ia64-linux-nat.c: Include "gdbarch.h" to declare used
  69         'gdbarch_num_regs'.
  70
  71 2020-08-17  Tom Tromey  <tromey@adacore.com>
  72
  73         * ada-varobj.c (ada_varobj_decode_var): Handle case where
  74         ada_get_decoded_value returns NULL.
  75
  76 2020-08-17  Tom Tromey  <tromey@adacore.com>
  77
  78         * python/py-inferior.c (infpy_search_memory): Use
  79         gdb_py_object_from_ulongest.
  80         * python/py-infevents.c (create_inferior_call_event_object)
  81         (create_memory_changed_event_object): Use
  82         gdb_py_object_from_ulongest.
  83         * python/py-linetable.c (ltpy_entry_get_pc): Use
  84         gdb_py_object_from_ulongest.
  85
  86 2020-08-17  Simon Marchi  <simon.marchi@polymtl.ca>
  87
  88         * loc.c (class symbol_needs_eval_context): Fix indentation.
  89
  90 2020-08-17  Simon Marchi  <simon.marchi@polymtl.ca>
  91
  92         * dwarf2/loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use
  93         bool.
  94
  95 2020-08-17  Tom de Vries  <tdevries@suse.de>
  96
  97         PR gdb/26393
  98         * gdbtypes.c (dump_dynamic_prop): New function.
  99         (recursive_dump_type): Use dump_dynamic_prop for TYPE_CODE_RANGE.
 100
 101 2020-08-15  Tom de Vries  <tdevries@suse.de>
 102
 103         PR backtrace/26390
 104         * stack.c (print_frame_args): Temporarily set the selected
 105         frame to FRAME while printing the frame's arguments.
 106
 107 2020-08-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 108
 109         PR breakpoints/26385
 110         * ppc-linux-nat.c (ppc_linux_nat_target::low_prepare_to_resume):
 111         Always clear watchpoint with PTRACE_SET_DEBUGREG.
 112
 113 2020-08-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 114
 115         * ppc-linux-nat.c (ppc_linux_dreg_interface::detect)
 116         (ppc_linux_nat_target::low_prepare_to_resume): Use ptrace () < 0
 117         and >= to check return value instead of == -1 and != -1.
 118
 119 2020-08-14  Simon Marchi  <simon.marchi@polymtl.ca>
 120
 121         * utils.h (class gdb_argv) <as_array_view>: New method.
 122         * utils.c (gdb_argv_as_array_view_test): New.
 123         (_initialize_utils): Register selftest.
 124         * maint.c (maintenance_selftest): Use the new method.
 125
 126 2020-08-13  Kamil Rytarowski  <n54@gmx.com>
 127
 128         * target.h (supports_dumpcore, dumpcore): New
 129         function declarations.
 130         * target.c (supports_dumpcore, dumpcore): New
 131         functions.
 132         * target-delegates.c: Rebuild.
 133         * gcore.c (gcore_command): Use target_supports_dumpcore ()
 134         and target_dumpcore ().
 135
 136 2020-08-13  Aaron Merey  <amerey@redhat.com>
 137
 138         * debuginfod-support.c: Replace global variables with user_data.
 139
 140 2020-08-13  Simon Marchi  <simon.marchi@polymtl.ca>
 141
 142         * maint.c (maintenance_selftest): Split args and pass array_view
 143         to run_tests.
 144
 145 2020-08-12  Luis Machado  <luis.machado@linaro.org>
 146
 147         * value.c (check_type_length_before_alloc): Use ULONGEST to store a
 148         type's length.
 149         Use %s and pulongest to print the length.
 150
 151 2020-08-12  Pedro Alves  <palves@redhat.com>
 152
 153         * NEWS: Move "Multi-target debugging support" item to the
 154         "Changes since GDB 9" section.
 155
 156 2020-08-12  Pedro Alves  <palves@redhat.com>
 157
 158         PR gdb/26336
 159         * progspace.c (program_space::remove_objfile): Invalidate the
 160         frame cache.
 161
 162 2020-08-11  Tom de Vries  <tdevries@suse.de>
 163
 164         * MAINTAINERS: Mark ms1 as deleted.
 165
 166 2020-08-10  Luis Machado  <luis.machado@linaro.org>
 167
 168         PR gdb/26310
 169
 170         * aarch64-tdep.c (aarch64_analyze_prologue): Track use of SP/FP and
 171         act accordingly.
 172         (aarch64_analyze_prologue_test): Add more unit tests to exercise
 173         movz/str/stur/stp skipping behavior.
 174
 175 2020-08-10  Luis Machado  <luis.machado@linaro.org>
 176
 177         * nat/aarch64-sve-linux-sigcontext.h (SVE_PT_REGS_OFFSET): Use
 178         struct user_sve_header instead of struct sve_context.
 179
 180 2020-08-09  Simon Marchi  <simon.marchi@polymtl.ca>
 181
 182         * read.h (dwarf2_fetch_die_loc_sect_off,
 183         dwarf2_fetch_die_loc_cu_off): Replace function pointer +
 184         `void *` parameter with function_view.
 185         * read.c (dwarf2_fetch_die_loc_sect_off,
 186         dwarf2_fetch_die_loc_cu_off): Likewise.
 187         * loc.c (get_frame_pc_for_per_cu_dwarf_call): Remove.
 188         (per_cu_dwarf_call): Adjust.
 189         (get_frame_address_in_block_wrapper): Remove.
 190         (indirect_synthetic_pointer): Adjust.
 191         (get_ax_pc): Remove.
 192         (dwarf2_compile_expr_to_ax): Adjust.
 193
 194 2020-08-08  Tom de Vries  <tdevries@suse.de>
 195
 196         PR build/26344
 197         * arch/riscv.c (riscv_lookup_target_description): Use an explicit
 198         constructor.
 199         * regcache.c (get_thread_arch_aspace_regcache): Same.
 200
 201 2020-08-07  Tom Tromey  <tromey@adacore.com>
 202
 203         * ravenscar-thread.c
 204         (ravenscar_thread_target::set_base_thread_from_ravenscar_task):
 205         New method.
 206         (ravenscar_thread_target::wait): Check
 207         runtime_initialized.
 208         (ravenscar_thread_target::prepare_to_store)
 209         (ravenscar_thread_target::stopped_by_sw_breakpoint)
 210         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 211         (ravenscar_thread_target::stopped_by_watchpoint)
 212         (ravenscar_thread_target::stopped_data_address)
 213         (ravenscar_thread_target::core_of_thread): Use
 214         scoped_restore_current_thread and
 215         set_base_thread_from_ravenscar_task.
 216
 217 2020-08-07  Tom Tromey  <tromey@adacore.com>
 218
 219         * ravenscar-thread.c (update_thread_list): Set inferior_ptid.
 220
 221 2020-08-07  Tom Tromey  <tromey@adacore.com>
 222
 223         * ravenscar-thread.c (ravenscar_thread_target::wait): Call
 224         update_inferior_ptid before update_thread_list.
 225         (temporarily_change_regcache_ptid): New class.
 226         (ravenscar_thread_target::fetch_registers)
 227         (ravenscar_thread_target::store_registers)
 228         (ravenscar_thread_target::prepare_to_store): Use base thread when
 229         forwarding operation.
 230
 231 2020-08-07  Tom Tromey  <tromey@adacore.com>
 232
 233         * ravenscar-thread.c (ravenscar_thread_target::resume): Handle
 234         "is_pid" case.
 235
 236 2020-08-07  Tom Tromey  <tromey@adacore.com>
 237
 238         * ravenscar-thread.c (xfer_partial, enable_btrace, add_thread):
 239         New methods.
 240         (ravenscar_thread_target::get_thread_base_cpu): Check m_cpu_map
 241         first.
 242         (ravenscar_thread_target::add_thread): Rename from
 243         ravenscar_add_thread.
 244         (ravenscar_thread_target::update_thread_list): Use a lambda.
 245         (ravenscar_thread_target::xfer_partial): New method.
 246
 247 2020-08-07  Tom Tromey  <tromey@adacore.com>
 248
 249         * ada-lang.h (ada_task_list_iterator_ftype): Now a
 250         gdb::function_view.
 251         (iterate_over_live_ada_tasks): Change type of argument.
 252         * ada-tasks.c (iterate_over_live_ada_tasks): Change type
 253         of argument.
 254
 255 2020-08-07  Tom Tromey  <tromey@adacore.com>
 256
 257         * ravenscar-thread.c (ravenscar_thread_target) <extra_thread_info>:
 258         Remove.
 259         (ravenscar_thread_target::extra_thread_info): Remove.
 260         (ravenscar_thread_target::pid_to_str): Mention Ravenscar in result;
 261         defer to target beneath for non-Ravenscar threads.
 262
 263 2020-08-07  Tom Tromey  <tromey@adacore.com>
 264
 265         * ravenscar-thread.c (ravenscar_thread_target) <get_base_cpu,
 266         get_base_thread_from_ravenscar_task>: Now methods.
 267         <m_cpu_map>: New member.
 268         (ravenscar_thread_target::get_thread_base_cpu): Rename from
 269         ravenscar_get_thread_base_cpu.  Check m_cpu_map.
 270         (ravenscar_thread_target::task_is_currently_active): Update.
 271         (ravenscar_thread_target::get_base_thread_from_ravenscar_task):
 272         Now a method.
 273         (ravenscar_thread_target::add_active_thread): Put initial thread
 274         into the m_cpu_map.
 275
 276 2020-08-07  Tom Tromey  <tromey@adacore.com>
 277
 278         * ravenscar-thread.c (ravenscar_thread_target::wait): Return
 279         event_ptid.
 280
 281 2020-08-07  Tom Tromey  <tromey@adacore.com>
 282
 283         * ravenscar-thread.c (ravenscar_thread_target::wait): Check
 284         runtime_initialized.
 285
 286 2020-08-07  Tom Tromey  <tromey@adacore.com>
 287
 288         * ravenscar-thread.c (ravenscar_thread_target): Don't call
 289         add_active_thread.
 290         (ravenscar_thread_target::add_active_thread): Now public.
 291         (ravenscar_inferior_created): Call add_active_thread after pushing
 292         the target.
 293
 294 2020-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
 295
 296         * regcache.c (ptid_regcache_map): New type.
 297         (target_ptid_regcache_map): New type.
 298         (regcaches): Change type to target_ptid_regcache_map.
 299         (get_thread_arch_aspace_regcache): Update to regcaches' new
 300         type.
 301         (regcache_thread_ptid_changed): Likewise.
 302         (registers_changed_ptid): Likewise.
 303         (regcaches_size): Likewise.
 304         (regcaches_test): Update.
 305         (regcache_thread_ptid_changed): Update.
 306         * regcache.h (regcache_up): New type.
 307         * gdbsupport/ptid.h (hash_ptid): New struct.
 308
 309 2020-08-07  Simon Marchi  <simon.marchi@efficios.com>
 310
 311         * observable.h (thread_ptid_changed): Add parameter
 312         `process_stratum_target *`.
 313         * infrun.c (infrun_thread_ptid_changed): Add parameter
 314         `process_stratum_target *` and use it.
 315         (selftests): New namespace.
 316         (infrun_thread_ptid_changed): New function.
 317         (_initialize_infrun): Register selftest.
 318         * regcache.c (regcache_thread_ptid_changed): Add parameter
 319         `process_stratum_target *` and use it.
 320         (regcache_thread_ptid_changed): New function.
 321         (_initialize_regcache): Register selftest.
 322         * thread.c (thread_change_ptid): Pass target to
 323         thread_ptid_changed observable.
 324
 325 2020-08-06  Caroline Tice <cmtice@google.com>
 326
 327         * dwarf2/read.c (struct dwo_file): Update comment on 'sections' field.
 328         (struct dwp_sections): Update field comments.  Add loclists and
 329         rnglists fields.
 330         (struct virtual_v2_dwo_sections): Rename struct to
 331         'virtual_v2_or_v5_dwo_sections'; update comments at top of struct; add
 332         size & offset fields for loclists and rnglists.
 333         (struct dwp_hash_table): Add a 'v5' struct field to the union section.
 334         (create_debug_type_hash_table): Add 'DW_UT_split_type' to the check for
 335         skipping dummy type units.
 336         (create_dwp_hash_table): Update the large comment above the function to
 337         discuss Version 5 DWP files as well, with references.  Update all the
 338         version checks in the function to check for version 5 as well.  Add new
 339         section at the end to create dwp hash table for version 5.
 340         (create_dwp_v2_section): Rename function to
 341         'create_dwp_v2_or_v5_section'.  Update function comment appropriately.
 342         Add V5 to error message text.
 343         (create_dwo_unit_in_dwp_v2): Change calls to create_dwp_v2_section
 344         into calls to create_dwp_v2_or_v5_section.
 345         (create_dwo_unit_in_dwp_v5): New function.
 346         (lookup_dwo_unit_in_dwp): Update conditional statement to explicitly
 347         check for version2; add else clause to handle version 5.
 348         (open_and_init_dwo_file): Add code to check dwarf version & only call
 349         create_debug_types_hash_table (with sections.types) if version is not 5;
 350         else call create_debug_type_hash_table, with sections.info.
 351         (dwarf2_locate_v2_dwp_sections): Update function comment to mention
 352         version 5.
 353         (dwarf2_locate_v5_dwp_sections): New function.
 354         (open_and_init_dwp_file): Add else-if clause for version 5 to call
 355         bfd_map_over_sections with dwarf2_locate_v5_dwp_sections.
 356
 357 2020-08-06  Simon Marchi  <simon.marchi@efficios.com>
 358
 359         * regcache.h (class regcache): Remove friend
 360         registers_changed_ptid.
 361         <regcache_thread_ptid_changed>: Remove.
 362         <regcaches>: Remove.
 363         * regcache.c (regcache::regcaches): Rename to...
 364         (regcaches): ... this.  Make static.
 365         (get_thread_arch_aspace_regcache): Update.
 366         (regcache::regcache_thread_ptid_changed): Rename to...
 367         (regcache_thread_ptid_changed): ... this.  Update.
 368         (class regcache_access): Remove.
 369         (regcaches_test): Update.
 370         (_initialize_regcache): Update.
 371         * sparc64-tdep.c, dwarf2/index-write.c, record-btrace.c: Include
 372         <forward_list>.
 373
 374 2020-08-06  Simon Marchi  <simon.marchi@efficios.com>
 375
 376         * regcache.h (class regcache) <current_regcache>: Rename to...
 377         <regcaches>: ... this.  Move doc here.
 378         * regcache.c (regcache::current_regcache) Rename to...
 379         (regcache::regcaches): ... this.  Move doc to header.
 380         (get_thread_arch_aspace_regcache): Update.
 381         (regcache::regcache_thread_ptid_changed): Update.
 382         (registers_changed_ptid): Update.
 383         (class regcache_access) <current_regcache_size>: Rename to...
 384         <regcaches_size>: ... this.
 385         (current_regcache_test): Rename to...
 386         (regcaches_test): ... this.
 387         (_initialize_regcache): Update.
 388
 389 2020-08-06  Victor Collod  <vcollod@nvidia.com>
 390
 391         * amd64-tdep.c (amd64_analyze_prologue): Fix incorrect comment.
 392
 393 2020-08-05  Kevin Buettner  <kevinb@redhat.com>
 394
 395         * corelow.c (core_target::build_file_mappings): Don't output
 396         null pathname in warning.
 397
 398 2020-08-05  Simon Marchi  <simon.marchi@polymtl.ca>
 399
 400         * gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
 401         gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
 402         gdb.dwarf2/dw2-single-line-discriminators.exp,
 403         dw2-undefined-ret-addr.exp: Pass nopie to compilation options.
 404
 405 2020-08-05  Tom Tromey  <tromey@adacore.com>
 406
 407         PR rust/26197:
 408         * dwarf2/read.c (alloc_rust_variant): Handle univariant case.
 409         (quirk_rust_enum): Call alloc_rust_variant for univariant case.
 410         Fix off-by-one and type size errors in ordinary case.
 411
 412 2020-08-05  Tom de Vries  <tdevries@suse.de>
 413
 414         * gdbtypes.c (type_not_allocated, type_not_associated): Use
 415         "prop->const_val () == 0" instead of "prop->const_val () != 0".
 416
 417 2020-08-04  Simon Marchi  <simon.marchi@efficios.com>
 418
 419         * frame.h (frame_id_p): Return bool.
 420         (frame_id_artificial_p): Return bool.
 421         (frame_id_eq): Return bool.
 422         (has_stack_frames): Return bool.
 423         (get_selected_frame): Fix typo in comment.
 424         (get_frame_pc_if_available): Return bool.
 425         (get_frame_address_in_block_if_available): Return bool.
 426         (get_frame_func_if_available): Return bool.
 427         (read_frame_register_unsigned): Return bool.
 428         (get_frame_register_bytes): Return bool.
 429         (safe_frame_unwind_memory): Return bool.
 430         (deprecated_frame_register_read): Return bool.
 431         (frame_unwinder_is): Return bool.
 432         * frame.c (struct frame_info) <prev_arch::p>: Change type to
 433         bool.
 434         <this_id::p>: Likewise.
 435         <prev_p>: Likewise.
 436         (frame_stash_add): Return bool.
 437         (get_frame_id): Use bool.
 438         (frame_id_build_special) Use bool.
 439         (frame_id_build_unavailable_stack): Use bool.
 440         (frame_id_build): Use bool.
 441         (frame_id_p): Return bool, use true/false instead of 1/0.
 442         (frame_id_artificial_p): Likewise.
 443         (frame_id_eq): Likewise.
 444         (frame_id_inner): Likewise.
 445         (get_frame_func_if_available): Likewise.
 446         (read_frame_register_unsigned): Likewise.
 447         (deprecated_frame_register_read): Likewise.
 448         (get_frame_register_bytes): Likewise.
 449         (has_stack_frames): Likewise.
 450         (inside_main_func): Likewise.
 451         (inside_entry_func): Likewise.
 452         (get_frame_pc_if_available): Likewise.
 453         (get_frame_address_in_block_if_available): Likewise.
 454         (frame_unwinder_is): Likewise.
 455         (safe_frame_unwind_memory): Likewise.
 456         (frame_unwind_arch): Likewise.
 457
 458 2020-08-04  Simon Marchi  <simon.marchi@efficios.com>
 459
 460         * frame.c (frame_info) <prev_func> <p>: Rename to status, change
 461         type to cached_copy_status.
 462         (fprintf_frame): Adjust.
 463         (get_frame_func_if_available): Adjust.
 464         (frame_cleanup_after_sniffer): Adjust.
 465
 466 2020-08-04  Mark Wielaard  <mark@klomp.org>
 467
 468         * MAINTAINERS (Write After Approval): Update email address.
 469
 470 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 471
 472         * gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with
 473         dynamic_prop::const_val.
 474
 475 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 476
 477         * gdbtypes.h (TYPE_DYN_PROP_KIND): Remove, replace uses with
 478         dynamic_prop::kind.
 479
 480 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 481
 482         * gdbtypes.h (TYPE_DYN_PROP_BATON): Remove.
 483
 484 2020-08-04  Jose E. Marchesi  <jose.marchesi@oracle.com>
 485
 486         * configure.tgt: Set gdb_sim for bpf-*-* targets.
 487
 488 2020-08-04  Weimin Pan <weimin.pan@oracle.com>
 489             Jose E. Marchesi  <jose.marchesi@oracle.com>
 490
 491         * configure.tgt: Add entry for bpf-*-*.
 492         * Makefile.in (ALL_TARGET_OBS): Add bpf-tdep.o
 493         (ALLDEPFILES): Add bpf-tdep.c.
 494         * bpf-tdep.c: New file.
 495         * MAINTAINERS: Add bpf target and maintainer.
 496         * NEWS: Mention the support for the new target.
 497
 498 2020-08-04  Tom de Vries  <tdevries@suse.de>
 499
 500         PR symtab/23270
 501         * dwarf2/read.c (find_partial_die): Change internal error into Dwarf
 502         Error.
 503
 504 2020-08-03  John Baldwin  <jhb@FreeBSD.org>
 505
 506         * syscalls/freebsd.xml: Regenerate.
 507
 508 2020-08-03  John Baldwin  <jhb@FreeBSD.org>
 509
 510         * syscalls/update-freebsd.sh: Fix usage and year range.
 511
 512 2020-08-03  Tom de Vries  <tdevries@suse.de>
 513
 514         PR symtab/26333
 515         * dwarf2/read.c (dwarf_decode_lines_1): Ignore
 516         DW_LNE_lo_user/DW_LNE_hi_user range.
 517
 518 2020-07-30  Simon Marchi  <simon.marchi@polymtl.ca>
 519
 520         PR ada/26318
 521         * ada-lang.c (ada_modulus): Return 0 if property is not of const
 522         kind.
 523
 524 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 525
 526         * breakpoint.c (set_breakpoint_condition): Do minor refactoring.
 527
 528 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 529
 530         * breakpoint.c (set_breakpoint_condition): Update the condition
 531         expressions after checking that the input condition string parses
 532         successfully and does not contain junk at the end.
 533
 534 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 535
 536         * breakpoint.c (set_breakpoint_condition): Update the
 537         condition string after parsing the new condition successfully.
 538
 539 2020-07-30  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 540
 541         * proc-api.c (_STRUCTURED_PROC): Don't define.
 542         * proc-events.c: Likewise.
 543         * proc-flags.c: Likewise.
 544         * proc-why.c: Likewise.
 545         * procfs.c: Likewise.
 546
 547         * Makefile.in (INTERNAL_CPPFLAGS): Add LARGEFILE_CPPFLAGS.
 548         * configure, config.in: Regenerate.
 549
 550 2020-07-30  Tom de Vries  <tdevries@suse.de>
 551
 552         PR build/26320
 553         * ui-style.h (struct ui_file_style::color): Wrap m_value and
 554         m_red/m_green/m_blue in a union.
 555
 556 2020-07-29  Tom de Vries  <tdevries@suse.de>
 557
 558         PR tdep/26280
 559         * s390-tdep.c (s390_displaced_step_fixup): Fix Wmaybe-uninitialized.
 560
 561 2020-07-28  Tom Tromey  <tromey@adacore.com>
 562
 563         PR symtab/26270:
 564         * symtab.h (find_pc_partial_function_sym): Declare.
 565         * cli/cli-cmds.c (disassemble_command): Use
 566         find_pc_partial_function_sym.  Check asm_demangle.
 567         * blockframe.c (cache_pc_function_sym): New global.
 568         (cache_pc_function_name): Remove.
 569         (clear_pc_function_cache): Update.
 570         (find_pc_partial_function_sym): New function, from
 571         find_pc_partial_function.
 572         (find_pc_partial_function): Rewrite using
 573         find_pc_partial_function_sym.
 574
 575 2020-07-28  Tom Tromey  <tromey@adacore.com>
 576
 577         * cli/cli-cmds.c (_initialize_cli_cmds): Rearrange "disassemble"
 578         help.  Add usage.
 579
 580 2020-07-28  Tom Tromey  <tromey@adacore.com>
 581
 582         * dwarf2/expr.c (dwarf_expr_context::execute_stack_op)
 583         <DW_OP_GNU_variable_value>: Cast to address type.
 584
 585 2020-07-28  Kamil Rytarowski  <n54@gmx.com>
 586
 587         * nbsd-nat.h (nbsd_nat_target::xfer_partial): New declaration.
 588         * nbsd-nat.c (nbsd_nat_target::xfer_partial): New function.
 589         * nbsd-tdep.c (nbsd_gdbarch_data_handle, struct nbsd_gdbarch_data)
 590         (init_nbsd_gdbarch_data, get_nbsd_gdbarch_data)
 591         (nbsd_get_siginfo_type): New.
 592         (nbsd_init_abi): Install gdbarch "get_siginfo_type" method.
 593         (_initialize_nbsd_tdep): New.
 594
 595 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
 596
 597         PR binutils/26301
 598         * configure: Regenerated.
 599
 600 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
 601
 602         PR binutils/26301
 603         * configure: Regenerated.
 604
 605 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * python/py-frame.c: Remove 'user-regs.h' include.
 608         (frapy_read_register): Rewrite to make use of
 609         gdbpy_parse_register_id.
 610         * python/py-registers.c (gdbpy_parse_register_id): New function,
 611         moved here from python/py-unwind.c.  Updated the return type, and
 612         also accepts register descriptor objects.
 613         * python/py-unwind.c: Remove 'user-regs.h' include.
 614         (pyuw_parse_register_id): Moved to python/py-registers.c.
 615         (unwind_infopy_add_saved_register): Update to use
 616         gdbpy_parse_register_id.
 617         (pending_framepy_read_register): Likewise.
 618         * python/python-internal.h (gdbpy_parse_register_id): Declare.
 619
 620 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * python/py-registers.c: Add 'user-regs.h' include.
 623         (register_descriptor_iter_find): New function.
 624         (register_descriptor_iterator_object_methods): New static global
 625         methods array.
 626         (register_descriptor_iterator_object_type): Add pointer to methods
 627         array.
 628
 629 2020-07-27  John Baldwin  <jhb@FreeBSD.org>
 630
 631         * fbsd-nat.h: Include <osreldate.h>.  Define USE_SIGTRAP_SIGINFO
 632         for all architectures on FreeBSD 11.3 and later.
 633
 634 2020-07-27  Tom Tromey  <tromey@adacore.com>
 635
 636         * gcore.h (load_corefile): Don't declare.
 637
 638 2020-07-27  Tom de Vries  <tdevries@suse.de>
 639
 640         * configure.ac: Fix sys/sockets.h -> sys/socket.h typo.
 641         * config.in: Regenerate.
 642         * configure: Regenerate.
 643
 644 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 645
 646         * configure.ac (AC_CHECK_HEADERS): Check for sys/socket.h and
 647         ws2tcpip.h.  When checking whether socklen_t type is defined, use
 648         ws2tcpip.h if it is available and sys/socket.h isn't.
 649         * configure: Regenerate.
 650         * config.in: Regenerate.
 651
 652 2020-07-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         PR fortran/23051
 655         PR fortran/26139
 656         * valops.c (value_ind): Pass address to
 657         readjust_indirect_value_type.
 658         * value.c (readjust_indirect_value_type): Make parameter
 659         non-const, and add extra address parameter.  Resolve original type
 660         before using it.
 661         * value.h (readjust_indirect_value_type): Update function
 662         signature and comment.
 663
 664 2020-07-25  Tom de Vries  <tdevries@suse.de>
 665
 666         PR symtab/26243
 667         * dwarf2/read.c (lnp_state_machine::record_line): Ignore zero line
 668         entries.
 669
 670 2020-07-24  Aaron Merey  <amerey@redhat.com>
 671
 672         * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
 673         * configure: Rebuild.
 674
 675 2020-07-23  Kevin Buettner  <kevinb@redhat.com>
 676
 677         PR corefiles/26294
 678         * corelow.c (_initialize_corelow): Add period to help text
 679         for "maintenance print core-file-backed-mappings".
 680
 681 2020-07-23  Pedro Alves  <pedro@palves.net>
 682
 683         * frame-unwind.c (frame_unwind_try_unwinder): On exception, don't
 684         touch THIS_CACHE/THIS_FRAME if the frame cache was cleared
 685         meanwhile.
 686         * frame.c (frame_cache_generation, get_frame_cache_generation):
 687         New.
 688         (reinit_frame_cache): Increment FRAME_CACHE_GENERATION.
 689         (get_prev_frame_if_no_cycle): On exception, don't touch
 690         PREV_FRAME/THIS_FRAME if the frame cache was cleared meanwhile.
 691         * frame.h (get_frame_cache_generation): Declare.
 692
 693 2020-07-23  Tom de Vries  <tdevries@suse.de>
 694
 695         PR tui/26282
 696         * tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
 697         New default constructor.
 698
 699 2020-07-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 700
 701         * disasm.c (do_mixed_source_and_assembly_deprecated): Don't
 702         exclude non-statement entries.
 703
 704 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 705
 706         * NEWS (New commands): Mention new command
 707         "maintenance print core-file-backed-mappings".
 708
 709 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 710
 711         * corelow.c (gdbcmd.h): Include.
 712         (core_target::info_proc_mappings): New method.
 713         (get_current_core_target): New function.
 714         (maintenance_print_core_file_backed_mappings): New function.
 715         (_initialize_corelow): Add core-file-backed-mappings to
 716         "maint print" commands.
 717
 718 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 719
 720         * linux-tdep.c (dump_note_entry_p): New function.
 721         (linux_dump_mapping_p_ftype): New typedef.
 722         (linux_find_memory_regions_full): Add new parameter,
 723         should_dump_mapping_p.
 724         (linux_find_memory_regions): Adjust call to
 725         linux_find_memory_regions_full.
 726         (linux_make_mappings_core_file_notes): Use dump_note_entry_p in
 727         call to linux_find_memory_regions_full.
 728
 729 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 730
 731         * corelow.c (solist.h, unordered_map): Include.
 732         (class core_target): Add field m_core_file_mappings and
 733         method build_file_mappings.
 734         (core_target::core_target): Call build_file_mappings.
 735         (core_target::~core_target): Free memory associated with
 736         m_core_file_mappings.
 737         (core_target::build_file_mappings): New method.
 738         (core_target::xfer_partial): Use m_core_file_mappings
 739         for memory transfers.
 740         * linux-tdep.c (linux_read_core_file_mappings): New
 741         function.
 742         (linux_core_info_proc_mappings): Rewrite to use
 743         linux_read_core_file_mappings.
 744         (linux_init_abi): Register linux_read_core_file_mappings.
 745
 746 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 747
 748         * arch-utils.c (default_read_core_file_mappings): New function.
 749         * arch-utils.c (default_read_core_file_mappings): Declare.
 750         * gdbarch.sh (read_core_file_mappings): New gdbarch method.
 751         * gdbarch.h, gdbarch.c: Regenerate.
 752
 753 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 754
 755         PR corefiles/25631
 756         * corelow.c (core_target:xfer_partial):  Revise
 757         TARGET_OBJECT_MEMORY case to consider non-SEC_HAS_CONTENTS
 758         case after first checking the stratum beneath the core
 759         target.
 760         (has_all_memory): Return true.
 761         * target.c (raw_memory_xfer_partial): Revise comment
 762         regarding use of has_all_memory.
 763
 764 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 765
 766         * exec.h (section_table_xfer_memory): Revise declaration,
 767         replacing section name parameter with an optional callback
 768         predicate.
 769         * exec.c (section_table_xfer_memory): Likewise.
 770         * bfd-target.c, exec.c, target.c, corelow.c: Adjust all callers
 771         of section_table_xfer_memory.
 772
 773 2020-07-22  Tom Tromey  <tromey@adacore.com>
 774
 775         * mi/mi-cmd-stack.c (list_args_or_locals): Use
 776         lookup_symbol_search_name.
 777
 778 2020-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * python/py-registers.c (gdbpy_register_object_data_init): Remove
 781         redundant local variable.
 782         (gdbpy_get_register_descriptor): Extract descriptor vector as a
 783         reference, not pointer, update code accordingly.
 784
 785 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 786             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 787
 788         * objfiles.h (struct objfile) <skip_jit_symbol_lookup>: New field.
 789         * jit.c (jit_breakpoint_re_set_internal): Use the
 790         `skip_jit_symbol_lookup` field.
 791
 792 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 793             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 794
 795         * jit.c (jit_read_descriptor): Define the descriptor address once,
 796         use twice.
 797         (jit_breakpoint_deleted): Move the declaration of the loop variable
 798         `iter` into the loop header.
 799         (jit_breakpoint_re_set_internal): Move the declaration of the local
 800         variable `objf_data` to the first point of definition.
 801         (jit_event_handler): Move the declaration of local variables
 802         `code_entry`, `entry_addr`, and `objf` to their first point of use.
 803         Rename `objf` to `jited`.
 804
 805 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 806
 807         * jit.h (struct jiter_objfile_data) <jiter_objfile_data, objfile>:
 808         Remove.
 809         * jit.c (get_jiter_objfile_data): Update.
 810
 811 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 812             Simon Marchi  <simon.marchi@polymtl.ca>
 813
 814         * jit.c (struct jit_program_space_data): Remove.
 815         (jit_program_space_key): Remove.
 816         (jiter_objfile_data::~jiter_objfile_data): Remove program space
 817         stuff.
 818         (get_jit_program_space_data): Remove.
 819         (jit_breakpoint_deleted): Iterate on all of the program space's
 820         objfiles.
 821         (jit_inferior_init): Likewise.
 822         (jit_breakpoint_re_set_internal): Likewise.  Also change return
 823         type to void.
 824         (jit_breakpoint_re_set): Pass current_program_space to
 825         jit_breakpoint_re_set_internal.
 826
 827 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 828
 829         * jit.h (struct jiter_objfile_data) <cached_code_address,
 830         jit_breakpoint>: Move to here from ...
 831         * jit.c (jit_program_space_data): ... here.
 832         (jiter_objfile_data::~jiter_objfile_data): Update.
 833         (jit_breakpoint_deleted): Update.
 834         (jit_breakpoint_re_set_internal): Update.
 835
 836 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 837
 838         * jit.c (jiter_objfile_data::~jiter_objfile_data): Remove some
 839         checks.
 840         (jit_read_descriptor): Remove NULL check.
 841         (jit_event_handler): Add an assertion.
 842
 843 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 844
 845         * jit.h (struct jit_objfile_data):  Split into...
 846         (struct jiter_objfile_data): ... this ...
 847         (struct jited_objfile_data): ... and this.
 848         * objfiles.h (struct objfile) <jit_data>: Remove.
 849         <jiter_data, jited_data>: New fields.
 850         * jit.c (jit_objfile_data::~jit_objfile_data): Rename to ...
 851         (jiter_objfile_data::~jiter_objfile_data): ... this.
 852         (get_jit_objfile_data): Rename to ...
 853         (get_jiter_objfile_data): ... this.
 854         (add_objfile_entry): Update.
 855         (jit_read_descriptor): Use get_jiter_objfile_data.
 856         (jit_find_objf_with_entry_addr): Use objfile's jited_data field.
 857         (jit_breakpoint_re_set_internal): Use get_jiter_objfile_data.
 858         (jit_inferior_exit_hook): Use objfile's jited_data field.
 859
 860 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 861
 862         * jit.h: Forward-declare `struct minimal_symbol`.
 863         (struct jit_objfile_data): Migrate to here from jit.c; also add a
 864         constructor, destructor, and an objfile* field.
 865         * jit.c (jit_objfile_data): Remove.
 866         (struct jit_objfile_data): Migrate from here to jit.h.
 867         (jit_objfile_data::~jit_objfile_data): New destructor
 868         implementation with code moved from free_objfile_data.
 869         (free_objfile_data): Delete.
 870         (get_jit_objfile_data): Update to use the jit_data field of objfile.
 871         (jit_find_objf_with_entry_addr): Ditto.
 872         (jit_inferior_exit_hook): Ditto.
 873         (_initialize_jit): Remove the call to
 874         register_objfile_data_with_cleanup.
 875         * objfiles.h (struct objfile) <jit_data>: New field.
 876
 877 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 878
 879         * jit.h: Forward-declare `struct objfile`.
 880         (jit_event_handler): Add a second parameter, the JITer objfile.
 881         * jit.c (jit_read_descriptor): Change the signature to take the
 882         JITer objfile as an argument instead of the jit_program_space_data.
 883         (jit_inferior_init): Update the call to jit_read_descriptor.
 884         (jit_event_handler): Use the new JITer objfile argument when calling
 885         jit_read_descriptor.
 886         * breakpoint.c (handle_jit_event): Update the call to
 887         jit_event_handler to pass the JITer objfile.
 888
 889 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 890
 891         * gdbarch.c: Regenerate.
 892         * gdbarch.h: Regenerate.
 893         * gdbarch.sh (handle_segmentation_fault): Remove method.
 894         * infrun.c (handle_segmentation_fault): Remove.
 895         (print_signal_received_reason): Remove call to
 896         handle_segmentation_fault.
 897
 898 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 899
 900         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 901         Rename to sparc64_linux_report_signal_info and add siggnal
 902         argument.
 903         (sparc64_linux_init_abi): Use sparc64_linux_report_signal_info
 904         instead of sparc64_linux_handle_segmentation_fault.
 905
 906 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 907
 908         * amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
 909         i386_linux_report_signal_info instead of
 910         i386_linux_handle_segmentation_fault.
 911         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
 912         to i386_linux_report_signal_info and add siggnal argument.
 913         (i386_linux_init_abi): Use i386_linux_report_signal_info instead
 914         of i386_linux_handle_segmentation_fault.
 915         * i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
 916         to i386_linux_report_signal_info and add siggnal argument.
 917
 918 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 919
 920         * corelow.c (core_target_open): Invoke gdbarch report_signal_info
 921         hook if present.
 922
 923 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 924
 925         * gdbarch.c: Regenerate.
 926         * gdbarch.h: Regenerate.
 927         * gdbarch.sh (report_signal_info): New method.
 928         * infrun.c (print_signal_received_reason): Invoke gdbarch
 929         report_signal_info hook if present.
 930
 931 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * python/py-registers.c : Add 'unordered_map' include.
 934         (gdbpy_new_reggroup): Renamed to...
 935         (gdbpy_get_reggroup): ...this.  Update to only create register
 936         group descriptors when needed.
 937         (gdbpy_reggroup_iter_next): Update.
 938
 939 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * python/py-registers.c (gdbpy_register_object_data): New static
 942         global.
 943         (gdbpy_register_object_data_init): New function.
 944         (gdbpy_new_register_descriptor): Renamed to...
 945         (gdbpy_get_register_descriptor): ...this, and update to reuse
 946         existing register descriptors where possible.
 947         (gdbpy_register_descriptor_iter_next): Update.
 948         (gdbpy_initialize_registers): Register new gdbarch data.
 949
 950 2020-07-21  Simon Marchi  <simon.marchi@efficios.com>
 951
 952         * linux-nat.c (stopped_pids): Make static.
 953
 954 2020-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
 955
 956         PR ada/26235
 957         * gdbtypes.c (ada_discrete_type_low_bound,
 958         ada_discrete_type_high_bound): Handle undefined bounds.
 959
 960 2020-07-21  Kamil Rytarowski  <n54@gmx.com>
 961
 962         * nbsd-nat.h (nbsd_nat_target::supports_multi_process): New
 963         declaration.
 964         * nbsd-nat.c (nbsd_nat_target::supports_multi_process): New
 965         function.
 966
 967 2020-07-20  John Baldwin  <jhb@FreeBSD.org>
 968
 969         * fbsd-tdep.c (fbsd_skip_solib_resolver): New function.
 970         (fbsd_init_abi): Install gdbarch "skip_solib_resolver" method.
 971         * fbsd-tdep.h (fbsd_skip_solib_resolver): New prototype.
 972         * mips-fbsd-tdep.c (mips_fbsd_skip_solib_resolver): New function.
 973         (mips_fbsd_init_abi): Install gdbarch "skip_solib_resolver"
 974         method.
 975
 976 2020-07-20 Ludovic Courtès  <ludo@gnu.org>
 977
 978         * guile/scm-math.c (vlscm_integer_fits_p): Use 'uintmax_t'
 979         and 'intmax_t' instead of 'scm_t_uintmax' and 'scm_t_intmax',
 980         which are deprecated in Guile 3.0.
 981         * configure.ac (try_guile_versions): Add "guile-3.0".
 982         * configure (try_guile_versions): Regenerate.
 983         * NEWS: Update entry.
 984
 985 2020-07-20  Ludovic Courtès  <ludo@gnu.org>
 986             Doug Evans  <dje@google.com>
 987
 988         PR gdb/21104
 989         * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro.
 990         (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if
 991         USING_GUILE_BEFORE_2_2.
 992         (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]:
 993         Change type to 'scm_t_port_type *'.
 994         (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable.
 995         (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream'
 996         parameter and honor it.  Update callers.
 997         (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function.
 998         (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New
 999         functions.
1000         (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if
1001         USING_GUILE_BEFORE_2_2.
1002         (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use
1003         'ioscm_read_from_port'.  Call 'scm_set_port_read_wait_fd'.
1004         (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function.
1005         (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP'
1006         and 'SCM_PORT_TYPE'.
1007         (gdbscm_memory_port_end_input, gdbscm_memory_port_seek)
1008         (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2.
1009         (gdbscm_memory_port_read, gdbscm_memory_port_write)
1010         (gdbscm_memory_port_seek, gdbscm_memory_port_close)
1011         [!USING_GUILE_BEFORE_2_2]: New functions.
1012         (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'.
1013         (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use
1014         'gdbscm_memory_port_read'.
1015         Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and
1016         'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2.
1017         (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New
1018         function.
1019         (ioscm_init_memory_port): Remove.
1020         (ioscm_init_memory_port_stream): New function
1021         (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New
1022         function.
1023         (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]:
1024         Return scm_from_uint (0).
1025         (gdbscm_set_memory_port_read_buffer_size_x)
1026         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
1027         (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]:
1028         Return scm_from_uint (0).
1029         (gdbscm_set_memory_port_write_buffer_size_x)
1030         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
1031         * configure.ac (try_guile_versions): Add "guile-2.2".
1032         * configure: Regenerate.
1033         * NEWS: Add entry.
1034
1035 2020-07-18  Tom Tromey  <tom@tromey.com>
1036
1037         * linux-nat.c (linux_multi_process): Remove.
1038         (linux_nat_target::supports_multi_process): Return true.
1039
1040 2020-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * arch/riscv.c (riscv_tdesc_cache): Change map type.
1043         (riscv_lookup_target_description): Return pointer out of
1044         unique_ptr.
1045         * target-descriptions.c (allocate_target_description): Add
1046         comment.
1047         (target_desc_deleter::operator()): Likewise.
1048         * target-descriptions.h (struct target_desc_deleter): Moved to
1049         gdbsupport/tdesc.h.
1050         (target_desc_up): Likewise.
1051
1052 2020-07-17  Tom Tromey  <tromey@adacore.com>
1053
1054         * linux-nat.c (linux_nat_target::supports_non_stop)
1055         (linux_nat_target::always_non_stop_p): Use "true".
1056         (linux_nat_target::supports_disable_randomization): Use "true" and
1057         "false".
1058
1059 2020-07-16  Caroline Tice  <cmtice@google.com>
1060
1061         * dwarf2/read.c (RNGLIST_HEADER_SIZE32) New constant definition.
1062         (RNGLIST_HEADER_SIZE64): New constant definition.
1063         (struct dwop_section_names): Add rnglists_dwo.
1064         (dwop_section_names): Add .debug_rnglists.dwo, .zdebug_rnglists.dwo.
1065         (struct loclist_header): Rename to 'loclists_rnglists_header'.
1066         (struct dwo_sections): Add rnglists field.
1067         (read_attribut_reprocess): Add tag parameter.
1068         (dwarf2_ranges_read): Add tag parameter & remove forward function decl.
1069         (cu_debug_rnglists_section): New function (decl & definition).
1070         (dwarf2_locate_dwo_sections): Add code to read rnglists_dwo section.
1071         (dwarf2_rnglists_process): Add a dwarf_tag parameter, for the kind of
1072         die whose range is being checked; get rnglist section from
1073         cu_debug_rnglists_section, to get from either objfile or dwo file as
1074         appropriate.  Add cases for DW_RLE_base_addressx,
1075         DW_RLE_startx_length, DW_RLE_startx_endx.  Also, update to only add
1076         the base address to DW_RLE_offset_pairs (not to all ranges), moving
1077         test inside if-condition and updating complaint message.
1078         (dwarf2_ranges_process): Add dwarf tag parameter and pass it to
1079         dwarf2_rnglists_process.
1080         (dwarf2_ranges_read): Add dwarf tag parameter and pass it to
1081         dwarf2_ranges_process.
1082         (dwarf2_get_pc_bounds): Check for DW_FORM_rnglistx when setting
1083         need_ranges_base and update comment appropriately.  Also pass die tag
1084         to dwarf2_ranges_read.
1085         (dwarf2_record_block_ranges): Check for DW_FORM_rnglistx when setting
1086         need_ranges_base and update comment appropriately.  Also pass die tag
1087         to dwarf2_ranges_process.
1088         (read_full_die_1): Add code to read DW_AT_rnglists_base and assign to
1089         cu->ranges_base.  Also pass die tag to read_attribute_reprocess.
1090         (partial_die_info::read): Check for DW_FORM_rnglistx when setting
1091         need_ranges_base and update comment appropriately.  Also pass die tag
1092         to read_attribute_reprocess and dwarf2_ranges_read.
1093         (read_loclist_header): Rename function to read_loclists_rnglists_header,
1094         and update function comment appropriately.
1095         (read_loclist_index): Call read_loclists_rnglists_header instead of
1096         read_loclist_header.
1097         (read_rnglist_index): New function.
1098         (read_attribute_reprocess):  Add tag parameter. Add code for
1099         DW_FORM_rnglistx, passing tag to read_rnglist_index.
1100         (read_attribute_value): Mark DW_FORM_rnglistx with need_reprocess.
1101
1102 2020-07-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * f-typeprint.c (f_type_print_base): Allow for dynamic types not
1105         being resolved.
1106
1107 2020-07-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * arch-utils.c (show_architecture): Update formatting of messages.
1110
1111 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1112
1113         * gdbtypes.h (struct type) <bounds>: Handle array and string
1114         types.
1115         * ada-lang.c (assign_aggregate): Use type::bounds on
1116         array/string type.
1117         * c-typeprint.c (c_type_print_varspec_suffix): Likewise.
1118         * c-varobj.c (c_number_of_children): Likewise.
1119         (c_describe_child): Likewise.
1120         * eval.c (evaluate_subexp_for_sizeof): Likewise.
1121         * f-typeprint.c (f_type_print_varspec_suffix): Likewise.
1122         (f_type_print_base): Likewise.
1123         * f-valprint.c (f77_array_offset_tbl): Likewise.
1124         (f77_get_upperbound): Likewise.
1125         (f77_print_array_1): Likewise.
1126         * guile/scm-type.c (gdbscm_type_range): Likewise.
1127         * m2-typeprint.c (m2_array): Likewise.
1128         (m2_is_long_set_of_type): Likewise.
1129         * m2-valprint.c (get_long_set_bounds): Likewise.
1130         * p-typeprint.c (pascal_type_print_varspec_prefix): Likewise.
1131         * python/py-type.c (typy_range): Likewise.
1132         * rust-lang.c (rust_internal_print_type): Likewise.
1133         * type-stack.c (type_stack::follow_types): Likewise.
1134         * valarith.c (value_subscripted_rvalue): Likewise.
1135         * valops.c (value_cast): Likewise.
1136
1137 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1138
1139         * gdbtypes.c (TYPE_ARRAY_BIT_STRIDE): Remove.  Update all
1140         callers to use the equivalent accessor methods.
1141
1142 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1143
1144         * gdbtypes.h (struct range_bounds) <bit_stride>: New method.
1145         (struct type) <bit_stride>: New method.
1146         (TYPE_BIT_STRIDE): Remove.
1147         * gdbtypes.c (update_static_array_size): Use type::bit_stride.
1148
1149 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1150
1151         * gdbtypes.h (TYPE_ARRAY_LOWER_BOUND_VALUE,
1152         TYPE_ARRAY_UPPER_BOUND_VALUE): Remove.  Update all
1153         callers to use the equivalent accessor methods instead.
1154
1155 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1156
1157         * gdbtypes.h (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED,
1158         TYPE_ARRAY_LOWER_BOUND_IS_UNDEFINED): Remove.  Update all
1159         callers to use the equivalent accessor methods instead.
1160
1161 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1162
1163         * gdbtypes.h (TYPE_LOW_BOUND_KIND,
1164         TYPE_HIGH_BOUND_KIND): Remove.  Update all callers
1165         to use dynamic_prop::kind.
1166
1167 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1168
1169         * gdbtypes.h (TYPE_LOW_BOUND_UNDEFINED,
1170         TYPE_HIGH_BOUND_UNDEFINED): Remove.  Update all callers
1171         to get the bound property's kind and check against
1172         PROP_UNDEFINED.
1173
1174 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1175
1176         * gdbtypes.h (TYPE_LOW_BOUND, TYPE_HIGH_BOUND): Remove.  Update
1177         all callers to use type::range_bounds followed by
1178         dynamic_prop::{low,high}.
1179
1180 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
1181
1182         * gdbtypes.h (struct dynamic_prop) <kind, set_undefined,
1183         const_val, set_const_val, baton, set_locexpr, set_loclist,
1184         set_addr_offset, variant_parts, set_variant_parts,
1185         original_type, set_original_type>: New methods.
1186         <kind>: Rename to...
1187         <m_kind>: ... this.  Update all users to use the new methods
1188         instead.
1189         <data>: Rename to...
1190         <m_data>: ... this.  Update all users to use the new methods
1191         instead.
1192
1193 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1194
1195         * gdbtypes.c (get_discrete_bounds): Return failure if
1196         the range type's bounds are not both defined and constant
1197         values.
1198         (get_array_bounds): Update comment.  Remove undefined bound check.
1199
1200 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
1201
1202         * gdbtypes.h (TYPE_RANGE_DATA): Remove.  Update callers to use
1203         the type::bounds method directly.
1204
1205 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1206
1207         * gdbtypes.h (struct type) <bounds, set_bounds>: New methods.
1208         (TYPE_RANGE_DATA): Use type::bounds.  Change all uses that
1209         are used to set the range type's bounds to use set_bounds.
1210
1211 2020-07-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1212
1213         * exec.c (_initialize_exec): Update exec-file-mismatch help.
1214
1215 2020-07-10  Pedro Alves  <pedro@palves.net>
1216
1217         * gdbthread.h (inferior_ref): Define.
1218         (scoped_restore_current_thread) <m_thread>: Now a thread_info_ref.
1219         (scoped_restore_current_thread) <m_inf>: Now an inferior_ref.
1220         * thread.c
1221         (scoped_restore_current_thread::restore):
1222         Adjust to gdb::ref_ptr.
1223         (scoped_restore_current_thread::~scoped_restore_current_thread):
1224         Remove manual decref handling.
1225         (scoped_restore_current_thread::scoped_restore_current_thread):
1226         Adjust to use
1227         inferior_ref::new_reference/thread_info_ref::new_reference.
1228         Incref the thread before calling get_frame_id instead of after.
1229         Let TARGET_CLOSE_ERROR propagate.
1230
1231 2020-07-10  Pedro Alves  <pedro@palves.net>
1232
1233         * frame-tailcall.c (dwarf2_tailcall_sniffer_first): Only swallow
1234         NO_ENTRY_VALUE_ERROR / MEMORY_ERROR / OPTIMIZED_OUT_ERROR /
1235         NOT_AVAILABLE_ERROR.
1236         * value.c (value_optimized_out): Only swallow MEMORY_ERROR /
1237         OPTIMIZED_OUT_ERROR / NOT_AVAILABLE_ERROR.
1238
1239 2020-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1240             Pedro Alves  <pedro@palves.net>
1241
1242         PR gdb/26199
1243         * infrun.c (threads_are_resumed_pending_p): Delete.
1244         (do_target_wait): Remove threads_are_executing and
1245         threads_are_resumed_pending_p checks from the inferior_matches
1246         lambda.  Update comments.
1247
1248 2020-07-10  Pedro Alves  <pedro@palves.net>
1249
1250         PR gdb/26199
1251         * infrun.c (handle_no_resumed): Transfer terminal to inferior with
1252         executing threads.
1253
1254 2020-07-10  Pedro Alves  <pedro@palves.net>
1255
1256         PR gdb/26199
1257         * infrun.c (handle_no_resumed): Handle multiple targets.
1258
1259 2020-07-10  Pedro Alves  <pedro@palves.net>
1260
1261         PR gdb/26199
1262         * infrun.c (prepare_to_wait): Check target_can_async_p instead of
1263         target_is_async_p.
1264
1265 2020-07-10  Pedro Alves  <pedro@palves.net>
1266
1267         PR gdb/26199
1268         * target.c (target_pass_ctrlc): Look at the inferior's non-exited
1269         threads, not all threads.
1270
1271 2020-07-10  Pedro Alves  <pedro@palves.net>
1272
1273         PR gdb/26199
1274         * remote.c (remote_target::open_1): Pass remote target pointer as
1275         data to create_async_event_handler.
1276         (remote_async_inferior_event_handler): Mark async event handler
1277         before returning if the remote target still has either pending
1278         events or unacknowledged notifications.
1279
1280 2020-07-10  John Baldwin  <jhb@FreeBSD.org>
1281
1282         * fbsd-nat.h (fbsd_nat_target::supports_multi_process): New
1283         declaration.
1284         * fbsd-nat.c (fbsd_nat_target::supports_multi_process): New
1285         function.
1286
1287 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
1288
1289         * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
1290         inferior_ptid.
1291
1292 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
1293
1294         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_ARGC,
1295         AT_FREEBSD_ARGV, AT_FREEBSD_ENVC, AT_FREEBSD_ENVV,
1296         AT_FREEBSD_PS_STRINGS.
1297
1298 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
1299
1300         * auto-load.c (auto_load_objfile_script_1): Convert drive part
1301         of debugfile path on Windows.
1302
1303 2020-07-08  John Baldwin  <jhb@FreeBSD.org>
1304
1305         * fbsd-nat.c (fbsd_nat_target::find_memory_regions): Rename 'obfd'
1306         argument to 'data'.
1307
1308 2020-07-08  Tom Tromey  <tromey@adacore.com>
1309
1310         * ada-lang.c (ada_exception_message_1): Use read_memory.
1311
1312 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         PR python/22748
1315         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Remove
1316         special handling for inline frames.
1317         * findvar.c (value_of_register_lazy): Skip inline frames when
1318         creating lazy register values.
1319         * frame.c (frame_id_computed_p): Delete definition.
1320         * frame.h (frame_id_computed_p): Delete declaration.
1321
1322 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * NEWS: Mention additions to Python API.
1325         * python/py-arch.c (archpy_register_groups): New function.
1326         (arch_object_methods): Add 'register_groups' method.
1327         * python/py-registers.c (reggroup_iterator_object): New struct.
1328         (reggroup_object): New struct.
1329         (gdbpy_new_reggroup): New function.
1330         (gdbpy_reggroup_to_string): New function.
1331         (gdbpy_reggroup_name): New function.
1332         (gdbpy_reggroup_iter): New function.
1333         (gdbpy_reggroup_iter_next): New function.
1334         (gdbpy_new_reggroup_iterator): New function
1335         (gdbpy_initialize_registers): Register new types.
1336         (reggroup_iterator_object_type): Define new Python type.
1337         (gdbpy_reggroup_getset): New static global.
1338         (reggroup_object_type): Define new Python type.
1339         * python/python-internal.h
1340
1341 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1342
1343         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-registers.c
1344         * python/py-arch.c (archpy_registers): New function.
1345         (arch_object_methods): Add 'registers' method.
1346         * python/py-registers.c: New file.
1347         * python/python-internal.h
1348         (gdbpy_new_register_descriptor_iterator): Declare.
1349         (gdbpy_initialize_registers): Declare.
1350         * python/python.c (do_start_initialization): Call
1351         gdbpy_initialize_registers.
1352         * NEWS: Mention additions to the Python API.
1353
1354 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * NEWS: Mention new Python API method.
1357         * python/py-unwind.c (pending_framepy_architecture): New function.
1358         (pending_frame_object_methods): Add architecture method.
1359
1360 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * gdbarch.c: Regenerate.
1363         * gdbarch.h: Regenerate.
1364         * gdbarch.sh (deprecated_set_gdbarch_data): Delete.
1365         (gdbarch_data): Use internal_error for the case where
1366         deprecated_set_gdbarch_data was originally needed.
1367         * ia64-libunwind-tdep.c (libunwind_descr_init): Update parameters,
1368         and use passed in obstack.
1369         (libunwind_frame_set_descr): Should no longer get back NULL from
1370         gdbarch_data.
1371         (_initialize_libunwind_frame): Register as a pre-init gdbarch data
1372         type.
1373         * user-regs.c (user_regs_init): Update parameters, and use passed
1374         in obstack.
1375         (user_reg_add): Should no longer get back NULL from gdbarch_data.
1376         (_initialize_user_regs): Register as a pre-init gdbarch data type.
1377
1378 2020-07-06  Tom de Vries  <tdevries@suse.de>
1379
1380         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Handle
1381         End-Of-Sequence in lte_is_less_than.
1382         * symtab.c (find_pc_sect_line): Revert change from commit 3d92a3e313
1383         "gdb: Don't reorder line table entries too much when sorting".
1384
1385 2020-07-06  Tom de Vries  <tdevries@suse.de>
1386
1387         PR tui/26205
1388         * tui/tui-win.c (tui_partial_win_by_name): Don't test for NULL name.
1389
1390 2020-07-05  Tom de Vries  <tdevries@suse.de>
1391
1392         PR build/26187
1393         * inferior.h (struct infcall_suspend_state_deleter): If available, use
1394         std::uncaught_exceptions instead of deprecated
1395         std::uncaught_exception.
1396
1397 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1398
1399         * macroexp.h (macro_stringify): Return
1400         gdb::unique_xmalloc_ptr<char>.
1401         * macroexp.c (macro_stringify): Likewise.
1402         * macrotab.c (fixup_definition): Update.
1403
1404 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1405
1406         * c-exp.y (scan_macro_expansion): Don't free `expansion`.
1407         (lex_one_token): Update.
1408         * macroexp.c (struct macro_buffer) <release>: Return
1409         gdb::unique_xmalloc_ptr<char>.
1410         (macro_stringify): Update.
1411         (macro_expand): Update.
1412         (macro_expand_next): Return gdb::unique_xmalloc_ptr<char>.
1413         * macroexp.h (macro_expand_next): Likewise.
1414
1415 2020-07-02  Simon Marchi  <simon.marchi@efficios.com>
1416
1417         * macroexp.h (macro_lookup_ftype): Remove.
1418         (macro_expand, macro_expand_once, macro_expand_next): Remove
1419         lookup function parameters, add scope parameter.
1420         * macroexp.c (scan, substitute_args, expand, maybe_expand,
1421         macro_expand, macro_expand_once, macro_expand_next): Likewise.
1422         * macroscope.h (standard_macro_lookup): Change parameter type
1423         to macro_scope.
1424         * macroscope.c (standard_macro_lookup): Likewise.
1425         * c-exp.y (lex_one_token): Update.
1426         * macrocmd.c (macro_expand_command): Likewise.
1427         (macro_expand_once_command): Likewise.
1428
1429 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1430
1431         * inf-loop.c (inferior_event_handler): Remove client_data param.
1432         * inf-loop.h (inferior_event_handler): Likewise.
1433         * infcmd.c (step_1): Adjust.
1434         * infrun.c (proceed): Adjust.
1435         (fetch_inferior_event): Remove client_data param.
1436         (infrun_async_inferior_event_handler): Adjust.
1437         * infrun.h (fetch_inferior_event): Remove `void *` param.
1438         * linux-nat.c (handle_target_event): Adjust.
1439         * record-btrace.c (record_btrace_handle_async_inferior_event):
1440         Adjust.
1441         * record-full.c (record_full_async_inferior_event_handler):
1442         Adjust.
1443         * remote.c (remote_async_inferior_event_handler): Adjust.
1444
1445 2020-07-01  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-data.h (struct tui_win_info) <name>: Now pure virtual.
1448         * tui/tui-stack.h (struct tui_locator_window) <name>: New method.
1449
1450 2020-07-01  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-wingeneral.c (tui_win_info::refresh_window): Move from
1453         tui_gen_win_info.
1454         (tui_win_info::make_window): Merge with
1455         tui_gen_win_info::make_window.
1456         (tui_win_info::make_visible): Move from tui_gen_win_info.
1457         * tui/tui-win.c (tui_win_info::max_width): Move from
1458         tui_gen_win_info.
1459         * tui/tui-layout.h (class tui_layout_window) <m_window>: Change
1460         type.
1461         <window_factory>: Likewise.
1462         * tui/tui-layout.c (tui_win_info::resize): Move from
1463         tui_gen_win_info.
1464         (make_standard_window): Change return type.
1465         (get_locator_window, tui_get_window_by_name): Likewise.
1466         (tui_layout_window::apply): Remove a cast.
1467         * tui/tui-data.h (MIN_WIN_HEIGHT): Move earlier.
1468         (struct tui_win_info): Merge with tui_gen_win_info.
1469         (struct tui_gen_win_info): Remove.
1470
1471 2020-07-01  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-stack.h (struct tui_locator_window): Derive from
1474         tui_win_info.
1475         <do_scroll_horizontal, do_scroll_vertical>: New methods.
1476         <can_box>: New method.
1477
1478 2020-07-01  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-stack.h (struct tui_locator_window): Remove body.
1481
1482 2020-07-01  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-regs.c (tui_data_window::display_registers_from)
1485         (tui_data_window::display_registers_from)
1486         (tui_data_window::first_data_item_displayed)
1487         (tui_data_window::delete_data_content_windows): Update.
1488         (tui_data_window::refresh_window, tui_data_window::no_refresh):
1489         Remove.
1490         (tui_data_window::check_register_values): Update.
1491         (tui_data_item_window::rerender): Add parameters.  Update.
1492         (tui_data_item_window::refresh_window): Remove.
1493         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: No longer
1494         virtual.
1495         * tui/tui-regs.h (struct tui_data_item_window): Don't derive from
1496         tui_gen_win_info.
1497         <refresh_window, max_height, min_height>: Remove.
1498         <rerender>: Add parameters.
1499         <x, y, visible>: New members.
1500         (struct tui_data_window) <refresh_window, no_refresh>: Remove.
1501         <m_item_width>: New member.
1502
1503 2020-07-01  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-regs.c (tui_data_window::show_register_group)
1506         (tui_data_window::check_register_values): Update.
1507         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
1508         from item_no.
1509
1510 2020-07-01  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
1513         useless "if".
1514
1515 2020-07-01  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1518         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
1519
1520 2020-07-01  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
1523         * tui/tui-winsource.h (enum tui_line_or_address_kind)
1524         (struct tui_line_or_address): Move from tui-data.h.
1525         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
1526         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
1527         (tui_cmd_window, tui_source_window_base, tui_source_window)
1528         (tui_disasm_window): Don't declare.
1529         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
1530         to tui-winsource.h.
1531         (SINGLE_KEY): Move to tui-stack.c.
1532
1533 2020-07-01  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
1536         std::string.
1537         * tui/tui-regs.c (class tab_expansion_file): New.
1538         (tab_expansion_file::write): New method.
1539         (tui_register_format): Change return type.  Use
1540         tab_expansion_file.
1541         (tui_get_register, tui_data_window::display_registers_from)
1542         (tui_data_item_window::rerender): Update.
1543         * tui/tui-io.h (tui_expand_tabs): Don't declare.
1544         * tui/tui-io.c (tui_expand_tabs): Remove.
1545
1546 2020-07-01  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
1549
1550 2020-07-01  Fangrui Song  <maskray@google.com>
1551
1552         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
1553
1554 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1555
1556         * dwarf2/read.c (set_die_type): Removed conditions to restrict
1557         forms for DW_AT_associated and DW_AT_allocated attributes,
1558         which is already checked in function attr_to_dynamic_prop.
1559
1560 2020-06-30  Tom Tromey  <tromey@adacore.com>
1561
1562         * dwarf2/read.c (quirk_rust_enum): Correctly call
1563         alloc_rust_variant for default-less enum.
1564
1565 2020-06-30  Tom Tromey  <tromey@adacore.com>
1566
1567         PR build/26183:
1568         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
1569         gdb::to_string.
1570
1571 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
1572
1573         * gdbarch.sh (displaced_step_copy_insn): Update doc.
1574         * gdbarch.h: Re-generate.
1575
1576 2020-06-28  Tom Tromey  <tom@tromey.com>
1577
1578         * command.h (cmd_types): Remove.
1579         (cmd_type): Don't declare.
1580         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
1581         typedef.
1582         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
1583         * cli/cli-decode.c (cmd_type): Remove.
1584
1585 2020-06-27  Pedro Alves  <palves@redhat.com>
1586
1587         * fork-child.c (prefork_hook): Adjust.
1588         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
1589         Delete.
1590         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
1591         * inferior.c (inferior::set_tty, inferior::tty): New methods.
1592         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
1593         Remove declarations.
1594         (struct inferior) <set_tty, tty>: New methods.
1595         (struct inferior) <terminal>: Rename to ...
1596         (struct inferior) <m_terminal>: ... this and make private.
1597         * main.c (captured_main_1): Adjust.
1598         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
1599         (mi_cmd_inferior_tty_show): Adjust.
1600         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
1601         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
1602
1603 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
1604
1605         * configure.ac: Add --enable-libctf: handle --disable-static
1606         properly.
1607         * acinclude.m4: sinclude ../config/enable.m4.
1608         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
1609         (LIBCTF): Substitute in.
1610         (CTF_DEPS): New, likewise.
1611         (CLIBS): libctf needs symbols from libbfd: move earlier.
1612         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
1613         flags.
1614         * ctfread.c: Surround in ENABLE_LIBCTF.
1615         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
1616         * configure: Regenerate.
1617         * config.in: Likewise.
1618
1619 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1620
1621         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
1622
1623 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1624
1625         * inferior.h (struct inferior) <terminal>: Change type to
1626         gdb::unique_xmalloc_ptr<char>.
1627         * inferior.c (inferior::~inferior): Don't free inf->terminal.
1628         * infcmd.c (set_inferior_io_terminal): Don't free terminal
1629         field, adjust to unique pointer.
1630         (get_inferior_io_terminal): Adjust to unique pointer.
1631
1632 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1633
1634         * riscv-tdep.c (riscv_print_registers_info): Loop over all
1635         registers, not just the known core set of registers.
1636
1637 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1638
1639         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
1640         fflags, frm, and fcsr registers.
1641         (riscv_register_reggroup_p): Remove unknown CSRs from save and
1642         restore groups.
1643         (riscv_tdesc_unknown_reg): New function.
1644         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
1645         tdesc_use_registers.
1646         * riscv-tdep.h (struct gdbarch_tdep): Add
1647         unknown_csrs_first_regnum, unknown_csrs_count,
1648         duplicate_fflags_regnum, duplicate_frm_regnum, and
1649         duplicate_fcsr_regnum fields.
1650
1651 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * target-descriptions.c (tdesc_use_registers): Add new parameter a
1654         callback, use the callback (when not null) to help number unknown
1655         registers.
1656         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
1657         (tdesc_use_registers): Add extra parameter to declaration.
1658
1659 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
1662         in the file.
1663         (class riscv_pending_register_alias): Likewise.
1664         (riscv_register_feature::register_info): Change 'required_p' field
1665         to 'required', and change its type.  Add 'check' member function.
1666         (riscv_register_feature::register_info::check): Define new member
1667         function.
1668         (riscv_xreg_feature): Change initialisation of 'required' field.
1669         (riscv_freg_feature): Likewise.
1670         (riscv_virtual_feature): Likewise.
1671         (riscv_csr_feature): Likewise.
1672         (riscv_check_tdesc_feature): Take extra parameter, the csr
1673         tdesc_feature, rewrite the function to use the new
1674         riscv_register_feature::register_info::check function.
1675         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
1676
1677 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * features/Makefile: Remove all references to the deleted files
1680         below.
1681         * features/riscv/32bit-csr.c: Deleted.
1682         * features/riscv/32bit-csr.xml: Deleted.
1683         * features/riscv/64bit-csr.c: Deleted.
1684         * features/riscv/64bit-csr.xml: Deleted.
1685         * features/riscv/rebuild-csr-xml.sh: Deleted.
1686
1687 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1688
1689         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
1690         whitespace error for declaration of names member variable.
1691         (struct riscv_register_feature): Add new prefer_first_name member
1692         variable, and fix whitespace error in declaration of registers.
1693         (riscv_xreg_feature): Initialize prefer_first_name field.
1694         (riscv_freg_feature): Likewise.
1695         (riscv_virtual_feature): Likewise.
1696         (riscv_csr_feature): Likewise.
1697         (riscv_register_name): Expand on comments.  Remove register name
1698         modifications for CSR and virtual registers.
1699
1700 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1701
1702         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
1703         errors.
1704
1705 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1706
1707         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
1708         riscv-opc.h.
1709         (class riscv_pending_register_alias): New class.
1710         (riscv_check_tdesc_feature): Take vector of pending aliases and
1711         populate it as appropriate.
1712         (riscv_setup_register_aliases): Delete.
1713         (riscv_gdbarch_init): Create vector of pending aliases and pass it
1714         to riscv_check_tdesc_feature in all cases.  Use the vector to
1715         create the register aliases.
1716
1717 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1718
1719         * sol2-tdep.c (sol2_static_transform_name): Remove.
1720         (sol2_init_abi): Don't register it.
1721         * gdbarch.sh (static_transform_name): Remove.
1722         * gdbarch.c, gdbarch.h: Regenerate.
1723
1724         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
1725         gdbarch_static_transform_name.
1726         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
1727         * stabsread.c (define_symbol) <'X'>: Remove.
1728         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
1729         handling.
1730         <'V'>: Likewise.
1731         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
1732         <'S'>: Remove call to gdbarch_static_transform_name.
1733
1734 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1735
1736         * procfs.c (procfs_pre_trace): New function.
1737         (procfs_target::create_inferior): Pass it to fork_inferior.
1738
1739 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1740
1741         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
1742         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
1743         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
1744         sol2-tdep.o, sparc-sol2-tdep.o.
1745         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
1746         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
1747         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
1748         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
1749
1750 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1751
1752         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
1753         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
1754         Call sol2_init_abi.
1755         Remove calls to set_gdbarch_skip_solib_resolver,
1756         set_gdbarch_core_pid_to_str.
1757         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
1758         (i386_sol2_static_transform_name): Remove.
1759         (i386_sol2_init_abi): Call sol2_init_abi.
1760         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1761         set_gdbarch_static_transform_name,
1762         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1763         Use sol2_sigtramp_p.
1764         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
1765         (sol2_sigtramp_p): New function.
1766         (sol2_static_transform_name): New function.
1767         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
1768         (sol2_init_abi): New function.
1769         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
1770         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
1771         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
1772         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
1773         (sparc_sol2_static_transform_name): Remove.
1774         (sparc32_sol2_init_abi): Call sol2_init_abi.
1775         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1776         set_gdbarch_static_transform_name,
1777         set_gdbarch_skip_solib_resolver,
1778         set_gdbarch_core_pid_to_str.
1779         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
1780         (sparc_sol2_static_transform_name): Remove
1781         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
1782         call sol2_sigtramp_p.
1783         (sparc64_sol2_init_abi): Call sol2_init_abi.
1784         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1785         set_gdbarch_static_transform_name,
1786         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1787
1788 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1789
1790         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
1791         * exec.c (validate_exec_file): If from_tty, set both
1792         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
1793         * symfile.c (symbol_file_add_with_addrs): if always_confirm
1794         and from_tty, unconditionally ask a confirmation.
1795
1796 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1797
1798         * target-descriptions.c (tdesc_architecture_name): Protect against
1799         NULL pointer dereference.
1800         (maint_print_xml_tdesc_cmd): New function.
1801         (_initialize_target_descriptions): Register new 'maint print
1802         xml-tdesc' command and give it the filename completer.
1803         * NEWS: Mention new 'maint print xml-tdesc' command.
1804
1805 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1806
1807         * target-descriptions.c (class tdesc_compatible_info): New class.
1808         (struct target_desc): Change type of compatible vector.
1809         (tdesc_compatible_p): Update for change in type of
1810         target_desc::compatible.
1811         (tdesc_compatible_info_list): New function.
1812         (tdesc_compatible_info_arch_name): New function.
1813         (tdesc_add_compatible): Update for change in type of
1814         target_desc::compatible.
1815         (print_c_tdesc::visit_pre): Likewise.
1816
1817 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
1820         whitespace to underscore.
1821         (maint_print_c_tdesc_cmd): Use fake filename for target
1822         descriptions that came from the target.
1823         (_initialize_target_descriptions): Add filename command completion
1824         for 'maint print c-tdesc'.
1825
1826 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
1827
1828         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
1829         lines.
1830
1831 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
1832
1833         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
1834         lines.
1835         (dwarf2_find_location_expression): Likewise.
1836         (call_site_parameter_matches): Likewise.
1837         (dwarf2_compile_expr_to_ax): Likewise.
1838         (disassemble_dwarf_expression): Likewise.
1839         (loclist_describe_location): Likewise.
1840
1841 2020-06-23  Pedro Alves  <palves@redhat.com>
1842
1843         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
1844         progspace-and-thread.h.  Include scoped-mock-context.h instead.
1845         (register_to_value_test): Use scoped_mock_context.
1846         * regcache.c: Include "scoped-mock-context.h".
1847         (cooked_read_test): Don't error out if a target is already pushed.
1848         Use scoped_mock_context.  Adjust.
1849         * scoped-mock-context.h: New file.
1850
1851 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
1854         initializer.
1855         (ada_language::is_string_type_p): New member function.
1856         * c-lang.c (c_language_data): Delete la_is_string_type_p
1857         initializer.
1858         (cplus_language_data): Likewise.
1859         (asm_language_data): Likewise.
1860         (minimal_language_data): Likewise.
1861         * d-lang.c (d_language_data): Likewise.
1862         * f-lang.c (f_is_string_type_p): Delete function, implementation
1863         moved to f_language::is_string_type_p.
1864         (f_language_data): Delete la_is_string_type_p initializer.
1865         (f_language::is_string_type_p): New member function,
1866         implementation from f_is_string_type_p.
1867         * go-lang.c (go_is_string_type_p): Delete function, implementation
1868         moved to go_language::is_string_type_p.
1869         (go_language_data): Delete la_is_string_type_p initializer.
1870         (go_language::is_string_type_p): New member function,
1871         implementation from go_is_string_type_p.
1872         * language.c (language_defn::is_string_type_p): Define new member
1873         function.
1874         (default_is_string_type_p): Make static, add comment copied from
1875         header file.
1876         (unknown_language_data): Delete la_is_string_type_p initializer.
1877         (unknown_language::is_string_type_p): New member function.
1878         (auto_language_data): Delete la_is_string_type_p initializer.
1879         (auto_language::is_string_type_p): New member function.
1880         * language.h (language_data): Delete la_is_string_type_p field.
1881         (language_defn::is_string_type_p): Declare new function.
1882         (default_is_string_type_p): Delete desclaration, move comment to
1883         definition.
1884         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
1885         moved to m2_language::is_string_type_p.
1886         (m2_language_data): Delete la_is_string_type_p initializer.
1887         (m2_language::is_string_type_p): New member function,
1888         implementation from m2_is_string_type_p.
1889         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
1890         initializer.
1891         * opencl-lang.c (opencl_language_data): Likewise.
1892         * p-lang.c (pascal_is_string_type_p): Delete function,
1893         implementation moved to pascal_language::is_string_type_p.
1894         (pascal_language_data): Delete la_is_string_type_p initializer.
1895         (pascal_language::is_string_type_p): New member function,
1896         implementation from pascal_is_string_type_p.
1897         * rust-lang.c (rust_is_string_type_p): Delete function,
1898         implementation moved to rust_language::is_string_type_p.
1899         (rust_language_data): Delete la_is_string_type_p initializer.
1900         (rust_language::is_string_type_p): New member function,
1901         implementation from rust_is_string_type_p.
1902         * valprint.c (val_print_scalar_or_string_type_p): Update call to
1903         is_string_type_p.
1904
1905 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * ada-lang.c (ada_language_data): Delete la_print_typedef
1908         initializer.
1909         (ada_language::print_typedef): New member function.
1910         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
1911         (cplus_language_data): Likewise.
1912         (asm_language_data): Likewise.
1913         (minimal_language_data): Likewise.
1914         * d-lang.c (d_language_data): Likewise.
1915         * f-lang.c (f_language_data): Likewise.
1916         (f_language::print_typedef): New member function.
1917         * go-lang.c (go_language_data): Delete la_print_typedef
1918         initializer.
1919         * language.c (language_defn::print_typedef): Define member
1920         function.
1921         (unknown_language_data): Delete la_print_typedef initializer.
1922         (unknown_language::print_typedef): New member function.
1923         (auto_language_data): Delete la_print_typedef initializer.
1924         (auto_language::print_typedef): New member function.
1925         * language.h (language_data): Delete la_print_typedef field.
1926         (language_defn::print_typedef): Declare new member function.
1927         (LA_PRINT_TYPEDEF): Update call to print_typedef.
1928         (default_print_typedef): Delete declaration.
1929         * m2-lang.c (m2_language_data): Delete la_print_typedef
1930         initializer.
1931         (m2_language::print_typedef): New member function.
1932         * objc-lang.c (objc_language_data): Delete la_print_typedef
1933         initializer.
1934         * opencl-lang.c (opencl_language_data): Likewise.
1935         * p-lang.c (pascal_language_data): Likewise.
1936         (pascal_language::print_typedef): New member function.
1937         * rust-lang.c (rust_print_typedef): Delete function,
1938         implementation moved to rust_language::print_typedef.
1939         (rust_language): Delete la_print_typedef initializer.
1940         (rust_language::print_typedef): New member function,
1941         implementation from rust_print_typedef.
1942         * typeprint.c (default_print_typedef): Delete.
1943
1944 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
1947         (ada_language::printstr): New member function.
1948         * c-lang.c (c_language_data): Delete la_printstr initializer.
1949         (cplus_language_data): Likewise.
1950         (asm_language_data): Likewise.
1951         (minimal_language_data): Likewise.
1952         * d-lang.c (d_language_data): Likewise.
1953         * f-lang.c (f_printstr): Rename to f_language::printstr.
1954         (f_language_data): Delete la_printstr initializer.
1955         (f_language::printstr): New member function, implementation from
1956         f_printstr.
1957         * go-lang.c (go_language_data): Delete la_printstr initializer.
1958         * language.c (language_defn::printstr): Define new member
1959         function.
1960         (unk_lang_printstr): Delete.
1961         (unknown_language_data): Delete la_printstr initializer.
1962         (unknown_language::printstr): New member function.
1963         (auto_language_data): Delete la_printstr initializer.
1964         (auto_language::printstr): New member function.
1965         * language.h (language_data): Delete la_printstr field.
1966         (language_defn::printstr): Declare new member function.
1967         (LA_PRINT_STRING): Update call to printstr.
1968         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
1969         (m2_language_data): Delete la_printstr initializer.
1970         (m2_language::printstr): New member function, implementation from
1971         m2_printstr.
1972         * objc-lang.c (objc_language_data): Delete la_printstr
1973         initializer.
1974         * opencl-lang.c (opencl_language_data): Likewise.
1975         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
1976         (pascal_language_data): Delete la_printstr initializer.
1977         (pascal_language::printstr): New member function, implementation
1978         from pascal_printstr.
1979         * p-lang.h (pascal_printstr): Delete declaration.
1980         * rust-lang.c (rust_printstr): Update header comment.
1981         (rust_language_data): Delete la_printstr initializer.
1982         (rust_language::printstr): New member function.
1983
1984 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1985
1986         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
1987         (ada_language::printchar): New member function.
1988         * c-lang.c (c_language_data): Delete la_printchar initializer.
1989         (cplus_language_data): Likewise.
1990         (asm_language_data): Likewise.
1991         (minimal_language_data): Likewise.
1992         * d-lang.c (d_language_data): Likewise.
1993         * f-lang.c (f_printchar): Rename to f_language::printchar.
1994         (f_language_data): Delete la_printchar initializer.
1995         (f_language::printchar): New member function, implementation from
1996         f_printchar.
1997         * go-lang.c (go_language_data): Delete la_printchar initializer.
1998         * language.c (unk_lang_printchar): Delete.
1999         (language_defn::printchar): Define new member function.
2000         (unknown_language_data): Delete la_printchar initializer.
2001         (unknown_language::printchar): New member function.
2002         (auto_language_data): Delete la_printchar initializer.
2003         (auto_language::printchar): New member function.
2004         * language.h (language_data): Delete la_printchar field.
2005         (language_defn::printchar): Declare new member function.
2006         (LA_PRINT_CHAR): Update call to printchar.
2007         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
2008         (m2_language::printchar): New member function.
2009         * objc-lang.c (objc_language_data): Delete la_printchar
2010         initializer.
2011         * opencl-lang.c (opencl_language_data): Likewise.
2012         * p-lang.c (pascal_language_data): Delete la_printchar
2013         initializer.
2014         (pascal_language::printchar): New member function.
2015         * rust-lang.c (rust_printchar): Rename to
2016         rust_language::printchar.
2017         (rust_language_data): Delete la_printchar initializer.
2018         (rust_language::printchar): New member function, implementation
2019         from rust_printchar.
2020
2021 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
2024         (ada_language_data): Delete la_emitchar initializer.
2025         (ada_language::emitchar): New member function, implementation from
2026         emit_char.
2027         * c-lang.c (c_language_data): Delete la_emitchar initializer.
2028         (cplus_language_data): Likewise.
2029         (asm_language_data): Likewise.
2030         (minimal_language_data): Likewise.
2031         * d-lang.c (d_language_data): Likewise.
2032         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
2033         (f_language_data): Delete la_emitchar initializer.
2034         (f_language::emitchar): New member function, implementation from
2035         f_emit_char.
2036         * go-lang.c (go_language_data): Delete la_emitchar initializer.
2037         * language.c (unk_lang_emit_char): Delete.
2038         (language_defn::emitchar): New member function definition.
2039         (unknown_language_data): Delete la_emitchar initializer.
2040         (unknown_language::emitchar): New member function.
2041         (auto_language_data): Delete la_emitchar initializer.
2042         (auto_language::emitchar): New member function.
2043         * language.h (language_data): Delete la_emitchar field.
2044         (language_defn::emitchar): New member field declaration.
2045         (LA_EMIT_CHAR): Update call to emitchar.
2046         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
2047         (m2_language_data): Delete la_emitchar initializer.
2048         (m2_language::emitchar): New member function, implementation from
2049         m2_emit_char.
2050         * objc-lang.c (objc_language_data): Delete la_emitchar
2051         initializer.
2052         * opencl-lang.c (opencl_language_data): Likewise.
2053         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
2054         (pascal_language_data): Delete la_emitchar initializer.
2055         (pascal_language::emitchar): New member function, implementation
2056         from pascal_emit_char.
2057         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
2058         (rust_language_data): Delete la_emitchar initializer.
2059         (rust_language::emitchar): New member function, implementation
2060         from rust_emitchar.
2061
2062 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * ada-lang.c (resolve): Rename to ada_language::post_parser.
2065         (ada_language_data): Delete la_post_parser initializer.
2066         (ada_language::post_parser): New member function.
2067         * c-lang.c (c_language_data): Delete la_post_parser initializer.
2068         (cplus_language_data): Likewise.
2069         (asm_language_data): Likewise.
2070         (minimal_language_data): Likewise.
2071         * d-lang.c (d_language_data): Likewise.
2072         * f-lang.c (f_language_data): Likewise.
2073         * go-lang.c (go_language_data): Likewise.
2074         * language.c (unknown_language_data): Likewise.
2075         (auto_language_data): Likewise.
2076         * language.h (language_data): Delete la_post_parser field.
2077         (language_defn::post_parser): New member function.
2078         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
2079         * objc-lang.c (objc_language_data): Likewise.
2080         * opencl-lang.c (opencl_language_data): Likewise.
2081         * p-lang.c (pascal_language_data): Likewise.
2082         * parse.c (parse_exp_in_context): Update call to post_parser.
2083         (null_post_parser): Delete definition.
2084         * parser-defs.h (null_post_parser): Delete declaration.
2085         * rust-lang.c (rust_language_data): Delete la_post_parser
2086         initializer.
2087
2088 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * ada-lang.c (parse): Rename to ada_language::parser.
2091         (ada_language_data): Delete la_parser initializer.
2092         (ada_language::parser): New member function, implementation from
2093         parse.
2094         * c-lang.c (c_language_data): Delete la_parser initializer.
2095         (cplus_language_data): Likewise.
2096         (asm_language_data): Likewise.
2097         (minimal_language_data): Likewise.
2098         * d-lang.c (d_language_data): Likewise.
2099         (d_language::parser): New member function.
2100         * f-lang.c (f_language_data): Delete la_parser initializer.
2101         (f_language::parser): New member function.
2102         * go-lang.c (go_language_data): Delete la_parser initializer.
2103         (go_language::parser): New member function.
2104         * language.c (unk_lang_parser): Delete.
2105         (language_defn::parser): Define new member function.
2106         (unknown_language_data): Delete la_parser initializer.
2107         (unknown_language::parser): New member function.
2108         (auto_language_data): Delete la_parser initializer.
2109         (auto_language::parser): New member function.
2110         * language.h (language_data): Delete la_parser field.
2111         (language_defn::parser): Declare new member function.
2112         * m2-lang.c (m2_language_data): Delete la_parser initializer.
2113         (m2_language::parser): New member function.
2114         * objc-lang.c (objc_language_data): Delete la_parser initializer.
2115         * opencl-lang.c (opencl_language_data): Likewise.
2116         * p-lang.c (pascal_language_data): Likewise.
2117         (pascal_language::parser): New member function.
2118         * parse.c (parse_exp_in_context): Update call to parser.
2119         * rust-lang.c (rust_language_data): Delete la_parser initializer.
2120         (rust_language::parser): New member function.
2121
2122 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * top.c (print_gdb_configuration): Print --with-python-libdir
2125         configuration value.
2126
2127 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2128
2129         * NEWS: Mention change to the alias command.
2130
2131 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2132
2133         * cli/cli-cmds.c (lookup_cmd_for_default_args)
2134         (alias_command_completer)
2135         (make_alias_options_def_group): New functions.
2136         (alias_opts, alias_option_defs): New struct and array.
2137         (alias_usage_error): Update usage.
2138         (alias_command): Handles optional DEFAULT-ARGS... arguments.
2139         Use option framework.
2140         (_initialize_cli_cmds): Update alias command help.
2141         Update aliases command help.
2142         (show_user):
2143         Add NULL for new default_args lookup_cmd argument.
2144         (valid_command_p): Rename to validate_aliased_command.
2145         Add NULL for new default_args lookup_cmd argument.  Verify that the
2146         aliased_command has no default args.
2147         * cli/cli-decode.c (help_cmd): Show aliases definitions.
2148         (lookup_cmd_1, lookup_cmd): New argument default_args.
2149         (add_alias_cmd):
2150         Add NULL for new default_args lookup_cmd argument.
2151         (print_help_for_command): Show default args under the layout
2152          alias some_alias = some_aliased_cmd some_alias_default_arg.
2153         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
2154         xfree default_args in destructor.
2155         * cli/cli-script.c (process_next_line, do_define_command):
2156         Add NULL for new default_args lookup_cmd argument.
2157         * command.h: Declare new default_args argument in lookup_cmd
2158         and lookup_cmd_1.
2159         * completer.c (complete_line_internal_1):
2160         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2161         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
2162         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
2163         Likewise.
2164         * infcmd.c (_initialize_infcmd): Likewise.
2165         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
2166         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
2167         * python/py-param.c (add_setshow_generic): Likewise.
2168         * remote.c (_initialize_remote): Likewise.
2169         * top.c (execute_command): Prepend default_args if command has some.
2170         (set_verbose):
2171         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2172         * tracepoint.c (validate_actionline, encode_actions_1):
2173         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2174
2175 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2176
2177         * jit.c (jit_read_descriptor): Use bool as the return type.
2178         (jit_breakpoint_re_set_internal): Use bool as the return type.
2179         Invert the return value logic; return true if the jit breakpoint
2180         has been successfully initialized.
2181         (jit_inferior_init): Update the call to
2182         jit_breakpoint_re_set_internal.
2183
2184 2020-06-22  Pedro Alves  <palves@redhat.com>
2185
2186         PR gdb/25939
2187         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
2188         Use the current inferior instead.  Don't return
2189         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
2190         wait again.
2191         * sol-thread.c (sol_thread_target::wait): Don't reference
2192         inferior_ptid.
2193         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
2194         (sol_update_thread_list_callback): Use the current inferior's pid
2195         instead of inferior_ptid.
2196
2197 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2198
2199         * procfs.c: Cleanup many comments.
2200
2201         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
2202         (AFTER_WATCHFLAG): Replace by value.
2203
2204         (MAIN_PROC_NAME_FORMAT): Inline ...
2205         (create_procinfo): ... here.
2206
2207         (procfs_debug_inferior): Remove SYS_exec handling.
2208         (syscall_is_exec): Likewise.
2209         (procfs_set_exec_trap): Likewise.
2210
2211         (syscall_is_lwp_exit): Inline in callers.
2212         (syscall_is_exit): Likewise.
2213         (syscall_is_exec): Likewise.
2214         (syscall_is_lwp_create): Likewise.
2215
2216         (invalidate_cache): Remove #if 0 code.
2217
2218         (make_signal_thread_runnable):  Remove.
2219         (procfs_target::resume): Remove #if 0 code.
2220
2221 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2222
2223         PR gdb/25939
2224         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
2225         call ...
2226         (procfs_target::create_inferior): ... here.
2227
2228 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2229
2230         * exec.c (validate_exec_file): Ensure the build-id is up to
2231         date by calling reopen_exec_file (that checks file timestamp
2232         to decide to re-read the file).
2233
2234 2020-06-18  Pedro Alves  <palves@redhat.com>
2235
2236         PR gdb/25412
2237         * gdbthread.h (delete_thread, delete_thread_silent)
2238         (find_thread_ptid): Update comments.
2239         * thread.c (current_thread_): New global.
2240         (is_current_thread): Move higher, and reimplement.
2241         (inferior_thread): Reimplement.
2242         (set_thread_exited): Use bool.  Add assertions.
2243         (add_thread_silent): Simplify thread-reuse handling by always
2244         calling delete_thread.
2245         (delete_thread): Remove intro comment.
2246         (find_thread_ptid): Skip exited threads.
2247         (switch_to_thread_no_regs): Write to current_thread_.
2248         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
2249         INFERIOR_PTID.  Clear current_thread_.
2250
2251 2020-06-18  Pedro Alves  <palves@redhat.com>
2252
2253         * aix-thread.c (pd_update): Use switch_to_thread.
2254
2255 2020-06-18  Pedro Alves  <palves@redhat.com>
2256
2257         * ravenscar-thread.c (ravenscar_thread_target): Update.
2258         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
2259         (ravenscar_thread_target::add_active_thread): ... this.  Don't
2260         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
2261         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
2262
2263 2020-06-18  Pedro Alves  <palves@redhat.com>
2264
2265         * nat/windows-nat.c (current_windows_thread): Remove.
2266         * nat/windows-nat.h (current_windows_thread): Remove.
2267         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
2268         Adjust.
2269         (display_selectors): Adjust to fetch the current
2270         windows_thread_info based on inferior_ptid.
2271         (fake_create_process): No longer write to current_windows_thread.
2272         (windows_nat_target::get_windows_debug_event):
2273         Don't set inferior_ptid or current_windows_thread.
2274         (windows_nat_target::wait): Adjust to not rely on
2275         current_windows_thread.
2276         (do_initial_windows_stuff): Now a method of windows_nat_target.
2277         Switch to the last_ptid thread.
2278         (windows_nat_target::attach): Adjust.
2279         (windows_nat_target::detach): Use switch_to_no_thread instead of
2280         writing to inferior_ptid directly.
2281         (windows_nat_target::create_inferior): Adjust.
2282
2283 2020-06-18  Pedro Alves  <palves@redhat.com>
2284
2285         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
2286
2287 2020-06-18  Pedro Alves  <palves@redhat.com>
2288
2289         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
2290         after creating it, instead of writing to inferior_ptid.  Don't
2291         write to inferior_ptid.
2292
2293 2020-06-18  Pedro Alves  <palves@redhat.com>
2294
2295         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
2296
2297 2020-06-18  Pedro Alves  <palves@redhat.com>
2298
2299         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
2300         it, instead of writing to inferior_ptid.
2301
2302 2020-06-18  Pedro Alves  <palves@redhat.com>
2303
2304         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
2305         to inferior_ptid.
2306
2307 2020-06-18  Pedro Alves  <palves@redhat.com>
2308
2309         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
2310         instead of writing to inferior_ptid directly.
2311
2312 2020-06-18  Pedro Alves  <palves@redhat.com>
2313
2314         * corelow.c (core_target::close): Use switch_to_no_thread instead
2315         of writing to inferior_ptid directly.
2316         (add_to_thread_list, core_target_open): Use switch_to_thread
2317         instead of writing to inferior_ptid directly.
2318
2319 2020-06-18  Pedro Alves  <palves@redhat.com>
2320
2321         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
2322         inferior_ptid.
2323         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
2324         inferior_ptid.
2325         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
2326         inferior_ptid directly.
2327         (darwin_nat_target::init_thread_list): Switch to thread, instead
2328         of writing to inferior_ptid.
2329         (darwin_nat_target::attach): Don't write to inferior_ptid.
2330         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
2331
2332 2020-06-18  Pedro Alves  <palves@redhat.com>
2333
2334         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
2335         thread.
2336         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
2337         Instead use switch_to_thread.
2338         (gnu_nat_target::detach): Use switch_to_no_thread
2339         instead of writing to inferior_ptid directly.  Used passed-in
2340         inferior instead of looking up the inferior by pid.
2341
2342 2020-06-18  Pedro Alves  <palves@redhat.com>
2343
2344         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
2345         inferior_ptid.
2346
2347 2020-06-18  Pedro Alves  <palves@redhat.com>
2348
2349         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
2350         inferior_ptid.
2351         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
2352         thread.
2353         (nto_procfs_target::detach): Avoid referencing
2354         inferior_ptid.  Use switch_to_no_thread instead of writing to
2355         inferior_ptid directly.
2356         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
2357         instead of writing to inferior_ptid directly.
2358         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
2359         to thread.
2360
2361 2020-06-18  Pedro Alves  <palves@redhat.com>
2362
2363         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
2364         after creating it, instead of writing to inferior_ptid.
2365         (gdbsim_target_open): Use switch_to_no_thread instead of writing
2366         to inferior_ptid directly.
2367         (gdbsim_target::wait): Don't write to inferior_ptid.
2368
2369 2020-06-18  Pedro Alves  <palves@redhat.com>
2370
2371         * remote.c (remote_target::remote_notice_new_inferior): Use
2372         switch_to_thread instead of writing to inferior_ptid directly.
2373         (remote_target::add_current_inferior_and_thread): Use
2374         switch_to_no_thread instead of writing to inferior_ptid directly.
2375         (extended_remote_target::attach): Use switch_to_inferior_no_thread
2376         and switch_to_thread instead of using set_current_inferior or
2377         writing to inferior_ptid directly.
2378
2379 2020-06-18  Pedro Alves  <palves@redhat.com>
2380
2381         * tracectf.c (ctf_target_open): Switch to added thread instead of
2382         writing to inferior_ptid directly.
2383         (ctf_target::close): Use switch_to_no_thread instead of writing to
2384         inferior_ptid directly.
2385
2386 2020-06-18  Pedro Alves  <palves@redhat.com>
2387
2388         * tracefile-tfile.c (tfile_target_open): Don't write to
2389         inferior_ptid directly, instead switch to added thread.
2390         (tfile_target::close): Use switch_to_no_thread instead of writing
2391         to inferior_ptid directly.
2392
2393 2020-06-18  Pedro Alves  <palves@redhat.com>
2394
2395         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
2396         (procfs_target::detach): Use switch_to_no_thread
2397         instead of writing to inferior_ptid directly.
2398         (do_attach): Change return type to void.  Switch to the added
2399         thread.
2400         (procfs_target::create_inferior): Switch to the added thread.
2401         (procfs_do_thread_registers): Don't write to inferior_ptid.
2402
2403 2020-06-18  Pedro Alves  <palves@redhat.com>
2404
2405         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
2406         of writing to inferior_ptid.
2407         (scoped_restore_exited_inferior): Delete.
2408         (handle_vfork_child_exec_or_exit): Simplify using
2409         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
2410         instead of writing to inferior_ptid.
2411         (THREAD_STOPPED_BY): Delete.
2412         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
2413         (thread_stopped_by_hw_breakpoint): Delete.
2414         (save_waitstatus): Use
2415         scoped_restore_current_thread+switch_to_thread, and call
2416         target_stopped_by_watchpoint instead of
2417         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
2418         instead of thread_stopped_by_sw_breakpoint, and
2419         target_stopped_by_hw_breakpoint instead of
2420         thread_stopped_by_hw_breakpoint.
2421         (handle_inferior_event)
2422         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
2423         inferior_ptid directly, nor
2424         set_current_inferior/set_current_program_space.  Use
2425         switch_to_thread / switch_to_inferior_no_thread instead.
2426
2427 2020-06-18  Pedro Alves  <palves@redhat.com>
2428
2429         * target.c (generic_mourn_inferior): Use switch_to_no_thread
2430         instead of writing to inferior_ptid.
2431
2432 2020-06-18  Pedro Alves  <palves@redhat.com>
2433
2434         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
2435         added thread.
2436         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
2437         to the added thread.
2438         (inf_ptrace_target::detach_success): Use switch_to_no_thread
2439         instead of writing to inferior_ptid.
2440
2441 2020-06-18  Pedro Alves  <palves@redhat.com>
2442
2443         * gdbarch-selftests.c: Include "progspace-and-thread.h".
2444         (register_to_value_test): Mock a program_space too.  Heap-allocate
2445         the address space.  Don't write to inferior_ptid.  Use
2446         switch_to_thread instead.
2447
2448 2020-06-18  Pedro Alves  <palves@redhat.com>
2449
2450         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
2451         Delete.
2452         (find_signalled_thread()): New, factored out from
2453         linux_make_corefile_notes and adjusted to handle exited threads.
2454         (linux_make_corefile_notes): Adjust to use the new
2455         find_signalled_thread.
2456
2457 2020-06-18  Pedro Alves  <palves@redhat.com>
2458
2459         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
2460         of saving/restoring inferior_ptid.
2461
2462 2020-06-17  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
2465         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
2466         declare.
2467         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
2468
2469 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
2470
2471         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
2472         of partial symtabs.
2473
2474 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2475
2476         * regformats/reg-arm.dat: Remove.
2477         * regformats/reg-bfin.dat: Remove.
2478         * regformats/reg-cris.dat: Remove.
2479         * regformats/reg-crisv32.dat: Remove.
2480         * regformats/reg-m32r.dat: Remove.
2481         * regformats/reg-tilegx.dat: Remove.
2482         * regformats/reg-tilegx32.dat: Remove.
2483
2484 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2485
2486         * features/Makefile (WHICH): Remove arm files.
2487         * regformats/arm/arm-with-iwmmxt.dat: Remove.
2488         * regformats/arm/arm-with-neon.dat: Remove.
2489         * regformats/arm/arm-with-vfpv2.dat: Remove.
2490         * regformats/arm/arm-with-vfpv3.dat: Remove.
2491
2492 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2493
2494         * features/Makefile (XMLTOC): Remove rx.xml.
2495
2496 2020-06-17  Pedro Alves  <palves@redhat.com>
2497
2498         * gdbthread.h (thread_control_state) <trap_expected> Update
2499         comments.
2500
2501 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
2504         ada_language::lookup_symbol_nonlocal.
2505         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
2506         (ada_language::lookup_symbol_nonlocal): New member function,
2507         implementation from ada_lookup_symbol_nonlocal.
2508         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
2509         initializer.
2510         (cplus_language_data): Delete la_lookup_symbol_nonlocal
2511         initializer.
2512         (cplus_language::lookup_symbol_nonlocal): New member function.
2513         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
2514         (minimal_language_data) Likewise.
2515         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
2516         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
2517         initializer.
2518         (d_language::lookup_symbol_nonlocal): New member function.
2519         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
2520         initializer.
2521         (f_language::lookup_symbol_nonlocal): New member function.
2522         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
2523         initializer.
2524         * language.c (unknown_language_data): Likewise.
2525         (auto_language_data): Likewise.
2526         * language.h (language_data): Delete la_lookup_symbol_nonlocal
2527         field.
2528         (language_defn::lookup_symbol_nonlocal): New member function.
2529         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
2530         initializer.
2531         * objc-lang.c (objc_language_data): Likewise.
2532         * opencl-lang.c (opencl_language_data): Likewise.
2533         * p-lang.c (pascal_language_data): Likewise.
2534         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
2535         rust_language::lookup_symbol_nonlocal.
2536         (rust_language_data): Delete la_lookup_symbol_nonlocal
2537         initializer.
2538         (rust_language::lookup_symbol_nonlocal): New member function,
2539         implementation from rust_lookup_symbol_nonlocal.
2540         * symtab.c (lookup_symbol_aux): Update call to
2541         lookup_symbol_nonlocal.
2542         (basic_lookup_symbol_nonlocal): Rename to...
2543         (language_defn::lookup_symbol_nonlocal): ...this, and update
2544         header comment.  Remove language_defn parameter, and replace with
2545         uses of `this'.
2546         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
2547
2548 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * ada-lang.c (ada_language_data): Delete la_value_print_inner
2551         initializer.
2552         (ada_language::value_print_inner): New member function.
2553         * c-lang.c (c_language_data): Delete la_value_print_inner
2554         initializer.
2555         (cplus_language_data): Likewise.
2556         (asm_language_data): Likewise.
2557         (minimal_language_data): Likewise.
2558         * d-lang.c (d_language_data): Likewise.
2559         (d_language::value_print_inner): New member function.
2560         * f-lang.c (f_language_data): Delete la_value_print_inner
2561         initializer.
2562         (f_language::value_print_inner): New member function.
2563         * f-lang.h (f_value_print_innner): Rename to...
2564         (f_value_print_inner): ...this (note spelling of 'inner').
2565         * f-valprint.c (f_value_print_innner): Rename to...
2566         (f_value_print_inner): ...this (note spelling of 'inner').
2567         * go-lang.c (go_language_data): Delete la_value_print_inner
2568         initializer.
2569         (go_language::value_print_inner): New member function.
2570         * language.c (language_defn::value_print_inner): Define new member
2571         function.
2572         (unk_lang_value_print_inner): Delete.
2573         (unknown_language_data): Delete la_value_print_inner initializer.
2574         (unknown_language::value_print_inner): New member function.
2575         (auto_language_data): Delete la_value_print_inner initializer.
2576         (auto_language::value_print_inner): New member function.
2577         * language.h (language_data): Delete la_value_print_inner field.
2578         (language_defn::value_print_inner): Delcare new member function.
2579         * m2-lang.c (m2_language_data): Delete la_value_print_inner
2580         initializer.
2581         (m2_language::value_print_inner): New member function.
2582         * objc-lang.c (objc_language_data): Delete la_value_print_inner
2583         initializer.
2584         * opencl-lang.c (opencl_language_data): Likewise.
2585         * p-lang.c (pascal_language_data): Likewise.
2586         (pascal_language::value_print_inner): New member function.
2587         * rust-lang.c (rust_language_data): Delete la_value_print_inner
2588         initializer.
2589         (rust_language::value_print_inner): New member function.
2590         * valprint.c (do_val_print): Update call to value_print_inner.
2591
2592 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * ada-lang.c (ada_language_data): Delete la_value_print
2595         initializer.
2596         (ada_language::value_print): New member function.
2597         * c-lang.c (c_language_data): Delete la_value_print initializer.
2598         (cplus_language_data): Likewise.
2599         (asm_language_data): Likewise.
2600         (minimal_language_data): Likewise.
2601         * d-lang.c (d_language_data): Likewise.
2602         * f-lang.c (f_language_data): Likewise.
2603         * go-lang.c (go_language_data): Likewise.
2604         * language.c (unk_lang_value_print): Delete.
2605         (language_defn::value_print): Define new member function.
2606         (unknown_language_data): Delete la_value_print initializer.
2607         (unknown_language::value_print): New member function.
2608         (auto_language_data): Delete la_value_print initializer.
2609         (auto_language::value_print): New member function.
2610         * language.h (language_data): Delete la_value_print field.
2611         (language_defn::value_print): Declare new member function.
2612         (LA_VALUE_PRINT): Update call to value_print.
2613         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
2614         * objc-lang.c (objc_language_data): Likewise.
2615         * opencl-lang.c (opencl_language_data): Likewise.
2616         * p-lang.c (pascal_language_data): Likewise.
2617         (pascal_language::value_print): New member function.
2618         * rust-lang.c (rust_language_data): Delete la_value_print
2619         initializer.
2620
2621 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2622
2623         * ada-lang.c (ada_watch_location_expression): Rename to
2624         ada_language::watch_location_expression.
2625         (ada_language_data): Delete la_watch_location_expression
2626         initializer.
2627         (ada_language::watch_location_expression): New member function,
2628         implementation from ada_watch_location_expression.
2629         * breakpoint.c (watch_command_1): Update call to
2630         watch_location_expression.
2631         * c-lang.c (c_watch_location_expression): Rename to
2632         language_defn::watch_location_expression.
2633         (c_language_data): Delete la_watch_location_expression
2634         initializer.
2635         (cplus_language_data): Likewise.
2636         (asm_language_data): Likewise.
2637         (minimal_language_data): Likewise.
2638         * c-lang.h (c_watch_location_expression): Delete declaration.
2639         * d-lang.c (d_language_data): Delete la_watch_location_expression
2640         initializer.
2641         * f-lang.c (f_language_data): Likewise.
2642         * go-lang.c (go_language_data): Likewise.
2643         * language.c (language_defn::watch_location_expression): Member
2644         function implementation from c_watch_location_expression.
2645         (unknown_language_data): Delete la_watch_location_expression
2646         initializer.
2647         (auto_language_data): Likewise.
2648         * language.h (language_data): Delete la_watch_location_expression
2649         field.
2650         (language_defn::watch_location_expression): Declare new member
2651         function.
2652         * m2-lang.c (m2_language_data): Delete
2653         la_watch_location_expression initializer.
2654         * objc-lang.c (objc_language_data): Likewise.
2655         * opencl-lang.c (opencl_language_data): Likewise.
2656         * p-lang.c (pascal_language_data): Likewise.
2657         * rust-lang.c (rust_watch_location_expression): Rename to
2658         rust_language::watch_location_expression.
2659         (rust_language_data): Delete la_watch_location_expression
2660         initializer.
2661         (rust_language::watch_location_expression): New member function,
2662         implementation from rust_watch_location_expression.
2663
2664 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
2667         ada_language::collect_symbol_completion_matches.
2668         (ada_language_data): Delete la_collect_symbol_completion_matches
2669         initializer.
2670         (ada_language::collect_symbol_completion_matches): New member
2671         function, implementation from
2672         ada_collect_symbol_completion_matches.
2673         * c-lang.c (c_language_data): Delete
2674         la_collect_symbol_completion_matches initializer.
2675         (cplus_language_data): Likewise.
2676         (asm_language_data): Likewise.
2677         (minimal_language_data): Likewise.
2678         * d-lang.c (d_language_data): Likewise.
2679         * f-lang.c (f_collect_symbol_completion_matches): Rename to
2680         f_language::collect_symbol_completion_matches.
2681         (f_language_data): Delete la_collect_symbol_completion_matches
2682         initializer.
2683         (f_language::collect_symbol_completion_matches) New member
2684         function, implementation from f_collect_symbol_completion_matches.
2685         * go-lang.c (go_language_data): Delete
2686         la_collect_symbol_completion_matches initializer.
2687         * language.c (unknown_language_data): Likewise.
2688         (auto_language_data): Likewise.
2689         * language.h (language_data): Delete
2690         la_collect_symbol_completion_matches field.
2691         (language_defn::collect_symbol_completion_matches): New member
2692         function.
2693         * m2-lang.c (m2_language_data): Delete
2694         la_collect_symbol_completion_matches initializer.
2695         * objc-lang.c (objc_language_data): Likewise.
2696         * opencl-lang.c (opencl_language_data): Likewise.
2697         * p-lang.c (pascal_language_data): Likewise.
2698         * rust-lang.c (rust_language_data): Likewise.
2699         * symtab.c (default_collect_symbol_completion_matches): Delete.
2700         (collect_symbol_completion_matches): Update call to
2701         collect_symbol_completion_matches.
2702         (collect_symbol_completion_matches_type): Likewise.
2703         * symtab.h (default_collect_symbol_completion_matches): Delete
2704         declaration.
2705
2706 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
2709         (ada_language_data): Delete la_word_break_characters initializer.
2710         (ada_language::word_break_characters): New member function.
2711         * c-lang.c (c_language_data): Delete la_word_break_characters
2712         initializer.
2713         (cplus_language_data): Likewise.
2714         (asm_language_data): Likewise.
2715         (minimal_language_data): Likewise.
2716         * completer.c: Update global comment.
2717         (advance_to_expression_complete_word_point): Update call to
2718         word_break_characters.
2719         (complete_files_symbols): Likewise.
2720         (complete_line_internal_1): Likewise.
2721         (default_completer_handle_brkchars): Likewise.
2722         (skip_quoted_chars): Likewise.
2723         * d-lang.c (d_language_data): Delete la_word_break_characters
2724         initializer.
2725         * f-lang.c (f_word_break_characters): Delete.
2726         (f_language_data): Delete la_word_break_characters initializer.
2727         (f_language::word_break_characters): New member function.
2728         * go-lang.c (go_language_data): Delete la_word_break_characters
2729         initializer.
2730         * language.c (unknown_language_data): Likewise.
2731         (auto_language_data): Likewise.
2732         * language.h (default_word_break_characters): Move declaration to
2733         earlier in the file.
2734         (language_data): Delete la_word_break_characters field.
2735         (language_defn::word_break_characters): New member function.
2736         * m2-lang.c (m2_language_data): Delete la_word_break_characters
2737         initializer.
2738         * objc-lang.c (objc_language_data): Likewise.
2739         * opencl-lang.c (opencl_language_data): Likewise.
2740         * p-lang.c (pascal_language_data): Likewise.
2741         * rust-lang.c (rust_language_data): Likewise.
2742
2743 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
2746         (ada_language_data): Delete la_get_symbol_name_matcher
2747         initializer.
2748         (language_defn::get_symbol_name_matcher_inner): New member
2749         function.
2750         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
2751         initializer.
2752         (cplus_language_data): Likewise.
2753         (cplus_language::get_symbol_name_matcher_inner): New member
2754         function.
2755         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
2756         (minimal_language_data): Likewise.
2757         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
2758         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
2759         initializer.
2760         * dictionary.c (iter_match_first_hashed): Update call to
2761         get_symbol_name_matcher.
2762         (iter_match_next_hashed): Likewise.
2763         (iter_match_next_linear): Likewise.
2764         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
2765         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
2766         initializer.
2767         (f_language::get_symbol_name_matcher_inner): New member function.
2768         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
2769         initializer.
2770         * language.c (default_symbol_name_matcher): Update header comment,
2771         make static.
2772         (language_defn::get_symbol_name_matcher): New definition.
2773         (language_defn::get_symbol_name_matcher_inner): Likewise.
2774         (get_symbol_name_matcher): Delete.
2775         (unknown_language_data): Delete la_get_symbol_name_matcher
2776         initializer.
2777         (auto_language_data): Likewise.
2778         * language.h (language_data): Delete la_get_symbol_name_matcher
2779         field.
2780         (language_defn::get_symbol_name_matcher): New member function.
2781         (language_defn::get_symbol_name_matcher_inner): Likewise.
2782         (default_symbol_name_matcher): Delete declaration.
2783         * linespec.c (find_methods): Update call to
2784         get_symbol_name_matcher.
2785         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
2786         initializer.
2787         * minsyms.c (lookup_minimal_symbol): Update call to
2788         get_symbol_name_matcher.
2789         (iterate_over_minimal_symbols): Likewise.
2790         * objc-lang.c (objc_language_data): Delete
2791         la_get_symbol_name_matcher initializer.
2792         * opencl-lang.c (opencl_language_data): Likewise.
2793         * p-lang.c (pascal_language_data): Likewise.
2794         * psymtab.c (psymbol_name_matches): Update call to
2795         get_symbol_name_matcher.
2796         * rust-lang.c (rust_language_data): Delete
2797         la_get_symbol_name_matcher initializer.
2798         * symtab.c (symbol_matches_search_name): Update call to
2799         get_symbol_name_matcher.
2800         (compare_symbol_name): Likewise.
2801
2802 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2803
2804         * ada-lang.c (ada_language_data): Delete la_compute_program
2805         initializer.
2806         * c-lang.c (c_language_data): Likewise.
2807         (c_language::compute_program): New member function.
2808         (cplus_language_data): Delete la_compute_program initializer.
2809         (cplus_language::compute_program): New member function.
2810         (asm_language_data): Delete la_compute_program initializer.
2811         (minimal_language_data): Likewise.
2812         * c-lang.h (c_compute_program): Update comment.
2813         (cplus_compute_program): Likewise.
2814         * compile/compile-c-support.c (c_compute_program): Likewise.
2815         (cplus_compute_program): Likewise.
2816         * compile/compile.c (compile_to_object): Update call to
2817         la_compute_program.
2818         * d-lang.c (d_language_data): Delete la_compute_program
2819         initializer.
2820         * f-lang.c (f_language_data): Likewise.
2821         * go-lang.c (go_language_data): Likewise.
2822         * language.c (unknown_language_data): Likewise.
2823         (auto_language_data): Likewise.
2824         * language.h (language_data): Delete la_compute_program field.
2825         (language_defn::compute_program): New member function.
2826         * m2-lang.c (m2_language_data): Delete la_compute_program
2827         initializer.
2828         * objc-lang.c (objc_language_data): Likewise.
2829         * opencl-lang.c (opencl_language_data): Likewise.
2830         * p-lang.c (pascal_language_data): Likewise.
2831         * rust-lang.c (rust_language_data): Likewise.
2832
2833 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * ada-lang.c (ada_language_data) Delete
2836         la_class_name_from_physname initializer.
2837         * c-lang.c (c_language_data): Likewise.
2838         (cplus_language_data): Likewise.
2839         (cplus_language::class_name_from_physname): New member function.
2840         (asm_language_data): Delete la_class_name_from_physname
2841         initializer.
2842         (minimal_language_data): Likewise.
2843         * d-lang.c (d_language_data): Likewise.
2844         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
2845         method on language_defn class.
2846         (guess_full_die_structure_name): Likewise.
2847         * f-lang.c (f_language_data): Delete la_class_name_from_physname
2848         initializer.
2849         * go-lang.c (go_language_data): Likewise.
2850         * language.c (language_class_name_from_physname): Delete.
2851         (unk_lang_class_name): Delete.
2852         (unknown_language_data): Delete la_class_name_from_physname
2853         initializer.
2854         (auto_language_data): Likewise.
2855         * language.h (language_data): Delete la_class_name_from_physname
2856         field.
2857         (language_defn::class_name_from_physname): New function.
2858         (language_class_name_from_physname): Delete declaration.
2859         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
2860         initializer.
2861         * objc-lang.c (objc_language_data): Likewise.
2862         * opencl-lang.c (opencl_language_data): Likewise.
2863         * p-lang.c (pascal_language_data): Likewise.
2864         * rust-lang.c (rust_language_data): Likewise.
2865
2866 2020-06-16  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-data.h (STATUS_NAME): New macro.
2869         * tui/tui-layout.c (tui_remove_some_windows)
2870         (initialize_known_windows, tui_register_window)
2871         (tui_layout_split::remove_windows, initialize_layouts)
2872         (tui_new_layout_command): Don't use hard-coded window names.
2873
2874 2020-06-16  Tom Tromey  <tom@tromey.com>
2875
2876         PR tui/25348:
2877         * tui/tui.c (tui_ensure_readline_initialized): Rename from
2878         tui_initialize_readline.  Only run once.  Call rl_initialize.
2879         * tui/tui.h (tui_ensure_readline_initialized): Rename from
2880         tui_initialize_readline.
2881         * tui/tui-io.c (tui_setup_io): Call
2882         tui_ensure_readline_initialized.
2883         * tui/tui-interp.c (tui_interp::init): Update.
2884
2885 2020-06-16  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
2888         Also preserve the status window.
2889
2890 2020-06-16  Tom Tromey  <tom@tromey.com>
2891
2892         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
2893         where m_window==nullptr.
2894
2895 2020-06-15  Tom Tromey  <tromey@adacore.com>
2896
2897         * windows-nat.c (windows_nat::handle_output_debug_string):
2898         Update.
2899         (windows_nat::handle_ms_vc_exception): Update.
2900         * target.h (target_read_string): Change API.
2901         * target.c (target_read_string): Change API.
2902         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
2903         Update.
2904         * solib-frv.c (frv_current_sos): Update.
2905         * solib-dsbt.c (dsbt_current_sos): Update.
2906         * solib-darwin.c (darwin_current_sos): Update.
2907         * linux-thread-db.c (inferior_has_bug): Update.
2908         * expprint.c (print_subexp_standard): Update.
2909         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
2910         (ada_exception_message_1): Update.
2911
2912 2020-06-15  Tom Tromey  <tromey@adacore.com>
2913
2914         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
2915
2916 2020-06-15  Tom Tromey  <tromey@adacore.com>
2917
2918         * valprint.c (read_string): Update comment.
2919         * target.c (MIN): Remove.
2920         (target_read_string): Rewrite.
2921
2922 2020-06-15  Tom Tromey  <tromey@adacore.com>
2923
2924         * corefile.c (read_memory_string): Remove.
2925         * ada-valprint.c (ada_value_print_ptr): Update.
2926         * ada-lang.h (ada_tag_name): Change return type.
2927         * ada-lang.c (type_from_tag): Update.
2928         (ada_tag_name_from_tsd): Change return type.  Use
2929         target_read_string.
2930         (ada_tag_name): Likewise.
2931         * gdbcore.h (read_memory_string): Don't declare.
2932
2933 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
2934
2935         * symtab.c (rbreak_command): Ignore Windows drive colon.
2936
2937 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
2938
2939         * NEWS: Mention removed GDBserver host support.
2940
2941 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
2942
2943         * features/riscv/rebuild-csr-xml.sh: Updated.
2944
2945 2020-06-11  Tom Tromey  <tom@tromey.com>
2946
2947         PR gdb/18318:
2948         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
2949
2950 2020-06-09  Jonny Grant  <jg@jguk.org>
2951 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
2952
2953         * main.c (captured_main_1): Don't print new line after help.
2954         (print_gdb_help): add mailing list and IRC channel information
2955         to --help.  Add new lines between items in the footer.  Remove
2956         quotes around bug url.
2957
2958 2020-06-11  Keith Seitz  <keiths@redhat.com>
2959
2960         PR gdb/21356
2961         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
2962         Resolve typedefs for type length calculations.
2963
2964 2020-06-10  Tom de Vries  <tdevries@suse.de>
2965
2966         PR ada/24713
2967         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
2968         (write_psymbols): Enable .gdb_index for ada.
2969         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
2970         ada.
2971
2972 2020-06-10  Tom de Vries  <tdevries@suse.de>
2973
2974         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
2975         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
2976         namei" instead of "const char *name" argument.
2977         (dw2_map_matching_symbols): Use "offset_type namei" variant of
2978         dw2_symtab_iter_init.
2979
2980 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2981
2982         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
2983         to use type::field and field::type instead.
2984
2985 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2986
2987         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
2988         to use field::type instead.
2989
2990 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2991
2992         * gdbtypes.h (struct field) <type, set_type>: New methods.
2993         Rename `type` field to...
2994         <m_type>: ... this.  Change references throughout to use type or
2995         set_type methods.
2996         (FIELD_TYPE): Use field::type.  Change call sites that modify
2997         the field's type to use field::set_type instead.
2998
2999 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3000
3001         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
3002         to use type::index_type instead.
3003
3004 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3005
3006         * gdbtypes.h (struct type) <index_type, set_index_type>: New
3007         methods.
3008         (TYPE_INDEX_TYPE): Use type::index_type.
3009         * gdbtypes.c (create_array_type_with_stride): Likewise.
3010
3011 2020-06-07  Tom Tromey  <tom@tromey.com>
3012
3013         * valprint.c (generic_val_print_float): Remove "embedded_offset"
3014         parameter.
3015         (generic_value_print): Update.
3016
3017 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         Revert commit 982a38f60b0.
3020         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
3021
3022 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
3025         avoid use after free.
3026
3027 2020-06-05  Tom de Vries  <tdevries@suse.de>
3028
3029         * NEWS: Fix typos.
3030
3031 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
3032
3033         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
3034         the per_bfd object.
3035         (dwarf2_read_debug_names): Likewise.
3036         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
3037         object when re-using a per_bfd object with an index.
3038
3039 2020-06-03  Tom de Vries  <tdevries@suse.de>
3040
3041         PR symtab/26046
3042         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
3043         children for C++.
3044         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
3045         DW_TAG_subprogram.
3046
3047 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3048
3049         * ada-lang.c (ada_language_data): Delete skip_trampoline
3050         initializer.
3051         * c-lang.c (c_language_data): Likewise.
3052         (cplus_language_data): Likewise.
3053         (cplus_language::skip_trampoline): New member function.
3054         (asm_language_data): Delete skip_trampoline initializer.
3055         (minimal_language_data): Likewise.
3056         * d-lang.c (d_language_data): Likewise.
3057         * f-lang.c (f_language_data): Likewise.
3058         * go-lang.c (go_language_data): Likewise.
3059         * language.c (unk_lang_trampoline): Delete function.
3060         (skip_language_trampoline): Update.
3061         (unknown_language_data): Delete skip_trampoline initializer.
3062         (auto_language_data): Likewise.
3063         * language.h (language_data): Delete skip_trampoline field.
3064         (language_defn::skip_trampoline): New function.
3065         * m2-lang.c (m2_language_data): Delete skip_trampoline
3066         initializer.
3067         * objc-lang.c (objc_skip_trampoline): Delete function, move
3068         implementation to objc_language::skip_trampoline.
3069         (objc_language_data): Delete skip_trampoline initializer.
3070         (objc_language::skip_trampoline): New member function with
3071         implementation from objc_skip_trampoline.
3072         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
3073         initializer.
3074         * p-lang.c (pascal_language_data): Likewise.
3075         * rust-lang.c (rust_language_data): Likewise.
3076
3077 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
3080         (ada_language::demangle): New member function.
3081         * c-lang.c (c_language_data): Delete la_demangle initializer.
3082         (cplus_language_data): Delete la_demangle initializer.
3083         (cplus_language::demangle): New member function.
3084         (asm_language_data): Delete la_demangle initializer.
3085         (minimal_language_data): Delete la_demangle initializer.
3086         * d-lang.c (d_language_data): Delete la_demangle initializer.
3087         (d_language::demangle): New member function.
3088         * f-lang.c (f_language_data): Delete la_demangle initializer.
3089         (f_language::demangle): New member function.
3090         * go-lang.c (go_language_data): Delete la_demangle initializer.
3091         (go_language::demangle): New member function.
3092         * language.c (language_demangle): Update.
3093         (unk_lang_demangle): Delete.
3094         (unknown_language_data): Delete la_demangle initializer.
3095         (unknown_language::demangle): New member function.
3096         (auto_language_data): Delete la_demangle initializer.
3097         (auto_language::demangle): New member function.
3098         * language.h (language_data): Delete la_demangle field.
3099         (language_defn::demangle): New function.
3100         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
3101         * objc-lang.c (objc_language_data): Delete la_demangle
3102         initializer.
3103         (objc_language::demangle): New member function.
3104         * opencl-lang.c (opencl_language_data): Delete la_demangle
3105         initializer.
3106         * p-lang.c (pascal_language_data): Likewise.
3107         * rust-lang.c (rust_language_data): Likewise.
3108         (rust_language::demangle): New member function.
3109
3110 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * ada-lang.c (ada_language_data): Delete la_print_type
3113         initializer.
3114         (ada_language::print_type): New member function.
3115         * c-lang.c (c_language_data): Delete la_print_type initializer.
3116         (c_language::print_type): New member function.
3117         (cplus_language_data): Delete la_print_type initializer.
3118         (cplus_language::print_type): New member function.
3119         (asm_language_data): Delete la_print_type initializer.
3120         (asm_language::print_type): New member function.
3121         (minimal_language_data): Delete la_print_type initializer.
3122         (minimal_language::print_type): New member function.
3123         * d-lang.c (d_language_data): Delete la_print_type initializer.
3124         (d_language::print_type): New member function.
3125         * f-lang.c (f_language_data): Delete la_print_type initializer.
3126         (f_language::print_type): New member function.
3127         * go-lang.c (go_language_data): Delete la_print_type initializer.
3128         (go_language::print_type): New member function.
3129         * language.c (unk_lang_print_type): Delete.
3130         (unknown_language_data): Delete la_print_type initializer.
3131         (unknown_language::print_type): New member function.
3132         (auto_language_data): Delete la_print_type initializer.
3133         (auto_language::print_type): New member function.
3134         * language.h (language_data): Delete la_print_type field.
3135         (language_defn::print_type): New function.
3136         (LA_PRINT_TYPE): Update.
3137         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
3138         (m2_language::print_type): New member function.
3139         * objc-lang.c (objc_language_data): Delete la_print_type
3140         initializer.
3141         (objc_language::print_type): New member function.
3142         * opencl-lang.c (opencl_print_type): Delete, implementation moved
3143         to opencl_language::print_type.
3144         (opencl_language_data): Delete la_print_type initializer.
3145         (opencl_language::print_type): New member function, implementation
3146         from opencl_print_type.
3147         * p-lang.c (pascal_language_data): Delete la_print_type
3148         initializer.
3149         (pascal_language::print_type): New member function.
3150         * rust-lang.c (rust_print_type): Delete, implementation moved to
3151         rust_language::print_type.
3152         (rust_language_data): Delete la_print_type initializer.
3153         (rust_language::print_type): New member function, implementation
3154         from rust_print_type.
3155
3156 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
3159         implementation moves to...
3160         (ada_language::sniff_from_mangled_name): ...here.  Update return
3161         type.
3162         (ada_language_data): Delete la_sniff_from_mangled_name
3163         initializer.
3164         * c-lang.c (c_language_data): Likewise.
3165         (cplus_language_data): Likewise.
3166         (cplus_language::sniff_from_mangled_name): New member function,
3167         implementation taken from gdb_sniff_from_mangled_name.
3168         (asm_language_data): Delete la_sniff_from_mangled_name
3169         initializer.
3170         (minimal_language_data): Likewise.
3171         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
3172         implementation moves to cplus_language::sniff_from_mangled_name.
3173         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
3174         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
3175         moves to...
3176         (d_language::sniff_from_mangled_name): ...here.
3177         (d_language_data): Delete la_sniff_from_mangled_name initializer.
3178         * f-lang.c (f_language_data): Likewise.
3179         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
3180         moves to...
3181         (go_language::sniff_from_mangled_name): ...here.
3182         (go_language_data): Delete la_sniff_from_mangled_name initializer.
3183         * language.c (language_sniff_from_mangled_name): Delete.
3184         (unknown_language_data): Delete la_sniff_from_mangled_name
3185         initializer.
3186         (auto_language_data): Likewise.
3187         * language.h (language_data): Delete la_sniff_from_mangled_name
3188         field.
3189         (language_defn::sniff_from_mangled_name): New function.
3190         (language_sniff_from_mangled_name): Delete declaration.
3191         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
3192         field.
3193         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
3194         implementation moves to...
3195         (objc_language::sniff_from_mangled_name): ...here.
3196         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
3197         * opencl-lang.c (opencl_language_data): Likewise.
3198         * p-lang.c (pascal_language_data): Likewise.
3199         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
3200         implementation moves to...
3201         (rust_language::sniff_from_mangled_name): ...here.
3202         (rust_language_data): Delete la_sniff_from_mangled_name
3203         initializer.
3204         * symtab.c (symbol_find_demangled_name): Call
3205         sniff_from_mangled_name member function.
3206
3207 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         * ada-lang.c (ada_language_data): Delete la_search_name_hash
3210         initializer.
3211         * c-lang.c (c_language_data): Likewise.
3212         (cplus_language_data): Likewise.
3213         (cplus_language::search_name_hash): New member function.
3214         (asm_language_data): Delete la_search_name_hash initializer.
3215         (minimal_language_data): Likewise.
3216         * d-lang.c (d_language_data): Likewise.
3217         * dictionary.c (default_search_name_hash): Rename to...
3218         (language_defn::search_name_hash): ...this.
3219         * f-lang.c (f_language_data): Likewise.
3220         (f_language::search_name_hash): New member function.
3221         * go-lang.c (go_language_data): Delete la_search_name_hash
3222         initializer.
3223         * language.c (unknown_language_data): Likewise.
3224         (auto_language_data): Likewise.
3225         * language.h (struct language_data): Delete la_search_name_hash
3226         field.
3227         (language_defn::search_name_hash): Declare new member function.
3228         (default_search_name_hash): Delete declaration.
3229         * m2-lang.c (m2_language_data): Delete la_search_name_hash
3230         initializer.
3231         * objc-lang.c (objc_language_data): Likewise.
3232         * opencl-lang.c (opencl_language_data): Likewise.
3233         * p-lang.c (pascal_language_data): Likewise.
3234         * rust-lang.c (rust_language_data): Likewise.
3235         * symtab.c (search_name_hash): Update call.
3236
3237 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
3240         initializer.
3241         * c-lang.c (class compile_instance): Declare.
3242         (c_language_data): Delete la_get_compile_instance initializer.
3243         (c_language::get_compile_instance): New member function.
3244         (cplus_language_data): Delete la_get_compile_instance initializer.
3245         (cplus_language::get_compile_instance): New member function.
3246         (asm_language_data): Delete la_get_compile_instance initializer.
3247         (minimal_language_data): Likewise.
3248         * c-lang.h (c_get_compile_context): Update comment.
3249         (cplus_get_compile_context): Update comment.
3250         * compile/compile.c (compile_to_object): Update calls, don't rely
3251         on function pointer being NULL.
3252         * d-lang.c (d_language_data): Delete la_get_compile_instance
3253         initializer.
3254         * f-lang.c (f_language_data): Likewise.
3255         * go-lang.c (go_language_data): Likewise.
3256         * language.c (unknown_language_data): Likewise.
3257         (auto_language_data): Likewise.
3258         * language.h (language_data): Delete la_get_compile_instance field.
3259         (language_defn::get_compile_instance): New member function.
3260         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
3261         initializer.
3262         * objc-lang.c (objc_language_data): Likewise.
3263         * opencl-lang.c (opencl_language_data): Likewise.
3264         * p-lang.c (pascal_language_data): Likewise.
3265         * rust-lang.c (rust_language_data): Likewise.
3266
3267 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * ada-lang.c (ada_add_all_symbols): Update comment.
3270         (ada_iterate_over_symbols): Delete, move implementation to...
3271         (ada_language::iterate_over_symbols): ...here, a new member
3272         function, rewrite to use range based for loop.
3273         (ada_language_data): Delete la_iterate_over_symbols initializer.
3274         * c-lang.c (c_language_data): Likewise.
3275         (cplus_language_data): Likewise.
3276         (asm_language_data): Likewise.
3277         (minimal_language_data): Likewise.
3278         * d-lang.c (d_language_data): Likewise.
3279         * f-lang.c (f_language_data): Likewise.
3280         * go-lang.c (go_language_data): Likewise.
3281         * language.c (unknown_language_data): Likewise.
3282         (auto_language_data): Likewise.
3283         * language.h (language_data): Delete la_iterate_over_symbols field.
3284         (language_defn::iterate_over_symbols): New member function.
3285         (LA_ITERATE_OVER_SYMBOLS): Update.
3286         * linespec.c (iterate_over_all_matching_symtabs): Update.
3287         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
3288         initializer.
3289         * objc-lang.c (objc_language_data): Likewise.
3290         * opencl-lang.c (opencl_language_data): Likewise.
3291         * p-lang.c (pascal_language_data): Likewise.
3292         * rust-lang.c (rust_language_data): Likewise.
3293
3294 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3295
3296         * ada-lang.c (ada_language_data): Delete
3297         la_lookup_transparent_type initializer.
3298         * c-lang.c (c_language_data): Likewise.
3299         (cplus_language_data): Likewise.
3300         (cplus_language::lookup_transparent_type): New member function.
3301         (asm_language_data): Delete la_lookup_transparent_type
3302         initializer.
3303         (minimal_language_data): Likewise.
3304         * d-lang.c (d_language_data): Likewise.
3305         * f-lang.c (f_language_data): Likewise.
3306         * go-lang.c (go_language_data): Likewise.
3307         * language.c (unknown_language_data): Likewise.
3308         (auto_language_data): Likewise.
3309         * language.h (struct language_data): Delete
3310         la_lookup_transparent_type field.
3311         (language_defn::lookup_transparent_type): New member function.
3312         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
3313         initializer.
3314         * objc-lang.c (objc_language_data): Likewise.
3315         * opencl-lang.c (opencl_language_data): Likewise.
3316         * p-lang.c (pascal_language_data): Likewise.
3317         * rust-lang.c (rust_language_data): Likewise.
3318         * symtab.c (symbol_matches_domain): Update call.
3319
3320 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3321
3322         * ada-lang.c (ada_language_arch_info): Delete function, move
3323         implementation to...
3324         (ada_language::language_arch_info): ...here, a new member
3325         function.
3326         (ada_language_data): Delete la_language_arch_info.
3327         * c-lang.c (c_language_data): Likewise.
3328         (c_language::language_arch_info): New member function.
3329         (cplus_language_arch_info): Delete function, move
3330         implementation to...
3331         (cplus_language::language_arch_info): ...here, a new member
3332         function.
3333         (cplus_language_data): Delete la_language_arch_info.
3334         (asm_language_data): Likewise.
3335         (asm_language::language_arch_info): New member function.
3336         (minimal_language_data): Delete la_language_arch_info.
3337         (minimal_language::language_arch_info): New member function.
3338         * d-lang.c (d_language_arch_info): Delete function, move
3339         implementation to...
3340         (d_language::language_arch_info): ...here, a new member
3341         function.
3342         (d_language_data): Delete la_language_arch_info.
3343         * f-lang.c (f_language_arch_info): Delete function, move
3344         implementation to...
3345         (f_language::language_arch_info): ...here, a new member
3346         function.
3347         (f_language_data): Delete la_language_arch_info.
3348         * go-lang.c (go_language_arch_info): Delete function, move
3349         implementation to...
3350         (go_language::language_arch_info): ...here, a new member
3351         function.
3352         (go_language_data): Delete la_language_arch_info.
3353         * language.c (unknown_language_data): Likewise.
3354         (unknown_language::language_arch_info): New member function.
3355         (auto_language_data): Delete la_language_arch_info.
3356         (auto_language::language_arch_info): New member function.
3357         (language_gdbarch_post_init): Update call to
3358         la_language_arch_info.
3359         * language.h (language_data): Delete la_language_arch_info
3360         function pointer.
3361         (language_defn::language_arch_info): New function.
3362         * m2-lang.c (m2_language_arch_info): Delete function, move
3363         implementation to...
3364         (m2_language::language_arch_info): ...here, a new member
3365         function.
3366         (m2_language_data): Delete la_language_arch_info.
3367         * objc-lang.c (objc_language_arch_info): Delete function, move
3368         implementation to...
3369         (objc_language::language_arch_info): ...here, a new member
3370         function.
3371         (objc_language_data): Delete la_language_arch_info.
3372         * opencl-lang.c (opencl_language_arch_info): Delete function, move
3373         implementation to...
3374         (opencl_language::language_arch_info): ...here, a new member
3375         function.
3376         (opencl_language_data): Delete la_language_arch_info.
3377         * p-lang.c (pascal_language_arch_info): Delete function, move
3378         implementation to...
3379         (pascal_language::language_arch_info): ...here, a new member
3380         function.
3381         (pascal_language_data): Delete la_language_arch_info.
3382         * rust-lang.c (rust_language_arch_info): Delete function, move
3383         implementation to...
3384         (rust_language::language_arch_info): ...here, a new member
3385         function.
3386         (rust_language_data): Delete la_language_arch_info.
3387
3388 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
3391         initializer.
3392         * c-lang.c (c_language_data): Likewise.
3393         (cplus_language_data): Likewise.
3394         (cplus_language::pass_by_reference_info): New method.
3395         (asm_language_data): Delete la_pass_by_reference initializer.
3396         (minimal_language_data): Likewise.
3397         * cp-abi.c (cp_pass_by_reference): Remove use of
3398         default_pass_by_reference.
3399         * d-lang.c (d_language_data): Likewise.
3400         * f-lang.c (f_language_data): Likewise.
3401         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
3402         default_pass_by_reference.
3403         * go-lang.c (go_language_data): Likewise.
3404         * language.c (language_pass_by_reference): Update.
3405         (default_pass_by_reference): Delete.
3406         (unknown_language_data): Delete la_pass_by_reference
3407         initializer.
3408         (auto_language_data): Likewise.
3409         * language.h (struct language_data): Delete la_pass_by_reference
3410         field.
3411         (language_defn::pass_by_reference_info): New member function.
3412         (default_pass_by_reference): Delete declaration.
3413         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
3414         initializer.
3415         * objc-lang.c (objc_language_data): Likewise.
3416         * opencl-lang.c (opencl_language_data): Likewise.
3417         * p-lang.c (pascal_language_data): Likewise.
3418         * rust-lang.c (rust_language_data): Likewise.
3419
3420 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * ada-lang.c (ada_read_var_value): Delete function, move
3423         implementation to...
3424         (ada_language::read_var_value): ...here.
3425         (ada_language_data): Delete la_read_var_value initializer.
3426         * c-lang.c (c_language_data): Likewise.
3427         (cplus_language_data): Likewise.
3428         (minimal_language_data): Likewise.
3429         * d-lang.c (d_language_data): Likewise.
3430         * f-lang.c (f_language_data): Likewise.
3431         * findvar.c (default_read_var_value): Rename to...
3432         (language_defn::read_var_value): ...this.
3433         * findvar.c (read_var_value): Update header comment, and change to
3434         call member function instead of function pointer.
3435         * go-lang.c (go_language_data): Likewise.
3436         * language.c (unknown_language_data): Delete la_read_var_value
3437         initializer.
3438         (auto_language_data): Likewise.
3439         * language.h (struct language_data): Delete la_read_var_value
3440         field.
3441         (language_defn::read_var_value): New member function.
3442         (default_read_var_value): Delete declaration.
3443         * m2-lang.c (m2_language_data): Delete la_read_var_value
3444         initializer.
3445         * objc-lang.c (objc_language_data): Likewise.
3446         * opencl-lang.c (opencl_language_data): Likewise.
3447         * p-lang.c (pascal_language_data): Likewise.
3448         * rust-lang.c (rust_language_data): Likewise.
3449         * value.h (default_read_var_value): Delete declaration.
3450
3451 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * ada-lang.c (ada_print_array_index): Delete function, move
3454         implementation to...
3455         (ada_language::print_array_index): ...here.
3456         (ada_language_data): Delete la_print_array_index initializer.
3457         * c-lang.c (c_language_data): Likewise.
3458         (cplus_language_data): Likewise.
3459         (minimal_language_data): Likewise.
3460         * d-lang.c (d_language_data): Likewise.
3461         * f-lang.c (f_language_data): Likewise.
3462         * go-lang.c (go_language_data): Likewise.
3463         * language.c (default_print_array_index): Delete function, move
3464         implementation to...
3465         (language_defn::print_array_index): ...here.
3466         (unknown_language_data): Delete la_print_array_index initializer.
3467         (auto_language_data): Likewise.
3468         * language.h (struct language_data): Delete la_print_array_index
3469         field.
3470         (language_defn::print_array_index): New member function.
3471         (LA_PRINT_ARRAY_INDEX): Update.
3472         (default_print_array_index): Delete declaration.
3473         * m2-lang.c (m2_language_data): Delete la_print_array_index
3474         initializer.
3475         * objc-lang.c (objc_language_data): Likewise.
3476         * opencl-lang.c (opencl_language_data): Likewise.
3477         * p-lang.c (pascal_language_data): Likewise.
3478         * rust-lang.c (rust_language_data): Likewise.
3479
3480 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * gdb/ada-lang.c (ada_language_defn): Convert to...
3483         (ada_language_data): ...this.
3484         (class ada_language): New class.
3485         (ada_language_defn): New static global.
3486         * gdb/c-lang.c (c_language_defn): Convert to...
3487         (c_language_data): ...this.
3488         (class c_language): New class.
3489         (c_language_defn): New static global.
3490         (cplus_language_defn): Convert to...
3491         (cplus_language_data): ...this.
3492         (class cplus_language): New class.
3493         (cplus_language_defn): New static global.
3494         (asm_language_defn): Convert to...
3495         (asm_language_data): ...this.
3496         (class asm_language): New class.
3497         (asm_language_defn): New static global.
3498         (minimal_language_defn): Convert to...
3499         (minimal_language_data): ...this.
3500         (class minimal_language): New class.
3501         (minimal_language_defn): New static global.
3502         * gdb/d-lang.c (d_language_defn): Convert to...
3503         (d_language_data): ...this.
3504         (class d_language): New class.
3505         (d_language_defn): New static global.
3506         * gdb/f-lang.c (f_language_defn): Convert to...
3507         (f_language_data): ...this.
3508         (class f_language): New class.
3509         (f_language_defn): New static global.
3510         * gdb/go-lang.c (go_language_defn): Convert to...
3511         (go_language_data): ...this.
3512         (class go_language): New class.
3513         (go_language_defn): New static global.
3514         * gdb/language.c (unknown_language_defn): Remove declaration.
3515         (current_language): Initialize to nullptr, real initialization is
3516         moved to _initialize_language.
3517         (languages): Delete global.
3518         (language_defn::languages): Define.
3519         (set_language_command): Use language_defn::languages.
3520         (set_language): Likewise.
3521         (range_error): Likewise.
3522         (language_enum): Likewise.
3523         (language_def): Likewise.
3524         (add_set_language_command): Use language_def::languages for the
3525         language list, and language_def to lookup language pointers.
3526         (skip_language_trampoline): Use language_defn::languages.
3527         (unknown_language_defn): Convert to...
3528         (unknown_language_data): ...this.
3529         (class unknown_language): New class.
3530         (unknown_language_defn): New static global.
3531         (auto_language_defn): Convert to...
3532         (auto_language_data): ...this.
3533         (class auto_language): New class.
3534         (auto_language_defn): New static global.
3535         (language_gdbarch_post_init): Use language_defn::languages.
3536         (_initialize_language): Initialize current_language.
3537         * gdb/language.h (struct language_defn): Rename to...
3538         (struct language_data): ...this.
3539         (struct language_defn): New.
3540         (auto_language_defn): Delete.
3541         (unknown_language_defn): Delete.
3542         (minimal_language_defn): Delete.
3543         (ada_language_defn): Delete.
3544         (asm_language_defn): Delete.
3545         (c_language_defn): Delete.
3546         (cplus_language_defn): Delete.
3547         (d_language_defn): Delete.
3548         (f_language_defn): Delete.
3549         (go_language_defn): Delete.
3550         (m2_language_defn): Delete.
3551         (objc_language_defn): Delete.
3552         (opencl_language_defn): Delete.
3553         (pascal_language_defn): Delete.
3554         (rust_language_defn): Delete.
3555         * gdb/m2-lang.c (m2_language_defn): Convert to...
3556         (m2_language_data): ...this.
3557         (class m2_language): New class.
3558         (m2_language_defn): New static global.
3559         * gdb/objc-lang.c (objc_language_defn): Convert to...
3560         (objc_language_data): ...this.
3561         (class objc_language): New class.
3562         (objc_language_defn): New static global.
3563         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
3564         (opencl_language_data): ...this.
3565         (class opencl_language): New class.
3566         (opencl_language_defn): New static global.
3567         * gdb/p-lang.c (pascal_language_defn): Convert to...
3568         (pascal_language_data): ...this.
3569         (class pascal_language): New class.
3570         (pascal_language_defn): New static global.
3571         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
3572         language pointer, update comment format.
3573         * gdb/rust-lang.c (rust_language_defn): Convert to...
3574         (rust_language_data): ...this.
3575         (class rust_language): New class.
3576         (rust_language_defn): New static global.
3577
3578 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
3581         member variable.
3582         <m_stmt_at_address>: New member variable.
3583         (lnp_state_machine::record_line): Don't record some lines, update
3584         tracking of is_stmt at the same address.
3585         (lnp_state_machine::lnp_state_machine): Initialise new member
3586         variables.
3587
3588 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3589
3590         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
3591         "-include gnu-nat-mig.h".
3592         * gnu-nat-mig.h: New file.
3593         * gnu-nat.c: Include "gnu-nat-mig.h".
3594         (exc_server, msg_reply_server, notify_server,
3595         process_reply_server): Remove declarations.
3596
3597 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3598
3599         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
3600         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
3601         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
3602         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
3603         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
3604         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
3605         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
3606         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
3607         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
3608         to gnu_nat_target class.
3609         * gnu-nat.c: Likewise.
3610         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
3611         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
3612         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
3613         object.
3614         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
3615         instead of `gnu_target'.
3616
3617 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3618
3619         * i386-gnu-tdep.c: Include "gdbcore.h"
3620         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
3621         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
3622         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
3623         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
3624         i386_gnu_sigcontext_addr): New functions
3625         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
3626         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
3627         tdep.
3628
3629 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3630
3631         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
3632         before fork_inferior call. Avoid calling it if target_is_pushed returns
3633         true.
3634
3635 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3636
3637         * gnu-nat.h (gnu_target): New variable declaration.
3638         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
3639         gnu_target.
3640         * gnu-nat.c (gnu_target): New variable.
3641         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
3642         add_thread_silent, and add_thread calls.
3643         (gnu_nat_target::create_inferior): Pass gnu_target to
3644         add_thread_silent, thread_change_ptid call.
3645         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
3646         call.
3647
3648 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3649
3650         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
3651         (gnu_nat_target::find_memory_regions): Remove unused
3652         `old_address' variable.
3653
3654 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3655
3656         * gnu-nat.c: Include "gdbarch.h".
3657
3658 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3659
3660         * reply_mig_hack.awk (Error return): Cast function through
3661         void *, to bypass compiler function call check.
3662
3663 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3664
3665         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
3666         $(srcdir)/reply_mig_hack.awk.
3667
3668 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3669
3670         * gnu-nat.h (gnu_debug_flag): Set type to bool.
3671
3672 2020-05-30  Jonny Grant  <jg@jguk.org>
3673
3674         * configure.ac (ACX_BUGURL): change bug URL to https.
3675
3676 2020-05-30  Pedro Alves  <palves@redhat.com>
3677
3678         * cp-support.c (replace_typedefs_template): New.
3679         (replace_typedefs_qualified_name): Handle
3680         DEMANGLE_COMPONENT_TEMPLATE.
3681
3682 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
3683
3684         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
3685         dwarf2/index-cache.h, dwarf2/index-write.c,
3686         dwarf2/index-write.h, dwarf2/line-header.c,
3687         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
3688         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
3689         variables and fields from `dwarf2_per_objfile` to just
3690         `per_objfile` throughout.
3691
3692 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
3693
3694         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3695         <push_dwarf_reg_entry_value>: Add comment.
3696
3697 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
3698             Keith Seitz  <keiths@redhat.com>
3699
3700         * python/python.c (do_start_initialization): Call PyEval_SaveThread
3701         instead of PyEval_ReleaseLock.
3702         (class gdbpy_gil): Move to earlier in file.
3703         (finalize_python): Set gdb_python_initialized.
3704         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
3705         when not initialized.
3706
3707 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
3708
3709         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3710         <push_dwarf_reg_entry_value>: Remove assert.  Override
3711         per_objfile with caller_per_objfile.
3712
3713 2020-05-28  Tom de Vries  <tdevries@suse.de>
3714
3715         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
3716         PR gold/15646 workaround to symbol kind "type".
3717
3718 2020-05-27  Tom Tromey  <tromey@adacore.com>
3719
3720         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
3721
3722 2020-05-27  Tom Tromey  <tromey@adacore.com>
3723
3724         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
3725         Use htab_find_with_hash.
3726         <add_abbrev>: Remove "abbrev_number" parameter.
3727         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
3728         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
3729         (hash_abbrev): Add comment.
3730         (abbrev_table::lookup_abbrev): Move to header file.
3731         (abbrev_table::read): Update.
3732
3733 2020-05-27  Tom Tromey  <tromey@adacore.com>
3734
3735         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
3736         method.
3737         <canonical_name>: New member.
3738         <raw_name>: Rename from "name".
3739         (partial_die_info): Initialize canonical_name.
3740         (scan_partial_symbols): Check raw_name.
3741         (partial_die_parent_scope, partial_die_full_name)
3742         (add_partial_symbol, add_partial_subprogram)
3743         (add_partial_enumeration, load_partial_dies): Use "name" method.
3744         (partial_die_info::name): New method.
3745         (partial_die_info::read, guess_partial_die_structure_name)
3746         (partial_die_info::fixup): Update.
3747
3748 2020-05-27  Tom Tromey  <tromey@adacore.com>
3749
3750         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
3751         <get_ref_die_offset>: Inline.
3752         <get_ref_die_offset_complaint>: New method.
3753         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
3754         (attribute::get_ref_die_offset_complaint): Rename from
3755         get_ref_die_offset.  Just issue complaint.
3756
3757 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3758
3759         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
3760
3761 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3762
3763         * exec.c (exec_file_attach): Use errno value of first openp failure.
3764
3765 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3766
3767         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
3768         Don't close thread handle.
3769
3770 2020-05-27  Tom Tromey  <tom@tromey.com>
3771             Simon Marchi  <simon.marchi@efficios.com>
3772
3773         * objfiles.h (struct objfile) <partial_symtabs>: Now a
3774         shared_ptr.
3775         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
3776         member.
3777         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
3778         dwarf2_per_bfd_objfile_data_key>: New globals.
3779         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
3780         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
3781         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
3782         shared.
3783         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
3784         short-circuit when sharing.
3785         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
3786         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
3787
3788 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3789
3790         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
3791         to...
3792         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
3793         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
3794
3795 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3796
3797         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
3798         build_name_components, find_name_components_bounds>:
3799         Add per_objfile parameter.
3800         (struct mapped_index) <symbol_name_at>: Likewise.
3801         (struct mapped_debug_names): Remove constructor.
3802         <dwarf2_per_objfile>: Remove field.
3803         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
3804         (mapped_index_base::find_name_components_bounds,
3805         mapped_index_base::build_name_components,
3806         dw2_expand_symtabs_matching_symbol): Likewise.
3807         (class mock_mapped_index) <symbol_name_at>: Likewise.
3808         (check_match): Likewise.
3809         (check_find_bounds_finds): Likewise.
3810         (test_mapped_index_find_name_component_bounds): Update.
3811         (CHECK_MATCH): Update.
3812         (dw2_expand_symtabs_matching): Update.
3813         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
3814         per_objfile parameter.
3815         <find_vec_in_debug_names>: Likewise.
3816         <m_per_objfile>: New field.
3817         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
3818         parameter.
3819         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
3820         (dw2_debug_names_iterator::next): Update.
3821         (dw2_debug_names_lookup_symbol): Update.
3822         (dw2_debug_names_expand_symtabs_for_function): Update.
3823         (dw2_debug_names_map_matching_symbols): Update.
3824         (dw2_debug_names_expand_symtabs_matching): Update.
3825         (dwarf2_read_debug_names): Update.
3826
3827 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3828
3829         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
3830         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
3831         move to dwarf2_per_objfile.
3832         <read_in_chain>: Remove.
3833         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
3834         remove_all_cus, age_comp_units>: New methods.
3835         <m_dwarf2_cus>: New member.
3836         (struct dwarf2_per_cu_data) <cu>: Remove.
3837         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
3838         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
3839         moved to methods of dwarf2_per_objfile.
3840         (dwarf2_clear_marks): Remove.
3841         (dwarf2_queue_item::~dwarf2_queue_item): Update.
3842         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
3843         (dwarf2_per_bfd::free_cached_comp_units): Remove.
3844         (dwarf2_per_objfile::remove_all_cus): New.
3845         (class free_cached_comp_units) <~free_cached_comp_units>:
3846         Update.
3847         (load_cu): Update.
3848         (dw2_do_instantiate_symtab): Adjust.
3849         (fill_in_sig_entry_from_dwo_entry): Adjust.
3850         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3851         (cutu_reader::cutu_reader): Likewise.
3852         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
3853         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
3854         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
3855         and dwarf2_per_objfile::age_comp_units.
3856         (load_partial_comp_unit): Update.
3857         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
3858         (process_queue): Likewise.
3859         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
3860         backlink.
3861         (dwarf2_read_addr_index): Likewise.
3862         (follow_die_offset): Likewise.
3863         (dwarf2_fetch_die_loc_sect_off): Likewise.
3864         (dwarf2_fetch_constant_bytes): Likewise.
3865         (dwarf2_fetch_die_type_sect_off): Likewise.
3866         (follow_die_sig_1): Likewise.
3867         (load_full_type_unit): Likewise.
3868         (read_signatured_type): Likewise.
3869         (dwarf2_cu::dwarf2_cu): Don't set cu field.
3870         (dwarf2_cu::~dwarf2_cu): Remove.
3871         (dwarf2_per_objfile::get_cu): New.
3872         (dwarf2_per_objfile::set_cu): New.
3873         (age_cached_comp_units): Rename to...
3874         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
3875         to std::unordered_map.
3876         (free_one_cached_comp_unit): Rename to...
3877         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
3878         to std::unordered_map.
3879         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
3880         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
3881         a dwarf2_per_objfile in data.
3882         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
3883         (dwarf2_clear_marks): Remove.
3884
3885 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3886
3887         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
3888         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
3889         (init_tu_and_read_dwo_dies): Likewise.
3890         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
3891         (cutu_reader::cutu_reader): Likewise.
3892         (load_partial_comp_unit): Likewise.
3893         (process_psymtab_comp_unit): Update.
3894         (build_type_psymtabs_1): Update.
3895         (process_skeletonless_type_unit): Update.
3896         (load_full_comp_unit): Update.
3897         (find_partial_die): Update.
3898         (dwarf2_read_addr_index): Update.
3899         (read_signatured_type): Update.
3900
3901 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3902
3903         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
3904         m_header_read_in>: New fields.
3905         <get_header>: New method.
3906         * dwarf2/read.c (per_cu_header_read_in): Remove.
3907         (dwarf2_per_cu_data::get_header): New.
3908         (dwarf2_per_cu_data::addr_size): Update.
3909         (dwarf2_per_cu_data::offset_size): Update.
3910         (dwarf2_per_cu_data::ref_addr_size): Update.
3911
3912 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3913
3914         * dwarf2/read.c (load_cu): Return dwarf2_cu.
3915         (dw2_do_instantiate_symtab): Update.
3916         (queue_and_load_all_dwo_tus): Change parameter from
3917         dwarf2_per_cu_data to dwarf2_cu.
3918         (dwarf2_fetch_die_loc_sect_off): Update.
3919         (dwarf2_fetch_constant_bytes): Update.
3920         (dwarf2_fetch_die_type_sect_off): Update.
3921
3922 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3923
3924         * dwarf2/read.c (process_full_comp_unit,
3925         process_full_type_unit): Remove per_cu, per_objfile paramters.
3926         Add dwarf2_cu parameter.
3927         (process_queue): Update.
3928
3929 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3930
3931         * dwarf2/read.c (create_cu_from_index_list): Replace
3932         dwarf2_per_objfile parameter with dwarf2_per_bfd.
3933         (create_cus_from_index_list): Likewise.
3934         (create_cus_from_index): Likewise.
3935         (create_signatured_type_table_from_index): Likewise.
3936         (create_cus_from_debug_names_list): Likewise.
3937         (create_cus_from_debug_names): Likewise.
3938         (dwarf2_read_gdb_index): Update.
3939         (dwarf2_read_debug_names): Update.
3940
3941 2020-05-27  Tom Tromey  <tom@tromey.com>
3942             Simon Marchi  <simon.marchi@efficios.com>
3943
3944         * dwarf2/read.h (struct dwarf2_per_objfile)
3945         <get_type_for_signatured_type, set_type_for_signatured_type>:
3946         New methods.
3947         <m_type_map>: New member.
3948         (struct signatured_type) <type>: Remove.
3949         * dwarf2/read.c
3950         (dwarf2_per_objfile::get_type_for_signatured_type,
3951         dwarf2_per_objfile::set_type_for_signatured_type): New.
3952         (get_signatured_type): Use new methods.
3953
3954 2020-05-27  Tom Tromey  <tom@tromey.com>
3955             Simon Marchi  <simon.marchi@efficios.com>
3956
3957         * dwarf2/read.h (struct type_unit_group_unshareable): New.
3958         (struct dwarf2_per_objfile) <type_units>: New member.
3959         <get_type_unit_group_unshareable>: New method.
3960         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
3961         num_symtabs, symtabs>: Remove; move to
3962         type_unit_group_unshareable.
3963         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
3964         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
3965         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
3966
3967 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3968
3969         * dwarf2/read.h (struct dwarf2_per_cu_data):
3970         <dwarf2_per_objfile>: Remove.
3971         * dwarf2/read.c (create_cu_from_index_list): Don't assign
3972         dwarf2_per_objfile.
3973         (create_signatured_type_table_from_index): Likewise.
3974         (create_signatured_type_table_from_debug_names): Likewise.
3975         (create_debug_type_hash_table): Likewise.
3976         (fill_in_sig_entry_from_dwo_entry): Likewise.
3977         (create_type_unit_group): Likewise.
3978         (read_comp_units_from_section): Likewise.
3979         (create_cus_hash_table): Likewise.
3980
3981 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3982
3983         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
3984         dwarf2_per_cu_data::dwarf2_per_objfile.
3985         (compute_compunit_symtab_includes): Likewise.
3986         (dwarf2_cu::start_symtab): Likewise.
3987
3988 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3989
3990         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
3991         parameter.
3992         * dwarf2/read.c (get_die_type_at_offset): Likewise.
3993         (read_namespace_alias): Update.
3994         (lookup_die_type): Update.
3995         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
3996         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
3997         Update.
3998         (disassemble_dwarf_expression): Update.
3999
4000 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4001
4002         * dwarf2/read.h (struct dwarf2_queue_item): Add
4003         dwarf2_per_objfile parameter, assign new parameter.
4004         <per_objfile>: New field.
4005         * dwarf2/read.c (free_one_cached_comp_unit): Add
4006         dwarf2_per_objfile parameter.
4007         (queue_comp_unit): Likewise.
4008         (dw2_do_instantiate_symtab): Update.
4009         (process_psymtab_comp_unit): Update.
4010         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
4011         (process_imported_unit_die): Update.
4012         (queue_and_load_dwo_tu): Update.
4013         (follow_die_offset): Update.
4014         (follow_die_sig_1): Update.
4015
4016 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4017
4018         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
4019         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
4020         (read_call_site_scope): Assign per_objfile.
4021         (dwarf2_per_cu_data::objfile): Remove.
4022         * gdbtypes.h (struct call_site) <per_objfile>: New member.
4023         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
4024         dwarf2_per_objfile parameter.
4025         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
4026         dwarf2_per_objfile parameter.
4027         (dwarf_expr_reg_to_entry_parameter): Add output
4028         dwarf2_per_objfile parameter.
4029         (locexpr_get_frame_base): Update.
4030         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
4031         <push_dwarf_reg_entry_value>: Update.
4032         <call_site_to_target_addr>: Update.
4033         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
4034         parameter.
4035         (value_of_dwarf_reg_entry): Update.
4036         (rw_pieced_value): Update.
4037         (indirect_synthetic_pointer): Update.
4038         (dwarf2_evaluate_property): Update.
4039         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
4040         parameter.
4041         (locexpr_read_variable): Update.
4042         (locexpr_get_symbol_read_needs): Update.
4043         (loclist_read_variable): Update.
4044
4045 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4046
4047         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
4048         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4049         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
4050         parameter.
4051         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
4052         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4053         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
4054         parameter.
4055         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
4056         sect_variable_value): Add dwarf2_per_objfile parameter.
4057         (class dwarf_evaluate_loc_desc) <dwarf_call,
4058         dwarf_variable_value>: Update.
4059         (fetch_const_value_from_synthetic_pointer): Add
4060         dwarf2_per_objfile parameter.
4061         (fetch_const_value_from_synthetic_pointer): Update.
4062         (coerced_pieced_ref): Update.
4063         (class symbol_needs_eval_context) <dwarf_call,
4064         dwarf_variable_value>: Update.
4065         (dwarf2_compile_expr_to_ax): Update.
4066
4067 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4068
4069         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
4070         parameter.
4071         (dwarf2_evaluate_loc_desc_full): Update.
4072
4073 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4074
4075         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
4076         parameter.
4077         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
4078         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
4079         dwarf2_per_objfile parameter.
4080         (decode_debug_loc_dwo_addresses): Likewise.
4081         (dwarf2_find_location_expression): Update.
4082         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
4083         (locexpr_describe_location_piece): Add dwarf2_per_objfile
4084         parameter.
4085         (disassemble_dwarf_expression): Add dwarf2_per_objfile
4086         parameter.
4087         (locexpr_describe_location_1): Likewise.
4088         (locexpr_describe_location): Update.
4089
4090 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4091
4092         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
4093         Remove.
4094         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
4095         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
4096         (dwarf2_compile_property_to_c): Update.
4097         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
4098         use text offset from objfile.
4099         (locexpr_tracepoint_var_ref): Update.
4100         (locexpr_generate_c_location): Update.
4101         (loclist_describe_location): Update.
4102         (loclist_tracepoint_var_ref): Update.
4103         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
4104         dwarf2_per_objfile parameter.
4105         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
4106         use text offset from objfile.
4107         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
4108
4109 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4110
4111         * dwarf2/expr.h (struct dwarf_expr_context)
4112         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
4113         <offset>: Remove.
4114         <per_objfile>: New member.
4115         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
4116         dwarf2_per_objfile parameter.  Don't set offset, set
4117         per_objfile.
4118         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
4119         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
4120         a dwarf2_per_objfile object instead of an offset.
4121         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
4122         constructor.
4123         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
4124         to dwarf2_expr_executor constructor.  Don't set offset.
4125         (dwarf2_fetch_cfa_info): Update.
4126         (struct dwarf2_frame_cache) <text_offset>: Remove.
4127         <per_objfile>: New field.
4128         (dwarf2_frame_cache): Update.
4129         (dwarf2_frame_prev_register): Update.
4130         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
4131         <dwarf_evaluate_loc_desc>: Add constructor.
4132         (dwarf2_evaluate_loc_desc_full): Update.
4133         (dwarf2_locexpr_baton_eval): Update.
4134         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
4135         Add constructor.
4136         (dwarf2_loc_desc_get_symbol_read_needs): Update.
4137
4138 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4139
4140         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
4141         addr_sized_int_type>: Move to dwarf2_cu.
4142         <int_type>: Move to dwarf2_per_objfile.
4143         (struct dwarf2_per_objfile) <int_type>: Move here.
4144         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
4145         addr_sized_int_type>: Move here.
4146         (read_func_scope): Update.
4147         (read_array_type): Update.
4148         (read_tag_string_type): Update.
4149         (attr_to_dynamic_prop): Update.
4150         (dwarf2_per_cu_data::int_type): Rename to...
4151         (dwarf2_per_objfile::int_type): ... this.
4152         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
4153         (dwarf2_cu::addr_sized_int_type): ... this.
4154         (read_subrange_type): Update.
4155         (dwarf2_per_cu_data::addr_type): Rename to...
4156         (dwarf2_cu::addr_type): ... this.
4157         (set_die_type): Update.
4158
4159 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4160
4161         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
4162         data through per_cu->cu.
4163
4164 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4165
4166         * dwarf2/read.c (lookup_dwo_comp_unit): Change
4167         dwarf2_per_cu_data parameter fo dwarf2_cu.
4168         (lookup_dwo_type_unit): Likewise.
4169         (read_cutu_die_from_dwo): Likewise.
4170         (lookup_dwo_unit): Likewise.
4171         (open_and_init_dwo_file): Likewise.
4172         (lookup_dwo_cutu): Likewise.
4173         (lookup_dwo_comp_unit): Likewise.
4174         (lookup_dwo_type_unit): Likewise.
4175         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4176         (cutu_reader::cutu_reader): Update.
4177
4178 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4179
4180         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
4181         parameter.
4182         (process_full_type_unit): Likewise.
4183         (process_queue): Update.
4184
4185 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4186
4187         * dwarf2/read.c (recursively_compute_inclusions): Add
4188         dwarf2_per_objfile parameter.
4189         (compute_compunit_symtab_includes): Likewise.
4190         (process_cu_includes): Update.
4191
4192 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4193
4194         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
4195         parameter.
4196         (create_type_unit_group): Update.
4197         (process_psymtab_comp_unit_reader): Update.
4198         (build_type_psymtabs_reader): Update.
4199
4200 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4201
4202         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
4203         object through m_this_cu->cu.
4204
4205 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4206
4207         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
4208         the info parameter.
4209         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
4210
4211 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4212
4213         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
4214         per_objfile parameter.
4215         (load_full_type_unit): Add per_objfile parameter.
4216         (read_signatured_type): Likewise.
4217         (load_full_comp_unit): Likewise.
4218         (load_cu): Likewise.
4219         (dw2_do_instantiate_symtab): Likewise.
4220         (dw2_get_file_names): Likewise.
4221         (dw2_map_symtabs_matching_filename): Update.
4222         (dw_expand_symtabs_matching_file_matcher): Update.
4223         (dw2_map_symbol_filenames): Update.
4224         (process_psymtab_comp_unit): Add per_objfile parameter.
4225         (build_type_psymtabs_1): Update.
4226         (process_skeletonless_type_unit): Update.
4227         (dwarf2_build_psymtabs_hard): Update.
4228         (load_partial_comp_unit): Add per_objfile parameter.
4229         (scan_partial_symbols): Update.
4230         (load_full_comp_unit): Add per_objfile parameter.
4231         (process_imported_unit_die): Update.
4232         (create_cus_hash_table): Update.
4233         (find_partial_die): Update.
4234         (dwarf2_read_addr_index): Update.
4235         (follow_die_offset): Update.
4236         (dwarf2_fetch_die_loc_sect_off): Update.
4237         (dwarf2_fetch_constant_bytes): Update.
4238         (dwarf2_fetch_die_type_sect_off): Update.
4239         (follow_die_sig_1): Update.
4240         (load_full_type_unit): Add per_objfile parameter.
4241         (read_signatured_type): Likewise.
4242
4243 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4244
4245         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
4246         of objfile_name.
4247
4248 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4249
4250         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
4251         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
4252         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
4253         field.
4254         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
4255         (create_cus_from_index): Update.
4256         (dwarf2_read_gdb_index): Update.
4257         (create_cus_from_debug_names): Update.
4258         (dwarf2_read_debug_names): Update.
4259         (get_abbrev_section_for_cu): Update.
4260         (create_all_comp_units): Update.
4261         (read_attribute_value): Update.
4262         (get_debug_line_section): Update.
4263         * dwarf2/index-cache.c (index_cache::store): Update.
4264         * dwarf2/index-write.c (save_gdb_index_command): Update.
4265         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
4266
4267 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4268
4269         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
4270         member.
4271         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
4272         dwarf2_per_cu_data::per_bfd.
4273         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
4274         (create_type_unit_group): Likewise.
4275         (queue_comp_unit): Remove reference to
4276         per_cu->dwarf2_per_objfile.
4277         (maybe_queue_comp_unit): Likewise.
4278         (fill_in_sig_entry_from_dwo_entry): Assign new field.
4279         (create_cus_hash_table): Assign new field.
4280
4281 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4282
4283         * dwarf2/read.c: Replace
4284         dwarf2_cu->per_cu->dwarf2_per_objfile references with
4285         dwarf2_cu->per_objfile throughout.
4286
4287 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4288
4289         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
4290         parameter, don't use per_cu->dwarf2_per_objfile.
4291         (dw2_instantiate_symtab): Likewise.
4292         (dw2_find_last_source_symtab): Update.
4293         (dw2_map_expand_apply): Update.
4294         (dw2_lookup_symbol): Update.
4295         (dw2_expand_symtabs_for_function): Update.
4296         (dw2_expand_all_symtabs): Update.
4297         (dw2_expand_symtabs_with_fullname): Update.
4298         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
4299         don't use per_cu->dwarf2_per_objfile.
4300         (dw2_expand_marked_cus): Update.
4301         (dw2_find_pc_sect_compunit_symtab): Update.
4302         (dw2_debug_names_lookup_symbol): Update.
4303         (dw2_debug_names_expand_symtabs_for_function): Update.
4304         (dw2_debug_names_map_matching_symbols): Update.
4305         (dwarf2_psymtab::expand_psymtab): Update.
4306
4307 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4308
4309         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
4310         <per_objfile>: New member.
4311         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
4312         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
4313         call to dwarf2_cu.
4314         (cutu_reader::cutu_reader): Update.
4315         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
4316
4317 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4318
4319         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
4320         struct dwarf2_per_objfile.
4321         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
4322         dwarf2_per_bfd.
4323         * dwarf2/read.c (set_die_type): Update.
4324         (get_die_type_at_offset): Update.
4325
4326 2020-05-27  Tom Tromey  <tom@tromey.com>
4327             Simon Marchi  <simon.marchi@efficios.com>
4328
4329         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
4330         method.
4331         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
4332         get_symtab, set_symtab>: New methods.
4333         <m_symtabs>: New field.
4334         (struct dwarf2_psymtab): Derive from partial_symtab.
4335         <readin_p, get_compunit_symtab>: Declare methods.
4336         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
4337         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
4338         New methods.
4339         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
4340         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
4341         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
4342         (dw2_symtab_iter_next, dw2_print_stats)
4343         (dw2_expand_symtabs_with_fullname)
4344         (dw2_expand_symtabs_matching_one)
4345         (dw_expand_symtabs_matching_file_matcher)
4346         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
4347         (dw2_debug_names_iterator::next)
4348         (dw2_debug_names_map_matching_symbols)
4349         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
4350         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
4351         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
4352         New methods.
4353         (get_compunit_symtab, process_full_comp_unit)
4354         (process_full_type_unit): Update.
4355         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
4356
4357 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4358
4359         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
4360         then introduce a new dwarf2_per_objfile type.
4361         <read_line_string>: Move to the new dwarf2_per_objfile type.
4362         <objfile>: Likewise.
4363         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
4364         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
4365         dwarf2_per_objfile->per_bfd.
4366         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
4367         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
4368         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
4369         (dwarf2_per_bfd::free_cached_comp_units): ... this.
4370         (dwarf2_has_info): Allocate dwarf2_per_bfd.
4371         (dwarf2_per_objfile::locate_sections): Rename to...
4372         (dwarf2_per_bfd::locate_sections): ... this.
4373         (dwarf2_per_objfile::get_cutu): Rename to...
4374         (dwarf2_per_bfd::get_cutu): ... this.
4375         (dwarf2_per_objfile::get_cu): Rename to...
4376         (dwarf2_per_bfd::get_cu): ... this.
4377         (dwarf2_per_objfile::get_tu): Rename to...
4378         (dwarf2_per_bfd::get_tu): ... this.
4379         (dwarf2_per_objfile::allocate_per_cu): Rename to...
4380         (dwarf2_per_bfd::allocate_per_cu): ... this.
4381         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
4382         (dwarf2_per_bfd::allocate_signatured_type): ... this.
4383         (get_gdb_index_contents_ftype): Change parameter from
4384         dwarf2_per_objfile to dwarf2_per_bfd.
4385         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
4386         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
4387
4388 2020-05-27  Tom Tromey  <tom@tromey.com>
4389             Simon Marchi  <simon.marchi@efficios.com>
4390
4391         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
4392         (allocate_piece_closure): Set "per_objfile" member.
4393         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
4394         (locexpr_describe_location, loclist_describe_location): Use new
4395         member.
4396         * dwarf2/read.c (read_call_site_scope)
4397         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
4398         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
4399         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
4400         handle_data_member_location): Set per_objfile member.
4401         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
4402         member.
4403         (struct dwarf2_loclist_baton) <per_objfile>: New member.
4404
4405 2020-05-27  Tom Tromey  <tom@tromey.com>
4406
4407         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
4408         allocate_signatured_type>: Declare new methods.
4409         <m_num_psymtabs>: New member.
4410         (struct dwarf2_per_cu_data) <index>: New member.
4411         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
4412         (dwarf2_per_objfile::allocate_signatured_type): New methods.
4413         (create_cu_from_index_list): Use allocate_per_cu.
4414         (create_signatured_type_table_from_index)
4415         (create_signatured_type_table_from_debug_names)
4416         (create_debug_type_hash_table, add_type_unit)
4417         (read_comp_units_from_section): Use allocate_signatured_type.
4418
4419 2020-05-27  Tom Tromey  <tom@tromey.com>
4420
4421         * psymtab.c (partial_map_expand_apply)
4422         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4423         (psym_lookup_global_symbol_language)
4424         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4425         (psym_print_stats, psym_expand_symtabs_for_function)
4426         (psym_map_symbol_filenames, psym_map_matching_symbols)
4427         (psym_expand_symtabs_matching)
4428         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4429         (maintenance_check_psymtabs): Update.
4430         * psympriv.h (struct partial_symtab) <readin_p,
4431         get_compunit_symtab>: Add objfile parameter.
4432         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
4433         Likewise.
4434         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
4435         get_compunit_symtab>: Likewise.
4436         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
4437
4438 2020-05-27  Tom Tromey  <tom@tromey.com>
4439
4440         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
4441         member.
4442         * dwarf2/read.c (delete_file_name_entry): Fix comment.
4443         (create_cu_from_index_list)
4444         (create_signatured_type_table_from_index)
4445         (create_signatured_type_table_from_debug_names)
4446         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
4447         (dwarf2_create_include_psymtab)
4448         (create_debug_type_hash_table, add_type_unit)
4449         (create_type_unit_group, read_comp_units_from_section)
4450         (dwarf2_compute_name, create_cus_hash_table)
4451         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4452         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
4453         obstack.
4454         (dw2_get_real_path): Likewise.  Change argument to
4455         dwarf2_per_objfile.
4456
4457 2020-05-27  Luis Machado  <luis.machado@linaro.org>
4458
4459         PR tdep/26000
4460         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
4461         for ldrd (immediate).
4462
4463 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4464
4465         * command.h: Add comment giving the name of class_tui.
4466         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
4467         create the fake command for the help for class_tui.
4468
4469 2020-05-26  Tom Tromey  <tromey@adacore.com>
4470
4471         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
4472         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
4473         (val_atr): New function.
4474         (value_val_atr): Use it.
4475         * ada-valprint.c (print_optional_low_bound): Change low bound
4476         handling for enums.
4477         (val_print_packed_array_elements): Don't call discrete_position.
4478         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
4479         discrete_position for enum types.
4480         * language.c (default_print_array_index): Change type.
4481         * language.h (struct language_defn) <la_print_array_index>: Add
4482         index_type parameter, change type of index_value.
4483         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
4484         (default_print_array_index): Update.
4485         * valprint.c (maybe_print_array_index): Don't call
4486         value_from_longest.  Update.
4487         (value_print_array_elements): Don't call discrete_position.
4488
4489 2020-05-26  Tom Tromey  <tromey@adacore.com>
4490
4491         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
4492         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
4493
4494 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
4495
4496         PR gdb/13519
4497         * avr-tdep.c (avr_integer_to_address): Return data or code
4498         address accordingly to the second 'type' argument of the
4499         function.
4500
4501 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
4502
4503         * infcmd.c, inferior.h: (construct_inferior_arguments):
4504         Moved function from here to gdbsupport/common-inferior.{h,cc}
4505
4506 2020-05-23  Tom Tromey  <tom@tromey.com>
4507
4508         Revert commit eca1f90c:
4509         * NEWS: Remove entry for completion styling.
4510         * completer.c (_rl_completion_prefix_display_length): Move
4511         declaration later.
4512         (gdb_fnprint): Revert.
4513         (gdb_display_match_list_1): Likewise.
4514         * cli/cli-style.c (completion_prefix_style)
4515         (completion_difference_style, completion_suffix_style): Remove.
4516         (_initialize_cli_style): Revert.
4517         * cli/cli-style.h (completion_prefix_style)
4518         (completion_difference_style, completion_suffix_style): Don't
4519         declare.
4520
4521 2020-05-24  Pedro Alves  <palves@redhat.com>
4522
4523         * symtab.c (completion_list_add_name): Return boolean indication
4524         of whether the symbol matched.
4525         (completion_list_add_symbol): Don't try to remove C++ aliases if
4526         the symbol didn't match in the first place.
4527         * symtab.h (completion_list_add_name): Return bool.
4528
4529 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
4530
4531         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
4532         type::field.
4533
4534 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
4535
4536         GDB 9.2 released.
4537
4538 2020-05-23  Tom Tromey  <tom@tromey.com>
4539
4540         * NEWS: Add entry for completion styling.
4541         * completer.c (_rl_completion_prefix_display_length): Move
4542         declaration earlier.
4543         (gdb_fnprint): Use completion_style.
4544         (gdb_display_match_list_1): Likewise.
4545         * cli/cli-style.c (completion_prefix_style)
4546         (completion_difference_style, completion_suffix_style): New
4547         globals.
4548         (_initialize_cli_style): Register new globals.
4549         * cli/cli-style.h (completion_prefix_style)
4550         (completion_difference_style, completion_suffix_style): Declare.
4551
4552 2020-05-23  Pedro Alves  <palves@redhat.com>
4553
4554         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
4555         (parse_escape): Use ISDIGIT instead of isdigit.
4556         (puts_debug): Use gdb_isprint instead of isprint.
4557         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
4558         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
4559         ISSPACE instead of isspace.
4560         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
4561         instead of isspace.
4562         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
4563         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
4564         instead of isxdigit and ISDIGIT instead of isdigit.
4565
4566 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4567
4568         * gdbtypes.h (struct type) <field>: New method.
4569         (TYPE_FIELDS): Remove, replace all uses with either type::fields
4570         or type::field.
4571
4572 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4573
4574         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
4575         (TYPE_FIELDS): Use type::fields.  Change all call sites that
4576         modify the propery to use type::set_fields instead.
4577
4578 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4579
4580         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
4581         type::num_fields instead.
4582
4583 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4584
4585         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
4586         methods.
4587         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
4588         that modify the number of fields to use type::set_num_fields
4589         instead.
4590
4591 2020-05-22  Tom Tromey  <tromey@adacore.com>
4592
4593         * compile/compile-object-load.h (munmap_list_free): Don't
4594         declare.
4595
4596 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * annotate.c (annotate_source_line): Update return type, add call
4599         to update current symtab and line.
4600         * annotate.h (annotate_source_line): Update return type, and
4601         extend header comment.
4602         * source.c (info_line_command): Check annotation_level before
4603         calling annotate_source_line.
4604         * stack.c (print_frame_info): If calling annotate_source_line
4605         returns true, then don't print any other source line information.
4606
4607 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4608
4609         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
4610
4611 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4612
4613         * coffread.c (patch_type): Remove NULL check before xfree.
4614         * corefile.c (set_gnutarget): Likewise.
4615         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
4616         * exec.c (build_section_table): Likewise.
4617         * remote.c (remote_target::pass_signals): Likewise.
4618         * utils.c (n_spaces): Likewise.
4619         * cli/cli-script.c (document_command): Likewise.
4620         * i386-windows-tdep.c (core_process_module_section): Likewise.
4621         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
4622
4623 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
4624
4625         * symfile.c (reread_symbols): Clear objfile's section_offsets
4626         vector and section indices, re-compute them by calling
4627         sym_offsets.
4628
4629 2020-05-20  Tom Tromey  <tromey@adacore.com>
4630
4631         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
4632         (desc_one_bound, desc_index_type): Compute field name.
4633
4634 2020-05-20  Tom de Vries  <tdevries@suse.de>
4635
4636         PR symtab/25833
4637         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
4638
4639 2020-05-20  Alan Modra  <amodra@gmail.com>
4640
4641         PR 25993
4642         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
4643         bfd_set_filename.
4644         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
4645         passed to bfd_set_filename.
4646         * symfile-mem.c (add_vsyscall_page): Likewise for string
4647         passed to symbol_file_add_from_memory.
4648         (symbol_file_add_from_memory): Make name param a const char* and
4649         don't strdup.
4650
4651 2020-05-20  Alan Modra  <amodra@gmail.com>
4652
4653         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
4654         rather than accessing bfd->filename directly.
4655         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
4656         and use bfd_section_name.
4657         * dwarf2/frame.c (decode_frame_entry): Likewise.
4658         * exec.c (exec_set_section_address): Likewise.
4659         * solib-aix.c (solib_aix_bfd_open): Likewise.
4660         * stap-probe.c (get_stap_base_address): Likewise.
4661         * symfile.c (reread_symbols): Likewise.
4662
4663 2020-05-19  Tom Tromey  <tromey@adacore.com>
4664
4665         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
4666
4667 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4668
4669         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
4670
4671 2020-05-19  Pedro Alves  <palves@redhat.com>
4672
4673         * NEWS (set exec-file-mismatch): Adjust entry.
4674         * exec.c: Include "build-id.h".
4675         (validate_exec_file): Try to match build IDs instead of filenames.
4676         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
4677         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
4678         and pass down 'warn_if_slow'.
4679         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
4680         gdb_bfd_open_closure to pass it down.
4681         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
4682
4683 2020-05-19  Pedro Alves  <palves@redhat.com>
4684
4685         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
4686         * target.c (target_fileio_open_1): Rename to target_fileio_open
4687         and make extern.  Use bool.
4688         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
4689         (target_fileio_read_alloc_1): Adjust.
4690         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
4691         (target_fileio_open_warn_if_slow): Delete declaration.
4692
4693 2020-05-19  Pedro Alves  <palves@redhat.com>
4694
4695         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
4696         Adjust all callers.
4697
4698 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
4699
4700         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
4701         whether disp is negative.
4702
4703 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4704
4705         * symfile.h (struct symfile_segment_data)
4706         <~symfile_segment_data>: Remove.
4707         <segment_info>: Change to std::vector.
4708         * symfile.c (default_symfile_segments): Update.
4709         * elfread.c (elf_symfile_segments): Update.
4710
4711 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4712
4713         * symfile.h (struct symfile_segment_data) <struct segment>: New.
4714         <segments>: New.
4715         <segment_bases, segment_sizes>: Remove.
4716         * symfile.c (default_symfile_segments): Update.
4717         * elfread.c (elf_symfile_segments): Update.
4718         * remote.c (remote_target::get_offsets): Update.
4719         * solib-target.c (solib_target_relocate_section_addresses):
4720         Update.
4721
4722 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4723
4724         * symfile.h (struct symfile_segment_data): Initialize fields.
4725         <~symfile_segment_data>: Add.
4726         (symfile_segment_data_up): New.
4727         (struct sym_fns) <sym_segments>: Return a
4728         symfile_segment_data_up.
4729         (default_symfile_segments): Return a symfile_segment_data_up.
4730         (free_symfile_segment_data): Remove.
4731         (get_symfile_segment_data): Return a symfile_segment_data_up.
4732         * symfile.c (default_symfile_segments): Likewise.
4733         (get_symfile_segment_data): Likewise.
4734         (free_symfile_segment_data): Remove.
4735         (symfile_find_segment_sections): Update.
4736         * elfread.c (elf_symfile_segments): Return a
4737         symfile_segment_data_up.
4738         * remote.c (remote_target::get_offsets): Update.
4739         * solib-target.c (solib_target_relocate_section_addresses):
4740         Update.
4741         * symfile-debug.c (debug_sym_segments): Return a
4742         symfile_segment_data_up.
4743
4744 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4745
4746         PR build/25981
4747         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
4748         Hardcode register numbers.
4749
4750         PR build/25981
4751         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
4752         procfs_find_LDT_entry): Remove.
4753         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
4754         procfs_find_LDT_entry): Remove.
4755         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
4756         Remove.
4757
4758 2020-05-17  Pedro Alves  <palves@redhat.com>
4759             Andrew Burgess  <andrew.burgess@embecosm.com>
4760             Keno Fischer  <keno@juliacomputing.com>
4761
4762         PR gdb/25741
4763         * breakpoint.c (build_target_condition_list): Update comments.
4764         (build_target_command_list): Update comments and skip matching
4765         locations.
4766         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
4767         a separate function.  Simplify "set breakpoint auto-hw off"
4768         handling.
4769         (insert_breakpoints): Update comment.
4770         (tracepoint_locations_match): New parameter.  For breakpoints,
4771         compare location types too, if the caller wants to.
4772         (handle_automatic_hardware_breakpoints): New functions.
4773         (bp_location_is_less_than): Also sort by location type and
4774         hardware breakpoint length.
4775         (update_global_location_list): Handle "set breakpoint auto-hw on"
4776         here.
4777         (update_breakpoint_locations): Ask breakpoint_locations_match to
4778         ignore location types.
4779
4780 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4781
4782         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
4783         type::name instead.
4784
4785 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4786
4787         * gdbtypes.h (struct type) <name, set_name>: New methods.
4788         (TYPE_CODE): Use type::name.  Change all call sites used to set
4789         the name to use type::set_name instead.
4790
4791 2020-05-16  Tom Tromey  <tom@tromey.com>
4792
4793         * top.c (quit_force): Update.
4794         * infrun.c (handle_no_resumed): Update.
4795         * top.h (all_uis): New function.
4796         (ALL_UIS): Remove.
4797
4798 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4799
4800         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
4801
4802 2020-05-16  Pedro Alves  <palves@redhat.com>
4803
4804         * ia64-linux-nat.c
4805         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
4806         Declare method.
4807         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
4808
4809 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
4810
4811         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
4812         (sparc64_adi_info): Likewise.
4813
4814 2020-05-15  Tom Tromey  <tom@tromey.com>
4815
4816         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
4817         block_objfile.
4818         (lookup_objfile_from_block): Remove.
4819         (lookup_symbol_in_block, lookup_symbol_in_static_block)
4820         (lookup_global_symbol): Use block_objfile.
4821         * symtab.h (lookup_objfile_from_block): Don't declare.
4822         * printcmd.c (clear_dangling_display_expressions): Use
4823         block_objfile.
4824         * parse.c (operator_check_standard): Use block_objfile.
4825
4826 2020-05-15  Tom Tromey  <tom@tromey.com>
4827
4828         * language.c (language_alloc_type_symbol): Set
4829         SYMBOL_SECTION.
4830         * symtab.c (initialize_objfile_symbol): Remove.
4831         (allocate_symbol): Remove.
4832         (allocate_template_symbol): Remove.
4833         * dwarf2/read.c (fixup_go_packaging): Use "new".
4834         (new_symbol): Use "new".
4835         (read_variable): Don't call initialize_objfile_symbol.  Use
4836         "new".
4837         (read_func_scope): Use "new".
4838         * xcoffread.c (process_xcoff_symbol): Don't call
4839         initialize_objfile_symbol.
4840         (SYMBOL_DUP): Remove.
4841         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
4842         "new".
4843         * symtab.h (allocate_symbol, initialize_objfile_symbol)
4844         (allocate_template_symbol): Don't declare.
4845         (struct symbol): Add copy constructor.  Change defaults.
4846         * jit.c (finalize_symtab): Use "new".
4847         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
4848         Use "new".
4849         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
4850         (common_block_end): Use "new".
4851         * mdebugread.c (parse_symbol): Use "new".
4852         (new_symbol): Likewise.
4853
4854 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4855
4856         * NEWS: Mention changes to help and apropos.
4857
4858 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4859
4860         * command.h (enum command_class): Improve comments, document
4861         that class_alias is for user-defined aliases, give the class
4862         name for each class, remove unused class_xdb.
4863         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
4864         * breakpoint.c (_initialize_breakpoint): Replace class_alias
4865         by a precise class.
4866         * infcmd.c (_initialize_infcmd): Likewise.
4867         * reverse.c (_initialize_reverse): Likewise.
4868         * stack.c (_initialize_stack): Likewise.
4869         * symfile.c (_initialize_symfile): Likewise.
4870         * tracepoint.c (_initialize_tracepoint): Likewise.
4871
4872 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4873
4874         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
4875         when their aliased command is traversed.
4876         (help_cmd): Add fput_command_names_styled call to
4877         output command name and aliases when command has an alias.
4878
4879 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4880
4881         * cli/cli-decode.h (help_cmd_list): Remove declaration.
4882         * cli/cli-decode.c (help_cmd_list): Declare as static,
4883         remove prefix argument, use bool for recurse arg, rework to show the aliases of
4884         a command together with the command.
4885         (fput_command_name_styled, fput_command_names_styled): New functions.
4886         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
4887         fput_command_name_styled.
4888         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
4889         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
4890
4891 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4892
4893         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
4894         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
4895         * command.h (cmd_show_list): Likewise.
4896         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
4897         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
4898
4899 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4900
4901         * unittests/command-def-selftests.c (traverse_command_structure):
4902         Verify all commands of a list have the same prefix command and
4903         that only the top cmdlist commands have a null prefix.
4904
4905 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4906
4907         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
4908         as prefix, not one of its aliases.
4909         (set_cmd_prefix): Remove.
4910         (do_add_cmd): Centralize the setting of the prefix of a command, when
4911         command is defined after its full chain of prefix commands.
4912         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
4913         (add_setshow_cmd_full): Likewise.
4914         (update_prefix_field_of_prefixed_commands): New function.
4915         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
4916         update_prefix_field_of_prefixed_commands.
4917         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
4918         addresses of remote_set_cmdlist and remote_show_cmdlist given
4919         as argument, not the address of an argument.
4920         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
4921         * gdb/remote.c (_initialize_remote): Likewise.
4922
4923 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4924
4925         * cli/cli-cmds.c (alias_command): Check for an existing alias
4926         using lookup_cmd_composition, as valid_command_p is too strict
4927         and forbids aliases that are the prefix of an existing alias
4928         or command.
4929         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
4930         command is properly recognised as a valid command.
4931
4932 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4933
4934         * unittests/help-doc-selftests.c: Rename to
4935         unittests/command-def-selftests.c
4936         * unittests/command-def-selftests.c (help_doc_tests): Update some
4937         comments.
4938         (command_structure_tests, traverse_command_structure): New namespace
4939         and function.
4940         (command_structure_invariants_tests): New function.
4941         (_initialize_command_def_selftests) Renamed from
4942         _initialize_help_doc_selftests, register command_structure_invariants
4943         selftest.
4944
4945 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4946
4947         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
4948         an alias of 'show'.
4949
4950 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
4951
4952         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
4953         ada_is_fixed_point_type.  Update all callers.
4954         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
4955         all callers.
4956         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
4957         Update all callers.
4958         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
4959         print_fixed_point_type.  Update all callers.
4960         * ada-valprint.c (ada_value_print_num): Replace call to
4961         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
4962
4963 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
4964
4965         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
4966         processors.
4967         (cpu_supports_bts): Add CV_AMD case.
4968
4969 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
4970             Simon Marchi  <simon.marchi@efficios.com>
4971
4972         * infrun.c (stop_all_threads): Collect multiple wait events at
4973         each pass.
4974
4975 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
4976
4977         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
4978         type::code instead.
4979
4980 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
4981
4982         * gdbtypes.h (struct type) <code, set_code>: New methods.
4983         (TYPE_CODE): Use type::code.  Change all call sites used to set
4984         the code to use type::set_code instead.
4985
4986 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4987             Tom de Vries  <tdevries@suse.de>
4988             Pedro Alves  <palves@redhat.com>
4989
4990         PR threads/25478
4991         * infrun.c (stop_all_threads): Do NOT ignore
4992         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
4993         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
4994         received.
4995         (handle_no_resumed): Remove code handling a live inferior with no
4996         threads.
4997         * remote.c (has_single_non_exited_thread): New.
4998         (remote_target::update_thread_list): Do not delete a thread if is
4999         the last thread of the process.
5000         * thread.c (thread_select): Call delete_exited_threads instead of
5001         prune_threads.
5002
5003 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5004
5005         * infrun.c (stop_all_threads): Enable/disable thread events of all
5006         targets.  Move a debug message denoting the end of the function
5007         into the SCOPED_EXIT block.
5008
5009 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5010
5011         * process-stratum-target.h: Include <set>.
5012         (all_non_exited_process_targets, switch_to_target_no_thread): New
5013         function declarations.
5014         * process-stratum-target.c (all_non_exited_process_targets)
5015         (switch_to_target_no_thread): New function implementations.
5016
5017 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5018
5019         * infrun.c (handle_inferior_event): Extract out a piece of code
5020         into...
5021         (mark_non_executing_threads): ...this new function.
5022
5023 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5024
5025         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
5026         use.
5027
5028 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5029
5030         * regcache.c (regcache_read_pc_protected): New function
5031         implementation that returns 0 if the PC cannot read via
5032         'regcache_read_pc'.
5033         * infrun.c (proceed): Call 'regcache_read_pc_protected'
5034         instead of 'regcache_read_pc'.
5035         (keep_going_pass_signal): Ditto.
5036
5037 2020-05-13  Tom Tromey  <tromey@adacore.com>
5038
5039         * ada-lang.c (align_value): Remove.
5040         (ada_template_to_fixed_record_type_1): Use align_up.
5041
5042 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5043
5044         * async-event.c: Update the copyright year.
5045         * async-event.h: Update the copyright year.
5046
5047 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
5048
5049         * objfiles.h (is_addr_in_objfile,
5050         shared_objfile_contains_address_p): Return bool.
5051         * objfile.c (is_addr_in_objfile,
5052         shared_objfile_contains_address_p): Return bool.
5053
5054 2020-05-11  Tom Tromey  <tromey@adacore.com>
5055
5056         * cli/cli-cmds.c (info_command): Restore.
5057         (_initialize_cli_cmds): Use add_prefix_command for "info".
5058         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
5059
5060 2020-05-11  Tom Tromey  <tromey@adacore.com>
5061
5062         * ada-lang.c (ada_value_primitive_field): Now public.
5063         * ada-lang.h (ada_value_primitive_field): Declare.
5064         * ada-valprint.c (print_field_values): Use
5065         ada_value_primitive_field for wrapper fields.
5066
5067 2020-05-11  Tom de Vries  <tdevries@suse.de>
5068
5069         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
5070         MODULE_DOMAIN.
5071
5072 2020-05-11  Tom de Vries  <tdevries@suse.de>
5073
5074         PR symtab/25941
5075         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
5076         with length 0, if not gdb-produced.
5077         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
5078
5079 2020-05-09  Tom de Vries  <tdevries@suse.de>
5080
5081         PR gdb/25955
5082         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
5083         calculation.
5084
5085 2020-05-09  Tom Tromey  <tom@tromey.com>
5086
5087         * top.c (server_command): Now bool.
5088         * top.h (server_command): Now bool.
5089
5090 2020-05-08  Tom Tromey  <tromey@adacore.com>
5091
5092         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
5093         already being processed.
5094
5095 2020-05-08  Tom Tromey  <tom@tromey.com>
5096
5097         * printcmd.c (struct display) <next>: Remove.
5098         <display>: New constructor.
5099         <exp_string>: Now a std::string.
5100         <enabled_p>: Now a bool.
5101         (display_number): Move definition earlier.
5102         (displays): Rename from display_chain.  Now a std::vector.
5103         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
5104         (display_command): Update.
5105         (do_one_display, disable_display)
5106         (enable_disable_display_command, do_enable_disable_display):
5107         Update.
5108         (free_display): Remove.
5109         (clear_displays): Rewrite.
5110         (delete_display): Update.
5111         (map_display_numbers): Use function_view.  Remove "data"
5112         parameter.  Update.
5113         (do_delete_display): Remove.
5114         (undisplay_command): Update.
5115         (do_one_display, do_displays, disable_display)
5116         (info_display_command): Update.
5117         (do_enable_disable_display): Remove.
5118         (enable_disable_display_command)
5119         (clear_dangling_display_expressions): Update.
5120
5121 2020-05-08  Tom Tromey  <tom@tromey.com>
5122
5123         * symtab.c (set_symbol_cache_size)
5124         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
5125         (maintenance_print_symbol_cache_statistics): Update.
5126         * symmisc.c (print_symbol_bcache_statistics)
5127         (print_objfile_statistics, maintenance_print_objfiles)
5128         (maintenance_info_symtabs, maintenance_check_symtabs)
5129         (maintenance_expand_symtabs, maintenance_info_line_tables):
5130         Update.
5131         * symfile-debug.c (set_debug_symfile): Update.
5132         * source.c (forget_cached_source_info): Update.
5133         * python/python.c (gdbpy_progspaces): Update.
5134         * psymtab.c (maintenance_info_psymtabs): Update.
5135         * probe.c (parse_probes): Update.
5136         * linespec.c (iterate_over_all_matching_symtabs)
5137         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
5138         * guile/scm-progspace.c (gdbscm_progspaces): Update.
5139         * exec.c (exec_target::close): Update.
5140         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
5141         * breakpoint.c (print_one_breakpoint_location)
5142         (create_longjmp_master_breakpoint)
5143         (create_std_terminate_master_breakpoint): Update.
5144         * progspace.c (program_spaces): Now a std::vector.
5145         (maybe_new_address_space): Update.
5146         (add_program_space): Remove.
5147         (program_space::program_space): Update.
5148         (remove_program_space): Update.
5149         (number_of_program_spaces): Remove.
5150         (print_program_space, update_address_spaces): Update.
5151         * progspace.h (program_spaces): Change type.
5152         (ALL_PSPACES): Remove.
5153         (number_of_program_spaces): Don't declare.
5154         (struct program_space) <next>: Remove.
5155
5156 2020-05-08  Tom Tromey  <tom@tromey.com>
5157
5158         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
5159         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
5160         (enable_break): Update.
5161         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
5162         (frv_fdpic_find_canonical_descriptor): Update.
5163         (frv_fetch_objfile_link_map): Update.
5164         * progspace.c (program_space::free_all_objfiles): Update.
5165         (program_space::solibs): New method.
5166         * progspace.h (struct program_space) <solibs>: New method.
5167         * solist.h (master_so_list): Don't declare.
5168         (ALL_SO_LIBS): Remove.
5169         * solib.h (so_list_head): Remove.
5170         (update_solib_list): Update comment.
5171         * solib.c (master_so_list): Remove.
5172         (solib_used, update_solib_list, solib_add)
5173         (info_sharedlibrary_command, clear_solib)
5174         (reload_shared_libraries_1, remove_user_added_objfile): Update.
5175
5176 2020-05-08  Tom Tromey  <tom@tromey.com>
5177
5178         * extension.c (extension_languages): Now a std::array.
5179         (ALL_EXTENSION_LANGUAGES): Remove.
5180         (get_ext_lang_defn, get_ext_lang_of_file)
5181         (eval_ext_lang_from_control_command): Update.
5182         (finish_ext_lang_initialization)
5183         (auto_load_ext_lang_scripts_for_objfile)
5184         (ext_lang_type_printers::ext_lang_type_printers)
5185         (apply_ext_lang_type_printers)
5186         (ext_lang_type_printers::~ext_lang_type_printers)
5187         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
5188         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
5189         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
5190         (get_matching_xmethod_workers, ext_lang_colorize)
5191         (ext_lang_before_prompt): Update.
5192         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
5193
5194 2020-05-08  Tom Tromey  <tom@tromey.com>
5195
5196         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
5197         overload.
5198         <swap_string, m_string>: Remove.
5199         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
5200         Update.
5201         * stabsread.c (define_symbol, read_type): Update.
5202         * linespec.c (find_linespec_symbols): Update.
5203         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
5204         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
5205         * dbxread.c (read_dbx_symtab): Update.
5206         * cp-support.h (cp_canonicalize_string_full)
5207         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
5208         Return unique_xmalloc_ptr.
5209         * cp-support.c (inspect_type): Update.
5210         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
5211         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
5212         Likewise.
5213         * c-typeprint.c (print_name_maybe_canonical): Update.
5214         * break-catch-throw.c (check_status_exception_catchpoint):
5215         Update.
5216
5217 2020-05-08  Tom de Vries  <tdevries@suse.de>
5218
5219         * infrun.c (follow_fork): Copy current_line and current_symtab to
5220         child thread.
5221
5222 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5223
5224         * async-event.c (struct async_signal_handler, struct
5225         async_event_handler): Reformat, remove typedef.
5226
5227 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5228
5229         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
5230         access thistype->main_type->dyn_prop_list directly.
5231
5232 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5233
5234         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
5235         (remove_dyn_prop): Remove.  Update all users to use
5236         type::remove_dyn_prop.
5237         * gdbtypes.c (remove_dyn_prop): Rename to...
5238         (type::remove_dyn_prop): ... this.
5239
5240 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
5241
5242         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
5243         (add_dyn_prop): Remove.  Update all users to use
5244         type::add_dyn_prop.
5245         * gdbtypes.c (add_dyn_prop): Rename to...
5246         (type::add_dyn_prop): ... this.
5247
5248 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5249
5250         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
5251         (get_dyn_prop): Remove.  Update all users to use
5252         type::dyn_prop.
5253         * gdbtypes.c (get_dyn_prop): Rename to...
5254         (type::dyn_prop): ... this.
5255
5256 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
5257
5258         * gdbtypes.h (struct main_type) <flag_static>: Remove.
5259
5260 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
5261
5262         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
5263         instruction, skip it if it's there.
5264
5265 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
5266
5267         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
5268
5269 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
5270
5271         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
5272         * gdbtypes.c (recursive_dump_type): Remove use of
5273         TYPE_INCOMPLETE.
5274
5275 2020-05-03  Tom Tromey  <tom@tromey.com>
5276
5277         * breakpoint.c (catch_command, tcatch_command): Remove.
5278         (_initialize_breakpoint): Use add_basic_prefix_cmd,
5279         add_show_prefix_cmd.
5280         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
5281         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
5282         Remove.
5283         (add_internal_problem_command): Use add_basic_prefix_cmd,
5284         add_show_prefix_cmd.
5285         * mips-tdep.c (set_mipsfpu_command): Remove.
5286         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
5287         * dwarf2/index-cache.c (set_index_cache_command): Remove.
5288         (_initialize_index_cache): Use add_basic_prefix_cmd.
5289         * memattr.c (dummy_cmd): Remove.
5290         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
5291         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
5292         (_initialize_tui_win): Use add_basic_prefix_cmd,
5293         add_show_prefix_cmd.
5294         * cli/cli-logging.c (set_logging_command): Remove.
5295         (_initialize_cli_logging): Use add_basic_prefix_cmd,
5296         add_show_prefix_cmd.
5297         (show_logging_command): Remove.
5298         * target.c (target_command): Remove.
5299         (add_target): Use add_basic_prefix_cmd.
5300
5301 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
5302
5303         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
5304
5305 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5306
5307         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
5308         info_command.
5309
5310 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
5311
5312         * nbsd-nat.c (nbsd_enable_proc_events)
5313         (nbsd_nat_target::post_startup_inferior): Add.
5314         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
5315         (nbsd_nat_target::update_thread_list): Rewrite.
5316         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
5317         "PTRACE_LWP_CREATE".
5318         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
5319
5320 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5321
5322         * stack.c (_initialize_stack): Remove duplicated creation
5323         of "frame" command and "f" alias.
5324
5325 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
5326
5327         PR gdb/18706
5328         * gdbtypes.c (check_typedef): Calculate size of array of
5329         stubbed type.
5330
5331 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
5332
5333         PR gdb/15559
5334         * i386-tdep.c (i386_push_dummy_call): Call
5335         i386_thiscall_push_dummy_call.
5336         (i386_thiscall_push_dummy_call): New function.
5337         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
5338         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
5339         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
5340
5341 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5342
5343         * gdbarch.sh (do_read): Add shellcheck disable directive for
5344         warning SC2162.
5345
5346 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5347
5348         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
5349         "referenced but not assigned" warning.
5350
5351 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5352
5353         * gdbarch.sh: Remove code that sets fallbackdefault.
5354
5355 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5356
5357         * gdbarch.sh: Use shell operators && and || instead of
5358         -a and -o.
5359
5360 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5361
5362         * gdbarch.sh: Use $(...) instead of `...`.
5363
5364 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5365
5366         * gdbarch.sh: Use double quotes around variables.
5367
5368 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5369
5370         * gdbarch.sh: Use %s with printf, instead of variables in the
5371         format string.
5372
5373 2020-04-29  Tom Tromey  <tromey@adacore.com>
5374
5375         PR ada/25875:
5376         * dwarf2/read.c (update_enumeration_type_from_children): Compute
5377         type fields here.
5378         (read_enumeration_type): Call
5379         update_enumeration_type_from_children later.  Update comments.
5380         (process_enumeration_scope): Don't create type fields.
5381
5382 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
5383
5384         * nbsd-tdep.c: Include "xml-syscall.h".
5385         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
5386
5387 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
5388
5389         * nbsd-nat.c: Include "sys/wait.h".
5390         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
5391         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
5392         (nbsd_nat_target::remove_exec_catchpoint)
5393         (nbsd_nat_target::set_syscall_catchpoint): Add.
5394         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
5395         (nbsd_nat_target::insert_exec_catchpoint)
5396         (nbsd_nat_target::remove_exec_catchpoint)
5397         (nbsd_nat_target::set_syscall_catchpoint): Add.
5398         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
5399         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
5400         `nbsd_get_syscall_number'.
5401
5402 2020-04-29  Tom Tromey  <tom@tromey.com>
5403
5404         * stack.c (print_block_frame_labels): Remove.
5405
5406 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
5407
5408         PR gdb/17320
5409         * ada-valprint.c (val_print_packed_array_elements): Move array
5410         end bracket to new line.
5411         (ada_val_print_string): Remove extra spaces before first array
5412         element.
5413         * c-valprint.c (c_value_print_array): Likewise.
5414         * m2-valprint.c (m2_print_array_contents): Likewise.
5415         (m2_value_print_inner): Likewise.
5416         * p-valprint.c (pascal_value_print_inner): Likewise.
5417         * valprint.c (generic_val_print_array): Likewise.
5418         (value_print_array_elements): Move first array element and array
5419         end bracket to new line.
5420
5421 2020-04-29  Tom de Vries  <tdevries@suse.de>
5422
5423         PR symtab/25889
5424         * linespec.c (find_method): Fix ix calculation.
5425
5426 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
5427
5428         * syscalls/update-netbsd.sh: New file.
5429         * syscalls/netbsd.xml: Regenerate.
5430         * data-directory/Makefile.in: Register `netbsd.xml' in
5431         `SYSCALLS_FILES'.
5432
5433 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
5434
5435         * syscalls/update-freebsd.sh: Add double quotes.
5436
5437 2020-04-28  Tom Tromey  <tom@tromey.com>
5438
5439         * NEWS: Update.
5440         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
5441         (cmdpy_init): Allow class_tui.
5442
5443 2020-04-28 Mark Williams <mark@myosotissp.com>
5444
5445         PR gdb/24480
5446         * dwarf2read.c: Add missing assingments to list_in_scope when
5447         start_symtab was already called.
5448
5449 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
5450
5451         PR gdb/25881
5452         * dwarf2/read.c (offset_map_type): Use
5453         gdb:hash_enum<sect_offset> as hash function.
5454
5455 2020-04-28  Tom de Vries  <tdevries@suse.de>
5456
5457         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
5458         with DW_AT_signature.
5459
5460 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
5461
5462         * configure.ac: Remove check for fs_base/gs_base in
5463         user_regs_struct.
5464         * configure: Re-generate.
5465         * config.in: Re-generate.
5466         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
5467         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
5468         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
5469
5470 2020-04-27  Luis Machado  <luis.machado@linaro.org>
5471
5472         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
5473         problematic inline frame unwinding situation.
5474         * frame.c (frame_id_computed_p): New function.
5475         * frame.h (frame_id_computed_p): New prototype.
5476
5477 2020-04-26  Tom Tromey  <tom@tromey.com>
5478
5479         * command.h (enum command_class) <class_pseudo>: Remove.
5480
5481 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5482
5483         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
5484         and whitespace.
5485
5486 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
5487
5488         * inf-ptrace.c (inf_ptrace_target::wait): Remove
5489         `PT_GET_PROCESS_STATE' block.
5490
5491 2020-04-24  Tom Tromey  <tom@tromey.com>
5492
5493         * symtab.h (symbol_get_demangled_name): Don't declare.
5494         * symtab.c (symbol_get_demangled_name): Remove.
5495         (general_symbol_info::natural_name)
5496         (general_symbol_info::demangled_name): Update.
5497
5498 2020-04-24  Tom Tromey  <tom@tromey.com>
5499
5500         PR rust/25025:
5501         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
5502
5503 2020-04-24  Tom Tromey  <tom@tromey.com>
5504
5505         PR symtab/12707:
5506         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
5507         exists.
5508         (new_symbol): Likewise.
5509         * compile/compile-object-load.c (get_out_value_type): Use
5510         symbol_matches_search_name.
5511
5512 2020-04-24  Tom Tromey  <tom@tromey.com>
5513
5514         * dwarf2/read.c (add_partial_symbol): Do not call
5515         compute_and_set_names.
5516
5517 2020-04-24  Tom Tromey  <tom@tromey.com>
5518
5519         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
5520         overload.
5521
5522 2020-04-24  Tom Tromey  <tom@tromey.com>
5523
5524         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
5525         (add_psymbol_to_list): New overload.  Make old overload call new
5526         one.
5527         * psympriv.h (add_psymbol_to_list): New overload.
5528
5529 2020-04-24  Tom Tromey  <tom@tromey.com>
5530
5531         * dwarf2/read.c (partial_die_info::read) <case
5532         DW_AT_linkage_name>: Use value_as_string.
5533         (dwarf2_string_attr): Use value_as_string.
5534         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
5535         method.
5536         * dwarf2/attribute.c (attribute::value_as_string): New method.
5537
5538 2020-04-24  Tom Tromey  <tom@tromey.com>
5539
5540         * symtab.c (general_symbol_info::natural_name)
5541         (general_symbol_info::demangled_name): Check for language_rust.
5542
5543 2020-04-24  Tom Tromey  <tom@tromey.com>
5544
5545         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
5546         (dwarf2_physname): ... from here.
5547         (partial_die_info::read): Add Rust "{" hack.
5548
5549 2020-04-24  Tom Tromey  <tom@tromey.com>
5550
5551         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
5552         method.
5553         (symbol_set_demangled_name): Don't declare.
5554         * symtab.c (general_symbol_info::set_demangled_name): Rename from
5555         symbol_set_demangled_name.
5556         (general_symbol_info::set_language)
5557         (general_symbol_info::compute_and_set_names): Update.
5558         * minsyms.c (minimal_symbol_reader::install): Update.
5559         * dwarf2/read.c (new_symbol): Update.
5560
5561 2020-04-24  Tom Tromey  <tromey@adacore.com>
5562
5563         PR python/23662:
5564         * python/py-type.c (convert_field): Handle
5565         FIELD_LOC_KIND_DWARF_BLOCK.
5566         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
5567         (typy_get_dynamic): Nw function.
5568         (type_object_getset): Add "dynamic".
5569         * NEWS: Add entry.
5570
5571 2020-04-24  Tom Tromey  <tromey@adacore.com>
5572
5573         * ada-typeprint.c (print_choices, print_variant_part)
5574         (print_record_field_types_dynamic): New functions.
5575         (print_record_field_types): Use print_record_field_types_dynamic.
5576
5577 2020-04-24  Tom Tromey  <tromey@adacore.com>
5578
5579         * dwarf2/read.c (handle_data_member_location): New overload.
5580         (dwarf2_add_field): Use it.
5581         (decode_locdesc): Add "computed" parameter.  Update comment.
5582         * gdbtypes.c (is_dynamic_type_internal): Also look for
5583         FIELD_LOC_KIND_DWARF_BLOCK.
5584         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
5585         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
5586         virtual base classes.
5587         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
5588         FIELD_LOC_KIND_DWARF_BLOCK.
5589
5590 2020-04-24  Tom Tromey  <tromey@adacore.com>
5591
5592         * dwarf2/read.c (read_structure_type): Handle dynamic length.
5593         * gdbtypes.c (is_dynamic_type_internal): Check
5594         TYPE_HAS_DYNAMIC_LENGTH.
5595         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
5596         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
5597         New macros.
5598         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
5599         constant.
5600
5601 2020-04-24  Tom Tromey  <tromey@adacore.com>
5602
5603         * dwarf2/read.c (struct variant_field): Rewrite.
5604         (struct variant_part_builder): New.
5605         (struct nextfield): Remove "variant" field.  Add "offset".
5606         (struct field_info): Add "current_variant_part" and
5607         "variant_parts".
5608         (alloc_discriminant_info): Remove.
5609         (alloc_rust_variant): New function.
5610         (quirk_rust_enum): Update.
5611         (dwarf2_add_field): Set "offset" member.  Don't handle
5612         DW_TAG_variant_part.
5613         (offset_map_type): New typedef.
5614         (convert_variant_range, create_one_variant)
5615         (create_one_variant_part, create_variant_parts)
5616         (add_variant_property): New functions.
5617         (dwarf2_attach_fields_to_type): Call add_variant_property.
5618         (read_structure_type): Don't handle DW_TAG_variant_part.
5619         (handle_variant_part, handle_variant): New functions.
5620         (handle_struct_member_die): Use them.
5621         (process_structure_scope): Don't handle variant parts.
5622         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
5623         (struct discriminant_info): Remove.
5624         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
5625         (struct main_type) <flag_discriminated_union>: Remove.
5626         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
5627         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
5628         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
5629         Update.
5630         * valops.c (value_union_variant): Remove.
5631         * value.h (value_union_variant): Don't declare.
5632
5633 2020-04-24  Tom Tromey  <tromey@adacore.com>
5634
5635         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
5636         (ada_value_primitive_packed_val): Update.
5637         * ada-valprint.c (ada_value_print_1): Update.
5638         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
5639         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
5640         just an address.  Use evaluate_for_locexpr_baton.
5641         (dwarf2_evaluate_property): Update.
5642         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
5643         array_view.
5644         * findvar.c (default_read_var_value): Update.
5645         * gdbtypes.c (compute_variant_fields_inner)
5646         (resolve_dynamic_type_internal): Update.
5647         (resolve_dynamic_type): Change type of valaddr parameter.
5648         * gdbtypes.h (resolve_dynamic_type): Update.
5649         * valarith.c (value_subscripted_rvalue): Update.
5650         * value.c (value_from_contents_and_address): Update.
5651
5652 2020-04-24  Tom Tromey  <tromey@adacore.com>
5653
5654         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
5655         "push_initial_value" parameter.
5656         (dwarf2_evaluate_property): Likewise.
5657         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
5658
5659 2020-04-24  Tom Tromey  <tromey@adacore.com>
5660
5661         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
5662         (variant::matches, compute_variant_fields_recurse)
5663         (compute_variant_fields_inner, compute_variant_fields): New
5664         functions.
5665         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
5666         Use resolved_type after type is made.
5667         (operator==): Add new cases.
5668         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
5669         (struct discriminant_range, struct variant, struct variant_part):
5670         New.
5671         (union dynamic_prop_data) <variant_parts, original_type>: New
5672         members.
5673         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
5674         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
5675         constants.
5676         * value.c (unpack_bits_as_long): Now public.
5677         * value.h (unpack_bits_as_long): Declare.
5678
5679 2020-04-24  Tom Tromey  <tromey@adacore.com>
5680
5681         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
5682         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
5683
5684 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
5685
5686         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
5687
5688 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
5689
5690         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
5691         (remove_fork_catchpoint, post_startup_inferior)
5692         (post_attach): Move...
5693         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
5694         (remove_fork_catchpoint, post_startup_inferior)
5695         (post_attach): ...here.
5696         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
5697         (remove_fork_catchpoint, post_startup_inferior)
5698         (post_attach): Move...
5699         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
5700         (remove_fork_catchpoint, post_startup_inferior)
5701         (post_attach): ...here.
5702
5703 2020-04-24  Tom Tromey  <tromey@adacore.com>
5704
5705         * nat/windows-nat.h (struct windows_thread_info)
5706         <pc_adjusted>: New member.
5707         * windows-nat.c (windows_fetch_one_register): Check
5708         pc_adjusted.
5709         (windows_nat_target::get_windows_debug_event)
5710         (windows_nat_target::wait): Set pc_adjusted.
5711
5712 2020-04-24  Tom de Vries  <tdevries@suse.de>
5713
5714         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
5715         Run gdb-add-index inside temp dir.
5716
5717 2020-04-23  Tom Tromey  <tromey@adacore.com>
5718
5719         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
5720         in loop.
5721
5722 2020-04-23  Luis Machado  <luis.machado@linaro.org>
5723
5724         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
5725         get_frame_register instead of gdbarch_unwind_pc.
5726
5727 2020-04-23  Tom de Vries  <tdevries@suse.de>
5728
5729         * symtab.c (lookup_global_symbol): Prefer def over decl.
5730
5731 2020-04-23  Tom de Vries  <tdevries@suse.de>
5732
5733         PR symtab/25807
5734         * block.c (best_symbol, better_symbol): Promote to external.
5735         * block.h (best_symbol, better_symbol): Declare.
5736         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
5737         decl.
5738
5739 2020-04-23  Tom Tromey  <tromey@adacore.com>
5740
5741         PR ada/25837:
5742         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
5743         "const char *", not a "const std::string &".
5744         <name_and_matcher::operator==>: Update.
5745         * unittests/lookup_name_info-selftests.c: Change type of
5746         "result".
5747
5748 2020-04-23  Tom Tromey  <tom@tromey.com>
5749
5750         * inferior.h (iterate_over_inferiors): Don't declare.
5751         * inferior.c (iterate_over_inferiors): Remove.
5752         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
5753         Remove.
5754         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
5755         use iterate_over_inferiors.
5756         (darwin_resume_inferior_it)
5757         (struct resume_inferior_threads_param)
5758         (darwin_resume_inferior_threads_it): Remove.
5759         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
5760
5761 2020-04-23  Tom de Vries  <tdevries@suse.de>
5762
5763         * blockframe.c (find_pc_partial_function): Use
5764         find_pc_sect_compunit_symtab rather than
5765         objfile->sf->qf->find_pc_sect_compunit_symtab.
5766
5767 2020-04-22  Tom de Vries  <tdevries@suse.de>
5768
5769         PR symtab/25764
5770         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
5771         in psymtabs.
5772
5773 2020-04-22  Tom de Vries  <tdevries@suse.de>
5774
5775         PR symtab/25801
5776         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
5777         symtabs.
5778
5779 2020-04-22  Tom de Vries  <tdevries@suse.de>
5780
5781         PR symtab/25700
5782         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
5783         CU if already created.
5784
5785 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5786
5787         * infrun.c (displaced_step_fixup): Switch to the event_thread
5788         before calling displaced_step_restore, not after.
5789
5790 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5791
5792         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
5793         its inferior is not recorded by us.
5794         (record_btrace_target_open): Replace call to
5795         all_non_exited_threads () with call to current_inferior
5796         ()->non_exited_threads ().
5797         (record_btrace_target::stop_recording): Likewise.
5798         (record_btrace_target::close): Likewise.
5799         (record_btrace_target::wait): Likewise.
5800         (record_btrace_target::record_stop_replaying): Likewise.
5801
5802 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5803
5804         * btrace.c (btrace_enable): Throw an error on double enables and
5805         when enabling recording fails.
5806         (btrace_disable): Throw an error if the thread is not recorded.
5807
5808 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5809
5810         * record-btrace.c (record_btrace_target::fetch_registers): Forward
5811         request if we do not have a thread_info.
5812
5813 2020-04-21  Tom de Vries  <tdevries@suse.de>
5814
5815         PR gdb/25471
5816         * thread.c
5817         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
5818         exception in get_frame_id.
5819
5820 2020-04-20  Tom Tromey  <tromey@adacore.com>
5821
5822         * python/python.c (struct gdbpy_event): Mark move constructor as
5823         noexcept.
5824         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
5825         constructor as noexcept.
5826         * completer.h (struct completion_result): Mark move constructor as
5827         noexcept.
5828         * completer.c (completion_result::completion_result): Use
5829         initialization style.  Don't call reset_match_list.
5830
5831 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
5832
5833         * MAINTAINERS (Write After Approval): Add myself.
5834
5835 2020-04-18  Tom Tromey  <tom@tromey.com>
5836
5837         * windows-tdep.c (init_w32_command_list)
5838         (w32_prefix_command_valid): Restore.
5839         (_initialize_windows_tdep): Call init_w32_command_list.
5840
5841 2020-04-18  Tom Tromey  <tom@tromey.com>
5842
5843         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
5844         * value.c (value_fn_field): Update.
5845         * valops.c (find_function_in_inferior)
5846         (value_allocate_space_in_inferior): Update.
5847         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5848         Update.
5849         * tui/tui-source.c (tui_source_window::set_contents): Update.
5850         * symtab.c (lookup_global_or_static_symbol)
5851         (find_function_start_sal_1, skip_prologue_sal)
5852         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
5853         * symmisc.c (dump_msymbols, dump_symtab_1)
5854         (maintenance_print_one_line_table): Update.
5855         * symfile.c (init_entry_point_info, section_is_mapped)
5856         (list_overlays_command, simple_read_overlay_table)
5857         (simple_overlay_update_1): Update.
5858         * stap-probe.c (handle_stap_probe): Update.
5859         * stabsread.c (dbx_init_float_type, define_symbol)
5860         (read_one_struct_field, read_enum_type, read_range_type): Update.
5861         * source.c (info_line_command): Update.
5862         * python/python.c (gdbpy_source_objfile_script)
5863         (gdbpy_execute_objfile_script): Update.
5864         * python/py-type.c (save_objfile_types): Update.
5865         * python/py-objfile.c (py_free_objfile): Update.
5866         * python/py-inferior.c (python_new_objfile): Update.
5867         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
5868         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
5869         (maintenance_check_psymtabs): Update.
5870         * printcmd.c (info_address_command): Update.
5871         * objfiles.h (struct objfile) <arch>: New method, from
5872         get_objfile_arch.
5873         (get_objfile_arch): Don't declare.
5874         * objfiles.c (get_objfile_arch): Remove.
5875         (filter_overlapping_sections): Update.
5876         * minsyms.c (msymbol_is_function): Update.
5877         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
5878         (output_nondebug_symbol): Update.
5879         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
5880         (mdebug_expand_psymtab): Update.
5881         * machoread.c (macho_add_oso_symfile): Update.
5882         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
5883         Update.
5884         * linux-fork.c (checkpoint_command): Update.
5885         * linespec.c (convert_linespec_to_sals): Update.
5886         * jit.c (finalize_symtab): Update.
5887         * infrun.c (insert_exception_resume_from_probe): Update.
5888         * ia64-tdep.c (ia64_find_unwind_table): Update.
5889         * hppa-tdep.c (internalize_unwinds): Update.
5890         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
5891         Update.
5892         * gcore.c (call_target_sbrk): Update.
5893         * elfread.c (record_minimal_symbol, elf_symtab_read)
5894         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
5895         (elf_gnu_ifunc_resolve_by_got): Update.
5896         * dwarf2/read.c (create_addrmap_from_index)
5897         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5898         (read_debug_names_from_section)
5899         (process_psymtab_comp_unit_reader, add_partial_symbol)
5900         (add_partial_subprogram, process_full_comp_unit)
5901         (read_file_scope, read_func_scope, read_lexical_block_scope)
5902         (read_call_site_scope, dwarf2_ranges_read)
5903         (dwarf2_record_block_ranges, dwarf2_add_field)
5904         (mark_common_block_symbol_computed, read_tag_pointer_type)
5905         (read_tag_string_type, dwarf2_init_float_type)
5906         (dwarf2_init_complex_target_type, read_base_type)
5907         (partial_die_info::read, partial_die_info::read)
5908         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
5909         (dwarf2_fetch_die_loc_sect_off): Update.
5910         * dwarf2/loc.c (dwarf2_find_location_expression)
5911         (class dwarf_evaluate_loc_desc, rw_pieced_value)
5912         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
5913         (dwarf2_loc_desc_get_symbol_read_needs)
5914         (locexpr_describe_location_piece, locexpr_describe_location_1)
5915         (loclist_describe_location): Update.
5916         * dwarf2/index-write.c (write_debug_names): Update.
5917         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
5918         * dtrace-probe.c (dtrace_process_dof): Update.
5919         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
5920         (process_one_symbol): Update.
5921         * ctfread.c (ctf_init_float_type, read_base_type): Update.
5922         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
5923         (coff_read_enum_type): Update.
5924         * cli/cli-cmds.c (edit_command, list_command): Update.
5925         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
5926         * breakpoint.c (create_overlay_event_breakpoint)
5927         (create_longjmp_master_breakpoint)
5928         (create_std_terminate_master_breakpoint)
5929         (create_exception_master_breakpoint, get_sal_arch): Update.
5930         * block.c (block_gdbarch): Update.
5931         * annotate.c (annotate_source_line): Update.
5932
5933 2020-04-17  Tom Tromey  <tromey@adacore.com>
5934
5935         * auto-load.c (show_auto_load_cmd): Remove.
5936         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
5937         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
5938         (maintenance_print_arc_command): Remove.
5939         * tui/tui-win.c (tui_command): Remove.
5940         (tui_get_cmd_list): Use add_basic_prefix_cmd.
5941         * tui/tui-layout.c (tui_layout_command): Remove.
5942         (_initialize_tui_layout): Use add_basic_prefix_cmd.
5943         * python/python.c (user_set_python, user_show_python): Remove.
5944         (_initialize_python): Use add_basic_prefix_cmd,
5945         add_show_prefix_cmd.
5946         * guile/guile.c (set_guile_command, show_guile_command): Remove.
5947         (install_gdb_commands): Use add_basic_prefix_cmd,
5948         add_show_prefix_cmd.
5949         (info_guile_command): Remove.
5950         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
5951         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
5952         add_show_prefix_cmd.
5953         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
5954         Remove do_set and do_show parameters.
5955         * cli/cli-style.c (set_style, show_style): Remove.
5956         (_initialize_cli_style): Use add_basic_prefix_cmd,
5957         add_show_prefix_cmd.
5958         (cli_style_option::add_setshow_commands): Remove do_set and
5959         do_show parameters.
5960         (cli_style_option::add_setshow_commands): Use
5961         add_basic_prefix_cmd, add_show_prefix_cmd.
5962         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
5963         (set_style_name): Remove.
5964         * cli/cli-dump.c (dump_command, append_command): Remove.
5965         (srec_dump_command, ihex_dump_command, verilog_dump_command)
5966         (tekhex_dump_command, binary_dump_command)
5967         (binary_append_command): Remove.
5968         (_initialize_cli_dump): Use add_basic_prefix_cmd.
5969         * windows-tdep.c (w32_prefix_command_valid): Remove global.
5970         (init_w32_command_list): Remove; move into ...
5971         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
5972         * valprint.c (set_print, show_print, set_print_raw)
5973         (show_print_raw): Remove.
5974         (_initialize_valprint): Use add_basic_prefix_cmd,
5975         add_show_prefix_cmd.
5976         * typeprint.c (set_print_type, show_print_type): Remove.
5977         (_initialize_typeprint): Use add_basic_prefix_cmd,
5978         add_show_prefix_cmd.
5979         * record.c (set_record_command, show_record_command): Remove.
5980         (_initialize_record): Use add_basic_prefix_cmd,
5981         add_show_prefix_cmd.
5982         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
5983         add_show_prefix_cmd.
5984         (info_command, show_command, set_debug, show_debug): Remove.
5985         * top.h (set_history, show_history): Don't declare.
5986         * top.c (set_history, show_history): Remove.
5987         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
5988         (unset_tdesc_cmd): Remove.
5989         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
5990         add_show_prefix_cmd.
5991         * symtab.c (info_module_command): Remove.
5992         (_initialize_symtab): Use add_basic_prefix_cmd.
5993         * symfile.c (overlay_command): Remove.
5994         (_initialize_symfile): Use add_basic_prefix_cmd.
5995         * sparc64-tdep.c (info_adi_command): Remove.
5996         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
5997         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
5998         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
5999         add_show_prefix_cmd.
6000         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
6001         (_initialize_serial): Use add_basic_prefix_cmd,
6002         add_show_prefix_cmd.
6003         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
6004         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
6005         add_show_prefix_cmd.
6006         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
6007         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
6008         add_show_prefix_cmd.
6009         * riscv-tdep.c (show_riscv_command, set_riscv_command)
6010         (show_debug_riscv_command, set_debug_riscv_command): Remove.
6011         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
6012         add_show_prefix_cmd.
6013         * remote.c (remote_command, set_remote_cmd): Remove.
6014         (_initialize_remote): Use add_basic_prefix_cmd.
6015         * record-full.c (set_record_full_command)
6016         (show_record_full_command): Remove.
6017         (_initialize_record_full): Use add_basic_prefix_cmd,
6018         add_show_prefix_cmd.
6019         * record-btrace.c (cmd_set_record_btrace)
6020         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
6021         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
6022         (cmd_show_record_btrace_pt): Remove.
6023         (_initialize_record_btrace): Use add_basic_prefix_cmd,
6024         add_show_prefix_cmd.
6025         * ravenscar-thread.c (set_ravenscar_command)
6026         (show_ravenscar_command): Remove.
6027         (_initialize_ravenscar): Use add_basic_prefix_cmd,
6028         add_show_prefix_cmd.
6029         * mips-tdep.c (show_mips_command, set_mips_command)
6030         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
6031         add_show_prefix_cmd.
6032         * maint.c (maintenance_command, maintenance_info_command)
6033         (maintenance_check_command, maintenance_print_command)
6034         (maintenance_set_cmd, maintenance_show_cmd): Remove.
6035         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
6036         add_show_prefix_cmd.
6037         (show_per_command_cmd): Remove.
6038         * maint-test-settings.c (maintenance_set_test_settings_cmd):
6039         Remove.
6040         (maintenance_show_test_settings_cmd): Remove.
6041         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
6042         add_show_prefix_cmd.
6043         * maint-test-options.c (maintenance_test_options_command):
6044         Remove.
6045         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
6046         * macrocmd.c (macro_command): Remove
6047         (_initialize_macrocmd): Use add_basic_prefix_cmd.
6048         * language.c (set_check, show_check): Remove.
6049         (_initialize_language): Use add_basic_prefix_cmd,
6050         add_show_prefix_cmd.
6051         * infcmd.c (unset_command): Remove.
6052         (_initialize_infcmd): Use add_basic_prefix_cmd.
6053         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
6054         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
6055         add_show_prefix_cmd.
6056         * go32-nat.c (go32_info_dos_command): Remove.
6057         (_initialize_go32_nat): Use add_basic_prefix_cmd.
6058         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
6059         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
6060         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
6061         (_initialize_frame): Use add_basic_prefix_cmd,
6062         add_show_prefix_cmd.
6063         * dcache.c (set_dcache_command, show_dcache_command): Remove.
6064         (_initialize_dcache): Use add_basic_prefix_cmd,
6065         add_show_prefix_cmd.
6066         * cp-support.c (maint_cplus_command): Remove.
6067         (_initialize_cp_support): Use add_basic_prefix_cmd.
6068         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
6069         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
6070         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
6071         add_basic_prefix_cmd, add_show_prefix_cmd.
6072         * breakpoint.c (save_command): Remove.
6073         (_initialize_breakpoint): Use add_basic_prefix_cmd.
6074         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
6075         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
6076         add_show_prefix_cmd.
6077         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
6078         (set_ada_command, show_ada_command): Remove.
6079         (_initialize_ada_language): Use add_basic_prefix_cmd,
6080         add_show_prefix_cmd.
6081         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
6082
6083 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
6084
6085         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
6086         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
6087
6088 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
6089
6090         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
6091         warning messages.
6092
6093 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
6094
6095         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
6096         import table is not at beginning of .idata section.
6097
6098 2020-04-16  Pedro Alves  <palves@redhat.com>
6099
6100         * inferior.c (delete_inferior): Use delete operator directly
6101         instead of delete_program_space.
6102         * progspace.c (add_program_space): New, factored out from
6103         program_space::program_space.
6104         (remove_program_space): New, factored out from
6105         delete_program_space.
6106         (program_space::program_space): Remove intro comment.  Rewrite.
6107         (program_space::~program_space): Remove intro comment.  Call
6108         remove_program_space.
6109         (delete_program_space): Delete.
6110         * progspace.h (program_space::program_space): Make explicit.  Move
6111         intro comment here, adjusted.
6112         (program_space::~program_space): Move intro comment here,
6113         adjusted.
6114         (delete_program_space): Remove.
6115
6116 2020-04-16  Tom Tromey  <tromey@adacore.com>
6117
6118         * windows-nat.c (windows_nat::handle_access_violation): New
6119         function.
6120         * nat/windows-nat.h (handle_access_violation): Declare.
6121         * nat/windows-nat.c (handle_exception): Move Cygwin code to
6122         windows-nat.c.  Call handle_access_violation.
6123
6124 2020-04-16  Tom de Vries  <tdevries@suse.de>
6125
6126         PR symtab/25791
6127         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
6128         CUs without psymtab.
6129
6130 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
6131
6132         * python/python.c (do_start_initialization): Don't call
6133         PyEval_InitThreads for Python 3.9 and beyond.
6134
6135 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
6136
6137         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
6138         thread functions.
6139         (obsd_nat_target::wait): Likewise.
6140
6141 2020-04-15  Tom Tromey  <tromey@adacore.com>
6142
6143         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
6144         (DEBUG_EXCEPT): Use debug_printf.
6145
6146 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * completer.c (class completion_tracker::completion_hash_entry)
6149         <hash_name>: New member function.
6150         (completion_tracker::discard_completions): New callback to hash a
6151         completion_hash_entry, pass this to htab_create_alloc.
6152
6153 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
6154
6155         * windows-nat.c (windows_make_so): Warn rather than stopping with
6156         an error if realpath() fails.
6157
6158 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
6159
6160         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
6161         (nbsd_nat_target::info_proc): Add do_status.
6162
6163 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
6164             Tom de Vries  <tdevries@suse.de>
6165
6166         PR symtab/25718
6167         * psympriv.h (struct partial_symtab::read_symtab)
6168         (struct partial_symtab::expand_psymtab)
6169         (struct partial_symtab::read_dependencies): Update comments.
6170         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
6171         read_symtab for includer.
6172         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
6173         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
6174         (struct dwarf2_include_psymtab::m_readin): Remove.
6175         (struct dwarf2_include_psymtab::includer): New member function.
6176         (dwarf2_psymtab::expand_psymtab): Assert !readin.
6177
6178 2020-04-14  Tom de Vries  <tdevries@suse.de>
6179
6180         PR symtab/25720
6181         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
6182         with NULL symbol_matcher and lookup_name.
6183         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
6184         and lookup_name.
6185         * dwarf2/read.c (dw2_expand_symtabs_matching)
6186         (dw2_debug_names_expand_symtabs_matching): Same.
6187         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
6188         Make lookup_name a pointer.  Update comment.
6189         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
6190         lookup_name being a pointer.
6191         * symfile.c (expand_symtabs_matching): Same.
6192         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
6193         * linespec.c (iterate_over_all_matching_symtabs): Same.
6194
6195 2020-04-13  Tom Tromey  <tom@tromey.com>
6196
6197         * run-on-main-thread.c: Update include.
6198         * unittests/main-thread-selftests.c: Update include.
6199         * tui/tui-win.c: Update include.
6200         * tui/tui-io.c: Update include.
6201         * tui/tui-interp.c: Update include.
6202         * tui/tui-hooks.c: Update include.
6203         * top.h: Update include.
6204         * top.c: Update include.
6205         * ser-base.c: Update include.
6206         * remote.c: Update include.
6207         * remote-notif.c: Update include.
6208         * remote-fileio.c: Update include.
6209         * record-full.c: Update include.
6210         * record-btrace.c: Update include.
6211         * python/python.c: Update include.
6212         * posix-hdep.c: Update include.
6213         * mingw-hdep.c: Update include.
6214         * mi/mi-main.c: Update include.
6215         * mi/mi-interp.c: Update include.
6216         * main.c: Update include.
6217         * linux-nat.c: Update include.
6218         * interps.c: Update include.
6219         * infrun.c: Update include.
6220         * inf-loop.c: Update include.
6221         * event-top.c: Update include.
6222         * event-loop.c: Move to ../gdbsupport/.
6223         * event-loop.h: Move to ../gdbsupport/.
6224         * async-event.h: Update include.
6225         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
6226
6227 2020-04-13  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-win.c: Include async-event.h.
6230         * remote.c: Include async-event.h.
6231         * remote-notif.c: Include async-event.h.
6232         * record-full.c: Include async-event.h.
6233         * record-btrace.c: Include async-event.h.
6234         * infrun.c: Include async-event.h.
6235         * event-top.c: Include async-event.h.
6236         * event-loop.h: Move some declarations to async-event.h.
6237         * event-loop.c: Don't include ser-event.h or top.h.  Move some
6238         code to async-event.c.
6239         * async-event.h: New file.
6240         * async-event.c: New file.
6241         * Makefile.in (COMMON_SFILES): Add async-event.c.
6242         (HFILES_NO_SRCDIR): Add async-event.h.
6243
6244 2020-04-13  Tom Tromey  <tom@tromey.com>
6245
6246         * utils.c (flush_streams): New function.
6247         * event-loop.c (gdb_wait_for_event): Call flush_streams.
6248
6249 2020-04-13  Tom Tromey  <tom@tromey.com>
6250
6251         * event-loop.c (handle_file_event): Use warning, not
6252         printf_unfiltered.
6253
6254 2020-04-13  Tom Tromey  <tom@tromey.com>
6255
6256         * event-loop.c: Include <chrono>.
6257
6258 2020-04-13  Tom Tromey  <tom@tromey.com>
6259
6260         * gdb_select.h: Move to ../gdbsupport/.
6261         * event-loop.c: Update include path.
6262         * top.c: Update include path.
6263         * ser-base.c: Update include path.
6264         * ui-file.c: Update include path.
6265         * ser-tcp.c: Update include path.
6266         * guile/scm-ports.c: Update include path.
6267         * posix-hdep.c: Update include path.
6268         * ser-unix.c: Update include path.
6269         * gdb_usleep.c: Update include path.
6270         * mingw-hdep.c: Update include path.
6271         * inflow.c: Update include path.
6272         * infrun.c: Update include path.
6273         * event-top.c: Update include path.
6274
6275 2020-04-13  Tom Tromey  <tom@tromey.com>
6276
6277         * configure: Rebuild.
6278         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
6279
6280 2020-04-13  Tom Tromey  <tom@tromey.com>
6281
6282         * event-loop.h (start_event_loop): Don't declare.
6283         * event-loop.c (start_event_loop): Move...
6284         * main.c (start_event_loop): ...here.  Now static.
6285
6286 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
6287
6288         * MAINTAINERS: Update my email address.
6289
6290 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6291
6292         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
6293         IP_ALL.
6294
6295 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6296
6297         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
6298         (nbsd_nat_target::info_proc): Add do_cmdline.
6299
6300 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6301
6302         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
6303         (nbsd_nat_target::info_proc): Add do_cwd.
6304
6305 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6306
6307         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
6308
6309 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
6310
6311         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
6312         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
6313         (nbsd_nat_target::info_proc): New functions.
6314         * nbsd-nat.c (kinfo_get_vmmap): New function.
6315         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
6316         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
6317         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
6318         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
6319         functions.
6320         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
6321         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6322         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6323         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
6324         (KINFO_VME_FLAG_GROWS_DOWN): New.
6325
6326 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
6327
6328         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
6329         bit shift.
6330
6331 2020-04-10  Tom Tromey  <tromey@adacore.com>
6332
6333         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
6334
6335 2020-04-10  Tom Tromey  <tromey@adacore.com>
6336
6337         * symtab.c (get_symbol_address, get_msymbol_address): Skip
6338         separate debug files.
6339
6340 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
6341
6342         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
6343         Move to...
6344         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
6345         ... here.
6346         * windows-nat.c (windows_nat_target::get_windows_debug_event):
6347         Check for STATUS_WX86_BREAKPOINT.
6348         (windows_nat_target::wait): Same.
6349
6350 2020-04-10  Tom de Vries  <tdevries@suse.de>
6351
6352         PR cli/25808
6353         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
6354
6355 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
6356
6357         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
6358         (Write After Approval): Remove Tom de Vries.
6359
6360 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6361
6362         revert partially:
6363         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6364
6365         * buildsym.c (record_line): Fix undefined behavior and preserve
6366         lines at eof.
6367
6368 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
6369
6370         * auxv.h (svr4_auxv_parse): New.
6371         * auxv.c (default_auxv_parse): Split into default_auxv_parse
6372         and generic_auxv_parse.
6373         (svr4_auxv_parse): Add.
6374         * obsd-tdep.c: Include "auxv.h".
6375         (obsd_auxv_parse): Remove.
6376         (obsd_init_abi): Remove comment.
6377         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
6378         from `obsd_auxv_parse' to `svr4_auxv_parse'.
6379         * nbsd-tdep.c: Include "auxv.h".
6380         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
6381
6382 2020-04-08  Tom Tromey  <tromey@adacore.com>
6383
6384         * nat/windows-nat.h (last_wait_event): Don't declare.
6385         (wait_for_debug_event): Update comment.
6386         * nat/windows-nat.c (last_wait_event): Now static.
6387
6388 2020-04-08  Tom Tromey  <tromey@adacore.com>
6389
6390         * windows-nat.c (wait_for_debug_event): Move to
6391         nat/windows-nat.c.
6392         * nat/windows-nat.h (wait_for_debug_event): Declare.
6393         * nat/windows-nat.c (wait_for_debug_event): Move from
6394         windows-nat.c.  No longer static.
6395
6396 2020-04-08  Tom Tromey  <tromey@adacore.com>
6397
6398         * windows-nat.c (get_windows_debug_event): Use
6399         fetch_pending_stop.
6400         * nat/windows-nat.h (fetch_pending_stop): Declare.
6401         * nat/windows-nat.c (fetch_pending_stop): New function.
6402
6403 2020-04-08  Tom Tromey  <tromey@adacore.com>
6404
6405         * windows-nat.c (windows_continue): Use matching_pending_stop and
6406         continue_last_debug_event.
6407         * nat/windows-nat.h (matching_pending_stop)
6408         (continue_last_debug_event): Declare.
6409         * nat/windows-nat.c (DEBUG_EVENTS): New define.
6410         (matching_pending_stop, continue_last_debug_event): New
6411         functions.
6412
6413 2020-04-08  Tom Tromey  <tromey@adacore.com>
6414
6415         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
6416         (handle_exception_result): Move to nat/windows-nat.h.
6417         (DEBUG_EXCEPTION_SIMPLE): Remove.
6418         (windows_nat::handle_ms_vc_exception): New function.
6419         (handle_exception): Move to nat/windows-nat.c.
6420         (get_windows_debug_event): Update.
6421         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
6422         nat/windows-nat.c.
6423         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
6424         (handle_exception_result): Move from windows-nat.c.
6425         (handle_exception): Declare.
6426         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
6427         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
6428         windows-nat.c.
6429
6430 2020-04-08  Tom Tromey  <tromey@adacore.com>
6431
6432         * windows-nat.c (exception_count, event_count): Remove.
6433         (handle_exception, get_windows_debug_event)
6434         (do_initial_windows_stuff): Update.
6435
6436 2020-04-08  Tom Tromey  <tromey@adacore.com>
6437
6438         * windows-nat.c (windows_nat::handle_load_dll)
6439         (windows_nat::handle_unload_dll): Rename.  No longer static.
6440         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
6441         Declare.
6442
6443 2020-04-08  Tom Tromey  <tromey@adacore.com>
6444
6445         * complaints.h (stop_whining): Declare at top-level.
6446         (complaint): Don't declare stop_whining.
6447
6448 2020-04-08  Tom Tromey  <tromey@adacore.com>
6449
6450         * windows-nat.c (windows_nat::handle_output_debug_string):
6451         Rename.  No longer static.
6452         * nat/windows-nat.h (handle_output_debug_string): Declare.
6453
6454 2020-04-08  Tom Tromey  <tromey@adacore.com>
6455
6456         * windows-nat.c (current_process_handle, current_process_id)
6457         (main_thread_id, last_sig, current_event, last_wait_event)
6458         (current_windows_thread, desired_stop_thread_id, pending_stops)
6459         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
6460         (display_selectors, fake_create_process)
6461         (get_windows_debug_event): Update.
6462         * nat/windows-nat.h (current_process_handle, current_process_id)
6463         (main_thread_id, last_sig, current_event, last_wait_event)
6464         (current_windows_thread, desired_stop_thread_id, pending_stops)
6465         (struct pending_stop, siginfo_er): Move from windows-nat.c.
6466         * nat/windows-nat.c (current_process_handle, current_process_id)
6467         (main_thread_id, last_sig, current_event, last_wait_event)
6468         (current_windows_thread, desired_stop_thread_id, pending_stops)
6469         (siginfo_er): New globals.  Move from windows-nat.c.
6470
6471 2020-04-08  Tom Tromey  <tromey@adacore.com>
6472
6473         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
6474         (handle_load_dll): Update.
6475         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
6476
6477 2020-04-08  Tom Tromey  <tromey@adacore.com>
6478
6479         * windows-nat.c (enum thread_disposition_type): Move to
6480         nat/windows-nat.h.
6481         (windows_nat::thread_rec): Rename from thread_rec.  No longer
6482         static.
6483         (windows_add_thread, windows_nat_target::fetch_registers)
6484         (windows_nat_target::store_registers, handle_exception)
6485         (windows_nat_target::resume, get_windows_debug_event)
6486         (windows_nat_target::get_tib_address)
6487         (windows_nat_target::thread_name)
6488         (windows_nat_target::thread_alive): Update.
6489         * nat/windows-nat.h (enum thread_disposition_type): Move from
6490         windows-nat.c.
6491         (thread_rec): Declare.
6492
6493 2020-04-08  Tom Tromey  <tromey@adacore.com>
6494
6495         * windows-nat.c: Add "using namespace".
6496         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
6497         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
6498
6499 2020-04-08  Tom Tromey  <tromey@adacore.com>
6500
6501         * nat/windows-nat.h (struct windows_thread_info): Declare
6502         destructor.
6503         * nat/windows-nat.c (~windows_thread_info): New.
6504
6505 2020-04-08  Tom Tromey  <tromey@adacore.com>
6506
6507         PR gdb/22992
6508         * windows-nat.c (current_event): Update comment.
6509         (last_wait_event, desired_stop_thread_id): New globals.
6510         (struct pending_stop): New.
6511         (pending_stops): New global.
6512         (windows_nat_target) <stopped_by_sw_breakpoint>
6513         <supports_stopped_by_sw_breakpoint>: New methods.
6514         (windows_fetch_one_register): Add assertions.  Adjust PC.
6515         (windows_continue): Handle pending stops.  Suspend other threads
6516         when stepping.  Use last_wait_event
6517         (wait_for_debug_event): New function.
6518         (get_windows_debug_event): Use wait_for_debug_event.  Handle
6519         pending stops.  Queue spurious stops.
6520         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
6521         (windows_nat_target::kill): Use wait_for_debug_event.
6522         * nat/windows-nat.h (struct windows_thread_info)
6523         <stopped_at_software_breakpoint>: New field.
6524         * nat/windows-nat.c (windows_thread_info::resume): Clear
6525         stopped_at_software_breakpoint.
6526
6527 2020-04-08  Tom Tromey  <tromey@adacore.com>
6528
6529         * windows-nat.c (enum thread_disposition_type): New.
6530         (thread_rec): Replace "get_context" parameter with "disposition";
6531         change type.
6532         (windows_add_thread, windows_nat_target::fetch_registers)
6533         (windows_nat_target::store_registers, handle_exception)
6534         (windows_nat_target::resume, get_windows_debug_event)
6535         (windows_nat_target::get_tib_address)
6536         (windows_nat_target::thread_name)
6537         (windows_nat_target::thread_alive): Update.
6538
6539 2020-04-08  Tom Tromey  <tromey@adacore.com>
6540
6541         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
6542         (windows_continue): Use windows_continue::resume.
6543         * nat/windows-nat.h (struct windows_thread_info) <suspend,
6544         resume>: Declare new methods.
6545         * nat/windows-nat.c: New file.
6546         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
6547
6548 2020-04-08  Tom Tromey  <tromey@adacore.com>
6549
6550         * windows-nat.c (windows_add_thread, windows_delete_thread)
6551         (windows_nat_target::fetch_registers)
6552         (windows_nat_target::store_registers, fake_create_process)
6553         (windows_nat_target::resume, windows_nat_target::resume)
6554         (get_windows_debug_event, windows_nat_target::wait)
6555         (windows_nat_target::pid_to_str)
6556         (windows_nat_target::get_tib_address)
6557         (windows_nat_target::get_ada_task_ptid)
6558         (windows_nat_target::thread_name)
6559         (windows_nat_target::thread_alive): Use lwp, not tid.
6560
6561 2020-04-08  Tom Tromey  <tromey@adacore.com>
6562
6563         * windows-nat.c (handle_exception)
6564         (windows_nat_target::thread_name): Update.
6565         * nat/windows-nat.h (windows_thread_info): Remove destructor.
6566         <name>: Now unique_xmalloc_ptr.
6567
6568 2020-04-08  Tom Tromey  <tromey@adacore.com>
6569
6570         * windows-nat.c (thread_rec)
6571         (windows_nat_target::fetch_registers): Update.
6572         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
6573         Update comment.
6574         <debug_registers_changed, reload_context>: Now bool.
6575
6576 2020-04-08  Tom Tromey  <tromey@adacore.com>
6577
6578         * windows-nat.c (windows_add_thread): Use new.
6579         (windows_init_thread_list, windows_delete_thread): Use delete.
6580         (get_windows_debug_event): Update.
6581         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
6582         destructor, and initializers.
6583
6584 2020-04-08  Tom Tromey  <tromey@adacore.com>
6585
6586         * windows-nat.c (struct windows_thread_info): Remove.
6587         * nat/windows-nat.h: New file.
6588
6589 2020-04-08  Tom Tromey  <tromey@adacore.com>
6590
6591         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
6592         (thread_rec, windows_add_thread, windows_delete_thread)
6593         (windows_continue): Update.
6594
6595 2020-04-08  Tom Tromey  <tromey@adacore.com>
6596
6597         * windows-nat.c (struct windows_thread_info): Remove typedef.
6598         (thread_head): Remove.
6599         (thread_list): New global.
6600         (thread_rec, windows_add_thread, windows_init_thread_list)
6601         (windows_delete_thread, windows_continue): Update.
6602
6603 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6604
6605         * windows-tdep.h (windows_init_abi): Add comment.
6606         (cygwin_init_abi): New declaration.
6607         * windows-tdep.c: Split signal enumeration in two, one for
6608         Windows and one for Cygwin.
6609         (windows_gdb_signal_to_target): Only deal with signal of the
6610         Windows OS ABI.
6611         (cygwin_gdb_signal_to_target): New function.
6612         (windows_init_abi): Rename to windows_init_abi_common, don't set
6613         gdb_signal_to_target gdbarch method.  Add new new function with
6614         this name.
6615         (cygwin_init_abi): New function.
6616         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
6617         comment.  Don't call windows_init_abi.
6618         (amd64_windows_init_abi): Add comment, call windows_init_abi.
6619         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
6620         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
6621         i386_windows_init_abi_common, don't call windows_init_abi.  Add
6622         a new function of this name.
6623         (i386_cygwin_init_abi): New function.
6624         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
6625         OS ABI Cygwin.
6626
6627 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6628
6629         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
6630         parameter.c.
6631         (dwarf2_read_gdb_index): Update.
6632
6633 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
6634
6635         * nbsd-tdep.c: Include "objfiles.h".
6636         (nbsd_skip_solib_resolver): New.
6637         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
6638
6639 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6640
6641         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
6642         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
6643         with DW_LLE_base_addressx are being emitted in DWARFv5.
6644         Add the newly added kind DW_LOC_OFFSET_PAIR also.
6645         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
6646         unsigned integer.
6647
6648 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6649
6650         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
6651         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
6652         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
6653         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
6654         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
6655         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
6656         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
6657
6658
6659 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6660
6661         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
6662         (read_loclist_index): New function definition.
6663         (lookup_loclist_base): New function definition.
6664         (read_loclist_header): New function definition.
6665         (dwarf2_cu): Add loclist_base and loclist_header field.
6666         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
6667         (read_full_die_1): Read the value of DW_AT_loclists_base.
6668         (read_attribute_reprocess): Handle DW_FORM_loclistx.
6669         (read_attribute_value): Handle DW_FORM_loclistx.
6670         (skip_one_die): Handle DW_FORM_loclistx.
6671         (loclist_header): New structure declaration.
6672         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
6673
6674 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
6675
6676         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
6677         constructor.  Remove `addr` parameter from other constructor and
6678         add `per_cu` parameter.
6679         * dwarf2/read.c (create_partial_symtab): Update.
6680
6681 2020-04-07  Tom de Vries  <tdevries@suse.de>
6682
6683         PR symtab/25796
6684         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
6685         (partial_die_info::fixup): Inherit has_const_value.
6686
6687 2020-04-07  Tom de Vries  <tdevries@suse.de>
6688
6689         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
6690         symbols without address.
6691
6692 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6693
6694         * nbsd-nat.h (struct thread_info): Add forward declaration.
6695         (nbsd_nat_target::thread_alive): Add.
6696         (nbsd_nat_target::thread_name): Likewise.
6697         (nbsd_nat_target::update_thread_list): Likewise.
6698         (update_thread_list::post_attach): Likewise.
6699         (post_attach::pid_to_str): Likewise.
6700         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
6701         (nbsd_thread_lister): Add.
6702         (nbsd_nat_target::thread_alive): Likewise.
6703         (nbsd_nat_target::thread_name): Likewise.
6704         (nbsd_add_threads): Likewise.
6705         (update_thread_list::post_attach): Likewise.
6706         (nbsd_nat_target::update_thread_list): Likewise.
6707         (post_attach::pid_to_str): Likewise.
6708
6709 2020-04-06  Tom Tromey  <tromey@adacore.com>
6710
6711         * ada-valprint.c (print_variant_part): Extract the variant field.
6712         (print_field_values): Use the field as the outer value when
6713         recursing.
6714
6715 2020-04-06  Tom Tromey  <tromey@adacore.com>
6716
6717         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
6718         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
6719         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
6720         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
6721         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
6722
6723 2020-04-06  Tom Tromey  <tromey@adacore.com>
6724
6725         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
6726         TYPE_CODE_ERROR.
6727
6728 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6729
6730         * nbsd-tdep.c: Include "gdbarch.h".
6731         Define enum with NetBSD signal numbers.
6732         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
6733         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
6734         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
6735         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
6736         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
6737         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
6738         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
6739         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
6740         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
6741         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
6742         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
6743         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
6744
6745 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
6746
6747         PR gdb/25325
6748         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
6749
6750 2020-04-03  Tom Tromey  <tromey@adacore.com>
6751
6752         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
6753         Read constant block.
6754
6755 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6756
6757         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
6758         (gdb_bfd_get_full_section_contents): New declaration.
6759         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
6760         * windows-tdep.c (is_linked_with_cygwin_dll): Use
6761         gdb_bfd_get_full_section_contents.
6762
6763 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6764
6765         * exec.c (build_section_table): Replace internal_error with
6766         gdb_assert.
6767         (section_table_xfer_memory_partial): Likewise.
6768         * mdebugread.c (parse_partial_symbols): Likewise.
6769         * psymtab.c (lookup_partial_symbol): Likewise.
6770         * utils.c (wrap_here): Likewise.
6771
6772 2020-04-02  Tom Tromey  <tromey@adacore.com>
6773
6774         * f-lang.c (build_fortran_types): Use arch_type to initialize
6775         builtin_complex_s32 in the TYPE_CODE_ERROR case.
6776
6777 2020-04-02  Tom Tromey  <tromey@adacore.com>
6778
6779         * dwarf2/read.c (partial_die_info::read): Do not create a vector
6780         of attributes.
6781
6782 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6783             Bernd Edlinger <bernd.edlinger@hotmail.de>
6784             Tom Tromey  <tromey@adacore.com>
6785
6786         * buildsym.c (buildsym_compunit::record_line): Remove
6787         deduplication code.
6788
6789 2020-04-02  Tom de Vries  <tdevries@suse.de>
6790
6791         PR ada/24671
6792         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
6793
6794 2020-04-02  Tom de Vries  <tdevries@suse.de>
6795
6796         * dwarf2/read.c (dwarf2_gdb_index_functions,
6797         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
6798         NULL.
6799         * psymtab.c (psym_lookup_global_symbol_language): New function.
6800         (psym_functions): Init psym_lookup_global_symbol_language with
6801         psym_lookup_global_symbol_language.
6802         * symfile-debug.c (debug_sym_quick_functions): Init
6803         lookup_global_symbol_language with NULL.
6804         * symfile.c (set_initial_language): Remove fixme comment.
6805         * symfile.h (struct quick_symbol_functions): Add
6806         lookup_global_symbol_language.
6807         * symtab.c (find_quick_global_symbol_language): New function.
6808         (find_main_name): Use find_quick_global_symbol_language.
6809
6810 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
6811
6812         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
6813
6814 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6815
6816         * buildsym.c (record_line): Fix undefined behavior and preserve
6817         lines at eof.
6818
6819 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6820
6821         * buildsym.c (record_line): Fix the resizing condition.
6822
6823 2020-04-01  Tom Tromey  <tom@tromey.com>
6824
6825         * value.h (value_literal_complex): Add comment.
6826         * valops.c (value_literal_complex): Refer to value.h.
6827
6828 2020-04-01  Tom Tromey  <tom@tromey.com>
6829
6830         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
6831         (scalar_type): New rule, from typebase.
6832         (typebase): Use scalar_type.  Recognize complex types.
6833         (field_name): Handle FLOAT_KEYWORD.
6834         (ident_tokens): Add _Complex and __complex__.
6835
6836 2020-04-01  Tom Tromey  <tom@tromey.com>
6837
6838         PR exp/25299:
6839         * valarith.c (promotion_type, complex_binop): New functions.
6840         (scalar_binop): Handle complex numbers.  Use promotion_type.
6841         (value_pos, value_neg, value_complement): Handle complex numbers.
6842
6843 2020-04-01  Tom Tromey  <tom@tromey.com>
6844
6845         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
6846         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
6847         (parse_number): Handle complex numbers.
6848
6849 2020-04-01  Tom Tromey  <tom@tromey.com>
6850
6851         * c-valprint.c (c_decorations): Change complex suffix to "i".
6852
6853 2020-04-01  Tom Tromey  <tom@tromey.com>
6854
6855         * valprint.c (generic_value_print_complex): Use accessors.
6856         * value.h (value_real_part, value_imaginary_part): Declare.
6857         * valops.c (value_real_part, value_imaginary_part): New
6858         functions.
6859         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
6860
6861 2020-04-01  Tom Tromey  <tom@tromey.com>
6862
6863         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
6864         (read_range_type): Update.
6865         * mdebugread.c (basic_type): Update.
6866         * go-lang.c (build_go_types): Use init_complex_type.
6867         * gdbtypes.h (struct main_type) <complex_type>: New member.
6868         (init_complex_type): Update.
6869         (arch_complex_type): Don't declare.
6870         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
6871         Make name if none given.  Use alloc_type_copy.  Look for cached
6872         complex type.
6873         (arch_complex_type): Remove.
6874         (gdbtypes_post_init): Use init_complex_type.
6875         * f-lang.c (build_fortran_types): Use init_complex_type.
6876         * dwarf2/read.c (read_base_type): Update.
6877         * d-lang.c (build_d_types): Use init_complex_type.
6878         * ctfread.c (read_base_type): Update.
6879
6880 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6881
6882         * infrun.c (stop_all_threads): Update assertion, plus when
6883         stopping threads, take into account that we might be trying
6884         to stop an all-stop target.
6885         (stop_waiting): Call 'stop_all_threads' if there exists a
6886         non-stop target.
6887
6888 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6889
6890         * target.h (exists_non_stop_target): New function declaration.
6891         * target.c (exists_non_stop_target): New function.
6892
6893 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
6894
6895         PR gdb/24789
6896         * eval.c (is_integral_or_integral_reference): New function.
6897         (evaluate_subexp_standard): Allow integer references in
6898         pointer arithmetic.
6899
6900 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6901
6902         * remote.c (remote_target::remote_parse_stop_reply): Remove the
6903         check for no ptid in the stop reply when the target is non-stop.
6904
6905 2020-04-01  Tom Tromey  <tromey@adacore.com>
6906
6907         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
6908         "name" parameter to rvalue reference.  Initialize m_name_holder.
6909         <lookup_name_info>: New overloads.
6910         <name>: Return gdb::string_view.
6911         <c_str>: New method.
6912         <make_ignore_params>: Update.
6913         <search_name_hash>: Update.
6914         <language_lookup_name>: Return const char *.
6915         <m_name>: Change type.
6916         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
6917         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
6918         (lookup_name_info::match_any): Update.
6919         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
6920         Update.
6921         * minsyms.c (linkage_name_str): Update.
6922         * language.c (default_symbol_name_matcher): Update.
6923         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
6924         Update.
6925         * ada-lang.c (ada_fold_name): Change parameter to string_view.
6926         (ada_lookup_name_info::ada_lookup_name_info): Update.
6927         (literal_symbol_name_matcher): Update.
6928
6929 2020-04-01  Tom Tromey  <tromey@adacore.com>
6930
6931         * psymtab.c (psymtab_search_name): Remove function.
6932         (psym_lookup_symbol): Create search name and lookup name here.
6933         (lookup_partial_symbol): Remove "name" parameter; add
6934         lookup_name.
6935         (psym_expand_symtabs_for_function): Update.
6936
6937 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
6938
6939         PR tui/25597:
6940         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
6941
6942 2020-03-31  Tom Tromey  <tromey@adacore.com>
6943
6944         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
6945         memcpy.
6946
6947 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
6948
6949         * features/riscv/32bit-csr.xml: Regenerated.
6950         * features/riscv/64bit-csr.xml: Regenerated.
6951
6952 2020-03-30  Tom Tromey  <tromey@adacore.com>
6953
6954         * ada-valprint.c (print_variant_part): Update.
6955         * ada-lang.h (ada_which_variant_applies): Update.
6956         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
6957         outer_valaddr parameters; replace with "outer" value parameter.
6958         (to_fixed_variant_branch_type): Update.
6959
6960 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6961
6962         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
6963         <list>.  Remove inclusion of observable.h.
6964         (PPC_DEBUG_CURRENT_VERSION): Move up define.
6965         (struct arch_lwp_info): New struct.
6966         (class ppc_linux_dreg_interface): New class.
6967         (struct ppc_linux_process_info): New struct.
6968         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
6969         <low_new_clone, low_forget_process, low_prepare_to_resume>
6970         <copy_thread_dreg_state, mark_thread_stale>
6971         <mark_debug_registers_changed, register_hw_breakpoint>
6972         <clear_hw_breakpoint, register_wp, clear_wp>
6973         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
6974         <num_memory_accesses, get_trigger_type>
6975         <create_watchpoint_request, hwdebug_point_cmp>
6976         <init_arch_lwp_info, get_arch_lwp_info>
6977         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
6978         methods.
6979         <struct ptid_hash>: New inner struct.
6980         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
6981         members.
6982         (saved_dabr_value, hwdebug_info, max_slots_number)
6983         (struct hw_break_tuple, struct thread_points, ppc_threads)
6984         (have_ptrace_hwdebug_interface)
6985         (hwdebug_find_thread_points_by_tid)
6986         (hwdebug_insert_point, hwdebug_remove_point): Remove.
6987         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
6988         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
6989         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
6990         use m_dreg_interface.
6991         (hwdebug_point_cmp): Change to...
6992         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
6993         reference arguments instead of pointers.
6994         (ppc_linux_nat_target::ranged_break_num_registers): Use
6995         m_dreg_interface.
6996         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
6997         m_dreg_interface.  Call register_hw_breakpoint.
6998         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
6999         m_dreg_interface.  Call clear_hw_breakpoint.
7000         (get_trigger_type): Change to...
7001         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
7002         comment.
7003         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
7004         use m_dreg_interface.  Call register_hw_breakpoint.
7005         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
7006         use m_dreg_interface.  Call clear_hw_breakpoint.
7007         (can_use_watchpoint_cond_accel): Change to...
7008         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
7009         method.  Update comment, use m_dreg_interface and
7010         m_process_info.
7011         (calculate_dvc): Change to...
7012         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
7013         m_dreg_interface.
7014         (num_memory_accesses): Change to...
7015         (ppc_linux_nat_target::num_memory_accesses): ...this method.
7016         (check_condition): Change to...
7017         (ppc_linux_nat_target::check_condition): ...this method.
7018         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
7019         comment, use m_dreg_interface.
7020         (create_watchpoint_request): Change to...
7021         (ppc_linux_nat_target::create_watchpoint_request): ...this
7022         method.  Use m_dreg_interface.
7023         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
7024         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
7025         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
7026         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
7027         (ppc_linux_nat_target::low_forget_process)
7028         (ppc_linux_nat_target::low_new_fork)
7029         (ppc_linux_nat_target::low_new_clone)
7030         (ppc_linux_nat_target::low_delete_thread)
7031         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
7032         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
7033         only call mark_thread_stale.
7034         (ppc_linux_thread_exit): Remove.
7035         (ppc_linux_nat_target::stopped_data_address): Change to...
7036         (ppc_linux_nat_target::low_stopped_data_address): This. Add
7037         comment, use m_dreg_interface and m_thread_hw_breakpoints.
7038         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
7039         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
7040         comment.  Call low_stopped_data_address.
7041         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
7042         m_dreg_interface.
7043         (ppc_linux_nat_target::masked_watch_num_registers): Use
7044         m_dreg_interface.
7045         (ppc_linux_nat_target::copy_thread_dreg_state)
7046         (ppc_linux_nat_target::mark_thread_stale)
7047         (ppc_linux_nat_target::mark_debug_registers_changed)
7048         (ppc_linux_nat_target::register_hw_breakpoint)
7049         (ppc_linux_nat_target::clear_hw_breakpoint)
7050         (ppc_linux_nat_target::register_wp)
7051         (ppc_linux_nat_target::clear_wp)
7052         (ppc_linux_nat_target::init_arch_lwp_info)
7053         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
7054         (_initialize_ppc_linux_nat): Remove observer callback.
7055
7056 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7057
7058         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
7059         (ppc_linux_nat_target::auxv_parse)
7060         (ppc_linux_nat_target::read_description)
7061         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
7062         Move up.
7063
7064 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7065
7066         * linux-nat.h (low_new_clone): New method.
7067         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
7068
7069 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7070
7071         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
7072         (dbx_expand_psymtab): ... this.
7073         (start_psymtab): Update.
7074         * mdebugread.c (psymtab_to_symtab_1): Rename to...
7075         (mdebug_expand_psymtab): ... this.
7076         (parse_partial_symbols): Update.
7077         (new_psymtab): Update.
7078         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
7079         (xcoff_expand_psymtab): ... this.
7080         (xcoff_start_psymtab): Update.
7081
7082 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7083
7084         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
7085         <expand_dependencies>: ... this.
7086         * psymtab.c (partial_symtab::read_dependencies): Rename to...
7087         (partial_symtab::expand_dependencies): ... this.
7088         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
7089         Update.
7090         (dwarf2_psymtab::expand_psymtab): Update.
7091         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7092         * mdebugread.c (psymtab_to_symtab_1): Update.
7093         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7094
7095 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7096
7097         * psympriv.h (discard_psymtab): Remove.
7098         * dbxread.c (dbx_end_psymtab): Update.
7099         * xcoffread.c (xcoff_end_psymtab): Update.
7100
7101 2020-03-28  Tom Tromey  <tom@tromey.com>
7102
7103         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
7104         comment.
7105
7106 2020-03-28  Tom Tromey  <tom@tromey.com>
7107
7108         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
7109
7110 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
7111
7112         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
7113
7114 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
7115
7116         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
7117
7118 2020-03-26  Tom Tromey  <tom@tromey.com>
7119
7120         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
7121         (mark_common_block_symbol_computed, read_tag_string_type)
7122         (attr_to_dynamic_prop, read_subrange_type): Update.
7123         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
7124         to be methods on struct attribute.
7125         (skip_one_die, process_imported_unit_die, read_namespace_alias)
7126         (read_call_site_scope, partial_die_info::read)
7127         (partial_die_info::read, lookup_die_type, follow_die_ref):
7128         Update.
7129         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
7130         from dwarf2_get_ref_die_offset.
7131         (attribute::constant_value): New method, from
7132         dwarf2_get_attr_constant_value.
7133         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
7134         Declare method.
7135         <constant_value>: New method.
7136
7137 2020-03-26  Tom Tromey  <tom@tromey.com>
7138
7139         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
7140         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
7141         (dwarf_type_encoding_name): Move to stringify.c.
7142         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
7143         * dwarf2/stringify.c: New file.
7144         * dwarf2/stringify.h: New file.
7145
7146 2020-03-26  Tom Tromey  <tom@tromey.com>
7147
7148         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
7149         Rewrite.
7150
7151 2020-03-26  Tom Tromey  <tom@tromey.com>
7152
7153         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
7154         methods.
7155         * dwarf2/read.c (lookup_addr_base): Move to die.h.
7156         (lookup_ranges_base): Likewise.
7157         (read_cutu_die_from_dwo, read_full_die_1): Update.
7158
7159 2020-03-26  Tom Tromey  <tom@tromey.com>
7160
7161         * dwarf2/read.c (read_import_statement, read_file_scope)
7162         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
7163         (read_lexical_block_scope, read_call_site_scope)
7164         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
7165         (handle_struct_member_die, process_structure_scope)
7166         (update_enumeration_type_from_children)
7167         (process_enumeration_scope, read_array_type, read_common_block)
7168         (read_namespace, read_module, read_subroutine_type): Update.
7169         (sibling_die): Remove.
7170
7171 2020-03-26  Tom Tromey  <tom@tromey.com>
7172
7173         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
7174         (build_type_psymtabs_reader, read_structure_type)
7175         (read_enumeration_type, read_full_die_1): Update.
7176         (dwarf2_attr_no_follow): Move to die.h.
7177         * dwarf2/die.h (struct die_info) <attr>: New method.
7178
7179 2020-03-26  Tom Tromey  <tom@tromey.com>
7180
7181         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
7182         <base_address>: Now an optional.
7183         (dwarf2_find_base_address, dwarf2_rnglists_process)
7184         (dwarf2_ranges_process, fill_in_loclist_baton)
7185         (dwarf2_symbol_mark_computed): Update.
7186
7187 2020-03-26  Tom Tromey  <tom@tromey.com>
7188
7189         * dwarf2/read.c (struct die_info): Move to die.h.
7190         * dwarf2/die.h: New file.
7191
7192 2020-03-26  Tom Tromey  <tom@tromey.com>
7193
7194         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
7195         * dwarf2/read.c
7196         (dwarf2_statement_list_fits_in_line_number_section_complaint):
7197         Move to line-header.c.
7198         (read_checked_initial_length_and_offset, read_formatted_entries):
7199         Likewise.
7200         (dwarf_decode_line_header): Split into two.
7201         * dwarf2/line-header.c
7202         (dwarf2_statement_list_fits_in_line_number_section_complaint):
7203         Move from read.c.
7204         (read_checked_initial_length_and_offset, read_formatted_entries):
7205         Likewise.
7206         (dwarf_decode_line_header): New function, split from read.c.
7207
7208 2020-03-26  Tom Tromey  <tom@tromey.com>
7209
7210         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
7211         Declare method.
7212         * dwarf2/read.c (read_attribute_value): Update.
7213         (dwarf2_per_objfile::read_line_string): Rename from
7214         read_indirect_line_string.
7215         (read_formatted_entries): Update.
7216
7217 2020-03-26  Tom Tromey  <tom@tromey.com>
7218
7219         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
7220         variable.
7221
7222 2020-03-26  Tom Tromey  <tom@tromey.com>
7223
7224         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
7225         const.
7226         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
7227         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
7228         parameter const.
7229
7230 2020-03-26  Tom Tromey  <tom@tromey.com>
7231
7232         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
7233         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
7234         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
7235         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
7236
7237 2020-03-26  Tom Tromey  <tom@tromey.com>
7238
7239         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
7240         file_names_size, file_full_name, file_file_name>: Use const.
7241         <file_name_at, file_names>: Add const overload.
7242         * dwarf2/line-header.c (line_header::file_file_name)
7243         (line_header::file_full_name): Update.
7244
7245 2020-03-26  Tom Tromey  <tom@tromey.com>
7246
7247         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
7248         (macro_start_file, consume_improper_spaces)
7249         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
7250         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
7251         (dwarf_decode_macros): Move to macro.c.
7252         * dwarf2/macro.c: New file.
7253         * dwarf2/macro.h: New file.
7254         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
7255
7256 2020-03-26  Tom Tromey  <tom@tromey.com>
7257
7258         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
7259         method.
7260         * dwarf2/section.c: New method.  From
7261         read_indirect_string_at_offset_from.
7262         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
7263         (read_indirect_string_at_offset_from): Move to section.c.
7264         (read_indirect_string_at_offset): Rewrite.
7265         (read_indirect_line_string_at_offset): Remove.
7266         (read_indirect_string, read_indirect_line_string)
7267         (dwarf_decode_macro_bytes): Update.
7268
7269 2020-03-26  Tom Tromey  <tom@tromey.com>
7270
7271         * dwarf2/section.h (struct dwarf2_section_info)
7272         <overload_complaint>: Declare.
7273         (dwarf2_section_buffer_overflow_complaint): Don't declare.
7274         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
7275         Rename from dwarf2_section_buffer_overflow_complaint.
7276         * dwarf2/read.c (skip_one_die, partial_die_info::read)
7277         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
7278
7279 2020-03-26  Tom Tromey  <tom@tromey.com>
7280
7281         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
7282         Declare.
7283         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
7284         Move from read.c.
7285         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
7286         to section.c.
7287
7288 2020-03-26  Tom Tromey  <tom@tromey.com>
7289
7290         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
7291
7292 2020-03-26  Tom Tromey  <tom@tromey.com>
7293
7294         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
7295         "builder".
7296         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
7297         parameter.
7298         (dwarf_decode_macros): Update.
7299
7300 2020-03-26  Tom Tromey  <tom@tromey.com>
7301
7302         * dwarf2/read.c (read_attribute_value): Update.
7303         (read_indirect_string_from_dwz): Move to dwz.c; change into
7304         method.
7305         (dwarf_decode_macro_bytes): Update.
7306         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
7307         * dwarf2/dwz.c: New file.
7308         * Makefile.in (COMMON_SFILES): Add dwz.c.
7309
7310 2020-03-26  Tom Tromey  <tom@tromey.com>
7311
7312         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
7313         * dwarf2/read.c: Add include.
7314         * dwarf2/index-write.c: Add include.
7315         * dwarf2/index-cache.c: Add include.
7316         * dwarf2/dwz.h: New file.
7317
7318 2020-03-25  Tom Tromey  <tom@tromey.com>
7319
7320         * compile/compile-object-load.c (get_out_value_type): Mention
7321         correct symbol name in error message.
7322
7323 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
7324
7325         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
7326
7327 2020-03-25  Tom de Vries  <tdevries@suse.de>
7328
7329         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
7330         * symmisc.c (dump_symtab_1): Print user and includes fields.
7331         (maintenance_info_symtabs): Same.
7332
7333 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         PR gdb/25534
7336         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
7337         (riscv_regcache_cooked_write): New function.
7338         (riscv_push_dummy_call): Use new function.
7339         (riscv_return_value): Likewise.
7340
7341 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
7342
7343         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
7344         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
7345         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
7346         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
7347         * infrun.c (follow_fork): Likewise.
7348         (follow_fork_inferior): Likewise.
7349         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
7350         * linux-nat.h (class linux_nat_target): Likewise.
7351         * remote.c (class remote_target) <follow_fork>: Likewise.
7352         (remote_target::follow_fork): Likewise.
7353         * target-delegates.c: Re-generate.
7354         * target.c (default_follow_fork): Likewise.
7355         (target_follow_fork): Likewise.
7356         * target.h (struct target_ops) <follow_fork>: Likewise.
7357         (target_follow_fork): Likewise.
7358
7359 2020-03-24  Tom de Vries  <tdevries@suse.de>
7360
7361         * psymtab.c (maintenance_info_psymtabs): Print user field.
7362
7363 2020-03-20  Tom Tromey  <tromey@adacore.com>
7364
7365         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
7366         const.
7367         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
7368         const.
7369
7370 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
7371
7372         * ptrace.m4: Don't check for ptrace declaration.
7373         * config.in: Re-generate.
7374         * configure: Re-generate.
7375         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
7376         not defined.
7377
7378 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7379
7380         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
7381         `PTRACE_TYPE_RET'.
7382         * i386-bsd-nat.c (gdb_ptrace): Likewise.
7383         * sparc-nat.c (gdb_ptrace): Likewise.
7384         * x86-bsd-nat.c (gdb_ptrace): Likewise.
7385
7386 2020-03-20  Tom Tromey  <tromey@adacore.com>
7387
7388         * c-exp.y (lex_one_token): Fix assert.
7389
7390 2020-03-20  Tom Tromey  <tromey@adacore.com>
7391
7392         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
7393         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
7394         strncpy call.
7395
7396 2020-03-20  Tom Tromey  <tromey@adacore.com>
7397
7398         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
7399
7400 2020-03-20  Tom Tromey  <tromey@adacore.com>
7401
7402         * ada-valprint.c (print_variant_part): Remove parameters; switch
7403         to value-based API.
7404         (print_field_values): Likewise.
7405         (ada_val_print_struct_union): Likewise.
7406         (ada_value_print_1): Update.
7407
7408 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7409
7410         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
7411         nbsd_nat_target instead of inf_ptrace_target.
7412         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7413         nbsd_nat_target.
7414
7415 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7416
7417         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
7418         it to the ptrace call.
7419         * (store_registers): Likewise.
7420
7421 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7422
7423         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
7424         it to the ptrace call.
7425         * (store_registers): Likewise.
7426
7427 2020-03-19  Luis Machado  <luis.machado@linaro.org>
7428
7429         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
7430         valid, fetch vg value from ptrace.
7431
7432 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
7433         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
7434         * inf-ptrace.c: Likewise.
7435         * (gdb_ptrace): Add.
7436         * (inf_ptrace_target::resume): Update.
7437         * (inf_ptrace_target::xfer_partial): Likewise.
7438         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
7439         * (inf_ptrace_peek_poke): Update.
7440
7441 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
7442
7443         * x86-bsd-nat.c (gdb_ptrace): New.
7444         * (x86bsd_dr_set): Add new argument `ptid'.
7445         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
7446         x86bsd_dr_set_addr): Update.
7447
7448 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * remote.c (remote_target::process_stop_reply): Handle events for
7451         all threads differently.
7452
7453 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * completer.c (completion_tracker::remove_completion): Define new
7456         function.
7457         * completer.h (completion_tracker::remove_completion): Declare new
7458         function.
7459         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
7460         when adding a C++ function symbol.
7461
7462 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7463
7464         * completer.c (completion_tracker::completion_hash_entry): Define
7465         new class.
7466         (advance_to_filename_complete_word_point): Call
7467         recompute_lowest_common_denominator.
7468         (completion_tracker::completion_tracker): Call discard_completions
7469         to setup the hash table.
7470         (completion_tracker::discard_completions): Allow for being called
7471         from the constructor, pass new equal function, and element deleter
7472         when constructing the hash table.  Initialise new class member
7473         variables.
7474         (completion_tracker::maybe_add_completion): Remove use of
7475         m_entries_vec, and store more information into m_entries_hash.
7476         (completion_tracker::recompute_lcd_visitor): New function, most
7477         content taken from...
7478         (completion_tracker::recompute_lowest_common_denominator):
7479         ...here, this now just visits each item in the hash calling the
7480         above visitor.
7481         (completion_tracker::build_completion_result): Remove use of
7482         m_entries_vec, call recompute_lowest_common_denominator.
7483         * completer.h (completion_tracker::have_completions): Remove use
7484         of m_entries_vec.
7485         (completion_tracker::completion_hash_entry): Declare new class.
7486         (completion_tracker::recompute_lowest_common_denominator): Change
7487         function signature.
7488         (completion_tracker::recompute_lcd_visitor): Declare new function.
7489         (completion_tracker::m_entries_vec): Delete.
7490         (completion_tracker::m_entries_hash): Initialize to NULL.
7491         (completion_tracker::m_lowest_common_denominator_valid): New
7492         member variable.
7493         (completion_tracker::m_lowest_common_denominator_max_length): New
7494         member variable.
7495
7496 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7497
7498         * regformats/regdef.h: Put reg in gdb namespace.
7499
7500 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7501
7502         * i386-bsd-nat.c (gdb_ptrace): New.
7503         * (i386bsd_fetch_inferior_registers,
7504         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
7505         * (i386bsd_fetch_inferior_registers,
7506         i386bsd_store_inferior_registers) Use gdb_ptrace.
7507
7508 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7509
7510         * amd64-bsd-nat.c (gdb_ptrace): New.
7511         * (amd64bsd_fetch_inferior_registers,
7512         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
7513         * (amd64bsd_fetch_inferior_registers,
7514         amd64bsd_store_inferior_registers) Use gdb_ptrace.
7515
7516 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7517
7518         * user-regs.c (user_reg::read): Rename to...
7519         (user_reg::xread): ...this.
7520         * (append_user_reg): Rename argument `read' to `xread'.
7521         * (user_reg_add_builtin): Likewise.
7522         * (user_reg_add): Likewise.
7523         * (value_of_user_reg): Likewise.
7524
7525 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7526
7527         * sparc-nat.c (gdb_ptrace): New.
7528         * sparc-nat.c (sparc_fetch_inferior_registers)
7529         (sparc_store_inferior_registers) Remove obsolete comment.
7530         * sparc-nat.c (sparc_fetch_inferior_registers)
7531         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
7532         * sparc-nat.c (sparc_fetch_inferior_registers)
7533         (sparc_store_inferior_registers) Use gdb_ptrace.
7534
7535 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7536
7537         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
7538         it to the ptrace call.
7539         * sh-nbsd-nat.c (store_registers): Likewise.
7540
7541 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7542
7543         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
7544         nbsd_nat_target instead of inf_ptrace_target.
7545         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7546         nbsd_nat_target.
7547
7548 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7549
7550         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
7551
7552 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7553
7554         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
7555         <sys/sysctl.h>.
7556         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
7557
7558 2020-03-17  Tom de Vries  <tdevries@suse.de>
7559
7560         PR gdb/23710
7561         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
7562         fields.
7563         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
7564         fields.
7565         (process_imported_unit_die): Skip import of c++ CUs.
7566
7567 2020-03-16  Tom Tromey  <tom@tromey.com>
7568
7569         * p-valprint.c (pascal_object_print_value): Initialize
7570         base_value.
7571
7572 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
7573             Shahab Vahedi  <shahab@synopsys.com>
7574
7575         * Makefile.in: Add arch/arc.o
7576         * configure.tgt: Likewise.
7577         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
7578         (_initialize_arc_tdep): Don't initialize old target descriptions.
7579         (arc_read_description): New function to cache target descriptions.
7580         * arc-tdep.h (arc_read_description): Add proto type.
7581         * arch/arc.c: New file.
7582         * arch/arc.h: Likewise.
7583         * features/Makefile: Replace old target descriptions with new.
7584         * features/arc-arcompact.c: Remove.
7585         * features/arc-arcompact.xml: Likewise.
7586         * features/arc-v2.c: Likewise
7587         * features/arc-v2.xml: Likewise
7588         * features/arc/aux-arcompact.xml: New file.
7589         * features/arc/aux-v2.xml: Likewise.
7590         * features/arc/core-arcompact.xml: Likewise.
7591         * features/arc/core-v2.xml: Likewise.
7592         * features/arc/aux-arcompact.c: Generate.
7593         * features/arc/aux-v2.c: Likewise.
7594         * features/arc/core-arcompact.c: Likewise.
7595         * features/arc/core-v2.c: Likewise.
7596         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
7597
7598 2020-03-16  Tom Tromey  <tromey@adacore.com>
7599
7600         PR gdb/25663:
7601         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
7602         putting value into bcache.
7603
7604 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7605
7606         PR gdb/21500
7607         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
7608         to...
7609         (amd64_windows_init_abi_common): ... this.  Don't set size of
7610         long type.
7611         (amd64_windows_init_abi): New function.
7612         (amd64_cygwin_init_abi): New function.
7613         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
7614         the Cygwin OS ABI.
7615         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
7616         comment.
7617
7618 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7619
7620         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
7621         * windows-tdep.c (CYGWIN_DLL_NAME): New.
7622         (pe_import_directory_entry): New struct type.
7623         (is_linked_with_cygwin_dll): New function.
7624         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
7625         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
7626         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
7627
7628 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7629
7630         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
7631         i386_cygwin_core_osabi_sniffer.
7632
7633 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7634
7635         * i386-cygwin-tdep.c: Rename to...
7636         * i386-windows-tdep.c: ... this.
7637         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
7638         i386-windows-tdep.c.
7639         * configure.tgt: Likewise.
7640
7641 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7642
7643         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
7644         * osabi.c (gdb_osabi_names): Add "Windows".
7645         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
7646         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
7647         (i386_cygwin_core_osabi_sniffer): New function, extracted from
7648         i386_cygwin_osabi_sniffer.
7649         (_initialize_i386_cygwin_tdep): Register OS ABI
7650         GDB_OSABI_WINDOWS for i386.
7651         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
7652         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
7653         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
7654         for x86-64.
7655         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
7656         when the target matches '*-*-mingw*'.
7657
7658 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7659
7660         * defs.h (enum gdb_osabi): Move to...
7661         * osabi.h (enum gdb_osabi): ... here.
7662         * gdbarch.sh: Include osabi.h in gdbarch.h.
7663         * gdbarch.h: Re-generate.
7664
7665 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7666
7667         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
7668         function.
7669         (_initialize_amd64_windows_tdep): Register osabi sniffer.
7670
7671 2020-03-14  Tom Tromey  <tom@tromey.com>
7672
7673         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
7674         for C++.
7675         (c_type_print_modifier): Likewise.  Add "language" parameter.
7676         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
7677         (c_type_print_base_1): Update.
7678         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
7679         constants.
7680         * type-stack.c (type_stack::insert): Handle tp_atomic and
7681         tp_restrict.
7682         (type_stack::follow_type_instance_flags): Likewise.
7683         (type_stack::follow_types): Likewise.  Merge type-following code.
7684         * c-exp.y (RESTRICT, ATOMIC): New tokens.
7685         (space_identifier, cv_with_space_id)
7686         (const_or_volatile_or_space_identifier_noopt)
7687         (const_or_volatile_or_space_identifier): Remove.
7688         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
7689         rules.
7690         (ptr_operator, typebase): Update.
7691         (enum token_flag) <FLAG_C>: New constant.
7692         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
7693         "_Atomic".
7694         (lex_one_token): Handle FLAG_C.
7695
7696 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7697
7698         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
7699         it to the ptrace call.
7700         * m68k-bsd-nat.c (store_registers): Likewise.
7701
7702 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7703
7704         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
7705         gdb_byte *.
7706         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
7707         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
7708         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
7709
7710 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7711
7712         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
7713         nbsd_nat_target instead of inf_ptrace_target.
7714         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7715         nbsd_nat_target.
7716
7717 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7718
7719         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
7720         register_t.
7721
7722 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7723
7724         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
7725         it to the ptrace call.
7726         * alpha-bsd-nat.c (store_registers): Likewise.
7727
7728 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7729
7730         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
7731         includes.
7732         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
7733         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
7734         fill_fpregset): Likewise.
7735
7736 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7737
7738         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
7739         nbsd_nat_target instead of inf_ptrace_target.
7740         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7741         nbsd_nat_target.
7742
7743 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7744
7745         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
7746         register_t.
7747
7748 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7749
7750         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
7751         it to the ptrace call.
7752         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
7753         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
7754         * arm-nbsd-nat.c (store_register): Likewise.
7755         * arm-nbsd-nat.c (store_regs): Likewise.
7756         * arm-nbsd-nat.c (store_fp_register): Likewise.
7757         * arm-nbsd-nat.c (store_fp_regs): Likewise.
7758
7759 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7760
7761         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
7762         nbsd_nat_target instead of inf_ptrace_target.
7763         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7764         nbsd_nat_target.
7765
7766 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7767
7768         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
7769         it to the ptrace call.
7770         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
7771
7772 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7773
7774         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
7775         it to the ptrace call.
7776         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
7777
7778 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7779
7780         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
7781         gdb_byte *.
7782         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
7783
7784 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7785
7786         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
7787         instead of inf_ptrace_target.
7788         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7789         nbsd_nat_target.
7790
7791 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7792
7793         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7794         register_t.
7795
7796 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7797
7798         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7799         register_t.
7800
7801 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7802
7803         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
7804         register_t.
7805
7806 2020-03-13  Tom Tromey  <tom@tromey.com>
7807
7808         * value.h (val_print): Don't declare.
7809         * valprint.h (val_print_array_elements)
7810         (val_print_scalar_formatted, generic_val_print): Don't declare.
7811         * valprint.c (generic_val_print_array): Take a struct value.
7812         (generic_val_print_ptr, generic_val_print_memberptr)
7813         (generic_val_print_bool, generic_val_print_int)
7814         (generic_val_print_char, generic_val_print_complex)
7815         (generic_val_print): Remove.
7816         (generic_value_print): Update.
7817         (do_val_print): Remove unused parameters.  Don't call
7818         la_val_print.
7819         (val_print): Remove.
7820         (common_val_print): Update.  Don't call value_check_printable.
7821         (val_print_scalar_formatted, val_print_array_elements): Remove.
7822         * rust-lang.c (rust_val_print): Remove.
7823         (rust_language_defn): Update.
7824         * p-valprint.c (pascal_val_print): Remove.
7825         (pascal_value_print_inner): Update.
7826         (pascal_object_print_val_fields, pascal_object_print_val):
7827         Remove.
7828         (pascal_object_print_static_field): Update.
7829         * p-lang.h (pascal_val_print): Don't declare.
7830         * p-lang.c (pascal_language_defn): Update.
7831         * opencl-lang.c (opencl_language_defn): Update.
7832         * objc-lang.c (objc_language_defn): Update.
7833         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
7834         * m2-lang.h (m2_val_print): Don't declare.
7835         * m2-lang.c (m2_language_defn): Update.
7836         * language.h (struct language_defn) <la_val_print>: Remove.
7837         * language.c (unk_lang_value_print_inner): Rename.  Change
7838         argument types.
7839         (unknown_language_defn, auto_language_defn): Update.
7840         * go-valprint.c (go_val_print): Remove.
7841         * go-lang.h (go_val_print): Don't declare.
7842         * go-lang.c (go_language_defn): Update.
7843         * f-valprint.c (f_val_print): Remove.
7844         * f-lang.h (f_value_print): Don't declare.
7845         * f-lang.c (f_language_defn): Update.
7846         * d-valprint.c (d_val_print): Remove.
7847         * d-lang.h (d_value_print): Don't declare.
7848         * d-lang.c (d_language_defn): Update.
7849         * cp-valprint.c (cp_print_value_fields)
7850         (cp_print_value_fields_rtti, cp_print_value): Remove.
7851         (cp_print_static_field): Update.
7852         * c-valprint.c (c_val_print_array, c_val_print_ptr)
7853         (c_val_print_struct, c_val_print_union, c_val_print_int)
7854         (c_val_print_memberptr, c_val_print): Remove.
7855         * c-lang.h (c_val_print_array, cp_print_value_fields)
7856         (cp_print_value_fields_rtti): Don't declare.
7857         * c-lang.c (c_language_defn, cplus_language_defn)
7858         (asm_language_defn, minimal_language_defn): Update.
7859         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
7860         (ada_val_print_enum): Take a struct value.
7861         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
7862         (ada_val_print): Remove.
7863         (ada_value_print_1): Update.
7864         (printable_val_type): Remove.
7865         * ada-lang.h (ada_val_print): Don't declare.
7866         * ada-lang.c (ada_language_defn): Update.
7867
7868 2020-03-13  Tom Tromey  <tom@tromey.com>
7869
7870         * valprint.c (do_val_print): Update.
7871         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
7872         a struct value.
7873         (value_to_value_object_no_release): Declare.
7874         * python/py-value.c (value_to_value_object_no_release): New
7875         function.
7876         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
7877         struct value.
7878         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
7879         function.
7880         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
7881         a struct value.
7882         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
7883         Declare.
7884         (gdbscm_apply_val_pretty_printer): Take a struct value.
7885         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
7886         value.
7887         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
7888         value.
7889         * extension-priv.h (struct extension_language_ops)
7890         <apply_val_pretty_printer>: Take a struct value.
7891         * cp-valprint.c (cp_print_value): Create a struct value.
7892         (cp_print_value): Update.
7893
7894 2020-03-13  Tom Tromey  <tom@tromey.com>
7895
7896         * ada-valprint.c (print_field_values): Call common_val_print.
7897
7898 2020-03-13  Tom Tromey  <tom@tromey.com>
7899
7900         * ada-valprint.c (val_print_packed_array_elements): Remove
7901         bitoffset and val parameters.  Call common_val_print.
7902         (ada_val_print_string): Remove offset, address, and original_value
7903         parameters.
7904         (ada_val_print_array): Update.
7905         (ada_value_print_array): New function.
7906         (ada_value_print_1): Call it.
7907
7908 2020-03-13  Tom Tromey  <tom@tromey.com>
7909
7910         * ada-valprint.c (ada_value_print): Use common_val_print.
7911
7912 2020-03-13  Tom Tromey  <tom@tromey.com>
7913
7914         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
7915
7916 2020-03-13  Tom Tromey  <tom@tromey.com>
7917
7918         * ada-valprint.c (ada_value_print_num): New function.
7919         (ada_value_print_1): Use it.
7920
7921 2020-03-13  Tom Tromey  <tom@tromey.com>
7922
7923         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
7924
7925 2020-03-13  Tom Tromey  <tom@tromey.com>
7926
7927         * ada-valprint.c (ada_value_print_ptr): New function.
7928         (ada_value_print_1): Use it.
7929
7930 2020-03-13  Tom Tromey  <tom@tromey.com>
7931
7932         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
7933         call common_val_print.
7934         (ada_val_print_1): Update.
7935         (ada_value_print_1): New function.
7936         (ada_value_print_inner): Rewrite.
7937
7938 2020-03-13  Tom Tromey  <tom@tromey.com>
7939
7940         * cp-valprint.c (cp_print_value_fields): Update.
7941         (cp_print_value): New function.
7942
7943 2020-03-13  Tom Tromey  <tom@tromey.com>
7944
7945         * m2-valprint.c (m2_value_print_inner): Use
7946         cp_print_value_fields.
7947         * cp-valprint.c (cp_print_value_fields): New function.
7948         * c-valprint.c (c_value_print_struct): New function.
7949         (c_value_print_inner): Use c_value_print_struct.
7950         * c-lang.h (cp_print_value_fields): Declare.
7951
7952 2020-03-13  Tom Tromey  <tom@tromey.com>
7953
7954         * c-valprint.c (c_value_print_array): New function.
7955         (c_value_print_inner): Use it.
7956
7957 2020-03-13  Tom Tromey  <tom@tromey.com>
7958
7959         * c-valprint.c (c_value_print_memberptr): New function.
7960         (c_value_print_inner): Use it.
7961
7962 2020-03-13  Tom Tromey  <tom@tromey.com>
7963
7964         * c-valprint.c (c_value_print_int): New function.
7965         (c_value_print_inner): Use it.
7966
7967 2020-03-13  Tom Tromey  <tom@tromey.com>
7968
7969         * c-valprint.c (c_value_print_ptr): New function.
7970         (c_value_print_inner): Use it.
7971
7972 2020-03-13  Tom Tromey  <tom@tromey.com>
7973
7974         * c-valprint.c (c_value_print_inner): Rewrite.
7975
7976 2020-03-13  Tom Tromey  <tom@tromey.com>
7977
7978         * valprint.c (generic_value_print_complex): New function.
7979         (generic_value_print): Use it.
7980
7981 2020-03-13  Tom Tromey  <tom@tromey.com>
7982
7983         * valprint.c (generic_val_print_float): Don't call
7984         val_print_scalar_formatted.
7985         (generic_val_print, generic_value_print): Update.
7986
7987 2020-03-13  Tom Tromey  <tom@tromey.com>
7988
7989         * valprint.c (generic_value_print_char): New function
7990         (generic_value_print): Use it.
7991
7992 2020-03-13  Tom Tromey  <tom@tromey.com>
7993
7994         * valprint.c (generic_value_print_int): New function.
7995         (generic_value_print): Use it.
7996
7997 2020-03-13  Tom Tromey  <tom@tromey.com>
7998
7999         * valprint.c (generic_value_print_bool): New function.
8000         (generic_value_print): Use it.
8001
8002 2020-03-13  Tom Tromey  <tom@tromey.com>
8003
8004         * valprint.c (generic_val_print_func): Simplify.
8005         (generic_val_print, generic_value_print): Update.
8006
8007 2020-03-13  Tom Tromey  <tom@tromey.com>
8008
8009         * valprint.c (generic_val_print_flags): Remove.
8010         (generic_val_print, generic_value_print): Update.
8011         (val_print_type_code_flags): Add original_value parameter.
8012
8013 2020-03-13  Tom Tromey  <tom@tromey.com>
8014
8015         * valprint.c (generic_val_print): Update.
8016         (generic_value_print): Update.
8017         * valprint.c (generic_val_print_enum): Don't call
8018         val_print_scalar_formatted.
8019
8020 2020-03-13  Tom Tromey  <tom@tromey.com>
8021
8022         * valprint.c (generic_value_print): Call generic_value_print_ptr.
8023         * valprint.c (generic_value_print_ptr): New function.
8024
8025 2020-03-13  Tom Tromey  <tom@tromey.com>
8026
8027         * valprint.c (generic_value_print): Rewrite.
8028
8029 2020-03-13  Tom Tromey  <tom@tromey.com>
8030
8031         * p-valprint.c (pascal_object_print_value_fields)
8032         (pascal_object_print_value): New functions.
8033
8034 2020-03-13  Tom Tromey  <tom@tromey.com>
8035
8036         * p-valprint.c (pascal_value_print_inner): Rewrite.
8037
8038 2020-03-13  Tom Tromey  <tom@tromey.com>
8039
8040         * f-valprint.c (f_value_print_innner): Rewrite.
8041
8042 2020-03-13  Tom Tromey  <tom@tromey.com>
8043
8044         * m2-valprint.c (m2_print_unbounded_array): New overload.
8045         (m2_print_unbounded_array): Update.
8046         (m2_print_array_contents): Take a struct value.
8047         (m2_value_print_inner): Rewrite.
8048
8049 2020-03-13  Tom Tromey  <tom@tromey.com>
8050
8051         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
8052         (d_value_print_inner): New function.
8053         * d-lang.h (d_value_print_inner): Declare.
8054         * d-lang.c (d_language_defn): Use d_value_print_inner.
8055
8056 2020-03-13  Tom Tromey  <tom@tromey.com>
8057
8058         * go-valprint.c (go_value_print_inner): New function.
8059         * go-lang.h (go_value_print_inner): Declare.
8060         * go-lang.c (go_language_defn): Use go_value_print_inner.
8061
8062 2020-03-13  Tom Tromey  <tom@tromey.com>
8063
8064         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
8065         API.
8066         (rust_val_print): Rewrite.
8067         (rust_value_print_inner): New function, from rust_val_print.
8068         (rust_language_defn): Use rust_value_print_inner.
8069
8070 2020-03-13  Tom Tromey  <tom@tromey.com>
8071
8072         * ada-valprint.c (ada_value_print_inner): New function.
8073         * ada-lang.h (ada_value_print_inner): Declare.
8074         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
8075
8076 2020-03-13  Tom Tromey  <tom@tromey.com>
8077
8078         * f-valprint.c (f_value_print_innner): New function.
8079         * f-lang.h (f_value_print_innner): Declare.
8080         * f-lang.c (f_language_defn): Use f_value_print_innner.
8081
8082 2020-03-13  Tom Tromey  <tom@tromey.com>
8083
8084         * p-valprint.c (pascal_value_print_inner): New function.
8085         * p-lang.h (pascal_value_print_inner): Declare.
8086         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
8087
8088 2020-03-13  Tom Tromey  <tom@tromey.com>
8089
8090         * m2-valprint.c (m2_value_print_inner): New function.
8091         * m2-lang.h (m2_value_print_inner): Declare.
8092         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
8093
8094 2020-03-13  Tom Tromey  <tom@tromey.com>
8095
8096         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
8097         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
8098         * c-valprint.c (c_value_print_inner): New function.
8099         * c-lang.h (c_value_print_inner): Declare.
8100         * c-lang.c (c_language_defn, cplus_language_defn)
8101         (asm_language_defn, minimal_language_defn): Use
8102         c_value_print_inner.
8103
8104 2020-03-13  Tom Tromey  <tom@tromey.com>
8105
8106         * p-valprint.c (pascal_object_print_value_fields): Now static.
8107         * p-lang.h (pascal_object_print_value_fields): Don't declare.
8108
8109 2020-03-13  Tom Tromey  <tom@tromey.com>
8110
8111         * c-valprint.c (c_val_print_array): Simplify.
8112
8113 2020-03-13  Tom Tromey  <tom@tromey.com>
8114
8115         * valprint.c (value_print_array_elements): New function.
8116         * valprint.h (value_print_array_elements): Declare.
8117
8118 2020-03-13  Tom Tromey  <tom@tromey.com>
8119
8120         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
8121         * mips-tdep.c (mips_print_register): Use
8122         value_print_scalar_formatted.
8123
8124 2020-03-13  Tom Tromey  <tom@tromey.com>
8125
8126         * valprint.h (value_print_scalar_formatted): Declare.
8127         * valprint.c (value_print_scalar_formatted): New function.
8128
8129 2020-03-13  Tom Tromey  <tom@tromey.com>
8130
8131         * valprint.h (generic_value_print): Declare.
8132         * valprint.c (generic_value_print): New function.
8133
8134 2020-03-13  Tom Tromey  <tom@tromey.com>
8135
8136         * valprint.c (do_val_print): Call la_value_print_inner, if
8137         available.
8138         * rust-lang.c (rust_language_defn): Update.
8139         * p-lang.c (pascal_language_defn): Update.
8140         * opencl-lang.c (opencl_language_defn): Update.
8141         * objc-lang.c (objc_language_defn): Update.
8142         * m2-lang.c (m2_language_defn): Update.
8143         * language.h (struct language_defn) <la_value_print_inner>: New
8144         member.
8145         * language.c (unknown_language_defn, auto_language_defn): Update.
8146         * go-lang.c (go_language_defn): Update.
8147         * f-lang.c (f_language_defn): Update.
8148         * d-lang.c (d_language_defn): Update.
8149         * c-lang.c (c_language_defn, cplus_language_defn)
8150         (asm_language_defn, minimal_language_defn): Update.
8151         * ada-lang.c (ada_language_defn): Update.
8152
8153 2020-03-13  Tom Tromey  <tom@tromey.com>
8154
8155         * c-valprint.c (c_value_print): Use common_val_print.
8156
8157 2020-03-13  Tom Tromey  <tom@tromey.com>
8158
8159         * cp-valprint.c (cp_print_static_field): Use common_val_print.
8160
8161 2020-03-13  Tom Tromey  <tom@tromey.com>
8162
8163         * f-valprint.c (f77_print_array_1, f_val_print): Use
8164         common_val_print.
8165
8166 2020-03-13  Tom Tromey  <tom@tromey.com>
8167
8168         * riscv-tdep.c (riscv_print_one_register_info): Use
8169         common_val_print.
8170
8171 2020-03-13  Tom Tromey  <tom@tromey.com>
8172
8173         * mi/mi-main.c (output_register): Use common_val_print.
8174
8175 2020-03-13  Tom Tromey  <tom@tromey.com>
8176
8177         * infcmd.c (default_print_one_register_info): Use
8178         common_val_print.
8179
8180 2020-03-13  Tom Tromey  <tom@tromey.com>
8181
8182         * valprint.h (common_val_print_checked): Declare.
8183         * valprint.c (common_val_print_checked): New function.
8184         * stack.c (print_frame_arg): Use common_val_print_checked.
8185
8186 2020-03-13  Tom Tromey  <tom@tromey.com>
8187
8188         * valprint.c (do_val_print): New function, from val_print.
8189         (val_print): Use do_val_print.
8190         (common_val_print): Use do_val_print.
8191
8192 2020-03-13  Tom Tromey  <tom@tromey.com>
8193
8194         * valprint.c (value_print): Use scoped_value_mark.
8195
8196 2020-03-13  Tom de Vries  <tdevries@suse.de>
8197
8198         PR symtab/25646
8199         * psymtab.c (partial_symtab::partial_symtab): Don't set
8200         globals_offset and statics_offset.  Push element onto
8201         current_global_psymbols and current_static_psymbols stacks.
8202         (concat): New function.
8203         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
8204         element from current_global_psymbols and current_static_psymbols
8205         stacks.  Concat popped elements to global_psymbols and
8206         static_symbols.
8207         (add_psymbol_to_list): Use current_global_psymbols and
8208         current_static_psymbols stacks.
8209         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
8210         current_static_psymbols fields.
8211
8212 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
8213
8214         * corelow.c (sniff_core_bfd): Remove.
8215         (class core_target) <m_core_vec>: Remove.
8216         (core_target::core_target): Update.
8217         (core_file_fns): Remove.
8218         (deprecated_add_core_fns): Remove.
8219         (default_core_sniffer): Remove.
8220         (sniff_core_bfd): Remove.
8221         (default_check_format): Remove.
8222         (gdb_check_format): Remove.
8223         (core_target_open): Update.
8224         (core_target::get_core_register_section): Update.
8225         (get_core_registers_cb): Update.
8226         (core_target::fetch_registers): Update.
8227         * gdbcore.h (struct core_fns): Remove.
8228         (deprecated_add_core_fns): Remove.
8229         (default_core_sniffer): Remove.
8230         (default_check_format): Remove.
8231
8232 2020-03-12  Tom Tromey  <tom@tromey.com>
8233
8234         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
8235         CORE_ADDR.
8236         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
8237
8238 2020-03-12  Tom Tromey  <tom@tromey.com>
8239
8240         * remote.c (remote_target::download_tracepoint)
8241         (remote_target::enable_tracepoint)
8242         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
8243         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
8244         sprintf_vma.
8245
8246 2020-03-12  Tom Tromey  <tom@tromey.com>
8247
8248         * symfile-mem.c: Update CORE_ADDR size assert.
8249
8250 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8251
8252         * selftest.m4: Move to gdbsupport/.
8253         * acinclude.m4: Update path to selftest.m4.
8254
8255 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8256
8257         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
8258         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
8259         gdbarch-selfselftests.c and selftest-arch.c.
8260         (SUBDIR_UNITTESTS_OBS): Rename to...
8261         (SELFTESTS_OBS): ... this.
8262         (COMMON_SFILES): Remove disasm-selftests.c and
8263         gdbarch-selftests.c.
8264         * configure.ac: Don't add selftest-arch.{c,o} to
8265         CONFIG_{SRCS,OBS}.
8266         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
8267         preprocessor conditions.
8268
8269 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8270
8271         * configure.ac: Don't source bfd/development.sh.
8272         * selftest.m4: Modify comment.
8273         * configure: Re-generate.
8274
8275 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8276
8277         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
8278         not "true" or "false".
8279         * configure: Re-generate.
8280
8281 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
8282
8283         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
8284         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
8285         renamed to arm_nbsd_supply_gregset.
8286         (fetch_register): Update to call arm_nbsd_supply_gregset.
8287         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
8288         (arm_netbsd_nat_target::fetch_registers): Update.
8289         (fetch_elfcore_registers): Removed.
8290         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
8291         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
8292         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
8293         not require NetBSD system headers.
8294         (arm_nbsd_regset): New struct.
8295         (arm_nbsd_iterate_over_regset_sections): New function.
8296         (arm_netbsd_init_abi_common): Updated to call
8297         set_gdbarch_iterate_over_regset_sections.
8298         * arm-nbsd-tdep.h: New file.
8299
8300 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
8301
8302         * symtab.c (find_pc_sect_line): Add check which prevents infinite
8303         recursion.
8304
8305 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
8306
8307         * configure: Re-generate.
8308
8309 2020-03-11  Tom Tromey  <tromey@adacore.com>
8310
8311         * ada-typeprint.c (print_choices): Fix comment.
8312
8313 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
8316         previous item in the list, when the list has no items.
8317
8318 2020-03-11  Tom de Vries  <tdevries@suse.de>
8319
8320         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
8321         PROP_LOCLIST handling code.
8322
8323 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * buildsym-legacy.c (record_line): Pass extra parameter to
8326         record_line.
8327         * buildsym.c (buildsym_compunit::record_line): Take an extra
8328         parameter, reduce duplication in the line table, and record the
8329         is_stmt flag in the line table.
8330         * buildsym.h (buildsym_compunit::record_line): Add extra
8331         parameter.
8332         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
8333         non-statement lines.
8334         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
8335         this to the symtab builder.
8336         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
8337         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
8338         through to dwarf_record_line_1.
8339         * infrun.c (process_event_stop_test): When stepping, don't stop at
8340         a non-statement instruction, and only refresh the step info when
8341         we land in the middle of a line's range.  Also add an extra
8342         comment.
8343         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
8344         field.
8345         * record-btrace.c (btrace_find_line_range): Only record lines
8346         marked as is-statement.
8347         * stack.c (frame_show_address): Show the frame address if we are
8348         in a non-statement sal.
8349         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
8350         (maintenance_print_one_line_table): Print a header for the is_stmt
8351         column, and include is_stmt information in the output.
8352         * symtab.c (find_pc_sect_line): Find lines marked as statements in
8353         preference to non-statements.
8354         (find_pcs_for_symtab_line): Prefer is-statement entries.
8355         (find_line_common): Likewise.
8356         * symtab.h (struct linetable_entry): Add is_stmt field.
8357         (struct symtab_and_line): Likewise.
8358         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
8359         arranging the line table.
8360
8361 2020-03-07  Tom de Vries  <tdevries@suse.de>
8362
8363         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
8364         DIE.
8365
8366 2020-03-07  Tom Tromey  <tom@tromey.com>
8367
8368         * valops.c (value_literal_complex): Remove obsolete comment.
8369         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
8370         comment.
8371
8372 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8373
8374         * infrun.h: Forward-declare thread_info.
8375         (set_step_info): Add thread_info parameter, add doc.
8376         * infrun.c (set_step_info): Add thread_info parameter, move doc
8377         to header.
8378         * infrun.c (process_event_stop_test): Pass thread to
8379         set_step_info call.
8380         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
8381         set_step_info.
8382         (prepare_one_step): Add thread_info parameter, pass it to
8383         set_step_frame and prepare_one_step (recursive) call.
8384         (step_1): Pass thread to prepare_one_step call.
8385         (step_command_fsm::should_stop): Pass thread to
8386         prepare_one_step.
8387         (until_next_fsm): Pass thread to set_step_frame call.
8388         (finish_command): Pass thread to set_step_info call.
8389
8390 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
8391
8392         * windows-tdep.c (windows_solib_create_inferior_hook):
8393         Check if inferior is running.
8394
8395 2020-03-06  Tom de Vries  <tdevries@suse.de>
8396
8397         * NEWS: Fix "the the".
8398         * ctfread.c: Same.
8399
8400 2020-03-06  Tom de Vries  <tdevries@suse.de>
8401
8402         * psymtab.c (psymtab_to_symtab): Don't print "done.".
8403
8404 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8405
8406         * .dir-locals.el: Add a comment referencing the other copies of
8407         this file.
8408
8409 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
8410
8411         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
8412         psargs.
8413
8414 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8415
8416         * .gitattributes: New file.
8417
8418 2020-03-04  Tom Tromey  <tom@tromey.com>
8419
8420         * symmisc.c (print_symbol_bcache_statistics)
8421         (print_objfile_statistics): Update.
8422         * symfile.c (allocate_symtab): Use intern.
8423         * psymtab.c (partial_symtab::partial_symtab): Use intern.
8424         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8425         macro_cache>: Remove.
8426         <string_cache>: New member.
8427         (struct objfile) <intern>: New methods.
8428         * elfread.c (elf_symtab_read): Use intern.
8429         * dwarf2/read.c (fixup_go_packaging): Intern package name.
8430         (dwarf2_compute_name, dwarf2_physname)
8431         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
8432         names.
8433         (guess_partial_die_structure_name): Update.
8434         (partial_die_info::fixup): Intern name.
8435         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
8436         name.
8437         (dwarf2_name): Intern name.  Update.
8438         * buildsym.c (buildsym_compunit::get_macro_table): Use
8439         string_cache.
8440
8441 2020-03-04  Tom Tromey  <tom@tromey.com>
8442
8443         * jit.c (bfd_open_from_target_memory): Make "target" const.
8444         * corefile.c (gnutarget): Now const.
8445         * gdbcore.h (gnutarget): Now const.
8446
8447 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
8448
8449         * NEWS: Mention support for WOW64 processes.
8450         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
8451         (amd64_windows_segment_register_p): Remove static.
8452         (_initialize_amd64_windows_nat): Update.
8453         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
8454         * i386-windows-nat.c (context_offset): Update.
8455         (i386_mappings): Rename and remove static.
8456         (i386_windows_segment_register_p): Remove static.
8457         (_initialize_i386_windows_nat): Update.
8458         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
8459         (STATUS_WX86_SINGLE_STEP): New macro.
8460         (EnumProcessModulesEx): New macro.
8461         (Wow64SuspendThread): New macro.
8462         (Wow64GetThreadContext): New macro.
8463         (Wow64SetThreadContext): New macro.
8464         (Wow64GetThreadSelectorEntry): New macro.
8465         (windows_set_context_register_offsets): Add static.
8466         (windows_set_segment_register_p): Likewise.
8467         (windows_add_thread): Adapt for WOW64 processes.
8468         (windows_fetch_one_register): Likewise.
8469         (windows_nat_target::fetch_registers): Likewise.
8470         (windows_store_one_register): Likewise.
8471         (display_selector): Likewise.
8472         (display_selectors): Likewise.
8473         (handle_exception): Likewise.
8474         (windows_continue): Likewise.
8475         (windows_nat_target::resume): Likewise.
8476         (windows_add_all_dlls): Likewise.
8477         (do_initial_windows_stuff): Likewise.
8478         (windows_nat_target::attach): Likewise.
8479         (windows_get_exec_module_filename): Likewise.
8480         (windows_nat_target::create_inferior): Likewise.
8481         (windows_xfer_siginfo): Likewise.
8482         (_initialize_loadable): Initialize Wow64SuspendThread,
8483         Wow64GetThreadContext, Wow64SetThreadContext,
8484         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
8485         * windows-nat.h (windows_set_context_register_offsets):
8486         Remove declaration.
8487         (windows_set_segment_register_p): Likewise.
8488         (i386_windows_segment_register_p): Add declaration.
8489         (amd64_windows_segment_register_p): Likewise.
8490
8491 2020-03-04  Luis Machado  <luis.machado@linaro.org>
8492
8493         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
8494         in "info registers" for AArch64/ARM.
8495
8496         The change caused "info registers" to not print GPR's.
8497
8498         gdb/ChangeLog:
8499
8500         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8501
8502         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8503         when reg->group is empty and reggroup is not.
8504
8505 2020-03-03  Tom Tromey  <tromey@adacore.com>
8506
8507         * dwarf2/frame.c (struct dwarf2_frame_cache)
8508         <checked_tailcall_bottom, entry_cfa_sp_offset,
8509         entry_cfa_sp_offset_p>: Remove members.
8510         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
8511         (dwarf2_frame_prev_register): Don't call
8512         dwarf2_tailcall_sniffer_first.
8513         (dwarf2_append_unwinders): Don't append tailcall unwinder.
8514         * frame-unwind.c (add_unwinder): New fuction.
8515         (frame_unwind_init): Use it.  Add tailcall unwinder.
8516
8517 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8518             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8519
8520         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
8521         value should be printed as true.
8522
8523 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
8524
8525         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
8526         (windows_init_abi): Set and use windows_so_ops.
8527
8528 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
8529
8530         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
8531         when verifying if dealing with a convenience variable.
8532
8533 2020-03-03  Luis Machado  <luis.machado@linaro.org>
8534
8535         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
8536
8537 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8538
8539         * infrun.c (gdbarch_supports_displaced_stepping): New.
8540         (use_displaced_stepping): Break up conditions in smaller pieces.
8541         Use gdbarch_supports_displaced_stepping.
8542         (displaced_step_prepare_throw): Use
8543         gdbarch_supports_displaced_stepping.
8544
8545 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8546
8547         * NEWS: Mention new behaviour of the history filename.
8548         * top.c (write_history_p): Add comment.
8549         (show_write_history_p): Add header comment, give a different
8550         message when history writing is on, but the history filename is
8551         empty.
8552         (history_filename): Add comment.
8553         (history_filename_empty): New function.
8554         (show_history_filename): Add header comment, give a different
8555         message when the filename is empty.
8556         (init_history): Compare history_filename against nullptr, and only
8557         read history if the filename is not empty.
8558         (set_history_filename): Add header comment, and only make
8559         non-empty filenames absolute.
8560         (init_main): Make the filename argument to 'set history filename'
8561         optional.
8562
8563 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
8564
8565         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
8566         (arm_supply_vfpregset): ...this, and update to use VFP registers.
8567         (fetch_fp_register): Update.
8568         (fetch_fp_regs): Update.
8569         (store_fp_register): Update.
8570         (store_fp_regs): Update.
8571         (arm_netbsd_nat_target::read_description): New function.
8572         (fetch_elfcore_registers): Update.
8573
8574 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
8577         general_thread if the stop reply is missing a thread-id.
8578         (remote_target::process_stop_reply): Use the first non-exited
8579         thread if the target didn't pass a thread-id.
8580         * infrun.c (do_target_wait): Move call to
8581         switch_to_inferior_no_thread to ....
8582         (do_target_wait_1): ... here.
8583
8584 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
8585
8586         * debuginfod-support.c: Include defs.h first.
8587
8588 2020-02-28  Tom de Vries  <tdevries@suse.de>
8589
8590         * symfile.c (set_initial_language): Use default language for lookup.
8591
8592 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
8593
8594         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
8595         reader variable, pass `this` to read_cutu_die_from_dwo.
8596
8597 2020-02-27  Aaron Merey  <amerey@redhat.com>
8598
8599         * source.c (open_source_file): Check for nullptr when computing
8600         srcpath.
8601
8602 2020-02-27  Tom Tromey  <tromey@adacore.com>
8603
8604         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
8605         member.
8606         (dwarf2_add_field): Don't update nfields.
8607         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
8608
8609 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
8612         abs.
8613
8614 2020-02-26  Tom Tromey  <tom@tromey.com>
8615
8616         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
8617         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
8618         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
8619         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
8620         per_cu_data.
8621
8622 2020-02-26  Tom Tromey  <tom@tromey.com>
8623
8624         * dwarf2/index-write.c (psym_index_map): Change type.
8625         (add_address_entry_worker, write_one_signatured_type)
8626         (recursively_count_psymbols, recursively_write_psymbols)
8627         (class debug_names, psyms_seen_size, write_gdbindex)
8628         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
8629
8630 2020-02-26  Aaron Merey  <amerey@redhat.com>
8631
8632         * Makefile.in: Handle optional debuginfod support.
8633         * NEWS: Update.
8634         * README: Add --with-debuginfod summary.
8635         * config.in: Regenerate.
8636         * configure: Regenerate.
8637         * configure.ac: Handle optional debuginfod support.
8638         * debuginfod-support.c: debuginfod helper functions.
8639         * debuginfod-support.h: Ditto.
8640         * doc/gdb.texinfo: Add --with-debuginfod to configure options
8641         summary.
8642         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
8643         when a dwz file cannot be found.
8644         * elfread.c (elf_symfile_read): Query debuginfod servers when a
8645         debuginfo file cannot be found.
8646         * source.c (open_source_file): Query debuginfod servers when a
8647         source file cannot be found.
8648         * top.c (print_gdb_configuration): Include
8649         --{with,without}-debuginfod in the output.
8650
8651 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
8652
8653         * thread.c (thr_try_catch_cmd): Print thread name.
8654
8655 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
8656
8657         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
8658         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8659         dwarf2_fetch_die_type_sect_off): Move to...
8660         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
8661         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8662         dwarf2_fetch_die_type_sect_off): ... here.
8663         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
8664         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8665         dwarf2_fetch_die_type_sect_off): Move doc to header file.
8666
8667 2020-02-26  Tom de Vries  <tdevries@suse.de>
8668
8669         PR gdb/25603
8670         * symfile.c (set_initial_language): Exit-early if
8671         language_mode == language_mode_manual.
8672
8673 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8674
8675         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
8676         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
8677         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
8678
8679 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
8680
8681         * gdbtypes.c (create_array_type_with_stride): Handle negative
8682         array strides.
8683         * valarith.c (value_subscripted_rvalue): Likewise.
8684
8685 2020-02-25  Luis Machado  <luis.machado@linaro.org>
8686
8687         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
8688
8689 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8690
8691         * loc.h (dwarf2_get_die_type): Move to...
8692         * read.h (dwarf2_get_die_type): ... here.
8693         * read.c (dwarf2_get_die_type): Move doc to header.
8694
8695 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
8696
8697         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
8698         'gnulib/Makefile.in' to the list.
8699
8700 2020-02-24  Tom Tromey  <tom@tromey.com>
8701
8702         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
8703         Remove.
8704         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
8705         XOBNEWVEC.
8706
8707 2020-02-24  Tom Tromey  <tom@tromey.com>
8708
8709         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
8710         New method.
8711         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
8712         (dw2_do_instantiate_symtab, dw2_get_file_names)
8713         (build_type_psymtab_dependencies, load_full_type_unit): Update.
8714
8715 2020-02-24  Tom Tromey  <tom@tromey.com>
8716
8717         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
8718         make_scoped_restore.
8719         (dwarf2_psymtab::read_symtab): Don't clear
8720         reading_partial_symbols.
8721
8722 2020-02-24  Tom de Vries  <tdevries@suse.de>
8723
8724         PR gdb/25592
8725         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
8726
8727 2020-02-24  Tom de Vries  <tdevries@suse.de>
8728
8729         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
8730         commands layout next/prev/regs.
8731
8732 2020-02-22  Tom Tromey  <tom@tromey.com>
8733
8734         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
8735         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
8736
8737 2020-02-22  Tom Tromey  <tom@tromey.com>
8738
8739         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
8740
8741 2020-02-22  Tom Tromey  <tom@tromey.com>
8742
8743         * tui/tui-win.c (_initialize_tui_win): Add usage text.
8744         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
8745         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
8746         * tui/tui.c (_initialize_tui): Add usage text.
8747
8748 2020-02-22  Tom Tromey  <tom@tromey.com>
8749
8750         * tui/tui-win.c (tui_set_focus_command)
8751         (tui_set_win_height_command): Use error_no_arg.
8752         (_initialize_tui_win): Update help text.
8753         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
8754
8755 2020-02-22  Tom Tromey  <tom@tromey.com>
8756
8757         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
8758         * tui/tui-disasm.h (struct tui_disasm_window)
8759         <display_start_addr>: Declare.
8760         * tui/tui-source.h (struct tui_source_window)
8761         <display_start_addr>: Declare.
8762         * tui/tui-winsource.h (struct tui_source_window_base)
8763         <show_source_line, display_start_addr>: New methods.
8764         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
8765         Rename and move to protected section.
8766         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
8767         (tui_source_window_base::do_erase_source_content): Update.
8768         (tui_source_window_base::show_source_line): Now a method.
8769         (tui_source_window_base::show_source_content)
8770         (tui_source_window_base::tui_source_window_base)
8771         (tui_source_window_base::rerender)
8772         (tui_source_window_base::refill)
8773         (tui_source_window_base::do_scroll_horizontal)
8774         (tui_source_window_base::set_is_exec_point_at)
8775         (tui_source_window_base::update_breakpoint_info)
8776         (tui_source_window_base::update_exec_info): Update.
8777         * tui/tui-source.c (tui_source_window::set_contents)
8778         (tui_source_window::showing_source_p)
8779         (tui_source_window::do_scroll_vertical)
8780         (tui_source_window::location_matches_p)
8781         (tui_source_window::line_is_displayed): Update.
8782         (tui_source_window::display_start_addr): New method.
8783         * tui/tui-disasm.c (tui_disasm_window::set_contents)
8784         (tui_disasm_window::do_scroll_vertical)
8785         (tui_disasm_window::location_matches_p): Update.
8786         (tui_disasm_window::display_start_addr): New method.
8787
8788 2020-02-22  Tom Tromey  <tom@tromey.com>
8789
8790         * NEWS: Add entry for gdb.register_window_type.
8791         * tui/tui-layout.h (window_factory): New typedef.
8792         (tui_register_window): Declare.
8793         * tui/tui-layout.c (saved_tui_windows): New global.
8794         (tui_apply_current_layout): Use it.
8795         (tui_register_window): New function.
8796         * python/python.c (do_start_initialization): Call
8797         gdbpy_initialize_tui.
8798         (python_GdbMethods): Add "register_window_type" function.
8799         * python/python-internal.h (gdbpy_register_tui_window)
8800         (gdbpy_initialize_tui): Declare.
8801         * python/py-tui.c: New file.
8802         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
8803
8804 2020-02-22  Tom Tromey  <tom@tromey.com>
8805
8806         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
8807
8808 2020-02-22  Tom Tromey  <tom@tromey.com>
8809
8810         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
8811         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
8812         * tui/tui-data.c (tui_set_win_with_focus): Remove.
8813         (tui_set_win_focus_to): Move from tui-win.c.
8814
8815 2020-02-22  Tom Tromey  <tom@tromey.com>
8816
8817         * tui/tui-layout.c (make_standard_window, get_locator_window): New
8818         functions.
8819         (known_window_types): New global.
8820         (tui_get_window_by_name): Reimplement.
8821         (initialize_known_windows): New function.
8822         (validate_window_name): Rewrite.
8823         (_initialize_tui_layout): Call initialize_known_windows.
8824
8825 2020-02-22  Tom Tromey  <tom@tromey.com>
8826
8827         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
8828         Remove constants.
8829         * tui/tui-winsource.h (struct tui_source_window_base)
8830         <tui_source_window_base>: Remove parameter.
8831         * tui/tui-winsource.c
8832         (tui_source_window_base::tui_source_window_base): Remove
8833         parameter.
8834         (tui_source_window_base::refill): Update.
8835         * tui/tui-stack.h (struct tui_locator_window)
8836         <tui_locator_window>: Update.
8837         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
8838         Default the constructor.
8839         * tui/tui-regs.h (struct tui_data_item_window)
8840         <tui_data_item_window>: Default the constructor.
8841         (struct tui_data_window) <tui_data_window>: Likewise.
8842         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
8843         Default the constructor.
8844         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
8845         Default the constructor.
8846         <type>: Remove.
8847         (struct tui_win_info) <tui_win_info>: Default the constructor.
8848         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
8849         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
8850         Default the constructor.
8851
8852 2020-02-22  Tom Tromey  <tom@tromey.com>
8853
8854         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
8855         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
8856         * tui/tui-win.c (tui_resize_all): Don't call
8857         tui_delete_invisible_windows.
8858         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
8859         done.
8860         (tui_set_layout): Update.
8861         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
8862         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
8863         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
8864
8865 2020-02-22  Tom Tromey  <tom@tromey.com>
8866
8867         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
8868         correctly.
8869
8870 2020-02-22  Tom Tromey  <tom@tromey.com>
8871
8872         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
8873
8874 2020-02-22  Tom Tromey  <tom@tromey.com>
8875
8876         * tui/tui-winsource.h (struct tui_source_window_iterator)
8877         <inner_iterator>: New etytypedef.
8878         <tui_source_window_iterator>: Take "end" parameter.
8879         <tui_source_window_iterator>: Take iterator.
8880         <operator*, advance>: Update.
8881         <m_iter>: Change type.
8882         <m_end>: New field.
8883         (struct tui_source_windows) <begin, end>: Update.
8884         * tui/tui-layout.c (tui_windows): New global.
8885         (tui_apply_current_layout): Clear tui_windows.
8886         (tui_layout_window::apply): Update tui_windows.
8887         * tui/tui-data.h (tui_windows): Declare.
8888         (all_tui_windows): Now inline function.
8889         (class tui_window_iterator, struct all_tui_windows): Remove.
8890
8891 2020-02-22  Tom Tromey  <tom@tromey.com>
8892
8893         PR tui/17850:
8894         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
8895         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
8896         "height" argument.
8897         (class tui_layout_window) <get_sizes>: Likewise.
8898         (class tui_layout_split) <tui_layout_split>: Add "vertical"
8899         argument.
8900         <get_sizes>: Add "height" argument.
8901         <m_vertical>: New field.
8902         * tui/tui-layout.c (tui_layout_split::clone): Update.
8903         (tui_layout_split::get_sizes): Add "height" argument.
8904         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
8905         (tui_new_layout_command): Parse "-horizontal".
8906         (_initialize_tui_layout): Update help string.
8907         (tui_layout_split::specification): Add "-horizontal" when needed.
8908         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
8909         argument.
8910         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
8911         New methods.
8912
8913 2020-02-22  Tom Tromey  <tom@tromey.com>
8914
8915         * tui/tui-layout.h (enum tui_adjust_result): New.
8916         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
8917         (class tui_layout_window) <adjust_size>: Return
8918         tui_adjust_result.  Rewrite.
8919         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
8920         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
8921
8922 2020-02-22  Tom Tromey  <tom@tromey.com>
8923
8924         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
8925         parameter and return types.
8926         (class tui_layout_base) <specification>: Add "depth".
8927         (class tui_layout_window) <specification>: Add "depth".
8928         (class tui_layout_split) <specification>: Add "depth".
8929         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
8930         and return types.
8931         (tui_new_layout_command): Parse sub-layouts.
8932         (_initialize_tui_layout): Update help string.
8933         (tui_layout_window::specification): Add "depth".
8934         (add_layout_command): Update.
8935
8936 2020-02-22  Tom Tromey  <tom@tromey.com>
8937
8938         * NEWS: Add "tui new-layout" item.
8939         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
8940         Add new-layout command to help text.
8941         (validate_window_name): New function.
8942         (tui_new_layout_command): New function.
8943         (_initialize_tui_layout): Register "new-layout".
8944         (tui_layout_window::specification): New method.
8945         (tui_layout_window::specification): New method.
8946         * tui/tui-layout.h (class tui_layout_base) <specification>: New
8947         method.
8948         (class tui_layout_window) <specification>: New method.
8949         (class tui_layout_split) <specification>: New method.
8950
8951 2020-02-22  Tom Tromey  <tom@tromey.com>
8952
8953         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
8954         * tui/tui-win.c (window_name_completer): Update comment.
8955         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
8956         Declare method.
8957         (class tui_layout_window) <replace_window>: Likewise.
8958         (class tui_layout_split) <replace_window>: Likewise.
8959         (tui_set_layout): Don't declare.
8960         (tui_set_initial_layout): Declare function.
8961         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
8962         (asm_regs_layout): New globals.
8963         (tui_current_layout, show_layout): Remove.
8964         (tui_set_layout, tui_add_win_to_layout): Rewrite.
8965         (find_layout, tui_apply_layout): New function.
8966         (layout_completer): Remove.
8967         (tui_next_layout): Reimplement.
8968         (tui_next_layout_command): New function.
8969         (tui_set_initial_layout, tui_prev_layout_command): New functions.
8970         (tui_regs_layout): Reimplement.
8971         (tui_regs_layout_command): New function.
8972         (extract_display_start_addr): Rewrite.
8973         (next_layout, prev_layout): Remove.
8974         (tui_layout_window::replace_window): New method.
8975         (tui_layout_split::replace_window): New method.
8976         (destroy_layout): New function.
8977         (layout_list): New global.
8978         (add_layout_command): New function.
8979         (initialize_layouts): Update.
8980         (tui_layout_command): New function.
8981         (_initialize_tui_layout): Install "layout" commands.
8982         * tui/tui-data.h (enum tui_layout_type): Remove.
8983         (tui_current_layout): Don't declare.
8984
8985 2020-02-22  Tom Tromey  <tom@tromey.com>
8986
8987         * tui/tui-regs.c (tui_reg_layout): Remove.
8988         (tui_reg_command): Use tui_regs_layout.
8989         * tui/tui-layout.h (tui_reg_command): Declare.
8990         * tui/tui-layout.c (tui_reg_command): New function.
8991
8992 2020-02-22  Tom Tromey  <tom@tromey.com>
8993
8994         * tui/tui.c (tui_rl_delete_other_windows): Call
8995         tui_remove_some_windows.
8996         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
8997         Declare method.
8998         (class tui_layout_window) <remove_windows>: New method.
8999         (class tui_layout_split) <remove_windows>: Declare.
9000         (tui_remove_some_windows): Declare.
9001         * tui/tui-layout.c (tui_remove_some_windows): New function.
9002         (tui_layout_split::remove_windows): New method.
9003
9004 2020-02-22  Tom Tromey  <tom@tromey.com>
9005
9006         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
9007         * tui/tui-layout.h (tui_next_layout): Declare.
9008         * tui/tui-layout.c (tui_next_layout): New function.
9009
9010 2020-02-22  Tom Tromey  <tom@tromey.com>
9011
9012         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
9013         correct coordinates.
9014
9015 2020-02-22  Tom Tromey  <tom@tromey.com>
9016
9017         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
9018         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
9019         DATA_WIN case.
9020
9021 2020-02-22  Tom Tromey  <tom@tromey.com>
9022
9023         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
9024         TUI_DISASM_WIN, not tui_win_list.
9025
9026 2020-02-22  Tom Tromey  <tom@tromey.com>
9027
9028         * valprint.c (generic_val_print_enum_1)
9029         (val_print_type_code_flags): Style member names.
9030         * rust-lang.c (val_print_struct, rust_print_enum)
9031         (rust_print_struct_def, rust_internal_print_type): Style member
9032         names.
9033         * p-valprint.c (pascal_object_print_value_fields): Style member
9034         names.  Only call fprintf_symbol_filtered for static members.
9035         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
9036         * f-valprint.c (f_val_print): Style member names.
9037         * f-typeprint.c (f_type_print_base): Style member names.
9038         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
9039         call fprintf_symbol_filtered for static members.
9040         (cp_print_class_member): Style member names.
9041         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
9042         member names.
9043         * ada-valprint.c (ada_print_scalar): Style enum names.
9044         (ada_val_print_enum): Likewise.
9045         * ada-typeprint.c (print_enum_type): Style enum names.
9046
9047 2020-02-21  Tom Tromey  <tom@tromey.com>
9048
9049         * psympriv.h (struct partial_symtab): Update comment.
9050
9051 2020-02-21  Tom Tromey  <tromey@adacore.com>
9052
9053         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
9054         type is CORE_ADDR.
9055
9056 2020-02-21  Tom de Vries  <tdevries@suse.de>
9057
9058         PR gdb/25534
9059         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
9060         if dependencies[i]->user != NULL.
9061
9062 2020-02-21  Ali Tamur  <tamur@google.com>
9063
9064         * dwarf2/read.c (dwarf2_name): Add null check.
9065
9066 2020-02-20  Tom Tromey  <tom@tromey.com>
9067
9068         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
9069         ">=", in binary search.
9070         (dwarf2_find_containing_comp_unit): New overload.
9071         (run_test): New self-test.
9072         (_initialize_dwarf2_read): Register new test.
9073
9074 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
9075
9076         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
9077         * riscv-tdep.h: Likewise.
9078         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
9079         rv32-only CSR.
9080         * features/riscv/64bit-csr.xml: Regenerated.
9081
9082 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
9083             Tom Tromey  <tom@tromey.com>
9084
9085         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
9086         of 'fputc_unfiltered'.
9087         (putchar_unfiltered): Call 'fputc_unfiltered'.
9088         (fputc_unfiltered): Call 'fputs_unfiltered'.
9089
9090 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
9091
9092         * config.in: Regenerate.
9093         * configure: Regenerate.
9094         * configure.ac: Add --with-python-libdir option.
9095         * main.c: Use WITH_PYTHON_LIBDIR.
9096
9097 2020-02-19  Tom Tromey  <tom@tromey.com>
9098
9099         * symtab.c (general_symbol_info::compute_and_set_names): Use
9100         obstack_strndup.  Simplify call to symbol_set_demangled_name.
9101
9102 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
9103
9104         * dwarf2/read.c (allocate_signatured_type_table,
9105         allocate_dwo_unit_table, allocate_type_unit_groups_table,
9106         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
9107         Remove objfile parameter, update all callers.
9108
9109 2020-02-19  Doug Evans  <dje@google.com>
9110
9111         PR rust/25535
9112         * rust-lang.c (rust_print_enum): Apply embedded_offset to
9113         rust_enum_variant calculation.
9114
9115 2020-02-19  Tom Tromey  <tromey@adacore.com>
9116
9117         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
9118
9119 2020-02-19  Tom Tromey  <tromey@adacore.com>
9120
9121         * ada-lang.c (cache_symbol): Use obstack_strdup.
9122
9123 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * configure: Regenerate.
9126
9127 2020-02-19  Tom Tromey  <tromey@adacore.com>
9128
9129         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
9130         NULL check.
9131
9132 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
9133
9134         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
9135
9136 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
9137
9138         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
9139         if GDBSERVER is not defined.
9140         (riscv_tdesc_cache): Likewise, also store const target_desc.
9141         (STATIC_IN_GDB): Define.
9142         (riscv_create_target_description): Update declaration with
9143         STATIC_IN_GDB.
9144         (riscv_lookup_target_description): New function, only define if
9145         GDBSERVER is not defined.
9146         * arch/riscv.h (riscv_create_target_description): Declare only
9147         when GDBSERVER is defined.
9148         (riscv_lookup_target_description): New declaration when GDBSERVER
9149         is not defined.
9150         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
9151         (riscv_linux_read_features): ...this, and return
9152         riscv_gdbarch_features instead of target_desc.
9153         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
9154         (riscv_linux_read_description): Rename to...
9155         (riscv_linux_read_features): ...this.
9156         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
9157         Update to use riscv_gdbarch_features and
9158         riscv_lookup_target_description.
9159         * riscv-tdep.c (riscv_find_default_target_description): Use
9160         riscv_lookup_target_description instead of
9161         riscv_create_target_description.
9162
9163 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9164
9165         * valprint.c (generic_val_print_enum_1): When printing a flag
9166         enum with value 0 and there is no enumerator with value 0, print
9167         just "0" instead of "(unknown: 0x0)".
9168
9169 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9170
9171         * valprint.c (generic_val_print_enum_1): Print unknown part of
9172         flag enum in hex.
9173
9174 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9175
9176         * dwarf2/read.c (update_enumeration_type_from_children): Allow
9177         flag enums to contain duplicate enumerators.
9178         * valprint.c (generic_val_print_enum_1): Update comment.
9179
9180 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9181
9182         * dwarf2/read.c: Include "count-one-bits.h".
9183         (update_enumeration_type_from_children): If an enumerator has
9184         multiple bits set, don't treat the enumeration as a "flag enum".
9185         * valprint.c (generic_val_print_enum_1): Assert that enumerators
9186         of flag enums have 0 or 1 bit set.
9187
9188 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9189
9190         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
9191         conversion.
9192         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9193         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
9194         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9195         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
9196         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9197
9198 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9199
9200         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
9201
9202 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9203
9204         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
9205         displaced_step_closure_up.
9206         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
9207         (struct displaced_step_closure_up):
9208         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9209         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9210         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
9211         Likewise.
9212         * gdbarch.sh (displaced_step_copy_insn): Likewise.
9213         * gdbarch.c, gdbarch.h: Re-generate.
9214         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
9215         displaced_step_closure_up.
9216         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9217         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
9218         * infrun.h (displaced_step_closure_up): New type alias.
9219         (struct displaced_step_inferior_state) <step_closure>: Change
9220         type to displaced_step_closure_up.
9221         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
9222         displaced_step_closure_up.
9223         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9224
9225 2020-02-14  Tom Tromey  <tom@tromey.com>
9226
9227         * minidebug.c (gnu_debug_key): New global.
9228         (find_separate_debug_file_in_section): Use it.
9229
9230 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9231
9232         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
9233         std::unique_ptr.
9234         * gdbarch.c: Re-generate.
9235         * gdbarch.h: Re-generate.
9236         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
9237         change.
9238         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
9239         type to std::unique_ptr.
9240         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
9241         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9242         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9243         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
9244         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
9245         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9246         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
9247         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
9248         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9249
9250 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9251
9252         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
9253         std::unique_ptr.
9254         (displaced_step_clear): Rename to...
9255         (displaced_step_reset): ... this.  Just call displaced->reset ().
9256         (displaced_step_clear_cleanup): Rename to...
9257         (displaced_step_reset_cleanup): ... this.
9258         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
9259         (displaced_step_fixup): Likewise.
9260         (resume_1): Likewise.
9261         (handle_inferior_event): Restore child's memory before calling
9262         displaced_step_fixup on the parent.
9263         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
9264         to std::unique_ptr.
9265         <step_closure>: Change type to std::unique_ptr.
9266
9267 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9268
9269         * arm-tdep.c: Include count-one-bits.h.
9270         (cleanup_block_store_pc): Use count_one_bits.
9271         (cleanup_block_load_pc): Use count_one_bits.
9272         (arm_copy_block_xfer): Use count_one_bits.
9273         (thumb2_copy_block_xfer): Use count_one_bits.
9274         (thumb_copy_pop_pc_16bit): Use count_one_bits.
9275         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
9276         (thumb_get_next_pcs_raw): Use count_one_bits.
9277         (arm_get_next_pcs_raw): Use count_one_bits_l.
9278         * arch/arm.c (bitcount): Remove.
9279         * arch/arm.h (bitcount): Remove.
9280
9281 2020-02-14  Tom Tromey  <tromey@adacore.com>
9282
9283         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
9284         Update.
9285         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
9286         * dwarf2/loc.c (call_site_find_chain_1): Return
9287         unique_xmalloc_ptr.
9288         (call_site_find_chain): Likewise.
9289
9290 2020-02-14  Richard Biener  <rguenther@suse.de>
9291
9292         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
9293         on expression with division operators.
9294
9295 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
9296
9297         * MAINTAINERS (Write After Approval): Adding myself.
9298
9299 2020-02-12  Tom Tromey  <tom@tromey.com>
9300
9301         * event-loop.c (event_data, gdb_event, event_handler_func):
9302         Remove.
9303
9304 2020-02-12  Tom Tromey  <tom@tromey.com>
9305
9306         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
9307         (dwarf2_frame_objfile_data): Add comment.
9308         (find_comp_unit, set_comp_unit): New functions.
9309         (dwarf2_frame_find_fde): Use find_comp_unit.
9310         (dwarf2_build_frame_info): Use set_comp_unit.
9311
9312 2020-02-12  Tom Tromey  <tom@tromey.com>
9313
9314         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
9315         (comp_unit): Don't initialize objfile.
9316         (execute_cfa_program): Add text_offset parameter.
9317         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
9318         (dwarf2_frame_cache): Update.
9319         (dwarf2_build_frame_info): Don't set "objfile" member.
9320
9321 2020-02-12  Tom Tromey  <tom@tromey.com>
9322
9323         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
9324         (decode_frame_entry): Likewise.
9325         (dwarf2_build_frame_info): Update.
9326
9327 2020-02-12  Tom Tromey  <tom@tromey.com>
9328
9329         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
9330         (decode_frame_entry_1): Use the comp_unit obstack.
9331
9332 2020-02-12  Tom Tromey  <tom@tromey.com>
9333
9334         * dwarf2/frame.c (struct comp_unit): Add initializers and
9335         constructor.
9336         (dwarf2_frame_objfile_data): Store a comp_unit.
9337         (dwarf2_frame_find_fde): Update.
9338         (dwarf2_build_frame_info): Use "new".
9339
9340 2020-02-12  Tom Tromey  <tom@tromey.com>
9341
9342         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
9343         (dwarf2_fde_table): Typedef for std::vector.
9344         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
9345         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
9346         (decode_frame_entry): Update.
9347         (dwarf2_build_frame_info): Use "new".
9348
9349 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
9350
9351         * arm-tdep.c (arm_gdbarch_init): Update.
9352         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
9353         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
9354         have_neon, is_m>: Change to bool.
9355
9356 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
9357
9358         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
9359
9360 2020-02-12  Tom Tromey  <tom@tromey.com>
9361
9362         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
9363
9364 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
9365
9366         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
9367         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
9368
9369 2020-02-11  Tom Tromey  <tom@tromey.com>
9370
9371         * psymtab.h: Update comment.
9372
9373 2020-02-11  Tom Tromey  <tom@tromey.com>
9374
9375         * gdb_obstack.h (struct auto_obstack): Use
9376         DISABLE_COPY_AND_ASSIGN.
9377
9378 2020-02-11  Tom Tromey  <tom@tromey.com>
9379
9380         * dwarf2/frame.h (struct objfile): Don't forward declare.
9381
9382 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9383
9384         * cris-tdep.c (cris_supply_gregset): Change signature to match
9385         what struct regset expects.
9386         (cris_regset): New struct.
9387         (fetch_core_registers): Remove.
9388         (cris_iterate_over_regset_sections): New function.
9389         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
9390         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
9391
9392 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9393
9394         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
9395         registers.
9396
9397 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9398
9399         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
9400
9401 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9402
9403         * configure: Re-generate.
9404
9405 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9406
9407         * configure: Re-generate.
9408
9409 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9410
9411         * acinclude: Update warning.m4 path.
9412         * warning.m4: Move to gdbsupport.
9413
9414 2020-02-11  Tom Tromey  <tromey@adacore.com>
9415
9416         * remote.c (remote_console_output): Update.
9417         * printcmd.c (printf_command): Update.
9418         * event-loop.c (gdb_wait_for_event): Update.
9419         * linux-nat.c (sigchld_handler): Update.
9420         * remote-sim.c (gdb_os_write_stdout): Update.
9421         (gdb_os_flush_stdout): Update.
9422         (gdb_os_flush_stderr): Update.
9423         (gdb_os_write_stderr): Update.
9424         * exceptions.c (print_exception): Update.
9425         * remote-fileio.c (remote_fileio_func_read): Update.
9426         (remote_fileio_func_write): Update.
9427         * tui/tui.c (tui_enable): Update.
9428         * tui/tui-interp.c (tui_interp::init): Update.
9429         * utils.c (init_page_info): Update.
9430         (putchar_unfiltered, fputc_unfiltered): Update.
9431         (gdb_flush): Update.
9432         (emit_style_escape): Update.
9433         (flush_wrap_buffer, fputs_maybe_filtered): Update.
9434         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
9435         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
9436         (stderr_file::write): Update.
9437         (stderr_file::puts): Update.
9438         * ui-file.h (ui_file_isatty, ui_file_write)
9439         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
9440         (ui_file_puts): Don't declare.
9441
9442 2020-02-10  Tom de Vries  <tdevries@suse.de>
9443
9444         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
9445         sentinel to char *.
9446
9447 2020-02-09  Tom de Vries  <tdevries@suse.de>
9448
9449         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
9450         filename if it matches "<artificial>".
9451
9452 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
9453
9454         * windows-tdep.c (struct enum_value_name): New struct.
9455         (create_enum): New function.
9456         (windows_get_siginfo_type): Create and use enum types.
9457
9458 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
9459
9460         * NEWS: Mention $_siginfo support for Windows.
9461         * windows-nat.c (handle_exception): Set siginfo_er.
9462         (windows_nat_target::mourn_inferior): Reset siginfo_er.
9463         (windows_xfer_siginfo): New function.
9464         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
9465         * windows-tdep.c (struct windows_gdbarch_data): New struct.
9466         (init_windows_gdbarch_data): New function.
9467         (get_windows_gdbarch_data): New function.
9468         (windows_get_siginfo_type): New function.
9469         (windows_init_abi): Register windows_get_siginfo_type.
9470         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
9471
9472 2020-02-08  Tom Tromey  <tom@tromey.com>
9473
9474         * dwarf2/read.c (class cutu_reader) <cutu_reader,
9475         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
9476         <keep>: Declare method.
9477         <m_keep>: Remove member.
9478         <~cutu_reader>: Remove.
9479         (cutu_reader::init_tu_and_read_dwo_dies): Update.
9480         (cutu_reader::cutu_reader): Update.
9481         (cutu_reader::keep): Rename from ~cutu_reader.
9482         (process_psymtab_comp_unit, build_type_psymtabs_1)
9483         (process_skeletonless_type_unit, load_partial_comp_unit)
9484         (load_full_comp_unit, dwarf2_read_addr_index)
9485         (read_signatured_type): Update.
9486
9487 2020-02-08  Tom Tromey  <tom@tromey.com>
9488
9489         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
9490         "want_partial_unit" parameter.
9491         (process_psymtab_comp_unit): Change want_partial_unit to bool.
9492         Inline check for DW_TAG_partial_unit.
9493         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
9494
9495 2020-02-08  Tom Tromey  <tom@tromey.com>
9496
9497         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
9498         read.c.
9499         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
9500         read.c.
9501
9502 2020-02-08  Tom Tromey  <tom@tromey.com>
9503
9504         * dwarf2/read.c (read_address): Move to comp-unit.c.
9505         (dwarf2_rnglists_process, dwarf2_ranges_process)
9506         (read_attribute_value, dwarf_decode_lines_1)
9507         (var_decode_location, decode_locdesc): Update.
9508         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
9509         read.c.  Remove "cu" parameter.
9510         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
9511         method.
9512
9513 2020-02-08  Tom Tromey  <tom@tromey.com>
9514
9515         * dwarf2/read.c (read_attribute_value, read_indirect_string)
9516         (read_indirect_line_string): Update.
9517         * dwarf2/comp-unit.c (read_offset): Remove.
9518         (read_comp_unit_head): Update.
9519         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
9520         method.
9521         (read_offset): Don't declare.
9522
9523 2020-02-08  Tom Tromey  <tom@tromey.com>
9524
9525         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
9526         * dwarf2/read.c (struct comp_unit_head): Move to
9527         dwarf2/comp-unit.h.
9528         (enum class rcuh_kind): Move to comp-unit.h.
9529         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
9530         (read_comp_unit_head, error_check_comp_unit_head)
9531         (read_and_check_comp_unit_head): Move to comp-unit.c.
9532         (read_offset, dwarf_unit_type_name): Likewise.
9533         (create_debug_type_hash_table, read_cutu_die_from_dwo)
9534         (cutu_reader::cutu_reader, read_call_site_scope)
9535         (find_partial_die, follow_die_offset): Update.
9536         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
9537
9538 2020-02-08  Tom Tromey  <tom@tromey.com>
9539
9540         * dwarf2/read.c (read_offset_1): Move to leb.c.
9541         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
9542         (dwarf_decode_macro_bytes): Update.
9543         * dwarf2/leb.c (read_offset): Rename; move from read.c.
9544         * dwarf2/leb.h (read_offset): Declare.
9545
9546 2020-02-08  Tom Tromey  <tom@tromey.com>
9547
9548         * dwarf2/read.c (dwarf2_section_size): Remove.
9549         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
9550         Update.
9551         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
9552
9553 2020-02-08  Tom Tromey  <tom@tromey.com>
9554
9555         * dwarf2/read.c (read_initial_length): Move to leb.c.
9556         * dwarf2/leb.h (read_initial_length): Declare.
9557         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
9558         handle_nonstd parameter.
9559         * dwarf2/frame.c (read_initial_length): Remove.
9560         (decode_frame_entry_1): Update.
9561
9562 2020-02-08  Tom Tromey  <tom@tromey.com>
9563
9564         * dwarf2/loc.c (dwarf2_find_location_expression)
9565         (dwarf_evaluate_loc_desc::get_tls_address)
9566         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
9567         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
9568         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
9569         (dwarf2_compile_property_to_c)
9570         (dwarf2_loc_desc_get_symbol_read_needs)
9571         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
9572         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
9573         (loclist_describe_location, loclist_tracepoint_var_ref)
9574         (loclist_generate_c_location): Update.
9575         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
9576         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
9577         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
9578         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
9579         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
9580         (dwarf2_per_cu_data::addr_size)
9581         (dwarf2_per_cu_data::ref_addr_size)
9582         (dwarf2_per_cu_data::text_offset)
9583         (dwarf2_per_cu_data::addr_type): Now methods.
9584         (per_cu_header_read_in): Make per_cu "const".
9585         (dwarf2_version): Remove.
9586         (dwarf2_per_cu_data::int_type): Now a method.
9587         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
9588         (set_die_type, read_array_type, read_subrange_index_type)
9589         (read_tag_string_type, read_subrange_type): Update.
9590         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
9591         offset_size, ref_addr_size, text_offset, addr_type, version,
9592         objfile, int_type, addr_sized_int_type>: Declare methods.
9593
9594 2020-02-08  Tom Tromey  <tom@tromey.com>
9595
9596         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
9597         Move earlier.
9598
9599 2020-02-08  Tom Tromey  <tom@tromey.com>
9600
9601         * dwarf2/read.h (dwarf_line_debug): Declare.
9602         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
9603         * dwarf2/read.c: Move line_header code to new files.
9604         (dwarf_line_debug): No longer static.
9605         * dwarf2/line-header.c: New file.
9606         * dwarf2/line-header.h: New file.
9607
9608 2020-02-08  Tom Tromey  <tom@tromey.com>
9609
9610         * dwarf2/read.c (struct line_header) <file_full_name,
9611         file_file_name>: Return unique_xmalloc_ptr.
9612         (line_header::file_file_name): Update.
9613         (line_header::file_full_name): Update.
9614         (dw2_get_file_names_reader): Update.
9615         (macro_start_file): Update.
9616
9617 2020-02-08  Tom Tromey  <tom@tromey.com>
9618
9619         * dwarf2/read.c (struct line_header) <file_full_name,
9620         file_file_name>: Declare methods.
9621         (dw2_get_file_names_reader): Update.
9622         (file_file_name): Now a method.
9623         (file_full_name): Likewise.
9624         (macro_start_file): Update.
9625
9626 2020-02-08  Tom Tromey  <tom@tromey.com>
9627
9628         * dwarf2/read.c (dwarf_always_disassemble)
9629         (show_dwarf_always_disassemble): Move to loc.c.
9630         (_initialize_dwarf2_read): Move "always-disassemble" registration
9631         to loc.c.
9632         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
9633         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
9634         static.
9635         (show_dwarf_always_disassemble): Move from read.c.
9636         (_initialize_dwarf2loc): Move always-disassemble from read.c.
9637
9638 2020-02-08  Tom Tromey  <tom@tromey.com>
9639
9640         * dwarf2/read.c (~dwarf2_per_objfile): Update.
9641         (create_quick_file_names_table): Return htab_up.
9642         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
9643         Update.
9644         * dwarf2/read.h (struct dwarf2_per_objfile)
9645         <quick_file_names_table>: Now htab_up.
9646
9647 2020-02-08  Tom Tromey  <tom@tromey.com>
9648
9649         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
9650
9651 2020-02-08  Tom Tromey  <tom@tromey.com>
9652
9653         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
9654         Rewrite.
9655         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
9656         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
9657         (abbrev_table::abbrev_table): No longer inline.
9658         (ABBREV_HASH_SIZE): Remove.
9659         (abbrev_table::m_abbrevs): Now an htab_up.
9660
9661 2020-02-08  Tom Tromey  <tom@tromey.com>
9662
9663         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
9664         (cutu_reader): Update.
9665         (build_type_psymtabs_1): Update.
9666         * dwarf2/abbrev.c (abbrev_table::read): Rename.
9667         (abbrev_table::alloc_abbrev): Update.
9668         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
9669         (abbrev_table::read): New static method, renamed from
9670         abbrev_table_read_table.
9671         (abbrev_table::alloc_abbrev)
9672         (abbrev_table::add_abbrev): Now private.
9673         (abbrev_table::abbrev_table): Now private.
9674         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
9675
9676 2020-02-08  Tom Tromey  <tom@tromey.com>
9677
9678         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
9679         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
9680         htab_up.
9681
9682 2020-02-08  Tom Tromey  <tom@tromey.com>
9683
9684         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
9685         htab_up.
9686         (lookup_dwo_unit_in_dwp): Update.
9687         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
9688         on obstack.
9689
9690 2020-02-08  Tom Tromey  <tom@tromey.com>
9691
9692         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
9693         obstack.
9694
9695 2020-02-08  Tom Tromey  <tom@tromey.com>
9696
9697         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
9698         line_header_hash.
9699         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
9700         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
9701         Change type to htab_up.
9702
9703 2020-02-08  Tom Tromey  <tom@tromey.com>
9704
9705         * dwarf2/read.c (allocate_type_unit_groups_table): Return
9706         htab_up.  Don't allocate on obstack.
9707         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
9708         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
9709         Change type to htab_up.
9710
9711 2020-02-08  Tom Tromey  <tom@tromey.com>
9712
9713         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
9714         Change type to htab_up.
9715         * dwarf2/read.c (create_signatured_type_table_from_index)
9716         (create_signatured_type_table_from_debug_names)
9717         (create_all_type_units, add_type_unit)
9718         (lookup_dwo_signatured_type, lookup_signatured_type)
9719         (process_skeletonless_type_unit): Update.
9720         (create_debug_type_hash_table, create_debug_types_hash_table):
9721         Change type of types_htab.
9722         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
9723         htab_up.  Don't allocate on obstack.
9724         (create_cus_hash_table): Change type of cus_htab parameter.
9725         (struct dwo_file) <cus, tus>: Now htab_up.
9726         (lookup_dwo_signatured_type, lookup_dwo_cutu)
9727         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
9728         (queue_and_load_all_dwo_tus): Update.
9729         * dwarf2/index-write.c (write_gdbindex): Update.
9730         (write_debug_names): Update.
9731
9732 2020-02-08  Tom Tromey  <tom@tromey.com>
9733
9734         * dwarf2/read.h (struct dwarf2_queue_item): Move from
9735         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
9736         destructor.
9737         (struct dwarf2_per_objfile) <queue>: New member.
9738         * dwarf2/read.c (struct dwarf2_queue_item): Move to
9739         dwarf2/read.h.
9740         (dwarf2_queue, dwarf2_queue_tail): Remove.
9741         (class dwarf2_queue_guard): Add parameter to constructor.  Use
9742         DISABLE_COPY_AND_ASSIGN.
9743         <m_per_objfile>: New member.
9744         <~dwarf2_queue_guard>: Rewrite.
9745         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
9746         Update.
9747         (~dwarf2_queue_item): New.
9748
9749 2020-02-08  Tom Tromey  <tom@tromey.com>
9750
9751         * dwarf2/read.c (struct die_info) <has_children>: New member.
9752         (dw2_get_file_names_reader): Remove has_children.
9753         (dw2_get_file_names): Update.
9754         (read_cutu_die_from_dwo): Remove has_children.
9755         (cutu_reader::init_tu_and_read_dwo_dies)
9756         (cutu_reader::cutu_reader): Update.
9757         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
9758         Remove has_children.
9759         (build_type_psymtabs_1, process_skeletonless_type_unit)
9760         (load_partial_comp_unit, load_full_comp_unit): Update.
9761         (create_dwo_cu_reader): Remove has_children.
9762         (create_cus_hash_table, read_die_and_children): Update.
9763         (read_full_die_1,read_full_die): Remove has_children.
9764         (read_signatured_type): Update.
9765         (class cutu_reader) <has_children>: Remove.
9766
9767 2020-02-08  Tom Tromey  <tom@tromey.com>
9768
9769         * dwarf2/expr.c: Rename from dwarf2expr.c.
9770         * dwarf2/expr.h: Rename from dwarf2expr.h.
9771         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
9772         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
9773         * dwarf2/frame.c: Rename from dwarf2-frame.c.
9774         * dwarf2/frame.h: Rename from dwarf2-frame.h.
9775         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
9776         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
9777         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
9778         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
9779         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
9780         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
9781         * dwarf2/loc.c: Rename from dwarf2loc.c.
9782         * dwarf2/loc.h: Rename from dwarf2loc.h.
9783         * dwarf2/read.c: Rename from dwarf2read.c.
9784         * dwarf2/read.h: Rename from dwarf2read.h.
9785         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
9786         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
9787         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
9788         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
9789         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
9790         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
9791         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
9792         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
9793         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
9794         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
9795         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
9796         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
9797         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
9798         Update.
9799         * Makefile.in (COMMON_SFILES): Update.
9800         (HFILES_NO_SRCDIR): Update.
9801
9802 2020-02-08  Tom Tromey  <tom@tromey.com>
9803
9804         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
9805         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
9806
9807 2020-02-08  Tom Tromey  <tom@tromey.com>
9808
9809         * dwarf2read.h (struct die_info): Don't declare.
9810
9811 2020-02-08  Tom Tromey  <tom@tromey.com>
9812
9813         * dwarf2read.h (die_info_ptr): Remove typedef.
9814
9815 2020-02-08  Tom Tromey  <tom@tromey.com>
9816
9817         * dwarf2read.c (read_call_site_scope)
9818         (handle_data_member_location, dwarf2_add_member_fn)
9819         (mark_common_block_symbol_computed, read_common_block)
9820         (attr_to_dynamic_prop, partial_die_info::read)
9821         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
9822         (dwarf2_symbol_mark_computed, set_die_type): Update.
9823         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
9824         method.
9825         (attr_form_is_block): Don't declare.
9826         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
9827
9828 2020-02-08  Tom Tromey  <tom@tromey.com>
9829
9830         * dwarf2read.c (dwarf2_find_base_address, )
9831         (read_call_site_scope, rust_containing_type)
9832         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
9833         (handle_data_member_location, dwarf2_add_member_fn)
9834         (get_alignment, read_structure_type, process_structure_scope)
9835         (mark_common_block_symbol_computed, read_common_block)
9836         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
9837         (partial_die_info::read, read_attribute_value, new_symbol)
9838         (lookup_die_type, dwarf2_get_ref_die_offset)
9839         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
9840         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
9841         (dwarf2_symbol_mark_computed): Update.
9842         * dwarf2/attribute.h (struct attribute) <value_as_address,
9843         form_is_section_offset, form_is_constant, form_is_ref>: Declare
9844         methods.
9845         (value_as_address, attr_form_is_section_offset)
9846         (attr_form_is_constant, attr_form_is_ref): Don't declare.
9847         * dwarf2/attribute.c (attribute::value_as_address)
9848         (attribute::form_is_section_offset, attribute::form_is_constant)
9849         (attribute::form_is_ref): Now methods.
9850
9851 2020-02-08  Tom Tromey  <tom@tromey.com>
9852
9853         * dwarf2read.c (struct attribute, DW_STRING)
9854         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
9855         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
9856         (attr_form_is_block, attr_form_is_section_offset)
9857         (attr_form_is_constant, attr_form_is_ref): Move.
9858         * dwarf2/attribute.h: New file.
9859         * dwarf2/attribute.c: New file, from dwarf2read.c.
9860         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
9861
9862 2020-02-08  Tom Tromey  <tom@tromey.com>
9863
9864         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
9865         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
9866         Move.
9867         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
9868         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
9869         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
9870         abbrev.c.
9871         * dwarf2/abbrev.h: New file.
9872         * dwarf2/abbrev.c: New file, from dwarf2read.c.
9873         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
9874
9875 2020-02-08  Tom Tromey  <tom@tromey.com>
9876
9877         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
9878         (dwarf2_section_size, dwarf2_get_section_info)
9879         (create_signatured_type_table_from_debug_names)
9880         (create_addrmap_from_aranges, read_debug_names_from_section)
9881         (get_gdb_index_contents_from_section, read_comp_unit_head)
9882         (error_check_comp_unit_head, read_abbrev_offset)
9883         (create_debug_type_hash_table, init_cu_die_reader)
9884         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
9885         (read_comp_units_from_section, create_cus_hash_table)
9886         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
9887         (create_dwp_v2_section, dwarf2_rnglists_process)
9888         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
9889         (abbrev_table_read_table, read_indirect_string_at_offset_from)
9890         (read_indirect_string_from_dwz, read_addr_index_1)
9891         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
9892         (dwarf_decode_macro_bytes, dwarf_decode_macros)
9893         (fill_in_loclist_baton): Update.
9894         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
9895         get_containing_section, get_bfd_owner, get_bfd_section,
9896         get_file_name, get_id, get_flags, empty, read>: Declare methods.
9897         (dwarf2_read_section, get_section_name, get_section_file_name)
9898         (get_containing_section, get_section_bfd_owner)
9899         (get_section_bfd_section, get_section_name, get_section_file_name)
9900         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
9901         declare.
9902         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
9903         (dwarf2_section_info::get_bfd_owner)
9904         (dwarf2_section_info::get_bfd_section)
9905         (dwarf2_section_info::get_name)
9906         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
9907         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
9908         (dwarf2_section_info::read): Now methods.
9909         * dwarf-index-write.c (class debug_names): Update.
9910
9911 2020-02-08  Tom Tromey  <tom@tromey.com>
9912
9913         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
9914         Move to dwarf2/section.h.
9915         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
9916         (get_section_bfd_section, get_section_name)
9917         (get_section_file_name, get_section_id, get_section_flags)
9918         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
9919         dwarf2/section.c.
9920         * dwarf2/section.h: New file.
9921         * dwarf2/section.c: New file, from dwarf2read.c.
9922         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
9923
9924 2020-02-08  Tom Tromey  <tom@tromey.com>
9925
9926         * dwarf2read.h (read_unsigned_leb128): Don't declare.
9927         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
9928         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
9929         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
9930         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
9931         * dwarf2/leb.h: New file, from dwarf2read.c.
9932         * dwarf2/leb.c: New file, from dwarf2read.c.
9933         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
9934         Remove.
9935         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
9936         (COMMON_SFILES): Add dwarf2/leb.c.
9937
9938 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
9939
9940         GDB 9.1 released.
9941
9942 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
9943
9944         PR gdb/25190:
9945         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
9946         * gdb/remote.c (remote_console_output): Update.
9947         * gdb/ui-file.c (fputs_unfiltered): Rename to...
9948         (ui_file_puts): ...this.
9949         * gdb/ui-file.h (ui_file_puts): Add declaration.
9950         * gdb/utils.c (emit_style_escape): Update.
9951         (flush_wrap_buffer): Update.
9952         (fputs_maybe_filtered): Update.
9953         (fputs_unfiltered): Add function.
9954
9955 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
9956
9957         * gdb/event-loop.c (gdb_wait_for_event): Update.
9958         * gdb/printcmd.c (printf_command): Update.
9959         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
9960         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
9961         (gdb_os_flush_stderr): Update.
9962         * gdb/remote.c (remote_console_output): Update.
9963         * gdb/ui-file.c (gdb_flush): Rename to...
9964         (ui_file_flush): ...this.
9965         (stderr_file::write): Update.
9966         (stderr_file::puts): Update.
9967         * gdb/ui-file.h (gdb_flush): Rename to...
9968         (ui_file_flush): ...this.
9969         * gdb/utils.c (gdb_flush): Add function.
9970         * gdb/utils.h (gdb_flush): Add declaration.
9971
9972 2020-02-07  Tom Tromey  <tromey@adacore.com>
9973
9974         PR breakpoints/24915:
9975         * source.c (find_and_open_source): Do not check basenames_may_differ.
9976
9977 2020-02-07  Tom Tromey  <tom@tromey.com>
9978
9979         * README: Update gdbserver documentation.
9980         * gdbserver: Move to top level.
9981         * configure.tgt (build_gdbserver): Remove.
9982         * configure.ac: Remove --enable-gdbserver.
9983         * configure: Rebuild.
9984         * Makefile.in (distclean): Don't mention gdbserver.
9985
9986 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
9987
9988         * source-cache.c (source_cache::ensure): Surround
9989         get_plain_source_lines with a try/catch.
9990         (source_cache::get_line_charpos): Get rid of try/catch
9991         and only check for the return value of "ensure".
9992         * tui/tui-source.c (tui_source_window::set_contents):
9993         Simplify "nlines" calculation.
9994
9995 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
9996
9997         * MAINTAINERS (Write After Approval): Add myself.
9998
9999 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
10000
10001         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
10002         function call.
10003
10004 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
10005
10006         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
10007
10008 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
10009
10010         * nat/riscv-linux-tdesc.h: New file.
10011         * nat/riscv-linux-tdesc.c: New file, taking code from...
10012         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
10013         ... here.
10014         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
10015         NATDEPFILES.
10016
10017 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
10018
10019         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
10020         we don't set the fake simulator ptid to the null_ptid.
10021
10022 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
10023
10024         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
10025         * gdbthread.h (class thread_info) <resumed>: Likewise.
10026         * infrun.c (resume_1): Likewise.
10027         (proceed): Likewise.
10028         (infrun_thread_stop_requested): Likewise.
10029         (stop_all_threads): Likewise.
10030         (handle_inferior_event): Likewise.
10031         (restart_threads): Likewise.
10032         (finish_step_over): Likewise.
10033         (keep_going_stepped_thread): Likewise.
10034         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
10035         (linux_handle_extended_wait): Likewise.
10036         * record-btrace.c (get_thread_current_frame_id): Likewise.
10037         * record-full.c (record_full_wait_1): Likewise.
10038         * remote.c (remote_target::process_initial_stop_replies): Likewise.
10039         * target.c (target_resume): Likewise.
10040         * thread.c (set_running_thread): Likewise.
10041
10042 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
10043
10044         * f-valprint.c (f77_print_array_1): Changed datatype of index
10045         variable to LONGEST from int to enable it to contain bound
10046         values correctly.
10047
10048 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
10049
10050         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
10051         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
10052         offsets according to FLEN determined.
10053         (riscv_linux_nat_target::read_description): Determine FLEN
10054         dynamically.
10055         (riscv_linux_nat_target::fetch_registers): Size regset buffer
10056         according to FLEN determined.
10057         (riscv_linux_nat_target::store_registers): Likewise.
10058
10059 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
10060
10061         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
10062         when reg->group is empty and reggroup is not.
10063
10064 2020-01-31  Tom Tromey  <tromey@adacore.com>
10065
10066         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
10067         Call beneath target's mourn_inferior after unpushing.
10068
10069 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
10070
10071         PR tui/9765
10072         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
10073         have enough lines to fill the screen, still return the lowest
10074         address we found.
10075
10076 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
10077
10078         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
10079         '-', '<', and '>' commands.
10080
10081 2020-01-29  Pedro Alves  <palves@redhat.com>
10082             Sergio Durigan Junior  <sergiodj@redhat.com>
10083
10084         * infcmd.c (construct_inferior_arguments): Assert that
10085         'argc' is greater than 0.
10086
10087 2020-01-29  Luis Machado  <luis.machado@linaro.org>
10088
10089         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
10090         (BRK_INSN_MASK): Define to 0xd4200000.
10091         (aarch64_program_breakpoint_here_p): New function.
10092         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
10093         * arch-utils.c (default_program_breakpoint_here_p): Moved from
10094         breakpoint.c.
10095         * arch-utils.h (default_program_breakpoint_here_p): Moved from
10096         breakpoint.h
10097         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
10098         call gdbarch_program_breakpoint_here_p.
10099         (program_breakpoint_here): Moved to arch-utils.c, renamed to
10100         default_program_breakpoint_here_p, changed return type to bool and
10101         simplified.
10102         * breakpoint.h (program_breakpoint_here): Moved prototype to
10103         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
10104         return type to bool.
10105         * gdbarch.c: Regenerate.
10106         * gdbarch.h: Regenerate.
10107         * gdbarch.sh (program_breakpoint_here_p): New method.
10108         * infrun.c (handle_signal_stop): Call
10109         gdbarch_program_breakpoint_here_p.
10110
10111 2020-01-26  Tom Tromey  <tom@tromey.com>
10112
10113         * ctfread.c (struct ctf_fp_info): Reindent.
10114         (_initialize_ctfread): Remove.
10115
10116 2020-01-26  Tom Tromey  <tom@tromey.com>
10117
10118         * psymtab.c (partial_map_expand_apply)
10119         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
10120         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
10121         (psym_print_stats, psym_expand_symtabs_for_function)
10122         (psym_map_symbol_filenames, psym_map_matching_symbols)
10123         (psym_expand_symtabs_matching)
10124         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
10125         (maintenance_check_psymtabs): Use new methods.
10126         * psympriv.h (struct partial_symtab) <readin_p,
10127         get_compunit_symtab>: New methods.
10128         <readin, compunit_symtab>: Remove members.
10129         (struct standard_psymtab): New.
10130         (struct legacy_psymtab): Derive from standard_psymtab.
10131         * dwarf2read.h (struct dwarf2_psymtab): Derive from
10132         standard_psymtab.
10133         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
10134
10135 2020-01-26  Tom Tromey  <tom@tromey.com>
10136
10137         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
10138         read_dependencies.  Add assert.
10139         * psymtab.c (partial_symtab::read_dependencies): New method.
10140         * psympriv.h (struct partial_symtab) <read_dependencies>: New
10141         method.
10142         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
10143         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
10144         read_dependencies.
10145         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
10146         Add assert.
10147
10148 2020-01-26  Tom Tromey  <tom@tromey.com>
10149
10150         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
10151         Call expand_psymtab.
10152         (xcoff_read_symtab): Call expand_psymtab.
10153         (xcoff_start_psymtab, xcoff_end_psymtab): Set
10154         legacy_expand_psymtab.
10155         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
10156         method.
10157         (struct legacy_psymtab) <expand_psymtab>: Implement.
10158         <legacy_expand_psymtab>: New member.
10159         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
10160         (parse_partial_symbols): Set legacy_expand_psymtab.
10161         (psymtab_to_symtab_1): Change argument order.  Call
10162         expand_psymtab.
10163         (new_psymtab): Set legacy_expand_psymtab.
10164         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
10165         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
10166         expand_psymtab.
10167         (dwarf2_psymtab::expand_psymtab): Rename from
10168         psymtab_to_symtab_1.  Call expand_psymtab.
10169         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
10170         (dbx_end_psymtab): Likewise.
10171         (dbx_psymtab_to_symtab_1): Change argument order. Call
10172         expand_psymtab.
10173         (dbx_read_symtab): Call expand_psymtab.
10174         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
10175         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
10176         (ctf_psymtab::read_symtab): Call expand_psymtab.
10177
10178 2020-01-26  Tom Tromey  <tom@tromey.com>
10179
10180         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
10181         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
10182         messages.
10183         * mdebugread.c (mdebug_read_symtab): Remove prints.
10184         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
10185         assert.
10186         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
10187
10188 2020-01-26  Tom Tromey  <tom@tromey.com>
10189
10190         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
10191         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
10192         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
10193         legacy_symtab.
10194         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
10195         * psymtab.c (psymtab_to_symtab): Call method.
10196         (dump_psymtab): Update.
10197         * psympriv.h (struct partial_symtab): Add virtual destructor.
10198         <read_symtab>: New method.
10199         (struct legacy_symtab): New.
10200         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
10201         (struct pst_map) <pst>: Now a legacy_psymtab.
10202         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
10203         (new_psymtab): Use legacy_psymtab.
10204         * dwarf2read.h (struct dwarf2_psymtab): New.
10205         (struct dwarf2_per_cu_data) <psymtab>: Use it.
10206         * dwarf2read.c (dwarf2_create_include_psymtab)
10207         (dwarf2_build_include_psymtabs, create_type_unit_group)
10208         (create_partial_symtab, process_psymtab_comp_unit_reader)
10209         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
10210         (set_partial_user): Use dwarf2_psymtab.
10211         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
10212         (psymtab_to_symtab_1, process_full_comp_unit)
10213         (process_full_type_unit, dwarf2_ranges_read)
10214         (dwarf2_get_pc_bounds, psymtab_include_file_name)
10215         (dwarf_decode_lines): Use dwarf2_psymtab.
10216         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
10217         (add_address_entry_worker, write_one_signatured_type)
10218         (recursively_count_psymbols, recursively_write_psymbols)
10219         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
10220         (write_debug_names): Likewise.
10221         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
10222         <pst>: Now a legacy_psymtab.
10223         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
10224         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
10225         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
10226         * ctfread.c (struct ctf_psymtab): New.
10227         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
10228         ctf_psymtab.
10229         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
10230         (create_partial_symtab): Return a ctf_psymtab.
10231         (scan_partial_symbols): Update.
10232
10233 2020-01-26  Tom Tromey  <tom@tromey.com>
10234
10235         * xcoffread.c (xcoff_start_psymtab): Use new.
10236         * psymtab.c (partial_symtab::partial_symtab): New constructor,
10237         renamed from start_psymtab_common.
10238         * psympriv.h (struct partial_symtab): Add new constructor.
10239         (start_psymtab_common): Don't declare.
10240         * mdebugread.c (parse_partial_symbols): Use new.
10241         * dwarf2read.c (create_partial_symtab): Use new.
10242         * dbxread.c (start_psymtab): Use new.
10243         * ctfread.c (create_partial_symtab): Use new.
10244
10245 2020-01-26  Tom Tromey  <tom@tromey.com>
10246
10247         * xcoffread.c (xcoff_end_psymtab): Use new.
10248         * psymtab.c (start_psymtab_common): Use new.
10249         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
10250         Update.
10251         * psympriv.h (struct partial_symtab): Add parameters to
10252         constructor.  Don't inline.
10253         (allocate_psymtab): Don't declare.
10254         * mdebugread.c (new_psymtab): Use new.
10255         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
10256         * dbxread.c (dbx_end_psymtab): Use new.
10257
10258 2020-01-26  Tom Tromey  <tom@tromey.com>
10259
10260         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
10261         allocate_psymtab.  Update documentation.
10262         * psymtab.c (psymtab_storage::install_psymtab): Rename from
10263         allocate_psymtab.  Do not use new.
10264         (allocate_psymtab): Use new.  Update.
10265
10266 2020-01-26  Tom Tromey  <tom@tromey.com>
10267
10268         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
10269         * psymtab.c (psym_print_stats): Update.
10270         * psympriv.h (struct partial_symtab) <readin,
10271         psymtabs_addrmap_supported, anonymous>: Now bool.
10272         * mdebugread.c (psymtab_to_symtab_1): Update.
10273         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
10274         (build_type_psymtabs_reader, psymtab_to_symtab_1)
10275         (process_full_comp_unit, process_full_type_unit): Update.
10276         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
10277         * ctfread.c (psymtab_to_symtab): Update.
10278
10279 2020-01-26  Tom Tromey  <tom@tromey.com>
10280
10281         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
10282         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
10283         * psymtab.c (psymtab_storage): Delete psymtabs.
10284         (psymtab_storage::allocate_psymtab): Use new.
10285         (psymtab_storage::discard_psymtab): Use delete.
10286         * psympriv.h (struct partial_symtab): Add constructor and
10287         initializers.
10288
10289 2020-01-26  Tom Tromey  <tom@tromey.com>
10290
10291         * machoread.c: Do not include psympriv.h.
10292
10293 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10294
10295         * NEWS: Mention the new option and the set/show commands.
10296
10297 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298
10299         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
10300         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
10301         (validate_exec_file): New variables, enums, functions.
10302         (exec_file_locate_attach, print_section_info): Style the filenames.
10303         (_initialize_exec): Install show_exec_file_mismatch_command and
10304          set_exec_file_mismatch_command.
10305         * gdbcore.h (validate_exec_file): Declare.
10306         * infcmd.c (attach_command): Call validate_exec_file.
10307         * remote.c ( remote_target::remote_add_inferior): Likewise.
10308
10309 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10310
10311         * frame.c (find_frame_sal): Move call to get_next_frame into more
10312         inner scope.
10313         * inline-frame.c (inilne_state) <inline_state>: Update argument
10314         types.
10315         (inilne_state) <skipped_symbol>: Rename to...
10316         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
10317         (skip_inline_frames): Build vector of skipped symbols and use this
10318         to reate the inline_state.
10319         (inline_skipped_symbol): Add a comment and some assertions, fetch
10320         skipped symbol from the list.
10321
10322 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10323
10324         * buildsym.c (lte_is_less_than): Delete.
10325         (buildsym_compunit::end_symtab_with_blockvector): Create local
10326         lambda function to sort line table entries, and use
10327         std::stable_sort instead of std::sort.
10328         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
10329         markers when looking for a previous line.
10330
10331 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10332
10333         * dwarf2read.c (lnp_state_machine::record_line): Include
10334         end_sequence parameter in debug print out.  Record the line if we
10335         are at an end_sequence marker even if it's not the start of a
10336         statement.
10337         * symmisc.c (maintenance_print_one_line_table): Print end of
10338         sequence markers with 'END' not '0'.
10339
10340 2020-01-24  Pedro Alves  <palves@redhat.com>
10341
10342         PR gdb/25410
10343         * thread.c (scoped_restore_current_thread::restore): Use
10344         switch_to_inferior_no_thread.
10345         * exec.c: Include "progspace-and-thread.h".
10346         (add_target_sections, remove_target_sections):
10347         scoped_restore_current_pspace_and_thread instead of
10348         scoped_restore_current_thread.
10349         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
10350         and aspace to the inferior before calling clone_program_space.
10351         Remove stale comment.
10352
10353 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10354
10355         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
10356         (arm_netbsd_nat_target::fetch_registers): ...this.
10357         (arm_nbsd_nat_target::store_registers): Rename to...
10358         (arm_netbsd_nat_target::store_registers): ...this.
10359
10360 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10361
10362         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
10363         register_t.
10364
10365 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10366
10367         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
10368         Update comment.
10369         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
10370         Likewise.
10371         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
10372         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
10373         the correct replacement (iterate_over_regset_sections).
10374         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
10375         Update comment.
10376
10377 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
10378
10379         PR gdb/23718
10380         * gdb/python/python.c (execute_gdb_command): Call
10381         async_enable_stdin in catch block.
10382
10383 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
10386         SWITCH_THRU_ALL_UIS.
10387
10388 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10389
10390         PR tui/9765
10391         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
10392         comment, add extra parameter, and update to store previous symbol
10393         when appropriate.
10394         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
10395         add extra parameter.
10396         * tui/tui-disasm.c (tui_disassemble): Update header comment,
10397         remove unneeded parameter, add try/catch around gdb_print_insn,
10398         rewrite to add items to asm_lines vector.
10399         (tui_find_backward_disassembly_start_address): New function.
10400         (tui_find_disassembly_address): Updated throughout.
10401         (tui_disasm_window::set_contents): Update for changes to
10402         tui_disassemble.
10403         (tui_disasm_window::do_scroll_vertical): No need to adjust the
10404         number of lines to scroll.
10405
10406 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
10407
10408         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
10409         (SECT_OFF_DATA): Likewise.
10410         (SECT_OFF_RODATA): Likewise.
10411         (SECT_OFF_TEXT): Likewise.
10412         (SECT_OFF_BSS): Likewise.
10413         (struct objfile) <text_section_offset, data_section_offset>: New
10414         methods.
10415         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
10416         objfile::text_section_offset.
10417         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
10418         * coffread.c (coff_symtab_read): Likewise.
10419         (enter_linenos): Likewise.
10420         (process_coff_symbol): Likewise.
10421         * ctfread.c (get_objfile_text_range): Likewise.
10422         * dtrace-probe.c (dtrace_probe::get_relocated_address):
10423         Use objfile::data_section_offset.
10424         * dwarf2-frame.c (execute_cfa_program): Use
10425         objfile::text_section_offset.
10426         (dwarf2_frame_find_fde): Likewise.
10427         * dwarf2read.c (create_addrmap_from_index): Likewise.
10428         (create_addrmap_from_aranges): Likewise.
10429         (dw2_find_pc_sect_compunit_symtab): Likewise.
10430         (process_psymtab_comp_unit_reader): Likewise.
10431         (add_partial_symbol): Likewise.
10432         (add_partial_subprogram): Likewise.
10433         (process_full_comp_unit): Likewise.
10434         (read_file_scope): Likewise.
10435         (read_func_scope): Likewise.
10436         (read_lexical_block_scope): Likewise.
10437         (read_call_site_scope): Likewise.
10438         (dwarf2_rnglists_process): Likewise.
10439         (dwarf2_ranges_process): Likewise.
10440         (dwarf2_ranges_read): Likewise.
10441         (dwarf_decode_lines_1): Likewise.
10442         (new_symbol): Likewise.
10443         (dwarf2_fetch_die_loc_sect_off): Likewise.
10444         (dwarf2_per_cu_text_offset): Likewise.
10445         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
10446         * hppa-tdep.c (read_unwind_info): Likewise.
10447         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
10448         * psympriv.h (struct partial_symtab): Likewise.
10449         * psymtab.c (find_pc_sect_psymtab): Likewise.
10450         * solib-svr4.c (enable_break): Likewise.
10451         * stap-probe.c (relocate_address): Use
10452         objfile::data_section_offset.
10453         * xcoffread.c (enter_line_range): Use
10454         objfile::text_section_offset.
10455         (read_xcoff_symtab): Likewise.
10456
10457 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
10458
10459         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
10460         declaration to narrower scopes.
10461
10462 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
10463
10464         * darwin-nat.h (struct darwin_exception_msg, enum
10465         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
10466         Move up.
10467         (class darwin_nat_target) <wait_1, check_new_threads,
10468         decode_exception_message, decode_message, stop_inferior,
10469         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
10470         * darwin-nat.c (darwin_check_new_threads): Rename to...
10471         (darwin_nat_target::check_new_threads): ... this.
10472         (darwin_suspend_inferior_it): Remove.
10473         (darwin_decode_exception_message): Rename to...
10474         (darwin_nat_target::decode_exception_message): ... this.
10475         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
10476         (darwin_decode_message): Rename to...
10477         (darwin_nat_target::decode_message): ... this.
10478         (cancel_breakpoint): Rename to...
10479         (darwin_nat_target::cancel_breakpoint): ... this.
10480         (darwin_wait): Rename to...
10481         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
10482         instead of iterate_over_inferiors.
10483         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
10484         (darwin_stop_inferior): Rename to...
10485         (darwin_nat_target::stop_inferior): ... this.
10486         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
10487         (darwin_init_thread_list): Rename to...
10488         (darwin_nat_target::init_thread_list): ... this.
10489         (darwin_ptrace_him): Rename to...
10490         (darwin_nat_target::ptrace_him): ... this.
10491         (darwin_nat_target::create_inferior): Pass lambda function to
10492         fork_inferior.
10493         (darwin_nat_target::detach): Call stop_inferior instead of
10494         darwin_stop_inferior.
10495         * fork-inferior.h (fork_inferior): Change init_trace_fun
10496         parameter to gdb::function_view.
10497         * fork-inferior.c (fork_inferior): Likewise.
10498
10499 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
10500
10501         * i386-cygwin-tdep.c (core_process_module_section): Update.
10502         * windows-nat.c (struct lm_info_windows): Add text_offset.
10503         (windows_xfer_shared_libraries): Update.
10504         * windows-tdep.c (windows_xfer_shared_library):
10505         Add text_offset_cached argument.
10506         * windows-tdep.h (windows_xfer_shared_library): Update.
10507
10508 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10509
10510         * gdbarch.sh: Add declaration for _initialize_gdbarch.
10511
10512 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10513
10514         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
10515         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
10516         replace with range-based for.
10517         (gdbsim_interrupt_inferior): Remove.
10518         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
10519         with a range-based for.  Inline code from
10520         gdbsim_interrupt_inferior.
10521
10522 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10523
10524         * infrun.c (proceed): Fix indentation.
10525
10526 2020-01-21  Tom Tromey  <tromey@adacore.com>
10527
10528         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
10529         * python/python.c (python_extension_ops): Update.
10530         (gdbpy_colorize): New function.
10531         * python/lib/gdb/__init__.py (colorize): New function.
10532         * extension.h (ext_lang_colorize): Declare.
10533         * extension.c (ext_lang_colorize): New function.
10534         * extension-priv.h (struct extension_language_ops) <colorize>: New
10535         member.
10536         * cli/cli-style.c (_initialize_cli_style): Update help text.
10537
10538 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10539
10540         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
10541         <cond>: Change type to bool.
10542         (aarch64_displaced_step_b_cond): Update cond to use bool type.
10543         (aarch64_displaced_step_cb): Likewise.
10544         (aarch64_displaced_step_tb): Likewise.
10545
10546 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10547
10548         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
10549         output.
10550
10551 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10552
10553         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
10554         <pc_adjust>: Adjust the documentation.
10555         (aarch64_displaced_step_fixup): Check if PC really moved before
10556         adjusting it.
10557
10558 2020-01-19  Tom Tromey  <tom@tromey.com>
10559
10560         * disasm.c (~gdb_disassembler): New destructor.
10561         (gdb_buffered_insn_length): Call disassemble_free_target.
10562         * disasm.h (class gdb_disassembler): Declare destructor.  Use
10563         DISABLE_COPY_AND_ASSIGN.
10564
10565 2020-01-19  Tom Tromey  <tom@tromey.com>
10566
10567         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
10568         (die_reader_func_ftype): Remove.
10569         (cutu_reader): New class.
10570         (dw2_get_file_names_reader): Remove "data" parameter.
10571         (dw2_get_file_names): Use cutu_reader.
10572         (create_debug_type_hash_table): Update.
10573         (read_cutu_die_from_dwo): Update comment.
10574         (lookup_dwo_unit): Add dwo_name parameter.
10575         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
10576         die_reader_func_ftype and data parameters.
10577         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
10578         Remove die_reader_func_ftype and data parameters.
10579         (~cutu_reader): New; from init_cutu_and_read_dies.
10580         (cutu_reader::cutu_reader): Rename from
10581         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
10582         and data parameters.
10583         (init_cutu_and_read_dies_simple): Remove.
10584         (struct process_psymtab_comp_unit_data): Remove.
10585         (process_psymtab_comp_unit_reader): Remove data parameter; add
10586         want_partial_unit and pretend_language parameters.
10587         (process_psymtab_comp_unit): Use cutu_reader.
10588         (build_type_psymtabs_reader): Remove data parameter.
10589         (build_type_psymtabs_1): Use cutu_reader.
10590         (process_skeletonless_type_unit): Likewise.
10591         (load_partial_comp_unit_reader): Remove.
10592         (load_partial_comp_unit): Use cutu_reader.
10593         (load_full_comp_unit_reader): Remove.
10594         (load_full_comp_unit): Use cutu_reader.
10595         (struct create_dwo_cu_data): Remove.
10596         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
10597         dwo_unit parameters.
10598         (create_cus_hash_table): Use cutu_reader.
10599         (struct dwarf2_read_addr_index_data): Remove.
10600         (dwarf2_read_addr_index_reader): Remove.
10601         (dwarf2_read_addr_index): Use cutu_reader.
10602         (read_signatured_type_reader): Remove.
10603         (read_signatured_type): Use cutu_reader.
10604
10605 2020-01-19  Tom Tromey  <tom@tromey.com>
10606
10607         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
10608         * tui/tui-wingeneral.h (class tui_suppress_output): New.
10609         (tui_wrefresh): Declare.
10610         * tui/tui-wingeneral.c (suppress_output): New global.
10611         (tui_suppress_output, ~tui_suppress_output): New constructor and
10612         destructor.
10613         (tui_wrefresh): New function.
10614         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
10615         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
10616         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
10617         method.
10618         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
10619         tui_wrefresh.
10620         (tui_data_window::no_refresh): New method.
10621         (tui_data_item_window::refresh_window): Call tui_wrefresh.
10622         (tui_reg_command): Use tui_suppress_output
10623         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
10624         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
10625         method.
10626         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
10627
10628 2020-01-19  Tom Tromey  <tom@tromey.com>
10629
10630         * tui/tui-winsource.c (tui_update_source_windows_with_line):
10631         Handle case where symtab is null.
10632
10633 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
10634
10635         * linux-fork.c (one_fork_p): Simplify.
10636
10637 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10638
10639         * top.c (struct qt_args): Remove.
10640         (kill_or_detach): Change return type to void, replace `void *`
10641         parameter with a proper one.
10642         (print_inferior_quit_action):  Likewise.
10643         (quit_confirm): Use range-based for loop to iterate over inferiors.
10644         (quit_force): Likewise.
10645
10646 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10647
10648         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
10649         `void *` parameter with proper parameters.
10650         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
10651         (print_one_inferior): Change return type to void, replace `void *`
10652         parameter with proper parameters.
10653         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
10654         inferiors.
10655         (get_other_inferior): Remove.
10656         (mi_cmd_remove_inferior): Use range-based loop to iterate over
10657         inferiors.
10658
10659 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10660
10661         * mi/mi-interp.c (report_initial_inferior): Remove.
10662         (mi_interp::init): Use range-based for to iterate over inferiors.
10663
10664 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10665
10666         * python/py-inferior.c (build_inferior_list): Remove.
10667         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
10668
10669 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
10670
10671         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
10672         (btrace_stitch_trace): Likewise.
10673         * charset.c (intermediate_encoding): Likewise (vaild).
10674         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
10675         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
10676         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
10677
10678 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
10679
10680         * windows-tdep.c (windows_get_tlb_type):
10681         Add rtl_user_process_parameters type.
10682
10683 2020-01-16  Pedro Alves  <palves@redhat.com>
10684             Norbert Lange  <nolange79@gmail.com>
10685
10686         PR build/24805
10687         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
10688         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
10689         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
10690         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
10691         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
10692         (ps_plog): Redeclare exported functions with default visibility.
10693
10694 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
10695
10696         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
10697         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
10698
10699 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
10700
10701         * infcmd.c (post_create_inferior): Use get_thread_regcache
10702         instead of get_current_regcache.
10703
10704 2020-01-14  Tom Tromey  <tom@tromey.com>
10705
10706         PR symtab/12535:
10707         * python/python.c (gdbpy_decode_line): Treat empty string the same
10708         as no argument.
10709
10710 2020-01-14  Tom Tromey  <tom@tromey.com>
10711
10712         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
10713
10714 2020-01-14  Tom Tromey  <tom@tromey.com>
10715
10716         * nat/linux-btrace.c: Don't include <config.h>.
10717         * nat/linux-ptrace.c: Don't include <config.h>.
10718         * nat/x86-linux-dregs.c: Don't include <config.h>.
10719
10720 2020-01-14  Tom Tromey  <tom@tromey.com>
10721
10722         * configure: Rebuild.
10723         * configure.ac: Move many checks to ../gdbsupport/common.m4.
10724
10725 2020-01-14  Tom Tromey  <tom@tromey.com>
10726
10727         * nat/x86-linux-dregs.c: Include configh.h.
10728         * nat/linux-ptrace.c: Include configh.h.
10729         * nat/linux-btrace.c: Include configh.h.
10730         * defs.h: Include config.h, bfd.h.
10731         * configure.ac: Don't source common.host.
10732         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
10733         * configure: Rebuild.
10734         * acinclude.m4: Update path.
10735         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
10736         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
10737         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
10738         (CLIBS): Add LIBSUPPORT.
10739         (CDEPS): Likewise.
10740         (COMMON_SFILES): Remove gdbsupport files.
10741         (HFILES_NO_SRCDIR): Likewise.
10742         (stamp-version): Update path to create-version.sh.
10743         (ALLDEPFILES): Remove gdbsupport files.
10744
10745 2020-01-14  Tom Tromey  <tom@tromey.com>
10746
10747         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
10748         USE_WIN32API when needed.
10749         * configure.ac (USE_WIN32API): Don't define.
10750         (WIN32LIBS): Use WIN32APILIBS.
10751         * configure: Rebuild.
10752
10753 2020-01-14  Tom Tromey  <tom@tromey.com>
10754
10755         * configure: Rebuild.
10756         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
10757
10758 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10759
10760         * skip.c (skip_function_command): Make skip w/o arguments use the
10761         name of the inlined function if pc is inside any inlined function.
10762
10763 2020-01-14  Luis Machado  <luis.machado@linaro.org>
10764
10765         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
10766         * infrun.c (resume_1): Likewise.
10767         (handle_inferior_event): Remove stale comment.
10768         * linux-nat.c (linux_nat_target::resume): Update comments.
10769         (save_stop_reason): Likewise.
10770         (linux_nat_filter_event): Likewise.
10771         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
10772
10773 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10774
10775         * elfread.c (record_minimal_symbol): Set section index to 0 for
10776         non-allocatable sections.
10777
10778
10779 2020-01-13  Ali Tamur <tamur@google.com>
10780
10781         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
10782         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
10783         to gdb::optional.  Update comments.
10784         (dwo_file): Update comments.
10785         (read_attribute): Update API to take an additional out parameter,
10786         need_reprocess.  This is used to mark attributes that need other
10787         attributes (e.g. str_offsets_base) for correct computation which may not
10788         have been read yet.
10789         (read_attribute_reprocess): New function declaration.
10790         (read_addr_index): Likewise.
10791         (read_dwo_str_index): Likewise.
10792         (read_stub_str_index): Likewise.
10793         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
10794         (lookup_addr_base): New function definition.
10795         (lookup_ranges_base): Likewise.
10796         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
10797         lookup_ranges_base.
10798         (init_cutu_and_read_dies): Update comments.
10799         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
10800         unit.  This is used to inherit parent's str_offsets_base and addr_base.
10801         Update comments.
10802         (init_cutu_and_read_dies_simple): Reflect API changes.
10803         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
10804         (create_cus_hash_table): Change API to take parent compile unit.
10805         Reflect API changes.
10806         (open_and_init_dwo_file): Reflect API changes.
10807         (dwarf2_get_pc_bounds): Update comments.
10808         (dwarf2_record_block_ranges): Likewise.
10809         (read_full_die_1): Change implementation to reprocess attributes that
10810         need str_offsets_base and addr_base.
10811         (partial_die_info::read): Likewise.
10812         (read_attribute_reprocess): New function definition.
10813         (read_attribute_value): Change API to take an additional out parameter,
10814         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
10815         when a non-dwo compile unit has index based attributes.
10816         (read_attribute): Reflect API changes.
10817         (read_addr_index_1): Reflect API changes.  Update comments.
10818         (dwarf2_read_addr_index_data): Reflect API changes.
10819         (dwarf2_read_addr_index): Likewise.
10820         (read_str_index): Change API and implementation.  This becomes a helper
10821         to be used by the new string index related methods.  Update error
10822         message and comments.
10823         (read_dwo_str_index): New function definition.
10824         (read_stub_str_index): Likewise.
10825         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
10826         * symfile.h (dwarf2_debug_sections): Likewise.
10827         * xcoffread.c (dwarf2_debug_sections): Likewise.
10828
10829 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10830
10831         * gdbcore.h (struct core_fns) <core_read_registers>: Change
10832         core_reg_sect type to gdb_byte *.
10833         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
10834         * cris-tdep.c (fetch_core_registers): Likewise.
10835         * corelow.c (core_target::get_core_register_section): Change
10836         type of `contents` to gdb::byte_vector.
10837
10838 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10839
10840         * tui/tui-wingeneral.c (box_win): Position the title in the center
10841         of the border.
10842
10843 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10844
10845         * corelow.c (core_target::get_core_register_section): Use
10846           std::vector instead of alloca.
10847
10848 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10849
10850         * warning.m4: Add -Wmissing-declarations to build_warnings.
10851         * configure: Re-generate.
10852
10853 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10854
10855         * python/python.c (init__gdb_module): Add declaration.
10856
10857 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10858
10859         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
10860         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
10861         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
10862         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
10863         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
10864         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
10865         * ada-exp.y (_initialize_ada_exp): Add declaration.
10866         * ada-lang.c (_initialize_ada_language): Add declaration.
10867         * ada-tasks.c (_initialize_tasks): Add declaration.
10868         * agent.c (_initialize_agent): Add declaration.
10869         * aix-thread.c (_initialize_aix_thread): Add declaration.
10870         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
10871         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
10872         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
10873         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
10874         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
10875         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
10876         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
10877         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
10878         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
10879         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
10880         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
10881         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
10882         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
10883         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
10884         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
10885         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
10886         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
10887         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
10888         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
10889         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
10890         * annotate.c (_initialize_annotate): Add declaration.
10891         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
10892         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
10893         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
10894         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
10895         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
10896         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
10897         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
10898         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
10899         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
10900         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
10901         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
10902         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
10903         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
10904         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
10905         * auto-load.c (_initialize_auto_load): Add declaration.
10906         * auxv.c (_initialize_auxv): Add declaration.
10907         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
10908         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
10909         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
10910         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
10911         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
10912         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
10913         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
10914         * breakpoint.c (_initialize_breakpoint): Add declaration.
10915         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
10916         * btrace.c (_initialize_btrace): Add declaration.
10917         * charset.c (_initialize_charset): Add declaration.
10918         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
10919         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
10920         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
10921         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
10922         * cli/cli-script.c (_initialize_cli_script): Add declaration.
10923         * cli/cli-style.c (_initialize_cli_style): Add declaration.
10924         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
10925         * coffread.c (_initialize_coffread): Add declaration.
10926         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
10927         * compile/compile.c (_initialize_compile): Add declaration.
10928         * complaints.c (_initialize_complaints): Add declaration.
10929         * completer.c (_initialize_completer): Add declaration.
10930         * copying.c (_initialize_copying): Add declaration.
10931         * corefile.c (_initialize_core): Add declaration.
10932         * corelow.c (_initialize_corelow): Add declaration.
10933         * cp-abi.c (_initialize_cp_abi): Add declaration.
10934         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
10935         * cp-support.c (_initialize_cp_support): Add declaration.
10936         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
10937         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
10938         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
10939         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
10940         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
10941         * ctfread.c (_initialize_ctfread): Add declaration.
10942         * d-lang.c (_initialize_d_language): Add declaration.
10943         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
10944         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
10945         * dbxread.c (_initialize_dbxread): Add declaration.
10946         * dcache.c (_initialize_dcache): Add declaration.
10947         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
10948         * disasm.c (_initialize_disasm): Add declaration.
10949         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
10950         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
10951         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
10952         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
10953         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
10954         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
10955         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
10956         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
10957         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
10958         * elfread.c (_initialize_elfread): Add declaration.
10959         * exec.c (_initialize_exec): Add declaration.
10960         * extension.c (_initialize_extension): Add declaration.
10961         * f-lang.c (_initialize_f_language): Add declaration.
10962         * f-valprint.c (_initialize_f_valprint): Add declaration.
10963         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
10964         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
10965         * filesystem.c (_initialize_filesystem): Add declaration.
10966         * findcmd.c (_initialize_mem_search): Add declaration.
10967         * findvar.c (_initialize_findvar): Add declaration.
10968         * fork-child.c (_initialize_fork_child): Add declaration.
10969         * frame-base.c (_initialize_frame_base): Add declaration.
10970         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
10971         * frame.c (_initialize_frame): Add declaration.
10972         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
10973         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
10974         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
10975         * gcore.c (_initialize_gcore): Add declaration.
10976         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
10977         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
10978         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
10979         * gdbarch.c (_initialize_gdbarch): Add declaration.
10980         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
10981         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
10982         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
10983         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
10984         * go-lang.c (_initialize_go_language): Add declaration.
10985         * go32-nat.c (_initialize_go32_nat): Add declaration.
10986         * guile/guile.c (_initialize_guile): Add declaration.
10987         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
10988         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
10989         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
10990         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
10991         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
10992         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
10993         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
10994         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
10995         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
10996         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
10997         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
10998         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
10999         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
11000         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
11001         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
11002         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
11003         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
11004         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
11005         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
11006         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
11007         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
11008         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
11009         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
11010         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
11011         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
11012         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
11013         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
11014         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
11015         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
11016         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
11017         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
11018         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
11019         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
11020         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
11021         * infcall.c (_initialize_infcall): Add declaration.
11022         * infcmd.c (_initialize_infcmd): Add declaration.
11023         * inflow.c (_initialize_inflow): Add declaration.
11024         * infrun.c (_initialize_infrun): Add declaration.
11025         * interps.c (_initialize_interpreter): Add declaration.
11026         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
11027         * jit.c (_initialize_jit): Add declaration.
11028         * language.c (_initialize_language): Add declaration.
11029         * linux-fork.c (_initialize_linux_fork): Add declaration.
11030         * linux-nat.c (_initialize_linux_nat): Add declaration.
11031         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
11032         * linux-thread-db.c (_initialize_thread_db): Add declaration.
11033         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
11034         * m2-lang.c (_initialize_m2_language): Add declaration.
11035         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
11036         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
11037         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
11038         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
11039         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
11040         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
11041         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
11042         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
11043         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
11044         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
11045         * machoread.c (_initialize_machoread): Add declaration.
11046         * macrocmd.c (_initialize_macrocmd): Add declaration.
11047         * macroscope.c (_initialize_macroscope): Add declaration.
11048         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
11049         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
11050         * maint.c (_initialize_maint_cmds): Add declaration.
11051         * mdebugread.c (_initialize_mdebugread): Add declaration.
11052         * memattr.c (_initialize_mem): Add declaration.
11053         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
11054         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
11055         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
11056         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
11057         * mi/mi-main.c (_initialize_mi_main): Add declaration.
11058         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
11059         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
11060         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
11061         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
11062         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
11063         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
11064         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
11065         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
11066         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
11067         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
11068         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
11069         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
11070         * mipsread.c (_initialize_mipsread): Add declaration.
11071         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
11072         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
11073         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
11074         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
11075         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
11076         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
11077         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
11078         * nto-procfs.c (_initialize_procfs): Add declaration.
11079         * objc-lang.c (_initialize_objc_language): Add declaration.
11080         * observable.c (_initialize_observer): Add declaration.
11081         * opencl-lang.c (_initialize_opencl_language): Add declaration.
11082         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
11083         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
11084         * osabi.c (_initialize_gdb_osabi): Add declaration.
11085         * osdata.c (_initialize_osdata): Add declaration.
11086         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
11087         * parse.c (_initialize_parse): Add declaration.
11088         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
11089         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
11090         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
11091         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
11092         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
11093         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
11094         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
11095         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
11096         * printcmd.c (_initialize_printcmd): Add declaration.
11097         * probe.c (_initialize_probe): Add declaration.
11098         * proc-api.c (_initialize_proc_api): Add declaration.
11099         * proc-events.c (_initialize_proc_events): Add declaration.
11100         * proc-service.c (_initialize_proc_service): Add declaration.
11101         * procfs.c (_initialize_procfs): Add declaration.
11102         * producer.c (_initialize_producer): Add declaration.
11103         * psymtab.c (_initialize_psymtab): Add declaration.
11104         * python/python.c (_initialize_python): Add declaration.
11105         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
11106         * record-btrace.c (_initialize_record_btrace): Add declaration.
11107         * record-full.c (_initialize_record_full): Add declaration.
11108         * record.c (_initialize_record): Add declaration.
11109         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
11110         * regcache.c (_initialize_regcache): Add declaration.
11111         * reggroups.c (_initialize_reggroup): Add declaration.
11112         * remote-notif.c (_initialize_notif): Add declaration.
11113         * remote-sim.c (_initialize_remote_sim): Add declaration.
11114         * remote.c (_initialize_remote): Add declaration.
11115         * reverse.c (_initialize_reverse): Add declaration.
11116         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
11117         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
11118         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
11119         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
11120         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
11121         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
11122         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
11123         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
11124         Add declaration.
11125         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
11126         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
11127         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
11128         * rust-exp.y (_initialize_rust_exp): Add declaration.
11129         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
11130         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
11131         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
11132         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
11133         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
11134         * score-tdep.c (_initialize_score_tdep): Add declaration.
11135         * ser-go32.c (_initialize_ser_dos): Add declaration.
11136         * ser-mingw.c (_initialize_ser_windows): Add declaration.
11137         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
11138         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
11139         * ser-uds.c (_initialize_ser_socket): Add declaration.
11140         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
11141         * serial.c (_initialize_serial): Add declaration.
11142         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
11143         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
11144         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
11145         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
11146         * skip.c (_initialize_step_skip): Add declaration.
11147         * sol-thread.c (_initialize_sol_thread): Add declaration.
11148         * solib-aix.c (_initialize_solib_aix): Add declaration.
11149         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
11150         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
11151         * solib-frv.c (_initialize_frv_solib): Add declaration.
11152         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
11153         * solib-target.c (_initialize_solib_target): Add declaration.
11154         * solib.c (_initialize_solib): Add declaration.
11155         * source-cache.c (_initialize_source_cache): Add declaration.
11156         * source.c (_initialize_source): Add declaration.
11157         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
11158         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
11159         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
11160         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
11161         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
11162         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
11163         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
11164         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
11165         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
11166         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
11167         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
11168         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
11169         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
11170         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
11171         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
11172         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
11173         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
11174         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
11175         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
11176         * stabsread.c (_initialize_stabsread): Add declaration.
11177         * stack.c (_initialize_stack): Add declaration.
11178         * stap-probe.c (_initialize_stap_probe): Add declaration.
11179         * std-regs.c (_initialize_frame_reg): Add declaration.
11180         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
11181         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
11182         * symfile.c (_initialize_symfile): Add declaration.
11183         * symmisc.c (_initialize_symmisc): Add declaration.
11184         * symtab.c (_initialize_symtab): Add declaration.
11185         * target.c (_initialize_target): Add declaration.
11186         * target-connection.c (_initialize_target_connection): Add
11187         declaration.
11188         * target-dcache.c (_initialize_target_dcache): Add declaration.
11189         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
11190         * thread.c (_initialize_thread): Add declaration.
11191         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
11192         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
11193         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
11194         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
11195         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
11196         * tracectf.c (_initialize_ctf): Add declaration.
11197         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
11198         * tracefile.c (_initialize_tracefile): Add declaration.
11199         * tracepoint.c (_initialize_tracepoint): Add declaration.
11200         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
11201         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
11202         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
11203         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
11204         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
11205         * tui/tui-win.c (_initialize_tui_win): Add declaration.
11206         * tui/tui.c (_initialize_tui): Add declaration.
11207         * typeprint.c (_initialize_typeprint): Add declaration.
11208         * ui-style.c (_initialize_ui_style): Add declaration.
11209         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
11210         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
11211         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
11212         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
11213         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
11214         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
11215         * unittests/filtered_iterator-selftests.c
11216         (_initialize_filtered_iterator_selftests): Add declaration.
11217         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
11218         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
11219         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
11220         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
11221         * unittests/main-thread-selftests.c
11222         (_initialize_main_thread_selftests): Add declaration.
11223         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
11224         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
11225         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
11226         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
11227         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
11228         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
11229         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
11230         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
11231         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
11232         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
11233         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
11234         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
11235         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
11236         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
11237         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
11238         declaration.
11239         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
11240         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
11241         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
11242         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
11243         * user-regs.c (_initialize_user_regs): Add declaration.
11244         * utils.c (_initialize_utils): Add declaration.
11245         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
11246         * valops.c (_initialize_valops): Add declaration.
11247         * valprint.c (_initialize_valprint): Add declaration.
11248         * value.c (_initialize_values): Add declaration.
11249         * varobj.c (_initialize_varobj): Add declaration.
11250         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
11251         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
11252         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
11253         * windows-nat.c (_initialize_windows_nat): Add declaration.
11254         (_initialize_check_for_gdb_ini): Add declaration.
11255         (_initialize_loadable): Add declaration.
11256         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
11257         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
11258         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
11259         * xcoffread.c (_initialize_xcoffread): Add declaration.
11260         * xml-support.c (_initialize_xml_support): Add declaration.
11261         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
11262         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
11263         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
11264         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
11265
11266 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11267
11268         * regformats/regdat.sh: Generate declaration for init function.
11269
11270 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11271
11272         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
11273         up.
11274         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
11275         close_one_inferior>: New methods.
11276         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
11277         pass down target to find_inferior_pid.
11278         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
11279         Pass down target to find_inferior_ptid.
11280         (gdbsim_target::create_inferior): Pass down target to
11281         add_thread_silent.
11282         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
11283         target down to find_inferior_ptid and switch_to_thread.
11284         (gdbsim_target::close): Update to call close_one_inferior.
11285         (struct resume_data): Remove.
11286         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
11287         directly, rather than through a void pointer.
11288         (gdbsim_target::resume): Update to call resume_one_inferior.
11289
11290 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
11291
11292         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
11293
11294 2020-01-12  Pedro Alves  <palves@redhat.com>
11295
11296         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
11297         directly for the current inferior instead of
11298         discard_all_inferiors.
11299         (discard_all_inferiors): Delete.
11300
11301 2020-01-11  Tom Tromey  <tom@tromey.com>
11302
11303         * tui/tui-wingeneral.c (box_win): Check cli_styling.
11304         * tui/tui-winsource.c (tui_source_window_base::refill): Use
11305         deprecated_safe_get_selected_frame.
11306
11307 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
11308
11309         * inferior.c (print_inferior): Switch inferior before printing it.
11310
11311 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
11312             Pedro Alves  <palves@redhat.com>
11313
11314         * progspace-and-thread.c (switch_to_program_space_and_thread):
11315         Assert there's an inferior for PSPACE.  Use
11316         switch_to_inferior_no_thread to switch the inferior too.
11317         * progspace.c (program_space::~program_space): Call
11318         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
11319         (program_space::free_all_objfiles): Don't call clear_symtab_users
11320         here.
11321         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
11322
11323 2020-01-10  Pedro Alves  <palves@redhat.com>
11324
11325         * NEWS: Mention multi-target debugging, "info connections", and
11326         "add-inferior -no-connection".
11327
11328 2020-01-10  Pedro Alves  <palves@redhat.com>
11329
11330         * infrun.c: Include "target-connection.h".
11331         (check_multi_target_resumption): New.
11332         (proceed): Call it.
11333         * target-connection.c (make_target_connection_string): Make
11334         extern.
11335         * target-connection.h (make_target_connection_string): Declare.
11336
11337 2020-01-10  Pedro Alves  <palves@redhat.com>
11338
11339         * Makefile.in (COMMON_SFILES): Add target-connection.c.
11340         * inferior.c (uiout_field_connection): New function.
11341         (print_inferior): Add new "connection-id" column.
11342         (add_inferior_command): Show connection number/string of added
11343         inferior.
11344         * process-stratum-target.h
11345         (process_stratum_target::connection_string): New virtual method.
11346         (process_stratum_target::connection_number): New field.
11347         * remote.c (remote_target::connection_string): New override.
11348         * target-connection.c: New file.
11349         * target-connection.h: New file.
11350         * target.c (decref_target): Remove process_stratum targets from
11351         the connection list.
11352         (target_stack::push): Add process_stratum targets to the
11353         connection list.
11354
11355 2020-01-10  Pedro Alves  <palves@redhat.com>
11356
11357         Revert:
11358         2016-04-12  Pedro Alves  <palves@redhat.com>
11359         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
11360         Remove references to name.
11361         * serial.h (struct serial) <name>: Delete.
11362
11363 2020-01-10  Pedro Alves  <palves@redhat.com>
11364
11365         * gdbarch-selftests.c (register_to_value_test): Remove "target
11366         already pushed" check.
11367
11368 2020-01-10  Pedro Alves  <palves@redhat.com>
11369             John Baldwin  <jhb@FreeBSD.org>
11370
11371         * aarch64-linux-nat.c
11372         (aarch64_linux_nat_target::thread_architecture): Adjust.
11373         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
11374         (task_command_1): Likewise.
11375         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
11376         (aix_thread_target::wait, aix_thread_target::fetch_registers)
11377         (aix_thread_target::store_registers)
11378         (aix_thread_target::thread_alive): Adjust.
11379         * amd64-fbsd-tdep.c: Include "inferior.h".
11380         (amd64fbsd_get_thread_local_address): Pass down target.
11381         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
11382         thread's gdbarch instead of target_gdbarch.
11383         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
11384         get_last_target_status.
11385         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
11386         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
11387         inferiors.
11388         (update_inserted_breakpoint_locations): Skip if inferiors with no
11389         execution.
11390         (update_global_location_list): When handling moribund locations,
11391         find representative inferior for location's pspace, and use thread
11392         count of its process_stratum target.
11393         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
11394         * bsd-uthread.c (bsd_uthread_target::wait): Use
11395         as_process_stratum_target and adjust thread_change_ptid and
11396         add_thread calls.
11397         (bsd_uthread_target::update_thread_list): Use
11398         as_process_stratum_target and adjust find_thread_ptid,
11399         thread_change_ptid and add_thread calls.
11400         * btrace.c (maint_btrace_packet_history_cmd): Adjust
11401         find_thread_ptid call.
11402         * corelow.c (add_to_thread_list): Adjust add_thread call.
11403         (core_target_open): Adjust add_thread_silent and thread_count
11404         calls.
11405         (core_target::pid_to_str): Adjust find_inferior_ptid call.
11406         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
11407         * event-top.c (async_disconnect): Pop targets from all inferiors.
11408         * exec.c (add_target_sections): Push exec target on all inferiors
11409         sharing the program space.
11410         (remove_target_sections): Remove the exec target from all
11411         inferiors sharing the program space.
11412         (exec_on_vfork): New.
11413         * exec.h (exec_on_vfork): Declare.
11414         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
11415         Pass it down.
11416         (fbsd_nat_target::update_thread_list): Adjust.
11417         (fbsd_nat_target::resume): Adjust.
11418         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
11419         down.
11420         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
11421         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
11422         get_thread_arch_regcache call.
11423         * fork-child.c (gdb_startup_inferior): Pass target down to
11424         startup_inferior and set_executing.
11425         * gdbthread.h (struct process_stratum_target): Forward declare.
11426         (add_thread, add_thread_silent, add_thread_with_info)
11427         (in_thread_list): Add process_stratum_target parameter.
11428         (find_thread_ptid(inferior*, ptid_t)): New overload.
11429         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
11430         parameter.
11431         (all_threads()): Delete overload.
11432         (all_threads, all_non_exited_threads): Add process_stratum_target
11433         parameter.
11434         (all_threads_safe): Use brace initialization.
11435         (thread_count): Add process_stratum_target parameter.
11436         (set_resumed, set_running, set_stop_requested, set_executing)
11437         (threads_are_executing, finish_thread_state): Add
11438         process_stratum_target parameter.
11439         (switch_to_thread): Use is_current_thread.
11440         * i386-fbsd-tdep.c: Include "inferior.h".
11441         (i386fbsd_get_thread_local_address): Pass down target.
11442         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
11443         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
11444         have_inferiors check.
11445         * inf-ptrace.c (inf_ptrace_target::create_inferior)
11446         (inf_ptrace_target::attach): Adjust.
11447         * infcall.c (run_inferior_call): Adjust.
11448         * infcmd.c (run_command_1): Pass target to
11449         scoped_finish_thread_state.
11450         (proceed_thread_callback): Skip inferiors with no execution.
11451         (continue_command): Rename 'all_threads' local to avoid hiding
11452         'all_threads' function.  Adjust get_last_target_status call.
11453         (prepare_one_step): Adjust set_running call.
11454         (signal_command): Use user_visible_resume_target.  Compare thread
11455         pointers instead of inferior_ptid.
11456         (info_program_command): Adjust to pass down target.
11457         (attach_command): Mark target's 'thread_executing' flag.
11458         (stop_current_target_threads_ns): New, factored out from ...
11459         (interrupt_target_1): ... this.  Switch inferior before making
11460         target calls.
11461         * inferior-iter.h
11462         (struct all_inferiors_iterator, struct all_inferiors_range)
11463         (struct all_inferiors_safe_range)
11464         (struct all_non_exited_inferiors_range): Filter on
11465         process_stratum_target too.  Remove explicit.
11466         * inferior.c (inferior::inferior): Push dummy target on target
11467         stack.
11468         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
11469         Add process_stratum_target parameter, and pass it down.
11470         (have_live_inferiors): Adjust.
11471         (switch_to_inferior_and_push_target): New.
11472         (add_inferior_command, clone_inferior_command): Handle
11473         "-no-connection" parameter.  Use
11474         switch_to_inferior_and_push_target.
11475         (_initialize_inferior): Mention "-no-connection" option in
11476         the help of "add-inferior" and "clone-inferior" commands.
11477         * inferior.h: Include "process-stratum-target.h".
11478         (interrupt_target_1): Use bool.
11479         (struct inferior) <push_target, unpush_target, target_is_pushed,
11480         find_target_beneath, top_target, process_target, target_at,
11481         m_stack>: New.
11482         (discard_all_inferiors): Delete.
11483         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
11484         (all_inferiors, all_non_exited_inferiors): Add
11485         process_stratum_target parameter.
11486         * infrun.c: Include "gdb_select.h" and <unordered_map>.
11487         (target_last_proc_target): New global.
11488         (follow_fork_inferior): Push target on new inferior.  Pass target
11489         to add_thread_silent.  Call exec_on_vfork.  Handle target's
11490         reference count.
11491         (follow_fork): Adjust get_last_target_status call.  Also consider
11492         target.
11493         (follow_exec): Push target on new inferior.
11494         (struct execution_control_state) <target>: New field.
11495         (user_visible_resume_target): New.
11496         (do_target_resume): Call target_async.
11497         (resume_1): Set target's threads_executing flag.  Consider resume
11498         target.
11499         (commit_resume_all_targets): New.
11500         (proceed): Also consider resume target.  Skip threads of inferiors
11501         with no execution.  Commit resumtion in all targets.
11502         (start_remote): Pass current inferior to wait_for_inferior.
11503         (infrun_thread_stop_requested): Consider target as well.  Pass
11504         thread_info pointer to clear_inline_frame_state instead of ptid.
11505         (infrun_thread_thread_exit): Consider target as well.
11506         (random_pending_event_thread): New inferior parameter.  Use it.
11507         (do_target_wait): Rename to ...
11508         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
11509         down.
11510         (threads_are_resumed_pending_p, do_target_wait): New.
11511         (prepare_for_detach): Adjust calls.
11512         (wait_for_inferior): New inferior parameter.  Handle it.  Use
11513         do_target_wait_1 instead of do_target_wait.
11514         (fetch_inferior_event): Adjust.  Switch to representative
11515         inferior.  Pass target down.
11516         (set_last_target_status): Add process_stratum_target parameter.
11517         Save target in global.
11518         (get_last_target_status): Add process_stratum_target parameter and
11519         handle it.
11520         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
11521         (context_switch): Check inferior_ptid == null_ptid before calling
11522         inferior_thread().
11523         (get_inferior_stop_soon): Pass down target.
11524         (wait_one): Rename to ...
11525         (poll_one_curr_target): ... this.
11526         (struct wait_one_event): New.
11527         (wait_one): New.
11528         (stop_all_threads): Adjust.
11529         (handle_no_resumed, handle_inferior_event): Adjust to consider the
11530         event's target.
11531         (switch_back_to_stepped_thread): Also consider target.
11532         (print_stop_event): Update.
11533         (normal_stop): Update.  Also consider the resume target.
11534         * infrun.h (wait_for_inferior): Remove declaration.
11535         (user_visible_resume_target): New declaration.
11536         (get_last_target_status, set_last_target_status): New
11537         process_stratum_target parameter.
11538         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
11539         process_stratum_target parameter, and use it.
11540         (clear_inline_frame_state (thread_info*)): New.
11541         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
11542         process_stratum_target parameter.
11543         (clear_inline_frame_state (thread_info*)): Declare.
11544         * linux-fork.c (delete_checkpoint_command): Pass target down to
11545         find_thread_ptid.
11546         (checkpoint_command): Adjust.
11547         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
11548         instead of just tweaking inferior_ptid.
11549         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
11550         (exit_lwp): Pass target down to find_thread_ptid.
11551         (attach_proc_task_lwp_callback): Pass target down to
11552         add_thread/set_running/set_executing.
11553         (linux_nat_target::attach): Pass target down to
11554         thread_change_ptid.
11555         (get_detach_signal): Pass target down to find_thread_ptid.
11556         Consider last target status's target.
11557         (linux_resume_one_lwp_throw, resume_lwp)
11558         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
11559         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
11560         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
11561         (linux_nat_target::async_wait_fd): New.
11562         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
11563         target down.
11564         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
11565         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
11566         * linux-thread-db.c (struct thread_db_info::process_target): New
11567         field.
11568         (add_thread_db_info): Save target.
11569         (get_thread_db_info): New process_stratum_target parameter.  Also
11570         match target.
11571         (delete_thread_db_info): New process_stratum_target parameter.
11572         Also match target.
11573         (thread_from_lwp): Adjust to pass down target.
11574         (thread_db_notice_clone): Pass down target.
11575         (check_thread_db_callback): Pass down target.
11576         (try_thread_db_load_1): Always push the thread_db target.
11577         (try_thread_db_load, record_thread): Pass target down.
11578         (thread_db_target::detach): Pass target down.  Always unpush the
11579         thread_db target.
11580         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
11581         target down.  Always unpush the thread_db target.
11582         (find_new_threads_callback, thread_db_find_new_threads_2)
11583         (thread_db_target::update_thread_list): Pass target down.
11584         (thread_db_target::pid_to_str): Pass current inferior down.
11585         (thread_db_target::get_thread_local_address): Pass target down.
11586         (thread_db_target::resume, maintenance_check_libthread_db): Pass
11587         target down.
11588         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
11589         * procfs.c (procfs_target::procfs_init_inferior): Declare.
11590         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
11591         (procfs_init_inferior): Rename to ...
11592         (procfs_target::procfs_init_inferior): ... this and adjust.
11593         (procfs_target::create_inferior, procfs_notice_thread)
11594         (procfs_do_thread_registers): Adjust.
11595         * ppc-fbsd-tdep.c: Include "inferior.h".
11596         (ppcfbsd_get_thread_local_address): Pass down target.
11597         * proc-service.c (ps_xfer_memory): Switch current inferior and
11598         program space as well.
11599         (get_ps_regcache): Pass target down.
11600         * process-stratum-target.c
11601         (process_stratum_target::thread_address_space)
11602         (process_stratum_target::thread_architecture): Pass target down.
11603         * process-stratum-target.h
11604         (process_stratum_target::threads_executing): New field.
11605         (as_process_stratum_target): New.
11606         * ravenscar-thread.c
11607         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
11608         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
11609         down.
11610         * record-btrace.c (record_btrace_target::info_record): Adjust.
11611         (record_btrace_target::record_method)
11612         (record_btrace_target::record_is_replaying)
11613         (record_btrace_target::fetch_registers)
11614         (get_thread_current_frame_id, record_btrace_target::resume)
11615         (record_btrace_target::wait, record_btrace_target::stop): Pass
11616         target down.
11617         * record-full.c (record_full_wait_1): Switch to event thread.
11618         Pass target down.
11619         * regcache.c (regcache::regcache)
11620         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
11621         process_stratum_target parameter and handle it.
11622         (current_thread_target): New global.
11623         (get_thread_regcache): Add process_stratum_target parameter and
11624         handle it.  Switch inferior before calling target method.
11625         (get_thread_regcache): Pass target down.
11626         (get_thread_regcache_for_ptid): Pass target down.
11627         (registers_changed_ptid): Add process_stratum_target parameter and
11628         handle it.
11629         (registers_changed_thread, registers_changed): Pass target down.
11630         (test_get_thread_arch_aspace_regcache): New.
11631         (current_regcache_test): Define a couple local test_target_ops
11632         instances and use them for testing.
11633         (readwrite_regcache): Pass process_stratum_target parameter.
11634         (cooked_read_test, cooked_write_test): Pass mock_target down.
11635         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
11636         (get_thread_arch_aspace_regcache): Add process_stratum_target
11637         parameter.
11638         (regcache::target): New method.
11639         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
11640         (regcache::registers_changed_ptid): Add process_stratum_target
11641         parameter.
11642         (regcache::m_target): New field.
11643         (registers_changed_ptid): Add process_stratum_target parameter.
11644         * remote.c (remote_state::supports_vCont_probed): New field.
11645         (remote_target::async_wait_fd): New method.
11646         (remote_unpush_and_throw): Add remote_target parameter.
11647         (get_current_remote_target): Adjust.
11648         (remote_target::remote_add_inferior): Push target.
11649         (remote_target::remote_add_thread)
11650         (remote_target::remote_notice_new_inferior)
11651         (get_remote_thread_info): Pass target down.
11652         (remote_target::update_thread_list): Skip threads of inferiors
11653         bound to other targets.  (remote_target::close): Don't discard
11654         inferiors.  (remote_target::add_current_inferior_and_thread)
11655         (remote_target::process_initial_stop_replies)
11656         (remote_target::start_remote)
11657         (remote_target::remote_serial_quit_handler): Pass down target.
11658         (remote_target::remote_unpush_target): New remote_target
11659         parameter.  Unpush the target from all inferiors.
11660         (remote_target::remote_unpush_and_throw): New remote_target
11661         parameter.  Pass it down.
11662         (remote_target::open_1): Check whether the current inferior has
11663         execution instead of checking whether any inferior is live.  Pass
11664         target down.
11665         (remote_target::remote_detach_1): Pass down target.  Use
11666         remote_unpush_target.
11667         (extended_remote_target::attach): Pass down target.
11668         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
11669         (remote_target::append_resumption): Pass down target.
11670         (remote_target::append_pending_thread_resumptions)
11671         (remote_target::remote_resume_with_hc, remote_target::resume)
11672         (remote_target::commit_resume): Pass down target.
11673         (remote_target::remote_stop_ns): Check supports_vCont_probed.
11674         (remote_target::interrupt_query)
11675         (remote_target::remove_new_fork_children)
11676         (remote_target::check_pending_events_prevent_wildcard_vcont)
11677         (remote_target::remote_parse_stop_reply)
11678         (remote_target::process_stop_reply): Pass down target.
11679         (first_remote_resumed_thread): New remote_target parameter.  Pass
11680         it down.
11681         (remote_target::wait_as): Pass down target.
11682         (unpush_and_perror): New remote_target parameter.  Pass it down.
11683         (remote_target::readchar, remote_target::remote_serial_write)
11684         (remote_target::getpkt_or_notif_sane_1)
11685         (remote_target::kill_new_fork_children, remote_target::kill): Pass
11686         down target.
11687         (remote_target::mourn_inferior): Pass down target.  Use
11688         remote_unpush_target.
11689         (remote_target::core_of_thread)
11690         (remote_target::remote_btrace_maybe_reopen): Pass down target.
11691         (remote_target::pid_to_exec_file)
11692         (remote_target::thread_handle_to_thread_info): Pass down target.
11693         (remote_target::async_wait_fd): New.
11694         * riscv-fbsd-tdep.c: Include "inferior.h".
11695         (riscv_fbsd_get_thread_local_address): Pass down target.
11696         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
11697         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
11698         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
11699         Adjust.
11700         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
11701         * solib-svr4.c (enable_break): Pass down target.
11702         * spu-multiarch.c (parse_spufs_run): Pass down target.
11703         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
11704         * target-delegates.c: Regenerate.
11705         * target.c (g_target_stack): Delete.
11706         (current_top_target): Return the current inferior's top target.
11707         (target_has_execution_1): Refer to the passed-in inferior's top
11708         target.
11709         (target_supports_terminal_ours): Check whether the initial
11710         inferior was already created.
11711         (decref_target): New.
11712         (target_stack::push): Incref/decref the target.
11713         (push_target, push_target, unpush_target): Adjust.
11714         (target_stack::unpush): Defref target.
11715         (target_is_pushed): Return bool.  Adjust to refer to the current
11716         inferior's target stack.
11717         (dispose_inferior): Delete, and inline parts ...
11718         (target_preopen): ... here.  Only dispose of the current inferior.
11719         (target_detach): Hold strong target reference while detaching.
11720         Pass target down.
11721         (target_thread_name): Add assertion.
11722         (target_resume): Pass down target.
11723         (target_ops::beneath, find_target_at): Adjust to refer to the
11724         current inferior's target stack.
11725         (get_dummy_target): New.
11726         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
11727         has a thread running.
11728         (initialize_targets): Rename to ...
11729         (_initialize_target): ... this.
11730         * target.h: Include "gdbsupport/refcounted-object.h".
11731         (struct target_ops): Inherit refcounted_object.
11732         (target_ops::shortname, target_ops::longname): Make const.
11733         (target_ops::async_wait_fd): New method.
11734         (decref_target): Declare.
11735         (struct target_ops_ref_policy): New.
11736         (target_ops_ref): New typedef.
11737         (get_dummy_target): Declare function.
11738         (target_is_pushed): Return bool.
11739         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
11740         (all_matching_threads_iterator::all_matching_threads_iterator):
11741         Handle filter target.
11742         * thread-iter.h (struct all_matching_threads_iterator, struct
11743         all_matching_threads_range, class all_non_exited_threads_range):
11744         Filter by target too.  Remove explicit.
11745         * thread.c (threads_executing): Delete.
11746         (inferior_thread): Pass down current inferior.
11747         (clear_thread_inferior_resources): Pass down thread pointer
11748         instead of ptid_t.
11749         (add_thread_silent, add_thread_with_info, add_thread): Add
11750         process_stratum_target parameter.  Use it for thread and inferior
11751         searches.
11752         (is_current_thread): New.
11753         (thread_info::deletable): Use it.
11754         (find_thread_ptid, thread_count, in_thread_list)
11755         (thread_change_ptid, set_resumed, set_running): New
11756         process_stratum_target parameter.  Pass it down.
11757         (set_executing): New process_stratum_target parameter.  Pass it
11758         down.  Adjust reference to 'threads_executing'.
11759         (threads_are_executing): New process_stratum_target parameter.
11760         Adjust reference to 'threads_executing'.
11761         (set_stop_requested, finish_thread_state): New
11762         process_stratum_target parameter.  Pass it down.
11763         (switch_to_thread): Also match inferior.
11764         (switch_to_thread): New process_stratum_target parameter.  Pass it
11765         down.
11766         (update_threads_executing): Reimplement.
11767         * top.c (quit_force): Pop targets from all inferior.
11768         (gdb_init): Don't call initialize_targets.
11769         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
11770         Declare.
11771         (windows_add_thread, windows_delete_thread): Adjust.
11772         (get_windows_debug_event): Rename to ...
11773         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
11774         * tracefile-tfile.c (tfile_target_open): Pass down target.
11775         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
11776         Forward declare.
11777         (switch_to_thread): Add process_stratum_target parameter.
11778         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
11779         parameter.  Use it.
11780         (mi_on_resume): Pass target down.
11781         * nat/fork-inferior.c (startup_inferior): Add
11782         process_stratum_target parameter.  Pass it down.
11783         * nat/fork-inferior.h (startup_inferior): Add
11784         process_stratum_target parameter.
11785         * python/py-threadevent.c (py_get_event_thread): Pass target down.
11786
11787 2020-01-10  Pedro Alves  <palves@redhat.com>
11788
11789         * remote.c (remote_target::start_remote): Don't set inferior_ptid
11790         directly.  Instead find the first thread in the thread list and
11791         use switch_to_thread.
11792
11793 2020-01-10  Pedro Alves  <palves@redhat.com>
11794
11795         * remote.c (remote_target::remote_add_inferior): Don't bind a
11796         process to the current inferior if the current inferior is already
11797         bound to a process.
11798
11799 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
11800             Pedro Alves  <palves@redhat.com>
11801
11802         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
11803         If no process is specified, return null_ptid instead of
11804         inferior_ptid.
11805         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
11806         TARGET_WAITKIND_SIGNALLED with no pid.
11807
11808 2020-01-10  Pedro Alves  <palves@redhat.com>
11809
11810         * remote.c (first_remote_resumed_thread): New.
11811         (remote_target::wait_as): Use it as default event_ptid instead of
11812         inferior_ptid.
11813
11814 2020-01-10  Pedro Alves  <palves@redhat.com>
11815
11816         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
11817
11818 2020-01-10  Pedro Alves  <palves@redhat.com>
11819
11820         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
11821         not -1.
11822
11823 2020-01-10  Pedro Alves  <palves@redhat.com>
11824
11825         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
11826         ptid to get_last_target_status.
11827         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
11828         ptid to get_last_target_status.
11829         * infcmd.c (continue_command): Don't pass a target_waitstatus to
11830         get_last_target_status.
11831         (info_program_command): Don't pass a target_waitstatus to
11832         get_last_target_status.
11833         * infrun.c (init_wait_for_inferior): Use
11834         nullify_last_target_wait_ptid.
11835         (get_last_target_status): Handle nullptr arguments.
11836         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
11837         (print_stop_event): Don't pass a ptid to get_last_target_status.
11838         (normal_stop): Don't pass a ptid to get_last_target_status.
11839         * infrun.h (get_last_target_status, set_last_target_status): Move
11840         comments here and update.
11841         (nullify_last_target_wait_ptid): Declare.
11842         * linux-fork.c (fork_load_infrun_state): Remove local extern
11843         declaration of nullify_last_target_wait_ptid.
11844         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
11845         to get_last_target_status.
11846
11847 2020-01-10  Pedro Alves  <palves@redhat.com>
11848
11849         * gdbthread.h (scoped_restore_current_thread)
11850         <dont_restore, restore, m_dont_restore>: Declare.
11851         * thread.c (thread_alive): Add assertion.  Return bool.
11852         (switch_to_thread_if_alive): New.
11853         (prune_threads): Switch inferior/thread.
11854         (print_thread_info_1): Switch thread before calling target methods.
11855         (scoped_restore_current_thread::restore): New, factored out from
11856         ...
11857         (scoped_restore_current_thread::~scoped_restore_current_thread):
11858         ... this.
11859         (scoped_restore_current_thread::scoped_restore_current_thread):
11860         Add assertion.
11861         (thread_apply_all_command, thread_select): Use
11862         switch_to_thread_if_alive.
11863         * infrun.c (proceed, restart_threads, handle_signal_stop)
11864         (switch_back_to_stepped_thread): Switch current thread before
11865         calling target methods.
11866
11867 2020-01-10  Pedro Alves <palves@redhat.com>
11868
11869         * inferior.c (switch_to_inferior_no_thread): New function,
11870         factored out from ...
11871         (inferior_command): ... here.
11872         * inferior.h (switch_to_inferior_no_thread): Declare.
11873         * mi/mi-main.c (run_one_inferior): Use
11874         switch_to_inferior_no_thread.
11875
11876 2020-01-10  Pedro Alves  <palves@redhat.com>
11877
11878         * infcmd.c (kill_command): Remove dead code.
11879
11880 2020-01-10  Pedro Alves  <palves@redhat.com>
11881
11882         * remote.c (remote_target::mourn_inferior): No longer check
11883         whether the target is running.
11884
11885 2020-01-10  Pedro Alves  <palves@redhat.com>
11886
11887         * corelow.c (core_target::has_execution): Change parameter type to
11888         inferior pointer.
11889         * inferior.c (number_of_live_inferiors): Use
11890         inferior::has_execution instead of target_has_execution_1.
11891         * inferior.h (inferior::has_execution): New.
11892         * linux-thread-db.c (thread_db_target::update_thread_list): Use
11893         inferior::has_execution instead of target_has_execution_1.
11894         * process-stratum-target.c
11895         (process_stratum_target::has_execution): Change parameter type to
11896         inferior pointer.  Check the inferior's PID instead of
11897         inferior_ptid.
11898         * process-stratum-target.h
11899         (process_stratum_target::has_execution): Change parameter type to
11900         inferior pointer.
11901         * record-full.c (record_full_core_target::has_execution): Change
11902         parameter type to inferior pointer.
11903         * target.c (target_has_execution_1): Change parameter type to
11904         inferior pointer.
11905         (target_has_execution_current): Adjust.
11906         * target.h (target_ops::has_execution): Change parameter type to
11907         inferior pointer.
11908         (target_has_execution_1): Change parameter type to inferior
11909         pointer.  Change return type to bool.
11910         * tracefile.h (tracefile_target::has_execution): Change parameter
11911         type to inferior pointer.
11912
11913 2020-01-10  Pedro Alves  <palves@redhat.com>
11914
11915         * exceptions.c (print_flush): Remove current_top_target() check.
11916
11917 2020-01-10  Pedro Alves  <palves@redhat.com>
11918
11919         * remote.c (show_remote_exec_file): Show the current inferior's
11920         exec-file instead of the command variable's value.
11921
11922 2020-01-10  Pedro Alves  <palves@redhat.com>
11923
11924         * record-full.c (record_full_resume_ptid): New global.
11925         (record_full_target::resume): Set it.
11926         (record_full_wait_1): Use record_full_resume_ptid instead of
11927         inferior_ptid.
11928
11929 2020-01-10  Pedro Alves  <palves@redhat.com>
11930
11931         * gdbthread.h (scoped_restore_current_thread)
11932         <dont_restore, restore, m_dont_restore>: Declare.
11933         * thread.c (thread_alive): Add assertion.  Return bool.
11934         (switch_to_thread_if_alive): New.
11935         (prune_threads): Switch inferior/thread.
11936         (print_thread_info_1): Switch thread before calling target methods.
11937         (scoped_restore_current_thread::restore): New, factored out from
11938         ...
11939         (scoped_restore_current_thread::~scoped_restore_current_thread):
11940         ... this.
11941         (scoped_restore_current_thread::scoped_restore_current_thread):
11942         Add assertion.
11943         (thread_apply_all_command, thread_select): Use
11944         switch_to_thread_if_alive.
11945
11946 2020-01-10  George Barrett  <bob@bob131.so>
11947
11948         * stap-probe.c (stap_modify_semaphore): Don't check for null
11949         semaphores.
11950         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
11951         for null semaphores.
11952
11953 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11954
11955         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
11956         all source windows, and maintain horizontal scroll status while
11957         doing so.
11958
11959 2020-01-09  Tom Tromey  <tom@tromey.com>
11960
11961         PR tui/18932:
11962         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
11963         update_source_window, not print_source_lines.
11964
11965 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11966
11967         * tui/tui.c (tui_enable): Register tui hooks after calling
11968         tui_display_main.
11969
11970 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
11971
11972         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
11973
11974 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
11975
11976         * thread.c (print_thread_info_1): Fix indentation.
11977
11978 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
11979
11980         * symtab.c (general_symbol_info::compute_and_set_names): Move the
11981         unique_xmalloc_ptr outside the if to always free the demangled name.
11982
11983 2020-01-08  Tom Tromey  <tromey@adacore.com>
11984
11985         * xcoffread.c (enter_line_range, read_xcoff_symtab)
11986         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
11987         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
11988         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
11989         Remove.
11990         (section_offsets): New typedef.
11991         * symtab.c (fixup_section, get_msymbol_address): Update.
11992         * symmisc.c (dump_msymbols): Update.
11993         * symfile.h (relative_addr_info_to_section_offsets)
11994         (symfile_map_offsets_to_segments): Update.
11995         * symfile.c (build_section_addr_info_from_objfile)
11996         (init_objfile_sect_indices): Update.
11997         (struct place_section_arg): Change type of "offsets".
11998         (place_section): Update.
11999         (relative_addr_info_to_section_offsets): Change type of
12000         "section_offsets".  Remove "num_sections" parameter.
12001         (default_symfile_offsets, syms_from_objfile_1)
12002         (set_objfile_default_section_offset): Update.
12003         (reread_symbols): No need to preserve section offsets by hand.
12004         (symfile_map_offsets_to_segments): Change type of "offsets".
12005         * stap-probe.c (relocate_address): Update.
12006         * stabsread.h (process_one_symbol): Update.
12007         * solib-target.c (struct lm_info_target) <offsets>: Change type.
12008         (solib_target_relocate_section_addresses): Update.
12009         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
12010         Update.
12011         * solib-frv.c (frv_relocate_main_executable): Update.
12012         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
12013         * solib-aix.c (solib_aix_get_section_offsets): Change return
12014         type.
12015         (solib_aix_solib_create_inferior_hook): Update.
12016         * remote.c (remote_target::get_offsets): Update.
12017         * psymtab.c (find_pc_sect_psymtab): Update.
12018         * psympriv.h (struct partial_symbol) <address, text_low,
12019         text_high>: Update.
12020         * objfiles.h (obj_section_offset): Update.
12021         (struct objfile) <section_offsets>: Change type.
12022         <num_sections>: Remove.
12023         (objfile_relocate): Update.
12024         * objfiles.c (entry_point_address_query): Update
12025         (relocate_one_symbol): Change type of "section_offsets".
12026         (objfile_relocate1, objfile_relocate1): Change type of
12027         "new_offsets".
12028         (objfile_rebase1): Update.
12029         * mipsread.c (mipscoff_symfile_read): Update.
12030         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
12031         parameter.
12032         * mdebugread.c (parse_symbol): Change type of "section_offsets".
12033         (parse_external, psymtab_to_symtab_1): Update.
12034         * machoread.c (macho_symfile_offsets): Update.
12035         * ia64-tdep.c (ia64_find_unwind_table): Update.
12036         * hppa-tdep.c (read_unwind_info): Update.
12037         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
12038         * dwarf2read.c (create_addrmap_from_index)
12039         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12040         (process_psymtab_comp_unit_reader, add_partial_symbol)
12041         (add_partial_subprogram, process_full_comp_unit)
12042         (read_file_scope, read_func_scope, read_lexical_block_scope)
12043         (read_call_site_scope, dwarf2_rnglists_process)
12044         (dwarf2_ranges_process, dwarf2_ranges_read)
12045         (dwarf_decode_lines_1, var_decode_location, new_symbol)
12046         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
12047         Update.
12048         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
12049         Update.
12050         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
12051         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
12052         (process_one_symbol): Change type of "section_offsets".
12053         * ctfread.c (get_objfile_text_range): Update.
12054         * coffread.c (coff_symtab_read, enter_linenos)
12055         (process_coff_symbol): Update.
12056         * coff-pe-read.c (add_pe_forwarded_sym): Update.
12057         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
12058
12059 2020-01-08  Tom Tromey  <tromey@adacore.com>
12060
12061         * dwarf2read.c (parse_macro_definition): Use std::string.
12062         (parse_macro_definition): Likewise.
12063
12064 2020-01-08  Tom Tromey  <tromey@adacore.com>
12065
12066         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
12067         (ATTR_ALLOC_CHUNK): Remove.
12068
12069 2020-01-08  Tom Tromey  <tromey@adacore.com>
12070
12071         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
12072
12073 2020-01-08  Tom Tromey  <tromey@adacore.com>
12074
12075         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
12076         (dwarf2_compute_name, open_dwo_file): Likewise.
12077         (process_enumeration_scope): Use std::vector.
12078         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
12079         (partial_die_info::fixup, dwarf2_start_subfile)
12080         (guess_full_die_structure_name, dwarf2_name): Likewise.
12081         (determine_prefix): Update.
12082         (guess_full_die_structure_name): Make return type const.
12083         (partial_die_full_name): Return unique_xmalloc_ptr.
12084         (DW_FIELD_ALLOC_CHUNK): Remove.
12085
12086 2020-01-07  Tom Tromey  <tromey@adacore.com>
12087
12088         PR build/24937:
12089         * stap-probe.c (class stap_static_probe_ops): Add constructor.
12090
12091 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
12092
12093         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
12094
12095 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12096
12097         * stack.c (print_frame_info): Move disassemble_next_line code
12098         inside source_print block.
12099
12100 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12101
12102         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
12103         gdb/signals.h, as we are now using native signal symbols.
12104
12105 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
12106
12107         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
12108         overflow by an early check of content vs threshold.
12109         * tui/tui-source.c (tui_source_window::line_is_displayed):
12110         Likewise.
12111
12112 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12113
12114         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
12115
12116 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
12117
12118         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
12119         export table if no section contains it's RVA.
12120
12121 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12122
12123         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
12124
12125 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
12126
12127         * source.c (print_source_lines_base): Set last_line_listed.
12128
12129 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
12130
12131         * tui/tui-disasm.c: Remove trailing spaces.
12132
12133 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12134             Pedro Alves  <palves@redhat.com>
12135
12136         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
12137         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
12138         (windows_gdb_signal_to_target): New function, uses the above
12139         enumeration to convert GDB internal signal codes to equivalent
12140         Windows codes.
12141         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
12142         * windows-nat.c: Include "gdb_wait.h".
12143         (get_windows_debug_event): Extract the fatal exception from the
12144         exit status and convert to the equivalent Posix signal number.
12145         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
12146         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
12147         * gdbsupport/gdb_wait.c: New file, implements
12148         windows_status_to_termsig.
12149         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
12150         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
12151
12152 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
12153
12154         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
12155         show_layout.
12156
12157 2020-01-05  Luis Machado  <luis.machado@linaro.org>
12158
12159         * aarch64-linux-nat.c
12160         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
12161         and bfd_mach_aarch64.
12162
12163 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12164
12165         * ui-file.c (stdio_file::can_emit_style_escape)
12166         (tee_file::can_emit_style_escape): Ensure style is used also on
12167         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
12168         to gdb_stdout.
12169         * main.c (set_gdb_data_directory): Use file style to output the
12170         warning that the given pathname is not a directory.
12171         * top.c (show_history_filename, gdb_safe_append_history)
12172         (show_gdb_datadir): Use file style.
12173
12174 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
12175
12176         * solib-target.c (struct lm_info_target):
12177         Change offsets to be a unique_xmalloc_ptr.
12178         (solib_target_relocate_section_addresses): Update.
12179
12180 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
12181
12182         * windows-nat.c (windows_clear_solib): Free so_list linked list.
12183
12184 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
12185
12186         * MAINTAINERS (Write After Approval): Add myself.
12187
12188 2020-01-02  Luis Machado  <luis.machado@linaro.org>
12189
12190         * proc-service.c (get_ps_regcache): Remove reference to obsolete
12191         Cell BE architecture.
12192         * target.h (struct target_ops) <thread_architecture>: Likewise.
12193
12194 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
12195
12196         * Makefile.in: Use INSTALL_PROGRAM_ENV.
12197
12198 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
12199
12200         * MAINTAINERS (Write After Approval): Add myself.
12201
12202 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12203
12204         * gdbarch.sh: Update copyright year range of generated files.
12205
12206 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12207
12208         Update copyright year range in all GDB files.
12209
12210 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12211
12212         * copyright.py: Convert to Python 3.
12213
12214 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12215
12216         * copyright.py: Adapt after move of gnulib directory from gdb
12217         directory to toplevel directory.
12218
12219 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12220
12221         * copyright.py (main): Exit if run from the wrong directory.
12222
12223 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12224
12225         * top.c (print_gdb_version): Change copyright year to 2020.
12226
12227 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12228
12229         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
12230
12231 For older changes see ChangeLog-2019.
12232 \f
12233 Local Variables:
12234 mode: change-log
12235 left-margin: 8
12236 fill-column: 74
12237 version-control: never
12238 coding: utf-8
12239 End: