gdb/ChangeLog

   1 2019-01-21  Tom Tromey  <tom@tromey.com>
   2
   3         * ui-out.c: Fix includes.
   4         * tui/tui-source.c: Fix includes.
   5         * target.c: Fix includes.
   6         * remote.c: Fix includes.
   7         * regcache.c: Fix includes.
   8         * python/py-block.c: Fix includes.
   9         * printcmd.c: Fix includes.
  10         * or1k-tdep.c: Fix includes.
  11         * mi/mi-main.c: Fix includes.
  12         * m32r-tdep.c: Fix includes.
  13         * csky-tdep.c: Fix includes.
  14         * compile/compile-cplus-types.c: Fix includes.
  15         * cli/cli-interp.c: Fix includes.
  16
  17 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  18
  19         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  20         for padding.
  21
  22 2019-01-16  Tom Tromey  <tom@tromey.com>
  23
  24         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  25         earlier.
  26         (struct objfile) <msymbols_range>: Move from top level.
  27         <msymbols>: New method.
  28         (class objfile_msymbols): Remove.
  29         * symtab.c (default_collect_symbol_completion_matches_break_on):
  30         Update.
  31         * symmisc.c (dump_msymbols): Update.
  32         * stabsread.c (scan_file_globals): Update.
  33         * objc-lang.c (info_selectors_command, info_classes_command)
  34         (find_methods): Update.
  35         * minsyms.c (find_solib_trampoline_target): Update.
  36         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  37         * coffread.c (coff_symfile_read): Update.
  38         * ada-lang.c (ada_lookup_simple_minsym)
  39         (ada_collect_symbol_completion_matches): Update.
  40
  41 2019-01-16  Tom Tromey  <tom@tromey.com>
  42
  43         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  44         type.  Remove no-argument constructor.
  45         <iterator::operator++>: Simplify.
  46         <begin>: Update.
  47         <end>: Use minimal_symbol_count.
  48
  49 2019-01-16  Tom Tromey  <tom@tromey.com>
  50
  51         * objfiles.h (struct objfile) <psymtabs>: New method.
  52         (class objfile_psymtabs): Remove.
  53         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  54         typedef.
  55         <range>: New method.
  56         (require_partial_symbols): Change return type.
  57         * psymtab.c (require_partial_symbols)
  58         (psym_expand_symtabs_matching): Update.
  59         * mdebugread.c (parse_partial_symbols): Update.
  60         * dbxread.c (dbx_end_psymtab): Update.
  61
  62 2019-01-15  Tom Tromey  <tom@tromey.com>
  63
  64         * symtab.c (lookup_objfile_from_block)
  65         (lookup_symbol_in_objfile_symtabs)
  66         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  67         (find_line_symtab, info_sources_command)
  68         (default_collect_symbol_completion_matches_break_on)
  69         (make_source_files_completion_list): Update.
  70         * symmisc.c (print_objfile_statistics, dump_objfile)
  71         (maintenance_print_symbols, maintenance_info_symtabs)
  72         (maintenance_check_symtabs, maintenance_info_line_tables):
  73         Update.
  74         * source.c (select_source_symtab)
  75         (forget_cached_source_info_for_objfile): Update.
  76         * objfiles.h (class objfile_compunits): Remove.
  77         (struct objfile) <compunits_range>: New typedef.
  78         (compunits): New method.
  79         * objfiles.c (objfile_relocate1): Update.
  80         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  81         * maint.c (count_symtabs_and_blocks): Update.
  82         * linespec.c (iterate_over_all_matching_symtabs): Update.
  83         * cp-support.c (add_symbol_overload_list_qualified): Update.
  84         * coffread.c (coff_symtab_read): Update.
  85         * ada-lang.c (add_nonlocal_symbols)
  86         (ada_collect_symbol_completion_matches)
  87         (ada_add_global_exceptions): Update.
  88
  89 2019-01-15  Tom Tromey  <tom@tromey.com>
  90
  91         * progspace.h (program_space) <objfiles_safe_range>: New
  92         typedef.
  93         <objfiles_safe>: New method.
  94         * objfiles.h (class all_objfiles_safe): Remove.
  95         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
  96         * jit.c (jit_inferior_exit_hook): Update.
  97
  98 2019-01-17  Tom Tromey  <tom@tromey.com>
  99
 100         * progspace.h (program_space) <objfiles_range>: New typedef.
 101         <objfiles>: New method.
 102         <objfiles_head>: Rename from objfiles.
 103         (object_files): Update.
 104         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 105         * guile/scm-pretty-print.c
 106         (ppscm_find_pretty_printer_from_objfiles): Update.
 107         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 108         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 109         Update.
 110         * python/py-progspace.c (pspy_get_objfiles): Update.
 111         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 112         Update.
 113         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 114         (objfpy_lookup_objfile_by_build_id): Update.
 115         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 116         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 117         Update.
 118         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 119         (expand_symtab_containing_pc, lookup_objfile_from_block)
 120         (lookup_static_symbol, basic_lookup_transparent_type)
 121         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 122         (find_line_symtab, info_sources_command)
 123         (default_collect_symbol_completion_matches_break_on)
 124         (make_source_files_completion_list, find_main_name): Update.
 125         * symmisc.c (print_symbol_bcache_statistics)
 126         (print_objfile_statistics, maintenance_print_symbols)
 127         (maintenance_print_msymbols, maintenance_print_objfiles)
 128         (maintenance_info_symtabs, maintenance_check_symtabs)
 129         (maintenance_expand_symtabs, maintenance_info_line_tables):
 130         Update.
 131         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 132         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 133         (map_overlay_command, unmap_overlay_command)
 134         (simple_overlay_update, expand_symtabs_matching)
 135         (map_symbol_filenames): Update.
 136         * symfile-debug.c (set_debug_symfile): Update.
 137         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 138         Update.
 139         * source.c (select_source_symtab, forget_cached_source_info):
 140         Update.
 141         * solib.c (solib_read_symbols): Update.
 142         * solib-spu.c (append_ocl_sos): Update.
 143         * psymtab.c (maintenance_print_psymbols)
 144         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 145         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 146         * printcmd.c (info_symbol_command): Update.
 147         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 148         Update.
 149         * objfiles.h (class all_objfiles): Remove.
 150         * objfiles.c (have_partial_symbols, have_full_symbols)
 151         (have_minimal_symbols, qsort_cmp, update_section_map)
 152         (shared_objfile_contains_address_p)
 153         (default_iterate_over_objfiles_in_search_order): Update.
 154         * objc-lang.c (info_selectors_command, info_classes_command)
 155         (find_methods): Update.
 156         * minsyms.c (find_solib_trampoline_target): Update.
 157         * maint.c (maintenance_info_sections)
 158         (maintenance_translate_address, count_symtabs_and_blocks):
 159         Update.
 160         * main.c (captured_main_1): Update.
 161         * linux-thread-db.c (try_thread_db_load_from_pdir)
 162         (has_libpthread): Update.
 163         * linespec.c (iterate_over_all_matching_symtabs)
 164         (search_minsyms_for_name): Update.
 165         * jit.c (jit_find_objf_with_entry_addr): Update.
 166         * hppa-tdep.c (find_unwind_entry)
 167         (hppa_lookup_stub_minimal_symbol): Update.
 168         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 169         Update.
 170         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 171         (elf_gnu_ifunc_resolve_by_got): Update.
 172         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 173         * dwarf-index-write.c (save_gdb_index_command): Update.
 174         * cp-support.c (add_symbol_overload_list_qualified): Update.
 175         * breakpoint.c (create_overlay_event_breakpoint)
 176         (create_longjmp_master_breakpoint)
 177         (create_std_terminate_master_breakpoint)
 178         (create_exception_master_breakpoint): Update.
 179         * blockframe.c (find_pc_partial_function): Update.
 180         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 181         (ada_collect_symbol_completion_matches)
 182         (ada_add_global_exceptions): Update.
 183
 184 2019-01-17  Tom Tromey  <tom@tromey.com>
 185
 186         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 187         declare VEC.
 188         (solib_target_parse_libraries): Change return type.
 189         (library_list_start_segment, library_list_start_section)
 190         (library_list_end_library, library_list_start_library); Update.
 191         (solib_target_free_library_list): Remove.
 192         (solib_target_parse_libraries): Remove cleanup.  Change return
 193         type.
 194         (solib_target_current_sos): Update.
 195
 196 2019-01-17  Tom Tromey  <tromey@bapiya>
 197
 198         * valprint.c: Replace "the the" with "the".
 199         * symtab.c: Replace "the the" with "the".
 200         * solib.c: Replace "the the" with "the".
 201         * solib-dsbt.c: Replace "the the" with "the".
 202         * linespec.c: Replace "the the" with "the".
 203         * dwarf2loc.h: Replace "the the" with "the".
 204         * amd64-windows-tdep.c: Replace "the the" with "the".
 205         * aarch64-tdep.c: Replace "the the" with "the".
 206
 207 2019-01-16  Keith Seitz  <keiths@redhat.com>
 208
 209         PR gdb/23773
 210         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 211         <builder>: Rename to ..
 212         <m_builder>: ... this and make private.
 213         (dwarf2_cu::get_builder): New method.  Change all users of
 214         `builder' to use this method.
 215         (dwarf2_start_symtab): Move to ...
 216         (dwarf2_cu::start_symtab): ... here.  Update all callers
 217         (setup_type_unit_groups): Move to ...
 218         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 219         callers.
 220         (dwarf2_cu::reset_builder): New method.
 221         (process_full_compunit, process_full_type_unit): Use
 222         dwarf2_cu::reset_builder.
 223         (follow_die_offset): Record the ancestor CU if it is different
 224         from the followed DIE's CU.
 225         (follow_die_sig_1): Likewise.
 226
 227 2019-01-15  Tom Tromey  <tom@tromey.com>
 228
 229         * remote.c (class remote_state) <buf>: Now a char_vector.
 230         <buf_size>: Remove.
 231         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 232         parameter.
 233         (remote_target::getpkt_or_notif_sane_1)
 234         (remote_target::getpkt_sane)
 235         (remote_target::getpkt_or_notif_sane): Likewise.
 236         (class remote_target) <putpkt>: New overload.
 237         (remote_target::read_frame): Change type of "buf_p".  Remove
 238         sizeof_p parameter.
 239         (packet_ok): New overload.
 240         (packet_check_result): New overload.
 241         Update all uses.
 242
 243 2019-01-14  Tom Tromey  <tom@tromey.com>
 244
 245         * remote-notif.c (handle_notification, remote_notif_ack)
 246         (remote_notif_parse): Make "buf" const.
 247         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 248         const.
 249         (remote_notif_parse, remote_notif_ack, handle_notification):
 250         Likewise.
 251         * remote.c (remote_notif_stop_parse): Make "buf" const.
 252         (remote_target::remote_parse_stop_reply): Make "buf" const.
 253         (remote_notif_stop_ack): Make "buf" const.
 254
 255 2019-01-14  Tom Tromey  <tom@tromey.com>
 256
 257         * remote.c (remote_console_output): Make parameter const.
 258
 259 2019-01-14  Tom Tromey  <tom@tromey.com>
 260
 261         * target-debug.h (target_debug_print_signals): Constify.
 262         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 263         * procfs.c (procfs_target::pass_signals): Update.
 264         * linux-nat.c (linux_nat_target::pass_signals): Update.
 265         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 266         * target-delegates.c: Rebuild.
 267         * remote.c (remote_target::program_signals): Update.
 268         (remote_target::pass_signals): Update.
 269         * target.c (target_pass_signals): Constify argument.
 270         (target_program_signals): Likewise.
 271         * target.h (struct target_ops) <pass_signals, program_signals>:
 272         Constify argument.
 273         (target_pass_signals, target_program_signals): Constify argument.
 274
 275 2019-01-14  Tom Tromey  <tom@tromey.com>
 276
 277         PR tui/28819:
 278         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 279
 280 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 281
 282         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 283         field.
 284         * rs6000-tdep.c: Include reggroups.h.
 285         (IS_V_ALIAS_PSEUDOREG): Define.
 286         (rs6000_register_name): Return names for the "vX" aliases.
 287         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 288         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 289         aliases.  Call default_register_reggroup_p for all other
 290         pseudo-registers.
 291         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 292         New functions.
 293         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 294         Handle "vX" aliases.
 295         (v_alias_pseudo_register_collect): New function.
 296         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 297         (rs6000_gdbarch_init): Initialize "vX" aliases as
 298         pseudo-registers.  Restore registration of
 299         rs6000_pseudo_register_reggroup_p with
 300         set_tdesc_pseudo_register_reggroup_p.
 301
 302 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 303
 304         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 305         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 306         set_gdbarch_num_pseudo_regs.
 307
 308 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 309
 310         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 311         Remove arg prefixname, add do_set and do_show.
 312         Add member functions set_list and show_list.
 313         * cli/cli-style.c (class cli_style_option): Update accordingly.
 314         (style_set_list): Move to file scope.
 315         (style_show_list): Likewise.
 316         (set_style): Call help_list.
 317         (show_style): Call cmd_show_list.
 318         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 319         Update to use the new macro.
 320
 321 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 322
 323         * ada-lang.c (_initialize_ada_language): Expand the help text
 324         for the "catch exception" command.
 325
 326 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 327
 328         * symtab.c (matching_obj_sections): Initialize obj,
 329         declare it closer to its usage.
 330
 331 2019-01-10  Tom Tromey  <tom@tromey.com>
 332
 333         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 334         (basic_inf_threads_range): Remove.
 335         (inf_threads_range, inf_non_exited_threads_range)
 336         (safe_inf_threads_range): Use next_adapter.
 337
 338 2019-01-10  Keith Seitz  <keiths@redhat.com>
 339
 340         PR gdb/23712
 341         PR symtab/23010
 342         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 343         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 344
 345 2019-01-10  Keith Seitz  <keiths@redhat.com>
 346
 347         PR gdb/23712
 348         PR symtab/23010
 349         * dictionary.c (pending_to_vector): Remove.
 350         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 351         Remove _1 suffix, replacing functions of the same name.  Update
 352         all callers.
 353         (dict_create_hashed, dict_create_hashed_expandable)
 354         (dict_create_linear, dict_create_linear_expandable, dict_free)
 355         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 356         Make functions static.
 357
 358 2019-01-10  Keith Seitz  <keiths@redhat.com>
 359
 360         PR gdb/23712
 361         PR symtab/23010
 362         * dictionary.h (struct dictionary): Replace declaration with
 363         multidictionary.
 364         (dict_create_hashed, dict_create_hashed_expandable)
 365         (dict_create_linear, dict_create_linear_expandable)
 366         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 367         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 368         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 369         taking multidictionary argument.
 370         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 371         * block.h (struct block) <dict>: Change to multidictionary
 372         and rename `multidict'.
 373         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 374         symmisc.c: Update all dictionary references to multidictionary.
 375
 376 2019-01-10  Keith Seitz  <keiths@redhat.com>
 377
 378         PR gdb/23712
 379         PR symtab/23010
 380         * dictionary.c: Include unordered_map.
 381         (pending_to_vector): New function.
 382         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 383         Rewrite the non-"_1" functions to take vector instead
 384         of linked list.
 385         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 386         "new" _1 versions of the same name.
 387         (multidictionary): Define.
 388         (std::hash<enum language): New definition.
 389         (collate_pending_symbols_by_language, mdict_create_hashed)
 390         (mdict_create_hashed_expandable, mdict_create_linear)
 391         (mdict_create_linear_expandable, mdict_free)
 392         (find_language_dictionary, create_new_language_dictionary)
 393         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 394         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 395         (mdict_size, mdict_empty): New functions.
 396         * dictionary.h (mdict_iterator): Define.
 397
 398 2019-01-10  Pedro Alves  <palves@redhat.com>
 399
 400         * breakpoint.c (read_uploaded_action)
 401         (create_tracepoint_from_upload): Adjust to use
 402         gdb::unique_xmalloc_ptr.
 403         * ctf.c (ctf_write_uploaded_tp):
 404         (SET_ARRAY_FIELD): Use emplace_back.
 405         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 406         * tracefile-tfile.c (tfile_write_uploaded_tp):
 407         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 408         gdb::unique_xmalloc_ptr.
 409         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 410         at_string, cond_string, cmd_strings>: Replace char pointers
 411         with gdb::unique_xmalloc_ptr.
 412
 413 2019-01-10  Pedro Alves  <palves@redhat.com>
 414
 415         * solib-target.c (library_list_start_library): Don't xstrdup name.
 416
 417 2019-01-10  Pedro Alves  <palves@redhat.com>
 418
 419         * mdebugread.c (parse_partial_symbols): Use
 420         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 421
 422 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 423
 424         * linux-fork.c (scoped_switch_fork_info)
 425         <~scoped_switch_fork_info>: Fix incorrect variable name.
 426
 427 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * linux-fork.c (scoped_switch_fork_info)
 430         <scoped_switch_fork_info>: Make explicit.
 431         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 432
 433 2019-01-10  Tom Tromey  <tom@tromey.com>
 434
 435         * objfiles.h (objfile::reset_psymtabs): Update.
 436         * objfiles.c (objfile::objfile): Update.
 437         * psymtab.h (psymtab_storage::obstack): Update.
 438         (psymtab_storage::m_obstack): Use gdb::optional.
 439         (class psymtab_storage): Update comment.  Remove objfile
 440         parameter.
 441         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 442
 443 2019-01-10  Tom Tromey  <tom@tromey.com>
 444
 445         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 446         <free_psymtabs>: Now private.
 447         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 448         (allocate_psymtab): Use new method.
 449
 450 2019-01-10  Tom Tromey  <tom@tromey.com>
 451
 452         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 453         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 454         * mdebugread.c (parse_partial_symbols): Use
 455         allocate_dependencies.
 456         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 457         allocate_dependencies.
 458         (process_psymtab_comp_unit_reader)
 459         (build_type_psymtab_dependencies): Likewise.
 460         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 461
 462 2019-01-10  Tom Tromey  <tom@tromey.com>
 463
 464         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 465         PSYMBOL_SET_LANGUAGE.
 466         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 467
 468 2019-01-10  Tom Tromey  <tom@tromey.com>
 469
 470         * psymtab.h (psymtab_storage::obstack): New method.
 471         <m_obstack>: Rename from obstack; now private.
 472         * psymtab.c (psymtab_storage): Update.
 473         * dwarf2read.c (create_addrmap_from_index)
 474         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 475         Update.
 476
 477 2019-01-10  Tom Tromey  <tom@tromey.com>
 478
 479         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 480         * objfiles.h (objfile::reset_psymtabs): New method.
 481
 482 2019-01-10  Tom Tromey  <tom@tromey.com>
 483
 484         * symmisc.c (print_symbol_bcache_statistics): Update.
 485         (print_objfile_statistics): Update.
 486         * symfile.c (reread_symbols): Update.
 487         * psymtab.h (class psymtab_storage): New.
 488         * psymtab.c (psymtab_storage): New constructor.
 489         (~psymtab_storage): New destructor.
 490         (require_partial_symbols): Update.
 491         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 492         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 493         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 494         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 495         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 496         (start_psymtab_common, end_psymtab_common)
 497         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 498         (allocate_psymtab): Update.
 499         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 500         Update.
 501         (dump_psymtab_addrmap, maintenance_print_psymbols)
 502         (maintenance_check_psymtabs): Update.
 503         (class objfile_psymtabs): Move to objfiles.h.
 504         * psympriv.h (discard_psymtab): Now inline.
 505         (psymtab_discarder::psymtab_discarder): Update.
 506         (psymtab_discarder::~psymtab_discarder): Update.
 507         (ALL_OBJFILE_PSYMTABS): Rewrite.
 508         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 509         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 510         Remove fields.
 511         <partial_symtabs>: New field.
 512         (class objfile_psymtabs): Move from psymtab.h.  Update.
 513         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 514         psymbol_cache.
 515         (objfile::~objfile): Don't destroy psymbol_cache.
 516         * mdebugread.c (parse_partial_symbols): Update.
 517         * dwarf2read.c (create_addrmap_from_index)
 518         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 519         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 520         (add_partial_subprogram, dwarf2_ranges_read): Update.
 521         * dwarf-index-write.c (write_address_map)
 522         (write_one_signatured_type, recursively_write_psymbols)
 523         (class debug_names, class debug_names, write_psymtabs_to_index):
 524         Update.
 525
 526 2019-01-10  Tom Tromey  <tom@tromey.com>
 527
 528         * symtab.h (SYMBOL_SET_NAMES): Update.
 529         (symbol_set_names): Update.
 530         (MSYMBOL_SET_NAMES): Update.
 531         * symtab.c (symbol_set_names): Change argument to be an
 532         objfile_per_bfd_storage.
 533         * psymtab.c (add_psymbol_to_bcache): Update.
 534         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 535
 536 2019-01-10  Tom Tromey  <tom@tromey.com>
 537
 538         * symtab.c (create_demangled_names_hash): Change argument to be an
 539         objfile_per_bfd_storage.
 540         (symbol_set_names): Update.
 541
 542 2019-01-10  Tom Tromey  <tom@tromey.com>
 543
 544         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 545         init_psymbol_list.
 546         * psymtab.c (init_psymbol_list): Do nothing if already called.
 547         * psympriv.h (init_psymbol_list): Add comment.
 548         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 549         init_psymbol_list.
 550         * dbxread.c (dbx_symfile_read): Unconditionally call
 551         init_psymbol_list.
 552
 553 2019-01-10  Tom Tromey  <tom@tromey.com>
 554
 555         * xcoffread.c (scan_xcoff_symtab): Update.
 556         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 557         "where".
 558         * mdebugread.c (parse_partial_symbols)
 559         (handle_psymbol_enumerators): Update.
 560         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 561         * dbxread.c (read_dbx_symtab): Update.
 562         * psympriv.h (psymbol_placement): New enum.
 563         (add_psymbol_to_list): Update.
 564
 565 2019-01-10  Tom Tromey  <tom@tromey.com>
 566
 567         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 568         static_psymbols parameters.
 569         (scan_xcoff_symtab): Update.
 570         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 571         static_psymbols parameters.
 572         * psympriv.h (start_psymtab_common): Update.
 573         * mdebugread.c (parse_partial_symbols): Update.
 574         * dwarf2read.c (create_partial_symtab): Update.
 575         * dbxread.c (read_dbx_symtab): Update.
 576         (start_psymtab): Remove global_psymbols and static_psymbols
 577         parameters.
 578
 579 2019-01-10  Tom Tromey  <tom@tromey.com>
 580
 581         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 582         * psymtab.c (allocate_psymtab): Add comment.
 583         * psympriv.h (allocate_psymtab): Add comment.
 584         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 585         initializations.
 586         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 587
 588 2019-01-10  Tom Tromey  <tom@tromey.com>
 589
 590         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 591         Don't declare.
 592         * mipsread.c: Include mdebugread.h.
 593         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 594         Declare.
 595         * elfread.c: Include mdebugread.h.
 596
 597 2019-01-09  Tom Tromey  <tom@tromey.com>
 598
 599         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 600         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 601         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 602         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 603         (psym_lookup_symbol, psym_find_last_source_symtab)
 604         (psym_forget_cached_source_info, psym_print_stats)
 605         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 606         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 607         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 608         (psym_find_compunit_symtab_by_address)
 609         (maintenance_print_psymbols, maintenance_info_psymtabs)
 610         (maintenance_check_psymtabs): Use ranged for.
 611         * psymtab.h (class objfile_psymtabs): New.
 612         (require_partial_symbols): Return objfile_psymtabs.
 613         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 614
 615 2019-01-09  Tom Tromey  <tom@tromey.com>
 616
 617         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 618         (find_pc_mapped_section, list_overlays_command)
 619         (map_overlay_command, unmap_overlay_command)
 620         (simple_overlay_update): Use all_objfiles.
 621         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 622         * printcmd.c (info_symbol_command): Use all_objfiles.
 623         * objfiles.h (ALL_OBJSECTIONS): Remove.
 624         * maint.c (maintenance_translate_address): Use all_objfiles.
 625         * gcore.c (gcore_create_callback): Use all_objfiles.
 626         (objfile_find_memory_regions): Likewise.
 627
 628 2019-01-09  Tom Tromey  <tom@tromey.com>
 629
 630         * symtab.c (find_line_symtab, info_sources_command)
 631         (make_source_files_completion_list): Use objfile_compunits.
 632         * source.c (select_source_symtab): Use objfile_compunits.
 633         * objfiles.h (struct objfile): Update comment.
 634         (ALL_OBJFILES): Remove.
 635         (ALL_FILETABS): Remove.
 636         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 637         objfile_compunits.
 638
 639 2019-01-09  Tom Tromey  <tom@tromey.com>
 640
 641         * symmisc.c (print_objfile_statistics, dump_objfile)
 642         (maintenance_print_symbols): Use compunit_filetabs.
 643         * source.c (forget_cached_source_info_for_objfile): Use
 644         compunit_filetabs.
 645         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 646         (ALL_FILETABS): Use compunit_filetabs.
 647         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 648         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 649
 650 2019-01-09  Tom Tromey  <tom@tromey.com>
 651
 652         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 653         (compunit_filetabs): New.
 654         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 655         compunit_filetabs.
 656         (info_sources_command, make_source_files_completion_list): Remove
 657         declaration.
 658         * symmisc.c (print_objfile_statistics, dump_objfile)
 659         (maintenance_print_symbols): Remove declaration.
 660         (maintenance_info_symtabs): Use compunit_filetabs.
 661         (maintenance_info_line_tables): Likewise.
 662         * source.c (select_source_symtab): Change local variable name.
 663         (forget_cached_source_info_for_objfile): Remove declaration.
 664         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 665         * objfiles.c (objfile_relocate1): Remove declaration.
 666         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 667         declaration.
 668         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 669         * coffread.c (coff_symtab_read): Remove declaration.
 670         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 671         compunit_filetabs.
 672
 673 2019-01-09  Tom Tromey  <tom@tromey.com>
 674
 675         * symtab.c (lookup_objfile_from_block)
 676         (find_pc_sect_compunit_symtab, search_symbols)
 677         (default_collect_symbol_completion_matches_break_on): Use
 678         objfile_compunits.
 679         * objfiles.h (ALL_COMPUNITS): Remove.
 680         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 681         * cp-support.c (add_symbol_overload_list_qualified): Use
 682         objfile_compunits.
 683         * ada-lang.c (ada_collect_symbol_completion_matches)
 684         (ada_add_global_exceptions): Use objfile_compunits.
 685
 686 2019-01-09  Tom Tromey  <tom@tromey.com>
 687
 688         * source.c (select_source_symtab)
 689         (forget_cached_source_info_for_objfile): Remove declaration.
 690         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 691         declaration.
 692         * maint.c (count_symtabs_and_blocks): Remove declaration.
 693         * cp-support.c (add_symbol_overload_list_qualified): Remove
 694         declaration.
 695         * coffread.c (coff_symtab_read): Remove declaration.
 696         * symtab.c (lookup_symbol_in_objfile_symtabs)
 697         (basic_lookup_transparent_type_1): Use objfile_compunits.
 698         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 699         (info_sources_command, search_symbols)
 700         (default_collect_symbol_completion_matches_break_on)
 701         (make_source_files_completion_list): Remove declaration.
 702         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 703         (ada_collect_symbol_completion_matches)
 704         (ada_add_global_exceptions): Remove declaration.
 705         * linespec.c (iterate_over_all_matching_symtabs): Use
 706         objfile_compunits.
 707         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 708         (class objfile_compunits): New.
 709         (ALL_COMPUNITS): Use objfile_compunits.
 710         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 711         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 712         objfile_compunits.
 713         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 714
 715 2019-01-09  Tom Tromey  <tom@tromey.com>
 716
 717         * symtab.c (search_symbols)
 718         (default_collect_symbol_completion_matches_break_on): Use
 719         objfile_msymbols.
 720         * ada-lang.c (ada_lookup_simple_minsym)
 721         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 722         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 723         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 724         objfile_msymbols.
 725         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 726         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 727         * objc-lang.c (find_methods): Use objfile_msymbols.
 728         (info_selectors_command, info_classes_command): Likewise.
 729         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 730         * objfiles.h (class objfile_msymbols): New.
 731         (ALL_OBJFILE_MSYMBOLS): Remove.
 732         (ALL_MSYMBOLS): Remove.
 733
 734 2019-01-09  Tom Tromey  <tom@tromey.com>
 735
 736         * common/next-iterator.h (next_adapter): Add Iterator template
 737         parameter.
 738         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 739         (class all_objfiles_safe): New.
 740         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 741         * objfiles.c (put_objfile_before): Update comment.
 742         (add_separate_debug_objfile): Likewise.
 743         (free_all_objfiles): Use all_objfiles_safe.
 744         (objfile_purge_solibs): Likewise.
 745
 746 2019-01-09  Tom Tromey  <tom@tromey.com>
 747
 748         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 749         (expand_symtab_containing_pc, lookup_static_symbol)
 750         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 751         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 752         all_objfiles.
 753         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 754         * breakpoint.c (create_overlay_event_breakpoint)
 755         (create_longjmp_master_breakpoint)
 756         (create_std_terminate_master_breakpoint)
 757         (create_exception_master_breakpoint): Use all_objfiles.
 758         * linux-thread-db.c (try_thread_db_load_from_pdir)
 759         (has_libpthread): Use all_objfiles.
 760         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 761         * linespec.c (iterate_over_all_matching_symtabs)
 762         (search_minsyms_for_name): Use all_objfiles.
 763         * maint.c (maintenance_info_sections): Use all_objfiles.
 764         * main.c (captured_main_1): Use all_objfiles.
 765         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 766         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 767         * guile/scm-pretty-print.c
 768         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 769         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 770         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 771         (maintenance_print_msymbols): Use all_objfiles.
 772         * source.c (select_source_symtab): Use all_objfiles.
 773         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 774         * symfile.c (remove_symbol_file_command)
 775         (expand_symtabs_matching, map_symbol_filenames): Use
 776         all_objfiles.
 777         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 778         all_objfiles.
 779         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 780         * objc-lang.c (find_methods): Use all_objfiles.
 781         * objfiles.c (have_partial_symbols, have_full_symbols)
 782         (have_minimal_symbols, qsort_cmp)
 783         (default_iterate_over_objfiles_in_search_order): Use
 784         all_objfiles.
 785         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 786         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 787         (maintenance_check_psymtabs): Use all_objfiles.
 788         (ALL_PSYMTABS): Remove.
 789         * compile/compile-object-run.c (do_module_cleanup): Use
 790         all_objfiles.
 791         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 792         * cp-support.c (add_symbol_overload_list_qualified): Use
 793         all_objfiles.
 794         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 795         Use all_objfiles.
 796         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 797         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 798         all_objfiles.
 799         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 800         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 801         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 802         Uses all_objfiles.
 803         * solib.c (solib_read_symbols): Use all_objfiles
 804
 805 2019-01-09  Tom Tromey  <tom@tromey.com>
 806
 807         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 808         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 809         all_objfiles.
 810         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 811         * symmisc.c (print_symbol_bcache_statistics)
 812         (print_objfile_statistics, maintenance_print_objfiles)
 813         (maintenance_info_symtabs, maintenance_check_symtabs)
 814         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 815         all_objfiles.
 816         * source.c (forget_cached_source_info): Use all_objfiles.
 817         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 818         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 819         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 820         * objfiles.c (update_section_map): Use all_objfiles.
 821         (shared_objfile_contains_address_p): Likewise.
 822         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 823         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 824
 825 2019-01-09  Tom Tromey  <tom@tromey.com>
 826
 827         * common/next-iterator.h: New file.
 828         * objfiles.h (class all_objfiles): New.
 829         (struct objfile_iterator): New.
 830
 831 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 832
 833         * NEWS: Move the description of the changed "frame", "select-frame",
 834          and "info frame" commands to the Changed commands section.
 835
 836 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 837
 838         * gdbtypes.c (check_stub_method_group): Remove handling of old
 839         mangling schemes.
 840         * linespec.c (find_methods): Likewise.
 841         * stabsread.c (read_member_functions): Likewise.
 842         * valops.c (search_struct_method): Likewise.
 843         (value_struct_elt_for_reference): Likewise.
 844         * NEWS: Mention this change.
 845
 846 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 849         print_source_lines.
 850         * source.c (print_source_lines_base): Update line number check.
 851         (print_source_lines): New function.
 852         (source_lines_range::source_lines_range): New function.
 853         * source.h (class source_lines_range): New class.
 854         (print_source_lines): New declaration.
 855
 856 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 857
 858         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 859
 860 2019-01-08  Tom Tromey  <tom@tromey.com>
 861             Simon Marchi  <simon.marchi@ericsson.com>
 862
 863         PR gdb/24060
 864         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 865         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 866         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 867         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 868         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 869         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 870
 871 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 872
 873         * source.c (select_source_symtab): Move header comment to
 874         declaration in source.h.
 875         (forget_cached_source_info_for_objfile): Likewise.
 876         (forget_cached_source_info): Likewise.
 877         (identify_source_line): Likewise.
 878         * source.h (identify_source_line): Move declaration from symtab.h
 879         and add comment from source.c
 880         (print_source_lines): Likewise.
 881         (forget_cached_source_info_for_objfile): Likewise.
 882         (forget_cached_source_info): Likewise.
 883         (select_source_symtab): Likewise.
 884         (enum print_source_lines_flag): Move definition from symtab.h.
 885         * symtab.h (identify_source_line): Move declaration to source.h.
 886         (print_source_lines): Likewise.
 887         (forget_cached_source_info_for_objfile): Likewise.
 888         (forget_cached_source_info): Likewise.
 889         (select_source_symtab): Likewise.
 890         (enum print_source_lines_flag): Move definition to source.h.
 891         * tui/tui-hooks.c: Add 'source.h' include.
 892
 893 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * source.c (print_source_lines_base): Handle requests to print
 896         reverse line number sequences, and guard against empty lines
 897         string.
 898
 899 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * source.c (print_source_lines_base): Fix skip of '\r' if next
 902         character is '\n'.
 903
 904 2019-01-06  Tom Tromey  <tom@tromey.com>
 905
 906         * c-exp.y (struct c_parse_state) <macro_original_text,
 907         expansion_obstack>: New member.
 908         (macro_original_text, expansion_obstack): Remove globals.
 909         (scan_macro_expansion, scanning_macro_expansion)
 910         (finished_macro_expansion): Update.
 911         (scan_macro_cleanup): Remove.
 912         (yylex, c_parse): Update.
 913
 914 2019-01-06  Tom Tromey  <tom@tromey.com>
 915
 916         * c-exp.y (struct c_parse_state) <strings>: New member.
 917         (operator_stoken): Update.
 918
 919 2019-01-06  Tom Tromey  <tom@tromey.com>
 920
 921         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 922         (union type_stack_elt) <typelist_val>: Now a pointer to
 923         std::vector.
 924         (type_stack_cleanup): Don't declare.
 925         (push_typelist): Update.
 926         * parse.c (pop_typelist): Return a std::vector.
 927         (push_typelist): Take a std::vector.
 928         (follow_types): Update.  Do not free args.
 929         (type_stack_cleanup): Remove.
 930         * c-exp.y (struct c_parse_state): New.
 931         (cpstate): New global.
 932         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 933         (nonempty_typelist): Update.
 934         (func_mod): Create a new vector.
 935         (c_parse): Create a c_parse_state.
 936         (check_parameter_typelist): Do not delete params.
 937         (function_method): Update.  Do not delete type_list.
 938
 939 2019-01-06  Tom Tromey  <tom@tromey.com>
 940
 941         PR gdb/28155:
 942         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 943         check_typedef.
 944         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 945         (print_return_value): Likewise.
 946
 947 2019-01-05  Tom Tromey  <tom@tromey.com>
 948
 949         * contrib/cleanup_check.py: Remove.
 950         * contrib/gcc-with-excheck: Remove.
 951         * contrib/exsummary.py: Remove.
 952         * contrib/excheck.py: Remove.
 953
 954 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 955
 956         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 957         NULL. Initialize tpprev to NULL instead of assigning it
 958         to NULL on the next statement.
 959         * windows-nat.c (windows_delete_thread): Remove check for
 960         main_thread_id before printing thread exit notifications.
 961         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 962         Remove thread ID check against main_thread_id.
 963         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 964         windows_delete_thread.
 965         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 966
 967 2019-01-04  Tom Tromey  <tom@tromey.com>
 968
 969         * compile/compile.c (_initialize_compile): Use upper case for
 970         metasyntactic variables.
 971         * symmisc.c (_initialize_symmisc): Use upper case for
 972         metasyntactic variables.
 973         * psymtab.c (_initialize_psymtab): Use upper case for
 974         metasyntactic variables.
 975         * demangle.c (demangle_command): Use upper case for metasyntactic
 976         variables.
 977         (_initialize_demangler): Likewise.
 978         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 979         variables.
 980
 981 2019-01-03  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 984
 985 2019-01-03  Tom Tromey  <tom@tromey.com>
 986
 987         * python/py-symtab.c (salpy_str): Update.
 988         (struct salpy_sal_object) <symtab>: Now a PyObject.
 989         (salpy_dealloc): Update.
 990         (del_objfile_sal): Use gdbpy_ref.
 991
 992 2019-01-03  Tom Tromey  <tom@tromey.com>
 993
 994         * python/py-type.c (convert_field): Use new_reference.  Return
 995         gdbpy_ref.
 996         (make_fielditem): Return gdbpy_ref.
 997         (typy_fields): Update.
 998         (typy_getitem): Update.
 999         (field_name): Return gdbpy_ref.  Use new_reference.
1000         (typy_iterator_iternext): Update.
1001
1002 2019-01-03  Tom Tromey  <tom@tromey.com>
1003
1004         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1005
1006 2019-01-03  Tom Tromey  <tom@tromey.com>
1007
1008         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1009         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1010         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1011         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1012         (pspy_set_type_printers): Likewise.
1013         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1014         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1015         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1016         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1017         (objfpy_set_type_printers): Likewise.
1018
1019 2019-01-03  Tom Tromey  <tom@tromey.com>
1020
1021         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1022         (gdbpy_print_stack): Use gdbpy_err_fetch.
1023         * python/python-internal.h (class gdbpy_err_fetch): New class.
1024         (class gdbpy_enter) <m_error_type, m_error_value,
1025         m_error_traceback>: Remove.
1026         <m_error>: New member.
1027         (gdbpy_exception_to_string): Don't declare.
1028         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1029         * python/py-value.c (convert_value_from_python): Use
1030         gdbpy_err_fetch.
1031         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1032         gdbpy_exception_to_string.
1033         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1034         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1035         gdbpy_err_fetch.
1036
1037 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * linux-nat.c (delete_lwp_cleanup): Delete.
1040         (struct lwp_deleter): New struct.
1041         (lwp_info_up): New typedef.
1042         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1043         lwp_info_up.
1044
1045 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1046
1047         * linux-fork.c (class scoped_switch_fork_info): New class.
1048         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1049
1050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * valops.c (find_overload_match): Remove use of null_cleanup, and
1053         calls to do_cleanups.
1054
1055 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * compile/compile-cplus-types.c
1058         (compile_cplus_instance::decl_name): Handle changes to
1059         cp_func_name.
1060         * cp-support.c (cp_func_name): Update header comment, update
1061         return type.
1062         * cp-support.h (cp_func_name): Update return type in declaration.
1063         * valops.c (find_overload_match): Move temp_func local to top
1064         level of function and change its type.  Use temp_func to hold and
1065         delete temporary string obtained from cp_func_name.
1066
1067 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1070         gdb::char_vector, remove cleanup, and update uses of `msg`.
1071
1072 2019-01-03  Jim Wilson  <jimw@sifive.com>
1073
1074         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1075
1076 2019-01-02  Tom Tromey  <tom@tromey.com>
1077
1078         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1079         (tdesc_parse_xml): Remove cleanups.
1080         * target-descriptions.h (make_cleanup_free_target_description):
1081         Don't declare.
1082         (target_desc_deleter): New struct.
1083         (target_desc_up): New typedef.
1084         * target-descriptions.c (target_desc_deleter::operator()): Rename
1085         from free_target_description.
1086         (make_cleanup_free_target_description): Remove.
1087
1088 2019-01-02  Tom Tromey  <tom@tromey.com>
1089
1090         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1091         constructor, destructor.
1092         (linespec_parser): Remove typedef.
1093         (~linespec_parser): Rename from linespec_parser_delete.
1094         (linespec_lex_to_end, linespec_complete_label)
1095         (linespec_complete): Update.
1096         (decode_line_full): Remove cleanups.
1097         (decode_line_1): Update.
1098
1099 2019-01-02  Tom Tromey  <tom@tromey.com>
1100
1101         * python/python-internal.h (inferior_to_inferior_object): Change
1102         return type.
1103         * python/py-exitedevent.c (create_exited_event_object): Update.
1104         * python/py-inferior.c (inferior_to_inferior_object): Return
1105         gdbpy_ref.
1106         (python_new_inferior, python_inferior_deleted)
1107         (thread_to_thread_object, delete_thread_object)
1108         (build_inferior_list, gdbpy_selected_inferior): Update.
1109         * python/py-infthread.c (create_thread_object): Update.  Also fail
1110         if inferior_to_inferior_object fails.
1111
1112 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1113
1114         * inferior.h (class inferior) <displaced_step_state>: New field.
1115         * infrun.h (struct displaced_step_state): Move here from
1116         infrun.c.  Initialize fields, add constructor.
1117         <inf>: Remove field.
1118         <reset>: New method.
1119         * infrun.c (struct displaced_step_inferior_state): Move to
1120         infrun.h.
1121         (displaced_step_inferior_states): Remove.
1122         (get_displaced_stepping_state): Adust.
1123         (displaced_step_in_progress_any_inferior): Adjust.
1124         (displaced_step_in_progress_thread): Adjust.
1125         (displaced_step_in_progress): Adjust.
1126         (add_displaced_stepping_state): Remove.
1127         (get_displaced_step_closure_by_addr): Adjust.
1128         (remove_displaced_stepping_state): Remove.
1129         (infrun_inferior_exit): Call displaced_step_state.reset.
1130         (use_displaced_stepping): Don't check for NULL.
1131         (displaced_step_prepare_throw): Call
1132         get_displaced_stepping_state.
1133         (displaced_step_fixup): Don't check for NULL.
1134         (prepare_for_detach): Don't check for NULL.
1135
1136 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1137
1138         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1139          in case of call that did not complete.
1140
1141 2019-01-02  Andrey Utkin  <autkin@undo.io>
1142
1143         * symfile.c (find_separate_debug_file): Fix search of debug files for
1144         remote debuggee.
1145
1146 2019-01-02  Tom Tromey  <tom@tromey.com>
1147
1148         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1149         indentation.
1150         * python/py-frame.c (frapy_older): Remove cast.
1151         (frapy_newer): Likewise.
1152         * python/py-breakpoint.c (local_setattro): Remove cast.
1153         * python/py-arch.c (archpy_name): Remove local variable.
1154         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1155
1156 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1157
1158         * unittests/basic_string_view/element_access/char/empty.cc:
1159         Fix year range in copyright header.
1160
1161 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1164         Delete.
1165         <operator==>: Update with for removed field.
1166         <hash>: Likewise.
1167         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1168         <isa_features>: ...this.
1169         <abi_features>: New field.
1170         (riscv_isa_flen): Update comment.
1171         (riscv_abi_xlen): New declaration.
1172         (riscv_abi_flen): New declaration.
1173         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1174         isa_features.
1175         (riscv_abi_xlen): New function.
1176         (riscv_isa_flen): Update to get answer from isa_features.
1177         (riscv_abi_flen): New function.
1178         (riscv_has_fp_abi): Update to get answer from abi_features.
1179         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1180         xlen and flen.
1181         (riscv_call_info) <xlen, flen>: Update comment.
1182         (riscv_call_arg_struct): Remove invalid assertions
1183         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1184         is removed.
1185         (riscv_gdbarch_init): Gather isa features and abi features
1186         separately, ensure both match on the gdbarch when reusing an old
1187         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1188         a target with 64-bit float hardware.
1189
1190 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1191
1192         * source.c (search_command_helper): Stop reverse search
1193         when line 1 has been searched.
1194
1195 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1196
1197         * record-full.c (record_full_base_target::close): Rewrite
1198         record_full_core_buf_list free logic.
1199
1200 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1201
1202         * break-catch-syscall.c (print_one_catch_syscall): xfree
1203         the last text.
1204
1205 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1206
1207         * top.c (print_gdb_version): Update Copyright year in version
1208         message.
1209
1210 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1211
1212         Update copyright year range in all GDB files.
1213
1214 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1215
1216         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1217
1218 For older changes see ChangeLog-2018.
1219 \f
1220 Local Variables:
1221 mode: change-log
1222 left-margin: 8
1223 fill-column: 74
1224 version-control: never
1225 coding: utf-8
1226 End:
1227