gdb/ChangeLog

   1 2019-06-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
   4         (tui_free_window, free_content, free_content_elements): Remove
   5         unnecessary cast.
   6         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
   7         cast.
   8         * tui/tui-regs.c (tui_show_register_group)
   9         (tui_display_registers_from, tui_display_reg_element_at_line):
  10         Remove unnecessary cast.
  11
  12 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  13
  14         * linux-nat.c (normal_mask): Delete.
  15         (_initialize_linux_nat): Don't initialise normal_mask.
  16
  17 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  18
  19         PR gdb/24445
  20         * dwarf-index-write.h (write_psymtabs_to_index): Add
  21         dwz_basename parameter.
  22         * dwarf-index-write.c (write_gdbindex): Move file writing to
  23         write_gdbindex_1.  Change return type void.
  24         (assert_file_size): Move up, remove filename parameter.
  25         (write_gdbindex_1): New function.
  26         (write_debug_names): Change return type to void, call
  27         assert_file_size.
  28         (struct index_wip_file): New struct.
  29         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  30         file logic to index_wip_file.  Write index for dwz file if
  31         needed.
  32         (save_gdb_index_command): Pass basename of dwz file, if present.
  33         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  34         build-id of dwz file, if present.
  35         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  36         (dwarf2_get_dwz_file): Likewise.
  37         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  38         (dwarf2_get_dwz_file): Likewise.
  39
  40 2019-06-16  Tom Tromey  <tom@tromey.com>
  41
  42         * coffread.c (process_coff_symbol): Use xstrdup.
  43         * value.c (create_internalvar): Use xstrdup.
  44
  45 2019-06-16  Tom Tromey  <tom@tromey.com>
  46
  47         * valops.c (value_cast, value_slice): Remove unnecessary cast.
  48         * breakpoint.c (stopin_command, stopat_command)
  49         (until_break_command, decode_location_default): Remove unnecessary
  50         cast.
  51         * utils.c (subset_compare): Remove unnecessary cast.
  52         * ada-lang.c (ada_update_initial_language): Remove unnecessary
  53         cast.
  54         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
  55         cast.
  56         * infcmd.c (path_command): Remove unnecessary cast.
  57         * coffread.c (decode_type): Remove unnecessary cast.
  58         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
  59         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
  60         * tui/tui-stack.c (tui_show_locator_content)
  61         (tui_show_frame_info): Remove unnecessary cast.
  62         * tui/tui-win.c (tui_scroll_forward_command)
  63         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
  64         (parse_scrolling_args): Remove unnecessary cast.
  65         * tui/tui-data.c (init_win_info, tui_del_window)
  66         (tui_free_window, tui_del_data_windows, tui_free_data_content)
  67         (free_content_elements): Remove unnecessary cast.
  68         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
  69         unnecessary cast.
  70         * tui/tui-source.c (tui_set_source_content)
  71         (tui_vertical_source_scroll): Remove unnecessary cast.
  72         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
  73         cast.
  74         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
  75         * tui/tui-regs.c (tui_display_registers_from)
  76         (tui_display_register): Remove unnecessary cast.
  77         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
  78         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
  79         (make_visible): Remove unnecessary cast.
  80         * tui/tui-winsource.c (tui_erase_source_content)
  81         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
  82         unnecessary cast.
  83         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
  84         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
  85         * stabsread.c (read_type, read_array_type, read_range_type):
  86         Remove unnecessary cast.
  87         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
  88         (parse_symbol, parse_type, upgrade_type, parse_external)
  89         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
  90         unnecessary cast.
  91         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
  92
  93 2019-06-16  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-data.c (tui_alloc_generic_win_info)
  96         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
  97         checks.
  98
  99 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 100             Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         * f-typeprint.c (f_print_type): Don't return early for not
 103         associated or not allocated types.
 104         (f_type_print_varspec_suffix): Add print_rank parameter and print
 105         ranks of array types in case they dangling.
 106         (f_type_print_base): Add print_rank parameter.
 107
 108 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 109
 110         * NEWS: Mention new MI commands.
 111         * break-catch-throw.c (enum exception_event_kind): Move to
 112         breakpoint.h.
 113         (print_mention_exception_catchpoint): Output text as a single
 114         message.
 115         (catch_exception_command_1): Rename to...
 116         (catch_exception_event): ...this, make non-static, update header
 117         command, and change some parameter types.
 118         (catch_catch_command): Update for changes to
 119         catch_exception_command_1.
 120         (catch_throw_command): Likewise.
 121         (catch_rethrow_command): Likewise.
 122         * breakpoint.c (enum exception_event_kind): Delete.
 123         * breakpoint.h (enum exception_event_kind): Moved here from
 124         break-catch-throw.c.
 125         (catch_exception_event): Declare.
 126         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 127         (mi_cmd_catch_throw): New function.
 128         (mi_cmd_catch_rethrow): New function.
 129         (mi_cmd_catch_catch): New function.
 130         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 131         'catch-catch' entries.
 132         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 133         (mi_cmd_catch_rethrow): Declare.
 134         (mi_cmd_catch_catch): Declare.
 135
 136 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 137
 138         * annotate.c (annotate_source_line): Change return type to void,
 139         update implementation to match.
 140         * annotate.h (annotate_source_line): Change return type to void,
 141         update header comment.
 142         * stack.c (print_frame_info): Don't change what frame information
 143         is printed based on whether annotations are on or not.
 144
 145 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 146
 147         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 148         (annotate_source): Make static.
 149         (annotate_source_line): Moved from source.c and renamed from
 150         identify_source_line.  Update the return type.
 151         * annotate.h (annotate_source): Delete declaration.
 152         (annotate_source_line): Declaration moved from source.h, and
 153         renamed from identify_source_line.  Return type updated.
 154         * source.c (identify_source_line): Moved to annotate.c and renamed
 155         to annotate_source_line.
 156         (info_line_command): Remove check of annotation_level.
 157         * source.h (identify_source_line): Move declaration to annotate.h
 158         and rename to annotate_source_line.
 159         * stack.c: Add 'annotate.h' include.
 160         (print_frame_info): Remove check of annotation_level before
 161         calling annotate_source_line.
 162
 163 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * source-cache.c (source_cache::get_plain_source_lines): Use
 166         open_source_file_with_line_charpos instead of just
 167         open_source_file, remove call to find_source_lines.
 168         (source_cache::get_source_lines): Likewise.
 169         * source.c (find_source_lines): Make static.
 170         (get_filename_and_charpos): Renamed into...
 171         (open_source_file_with_line_charpos): ..this along with changes to
 172         return a scoped_fd, and some other minor clean ups.
 173         (identify_source_line): Use open_source_file_with_line_charpos.
 174         (search_command_helper): Use open_source_file_with_line_charpos
 175         instead of just open_source_file, remove call to
 176         find_source_lines.
 177         * source.h (open_source_file_with_line_charpos): Declare new
 178         function.
 179         (find_source_lines): Delete declaration.
 180
 181 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 182
 183         * source.c (get_filename_and_charpos): Remove fullname
 184         parameter.
 185         (identify_source_line): Update call to get_filename_and_charpos.
 186
 187 2019-06-14  Tom Tromey  <tromey@adacore.com>
 188
 189         PR gdb/24502:
 190         * ui-style.h (skip_ansi_escape): Update comment.
 191         * ui-file.h (class no_terminal_escape_file): New class.
 192         * ui-file.c (no_terminal_escape_file::write)
 193         (no_terminal_escape_file::puts): New methods.
 194         * cli/cli-logging.c (handle_redirections): Use
 195         no_terminal_escape_file.
 196
 197 2019-06-14  Tom Tromey  <tromey@adacore.com>
 198
 199         * NEWS: Move convenience variable news above Python news.
 200
 201 2019-06-14  Tom Tromey  <tom@tromey.com>
 202
 203         * gnulib: Move directory to top-level.
 204         * configure.ac: Don't configure gnulib.
 205         * configure: Rebuild.
 206         * common/common-defs.h: Use new path to gnulib.
 207         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 208         (GNULIB_H): Remove.
 209         (INCGNU): Look in new gnulib location.
 210         (HFILES_NO_SRCDIR): Remove gnulib files.
 211         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 212         (generated_files): Remove GNULIB_H.
 213         ($(LIBGNU), all-lib): Remove targets.
 214         (distclean): Don't mention GNULIB_BUILDDIR.
 215         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 216
 217 2019-06-14  Tom Tromey  <tromey@adacore.com>
 218
 219         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 220         Warn if symbol file does not provide any symbols.
 221
 222 2019-06-14  Tom Tromey  <tromey@adacore.com>
 223
 224         * source.c (find_and_open_source): Respect basenames_may_differ.
 225
 226 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 227
 228         * annotate.c (annotate_breakpoints_invalid): Make use of
 229         scoped_restore_terminal_state.
 230         (annotate_frames_invalid): Likewise.
 231
 232 2019-06-14  Tom Tromey  <tromey@adacore.com>
 233
 234         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 235         allow assignment to an internalvar.
 236
 237 2019-06-14  Tom Tromey  <tromey@adacore.com>
 238
 239         * ada-lex.l: Allow "_" in attribute names.
 240
 241 2019-06-14  Tom Tromey  <tromey@adacore.com>
 242
 243         PR gdb/24653:
 244         * regcache.c (registers_changed): Don't call alloca.
 245         * top.c (execute_command): Don't call alloca.
 246
 247 2019-06-13  Pedro Alves  <palves@redhat.com>
 248
 249         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 250         'expression'.  When parsing an expression, error out if there's
 251         junk after "unlimited".
 252         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 253         (do_set_command): Adjust calls to is_unlimited_literal.
 254
 255 2019-06-13  Pedro Alves  <palves@redhat.com>
 256
 257         * compile/compile.c (make_compile_options_def_group): Add braces
 258         around array_view initializer.
 259         * thread.c (make_thread_apply_all_options_def_group)
 260         (make_thread_apply_all_options_def_group): Likewise.
 261
 262 2019-06-13  Pedro Alves  <palves@redhat.com>
 263
 264         * NEWS (New commands): Mention "maint test-options
 265         require-delimiter", "maint test-options unknown-is-error", "maint
 266         test-options unknown-is-operand" and "maint show
 267         test-options-completion-result".
 268         (New command options, command completion): New section.
 269         (Completion improvements): New section.
 270         Mention that you can abbreviate "unlimited".
 271
 272 2019-06-13  Pedro Alves  <palves@redhat.com>
 273
 274         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 275         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 276         * unittests/cli-utils-selftests.c (test_parse_flags)
 277         (test_parse_flags_qcs): Delete.
 278         (test_cli_utils): Don't call deleted functions.
 279
 280 2019-06-13  Pedro Alves  <palves@redhat.com>
 281
 282         * thread.c: Include "cli/cli-option.h".
 283         (tp_array_compar_ascending): Global.
 284         (tp_array_compar): Delete function.
 285         (tp_array_compar_ascending, tp_array_compar_descending): New
 286         functions.
 287         (ascending_option_def, qcs_flag_option_def)
 288         (thr_qcs_flags_option_defs)
 289         (make_thread_apply_all_options_def_group)
 290         (make_thread_apply_options_def_group): New.
 291         (thread_apply_all_command): Use gdb::option::process_options.
 292         (thread_apply_command_completer)
 293         (thread_apply_all_command_completer): New.
 294         (thread_apply_command): Use gdb::option::process_options.
 295         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 296         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 297         to generate help text of "thread apply".  Adjust "taas"'s help.
 298         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 299         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 300
 301 2019-06-13  Pedro Alves  <palves@redhat.com>
 302
 303         * thread.c (thread_apply_command): Check for invalid TID with
 304         isdigit instead of !isalpha.
 305
 306 2019-06-13  Pedro Alves  <palves@redhat.com>
 307
 308         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 309         (validate_flags_qcs): New.
 310         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 311         (validate_flags_qcs): Declare.
 312         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 313         (make_frame_apply_options_def_group): New.
 314         (frame_apply_command_count): Process options with
 315         gdb::option::process_options.
 316         (frame_apply_completer): New.
 317         (frame_apply_level_completer, frame_apply_all_completer)
 318         (frame_apply_completer): New.
 319         (_initialize_stack): Update help of "frame apply", "frame apply
 320         level", "frame apply all" and "faas" to mention supported options
 321         and install command completers.
 322         * stack.h (frame_apply_all_completer): Declare.
 323         * thread.c: Include "stack.h".
 324         (tfaas_command): Add "--".
 325         (_initialize_thread): Update help "tfaas" to mention supported
 326         options and install command completer.
 327
 328 2019-06-13  Pedro Alves  <palves@redhat.com>
 329
 330         * completer.c (complete_nested_command_line): New.
 331         (gdb_completion_word_break_characters_throw): Add assertion.
 332         * completer.h (complete_nested_command_line): Declare.
 333
 334 2019-06-13  Pedro Alves  <palves@redhat.com>
 335
 336         * stack.c (parse_backtrace_qualifiers): New.
 337         (backtrace_command): Use it.
 338         (backtrace_command_completer): Complete on qualifiers.
 339
 340 2019-06-13  Pedro Alves  <palves@redhat.com>
 341
 342         * frame.c: Include "cli/cli-option.h.
 343         (user_set_backtrace_options): New.
 344         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 345         Delete.
 346         (get_prev_frame): Adjust.
 347         (boolean_option_def, uinteger_option_def)
 348         (set_backtrace_option_defs): New.
 349         (_initialize_frame): Adjust and use
 350         gdb::option::add_setshow_cmds_for_options to install "set
 351         backtrace past-main" and "set backtrace past-entry".
 352         * frame.h: Include "cli/cli-option.h".
 353         (struct frame_print_options): Forward declare.
 354         (print_frame_arguments_all, print_frame_arguments_scalars)
 355         (print_frame_arguments_none): Declare.
 356         (print_entry_values): Delete declaration.
 357         (struct frame_print_options, user_frame_print_options): New.
 358         (struct set_backtrace_options): New.
 359         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 360         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 361         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 362         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 363         (list_args_or_locals): Add frame_print_options parameter.
 364         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 365         * python/py-framefilter.c (enumerate_args): Pass down
 366         USER_FRAME_PRINT_OPTIONS.
 367         * stack.c: Include "cli/cli-option.h".
 368         (print_frame_arguments_all, print_frame_arguments_scalars)
 369         (print_frame_arguments_none): Declare.
 370         (print_raw_frame_arguments, print_entry_values): Delete.
 371         (user_frame_print_options): New.
 372         (boolean_option_def, enum_option_def, frame_print_option_defs):
 373         New.
 374         (struct backtrace_cmd_options): New.
 375         (bt_flag_option_def): New.
 376         (backtrace_command_option_defs): New.
 377         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 378         (print_frame_arg, read_frame_arg, print_frame_args)
 379         (print_frame_info, print_frame): Add frame_print_options parameter
 380         and use it.
 381         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 382         (backtrace_command_1): Add frame_print_options and
 383         backtrace_cmd_options parameters and use them.
 384         (make_backtrace_options_def_group): New.
 385         (backtrace_command): Process command options with
 386         gdb::option::process_options.
 387         (backtrace_command_completer): New.
 388         (_initialize_stack): Extend "backtrace"'s help to mention
 389         supported options.  Install completer for "backtrace".
 390         Install some settings commands with add_setshow_cmds_for_options.
 391
 392 2019-06-13  Pedro Alves  <palves@redhat.com>
 393
 394         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 395         and that "set/show print raw frame-arguments" are now deprecated.
 396
 397         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 398         command.
 399         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 400         * stack.c (_initialize_stack): Install "set/show print
 401         raw-frame-arguments", and deprecate "set/show print raw
 402         frame-arguments".
 403         * valprint.c (_initialize_valprint): Deprecate "set/show print
 404         raw".
 405
 406 2019-06-13  Pedro Alves  <palves@redhat.com>
 407
 408         * compile/compile.c (struct compile_options): New.
 409         (compile_flag_option_def, compile_command_option_defs)
 410         (make_compile_options_def_group): New.
 411         (compile_file_command): Handle options with
 412         gdb::option::process_options.
 413         (compile_file_command_completer): New function.
 414         (compile_code_command): Handle options with
 415         gdb::option::process_options.
 416         (compile_code_command_completer): New function.
 417         (_initialize_compiler): Install completers for "compile code" and
 418         "compile file".  Mention available options in "compile code" and
 419         "compile code"'s help.
 420         * completer.c (advance_to_completion_word): New, factored out from
 421         ...
 422         (advance_to_expression_complete_word_point): ... this.
 423         (advance_to_filename_complete_word_point): New.
 424         * completer.h (advance_to_filename_complete_word_point): New
 425         declaration.
 426
 427 2019-06-13  Pedro Alves  <palves@redhat.com>
 428
 429         * compile/compile.c: Include "cli/cli-option.h".
 430         (compile_print_value): Scope data pointer is now a
 431         value_print_options pointer; adjust.
 432         (compile_print_command): Process options.  Scope data pointer is
 433         now a value_print_options pointer; adjust.
 434         (_initialize_compile): Update "compile print"'s help to include
 435         supported options.  Install a completer for "compile print".
 436         * cp-valprint.c (show_vtblprint, show_objectprint)
 437         (show_static_field_print): Delete.
 438         (_initialize_cp_valprint): Don't install "set print
 439         static-members", "set print vtbl", "set print object" here.
 440         * printcmd.c: Include "cli/cli-option.h" and
 441         "common/gdb_optional.h".
 442         (print_command_parse_format): Rework to fill in a
 443         value_print_options instead of a format_data.
 444         (print_value): Change parameter type from format_data pointer to
 445         value_print_options reference.  Adjust.
 446         (print_command_1): Process options.  Adjust to pass down a
 447         value_print_options.
 448         (print_command_completer): New.
 449         (_initialize_printcmd): Install print_command_completer as
 450         handle_brkchars completer for the "print" command.  Update
 451         "print"'s help to include supported options.
 452         * valprint.c: Include "cli/cli-option.h".
 453         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 454         here from cp-valprint.c.
 455         (boolean_option_def, uinteger_option_def)
 456         (value_print_option_defs, make_value_print_options_def_group):
 457         New.  Use gdb::option::add_setshow_cmds_for_options to install
 458         "set print elements", "set print null-stop", "set print repeats",
 459         "set print pretty", "set print union", "set print array", "set
 460         print address", "set print symbol", "set print array-indexes".
 461         * valprint.h: Include <string> and "cli/cli-option.h".
 462         (make_value_print_options_def_group): Declare.
 463         (print_value): Change parameter type from format_data pointer to
 464         value_print_options reference.
 465         (print_command_completer): Declare.
 466
 467 2019-06-13  Pedro Alves  <palves@redhat.com>
 468
 469         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 470         (COMMON_SFILES): Add maint-test-settings.c.
 471         * cli/cli-decode.c (boolean_enums): New global, factored out from
 472         ...
 473         (add_setshow_boolean_cmd): ... here.
 474         * cli/cli-decode.h (boolean_enums): Declare.
 475         * cli/cli-option.c: New file.
 476         * cli/cli-option.h: New file.
 477         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 478         factored out from ...
 479         (parse_cli_boolean_value(const char *)): ... this.
 480         (is_unlimited_literal): Change parameter type to pointer to
 481         pointer.  Adjust and advance ARG pointer.
 482         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 483         (parse_cli_var_enum): New, factored out from ...
 484         (do_set_command): ... this.  Adjust.
 485         * cli/cli-setshow.h (parse_cli_boolean_value)
 486         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 487         (parse_cli_var_enum): Declare.
 488         * cli/cli-utils.c: Include "cli/cli-option.h".
 489         (get_ulongest): New.
 490         * cli/cli-utils.h (get_ulongest): Declare.
 491         (check_for_argument): New overloads.
 492         * maint-test-options.c: New file.
 493
 494 2019-06-13  Pedro Alves  <palves@redhat.com>
 495
 496         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 497         parse a range if "-" is at the end of the string.
 498
 499 2019-06-13  Pedro Alves  <palves@redhat.com>
 500
 501         * cli/cli-setshow.c (parse_auto_binary_operation)
 502         (parse_cli_boolean_value): Don't allow "o".
 503
 504 2019-06-13  Pedro Alves  <palves@redhat.com>
 505
 506         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 507         * NEWS: Mention maint test-settings KIND.
 508         * maint-test-settings.c: New file.
 509
 510 2019-06-13  Pedro Alves  <palves@redhat.com>
 511
 512         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 513         completer.
 514         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 515         "set" completers.
 516
 517 2019-06-13  Pedro Alves  <palves@redhat.com>
 518
 519         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 520         after item.
 521
 522 2019-06-13  Pedro Alves  <palves@redhat.com>
 523
 524         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 525
 526 2019-06-13  Pedro Alves <palves@redhat.com>
 527
 528         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 529         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 530         call.
 531         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 532         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 533         calls.
 534         (check_for_argument): Skip spaces after argument.
 535
 536 2019-06-13  Pedro Alves  <palves@redhat.com>
 537
 538         * thread.c (thread_apply_command): Adjust TID parsing.
 539         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 540         detected before end of string.
 541         (tid_is_in_list): Error out if LIST is invalid.
 542
 543 2019-06-13  Pedro Alves  <palves@redhat.com>
 544
 545         * completer.c (complete_line_internal_1): Rewind completion word
 546         point.
 547         (completion_tracker::advance_custom_word_point_by): Change
 548         parameter type to int.
 549         * completer.h (completion_tracker::advance_custom_word_point_by):
 550         Likewise.
 551
 552 2019-06-13  Pedro Alves  <palves@redhat.com>
 553
 554         * completer.c (advance_to_completion_word): Handle delimiters.
 555
 556 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 557
 558         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 559
 560 2019-06-11  Tom Tromey  <tom@tromey.com>
 561
 562         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 563         (xmalloc_failed): Move to alloc.c.
 564         * alloc.c: New file.
 565         * Makefile.in (COMMON_SFILES): Add alloc.c.
 566
 567 2019-06-11  Tom Tromey  <tom@tromey.com>
 568
 569         * nat/linux-waitpid.c: Don't include server.h.
 570         (linux_debug): Remove.
 571         (my_waitpid): Update.
 572
 573 2019-06-11  Tom Tromey  <tromey@adacore.com>
 574
 575         * infcall.c (_initialize_infcall): Remove trailing newline from
 576         help.
 577         * user-regs.c (_initialize_user_regs): Remove trailing newline
 578         from help.
 579         * typeprint.c (_initialize_typeprint): Remove trailing newline
 580         from help.
 581         * reverse.c (_initialize_reverse): Remove trailing newlines from
 582         help.
 583         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 584         from help.
 585         * language.c (add_set_language_command): Remove trailing newline
 586         from help.
 587         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 588         help.
 589         * disasm.c (_initialize_disasm): Remove trailing newline from
 590         help.
 591         * top.c (init_main): Remove trailing newline from help.
 592         * interps.c (_initialize_interpreter): Remove trailing newline
 593         from help.
 594         * btrace.c (_initialize_btrace): Remove trailing newlines from
 595         help.
 596         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 597         from help.
 598         * python/python.c (_initialize_python): Remove trailing newline
 599         from help.
 600         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 601         help.
 602         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 603         from help.  Reformat some text.
 604         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 605         from help.
 606         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 607         newline from help.
 608
 609 2019-06-11  Tom Tromey  <tromey@adacore.com>
 610
 611         * darwin-nat.c (darwin_decode_exception_message)
 612         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 613
 614 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * valops.c (value_slice): Check for not allocated or not
 617         associated values.
 618
 619 2019-06-10  Tom de Vries  <tdevries@suse.de>
 620
 621         PR gdb/24618
 622         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 623         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 624         invalid.
 625
 626 2019-06-10  Tom de Vries  <tdevries@suse.de>
 627
 628         PR gdb/24611
 629         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 630         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 631
 632 2019-06-10  Tom de Vries  <tdevries@suse.de>
 633
 634         PR symtab/24545
 635         * symtab.c (struct demangled_name_entry): Add language field.
 636         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 637         static minimal symbol".  Set and use language field.
 638
 639 2019-06-10  Tom Tromey  <tromey@adacore.com>
 640
 641         * ada-lang.c (_initialize_ada_language): Update help text.
 642
 643 2019-06-10  Tom Tromey  <tromey@adacore.com>
 644
 645         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 646         with a newline.
 647         * guile/guile.c (handle_boot_error): Don't end warning with a
 648         newline.
 649         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 650         warning with a newline.
 651         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 652         newline.
 653         (s12z_frame_cache): Likewise.
 654         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 655         a newline.
 656         * solib-svr4.c (disable_probes_interface): Don't end warning with
 657         a newline.
 658         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 659         newline.
 660         * python/python.c (do_finish_initialization): Don't end warning
 661         with a newline.
 662
 663 2019-06-10  Tom Tromey  <tom@tromey.com>
 664
 665         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 666         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 667         gdbpy_enter.
 668
 669 2019-06-10  Tom Tromey  <tromey@adacore.com>
 670
 671         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 672         data.
 673         (elf_new_init): Don't call stabsread_new_init.
 674         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 675         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 676         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 677
 678 2019-06-10  Tom de Vries  <tdevries@suse.de>
 679
 680         PR symtab/16264
 681         PR symtab/24517
 682         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 683
 684 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 685
 686         * source.c (find_and_open_source): Also rewrite relative file
 687         names.
 688
 689 2019-04-26  Amos Bird  <amosbird@gmail.com>
 690
 691         * annotate.c (annotate_thread_exited): Add "thread-exited"
 692         annotation.
 693
 694 2019-06-06  Tom Tromey  <tromey@adacore.com>
 695
 696         * maint.h (class scoped_command_stats): Use
 697         DISABLE_COPY_AND_ASSIGN.
 698         <print_time>: New method.
 699         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 700         print_time.
 701         (scoped_command_stats::print_time): New method.
 702
 703 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 706         instructions of lengths 6 or 8 bytes.
 707
 708 2019-06-04  Pedro Alves  <palves@redhat.com>
 709
 710         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 711
 712         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 713         * breakpoint.c (condition_completer): Likewise.
 714         * cli/cli-dump.c (scan_expression): Likewise.
 715         * common/filestuff.c (mkdir_recursive): Likewise.
 716         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 717         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 718         (gdb_abspath): Likewise.
 719         * compile/compile-cplus-types.c
 720         (compile_cplus_instance::decl_name): Likewise.
 721         * completer.c (complete_explicit_location):
 722         (signal_completer, reg_or_group_completer_1): Likewise.
 723         * cp-support.c (cp_remove_params_if_any): Likewise.
 724         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 725         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 726         * infcmd.c (strip_bg_char): Likewise.
 727         * linespec.c (copy_token_string): Likewise.
 728         * mi/mi-main.c (output_cores): Likewise.
 729         * psymtab.c (psymtab_search_name):
 730         * symfile.c (test_set_ext_lang_command): Likewise.
 731         * target.c (target_fileio_read_stralloc): Likewise.
 732         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 733         * value.c (complete_internalvar): Likewise.
 734
 735 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 736
 737         Add objfile property to gdb.Type.
 738         * NEWS: Mention Python API addition.
 739         * python/py-type.c (typy_get_objfile): New method.
 740
 741 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 742
 743         * NEWS: Mention the new set|show style [title|highlight].
 744         Mention changes to "show style", "help" and "apropos".
 745
 746 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 747
 748         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 749         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 750         instead of print_help_for_command.
 751         (print_doc_of_command): New function.
 752         (help_list): Add 'apropos -v word' suggestion.
 753         (print_help_for_command): Style the command name using title style.
 754         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 755         (_initialize_cli_cmds): Describe -v in apropos_command help.
 756
 757 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 758
 759         * cli/cli-style.h (cli_style_option): Add name in constructor,
 760         add m_name class member, add constructor with intensity,
 761         add name class function.
 762         (cli_style_option::add_setshow_commands): Remove name argument.
 763         (highlight_style, title_style): New styles.
 764         * cli/cli-style.c (do_show): New function that shows a style
 765         characteristic styling the style name with itself.
 766         (set_style_name): New function.
 767         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 768         Update all callers according to the changes in cli/cli-style.h.
 769         * utils.h (fputs_highlighted): New function.
 770         * utils.c (fputs_highlighted): Likewise.
 771
 772 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 773
 774         * NEWS: Mention new pipe command and new convenience variables.
 775
 776 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 777
 778         * cli/cli-cmds.c (pipe_command): New function.
 779         (_initialize_cli_cmds): Call add_com for pipe_command.
 780         Define | as an alias for pipe.
 781         (exit_status_set_internal_vars): New function.
 782         (shell_escape): Call exit_status_set_internal_vars.
 783         cli/cli-decode.c (find_command_name_length): Recognize | as
 784         a single character command.
 785
 786 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 787
 788         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 789         top.c (execute_command_to_ui_file): New function, mostly a copy
 790         of execute_command_to_string.
 791         (execute_command_to_string): Implement by calling
 792         execute_command_to_ui_file.
 793
 794 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 795
 796         * top.h (saved_command_line): Remove declaration.
 797         * top.c (previous_saved_command_line, previous_repeat_arguments):
 798         New variables.
 799         (saved_command_line): Make static, define together with other
 800         'repeat variables'.
 801         (dont_repeat): Clear repeat_arguments.
 802         (repeat_previous, get_saved_command_line, save_command_line):
 803         New functions.
 804         (gdb_init): Initialize saved_command_line
 805         and previous_saved_command_line.
 806         * main.c (captured_main_1): Remove saved_command_line initialization.
 807         * event-top.c (handle_line_of_input): Update to use
 808         the new 'repeat' related functions instead of direct access to
 809         saved_command_line.
 810         * command.h (repeat_previous, get_saved_command_line,
 811         save_command_line): New declarations.
 812         (dont_repeat): Add comment.
 813
 814 2019-05-30  Tom Tromey  <tromey@adacore.com>
 815
 816         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 817         Fix comment.
 818         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 819
 820 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 821
 822         PR cli/24587
 823         * completer.c (complete): Initialize variable word.
 824
 825 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 826
 827         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 828         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 829         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 830         'body' is NULL to the outter 'if', protecting the '!is_define'
 831         situation as well.
 832
 833 2019-05-29  Tom Tromey  <tromey@adacore.com>
 834
 835         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 836         (dwarf_unknown): New function.
 837         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 838         (dwarf_type_encoding_name): Use dwarf_unknown.
 839
 840 2019-05-29  Tom Tromey  <tromey@adacore.com>
 841
 842         PR c++/20020:
 843         * cp-valprint.c (cp_print_value_fields): Call
 844         cp_print_static_field inside "try".
 845
 846 2019-05-29  Tom Tromey  <tromey@adacore.com>
 847
 848         * inflow.c (struct terminal_info): Add default operator=.
 849         * configure: Rebuild.
 850         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 851         -Wdeprecated-copy-dtor, -Wredundant-move.
 852
 853 2019-05-29  Tom Tromey  <tromey@adacore.com>
 854
 855         * NEWS: Add entry.
 856         * infcmd.c (print_return_value_1): Handle finish_print
 857         option.
 858         (show_print_finish): New function.
 859         (_initialize_infcmd): Add "set/show print finish" commands.
 860         * valprint.c (user_print_options): Initialize new member.
 861         * valprint.h (struct value_print_options) <finish_print>: New
 862         member.
 863
 864 2019-05-28  Tom Tromey  <tromey@adacore.com>
 865
 866         * ada-lang.c (ada_remove_Xbn_suffix)
 867         (find_old_style_renaming_symbol)
 868         (parse_old_style_renaming): Remove.
 869         (ada_find_renaming_symbol): Don't call
 870         find_old_style_renaming_symbol.
 871         (ada_is_renaming_symbol): Rename from
 872         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 873         bool.  Now static.
 874         (ada_read_var_value): Update and simplify.
 875         * ada-exp.y (write_var_or_type): Remove old code.
 876
 877 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 878
 879         * event-top.c: Remove include comment.
 880         * inflow.c (class scoped_ignore_sigttou): Move from here...
 881         * inflow.h (class scoped_ignore_sigttou): ...to here.
 882         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 883         * top.c:  Remove include comment.
 884
 885 2019-05-27  Tom Tromey  <tom@tromey.com>
 886
 887         * NEWS: Fix typo.
 888
 889 2019-05-22  Tom Tromey  <tromey@adacore.com>
 890
 891         * target.c (target_follow_exec): Constify parameter.
 892         * target-delegates.c: Rebuild.
 893         * remote.c (remote_target::follow_exec): Constify parameter.
 894         * infrun.c (follow_exec): Constify parameter.
 895         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 896         (target_follow_exec): Likewise.
 897
 898 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 899
 900         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 901         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 902
 903 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 904
 905         * NEWS: Add debugredirect and testsuite sections.
 906
 907 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 908
 909         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 910         target descriptions using exclusively floating point register name
 911         aliases.
 912
 913 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         PR gdb/18644:
 916         * f-lang.c (build_fortran_types): Handle the case where
 917         gdbarch_floatformat_for_type returns a nullptr.
 918
 919 2019-05-21  Tom de Vries  <tdevries@suse.de>
 920
 921         PR cli/24587
 922         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 923
 924 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         PR gdb/18644:
 927         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 928         16-byte floats.
 929         * i386-tdep.c (i386_floatformat_for_type): Use
 930         floatformats_ia64_quad for the 16-byte floating point component
 931         within a fortran 32-byte complex number.
 932
 933 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 934
 935         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 936         delete default constructor.
 937         (find_partial_die): Update to return const struct.
 938         (partial_die_parent_scope): Move variable declaration into scope
 939         of its use and change its type to auto.
 940         (guess_partial_die_structure_name): Likewise.
 941         (partial_die_info::fixup): Likewise.
 942
 943 2019-05-17  Tom Tromey  <tromey@adacore.com>
 944
 945         * source.c (find_and_open_source): Remove cast.
 946
 947 2019-05-17  Tom Tromey  <tromey@adacore.com>
 948
 949         * annotate.c (annotate_source): Make "filename" const.
 950         * annotate.h (annotate_source): Use const.
 951
 952 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 953
 954         * disasm.c (set_disassembler_options): Send errors to stderr.
 955
 956 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 957
 958         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 959         (cli_interp_base::set_logging): Check debug_redirect.
 960         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 961         * cli/cli-logging.c (debug_redirect): Add static variable.
 962         (pop_output_files): Add default param.
 963         (handle_redirections): Print debug setting.
 964         (show_logging_command): Likewise.
 965         (_initialize_cli_logging): Add debugredirect command.
 966         * interps.c (current_interp_set_logging): Add debug_redirect
 967         parameter.
 968         * interps.h (set_logging): Add debug_redirect parameter.
 969         (current_interp_set_logging): Likewise.
 970         * mi/mi-common.h: Likewise.
 971         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 972
 973 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 974             Tom Tromey  <tromey@adacore.com>
 975
 976         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 977         directly.
 978         * cli/cli-interp.h (make_logging_output): Remove declaration.
 979         * cli/cli-logging.c (make_logging_output): Remove function.
 980         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 981         directly.
 982         * ui-file.c (tee_file::tee_file): Remove bools.
 983         (tee_file::~tee_file): Remove deletes.
 984         * ui-file.h (tee_file): Remove bools.
 985
 986 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 987
 988         * mi/mi-cmds.h (mi_cmd_complete): New function.
 989         * mi/mi-main.c (mi_cmd_complete): Likewise.
 990         * mi/mi-cmds.c: Define new MI command -complete.
 991         * NEWS: Mention new -complete command.
 992
 993 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 994
 995         * completer.h (complete): New function.
 996         * completer.c (complete): Likewise.
 997         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 998         function defined in completer.h.
 999
1000 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1001
1002         * MAINTAINERS (Write After Approval): Add myself.
1003
1004 2019-05-17  Tom de Vries  <tdevries@suse.de>
1005
1006         PR gdb/24094
1007         * dwarf2read.c (struct cu_partial_die_info): New struct.
1008         (find_partial_die): Return cu_partial_die_info.
1009         (partial_die_parent_scope, guess_partial_die_structure_name)
1010         (partial_die_info::fixup): Handle new return type of find_partial_die.
1011
1012 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1013
1014         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1015         "std::string", simplifying the algorithm.
1016
1017 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1018
1019         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1020         (stap_static_probe_ops::get_probes): Likewise.
1021
1022 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1023
1024         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1025         '-')" and "else if".
1026         (stap_parse_single_operand): Join checks for
1027         "gdbarch_stap_parse_special_token_p" and
1028         "gdbarch_stap_parse_special_token" in the same "if" statement.
1029         Invert check when verifying for operation on register
1030         displacement.
1031
1032 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1033
1034         * stap-probe.c (stap_get_opcode): Update comment.
1035         (stap_get_expected_argument_type): Likewise.
1036         (handle_stap_probe): Likewise.
1037
1038 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1039
1040         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1041         return type to 'bool'.  Adjust comment.  Use 'bool' when
1042         appropriate.
1043         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1044         * stap-probe.c (stap_parse_argument_1): Likewise.
1045         (stap_is_operator): Likewise.
1046         (stap_is_generic_prefix): Likewise.
1047         (stap_is_register_prefix): Likewise.
1048         (stap_is_register_indirection_prefix): Likewise.
1049         (stap_is_integer_prefix): Likewise.
1050         (stap_generic_check_suffix): Likewise.
1051         (stap_check_integer_suffix): Likewise.
1052         (stap_check_register_suffix): Likewise.
1053         (stap_check_register_indirection_suffix): Likewise.
1054         (stap_parse_register_operand): Likewise.
1055         (stap_parse_single_operand): Likewise.
1056         (stap_parse_argument_1): Likewise.
1057         (stap_probe::get_argument_count): Likewise.
1058         (stap_is_operator): Likewise.
1059
1060 2019-05-16  Tom Tromey  <tromey@adacore.com>
1061
1062         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1063         keyword to foreach.
1064
1065 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1066
1067         * linux-thread-db.c (try_thread_db_load_1): Change return type
1068         to bool.
1069         (try_thread_db_load): Likewise.
1070         (try_thread_db_load_from_pdir_1): Likewise.
1071         (try_thread_db_load_from_pdir): Likewise.
1072         (try_thread_db_load_from_sdir): Likewise.
1073         (try_thread_db_load_from_dir): Likewise.
1074         (thread_db_load_search): Likewise.
1075         (has_libpthread): Likewise.
1076         (thread_db_load): Likewise.
1077
1078 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1079
1080         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1081         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1082         NULL, and complain/return if that's the case.
1083
1084 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1085
1086         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1087         (advance, posn, abstract_read_memory): New functions.
1088         [struct mem_read_abstraction]: New struct.
1089         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1090
1091 2019-05-14  Tom Tromey  <tromey@adacore.com>
1092
1093         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1094         value is not lval_memory.
1095
1096 2019-05-14  Tom Tromey  <tromey@adacore.com>
1097
1098         * solib.c (info_sharedlibrary_command): Style the file name.
1099
1100 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1101
1102         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1103         (aarch64_vnv_type): Likewise.
1104         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1105         * common/tdesc.c: Likewise.
1106         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1107         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1108         * features/aarch64-fpu.xml: Add ieee half view.
1109         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1110         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1111         * gdbtypes.h (struct builtin_type): Likewise.
1112         (struct objfile_type): Likewise.
1113
1114 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1115
1116         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1117         typo.
1118         * location.h (string_to_event_location): Likewise.
1119
1120 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1121
1122         GDB 8.3 released.
1123
1124 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1125
1126         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1127         New variable declaration.
1128         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1129         New variable.
1130         (print_one_breakpoint): Use ui_out::test_flags and new global
1131         variable to compute use_fixed_output.
1132         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1133         Remove.
1134         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1135         (mi_multi_location_breakpoint_output_fixed): Remove.
1136         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1137         new variable.
1138         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1139         fix_multi_location_breakpoint_output flag if version >= 3.
1140         * ui-out.h (enum ui_out_flag)
1141         <fix_multi_location_breakpoint_output>: New enumerator.
1142
1143 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1144
1145         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1146
1147 2019-05-10  Tom Tromey  <tromey@adacore.com>
1148
1149         * ada-lang.c (catch_ada_completer): New function.
1150         (_initialize_ada_language): Use it.
1151
1152 2019-05-10  Tom Tromey  <tromey@adacore.com>
1153
1154         * thread.c (print_thread_info): Make "requested_threads" const.
1155         * gdbthread.h (print_thread_info): Make "requested_threads"
1156         const.
1157         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1158         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1159
1160 2019-05-08  Tom Tromey  <tom@tromey.com>
1161
1162         * gdbtypes.c (objfile_type_data): Change type.
1163         (objfile_type, _initialize_gdbtypes): Update.
1164
1165 2019-05-08  Tom Tromey  <tom@tromey.com>
1166
1167         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1168         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1169         (_initialize_dwarf2_frame): Update.
1170
1171 2019-05-08  Tom Tromey  <tom@tromey.com>
1172
1173         * objc-lang.c (objc_objfile_data): Change type.
1174         (find_methods): Update.
1175         (_initialize_objc_lang): Remove.
1176
1177 2019-05-08  Tom Tromey  <tom@tromey.com>
1178
1179         * stabsread.c (rs6000_builtin_type_data): Change type.
1180         (rs6000_builtin_type, _initialize_stabsread): Update.
1181
1182 2019-05-08  Tom Tromey  <tom@tromey.com>
1183
1184         * mips-tdep.c (mips_pdr_data): Remove.
1185         (_initialize_mips_tdep): Update.
1186
1187 2019-05-08  Tom Tromey  <tom@tromey.com>
1188
1189         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1190         (hppa_init_objfile_priv_data, read_unwind_info)
1191         (find_unwind_entry, _initialize_hppa_tdep): Update.
1192
1193 2019-05-08  Tom Tromey  <tom@tromey.com>
1194
1195         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1196         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1197         on obstack.
1198         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1199
1200 2019-05-08  Tom Tromey  <tom@tromey.com>
1201
1202         * mdebugread.c (basic_type_data): Change type.
1203         (basic_type, _initialize_mdebugread): Update.
1204
1205 2019-05-08  Tom Tromey  <tom@tromey.com>
1206
1207         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1208
1209 2019-05-08  Tom Tromey  <tom@tromey.com>
1210
1211         * nto-tdep.c (nto_inferior_data_reg): Change type.
1212         (nto_inferior_data): Update.
1213         (nto_inferior_data_cleanup, nto_new_inferior_data)
1214         (_initialize_nto_tdep): Remove.
1215         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1216
1217 2019-05-08  Tom Tromey  <tom@tromey.com>
1218
1219         * ada-lang.c (struct ada_inferior_data): Add initializers.
1220         (ada_inferior_data): Change type.
1221         (ada_inferior_data_cleanup): Remove.
1222         (get_ada_inferior_data, ada_inferior_exit)
1223         (struct ada_pspace_data): Add initializers, destructor.
1224         (ada_pspace_data_handle): Change type.
1225         (get_ada_pspace_data): Update.
1226         (ada_pspace_data_cleanup): Remove.
1227
1228 2019-05-08  Tom Tromey  <tom@tromey.com>
1229
1230         * coffread.c (struct coff_symfile_info): Add initializers.
1231         (coff_objfile_data_key): Move lower.  Change type.
1232         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1233         Update.
1234         (coff_free_info): Remove.
1235
1236 2019-05-08  Tom Tromey  <tom@tromey.com>
1237
1238         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1239         (fbsd_pspace_data_handle): Move lower.  Change type.
1240         (get_fbsd_pspace_data): Update.
1241         (fbsd_pspace_data_cleanup): Remove.
1242         (_initialize_fbsd_tdep): Update.
1243
1244 2019-05-08  Tom Tromey  <tom@tromey.com>
1245
1246         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1247         (get_ada_tasks_pspace_data): Update.
1248         (ada_tasks_pspace_data_cleanup): Remove.
1249         (_initialize_tasks): Update.
1250         (ada_tasks_inferior_data_handle): Change type.
1251         (get_ada_tasks_inferior_data): Update.
1252         (ada_tasks_inferior_data_cleanup): Remove.
1253         (struct ada_tasks_pspace_data): Add initializers.
1254
1255 2019-05-08  Tom Tromey  <tom@tromey.com>
1256
1257         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1258         * symfile-debug.c (debug_sym_get_probes): Change type.
1259         * stap-probe.c (handle_stap_probe):
1260         (stap_static_probe_ops::get_probes): Change type.
1261         * probe.h (class static_probe_ops) <get_probes>: Change type.
1262         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1263         (parse_probes_in_pspace): Update.
1264         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1265         Update.
1266         (any_static_probe_ops::get_probes): Change type.
1267         * elfread.c (elfread_data): New typedef.
1268         (probe_key): Change type.
1269         (elf_get_probes): Likewise.  Update.
1270         (probe_key_free): Remove.
1271         (_initialize_elfread): Update.
1272         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1273         Change type.
1274         (dtrace_process_dof_probe, dtrace_process_dof)
1275         (dtrace_static_probe_ops::get_probe): Change type.
1276
1277 2019-05-08  Tom Tromey  <tom@tromey.com>
1278
1279         * xcoffread.c (struct xcoff_symfile_info): Rename from
1280         coff_symfile_info.  Add initializers.
1281         (xcoff_objfile_data_key): Move lower.  Change type.
1282         (XCOFF_DATA): Rewrite.
1283         (xcoff_free_info): Remove.
1284         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1285         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1286         (xcoff_initial_scan): Update.
1287
1288 2019-05-08  Tom Tromey  <tom@tromey.com>
1289
1290         * solib-svr4.c (struct svr4_info): Add initializers and
1291         destructor.
1292         <probes_table>: Now an htab_up.
1293         (solib_svr4_pspace_data): Change type.
1294         (free_probes_table): Simplify.
1295         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1296         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1297         (probes_table_remove_objfile_probes, register_solib_event_probe)
1298         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1299         (_initialize_svr4_solib): Update.
1300
1301 2019-05-08  Tom Tromey  <tom@tromey.com>
1302
1303         * remote.c (remote_pspace_data): Change type.
1304         (remote_pspace_data_cleanup): Remove.
1305         (get_remote_exec_file, set_pspace_remote_exec_file)
1306         (_initialize_remote): Update.
1307
1308 2019-05-08  Tom Tromey  <tom@tromey.com>
1309
1310         * breakpoint.c (breakpoint_objfile_key): Change type.
1311         (get_breakpoint_objfile_data): Update.
1312         (free_breakpoint_objfile_data): Remove.
1313         (_initialize_breakpoint): Update.
1314
1315 2019-05-08  Tom Tromey  <tom@tromey.com>
1316
1317         * linux-tdep.c (struct linux_info): Add initializers.
1318         (linux_inferior_data): Move.  Change type.
1319         (invalidate_linux_cache_inf): Update.
1320         (linux_inferior_data_cleanup): Remove.
1321         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1322
1323 2019-05-08  Tom Tromey  <tom@tromey.com>
1324
1325         * auxv.c (auxv_inferior_data): Move.  Change type.
1326         (auxv_inferior_data_cleanup): Remove.
1327         (invalidate_auxv_cache_inf): Rewrite.
1328         (get_auxv_inferior_data, _initialize_auxv): Update.
1329
1330 2019-05-08  Tom Tromey  <tom@tromey.com>
1331
1332         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1333         (symfile_debug_objfile_data_key): Change type.
1334         (symfile_debug_installed, debug_qf_has_symbols)
1335         (debug_qf_find_last_source_symtab)
1336         (debug_qf_forget_cached_source_info)
1337         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1338         (debug_qf_print_stats, debug_qf_dump)
1339         (debug_qf_expand_symtabs_for_function)
1340         (debug_qf_expand_all_symtabs)
1341         (debug_qf_expand_symtabs_with_fullname)
1342         (debug_qf_map_matching_symbols)
1343         (debug_qf_expand_symtabs_matching)
1344         (debug_qf_find_pc_sect_compunit_symtab)
1345         (debug_qf_map_symbol_filenames)
1346         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1347         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1348         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1349         (debug_sym_read_linetable, debug_sym_relocate): Update.
1350         (symfile_debug_free_objfile): Remove.
1351         (install_symfile_debug_logging, _initialize_symfile_debug):
1352         Update.
1353
1354 2019-05-08  Tom Tromey  <tom@tromey.com>
1355
1356         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1357         allocate_on_obstack.
1358         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1359         (get_dwarf2_per_objfile): Update.
1360         (set_dwarf2_per_objfile): Remove.
1361         (dwarf2_has_info, dwarf2_get_section_info): Update.
1362         (dwarf2_free_objfile): Remove.
1363         (_initialize_dwarf2_read): Update.
1364
1365 2019-05-08  Tom Tromey  <tom@tromey.com>
1366
1367         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1368         initializers.
1369         <unsupported_script_warning_printed,
1370         script_not_found_warning_printed>: Now bool.
1371         (auto_load_pspace_data): Change type.
1372         (~auto_load_pspace_info): Rename from
1373         auto_load_pspace_data_cleanup.
1374         (get_auto_load_pspace_data, init_loaded_scripts_info)
1375         (clear_section_scripts, maybe_print_unsupported_script_warning)
1376         (maybe_print_script_not_found_warning, _initialize_auto_load):
1377         Update.
1378
1379 2019-05-08  Tom Tromey  <tom@tromey.com>
1380
1381         * objfiles.c (objfile_pspace_info): Add destructor and
1382         initializers.
1383         (objfiles_pspace_data): Change type.
1384         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1385         (get_objfile_pspace_data): Update.
1386         (objfiles_bfd_data): Change type.
1387         (get_objfile_bfd_data): Update.
1388         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1389
1390 2019-05-08  Tom Tromey  <tom@tromey.com>
1391
1392         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1393         Change type.
1394         (get_catch_syscall_inferior_data): Update.
1395         (catch_syscall_inferior_data_cleanup): Remove.
1396         (_initialize_break_catch_syscall): Update.
1397
1398 2019-05-08  Tom Tromey  <tom@tromey.com>
1399
1400         * inflow.c (struct terminal_info): Add destructor and
1401         initializers.
1402         (inflow_inferior_data): Change type.
1403         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1404         (get_inflow_inferior_data, inflow_inferior_exit)
1405         (swap_terminal_info, _initialize_inflow): Update.
1406
1407 2019-05-08  Tom Tromey  <tom@tromey.com>
1408
1409         * target-dcache.c (target_dcache_cleanup): Remove.
1410         (target_dcache_aspace_key): Change type.
1411         (target_dcache_init_p, target_dcache_invalidate)
1412         (target_dcache_get, target_dcache_get_or_init)
1413         (_initialize_target_dcache): Update.
1414         * dcache.h (struct dcache_deleter): New.
1415
1416 2019-05-08  Tom Tromey  <tom@tromey.com>
1417
1418         * symtab.c (struct symbol_cache): Add destructor and
1419         initializers.
1420         (symbol_cache_key): Move.  Change type.
1421         (make_symbol_cache, free_symbol_cache): Remove.
1422         (get_symbol_cache): Update.
1423         (symbol_cache_cleanup): Remove.
1424         (ALL_PSPACES, symbol_cache_flush)
1425         (maintenance_print_symbol_cache)
1426         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1427         Update.
1428
1429 2019-05-08  Tom Tromey  <tom@tromey.com>
1430
1431         * symtab.c (struct main_info): Add destructor and initializers.
1432         (main_progspace_key): Move.  Change type.
1433         (get_main_info): Update.
1434         (main_info_cleanup): Remove.
1435         (_initialize_symtab): Update.
1436
1437 2019-05-08  Tom Tromey  <tom@tromey.com>
1438
1439         * registry.h (DECLARE_REGISTRY): Define the _key class.
1440
1441 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * NEWS: Merge two 'New commands' sections.
1444
1445 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1446
1447         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1448         parameter and use Ada language definition instead.
1449         (ada_val_print_ptr): Remove unused language parameter.
1450         (ada_val_print_num): Remove language parameter and use Ada language
1451         definition instead.
1452         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1453         parameter.
1454         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1455         parameter and use Ada language definition instead.
1456         (ada_val_print_1): Update all ada_val_print_xxx calls.
1457         Remove language parameter.
1458         (ada_val_print): Update ada_val_print_1 call.
1459
1460 2019-05-08  Tom Tromey  <tromey@adacore.com>
1461
1462         * remote.c (remote_hw_watchpoint_limit)
1463         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1464         Now static.
1465
1466 2019-05-08  Tom Tromey  <tromey@adacore.com>
1467
1468         * maint.c (_initialize_maint_cmds): Move initialization code to
1469         remote.c.
1470         (watchdog, show_watchdog): Move to remote.c.
1471         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1472         "watchdog" static.
1473         (_initialize_remote): Move initialization code from maint.c.
1474         * defs.h (watchdog): Don't declare.
1475
1476 2019-05-08  Tom Tromey  <tromey@adacore.com>
1477
1478         * tui/tui-interp.c: Include main.h.
1479         * interps.c: Include main.h.
1480         * main.h (interpreter_p): Declare.
1481         * defs.h (interpreter_p): Don't declare.
1482
1483 2019-05-08  Tom Tromey  <tromey@adacore.com>
1484
1485         * dwarf2loc.c: Include dwarf2read.h.
1486         * defs.h (read_unsigned_leb128): Don't declare.
1487         * dwarf2read.h (read_unsigned_leb128): Declare.
1488
1489 2019-05-08  Tom Tromey  <tromey@adacore.com>
1490
1491         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1492         method.
1493
1494 2019-05-08  Tom Tromey  <tromey@adacore.com>
1495
1496         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1497         when no wrap column is set.
1498
1499 2019-05-08  Tom Tromey  <tromey@adacore.com>
1500
1501         * c-lang.c (c_get_string): Handle non-C-style arrays.
1502
1503 2019-05-08  Tom Tromey  <tromey@adacore.com>
1504
1505         * typeprint.c (print_offset_data::update): Print the bit offset,
1506         not the number of bits remaining.
1507
1508 2019-05-08  Tom Tromey  <tromey@adacore.com>
1509
1510         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1511         padding at end of comment.
1512
1513 2019-05-08  Tom Tromey  <tromey@adacore.com>
1514
1515         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1516         Compare main types.
1517
1518 2019-05-06  Tom Tromey  <tom@tromey.com>
1519
1520         * common/scoped_mmap.c: Include common-defs.h.
1521         * common/scoped_mmap.h: Don't include config.h.
1522
1523 2019-05-04  Tom Tromey  <tom@tromey.com>
1524
1525         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1526         (struct aarch64_call_info): Add initializers.
1527         <si>: Now a std::vector.
1528         (pass_on_stack, aarch64_push_dummy_call): Update.
1529
1530 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1531             Tom Tromey  <tom@tromey.com>
1532
1533         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1534         (ppc_threads): Now a std::vector.  Now static.
1535         (hwdebug_find_thread_points_by_tid)
1536         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1537         Update.
1538
1539 2019-05-04  Tom Tromey  <tom@tromey.com>
1540
1541         * arc-tdep.c (arc_tdesc_init): Return bool.
1542
1543 2019-05-04  Tom Tromey  <tom@tromey.com>
1544
1545         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1546         Use gdb_assert_not_reached.
1547
1548 2019-05-04  Tom Tromey  <tom@tromey.com>
1549
1550         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1551         "false".
1552
1553 2019-05-04  Tom Tromey  <tom@tromey.com>
1554
1555         * arc-tdep.c (arc_tdesc_init): Use bool.
1556
1557 2019-05-04  Tom Tromey  <tom@tromey.com>
1558
1559         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1560
1561 2019-05-04  Tom Tromey  <tom@tromey.com>
1562
1563         * cli/cli-cmds.c (valid_command_p): Return bool.
1564
1565 2019-05-04  Tom Tromey  <tom@tromey.com>
1566
1567         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1568         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1569
1570 2019-05-04  Raul Tambre  <raul@tambre.ee>
1571
1572         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1573         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1574         operator for comparison.
1575
1576 2019-05-04  Tom Tromey  <tom@tromey.com>
1577
1578         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1579         (lookup_partial_symbol, print_partial_symbols)
1580         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1581         (psymbol_compare): Update.
1582         (add_psymbol_to_bcache): Clear the entire psymbol.
1583         (maintenance_check_psymtabs): Update.
1584         * psympriv.h (struct partial_symbol): Don't derive from
1585         general_symbol_info.
1586         <obj_section, unrelocated_address, address,
1587         set_unrelocated_address>: Update.
1588         <ginfo>: New member.
1589         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1590         (debug_names::write_psymbols): Update.
1591
1592 2019-05-04  Tom de Vries  <tdevries@suse.de>
1593
1594         * contrib/cc-with-tweaks.sh: Support -n arg.
1595
1596 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1597
1598         * corelow.c (core_target::detach): Ensure frame cache and
1599         register caches are cleared.
1600         inferior.c (exit_inferior_1): Likewise.
1601
1602 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1603             Tom Tromey  <tom@tromey.com>
1604
1605         * dictionary.c (collate_pending_symbols_by_language): Remove
1606         "struct" from foreach.
1607         * symtab.c (lookup_global_symbol_from_objfile)
1608         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1609         foreach.
1610         * ser-tcp.c (net_open): Remove "struct" from foreach.
1611         * objfiles.c (objfile_relocate, objfile_rebase)
1612         (objfile_has_symbols): Remove "struct" from foreach.
1613         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1614         from foreach.
1615         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1616         foreach.
1617         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1618         "struct" from foreach.
1619         * ada-lang.c (create_excep_cond_exprs)
1620         (ada_exception_catchpoint_cond_string): Remove "struct" from
1621         foreach.
1622
1623 2019-05-03  Tom Tromey  <tromey@adacore.com>
1624
1625         * ada-exp.y (convert_char_literal): Check suffix of each
1626         enumerator.
1627
1628 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1629
1630         PR ada/21406:
1631         * ada-exp.y (yywrap): Don't define.
1632         * ada-lex.l (%option): Add noyywrap
1633         (yywrap): Remove.
1634
1635 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1636
1637         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1638         _WIN32_WINNT to the XP level, unless already defined to a higher
1639         level.
1640
1641         * unittests/parse-connection-spec-selftests.c:
1642         * ser-tcp.c:
1643         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1644         override.
1645
1646         * symfile.c (find_separate_debug_file): Remove colon from the
1647         drive spec of DOS/Windows file names of the target, so that the
1648         file name produced from DEBUGDIR and the target's directory will
1649         be valid on DOS/Windows systems.
1650
1651 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * rust-lang.c (val_print_struct): Handle printing structures
1654         containing strings.
1655
1656 2019-05-02  Tom Tromey  <tromey@adacore.com>
1657
1658         * valarith.c (_initialize_valarith): Remove.
1659
1660 2019-05-01  Tom Tromey  <tromey@adacore.com>
1661
1662         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1663         bitfields.
1664
1665 2019-05-01  Tom Tromey  <tromey@adacore.com>
1666
1667         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1668         for big-endian copies.
1669
1670 2019-04-30  Ali Tamur  <tamur@google.com>
1671         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1672         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1673         (read_3_bytes): New function.
1674
1675 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1676
1677         * windows-nat.c (main_thread_id): Delete.
1678         (handle_output_debug_string): Replace main_thread_id by
1679         current_event.dwThreadId.
1680         (fake_create_process): Likewise.
1681         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1682         Do not set main_thread_id.
1683         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1684         current_event.dwThreadId.
1685         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1686
1687 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1688
1689         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1690         Use current_event.dwThreadId instead of main_thread_id.
1691
1692 2019-04-30  Tom Tromey  <tromey@adacore.com>
1693
1694         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1695         (create_excep_cond_exprs): Iterate over program spaces.
1696         (ada_exception_catchpoint_cond_string): Examine all minimal
1697         symbols for exception types.
1698
1699 2019-04-30  Tom Tromey  <tromey@adacore.com>
1700
1701         PR c++/24470:
1702         * dwarf2read.c (process_structure_scope): Handle case where type
1703         has template parameters but no symbol was created.
1704
1705 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1706             Chris January  <chris.january@arm.com>
1707
1708         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1709         qualifier.
1710         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1711
1712 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1713
1714         * f-typeprint.c (f_print_type): Update rules for printing
1715         whitespace.
1716         (f_type_print_varspec_suffix): Likewise.
1717
1718 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1719             Chris January  <chris.january@arm.com>
1720
1721         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1722         function arguments.
1723
1724 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * f-lang.c (build_fortran_types): Change name of void type to
1727         lower case.
1728         * f-typeprint.c (f_type_print_base): Print the name of the void
1729         type, rather than a fixed string.
1730         * f-valprint.c (f_decorations): Use lower case void string.
1731
1732 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1733             Chris January  <chris.january@arm.com>
1734
1735         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1736         types for Fortran.
1737
1738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1739             Chris January  <chris.january@arm.com>
1740             David Lecomber  <david.lecomber@arm.com>
1741
1742         * f-exp.y (BINOP_INTRINSIC): New token.
1743         (exp): New parser rule handling BINOP_INTRINSIC.
1744         (f77_keywords): Add new builtin procedures.
1745         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1746         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1747         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1748         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1749         (print_unop_subexp_f): New function.
1750         (print_binop_subexp_f): New function.
1751         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1752         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1753         (dump_subexp_body_f): Likewise.
1754         (operator_check_f): Likewise.
1755         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1756         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1757
1758 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1761         UNOP_KIND.
1762         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1763         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1764         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1765         (operator_length_f): New fuction.
1766         (print_subexp_f): New function.
1767         (op_name_f): New function.
1768         (dump_subexp_body_f): New function.
1769         (operator_check_f): New function.
1770         (exp_descriptor_f): Replace standard expression handling functions
1771         with new functions.
1772         * gdb/fortran-operator.def: New file.
1773         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1774         * gdb/std-operator.def: Remove UNOP_KIND.
1775
1776 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * std-operator.def: Remove unbalanced, stray double quote
1779         character.
1780
1781 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1782             Chris January  <chris.january@arm.com>
1783             Daniel Everett  <daniel.everett@arm.com>
1784             Nick Forrington  <nick.forrington@arm.com>
1785             Richard Bunt  <richard.bunt@arm.com>
1786
1787         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1788         of depth when printing anonymous structs or unions.
1789         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1790         Don't print either the top-level value, or the children if the
1791         max-depth is exceeded.
1792         (ppscm_print_children): When printing the key of a map, allow one
1793         extra level of depth.
1794         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1795         print either the top-level value, or the children if the max-depth
1796         is exceeded.
1797         (print_children): When printing the key of a map, allow one extra
1798         level of depth.
1799         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1800         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1801         (user_print_options): Initialise max_depth field.
1802         (val_print_scalar_or_string_type_p): New function.
1803         (val_print): Check to see if the max depth has been reached.
1804         (val_print_check_max_depth): Define new function.
1805         (show_print_max_depth): New function.
1806         (_initialize_valprint): Add 'print max-depth' option.
1807         * valprint.h (struct value_print_options) <max_depth>: New field.
1808         (val_print_check_max_depth): Declare new function.
1809         * NEWS: Document new feature.
1810
1811 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * ada-lang.c (ada_language_defn): Initialise new field.
1814         * c-lang.c (c_is_string_type_p): New function.
1815         (c_language_defn): Initialise new field.
1816         (cplus_language_defn): Initialise new field.
1817         (asm_language_defn): Initialise new field.
1818         (minimal_language_defn): Initialise new field.
1819         * c-lang.h (c_is_string_type_p): Declare new function.
1820         * d-lang.c (d_language_defn): Initialise new field.
1821         * f-lang.c (f_is_string_type_p): New function.
1822         (f_language_defn): Initialise new field.
1823         * go-lang.c (go_is_string_type_p): New function.
1824         (go_language_defn): Initialise new field.
1825         * language.c (default_is_string_type_p): New function.
1826         (unknown_language_defn): Initialise new field.
1827         (auto_language_defn): Initialise new field.
1828         * language.h (struct language_defn) <la_is_string_type_p>: New
1829         member variable.
1830         (default_is_string_type_p): Declare new function.
1831         * m2-lang.c (m2_language_defn): Initialise new field.
1832         * objc-lang.c (objc_language_defn): Initialise new field.
1833         * opencl-lang.c (opencl_language_defn): Initialise new field.
1834         * p-lang.c (pascal_is_string_type_p): New function.
1835         (pascal_language_defn): Initialise new field.
1836         * rust-lang.c (rust_is_string_type_p): New function.
1837         (rust_language_defn): Initialise new field.
1838
1839 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1840
1841         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1842         New field.
1843         * ada-lang.c (ada_language_defn): Initialise new field.
1844         * c-lang.c (c_language_defn): Likewise.
1845         (cplus_language_defn): Likewise.
1846         (asm_language_defn): Likewise.
1847         (minimal_language_defn): Likewise.
1848         * d-lang.c (d_language_defn): Likewise.
1849         * f-lang.c (f_language_defn): Likewise.
1850         * go-lang.c (go_language_defn): Likewise.
1851         * language.c (unknown_language_defn): Likewise.
1852         (auto_language_defn): Likewise.
1853         * m2-lang.c (m2_language_defn): Likewise.
1854         * objc-lang.c (objc_language_defn): Likewise.
1855         * opencl-lang.c (opencl_language_defn): Likewise.
1856         * p-lang.c (pascal_language_defn): Likewise.
1857         * rust-lang.c (rust_language_defn): Likewise.
1858
1859 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1860
1861         * ada-lang.c (ada_is_character_type): Change return type to bool.
1862         (ada_is_string_type): Likewise.
1863         * ada-lang.h (ada_is_character_type): Update declaration
1864         (ada_is_string_type): Likewise.
1865
1866 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1867
1868         Support style in 'frame|thread apply'
1869
1870         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1871         * record.c (record_start, record_stop): Update callers of
1872         execute_command_to_string with false.
1873         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1874         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1875         methods.
1876         (class string_file): New constructor with term_out parameter.
1877         Override methods term_out and can_emit_style_escape.  New member
1878         term_out.
1879         (class stdio_file): Override can_emit_style_escape.
1880         (class tee_file): Override term_out and can_emit_style_escape.
1881         * utils.h (can_emit_style_escape): Remove.
1882         * utils.c (can_emit_style_escape): Likewise.
1883         Update all callers of can_emit_style_escape (SOMESTREAM) to
1884         SOMESTREAM->can_emit_style_escape.
1885         * source-cache.c (source_cache::get_source_lines): Likewise.
1886         * stack.c (frame_apply_command_count): Call execute_command_to_string
1887         passing the term_out characteristic of the current gdb_stdout.
1888         * thread.c (thr_try_catch_cmd): Likewise.
1889         * top.c (execute_command_to_string): pass term_out parameter
1890         to construct the string_file for the command output.
1891         * ui-file.c (term_cli_styling): New function (most code moved
1892         from utils.c can_emit_style_escape).
1893         (string_file::string_file, string_file::can_emit_style_escape,
1894         stdio_file::can_emit_style_escape, tee_file::term_out,
1895         tee_file::can_emit_style_escape): New functions.
1896
1897 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1898
1899         * NEWS: Mention the new set|show may-call-functions.
1900         * infcall.c (may_call_functions_p): New variable.
1901         (show_may_call_functions_p): New function.
1902         (call_function_by_hand_dummy): Throws an error if not
1903         may-call-functions.
1904         (_initialize_infcall): Call add_setshow_boolean_cmd for
1905         may-call-functions.
1906
1907 2019-04-25  Keith Seitz  <keiths@redhat.com>
1908
1909         PR c++/24367
1910         * cp-support.c (inspect_type): Don't attempt substitutions
1911         of symbol with the same name.
1912
1913 2019-04-25  Tom Tromey  <tromey@adacore.com>
1914
1915         PR gdb/24475:
1916         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1917         static.
1918
1919 2019-04-25  Tom Tromey  <tromey@adacore.com>
1920
1921         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1922         rvalue reference.
1923         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1924         (gdb_xml_parser::parse): Use std::move.
1925         * python/python-internal.h (gdbpy_convert_exception): Take a const
1926         reference.
1927         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1928         std::move.
1929         * python/py-utils.c (gdbpy_convert_exception): Take a const
1930         reference.
1931         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1932         Use std::move.
1933         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1934         Use std::move.
1935         * mi/mi-main.c (mi_print_exception): Take a const reference.
1936         * main.c (handle_command_errors): Take a const reference.
1937         * linespec.c (parse_linespec): Use std::move.
1938         * infcall.c (run_inferior_call): Use std::move.
1939         (call_function_by_hand_dummy): Use std::move.
1940         * exec.c (try_open_exec_file): Use std::move.
1941         * exceptions.h (exception_print, exception_fprintf)
1942         (exception_print_same): Update.
1943         * exceptions.c (print_exception, exception_print)
1944         (exception_fprintf, exception_print_same): Change parameters to
1945         const reference.
1946         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1947         * common/new-op.c: Use std::move.
1948         * common/common-exceptions.h (struct gdb_exception): Add move
1949         constructor.
1950         (struct gdb_exception_error, struct gdb_exception_quit, struct
1951         gdb_quit_bad_alloc): Change constructor to move constructor.
1952         (throw_exception): Change parameter to rvalue reference.
1953         * common/common-exceptions.c (throw_exception): Take rvalue
1954         reference.
1955         * cli/cli-interp.c (safe_execute_command): Use std::move.
1956         * breakpoint.c (insert_bp_location, location_to_sals): Use
1957         std::move.
1958
1959 2019-04-25  Tom Tromey  <tromey@adacore.com>
1960
1961         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1962         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1963         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1964         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1965         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1966         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1967         guile/scm-value.c: Use unpack.
1968         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1969         gdbscm_gdb_exception.
1970         (gdbscm_throw_gdb_exception): Likewise.
1971         (struct gdbscm_gdb_exception): New.
1972         (unpack): New function.
1973         (gdbscm_wrap): Use unpack.
1974
1975 2019-04-25  Tom Tromey  <tromey@adacore.com>
1976
1977         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1978         (gdb_rl_callback_handler): Use std::move.
1979         * common/common-exceptions.h (struct gdb_exception): Add move
1980         assignment operator.
1981         (throw_exception_sjlj): Change "exception" to const reference.
1982         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1983         (throw_exception_sjlj): Change "exception" to const reference.
1984
1985 2019-04-25  Tom Tromey  <tromey@adacore.com>
1986
1987         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1988         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1989         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1990         Update.
1991         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1992         Update.
1993         * mi/mi-interp.c (mi_interp::exec): Update.
1994         * linespec.c (parse_linespec): Update.
1995         * infcall.c (run_inferior_call): Update.
1996         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1997         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1998         (gdbscm_lookup_global_symbol): Update.
1999         * guile/scm-param.c (gdbscm_parameter_value): Update.
2000         * guile/scm-frame.c (gdbscm_frame_read_register)
2001         (gdbscm_frame_read_var): Update.
2002         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2003         * exec.c (try_open_exec_file): Update.
2004         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2005         (gdb_rl_callback_handler): Update.
2006         * common/common-exceptions.h (exception_none): Don't declare.
2007         * common/common-exceptions.c (exception_none): Don't define.
2008         (struct catcher) <exception>: Update.
2009         * cli/cli-interp.c (safe_execute_command): Update.
2010         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2011
2012 2019-04-25  Ali Tamur  <tamur@google.com>
2013
2014         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2015         (read_attribute_value): Likewise.
2016         (dwarf2_read_addr_index): Update comment.
2017         (read_str_index): Add DW_FORM_strx.
2018         (dwarf2_string_attr): Likewise.
2019         (dwarf2_const_value_attr): Likewise.
2020         (dump_die_shallow): Likewise.
2021         (dwarf2_fetch_constant_bytes): Likewise.
2022         (skip_form_bytes): Likewise.
2023         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2024
2025 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2026
2027         PR corefiles/11608
2028         PR corefiles/18187
2029         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2030         OFFSET.  Verify if current mapping contains an ELF header.
2031         (linux_find_memory_regions_full): Adjust call to
2032         dump_mapping_p.
2033
2034 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2035             Kang Li <kanglictf@gmail.com>
2036
2037         PR gdb/21600
2038
2039         * dwarf2-frame.c (read_initial_length): Be consistent about using
2040         unsigned representation of length.
2041         (decode_frame_entry_1): Likewise.  Check for wraparound of
2042         end pointer as well as buffer overflow.
2043
2044 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2045
2046         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2047         "vq".
2048
2049 2019-04-24  Tom Tromey  <tromey@adacore.com>
2050
2051         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2052
2053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2054
2055         * s12z-tdep.c (s12z_unwind_pc): Delete.
2056         (s12z_unwind_sp): Delete.
2057         (s12z_gdbarch_init): Don't register deleted functions with
2058         gdbarch.
2059
2060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * rl78-tdep.c (rl78_unwind_sp): Delete.
2063         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2064
2065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2066
2067         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2068         (xstormy16_unwind_pc): Delete.
2069         (xstormy16_dummy_id): Delete.
2070         (xstormy16_gdbarch_init): Don't register deleted functions with
2071         gdbarch.
2072
2073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2074
2075         * vax-tdep.c (vax_unwind_pc): Delete.
2076         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2077
2078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * v850-tdep.c (v850_unwind_sp): Delete.
2081         (v850_unwind_pc): Delete.
2082         (v850_dummy_id): Delete.
2083         (v850_gdbarch_init): Don't register deleted functions with
2084         gdbarch.
2085
2086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2087
2088         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2089         (tilegx_unwind_pc): Delete.
2090         (tilegx_unwind_dummy_id): Delete.
2091         (tilegx_gdbarch_init): Don't register deleted functions with
2092         gdbarch.
2093
2094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2097         (tic6x_dummy_id): Delete.
2098         (tic6x_gdbarch_init): Don't register deleted functions with
2099         gdbarch.
2100
2101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * sparc-tdep.c (sparc_unwind_pc): Delete.
2104         (sparc32_gdbarch_init): Don't register deleted function with
2105         gdbarch.
2106
2107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2108
2109         * sh-tdep.c (sh_unwind_sp): Delete.
2110         (sh_unwind_pc): Delete.
2111         (sh_dummy_id): Delete.
2112         (sh_gdbarch_init): Don't register deleted functions with
2113         gdbarch.
2114
2115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * score-tdep.c (score_unwind_sp): Delete.
2118         (score_unwind_pc): Delete.
2119         (score_dummy_id): Delete.
2120         (score_gdbarch_init): Don't register deleted functions with
2121         gdbarch.
2122
2123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * rx-tdep.c (rx_unwind_pc): Delete.
2126         (rx_unwind_sp): Delete.
2127         (rx_dummy_id): Delete.
2128         (rx_gdbarch_init): Don't register deleted functions with
2129         gdbarch.  Update comment.
2130
2131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2132
2133         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2134         (rs6000_dummy_id): Delete.
2135         (rs6000_gdbarch_init): Don't register deleted functions with
2136         gdbarch.
2137
2138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * or1k-tdep.c (or1k_dummy_id): Delete.
2141         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2142
2143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * nios2-tdep.c (nios2_dummy_id): Delete.
2146         (nios2_unwind_sp): Delete.
2147         (nios2_gdbarch_init): Don't register deleted functions with
2148         gdbarch.
2149
2150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * nds32-tdep.c (nds32_dummy_id): Delete.
2153         (nds32_unwind_pc): Delete.
2154         (nds32_unwind_sp): Delete.
2155         (nds32_gdbarch_init): Don't register deleted functions with
2156         gdbarch.
2157
2158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * msp430-tdep.c (msp430_unwind_pc): Delete.
2161         (msp430_unwind_sp): Delete.
2162         (msp430_dummy_id): Delete.
2163         (msp430_gdbarch_init): Don't register deleted functions with
2164         gdbarch.
2165
2166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * moxie-tdep.c (moxie_unwind_sp): Delete.
2169         (moxie_unwind_pc): Delete.
2170         (moxie_dummy_id): Delete.
2171         (moxie_gdbarch_init): Don't register deleted functions with
2172         gdbarch.
2173
2174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2177         (mn10300_unwind_pc): Delete.
2178         (mn10300_unwind_sp): Delete.
2179         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2180         mn10300_unwind_sp.
2181         (mn10300_frame_unwind_init): Don't register deleted functions with
2182         gdbarch.
2183
2184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * mep-tdep.c (mep_unwind_pc): Delete.
2187         (mep_unwind_sp): Delete.
2188         (mep_dummy_id): Delete.
2189         (mep_gdbarch_init): Don't register deleted functions with
2190         gdbarch.
2191
2192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2195         (m68hc11_unwind_sp): Delete.
2196         (m68hc11_gdbarch_init): Don't register deleted functions with
2197         gdbarch.
2198
2199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * m32r-tdep.c (m32r_unwind_sp): Delete.
2202         (m32r_unwind_pc): Delete.
2203         (m32r_dummy_id): Delete.
2204         (m32r_gdbarch_init): Don't register deleted functions with
2205         gdbarch.
2206
2207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * m32c-tdep.c (m32c_unwind_pc): Delete.
2210         (m32c_unwind_sp): Delete.
2211         (m32c_dummy_id): Delete.
2212         (m32c_gdbarch_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2218         (lm32_unwind_pc): Delete.
2219         (lm32_dummy_id): Delete.
2220         (lm32_gdbarch_init): Don't register deleted functions with
2221         gdbarch.
2222
2223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2226         (iq2000_unwind_pc): Delete.
2227         (iq2000_dummy_id): Delete.
2228         (iq2000_gdbarch_init): Don't register deleted functions with
2229         gdbarch.
2230
2231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * nds32-tdep.c (nds32_type_align): Delete.
2234         (nds32_push_dummy_call): Use type_align instead.
2235
2236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * arm-tdep.c (arm_type_align): Only handle vector override case.
2239         (arm_push_dummy_call): Use type_align.
2240         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2241
2242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2245         case.
2246         (pass_on_stack): Use type_align.
2247         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2248         function.
2249
2250 2019-04-23  Tom Tromey  <tromey@adacore.com>
2251
2252         * dwarf2read.c (line_header::file_name_at): Remove unused
2253         overload.
2254
2255 2019-04-23  Tom de Vries  <tdevries@suse.de>
2256
2257         PR gdb/24438
2258         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2259         invocation.
2260
2261
2262 2019-03-27  Ali Tamur  <tamur@google.com>
2263
2264         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2265         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2266         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2267         (dwarf_expr_context::get_addr_index): Likewise
2268         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2269         (symbol_needs_eval_context::get_addr_index): Likewise
2270         (disassemble_dwarf_expression): Add DW_OP_addrx
2271         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2272         (read_cutu_die_from_dwo): Update comment
2273         (skip_one_die): Add DW_FORM_addrx
2274         (read_attribute_value): Likewise
2275         (var_decode_location): Add DW_OP_addrx
2276         (dwarf2_const_value_attr): Add DW_FORM_addrx
2277         (dump_die_shallow): Likewise
2278         (dwarf2_fetch_constant_bytes): Likewise
2279         (decode_locdesc): Add DW_OP_addrx
2280         (skip_form_bytes): Add DW_FORM_addrx
2281
2282 2019-04-22  Ali Tamur  <tamur@google.com>
2283
2284         * MAINTAINERS (Write After Approval): Add self.
2285
2286 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2287
2288         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2289         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2290         (open_symbol_file_object): Likewise.
2291         (svr4_default_sos): Add info parameter.
2292         (svr4_read_so_list): Likewise.
2293         (svr4_current_sos_direct): Adjust functions calls to pass down
2294         info.
2295         (svr4_current_sos_1): Add info parameter.
2296         (svr4_current_sos): Call get_svr4_info, pass info down to
2297         svr4_current_sos_1.
2298         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2299         get_svr4_info.
2300         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2301         get_svr4_info.
2302         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2303         to get_svr4_info.
2304         (probes_table_remove_objfile_probes): Likewise.
2305         (register_solib_event_probe): Add info parameter.
2306         (solist_update_incremental): Pass info parameter down to
2307         svr4_read_so_list.
2308         (disable_probes_interface): Add info parameter.
2309         (svr4_handle_solib_event): Pass current_program_space to
2310         get_svr4_info.  Adjust disable_probes_interface cleanup.
2311         (svr4_create_probe_breakpoints): Add info parameter, pass it
2312         down to register_solib_event_probe.
2313         (svr4_create_solib_event_breakpoints): Add info parameter,
2314         pass it down to svr4_create_probe_breakpoints.
2315         (enable_break): Pass info down to
2316         svr4_create_solib_event_breakpoints.
2317         (svr4_solib_create_inferior_hook): Pass current_program_space to
2318         get_svr4_info.
2319         (svr4_clear_solib): Likewise.
2320
2321 2019-04-22  Pedro Alves  <palves@redhat.com>
2322
2323         * solib-svr4.c (svr4_free_objfile_observer): New.
2324         (probe_and_action::objfile): New field.
2325         (probes_table_htab_remove_objfile_probes)
2326         (probes_table_remove_objfile_probes): New functions.
2327         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2328         in the new probe_and_action.  Don't store the probe in 'lookup'.
2329         (svr4_create_probe_breakpoints): Pass objfile to
2330         register_solib_event_probe.
2331         (_initialize_svr4_solib): Register a free_objfile observer.
2332
2333 2019-04-19  Tom Tromey  <tom@tromey.com>
2334
2335         * common/queue.h: Remove.
2336
2337 2019-04-19  Tom Tromey  <tom@tromey.com>
2338
2339         * event-loop.c: Don't include "common/queue.h".
2340
2341 2019-04-19  Tom Tromey  <tom@tromey.com>
2342
2343         * remote.c (remote_target): Use delete.
2344         * remote-notif.h: Include <list>, not "common/queue.h".
2345         (notif_client_p): Remove typedef.
2346         (remote_notif_state): Add constructor, destructor, initializer.
2347         <notif_queue>: Now a std::list.
2348         (remote_notif_state_xfree): Don't declare.
2349         * remote-notif.c (remote_notif_process, handle_notification)
2350         (remote_notif_state_allocate): Update.
2351         (~remote_notif_state): Rename from remote_notif_state_xfree.
2352
2353 2019-04-19  Tom Tromey  <tom@tromey.com>
2354
2355         * symfile.c (reread_symbols): Update.
2356         * objfiles.c (objfile_register_static_link)
2357         (objfile_lookup_static_link): Update
2358         (~objfile) Don't delete static_links.
2359         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2360
2361 2019-04-19  Tom Tromey  <tom@tromey.com>
2362
2363         * type-stack.h (struct type_stack) <insert>: Constify string.
2364         * type-stack.c (type_stack::insert): Constify string.
2365         * gdbtypes.h (lookup_template_type): Update.
2366         (address_space_name_to_int): Update.
2367         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2368         const.
2369         (lookup_template_type): Make name const.
2370         * c-exp.y: Update rules.
2371         (lex_one_token, classify_name, classify_inner_name)
2372         (c_print_token): Update.
2373         * p-exp.y: Update rules.
2374         (yylex): Update.
2375         * f-exp.y: Update rules.
2376         (yylex): Update.
2377         * d-exp.y: Update rules.
2378         (lex_one_token, classify_name, classify_inner_name): Update.
2379         * parse.c (write_dollar_variable, copy_name): Return std::string.
2380         * parser-defs.h (copy_name): Change return type.
2381         * m2-exp.y: Update rules.
2382         (yylex): Update.
2383         * go-exp.y (lex_one_token): Update.
2384         Update rules.
2385         (classify_unsafe_function, classify_packaged_name)
2386         (classify_name, yylex): Update.
2387
2388 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2389
2390         * configure.ac: add --enable-source-highlight switch.
2391         * configure: Regenerate.
2392         * top.c (print_gdb_version): plumb --enable-source-highlight
2393         status to "show configuration".
2394
2395 2019-04-19  Tom Tromey  <tromey@adacore.com>
2396
2397         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2398         Check ADA_TYPE_P.
2399         (empty_record, ada_template_to_fixed_record_type_1)
2400         (template_to_static_fixed_type)
2401         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2402         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2403         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2404         macros.
2405
2406 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2407
2408         PR symtab/24423:
2409         * source.c (print_source_lines_base): Advance "iter" when a
2410         control character is seen.
2411
2412 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2413
2414         * inferior.h (struct infcall_suspend_state_deleter):
2415         Catch exception in destructor to avoid crash.
2416
2417 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2418
2419         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2420         close to the add_com "shell".
2421
2422 2019-04-18  Tom Tromey  <tromey@adacore.com>
2423
2424         * process-stratum-target.h (class process_stratum_target)
2425         <stratum>: Add "final".
2426
2427 2019-04-17  Tom Tromey  <tromey@adacore.com>
2428
2429         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2430         against nullptr before use.
2431
2432 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2433
2434         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2435
2436 2019-04-17  Jim Wilson  <jimw@sifive.com>
2437             Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2440         code read might fail, assume 4-byte breakpoint in that case.
2441
2442 2019-04-15  Leszek Swirski  <leszeks@google.com>
2443
2444         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2445         rather than a hand-rolled POD check when checking for forced MEMORY
2446         classification.
2447
2448 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2449
2450         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2451         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2452         function.
2453         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2454         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2455         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2456         declaration.
2457
2458 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2459
2460         * aarch64-linux-nat.c
2461         (aarch64_linux_nat_target::thread_architecture): Add override.
2462         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2463         each VQ.
2464
2465 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2468
2469 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2472         target types of size 96-bits, add some additional comments, and
2473         check that the builtin type we found was the correct size.
2474
2475 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2476
2477         * utils.c (prompt_for_continue): Don't restore the styling at the
2478         end, as applied_style has the wrong value.  This fixes styling in
2479         long lists of file names that are interrupted by the "Continue?"
2480         prompt.
2481
2482 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2483
2484         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2485         * c-lang.c (c_language_defn): Likewise.
2486         (cplus_language_defn): Likewise.
2487         (asm_language_defn): Likewise.
2488         (minimal_language_defn): Likewise.
2489         * d-lang.c (d_language_defn): Likewise.
2490         * f-lang.c (f_language_defn): Likewise.
2491         * go-lang.c (go_language_defn): Likewise.
2492         * language.c (unknown_language_defn): Likewise.
2493         (auto_language_defn): Likewise.
2494         * language.h (struct language_defn): Remove la_magic field.
2495         (LANG_MAGIC): Delete.
2496         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2497         * objc-lang.c (objc_language_defn): Likewise.
2498         * opencl-lang.c (opencl_language_defn): Likewise.
2499         * p-lang.c (pascal_language_defn): Likewise.
2500         * rust-lang.c (rust_language_defn): Likewise.
2501
2502 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * riscv-tdep.c (riscv_type_align): New function.
2505         (riscv_type_alignment): Delete.
2506         (riscv_arg_location): Use 'type_align'.
2507         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2508
2509 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * gdbtypes.c (type_align): A struct with no non-static fields also
2512         has alignment of 1.
2513
2514 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2517         component to 0.
2518         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2519         member.
2520         (riscv_struct_info::analyse): New implementation using new
2521         analyse_inner member function.
2522         (riscv_struct_info::field_offset): New member function.
2523         (riscv_struct_info::m_offsets): New member variable.
2524         (riscv_struct_info::analyse_inner): New private member function,
2525         takes the old implementation of riscv_struct_info::analyse but
2526         extended to track field offsets.
2527         (riscv_call_arg_struct): Update the struct folding special cases
2528         to handle cases where empty C++ structs, which are non-zero
2529         length, are found.
2530         (riscv_arg_location): Initialise the length of each location, a
2531         non-zero length now indicates the location is in use.
2532         (riscv_push_dummy_call): Allow for the first location having a
2533         non-zero offset when setting up arguments.
2534         (riscv_return_value): Likewise, but for return values.
2535
2536 2019-04-11  Tom Tromey  <tromey@adacore.com>
2537
2538         * utils.c (internal_vproblem): Make "msg" const.
2539
2540 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2541
2542         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2543         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2544         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2545         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2546
2547 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2548
2549         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2550         function.
2551         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2552         of amd64_collect_native_gregset.
2553         (amd64_linux_nat_target::store_registers): Likewise.
2554
2555 2019-04-10  Tom Tromey  <tom@tromey.com>
2556
2557         * symtab.c (lookup_global_symbol_from_objfile)
2558         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2559         * objfiles.h (class separate_debug_iterator): New.
2560         (class separate_debug_range): New.
2561         (struct objfile) <separate_debug_objfiles>: New method.
2562         (objfile_separate_debug_iterate): Don't declare.
2563         * objfiles.c (separate_debug_iterator::operator++): Rename from
2564         objfile_separate_debug_iterate.
2565         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2566         iterator.
2567         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2568         iterator.
2569
2570 2019-04-10  Tom Tromey  <tom@tromey.com>
2571
2572         * symfile.c (reread_symbols): Remove old comment.
2573         * objfiles.c (free_all_objfiles): Fix a typo.
2574
2575 2019-04-10  Tom Tromey  <tom@tromey.com>
2576
2577         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2578         * minsyms.c (lookup_minimal_symbol): Use foreach.
2579         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2580         (lookup_minimal_symbol_solib_trampoline): Likewise.
2581         * symfile.c (reread_symbols): Use foreach.
2582
2583 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2584             Tom Tromey  <tromey@adacore.com>
2585
2586         PR rust/24414:
2587         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2588         (rust_lex_int_test): Change "value" to be LONGEST.
2589         (rust_lex_tests): Add test for long integer literal.
2590
2591 2019-04-09  Tom Tromey  <tromey@adacore.com>
2592
2593         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2594         to bool.
2595         (extended_remote_target::attach): Update.
2596         (remote_target::remote_notice_new_inferior): Update.
2597         (remote_target::add_current_inferior_and_thread): Update.
2598         * inferior.c (exit_inferior_1): Use "false".
2599         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2600
2601 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2602
2603         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2604         the "start" command.
2605
2606 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2607
2608         * python/py-inferior.c (infpy_thread_from_thread_handle):
2609         Adjust comments to reflect renaming of thread_from_thread_handle
2610         to thread_from_handle.  Adjust keywords.  Fix type error message.
2611         (inferior_object_methods): Add thread_from_handle.  Retain
2612         thread_from_thread_handle, but mark it as deprecated.
2613
2614 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2615
2616         * gdbthread.h (find_thread_by_handle): Revise declaration.
2617         * thread.c (find_thread_by_handle): Likewise.  Adjust
2618         implementation too.
2619         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2620         support for buffer objects as handles.
2621
2622 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2623
2624         * python/py-infthread.c (thpy_thread_handle): New function.
2625         (thread_object_methods): Register thpy_thread_handle.
2626
2627 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2628
2629         * gdbthread.h (thread_to_thread_handle): Declare.
2630         * thread.c (gdbtypes.h): Include.
2631         (thread_to_thread_handle): New function.
2632
2633         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2634         (target_thread_info_to_thread_handle): Declare.
2635         * target.c (target_thread_info_to_thread_handle): New function.
2636         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2637         * target-delegates.c: Regenerate.
2638
2639         * linux-thread-db.c (class thread_db_target): Add method
2640         thread_info_to_thread_handle.
2641         (thread_db_target::thread_info_to_thread_handle): Define.
2642         * remote.c (class remote_target): Add new method
2643         thread_info_to_thread_handle.
2644         (remote_target::thread_info_to_thread_handle): Define.
2645
2646 2019-04-08  Pedro Alves  <palves@redhat.com>
2647
2648         * common/common-exceptions.c (throw_exception): Don't create
2649         named object to throw; throw directly.
2650         (throw_it): Likewise.  Don't initialize gdb_exception::message
2651         here, with new; pass FMT and AP to the ctor instead.
2652         * common/common-exceptions.h: Include <string>.
2653         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2654         const char *, va_list)): New ctor.  Use std::make_shared.
2655         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2656         errors)): Delete.
2657         (gdb_exception_error::gdb_exception_error(enum errors, const char
2658         *, va_list)): New.
2659         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2660         Add assertion.
2661         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2662         errors)): Delete.
2663         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2664         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2665         Add assertion.
2666
2667 2019-04-08  Tom Tromey  <tom@tromey.com>
2668
2669         * valops.c (value_rtti_indirect_type): Replace throw_exception
2670         with throw.
2671         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2672         with throw.
2673         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2674         throw.
2675         * target.c (target_translate_tls_address): Replace throw_exception
2676         with throw.
2677         * stack.c (frame_apply_command_count): Replace throw_exception
2678         with throw.
2679         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2680         throw.
2681         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2682         with throw.
2683         * rs6000-tdep.c (rs6000_frame_cache)
2684         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2685         * remote.c: Replace throw_exception with throw.
2686         * record-full.c (record_full_message, record_full_wait_1)
2687         (record_full_restore): Replace throw_exception with throw.
2688         * record-btrace.c:
2689         (get_thread_current_frame_id, record_btrace_start_replaying)
2690         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2691         (cmd_record_btrace_start): Replace throw_exception with throw.
2692         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2693         throw.
2694         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2695         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2696         * linespec.c:
2697         (find_linespec_symbols): Replace throw_exception with throw.
2698         * infrun.c (displaced_step_prepare, resume): Replace
2699         throw_exception with throw.
2700         * infcmd.c (post_create_inferior): Replace throw_exception with
2701         throw.
2702         * inf-loop.c (inferior_event_handler): Replace throw_exception
2703         with throw.
2704         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2705         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2706         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2707         (get_prev_frame_always, get_frame_pc_if_available)
2708         (get_frame_address_in_block_if_available, get_frame_language):
2709         Replace throw_exception with throw.
2710         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2711         throw_exception with throw.
2712         * eval.c (fetch_subexp_value, evaluate_var_value)
2713         (evaluate_funcall, evaluate_subexp_standard): Replace
2714         throw_exception with throw.
2715         * dwarf2loc.c (call_site_find_chain)
2716         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2717         Replace throw_exception with throw.
2718         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2719         with throw.
2720         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2721         throw.
2722         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2723         * completer.c (complete_line_internal): Replace throw_exception
2724         with throw.
2725         * compile/compile-object-run.c (compile_object_run): Replace
2726         throw_exception with throw.
2727         * cli/cli-script.c (process_next_line): Replace throw_exception
2728         with throw.
2729         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2730         (btrace_enable, btrace_maint_update_pt_packets): Replace
2731         throw_exception with throw.
2732         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2733         throw_exception with throw.
2734         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2735         throw_exception with throw.
2736         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2737         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2738         * aarch64-tdep.c (aarch64_make_prologue_cache)
2739         (aarch64_make_stub_cache): Replace throw_exception with throw.
2740
2741 2019-04-08  Tom Tromey  <tom@tromey.com>
2742
2743         * common/common-exceptions.c (throw_exception): Rename from
2744         throw_exception_cxx.  Remove old copy.  Make argument const.
2745         (throw_it): Create and throw exception objects directly.
2746         * common/common-exceptions.h (throw_exception): Make argument
2747         const.
2748         (struct gdb_exception_error): Add constructor.
2749         (struct gdb_exception_quit): Add constructor.
2750
2751 2019-04-08  Tom Tromey  <tom@tromey.com>
2752
2753         * common/common-exceptions.h (exception_rethrow): Don't declare.
2754         (TRY_SJLJ): Update comment.
2755         (TRY, CATCH, END_CATCH): Remove.
2756         * common/common-exceptions.c (exception_rethrow): Remove.
2757
2758 2019-04-08  Tom Tromey  <tom@tromey.com>
2759
2760         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2761         Remove.
2762         (gdb_exception_error): Rename from
2763         gdb_exception_RETURN_MASK_ERROR.
2764         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2765         (gdb_quit_bad_alloc): Update.
2766         * aarch64-tdep.c: Update.
2767         * ada-lang.c: Update.
2768         * ada-typeprint.c: Update.
2769         * ada-valprint.c: Update.
2770         * amd64-tdep.c: Update.
2771         * arch-utils.c: Update.
2772         * break-catch-throw.c: Update.
2773         * breakpoint.c: Update.
2774         * btrace.c: Update.
2775         * c-varobj.c: Update.
2776         * cli/cli-cmds.c: Update.
2777         * cli/cli-interp.c: Update.
2778         * cli/cli-script.c: Update.
2779         * common/common-exceptions.c: Update.
2780         * common/new-op.c: Update.
2781         * common/selftest.c: Update.
2782         * compile/compile-c-symbols.c: Update.
2783         * compile/compile-cplus-symbols.c: Update.
2784         * compile/compile-object-load.c: Update.
2785         * compile/compile-object-run.c: Update.
2786         * completer.c: Update.
2787         * corelow.c: Update.
2788         * cp-abi.c: Update.
2789         * cp-support.c: Update.
2790         * cp-valprint.c: Update.
2791         * darwin-nat.c: Update.
2792         * disasm-selftests.c: Update.
2793         * dtrace-probe.c: Update.
2794         * dwarf-index-cache.c: Update.
2795         * dwarf-index-write.c: Update.
2796         * dwarf2-frame-tailcall.c: Update.
2797         * dwarf2-frame.c: Update.
2798         * dwarf2loc.c: Update.
2799         * dwarf2read.c: Update.
2800         * eval.c: Update.
2801         * event-loop.c: Update.
2802         * event-top.c: Update.
2803         * exec.c: Update.
2804         * f-valprint.c: Update.
2805         * fbsd-tdep.c: Update.
2806         * frame-unwind.c: Update.
2807         * frame.c: Update.
2808         * gdbtypes.c: Update.
2809         * gnu-v3-abi.c: Update.
2810         * guile/guile-internal.h: Update.
2811         * guile/scm-block.c: Update.
2812         * guile/scm-breakpoint.c: Update.
2813         * guile/scm-cmd.c: Update.
2814         * guile/scm-disasm.c: Update.
2815         * guile/scm-frame.c: Update.
2816         * guile/scm-lazy-string.c: Update.
2817         * guile/scm-math.c: Update.
2818         * guile/scm-param.c: Update.
2819         * guile/scm-ports.c: Update.
2820         * guile/scm-pretty-print.c: Update.
2821         * guile/scm-symbol.c: Update.
2822         * guile/scm-symtab.c: Update.
2823         * guile/scm-type.c: Update.
2824         * guile/scm-value.c: Update.
2825         * i386-linux-tdep.c: Update.
2826         * i386-tdep.c: Update.
2827         * inf-loop.c: Update.
2828         * infcall.c: Update.
2829         * infcmd.c: Update.
2830         * infrun.c: Update.
2831         * jit.c: Update.
2832         * language.c: Update.
2833         * linespec.c: Update.
2834         * linux-fork.c: Update.
2835         * linux-nat.c: Update.
2836         * linux-tdep.c: Update.
2837         * linux-thread-db.c: Update.
2838         * main.c: Update.
2839         * mi/mi-cmd-break.c: Update.
2840         * mi/mi-cmd-stack.c: Update.
2841         * mi/mi-interp.c: Update.
2842         * mi/mi-main.c: Update.
2843         * objc-lang.c: Update.
2844         * p-valprint.c: Update.
2845         * parse.c: Update.
2846         * ppc-linux-tdep.c: Update.
2847         * printcmd.c: Update.
2848         * python/py-arch.c: Update.
2849         * python/py-breakpoint.c: Update.
2850         * python/py-cmd.c: Update.
2851         * python/py-finishbreakpoint.c: Update.
2852         * python/py-frame.c: Update.
2853         * python/py-framefilter.c: Update.
2854         * python/py-gdb-readline.c: Update.
2855         * python/py-inferior.c: Update.
2856         * python/py-infthread.c: Update.
2857         * python/py-lazy-string.c: Update.
2858         * python/py-linetable.c: Update.
2859         * python/py-objfile.c: Update.
2860         * python/py-param.c: Update.
2861         * python/py-prettyprint.c: Update.
2862         * python/py-progspace.c: Update.
2863         * python/py-record-btrace.c: Update.
2864         * python/py-record.c: Update.
2865         * python/py-symbol.c: Update.
2866         * python/py-type.c: Update.
2867         * python/py-unwind.c: Update.
2868         * python/py-utils.c: Update.
2869         * python/py-value.c: Update.
2870         * python/python.c: Update.
2871         * record-btrace.c: Update.
2872         * record-full.c: Update.
2873         * remote-fileio.c: Update.
2874         * remote.c: Update.
2875         * riscv-tdep.c: Update.
2876         * rs6000-aix-tdep.c: Update.
2877         * rs6000-tdep.c: Update.
2878         * rust-exp.y: Update.
2879         * rust-lang.c: Update.
2880         * s390-tdep.c: Update.
2881         * selftest-arch.c: Update.
2882         * solib-dsbt.c: Update.
2883         * solib-frv.c: Update.
2884         * solib-spu.c: Update.
2885         * solib-svr4.c: Update.
2886         * solib.c: Update.
2887         * sparc64-linux-tdep.c: Update.
2888         * stack.c: Update.
2889         * symfile-mem.c: Update.
2890         * symmisc.c: Update.
2891         * target.c: Update.
2892         * thread.c: Update.
2893         * top.c: Update.
2894         * tracefile-tfile.c: Update.
2895         * tui/tui.c: Update.
2896         * typeprint.c: Update.
2897         * unittests/cli-utils-selftests.c: Update.
2898         * unittests/parse-connection-spec-selftests.c: Update.
2899         * valops.c: Update.
2900         * valprint.c: Update.
2901         * value.c: Update.
2902         * varobj.c: Update.
2903         * windows-nat.c: Update.
2904         * x86-linux-nat.c: Update.
2905         * xml-support.c: Update.
2906
2907 2019-04-08  Tom Tromey  <tom@tromey.com>
2908
2909         * xml-support.c: Use C++ exception handling.
2910         * x86-linux-nat.c: Use C++ exception handling.
2911         * windows-nat.c: Use C++ exception handling.
2912         * varobj.c: Use C++ exception handling.
2913         * value.c: Use C++ exception handling.
2914         * valprint.c: Use C++ exception handling.
2915         * valops.c: Use C++ exception handling.
2916         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2917         handling.
2918         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2919         * typeprint.c: Use C++ exception handling.
2920         * tui/tui.c: Use C++ exception handling.
2921         * tracefile-tfile.c: Use C++ exception handling.
2922         * top.c: Use C++ exception handling.
2923         * thread.c: Use C++ exception handling.
2924         * target.c: Use C++ exception handling.
2925         * symmisc.c: Use C++ exception handling.
2926         * symfile-mem.c: Use C++ exception handling.
2927         * stack.c: Use C++ exception handling.
2928         * sparc64-linux-tdep.c: Use C++ exception handling.
2929         * solib.c: Use C++ exception handling.
2930         * solib-svr4.c: Use C++ exception handling.
2931         * solib-spu.c: Use C++ exception handling.
2932         * solib-frv.c: Use C++ exception handling.
2933         * solib-dsbt.c: Use C++ exception handling.
2934         * selftest-arch.c: Use C++ exception handling.
2935         * s390-tdep.c: Use C++ exception handling.
2936         * rust-lang.c: Use C++ exception handling.
2937         * rust-exp.y: Use C++ exception handling.
2938         * rs6000-tdep.c: Use C++ exception handling.
2939         * rs6000-aix-tdep.c: Use C++ exception handling.
2940         * riscv-tdep.c: Use C++ exception handling.
2941         * remote.c: Use C++ exception handling.
2942         * remote-fileio.c: Use C++ exception handling.
2943         * record-full.c: Use C++ exception handling.
2944         * record-btrace.c: Use C++ exception handling.
2945         * python/python.c: Use C++ exception handling.
2946         * python/py-value.c: Use C++ exception handling.
2947         * python/py-utils.c: Use C++ exception handling.
2948         * python/py-unwind.c: Use C++ exception handling.
2949         * python/py-type.c: Use C++ exception handling.
2950         * python/py-symbol.c: Use C++ exception handling.
2951         * python/py-record.c: Use C++ exception handling.
2952         * python/py-record-btrace.c: Use C++ exception handling.
2953         * python/py-progspace.c: Use C++ exception handling.
2954         * python/py-prettyprint.c: Use C++ exception handling.
2955         * python/py-param.c: Use C++ exception handling.
2956         * python/py-objfile.c: Use C++ exception handling.
2957         * python/py-linetable.c: Use C++ exception handling.
2958         * python/py-lazy-string.c: Use C++ exception handling.
2959         * python/py-infthread.c: Use C++ exception handling.
2960         * python/py-inferior.c: Use C++ exception handling.
2961         * python/py-gdb-readline.c: Use C++ exception handling.
2962         * python/py-framefilter.c: Use C++ exception handling.
2963         * python/py-frame.c: Use C++ exception handling.
2964         * python/py-finishbreakpoint.c: Use C++ exception handling.
2965         * python/py-cmd.c: Use C++ exception handling.
2966         * python/py-breakpoint.c: Use C++ exception handling.
2967         * python/py-arch.c: Use C++ exception handling.
2968         * printcmd.c: Use C++ exception handling.
2969         * ppc-linux-tdep.c: Use C++ exception handling.
2970         * parse.c: Use C++ exception handling.
2971         * p-valprint.c: Use C++ exception handling.
2972         * objc-lang.c: Use C++ exception handling.
2973         * mi/mi-main.c: Use C++ exception handling.
2974         * mi/mi-interp.c: Use C++ exception handling.
2975         * mi/mi-cmd-stack.c: Use C++ exception handling.
2976         * mi/mi-cmd-break.c: Use C++ exception handling.
2977         * main.c: Use C++ exception handling.
2978         * linux-thread-db.c: Use C++ exception handling.
2979         * linux-tdep.c: Use C++ exception handling.
2980         * linux-nat.c: Use C++ exception handling.
2981         * linux-fork.c: Use C++ exception handling.
2982         * linespec.c: Use C++ exception handling.
2983         * language.c: Use C++ exception handling.
2984         * jit.c: Use C++ exception handling.
2985         * infrun.c: Use C++ exception handling.
2986         * infcmd.c: Use C++ exception handling.
2987         * infcall.c: Use C++ exception handling.
2988         * inf-loop.c: Use C++ exception handling.
2989         * i386-tdep.c: Use C++ exception handling.
2990         * i386-linux-tdep.c: Use C++ exception handling.
2991         * guile/scm-value.c: Use C++ exception handling.
2992         * guile/scm-type.c: Use C++ exception handling.
2993         * guile/scm-symtab.c: Use C++ exception handling.
2994         * guile/scm-symbol.c: Use C++ exception handling.
2995         * guile/scm-pretty-print.c: Use C++ exception handling.
2996         * guile/scm-ports.c: Use C++ exception handling.
2997         * guile/scm-param.c: Use C++ exception handling.
2998         * guile/scm-math.c: Use C++ exception handling.
2999         * guile/scm-lazy-string.c: Use C++ exception handling.
3000         * guile/scm-frame.c: Use C++ exception handling.
3001         * guile/scm-disasm.c: Use C++ exception handling.
3002         * guile/scm-cmd.c: Use C++ exception handling.
3003         * guile/scm-breakpoint.c: Use C++ exception handling.
3004         * guile/scm-block.c: Use C++ exception handling.
3005         * guile/guile-internal.h: Use C++ exception handling.
3006         * gnu-v3-abi.c: Use C++ exception handling.
3007         * gdbtypes.c: Use C++ exception handling.
3008         * frame.c: Use C++ exception handling.
3009         * frame-unwind.c: Use C++ exception handling.
3010         * fbsd-tdep.c: Use C++ exception handling.
3011         * f-valprint.c: Use C++ exception handling.
3012         * exec.c: Use C++ exception handling.
3013         * event-top.c: Use C++ exception handling.
3014         * event-loop.c: Use C++ exception handling.
3015         * eval.c: Use C++ exception handling.
3016         * dwarf2read.c: Use C++ exception handling.
3017         * dwarf2loc.c: Use C++ exception handling.
3018         * dwarf2-frame.c: Use C++ exception handling.
3019         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3020         * dwarf-index-write.c: Use C++ exception handling.
3021         * dwarf-index-cache.c: Use C++ exception handling.
3022         * dtrace-probe.c: Use C++ exception handling.
3023         * disasm-selftests.c: Use C++ exception handling.
3024         * darwin-nat.c: Use C++ exception handling.
3025         * cp-valprint.c: Use C++ exception handling.
3026         * cp-support.c: Use C++ exception handling.
3027         * cp-abi.c: Use C++ exception handling.
3028         * corelow.c: Use C++ exception handling.
3029         * completer.c: Use C++ exception handling.
3030         * compile/compile-object-run.c: Use C++ exception handling.
3031         * compile/compile-object-load.c: Use C++ exception handling.
3032         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3033         * compile/compile-c-symbols.c: Use C++ exception handling.
3034         * common/selftest.c: Use C++ exception handling.
3035         * common/new-op.c: Use C++ exception handling.
3036         * cli/cli-script.c: Use C++ exception handling.
3037         * cli/cli-interp.c: Use C++ exception handling.
3038         * cli/cli-cmds.c: Use C++ exception handling.
3039         * c-varobj.c: Use C++ exception handling.
3040         * btrace.c: Use C++ exception handling.
3041         * breakpoint.c: Use C++ exception handling.
3042         * break-catch-throw.c: Use C++ exception handling.
3043         * arch-utils.c: Use C++ exception handling.
3044         * amd64-tdep.c: Use C++ exception handling.
3045         * ada-valprint.c: Use C++ exception handling.
3046         * ada-typeprint.c: Use C++ exception handling.
3047         * ada-lang.c: Use C++ exception handling.
3048         * aarch64-tdep.c: Use C++ exception handling.
3049
3050 2019-04-08  Tom Tromey  <tom@tromey.com>
3051
3052         * xml-support.c (gdb_xml_parser::parse): Update.
3053         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3054         * value.c (show_convenience): Update.
3055         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3056         (test_parse_flags_qcs): Update.
3057         * thread.c (thr_try_catch_cmd): Update.
3058         * target.c (target_translate_tls_address): Update.
3059         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3060         (info_frame_command_core, frame_apply_command_count): Update.
3061         * rust-exp.y (rust_lex_exception_test): Update.
3062         * riscv-tdep.c (riscv_print_one_register_info): Update.
3063         * remote.c (remote_target::enable_btrace): Update.
3064         * record-btrace.c (record_btrace_enable_warn): Update.
3065         * python/py-utils.c (gdbpy_convert_exception): Update.
3066         * printcmd.c (do_one_display, print_variable_and_value): Update.
3067         * mi/mi-main.c (mi_print_exception): Update.
3068         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3069         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3070         * linux-nat.c (linux_nat_target::attach): Update.
3071         * linux-fork.c (class scoped_switch_fork_info): Update.
3072         * infrun.c (displaced_step_prepare): Update.
3073         * infcall.c (call_function_by_hand_dummy): Update.
3074         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3075         * gnu-v3-abi.c (print_one_vtable): Update.
3076         * frame.c (get_prev_frame_always): Update.
3077         * f-valprint.c (info_common_command_for_block): Update.
3078         * exec.c (try_open_exec_file): Update.
3079         * exceptions.c (print_exception, exception_print)
3080         (exception_fprintf, exception_print_same): Update.
3081         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3082         * dwarf-index-cache.c (index_cache::store)
3083         (index_cache::lookup_gdb_index): Update.
3084         * darwin-nat.c (maybe_cache_shell): Update.
3085         * cp-valprint.c (cp_print_value_fields): Update.
3086         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3087         (gcc_cplus_symbol_address): Update.
3088         * compile/compile-c-symbols.c (gcc_convert_symbol)
3089         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3090         * common/selftest.c: Update.
3091         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3092         a std::string.
3093         (exception_try_scope_entry, exception_try_scope_exit): Don't
3094         declare.
3095         (struct exception_try_scope): Remove.
3096         (TRY): Don't use exception_try_scope.
3097         (struct gdb_exception): Add constructor, operator=.
3098         <what>: New method.
3099         (struct gdb_exception_RETURN_MASK_ALL)
3100         (struct gdb_exception_RETURN_MASK_ERROR)
3101         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3102         (struct gdb_quit_bad_alloc): Update.
3103         * common/common-exceptions.c (exception_none): Change
3104         initializer.
3105         (struct catcher) <state, exception>: Initialize inline.
3106         <prev>: Remove member.
3107         (current_catcher): Remove.
3108         (catchers): New global.
3109         (exceptions_state_mc_init): Simplify.
3110         (catcher_pop): Remove.
3111         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3112         (try_scope_depth, exception_try_scope_entry)
3113         (exception_try_scope_exit): Remove.
3114         (throw_exception_sjlj): Update.
3115         (exception_messages, exception_messages_size): Remove.
3116         (throw_it): Simplify.
3117         (gdb_exception_sliced_copy): Remove.
3118         (throw_exception_cxx): Update.
3119         * cli/cli-script.c (script_from_file): Update.
3120         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3121         Update.
3122         * ada-valprint.c (ada_val_print): Update.
3123         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3124         (create_excep_cond_exprs): Update.
3125
3126 2019-04-08  Tom Tromey  <tom@tromey.com>
3127
3128         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3129         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3130         (TRY, CATCH, END_CATCH): Remove some definitions.
3131         * common/common-exceptions.c: Don't use GDB_XCPT.
3132         (catcher_list_size): Remove.
3133         (throw_exception, throw_it): Simplify.
3134
3135 2019-04-05  Tom Tromey  <tom@tromey.com>
3136
3137         Revert the header-sorting patch.
3138         * ft32-tdep.c: Revert.
3139         * frv-tdep.c: Revert.
3140         * frv-linux-tdep.c: Revert.
3141         * frame.c: Revert.
3142         * frame-unwind.c: Revert.
3143         * frame-base.c: Revert.
3144         * fork-child.c: Revert.
3145         * findvar.c: Revert.
3146         * findcmd.c: Revert.
3147         * filesystem.c: Revert.
3148         * filename-seen-cache.h: Revert.
3149         * filename-seen-cache.c: Revert.
3150         * fbsd-tdep.c: Revert.
3151         * fbsd-nat.h: Revert.
3152         * fbsd-nat.c: Revert.
3153         * f-valprint.c: Revert.
3154         * f-typeprint.c: Revert.
3155         * f-lang.c: Revert.
3156         * extension.h: Revert.
3157         * extension.c: Revert.
3158         * extension-priv.h: Revert.
3159         * expprint.c: Revert.
3160         * exec.h: Revert.
3161         * exec.c: Revert.
3162         * exceptions.c: Revert.
3163         * event-top.c: Revert.
3164         * event-loop.c: Revert.
3165         * eval.c: Revert.
3166         * elfread.c: Revert.
3167         * dwarf2read.h: Revert.
3168         * dwarf2read.c: Revert.
3169         * dwarf2loc.c: Revert.
3170         * dwarf2expr.h: Revert.
3171         * dwarf2expr.c: Revert.
3172         * dwarf2-frame.c: Revert.
3173         * dwarf2-frame-tailcall.c: Revert.
3174         * dwarf-index-write.h: Revert.
3175         * dwarf-index-write.c: Revert.
3176         * dwarf-index-common.c: Revert.
3177         * dwarf-index-cache.h: Revert.
3178         * dwarf-index-cache.c: Revert.
3179         * dummy-frame.c: Revert.
3180         * dtrace-probe.c: Revert.
3181         * disasm.h: Revert.
3182         * disasm.c: Revert.
3183         * disasm-selftests.c: Revert.
3184         * dictionary.c: Revert.
3185         * dicos-tdep.c: Revert.
3186         * demangle.c: Revert.
3187         * dcache.h: Revert.
3188         * dcache.c: Revert.
3189         * darwin-nat.h: Revert.
3190         * darwin-nat.c: Revert.
3191         * darwin-nat-info.c: Revert.
3192         * d-valprint.c: Revert.
3193         * d-namespace.c: Revert.
3194         * d-lang.c: Revert.
3195         * ctf.c: Revert.
3196         * csky-tdep.c: Revert.
3197         * csky-linux-tdep.c: Revert.
3198         * cris-tdep.c: Revert.
3199         * cris-linux-tdep.c: Revert.
3200         * cp-valprint.c: Revert.
3201         * cp-support.c: Revert.
3202         * cp-namespace.c: Revert.
3203         * cp-abi.c: Revert.
3204         * corelow.c: Revert.
3205         * corefile.c: Revert.
3206         * continuations.c: Revert.
3207         * completer.h: Revert.
3208         * completer.c: Revert.
3209         * complaints.c: Revert.
3210         * coffread.c: Revert.
3211         * coff-pe-read.c: Revert.
3212         * cli-out.h: Revert.
3213         * cli-out.c: Revert.
3214         * charset.c: Revert.
3215         * c-varobj.c: Revert.
3216         * c-valprint.c: Revert.
3217         * c-typeprint.c: Revert.
3218         * c-lang.c: Revert.
3219         * buildsym.c: Revert.
3220         * buildsym-legacy.c: Revert.
3221         * build-id.h: Revert.
3222         * build-id.c: Revert.
3223         * btrace.c: Revert.
3224         * bsd-uthread.c: Revert.
3225         * breakpoint.h: Revert.
3226         * breakpoint.c: Revert.
3227         * break-catch-throw.c: Revert.
3228         * break-catch-syscall.c: Revert.
3229         * break-catch-sig.c: Revert.
3230         * blockframe.c: Revert.
3231         * block.c: Revert.
3232         * bfin-tdep.c: Revert.
3233         * bfin-linux-tdep.c: Revert.
3234         * bfd-target.c: Revert.
3235         * bcache.c: Revert.
3236         * ax-general.c: Revert.
3237         * ax-gdb.h: Revert.
3238         * ax-gdb.c: Revert.
3239         * avr-tdep.c: Revert.
3240         * auxv.c: Revert.
3241         * auto-load.c: Revert.
3242         * arm-wince-tdep.c: Revert.
3243         * arm-tdep.c: Revert.
3244         * arm-symbian-tdep.c: Revert.
3245         * arm-pikeos-tdep.c: Revert.
3246         * arm-obsd-tdep.c: Revert.
3247         * arm-nbsd-tdep.c: Revert.
3248         * arm-nbsd-nat.c: Revert.
3249         * arm-linux-tdep.c: Revert.
3250         * arm-linux-nat.c: Revert.
3251         * arm-fbsd-tdep.c: Revert.
3252         * arm-fbsd-nat.c: Revert.
3253         * arm-bsd-tdep.c: Revert.
3254         * arch-utils.c: Revert.
3255         * arc-tdep.c: Revert.
3256         * arc-newlib-tdep.c: Revert.
3257         * annotate.h: Revert.
3258         * annotate.c: Revert.
3259         * amd64-windows-tdep.c: Revert.
3260         * amd64-windows-nat.c: Revert.
3261         * amd64-tdep.c: Revert.
3262         * amd64-sol2-tdep.c: Revert.
3263         * amd64-obsd-tdep.c: Revert.
3264         * amd64-obsd-nat.c: Revert.
3265         * amd64-nbsd-tdep.c: Revert.
3266         * amd64-nbsd-nat.c: Revert.
3267         * amd64-nat.c: Revert.
3268         * amd64-linux-tdep.c: Revert.
3269         * amd64-linux-nat.c: Revert.
3270         * amd64-fbsd-tdep.c: Revert.
3271         * amd64-fbsd-nat.c: Revert.
3272         * amd64-dicos-tdep.c: Revert.
3273         * amd64-darwin-tdep.c: Revert.
3274         * amd64-bsd-nat.c: Revert.
3275         * alpha-tdep.c: Revert.
3276         * alpha-obsd-tdep.c: Revert.
3277         * alpha-nbsd-tdep.c: Revert.
3278         * alpha-mdebug-tdep.c: Revert.
3279         * alpha-linux-tdep.c: Revert.
3280         * alpha-linux-nat.c: Revert.
3281         * alpha-bsd-tdep.c: Revert.
3282         * alpha-bsd-nat.c: Revert.
3283         * aix-thread.c: Revert.
3284         * agent.c: Revert.
3285         * addrmap.c: Revert.
3286         * ada-varobj.c: Revert.
3287         * ada-valprint.c: Revert.
3288         * ada-typeprint.c: Revert.
3289         * ada-tasks.c: Revert.
3290         * ada-lang.c: Revert.
3291         * aarch64-tdep.c: Revert.
3292         * aarch64-ravenscar-thread.c: Revert.
3293         * aarch64-newlib-tdep.c: Revert.
3294         * aarch64-linux-tdep.c: Revert.
3295         * aarch64-linux-nat.c: Revert.
3296         * aarch64-fbsd-tdep.c: Revert.
3297         * aarch64-fbsd-nat.c: Revert.
3298         * aarch32-linux-nat.c: Revert.
3299
3300 2019-04-05  Tom Tromey  <tom@tromey.com>
3301
3302         * ft32-tdep.c: Sort headers.
3303         * frv-tdep.c: Sort headers.
3304         * frv-linux-tdep.c: Sort headers.
3305         * frame.c: Sort headers.
3306         * frame-unwind.c: Sort headers.
3307         * frame-base.c: Sort headers.
3308         * fork-child.c: Sort headers.
3309         * findvar.c: Sort headers.
3310         * findcmd.c: Sort headers.
3311         * filesystem.c: Sort headers.
3312         * filename-seen-cache.h: Sort headers.
3313         * filename-seen-cache.c: Sort headers.
3314         * fbsd-tdep.c: Sort headers.
3315         * fbsd-nat.h: Sort headers.
3316         * fbsd-nat.c: Sort headers.
3317         * f-valprint.c: Sort headers.
3318         * f-typeprint.c: Sort headers.
3319         * f-lang.c: Sort headers.
3320         * extension.h: Sort headers.
3321         * extension.c: Sort headers.
3322         * extension-priv.h: Sort headers.
3323         * expprint.c: Sort headers.
3324         * exec.h: Sort headers.
3325         * exec.c: Sort headers.
3326         * exceptions.c: Sort headers.
3327         * event-top.c: Sort headers.
3328         * event-loop.c: Sort headers.
3329         * eval.c: Sort headers.
3330         * elfread.c: Sort headers.
3331         * dwarf2read.h: Sort headers.
3332         * dwarf2read.c: Sort headers.
3333         * dwarf2loc.c: Sort headers.
3334         * dwarf2expr.h: Sort headers.
3335         * dwarf2expr.c: Sort headers.
3336         * dwarf2-frame.c: Sort headers.
3337         * dwarf2-frame-tailcall.c: Sort headers.
3338         * dwarf-index-write.h: Sort headers.
3339         * dwarf-index-write.c: Sort headers.
3340         * dwarf-index-common.c: Sort headers.
3341         * dwarf-index-cache.h: Sort headers.
3342         * dwarf-index-cache.c: Sort headers.
3343         * dummy-frame.c: Sort headers.
3344         * dtrace-probe.c: Sort headers.
3345         * disasm.h: Sort headers.
3346         * disasm.c: Sort headers.
3347         * disasm-selftests.c: Sort headers.
3348         * dictionary.c: Sort headers.
3349         * dicos-tdep.c: Sort headers.
3350         * demangle.c: Sort headers.
3351         * dcache.h: Sort headers.
3352         * dcache.c: Sort headers.
3353         * darwin-nat.h: Sort headers.
3354         * darwin-nat.c: Sort headers.
3355         * darwin-nat-info.c: Sort headers.
3356         * d-valprint.c: Sort headers.
3357         * d-namespace.c: Sort headers.
3358         * d-lang.c: Sort headers.
3359         * ctf.c: Sort headers.
3360         * csky-tdep.c: Sort headers.
3361         * csky-linux-tdep.c: Sort headers.
3362         * cris-tdep.c: Sort headers.
3363         * cris-linux-tdep.c: Sort headers.
3364         * cp-valprint.c: Sort headers.
3365         * cp-support.c: Sort headers.
3366         * cp-namespace.c: Sort headers.
3367         * cp-abi.c: Sort headers.
3368         * corelow.c: Sort headers.
3369         * corefile.c: Sort headers.
3370         * continuations.c: Sort headers.
3371         * completer.h: Sort headers.
3372         * completer.c: Sort headers.
3373         * complaints.c: Sort headers.
3374         * coffread.c: Sort headers.
3375         * coff-pe-read.c: Sort headers.
3376         * cli-out.h: Sort headers.
3377         * cli-out.c: Sort headers.
3378         * charset.c: Sort headers.
3379         * c-varobj.c: Sort headers.
3380         * c-valprint.c: Sort headers.
3381         * c-typeprint.c: Sort headers.
3382         * c-lang.c: Sort headers.
3383         * buildsym.c: Sort headers.
3384         * buildsym-legacy.c: Sort headers.
3385         * build-id.h: Sort headers.
3386         * build-id.c: Sort headers.
3387         * btrace.c: Sort headers.
3388         * bsd-uthread.c: Sort headers.
3389         * breakpoint.h: Sort headers.
3390         * breakpoint.c: Sort headers.
3391         * break-catch-throw.c: Sort headers.
3392         * break-catch-syscall.c: Sort headers.
3393         * break-catch-sig.c: Sort headers.
3394         * blockframe.c: Sort headers.
3395         * block.c: Sort headers.
3396         * bfin-tdep.c: Sort headers.
3397         * bfin-linux-tdep.c: Sort headers.
3398         * bfd-target.c: Sort headers.
3399         * bcache.c: Sort headers.
3400         * ax-general.c: Sort headers.
3401         * ax-gdb.h: Sort headers.
3402         * ax-gdb.c: Sort headers.
3403         * avr-tdep.c: Sort headers.
3404         * auxv.c: Sort headers.
3405         * auto-load.c: Sort headers.
3406         * arm-wince-tdep.c: Sort headers.
3407         * arm-tdep.c: Sort headers.
3408         * arm-symbian-tdep.c: Sort headers.
3409         * arm-pikeos-tdep.c: Sort headers.
3410         * arm-obsd-tdep.c: Sort headers.
3411         * arm-nbsd-tdep.c: Sort headers.
3412         * arm-nbsd-nat.c: Sort headers.
3413         * arm-linux-tdep.c: Sort headers.
3414         * arm-linux-nat.c: Sort headers.
3415         * arm-fbsd-tdep.c: Sort headers.
3416         * arm-fbsd-nat.c: Sort headers.
3417         * arm-bsd-tdep.c: Sort headers.
3418         * arch-utils.c: Sort headers.
3419         * arc-tdep.c: Sort headers.
3420         * arc-newlib-tdep.c: Sort headers.
3421         * annotate.h: Sort headers.
3422         * annotate.c: Sort headers.
3423         * amd64-windows-tdep.c: Sort headers.
3424         * amd64-windows-nat.c: Sort headers.
3425         * amd64-tdep.c: Sort headers.
3426         * amd64-sol2-tdep.c: Sort headers.
3427         * amd64-obsd-tdep.c: Sort headers.
3428         * amd64-obsd-nat.c: Sort headers.
3429         * amd64-nbsd-tdep.c: Sort headers.
3430         * amd64-nbsd-nat.c: Sort headers.
3431         * amd64-nat.c: Sort headers.
3432         * amd64-linux-tdep.c: Sort headers.
3433         * amd64-linux-nat.c: Sort headers.
3434         * amd64-fbsd-tdep.c: Sort headers.
3435         * amd64-fbsd-nat.c: Sort headers.
3436         * amd64-dicos-tdep.c: Sort headers.
3437         * amd64-darwin-tdep.c: Sort headers.
3438         * amd64-bsd-nat.c: Sort headers.
3439         * alpha-tdep.c: Sort headers.
3440         * alpha-obsd-tdep.c: Sort headers.
3441         * alpha-nbsd-tdep.c: Sort headers.
3442         * alpha-mdebug-tdep.c: Sort headers.
3443         * alpha-linux-tdep.c: Sort headers.
3444         * alpha-linux-nat.c: Sort headers.
3445         * alpha-bsd-tdep.c: Sort headers.
3446         * alpha-bsd-nat.c: Sort headers.
3447         * aix-thread.c: Sort headers.
3448         * agent.c: Sort headers.
3449         * addrmap.c: Sort headers.
3450         * ada-varobj.c: Sort headers.
3451         * ada-valprint.c: Sort headers.
3452         * ada-typeprint.c: Sort headers.
3453         * ada-tasks.c: Sort headers.
3454         * ada-lang.c: Sort headers.
3455         * aarch64-tdep.c: Sort headers.
3456         * aarch64-ravenscar-thread.c: Sort headers.
3457         * aarch64-newlib-tdep.c: Sort headers.
3458         * aarch64-linux-tdep.c: Sort headers.
3459         * aarch64-linux-nat.c: Sort headers.
3460         * aarch64-fbsd-tdep.c: Sort headers.
3461         * aarch64-fbsd-nat.c: Sort headers.
3462         * aarch32-linux-nat.c: Sort headers.
3463
3464 2019-04-04  Tom Tromey  <tom@tromey.com>
3465
3466         * varobj.c (varobj_create): Update.
3467         * rust-exp.y (struct rust_parser) <update_innermost_block,
3468         lookup_symbol>: New methods.
3469         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3470         Rename.
3471         (rust_parser::rust_lookup_type)
3472         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3473         * printcmd.c (display_command, do_one_display): Update.
3474         * parser-defs.h (struct parser_state) <parser_state>: Add
3475         "tracker" parameter.
3476         (block_tracker): New member.
3477         (class innermost_block_tracker) <innermost_block_tracker>: Add
3478         "types" parameter.
3479         <reset>: Remove method.
3480         (innermost_block): Don't declare.
3481         (null_post_parser): Update.
3482         * parse.c (innermost_block): Remove global.
3483         (write_dollar_variable): Update.
3484         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3485         Remove "tracker_types" parameter.
3486         (parse_expression): Add "tracker" parameter.
3487         (parse_expression_for_completion): Update.
3488         (null_post_parser): Add "tracker" parameter.
3489         * p-exp.y: Update rules.
3490         * m2-exp.y: Update rules.
3491         * language.h (struct language_defn) <la_post_parser>: Add
3492         "tracker" parameter.
3493         * go-exp.y: Update rules.
3494         * f-exp.y: Update rules.
3495         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3496         parameter.
3497         * d-exp.y: Update rules.
3498         * c-exp.y: Update rules.
3499         * breakpoint.c (set_breakpoint_condition): Create an
3500         innermost_block_tracker.
3501         (watch_command_1): Likewise.
3502         * ada-lang.c (resolve): Add "tracker" parameter.
3503         (resolve_subexp): Likewise.
3504         * ada-exp.y (write_var_from_sym): Update.
3505
3506 2019-04-04  Tom Tromey  <tom@tromey.com>
3507
3508         * type-stack.h: New file.
3509         * type-stack.c: New file.
3510         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3511         type-stack.h.
3512         (insert_into_type_stack, insert_type, push_type, push_type_int)
3513         (insert_type_address_space, pop_type, pop_type_int)
3514         (pop_typelist, pop_type_stack, append_type_stack)
3515         (push_type_stack, get_type_stack, push_typelist)
3516         (follow_type_instance_flags, follow_types): Don't declare.
3517         * parse.c (type_stack): Remove global.
3518         (parse_exp_in_context): Update.
3519         (insert_into_type_stack, insert_type, push_type, push_type_int)
3520         (insert_type_address_space, pop_type, pop_type_int)
3521         (pop_typelist, pop_type_stack, append_type_stack)
3522         (push_type_stack, get_type_stack, push_typelist)
3523         (follow_type_instance_flags, follow_types): Remove (moved to
3524         type-stack.c).
3525         * f-exp.y (type_stack): New global.
3526         Update rules.
3527         (push_kind_type, f_parse): Update.
3528         * d-exp.y (type_stack): New global.
3529         Update rules.
3530         (d_parse): Update.
3531         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3532         Update rules.
3533         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3534         (HFILES_NO_SRCDIR): Add type-stack.h.
3535
3536 2019-04-04  Tom Tromey  <tom@tromey.com>
3537
3538         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3539         (rust_parser::convert_ast_to_expression, rust_parse)
3540         (rust_lex_test_completion, rust_lex_tests): Update.
3541         * parser-defs.h (struct expr_completion_state): New.
3542         (struct parser_state) <parser_state>: Add completion parameter.
3543         <mark_struct_expression, mark_completion_tag>: New methods.
3544         <parse_completion, m_completion_state>: New members.
3545         (prefixify_expression, null_post_parser): Update.
3546         (mark_struct_expression, mark_completion_tag): Don't declare.
3547         * parse.c (parse_completion, expout_last_struct)
3548         (expout_tag_completion_type, expout_completion_name): Remove
3549         globals.
3550         (parser_state::mark_struct_expression)
3551         (parser_state::mark_completion_tag): Now methods.
3552         (prefixify_expression): Add last_struct parameter.
3553         (prefixify_subexp): Likewise.
3554         (parse_exp_1): Update.
3555         (parse_exp_in_context): Add cstate parameter.  Update.
3556         (parse_expression_for_completion): Create an
3557         expr_completion_state.
3558         (null_post_parser): Add "completion" parameter.
3559         * p-exp.y: Update rules.
3560         (yylex): Update.
3561         * language.h (struct language_defn) <la_post_parser>: Add
3562         "completing" parameter.
3563         * go-exp.y: Update rules.
3564         (lex_one_token): Update.
3565         * expression.h (parse_completion): Don't declare.
3566         * d-exp.y: Update rules.
3567         (lex_one_token): Update rules.
3568         * c-exp.y: Update rules.
3569         (lex_one_token): Update.
3570         * ada-lang.c (resolve): Add "parse_completion" parameter.
3571         (resolve_subexp): Likewise.
3572         (ada_resolve_function): Likewise.
3573
3574 2019-04-04  Tom Tromey  <tom@tromey.com>
3575
3576         * parser-defs.h (struct parser_state) <start_arglist,
3577         end_arglist>: New methods.
3578         <arglist_len, m_funcall_chain>: New members.
3579         (arglist_len, start_arglist, end_arglist): Don't declare.
3580         * parse.c (arglist_len, funcall_chain): Remove global.
3581         (start_arglist, end_arglist): Remove functions.
3582         (parse_exp_in_context): Update.
3583         * p-exp.y: Update rules.
3584         * m2-exp.y: Update rules.
3585         * go-exp.y: Update rules.
3586         * f-exp.y: Update rules.
3587         * d-exp.y: Update rules.
3588         * c-exp.y: Update rules.
3589
3590 2019-04-04  Tom Tromey  <tom@tromey.com>
3591
3592         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3593         lex_operator, push_back>: New methods.
3594         Update all rules.
3595         (rust_parser::lex_hex, lex_escape): Rename and update.
3596         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3597         (rust_parser::lex_operator): Rename and update.
3598         (rust_parser::lex_number, rustyylex, rustyyerror)
3599         (rust_lex_test_init, rust_lex_test_sequence)
3600         (rust_lex_test_push_back, rust_lex_tests): Update.
3601         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3602         parameter.
3603         <lexptr, prev_lexptr>: New members.
3604         (lexptr, prev_lexptr): Don't declare.
3605         * parse.c (lexptr, prev_lexptr): Remove globals.
3606         (parse_exp_in_context): Update.
3607         * p-exp.y (yylex, yyerror): Update.
3608         * m2-exp.y (parse_number, yylex, yyerror): Update.
3609         * go-exp.y (lex_one_token, yyerror): Update.
3610         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3611         * d-exp.y (lex_one_token, yyerror): Update.
3612         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3613         (lex_one_token, yyerror): Update.
3614         * ada-lex.l (YY_INPUT): Update.
3615         (rewind_to_char): Update.
3616         * ada-exp.y (yyerror): Update.
3617
3618 2019-04-04  Tom Tromey  <tom@tromey.com>
3619
3620         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3621         * parser-defs.h (struct parser_state) <parser_state>: Add new
3622         parameter.
3623         <comma_terminates>: New member.
3624         (comma_terminates): Don't declare global.
3625         * parse.c (comma_terminates): Remove global.
3626         (parse_exp_in_context): Update.
3627         * p-exp.y (yylex): Update.
3628         * m2-exp.y (yylex): Update.
3629         * go-exp.y (lex_one_token): Update.
3630         * f-exp.y (yylex): Update.
3631         * d-exp.y (lex_one_token): Update.
3632         * c-exp.y (lex_one_token): Update.
3633         * ada-lex.l: Update.
3634
3635 2019-04-04  Tom Tromey  <tom@tromey.com>
3636
3637         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3638         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3639         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3640         * parser-defs.h (paren_depth): Don't declare.
3641         * parse.c (paren_depth): Remove global.
3642         (parse_exp_in_context): Update.
3643         * p-exp.y (paren_depth): New global.
3644         (pascal_parse): Initialize it.
3645         * m2-exp.y (paren_depth): New global.
3646         (m2_parse): Initialize it.
3647         * go-exp.y (paren_depth): New global.
3648         (go_parse): Initialize it.
3649         * f-exp.y (paren_depth): New global.
3650         (f_parse): Initialize it.
3651         * d-exp.y (paren_depth): New global.
3652         (d_parse): Initialize it.
3653         * c-exp.y (paren_depth): New global.
3654         (c_parse): Initialize it.
3655         * ada-lex.l (paren_depth): New global.
3656         (lexer_init): Initialize it.
3657
3658 2019-04-04  Tom Tromey  <tom@tromey.com>
3659
3660         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3661         (rust_parser::convert_ast_to_type)
3662         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3663         * parser-defs.h (struct parser_state) <parser_state>: Add
3664         parameters.  Initialize new members.
3665         <expression_context_block, expression_context_pc>: New members.
3666         * parse.c (expression_context_block, expression_context_pc):
3667         Remove globals.
3668         (parse_exp_in_context): Update.
3669         * p-exp.y: Update all rules.
3670         (yylex): Update.
3671         * m2-exp.y: Update all rules.
3672         (yylex): Update.
3673         * go-exp.y (yylex): Update.
3674         * f-exp.y (yylex): Update.
3675         * d-exp.y: Update all rules.
3676         (yylex): Update.
3677         * c-exp.y: Update all rules.
3678         (lex_one_token, classify_name, yylex, c_parse): Update.
3679         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3680
3681 2019-04-04  Tom Tromey  <tom@tromey.com>
3682
3683         * gdbarch.h, gdbarch.c: Rebuild.
3684         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3685         * stap-probe.h:
3686         (struct stap_parse_info): Replace "parser_state" with
3687         "expr_builder".
3688         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3689         (parser_state): New class.
3690         * parse.c (expr_builder): Rename.
3691         (expr_builder::release): Rename.
3692         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3693         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3694         (write_exp_elt_longcst, write_exp_elt_floatcst)
3695         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3696         (write_exp_string_vector, write_exp_bitstring)
3697         (write_exp_msymbol, mark_struct_expression)
3698         (write_dollar_variable)
3699         (insert_type_address_space, increase_expout_size): Replace
3700         "parser_state" with "expr_builder".
3701         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3702         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3703         "parser_state" with "expr_builder".
3704
3705 2019-04-04  Tom Tromey  <tom@tromey.com>
3706
3707         * rust-exp.y: Replace "parse_language" with method call.
3708         * p-exp.y:
3709         (yylex): Replace "parse_language" with method call.
3710         * m2-exp.y:
3711         (yylex): Replace "parse_language" with method call.
3712         * go-exp.y (classify_name): Replace "parse_language" with method
3713         call.
3714         * f-exp.y (yylex): Replace "parse_language" with method call.
3715         * d-exp.y (lex_one_token): Replace "parse_language" with method
3716         call.
3717         * c-exp.y:
3718         (lex_one_token, classify_name, yylex): Replace "parse_language"
3719         with method call.
3720         * ada-exp.y (find_primitive_type, type_char)
3721         (type_system_address): Replace "parse_language" with method call.
3722
3723 2019-04-04  Tom Tromey  <tom@tromey.com>
3724
3725         * rust-exp.y: Replace "parse_gdbarch" with method call.
3726         * parse.c (write_dollar_variable, insert_type_address_space):
3727         Replace "parse_gdbarch" with method call.
3728         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3729         call.
3730         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3731         call.
3732         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3733         "parse_gdbarch" with method call.
3734         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3735         with method call.
3736         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3737         "parse_gdbarch" with method call.
3738         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3739         "parse_gdbarch" with method call.
3740         * c-exp.y (parse_type, parse_number, classify_name): Replace
3741         "parse_gdbarch" with method call.
3742         * ada-lex.l: Replace "parse_gdbarch" with method call.
3743         * ada-exp.y (parse_type, find_primitive_type, type_char)
3744         (type_system_address): Replace "parse_gdbarch" with method call.
3745
3746 2019-04-04  Tom Tromey  <tom@tromey.com>
3747
3748         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3749         * stap-probe.c (stap_parse_argument): Update.
3750         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3751         initial_size parameter.
3752         * rust-exp.y (rust_lex_tests): Update.
3753         * parse.c (parser_state): Update.
3754         (parse_exp_in_context): Update.
3755         * parser-defs.h (struct parser_state) <parser_state>: Remove
3756         "initial_size" parameter.
3757
3758 2019-04-04  Tom Tromey  <tom@tromey.com>
3759
3760         * parser-defs.h (increase_expout_size): Don't declare.
3761         * parse.c (increase_expout_size): Now static.
3762
3763 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3764
3765         * gnu-nat.c (gnu_nat_target::wait): Fix
3766         target_waitstatus_to_string call.
3767
3768 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         * eval.c (evaluate_subexp_standard): Handle internal functions
3771         during Fortran function call handling.
3772
3773 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3774
3775         * NEWS: Mention new internal functions.
3776         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3777         (read_base_type): Use dwarf2_init_complex_target_type.
3778         * value.c (creal_internal_fn): New function.
3779         (cimag_internal_fn): New function.
3780         (_initialize_values): Register new internal functions.
3781
3782 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3783
3784         * infrun.c (stop_all_threads): If debug_infrun, always
3785         trace the wait status after wait_one, using
3786         target_waitstatus_to_string and target_pid_to_str.
3787         (handle_inferior_event): Replace various trace of
3788         wait status kind by a single trace.
3789         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3790         wait status kind image by target_waitstatus_to_string.
3791         * target/waitstatus.c (target_waitstatus_to_string): Fix
3792         obsolete comment.
3793
3794 2019-04-01  Tom Tromey  <tromey@adacore.com>
3795
3796         PR symtab/23331:
3797         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3798
3799 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3800             Pedro Alves  <palves@redhat.com>
3801
3802         * top.c (quit_force): Call 'finalize_values'.
3803         * value.c (finalize_values): New function.
3804         * value.h (finalize_values): Declare.
3805
3806 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3807
3808         * NEWS: Announce $_gdb_major and $_gdb_minor.
3809
3810         * top.c (init_gdb_version_vars): New function.
3811         (gdb_init): Call init_gdb_version_vars.
3812
3813 2019-03-29  Tom Tromey  <tromey@adacore.com>
3814
3815         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3816         help text.  Remove dead code.
3817
3818 2019-03-29  Keith Seitz  <keiths@redhat.com>
3819
3820         From Siddhesh Poyarekar:
3821         * f-lang.h (f77_get_upperbound): Return LONGEST.
3822         (f77_get_lowerbound): Likewise.
3823         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3824         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3825         print them.
3826         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3827         plongest to format print it.
3828         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3829         (f77_get_upperbound): Likewise.
3830         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3831         LOWER_BOUND to LONGEST.
3832         (f77_create_arrayprint_offset_tbl): Likewise.
3833
3834 2019-03-29  Keith Seitz  <keiths@redhat.com>
3835
3836         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3837         %s/pulongest for TYPE_LENGTH instead of %d in format
3838         strings.
3839         * ada-typerint.c (ada_print_type): Likewise.
3840         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3841         * compile/compile-c-support.c (generate_register_struct): Likewise.
3842         * gdbtypes.c (recursive_dump_type): Likewise.
3843         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3844         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3845         instead of %d in format strings.
3846         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3847         to std::min to ULONGEST.
3848         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3849         instead of %d in format strings.
3850         * tracepoint.c (info_scope_command): Likewise.
3851         * typeprint.c (print_offset_data::update)
3852         (print_offset_data::finish): Likewise.
3853         * xtensa-tdep.c (xtensa_store_return_value)
3854         (xtensa_push_dummy_call): Likewise.
3855
3856 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3857
3858         * windows-nat.c (display_selector): Fixed format specifications
3859         for 64-bit Cygwin.
3860
3861 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3862
3863         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3864
3865 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3866
3867         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3868         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3869         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3870         (nios2_linux_init_abi): Install it.
3871
3872 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3873
3874         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3875
3876 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3877
3878         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3879
3880 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3881             Tom Tromey  <tromey@adacore.com>
3882
3883         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3884
3885 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3886
3887         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3888         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3889         method to compute the bounds of range types. Also print "[evaluated]"
3890         if the bounds' values come from a dynamic evaluation.
3891
3892 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3895         whitespace when pretty printing is on.
3896
3897 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3898
3899         * ppc-linux-nat.c: Add include.
3900
3901 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3902
3903         * NEWS: Mention AArch64 Pointer Authentication.
3904
3905 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3906
3907         * arm-linux-nat.c: Add include.
3908
3909 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3910
3911         * source-cache.c (source_cache::get_source_lines): Re-read
3912         fullname after calling open_source_file.
3913
3914 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3915
3916         * NEWS: Mention TLS support for FreeBSD.
3917
3918 2019-03-25  Tom Tromey  <tromey@adacore.com>
3919
3920         * minsyms.c (BUNCH_SIZE): Update comment.
3921         (~minimal_symbol_reader): Remove old comment.
3922         (compact_minimal_symbols): Update comment.
3923         (minimal_symbol_reader::install): Remove old comment.  Update
3924         other comments.
3925
3926 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3927
3928         * s390-linux-nat.c: Add include.
3929
3930 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3931
3932         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3933         Call linux_get_hwcap.
3934         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3935         Likewise.
3936         (aarch64_linux_get_hwcap): Remove function.
3937         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3938         declaration.
3939         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3940         linux_get_hwcap.
3941         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3942         * linux-tdep.c (linux_get_hwcap): Add function.
3943         (linux_get_hwcap2): Likewise.
3944         * linux-tdep.h (linux_get_hwcap): Add declaration.
3945         (linux_get_hwcap2): Likewise.
3946         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3947         (ppc_linux_get_hwcap2): Likewise.
3948         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3949         linux_get_hwcap.
3950         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3951         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3952         (ppc_linux_nat_target::read_description): Likewise.
3953         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3954         * s390-linux-nat.c: Likewise.
3955         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3956
3957 2019-03-24  Tom Tromey  <tom@tromey.com>
3958
3959         * ada-lang.c (standard_lookup): Simplify initialization.
3960         (ada_lookup_symbol_nonlocal): Simplify return.
3961         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3962         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3963         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3964         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3965         initialization.
3966         * solib.c (solib_global_lookup): Simplify.
3967         * symtab.c (null_block_symbol): Remove.
3968         (symbol_cache_lookup): Simplify returns.
3969         (lookup_language_this): Simplify returns.
3970         (lookup_symbol_aux): Simplify return.
3971         (lookup_local_symbol): Simplify returns.
3972         (lookup_global_symbol_from_objfile): Simplify return.
3973         (lookup_symbol_in_objfile_symtabs)
3974         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3975         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3976         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3977         * cp-namespace.c (cp_lookup_bare_symbol)
3978         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3979         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3980         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3981         (cp_lookup_symbol_via_imports): Simplify initialization.
3982         (find_symbol_in_baseclass): Likewise.
3983         * symtab.h (null_block_symbol): Remove.
3984         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3985         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3986         (d_lookup_symbol_module): Likewise.
3987         (find_symbol_in_baseclass): Simplify initialization.
3988
3989 2019-03-24  Tom Tromey  <tom@tromey.com>
3990
3991         * expression.h: Don't include symtab.h.
3992         (struct block): Forward declare.
3993
3994 2019-03-24  Tom Tromey  <tom@tromey.com>
3995
3996         * c-exp.y (typebase): Remove casts.
3997         * gdbtypes.c (lookup_unsigned_typename, )
3998         (lookup_signed_typename): Remove cast.
3999         * eval.c (parse_to_comma_and_eval): Remove cast.
4000         * parse.c (write_dollar_variable): Remove cast.
4001         * block.h (struct block) <superblock>: Now const.
4002         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4003         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4004         (map_block): Make "block" const.
4005         * symfile.h (struct quick_symbol_functions)
4006         <map_matching_symbols>: Constify block argument to "callback".
4007         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4008         const.
4009         (find_pc_sect_compunit_symtab): Make "b" const.
4010         (find_symbol_at_address): Likewise.
4011         (search_symbols): Likewise.
4012         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4013         (dw2_debug_names_lookup_symbol): Likewise.
4014         (dw2_map_matching_symbols): Update.
4015         * p-valprint.c (pascal_val_print): Remove "block".
4016         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4017         (aux_add_nonlocal_symbols): Make "block" const.
4018         (resolve_subexp): Remove cast.
4019         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4020         const.
4021         (iterate_over_file_blocks): Likewise.
4022         * f-exp.y (%union) <bval>: Remove.
4023         * coffread.c (patch_opaque_types): Make "b" const.
4024         * spu-tdep.c (spu_catch_start): Make "block" const.
4025         * c-valprint.c (print_unpacked_pointer): Remove "block".
4026         * symmisc.c (dump_symtab_1): Make "b" const.
4027         (block_depth): Make "block" const.
4028         * d-exp.y (%union) <bval>: Remove.
4029         * cp-support.h (cp_lookup_rtti_type): Update.
4030         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4031         * psymtab.c (psym_lookup_symbol): Make "block" const.
4032         (maintenance_check_psymtabs): Make "b" const.
4033         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4034         (enumerate_locals, enumerate_args): Update.
4035         * python/py-symtab.c (stpy_global_block): Make "block" const.
4036         (stpy_static_block): Likewise.
4037         * inline-frame.c (block_starting_point_at): Make "new_block"
4038         const.
4039         * block.c (find_block_in_blockvector): Make return type const.
4040         (blockvector_for_pc_sect): Make "b" const.
4041         (find_block_in_blockvector): Make "b" const.
4042
4043 2019-03-23  Tom Tromey  <tom@tromey.com>
4044
4045         * varobj.c (varobj_create): Update.
4046         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4047         * printcmd.c (display_command, do_one_display): Don't reset
4048         innermost_block.
4049         * parser-defs.h (enum innermost_block_tracker_type): Move to
4050         expression.h.
4051         (innermost_block): Update comment.
4052         * parse.c (parse_exp_1): Add tracker_types parameter.
4053         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4054         tracker_types parameter.  Reset innermost_block.
4055         (parse_exp_in_context): Remove.
4056         (parse_expression_for_completion): Update.
4057         * objfiles.c (~objfile): Don't reset expression_context_block or
4058         innermost_block.
4059         * expression.h (enum innermost_block_tracker_type): Move from
4060         parser-defs.h.
4061         (parse_exp_1): Add tracker_types parameter.
4062         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4063         reset innermost_block.
4064
4065 2019-03-23  Tom Tromey  <tom@tromey.com>
4066
4067         * objfiles.h: Include bcache.h.
4068
4069 2019-03-23  Tom Tromey  <tom@tromey.com>
4070
4071         * linespec.c (get_current_search_block): Use
4072         scoped_restore_current_language.
4073         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4074
4075 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4076             Jiong Wang  <jiong.wang@arm.com>
4077
4078         * aarch64-linux-tdep.c
4079         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4080         section.
4081         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4082
4083 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4084             Jiong Wang  <jiong.wang@arm.com>
4085
4086         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4087         instructions.
4088         (aarch64_analyze_prologue_test): Add PACIASP test.
4089         (aarch64_prologue_prev_register): Unmask PC value.
4090
4091 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4092             Jiong Wang  <jiong.wang@arm.com>
4093
4094         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4095         (aarch64_dwarf2_prev_register): Unmask PC value.
4096         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4097         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4098         DW_CFA_AARCH64_negate_ra_state.
4099         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4100
4101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4102             Jiong Wang  <jiong.wang@arm.com>
4103
4104         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4105         registers.
4106         (aarch64_pseudo_register_name): Likewise.
4107         (aarch64_pseudo_register_type): Likewise.
4108         (aarch64_pseudo_register_reggroup_p): Likewise.
4109         (aarch64_gdbarch_init): Add pauth registers.
4110         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4111         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4112         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4113         (struct gdbarch_tdep): Add regnum for ra_state.
4114
4115 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4116             Jiong Wang  <jiong.wang@arm.com>
4117
4118         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4119
4120 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4121             Jiong Wang  <jiong.wang@arm.com>
4122
4123         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4124         function.
4125         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4126         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4127         (aarch64_gdbarch_init): Add puth registers.
4128         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4129         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4130         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4131
4132 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4133             Jiong Wang  <jiong.wang@arm.com>
4134
4135         * aarch64-linux-nat.c
4136         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4137         * aarch64-linux-tdep.c
4138         (aarch64_linux_core_read_description): Likewise.
4139         (aarch64_linux_get_hwcap): New function.
4140         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4141         (aarch64_linux_get_hwcap): New declaration.
4142
4143 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4144             Jiong Wang  <jiong.wang@arm.com>
4145
4146         * aarch64-linux-nat.c
4147         (aarch64_linux_nat_target::read_description): Add pauth param.
4148         * aarch64-linux-tdep.c
4149         (aarch64_linux_core_read_description): Likewise.
4150         * aarch64-tdep.c (struct target_desc): Add in pauth.
4151         (aarch64_read_description): Add pauth param.
4152         (aarch64_gdbarch_init): Likewise.
4153         * aarch64-tdep.h (aarch64_read_description): Likewise.
4154         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4155         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4156         * features/Makefile: Add new files.
4157         * features/aarch64-pauth.c: New file.
4158         * features/aarch64-pauth.xml: New file.
4159
4160 2019-03-20  Tom Tromey  <tromey@adacore.com>
4161
4162         * infrun.c (handle_inferior_event): Rename from
4163         handle_inferior_event_1.  Create a scoped_value_mark.
4164         (handle_inferior_event): Remove.
4165
4166 2019-03-19  Tom Tromey  <tromey@adacore.com>
4167
4168         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4169         * infrun.h (print_stop_event): Add "displays" parameter.
4170         * infrun.c (print_stop_event): Add "displays" parameter.
4171
4172 2019-03-19  Pedro Alves  <palves@redhat.com>
4173
4174         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4175         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4176         to -1.  Fix TABs vs spaces.
4177         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4178         * tui/tui-out.h (tui_ui_out) Add intro comments.
4179         <m_line, m_start_of_line>: In-class initialize, and add describing
4180         comment.
4181
4182 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4183
4184         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4185         variable names.
4186         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4187
4188 2019-03-18  Pedro Alves  <palves@redhat.com>
4189             Eli Zaretskii <eliz@gnu.org>
4190
4191         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4192         m_line and m_start_of_line.
4193
4194 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4195
4196         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4197         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4198         it returns a newline.  This fixes a regression in TU mode, whereby
4199         the next line is output on the same screen line as the user input.
4200
4201 2019-03-18  Tom Tromey  <tromey@adacore.com>
4202
4203         * minsyms.c (minimal_symbol_reader::install): Remove call to
4204         obstack_blank.
4205
4206 2019-03-18  Pedro Alves  <palves@redhat.com>
4207
4208         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4209         New globals.
4210         (apply_style): New, factored out from ...
4211         (apply_ansi_escape): ... this.  Handle reverse video mode.
4212         (tui_set_reverse_mode): New function.
4213         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4214         * tui/tui-winsource.c (tui_show_source_line): Use
4215         tui_set_reverse_mode instead of setting A_STANDOUT.
4216         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4217         New setter methods.
4218
4219 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4220
4221         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4222         Handle tabs.
4223
4224 2019-03-18  Tom Tromey  <tromey@adacore.com>
4225
4226         * ada-lang.c (empty_array): Add "high" parameter.
4227         (ada_evaluate_subexp): Update.
4228
4229 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4230
4231         * unittests/string_view-selftests.c: Define
4232         _initialize_string_view_selftests unconditionally.
4233
4234 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4235
4236         PR gdb/24350
4237         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4238
4239 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4240
4241         PR gdb/24351
4242         * windows-nat.c (display_selector): Fix format specifiers.
4243
4244 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4245
4246         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4247         tui_refill_source_window instead of tui_refresh_win, to update the
4248         current execution line.  This fixes redisplay of the current line
4249         when stepping through the code with "next" or "step".
4250
4251 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4252
4253         * source-cache.c (source_cache::get_source_lines): Call
4254         find_source_lines to initialize s->nlines.  This fixes vertical
4255         scrolling of TUI source window when the DOWN arrow is pressed.
4256
4257 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4258
4259         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4260         linux-thread-db.c (_initialize_thread_db): Likewise.
4261
4262 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4263
4264         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4265         wclrtoeol in tui_show_source_line".  This reverts changes made in
4266         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4267
4268 2019-03-15  Tom Tromey  <tom@tromey.com>
4269
4270         * symtab.h (struct minimal_symbol): Derive from
4271         general_symbol_info.
4272         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4273         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4274         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4275         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4276         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4277         (MSYMBOL_SEARCH_NAME): Update.
4278         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4279         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4280         * minsyms.c (minimal_symbol_reader::record_full): Update.
4281
4282 2019-03-15  Tom Tromey  <tom@tromey.com>
4283
4284         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4285
4286 2019-03-15  Tom Tromey  <tom@tromey.com>
4287
4288         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4289         unique_xmalloc_ptr.
4290         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4291         Update.
4292         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4293         (build_minimal_symbol_hash_tables)
4294         (minimal_symbol_reader::install): Update.
4295
4296 2019-03-15  Tom Tromey  <tom@tromey.com>
4297
4298         * symtab.c (create_demangled_names_hash): Update.
4299         (symbol_set_names): Update.
4300         * objfiles.h (struct objfile_per_bfd_storage)
4301         <demangled_names_hash>: Now an htab_up.
4302         * objfiles.c (objfile_per_bfd_storage): Simplify.
4303
4304 2019-03-15  Tom Tromey  <tom@tromey.com>
4305
4306         * objfiles.h (struct objfile_per_bfd_storage): Declare
4307         destructor.
4308         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4309         New.
4310         (get_objfile_bfd_data): Use new.  Don't initialize
4311         language_of_main.
4312         (free_objfile_per_bfd_storage): Remove.
4313         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4314
4315 2019-03-15  Tom Tromey  <tom@tromey.com>
4316
4317         * symfile.c (reread_symbols): Update.
4318         * objfiles.c (objfile::objfile): Update.
4319         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4320         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4321         comment.
4322         (minimal_symbol_reader::install): Update.
4323         (terminate_minimal_symbol_table): Remove.
4324         * jit.c (jit_object_close_impl): Update.
4325
4326 2019-03-15  Tom Tromey  <tom@tromey.com>
4327
4328         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4329         initializations.
4330
4331 2019-03-15  Tom Tromey  <tom@tromey.com>
4332
4333         * objfiles.h (struct objfile_per_bfd_storage)
4334         <demangled_hash_languages>: Now a bitset.
4335         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4336         (lookup_minimal_symbol): Update.
4337
4338 2019-03-15  Tom Tromey  <tom@tromey.com>
4339
4340         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4341         Don't return the symbol.
4342         * coffread.c (record_minimal_symbol): Use record_full.
4343
4344 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4345
4346         The MS-Windows port of ncurses fails to switch to a color pair if
4347         one or both of the colors are the implicit default colors.  This
4348         change records the default colors when TUI is initialized, and
4349         then specifies them explicitly when a color pair uses the default
4350         colors.  This allows color styling in TUI mode on MS-Windows.
4351
4352         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4353         ncurses_norm_attr.
4354         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4355         colors in ncurses_norm_attr.
4356         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4357         "none", replace it with the default color recorded in
4358         ncurses_norm_attr.
4359
4360 2019-03-14  Tom Tromey  <tromey@adacore.com>
4361
4362         * source-cache.h (class source_cache) <get_source_lines>: Return
4363         std::string.
4364         * source-cache.c (source_cache::extract_lines): Handle case where
4365         first_pos==npos.  Return std::string.
4366         (source_cache::get_source_lines): Update.
4367
4368 2019-03-14  Tom Tromey  <tromey@adacore.com>
4369
4370         * NEWS: Add item for "style sources" commands.
4371         * source-cache.c (source_cache::get_source_lines): Check
4372         source_styling.
4373         * cli/cli-style.c (source_styling): New global.
4374         (_initialize_cli_style): Add "style sources" commands.
4375         (show_style_sources): New function.
4376         * cli/cli-style.h (source_styling): Declare.
4377
4378 2019-03-14  Pedro Alves  <palves@redhat.com>
4379             Tom Tromey  <tromey@adacore.com>
4380
4381         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4382         * tui/tui-winsource.c (tui_refill_source_window): New function,
4383         from...
4384         (tui_horizontal_source_scroll): ... here.  Move some logic.
4385         * cli/cli-style.c (set_style_enabled): Notify new observable.
4386         * tui/tui-hooks.c (tui_redisplay_source): New function.
4387         (tui_attach_detach_observers): Attach or detach
4388         tui_redisplay_source.
4389         * observable.h (source_styling_changed): New observable.
4390         * observable.c: Define source_styling_changed observable.
4391
4392 2019-03-13  Tom Tromey  <tromey@adacore.com>
4393
4394         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4395         (i386_gnu_nat_target::store_registers): Update.
4396         * target-debug.h (target_debug_print_std_string): New macro.
4397         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4398         * windows-tdep.c (display_one_tib): Update.
4399         * tui/tui-stack.c (tui_make_status_line): Update.
4400         * top.c (print_inferior_quit_action): Update.
4401         * thread.c (thr_try_catch_cmd): Update.
4402         (add_thread_with_info): Update.
4403         (thread_target_id_str): Update.
4404         (thr_try_catch_cmd): Update.
4405         (thread_command): Update.
4406         (thread_find_command): Update.
4407         * record-btrace.c (record_btrace_target::info_record)
4408         (record_btrace_resume_thread, record_btrace_target::resume)
4409         (record_btrace_cancel_resume, record_btrace_step_thread)
4410         (record_btrace_target::wait, record_btrace_target::wait)
4411         (record_btrace_target::wait, record_btrace_target::stop): Update.
4412         * progspace.c (print_program_space): Update.
4413         * process-stratum-target.c
4414         (process_stratum_target::thread_address_space): Update.
4415         * linux-fork.c (linux_fork_mourn_inferior)
4416         (detach_checkpoint_command, info_checkpoints_command)
4417         (linux_fork_context): Update.
4418         (linux_fork_detach): Update.
4419         (class scoped_switch_fork_info): Update.
4420         (delete_checkpoint_command): Update.
4421         * infrun.c (follow_fork_inferior): Update.
4422         (follow_fork_inferior): Update.
4423         (proceed_after_vfork_done): Update.
4424         (handle_vfork_child_exec_or_exit): Update.
4425         (follow_exec): Update.
4426         (displaced_step_prepare_throw): Update.
4427         (displaced_step_restore): Update.
4428         (start_step_over): Update.
4429         (resume_1): Update.
4430         (clear_proceed_status_thread): Update.
4431         (proceed): Update.
4432         (print_target_wait_results): Update.
4433         (do_target_wait): Update.
4434         (context_switch): Update.
4435         (stop_all_threads): Update.
4436         (restart_threads): Update.
4437         (finish_step_over): Update.
4438         (handle_signal_stop): Update.
4439         (switch_back_to_stepped_thread): Update.
4440         (keep_going_pass_signal): Update.
4441         (print_exited_reason): Update.
4442         (normal_stop): Update.
4443         * inferior.c (inferior_pid_to_str): Change return type.
4444         (print_selected_inferior): Update.
4445         (add_inferior): Update.
4446         (detach_inferior): Update.
4447         * dummy-frame.c (fprint_dummy_frames): Update.
4448         * dcache.c (dcache_info_1): Update.
4449         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4450         (btrace_fetch, btrace_clear): Update.
4451         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4452         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4453         type.
4454         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4455         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4456         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4457         * gdbarch.c, gdbarch.h: Rebuild.
4458         * gdbarch.sh (core_pid_to_str): Change return type.
4459         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4460         return type.
4461         (windows_nat_target::pid_to_str): Change return type.
4462         (windows_delete_thread): Update.
4463         (windows_nat_target::attach): Update.
4464         (windows_nat_target::files_info): Update.
4465         * target-delegates.c: Rebuild.
4466         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4467         return type.
4468         (sol_thread_target::pid_to_str): Change return type.
4469         * remote.c (class remote_target) <pid_to_str>: Change return
4470         type.
4471         (remote_target::pid_to_str): Change return type.
4472         (extended_remote_target::attach, remote_target::remote_stop_ns)
4473         (remote_target::remote_notif_remove_queued_reply)
4474         (remote_target::push_stop_reply, remote_target::disable_btrace):
4475         Update.
4476         (extended_remote_target::attach): Update.
4477         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4478         type.
4479         (gdbsim_target::pid_to_str): Change return type.
4480         * ravenscar-thread.c (struct ravenscar_thread_target)
4481         <pid_to_str>: Change return type.
4482         (ravenscar_thread_target::pid_to_str): Change return type.
4483         * procfs.c (class procfs_target) <pid_to_str>: Change return
4484         type.
4485         (procfs_target::pid_to_str): Change return type.
4486         (procfs_target::attach): Update.
4487         (procfs_target::detach): Update.
4488         (procfs_target::fetch_registers): Update.
4489         (procfs_target::store_registers): Update.
4490         (procfs_target::wait): Update.
4491         (procfs_target::files_info): Update.
4492         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4493         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4494         return type.
4495         (nto_procfs_target::pid_to_str): Change return type.
4496         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4497         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4498         return type.
4499         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4500         (exit_lwp): Update.
4501         (attach_proc_task_lwp_callback, get_detach_signal)
4502         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4503         (linux_nat_target::resume, wait_lwp, stop_callback)
4504         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4505         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4506         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4507         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4508         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4509         type.
4510         (inf_ptrace_target::attach): Update.
4511         (inf_ptrace_target::files_info): Update.
4512         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4513         type.
4514         (go32_nat_target::pid_to_str): Change return type.
4515         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4516         (gnu_nat_target::wait): Update.
4517         (gnu_nat_target::wait): Update.
4518         (gnu_nat_target::resume): Update.
4519         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4520         (fbsd_nat_target::wait): Update.
4521         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4522         type.
4523         (darwin_nat_target::attach): Update.
4524         * corelow.c (class core_target) <pid_to_str>: Change return type.
4525         (core_target::pid_to_str): Change return type.
4526         * target.c (normal_pid_to_str): Change return type.
4527         (default_pid_to_str): Likewise.
4528         (target_pid_to_str): Change return type.
4529         (target_translate_tls_address): Update.
4530         (target_announce_detach): Update.
4531         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4532         return type.
4533         (bsd_uthread_target::pid_to_str): Change return type.
4534         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4535         type.
4536         (bsd_kvm_target::pid_to_str): Change return type.
4537         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4538         return type.
4539         (aix_thread_target::pid_to_str): Change return type.
4540         * target.h (struct target_ops) <pid_to_str>: Change return type.
4541         (target_pid_to_str, normal_pid_to_str): Likewise.
4542         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4543         type.
4544         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4545         type.
4546         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4547         return type.
4548         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4549         type.
4550         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4551         type.
4552         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4553         return type.
4554
4555 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4556
4557         * NEWS: Mention that the new default MI version is 3.  Mention
4558         changes to the output of commands and events that deal with
4559         multi-location breakpoints.
4560         * breakpoint.c: Include "mi/mi-out.h".
4561         (print_one_breakpoint): Change output syntax if using MI version
4562         >= 3.
4563         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4564         New.
4565         (mi_multi_location_breakpoint_output_fixed): New.
4566         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4567         (mi_cmd_fix_multi_location_breakpoint_output): New.
4568         (mi_multi_location_breakpoint_output_fixed): New.
4569         * mi/mi-cmds.c (mi_cmds): Register command
4570         -fix-multi-location-breakpoint-output.
4571         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4572         interpreter "mi".
4573
4574 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4575
4576         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4577         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4578         instantiate mi_ui_out based on interpreter name.
4579         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4580         * mi/mi-main.c (mi_load_progress): Likewise.
4581
4582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4583
4584         * NEWS: Combine separate "New targets" sections for 8.3.
4585
4586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4587
4588         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4589         (ppcfbsd_init_abi): Install gdbarch
4590         "fetch_tls_load_module_address" and "get_thread_local_address"
4591         methods.
4592
4593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4594
4595         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4596         (riscv_fbsd_init_abi): Install gdbarch
4597         "fetch_tls_load_module_address" and "get_thread_local_address"
4598         methods.
4599
4600 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4601
4602         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4603         (i386fbsd_init_abi): Install gdbarch
4604         "fetch_tls_load_module_address" and "get_thread_local_address"
4605         methods.
4606
4607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4608
4609         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4610         (amd64fbsd_init_abi): Install gdbarch
4611         "fetch_tls_load_module_address" and "get_thread_local_address"
4612         methods.
4613
4614 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4615
4616         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4617         (struct fbsd_pspace_data): New type.
4618         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4619         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4620         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4621         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4622         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4623
4624 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4625
4626         * gdbtypes.c (lookup_struct_elt): New function.
4627         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4628         * gdbtypes.h (struct struct_elt): New type.
4629         (lookup_struct_elt): New prototype.
4630
4631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4632
4633         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4634         remove disabled code block.
4635
4636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4637
4638         * gdbarch.sh (get_thread_local_address): New method.
4639         * gdbarch.h, gdbarch.c: Regenerate.
4640         * target.c (target_translate_tls_address): Use
4641         gdbarch_get_thread_local_address if present instead of
4642         target::get_thread_local_address.
4643
4644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4645
4646         * target.h (target::get_thread_local_address): Update comment.
4647
4648 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4649
4650         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4651         objfile->separate_debug_objfile_backlink if not NULL.
4652
4653 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4654
4655         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4656         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4657         (amd64bsd_store_inferior_registers): Likewise.
4658         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4659         Enable segment base registers.
4660         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4661         PT_GETFSBASE and PT_GETGSBASE.
4662         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4663         PT_SETGSBASE.
4664         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4665         segment base registers.
4666         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4667
4668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4669
4670         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4671         Update calls to i386_target_description to add 'segments'
4672         parameter.
4673         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4674         add segment base registers.
4675         * arch/i386.c (i386_create_target_description): Add 'segments'
4676         parameter to enable segment base registers.
4677         * arch/i386.h (i386_create_target_description): Likewise.
4678         * features/i386/32bit-segments.xml: New file.
4679         * features/i386/32bit-segments.c: Generate.
4680         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4681         call to i386_target_description to add 'segments' parameter.
4682         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4683         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4684         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4685         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4686         if feature is present.
4687         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4688         Add 'segments' parameter to call to i386_target_description.
4689         (i386_target_description): Add 'segments' parameter to enable
4690         segment base registers.
4691         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4692         to call to i386_target_description.
4693         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4694         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4695         Define I386_NUM_REGS.
4696         (i386_target_description): Add 'segments' parameter to enable
4697         segment base registers.
4698
4699 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4700
4701         PR/24325
4702         * source-cache.c: #undef open and close, to avoid unresolved
4703         externals during linking.
4704
4705 2019-03-12  Tom Tromey  <tromey@adacore.com>
4706
4707         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4708         const.  Add initializers.
4709         (_initialize_remote): Don't initialize ptid globals.
4710
4711 2019-03-12  Pedro Alves  <palves@redhat.com>
4712
4713         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4714
4715 2019-03-12  Pedro Alves  <palves@redhat.com>
4716
4717         * cp-name-parser.y (main): Remove unused 'len' variable.
4718
4719 2019-03-12  Tom Tromey  <tromey@adacore.com>
4720
4721         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4722         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4723
4724 2019-03-12  Tom Tromey  <tromey@adacore.com>
4725
4726         * linux-nat.c (iterate_over_lwps): Update.
4727         (stop_callback): Remove parameter.
4728         (stop_wait_callback, detach_callback, resume_set_callback)
4729         (select_singlestep_lwp_callback, set_ignore_sigint)
4730         (status_callback, resumed_callback, resume_clear_callback)
4731         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4732         data parameter.
4733         (linux_nat_target::detach, linux_nat_target::resume)
4734         (linux_stop_and_wait_all_lwps, select_event_lwp)
4735         (linux_nat_filter_event, linux_nat_wait_1)
4736         (linux_nat_target::kill, linux_nat_target::stop)
4737         (linux_nat_target::stop): Update.
4738         (linux_nat_resume_callback): Change type.
4739         (resume_stopped_resumed_lwps, count_events_callback)
4740         (select_event_lwp_callback): Likewise.
4741         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4742         * arm-linux-nat.c (struct update_registers_data): Remove.
4743         (update_registers_callback): Change type.
4744         (arm_linux_insert_hw_breakpoint1): Update.
4745         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4746         parameter.
4747         (x86_linux_dr_set_addr): Update.
4748         (x86_linux_dr_set_control): Update.
4749         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4750         (iterate_over_lwps): Use gdb::function_view.
4751         * nat/aarch64-linux-hw-point.c (struct
4752         aarch64_dr_update_callback_param): Remove.
4753         (debug_reg_change_callback): Change type.
4754         (aarch64_notify_debug_reg_change): Update.
4755         * s390-linux-nat.c (s390_refresh_per_info): Update.
4756
4757 2019-03-11  Tom Tromey  <tromey@adacore.com>
4758
4759         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4760         redundant assignment to "this_cu".
4761
4762 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4763
4764         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4765
4766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4767
4768         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4769         from...
4770         (rank_one_type): ... this.
4771
4772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4773
4774         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4775         from...
4776         (rank_one_type): ... this.
4777
4778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4779
4780         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4781         from...
4782         (rank_one_type): ... this.
4783
4784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4785
4786         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4787         from...
4788         (rank_one_type): ... this.
4789
4790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4791
4792         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4793         from...
4794         (rank_one_type): ... this.
4795
4796 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4797
4798         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4799         from...
4800         (rank_one_type): ... this.
4801
4802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4803
4804         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4805         from...
4806         (rank_one_type): ... this.
4807
4808 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4809
4810         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4811         from...
4812         (rank_one_type): ... this.
4813
4814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4815
4816         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4817         from...
4818         (rank_one_type): ... this.
4819
4820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4821
4822         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4823         from...
4824         (rank_one_type): ... this.
4825
4826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4827
4828         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4829         from...
4830         (rank_one_type): ... this.
4831
4832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4833
4834         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4835         from...
4836         (rank_one_type): ... this.
4837
4838 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4839
4840         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4841         inferior-events' shows the example events.
4842
4843 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4844
4845         Support styling on native MS-Windows console
4846
4847         PR/24315
4848         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4849         on MS-Windows if $TERM is not defined.
4850
4851         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4852
4853         * posix-hdep.c (gdb_console_fputs):
4854         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4855         functions.
4856         * ui-file.h (gdb_console_fputs): Add prototype.
4857
4858         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4859         back to fputs only if the former returns zero.
4860
4861 2019-03-07  Tom Tromey  <tom@tromey.com>
4862
4863         * symmisc.c (print_symbol_bcache_statistics): Update.
4864         (print_objfile_statistics): Update.
4865         * symfile.c (allocate_symtab): Update.
4866         * stabsread.c: Don't include bcache.h.
4867         * psymtab.h (struct psymbol_bcache): Don't declare.
4868         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4869         (psymbol_bcache_init, psymbol_bcache_free)
4870         (psymbol_bcache_get_bcache): Don't declare.
4871         * psymtab.c (struct psymbol_bcache): Remove.
4872         (psymtab_storage::psymtab_storage): Update.
4873         (psymtab_storage::~psymtab_storage): Update.
4874         (psymbol_bcache_init, psymbol_bcache_free)
4875         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4876         (add_psymbol_to_bcache): Update.
4877         (allocate_psymtab): Update.
4878         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4879         macro_cache>: No longer pointers.
4880         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4881         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4882         * macrotab.c (macro_bcache): Update.
4883         * macroexp.c: Don't include bcache.h.
4884         * gdbtypes.c (check_types_worklist): Update.
4885         (types_deeply_equal): Remove TRY/CATCH.  Update.
4886         * elfread.c (elf_symtab_read): Update.
4887         * dwarf2read.c: Don't include bcache.h.
4888         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4889         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4890         (print_bcache_statistics, bcache_memory_used): Don't declare.
4891         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4892         methods.  Rename all data members.
4893         * bcache.c (struct bcache): Move to bcache.h.
4894         (bcache::expand_hash_table): Rename from expand_hash_table.
4895         (bcache): Remove.
4896         (bcache::insert): Rename from bcache_full.
4897         (bcache::compare): Rename from bcache_compare.
4898         (bcache_xmalloc): Remove.
4899         (bcache::~bcache): Rename from bcache_xfree.
4900         (bcache::print_statistics): Rename from print_bcache_statistics.
4901         (bcache::memory_used): Rename from bcache_memory_used.
4902
4903 2019-03-07  Pedro Alves  <palves@redhat.com>
4904
4905         * infrun.c (normal_stop): Also check for
4906         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4907
4908 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * f-lang.c (value_from_host_double): Moved to...
4911         * value.c (value_from_host_double): ...here.
4912         * value.h (value_from_host_double): Declare.
4913         * guile/scm-math.c (vlscm_convert_typed_number): Use
4914         value_from_host_double.
4915         (vlscm_convert_number): Likewise.
4916         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4917         * python/py-value.c (convert_value_from_python): Likewise.
4918
4919 2019-03-06  Tom Tromey  <tom@tromey.com>
4920
4921         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4922
4923 2019-03-06  Tom Tromey  <tom@tromey.com>
4924
4925         * utils.h (free_current_contents): Don't declare.
4926         * utils.c (free_current_contents): Remove.
4927
4928 2019-03-06  Tom Tromey  <tom@tromey.com>
4929
4930         * top.c (quit_force): Update.
4931         * main.c (captured_command_loop): Update.
4932         * common/new-op.c (operator new): Update.
4933         * common/common-exceptions.c (struct catcher)
4934         <save_cleanup_chain>: Remove member.
4935         (exceptions_state_mc_init): Update.
4936         (exception_try_scope_entry): Return nullptr.
4937         (exception_try_scope_exit, exception_rethrow)
4938         (throw_exception_sjlj, throw_exception_cxx): Update.
4939         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4940         (all_cleanups, do_cleanups, discard_cleanups)
4941         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4942         (restore_cleanups, restore_final_cleanups): Don't declare.
4943         (do_final_cleanups): Remove parameter.
4944         * common/cleanups.c (cleanup_chain, make_cleanup)
4945         (make_cleanup_dtor, all_cleanups, do_cleanups)
4946         (discard_my_cleanups, discard_cleanups)
4947         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4948         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4949         (null_cleanup): Remove.
4950         (do_final_cleanups): Remove parameter.
4951
4952 2019-03-06  Tom Tromey  <tom@tromey.com>
4953
4954         * remote.c (remote_target::remote_parse_stop_reply): Use
4955         unique_xmalloc_ptr.
4956
4957 2019-03-06  Tom Tromey  <tom@tromey.com>
4958
4959         * stabsread.c (struct stabs_field_info): Rename from field_info.
4960         <list, fnlist>: Add initializers.
4961         <obstack>: New member.
4962         (read_member_functions, read_struct_fields, read_baseclasses):
4963         Allocate on obstack.  Don't use cleanups.
4964         (read_one_struct_field, read_member_functions, read_struct_fields)
4965         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4966         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4967         (read_struct_type): Update.
4968
4969 2019-03-06  Tom Tromey  <tom@tromey.com>
4970
4971         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4972         * common/filestuff.h (make_cleanup_close): Don't declare.
4973         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4974         Remove.
4975
4976 2019-03-06  Tom Tromey  <tom@tromey.com>
4977
4978         * solib-aix.c: Use make_scope_exit.
4979
4980 2019-03-06  Tom Tromey  <tom@tromey.com>
4981
4982         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4983         Use make_scope_exit.
4984
4985 2019-03-06  Tom Tromey  <tom@tromey.com>
4986
4987         * solib-svr4.c (disable_probes_interface): Remove parameter.
4988         (svr4_handle_solib_event): Use make_scope_exit.
4989
4990 2019-03-06  Tom Tromey  <tom@tromey.com>
4991
4992         * remote.c (struct stop_reply_deleter): Remove.
4993         (stop_reply_up): Update.
4994         (struct stop_reply): Derive from notif_event.  Don't typedef.
4995         <regcache>: Now a std::vector.
4996         (stop_reply_xfree): Remove.
4997         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4998         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4999         (remote_target::discard_pending_stop_replies): Use delete.
5000         (remote_target::remote_parse_stop_reply): Update.
5001         (remote_target::process_stop_reply): Update.
5002         * remote-notif.h (struct notif_event): Add virtual destructor.
5003         Remove "dtr" member.
5004         (struct notif_client) <alloc_event>: Return a unique_ptr.
5005         (notif_event_xfree): Don't declare.
5006         (notif_event_up): New typedef.
5007         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5008         (notif_event_xfree, do_notif_event_xfree): Remove.
5009         (remote_notif_state_xfree): Update.
5010
5011 2019-03-06  Tom Tromey  <tom@tromey.com>
5012
5013         * infrun.c (displaced_step_clear_cleanup): Now a
5014         forward_scope_exit type.
5015         (displaced_step_prepare_throw): Update.
5016         (displaced_step_fixup): Update.
5017
5018 2019-03-06  Tom Tromey  <tom@tromey.com>
5019
5020         * inferior.h (class inferior): Update comment.
5021         * gdbthread.h (class thread_info): Update comment.
5022
5023 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5024             Tom Tromey  <tom@tromey.com>
5025
5026         * stabsread.h (struct stab_section_list): Remove.
5027         (coffstab_build_psymtabs): Update.
5028         * dbxread.c (symbuf_sections): Now a std::vector.
5029         (sect_idx): New global.
5030         (fill_symbuf): Update.
5031         (coffstab_build_psymtabs): Change type of stabsects parameter.
5032         Update.
5033         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5034         std::vector.
5035         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5036         (coff_locate_sections): Update.
5037         (coff_symfile_read): Remove cleanups.  Update.
5038         (init_stringtab): Add storage parameter.
5039         (free_stringtab, free_stringtab_cleanup): Remove.
5040         (init_lineno): Add storage parameter.
5041         (free_linetab, free_linetab_cleanup): Remove.
5042
5043 2019-03-06  Pedro Alves  <palves@redhat.com>
5044
5045         * linux-fork.c (fork_info::clobber_regs): Delete.
5046         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5047         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5048         comment.  Adjust.
5049         (scoped_switch_fork_info::scoped_switch_fork_info)
5050         (checkpoint_command, linux_fork_context): Adjust
5051         fork_save_infrun_state calls.
5052
5053 2019-03-06  Pedro Alves  <palves@redhat.com>
5054
5055         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5056         (inf_has_multiple_threads): Return 'bool' and rewrite using
5057         inferior_info::threads().
5058
5059 2019-03-06  Pedro Alves  <palves@redhat.com>
5060
5061         * linux-fork.c: Include <list>.
5062         (fork_list): Now a std::list instance.
5063         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5064         (forks_exist_p, find_last_fork): Adjust.
5065         (new_fork): Delete.
5066         (one_fork_p): New.
5067         (add_fork): Adjust.
5068         (free_fork): Delete, folded into fork_info::~fork_info().
5069         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5070         Adjust.
5071         (init_fork_list): Delete.
5072         (linux_fork_killall, linux_fork_mourn_inferior)
5073         (linux_fork_detach, info_checkpoints_command): Adjust.
5074         (_initialize_linux_fork): No longer call init_fork_list.
5075
5076 2019-03-06  Pedro Alves  <palves@redhat.com>
5077
5078         * linux-fork.c (new_fork): New, split out of ...
5079         (add_fork): ... this.  Return void.  Move "first fork" special
5080         case from here, to ...
5081         (checkpoint_command): ... here.
5082         * linux-linux.h (add_fork): Return void.
5083
5084 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5087
5088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5089             Chris January  <chris.january@arm.com>
5090             David Lecomber  <david.lecomber@arm.com>
5091
5092         * f-exp.y: New token, UNOP_INTRINSIC.
5093         (exp): New pattern using UNOP_INTRINSIC token.
5094         (f77_keywords): Add 'abs' keyword.
5095         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5096         (value_from_host_double): New function.
5097         (evaluate_subexp_f): Support UNOP_ABS.
5098
5099 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5102         types.
5103
5104 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5107         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5108         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5109
5110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5113
5114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5115             Chris January  <chris.january@arm.com>
5116
5117         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5118         * f-exp.y: Define 'KIND' token.
5119         (exp): New pattern for KIND expressions.
5120         (ptype): Handle types with a kind extension.
5121         (direct_abs_decl): Extend to spot kind extensions.
5122         (f77_keywords): Add 'kind' to the list.
5123         (push_kind_type): New function.
5124         (convert_to_kind_type): New function.
5125         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5126         * parse.c (operator_length_standard): Likewise.
5127         * parser-defs.h (enum type_pieces): Add tp_kind.
5128         * std-operator.def: Add UNOP_KIND.
5129
5130 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5131
5132         * f-exp.y (f_parse): Set yydebug.
5133
5134 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * f-lang.c (evaluate_subexp_f): New function.
5137         (exp_descriptor_f): New global.
5138         (f_language_defn): Use exp_descriptor_f instead of
5139         exp_descriptor_standard.
5140
5141 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         * f-exp.y (struct token): Add comments.
5144         (dot_ops): Remove uppercase versions and the end marker.
5145         (f77_keywords): Likewise.
5146         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5147         entries in the dot_ops array are case insensitive, and use
5148         strncasecmp to compare strings.  Also some whitespace cleanup in
5149         this area.  Similar for the f77_keywords array, except entries in
5150         this list might be case sensitive.
5151
5152 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * f-exp.y (struct f77_boolean_val): Add comments.
5155         (boolean_values): Remove uppercase versions, and end marker.
5156         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5157         and use strncasecmp to achieve case insensitivity.  Additionally,
5158         perform whitespace cleanup around this code.
5159
5160 2019-03-06  Tom Tromey  <tromey@adacore.com>
5161
5162         * remote-sim.c (gdbsim_target_open): Use result of
5163         gdb_argv::release.
5164
5165 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5166         Dirk Schubert  <dirk.schubert@arm.com>
5167         Chris January  <chris.january@arm.com>
5168
5169         * eval.c (evaluate_subexp_standard): Call Fortran argument
5170         wrapping logic.
5171         * f-lang.c (struct value): A value which can be passed into a
5172         Fortran function call.
5173         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5174         where appropriate.
5175         (struct type): Value ready for a Fortran function call.
5176         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5177         is needed.
5178         * f-lang.h (fortran_argument_convert): Declaration.
5179         (fortran_preserve_arg_pointer): Declaration.
5180         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5181
5182 2019-03-05  Tom Tromey  <tromey@adacore.com>
5183
5184         * python/py-prettyprint.c (print_string_repr): Remove #if.
5185         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5186
5187 2019-03-05  Tom Tromey  <tromey@adacore.com>
5188
5189         * target.c (the_dummy_target): Move later.  Change type to
5190         "dummy_target".
5191         (initialize_targets): Don't initialize the_dummy_target.
5192
5193 2019-03-05  Tom Tromey  <tromey@adacore.com>
5194
5195         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5196         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5197
5198 2019-03-05  Tom Tromey  <tromey@adacore.com>
5199
5200         * windows-nat.c (windows_nat_target::attach)
5201         (windows_nat_target::detach): Don't call gdb_flush.
5202         * valprint.c (generic_val_print, val_print, val_print_string):
5203         Don't call gdb_flush.
5204         * utils.c (defaulted_query): Don't call gdb_flush.
5205         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5206         * target.c (target_announce_detach): Don't call gdb_flush.
5207         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5208         * remote.c (extended_remote_target::attach): Don't call
5209         gdb_flush.
5210         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5211         * printcmd.c (do_examine): Don't call gdb_flush.
5212         (info_display_command): Don't call gdb_flush.
5213         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5214         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5215         * memattr.c (info_mem_command): Don't call gdb_flush.
5216         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5217         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5218         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5219         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5220         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5221         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5222         (gnu_nat_target::detach): Don't call gdb_flush.
5223         * f-valprint.c (f_val_print): Don't call gdb_flush.
5224         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5225         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5226         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5227         gdb_flush.
5228         * c-valprint.c (c_val_print): Don't call gdb_flush.
5229         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5230
5231 2019-03-05  Tom Tromey  <tromey@adacore.com>
5232
5233         * varobj.c (update_dynamic_varobj_children): Update.
5234         (install_default_visualizer): Use reset, not release.
5235         * value.c (set_internalvar): Update.
5236         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5237         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5238         ATTRIBUTE_UNUSED_RESULT.
5239
5240 2019-03-05  Tom Tromey  <tromey@adacore.com>
5241
5242         * remote.c (class scoped_remote_fd) <release>: Add
5243         ATTRIBUTE_UNUSED_RESULT.
5244
5245 2019-03-05  Tom Tromey  <tromey@adacore.com>
5246
5247         * macroexp.c (struct macro_buffer) <release>: Add
5248         ATTRIBUTE_UNUSED_RESULT.
5249
5250 2019-03-05  Tom Tromey  <tromey@adacore.com>
5251
5252         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5253         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5254         ATTRIBUTE_UNUSED_RESULT.
5255
5256 2019-03-05  Tom Tromey  <tromey@adacore.com>
5257
5258         * common/scoped_fd.h (class scoped_fd) <release>: Add
5259         ATTRIBUTE_UNUSED_RESULT.
5260
5261 2019-03-05  Tom Tromey  <tromey@adacore.com>
5262
5263         * parser-defs.h (struct parser_state) <release>: Add
5264         ATTRIBUTE_UNUSED_RESULT.
5265
5266 2019-03-05  Tom Tromey  <tromey@adacore.com>
5267
5268         * utils.h (class gdb_argv) <release>: Add
5269         ATTRIBUTE_UNUSED_RESULT.
5270         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5271
5272 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5273
5274         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5275         for-loop range, to avoid compiler warnings.
5276
5277         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5278         avoid compiler warnings about unused variables.
5279
5280         * NEWS: Mention end of support for native debugging on MS-Windows
5281         before XP.
5282
5283         PR gdb/24292
5284         * common/netstuff.c:
5285         * gdbserver/gdbreplay.c
5286         * gdbserver/remote-utils.c:
5287         * ser-tcp.c:
5288         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5289         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5290         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5291         'getaddrinfo' and 'freeaddrinfo' were not available before
5292         Windows XP, and mingw.org's MinGW headers by default define
5293         _WIN32_WINNT to 0x500.
5294
5295 2019-03-01  Gary Benson <gbenson@redhat.com>
5296
5297         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5298
5299 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5300             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5301
5302         PR gdb/8527
5303         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5304         set_sigint_trap, clear_sigint_trap.
5305
5306 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5307
5308         * target.c (target_detach): Clear the regcache and the
5309         frame cache.
5310
5311 2019-02-27  Pedro Alves  <palves@redhat.com>
5312
5313         * utils.c (set_screen_size): When we cap the height/width sizes,
5314         tweak the corresponding command variable to show "unlimited":
5315
5316 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5317             Pedro Alves  <palves@redhat.com>
5318
5319         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5320         before calling rl_set_screen_size.
5321
5322 2019-02-27  Tom Tromey  <tromey@adacore.com>
5323
5324         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5325         define.
5326         * python/py-value.c: Remove Python 2.4 workaround.
5327         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5328         workaround.
5329         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5330         Python 2.4 workaround.
5331         * python/python-internal.h: Remove Python 2.4 comment.
5332         (Py_ssize_t): Don't define.
5333         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5334         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5335         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5336         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5337         * python/python.c (do_start_initialization): Remove Python 2.4
5338         workaround.
5339         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5340         (print_children): Remove Python 2.4 workaround.
5341         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5342         workaround.
5343         (CHARBUFFERPROC_NAME): Remove.
5344         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5345         Python 2.4 workaround.
5346
5347 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5348
5349         * NEWS: Note minimum Python version.
5350
5351 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5352
5353         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5354         code from these functions.  Remove corresponding ifdefs.  Use
5355         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5356         Remove gotos and target of gotos.
5357         (infpy_search_memory): Likewise.
5358
5359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5362         (hppa_gdbarch_init): Don't register deleted functions with
5363         gdbarch.
5364
5365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5368         (h8300_unwind_sp): Delete.
5369         (h8300_dummy_id): Delete.
5370         (h8300_gdbarch_init): Don't register deleted functions with
5371         gdbarch.
5372
5373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5376         (ft32_unwind_pc): Delete.
5377         (ft32_unwind_sp): Delete.
5378         (ft32_gdbarch_init): Don't register deleted functions with
5379         gdbarch.
5380
5381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5384         (frv_unwind_pc): Delete.
5385         (frv_unwind_sp): Delete.
5386         (frv_gdbarch_init): Don't register deleted functions with
5387         gdbarch.
5388
5389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5392         (riscv_unwind_pc): Delete.
5393         (riscv_unwind_sp): Delete.
5394         (riscv_gdbarch_init): Don't register deleted functions with
5395         gdbarch.
5396
5397 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5400         (csky_unwind_pc): Delete.
5401         (csky_unwind_sp): Delete.
5402         (csky_gdbarch_init): Don't register deleted functions with
5403         gdbarch.
5404
5405 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5408         (cris_unwind_pc): Delete.
5409         (cris_unwind_sp): Delete.
5410         (cris_gdbarch_init): Don't register deleted functions with
5411         gdbarch.
5412
5413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5414
5415         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5416         (bfin_unwind_pc): Delete.
5417         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5418
5419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5420
5421         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5422         (arm_unwind_pc): Delete.
5423         (arm_unwind_sp): Delete.
5424         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5425
5426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5427
5428         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5429         (arc_unwind_pc): Delete.
5430         (arc_unwind_sp): Delete.
5431         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5432
5433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5436         (alpha_unwind_pc): Delete.
5437         (alpha_gdbarch_init): Don't register deleted functions with
5438         gdbarch.
5439
5440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5443         (aarch64_unwind_pc): Delete.
5444         (aarch64_unwind_sp): Delete.
5445         (aarch64_gdbarch_init): Don't register deleted functions with
5446         gdbarch.
5447
5448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5449
5450         * gdbtypes.c (type_align): Don't consider static members when
5451         computing structure alignment.
5452
5453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5454
5455         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5456         return 0 for other types.
5457         * arch-utils.c (default_type_align): Always return 0.
5458         * gdbarch.h: Regenerate.
5459         * gdbarch.sh (type_align): Extend comment.
5460         * gdbtypes.c (type_align): Add additional comments, always call
5461         gdbarch_type_align before applying the default rules.
5462         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5463         generic code will then apply a suitable default.
5464         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5465         types, return 0 for other types.
5466
5467 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5468
5469         * NEWS: Create a new section for the next release branch.
5470         Rename the section of the current branch, now that it has
5471         been cut.
5472
5473 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5474
5475         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5476         * version.in: Bump version to 8.3.50.DATE-git.
5477
5478 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5479
5480         * aix-thread.c (ptid_cmp): Remove unused variable.
5481         (get_signaled_thread): Likewise.
5482         (store_regs_user_thread): Likewise.
5483         (store_regs_kernel_thread): Likewise.
5484         (fetch_regs_kernel_thread): Remove shadowed variable.
5485
5486 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * features/riscv/32bit-cpu.xml: Add register numbers.
5489         * features/riscv/32bit-fpu.c: Regenerate.
5490         * features/riscv/32bit-fpu.xml: Add register numbers.
5491         * features/riscv/64bit-cpu.xml: Add register numbers.
5492         * features/riscv/64bit-fpu.c: Regenerate.
5493         * features/riscv/64bit-fpu.xml: Add register numbers.
5494
5495 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5496
5497         * NEWS: Mention two argument form of gdb.Value constructor.
5498         * python/py-value.c (convert_buffer_and_type_to_value): New
5499         function.
5500         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5501         Add support for handling an optional second argument.  Call
5502         convert_buffer_and_type_to_value as appropriate.
5503         * python/python-internal.h (Py_buffer_deleter): New struct.
5504         (Py_buffer_up): New typedef.
5505
5506 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5507
5508         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5509         instead of releasing ownership.
5510
5511 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5512
5513         * dwarf2read.c (open_and_init_dwp_file): Call
5514         elf_numsections instead of bfd_count_sections to initialize
5515         dwp_file->num_sections.
5516
5517 2019-02-25  Tom Tromey  <tromey@adacore.com>
5518
5519         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5520
5521 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5522
5523         * gcore.in: Add '--readnever' option when invoking GDB.
5524
5525 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5526
5527         * MAINTAINERS: Update my email address.
5528
5529 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5530
5531         * build-id.c (build_id_to_debug_bfd_1): New function.
5532         (build_id_to_debug_bfd): Look for separate debug file in
5533         sysroot.
5534
5535 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * gdbarch.sh: Update the copyright year range that is placed into
5538         generated files.
5539
5540 2019-02-22  Keith Seitz  <keiths@redhat.com>
5541
5542         PR symtab/23853
5543         * linespec.c (create_sals_line_offset): Search for the default
5544         symtab's filename instead of its fullname.
5545
5546 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5547
5548         * NEWS: Update style defaults.
5549
5550 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5551
5552         * main.c (captured_main_1): Disable styling in batch mode.
5553
5554 2019-02-20  Tom Tromey  <tom@tromey.com>
5555
5556         * symtab.c (symtab_symbol_info): Fix typos.
5557
5558 2019-02-20  Tom Tromey  <tromey@adacore.com>
5559
5560         * findcmd.c (_initialize_mem_search): Use upper case for
5561         metasyntactic variables.
5562
5563 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5564
5565         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5566         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5567
5568 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5569
5570         * top.h (source_file_name): Change to std::string.
5571         * top.c (source_file_name): Likewise.
5572         (command_line_input): Adjust.
5573         * cli/cli-script.c (script_from_file): Adjust.
5574
5575 2019-02-19  Tom Tromey  <tromey@adacore.com>
5576
5577         * ravenscar-thread.c
5578         (ravenscar_thread_target::update_thread_list): Don't call
5579         ada_build_task_list.
5580         * ada-lang.h (ada_build_task_list): Don't declare.
5581         * ada-tasks.c (struct ada_tasks_inferior_data)
5582         <task_list_valid_p>: Now bool.
5583         (read_known_tasks, ada_task_list_changed)
5584         (ada_tasks_invalidate_inferior_data): Update.
5585         (read_known_tasks_array): Return bool.
5586         (read_known_tasks_list): Likewise.
5587         (read_known_tasks): Return void.
5588         (ada_build_task_list): Now static.
5589
5590 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5591
5592         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5593         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5594
5595 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5596
5597         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5598         variant for ada_tasks_pspace_data_handle and
5599         ada_tasks_inferior_data_handle.
5600         (ada_tasks_pspace_data_cleanup): New function.
5601         (ada_tasks_inferior_data_cleanup): New function.
5602
5603 2019-02-17  Tom Tromey  <tom@tromey.com>
5604
5605         * macrotab.h (macro_source_fullname): Return a std::string.
5606         * macrotab.c (macro_include, check_for_redefinition)
5607         (macro_undef, macro_lookup_definition, foreach_macro)
5608         (foreach_macro_in_scope): Update.
5609         (macro_source_fullname): Return a std::string.
5610         * macrocmd.c (show_pp_source_pos): Update.
5611
5612 2019-02-17  Tom Tromey  <tom@tromey.com>
5613
5614         * macrocmd.c (show_pp_source_pos): Style the file names.
5615
5616 2019-02-17  Tom Tromey  <tom@tromey.com>
5617
5618         PR tui/24197:
5619         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5620
5621 2019-02-17  Tom Tromey  <tom@tromey.com>
5622
5623         * ada-lang.c (user_select_syms): Use filtered printing.
5624         * utils.c (wrap_style): New global.
5625         (desired_style): Remove.
5626         (emit_style_escape): Add stream parameter.
5627         (set_output_style, reset_terminal_style, prompt_for_continue):
5628         Update.
5629         (flush_wrap_buffer): Only flush gdb_stdout.
5630         (wrap_here): Set wrap_style.
5631         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5632         treat escape sequences as a character.  Change when wrap buffer is
5633         flushed.
5634         (fputs_styled): Do not set the output style when the default is
5635         requested.
5636         * ui-style.h (struct ui_file_style) <is_default>: New method.
5637         * source.c (print_source_lines_base): Emit escape sequences in one
5638         piece.
5639
5640 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5641
5642         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5643         integers and enumeration types.
5644
5645 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5646
5647         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5648         instead of lookup_symbol_in_language
5649         (do_exact_match): New function.
5650         (ada_get_symbol_name_matcher): Return do_exact_match when
5651         doing a verbatim match.
5652
5653 2019-02-15  Tom Tromey  <tromey@adacore.com>
5654
5655         * ravenscar-thread.c (ravenscar_thread_target::resume)
5656         (ravenscar_thread_target::wait): Special case wildcard requests.
5657
5658 2019-02-15  Tom Tromey  <tromey@adacore.com>
5659
5660         * ravenscar-thread.c (base_ptid): Remove.
5661         (struct ravenscar_thread_target) <close>: New method.
5662         <m_base_ptid>: New member.
5663         <update_inferior_ptid, active_task, task_is_currently_active,
5664         runtime_initialized>: Declare methods.
5665         <ravenscar_thread_target>: Add constructor.
5666         (ravenscar_thread_target::task_is_currently_active)
5667         (ravenscar_thread_target::update_inferior_ptid)
5668         (ravenscar_runtime_initialized): Rename.  Now methods.
5669         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5670         (ravenscar_thread_target::update_thread_list): Update.
5671         (ravenscar_thread_target::active_task): Now method.
5672         (ravenscar_thread_target::store_registers)
5673         (ravenscar_thread_target::prepare_to_store)
5674         (ravenscar_thread_target::prepare_to_store)
5675         (ravenscar_thread_target::mourn_inferior): Update.
5676         (ravenscar_inferior_created): Use "new" to create target.
5677         (ravenscar_thread_target::get_ada_task_ptid): Update.
5678         (_initialize_ravenscar): Don't initialize base_ptid.
5679         (ravenscar_ops): Remove global.
5680
5681 2019-02-15  Tom Tromey  <tromey@adacore.com>
5682
5683         * target.h (push_target): Declare new overload.
5684         * target.c (push_target): New overload, taking an rvalue reference.
5685         * remote.c (remote_target::open_1): Use push_target overload.
5686         * corelow.c (core_target_open): Use push_target overload.
5687
5688 2019-02-15  Tom Tromey  <tromey@adacore.com>
5689
5690         * ravenscar-thread.c (is_ravenscar_task)
5691         (ravenscar_task_is_currently_active): Return bool.
5692         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5693         (_initialize_ravenscar): Remove "(void)".
5694         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5695         Return bool.
5696
5697 2019-02-15  Tom Tromey  <tromey@adacore.com>
5698
5699         * ravenscar-thread.c (ravenscar_runtime_initializer)
5700         (has_ravenscar_runtime, get_running_thread_id)
5701         (ravenscar_thread_target::resume): Fix indentation.
5702
5703 2019-02-15  Tom Tromey  <tromey@adacore.com>
5704
5705         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5706         from ravenscar_arch_ops.
5707         (sparc_ravenscar_ops::fetch_registers)
5708         (sparc_ravenscar_ops::store_registers): Now methods.
5709         (sparc_ravenscar_prepare_to_store): Remove.
5710         (sparc_ravenscar_ops): Redefine.
5711         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5712         methods and destructor.  Remove members.
5713         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5714         (ravenscar_thread_target::store_registers)
5715         (ravenscar_thread_target::prepare_to_store): Update.
5716         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5717         Remove.
5718         (struct ppc_ravenscar_powerpc_ops): Derive from
5719         ravenscar_arch_ops.
5720         (ppc_ravenscar_powerpc_ops::fetch_registers)
5721         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5722         (ppc_ravenscar_powerpc_ops): Redefine.
5723         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5724         (ppc_ravenscar_e500_ops::fetch_registers)
5725         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5726         (ppc_ravenscar_e500_ops): Redefine.
5727         * aarch64-ravenscar-thread.c
5728         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5729         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5730         (aarch64_ravenscar_fetch_registers)
5731         (aarch64_ravenscar_store_registers): Now methods.
5732         (aarch64_ravenscar_ops): Redefine.
5733
5734 2019-02-15  Tom Tromey  <tromey@adacore.com>
5735
5736         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5737         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5738         (ravenscar_thread_target::stopped_by_watchpoint)
5739         (ravenscar_thread_target::stopped_data_address)
5740         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5741
5742 2019-02-15  Tom Tromey  <tromey@adacore.com>
5743
5744         * ravenscar-thread.c: Fix some typos.
5745
5746 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5747             Tom Tromey  <tromey@adacore.com>
5748
5749         * ada-lang.c (ada_exception_sal): Change addr_string to a
5750         std::string.
5751         (create_ada_exception_catchpoint): Update.
5752
5753 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5754             Tom Tromey  <tromey@adacore.com>
5755
5756         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5757         (bp_location_ops): Remove.
5758         (base_breakpoint_allocate_location): Update.
5759         (free_bp_location): Update.
5760         * ada-lang.c (class ada_catchpoint_location)
5761         <ada_catchpoint_location>: Remove ops parameter.
5762         (ada_catchpoint_location_dtor): Remove.
5763         (ada_catchpoint_location_ops): Remove.
5764         (allocate_location_exception): Update.
5765         * breakpoint.h (struct bp_location_ops): Remove.
5766         (class bp_location) <bp_location>: Remove bp_location_ops
5767         parameter.
5768         <~bp_location>: Add destructor.
5769         <ops>: Remove.
5770
5771 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5772             Pedro Alves  <palves@redhat.com>
5773
5774         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5775         'PATH_MAX'.
5776
5777 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5778             Samuel Thibault  <samuel.thibault@gnu.org>
5779             Thomas Schwinge  <thomas@codesourcery.com>
5780
5781         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5782         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5783
5784 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5785
5786         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5787         (check_empty): Use "const char *".
5788
5789         * gnu-nat.c (gnu_nat_target::detach): Instead of
5790         'detach_inferior (pid)' call
5791         'detach_inferior (find_inferior_pid (pid))'.
5792
5793         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5794         'nat/fork-inferior.o'.
5795         * gnu-nat.c: #include "nat/fork-inferior.h".
5796
5797         * gnu-nat.c (gnu_nat_target::detach): Instead of
5798         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5799         * gnu-nat.h: #include "inf-child.h".
5800         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5801         'i386_gnu_nat_target::fetch_registers'.
5802         (gnu_store_registers): Rename/move to
5803         'i386_gnu_nat_target::store_registers'.
5804
5805         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5806         * gnu-nat.h (mach_thread_info): New function.
5807         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5808
5809         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5810
5811 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5812
5813         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5814
5815 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5816
5817         * windows-nat.c (windows_add_thread): Add new parameter
5818         "main_thread_p" with default value set to false.  Update
5819         function documentation as well as all callers.
5820         (windows_delete_thread): Likewise.
5821         (fake_create_process): Update call to windows_add_thread.
5822         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5823         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5824         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5825         call to windows_delete_thread.
5826
5827 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5828
5829         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5830
5831 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5832
5833         * symfile.c (find_separate_debug_file): Use canonical path of
5834         sysroot with child_path instead of gdb_sysroot if it is valid.
5835
5836 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5837
5838         * symfile.c (find_separate_debug_file): Use child_path to
5839         determine if an object file is under a sysroot.
5840
5841 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5842
5843         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5844         unittests/child-path-selftests.c.
5845         * common/pathstuff.c (child_path): New function.
5846         * common/pathstuff.h (child_path): New prototype.
5847         * unittests/child-path-selftests.c: New file.
5848
5849 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5850
5851         * symfile.c (find_separate_debug_file): Look for separate debug
5852         files in debug directories under the sysroot.
5853
5854 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5855
5856         * symtab.h (struct minimal_symbol data_p): New const method.
5857         (struct minimal_symbol text_p): Likewise.
5858         * symtab.c (output_source_filename): Use file name style
5859         to print file name.
5860         (print_symbol_info): Likewise.
5861         (print_msymbol_info): Use address style to print addresses.
5862         Use function name style to print executable text symbols.
5863         (expand_symtab_containing_pc): Use data_p.
5864         (find_pc_sect_compunit_symtab): Likewise.
5865
5866 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5867
5868         * breakpoint.c (describe_other_breakpoints): Use address style
5869         to print addresses.
5870         (say_where): Likewise.
5871
5872 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5873
5874         * ada-typeprint.c (print_func_type): Print function name
5875         style to print function name.
5876         * c-typeprint.c (c_print_type_1): Likewise.
5877
5878 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5879
5880         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5881         for execve.
5882
5883 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5884
5885         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5886         type_stack.
5887
5888 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5889
5890         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5891         TYPE_CODE_REF types.
5892
5893 2019-02-08  Jim Wilson  <jimw@sifive.com>
5894
5895         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5896         (riscv_linux_fregset): New.
5897         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5898
5899 2019-02-07  Tom Tromey  <tom@tromey.com>
5900
5901         * thread.c (thread_cancel_execution_command): Update.
5902         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5903         methods.
5904         (struct thread_fsm_ops): Remove.
5905         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5906         (thread_fsm_should_stop, thread_fsm_return_value)
5907         (thread_fsm_set_finished, thread_fsm_finished_p)
5908         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5909         Don't declare.
5910         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5911         * infrun.c (clear_proceed_status_thread)
5912         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5913         (print_stop_event): Update.
5914         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5915         Add constructor.
5916         (step_command_fsm_ops): Remove.
5917         (new_step_command_fsm): Remove.
5918         (step_1): Update.
5919         (step_command_fsm::should_stop): Rename from
5920         step_command_fsm_should_stop.
5921         (step_command_fsm::clean_up): Rename from
5922         step_command_fsm_clean_up.
5923         (step_command_fsm::do_async_reply_reason): Rename from
5924         step_command_fsm_async_reply_reason.
5925         (struct until_next_fsm): Inherit from thread_fsm.  Add
5926         constructor.
5927         (until_next_fsm_ops): Remove.
5928         (new_until_next_fsm): Remove.
5929         (until_next_fsm::should_stop): Rename from
5930         until_next_fsm_should_stop.
5931         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5932         (until_next_fsm::do_async_reply_reason): Rename from
5933         until_next_fsm_async_reply_reason.
5934         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5935         constructor.  Change type of breakpoint.
5936         (finish_command_fsm_ops): Remove.
5937         (new_finish_command_fsm): Remove.
5938         (finish_command_fsm::should_stop): Rename from
5939         finish_command_fsm_should_stop.
5940         (finish_command_fsm::clean_up): Rename from
5941         finish_command_fsm_clean_up.
5942         (finish_command_fsm::return_value): Rename from
5943         finish_command_fsm_return_value.
5944         (finish_command_fsm::do_async_reply_reason): Rename from
5945         finish_command_fsm_async_reply_reason.
5946         (finish_command): Update.
5947         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5948         Add constructor.
5949         (call_thread_fsm_ops): Remove.
5950         (call_thread_fsm::call_thread_fsm): Rename from
5951         new_call_thread_fsm.
5952         (call_thread_fsm::should_stop): Rename from
5953         call_thread_fsm_should_stop.
5954         (call_thread_fsm::should_notify_stop): Rename from
5955         call_thread_fsm_should_notify_stop.
5956         (run_inferior_call, call_function_by_hand_dummy): Update.
5957         * cli/cli-interp.c (should_print_stop_to_console): Update.
5958         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5959         Add constructor.  Change type of location_breakpoint,
5960         caller_breakpoint.
5961         (until_break_fsm_ops): Remove.
5962         (new_until_break_fsm): Remove.
5963         (until_break_fsm::should_stop): Rename from
5964         until_break_fsm_should_stop.
5965         (until_break_fsm::clean_up): Rename from
5966         until_break_fsm_clean_up.
5967         (until_break_fsm::do_async_reply_reason): Rename from
5968         until_break_fsm_async_reply_reason.
5969         (until_break_command): Update.
5970         * thread-fsm.c: Remove.
5971         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5972
5973 2019-02-07  Tom Tromey  <tom@tromey.com>
5974
5975         * yy-remap.h: Add include guard.
5976         * xtensa-tdep.h: Add include guard.
5977         * xcoffread.h: Rename include guard.
5978         * varobj-iter.h: Add include guard.
5979         * tui/tui.h: Rename include guard.
5980         * tui/tui-winsource.h: Rename include guard.
5981         * tui/tui-wingeneral.h: Rename include guard.
5982         * tui/tui-windata.h: Rename include guard.
5983         * tui/tui-win.h: Rename include guard.
5984         * tui/tui-stack.h: Rename include guard.
5985         * tui/tui-source.h: Rename include guard.
5986         * tui/tui-regs.h: Rename include guard.
5987         * tui/tui-out.h: Rename include guard.
5988         * tui/tui-layout.h: Rename include guard.
5989         * tui/tui-io.h: Rename include guard.
5990         * tui/tui-hooks.h: Rename include guard.
5991         * tui/tui-file.h: Rename include guard.
5992         * tui/tui-disasm.h: Rename include guard.
5993         * tui/tui-data.h: Rename include guard.
5994         * tui/tui-command.h: Rename include guard.
5995         * tic6x-tdep.h: Add include guard.
5996         * target/waitstatus.h: Rename include guard.
5997         * target/wait.h: Rename include guard.
5998         * target/target.h: Rename include guard.
5999         * target/resume.h: Rename include guard.
6000         * target-float.h: Rename include guard.
6001         * stabsread.h: Add include guard.
6002         * rs6000-tdep.h: Add include guard.
6003         * riscv-fbsd-tdep.h: Add include guard.
6004         * regformats/regdef.h: Rename include guard.
6005         * record.h: Rename include guard.
6006         * python/python.h: Rename include guard.
6007         * python/python-internal.h: Rename include guard.
6008         * python/py-stopevent.h: Rename include guard.
6009         * python/py-ref.h: Rename include guard.
6010         * python/py-record.h: Rename include guard.
6011         * python/py-record-full.h: Rename include guard.
6012         * python/py-record-btrace.h: Rename include guard.
6013         * python/py-instruction.h: Rename include guard.
6014         * python/py-events.h: Rename include guard.
6015         * python/py-event.h: Rename include guard.
6016         * procfs.h: Add include guard.
6017         * proc-utils.h: Add include guard.
6018         * p-lang.h: Add include guard.
6019         * or1k-tdep.h: Rename include guard.
6020         * observable.h: Rename include guard.
6021         * nto-tdep.h: Rename include guard.
6022         * nat/x86-linux.h: Rename include guard.
6023         * nat/x86-linux-dregs.h: Rename include guard.
6024         * nat/x86-gcc-cpuid.h: Add include guard.
6025         * nat/x86-dregs.h: Rename include guard.
6026         * nat/x86-cpuid.h: Rename include guard.
6027         * nat/ppc-linux.h: Rename include guard.
6028         * nat/mips-linux-watch.h: Rename include guard.
6029         * nat/linux-waitpid.h: Rename include guard.
6030         * nat/linux-ptrace.h: Rename include guard.
6031         * nat/linux-procfs.h: Rename include guard.
6032         * nat/linux-osdata.h: Rename include guard.
6033         * nat/linux-nat.h: Rename include guard.
6034         * nat/linux-namespaces.h: Rename include guard.
6035         * nat/linux-btrace.h: Rename include guard.
6036         * nat/glibc_thread_db.h: Rename include guard.
6037         * nat/gdb_thread_db.h: Rename include guard.
6038         * nat/gdb_ptrace.h: Rename include guard.
6039         * nat/fork-inferior.h: Rename include guard.
6040         * nat/amd64-linux-siginfo.h: Rename include guard.
6041         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6042         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6043         * nat/aarch64-linux.h: Rename include guard.
6044         * nat/aarch64-linux-hw-point.h: Rename include guard.
6045         * mn10300-tdep.h: Add include guard.
6046         * mips-linux-tdep.h: Add include guard.
6047         * mi/mi-parse.h: Rename include guard.
6048         * mi/mi-out.h: Rename include guard.
6049         * mi/mi-main.h: Rename include guard.
6050         * mi/mi-interp.h: Rename include guard.
6051         * mi/mi-getopt.h: Rename include guard.
6052         * mi/mi-console.h: Rename include guard.
6053         * mi/mi-common.h: Rename include guard.
6054         * mi/mi-cmds.h: Rename include guard.
6055         * mi/mi-cmd-break.h: Rename include guard.
6056         * m2-lang.h: Add include guard.
6057         * location.h: Rename include guard.
6058         * linux-record.h: Rename include guard.
6059         * linux-nat.h: Add include guard.
6060         * linux-fork.h: Add include guard.
6061         * i386-darwin-tdep.h: Rename include guard.
6062         * hppa-linux-offsets.h: Add include guard.
6063         * guile/guile.h: Rename include guard.
6064         * guile/guile-internal.h: Rename include guard.
6065         * gnu-nat.h: Rename include guard.
6066         * gdb-stabs.h: Rename include guard.
6067         * frv-tdep.h: Add include guard.
6068         * f-lang.h: Add include guard.
6069         * event-loop.h: Add include guard.
6070         * darwin-nat.h: Rename include guard.
6071         * cp-abi.h: Rename include guard.
6072         * config/sparc/nm-sol2.h: Rename include guard.
6073         * config/nm-nto.h: Rename include guard.
6074         * config/nm-linux.h: Add include guard.
6075         * config/i386/nm-i386gnu.h: Rename include guard.
6076         * config/djgpp/nl_types.h: Rename include guard.
6077         * config/djgpp/langinfo.h: Rename include guard.
6078         * compile/gcc-cp-plugin.h: Add include guard.
6079         * compile/gcc-c-plugin.h: Add include guard.
6080         * compile/compile.h: Rename include guard.
6081         * compile/compile-object-run.h: Rename include guard.
6082         * compile/compile-object-load.h: Rename include guard.
6083         * compile/compile-internal.h: Rename include guard.
6084         * compile/compile-cplus.h: Rename include guard.
6085         * compile/compile-c.h: Rename include guard.
6086         * common/xml-utils.h: Rename include guard.
6087         * common/x86-xstate.h: Rename include guard.
6088         * common/version.h: Rename include guard.
6089         * common/vec.h: Rename include guard.
6090         * common/tdesc.h: Rename include guard.
6091         * common/selftest.h: Rename include guard.
6092         * common/scoped_restore.h: Rename include guard.
6093         * common/scoped_mmap.h: Rename include guard.
6094         * common/scoped_fd.h: Rename include guard.
6095         * common/safe-iterator.h: Rename include guard.
6096         * common/run-time-clock.h: Rename include guard.
6097         * common/refcounted-object.h: Rename include guard.
6098         * common/queue.h: Rename include guard.
6099         * common/ptid.h: Rename include guard.
6100         * common/print-utils.h: Rename include guard.
6101         * common/preprocessor.h: Rename include guard.
6102         * common/pathstuff.h: Rename include guard.
6103         * common/observable.h: Rename include guard.
6104         * common/netstuff.h: Rename include guard.
6105         * common/job-control.h: Rename include guard.
6106         * common/host-defs.h: Rename include guard.
6107         * common/gdb_wait.h: Rename include guard.
6108         * common/gdb_vecs.h: Rename include guard.
6109         * common/gdb_unlinker.h: Rename include guard.
6110         * common/gdb_unique_ptr.h: Rename include guard.
6111         * common/gdb_tilde_expand.h: Rename include guard.
6112         * common/gdb_sys_time.h: Rename include guard.
6113         * common/gdb_string_view.h: Rename include guard.
6114         * common/gdb_splay_tree.h: Rename include guard.
6115         * common/gdb_setjmp.h: Rename include guard.
6116         * common/gdb_ref_ptr.h: Rename include guard.
6117         * common/gdb_optional.h: Rename include guard.
6118         * common/gdb_locale.h: Rename include guard.
6119         * common/gdb_assert.h: Rename include guard.
6120         * common/filtered-iterator.h: Rename include guard.
6121         * common/filestuff.h: Rename include guard.
6122         * common/fileio.h: Rename include guard.
6123         * common/environ.h: Rename include guard.
6124         * common/common-utils.h: Rename include guard.
6125         * common/common-types.h: Rename include guard.
6126         * common/common-regcache.h: Rename include guard.
6127         * common/common-inferior.h: Rename include guard.
6128         * common/common-gdbthread.h: Rename include guard.
6129         * common/common-exceptions.h: Rename include guard.
6130         * common/common-defs.h: Rename include guard.
6131         * common/common-debug.h: Rename include guard.
6132         * common/cleanups.h: Rename include guard.
6133         * common/buffer.h: Rename include guard.
6134         * common/btrace-common.h: Rename include guard.
6135         * common/break-common.h: Rename include guard.
6136         * cli/cli-utils.h: Rename include guard.
6137         * cli/cli-style.h: Rename include guard.
6138         * cli/cli-setshow.h: Rename include guard.
6139         * cli/cli-script.h: Rename include guard.
6140         * cli/cli-interp.h: Rename include guard.
6141         * cli/cli-decode.h: Rename include guard.
6142         * cli/cli-cmds.h: Rename include guard.
6143         * charset-list.h: Add include guard.
6144         * buildsym-legacy.h: Rename include guard.
6145         * bfin-tdep.h: Add include guard.
6146         * ax.h: Rename include guard.
6147         * arm-linux-tdep.h: Add include guard.
6148         * arm-fbsd-tdep.h: Add include guard.
6149         * arch/xtensa.h: Rename include guard.
6150         * arch/tic6x.h: Add include guard.
6151         * arch/i386.h: Add include guard.
6152         * arch/arm.h: Rename include guard.
6153         * arch/arm-linux.h: Rename include guard.
6154         * arch/arm-get-next-pcs.h: Rename include guard.
6155         * arch/amd64.h: Add include guard.
6156         * arch/aarch64-insn.h: Rename include guard.
6157         * arch-utils.h: Rename include guard.
6158         * annotate.h: Add include guard.
6159         * amd64-darwin-tdep.h: Rename include guard.
6160         * aarch64-linux-tdep.h: Add include guard.
6161         * aarch64-fbsd-tdep.h: Add include guard.
6162         * aarch32-linux-nat.h: Add include guard.
6163
6164 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6165
6166         * macrotab.c (macro_define_internal): New function that
6167         factorizes macro_define_object_internal and macro_define_function
6168         code.
6169         (macro_define_object_internal): Use macro_define_internal.
6170         (macro_define_function): Likewise.
6171
6172 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * macrocmd.c (extract_identifier): Return
6175         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6176         callers.
6177
6178 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6179
6180         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6181
6182 2019-02-05  Tom Tromey  <tom@tromey.com>
6183
6184         * target.c (target_stack::unpush): Move assertion earlier.
6185
6186 2019-01-30  Tom Tromey  <tom@tromey.com>
6187
6188         PR python/23615:
6189         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6190         (gdbpy_parse_and_eval): Likewise.
6191         * python/python-internal.h (gdbpy_allow_threads): New class.
6192
6193 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6194
6195         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6196         (aarch64_fbsd_fpregmap): Move earlier.
6197         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6198         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6199         instead of individual calls to trad_frame_set_reg_addr.
6200         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6201         earlier.
6202         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6203         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6204         instead of individual calls to trad_frame_set_reg_addr.
6205
6206 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6207
6208         * CONTRIBUTE: Replace contribution list with wiki link.
6209
6210 2019-01-25  Tom Tromey  <tom@tromey.com>
6211
6212         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6213
6214 2019-01-25  Tom Tromey  <tom@tromey.com>
6215
6216         * xtensa-linux-nat.c: Fix common/ includes.
6217         * xml-support.h: Fix common/ includes.
6218         * xml-support.c: Fix common/ includes.
6219         * x86-linux-nat.c: Fix common/ includes.
6220         * windows-nat.c: Fix common/ includes.
6221         * varobj.h: Fix common/ includes.
6222         * varobj.c: Fix common/ includes.
6223         * value.c: Fix common/ includes.
6224         * valops.c: Fix common/ includes.
6225         * utils.c: Fix common/ includes.
6226         * unittests/xml-utils-selftests.c: Fix common/ includes.
6227         * unittests/utils-selftests.c: Fix common/ includes.
6228         * unittests/unpack-selftests.c: Fix common/ includes.
6229         * unittests/tracepoint-selftests.c: Fix common/ includes.
6230         * unittests/style-selftests.c: Fix common/ includes.
6231         * unittests/string_view-selftests.c: Fix common/ includes.
6232         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6233         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6234         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6235         * unittests/rsp-low-selftests.c: Fix common/ includes.
6236         * unittests/parse-connection-spec-selftests.c: Fix common/
6237         includes.
6238         * unittests/optional-selftests.c: Fix common/ includes.
6239         * unittests/offset-type-selftests.c: Fix common/ includes.
6240         * unittests/observable-selftests.c: Fix common/ includes.
6241         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6242         * unittests/memrange-selftests.c: Fix common/ includes.
6243         * unittests/memory-map-selftests.c: Fix common/ includes.
6244         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6245         * unittests/function-view-selftests.c: Fix common/ includes.
6246         * unittests/environ-selftests.c: Fix common/ includes.
6247         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6248         * unittests/common-utils-selftests.c: Fix common/ includes.
6249         * unittests/cli-utils-selftests.c: Fix common/ includes.
6250         * unittests/array-view-selftests.c: Fix common/ includes.
6251         * ui-file.c: Fix common/ includes.
6252         * tui/tui-io.c: Fix common/ includes.
6253         * tracepoint.h: Fix common/ includes.
6254         * tracepoint.c: Fix common/ includes.
6255         * tracefile-tfile.c: Fix common/ includes.
6256         * top.h: Fix common/ includes.
6257         * top.c: Fix common/ includes.
6258         * thread.c: Fix common/ includes.
6259         * target/waitstatus.h: Fix common/ includes.
6260         * target/waitstatus.c: Fix common/ includes.
6261         * target.h: Fix common/ includes.
6262         * target.c: Fix common/ includes.
6263         * target-memory.c: Fix common/ includes.
6264         * target-descriptions.c: Fix common/ includes.
6265         * symtab.h: Fix common/ includes.
6266         * symfile.c: Fix common/ includes.
6267         * stap-probe.c: Fix common/ includes.
6268         * spu-linux-nat.c: Fix common/ includes.
6269         * sparc-nat.c: Fix common/ includes.
6270         * source.c: Fix common/ includes.
6271         * solib.c: Fix common/ includes.
6272         * solib-target.c: Fix common/ includes.
6273         * ser-unix.c: Fix common/ includes.
6274         * ser-tcp.c: Fix common/ includes.
6275         * ser-pipe.c: Fix common/ includes.
6276         * ser-base.c: Fix common/ includes.
6277         * selftest-arch.c: Fix common/ includes.
6278         * s12z-tdep.c: Fix common/ includes.
6279         * rust-exp.y: Fix common/ includes.
6280         * rs6000-aix-tdep.c: Fix common/ includes.
6281         * riscv-tdep.c: Fix common/ includes.
6282         * remote.c: Fix common/ includes.
6283         * remote-notif.h: Fix common/ includes.
6284         * remote-fileio.h: Fix common/ includes.
6285         * remote-fileio.c: Fix common/ includes.
6286         * regcache.h: Fix common/ includes.
6287         * regcache.c: Fix common/ includes.
6288         * record-btrace.c: Fix common/ includes.
6289         * python/python.c: Fix common/ includes.
6290         * python/py-type.c: Fix common/ includes.
6291         * python/py-inferior.c: Fix common/ includes.
6292         * progspace.h: Fix common/ includes.
6293         * producer.c: Fix common/ includes.
6294         * procfs.c: Fix common/ includes.
6295         * proc-api.c: Fix common/ includes.
6296         * printcmd.c: Fix common/ includes.
6297         * ppc-linux-nat.c: Fix common/ includes.
6298         * parser-defs.h: Fix common/ includes.
6299         * osdata.c: Fix common/ includes.
6300         * obsd-nat.c: Fix common/ includes.
6301         * nat/x86-linux.c: Fix common/ includes.
6302         * nat/x86-linux-dregs.c: Fix common/ includes.
6303         * nat/x86-dregs.h: Fix common/ includes.
6304         * nat/x86-dregs.c: Fix common/ includes.
6305         * nat/ppc-linux.c: Fix common/ includes.
6306         * nat/mips-linux-watch.h: Fix common/ includes.
6307         * nat/mips-linux-watch.c: Fix common/ includes.
6308         * nat/linux-waitpid.c: Fix common/ includes.
6309         * nat/linux-ptrace.h: Fix common/ includes.
6310         * nat/linux-ptrace.c: Fix common/ includes.
6311         * nat/linux-procfs.c: Fix common/ includes.
6312         * nat/linux-personality.c: Fix common/ includes.
6313         * nat/linux-osdata.c: Fix common/ includes.
6314         * nat/linux-namespaces.c: Fix common/ includes.
6315         * nat/linux-btrace.h: Fix common/ includes.
6316         * nat/linux-btrace.c: Fix common/ includes.
6317         * nat/fork-inferior.c: Fix common/ includes.
6318         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6319         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6320         * nat/aarch64-linux.c: Fix common/ includes.
6321         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6322         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6323         * namespace.h: Fix common/ includes.
6324         * mips-linux-tdep.c: Fix common/ includes.
6325         * minsyms.c: Fix common/ includes.
6326         * mi/mi-parse.h: Fix common/ includes.
6327         * mi/mi-main.c: Fix common/ includes.
6328         * mi/mi-cmd-env.c: Fix common/ includes.
6329         * memrange.h: Fix common/ includes.
6330         * memattr.c: Fix common/ includes.
6331         * maint.h: Fix common/ includes.
6332         * maint.c: Fix common/ includes.
6333         * main.c: Fix common/ includes.
6334         * machoread.c: Fix common/ includes.
6335         * location.c: Fix common/ includes.
6336         * linux-thread-db.c: Fix common/ includes.
6337         * linux-nat.c: Fix common/ includes.
6338         * linux-fork.c: Fix common/ includes.
6339         * inline-frame.c: Fix common/ includes.
6340         * infrun.c: Fix common/ includes.
6341         * inflow.c: Fix common/ includes.
6342         * inferior.h: Fix common/ includes.
6343         * inferior.c: Fix common/ includes.
6344         * infcmd.c: Fix common/ includes.
6345         * inf-ptrace.c: Fix common/ includes.
6346         * inf-child.c: Fix common/ includes.
6347         * ia64-linux-nat.c: Fix common/ includes.
6348         * i387-tdep.c: Fix common/ includes.
6349         * i386-tdep.c: Fix common/ includes.
6350         * i386-linux-tdep.c: Fix common/ includes.
6351         * i386-linux-nat.c: Fix common/ includes.
6352         * i386-go32-tdep.c: Fix common/ includes.
6353         * i386-fbsd-tdep.c: Fix common/ includes.
6354         * i386-fbsd-nat.c: Fix common/ includes.
6355         * guile/scm-type.c: Fix common/ includes.
6356         * guile/guile.c: Fix common/ includes.
6357         * go32-nat.c: Fix common/ includes.
6358         * gnu-nat.c: Fix common/ includes.
6359         * gdbthread.h: Fix common/ includes.
6360         * gdbarch-selftests.c: Fix common/ includes.
6361         * gdb_usleep.c: Fix common/ includes.
6362         * gdb_select.h: Fix common/ includes.
6363         * gdb_bfd.c: Fix common/ includes.
6364         * gcore.c: Fix common/ includes.
6365         * fork-child.c: Fix common/ includes.
6366         * findvar.c: Fix common/ includes.
6367         * fbsd-nat.c: Fix common/ includes.
6368         * event-top.c: Fix common/ includes.
6369         * event-loop.c: Fix common/ includes.
6370         * dwarf2read.c: Fix common/ includes.
6371         * dwarf2loc.c: Fix common/ includes.
6372         * dwarf2-frame.c: Fix common/ includes.
6373         * dwarf-index-cache.c: Fix common/ includes.
6374         * dtrace-probe.c: Fix common/ includes.
6375         * disasm-selftests.c: Fix common/ includes.
6376         * defs.h: Fix common/ includes.
6377         * csky-tdep.c: Fix common/ includes.
6378         * cp-valprint.c: Fix common/ includes.
6379         * cp-support.h: Fix common/ includes.
6380         * cp-support.c: Fix common/ includes.
6381         * corelow.c: Fix common/ includes.
6382         * completer.h: Fix common/ includes.
6383         * completer.c: Fix common/ includes.
6384         * compile/compile.c: Fix common/ includes.
6385         * compile/compile-loc2c.c: Fix common/ includes.
6386         * compile/compile-cplus-types.c: Fix common/ includes.
6387         * compile/compile-cplus-symbols.c: Fix common/ includes.
6388         * command.h: Fix common/ includes.
6389         * cli/cli-dump.c: Fix common/ includes.
6390         * cli/cli-cmds.c: Fix common/ includes.
6391         * charset.c: Fix common/ includes.
6392         * build-id.c: Fix common/ includes.
6393         * btrace.h: Fix common/ includes.
6394         * btrace.c: Fix common/ includes.
6395         * breakpoint.h: Fix common/ includes.
6396         * breakpoint.c: Fix common/ includes.
6397         * ax.h:
6398         (enum agent_op): Fix common/ includes.
6399         * ax-general.c (struct aop_map): Fix common/ includes.
6400         * ax-gdb.c: Fix common/ includes.
6401         * auxv.c: Fix common/ includes.
6402         * auto-load.c: Fix common/ includes.
6403         * arm-tdep.c: Fix common/ includes.
6404         * arch/riscv.c: Fix common/ includes.
6405         * arch/ppc-linux-common.c: Fix common/ includes.
6406         * arch/i386.c: Fix common/ includes.
6407         * arch/arm.c: Fix common/ includes.
6408         * arch/arm-linux.c: Fix common/ includes.
6409         * arch/arm-get-next-pcs.c: Fix common/ includes.
6410         * arch/amd64.c: Fix common/ includes.
6411         * arch/aarch64.c: Fix common/ includes.
6412         * arch/aarch64-insn.c: Fix common/ includes.
6413         * arch-utils.c: Fix common/ includes.
6414         * amd64-windows-tdep.c: Fix common/ includes.
6415         * amd64-tdep.c: Fix common/ includes.
6416         * amd64-sol2-tdep.c: Fix common/ includes.
6417         * amd64-obsd-tdep.c: Fix common/ includes.
6418         * amd64-nbsd-tdep.c: Fix common/ includes.
6419         * amd64-linux-tdep.c: Fix common/ includes.
6420         * amd64-linux-nat.c: Fix common/ includes.
6421         * amd64-fbsd-tdep.c: Fix common/ includes.
6422         * amd64-fbsd-nat.c: Fix common/ includes.
6423         * amd64-dicos-tdep.c: Fix common/ includes.
6424         * amd64-darwin-tdep.c: Fix common/ includes.
6425         * agent.c: Fix common/ includes.
6426         * ada-lang.h: Fix common/ includes.
6427         * ada-lang.c: Fix common/ includes.
6428         * aarch64-tdep.c: Fix common/ includes.
6429
6430 2019-01-25  Tom Tromey  <tom@tromey.com>
6431
6432         * common/create-version.sh: Use common/version.h.
6433
6434 2019-01-24  Pedro Alves  <palves@redhat.com>
6435
6436         * infrun.c (signal_stop, signal_print, signal_program)
6437         (signal_catch, signal_pass): Now arrays instead of pointers.
6438         (update_signals_program_target, do_target_resume)
6439         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6440         * linux-nat.c (linux_nat_target::pass_signals)
6441         (linux_nat_target::create_inferior, linux_nat_target::attach):
6442         Adjust.
6443         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6444         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6445         * procfs.c (procfs_target::pass_signals): Adjust.
6446         * record-full.c (record_full_target::resume): Adjust.
6447         * remote.c (remote_target::pass_signals)
6448         (remote_target::program_signals): Adjust.
6449         * target-debug.h (target_debug_print_signals): Now takes a
6450         gdb::array_view as parameter.  Adjust.
6451         * target.h (target_ops) <pass_signals, program_signals>: Replace
6452         pointer and length parameters with gdb::array_view.
6453         (target_pass_signals, target_program_signals): Likewise.
6454         * target-delegates.c: Regenerate.
6455
6456 2019-01-24  Pedro Alves  <palves@redhat.com>
6457
6458         * common/forward-scope-exit.h
6459         (forward_scope_exit::forward_scope_exit): Pass arguments to
6460         m_bind_function directly, instead of creating a std::bind and
6461         copying that.
6462
6463 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6464
6465         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6466         for static members.
6467         (pass_in_v_vfp_candidate): Likewise.
6468
6469 2019-01-23  Tom Tromey  <tom@tromey.com>
6470             Pedro Alves  <palves@redhat.com>
6471
6472         * regcache.c (class regcache_invalidator): Remove.
6473         (regcache::raw_write): Use make_scope_exit.
6474
6475 2019-01-23  Tom Tromey  <tom@tromey.com>
6476
6477         * ui-out.h (class ui_out_emit_type): Update comment.
6478
6479 2019-01-23  Tom Tromey  <tom@tromey.com>
6480
6481         * infrun.c (fetch_inferior_event): Update comment.
6482
6483 2019-01-23  Tom Tromey  <tom@tromey.com>
6484             Pedro Alves  <palves@redhat.com>
6485
6486         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6487         parameter.
6488         (fetch_inferior_event): Use SCOPE_EXIT.
6489
6490
6491 2019-01-23  Tom Tromey  <tom@tromey.com>
6492             Pedro Alves  <palves@redhat.com>
6493
6494         * infrun.c (disable_thread_events): Delete.
6495         (stop_all_threads): Use SCOPE_EXIT.
6496
6497 2019-01-23  Tom Tromey  <tom@tromey.com>
6498             Pedro Alves  <palves@redhat.com>
6499
6500         * symfile.c: Include forward-scope-exit.h.
6501         (clear_symtab_users_cleanup): Replace forward declaration with
6502         a FORWARD_SCOPE_EXIT.
6503         (syms_from_objfile_1): Use the forward_scope_exit and
6504         gdb::optional instead of cleanup_function.
6505         (reread_symbols): Use the forward_scope_exit instead of
6506         cleanup_function.
6507         (clear_symtab_users_cleanup): Remove function.
6508
6509 2019-01-23  Tom Tromey  <tom@tromey.com>
6510             Pedro Alves  <palves@redhat.com>
6511
6512         * linux-nat.c: Include scope-exit.h.
6513         (cleanup_target_stop): Remove.
6514         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6515         SCOPE_EXIT.
6516
6517 2019-01-23  Tom Tromey  <tom@tromey.com>
6518             Pedro Alves  <palves@redhat.com>
6519
6520         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6521         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6522
6523 2019-01-23  Tom Tromey  <tom@tromey.com>
6524             Andrew Burgess  <andrew.burgess@embecosm.com>
6525             Pedro Alves  <palves@redhat.com>
6526
6527         * infrun.c (fetch_inferior_event): Use scope_exit.
6528         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6529         * top.c (execute_command): Use scope_exit.
6530         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6531         * utils.c (do_bpstat_clear_actions_cleanup)
6532         (make_bpstat_clear_actions_cleanup): Remove.
6533
6534 2019-01-23  Tom Tromey  <tom@tromey.com>
6535             Pedro Alves  <palves@redhat.com>
6536
6537         * infrun.c: Include "common/scope-exit.h"
6538         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6539         (wait_for_inferior): Use SCOPE_EXIT.
6540         (fetch_inferior_event): Use scope_exit.
6541
6542 2019-01-23  Tom Tromey  <tom@tromey.com>
6543             Pedro Alves  <palves@redhat.com>
6544
6545         * breakpoint.c (create_breakpoint): Remove cleanup.
6546
6547 2019-01-23  Tom Tromey  <tom@tromey.com>
6548             Andrew Burgess  <andrew.burgess@embecosm.com>
6549             Pedro Alves  <palves@redhat.com>
6550
6551 2019-01-23  Pedro Alves  <palves@redhat.com>
6552
6553         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6554
6555 2019-01-23  Pedro Alves  <palves@redhat.com>
6556             Andrew Burgess  <andrew.burgess@embecosm.com>
6557
6558         * gdbthread.h: Include "common/forward-scope-exit.h".
6559         (scoped_finish_thread_state): Redefine custom class in terms of
6560         forward_scope_exit.
6561
6562 2019-01-23  Pedro Alves  <palves@redhat.com>
6563             Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * common/forward-scope-exit.h: New file.
6566
6567 2019-01-23  Pedro Alves  <palves@redhat.com>
6568             Andrew Burgess  <andrew.burgess@embecosm.com>
6569             Tom Tromey  <tom@tromey.com>
6570
6571         * common/scope-exit.h: New file.
6572
6573 2019-01-23  Pedro Alves  <palves@redhat.com>
6574
6575         * common/preprocessor.h (ESC): Rename to ...
6576         (ESC_PARENS): ... this.
6577         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6578         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6579
6580 2019-01-23  Tom Tromey  <tom@tromey.com>
6581
6582         * language.h (class scoped_switch_to_sym_language_if_auto):
6583         Initialize m_lang in both cases.
6584
6585 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6586
6587         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6588         with XCNEW.
6589
6590 2019-01-22  Tom Tromey  <tom@tromey.com>
6591
6592         * corelow.c: Do not include sys/file.h.
6593
6594 2019-01-22  Tom Tromey  <tom@tromey.com>
6595
6596         * tui/tui-wingeneral.h: Include gdb_curses.h.
6597
6598 2019-01-22  Tom Tromey  <tom@tromey.com>
6599
6600         * source-cache.h (class source_cache) <get_source_lines,
6601         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6602
6603 2019-01-22  Tom Tromey  <tom@tromey.com>
6604
6605         * remote-fileio.h (struct remote_target): Declare.
6606
6607 2019-01-22  Tom Tromey  <tom@tromey.com>
6608
6609         * python/py-arch.c: Do not include py-ref.h.
6610         * python/py-bpevent.c: Do not include py-ref.h.
6611         * python/py-cmd.c: Do not include py-ref.h.
6612         * python/py-continueevent.c: Do not include py-ref.h.
6613         * python/py-event.h: Do not include py-ref.h.
6614         * python/py-evtregistry.c: Do not include py-ref.h.
6615         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6616         * python/py-frame.c: Do not include py-ref.h.
6617         * python/py-framefilter.c: Do not include py-ref.h.
6618         * python/py-function.c: Do not include py-ref.h.
6619         * python/py-infevents.c: Do not include py-ref.h.
6620         * python/py-linetable.c: Do not include py-ref.h.
6621         * python/py-objfile.c: Do not include py-ref.h.
6622         * python/py-param.c: Do not include py-ref.h.
6623         * python/py-prettyprint.c: Do not include py-ref.h.
6624         * python/py-progspace.c: Do not include py-ref.h.
6625         * python/py-symbol.c: Do not include py-ref.h.
6626         * python/py-symtab.c: Do not include py-ref.h.
6627         * python/py-type.c: Do not include py-ref.h.
6628         * python/py-unwind.c: Do not include py-ref.h.
6629         * python/py-utils.c: Do not include py-ref.h.
6630         * python/py-value.c: Do not include py-ref.h.
6631         * python/py-varobj.c: Do not include py-ref.h.
6632         * python/py-xmethods.c: Do not include py-ref.h.
6633         * python/python.c: Do not include py-ref.h.
6634         * varobj.c: Do not include py-ref.h.
6635
6636 2019-01-22  Tom Tromey  <tom@tromey.com>
6637
6638         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6639         keyword for bcache.
6640
6641 2019-01-22  Tom Tromey  <tom@tromey.com>
6642
6643         * compile/compile-cplus-types.c: Remove a comment by #include.
6644
6645 2019-01-22  Tom Tromey  <tom@tromey.com>
6646
6647         * compile/gcc-c-plugin.h: Include compile-internal.h.
6648
6649 2019-01-22  Tom Tromey  <tom@tromey.com>
6650
6651         * stabsread.c (EXTERN): Do not define.
6652         (symnum, next_symbol_text_func, processing_gcc_compilation)
6653         (within_function, global_sym_chain, global_stabs)
6654         (previous_stab_code, this_object_header_files)
6655         (n_this_object_header_files)
6656         (n_allocated_this_object_header_files): Define.
6657         * stabsread.h (EXTERN): Never define.  Use "extern".
6658
6659 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6660
6661         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6662         history_value.
6663
6664 2019-01-21  Tom Tromey  <tom@tromey.com>
6665
6666         * ui-out.c: Fix includes.
6667         * tui/tui-source.c: Fix includes.
6668         * target.c: Fix includes.
6669         * remote.c: Fix includes.
6670         * regcache.c: Fix includes.
6671         * python/py-block.c: Fix includes.
6672         * printcmd.c: Fix includes.
6673         * or1k-tdep.c: Fix includes.
6674         * mi/mi-main.c: Fix includes.
6675         * m32r-tdep.c: Fix includes.
6676         * csky-tdep.c: Fix includes.
6677         * compile/compile-cplus-types.c: Fix includes.
6678         * cli/cli-interp.c: Fix includes.
6679
6680 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6681
6682         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6683         for padding.
6684
6685 2019-01-16  Tom Tromey  <tom@tromey.com>
6686
6687         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6688         earlier.
6689         (struct objfile) <msymbols_range>: Move from top level.
6690         <msymbols>: New method.
6691         (class objfile_msymbols): Remove.
6692         * symtab.c (default_collect_symbol_completion_matches_break_on):
6693         Update.
6694         * symmisc.c (dump_msymbols): Update.
6695         * stabsread.c (scan_file_globals): Update.
6696         * objc-lang.c (info_selectors_command, info_classes_command)
6697         (find_methods): Update.
6698         * minsyms.c (find_solib_trampoline_target): Update.
6699         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6700         * coffread.c (coff_symfile_read): Update.
6701         * ada-lang.c (ada_lookup_simple_minsym)
6702         (ada_collect_symbol_completion_matches): Update.
6703
6704 2019-01-16  Tom Tromey  <tom@tromey.com>
6705
6706         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6707         type.  Remove no-argument constructor.
6708         <iterator::operator++>: Simplify.
6709         <begin>: Update.
6710         <end>: Use minimal_symbol_count.
6711
6712 2019-01-16  Tom Tromey  <tom@tromey.com>
6713
6714         * objfiles.h (struct objfile) <psymtabs>: New method.
6715         (class objfile_psymtabs): Remove.
6716         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6717         typedef.
6718         <range>: New method.
6719         (require_partial_symbols): Change return type.
6720         * psymtab.c (require_partial_symbols)
6721         (psym_expand_symtabs_matching): Update.
6722         * mdebugread.c (parse_partial_symbols): Update.
6723         * dbxread.c (dbx_end_psymtab): Update.
6724
6725 2019-01-15  Tom Tromey  <tom@tromey.com>
6726
6727         * symtab.c (lookup_objfile_from_block)
6728         (lookup_symbol_in_objfile_symtabs)
6729         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6730         (find_line_symtab, info_sources_command)
6731         (default_collect_symbol_completion_matches_break_on)
6732         (make_source_files_completion_list): Update.
6733         * symmisc.c (print_objfile_statistics, dump_objfile)
6734         (maintenance_print_symbols, maintenance_info_symtabs)
6735         (maintenance_check_symtabs, maintenance_info_line_tables):
6736         Update.
6737         * source.c (select_source_symtab)
6738         (forget_cached_source_info_for_objfile): Update.
6739         * objfiles.h (class objfile_compunits): Remove.
6740         (struct objfile) <compunits_range>: New typedef.
6741         (compunits): New method.
6742         * objfiles.c (objfile_relocate1): Update.
6743         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6744         * maint.c (count_symtabs_and_blocks): Update.
6745         * linespec.c (iterate_over_all_matching_symtabs): Update.
6746         * cp-support.c (add_symbol_overload_list_qualified): Update.
6747         * coffread.c (coff_symtab_read): Update.
6748         * ada-lang.c (add_nonlocal_symbols)
6749         (ada_collect_symbol_completion_matches)
6750         (ada_add_global_exceptions): Update.
6751
6752 2019-01-15  Tom Tromey  <tom@tromey.com>
6753
6754         * progspace.h (program_space) <objfiles_safe_range>: New
6755         typedef.
6756         <objfiles_safe>: New method.
6757         * objfiles.h (class all_objfiles_safe): Remove.
6758         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6759         * jit.c (jit_inferior_exit_hook): Update.
6760
6761 2019-01-17  Tom Tromey  <tom@tromey.com>
6762
6763         * progspace.h (program_space) <objfiles_range>: New typedef.
6764         <objfiles>: New method.
6765         <objfiles_head>: Rename from objfiles.
6766         (object_files): Update.
6767         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6768         * guile/scm-pretty-print.c
6769         (ppscm_find_pretty_printer_from_objfiles): Update.
6770         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6771         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6772         Update.
6773         * python/py-progspace.c (pspy_get_objfiles): Update.
6774         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6775         Update.
6776         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6777         (objfpy_lookup_objfile_by_build_id): Update.
6778         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6779         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6780         Update.
6781         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6782         (expand_symtab_containing_pc, lookup_objfile_from_block)
6783         (lookup_static_symbol, basic_lookup_transparent_type)
6784         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6785         (find_line_symtab, info_sources_command)
6786         (default_collect_symbol_completion_matches_break_on)
6787         (make_source_files_completion_list, find_main_name): Update.
6788         * symmisc.c (print_symbol_bcache_statistics)
6789         (print_objfile_statistics, maintenance_print_symbols)
6790         (maintenance_print_msymbols, maintenance_print_objfiles)
6791         (maintenance_info_symtabs, maintenance_check_symtabs)
6792         (maintenance_expand_symtabs, maintenance_info_line_tables):
6793         Update.
6794         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6795         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6796         (map_overlay_command, unmap_overlay_command)
6797         (simple_overlay_update, expand_symtabs_matching)
6798         (map_symbol_filenames): Update.
6799         * symfile-debug.c (set_debug_symfile): Update.
6800         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6801         Update.
6802         * source.c (select_source_symtab, forget_cached_source_info):
6803         Update.
6804         * solib.c (solib_read_symbols): Update.
6805         * solib-spu.c (append_ocl_sos): Update.
6806         * psymtab.c (maintenance_print_psymbols)
6807         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6808         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6809         * printcmd.c (info_symbol_command): Update.
6810         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6811         Update.
6812         * objfiles.h (class all_objfiles): Remove.
6813         * objfiles.c (have_partial_symbols, have_full_symbols)
6814         (have_minimal_symbols, qsort_cmp, update_section_map)
6815         (shared_objfile_contains_address_p)
6816         (default_iterate_over_objfiles_in_search_order): Update.
6817         * objc-lang.c (info_selectors_command, info_classes_command)
6818         (find_methods): Update.
6819         * minsyms.c (find_solib_trampoline_target): Update.
6820         * maint.c (maintenance_info_sections)
6821         (maintenance_translate_address, count_symtabs_and_blocks):
6822         Update.
6823         * main.c (captured_main_1): Update.
6824         * linux-thread-db.c (try_thread_db_load_from_pdir)
6825         (has_libpthread): Update.
6826         * linespec.c (iterate_over_all_matching_symtabs)
6827         (search_minsyms_for_name): Update.
6828         * jit.c (jit_find_objf_with_entry_addr): Update.
6829         * hppa-tdep.c (find_unwind_entry)
6830         (hppa_lookup_stub_minimal_symbol): Update.
6831         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6832         Update.
6833         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6834         (elf_gnu_ifunc_resolve_by_got): Update.
6835         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6836         * dwarf-index-write.c (save_gdb_index_command): Update.
6837         * cp-support.c (add_symbol_overload_list_qualified): Update.
6838         * breakpoint.c (create_overlay_event_breakpoint)
6839         (create_longjmp_master_breakpoint)
6840         (create_std_terminate_master_breakpoint)
6841         (create_exception_master_breakpoint): Update.
6842         * blockframe.c (find_pc_partial_function): Update.
6843         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6844         (ada_collect_symbol_completion_matches)
6845         (ada_add_global_exceptions): Update.
6846
6847 2019-01-17  Tom Tromey  <tom@tromey.com>
6848
6849         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6850         declare VEC.
6851         (solib_target_parse_libraries): Change return type.
6852         (library_list_start_segment, library_list_start_section)
6853         (library_list_end_library, library_list_start_library); Update.
6854         (solib_target_free_library_list): Remove.
6855         (solib_target_parse_libraries): Remove cleanup.  Change return
6856         type.
6857         (solib_target_current_sos): Update.
6858
6859 2019-01-17  Tom Tromey  <tromey@bapiya>
6860
6861         * valprint.c: Replace "the the" with "the".
6862         * symtab.c: Replace "the the" with "the".
6863         * solib.c: Replace "the the" with "the".
6864         * solib-dsbt.c: Replace "the the" with "the".
6865         * linespec.c: Replace "the the" with "the".
6866         * dwarf2loc.h: Replace "the the" with "the".
6867         * amd64-windows-tdep.c: Replace "the the" with "the".
6868         * aarch64-tdep.c: Replace "the the" with "the".
6869
6870 2019-01-16  Keith Seitz  <keiths@redhat.com>
6871
6872         PR gdb/23773
6873         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6874         <builder>: Rename to ..
6875         <m_builder>: ... this and make private.
6876         (dwarf2_cu::get_builder): New method.  Change all users of
6877         `builder' to use this method.
6878         (dwarf2_start_symtab): Move to ...
6879         (dwarf2_cu::start_symtab): ... here.  Update all callers
6880         (setup_type_unit_groups): Move to ...
6881         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6882         callers.
6883         (dwarf2_cu::reset_builder): New method.
6884         (process_full_compunit, process_full_type_unit): Use
6885         dwarf2_cu::reset_builder.
6886         (follow_die_offset): Record the ancestor CU if it is different
6887         from the followed DIE's CU.
6888         (follow_die_sig_1): Likewise.
6889
6890 2019-01-15  Tom Tromey  <tom@tromey.com>
6891
6892         * remote.c (class remote_state) <buf>: Now a char_vector.
6893         <buf_size>: Remove.
6894         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6895         parameter.
6896         (remote_target::getpkt_or_notif_sane_1)
6897         (remote_target::getpkt_sane)
6898         (remote_target::getpkt_or_notif_sane): Likewise.
6899         (class remote_target) <putpkt>: New overload.
6900         (remote_target::read_frame): Change type of "buf_p".  Remove
6901         sizeof_p parameter.
6902         (packet_ok): New overload.
6903         (packet_check_result): New overload.
6904         Update all uses.
6905
6906 2019-01-14  Tom Tromey  <tom@tromey.com>
6907
6908         * remote-notif.c (handle_notification, remote_notif_ack)
6909         (remote_notif_parse): Make "buf" const.
6910         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6911         const.
6912         (remote_notif_parse, remote_notif_ack, handle_notification):
6913         Likewise.
6914         * remote.c (remote_notif_stop_parse): Make "buf" const.
6915         (remote_target::remote_parse_stop_reply): Make "buf" const.
6916         (remote_notif_stop_ack): Make "buf" const.
6917
6918 2019-01-14  Tom Tromey  <tom@tromey.com>
6919
6920         * remote.c (remote_console_output): Make parameter const.
6921
6922 2019-01-14  Tom Tromey  <tom@tromey.com>
6923
6924         * target-debug.h (target_debug_print_signals): Constify.
6925         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6926         * procfs.c (procfs_target::pass_signals): Update.
6927         * linux-nat.c (linux_nat_target::pass_signals): Update.
6928         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6929         * target-delegates.c: Rebuild.
6930         * remote.c (remote_target::program_signals): Update.
6931         (remote_target::pass_signals): Update.
6932         * target.c (target_pass_signals): Constify argument.
6933         (target_program_signals): Likewise.
6934         * target.h (struct target_ops) <pass_signals, program_signals>:
6935         Constify argument.
6936         (target_pass_signals, target_program_signals): Constify argument.
6937
6938 2019-01-14  Tom Tromey  <tom@tromey.com>
6939
6940         PR tui/28819:
6941         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6942
6943 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6944
6945         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6946         field.
6947         * rs6000-tdep.c: Include reggroups.h.
6948         (IS_V_ALIAS_PSEUDOREG): Define.
6949         (rs6000_register_name): Return names for the "vX" aliases.
6950         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6951         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6952         aliases.  Call default_register_reggroup_p for all other
6953         pseudo-registers.
6954         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6955         New functions.
6956         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6957         Handle "vX" aliases.
6958         (v_alias_pseudo_register_collect): New function.
6959         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6960         (rs6000_gdbarch_init): Initialize "vX" aliases as
6961         pseudo-registers.  Restore registration of
6962         rs6000_pseudo_register_reggroup_p with
6963         set_tdesc_pseudo_register_reggroup_p.
6964
6965 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6966
6967         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6968         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6969         set_gdbarch_num_pseudo_regs.
6970
6971 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6972
6973         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6974         Remove arg prefixname, add do_set and do_show.
6975         Add member functions set_list and show_list.
6976         * cli/cli-style.c (class cli_style_option): Update accordingly.
6977         (style_set_list): Move to file scope.
6978         (style_show_list): Likewise.
6979         (set_style): Call help_list.
6980         (show_style): Call cmd_show_list.
6981         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6982         Update to use the new macro.
6983
6984 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6985
6986         * ada-lang.c (_initialize_ada_language): Expand the help text
6987         for the "catch exception" command.
6988
6989 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6990
6991         * symtab.c (matching_obj_sections): Initialize obj,
6992         declare it closer to its usage.
6993
6994 2019-01-10  Tom Tromey  <tom@tromey.com>
6995
6996         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6997         (basic_inf_threads_range): Remove.
6998         (inf_threads_range, inf_non_exited_threads_range)
6999         (safe_inf_threads_range): Use next_adapter.
7000
7001 2019-01-10  Keith Seitz  <keiths@redhat.com>
7002
7003         PR gdb/23712
7004         PR symtab/23010
7005         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7006         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7007
7008 2019-01-10  Keith Seitz  <keiths@redhat.com>
7009
7010         PR gdb/23712
7011         PR symtab/23010
7012         * dictionary.c (pending_to_vector): Remove.
7013         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7014         Remove _1 suffix, replacing functions of the same name.  Update
7015         all callers.
7016         (dict_create_hashed, dict_create_hashed_expandable)
7017         (dict_create_linear, dict_create_linear_expandable, dict_free)
7018         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7019         Make functions static.
7020
7021 2019-01-10  Keith Seitz  <keiths@redhat.com>
7022
7023         PR gdb/23712
7024         PR symtab/23010
7025         * dictionary.h (struct dictionary): Replace declaration with
7026         multidictionary.
7027         (dict_create_hashed, dict_create_hashed_expandable)
7028         (dict_create_linear, dict_create_linear_expandable)
7029         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7030         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7031         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7032         taking multidictionary argument.
7033         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7034         * block.h (struct block) <dict>: Change to multidictionary
7035         and rename `multidict'.
7036         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7037         symmisc.c: Update all dictionary references to multidictionary.
7038
7039 2019-01-10  Keith Seitz  <keiths@redhat.com>
7040
7041         PR gdb/23712
7042         PR symtab/23010
7043         * dictionary.c: Include unordered_map.
7044         (pending_to_vector): New function.
7045         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7046         Rewrite the non-"_1" functions to take vector instead
7047         of linked list.
7048         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7049         "new" _1 versions of the same name.
7050         (multidictionary): Define.
7051         (std::hash<enum language): New definition.
7052         (collate_pending_symbols_by_language, mdict_create_hashed)
7053         (mdict_create_hashed_expandable, mdict_create_linear)
7054         (mdict_create_linear_expandable, mdict_free)
7055         (find_language_dictionary, create_new_language_dictionary)
7056         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7057         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7058         (mdict_size, mdict_empty): New functions.
7059         * dictionary.h (mdict_iterator): Define.
7060
7061 2019-01-10  Pedro Alves  <palves@redhat.com>
7062
7063         * breakpoint.c (read_uploaded_action)
7064         (create_tracepoint_from_upload): Adjust to use
7065         gdb::unique_xmalloc_ptr.
7066         * ctf.c (ctf_write_uploaded_tp):
7067         (SET_ARRAY_FIELD): Use emplace_back.
7068         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7069         * tracefile-tfile.c (tfile_write_uploaded_tp):
7070         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7071         gdb::unique_xmalloc_ptr.
7072         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7073         at_string, cond_string, cmd_strings>: Replace char pointers
7074         with gdb::unique_xmalloc_ptr.
7075
7076 2019-01-10  Pedro Alves  <palves@redhat.com>
7077
7078         * solib-target.c (library_list_start_library): Don't xstrdup name.
7079
7080 2019-01-10  Pedro Alves  <palves@redhat.com>
7081
7082         * mdebugread.c (parse_partial_symbols): Use
7083         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7084
7085 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * linux-fork.c (scoped_switch_fork_info)
7088         <~scoped_switch_fork_info>: Fix incorrect variable name.
7089
7090 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7091
7092         * linux-fork.c (scoped_switch_fork_info)
7093         <scoped_switch_fork_info>: Make explicit.
7094         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7095
7096 2019-01-10  Tom Tromey  <tom@tromey.com>
7097
7098         * objfiles.h (objfile::reset_psymtabs): Update.
7099         * objfiles.c (objfile::objfile): Update.
7100         * psymtab.h (psymtab_storage::obstack): Update.
7101         (psymtab_storage::m_obstack): Use gdb::optional.
7102         (class psymtab_storage): Update comment.  Remove objfile
7103         parameter.
7104         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7105
7106 2019-01-10  Tom Tromey  <tom@tromey.com>
7107
7108         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7109         <free_psymtabs>: Now private.
7110         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7111         (allocate_psymtab): Use new method.
7112
7113 2019-01-10  Tom Tromey  <tom@tromey.com>
7114
7115         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7116         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7117         * mdebugread.c (parse_partial_symbols): Use
7118         allocate_dependencies.
7119         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7120         allocate_dependencies.
7121         (process_psymtab_comp_unit_reader)
7122         (build_type_psymtab_dependencies): Likewise.
7123         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7124
7125 2019-01-10  Tom Tromey  <tom@tromey.com>
7126
7127         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7128         PSYMBOL_SET_LANGUAGE.
7129         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7130
7131 2019-01-10  Tom Tromey  <tom@tromey.com>
7132
7133         * psymtab.h (psymtab_storage::obstack): New method.
7134         <m_obstack>: Rename from obstack; now private.
7135         * psymtab.c (psymtab_storage): Update.
7136         * dwarf2read.c (create_addrmap_from_index)
7137         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7138         Update.
7139
7140 2019-01-10  Tom Tromey  <tom@tromey.com>
7141
7142         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7143         * objfiles.h (objfile::reset_psymtabs): New method.
7144
7145 2019-01-10  Tom Tromey  <tom@tromey.com>
7146
7147         * symmisc.c (print_symbol_bcache_statistics): Update.
7148         (print_objfile_statistics): Update.
7149         * symfile.c (reread_symbols): Update.
7150         * psymtab.h (class psymtab_storage): New.
7151         * psymtab.c (psymtab_storage): New constructor.
7152         (~psymtab_storage): New destructor.
7153         (require_partial_symbols): Update.
7154         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7155         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7156         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7157         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7158         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7159         (start_psymtab_common, end_psymtab_common)
7160         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7161         (allocate_psymtab): Update.
7162         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7163         Update.
7164         (dump_psymtab_addrmap, maintenance_print_psymbols)
7165         (maintenance_check_psymtabs): Update.
7166         (class objfile_psymtabs): Move to objfiles.h.
7167         * psympriv.h (discard_psymtab): Now inline.
7168         (psymtab_discarder::psymtab_discarder): Update.
7169         (psymtab_discarder::~psymtab_discarder): Update.
7170         (ALL_OBJFILE_PSYMTABS): Rewrite.
7171         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7172         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7173         Remove fields.
7174         <partial_symtabs>: New field.
7175         (class objfile_psymtabs): Move from psymtab.h.  Update.
7176         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7177         psymbol_cache.
7178         (objfile::~objfile): Don't destroy psymbol_cache.
7179         * mdebugread.c (parse_partial_symbols): Update.
7180         * dwarf2read.c (create_addrmap_from_index)
7181         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7182         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7183         (add_partial_subprogram, dwarf2_ranges_read): Update.
7184         * dwarf-index-write.c (write_address_map)
7185         (write_one_signatured_type, recursively_write_psymbols)
7186         (class debug_names, class debug_names, write_psymtabs_to_index):
7187         Update.
7188
7189 2019-01-10  Tom Tromey  <tom@tromey.com>
7190
7191         * symtab.h (SYMBOL_SET_NAMES): Update.
7192         (symbol_set_names): Update.
7193         (MSYMBOL_SET_NAMES): Update.
7194         * symtab.c (symbol_set_names): Change argument to be an
7195         objfile_per_bfd_storage.
7196         * psymtab.c (add_psymbol_to_bcache): Update.
7197         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7198
7199 2019-01-10  Tom Tromey  <tom@tromey.com>
7200
7201         * symtab.c (create_demangled_names_hash): Change argument to be an
7202         objfile_per_bfd_storage.
7203         (symbol_set_names): Update.
7204
7205 2019-01-10  Tom Tromey  <tom@tromey.com>
7206
7207         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7208         init_psymbol_list.
7209         * psymtab.c (init_psymbol_list): Do nothing if already called.
7210         * psympriv.h (init_psymbol_list): Add comment.
7211         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7212         init_psymbol_list.
7213         * dbxread.c (dbx_symfile_read): Unconditionally call
7214         init_psymbol_list.
7215
7216 2019-01-10  Tom Tromey  <tom@tromey.com>
7217
7218         * xcoffread.c (scan_xcoff_symtab): Update.
7219         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7220         "where".
7221         * mdebugread.c (parse_partial_symbols)
7222         (handle_psymbol_enumerators): Update.
7223         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7224         * dbxread.c (read_dbx_symtab): Update.
7225         * psympriv.h (psymbol_placement): New enum.
7226         (add_psymbol_to_list): Update.
7227
7228 2019-01-10  Tom Tromey  <tom@tromey.com>
7229
7230         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7231         static_psymbols parameters.
7232         (scan_xcoff_symtab): Update.
7233         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7234         static_psymbols parameters.
7235         * psympriv.h (start_psymtab_common): Update.
7236         * mdebugread.c (parse_partial_symbols): Update.
7237         * dwarf2read.c (create_partial_symtab): Update.
7238         * dbxread.c (read_dbx_symtab): Update.
7239         (start_psymtab): Remove global_psymbols and static_psymbols
7240         parameters.
7241
7242 2019-01-10  Tom Tromey  <tom@tromey.com>
7243
7244         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7245         * psymtab.c (allocate_psymtab): Add comment.
7246         * psympriv.h (allocate_psymtab): Add comment.
7247         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7248         initializations.
7249         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7250
7251 2019-01-10  Tom Tromey  <tom@tromey.com>
7252
7253         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7254         Don't declare.
7255         * mipsread.c: Include mdebugread.h.
7256         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7257         Declare.
7258         * elfread.c: Include mdebugread.h.
7259
7260 2019-01-09  Tom Tromey  <tom@tromey.com>
7261
7262         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7263         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7264         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7265         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7266         (psym_lookup_symbol, psym_find_last_source_symtab)
7267         (psym_forget_cached_source_info, psym_print_stats)
7268         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7269         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7270         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7271         (psym_find_compunit_symtab_by_address)
7272         (maintenance_print_psymbols, maintenance_info_psymtabs)
7273         (maintenance_check_psymtabs): Use ranged for.
7274         * psymtab.h (class objfile_psymtabs): New.
7275         (require_partial_symbols): Return objfile_psymtabs.
7276         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7277
7278 2019-01-09  Tom Tromey  <tom@tromey.com>
7279
7280         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7281         (find_pc_mapped_section, list_overlays_command)
7282         (map_overlay_command, unmap_overlay_command)
7283         (simple_overlay_update): Use all_objfiles.
7284         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7285         * printcmd.c (info_symbol_command): Use all_objfiles.
7286         * objfiles.h (ALL_OBJSECTIONS): Remove.
7287         * maint.c (maintenance_translate_address): Use all_objfiles.
7288         * gcore.c (gcore_create_callback): Use all_objfiles.
7289         (objfile_find_memory_regions): Likewise.
7290
7291 2019-01-09  Tom Tromey  <tom@tromey.com>
7292
7293         * symtab.c (find_line_symtab, info_sources_command)
7294         (make_source_files_completion_list): Use objfile_compunits.
7295         * source.c (select_source_symtab): Use objfile_compunits.
7296         * objfiles.h (struct objfile): Update comment.
7297         (ALL_OBJFILES): Remove.
7298         (ALL_FILETABS): Remove.
7299         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7300         objfile_compunits.
7301
7302 2019-01-09  Tom Tromey  <tom@tromey.com>
7303
7304         * symmisc.c (print_objfile_statistics, dump_objfile)
7305         (maintenance_print_symbols): Use compunit_filetabs.
7306         * source.c (forget_cached_source_info_for_objfile): Use
7307         compunit_filetabs.
7308         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7309         (ALL_FILETABS): Use compunit_filetabs.
7310         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7311         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7312
7313 2019-01-09  Tom Tromey  <tom@tromey.com>
7314
7315         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7316         (compunit_filetabs): New.
7317         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7318         compunit_filetabs.
7319         (info_sources_command, make_source_files_completion_list): Remove
7320         declaration.
7321         * symmisc.c (print_objfile_statistics, dump_objfile)
7322         (maintenance_print_symbols): Remove declaration.
7323         (maintenance_info_symtabs): Use compunit_filetabs.
7324         (maintenance_info_line_tables): Likewise.
7325         * source.c (select_source_symtab): Change local variable name.
7326         (forget_cached_source_info_for_objfile): Remove declaration.
7327         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7328         * objfiles.c (objfile_relocate1): Remove declaration.
7329         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7330         declaration.
7331         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7332         * coffread.c (coff_symtab_read): Remove declaration.
7333         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7334         compunit_filetabs.
7335
7336 2019-01-09  Tom Tromey  <tom@tromey.com>
7337
7338         * symtab.c (lookup_objfile_from_block)
7339         (find_pc_sect_compunit_symtab, search_symbols)
7340         (default_collect_symbol_completion_matches_break_on): Use
7341         objfile_compunits.
7342         * objfiles.h (ALL_COMPUNITS): Remove.
7343         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7344         * cp-support.c (add_symbol_overload_list_qualified): Use
7345         objfile_compunits.
7346         * ada-lang.c (ada_collect_symbol_completion_matches)
7347         (ada_add_global_exceptions): Use objfile_compunits.
7348
7349 2019-01-09  Tom Tromey  <tom@tromey.com>
7350
7351         * source.c (select_source_symtab)
7352         (forget_cached_source_info_for_objfile): Remove declaration.
7353         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7354         declaration.
7355         * maint.c (count_symtabs_and_blocks): Remove declaration.
7356         * cp-support.c (add_symbol_overload_list_qualified): Remove
7357         declaration.
7358         * coffread.c (coff_symtab_read): Remove declaration.
7359         * symtab.c (lookup_symbol_in_objfile_symtabs)
7360         (basic_lookup_transparent_type_1): Use objfile_compunits.
7361         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7362         (info_sources_command, search_symbols)
7363         (default_collect_symbol_completion_matches_break_on)
7364         (make_source_files_completion_list): Remove declaration.
7365         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7366         (ada_collect_symbol_completion_matches)
7367         (ada_add_global_exceptions): Remove declaration.
7368         * linespec.c (iterate_over_all_matching_symtabs): Use
7369         objfile_compunits.
7370         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7371         (class objfile_compunits): New.
7372         (ALL_COMPUNITS): Use objfile_compunits.
7373         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7374         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7375         objfile_compunits.
7376         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7377
7378 2019-01-09  Tom Tromey  <tom@tromey.com>
7379
7380         * symtab.c (search_symbols)
7381         (default_collect_symbol_completion_matches_break_on): Use
7382         objfile_msymbols.
7383         * ada-lang.c (ada_lookup_simple_minsym)
7384         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7385         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7386         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7387         objfile_msymbols.
7388         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7389         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7390         * objc-lang.c (find_methods): Use objfile_msymbols.
7391         (info_selectors_command, info_classes_command): Likewise.
7392         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7393         * objfiles.h (class objfile_msymbols): New.
7394         (ALL_OBJFILE_MSYMBOLS): Remove.
7395         (ALL_MSYMBOLS): Remove.
7396
7397 2019-01-09  Tom Tromey  <tom@tromey.com>
7398
7399         * common/next-iterator.h (next_adapter): Add Iterator template
7400         parameter.
7401         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7402         (class all_objfiles_safe): New.
7403         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7404         * objfiles.c (put_objfile_before): Update comment.
7405         (add_separate_debug_objfile): Likewise.
7406         (free_all_objfiles): Use all_objfiles_safe.
7407         (objfile_purge_solibs): Likewise.
7408
7409 2019-01-09  Tom Tromey  <tom@tromey.com>
7410
7411         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7412         (expand_symtab_containing_pc, lookup_static_symbol)
7413         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7414         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7415         all_objfiles.
7416         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7417         * breakpoint.c (create_overlay_event_breakpoint)
7418         (create_longjmp_master_breakpoint)
7419         (create_std_terminate_master_breakpoint)
7420         (create_exception_master_breakpoint): Use all_objfiles.
7421         * linux-thread-db.c (try_thread_db_load_from_pdir)
7422         (has_libpthread): Use all_objfiles.
7423         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7424         * linespec.c (iterate_over_all_matching_symtabs)
7425         (search_minsyms_for_name): Use all_objfiles.
7426         * maint.c (maintenance_info_sections): Use all_objfiles.
7427         * main.c (captured_main_1): Use all_objfiles.
7428         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7429         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7430         * guile/scm-pretty-print.c
7431         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7432         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7433         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7434         (maintenance_print_msymbols): Use all_objfiles.
7435         * source.c (select_source_symtab): Use all_objfiles.
7436         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7437         * symfile.c (remove_symbol_file_command)
7438         (expand_symtabs_matching, map_symbol_filenames): Use
7439         all_objfiles.
7440         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7441         all_objfiles.
7442         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7443         * objc-lang.c (find_methods): Use all_objfiles.
7444         * objfiles.c (have_partial_symbols, have_full_symbols)
7445         (have_minimal_symbols, qsort_cmp)
7446         (default_iterate_over_objfiles_in_search_order): Use
7447         all_objfiles.
7448         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7449         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7450         (maintenance_check_psymtabs): Use all_objfiles.
7451         (ALL_PSYMTABS): Remove.
7452         * compile/compile-object-run.c (do_module_cleanup): Use
7453         all_objfiles.
7454         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7455         * cp-support.c (add_symbol_overload_list_qualified): Use
7456         all_objfiles.
7457         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7458         Use all_objfiles.
7459         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7460         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7461         all_objfiles.
7462         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7463         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7464         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7465         Uses all_objfiles.
7466         * solib.c (solib_read_symbols): Use all_objfiles
7467
7468 2019-01-09  Tom Tromey  <tom@tromey.com>
7469
7470         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7471         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7472         all_objfiles.
7473         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7474         * symmisc.c (print_symbol_bcache_statistics)
7475         (print_objfile_statistics, maintenance_print_objfiles)
7476         (maintenance_info_symtabs, maintenance_check_symtabs)
7477         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7478         all_objfiles.
7479         * source.c (forget_cached_source_info): Use all_objfiles.
7480         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7481         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7482         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7483         * objfiles.c (update_section_map): Use all_objfiles.
7484         (shared_objfile_contains_address_p): Likewise.
7485         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7486         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7487
7488 2019-01-09  Tom Tromey  <tom@tromey.com>
7489
7490         * common/next-iterator.h: New file.
7491         * objfiles.h (class all_objfiles): New.
7492         (struct objfile_iterator): New.
7493
7494 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7495
7496         * NEWS: Move the description of the changed "frame", "select-frame",
7497          and "info frame" commands to the Changed commands section.
7498
7499 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7500
7501         * gdbtypes.c (check_stub_method_group): Remove handling of old
7502         mangling schemes.
7503         * linespec.c (find_methods): Likewise.
7504         * stabsread.c (read_member_functions): Likewise.
7505         * valops.c (search_struct_method): Likewise.
7506         (value_struct_elt_for_reference): Likewise.
7507         * NEWS: Mention this change.
7508
7509 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7510
7511         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7512         print_source_lines.
7513         * source.c (print_source_lines_base): Update line number check.
7514         (print_source_lines): New function.
7515         (source_lines_range::source_lines_range): New function.
7516         * source.h (class source_lines_range): New class.
7517         (print_source_lines): New declaration.
7518
7519 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7520
7521         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7522
7523 2019-01-08  Tom Tromey  <tom@tromey.com>
7524             Simon Marchi  <simon.marchi@ericsson.com>
7525
7526         PR gdb/24060
7527         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7528         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7529         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7530         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7531         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7532         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7533
7534 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * source.c (select_source_symtab): Move header comment to
7537         declaration in source.h.
7538         (forget_cached_source_info_for_objfile): Likewise.
7539         (forget_cached_source_info): Likewise.
7540         (identify_source_line): Likewise.
7541         * source.h (identify_source_line): Move declaration from symtab.h
7542         and add comment from source.c
7543         (print_source_lines): Likewise.
7544         (forget_cached_source_info_for_objfile): Likewise.
7545         (forget_cached_source_info): Likewise.
7546         (select_source_symtab): Likewise.
7547         (enum print_source_lines_flag): Move definition from symtab.h.
7548         * symtab.h (identify_source_line): Move declaration to source.h.
7549         (print_source_lines): Likewise.
7550         (forget_cached_source_info_for_objfile): Likewise.
7551         (forget_cached_source_info): Likewise.
7552         (select_source_symtab): Likewise.
7553         (enum print_source_lines_flag): Move definition to source.h.
7554         * tui/tui-hooks.c: Add 'source.h' include.
7555
7556 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7557
7558         * source.c (print_source_lines_base): Handle requests to print
7559         reverse line number sequences, and guard against empty lines
7560         string.
7561
7562 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7563
7564         * source.c (print_source_lines_base): Fix skip of '\r' if next
7565         character is '\n'.
7566
7567 2019-01-06  Tom Tromey  <tom@tromey.com>
7568
7569         * c-exp.y (struct c_parse_state) <macro_original_text,
7570         expansion_obstack>: New member.
7571         (macro_original_text, expansion_obstack): Remove globals.
7572         (scan_macro_expansion, scanning_macro_expansion)
7573         (finished_macro_expansion): Update.
7574         (scan_macro_cleanup): Remove.
7575         (yylex, c_parse): Update.
7576
7577 2019-01-06  Tom Tromey  <tom@tromey.com>
7578
7579         * c-exp.y (struct c_parse_state) <strings>: New member.
7580         (operator_stoken): Update.
7581
7582 2019-01-06  Tom Tromey  <tom@tromey.com>
7583
7584         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7585         (union type_stack_elt) <typelist_val>: Now a pointer to
7586         std::vector.
7587         (type_stack_cleanup): Don't declare.
7588         (push_typelist): Update.
7589         * parse.c (pop_typelist): Return a std::vector.
7590         (push_typelist): Take a std::vector.
7591         (follow_types): Update.  Do not free args.
7592         (type_stack_cleanup): Remove.
7593         * c-exp.y (struct c_parse_state): New.
7594         (cpstate): New global.
7595         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7596         (nonempty_typelist): Update.
7597         (func_mod): Create a new vector.
7598         (c_parse): Create a c_parse_state.
7599         (check_parameter_typelist): Do not delete params.
7600         (function_method): Update.  Do not delete type_list.
7601
7602 2019-01-06  Tom Tromey  <tom@tromey.com>
7603
7604         PR gdb/28155:
7605         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7606         check_typedef.
7607         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7608         (print_return_value): Likewise.
7609
7610 2019-01-05  Tom Tromey  <tom@tromey.com>
7611
7612         * contrib/cleanup_check.py: Remove.
7613         * contrib/gcc-with-excheck: Remove.
7614         * contrib/exsummary.py: Remove.
7615         * contrib/excheck.py: Remove.
7616
7617 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7618
7619         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7620         NULL. Initialize tpprev to NULL instead of assigning it
7621         to NULL on the next statement.
7622         * windows-nat.c (windows_delete_thread): Remove check for
7623         main_thread_id before printing thread exit notifications.
7624         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7625         Remove thread ID check against main_thread_id.
7626         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7627         windows_delete_thread.
7628         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7629
7630 2019-01-04  Tom Tromey  <tom@tromey.com>
7631
7632         * compile/compile.c (_initialize_compile): Use upper case for
7633         metasyntactic variables.
7634         * symmisc.c (_initialize_symmisc): Use upper case for
7635         metasyntactic variables.
7636         * psymtab.c (_initialize_psymtab): Use upper case for
7637         metasyntactic variables.
7638         * demangle.c (demangle_command): Use upper case for metasyntactic
7639         variables.
7640         (_initialize_demangler): Likewise.
7641         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7642         variables.
7643
7644 2019-01-03  Tom Tromey  <tom@tromey.com>
7645
7646         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7647
7648 2019-01-03  Tom Tromey  <tom@tromey.com>
7649
7650         * python/py-symtab.c (salpy_str): Update.
7651         (struct salpy_sal_object) <symtab>: Now a PyObject.
7652         (salpy_dealloc): Update.
7653         (del_objfile_sal): Use gdbpy_ref.
7654
7655 2019-01-03  Tom Tromey  <tom@tromey.com>
7656
7657         * python/py-type.c (convert_field): Use new_reference.  Return
7658         gdbpy_ref.
7659         (make_fielditem): Return gdbpy_ref.
7660         (typy_fields): Update.
7661         (typy_getitem): Update.
7662         (field_name): Return gdbpy_ref.  Use new_reference.
7663         (typy_iterator_iternext): Update.
7664
7665 2019-01-03  Tom Tromey  <tom@tromey.com>
7666
7667         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7668
7669 2019-01-03  Tom Tromey  <tom@tromey.com>
7670
7671         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7672         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7673         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7674         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7675         (pspy_set_type_printers): Likewise.
7676         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7677         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7678         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7679         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7680         (objfpy_set_type_printers): Likewise.
7681
7682 2019-01-03  Tom Tromey  <tom@tromey.com>
7683
7684         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7685         (gdbpy_print_stack): Use gdbpy_err_fetch.
7686         * python/python-internal.h (class gdbpy_err_fetch): New class.
7687         (class gdbpy_enter) <m_error_type, m_error_value,
7688         m_error_traceback>: Remove.
7689         <m_error>: New member.
7690         (gdbpy_exception_to_string): Don't declare.
7691         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7692         * python/py-value.c (convert_value_from_python): Use
7693         gdbpy_err_fetch.
7694         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7695         gdbpy_exception_to_string.
7696         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7697         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7698         gdbpy_err_fetch.
7699
7700 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7701
7702         * linux-nat.c (delete_lwp_cleanup): Delete.
7703         (struct lwp_deleter): New struct.
7704         (lwp_info_up): New typedef.
7705         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7706         lwp_info_up.
7707
7708 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * linux-fork.c (class scoped_switch_fork_info): New class.
7711         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7712
7713 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * valops.c (find_overload_match): Remove use of null_cleanup, and
7716         calls to do_cleanups.
7717
7718 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7719
7720         * compile/compile-cplus-types.c
7721         (compile_cplus_instance::decl_name): Handle changes to
7722         cp_func_name.
7723         * cp-support.c (cp_func_name): Update header comment, update
7724         return type.
7725         * cp-support.h (cp_func_name): Update return type in declaration.
7726         * valops.c (find_overload_match): Move temp_func local to top
7727         level of function and change its type.  Use temp_func to hold and
7728         delete temporary string obtained from cp_func_name.
7729
7730 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7733         gdb::char_vector, remove cleanup, and update uses of `msg`.
7734
7735 2019-01-03  Jim Wilson  <jimw@sifive.com>
7736
7737         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7738
7739 2019-01-02  Tom Tromey  <tom@tromey.com>
7740
7741         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7742         (tdesc_parse_xml): Remove cleanups.
7743         * target-descriptions.h (make_cleanup_free_target_description):
7744         Don't declare.
7745         (target_desc_deleter): New struct.
7746         (target_desc_up): New typedef.
7747         * target-descriptions.c (target_desc_deleter::operator()): Rename
7748         from free_target_description.
7749         (make_cleanup_free_target_description): Remove.
7750
7751 2019-01-02  Tom Tromey  <tom@tromey.com>
7752
7753         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7754         constructor, destructor.
7755         (linespec_parser): Remove typedef.
7756         (~linespec_parser): Rename from linespec_parser_delete.
7757         (linespec_lex_to_end, linespec_complete_label)
7758         (linespec_complete): Update.
7759         (decode_line_full): Remove cleanups.
7760         (decode_line_1): Update.
7761
7762 2019-01-02  Tom Tromey  <tom@tromey.com>
7763
7764         * python/python-internal.h (inferior_to_inferior_object): Change
7765         return type.
7766         * python/py-exitedevent.c (create_exited_event_object): Update.
7767         * python/py-inferior.c (inferior_to_inferior_object): Return
7768         gdbpy_ref.
7769         (python_new_inferior, python_inferior_deleted)
7770         (thread_to_thread_object, delete_thread_object)
7771         (build_inferior_list, gdbpy_selected_inferior): Update.
7772         * python/py-infthread.c (create_thread_object): Update.  Also fail
7773         if inferior_to_inferior_object fails.
7774
7775 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7776
7777         * inferior.h (class inferior) <displaced_step_state>: New field.
7778         * infrun.h (struct displaced_step_state): Move here from
7779         infrun.c.  Initialize fields, add constructor.
7780         <inf>: Remove field.
7781         <reset>: New method.
7782         * infrun.c (struct displaced_step_inferior_state): Move to
7783         infrun.h.
7784         (displaced_step_inferior_states): Remove.
7785         (get_displaced_stepping_state): Adust.
7786         (displaced_step_in_progress_any_inferior): Adjust.
7787         (displaced_step_in_progress_thread): Adjust.
7788         (displaced_step_in_progress): Adjust.
7789         (add_displaced_stepping_state): Remove.
7790         (get_displaced_step_closure_by_addr): Adjust.
7791         (remove_displaced_stepping_state): Remove.
7792         (infrun_inferior_exit): Call displaced_step_state.reset.
7793         (use_displaced_stepping): Don't check for NULL.
7794         (displaced_step_prepare_throw): Call
7795         get_displaced_stepping_state.
7796         (displaced_step_fixup): Don't check for NULL.
7797         (prepare_for_detach): Don't check for NULL.
7798
7799 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7800
7801         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7802          in case of call that did not complete.
7803
7804 2019-01-02  Andrey Utkin  <autkin@undo.io>
7805
7806         * symfile.c (find_separate_debug_file): Fix search of debug files for
7807         remote debuggee.
7808
7809 2019-01-02  Tom Tromey  <tom@tromey.com>
7810
7811         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7812         indentation.
7813         * python/py-frame.c (frapy_older): Remove cast.
7814         (frapy_newer): Likewise.
7815         * python/py-breakpoint.c (local_setattro): Remove cast.
7816         * python/py-arch.c (archpy_name): Remove local variable.
7817         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7818
7819 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7820
7821         * unittests/basic_string_view/element_access/char/empty.cc:
7822         Fix year range in copyright header.
7823
7824 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7827         Delete.
7828         <operator==>: Update with for removed field.
7829         <hash>: Likewise.
7830         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7831         <isa_features>: ...this.
7832         <abi_features>: New field.
7833         (riscv_isa_flen): Update comment.
7834         (riscv_abi_xlen): New declaration.
7835         (riscv_abi_flen): New declaration.
7836         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7837         isa_features.
7838         (riscv_abi_xlen): New function.
7839         (riscv_isa_flen): Update to get answer from isa_features.
7840         (riscv_abi_flen): New function.
7841         (riscv_has_fp_abi): Update to get answer from abi_features.
7842         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7843         xlen and flen.
7844         (riscv_call_info) <xlen, flen>: Update comment.
7845         (riscv_call_arg_struct): Remove invalid assertions
7846         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7847         is removed.
7848         (riscv_gdbarch_init): Gather isa features and abi features
7849         separately, ensure both match on the gdbarch when reusing an old
7850         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7851         a target with 64-bit float hardware.
7852
7853 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7854
7855         * source.c (search_command_helper): Stop reverse search
7856         when line 1 has been searched.
7857
7858 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7859
7860         * record-full.c (record_full_base_target::close): Rewrite
7861         record_full_core_buf_list free logic.
7862
7863 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7864
7865         * break-catch-syscall.c (print_one_catch_syscall): xfree
7866         the last text.
7867
7868 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7869
7870         * top.c (print_gdb_version): Update Copyright year in version
7871         message.
7872
7873 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7874
7875         Update copyright year range in all GDB files.
7876
7877 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7878
7879         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7880
7881 For older changes see ChangeLog-2018.
7882 \f
7883 Local Variables:
7884 mode: change-log
7885 left-margin: 8
7886 fill-column: 74
7887 version-control: never
7888 coding: utf-8
7889 End:
7890