gdb/ChangeLog

   1 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
   2
   3         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
   4         * configure.host: Mark *-*-solaris2.10* obsolete.
   5         * configure.tgt: Mark Solaris < 11 obsolete.
   6         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
   7         Update target triplet.
   8
   9 2019-11-01  Tom Tromey  <tromey@adacore.com>
  10
  11         * utils.c (print_sys_errmsg): Simplify.
  12
  13 2019-11-01  Tom Tromey  <tromey@adacore.com>
  14
  15         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
  16
  17 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * configure: Regenerate.
  20         * configure.ac: Remove check for strerror_r.
  21         * gdbsupport/common.m4: Check for strerror_r.
  22
  23 2019-11-01  Luis Machado  <luis.machado@linaro.org>
  24
  25         PR gdb/25124
  26
  27         * arm-tdep.c (arm_per_objfile): Rename to ...
  28         (arm_per_bfd): ... this.
  29         (arm_objfile_data_key): Rename to ...
  30         (arm_bfd_data_key): ... this.
  31         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
  32         data.
  33         (arm_record_special_symbol): Likewise.
  34
  35 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
  38         end.
  39         * c-typeprint.c (c_print_typedef): Likewise.
  40         * f-typeprint.c (f_print_typedef): Likewise.
  41         * m2-typeprint.c (m2_print_typedef): Likewise.
  42         * p-typeprint.c (pascal_print_typedef): Likewise.
  43         * rust-lang.c (rust_print_typedef): Likewise.
  44         * symtab.c (print_symbol_info): Print a newline after calling
  45         typedef_print.
  46
  47 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * symtab.c (info_module_cmdlist): New variable.
  50         (info_module_command): New function.
  51         (search_module_symbols): New function.
  52         (info_module_subcommand): New function.
  53         (struct info_modules_var_func_options): New struct.
  54         (info_modules_var_func_options_defs): New variable.
  55         (make_info_modules_var_func_options_def_group): New function.
  56         (info_module_functions_command): New function.
  57         (info_module_variables_command): New function.
  58         (info_module_var_func_command_completer): New function.
  59         (_initialize_symtab): Register new 'info module functions' and
  60         'info module variables' commands.
  61         * symtab.h (typedef symbol_search_in_module): New typedef.
  62         (search_module_symbols): Declare new function.
  63         * NEWS: Mention new commands.
  64
  65 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  66
  67         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
  68         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
  69         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
  70         MODULES_DOMAIN.
  71         (scan_partial_symbols): Only create partial module symbols for non
  72         declarations.
  73         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
  74         and MODULES_DOMAIN.
  75         * symtab.c (search_domain_name): Likewise.
  76         (search_symbols): Likewise.
  77         (print_symbol_info): Likewise.
  78         (symtab_symbol_info): Likewise.
  79         (info_modules_command): New function.
  80         (_initialize_symtab): Register 'info modules' command.
  81         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
  82         * NEWS: Mention new 'info modules' command.
  83
  84 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  85
  86         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
  87         and $_gdb_maint_setting_str.
  88
  89 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90
  91         * cli/cli-cmds.c (setting_cmd, value_from_setting)
  92         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
  93         (str_value_from_setting, gdb_setting_str_internal_fn)
  94         (gdb_maint_setting_str_internal_fn): New functions.
  95         (_initialize_cli_cmds): Define the new convenience functions.
  96         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
  97         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  98
  99 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 100
 101         * agent.c (set_can_use_agent): When the setting is turned on,
 102         look up agent symbols if we don't have them yet.
 103         (agent_new_objfile): Don't look up agent symbols when the agent
 104         setting is off.
 105
 106 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 107
 108         * config.in: Regenerate.
 109
 110 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 111
 112         * configure: Regenerate.
 113         * configure.ac: Check for strerror_r.
 114         * gdbsupport/common-utils.h (safe_strerror): Change return value
 115         to const char * and document that this function is now threadsafe.
 116         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 117         thread_local and call strerror_r, if available.
 118         * utils.c (perror_string): Update.
 119         (print_sys_errmsg): Update.
 120
 121 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 122
 123         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 124         objfile_key.
 125         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 126         objfile to fetch per-bfd data.
 127         (arm_find_exidx_entry): Likewise.
 128
 129 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * gdbsupport/agent.c (debug_agent): Change type to bool.
 132         (use_agent): Likewise.
 133         (all_agent_symbols_look_up): Likewise.
 134         (agent_loaded_p): Change return value to bool.
 135         (agent_look_up_symbols): Update.
 136         (agent_capability_check): Change return value to bool.
 137         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 138         (debug_agent): Change type to bool.
 139         (use_agent): Likewise.
 140         (agent_capability_check): Change return value to bool.
 141
 142 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 143
 144         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 145         (build_minimal_symbol_hash_tables): Code to clear the table moved
 146         to clear_minimal_symbol_hash_tables.
 147         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 148         when needed.
 149
 150 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 151
 152         * infcmd.c: Remove includes.
 153         * infrun.c: Remove includes.
 154
 155 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 156
 157         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 158         (grow_vect): Remove declaration.
 159         (ada_type_of_array): Remove declaration.
 160         (ada_update_initial_language): Remove declaration.
 161         (ada_fold_name): Remove declaration.
 162         (ada_fill_in_ada_prototype): Remove declaration.
 163         (user_select_syms): Remove declaration.
 164         (get_selections): Remove declaration.
 165         (ada_tag_type): Remove declaration.
 166         (ada_value_tag): Remove declaration.
 167         (ada_is_others_clause): Remove declaration.
 168         (ada_in_variant): Remove declaration.
 169         (ada_value_struct_elt): Remove declaration.
 170         (ada_attribute_name): Remove declaration.
 171         (ada_system_address_type): Remove declaration.
 172         * ada-lang.c (ada_watch_location_expression): Make static.
 173         (GROW_VECT): Move here from ada-lang.h.
 174         (grow_vect): Make static.
 175         (ada_update_initial_language): Make static.
 176         (ada_fold_name): Make static.
 177         (ada_type_of_array): Make static.
 178         (encoded_ordered_before): Move up.
 179         (sort_choices): Move up.
 180         (print_signatures): Move up.
 181         (ada_print_symbol_signature): Move up.
 182         (get_selections): Move up and make static.
 183         (user_select_syms): Move up and make static.
 184         (ada_value_struct_elt): Move up and make static.
 185         (ada_tag_type): Make static.
 186         (ada_value_tag): Make static.
 187         (ada_is_others_clause): Make static.
 188         (ada_in_variant): Make static.
 189         (ada_attribute_name): Make static.
 190
 191 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 192
 193         * ada-lang.c: Remove includes.
 194         * ada-typeprint.c: Remove includes.
 195         * ada-valprint.c: Remove includes.
 196
 197 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 198
 199         * addrmap.c: Add static assertions of type size, moved from
 200         _initialize_addrmap.
 201         (_initialize_addrmap): Remove.
 202
 203 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 204
 205         * coffread.c (record_minimal_symbol): Update.
 206         (process_coff_symbol): Update.
 207         * dbxread.c (read_dbx_symtab): Update.
 208         * dwarf2read.c (add_partial_symbol): Update.
 209         (fixup_go_packaging): Update.
 210         (load_partial_dies): Update.
 211         (new_symbol): Update.
 212         * elfread.c (record_minimal_symbol): Change signature to use
 213         gdb::string_view instead of name+len.
 214         (elf_symtab_read): Update.
 215         (elf_rel_plt_read): Update.
 216         * mdebugread.c (parse_partial_symbols): Update.
 217         (handle_psymbol_enumerators): Update.
 218         (new_symbol): Update.
 219         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 220         to use gdb::string_view instead of name+len.
 221         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 222         * psympriv.h (add_psymbol_to_list): Likewise.
 223         * psymtab.c (add_psymbol_to_bcache): Likewise.
 224         (add_psymbol_to_list): Likewise.
 225         * stabsread.c (define_symbol): Update.
 226         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 227         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 228         (symbol_set_names): Likewise.
 229         * xcoffread.c (scan_xcoff_symtab): Update.
 230
 231 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 232
 233         * symtab.h (symbol_set_names): Document that copy_name must be
 234         set to true for non-nullterminated strings.
 235         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 236         linkage_name if the entry was not found and we need to demangle.
 237
 238 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 239
 240         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 241         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 242         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 243         * gdbsupport/gdb_binary_search.h: New file.
 244
 245 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 246
 247         * NEWS: Mention new --with-system-gdbinit-dir option.
 248         * config.in: Regenerate.
 249         * configure: Regenerate.
 250         * configure.ac: Add new option --with-system-gdbinit-dir.
 251         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 252         for a ".gdb" suffix.
 253         * main.c (get_init_files): Change system_gdbinit argument to
 254         a vector and return the files in SYSTEM_GDBINIT_DIR in
 255         addition to SYSTEM_GDBINIT.
 256         (captured_main_1): Update.
 257         (print_gdb_help): Update.
 258         * top.c (print_gdb_configuration): Also print the value of
 259         SYSTEM_GDBINIT_DIR.
 260
 261 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 262
 263         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 264         that takes gdb::string_view arguments.
 265
 266 2019-10-26  Tom de Vries  <tdevries@suse.de>
 267
 268         * aarch64-linux-tdep.c: Fix typos in comments.
 269         * aarch64-tdep.c: Same.
 270         * ada-lang.c: Same.
 271         * amd64-nat.c: Same.
 272         * arc-tdep.c: Same.
 273         * arch/aarch64-insn.c: Same.
 274         * block.c: Same.
 275         * breakpoint.h: Same.
 276         * btrace.h: Same.
 277         * c-varobj.c: Same.
 278         * cli/cli-decode.c: Same.
 279         * cli/cli-script.c: Same.
 280         * cli/cli-utils.h: Same.
 281         * coff-pe-read.c: Same.
 282         * coffread.c: Same.
 283         * compile/compile-cplus-symbols.c: Same.
 284         * compile/compile-object-run.c: Same.
 285         * completer.c: Same.
 286         * corelow.c: Same.
 287         * cp-support.c: Same.
 288         * demangle.c: Same.
 289         * dwarf-index-write.c: Same.
 290         * dwarf2-frame.c: Same.
 291         * dwarf2-frame.h: Same.
 292         * eval.c: Same.
 293         * frame-base.h: Same.
 294         * frame.h: Same.
 295         * gdbcmd.h: Same.
 296         * gdbtypes.h: Same.
 297         * gnu-nat.c: Same.
 298         * guile/scm-objfile.c: Same.
 299         * i386-tdep.c: Same.
 300         * i386-tdep.h: Same.
 301         * infcall.c: Same.
 302         * infcall.h: Same.
 303         * linux-nat.c: Same.
 304         * m68k-tdep.c: Same.
 305         * macroexp.c: Same.
 306         * memattr.c: Same.
 307         * mi/mi-cmd-disas.c: Same.
 308         * mi/mi-getopt.h: Same.
 309         * mi/mi-main.c: Same.
 310         * minsyms.c: Same.
 311         * nat/aarch64-sve-linux-sigcontext.h: Same.
 312         * objfiles.h: Same.
 313         * ppc-linux-nat.c: Same.
 314         * ppc-linux-tdep.c: Same.
 315         * ppc-tdep.h: Same.
 316         * progspace.h: Same.
 317         * prologue-value.h: Same.
 318         * python/py-evtregistry.c: Same.
 319         * python/py-instruction.h: Same.
 320         * record-btrace.c: Same.
 321         * record-full.c: Same.
 322         * remote.c: Same.
 323         * rs6000-tdep.c: Same.
 324         * ser-tcp.c: Same.
 325         * sol-thread.c: Same.
 326         * sparc-sol2-tdep.c: Same.
 327         * sparc64-tdep.c: Same.
 328         * stabsread.c: Same.
 329         * symfile.c: Same.
 330         * symtab.h: Same.
 331         * target.c: Same.
 332         * tracepoint.c: Same.
 333         * tui/tui-data.h: Same.
 334         * tui/tui-io.c: Same.
 335         * tui/tui-win.c: Same.
 336         * tui/tui.c: Same.
 337         * unittests/rsp-low-selftests.c: Same.
 338         * user-regs.h: Same.
 339         * utils.c: Same.
 340         * utils.h: Same.
 341         * valarith.c: Same.
 342         * valops.c: Same.
 343         * valprint.c: Same.
 344         * valprint.h: Same.
 345         * value.c: Same.
 346         * value.h: Same.
 347         * varobj.c: Same.
 348         * x86-nat.h: Same.
 349         * xtensa-tdep.c: Same.
 350
 351 2019-10-25  Ali Tamur <tamur@google.com>
 352
 353         * charset.c (find_charset_names): Reflect API change.
 354
 355 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 356
 357         * symtab.c (struct demangled_name_entry): Change demangled name
 358         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 359         part of the struct anymore.
 360         (symbol_set_names): No longer obstack allocate + copy the demangled
 361         name, just store the allocated name from bfd.
 362
 363 2019-10-25  Tom Tromey  <tromey@adacore.com>
 364
 365         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 366         (bsearch_cie_cmp, add_cie): Remove.
 367         (find_cie): Reimplement.
 368         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 369         (dwarf2_build_frame_info): Update.
 370
 371 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 372
 373         PR gdb/25126
 374         * symfile.c (reread_symbols): Call forget_cached_source_info to
 375         clear the stale source cache.
 376
 377 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 378
 379         * configure: Regenerate.
 380         * configure.ac: Remove code that sets python_has_threads.
 381
 382 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 383
 384         * config.in: Regenerate.
 385         * configure: Regenerate.
 386         * configure.ac: Remove the code that uses sed to get the python
 387         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 388
 389 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 392         error paths.
 393
 394 2019-10-23  Tom Tromey  <tom@tromey.com>
 395
 396         * arc-tdep.c: Remove ".." from include.
 397         * frv-tdep.c: Remove ".." from include.
 398         * lm32-tdep.c: Remove ".." from include.
 399         * microblaze-tdep.c: Remove ".." from include.
 400         * or1k-tdep.h: Remove ".." from include.
 401         * s12z-tdep.c: Remove ".." from include.
 402         * Makefile.in (OPCODES_CFLAGS): Add comment.
 403         (TOP_CFLAGS): New variable.
 404         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 405
 406 2019-10-23  Tom Tromey  <tom@tromey.com>
 407
 408         * Makefile.in (READLINE_DIR): Update.
 409
 410 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 411
 412         * infcall.c (call_function_by_hand_dummy): Fix the function
 413         comment.  And extract out a code section into...
 414         (reserve_stack_space): ...this new function.
 415
 416 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 417
 418         * infcall.c (value_arg_coerce): Remove an unused parameter.
 419         (call_function_by_hand_dummy): Update the call to
 420         'value_arg_coerce'.
 421
 422 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 423
 424         * infcall.c (call_function_by_hand_dummy): Refactor.
 425
 426 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 427
 428         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 429
 430 2019-10-23  Tom Tromey  <tom@tromey.com>
 431
 432         * configure: Rebuild.
 433         * configure.ac: Don't check for sigprocmask.
 434         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 435
 436 2019-10-23  Tom Tromey  <tom@tromey.com>
 437
 438         * configure: Rebuild.
 439         * acinclude.m4: Use m4_include, not sinclude.
 440
 441 2019-10-23  Tom de Vries  <tdevries@suse.de>
 442
 443         PR breakpoints/24687
 444         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 445
 446 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 447
 448         * symtab.c (struct demangled_name_entry) <language>: Change from
 449         bitfield to regular variable.
 450
 451 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 452
 453         * symtab.c (struct demangled_name_entry): Add a constructor.
 454         (free_demangled_name_entry): New function to call the destructor
 455         for demangled_name_entry.
 456         (create_demangled_names_hash): Pass free_demangled_name_entry to
 457         htab_create_alloc.
 458         (symbol_set_names): Call placement new for demangled_name_entry.
 459         * utils.c: No longer include xxhash.h here, now that fast_hash
 460         is inlined in the header.
 461         * utils.h: Instead, include it here.
 462
 463 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * Makefile.in: Link with libxxhash.
 466         * config.in: Regenerate.
 467         * configure: Regenerate.
 468         * configure.ac: Search for libxxhash.
 469         * utils.c (fast_hash): Use xxhash if present.
 470
 471 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 472
 473         * utils.h (fast_hash): New function.
 474         * symtab.c (hash_demangled_name_entry): Call new function
 475         fast_hash.
 476
 477 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 478
 479         * symtab.c (struct demangled_name_entry): Change type of mangled
 480         to gdb::string_view. Also adds a constructor that takes the
 481         mangled name.
 482         (hash_demangled_name_entry): Update.
 483         (eq_demangled_name_entry): Update.
 484         (free_demangled_name_entry): New function to call the destructor
 485         now that this is not a POD anymore.
 486         (create_demangled_names_hash): Pass free_demangled_name_entry to
 487         htab_create_alloc.
 488         (symbol_set_names): Update.
 489
 490 2019-10-21  Ali Tamur  <tamu@google.com>
 491
 492         * dwarf2read.c (dir_index): Change type.
 493         (file_name_index): Likewise.
 494         (line_header::include_dir_at): Change comment and implementation on
 495         whether it is DWARF 5.
 496         (line_header::is_valid_file_index): New function.
 497         (line_header::file_name_at): Change comment and implementation on
 498         whether it is DWARF 5.
 499         (line_header::file_names): Change to private field renamed as
 500         m_file_names and introduce a new accessor method.
 501         (line_header::file_names_size): New method.
 502         (line_header::include_dirs): Change to private field and rename as
 503         m_include_dirs.
 504         (dw2_get_file_names_reader): Define local var at a smaller scope and
 505         reflect API change.
 506         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 507         (process_structure_scope): Likewise.
 508         (line_header::add_include_dir): Change message and reflect renaming.
 509         (line_header::add_file_name): Likewise.
 510         (read_formatted_entries): Handle DW_FORM_data16.
 511         (dwarf_decode_line_header): Fix line header length calculation.
 512         (psymtab_include_file_name): Change comment and API.
 513         (lnp_state_machine::m_file): Update comment and reflect type change.
 514         (lnp_state_machine::record_line): Reflect type change.
 515         (dwarf_decode_lines): Reflect API change.
 516         (file_file_name): Likewise.
 517         (file_full_name): Likewise.
 518
 519 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 522
 523 2019-10-21  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 526
 527 2019-10-21  Tom Tromey  <tom@tromey.com>
 528
 529         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 530         NM_H.   Use AC_CONFIG_LINKS.
 531         * configure: Rebuild.
 532         * Makefile.in (NM_H): New variable.
 533         (generated_files): Add NM_H.  Remove gcore.
 534         (nm.h, stamp-nmh): New targets.
 535
 536 2019-10-20  Tom Tromey  <tom@tromey.com>
 537
 538         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 539         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 540         obsolete comment.
 541         (put_objfile_before): Now static.
 542
 543 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 544
 545         * gdbsupport/common-utils.h (startswith): Change return type to
 546         bool.
 547
 548 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 549
 550         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 551         * breakpoint.c (bp_locations_compare): Rename to...
 552         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 553         (update_global_location_list): Use std::sort instead of qsort.
 554         * buildsym.c (compare_line_numbers): Rename to...
 555         (lte_is_less_than): ...this, and change to std::sort semantics.
 556         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 557         instead of qsort.
 558         * disasm.c (compare_lines): Rename to...
 559         (line_is_less_than): ...this, and change to std::sort semantics.
 560         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 561         of qsort.
 562         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 563         (fde_is_less_than): ...this, and change to std::sort semantics.
 564         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 565         * mdebugread.c (compare_blocks):
 566         (block_is_less_than): ...this, and change to std::sort semantics.
 567         (sort_blocks): Call std::sort instead of qsort.
 568         * objfiles.c (qsort_cmp): Rename to...
 569         (sort_cmp): ...this, and change to std::sort semantics.
 570         (update_section_map): Call std::sort instead of qsort.
 571         * remote.c (compare_pnums): Remove.
 572         (map_regcache_remote_table): Call std::sort instead of qsort.
 573         * utils.c (compare_positive_ints): Remove.
 574         * utils.h (compare_positive_ints): Remove.
 575         * xcoffread.c (compare_lte): Remove.
 576         (arrange_linetable): Call std::sort instead of qsort.
 577
 578 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 579
 580         * symfile.c (init_entry_point_info): Fix typo.
 581         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 582
 583 2019-10-18  Tom de Vries  <tdevries@suse.de>
 584
 585         * aarch64-tdep.c: Fix typos in comments.
 586         * ada-lang.c: Same.
 587         * ada-tasks.c: Same.
 588         * alpha-tdep.c: Same.
 589         * alpha-tdep.h: Same.
 590         * amd64-nat.c: Same.
 591         * amd64-windows-tdep.c: Same.
 592         * arc-tdep.c: Same.
 593         * arc-tdep.h: Same.
 594         * arch-utils.c: Same.
 595         * arm-nbsd-tdep.c: Same.
 596         * arm-tdep.c: Same.
 597         * ax-gdb.c: Same.
 598         * blockframe.c: Same.
 599         * btrace.c: Same.
 600         * c-varobj.c: Same.
 601         * coff-pe-read.c: Same.
 602         * coffread.c: Same.
 603         * cris-tdep.c: Same.
 604         * darwin-nat.c: Same.
 605         * dbxread.c: Same.
 606         * dcache.c: Same.
 607         * disasm.c: Same.
 608         * dtrace-probe.c: Same.
 609         * dwarf-index-write.c: Same.
 610         * dwarf2-frame-tailcall.c: Same.
 611         * dwarf2-frame.c: Same.
 612         * dwarf2read.c: Same.
 613         * eval.c: Same.
 614         * exceptions.c: Same.
 615         * fbsd-tdep.c: Same.
 616         * findvar.c: Same.
 617         * frame.c: Same.
 618         * frv-tdep.c: Same.
 619         * gnu-v3-abi.c: Same.
 620         * go32-nat.c: Same.
 621         * h8300-tdep.c: Same.
 622         * hppa-tdep.c: Same.
 623         * i386-linux-tdep.c: Same.
 624         * i386-tdep.c: Same.
 625         * ia64-libunwind-tdep.c: Same.
 626         * ia64-tdep.c: Same.
 627         * infcmd.c: Same.
 628         * infrun.c: Same.
 629         * linespec.c: Same.
 630         * linux-nat.c: Same.
 631         * linux-thread-db.c: Same.
 632         * machoread.c: Same.
 633         * mdebugread.c: Same.
 634         * mep-tdep.c: Same.
 635         * mn10300-tdep.c: Same.
 636         * namespace.c: Same.
 637         * objfiles.c: Same.
 638         * opencl-lang.c: Same.
 639         * or1k-tdep.c: Same.
 640         * osabi.c: Same.
 641         * ppc-linux-nat.c: Same.
 642         * ppc-linux-tdep.c: Same.
 643         * ppc-sysv-tdep.c: Same.
 644         * printcmd.c: Same.
 645         * procfs.c: Same.
 646         * record-btrace.c: Same.
 647         * record-full.c: Same.
 648         * remote-fileio.c: Same.
 649         * remote.c: Same.
 650         * rs6000-tdep.c: Same.
 651         * s12z-tdep.c: Same.
 652         * score-tdep.c: Same.
 653         * ser-base.c: Same.
 654         * ser-go32.c: Same.
 655         * skip.c: Same.
 656         * sol-thread.c: Same.
 657         * solib-svr4.c: Same.
 658         * solib.c: Same.
 659         * source.c: Same.
 660         * sparc-nat.c: Same.
 661         * sparc-sol2-tdep.c: Same.
 662         * sparc-tdep.c: Same.
 663         * sparc64-tdep.c: Same.
 664         * stabsread.c: Same.
 665         * stack.c: Same.
 666         * symfile.c: Same.
 667         * symtab.c: Same.
 668         * target-descriptions.c: Same.
 669         * target-float.c: Same.
 670         * thread.c: Same.
 671         * utils.c: Same.
 672         * valops.c: Same.
 673         * valprint.c: Same.
 674         * value.c: Same.
 675         * varobj.c: Same.
 676         * windows-nat.c: Same.
 677         * xcoffread.c: Same.
 678         * xstormy16-tdep.c: Same.
 679         * xtensa-tdep.c: Same.
 680
 681 2019-10-17  Tom Tromey  <tromey@adacore.com>
 682
 683         * configure: Rebuild.
 684         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 685         in AC_CONFIG_FILES invocation.
 686         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 687         new-style config.status invocation.
 688
 689 2019-10-17  Tom de Vries  <tdevries@suse.de>
 690
 691         * arm-nbsd-nat.c: Fix typos in comments.
 692         * arm-tdep.c: Same.
 693         * darwin-nat-info.c: Same.
 694         * dwarf2read.c: Same.
 695         * elfread.c: Same.
 696         * event-top.c: Same.
 697         * findvar.c: Same.
 698         * gdbtypes.c: Same.
 699         * hppa-tdep.c: Same.
 700         * i386-tdep.c: Same.
 701         * jit.c: Same.
 702         * main.c: Same.
 703         * mdebugread.c: Same.
 704         * moxie-tdep.c: Same.
 705         * nto-procfs.c: Same.
 706         * osabi.c: Same.
 707         * ppc-linux-tdep.c: Same.
 708         * remote.c: Same.
 709         * riscv-tdep.c: Same.
 710         * s390-tdep.c: Same.
 711         * sh-tdep.c: Same.
 712         * sparc-linux-tdep.c: Same.
 713         * sparc-nat.c: Same.
 714         * stack.c: Same.
 715         * target-descriptions.c: Same.
 716         * top.c: Same.
 717         * varobj.c: Same.
 718
 719 2019-10-16  Tom Tromey  <tom@tromey.com>
 720
 721         * objfiles.h (struct objfile) <original_name>: Now const.
 722
 723 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 724
 725         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 726         pass on to sigsetjmp's second argument.
 727         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 728
 729 2019-10-16  Keith Seitz  <keiths@redhat.com>
 730
 731         PR gdb/23567
 732         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 733         sections whose size is greater than the file size.
 734
 735 2019-10-16  Jim Wilson  <jimw@sifive.com>
 736
 737         * riscv-tdep.c (riscv_gcc_target_options): New.
 738         (riscv_gnu_triplet_regexp): New.
 739         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 740         set_gdbarch_gnu_triplet_regexp.
 741
 742 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 743
 744         * Makefile.in: Add xml-builtin.h.
 745         * features/feature_to_c.sh: Add an include for xml-builtin.h
 746         to ensure that the compiler checks that the types match.
 747         * xml-builtin.h: New file.
 748         * xml-support.c (fetch_xml_builtin): Add missing const.
 749         * xml-support.h: Remove declaration of xml_builtins.
 750
 751 2019-10-16  Tom de Vries  <tdevries@suse.de>
 752
 753         PR tdep/25096
 754         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 755         (amd64_classify_aggregate): ... here.
 756         (amd64_classify_aggregate_field): Handled fiels of nested structs
 757         recursively.
 758
 759 2019-10-16  Tom de Vries  <tdevries@suse.de>
 760
 761         PR tdep/24104
 762         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 763         that handles 'theclass'.
 764
 765 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * linespec.c (decode_digits_ordinary): Update comment.
 768         * make-target-delegates: No longer need to handle VEC case.
 769         * memrange.c (normalize_mem_ranges): Update comment.
 770         * namespace.c (add_using_directive): Update comment.
 771         * objc-lang.c (uniquify_strings): Update comment.
 772         * ppc-linux-nat.c (struct thread_points): Update comment.
 773         * probe.h (find_probes_in_objfile): Update comment.
 774         * target.h (enum flash_preserve_mode): Update comment.
 775         * varobj.c (varobj_restrict_range): Update comment.
 776         * varobj.h (varobj_list_children): Update comment.
 777
 778 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * Makefile.in: Remove references to vec.h and vec.c.
 781         * aarch64-tdep.c: No longer include vec.h.
 782         * ada-lang.c: Likewise.
 783         * ada-lang.h: Likewise.
 784         * arm-tdep.c: Likewise.
 785         * ax.h: Likewise.
 786         * breakpoint.h: Likewise.
 787         * charset.c: Likewise.
 788         * cp-support.h: Likewise.
 789         * dtrace-probe.c: Likewise.
 790         * dwarf2read.c: Likewise.
 791         * extension.h: Likewise.
 792         * gdb_bfd.c: Likewise.
 793         * gdbsupport/gdb_vecs.h: Likewise.
 794         * gdbsupport/vec.c: Remove.
 795         * gdbsupport/vec.h: Remove.
 796         * gdbthread.h: Likewise.
 797         * guile/scm-type.c: Likewise.
 798         * inline-frame.c: Likewise.
 799         * machoread.c: Likewise.
 800         * memattr.c: Likewise.
 801         * memrange.h: Likewise.
 802         * namespace.h: Likewise.
 803         * nat/linux-btrace.h: Likewise.
 804         * osdata.c: Likewise.
 805         * parser-defs.h: Likewise.
 806         * progspace.h: Likewise.
 807         * python/py-type.c: Likewise.
 808         * record-btrace.c: Likewise.
 809         * rust-exp.y: Likewise.
 810         * solib-target.c: Likewise.
 811         * stap-probe.c: Likewise.
 812         * target-descriptions.c: Likewise.
 813         * target-memory.c: Likewise.
 814         * target.h: Likewise.
 815         * varobj.c: Likewise.
 816         * varobj.h: Likewise.
 817         * xml-support.h: Likewise.
 818
 819 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 822         Update for new std::vector based implementation.
 823         (process_psymtab_comp_unit_reader): Likewise.
 824         (scan_partial_symbols): Likewise.
 825         (recursively_compute_inclusions): Likewise.
 826         (compute_compunit_symtab_includes): Likewise.
 827         (process_imported_unit_die): Likewise.
 828         (queue_and_load_dwo_tu): Likewise.
 829         (follow_die_sig_1): Likewise.
 830         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 831         (typedef dwarf2_per_cu_ptr): Remove.
 832         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 833         function.
 834         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 835         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 836         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 837         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 838         std::vector.
 839
 840 2019-10-15  Tom Tromey  <tromey@adacore.com>
 841
 842         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 843         TID.
 844
 845 2019-10-15  Tom Tromey  <tromey@adacore.com>
 846
 847         * windows-nat.c (windows_nat_target::fetch_registers)
 848         (windows_nat_target::store_registers): Rename "pid" to "tid".
 849
 850 2019-10-15  Tom Tromey  <tromey@adacore.com>
 851
 852         * gdbarch.h, gdbarch.c: Rebuild.
 853         * gdbarch.sh (gcc_target_options): Change return type to
 854         std::string.
 855         * compile/compile.c (get_args): Update.
 856         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 857         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 858         std::string.
 859         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 860         std::string.
 861         * arch-utils.c (default_gcc_target_options): Return std::string.
 862         * arch-utils.h (default_gcc_target_options): Return std::string.
 863         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 864
 865 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 866
 867         * breakpoint.c (breakpoint_chain): Make static.
 868         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 869         of accessing breakpoint_chain.
 870
 871 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 872
 873         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 874         to a gdb::function_view and return value to bool.
 875         * breakpoint.h (iterate_over_breakpoints): Likewise.
 876         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 877         (pop_dummy_frame): Update.
 878         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 879         (gdbscm_breakpoints): Update.
 880         * python/py-breakpoint.c (build_bp_list): Update.
 881         (gdbpy_breakpoints): Update.
 882         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 883         Update.
 884         (bpfinishpy_handle_stop): Update.
 885         (bpfinishpy_handle_exit): Update.
 886         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 887         (svr4_update_solib_event_breakpoints): Update.
 888
 889 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 890
 891         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 892         when unwrapping single-field structs.
 893
 894 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 895
 896         * dwarf2read.c: Remove includes.
 897
 898 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 899
 900         * ui-out.c (ui_out::call_do_message): Silence
 901         -Wformat-nonliteral warning.
 902
 903 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 904
 905         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 906         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 907         include: readline/tilde.h.
 908
 909 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 910
 911         * remote.c (remote_target::get_trace_status): Remove declaration of
 912         trace_regblock_size.
 913
 914 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 915
 916         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 917         (show_user): Remove declaration of cmdlist.
 918         * cli/cli-cmds.h (max_user_call_depth): Declare.
 919         * cli/cli-script.c (execute_user_command): Remove declaration
 920         of max_user_call_depth.
 921
 922 2019-10-11  Jim Wilson  <jimw@sifive.com>
 923
 924         * gdbsupport/print-utils.h (pulongest): Fix comment.
 925         (plongest): Likewise.
 926         (phex): Add missing comment, mention leading zeros.
 927         (phex_nz): Add mention of no leading zeros to comment.
 928
 929         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 930         plongest instead of unsigned long long cast.
 931
 932 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 933
 934         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 935         for external_editor_command and gdbtk_test.
 936
 937 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 938
 939         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 940         * varobj.c (varobjdebug): Move comment to...
 941         * varobj.h (varobjdebug): ...here, and declare.
 942
 943 2019-10-09  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 946         erase_data_content.
 947
 948 2019-10-09  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 951         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 952         * tui/tui-command.c (tui_cmd_window::resize)
 953         (tui_refresh_cmd_win): Update.
 954         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 955         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 956         * tui/tui-data.c (~tui_gen_win_info): Remove.
 957         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 958         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 959         (tui_redisplay_readline, tui_mld_flush)
 960         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 961         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 962         (tui_data_window::erase_data_content)
 963         (tui_data_item_window::rerender)
 964         (tui_data_item_window::refresh_window): Update.
 965         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 966         (box_win, tui_gen_win_info::make_window)
 967         (tui_gen_win_info::make_visible): Update.
 968         (tui_delete_win): Remove.
 969         * tui/tui-winsource.c
 970         (tui_source_window_base::do_erase_source_content): Update.
 971         (tui_show_source_line, tui_source_window_base::update_tab_width)
 972         (tui_source_window_base::update_exec_info): Update.
 973         * tui/tui-data.h (struct curses_deleter): New.
 974         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 975         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 976
 977 2019-10-09  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 980
 981 2019-10-09  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 984         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 985
 986 2019-10-09  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 989         window height directly.
 990         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 991         declare.
 992         * tui/tui-layout.c (tui_default_win_height): Remove.
 993         (tui_default_win_viewport_height): Remove.
 994
 995 2019-10-09  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui.h: Remove comments.
 998
 999 2019-10-09  Tom de Vries  <tdevries@suse.de>
1000
1001         * python/lib/gdb/printer/bound_registers.py: Use
1002         '^builtin_type_bound128' as regexp argument for
1003         add_builtin_pretty_printer.
1004
1005 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * guile/guile.c (guile_extension_script_ops): Remove forward
1008         declaration and mark as static.
1009         (guile_script_ops): Likewise.
1010         (extension_language_guile): Move further down in the file so
1011         it can reference the definitions for guile_{extension_,}script_ops.
1012
1013 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1014
1015         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1016         except SORTL, DFLTCC, and KDSA.
1017
1018 2019-10-08  Tom Tromey  <tromey@adacore.com>
1019
1020         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1021         (struct safe_symbol_file_add_args): Remove.
1022
1023 2019-10-08  Tom Tromey  <tromey@adacore.com>
1024
1025         * windows-nat.c: Don't include buildsym-legacy.h.
1026
1027 2019-10-08  Tom Tromey  <tromey@adacore.com>
1028
1029         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1030
1031 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1032
1033         * gdbtypes.c (overload_debug): Move comment to header.
1034         * gdbtypes.h (overload_debug): Declare.
1035         * valops.c: Remove declaration of overload_debug, instead
1036         include gdbtypes.h.
1037
1038 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1039
1040         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1041         through _().
1042         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1043         move comment...
1044         * language.h (lang_frame_mismatch_warn): ... here. Also add
1045         declaration.
1046         * top.c (lang_frame_mismatch_warn): Remove declaration.
1047         (check_frame_language_change): Pass lang_frame_mismatch_warn
1048         through _().
1049
1050 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1051
1052         * c-lang.h (vtbl_ptr_name): Declare.
1053         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1054         it from the header.
1055         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1056
1057 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1058
1059         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1060         gdb_static_assert.
1061
1062 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1063
1064         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1065         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1066         * ctfread.c: New file.
1067         * ctfread.h: New file.
1068         * elfread.c: Include ctfread.h.
1069         (struct elfinfo text_p): New member ctfsect.
1070         (elf_locate_sections): Mark CTF section.
1071         (elf_symfile_read): Call elfctf_build_psymtabs.
1072         * Makefile.in (LIBCTF): Add.
1073         (CLIBS): Use it.
1074         (CDEPS): Likewise.
1075         (DIST): Add ctfread.c.
1076
1077 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1078
1079         * ctfread.c (struct nextfield): Renamed to ...
1080         (struct ctf_nextfield): ... this.
1081         (struct field_info): Renamed to ...
1082         (strut ctf_field_info): ... this.
1083         (attach_fields_to_type): Update for renamed structures.
1084         (ctf_add_member_cb): Likewise.
1085         (ctf_add_enum_member_cb): Likewise.
1086         (process_struct_members): Likewise.
1087         (process_enum_type): Likewise.
1088
1089 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1090
1091         * tracectf.h: Rename, was ctf.h.
1092         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1093         * tracefile.c: Likewise.
1094         * tracepoint.c: Remove unused include ctf.h.
1095         * mi/mi-main.c: Likewise.
1096         * Makefile.in Replace ctf.c with tracectf.c.
1097
1098 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1099
1100         * version.in: Change version number to "9.0.50.DATE-git".
1101
1102 2019-10-03  Tom Tromey  <tom@tromey.com>
1103
1104         PR rust/24976:
1105         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1106
1107 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1110         cp_search_name_hash.
1111         * NEWS: Add entry about nested function support.
1112
1113 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1114             Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1117         for nested static variables when searchin VAR_DOMAIN.
1118         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1119         global scope, update comment.
1120         (add_partial_subprogram): Call add_partial_subprogram recursively
1121         for nested subroutines when processinng Fortran.
1122         (load_partial_dies): Process the child entities of a subprogram
1123         when processing Fortran.
1124         (partial_die_parent_scope): Handle building scope
1125         for Fortran nested functions.
1126         (process_die): Record that nested functions have a scope.
1127         (new_symbol): Always record Fortran subprograms on the global
1128         symbol list.
1129         (determine_prefix): How to build the prefix for Fortran
1130         subprograms.
1131
1132 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1133
1134         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1135         have just sent the thread a SIGSTOP and are waiting for it to
1136         arrive.
1137
1138 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * btrace.c (btrace_add_pc): Remove whitespace before the template
1141         parameter in 'std::vector <...>'.
1142         (parse_xml_btrace_block): Likewise.
1143         (btrace_maint_decode_pt): Likewise.
1144         (btrace_maint_update_packets): Likewise.
1145         (btrace_maint_print_packets): Likewise.
1146         * btrace.h (struct btrace_maint_info): Likewise.
1147         * dwarf2read.c (struct type_unit_group): Likewise.
1148         (build_type_psymtabs_reader): Likewise.
1149         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1150         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1151         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1152
1153 2019-10-03  Tom de Vries  <tdevries@suse.de>
1154
1155         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1156         the first line of the help text for set/show style metadata.
1157
1158 2019-10-02  Tom Tromey  <tromey@adacore.com>
1159
1160         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1161         * gdbsupport/common-inferior.c: New file.
1162         * infcmd.c (startup_with_shell): Don't define.
1163         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1164         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1165         * inferior.h (startup_with_shell): Don't declare.
1166
1167 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1168
1169         * gdbsupport/gdb_assert.h: Include errors.h.
1170         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1171
1172 2019-10-02  Tom Tromey  <tromey@adacore.com>
1173
1174         * NEWS: Add $_ada_exception entry.
1175         * ada-lang.c (struct ada_catchpoint): Add constructor.
1176         <m_kind>: New member.
1177         (allocate_location_exception, re_set_exception): Remove
1178         "ex" parameter.
1179         (should_stop_exception): Compute $_ada_exception.
1180         (check_status_exception, print_it_exception)
1181         (print_one_exception, print_mention_exception): Remove
1182         "ex" parameter.
1183         (allocate_location_catch_exception, re_set_catch_exception)
1184         (check_status_exception, print_it_catch_exception)
1185         (print_one_catch_exception, print_mention_catch_exception)
1186         (print_recreate_catch_exception)
1187         (allocate_location_catch_exception_unhandled)
1188         (re_set_catch_exception_unhandled)
1189         (check_status_exception, print_it_catch_exception_unhandled)
1190         (print_one_catch_exception_unhandled)
1191         (print_mention_catch_exception_unhandled)
1192         (print_recreate_catch_exception_unhandled)
1193         (allocate_location_catch_assert, re_set_catch_assert)
1194         (check_status_assert, print_it_catch_assert)
1195         (print_one_catch_assert, print_mention_catch_assert)
1196         (print_recreate_catch_assert)
1197         (allocate_location_catch_handlers, re_set_catch_handlers)
1198         (check_status_handlers, print_it_catch_handlers)
1199         (print_one_catch_handlers, print_mention_catch_handlers)
1200         (print_recreate_catch_handlers): Remove.
1201         (create_ada_exception_catchpoint): Update.
1202         (initialize_ada_catchpoint_ops): Update.
1203
1204 2019-10-02  Tom Tromey  <tromey@adacore.com>
1205
1206         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1207         (create_excep_cond_exprs): Simplify exception string computation.
1208         (ada_exception_catchpoint_cond_string): Likewise.
1209
1210 2019-10-02  Tom Tromey  <tromey@adacore.com>
1211
1212         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1213         * ada-lang.c (lesseq_defined_than): Handle
1214         LOC_STATIC.
1215         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1216         parameter.
1217         (dwarf2_has_info): Likewise.
1218         (new_symbol): Set maybe_copied on symbol when
1219         appropriate.
1220         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1221         parameter.
1222         <can_copy>: New member.
1223         * elfread.c (record_minimal_symbol): Set maybe_copied
1224         on symbol when appropriate.
1225         (elf_symfile_read): Update call to dwarf2_has_info.
1226         * minsyms.c (lookup_minimal_symbol_linkage): New
1227         function.
1228         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1229         * symtab.c (get_symbol_address, get_msymbol_address):
1230         New functions.
1231         * symtab.h (get_symbol_address, get_msymbol_address):
1232         Declare.
1233         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1234         maybe_copied.
1235         (struct symbol, struct minimal_symbol) <maybe_copied>:
1236         New member.
1237
1238 2019-10-02  Tom Tromey  <tromey@adacore.com>
1239
1240         * source.c (struct current_source_location): New.
1241         (current_source_key): New global.
1242         (current_source_symtab, current_source_line)
1243         (current_source_pspace): Remove.
1244         (get_source_location): New function.
1245         (get_current_source_symtab_and_line)
1246         (set_default_source_symtab_and_line)
1247         (set_current_source_symtab_and_line)
1248         (clear_current_source_symtab_and_line, select_source_symtab)
1249         (info_source_command, print_source_lines_base)
1250         (info_line_command, search_command_helper, _initialize_source):
1251         Update.
1252
1253 2019-10-02  Tom Tromey  <tromey@adacore.com>
1254
1255         * source.c (select_source_symtab): Don't call
1256         decode_line_with_current_source.
1257
1258 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * symtab.c (lookup_global_symbol): Search global block.
1261
1262 2019-10-02  Tom Tromey  <tromey@adacore.com>
1263
1264         * coffread.c (process_coff_symbol): Update.
1265         * dwarf2read.c (var_decode_location, new_symbol): Update.
1266         * mdebugread.c (parse_symbol): Update.
1267         * objfiles.c (relocate_one_symbol): Update.
1268         * stabsread.c (define_symbol, fix_common_block)
1269         (scan_file_globals): Update.
1270         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1271         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1272         * xcoffread.c (process_xcoff_symbol): Update.
1273
1274 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1275
1276         * MAINTAINERS: Update my email address.
1277
1278 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1281         std::vector.
1282         (build_type_psymtabs_reader): Update for std::vector.
1283         (build_type_psymtab_dependencies): Likewise.
1284         * dwarf2read.h: Remove use of DEF_VEC_P.
1285         (typedef sig_type_ptr): Delete.
1286
1287 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1290         to std::vector.
1291         (btrace_maint_decode_pt): Likewise, and move allocation of the
1292         vector outside of the loop.
1293         (btrace_maint_update_packets): Update to handle change from VEC to
1294         std::vector.
1295         (btrace_maint_print_packets): Likewise.
1296         (maint_info_btrace_cmd): Likewise.
1297         * btrace.h: Remove use of DEF_VEC_O.
1298         (typedef btrace_pt_packet_s): Delete.
1299         (struct btrace_maint_info) <packets>: Change fromm VEC to
1300         std::vector.
1301         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1302
1303 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1306         make accesses into the vector constant references.
1307         (btrace_add_pc): Update for std::vector.
1308         (btrace_stitch_bts): Likewise.
1309         (parse_xml_btrace_block): Likewise.
1310         (btrace_maint_update_packets): Likewise.
1311         (btrace_maint_print_packets): Likewise.
1312         (maint_info_btrace_cmd): Likewise.
1313         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1314         std::vector.
1315         (btrace_data::empty): Likewise.
1316         (btrace_data_append): Likewise.
1317         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1318         (typedef btrace_block_s): Delete.
1319         (struct btrace_block): Add constructor.
1320         (struct btrace_data_bts) <blocks>: Change to std::vector.
1321         * nat/linux-btrace.c (perf_event_read_bts): Update for
1322         std::vector.
1323         (linux_read_bts): Likewise.
1324
1325 2019-10-01  Tom Tromey  <tom@tromey.com>
1326
1327         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1328
1329 2019-10-01  Tom Tromey  <tom@tromey.com>
1330
1331         * stack.c (print_frame, info_frame_command_core): Use
1332         styled_string.
1333         * linux-thread-db.c (try_thread_db_load_1)
1334         (try_thread_db_load_from_pdir_1): Use styled_string.
1335         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1336         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1337         (maybe_print_unsupported_script_warning)
1338         (maybe_print_script_not_found_warning): Use styled_string.
1339         * ada-lang.c (user_select_syms): Use styled_string.
1340
1341 2019-10-01  Tom Tromey  <tom@tromey.com>
1342
1343         * p-lang.c (pascal_printstr): Use metadata style.
1344         * value.c (show_convenience): Use metadata style.
1345         * valprint.c (valprint_check_validity, val_print_optimized_out)
1346         (val_print_not_saved, val_print_unavailable)
1347         (val_print_invalid_address, generic_val_print, val_print)
1348         (value_check_printable, val_print_array_elements): Use metadata
1349         style.
1350         * ui-out.h (class ui_out) <field_fmt>: New overload.
1351         <do_field_fmt>: Add style parameter.
1352         * ui-out.c (ui_out::field_fmt): New overload.
1353         * typeprint.c (type_print_unknown_return_type)
1354         (val_print_not_allocated, val_print_not_associated): Use metadata
1355         style.
1356         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1357         parameter.
1358         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1359         * tracepoint.c (tvariables_info_1): Use metadata style.
1360         * stack.c (print_frame_arg, print_frame_info, print_frame)
1361         (info_frame_command_core): Use metadata style.
1362         * skip.c (info_skip_command): Use metadata style.
1363         * rust-lang.c (rust_print_enum): Use metadata style.
1364         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1365         metadata style.
1366         * python/py-framefilter.c (py_print_single_arg): Use metadata
1367         style.
1368         * printcmd.c (do_one_display, print_variable_and_value): Use
1369         metadata style.
1370         * p-valprint.c (pascal_val_print)
1371         (pascal_object_print_value_fields): Use metadata style.
1372         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1373         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1374         parameter.
1375         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1376         * m2-valprint.c (m2_print_long_set): Use metadata style.
1377         * m2-typeprint.c (m2_print_type): Use metadata style.
1378         * infcmd.c (print_return_value_1): Use metadata style.
1379         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1380         * f-valprint.c (info_common_command_for_block): Use metadata
1381         style.
1382         * f-typeprint.c (f_type_print_base): Use metadata style.
1383         * expprint.c (print_subexp_standard): Use metadata style.
1384         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1385         * cli/cli-style.h (class cli_style_option): Add constructor.
1386         (metadata_style): Declare.
1387         * cli/cli-style.c (metadata_style): New global.
1388         (_initialize_cli_style): Register metadata style.
1389         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1390         parameter.
1391         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1392         * c-typeprint.c (c_type_print_base_struct_union)
1393         (c_type_print_base_1): Use metadata style.
1394         * breakpoint.c (watchpoint_value_print)
1395         (print_one_breakpoint_location): Use metadata style.
1396         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1397         style.
1398         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1399         style.
1400         * ada-valprint.c (val_print_packed_array_elements, printstr)
1401         (print_field_values, ada_val_print_ref, ada_val_print): Use
1402         metadata style.
1403         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1404         style.
1405         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1406         style.
1407         * ada-lang.c (user_select_syms): Use metadata style.
1408
1409 2019-10-01  Tom Tromey  <tom@tromey.com>
1410
1411         * cli/cli-cmds.c (pwd_command): Style output.
1412
1413 2019-10-01  Pedro Alves  <palves@redhat.com>
1414             Tom Tromey  <tom@tromey.com>
1415
1416         * symtab.c (print_symbol_info): Use %ps.
1417         (print_msymbol_info): Use %ps.
1418         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1419         * printcmd.c (print_variable_and_value): Use %ps.
1420         * macrocmd.c (show_pp_source_pos): Use %ps.
1421         * infrun.c (print_exited_reason): Use ui_out::message.
1422         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1423         (describe_other_breakpoints): Use ui_out::message and new
1424         formats.
1425         (say_where): Use new formats.
1426         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1427         and new formats.
1428
1429 2019-10-01  Pedro Alves  <palves@redhat.com>
1430             Tom Tromey  <tom@tromey.com>
1431
1432         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1433         (test_gdb_formats): New function.
1434         (run_tests): Call it.
1435         (test_format_specifier): Update.
1436         * utils.h (fputs_filtered): Update comment.
1437         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1438         (fputs_styled_unfiltered): Declare.
1439         * utils.c (fputs_styled_unfiltered): New function.
1440         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1441         (vfprintf_filtered): Update.
1442         (vfprintf_unfiltered, vprintf_filtered): Update.
1443         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1444         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1445         disallow_ui_out_field>: New constants.
1446         (enum class field_kind): New.
1447         (struct base_field_s, struct signed_field_s): New.
1448         (signed_field): New function.
1449         (struct string_field_s): New.
1450         (string_field): New function.
1451         (struct styled_string_s): New.
1452         (styled_string): New function.
1453         (class ui_out) <message>: Add comment.
1454         <vmessage, call_do_message>: New methods.
1455         <do_message>: Add style parameter.
1456         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1457         methods.
1458         (ui_out::message): Rewrite.
1459         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1460         parameter.
1461         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1462         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1463         gdb_extensions parameter.
1464         (class format_piece): Add parameter to constructor.
1465         (n_int_args): New field.
1466         * gdbsupport/format.c (format_pieces::format_pieces): Add
1467         gdb_extensions parameter.  Handle '*'.
1468         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1469         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1470         vfprintf_styled_no_gdbfmt.
1471         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1472         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1473         unfiltered output.
1474         * ui-style.h (struct ui_file_style) <ptr>: New method.
1475
1476 2019-10-01  Tom Tromey  <tom@tromey.com>
1477
1478         * unittests/format_pieces-selftests.c: Update.  Add final format.
1479         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1480         empty literal pieces.
1481
1482 2019-10-01  Tom Tromey  <tom@tromey.com>
1483
1484         * ui-out.h (enum class ui_out_style_kind): Remove.
1485         (class ui_out) <field_string, field_stsream, do_field_string>:
1486         Change type of "style".
1487         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1488         (ui_out::field_string): Update.
1489         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1490         of "style".
1491         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1492         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1493         * stack.c (print_frame_arg, print_frame_info, print_frame):
1494         Update.
1495         * source.c (print_source_lines_base): Update.
1496         * solib.c (info_sharedlibrary_command): Update.
1497         * skip.c (info_skip_command): Update.
1498         * record-btrace.c (btrace_call_history_src_line)
1499         (btrace_call_history): Update.
1500         * python/py-framefilter.c (py_print_frame): Update.
1501         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1502         "style".
1503         * mi/mi-out.c (mi_ui_out::do_table_header)
1504         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1505         (mi_ui_out::do_field_string): Update.
1506         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1507         Update.
1508         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1509         "style".
1510         * cli-out.c (cli_ui_out::do_table_header)
1511         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1512         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1513         (cli_ui_out::do_field_fmt): Update.
1514         * breakpoint.c (print_breakpoint_location): Update.
1515         (update_static_tracepoint): Update.
1516
1517 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1518
1519         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1520         conversion of gdb_datadir.
1521         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1522         remove not needed c_str ().
1523
1524 2019-09-30  Ali Tamur <tamur@google.com>
1525
1526         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1527         (dwarf2_string_attr): Likewise.
1528
1529 2019-09-30  Ali Tamur <tamur@google.com>
1530
1531         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1532         (process_full_type_unit): Likewise.
1533         (dump_die_shallow): Likewise.
1534         (cu_debug_loc_section): Likewise.
1535
1536 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1537
1538         * minsyms.c (compare_minimal_symbols): Rename to...
1539         (minimal_symbol_is_less_than): ...this, and adjust to STL
1540         conventions (return bool, take arguments as references)
1541         (minimal_symbol_reader::install): Call std::sort instead
1542         of qsort.
1543
1544 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1545
1546         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1547         hash and why.
1548         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1549         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1550
1551 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1552
1553         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1554         * psympriv.h (add_psymbol_to_list): Move comment here and update
1555         it.
1556
1557 2019-09-29  Tom de Vries  <tdevries@suse.de>
1558
1559         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1560         Use $tmpdir/$(basename "$output_file").dwz instead of
1561         "${output_file}.dwz".
1562
1563 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1564
1565         PR gdb/25045
1566         * hppa-linux-nat.c: Include gdbarch.h.
1567
1568 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1569
1570         * blockframe.c (find_pc_partial_function): Change return type to bool.
1571         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1572         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1573         (stub_gnu_ifunc_resolve_name): Likewise.
1574         * symtab.c (compare_filenames_for_search): Likewise.
1575         (compare_glob_filenames_for_search): Likewise.
1576         (matching_obj_sections): Likewise.
1577         (symbol_matches_domain): Likewise.
1578         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1579         (find_line_pc): Change return type to bool.
1580         (find_line_pc_range): Likewise.
1581         (producer_is_realview): Likewise.
1582         * symtab.h (symbol_matches_domain): Likewise.
1583         (find_pc_partial_function): Likewise.
1584         (find_pc_line_pc_range): Likewise.
1585         (in_gnu_ifunc_stub): Likewise.
1586         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1587         (find_line_pc): Likewise.
1588         (find_line_pc_range): Likewise.
1589         (matching_obj_sections): Likewise.
1590         (find_line_symtab): Change out parameter to bool.
1591         (producer_is_realview): Change return type to bool.
1592         (compare_filenames_for_search): Likewise.
1593         (compare_glob_filenames_for_search): Likewise.
1594
1595 2019-09-26  Tom Tromey  <tom@tromey.com>
1596
1597         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1598         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1599         * gdb_usleep.h: Remove.
1600         * gdb_usleep.c: Remove.
1601         * utils.c: Don't include gdb_usleep.h.
1602
1603 2019-09-26  Tom Tromey  <tromey@adacore.com>
1604
1605         * python/py-type.c (type_to_type_object): Call check_typedef
1606         for stub types.
1607
1608 2019-09-26  Tom Tromey  <tom@tromey.com>
1609
1610         * utils.h (initialize_utils): Don't declare.
1611         * top.c (gdb_init): Don't call initialize_utils.
1612         * utils.c (initialize_utils): Remove.  Move contents...
1613         (_initialize_utils): ... here.
1614
1615 2019-09-25  Tom Tromey  <tom@tromey.com>
1616
1617         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1618         * utils.h (make_hex_string): Don't declare.
1619         * utils.c (make_hex_string): Remove.
1620
1621 2019-09-24  Tom de Vries  <tdevries@suse.de>
1622
1623         PR gdb/23815
1624         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1625         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1626
1627 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1628
1629         * NEWS: Mention new simulator port for PRU.
1630
1631 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1632
1633         * ada-exp.y (write_object_remaining): Update.
1634         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1635         and eliminate the static buffer.
1636         (ada_decode_symbol): Update.
1637         (ada_la_decode): Update.
1638         (ada_sniff_from_mangled_name): Update.
1639         (is_valid_name_for_wild_match): Update.
1640         (ada_lookup_name_info::matches): Update and simplify.
1641         (name_matches_regex): Update.
1642         (ada_add_global_exceptions): Update.
1643         * ada-lang.h (ada_decode): Update signature.
1644         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1645         * dwarf-index-write.c (debug_names::insert): Update.
1646
1647 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1648
1649         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1650         formatting.
1651
1652 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1653
1654         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1655         Change "nonzero" to "true" in documentation.
1656
1657 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1658
1659         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1660         (_initialize_darwin_solib): Don't set
1661         darwin_so_ops.lookup_lib_global_symbol.
1662         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1663         set_gdbarch_iterate_over_objfiles_in_search_order.
1664         (elf_lookup_lib_symbol): Rename to...
1665         (svr4_iterate_over_objfiles_in_search_order): this, and update
1666         to iterate semantics.
1667         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1668         * solib.c (solib_global_lookup): Remove.
1669         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1670         (solib_global_lookup): Remove.
1671         * symtab.c (lookup_global_or_static_symbol): Remove call to
1672         solib_global_lookup.
1673
1674 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1675
1676         * NEWS: Move entries about default MI version now being
1677         version 3, and about the GDB/MI fix for multi-location
1678         breakpoints to the "since GDB 8.3" section.
1679
1680 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1681
1682         GDB 8.3.1 released.
1683
1684 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1685
1686         * NEWS: Mention that Cell/B.E. debugging support was removed.
1687         * MAINTAINERS: Remove spu target.
1688
1689         * config/djgpp/fnchange.lst: Remove entries for removed files.
1690
1691         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1692         spu-multiarch.o, and spu-tdep.o.
1693         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1694         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1695         spu-multiarch.c, and spu-tdep.c.
1696         * spu-linux-nat.c: Remove file.
1697         * spu-multiarch.c: Remove file.
1698         * spu-tdep.c: Remove file.
1699         * spu-tdep.h: Remove file.
1700         * solib-spu.c: Remove file.
1701         * solib-spu.h: Remove file.
1702
1703         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1704         * configure.nat (spu-linux): Remove.
1705         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1706         solib-multiarch.o from gdb_target_obs.
1707         (spu*-*-*): Remove.
1708
1709         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1710         feature flag.
1711         (ppc_linux_no_features): Update.
1712         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1713         Cell/B.E. support.
1714         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1715         (tdesc_powerpc_cell64l): Likewise.
1716         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1717         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1718         Cell/B.E. support.
1719         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1720         Do not include "features/rs6000/powerpc-cell32l.c" or
1721         "features/rs6000/powerpc-cell64l.c".
1722         (ppc_linux_spu_section): Remove.
1723         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1724         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1725         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1726         (ppc_linux_spe_context_lookup): Remove.
1727         (ppc_linux_spe_context_inferior_created): Remove.
1728         (ppc_linux_spe_context_solib_loaded): Remove.
1729         (ppc_linux_spe_context_solib_unloaded): Remove.
1730         (ppc_linux_spe_context): Remove.
1731         (struct ppu2spu_cache): Remove.
1732         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1733         (struct ppu2spu_data): Remove.
1734         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1735         ppu2spu_unwind): Remove.
1736         (ppc_linux_init_abi): Remove Cell/B.E. support.
1737         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1738
1739         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1740         (rs6000/powerpc-cell64l-expedite): Likewise
1741         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1742         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1743         rs6000/powerpc-cell64l.xml.
1744         * features/rs6000/powerpc-cell32l.xml: Remove.
1745         * features/rs6000/powerpc-cell64l.xml: Likewise.
1746         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1747         * features/rs6000/powerpc-cell64l.c: Likewise.
1748         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1749         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1750         * regformats/reg-spu.dat: Remove.
1751
1752         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1753         * corelow.c (struct spuid_list): Remove.
1754         (add_to_spuid_list): Remove.
1755         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1756         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1757         (remote_protocol_features): Remove associated entries.
1758         (_initialize_remote): No longer initialize them.
1759         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1760         * linux-nat.c (SPUFS_MAGIC): Remove.
1761         (linux_proc_xfer_spu): Remove.
1762         (spu_enumerate_spu_ids): Remove.
1763         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1764         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1765         (linux_make_corefile_notes): No longer call it.
1766
1767         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1768         (cooked_write_test): Likewise.
1769
1770 2019-09-20  Tom Tromey  <tom@tromey.com>
1771
1772         * NEWS: Mention case-sensitivity of TUI commands.
1773         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1774         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1775         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1776
1777 2019-09-20  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-source.c (tui_source_window::set_contents): Use
1780         make_unique_xstrdup.
1781         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1782         make_unique_xstrdup.
1783
1784 2019-09-20  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-data.c: Remove separator comments.
1787         * tui/tui-layout.c: Remove separator comments.
1788         * tui/tui-win.c: Remove separator comments.
1789         * tui/tui-wingeneral.c: Remove separator comments.
1790
1791 2019-09-20  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui.h (strcat_to_buf): Don't declare.
1794         * tui/tui.c (strcat_to_buf): Remove.
1795
1796 2019-09-20  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1799         from "fullname".
1800         * tui/tui-source.c (tui_source_window::set_contents)
1801         (tui_source_window::location_matches_p)
1802         (tui_source_window::maybe_update): Update.
1803
1804 2019-09-20  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1807         Update.
1808         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1809         prefix.
1810         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1811         (tui_data_window::line_from_reg_element_no)
1812         (tui_data_window::first_reg_element_no_inline)
1813         (tui_data_window::show_registers)
1814         (tui_data_window::show_register_group)
1815         (tui_data_window::display_registers_from)
1816         (tui_data_window::display_registers_from_line)
1817         (tui_data_window::first_data_item_displayed)
1818         (tui_data_window::delete_data_content_windows)
1819         (tui_data_window::erase_data_content)
1820         (tui_data_window::do_scroll_vertical)
1821         (tui_data_window::refresh_window)
1822         (tui_data_window::check_register_values): Update.
1823
1824 2019-09-20  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1827         (struct tui_locator_window) <full_name, proc_name>: Now
1828         std::string.
1829         * tui/tui-stack.c (tui_locator_window::make_status_line)
1830         (tui_locator_window::set_locator_fullname)
1831         (tui_locator_window::set_locator_info): Update.
1832         * tui/tui-source.c (tui_source_window::set_contents)
1833         (tui_source_window::showing_source_p): Update.
1834
1835 2019-09-20  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1838         Don't call tui_locator_win_info_ptr.
1839
1840 2019-09-20  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1843
1844 2019-09-20  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1847         height for locator.
1848         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1849         * tui/tui-layout.c (show_source_disasm_command, show_data)
1850         (show_source_or_disasm_and_command): Use 1 as height for locator.
1851
1852 2019-09-20  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui.c (tui_enable): Update.
1855         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1856         Update.
1857         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1858         Update.
1859         * tui/tui-data.c (win_resized): Now bool.
1860         (tui_win_resized): Return bool.
1861         (tui_set_win_resized_to): Accept a bool.
1862
1863 2019-09-20  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1866         Change type of "refresh_values_only".
1867         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1868         type of "refresh_values_only".
1869
1870 2019-09-20  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1873         std::string.
1874         (tui_disassemble): Add "pos" parameter.
1875         (tui_disasm_window::set_contents): Simplify.
1876
1877 2019-09-20  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-winsource.h (struct tui_source_window_base)
1880         <show_source_content>: Now private.
1881         * tui/tui-winsource.c
1882         (tui_source_window_base::show_source_content): Don't handle empty
1883         content case.
1884
1885 2019-09-20  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-layout.c (show_source_disasm_command)
1888         (show_source_or_disasm_and_command): Don't call
1889         show_source_content.
1890
1891 2019-09-20  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1894         Declare.
1895         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1896         from tui_make_status_line.
1897         (tui_locator_window::rerender): Update.
1898
1899 2019-09-20  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1902         (tui_locator_window::rerender): Update.
1903
1904 2019-09-20  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-winsource.h (struct tui_source_window_base)
1907         <~tui_source_window_base>: Don't declare.
1908         <fullname>: Remove.
1909         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1910         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1911         member.
1912         * tui/tui-source.c (tui_source_window::set_contents): Update.
1913         (tui_source_window::location_matches_p)
1914         (tui_source_window::maybe_update): Update.
1915
1916 2019-09-20  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-winsource.h (~tui_source_element): Remove.
1919         (tui_source_element): Update.
1920         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1921         * tui/tui-winsource.c (tui_show_source_line): Update.
1922         * tui/tui-source.c (tui_source_window::set_contents): Update.
1923         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1924
1925 2019-09-20  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1928         declare.
1929         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1930         tui_clear_source_windows_detail.
1931         * tui/tui-winsource.h (struct tui_source_window_base)
1932         <clear_detail>: Don't declare.
1933         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1934         Remove.
1935         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1936
1937 2019-09-20  Tom Tromey  <tromey@adacore.com>
1938
1939         PR ada/24919:
1940         * block.c (contained_in): Fix final return value.
1941
1942 2019-09-20  Alan Modra  <amodra@gmail.com>
1943
1944         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1945         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1946         (read_indirect_string_from_dwz): Use bfd accessor.
1947         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1948         * machoread.c (macho_symfile_read_all_oso): Likewise.
1949         * solib.c (solib_bfd_open): Likewise.
1950
1951 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1952
1953         * eval.c: Move declaration of overload_resolution to...
1954         * value.h: ...here.
1955
1956 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1957
1958         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1959         * arm-linux-tdep.c: Likewise.
1960         * arm-nbsd-nat.c: Likewise.
1961         * arm-tdep.h: Declare arm_apcs_32.
1962         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1963
1964 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1965
1966         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1967         * dwarf2read.h: Declare dwarf_always_disassemble.
1968
1969 2019-09-19  Tom de Vries  <tdevries@suse.de>
1970
1971         PR gdb/25009
1972         * source-cache.c (source_cache::ensure): Catch exception thrown during
1973         construction of the highlighter.
1974
1975 2019-09-18  Alan Modra  <amodra@gmail.com>
1976
1977         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1978         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1979         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1980         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1981         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1982         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1983         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1984         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1985         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1986         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1987         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1988         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1989         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1990         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1991         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1992         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1993         * mi/mi-interp.c: Update throughout for bfd section macro and
1994         function changes.
1995         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1996         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1997
1998 2019-09-18  Tom Tromey  <tom@tromey.com>
1999
2000         * NEWS: Add entry.
2001         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2002         call rl_initialize.
2003         (tui_enable): Do not call rl_initialize.
2004
2005 2019-09-18  Christian Groessler  <chris@groessler.org>
2006
2007         * alpha-linux-nat.c: Include gdbarch.h.
2008
2009 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2010
2011         * ui-file.c: Include cli/cli-style.h.
2012         (term_cli_styling): Remove cli_styling declaration.
2013
2014 2019-09-18  Alan Modra  <amodra@gmail.com>
2015
2016         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2017         to bfd_asymbol_section.
2018
2019 2019-09-18  Alan Modra  <amodra@gmail.com>
2020
2021         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2022         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2023         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2024
2025 2019-09-18  Alan Modra  <amodra@gmail.com>
2026
2027         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2028         * spu-linux-nat.c (spu_bfd_open): Likewise.
2029
2030 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2031
2032         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2033         to bool to match definition in dwarf2read.c.
2034
2035 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2036
2037         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2038         (print_signatures): Likewise.
2039         (trust_pad_over_xvs): Likewise.
2040         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2041         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2042         * arm-linux-nat.c (arm_apcs_32): Likewise.
2043         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2044         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2045         * arm-tdep.c (arm_debug): Likewise.
2046         (arm_apcs_32): Likewise.
2047         * auto-load.c (debug_auto_load): Likewise.
2048         (auto_load_gdb_scripts): Likewise.
2049         (global_auto_load): Likewise.
2050         (auto_load_local_gdbinit): Likewise.
2051         (auto_load_local_gdbinit_loaded): Likewise.
2052         * auto-load.h (global_auto_load): Likewise.
2053         (auto_load_local_gdbinit): Likewise.
2054         (auto_load_local_gdbinit_loaded): Likewise.
2055         * breakpoint.c (disconnected_dprintf): Likewise.
2056         (breakpoint_proceeded): Likewise.
2057         (automatic_hardware_breakpoints): Likewise.
2058         (always_inserted_mode): Likewise.
2059         (target_exact_watchpoints): Likewise.
2060         (_initialize_breakpoint): Update.
2061         * breakpoint.h (target_exact_watchpoints): Change to bool.
2062         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2063         * cli/cli-cmds.c (trace_commands): Likewise.
2064         * cli/cli-cmds.h (trace_commands): Likewise.
2065         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2066         to bool*.
2067         * cli/cli-logging.c (logging_overwrite): Change to bool.
2068         (logging_redirect): Likewise.
2069         (debug_redirect): Likewise.
2070         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2071         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2072         to bool.
2073         <boolean_option_def>: Update.
2074         (struct flag_option_def): Change default type of Context to bool
2075         from int.
2076         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2077         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2078         (get_setshow_command_value_string): Likewise.
2079         * cli/cli-style.c (cli_styling): Change to bool.
2080         (source_styling): Likewise.
2081         * cli/cli-style.h (source_styling): Likewise.
2082         (cli_styling): Likewise.
2083         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2084         to bool.
2085         * command.h (var_types): Update comment.
2086         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2087         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2088         bool.
2089         (debug_compile_cplus_scopes): Likewise.
2090         * compile/compile-internal.h (compile_debug): Likewise.
2091         * compile/compile.c (compile_debug): Likewise.
2092         (struct compile_options) <raw>: Likewise.
2093         * cp-support.c (catch_demangler_crashes): Likewise.
2094         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2095         (usr_cmd_cris_dwarf2_cfi): Likewise.
2096         * csky-tdep.c (csky_debug): Likewise.
2097         * darwin-nat.c (enable_mach_exceptions): Likewise.
2098         * dcache.c (dcache_enabled_p): Likewise.
2099         * defs.h (info_verbose): Likewise.
2100         * demangle.c (demangle): Likewise.
2101         (asm_demangle): Likewise.
2102         * dwarf-index-cache.c (debug_index_cache): Likewise.
2103         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2104         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2105         * dwarf2read.c (check_physname): Likewise.
2106         (use_deprecated_index_sections): Likewise.
2107         (dwarf_always_disassemble): Likewise.
2108         * eval.c (overload_resolution): Likewise.
2109         * event-top.c (set_editing_cmd_var): Likewise.
2110         (exec_done_display_p): Likewise.
2111         * event-top.h (set_editing_cmd_var): Likewise.
2112         (exec_done_display_p): Likewise.
2113         * exec.c (write_files): Likewise.
2114         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2115         (debug_fbsd_nat): Likewise.
2116         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2117         Likewise.
2118         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2119         <backtrace_past_entry> Likewise.
2120         * gdb-demangle.h (demangle): Likewise.
2121         (asm_demangle): Likewise.
2122         * gdb_bfd.c (bfd_sharing): Likewise.
2123         * gdbcore.h (write_files): Likewise.
2124         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2125         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2126         * gdbthread.h (print_thread_events): Likewise.
2127         * gdbtypes.c (opaque_type_resolution): Likewise.
2128         (strict_type_checking): Likewise.
2129         * gnu-nat.c (gnu_debug_flag): Likewise.
2130         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2131         * guile/scm-param.c (pascm_variable): Add boolval.
2132         (add_setshow_generic): Update.
2133         (pascm_param_value): Update.
2134         (pascm_set_param_value_x): Update.
2135         * hppa-tdep.c (hppa_debug): Change to bool..
2136         * infcall.c (may_call_functions_p): Likewise.
2137         (coerce_float_to_double_p): Likewise.
2138         (unwind_on_signal_p): Likewise.
2139         (unwind_on_terminating_exception_p): Likewise.
2140         * infcmd.c (startup_with_shell): Likewise.
2141         * inferior.c (print_inferior_events): Likewise.
2142         * inferior.h (startup_with_shell): Likewise.
2143         (print_inferior_events): Likewise.
2144         * infrun.c (step_stop_if_no_debug): Likewise.
2145         (detach_fork): Likewise.
2146         (debug_displaced): Likewise.
2147         (disable_randomization): Likewise.
2148         (non_stop): Likewise.
2149         (non_stop_1): Likewise.
2150         (observer_mode): Likewise.
2151         (observer_mode_1): Likewise.
2152         (set_observer_mode): Update.
2153         (sched_multi): Change to bool.
2154         * infrun.h (debug_displaced): Likewise.
2155         (sched_multi): Likewise.
2156         (step_stop_if_no_debug): Likewise.
2157         (non_stop): Likewise.
2158         (disable_randomization): Likewise.
2159         * linux-tdep.c (use_coredump_filter): Likewise.
2160         (dump_excluded_mappings): Likewise.
2161         * linux-thread-db.c (auto_load_thread_db): Likewise.
2162         (check_thread_db_on_load): Likewise.
2163         * main.c (captured_main_1): Update.
2164         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2165         xx2_opt, boolean_opt>: Change to bool.
2166         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2167         * maint.c (maintenance_profile_p): Likewise.
2168         (per_command_time): Likewise.
2169         (per_command_space): Likewise.
2170         (per_command_symtab): Likewise.
2171         * memattr.c (inaccessible_by_default): Likewise.
2172         * mi/mi-main.c (mi_async): Likewise.
2173         (mi_async_1): Likewise.
2174         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2175         * nat/fork-inferior.h (startup_with_shell): Likewise.
2176         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2177         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2178         * nios2-tdep.c (nios2_debug): Likewise.
2179         * or1k-tdep.c (or1k_debug): Likewise.
2180         * parse.c (parser_debug): Likewise.
2181         * parser-defs.h (parser_debug): Likewise.
2182         * printcmd.c (print_symbol_filename): Likewise.
2183         * proc-api.c (procfs_trace): Likewise.
2184         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2185         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2186         (set_parameter_value): Update.
2187         (add_setshow_generic): Update.
2188         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2189         to bool*.
2190         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2191         int*.
2192         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2193         * record-btrace.c (record_btrace_target::store_registers): Update.
2194         * record-full.c (record_full_memory_query): Change to bool.
2195         (record_full_stop_at_limit): Likewise.
2196         * record-full.h (record_full_memory_query): Likewise.
2197         * remote-notif.c (notif_debug): Likewise.
2198         * remote-notif.h (notif_debug): Likewise.
2199         * remote.c (use_range_stepping): Likewise.
2200         (interrupt_on_connect): Likewise.
2201         (remote_break): Likewise.
2202         * ser-tcp.c (tcp_auto_retry): Likewise.
2203         * ser-unix.c (serial_hwflow): Likewise.
2204         * skip.c (debug_skip): Likewise.
2205         * solib-aix.c (solib_aix_debug): Likewise.
2206         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2207         (spu_auto_flush_cache_p): Likewise.
2208         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2209         Likewise.
2210         (struct info_print_options) <quiet>: Likewise.
2211         * symfile-debug.c (debug_symfile): Likewise.
2212         * symfile.c (auto_solib_add): Likewise.
2213         (separate_debug_file_debug): Likewise.
2214         * symfile.h (auto_solib_add): Likewise.
2215         (separate_debug_file_debug): Likewise.
2216         * symtab.c (basenames_may_differ): Likewise.
2217         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2218         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2219         (struct info_types_options) <quiet>: Likewise.
2220         * symtab.h (demangle): Likewise.
2221         (basenames_may_differ): Likewise.
2222         * target-dcache.c (stack_cache_enabled_1): Likewise.
2223         (code_cache_enabled_1): Likewise.
2224         * target.c (trust_readonly): Likewise.
2225         (may_write_registers): Likewise.
2226         (may_write_memory): Likewise.
2227         (may_insert_breakpoints): Likewise.
2228         (may_insert_tracepoints): Likewise.
2229         (may_insert_fast_tracepoints): Likewise.
2230         (may_stop): Likewise.
2231         (auto_connect_native_target): Likewise.
2232         (target_stop_and_wait): Update.
2233         (target_async_permitted): Change to bool.
2234         (target_async_permitted_1): Likewise.
2235         (may_write_registers_1): Likewise.
2236         (may_write_memory_1): Likewise.
2237         (may_insert_breakpoints_1): Likewise.
2238         (may_insert_tracepoints_1): Likewise.
2239         (may_insert_fast_tracepoints_1): Likewise.
2240         (may_stop_1): Likewise.
2241         * target.h (target_async_permitted): Likewise.
2242         (may_write_registers): Likewise.
2243         (may_write_memory): Likewise.
2244         (may_insert_breakpoints): Likewise.
2245         (may_insert_tracepoints): Likewise.
2246         (may_insert_fast_tracepoints): Likewise.
2247         (may_stop): Likewise.
2248         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2249         (make_thread_apply_all_options_def_group): Change argument from int*
2250         to bool*.
2251         (thread_apply_all_command): Update.
2252         (print_thread_events): Change to bool.
2253         * top.c (confirm): Likewise.
2254         (command_editing_p): Likewise.
2255         (history_expansion_p): Likewise.
2256         (write_history_p): Likewise.
2257         (info_verbose): Likewise.
2258         * top.h (confirm): Likewise.
2259         (history_expansion_p): Likewise.
2260         * tracepoint.c (disconnected_tracing): Likewise.
2261         (circular_trace_buffer): Likewise.
2262         * typeprint.c (print_methods): Likewise.
2263         (print_typedefs): Likewise.
2264         * utils.c (debug_timestamp): Likewise.
2265         (sevenbit_strings): Likewise.
2266         (pagination_enabled): Likewise.
2267         * utils.h (sevenbit_strings): Likewise.
2268         (pagination_enabled): Likewise.
2269         * valops.c (overload_resolution): Likewise.
2270         * valprint.h (struct value_print_options) <prettyformat_arrays,
2271         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2272         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2273         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2274         Likewise.
2275         * windows-nat.c (new_console): Likewise.
2276         (cygwin_exceptions): Likewise.
2277         (new_group): Likewise.
2278         (debug_exec): Likewise.
2279         (debug_events): Likewise.
2280         (debug_memory): Likewise.
2281         (debug_exceptions): Likewise.
2282         (useshell): Likewise.
2283         * windows-tdep.c (maint_display_all_tib): Likewise.
2284         * xml-support.c (debug_xml): Likewise.
2285
2286 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2287
2288         * source.c (prepare_path_for_appending): New function.
2289         (openp): Make use of new function.
2290         (find_and_open_source): Search for the compilation directory and
2291         source file as a relative path beneath the directory search path.
2292
2293 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * source-cache.c (source_cache::get_line_charpos): Catch
2296         exceptions and return false, this matches the behaviour documented
2297         in the header file.
2298
2299 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2300
2301         * ada-tasks.c (info_task): Remove quoting of the task's name.
2302
2303 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2304
2305         * symfile.c (auto_solib_add): Replace comment with a reference
2306         to the header file.
2307
2308 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2309
2310         * NEWS: Mention that gdb can now be compiled with Python 3
2311         on Windows.
2312
2313 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * maint.c (maint_print_section_data::maint_print_section_data):
2316         Force use of 'float log10 (float)' by casting the argument to
2317         float.
2318
2319 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * maint.c: Add 'cmath' include.
2322         (struct maint_print_section_data): New structure.
2323         (print_section_index): New function.
2324         (print_bfd_section_info): Add header comment, small whitespace
2325         cleanup, and update to call new print_section_index function.
2326         (print_objfile_section_info): Likewise.
2327         (maint_obj_section_from_bfd_section): New function.
2328         (print_bfd_section_info_maybe_relocated): New function.
2329         (maintenance_info_sections): Add header comment, always use
2330         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2331
2332 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2335         inner scope, add check that the objfile has psymtabs before
2336         checking psymtabs_addrmap.
2337         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2338
2339 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2340
2341         * NEWS: Announce that Ada task names are now shown at more places,
2342         and between quotes (except in info task output).
2343         * gdb/ada-tasks.c (task_to_str): New function.
2344         (display_current_task_id): Call task_to_str.
2345         (task_command_1): Likewise.
2346         (print_ada_task_info): In non-mi mode, Properly align headers and data
2347         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2348
2349 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2350
2351         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2352         prstatus.pr_lwp.pr_info instead of making it up.
2353
2354 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2355
2356         * auto-load.c (auto_load_expand_dir_vars): Update.
2357         * defs.h (gdb_datadir): Change to std::string.
2358         (python_libdir): Likewise.
2359         (relocate_gdb_directory): Change return type to std::string.
2360         * guile/guile.c (gdbscm_data_directory): Update.
2361         (initialize_scheme_side): Update.
2362         * jit.c (jit_reader_dir): Change to std::string.
2363         (jit_reader_load_command): Update.
2364         * main.c (gdb_datadir): Change to std::string.
2365         (python_libdir): Likewise.
2366         (set_gdb_data_directory): Update.
2367         (relocate_path): Change to return std::string.
2368         (relocate_gdb_directory): Change to return std::string.
2369         (relocate_gdbinit_path_maybe_in_datadir): Update.
2370         (captured_main_1): Update.
2371         * python/python.c (do_start_initialization): Update.
2372         * top.c (show_gdb_datadir): Update.
2373         * xml-syscall.c (xml_init_syscalls_info): Update.
2374         (init_syscalls_info): Update.
2375
2376 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2377
2378         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2379         out of get_init_files.
2380         (get_init_files): Update.
2381
2382 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2383
2384         * main.c (get_init_files): Change to use std::string.
2385         (captured_main_1): Update.
2386         (print_gdb_help): Update.
2387
2388 2019-09-11  Ali Tamur  <tamur@google.com>
2389
2390         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2391         implementation.
2392
2393 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2394
2395         * dbxread.c (read_dbx_symtab): Update.
2396         * dwarf2read.c (load_partial_dies): Update.
2397         * mdebugread.c (parse_partial_symbols): Update.
2398         (handle_psymbol_enumerators): Update.
2399         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2400         * psymtab.c (add_psymbol_to_bcache): Likewise.
2401         (add_psymbol_to_list): Likewise.
2402         * symtab.c (symbol_set_names): Likewise.
2403         * symtab.h (symbol_set_names): Likewise.
2404         * xcoffread.c (scan_xcoff_symtab): Update.
2405
2406 2019-09-11  Tom Tromey  <tom@tromey.com>
2407
2408         * symfile-mem.c (symbol_file_add_from_memory): Use
2409         bfd_set_filename.
2410         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2411         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2412
2413 2019-09-10  Tom Tromey  <tromey@adacore.com>
2414
2415         * dwarf-index-write.c (write_psymbols): Extend error message.
2416         (debug_names::insert): Add Ada code.
2417         (debug_names::write_psymbols): Remove Ada check.
2418         (debug_names) <m_string_obstack>: New member.
2419         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2420         (gdb_index_symbol_name_matcher::matches): Remove.
2421         (mapped_index_base::find_name_components_bounds): Add "lang"
2422         parameter.
2423         (mapped_index_base::build_name_components): Also split names
2424         according to Ada syntax.
2425         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2426         type of "match_callback".
2427         (check_match, check_find_bounds_finds)
2428         (dw2_expand_symtabs_matching): Update.
2429         (dw2_debug_names_iterator): Add new constructor.
2430         (dw2_debug_names_map_matching_symbols): New function.
2431         (dw2_debug_names_expand_symtabs_matching): Update.
2432         (dwarf2_debug_names_functions): Use
2433         dw2_debug_names_map_matching_symbols.
2434
2435 2019-09-10  Tom Tromey  <tromey@adacore.com>
2436
2437         * dwarf2read.c (dw2_get_file_names_reader): Add the
2438         CU's file name to the results.
2439
2440 2019-09-10  Tom Tromey  <tromey@adacore.com>
2441
2442         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2443         map_matching_symbols.  Update.
2444         * dwarf2read.c (dw2_map_matching_symbols): Update.
2445         * psymtab.c (match_partial_symbol): Change type; update.
2446         (psym_map_matching_symbols): Likewise.
2447         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2448         type; update.
2449         * symfile.h (struct quick_symbol_functions)
2450         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2451         Remove "match".
2452
2453 2019-09-10  Tom Tromey  <tromey@adacore.com>
2454
2455         * psymtab.c (map_block): Remove.
2456         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2457         * symtab.c (iterate_over_symbols_terminated): New function.
2458         * symtab.c (iterate_over_symbols_terminated): Declare.
2459
2460 2019-09-10  Tom Tromey  <tromey@adacore.com>
2461
2462         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2463         * language.h (struct language_defn) <la_iterate_over_symbols>:
2464         Return bool.
2465         * symtab.c (iterate_over_symbols): Return bool.
2466         * symtab.h (iterate_over_symbols): Return bool.
2467
2468 2019-09-10  Tom Tromey  <tromey@adacore.com>
2469
2470         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2471         (add_nonlocal_symbols): Update.
2472         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2473         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2474         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2475         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2476         Change type of "callback".  Remove "data".
2477
2478
2479 2019-09-09  Ali Tamur  <tamur@google.com>
2480
2481         * dwarf2read.c (comp_unit_head): Update comment.
2482         (dwarf2_dwo_name): New function declaration.
2483         (dwarf_unit_type_name): New function declaration.
2484         (read_comp_unit_head): Add support for new compilation units,
2485         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2486         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2487         (currently named as "signature") in their header. Also clarify error
2488         messages.
2489         (lookup_dwo_id): New function. Returns the dwo id of the given
2490         compile unit.
2491         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2492         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2493         functions.
2494         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2495         (dwarf2_dwo_name): Get the dwo name if present.
2496         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2497         purposes.
2498
2499 2019-09-09  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2502
2503 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2504
2505         * python/python.c (do_start_initialization): Make progname_copy static,
2506         to avoid a leak report.
2507
2508 2019-09-08  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2511
2512 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2513
2514         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2515         Change type to gdb::optional<block_enum>.
2516         (dw2_symtab_iter_init): Change block_index parameter type
2517         to gdb::optional<block_enum>.
2518         (dw2_lookup_symbol): Change block_index parameter
2519         type to block_enum.c
2520         (dw2_debug_names_lookup_symbol): Likewise.
2521         * psymtab.c (psym_lookup_symbol): Likewise.
2522         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2523         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2524         Likewise.
2525
2526 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2527
2528         * defs.h (relocate_gdb_directory): Change int to bool in
2529         signature and rename flag to relocatable.
2530         * main.c (relocate_path): Likewise.
2531         (relocate_gdb_directory): Likewise.
2532
2533 2019-09-06  Alan Modra  <amodra@gmail.com>
2534
2535         * coffread.c (coff_symfile_read): Constify filename variable.
2536         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2537         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2538         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2539         * solib.c (reload_shared_libraries_1): Likewise.
2540         * symfile.c (reread_symbols): Likewise.
2541         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2542         * solib-darwin.c (darwin_bfd_open): Likewise.
2543         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2544
2545 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2548         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2549
2550 2019-09-03  Tom Tromey  <tromey@adacore.com>
2551
2552         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2553         types.
2554         (has_negatives): Unbias a range type bound.
2555         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2556         * gdbtypes.c (operator==): Handle new field.
2557         (create_range_type): Add "bias" parameter.
2558         (create_static_range_type, resolve_dynamic_range): Update.
2559         * gdbtypes.h (struct range_bounds) <bias>: New member.
2560         (create_range_type): Add bias parameter.
2561         * printcmd.c (print_scalar_formatted): Unbias range types.
2562         * value.c (unpack_long): Unbias range types.
2563         (pack_long): Bias range types.
2564
2565 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2566
2567         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2568         probe arguments.
2569
2570 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2571
2572         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2573         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2574         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2575         (compile_probe_arg): Likewise.
2576         * probe.h (get_argument_count): Likewise.
2577         * solib-svr4.c (solib_event_probe_action): Likewise.
2578         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2579
2580 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2581
2582         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2583         code to here...
2584         (svr4_create_solib_event_breakpoints): ...from here.
2585
2586 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2587
2588         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2589         suffix from warning message.
2590
2591 2019-08-30  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-winsource.h (struct tui_source_window_base)
2594         <refresh_all>: Don't declare.
2595         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2596         Remove.
2597         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2598         tui_show_locator_content.
2599         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2600         declare.
2601         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2602         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2603         declare.
2604
2605 2019-08-30  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2608
2609 2019-08-30  Tom Tromey  <tom@tromey.com>
2610
2611         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2612         Remove unnecessary forward declarations.
2613
2614 2019-08-30  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2617         rerender.
2618         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2619         tui_show_locator_content.
2620
2621 2019-08-30  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2624         (tui_locator_window::rerender): Rewrite using body of previous
2625         tui_show_locator_content.
2626
2627 2019-08-30  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2630         set_locator_fullname>: New methods.
2631         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2632         Rename from tui_set_locator_fullname.
2633         (tui_locator_window::set_locator_info): Rename from
2634         tui_set_locator_info.  Return bool.
2635         (tui_update_locator_fullname, tui_show_frame_info): Update.
2636
2637 2019-08-30  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2640
2641 2019-08-30  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2644         call touchwin.
2645
2646 2019-08-30  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-wingeneral.c (box_win): Assume win_info and
2649         win_info->handle cannot be NULL.
2650
2651 2019-08-30  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2654         refresh_window>: Declare.
2655         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2656         resize.
2657         (tui_data_item_window::rerender): Rename from
2658         tui_display_register.
2659         (tui_data_item_window::refresh_window): New method.
2660         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2661         no-op.
2662
2663 2019-08-30  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2666         regs_column_count, current_group>: Move later.  Now private.
2667         <get_current_group>: New method.
2668         * tui/tui-regs.c (tui_reg_command): Update.
2669         * tui/tui-layout.c (tui_set_layout): Update.
2670
2671 2019-08-30  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2674         (tui_data_window::rerender): Don't call
2675         check_and_display_highlight_if_needed.
2676         (tui_data_window::refresh_all): Remove call to
2677         erase_data_content.
2678
2679 2019-08-30  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2682         (tui_data_window::display_registers_from)
2683         (tui_data_window::display_reg_element_at_line)
2684         (tui_data_window::display_registers_from_line): Remove checks of
2685         "empty".
2686
2687 2019-08-30  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2690         Don't declare.
2691         * tui/tui-regs.c (tui_data_window::show_registers): Call
2692         rerender.
2693         (tui_data_window::rerender): Rename from display_all_data.
2694         (tui_data_window::rerender): Remove old implementation.
2695
2696 2019-08-30  Tom Tromey  <tom@tromey.com>
2697
2698         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2699         text.
2700         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2701
2702 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2703             Sergio Durigan Junior  <sergiodj@redhat.com>
2704
2705         PR win32/24284
2706         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2707
2708 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2711         when searching for types.
2712
2713 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * f-lang.c (f_language_defn): Use f_print_typedef.
2716         * f-lang.h (f_print_typedef): Declare.
2717         * f-typeprint.c (f_print_typedef): Define.
2718
2719 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2720
2721         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2722
2723 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * cli/cli-utils.c (info_print_options_defs): Delete.
2726         (make_info_print_options_def_group): Delete.
2727         (extract_info_print_options): Delete.
2728         (info_print_command_completer): Delete.
2729         (info_print_args_help): Add extra parameter, and optionally
2730         include text about -n flag.
2731         * cli/cli-utils.h (struct info_print_options): Delete.
2732         (extract_info_print_options): Delete declaration.
2733         (info_print_command_completer): Delete declaration.
2734         (info_print_args_help): Add extra parameter, extend header
2735         comment.
2736         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2737         search_symbols.
2738         * stack.c (struct info_print_options): New type.
2739         (info_print_options_defs): New file scoped variable.
2740         (make_info_print_options_def_group): New static function.
2741         (info_print_command_completer): New static function.
2742         (info_locals_command): Update to use new local functions.
2743         (info_args_command): Likewise.
2744         (_initialize_stack): Add extra parameter to calls to
2745         info_print_args_help.
2746         * symtab.c (search_symbols): Add extra parameter, use this to
2747         possibly excluse non-debug symbols.
2748         (symtab_symbol_info): Add extra parameter, which is passed on to
2749         search_symbols.
2750         (struct info_print_options): New type.
2751         (info_print_options_defs): New file scoped variable.
2752         (make_info_print_options_def_group): New static function.
2753         (info_print_command_completer): New static function.
2754         (info_variables_command): Update to use local functions, and pass
2755         extra parameter through to symtab_symbol_info.
2756         (info_functions_command): Likewise.
2757         (info_types_command): Pass additional argument through to
2758         symtab_symbol_info.
2759         (rbreak_command): Pass extra argument to search_symbols.
2760         (_initialize_symtab): Add extra arguments for calls to
2761         info_print_args_help, and update help text for 'info variables',
2762         'whereis', and 'info functions' commands.
2763         * symtab.h (search_symbols): Add extra argument to declaration.
2764         * NEWS: Mention new flags.
2765
2766 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2767
2768         * symtab.c (lookup_static_symbol): Call the new function (and move
2769         it down to be next to lookup_global_symbol).
2770         (struct global_sym_lookup_data): Add block_enum member and rename to...
2771         (struct global_or_static_sym_lookup_data): ...this.
2772         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2773         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2774         (lookup_symbol_global_or_static_iterator_cb): ...this.
2775         (lookup_global_or_static_symbol): New function.
2776         (lookup_global_symbol): Call new function.
2777
2778 2019-08-26  Tom de Vries  <tdevries@suse.de>
2779
2780         PR c++/24852
2781         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2782         when pc_probe.prob == NULL.
2783
2784 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2785
2786         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2787         variable symbol_linkage to symbol_linkage_.
2788
2789 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2790
2791         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2792         represent whether the symbol is static, dynamic, or we don't
2793         know.
2794
2795 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2796
2797         * gdb/rx-tdep.c (rx_register_names): New.
2798         (rx_register_name): Delete.
2799         (rx_psw_type): Delete.
2800         (rx_fpsw_type): Delete.
2801         (rx_register_type): Delete.
2802         (rx_gdbarch_init): Convert target-descriptions.
2803         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2804         * gdb/features/Makefile: Add rx.xml.
2805         * gdb/features/rx.xml: New.
2806         * gdb/features/rx.c: Generated.
2807         * gdb/NEWS: Mention target description support.
2808
2809 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2810
2811         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2812         *slot_ptr.
2813
2814 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2815
2816         * configure.ac: Don't check for 'dlfcn.h' (moved to
2817         gdbsupport/common.m4).
2818         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2819         'gdbsupport/'.
2820         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2821         * compile/compile-c-support.c: Include
2822         'gdbsupport/gdb-dlfcn.h'.
2823         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2824         * gdb-dlfcn.c: Move to...
2825         * gdbsupport/gdb-dlfcn.c: ... here.
2826         * gdb-dlfcn.h: Move to...
2827         * gdbsupport/gdb-dlfcn.h: ... here.
2828
2829 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2830
2831         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2832         the offset field signed.
2833
2834 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2835
2836         * python/lib/gdb/__init__.py (_execute_file): New function.
2837         * python/python.c (python_run_simple_file): Call gdb._execute_file
2838         on Windows.
2839
2840 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2843         all uses as this was never set to anything but a zero value.
2844
2845 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2846
2847         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2848
2849 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2850
2851         * tui/tui-data.h (tui_gen_win_info): Add an =default
2852         move constructor, required by some GCC versions.
2853
2854 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2855
2856         * go32-nat.c (go32_sysinfo): Add hygon_p.
2857
2858 2019-08-20  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2861         line_from_reg_element_no, first_reg_element_no_inline,
2862         display_all_data, delete_data_content_windows,
2863         erase_data_content>: Now private.
2864
2865 2019-08-20  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2868         (tui_unhighlight_win, tui_highlight_win)
2869         (tui_win_info::make_window): Update.
2870         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2871
2872 2019-08-20  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2875         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2876         (MAX_PID_WIDTH): Move to tui-stack.c.
2877         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2878         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2879         (MAX_PID_WIDTH): Move from tui-data.h.
2880
2881 2019-08-20  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2884         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2885         (box_win): Update.
2886         (tui_gen_win_info::make_window): Rename from tui_make_window.
2887         (tui_win_info::make_window): New method.
2888         (tui_gen_win_info::make_visible): Update.
2889         * tui/tui-source.c (tui_source_window::set_contents): Update.
2890         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2891         (tui_data_window::display_registers_from): Update.
2892         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2893         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2894         Declare.
2895         <can_box>: Remove.
2896         <title>: Remove.
2897         (struct tui_win_info) <make_window>: Declare.
2898         <can_box>: Now virtual.
2899         <title>: New member.
2900         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2901         * tui/tui-command.c (tui_cmd_window::resize): Update.
2902
2903 2019-08-20  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2906         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2907         (tui_data_window::check_register_values): Update.
2908
2909 2019-08-20  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui-regs.h (struct tui_data_window): Use
2912         DISABLE_COPY_AND_ASSIGN.
2913         <regs_content>: Change type, removing unique_ptr.
2914         <tui_data_window>: Add move constructor.
2915         * tui/tui-regs.c (tui_data_window::show_registers)
2916         (tui_data_window::show_register_group)
2917         (tui_data_window::display_registers_from)
2918         (tui_data_window::display_registers_from)
2919         (tui_data_window::first_data_item_displayed)
2920         (tui_data_window::delete_data_content_windows)
2921         (tui_data_window::rerender, tui_data_window::refresh_window)
2922         (tui_data_window::check_register_values): Update.
2923
2924 2019-08-20  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2927         show_register_group>: Declare.
2928         (tui_show_register_group): Don't declare.
2929         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2930         tui_show_registers.
2931         (tui_data_window::show_register_group): Rename from
2932         tui_show_register_group.
2933         (tui_data_window::check_register_values, tui_reg_command):
2934         Update.
2935         * tui/tui-layout.c (tui_set_layout): Update.
2936
2937 2019-08-20  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2940         Declare.
2941         (tui_check_register_values): Don't declare.
2942         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2943         from tui_check_register_values.
2944         * tui/tui-hooks.c (tui_register_changed): Update.
2945
2946 2019-08-20  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-regs.c (tui_reg_layout): Move later.
2949         (tui_show_registers): Don't enable TUI mode or change layout.
2950
2951 2019-08-20  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-regs.h (struct tui_data_item_window)
2954         <~tui_data_item_window>: Remove.
2955         <content>: Now a unique_xmalloc_ptr.
2956         * tui/tui-regs.c (tui_register_format): Return a
2957         unique_xmalloc_ptr.
2958         (tui_get_register): Update.
2959         (~tui_data_item_window): Remove.
2960         (tui_data_window::display_registers_from, tui_display_register):
2961         Update.
2962         * tui/tui-io.h (tui_expand_tabs): Update.
2963         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2964         Remove "col" parameter.
2965
2966 2019-08-20  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2969         field.
2970         * tui/tui-regs.c (~tui_data_item_window): Update.
2971
2972 2019-08-20  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2975         earlier.
2976
2977 2019-08-20  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2980
2981 2019-08-20  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-source.h (struct tui_source_window): Update.
2984         * tui/tui-regs.c (tui_show_registers): Update.
2985         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2986         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2987         (NO_REGS_STRING): Remove defines.
2988
2989 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2990
2991         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2992         unnecessary thread walk if remote doesn't support the packet.
2993
2994 2019-08-19  Tom Tromey  <tromey@adacore.com>
2995
2996         * python/py-value.c (value_has_field): Fix indentation.
2997
2998 2019-08-19  Tom Tromey  <tromey@adacore.com>
2999
3000         * printcmd.c (do_one_display, info_display_command): Update.
3001         * block.h (contained_in): Return bool.  Add allow_nested
3002         parameter.
3003         * block.c (contained_in): Return bool.  Add allow_nested
3004         parameter.
3005
3006 2019-08-19  Tom Tromey  <tom@tromey.com>
3007
3008         * configure: Rebuild.
3009         * configure.ac: Disallow the combination of -static-libstdc++ and
3010         source highlight.
3011         * source-cache.c (get_language_name): Handle rust.
3012         (source_cache::get_source_lines): Ignore highlighting exceptions.
3013
3014 2019-08-16  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3017         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3018         (struct tui_source_window_base) <make_visible, refresh_window,
3019         resize>: Remove methods.
3020         <execution_info>: Remove field.
3021         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3022         (tui_show_source_line, tui_source_window_base)
3023         (~tui_source_window_base): Update.
3024         (tui_source_window_base::resize)
3025         (tui_source_window_base::make_visible)
3026         (tui_source_window_base::refresh_window): Remove.
3027         (tui_source_window_base::update_exec_info): Update.
3028         * tui/tui-source.c (tui_source_window::set_contents): Update.
3029         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3030
3031 2019-08-16  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3034         deprecated_query_hook.
3035
3036 2019-08-16  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3039         (tui_update_source_windows_with_line): Update.
3040         * tui/tui-source.h (struct tui_source_window)
3041         <show_symtab_source>: Declare.
3042         (tui_show_symtab_source): Don't declare.
3043         * tui/tui-source.c (tui_show_symtab_source): Rename from
3044         tui_show_symtab_source.
3045
3046 2019-08-16  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-winsource.h (struct tui_source_window_base)
3049         <set_contents>: Declare.
3050         * tui/tui-winsource.c
3051         (tui_source_window_base::update_source_window_as_is): Update.
3052         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3053         Declare.
3054         (tui_set_source_content): Don't declare.
3055         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3056         tui_set_source_content.
3057         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3058         Declare.
3059         (tui_set_disassem_content): Don't declare.
3060         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3061         tui_set_disassem_content.
3062
3063 2019-08-16  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-winsource.h (struct tui_source_window_base)
3066         <update_breakpoint_info>: Declare.
3067         (tui_update_breakpoint_info): Don't declare.
3068         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3069         (tui_update_all_breakpoint_info): Update.
3070         (tui_source_window_base::update_breakpoint_info): Rename from
3071         tui_update_breakpoint_info.
3072         (tui_source_window_base::update_exec_info): Update.
3073
3074 2019-08-16  Tom Tromey  <tom@tromey.com>
3075
3076         * tui/tui-winsource.h (struct tui_source_window_base)
3077         <update_source_window>: Declare.
3078         (tui_update_source_window): Don't declare.
3079         * tui/tui-winsource.c
3080         (tui_source_window_base::update_source_window): Rename from
3081         tui_update_source_window.
3082         (tui_source_window_base::rerender): Update.
3083         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3084         * tui/tui-disasm.c (tui_show_disassem)
3085         (tui_show_disassem_and_update_source)
3086         (tui_disasm_window::maybe_update): Update.
3087
3088 2019-08-16  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-winsource.h (struct tui_source_window_base)
3091         <update_source_window_as_is>: Declare.
3092         (tui_update_source_window_as_is): Don't declare.
3093         * tui/tui-winsource.c (tui_update_source_window): Update
3094         (tui_source_window_base::update_source_window_as_is): Rename from
3095         tui_update_source_window_as_is.
3096         (tui_source_window_base::refill): Update.
3097         * tui/tui-source.c (tui_show_symtab_source): Update.
3098         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3099         Update.
3100
3101 2019-08-16  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-winsource.h (tui_update_source_window)
3104         (tui_update_source_window_as_is): Remove "noerror" parameter.
3105         * tui/tui-winsource.c (tui_update_source_window)
3106         (tui_update_source_window_as_is): Remove "noerror" parameter.
3107         (tui_update_source_windows_with_addr)
3108         (tui_update_source_windows_with_line)
3109         (tui_source_window_base::rerender)
3110         (tui_source_window_base::refill): Update.
3111         * tui/tui-source.h (tui_set_source_content)
3112         (tui_show_symtab_source): Remove "noerror" parameter.
3113         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3114         parameter.
3115         (tui_show_symtab_source): Likewise.
3116         (tui_source_window::maybe_update): Update.
3117         * tui/tui-disasm.c (tui_show_disassem)
3118         (tui_show_disassem_and_update_source)
3119         (tui_disasm_window::do_scroll_vertical)
3120         (tui_disasm_window::maybe_update): Update.
3121
3122 2019-08-16  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui.c (tui_is_window_visible): Update.
3125         * tui/tui-wingeneral.c (tui_make_window)
3126         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3127         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3128         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3129         (tui_set_win_height_command, parse_scrolling_args): Update.
3130         * tui/tui-source.c (tui_source_window::style_changed): Update.
3131         * tui/tui-regs.c (tui_show_registers)
3132         (tui_data_window::first_data_item_displayed)
3133         (tui_data_window::delete_data_content_windows)
3134         (tui_check_register_values, tui_reg_command): Update.
3135         * tui/tui-disasm.c (tui_show_disassem): Update.
3136         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3137         method.
3138         <is_visible>: Remove field.
3139         * tui/tui-data.c (tui_next_win, tui_prev_win)
3140         (tui_delete_invisible_windows): Update.
3141
3142 2019-08-16  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-winsource.h (struct tui_source_window_base)
3145         <m_has_locator>: Remove.
3146         * tui/tui-layout.c (show_source_disasm_command, show_data)
3147         (show_source_or_disasm_and_command): Update.
3148
3149 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3150
3151         * NEWS (Other MI changes): New subsection.
3152         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3153         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3154         * arch-utils.c (default_get_pc_address_flags): New function.
3155         * arch-utils.h (default_get_pc_address_flags): New declaration.
3156         * gdbarch.sh: Add get_pc_address_flags.
3157         * gdbarch.c: Regenerate.
3158         * gdbarch.h: Likewise.
3159         * stack.c (print_pc): New function.
3160         (print_frame_info) (print_frame): Call print_pc.
3161
3162 2019-08-16  Tom de Vries  <tdevries@suse.de>
3163
3164         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3165         print_objfile_section_info.
3166
3167 2019-08-15  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3170         calling update_cmdwin_start_line.
3171         * tui/tui-winsource.h (struct tui_source_window_base)
3172         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3173         <rerender>: Declare.
3174         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3175         Call rerender.
3176         (tui_source_window_base::set_new_height): Remove.
3177         (tui_source_window_base::rerender): Rename from
3178         do_make_visible_with_new_height.
3179         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3180         resize method.
3181         (tui_win_info::make_invisible_and_set_new_height)
3182         (tui_win_info::make_visible_with_new_height): Remove.
3183         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3184         Declare.
3185         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3186         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3187         do_make_visible_with_new_height>: Don't declare.
3188         <rerender>: Declare.
3189         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3190         set_new_height.
3191         (tui_data_window::do_make_visible_with_new_height): Remove.
3192         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3193         call tui_show_locator_content.
3194         (tui_gen_win_info::resize): Call rerender.
3195         (show_source_or_disasm_and_command): Don't call
3196         tui_show_locator_content.
3197         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3198         method.
3199         (struct tui_win_info) <rerender>: Declare.
3200         <set_new_height, make_invisible_and_set_new_height,
3201         make_visible_with_new_height>: Don't declare.
3202         * tui/tui-data.c (tui_win_list::rerender): New method.
3203         * tui/tui-command.h (struct tui_cmd_window)
3204         <do_make_visible_with_new_height>: Don't declare.
3205         * tui/tui-command.c
3206         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3207
3208 2019-08-15  Tom Tromey  <tromey@adacore.com>
3209
3210         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3211         * ada-lang.c (ada_enum_name): Likewise.
3212
3213 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3214
3215         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3216         leading underscore.
3217         (GdbOutputErrorFile): Likewise.
3218         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3219         accordingly.
3220         (execute_unwinders): Rename to have a leading underscore.
3221         (auto_load_packages): Likewise.
3222         (global scope): Adjust call to auto_load_packages accordingly.
3223         (GdbSetPythonDirectory): Likewise.
3224         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3225         instead of execute_unwinders.
3226
3227 2019-08-15  Tom Tromey  <tom@tromey.com>
3228
3229         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3230         (show_data): Don't change window visibility.
3231         (tui_gen_win_info::resize): Remove special case for command
3232         window.  Use wresize, when available.
3233         (show_source_or_disasm_and_command): Don't change window
3234         visibility.
3235         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3236         <make_visible>: New method.
3237         * tui/tui-command.c (tui_cmd_window::resize): New method.
3238
3239 2019-08-15  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3242         (struct tui_source_windows): New.
3243         * tui/tui-winsource.c (tui_display_main): Update.
3244         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3245         (new_height_ok, parse_scrolling_args): Update.
3246         * tui/tui-layout.c (show_layout, show_data): Update.
3247         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3248         (tui_add_to_source_windows): Don't declare.
3249         * tui/tui-data.c (source_windows, tui_source_windows)
3250         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3251
3252 2019-08-15  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3255         Rename from reset.
3256         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3257         * tui/tui-layout.c (show_source_disasm_command, show_data):
3258         Update.
3259         (tui_gen_win_info::resize): Rename.
3260         (show_source_or_disasm_and_command): Update.
3261         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3262         reset.
3263
3264 2019-08-15  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3267         * tui/tui-interp.c (tui_interp::init): Don't call
3268         tui_initialize_static_data.
3269         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3270
3271 2019-08-15  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3274         examine tui_win_list.
3275
3276 2019-08-15  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3279         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3280         tui_clear_source_content.
3281         (tui_clear_source_content): Remove.
3282         (tui_source_window_base::do_erase_source_content): Hoist call to
3283         content.clear().
3284         * tui/tui-stack.c (tui_show_frame_info): Don't call
3285         tui_clear_source_content.
3286
3287 2019-08-15  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-winsource.h (struct tui_source_window_base)
3290         <do_erase_source_content>: New method.
3291         <erase_source_content>: New method.
3292         (tui_erase_source_content): Don't declare.
3293         * tui/tui-winsource.c (tui_clear_source_content): Update.
3294         (tui_source_window_base::do_erase_source_content): Rename from
3295         tui_erase_source_content.
3296         (tui_source_window_base::show_source_content): Update.
3297         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3298         * tui/tui-source.h (struct tui_source_window)
3299         <erase_source_content>: New method.
3300         * tui/tui-disasm.h (struct tui_disasm_window)
3301         <erase_source_content>: New method.
3302
3303 2019-08-15  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3306         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3307         constructor.
3308         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3309         * tui/tui-source.c (tui_set_source_content): Update.
3310         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3311
3312 2019-08-15  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3315         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3316         tui-source.c.
3317         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3318         Declare.
3319         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3320         method.
3321         (tui_source_window::maybe_update): Update.
3322
3323 2019-08-15  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3326         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3327         tui-disasm.c.
3328         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3329         Declare.
3330         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3331         method.
3332         (tui_disasm_window::maybe_update): Update.
3333
3334 2019-08-15  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-winsource.h (struct tui_source_window_base)
3337         <maybe_update>: Declare.
3338         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3339         method.
3340         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3341         Declare.
3342         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3343         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3344         Declare.
3345         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3346
3347 2019-08-15  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3350
3351 2019-08-15  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-wingeneral.c: Include tui-stack.h.
3354         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3355         (struct tui_locator_window): Move from tui-data.h.
3356         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3357         (tui_initialize_static_data): Move from tui-data.c.
3358         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3359         (struct tui_locator_window): Move to tui-stack.c.
3360         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3361         (tui_initialize_static_data): Move to tui-stack.c.
3362
3363 2019-08-15  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-layout.c (show_source_disasm_command)
3366         (show_source_or_disasm_and_command): Use make_visible method, not
3367         tui_make_window.
3368         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3369         Remove.
3370
3371 2019-08-15  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-wingeneral.h (tui_make_window): Update.
3374         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3375         parameter.
3376         (tui_gen_win_info::make_visible): Update.
3377         * tui/tui-regs.c (tui_data_window::display_registers_from):
3378         Update.
3379         * tui/tui-layout.c (show_source_disasm_command)
3380         (show_source_or_disasm_and_command): Update.
3381         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3382         (enum tui_box): Remove.
3383         (struct tui_win_info) <can_box>: New method.
3384         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3385         method.
3386
3387 2019-08-15  Tom de Vries  <tdevries@suse.de>
3388
3389         * linux-nat-trad.c: Include gdbarch.h.
3390
3391 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3392
3393         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3394         register sizes.
3395
3396 2019-08-14  Tom Tromey  <tromey@adacore.com>
3397
3398         * darwin-nat.c: Include gdbarch.h.
3399         * darwin-nat-info.c: Include gdbarch.h.
3400
3401 2019-08-13  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3404         Remove.
3405         * tui/tui-data.c (tui_initialize_static_data): Update.
3406
3407 2019-08-13  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-winsource.h (struct tui_exec_info_window)
3410         <~tui_exec_info_window, maybe_allocate_content, get_content,
3411         m_content>: Remove.
3412         (struct tui_source_window_base) <set_exec_info_content,
3413         show_exec_info_content>: Don't declare.
3414         * tui/tui-winsource.c
3415         (tui_exec_info_window::maybe_allocate_content): Remove.
3416         (tui_source_window_base::update_exec_info): Rename from
3417         set_exec_info_content.
3418         (tui_source_window_base::show_exec_info_content)
3419         (tui_source_window_base::update_exec_info): Remove.
3420
3421 2019-08-13  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3424         declare.
3425         * tui/tui-winsource.c (tui_update_source_window_as_is)
3426         (tui_update_source_windows_with_addr, tui_erase_source_content):
3427         Update.
3428         (tui_clear_exec_info_content): Remove.
3429
3430 2019-08-13  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3433         declare.
3434         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3435         call tui_erase_exec_info_content.
3436         (tui_clear_exec_info_content): Rename from
3437         tui_erase_exec_info_content.
3438         (tui_clear_exec_info_content): Delete.
3439
3440 2019-08-13  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-winsource.h (struct tui_source_window_base)
3443         <show_exec_info_content>: Declare.
3444         (tui_show_exec_info_content): Don't declare.
3445         * tui/tui-winsource.c
3446         (tui_source_window_base::show_exec_info_content): Rename from
3447         tui_show_exec_info_content.
3448         (tui_source_window_base::update_exec_info): Update.
3449
3450 2019-08-13  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3453         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3454         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3455         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3456         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3457         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3458         ... here.
3459
3460 2019-08-13  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-winsource.h (struct tui_source_window_base)
3463         <update_exec_info>: Declare.
3464         (tui_update_exec_info): Don't declare.
3465         * tui/tui-winsource.c (tui_update_source_window_as_is)
3466         (tui_source_window_base::refresh_all)
3467         (tui_update_all_breakpoint_info): Update.
3468         (tui_source_window_base::update_exec_info): Rename from
3469         tui_update_exec_info.
3470         * tui/tui-stack.c (tui_show_frame_info): Update.
3471
3472 2019-08-13  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-winsource.h (struct tui_source_window_base)
3475         <set_exec_info_content>: Declare.
3476         (tui_set_exec_info_content): Don't declare.
3477         * tui/tui-winsource.c
3478         (tui_source_window_base::set_exec_info_content): Rename from
3479         tui_set_exec_info_content.
3480         (tui_update_exec_info): Update.
3481
3482 2019-08-13  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-winsource.h (struct tui_source_window_base)
3485         <show_source_content>: Declare.
3486         (tui_show_source_content): Don't declare.
3487         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3488         (tui_source_window_base::show_source_content): Rename from
3489         tui_show_source_content.
3490         (tui_source_window_base::refresh_all): Update.
3491         * tui/tui-layout.c (show_source_disasm_command)
3492         (show_source_or_disasm_and_command): Update.
3493
3494 2019-08-13  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-winsource.c (tui_erase_source_content)
3497         (tui_show_source_content, tui_source_window_base::refresh_all):
3498         Update.
3499         * tui/tui-wingeneral.h
3500         (tui_check_and_display_highlight_if_needed): Don't declare.
3501         * tui/tui-wingeneral.c
3502         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3503         check_and_display_highlight_if_needed.
3504         * tui/tui-win.c (tui_rehighlight_all)
3505         (tui_win_info::make_visible_with_new_height): Update.
3506         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3507         (tui_data_window::erase_data_content)
3508         (tui_data_window::display_all_data): Update.
3509         * tui/tui-data.h (struct tui_win_info)
3510         <check_and_display_highlight_if_needed>: Declare.
3511
3512 2019-08-13  Tom Tromey  <tom@tromey.com>
3513
3514         * tui/tui-win.c (tui_resize_all): Call
3515         tui_delete_invisible_windows.
3516         * tui/tui-layout.c (show_layout): Call
3517         tui_delete_invisible_windows.
3518         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3519         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3520
3521 2019-08-13  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3524         tui_add_win_to_layout.
3525
3526 2019-08-13  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3529         * tui/tui-layout.c (tui_default_win_height): Now static.
3530
3531 2019-08-13  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3534         single switch.
3535         (show_source_disasm_command, show_source_or_disasm_and_command):
3536         Don't check current layout.
3537
3538 2019-08-13  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-wingeneral.c (make_all_visible): Remove.
3541         (tui_make_all_invisible): Simplify.
3542         * tui/tui-layout.c (tui_make_all_invisible): Move from
3543         tui-wingeneral.c; simplify.
3544         (show_layout): Hoist call to tui_make_all_invisible.
3545         (show_data): Don't call tui_make_all_invisible.
3546
3547 2019-08-13  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3550         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3551
3552 2019-08-13  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3555         tui-data.c.
3556         (show_source_disasm_command, show_data)
3557         (show_source_or_disasm_and_command): Don't use
3558         tui_set_current_layout_to.
3559         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3560         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3561         tui-layout.c.
3562         (tui_set_current_layout_to): Remove.
3563
3564 2019-08-13  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-layout.c (tui_set_layout): Update.
3567         * tui/tui-data.h (struct tui_layout_def): Remove.
3568         (tui_layout_def): Don't declare.
3569         * tui/tui-data.c (layout_def): Remove.
3570         (tui_layout_def): Remove.
3571
3572 2019-08-13  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-winsource.h (struct tui_source_window_base)
3575         <clear_detail>: No longer "override".
3576         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3577         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3578         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3579         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3580         Remove.
3581         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3582
3583 2019-08-13  Tom Tromey  <tromey@adacore.com>
3584
3585         * tracepoint.c: Don't include readline.h or history.h.
3586
3587 2019-08-12  Tom Tromey  <tom@tromey.com>
3588
3589         * configure: Rebuild.
3590         * configure.ac: Check for readline 7.
3591         * NEWS: Mention readline 7 requirement.
3592         * README: Update.
3593
3594 2019-08-12  Tom Tromey  <tom@tromey.com>
3595
3596         * mingw-hdep.c (gdb_select): Remove readline hack.
3597
3598 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3599
3600         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3601         when the function fails.
3602
3603 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3604
3605         * s390-tdep.c (s390_type_align): New function.
3606         (s390_gdbarch_init): Set it as type_align gdbarch method.
3607
3608 2019-08-09  Tom de Vries  <tdevries@suse.de>
3609
3610         PR gdb/24591
3611         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3612         pc_low with relocation offset.
3613
3614 2019-08-07  Tom Tromey  <tromey@adacore.com>
3615
3616         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3617         (print_frame_args): Update.
3618         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3619         Update.
3620         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3621         * frame.h (struct frame_arg): Add initializers.
3622         <error>: Now a unique_xmalloc_ptr.
3623
3624 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3625
3626         * NEWS: Expand the Pointer Authentication entry.
3627         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3628         (aarch64_frame_unmask_lr): ... to this.
3629         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3630         Call aarch64_frame_unmask_lr.
3631         * frame.c (struct frame_info): Add "masked" variable.
3632         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3633         (fprint_frame): Check for masked pc.
3634         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3635         declarations.
3636         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3637         * stack.c (print_frame): Check for masked pc.
3638
3639 2019-08-06  Tom Tromey  <tom@tromey.com>
3640
3641         * stabsread.c (patch_block_stabs, read_one_struct_field)
3642         (read_enum_type): Use obstack_strndup.
3643         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3644         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3645         * dwarf2read.c (guess_full_die_structure_name)
3646         (anonymous_struct_prefix): Use obstack_strndup.
3647         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3648         * c-exp.y (yylex): Use obstack_strndup.
3649         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3650         (write_var_or_type): Use obstack_strndup.
3651
3652 2019-08-06  Tom Tromey  <tom@tromey.com>
3653
3654         * symfile.c (reread_symbols): Use obstack_strdup.
3655         * stabsread.c (read_type): Use obstack_strdup.
3656         * gdb_obstack.h (obstack_strdup): New overload.
3657         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3658         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3659         (dwarf2_canonicalize_name): Use obstack_strdup.
3660         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3661         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3662         Use obstack_strdup.
3663
3664 2019-08-06  Tom Tromey  <tom@tromey.com>
3665
3666         * gdb_obstack.h (obstack_strdup): Define.
3667         * gdb_obstack.c (obstack_strdup): Don't define.
3668
3669 2019-08-06  Tom Tromey  <tom@tromey.com>
3670
3671         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3672         obstack_strdup.
3673         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3674         obstack_strdup.
3675         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3676         * stabsread.c (common_block_start): Use obstack_strdup.
3677         * objfiles.c (set_objfile_main_name, objfile): Use
3678         obstack_strdup.
3679         * namespace.c (add_using_directive): Use obstack_strdup.
3680         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3681         * jit.c (finalize_symtab): Use obstack_strdup.
3682         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3683         (guess_partial_die_structure_name, partial_die_info::fixup)
3684         (dwarf2_name): Use obstack_strdup.
3685         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3686         obstack_strdup.
3687         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3688         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3689         obstack_strdup.
3690         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3691
3692 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3693
3694         * unittests/help-doc-selftests.c: New file.
3695         * Makefile.in: Add the new file.
3696
3697 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3698
3699         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3700         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3701         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3702         the trailing '.' is not output, and the first character is uppercased.
3703         (print_help_for_command): Update call to print_doc_line.
3704         (print_doc_of_command): Likewise.
3705         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3706         * cli/cli-option.c (append_indented_doc): Do not append newline.
3707         (build_help_option): Append newline after first appended_indented_doc
3708         only if a second call is done.
3709         (build_help): Append 2 new lines before each option, except the first
3710         one.
3711         * compile/compile.c (_initialize_compile): Add new lines after
3712         %OPTIONS%, when not at the end of the help.
3713         Change help doc or code
3714         producing the help doc to respect the invariants.
3715         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3716         Also removed the new line after 'Options:', as all other commands
3717         do not put an empty line between 'Options:' and the first option.
3718         * printcmd.c (_initialize_printcmd): Likewise.
3719         * stack.c (_initialize_stack): Likewise.
3720         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3721         incorrectly telling COMMAND is optional.
3722         * ada-lang.c (_initialize_ada_language): Change help doc or code
3723         producing the help doc to respect the invariants.
3724         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3725         * breakpoint.c (_initialize_breakpoint): Likewise.
3726         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3727         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3728         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3729         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3730         _initialize_cli_style): Likewise.
3731         * corelow.c (core_target_info): Likewise.
3732         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3733         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3734         * filesystem.c (_initialize_filesystem): Likewise.
3735         * frame.c (_initialize_frame): Likewise.
3736         * gnu-nat.c (add_task_commands): Likewise.
3737         * infcall.c (_initialize_infcall): Likewise.
3738         * infcmd.c (_initialize_infcmd): Likewise.
3739         * interps.c (_initialize_interpreter): Likewise.
3740         * language.c (_initialize_language): Likewise.
3741         * linux-fork.c (_initialize_linux_fork): Likewise.
3742         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3743         * maint.c (_initialize_maint_cmds): Likewise.
3744         * memattr.c (_initialize_mem): Likewise.
3745         * printcmd.c (_initialize_printcmd): Likewise.
3746         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3747         _RegEx): Likewise.
3748         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3749         * record-btrace.c (_initialize_record_btrace): Likewise.
3750         * record-full.c (_initialize_record_full): Likewise.
3751         * record.c (_initialize_record): Likewise.
3752         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3753         * regcache.c (_initialize_regcache): Likewise.
3754         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3755         _initialize_remote): Likewise.
3756         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3757         * serial.c (_initialize_serial): Likewise.
3758         * skip.c (_initialize_step_skip): Likewise.
3759         * source.c (_initialize_source): Likewise.
3760         * stack.c (_initialize_stack): Likewise.
3761         * symfile.c (_initialize_symfile): Likewise.
3762         * symtab.c (_initialize_symtab): Likewise.
3763         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3764         * top.c (init_main): Likewise.
3765         * tracefile-tfile.c (tfile_target_info): Likewise.
3766         * tracepoint.c (_initialize_tracepoint): Likewise.
3767         * tui/tui-win.c (_initialize_tui_win): Likewise.
3768         * utils.c (add_internal_problem_command): Likewise.
3769         * valprint.c (value_print_option_defs): Likewise.
3770
3771 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3772
3773         PR build/24886
3774         * configure.ac: Drop enable-libmcheck support.
3775         * configure, config.in: Rebuild.
3776         * libmcheck.m4: Remove.
3777         * acinclude.m4: Don't include it.
3778         * Makefile.in: Don't distribute it.
3779         * top.c (print_gdb_configuration): Don't mention it.
3780
3781 2019-08-06  Tom Tromey  <tom@tromey.com>
3782
3783         * utils.c (set_output_style): Sometimes pass stream to
3784         emit_style_escape.
3785         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3786         * record-btrace.c (btrace_insn_history): Update.
3787         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3788         method.
3789         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3790         Update initializers.
3791         <m_uiout>: New field.
3792         <m_di>: Move lower.
3793         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3794         Remove "uiout" parameter.
3795         (dump_insns): Update.
3796         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3797         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3798
3799 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3800
3801         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3802         (error_in_psymtab_expansion): Likewise.
3803         (lookup_symbol_via_quick_fns): Likewise.
3804         (basic_lookup_transparent_type_quick): Likewise.
3805         (basic_lookup_transparent_type_1): Likewise.
3806
3807 2019-08-06  Tom Tromey  <tromey@adacore.com>
3808
3809         * source.c (last_source_error): Now bool.
3810         (print_source_lines_base): Make "noprint" bool.  Only open
3811         source file when last_source_visited changes.
3812
3813 2019-08-06  Tom Tromey  <tromey@adacore.com>
3814
3815         * annotate.c (annotate_source_line): Use g_source_cache.
3816         * source-cache.c (source_cache::get_plain_source_lines): Change
3817         parameters.  Populate m_offset_cache.
3818         (source_cache::ensure): New method.
3819         (source_cache::get_line_charpos): New method.
3820         (extract_lines): Move lower.  Change parameters.
3821         (source_cache::get_source_lines): Move lower.
3822         * source-cache.h (class source_cache): Update comment.
3823         <get_line_charpos>: New method.
3824         <get_source_lines>: Update comment.
3825         <clear>: Clear m_offset_cache.
3826         <get_plain_source_lines>: Change parameters.
3827         <ensure>: New method
3828         <m_offset_cache>: New member.
3829         * source.c (forget_cached_source_info_for_objfile): Update.
3830         (info_source_command): Use g_source_cache.
3831         (find_source_lines, open_source_file_with_line_charpos): Remove.
3832         (print_source_lines_base, search_command_helper): Use g_source_cache.
3833         * source.h (open_source_file_with_line_charpos): Don't declare.
3834         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3835         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3836         Use g_source_cache.
3837
3838 2019-08-06  Tom Tromey  <tromey@adacore.com>
3839
3840         * source-cache.c (source_cache::get_plain_source_lines):
3841         Remove "first_line" and "last_line" parameters.
3842         (source_cache::get_source_lines): Cache plain text.
3843         * source-cache.h (class source_cache)
3844         <get_plain_source_lines>: Update.
3845
3846 2019-08-06  Tom Tromey  <tromey@adacore.com>
3847
3848         * source-cache.c (extract_lines): No longer a method.
3849         Changed type of parameter.  Include final newline.
3850         (selftests::extract_lines_test): New function.
3851         (_initialize_source_cache): Likewise.
3852         * source-cache.h (class source_cache)
3853         <extract_lines>: Don't declare.
3854
3855 2019-08-06  Tom Tromey  <tromey@adacore.com>
3856
3857         * breakpoint.c (init_breakpoint_sal): Update.
3858         (breakpoint): Update.
3859         * breakpoint.h (struct breakpoint) <filter>: Now a
3860         unique_xmalloc_ptr.
3861
3862 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3863
3864         * NEWS: Mention dictionary access on blocks.
3865         * python/py-block.c (blpy_getitem): New function.
3866         (block_object_as_mapping): New struct.
3867         (block_object_type): Use new struct for tp_as_mapping field.
3868
3869 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3870
3871         * objfiles.h (objfile): Add a comment describing partial symbols.
3872
3873 2019-08-05  Tom Tromey  <tromey@adacore.com>
3874
3875         * compile/compile.c (_initialize_compile): Use _(), not N_().
3876         * thread.c (_initialize_thread): Use _(), not N_().
3877         * stack.c (_initialize_stack): Use _(), not N_().
3878         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3879
3880 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3881
3882         * dwarf2read.c (struct dw2_symtab_iterator):
3883         <want_specific_block>: Remove.
3884         <block_index>: Change type to gdb::optional.
3885         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3886         change type of BLOCK_INDEX parameter to gdb::optional.
3887         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3888         (dw2_lookup_symbol): Don't pass argument for
3889         WANT_SPECIFIC_BLOCK.
3890         (dw2_expand_symtabs_for_function): Don't pass argument for
3891         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3892         (class dw2_debug_names_iterator)
3893         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3894         parameter, change BLOCK_INDEX type to gdb::optional.
3895         <m_want_specific_block>: Remove.
3896         <m_block_index>: Change type to gdb::optional.
3897         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3898         gdb::optional.  Re-write in function of gdb::optional.
3899         (dw2_debug_names_lookup_symbol): Don't pass argument for
3900         WANT_SPECIFIC_BLOCK.
3901         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3902         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3903         BLOCK_INDEX.
3904
3905 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3906
3907         * NEWS: Mention changes to "info sources" command.
3908
3909 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3910
3911         * symtab.c (filename_partial_match_opts): New struct type.
3912         (struct output_source_filename_data): New members
3913         regexp, c_regexp, partial_match.
3914         (output_source_filename): Use new members to decide to print file.
3915         (info_sources_option_defs): New variable.
3916         (make_info_sources_options_def_group, print_info_sources_header,
3917         info_sources_command_completer):
3918         New functions.
3919         (info_sources_command): Read new optional arguments.
3920         (_initialize_symtab): Update info sources help.
3921
3922 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3923
3924         * ada-lang.c (exception_support_info_v0): Renamed from...
3925         (default_exception_support_info): ... this.  Create new
3926         definition for v1.
3927         (ada_has_this_exception_support): Look up catch_handlers_sym.
3928         (ada_exception_support_info_sniffer): Try v0 after default.
3929
3930 2019-08-01  Tom Tromey  <tromey@adacore.com>
3931
3932         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3933         gdbarch.h.
3934
3935 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3936
3937         * s12z-tdep.c: Fix include path for s12z-opc.h.
3938
3939 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3940
3941         * NEWS: Require GNU make 3.82.
3942
3943 2019-07-16  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3946         declare.
3947
3948 2019-07-30  Tom Tromey  <tromey@adacore.com>
3949
3950         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3951
3952 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3953
3954         * printcmd.c (print_address_symbolic): Print negative offsets.
3955         (build_address_symbolic): Force signed arithmetic when computing
3956         offset.
3957
3958 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3959
3960         PR/24474: Add a function to lookup static variables.
3961         * NEWS: Mention this new function.
3962         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3963         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3964         * python/python.c (python_GdbMethods): Add new function.
3965
3966 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3967
3968         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3969         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3970         (objfpy_lookup_static_symbol): New function.
3971         (objfile_object_methods): Add new functions.
3972
3973 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3974
3975         * NEWS: Mention 'set|show print frame-info'.  Mention new
3976         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3977         backtrace argument.  Mention that python frame filtering code
3978         is now consistent with what 'backtrace' command prints.
3979
3980 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3981
3982         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3983         comments.
3984         (print_frame_info_auto, print_frame_info_source_line,
3985         print_frame_info_location, print_frame_info_source_and_location,
3986         print_frame_info_location_and_address, print_frame_info_short_location):
3987         New declarations.
3988         (struct frame_print_options): New member print_frame_info.
3989         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3990         * stack.h (get_user_print_what_frame_info): New declaration.
3991         (frame_show_address): New declaration.
3992         * stack.c (print_frame_arguments_choices): New value 'presence'.
3993         (print_frame_info_auto, print_frame_info_source_line,
3994         print_frame_info_location, print_frame_info_source_and_location,
3995         print_frame_info_location_and_address, print_frame_info_short_location,
3996         print_frame_info_choices, print_frame_info_print_what): New definitions.
3997         (print_frame_args): Only print dots for args if print frame-arguments
3998         is 'presence'.
3999         (frame_print_option_defs): New element for "frame-info".
4000         (get_user_print_what_frame_info): New function.
4001         (frame_show_address): Make non static.  Move comment to stack.h.
4002         (print_frame_info_to_print_what): New function.
4003         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4004         to decide what to print.
4005         (backtrace_command_1): Handle the new print_frame_arguments_presence
4006         value.
4007         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4008         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4009         (py_print_frame): In non-mi mode, use LOCATION as default for
4010         print_what, similarly to frame information printed directly by
4011         backtrace command. Handle frame-info user option in non MI mode.
4012
4013 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4014
4015         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4016         Add case for debugging 32-bit target on 64-bit host.  Revise
4017         comment.
4018
4019 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4020
4021         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4022         instead of find_function_entry_range_from_pc.
4023
4024 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4025
4026         * stack.c (find_frame_funname): Remove code which preferred
4027         minsym over symtab sym in "certain pathological cases".
4028
4029         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4030         parameter.  Change type of "do_demangle" to bool.
4031         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4032         Pass suitable "prefer_sym_over_minsym" flag to
4033         build_address_symbolic().  Don't output "+" for negative offsets.
4034         * printcmd.c (print_address_symbolic): Update invocation of
4035         build_address_symbolic to include a "prefer_sym_over_minsym"
4036         flag.
4037         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4038         Restrict cases in which use of minimal symbol is preferred to that
4039         of a found symbol.  Update comments.
4040
4041         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4042         for entry pc when entry pc is out of range for that FDE.
4043
4044 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4045
4046         PR gdb/24839:
4047         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4048         type.
4049
4050 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4051
4052         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4053         this function's Python signature.
4054
4055
4056 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4057
4058         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4059         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4060         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4061         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4062         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4063
4064
4065 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4066
4067         * h8300-tdep.c (h8300_register_name_common): New.
4068         h8300_register_name): Use h8300_register_name_common.
4069         (h8300s_register_name): Likewise.
4070         (h8300sx_register_name): Likewise.
4071         (h8300h_register_nam): New.
4072         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4073
4074
4075 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4076
4077         * arm-tdep.c (arm_skip_cmse_entry): New function.
4078         (arm_is_sgstubs_section): New function.
4079         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4080
4081 2019-07-22  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4084         Don't self-assign.
4085
4086 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4089         type_print.
4090
4091 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4094         so that GDB doesn't match any msymbols when searching in the
4095         TYPES_DOMAIN.
4096         (print_symbol_info): Print using typedef_print or type_print based
4097         on the type of the symbol.  Add updated FIXME comment moved from...
4098         (_initialize_symtab): ... move and update FIXME comment to above.
4099
4100 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4101
4102         * NEWS: Mention adding -q option to "info types".
4103         * symtab.c (struct info_types_options): New struct.
4104         (info_types_options_defs): New variable.
4105         (make_info_types_options_def_group): New function.
4106         (info_types_command): Use gdb::option framework to parse options.
4107         (info_types_command_completer): New function.
4108         (_initialize_symtab): Extend the help text on "info types" and
4109         register command completer.
4110
4111 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4112
4113         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4114         (lookup_symbol_in_objfile): Change int to block_enum and add a
4115         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4116
4117 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4118
4119         * MAINTAINERS (Write After Approval): Add self.
4120
4121 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4124         instruction to the dummy code region.
4125
4126 2019-07-19  Tom Tromey  <tromey@adacore.com>
4127
4128         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4129         (ARGSUSED, PARAMS, __func__): Remove rules.
4130
4131 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4132
4133         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4134         * features/arm/arm-with-iwmmxt.c: Remove.
4135         * features/arm/arm-with-iwmmxt.xml: Remove.
4136         * features/arm/arm-with-m-fpa-layout.c: Remove.
4137         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4138         * features/arm/arm-with-m-vfp-d16.c: Remove.
4139         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4140         * features/arm/arm-with-m.c: Remove.
4141         * features/arm/arm-with-m.xml: Remove.
4142         * features/arm/arm-with-neon.c: Remove.
4143         * features/arm/arm-with-neon.xml: Remove.
4144         * features/arm/arm-with-vfpv2.c: Remove.
4145         * features/arm/arm-with-vfpv2.xml: Remove.
4146         * features/arm/arm-with-vfpv3.c: Remove.
4147         * features/arm/arm-with-vfpv3.xml: Remove.
4148
4149 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4150
4151         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4152
4153 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4154
4155         * arch/aarch32.c (aarch32_create_target_description): Create
4156         target descriptions using features.
4157         * arch/arm.c (arm_create_target_description)
4158         (arm_create_mprofile_target_description): Likewise.
4159         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4160
4161 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4162
4163         * Makefile.in: Add new files.
4164         * aarch32-tdep.c: New file.
4165         * aarch32-tdep.h: New file.
4166         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4167         Call aarch32_read_description.
4168         * arch/aarch32.c: New file.
4169         * arch/aarch32.h: New file.
4170         * arch/arm.c (arm_create_target_description)
4171         (arm_create_mprofile_target_description): New function.
4172         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4173         (arm_create_target_description)
4174         (arm_create_mprofile_target_description): New declaration.
4175         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4176         read_description functions.
4177         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4178         Likewise.
4179         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4180         * arm-tdep.c (tdesc_arm_list): New variable.
4181         (arm_register_g_packet_guesses): Call create description functions.
4182         (arm_read_description) (arm_read_mprofile_description): New
4183         function.
4184         * arm-tdep.h (arm_read_description)
4185         (arm_read_mprofile_description): Add declaration.
4186         * configure.tgt: Add new files.
4187
4188 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4189
4190         * top.c (new_ui_command): Open specified terminal just once.
4191
4192 2019-07-18  Tom Tromey  <tromey@adacore.com>
4193
4194         * symtab.c (main_name): Constify return type.
4195         * symfile.c (set_initial_language): Update.
4196         * symtab.h (main_name): Constify return type.
4197
4198 2019-07-17  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-winsource.c (tui_update_source_window)
4201         (tui_update_source_window_as_is)
4202         (tui_update_source_windows_with_line): Remove return.
4203         * tui/tui-disasm.c (tui_show_disassem)
4204         (tui_show_disassem_and_update_source): Remove return.
4205         * tui/tui.c (tui_reset): Remove return.
4206         * tui/tui-wingeneral.c
4207         (tui_check_and_display_highlight_if_needed): Remove return.
4208
4209 2019-07-17  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4212
4213 2019-07-17  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-winsource.h (struct tui_exec_info_window)
4216         (struct tui_source_window_base): Move from tui-data.h.
4217         * tui/tui-winsource.c: Move many method definitions from
4218         elsewhere.  Remove "structuring" comments.
4219         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4220         (tui_source_window_base::refresh_window): Move to
4221         tui-winsource.c.
4222         * tui/tui-win.c (tui_source_window_base::refresh_all)
4223         (tui_source_window_base::update_tab_width)
4224         (tui_source_window_base::set_new_height)
4225         (tui_source_window_base::do_make_visible_with_new_height): Move to
4226         tui-winsource.c.
4227         * tui/tui-source.h: Update.
4228         * tui/tui-source.c (tui_source_window_base::reset): Move to
4229         tui-winsource.c.
4230         * tui/tui-disasm.h: Update.
4231         * tui/tui-data.h (struct tui_exec_info_window): Move to
4232         tui-winsource.h.
4233         (struct tui_source_window_base): Likewise.
4234         * tui/tui-data.c (tui_source_window_base::clear_detail)
4235         (tui_source_window_base, ~tui_source_window_base): Move to
4236         tui-winsource.c.
4237
4238 2019-07-17  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-win.c (tui_resize_all)
4241         (tui_source_window_base::update_tab_width)
4242         (tui_adjust_win_heights): Update.
4243         (tui_win_info::make_invisible_and_set_new_height): Rename from
4244         make_invisible_and_set_new_height.
4245         * tui/tui-data.h (struct tui_win_info)
4246         <make_invisible_and_set_new_height>: New method.
4247
4248 2019-07-17  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui.c: Update.
4251         * tui/tui-source.h (struct tui_source_window): Move from
4252         tui-data.h.
4253         * tui/tui-layout.c: Update.
4254         * tui/tui-disasm.c: Update.
4255         * tui/tui-data.h (struct tui_source_window): Move to
4256         tui-source.h.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4261         tui-data.h.
4262         * tui/tui-data.h (struct tui_disasm_window): Move to
4263         tui-disasm.h.
4264
4265 2019-07-17  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-regs.h (struct tui_data_item_window): Move from
4268         tui-data.h.
4269         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4270         * tui/tui-data.h (struct tui_data_item_window): Move to
4271         tui-regs.h.
4272         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4273
4274 2019-07-17  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui.c: Update.
4277         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4278         (tui_cmd_window::max_height): Move to tui-command.c.
4279         * tui/tui-layout.c: Update.
4280         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4281         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4282         tui-command.c.
4283         * tui/tui-command.h (struct tui_cmd_window): Move from
4284         tui-data.h.
4285         * tui/tui-command.c: Remove "structuring" comments.
4286         (tui_cmd_window::clear_detail)
4287         (tui_cmd_window::do_make_visible_with_new_height)
4288         (tui_cmd_window::max_height): Move from elsewhere.
4289
4290 2019-07-17  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4293         Now static.
4294         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4295         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4296
4297 2019-07-17  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui.c: Update.
4300         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4301         tui-regs.c.
4302         * tui/tui-windata.h: Remove file.
4303         * tui/tui-windata.c: Remove file.
4304         * tui/tui-win.c (tui_data_window::set_new_height)
4305         (tui_data_window::do_make_visible_with_new_height): Move to
4306         tui-regs.c.
4307         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4308         * tui/tui-regs.c: Remove "structuring" comments.
4309         (tui_data_window::first_data_item_displayed)
4310         (tui_data_window::delete_data_content_windows)
4311         (tui_data_window::erase_data_content)
4312         (tui_data_window::display_all_data)
4313         (tui_data_window::refresh_all)
4314         (tui_data_window::do_scroll_vertical)
4315         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4316         (tui_data_window::do_make_visible_with_new_height)
4317         (tui_data_window::refresh_window): Move from elsewhere.
4318         (_initialize_tui_regs): Move to end of file.
4319         * tui/tui-layout.c: Update.
4320         * tui/tui-hooks.c: Update.
4321         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4322         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4323         tui-regs.c.
4324         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4325
4326 2019-07-17  Tom Tromey  <tom@tromey.com>
4327
4328         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4329         seen.
4330
4331 2019-07-17  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-win.c (tui_source_window_base::set_new_height)
4334         (tui_source_window_base::do_make_visible_with_new_height): Use
4335         m_has_locator field directly.
4336         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4337         method.
4338         (struct tui_source_window_base) <has_locator>: Likewise.
4339
4340 2019-07-17  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4343         Don't declare.
4344         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4345         Remove.
4346         * tui/tui-win.c (tui_source_window_base::set_new_height)
4347         (tui_source_window_base::set_new_height)
4348         (make_invisible_and_set_new_height)
4349         (tui_source_window_base::do_make_visible_with_new_height)
4350         (tui_source_window_base::do_make_visible_with_new_height):
4351         Update.
4352         * tui/tui-layout.c (show_source_disasm_command, show_data)
4353         (show_source_or_disasm_and_command): Update.
4354         * tui/tui-layout.c (show_layout): Update.
4355
4356 2019-07-17  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui-layout.c (make_data_window): Remove.
4359         (show_data): Unify creation and re-initialization cases.
4360
4361 2019-07-17  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-layout.c (make_source_window, make_disasm_window):
4364         Remove.
4365         (show_data): Unify creation and re-initialization cases.
4366
4367 2019-07-17  Tom Tromey  <tom@tromey.com>
4368
4369         * tui/tui-layout.c (make_command_window): Remove.
4370         (show_source_disasm_command, show_source_or_disasm_and_command):
4371         Unify creation and re-initialization cases.
4372
4373 2019-07-17  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4376         creation and re-initialization cases.
4377
4378 2019-07-17  Tom Tromey  <tom@tromey.com>
4379
4380         * tui/tui-regs.c (tui_get_register): Return void.
4381
4382 2019-07-17  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4385         Simplify.
4386
4387 2019-07-17  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4390         resetting.
4391
4392 2019-07-17  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4395         * tui/tui-regs.c (tui_reg_layout): New function.
4396         (tui_show_registers, tui_reg_command): Use it.
4397         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4398         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4399         parameters.
4400         (tui_layout_command): Remove.
4401
4402 2019-07-17  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-layout.h (tui/tui-layout): Return void.
4405         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4406
4407 2019-07-17  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-layout.c (show_source_disasm_command, show_data):
4410         Update.
4411         (reset_locator): Remove.
4412         (show_source_or_disasm_and_command): Update.
4413
4414 2019-07-17  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-source.c (tui_source_window_base::reset): Remove
4417         win_type parameter.
4418         * tui/tui-layout.c (make_command_window, make_source_window)
4419         (make_disasm_window, make_data_window)
4420         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4421         (reset_locator, show_source_or_disasm_and_command): Update.
4422         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4423         win_type parameter.
4424         (struct tui_source_window_base) <reset>: Likewise.
4425
4426 2019-07-17  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-layout.c (show_source_disasm_command): Use
4429         reset_locator.
4430         (reset_locator): New function.
4431         (init_and_make_win): Remove.
4432         (show_source_or_disasm_and_command): Use reset_locator.
4433
4434 2019-07-17  Tom Tromey  <tom@tromey.com>
4435
4436         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4437         condition.
4438         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4439         Remove condition.
4440         * tui/tui-source.c (tui_source_window_base::reset): New method.
4441         * tui/tui-layout.c (make_command_window): Don't call
4442         init_and_make_win.
4443         (make_source_window, make_disasm_window): Don't call
4444         make_source_or_disasm_window.
4445         (make_data_window): Don't call init_and_make_win.  Change calling
4446         convention.
4447         (show_source_disasm_command, show_data): Simplify.
4448         (make_source_or_disasm_window): Remove.
4449         (show_source_or_disasm_and_command): Simplify.
4450         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4451         (struct tui_source_window_base) <reset>: Likewise.
4452         <execution_info>: Remove initializer.
4453         * tui/tui-data.c (tui_source_window_base): Initialize
4454         execution_info.
4455
4456 2019-07-17  Tom Tromey  <tom@tromey.com>
4457
4458         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4459         variable.
4460
4461 2019-07-17  Tom Tromey  <tom@tromey.com>
4462
4463         * tui/tui.c (tui_rl_other_window): Update.
4464         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4465         superclass method first.  Always iterate over regs_content.
4466         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4467         method.
4468         * tui/tui-win.c (tui_set_focus_command): Update.
4469
4470 2019-07-17  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-win.c (tui_set_focus_command): Rename from
4473         tui_set_focus.  Call tui_enable.
4474         (tui_set_focus_command): Remove.
4475
4476 2019-07-17  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4479         refresh_window.
4480         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4481         touchwin.
4482         (tui_data_window::refresh_window): Call refresh_window on data
4483         items.  Always call superclass refresh_window.
4484         (tui_win_info::refresh): Remove.
4485         (tui_source_window_base::refresh_window): Update.
4486         (tui_refresh_all): Update.
4487         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4488         refresh_window.
4489         (show_source_or_disasm_and_command): Likewise.
4490         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4491         (struct tui_source_window_base) <refresh>: Likewise.
4492
4493 2019-07-17  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-winsource.c (tui_clear_source_content)
4496         (tui_show_source_content): Update.
4497         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4498         whether content is empty.
4499         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4500         Remove.
4501
4502 2019-07-17  Tom Tromey  <tom@tromey.com>
4503
4504         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4505         window's contents.
4506         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4507         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4508
4509 2019-07-17  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4512         (struct tui_data_item_window): Update.
4513
4514 2019-07-17  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4517         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4518         defines.
4519
4520 2019-07-17  Tom Tromey  <tom@tromey.com>
4521
4522         * tui/tui-winsource.h (tui_erase_source_content)
4523         (tui_clear_source_content): Remove "display_prompt" parameter.
4524         * tui/tui-winsource.c (tui_update_source_window_as_is)
4525         (tui_update_source_windows_with_addr): Update.
4526         (tui_clear_source_content): Remove "display_prompt" parameter.
4527         (tui_erase_source_content): Likewise.  Simplify.
4528         (tui_show_source_content): Update.
4529         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4530         * tui/tui-stack.c (tui_show_frame_info): Update.
4531         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4532         Remove defines.
4533
4534 2019-07-17  Tom Tromey  <tom@tromey.com>
4535
4536         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4537         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4538         parameter.
4539         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4540         parameter.
4541
4542 2019-07-17  Tom Tromey  <tom@tromey.com>
4543
4544         * tui/tui-winsource.c (tui_clear_source_content)
4545         (tui_show_source_content, tui_show_exec_info_content)
4546         (tui_clear_exec_info_content): Update.
4547         * tui/tui-stack.c (tui_show_locator_content): Update.
4548         (tui_show_frame_info): Update.
4549         * tui/tui-source.h (tui_source_window): Don't declare.
4550         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4551         from tui_source_is_displayed.
4552         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4553         Remove field.
4554         (struct tui_source_window_base) <content_in_use>: New field.  Now
4555         bool.
4556         (struct tui_source_window) <showing_source_p>: New method.
4557         (TUI_SRC_WIN): Change cast.
4558         * tui/tui-data.c (tui_initialize_static_data): Update.
4559
4560 2019-07-17  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4563         location_matches_p.
4564         * tui/tui-source.c (tui_source_window::location_matches_p): New
4565         method.
4566         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4567         method.
4568         * tui/tui-data.h (struct tui_source_window_base)
4569         <location_matches_p>: New method.
4570         (struct tui_source_window, struct tui_disasm_window)
4571         <location_matches_p>: Likewise.
4572
4573 2019-07-17  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui-win.c (tui_set_win_height_command): Rename from
4576         tui_set_win_height.
4577         (tui_set_win_height_command): Remove.
4578
4579 2019-07-17  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-source.c (tui_source_window): New constructor.  Add
4582         observer.
4583         (~tui_source_window): New destructor.
4584         (tui_source_window::style_changed): New method.
4585         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4586         (tui_attach_detach_observers): Update.
4587         * tui/tui-data.h (struct tui_source_window): Make constructor not
4588         inline.  Add destructor.
4589         (struct tui_source_window) <style_changed>: New method.
4590         <m_observable>: New member.
4591
4592 2019-07-17  Tom Tromey  <tom@tromey.com>
4593
4594         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4595         * tui/tui-win.c (tui_resize_all): Fix typo.
4596
4597 2019-07-17  Tom Tromey  <tom@tromey.com>
4598
4599         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4600         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4601         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4602         * tui/tui-win.c (window_name_completer): Use foreach.
4603         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4604         (update_tab_width): Likewise.
4605         * tui/tui-layout.c (show_layout): Update.
4606         * tui/tui-data.h (class tui_window_iterator): New.
4607         (struct all_tui_windows): New.
4608         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4609
4610 2019-07-17  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4613         parameter.  Don't reference globals.
4614         (tui_reg_command): Update.
4615
4616 2019-07-17  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-regs.c (tui_show_registers): Simplify.
4619
4620 2019-07-17  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-regs.c (tui_show_registers): Update.
4623         (tui_show_register_group): Add win_info parameter.
4624
4625 2019-07-17  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4628         Rename from tui_display_reg_element_at_line.
4629         (tui_data_window::display_registers_from_line): Update.
4630         * tui/tui-data.h (struct tui_data_window)
4631         <display_reg_element_at_line>: New method.
4632
4633 2019-07-17  Tom Tromey  <tom@tromey.com>
4634
4635         * tui/tui-regs.h (tui_display_registers_from)
4636         (tui_display_registers_from_line): Don't declare.
4637         * tui/tui-windata.c (tui_data_window::display_all_data)
4638         (tui_data_window::refresh_all)
4639         (tui_data_window::do_scroll_vertical): Update.
4640         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4641         from tui_display_registers_from.
4642         (tui_display_reg_element_at_line): Update.
4643         (tui_data_window::display_registers_from_line): Rename from
4644         tui_display_registers_from_line.
4645         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4646         display_registers_from_line>: New methods.
4647
4648 2019-07-17  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4651         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4652         from tui_erase_data_content.
4653         (tui_data_window::display_all_data)
4654         (tui_data_window::refresh_all)
4655         (tui_data_window::do_scroll_vertical): Update.
4656         * tui/tui-regs.c (tui_show_registers): Update.
4657         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4658         New method.
4659
4660 2019-07-17  Tom Tromey  <tom@tromey.com>
4661
4662         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4663         declare.
4664         * tui/tui-windata.c
4665         (tui_data_window::delete_data_content_windows): Rename from
4666         tui_delete_data_content_windows.
4667         (tui_data_window::display_all_data)
4668         (tui_data_window::do_scroll_vertical): Update.
4669         * tui/tui-data.h (struct tui_data_window)
4670         <delete_data_content_windows>: New method.
4671
4672 2019-07-17  Tom Tromey  <tom@tromey.com>
4673
4674         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4675         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4676
4677 2019-07-17  Tom Tromey  <tom@tromey.com>
4678
4679         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4680         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4681         from tui_display_all_data.
4682         * tui/tui-win.c
4683         (tui_data_window::do_make_visible_with_new_height): Update.
4684         * tui/tui-regs.c (tui_show_registers): Update.
4685         * tui/tui-layout.c (tui_set_layout): Update.
4686         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4687         method.
4688
4689 2019-07-17  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4692         * tui/tui-windata.c (tui_display_data_from): Remove.
4693         (tui_data_window::refresh_all): Update.
4694
4695 2019-07-17  Tom Tromey  <tom@tromey.com>
4696
4697         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4698         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4699         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4700         tui_display_registers_from_line.
4701         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4702         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4703         "force_display" parameter.
4704
4705 2019-07-17  Tom Tromey  <tom@tromey.com>
4706
4707         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4708         declare.
4709         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4710         Rename from tui_first_reg_element_no_inline.
4711         (tui_display_reg_element_at_line)
4712         (tui_display_registers_from_line): Update.
4713         * tui/tui-data.h (struct tui_data_window)
4714         <first_reg_element_no_inline>: New method.
4715
4716 2019-07-17  Tom Tromey  <tom@tromey.com>
4717
4718         * tui/tui-windata.c (tui_display_data_from)
4719         (tui_data_window::do_scroll_vertical): Update.
4720         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4721         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4722         Rename from tui_line_from_reg_element_no.
4723         (tui_display_registers_from_line): Update.
4724         * tui/tui-data.h (struct tui_data_window)
4725         <line_from_reg_element_no>: New method.
4726
4727 2019-07-17  Tom Tromey  <tom@tromey.com>
4728
4729         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4730         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4731         tui_last_regs_line_no.
4732         (tui_display_reg_element_at_line)
4733         (tui_display_registers_from_line): Update.
4734         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4735         method.
4736
4737 2019-07-17  Tom Tromey  <tom@tromey.com>
4738
4739         PR tui/24722:
4740         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4741         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4742         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4743         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4744         (tui_update_breakpoint_info): Likewise.
4745         * tui/tui-hooks.c (tui_event_create_breakpoint)
4746         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4747         Update.
4748
4749 2019-07-17  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4752
4753 2019-07-17  Tom Tromey  <tom@tromey.com>
4754
4755         * tui/tui-winsource.c (tui_update_source_window_as_is)
4756         (tui_update_source_windows_with_addr): Update.
4757         * tui/tui-source.h (tui_set_source_content)
4758         (tui_show_symtab_source): Add "win_info" parameter.
4759         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4760         parameter.
4761         (tui_show_symtab_source): Likewise.
4762
4763 2019-07-17  Tom Tromey  <tom@tromey.com>
4764
4765         * tui/tui-wingeneral.c
4766         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4767
4768 2019-07-17  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4771         (struct tui_cmd_window) <can_scroll>: New method.
4772         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4773         method.
4774
4775 2019-07-17  Tom Tromey  <tromey@adacore.com>
4776
4777         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4778         do_field_signed>: Rename.  Change type of "value".
4779         * ui-out.c (ui_out::field_signed): Rename from field_int.
4780         Change type of "value".
4781         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4782         type of "value".
4783         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4784         do_field_int.  Change type of "value".
4785         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4786         do_field_int.  Change type of "value".
4787         * tracepoint.c (trace_status_mi, tfind_1)
4788         (print_one_static_tracepoint_marker): Update.
4789         * thread.c (print_thread_info_1, print_selected_thread_frame):
4790         Update.
4791         * stack.c (print_frame, print_frame_info): Update.
4792         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4793         Update.
4794         * source.c (print_source_lines_base): Update.
4795         * skip.c (info_skip_command): Update.
4796         * record-btrace.c (btrace_ui_out_decode_error)
4797         (btrace_call_history_src_line): Update.
4798         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4799         Update.
4800         * progspace.c (print_program_space): Update.
4801         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4802         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4803         do_field_int.  Change type of "value".
4804         * mi/mi-out.c (mi_ui_out::do_table_begin)
4805         (mi_ui_out::do_table_header): Update.
4806         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4807         type of "value".
4808         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4809         (mi_cmd_data_list_changed_registers, output_register)
4810         (mi_cmd_data_read_memory, mi_load_progress)
4811         (mi_cmd_trace_frame_collected): Update.
4812         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4813         Update.
4814         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4815         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4816         (mi_cmd_var_list_children, varobj_update_one): Update.
4817         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4818         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4819         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4820         * inferior.c (print_inferior): Update.
4821         * gdb_bfd.c (print_one_bfd): Update.
4822         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4823         Update.
4824         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4825         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4826         do_field_int.  Change type of "value".
4827         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4828         do_field_int.  Change type of "value".
4829         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4830         (print_one_breakpoint_location, print_it_catch_fork)
4831         (print_one_catch_fork, print_it_catch_vfork)
4832         (print_one_catch_vfork, print_it_catch_solib)
4833         (print_it_catch_exec, print_it_ranged_breakpoint)
4834         (print_mention_watchpoint, print_mention_masked_watchpoint)
4835         (bkpt_print_it, update_static_tracepoint): Update.
4836         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4837         * break-catch-syscall.c (print_it_catch_syscall): Update.
4838         * ada-tasks.c (print_ada_task_info): Update.
4839         * ada-lang.c (print_it_exception, print_mention_exception):
4840         Update.
4841
4842 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         PR breakpoints/24541
4845         * gdbarch.c: Regenerate.
4846         * gdbarch.h: Regenerate.
4847         * gdbarch.sh: Adjust return type and parameter types for
4848         'stap_adjust_register'.
4849         (i386_stap_adjust_register): Adjust signature and return new
4850         register name.
4851         * stap-probe.c (stap_parse_register_operand): Adjust use of
4852         'gdbarch_stap_adjust_register'.
4853
4854 2019-07-17  Tom Tromey  <tromey@adacore.com>
4855
4856         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4857         declare VEC.
4858         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4859         std::vector.
4860         (struct s390_process_info): Add initializers.
4861         (s390_add_process): Use new.
4862         (s390_linux_nat_target::low_forget_process): Use delete.
4863         (s390_linux_nat_target::low_new_fork)
4864         (s390_linux_nat_target::stopped_by_watchpoint)
4865         (s390_linux_nat_target::low_prepare_to_resume)
4866         (s390_linux_nat_target::insert_watchpoint)
4867         (s390_linux_nat_target::insert_hw_breakpoint)
4868         (s390_linux_nat_target::remove_watchpoint)
4869         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4870
4871 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4872
4873         * aarch64-fbsd-nat.c: Include regcache.h.
4874         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4875         argument.
4876         (aarch64_fbsd_nat_target::fetch_registers)
4877         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4878         variable.
4879         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4880
4881 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4882
4883         * fbsd-nat.c: Include gdbarch.h.
4884
4885 2019-07-15  Tom Tromey  <tromey@adacore.com>
4886
4887         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4888
4889 2019-07-15  Tom Tromey  <tromey@adacore.com>
4890
4891         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4892         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4893         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4894         * cli-out.c (cli_ui_out::do_field_int): New method.
4895         * ui-out.c (ui_out::field_unsigned): New method.
4896         * symfile.c (generic_load): Use field_unsigned.
4897         (print_transfer_performance): Likewise.
4898         * record-btrace.c (ui_out_field_uint): Remove.
4899         (btrace_call_history_insn_range, btrace_call_history): Use
4900         field_unsigned.
4901         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4902         field_unsigned.
4903         * ui-out.h (class ui_out) <field_unsigned>: New method.
4904         <do_field_unsigned>: Likewise.
4905
4906 2019-07-15  Tom Tromey  <tromey@adacore.com>
4907
4908         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4909         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4910         * target.c (flash_erase_command): Use field_string.
4911         * infrun.c (print_signal_received_reason): Use field_string.
4912         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4913         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4914         field_string.
4915         * ada-tasks.c (print_ada_task_info): Use field_string.
4916
4917 2019-07-15  Tom Tromey  <tromey@adacore.com>
4918
4919         * target.c (flash_erase_command): Use field_core_addr.
4920         * symfile.c (generic_load): Use field_core_addr.
4921         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4922         Use field_core_addr.
4923         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4924         field_core_addr.
4925
4926 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4929         value if its desired type is smaller than a CORE_ADDR and signed.
4930
4931 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4934         of changes to field names, and use new is_reference field to
4935         decide if a property is a reference or not.
4936         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4937         field.
4938         (struct dwarf2_property_baton): Update header comment, rename
4939         'referenced_type' to 'property_type' and update comments.
4940         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4941         default property type, store in property baton, update to take
4942         accound of renamed field.
4943         (read_func_scope): Update call to attr_to_dynamic_prop.
4944         (read_array_type): Likewise.
4945         (dwarf2_per_cu_addr_sized_int_type): New function.
4946         (read_subrange_index_type): Move type finding code to
4947         dwarf2_per_cu_addr_sized_int_type.
4948         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4949         (dwarf2_per_cu_addr_type): New function.
4950         (set_die_type): Update calls to attr_to_dynamic_prop.
4951
4952 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * dwarf2read.c (read_subrange_index_type): New function.
4955         (read_subrange_type): Move code into new function and call it.
4956         * gdbtypes.c (create_range_type): Add some asserts.
4957
4958 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4961         update return statements.
4962         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4963         declaration, and update comment to match.
4964         * gdbtypes.c (resolve_dynamic_array): Update call to
4965         dwarf2_evaluate_property to match new return type.
4966
4967 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * valarith.c (value_subscripted_rvalue): Change lowerbound
4970         parameter type from int to LONGEST.
4971         * value.h (value_subscripted_rvalue): Likewise in declaration.
4972
4973 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * cli/cli-utils.c (info_print_command_completer): New function.
4976         * cli/cli-utils.h: Add 'completer.h' include, and forward
4977         declaration for 'struct cmd_list_element'.
4978         (info_print_command_completer): Declare.
4979         * stack.c (_initialize_stack): Add completer for 'info locals' and
4980         'info args'.
4981         * symtab.c (_initialize_symtab): Add completer for 'info
4982         variables' and 'info functions'.
4983         * NEWS: Mention completion for additional info commands.
4984
4985 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * cli/cli-utils.c (extract_info_print_args): Delete.
4988         (extract_arg_maybe_quoted): Delete.
4989         (info_print_options_defs): New variable.
4990         (make_info_print_options_def_group): New function.
4991         (extract_info_print_options): Define new function.
4992         * cli/cli-utils.h (extract_info_print_args): Delete.
4993         (struct info_print_options): New structure.
4994         (extract_info_print_options): Declare new function.
4995         * stack.c (info_locals_command): Update to use new
4996         extract_info_print_options, also add a header comment.
4997         (info_args_command): Likewise.
4998         * symtab.c (info_variables_command): Likewise.
4999         (info_functions_command): Likewise.
5000
5001 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5002
5003         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5004         to extract string arguments.
5005         * common/common-utils.c (extract_string_maybe_quoted): New function.
5006         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5007
5008 2019-07-11  Tom Tromey  <tromey@adacore.com>
5009
5010         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5011         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5012         * top.h (gdbinit): Don't declare.
5013         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5014         into...
5015         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5016         * top.c (gdb_init): Don't call init_cli_cmds.
5017         (gdbinit): Remove.
5018         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5019
5020 2019-07-11  Tom Tromey  <tromey@adacore.com>
5021
5022         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5023         after it has been moved.
5024
5025 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5026
5027         * valops.c (value_must_coerce_to_target): Change return type to
5028         bool.
5029         * value.h (value_must_coerce_to_target): Likewise.
5030
5031 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5032
5033         * breakpoint.c (is_hardware_watchpoint): Remove
5034         forward-declaration.
5035         (is_masked_watchpoint): Change return type to bool.
5036         (is_tracepoint): Likewise.
5037         (is_breakpoint): Likewise.
5038         (is_hardware_watchpoint): Likewise.
5039         (is_watchpoint): Likewise.
5040         (is_no_memory_software_watchpoint): Likewise.
5041         (is_catchpoint): Likewise.
5042         (breakpoint_1): Make FILTER parameter's return type bool.
5043         is_masked_watchpoint): Change return type to bool.
5044         (save_breakpoints): Make FILTER parameter's return type bool.
5045         * breakpoint.h (is_breakpoint): Change return type to bool.
5046         (is_watchpoint): Likewise.
5047         (is_catchpoint): Likewise.
5048         (is_tracepoint): Likewise.
5049
5050 2019-07-10  Tom Tromey  <tom@tromey.com>
5051
5052         * defs.h: Don't include gdbarch.h.
5053         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5054         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5055         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5056         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5057         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5058         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5059         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5060         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5061         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5062         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5063         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5064         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5065         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5066         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5067         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5068         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5069         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5070         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5071         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5072         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5073         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5074         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5075         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5076         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5077         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5078         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5079         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5080
5081 2019-07-10  Tom Tromey  <tromey@adacore.com>
5082
5083         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5084         * breakpoint.c (init_ada_exception_breakpoint): Register as
5085         bp_catchpoint.
5086         (print_one_breakpoint_location, print_one_breakpoint): Use
5087         is_ada_exception_catchpoint.
5088         * ada-lang.c (class ada_catchpoint_location): Pass
5089         bp_loc_software_breakpoint to bp_location constructor.
5090         (is_ada_exception_catchpoint): New function.
5091
5092 2019-07-10  Tom Tromey  <tromey@adacore.com>
5093
5094         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5095         VEC.
5096         (struct arm_exidx_entry): New method operator<.
5097         (struct arm_exidx_data) <section_maps>: Change type.
5098         (arm_exidx_data_free): Remove.
5099         (arm_exidx_data_key): Change type.  Move lower.
5100         (arm_exidx_new_objfile): Update.
5101         (arm_compare_exidx_entries): Remove.
5102         (arm_find_exidx_entry, _initialize_arm_tdep)
5103
5104 2019-07-10  Tom Tromey  <tromey@adacore.com>
5105
5106         * solib-spu.c (ocl_program_data_key): Change type.
5107         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5108         Update.
5109
5110 2019-07-10  Tom Tromey  <tromey@adacore.com>
5111
5112         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5113         (struct solib_aix_inferior_data) <library_list>: Change type.
5114         (solib_aix_inferior_data_handle): Change type.
5115         (get_solib_aix_inferior_data): Update.
5116         (solib_aix_free_library_list): Remove.
5117         (library_list_start_library): Update.
5118         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5119         return type.
5120         (solib_aix_get_library_list)
5121         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5122         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5123
5124 2019-07-10  Tom Tromey  <tromey@adacore.com>
5125
5126         * solib-dsbt.c (struct dsbt_info): Add initializers.
5127         (solib_dsbt_pspace_data): Change type.
5128         (dsbt_pspace_data_cleanup): Remove.
5129         (get_dsbt_info, _initialize_dsbt_solib): Update.
5130
5131 2019-07-10  Tom Tromey  <tromey@adacore.com>
5132
5133         * spu-tdep.c (spu_overlay_data): Change type.
5134         (spu_get_overlay_table, spu_overlay_new_objfile)
5135         (_initialize_spu_tdep): Update.
5136
5137 2019-07-10  Tom Tromey  <tromey@adacore.com>
5138
5139         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5140         destructor.
5141         (dbx_objfile_data_key): Change type and declare later.
5142         (DBX_SYMFILE_INFO): Rewrite.
5143         * dbxread.c (dbx_objfile_data_key): Change type.
5144         (dbx_symfile_init): Update.
5145         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5146         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5147         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5148
5149 2019-07-10  Tom Tromey  <tromey@adacore.com>
5150
5151         * jit.c (jit_program_space_key): Change type.  Move lower.
5152         (get_jit_program_space_data): Update.
5153         (jit_program_space_data_cleanup): Remove.
5154         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5155         Update.
5156         (struct jit_program_space_data): Add initializers.
5157
5158 2019-07-10  Tom Tromey  <tromey@adacore.com>
5159
5160         * solib-darwin.c (struct darwin_info): Add initializers.
5161         (solib_darwin_pspace_data): Change type.
5162         (darwin_pspace_data_cleanup): Remove.
5163         (get_darwin_info, _initialize_darwin_solib): Update.
5164
5165 2019-07-10  Tom Tromey  <tromey@adacore.com>
5166
5167         * remote-sim.c (struct sim_inferior_data): Add initializers,
5168         constructor, and destructor.
5169         (sim_inferior_data_key): Change type.  Move lower.
5170         (check_for_duplicate_sim_descriptor): Update.
5171         (get_sim_inferior_data): Use new.  Update.
5172         (~sim_inferior_data_cleanup): Rename from
5173         sim_inferior_data_cleanup.  Simplify.
5174         (gdbsim_close_inferior, simulator_command)
5175         (sim_command_completer, _initialize_remote_sim): Update.
5176         (next_pid, INITIAL_PID): Move earlier.
5177
5178 2019-07-10  Tom Tromey  <tromey@adacore.com>
5179
5180         * python/python-internal.h (create_thread_object): Return
5181         gdbpy_ref.
5182         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5183         * python/py-inferior.c (struct threadlist_entry): Add
5184         constructor.
5185         <thread_obj>: Now a gdbpy_ref.
5186         (thread_to_thread_object): Update.
5187         (add_thread_object): Use new.
5188         (delete_thread_object): Use delete.
5189         (infpy_threads): Update.
5190         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5191         GIL.
5192
5193 2019-07-10  Tom Tromey  <tromey@adacore.com>
5194
5195         * valops.c (value_cast): Specialize error message for Ada.
5196
5197 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5198
5199         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5200
5201 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5202
5203         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5204         bpstat_should_step): Return bool, adjust comments.
5205         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5206         bpstat_should_step): Likewise.
5207
5208 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5209
5210         * features/Makefile: Use feature target descriptions for Arm.
5211         * features/arm/arm-core.c: Generate new file.
5212         * features/arm/arm-fpa.c: Likewise.
5213         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5214         * features/arm/arm-m-profile.c: Likewise.
5215         * features/arm/arm-vfpv2.c: Likewise.
5216         * features/arm/arm-vfpv3.c: Likewise.
5217         * features/arm/xscale-iwmmxt.c: Likewise.
5218         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5219
5220 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5221
5222         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5223         ptrace earlier.
5224
5225 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5226
5227         * features/aarch64-pauth.c: Regenerate.
5228
5229 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5230
5231         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5232         bool.
5233         (bpstat_what): Use false instead of 0.
5234
5235 2019-07-09  Pedro Alves  <palves@redhat.com>
5236
5237         * break-catch-throw.c (is_exception_catchpoint): New.
5238         * breakpoint.c (print_one_breakpoint_location): New parameter
5239         'raw_loc'.  Handle it.  Use
5240         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5241         looking at the breakpoint's type.
5242         (print_one_breakpoint): If handling "maint info breakpoints", also
5243         print locations of exception catchpoints.
5244         * breakpoint.h (is_exception_catchpoint): Declare.
5245
5246 2019-07-09  Pedro Alves  <palves@redhat.com>
5247
5248         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5249         "addr" field.
5250         (allocate_location_exception_catchpoint): New.
5251         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5252         (initialize_throw_catchpoint_ops): Install
5253         allocate_location_exception_catchpoint as allocate_location
5254         method.
5255         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5256         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5257         bp_loc_other.
5258         (breakpoint_address_is_meaningful): Delete.
5259         (bl_address_is_meaningful): New.
5260         (breakpoint_locations_match): Adjust comment.
5261         (bp_location_from_bp_type): New, factored out of...
5262         (bp_location::bp_location(breakpoint *)): ... this.
5263         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5264         factored out of...
5265         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5266         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5267         breakpoint_address_is_meaningful.
5268         (bp_locations_compare): Adjust comment.
5269         (update_global_location_list): Use bl_address_is_meaningful
5270         instead of breakpoint_address_is_meaningful.
5271         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5272         explicit.
5273         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5274         * python/py-breakpoint.c (bppy_get_location): No longer check
5275         whether location is null.
5276
5277 2019-07-09  Pedro Alves  <palves@redhat.com>
5278
5279         PR c++/15468
5280         * breakpoint.c (print_one_breakpoint_location): Remove
5281         single-location assert.
5282
5283 2019-07-09  Tom Tromey  <tom@tromey.com>
5284
5285         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5286         * configure: Rebuild.
5287         * configure.ac: Change common to gdbsupport.
5288         * gdbsupport: Rename from common.
5289         * acinclude.m4: Change common to gdbsupport.
5290         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5291         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5292         gdbsupport.
5293         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5294         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5295         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5296         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5297         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5298         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5299         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5300         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5301         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5302         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5303         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5304         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5305         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5306         coff-pe-read.c, command.h, compile/compile-c-support.c,
5307         compile/compile-c.h, compile/compile-cplus-symbols.c,
5308         compile/compile-cplus-types.c, compile/compile-cplus.h,
5309         compile/compile-loc2c.c, compile/compile.c, completer.c,
5310         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5311         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5312         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5313         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5314         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5315         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5316         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5317         features/aarch64-core.c, features/aarch64-fpu.c,
5318         features/aarch64-pauth.c, features/aarch64-sve.c,
5319         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5320         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5321         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5322         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5323         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5324         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5325         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5326         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5327         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5328         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5329         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5330         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5331         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5332         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5333         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5334         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5335         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5336         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5337         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5338         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5339         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5340         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5341         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5342         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5343         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5344         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5345         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5346         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5347         minsyms.c, mips-linux-tdep.c, namespace.h,
5348         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5349         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5350         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5351         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5352         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5353         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5354         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5355         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5356         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5357         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5358         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5359         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5360         procfs.c, producer.c, progspace.h, psymtab.h,
5361         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5362         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5363         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5364         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5365         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5366         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5367         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5368         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5369         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5370         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5371         target-memory.c, target.c, target.h, target/waitstatus.c,
5372         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5373         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5374         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5375         unittests/array-view-selftests.c,
5376         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5377         unittests/common-utils-selftests.c,
5378         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5379         unittests/format_pieces-selftests.c,
5380         unittests/function-view-selftests.c,
5381         unittests/lookup_name_info-selftests.c,
5382         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5383         unittests/mkdir-recursive-selftests.c,
5384         unittests/observable-selftests.c,
5385         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5386         unittests/parse-connection-spec-selftests.c,
5387         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5388         unittests/scoped_fd-selftests.c,
5389         unittests/scoped_mmap-selftests.c,
5390         unittests/scoped_restore-selftests.c,
5391         unittests/string_view-selftests.c, unittests/style-selftests.c,
5392         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5393         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5394         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5395         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5396         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5397         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5398
5399 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5402         bool value.
5403         (decode_digits_ordinary): Set explicit_line field in sal.
5404         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5405         symtab_and_line that was set on an explicit line number in
5406         assembler code.  Do always update the recorded symtab and line if
5407         we do skip the prologue.
5408
5409 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * breakpoint.c (set_breakpoint_location_function): Remove
5412         explicit_loc parameter.
5413         (momentary_breakpoint_from_master): Update call to
5414         set_breakpoint_location_function.
5415         (add_location_to_breakpoint): Likewise.
5416
5417 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5418
5419         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5420         required features based on default bfd type when no specific bfd
5421         is present.
5422
5423 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5424
5425         * NEWS: Mention that GDB printf and eval commands can now print
5426         C-style and Ada-style convenience var strings without
5427         calling the inferior.
5428         * printcmd.c (printf_c_string): Locally print GDB internal var
5429         instead of transiting via the inferior.
5430         (printf_wide_c_string): Likewise.
5431
5432 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5433
5434         PR breakpoints/25011
5435         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5436
5437 2019-07-04  Tom Tromey  <tom@tromey.com>
5438
5439         PR tui/24724:
5440         * tui/tui-winsource.c (tui_clear_source_content): Update.
5441         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5442         (tui_update_breakpoint_info): Update.
5443         (tui_set_exec_info_content): Update.
5444         * tui/tui-source.c (tui_set_source_content_nil): Update.
5445         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5446         has_break.
5447         * tui/tui-data.h (enum tui_bp_flag): New.
5448         (tui_bp_flags): New enum flags type.
5449         (struct tui_source_element) <break_mode>: Change type.  Rename
5450         from has_break.
5451         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5452         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5453         constants.
5454         * tui/tui-winsource.h: Fix comment.
5455
5456 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5457
5458         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5459         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5460         (store_fpregs_to_thread)
5461         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5462         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5463         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5464         (IWMMXT_REGS_SIZE): Add define.
5465         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5466         (fetch_vfp_regs, store_vfp_regs)
5467         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5468         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5469
5470 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5471
5472         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5473         defines.
5474         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5475         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5476         (ARM_INT_REGISTER_SIZE): ...to this.
5477         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5478         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5479         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5480         (arm_linux_collect_gregset, supply_nwfpe_register)
5481         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5482         defines.
5483         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5484         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5485         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5486         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5487         (arm_return_in_memory, arm_store_return_value)
5488         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5489         (arm_record_ld_st_multiple): Likewise.
5490         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5491         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5492
5493 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5494
5495         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5496         AARCH64_DISPLACED_MODIFIED_INSNS.
5497         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5498         (aarch64_displaced_step_copy_insn): Likewise.
5499         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5500         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5501         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5502         ARM_DISPLACED_MODIFIED_INSNS.
5503         * arm-tdep.c (arm_gdbarch_init): Likewise.
5504         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5505         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5506         (struct arm_displaced_step_closure): Use
5507         ARM_DISPLACED_MODIFIED_INSNS.
5508
5509 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5510
5511         * features/Makefile: Remove unused xml files.
5512         * features/aarch64.xml: Remove.
5513         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5514         * features/i386/amd64-avx-avx512.xml: Remove.
5515         * features/i386/amd64-avx-linux.xml: Remove.
5516         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5517         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5518         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5519         * features/i386/amd64-avx-mpx.xml: Remove.
5520         * features/i386/amd64-avx.xml: Remove.
5521         * features/i386/amd64-linux.xml: Remove.
5522         * features/i386/amd64-mpx-linux.xml: Remove.
5523         * features/i386/amd64-mpx.xml: Remove.
5524         * features/i386/amd64.xml: Remove.
5525         * features/i386/i386-avx-avx512-linux.xml: Remove.
5526         * features/i386/i386-avx-avx512.xml: Remove.
5527         * features/i386/i386-avx-linux.xml: Remove.
5528         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5529         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5530         * features/i386/i386-avx-mpx-linux.xml: Remove.
5531         * features/i386/i386-avx-mpx.xml: Remove.
5532         * features/i386/i386-avx.xml: Remove.
5533         * features/i386/i386-linux.xml: Remove.
5534         * features/i386/i386-mmx-linux.xml: Remove.
5535         * features/i386/i386-mmx.xml: Remove.
5536         * features/i386/i386-mpx-linux.xml: Remove.
5537         * features/i386/i386-mpx.xml: Remove.
5538         * features/i386/i386.xml: Remove.
5539         * features/i386/x32-avx-avx512-linux.xml: Remove.
5540         * features/i386/x32-avx-linux.xml: Remove.
5541         * features/i386/x32-linux.xml: Remove.
5542
5543 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5544
5545         * regformats/aarch64.dat: Remove.
5546         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5547         * regformats/i386/amd64-avx-linux.dat: Remove.
5548         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5549         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5550         * regformats/i386/amd64-linux.dat: Remove.
5551         * regformats/i386/amd64-mpx-linux.dat: Remove.
5552         * regformats/i386/amd64.dat: Remove.
5553         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5554         * regformats/i386/i386-avx-linux.dat: Remove.
5555         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5556         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5557         * regformats/i386/i386-linux.dat: Remove.
5558         * regformats/i386/i386-mmx-linux.dat: Remove.
5559         * regformats/i386/i386-mpx-linux.dat: Remove.
5560         * regformats/i386/i386.dat: Remove.
5561         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5562         * regformats/i386/x32-avx-linux.dat: Remove.
5563         * regformats/i386/x32-linux.dat: Remove.
5564
5565 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5566
5567         * aarch64-tdep.c: Remove xml self tests.
5568         * amd64-linux-tdep.c: Likewise.
5569         * amd64-tdep.c: Likewise.
5570         * i386-linux-tdep.c: Likewise.
5571         * i386-tdep.c: Likewise.
5572
5573 2019-07-03  Pedro Alves  <palves@redhat.com>
5574
5575         PR cli/24732
5576         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5577         (pipe_cmd_option_defs): New.
5578         (make_pipe_cmd_options_def_group): New.
5579         (pipe_command): Use gdb::option::process_options.
5580         (pipe_command_completer): New function.
5581         (_initialize_cli_cmds): Install completer for "pipe" command.
5582
5583 2019-07-03  Pedro Alves  <palves@redhat.com>
5584
5585         * cli/cli-option.c (union option_value) <string>: New field.
5586         (struct option_def_and_value): Add ctor, move ctor, dtor and
5587         use DISABLE_COPY_AND_ASSIGN.
5588         (option_def_and_value::clear_value): New.
5589         (parse_option, save_option_value_in_ctx, get_val_type_str)
5590         (add_setshow_cmds_for_options): Handle var_string.
5591         * cli-option.h (union option_def::var_address) <string>: New
5592         field.
5593         (struct string_option_def): New.
5594         * maint-test-options.c (struct test_options_opts): Add default
5595         ctor and use DISABLE_COPY_AND_ASSIGN.
5596         <string_opt>: New field.
5597         (test_options_opts::~test_options_opts): New.
5598         (test_options_opts::dump): Also dump "-string".
5599         (test_options_option_defs): Install "string.
5600
5601 2019-07-03  Pedro Alves  <palves@redhat.com>
5602
5603         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5604         option_value with a null enumeration.
5605         (complete_options): Save the option values in the context.
5606         (save_option_value_in_ctx): New, factored out from ...
5607         (process_options): ... here.
5608         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5609         of the function.
5610         * maint-test-options.c (test_options_opts::dump): New, factored
5611         out from ...
5612         (maintenance_test_options_command_mode): ... here.
5613         (maintenance_test_options_command_completion_result): Delete.
5614         (maintenance_test_options_command_completion_text): Update
5615         comment.
5616         (maintenance_show_test_options_completion_result): Change
5617         prototype.  Just print
5618         maintenance_test_options_command_completion_text.
5619         (save_completion_result): New.
5620         (maintenance_test_options_completer_mode): Pass options context to
5621         complete_options, and then save a dump.
5622         (_initialize_maint_test_options): Use add_cmd to install "maint
5623         show test-options-completion-result".
5624
5625 2019-07-03  Pedro Alves  <palves@redhat.com>
5626
5627         * NEWS (New commands): Mention "with" and "maint with".
5628         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5629         (with_command, with_command_completer): New.
5630         (pipe_command): Adjust to new repeat_previous
5631         interface.
5632         (_initialize_cli_cmds): Install the "with" command and its "w"
5633         alias.
5634         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5635         declarations.
5636         * cli/cli-setshow.c (parse_cli_var_uinteger)
5637         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5638         argument strings for all var_types.
5639         (get_setshow_command_value_string): New, factored out from ...
5640         (do_show_command): ... this.
5641         * cli/cli-setshow.h: Include <string>.
5642         (get_setshow_command_value_string): Declare.
5643         * command.h (repeat_previous): Now returns const char *.  Adjust
5644         comment.
5645         * maint.c: Include "cli/cli-cmds.h".
5646         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5647         (_initialize_maint_cmds): Register the "maintenance with" command.
5648         * top.c (repeat_previous): Move bits from pipe_command here:
5649         Return the saved command line, if any; error out if there's no
5650         command to relaunch.
5651
5652 2019-07-03  Pedro Alves  <palves@redhat.com>
5653
5654         * NEWS (New commands): Mention "maint set/show test-settings"
5655         instead of "maint test-settings".
5656         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5657         (maintenance_test_settings_set_list): Rename to ...
5658         (maintenance_set_test_settings_list): ... this.
5659         (maintenance_test_settings_show_list): Rename to  ...
5660         (maintenance_show_test_settings_list): ... this.
5661         (maintenance_test_settings_cmd): Delete.
5662         (maintenance_test_settings_set_cmd): ...
5663         (maintenance_set_test_settings_cmd): ... this.
5664         (maintenance_test_settings_show_cmd): ...
5665         (maintenance_show_test_settings_cmd): ... this.
5666         (maintenance_test_settings_show_value_cmd):
5667         (maintenance_show_test_settings_value_cmd): ... this.
5668         (_initialize_maint_test_settings): No longer install the "maint
5669         test-settings" prefix command.  Rename "maint test-settings set"
5670         to "maint set test-settings", and "maint test-settings show" to
5671         "maint show test-settings".  Adjust all subcommands.
5672
5673 2019-07-03  Pedro Alves  <palves@redhat.com>
5674
5675         * maint-test-settings.c: Fix file's intro comment.  Replace all
5676         references to "test-options" with references to "test-settings",
5677         in comments.
5678
5679 2019-07-03  Pedro Alves  <palves@redhat.com>
5680
5681         * maint-test-settings.c (maintenance_test_settings_xxx)
5682         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5683         New.
5684         (maintenance_test_settings_enums): Use them.
5685         (maintenance_test_settings_enum): Default to
5686         maintenance_test_settings_xxx.
5687         (_initialize_maint_test_settings): Initialize
5688         MAINTENANCE_TEST_SETTINGS_FILENAME.
5689
5690 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5691
5692         * breakpoint.h (remove_breakpoints_inf): Change return type to
5693         void, move function documentation here.
5694         * breakpoint.c (remove_breakpoints_inf): Change return type to
5695         void, move function documentation to header.
5696
5697 2019-07-02  Pedro Alves  <palves@redhat.com>
5698
5699         * NEWS (Completion improvements): Mention "info threads".
5700         * thread.c (struct info_threads_opts, info_threads_option_defs)
5701         (make_info_threads_options_def_group): New.
5702         (info_threads_command): Use gdb::option::process_options.
5703         (info_threads_command_completer): New.
5704         (_initialize_thread): Use gdb::option::build_help to build the
5705         help text for "info threads".
5706
5707 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5708
5709         * defs.h (generic_load): Move from here...
5710         * symfile.h (generic_load): ... to here.  Rename name parameter
5711         to args.
5712         * symfile.c (generic_load): Add comment.
5713
5714 2019-07-01  Tom Tromey  <tromey@adacore.com>
5715
5716         * dwarf2read.c
5717         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5718         declaration of without_params.  Fix formatting.
5719
5720 2019-07-01  Tom Tromey  <tromey@adacore.com>
5721
5722         * ada-exp.y (find_primitive_type): Update.
5723         * ada-lang.h (ada_lookup_symbol): Update.
5724         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5725         parameter.
5726         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5727
5728 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5729
5730         PR breakpoints/24541
5731         * gdbarch.c: Regenerate.
5732         * gdbarch.h: Regenerate.
5733         * gdbarch.sh: Add 'stap_adjust_register'.
5734         * i386-tdep.c: Include '<unordered_set>'.
5735         (i386_stap_adjust_register): New function.
5736         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5737         * stap-probe.c (stap_parse_register_operand): Call
5738         'gdbarch_stap_adjust_register'.
5739
5740 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5741
5742         PR python/24742
5743         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5744         * python/python.c (do_start_initialization): Use 'xmalloc'
5745         instead of 'PyMem_Malloc'.
5746
5747 2019-06-28  Tom Tromey  <tromey@adacore.com>
5748
5749         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5750         for Ada.
5751
5752 2019-06-27  Tom Tromey  <tromey@adacore.com>
5753
5754         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5755         objfile_key.
5756         (arm_find_mapping_symbol, arm_record_special_symbol)
5757         (_initialize_arm_tdep): Update.
5758         (arm_objfile_data_free): Remove.
5759
5760 2019-06-27  Tom Tromey  <tromey@adacore.com>
5761
5762         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5763         to cp_print_static_field.
5764
5765 2019-06-26  Tom Tromey  <tromey@adacore.com>
5766
5767         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5768         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5769         declare.
5770
5771 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5772
5773         * features/aarch64-core.c (create_feature_aarch64_core):
5774         Regenerate.
5775         * features/aarch64-core.xml: Add cpsr flags.
5776
5777 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5778
5779         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5780         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5781
5782 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5783
5784         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5785         field.
5786         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5787         use.
5788         (arm_record_special_symbol): Don't insert new symbol in sorted
5789         position, push it at the end.
5790
5791 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5792
5793         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5794         (arm_mapping_symbol_s): Remove.
5795         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5796         (arm_mapping_symbol_vec): New typedef.
5797         (struct arm_per_objfile): Add constructor.
5798         <section_maps>: Change type to
5799         std::unique_ptr<arm_mapping_symbol_vec[]>.
5800         (arm_compare_mapping_symbols): Remove.
5801         (arm_find_mapping_symbol): Adjust to section_maps type change.
5802         (arm_objfile_data_free): Call delete on arm_per_objfile.
5803         (arm_record_special_symbol): Adjust to section_maps type change.
5804         Allocate arm_per_objfile with new.
5805
5806 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5807
5808         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5809         with the command prefix.
5810
5811 2019-06-25  Tom Tromey  <tom@tromey.com>
5812
5813         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5814         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5815
5816 2019-06-25  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5819         type.
5820         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5821         protected.
5822
5823 2019-06-25  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-winsource.c
5826         (tui_source_window_base::set_is_exec_point_at): Add check against
5827         LOA_ADDRESS.
5828
5829 2019-06-25  Tom Tromey  <tom@tromey.com>
5830
5831         * tui/tui-source.c (tui_set_source_content): Don't check before
5832         xfree.
5833         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5834
5835 2019-06-25  Tom Tromey  <tom@tromey.com>
5836
5837         * tui/tui-winsource.h (tui_update_source_window_as_is)
5838         (tui_alloc_source_buffer, tui_line_is_displayed)
5839         (tui_addr_is_displayed): Change type of win_info.
5840         * tui/tui-winsource.c (tui_update_source_window_as_is)
5841         (tui_clear_source_content, tui_show_source_line)
5842         (tui_show_source_content, tui_source_window_base::refill)
5843         (tui_source_window_base::set_is_exec_point_at)
5844         (tui_source_window_base::set_is_exec_point_at)
5845         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5846         (tui_alloc_source_buffer, tui_line_is_displayed)
5847         (tui_addr_is_displayed): Change type of win_info.  Update.
5848         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5849         (tui_source_window_base::do_make_visible_with_new_height):
5850         Update.
5851         * tui/tui-source.c (tui_set_source_content)
5852         (tui_set_source_content_nil)
5853         (tui_source_window::do_scroll_vertical): Update.
5854         * tui/tui-layout.c (show_layout): Update.
5855         * tui/tui-disasm.c (tui_set_disassem_content)
5856         (tui_disasm_window::do_scroll_vertical): Update.
5857         * tui/tui-data.h (tui_win_content): Remove.
5858         (struct tui_gen_win_info) <content, content_size>: Remove.
5859         (struct tui_source_element): Add initializers and destructor.
5860         (union tui_which_element, struct tui_win_element): Remove.
5861         (struct tui_source_window_base) <content>: New field.
5862         (struct tui_data_window): Remove destructor.
5863         (tui_alloc_content, tui_free_win_content)
5864         (tui_free_all_source_wins_content): Don't declare.
5865         * tui/tui-data.c (tui_initialize_static_data): Update.
5866         (init_content_element, tui_alloc_content): Remove.
5867         (~tui_gen_win_info): Update.
5868         (~tui_data_window, tui_free_all_source_wins_content)
5869         (tui_free_win_content, free_content, free_content_elements):
5870         Remove.
5871
5872 2019-06-25  Tom Tromey  <tom@tromey.com>
5873
5874         * tui/tui-winsource.h (tui_clear_source_content)
5875         (tui_erase_source_content, tui_show_source_content): Change type
5876         of win_info.
5877         * tui/tui-winsource.c (tui_clear_source_content)
5878         (tui_erase_source_content, tui_show_source_content): Change type
5879         of win_info.
5880         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5881         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5882         win_info.
5883         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5884         win_info.
5885         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5886
5887 2019-06-25  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-winsource.c (tui_clear_source_content)
5890         (tui_source_window_base::set_is_exec_point_at): Update.
5891         * tui/tui-source.c (tui_set_source_content_nil): Update.
5892         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5893         a bool.
5894         * tui/tui-data.c (init_content_element): Update.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5899         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5900         * tui/tui-layout.c (init_and_make_win): Update.
5901         * tui/tui.h (enum tui_win_type): Update.
5902         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5903         tui_win_is_auxillary.
5904         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5905         tui_win_is_auxillary.
5906
5907 2019-06-25  Tom Tromey  <tom@tromey.com>
5908
5909         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5910         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5911         (tui_delete_data_content_windows, tui_display_all_data)
5912         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5913         Update.
5914         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5915         * tui/tui-regs.c (tui_last_regs_line_no)
5916         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5917         (tui_show_registers): Update.
5918         (tui_show_register_group): Return void.  Update.
5919         (tui_display_registers_from, tui_display_reg_element_at_line)
5920         (tui_display_registers_from_line, tui_check_register_values):
5921         Update.
5922         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5923         member.
5924         (struct tui_data_window) <regs_content>: Now a std::vector.
5925         <regs_content_count>: Remove.
5926         (tui_add_content_elements, tui_free_data_content): Don't declare.
5927         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5928         (init_content_element): Remove DATA_WIN case.  Add assert.
5929         (tui_add_content_elements): Remove.
5930         (tui_data_window): Update.
5931         (tui_free_data_content): Remove.
5932         (free_content_elements): Remove DATA_WIN case.
5933
5934 2019-06-25  Tom Tromey  <tom@tromey.com>
5935
5936         * tui/tui-data.c (tui_data_item_window): Update.
5937         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5938         * tui/tui-windata.c (tui_display_all_data)
5939         (tui_display_data_from_line): Update.
5940         (tui_check_data_values): Remove.
5941         * tui/tui-regs.c (tui_show_register_group)
5942         (tui_display_reg_element_at_line): Update.
5943         * tui/tui-hooks.c (tui_register_changed)
5944         (tui_refresh_frame_and_register_information): Call
5945         tui_check_register_values.
5946         * tui/tui-data.h (struct tui_data_window) <data_content,
5947         data_content_count, data_type>: Remove.
5948         (enum tui_data_type): Remove.
5949
5950         * tui/tui-data.c (tui_data_window::clear_detail)
5951         (~tui_data_window): Update.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5956         declare.
5957         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5958         Rename from tui_first_data_item_displayed.  Update.
5959         (tui_data_window::refresh_all)
5960         (tui_data_window::do_scroll_vertical): Update.
5961         * tui/tui-data.h (struct tui_data_window)
5962         <first_data_item_displayed>: Declare new method.
5963
5964 2019-06-25  Tom Tromey  <tom@tromey.com>
5965
5966         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5967         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5968         contents...
5969         (tui_initialize_static_data): ...here.
5970
5971 2019-06-25  Tom Tromey  <tom@tromey.com>
5972
5973         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5974         (tui_display_registers_from, tui_check_register_values): Update.
5975         (tui_display_register): Remove win_info parameter; update.
5976         (tui_get_register): Change type of parameters.
5977         * tui/tui-data.h (struct tui_data_element): Remove.
5978         (union tui_which_element) <data>: Remove.
5979         <data_window>: Change type.
5980         (struct tui_data_item_window): New.
5981         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5982         case.  Add assert.
5983         (~tui_data_item_window): New destructor.
5984         (free_content_elements): Remove DATA_ITEM_WIN case.
5985
5986 2019-06-25  Tom Tromey  <tom@tromey.com>
5987
5988         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5989         Remove.
5990
5991 2019-06-25  Tom Tromey  <tom@tromey.com>
5992
5993         * tui/tui-data.h (struct tui_command_element): Remove.
5994         (union tui_which_element) <command>: Remove.
5995         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5996         assert.
5997         (free_content_elements): Remove CMD_WIN case.
5998
5999 2019-06-25  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-layout.c (tui_set_layout): Update.
6002         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6003         * tui/tui-data.c (layout_def): Update.
6004
6005 2019-06-25  Tom Tromey  <tom@tromey.com>
6006
6007         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6008         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6009         (tui_source_window_base::set_new_height): Update.
6010         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6011         Update.
6012         (tui_set_locator_fullname, tui_set_locator_info)
6013         (tui_show_frame_info): Update.
6014         * tui/tui-source.c (tui_set_source_content)
6015         (tui_source_is_displayed): Update.
6016         * tui/tui-layout.c (show_source_disasm_command, show_data)
6017         (show_source_or_disasm_and_command): Update.
6018         * tui/tui-disasm.c (tui_set_disassem_content)
6019         (tui_get_begin_asm_address): Update.
6020         * tui/tui-data.h (struct tui_locator_element): Remove.
6021         (union tui_which_element) <locator>: Remove.
6022         (struct tui_locator_window): New.
6023         (tui_locator_win_info_ptr): Change return type.
6024         * tui/tui-data.c (_locator): Change type.
6025         (tui_locator_win_info_ptr): Change return type.
6026         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6027         (tui_alloc_content): Add assert.
6028
6029 2019-06-25  Tom Tromey  <tom@tromey.com>
6030
6031         * tui/tui-winsource.c
6032         (tui_exec_info_window::maybe_allocate_content): New method.
6033         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6034         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6035         (make_source_or_disasm_window): Add cast.
6036         * tui/tui-data.h (union tui_which_element) <simple_string>:
6037         Remove.
6038         (struct tui_source_info): New.
6039         (struct tui_source_window_base) <execution_info>: Change type.
6040         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6041         case, and add assert.
6042         (tui_alloc_content): Add assert.
6043
6044 2019-06-25  Tom Tromey  <tom@tromey.com>
6045
6046         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6047         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6048         * tui/tui-data.c (tui_alloc_win_info): Remove.
6049
6050 2019-06-25  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6053         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6054         can_highlight.
6055
6056 2019-06-25  Tom Tromey  <tom@tromey.com>
6057
6058         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6059         make_visible_with_new_height method.
6060         (tui_win_info::make_visible_with_new_height): New method.
6061         (tui_source_window_base::do_make_visible_with_new_height)
6062         (tui_data_window::do_make_visible_with_new_height)
6063         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6064         (make_visible_with_new_height): Remove.
6065         (tui_resize_all, tui_adjust_win_heights): Use
6066         make_visible_with_new_height method.
6067         * tui/tui-data.h (struct tui_win_info)
6068         <do_make_visible_with_new_height, make_visible_with_new_height>:
6069         New methods.
6070         (struct tui_source_window_base, struct tui_data_window)
6071         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6072         methods.
6073
6074 2019-06-25  Tom Tromey  <tom@tromey.com>
6075
6076         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6077         method.
6078         (update_tab_width): Call update_tab_width method.
6079         * tui/tui-data.h (struct tui_win_info)
6080         (struct tui_source_window_base) <update_tab_width>: New methods.
6081
6082 2019-06-25  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6085         parameter.
6086         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6087         parameter.
6088         (tui_gen_win_info::make_visible): Update.
6089         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6090         parameter.
6091         * tui/tui-data.h (enum tui_box): New enum.
6092         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6093
6094 2019-06-25  Tom Tromey  <tom@tromey.com>
6095
6096         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6097         init_and_make_win for EXEC_INFO_WIN.
6098         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6099         longer inline.
6100         (struct tui_win_info) <~tui_win_info>: Inline.
6101         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6102         Don't declare.
6103         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6104         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6105         Remove.
6106         (tui_initialize_static_data): Update.
6107         (~tui_gen_win_info): Handle more cleanup here.
6108         (~tui_source_window_base): Delete "execution_info".
6109         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6110
6111 2019-06-25  Tom Tromey  <tom@tromey.com>
6112
6113         * tui/tui-layout.c (make_command_window): Don't set
6114         can_highlight.
6115         (show_source_disasm_command): Call the reset method.
6116         (show_data): Don't set can_highlight.  Call the reset method.
6117         (tui_gen_win_info::reset): Rename from init_gen_win_info
6118         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6119         (show_source_or_disasm_and_command): Call the reset method.
6120         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6121         (struct tui_cmd_window): Set can_highlight.
6122
6123 2019-06-25  Tom Tromey  <tom@tromey.com>
6124
6125         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6126         from make_visible.
6127         (tui_make_visible, tui_make_invisible): Rewrite.
6128         (tui_win_info::make_visible): Remove.
6129         (tui_source_window_base::make_visible): Update.
6130         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6131         method.  Moved from...
6132         (struct tui_win_info) <make_visible>: ...here.
6133
6134 2019-06-25  Tom Tromey  <tom@tromey.com>
6135
6136         * tui/tui-winsource.c
6137         (tui_source_window_base::do_scroll_horizontal): Remove direction
6138         parameter.
6139         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6140         direction parameter.
6141         * tui/tui-win.c (tui_win_info::forward_scroll)
6142         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6143         (tui_win_info::right_scroll): Update.
6144         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6145         direction parameter.
6146         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6147         direction parameter.
6148         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6149         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6150         Remove direction parameter.
6151         (struct tui_source_window_base, struct tui_source_window)
6152         (struct tui_disasm_window, struct tui_data_window)
6153         (struct tui_cmd_window): Update.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-winsource.h (tui_set_exec_info_content)
6158         (tui_show_exec_info_content, tui_erase_exec_info_content)
6159         (tui_clear_exec_info_content, tui_update_exec_info): Change
6160         argument to tui_source_window_base.
6161         * tui/tui-winsource.c (tui_set_exec_info_content)
6162         (tui_show_exec_info_content, tui_erase_exec_info_content)
6163         (tui_clear_exec_info_content, tui_update_exec_info): Change
6164         argument to tui_source_window_base.
6165
6166 2019-06-25  Tom Tromey  <tom@tromey.com>
6167
6168         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6169         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6170
6171 2019-06-25  Tom Tromey  <tom@tromey.com>
6172
6173         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6174         check.
6175
6176 2019-06-25  Tom Tromey  <tom@tromey.com>
6177
6178         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6179         type to void.
6180         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6181         type to void.
6182         * tui/tui-source.c (tui_set_source_content): Update.
6183         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6184
6185 2019-06-25  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-win.c (window_name_completer, tui_set_focus)
6188         (tui_all_windows_info): Use name method.
6189         * tui/tui-data.h (struct tui_gen_win_info)
6190         (struct tui_source_window, struct tui_disasm_window)
6191         (struct tui_data_window, struct tui_cmd_window) <name>: New
6192         method.
6193         (tui_win_name): Don't declare.
6194         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6195         (tui_win_name): Remove.
6196
6197 2019-06-25  Tom Tromey  <tom@tromey.com>
6198
6199         * tui/tui-winsource.h (tui_update_source_window)
6200         (tui_update_source_window_as_is): Change parameter type.
6201         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6202         to be a tui_source_window_base.
6203         (tui_update_source_window_as_is): Likewise.
6204         * tui/tui-win.c (make_visible_with_new_height): Update.
6205
6206 2019-06-25  Tom Tromey  <tom@tromey.com>
6207
6208         * tui/tui-winsource.c (tui_erase_source_content)
6209         (tui_show_source_content, tui_show_exec_info_content)
6210         (tui_erase_exec_info_content): Use refresh_window method.
6211         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6212         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6213         from tui_refresh_win.
6214         (tui_data_window::refresh_window): New method.
6215         (tui_win_info::refresh, tui_source_window_base::refresh)
6216         (tui_refresh_all): Use refresh_window method.
6217         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6218         method.
6219         * tui/tui-regs.c (tui_display_register): Call refresh_window
6220         method.
6221         * tui/tui-layout.c (show_source_disasm_command)
6222         (show_source_or_disasm_and_command): Call refresh_window method.
6223         * tui/tui-data.h (struct tui_gen_win_info)
6224         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6225         New method.
6226
6227 2019-06-25  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui.c (tui_rl_other_window, tui_enable)
6230         (tui_is_window_visible, tui_get_command_dimension): Update.
6231         * tui/tui-winsource.c (tui_update_source_window_as_is)
6232         (tui_clear_source_content, tui_erase_source_content)
6233         (tui_show_source_line, tui_source_window_base::refill)
6234         (tui_source_window_base::do_scroll_horizontal)
6235         (tui_source_window_base::set_is_exec_point_at)
6236         (tui_update_breakpoint_info, tui_set_exec_info_content)
6237         (tui_alloc_source_buffer, tui_line_is_displayed)
6238         (tui_addr_is_displayed): Update.
6239         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6240         (tui_check_and_display_highlight_if_needed)
6241         (tui_win_info::make_visible, tui_win_info::refresh)
6242         (tui_refresh_all): Update.
6243         * tui/tui-windata.c (tui_first_data_item_displayed)
6244         (tui_delete_data_content_windows, tui_erase_data_content)
6245         (tui_display_all_data, tui_data_window::refresh_all)
6246         (tui_check_data_values): Update.
6247         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6248         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6249         (tui_win_info::backward_scroll, tui_refresh_all_win)
6250         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6251         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6252         (tui_source_window_base::set_new_height)
6253         (tui_data_window::set_new_height)
6254         (make_invisible_and_set_new_height)
6255         (make_visible_with_new_height, new_height_ok)
6256         (parse_scrolling_args): Update.
6257         * tui/tui-stack.c (tui_show_frame_info): Update.
6258         * tui/tui-source.c (tui_set_source_content)
6259         (tui_set_source_content_nil, tui_source_is_displayed)
6260         (tui_source_window::do_scroll_vertical): Update.
6261         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6262         (tui_display_registers_from, tui_display_reg_element_at_line)
6263         (tui_check_register_values, tui_reg_command): Update.
6264         * tui/tui-layout.c (tui_default_win_height)
6265         (show_source_disasm_command, show_data, init_and_make_win)
6266         (show_source_or_disasm_and_command): Update.
6267         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6268         (tui_redisplay_readline, tui_mld_flush)
6269         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6270         (tui_getc): Update.
6271         * tui/tui-disasm.c (tui_set_disassem_content)
6272         (tui_disasm_window::do_scroll_vertical): Update.
6273         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6274         Now virtual.
6275         (struct tui_win_info): Derive from tui_gen_win_info.
6276         <~tui_win_info>: Mark as override.
6277         <generic>: Remove member.
6278         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6279         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6280         (~tui_data_window, ~tui_win_info)
6281         (tui_free_all_source_wins_content): Update.
6282         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6283
6284 2019-06-25  Tom Tromey  <tom@tromey.com>
6285
6286         * tui/tui-layout.c (init_and_make_win): Use new.
6287         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6288         destructor, initializers.
6289         (tui_alloc_generic_win_info): Don't declare.
6290         * tui/tui-data.c (_locator): Add argument to constructor.
6291         (source_win, disasm_win): New globals.
6292         (exec_info): Remove.
6293         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6294         Update.
6295         (tui_alloc_generic_win_info): Remove.
6296         (init_content_element): Use new.
6297         (tui_win_info::tui_win_info): Update.
6298         (free_content_elements) <case DATA_WIN>: Use delete.
6299
6300 2019-06-25  Tom Tromey  <tom@tromey.com>
6301
6302         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6303         * tui/tui-windata.c (tui_first_data_item_displayed)
6304         (tui_delete_data_content_windows): Update.
6305         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6306         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6307         (tui_display_registers_from, tui_check_register_values): Update.
6308         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6309         pointer.
6310         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6311         window.
6312         (tui_free_data_content): Update.
6313         (free_content_elements) <case DATA_WIN>: Free the window.
6314
6315 2019-06-25  Tom Tromey  <tom@tromey.com>
6316
6317         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6318         Update.
6319         * tui/tui-layout.c (make_command_window)
6320         (show_source_disasm_command, show_data, init_and_make_win)
6321         (show_source_or_disasm_and_command): Update.
6322         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6323         method.
6324         <can_highight, is_highlighted>: Now bool.
6325         (tui_set_win_highlight): Don't declare.
6326         * tui/tui-data.c (tui_set_win_highlight): Remove.
6327
6328 2019-06-25  Tom Tromey  <tom@tromey.com>
6329
6330         * tui/tui-wingeneral.c (make_visible): Remove check of window
6331         type.
6332
6333 2019-06-25  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-win.c (tui_win_info::max_height)
6336         (tui_cmd_window::max_height): New methods.
6337         (new_height_ok): Call max_height.
6338         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6339         <max_height>: New method.
6340
6341 2019-06-25  Tom Tromey  <tom@tromey.com>
6342
6343         * tui/tui-win.c (tui_source_window_base::set_new_height)
6344         (tui_data_window::set_new_height): New methods.
6345         (make_invisible_and_set_new_height): Call set_new_height method.
6346         * tui/tui-data.h (struct tui_win_info)
6347         (struct tui_source_window_base, struct tui_data_window)
6348         <set_new_height>: New method.
6349
6350 2019-06-25  Tom Tromey  <tom@tromey.com>
6351
6352         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6353         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6354         tui_refresh_data_win.
6355         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6356         method.
6357         (tui_refresh_all_win): Call the refresh_all method.
6358         (tui_set_focus): Likewise.
6359         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6360         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6361         Likewise.
6362
6363 2019-06-25  Tom Tromey  <tom@tromey.com>
6364
6365         * tui/tui-winsource.h (tui_refill_source_window)
6366         (tui_set_is_exec_point_at): Don't declare.
6367         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6368         (tui_source_window_base::refill): Rename from
6369         tui_refill_source_window.
6370         (tui_source_window_base::do_scroll_horizontal): Update.
6371         (tui_source_window_base::set_is_exec_point_at): Rename from
6372         tui_set_is_exec_point_at.
6373         (tui_update_all_breakpoint_info): Update.
6374         * tui/tui-stack.c (tui_show_frame_info): Update.
6375         * tui/tui-layout.c (show_data): Add cast.
6376         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6377         * tui/tui-data.h (struct tui_source_window_base) <refill,
6378         set_is_exec_point_at>: New methods.
6379         (tui_source_windows, tui_add_to_source_windows): Update types.
6380         (tui_add_to_source_windows): Remove redundant declaration.
6381         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6382         (tui_source_windows): Change return type.
6383         (tui_clear_source_windows_detail): Update.
6384         (tui_add_to_source_windows): Change type of parameter.
6385         (tui_free_all_source_wins_content): Update.
6386
6387 2019-06-25  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-wingeneral.c (tui_win_info::refresh)
6390         (tui_source_window_base::refresh): New methods.
6391         (tui_refresh_all): Call the refresh method.
6392         * tui/tui-data.h (struct tui_win_info)
6393         (struct tui_source_window_base) <refresh>: New method.
6394
6395 2019-06-25  Tom Tromey  <tom@tromey.com>
6396
6397         * tui/tui.h (tui_is_window_visible): Return bool.
6398         * tui/tui.c (tui_is_window_visible): Return bool.
6399         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6400         (tui_make_visible, tui_make_invisible)
6401         (tui_win_info::make_visible)
6402         (tui_source_window_base::make_visible, make_all_visible)
6403         (tui_make_all_visible, tui_make_all_invisible): Update.
6404         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6405         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6406         bool.
6407         (struct tui_win_info, struct tui_source_window_base)
6408         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6409         * tui/tui-data.c (tui_init_generic_part): Update.
6410
6411 2019-06-25  Tom Tromey  <tom@tromey.com>
6412
6413         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6414         (tui_source_window_base::make_visible): New methods.
6415         (make_all_visible): Make method call.
6416         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6417         (struct tui_source_window_base, struct tui_cmd_window): Override
6418         make_visible.
6419         (tui_win_is_source_type): Don't declare.
6420         * tui/tui-data.c (tui_win_is_source_type): Remove.
6421
6422 2019-06-25  Tom Tromey  <tom@tromey.com>
6423
6424         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6425         NULL check.
6426
6427 2019-06-25  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6430         Inline constructor.  Add initializers for members.
6431         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6432         constructors; now inline in class.
6433
6434 2019-06-25  Tom Tromey  <tom@tromey.com>
6435
6436         * tui/tui-regs.c (tui_show_registers): Update.
6437         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6438         bool.
6439         * tui/tui-data.c (tui_data_window::clear_detail)
6440         (tui_data_window): Update.
6441
6442 2019-06-25  Tom Tromey  <tom@tromey.com>
6443
6444         * tui/tui-windata.c (tui_display_all_data)
6445         (tui_display_data_from_line, tui_display_data_from)
6446         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6447         Update.
6448         * tui/tui-regs.c (tui_last_regs_line_no)
6449         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6450         (tui_show_registers, tui_show_register_group)
6451         (tui_display_registers_from, tui_display_reg_element_at_line)
6452         (tui_display_registers_from_line, tui_check_register_values)
6453         (tui_reg_next, tui_reg_prev): Update.
6454         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6455         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6456         tui_data_window.
6457         (struct tui_win_info) <detail>: Remove.  Add new fields from
6458         tui_data_info.
6459         (TUI_DATA_WIN): Add cast.
6460         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6461         (~tui_data_window): Simplify.
6462
6463 2019-06-25  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui-layout.c (show_source_disasm_command)
6466         (show_source_or_disasm_and_command): Update.
6467         * tui/tui-io.c (update_cmdwin_start_line)
6468         (tui_redisplay_readline): Update.
6469         * tui/tui-data.h (struct tui_command_info): Remove.
6470         (struct tui_win_info) <detail>: Remove command_info member.
6471         (struct tui_data_window) <start_line>: New member, from
6472         tui_command_info.
6473         (TUI_CMD_WIN): Add casts.
6474
6475 2019-06-25  Tom Tromey  <tom@tromey.com>
6476
6477         * tui/tui-winsource.c (tui_update_source_window)
6478         (tui_refill_source_window)
6479         (tui_source_window_base::do_scroll_horizontal)
6480         (tui_update_breakpoint_info, tui_set_exec_info_content)
6481         (tui_show_exec_info_content, tui_erase_exec_info_content)
6482         (tui_clear_exec_info_content): Update.
6483         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6484         Update.
6485         * tui/tui-win.c (make_invisible_and_set_new_height)
6486         (make_visible_with_new_height): Update.
6487         * tui/tui-source.c (tui_set_source_content)
6488         (tui_show_symtab_source): Update.
6489         * tui/tui-layout.c (extract_display_start_addr)
6490         (show_source_disasm_command, show_data)
6491         (make_source_or_disasm_window)
6492         (show_source_or_disasm_and_command): Update.
6493         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6494         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6495         "gdbarch".
6496         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6497         to tui_source_window_base.
6498         (struct tui_win_info) <detail>: Remove source_info member.
6499         (struct tui_source_window_base) <has_locator>: Inline.
6500         Move contents from tui_source_info; rename has_locator member to
6501         m_has_locator.
6502         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6503         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6504         header file.
6505         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6506         Simplify.
6507         (tui_free_all_source_wins_content): Cast to
6508         tui_source_window_base.
6509
6510 2019-06-25  Tom Tromey  <tom@tromey.com>
6511
6512         * tui/tui-win.c (make_invisible_and_set_new_height)
6513         (make_visible_with_new_height): Call has_locator method.
6514         * tui/tui-layout.c (show_source_disasm_command, show_data)
6515         (show_source_or_disasm_and_command): Update for bool change.
6516         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6517         (tui_win_info) <has_locator>: New method.
6518         (struct tui_source_window_base) <has_locator>: New method.
6519         (tui_win_has_locator): Don't declare.
6520         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6521         from tui_win_has_locator.
6522         (tui_source_window_base): Use false, not FALSE.
6523
6524 2019-06-25  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6527         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6528         clear_detail method directly.
6529         (tui_clear_win_detail): Remove.
6530
6531 2019-06-25  Tom Tromey  <tom@tromey.com>
6532
6533         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6534         "this", not TUI_DISASM_WIN.
6535
6536 2019-06-25  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6539         declare.
6540         * tui/tui-winsource.c
6541         (tui_source_window_base::do_scroll_horizontal): Rename from
6542         tui_horizontal_source_scroll.
6543         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6544         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6545         from tui_vertical_data_scroll.
6546         * tui/tui-win.h (tui_scroll): Don't declare.
6547         * tui/tui-win.c (tui_win_info::forward_scroll)
6548         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6549         (tui_win_info::right_scroll): Rename and update.
6550         (tui_scroll_forward_command, tui_scroll_backward_command)
6551         (tui_scroll_left_command, tui_scroll_right_command): Update.
6552         (tui_scroll): Remove.
6553         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6554         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6555         from tui_vertical_source_scroll.
6556         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6557         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6558         from tui_vertical_disassem_scroll.
6559         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6560         do_scroll_horizontal>: New methods.
6561         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6562         Likewise.
6563         (struct tui_source_window_base): Add do_scroll_horizontal.
6564         (struct tui_source_window, struct tui_disasm_window): Add
6565         do_scroll_vertical.
6566         (struct tui_data_window, struct tui_cmd_window): Add
6567         do_scroll_horizontal and do_scroll_vertical.
6568         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6569
6570 2019-06-25  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui-data.h (struct tui_source_window_base): New struct.
6573         (struct tui_source_window): Derive from tui_source_window_base.
6574         (struct tui_disasm_window): New struct.
6575         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6576         from tui_source_window::clear_detail.
6577         (tui_source_window_base): Rename from tui_source_window.
6578         (~tui_source_window_base): Rename from ~tui_source_window.
6579         (tui_alloc_win_info): Create a tui_disasm_window.
6580
6581 2019-06-25  Tom Tromey  <tom@tromey.com>
6582
6583         * tui/tui-data.h (struct tui_source_window)
6584         (struct tui_data_window): Declare destructors.
6585         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6586         destructors.
6587         (tui_win_info): Simplify.
6588
6589 2019-06-25  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-winsource.c (tui_display_main)
6592         (tui_update_source_windows_with_addr)
6593         (tui_update_all_breakpoint_info): Update.
6594         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6595         (new_height_ok, parse_scrolling_args): Update.
6596         * tui/tui-stack.c (tui_show_frame_info): Update.
6597         * tui/tui-data.h (struct tui_list): Remove.
6598         (tui_source_windows): Return a reference to a std::vector.
6599         * tui/tui-data.c (source_windows): Now a std::vector.
6600         (tui_source_windows): Change return type.
6601         (tui_clear_source_windows): Rewrite.
6602         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6603         (tui_free_all_source_wins_content): Rewrite.
6604
6605 2019-06-25  Tom Tromey  <tom@tromey.com>
6606
6607         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6608         (struct tui_data_window, struct tui_cmd_window): Declare
6609         clear_detail method.
6610         * tui/tui-data.c (tui_source_window::clear_detail)
6611         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6612         methods.
6613         (tui_clear_win_detail): Simplify.
6614
6615 2019-06-25  Tom Tromey  <tom@tromey.com>
6616
6617         * tui/tui-layout.c (make_source_window, make_disasm_window)
6618         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6619         Return the new window.
6620         (show_source_disasm_command, show_data)
6621         (show_source_or_disasm_and_command): Update.
6622
6623 2019-06-25  Tom Tromey  <tom@tromey.com>
6624
6625         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6626         parameter.  Return the new window.
6627         (show_source_disasm_command): Update and remove NULL check.
6628         (show_source_or_disasm_and_command): Update.
6629
6630 2019-06-25  Tom Tromey  <tom@tromey.com>
6631
6632         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6633
6634 2019-06-25  Tom Tromey  <tom@tromey.com>
6635
6636         * tui/tui-data.h (struct tui_win_info): Make constructor
6637         protected.  Make destructor virtual.  Add initializers.
6638         (tui_source_window, tui_data_window, tui_cmd_window): New
6639         classes.
6640         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6641         constructor.  Add "type" parameter.
6642         (tui_source_window, tui_data_window, tui_cmd_window): New
6643         constructors.
6644         (tui_alloc_win_info): Instantiate the appropriate subclass.
6645
6646 2019-06-25  Tom Tromey  <tom@tromey.com>
6647
6648         * tui/tui-win.c (tui_resize_all): Use delete.
6649         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6650         destructor.
6651         (tui_free_window): Don't declare.
6652         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6653         Update.
6654
6655 2019-06-25  Tom Tromey  <tom@tromey.com>
6656
6657         * tui/tui-data.h (struct tui_win_info): Add constructor.
6658         * tui/tui-data.c (tui_alloc_win_info): Use new.
6659         (tui_free_window): Use delete.
6660
6661 2019-06-22  Tom Tromey  <tom@tromey.com>
6662
6663         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6664         declare.
6665         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6666
6667 2019-06-22  Tom Tromey  <tom@tromey.com>
6668
6669         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6670         declare.
6671         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6672
6673 2019-06-22  Tom de Vries  <tdevries@suse.de>
6674
6675         * dwarf2read.c (create_addrmap_from_aranges)
6676         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6677         instead of '%zu'.
6678
6679 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6680
6681         * dwarf2read.h (dwarf2_section_info_def): Remove.
6682         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6683         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6684         std::vector<dwarf2_section_info>.
6685         (struct dwo_file) <~dwo_file>: Remove.
6686         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6687         types field.
6688         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6689         (dwarf2_read_debug_names): Likewise.
6690         (create_debug_types_hash_table): Change parameter type to
6691         array_view, adjust code accordingly.
6692         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6693         (partial_die_info::fixup): Likewise.
6694         (determine_prefix): Likewise.
6695         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6696
6697 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6698
6699         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6700         gdb_bfd_ref_ptr.
6701         <~dwo_file>: Remove call to gdb_bfd_unref.
6702         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6703         gdb_bfd_ref_ptr::get.
6704
6705 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6706
6707         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6708         type to htab_up.
6709         * dwarf2read.c (struct dwo_file): Initialize fields.
6710         <~dwo_file>: New.
6711         (free_dwo_file): Remove, move content to ~dwo_file.
6712         (struct dwo_file_deleter): Remove.
6713         (dwo_file_up>: Remove custom deleter.
6714         (free_dwo_files): Remove.
6715         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6716         dwo_files.
6717         (process_skeletonless_type_units): Call unique_ptr::get.
6718         (allocate_dwo_file_hash_table): Add deleter to created hash
6719         table.  Change return type to htab_up.
6720         (lookup_dwo_file_slot): Don't memset dwo_file, call
6721         unique_ptr::get.
6722         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6723         (create_dwo_unit_in_dwp_v2): Likewise.
6724         (open_and_init_dwo_file): Likewise.
6725         (free_dwo_file_from_slot): Remove.
6726
6727 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6728
6729         * dwarf2read.h (struct dwarf2_section_info) <readin,
6730         is_virtual>: Change type to bool.
6731         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6732         true instead of 1.
6733
6734 2019-06-19  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-data.h (tui_init_content_element): Don't declare.
6737
6738 2019-06-19  Tom Tromey  <tom@tromey.com>
6739
6740         * tui/tui-data.h (tui_init_win_info): Don't declare.
6741
6742 2019-06-19  Tom de Vries  <tdevries@suse.de>
6743
6744         * dwarf2read.h (abstract_to_concrete): Change type to
6745         std::unordered_map<sect_offset, std::vector<sect_offset>,
6746         gdb::hash_enum<sect_offset>>.
6747
6748 2019-06-19  Tom Tromey  <tromey@adacore.com>
6749
6750         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6751         EVAL_AVOID_SIDE_EFFECTS specially.
6752
6753 2019-06-19  Tom Tromey  <tromey@adacore.com>
6754
6755         * source-cache.c (highlighter): New global.
6756         (source_cache::get_source_lines): Create a highlighter on demand.
6757
6758 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6759
6760         * defs.h (deprecated_interactive_hook): Delete declaration.
6761         * interps.c (clear_interpreter_hooks): Remove use of
6762         deprecated_interactive_hook.
6763         * top.c (deprecated_interactive_hook): Delete definition.
6764         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6765
6766 2019-06-18  Tom de Vries  <tdevries@suse.de>
6767
6768         PR gdb/24515
6769         * dwarf2read.h (abstract_to_concrete): Change type from
6770         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6771         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6772         * dwarf2read.c (read_variable): Update.
6773         (dwarf2_fetch_die_loc_sect_off): Update.
6774
6775 2019-06-17  Tom de Vries  <tdevries@suse.de>
6776
6777         PR gdb/24617
6778         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6779         accessing parent[parent_len - 1].
6780
6781 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6782
6783         PR gdb/24364
6784         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6785         call dtrace_process_dof with NULL dof.
6786
6787 2019-06-16  Tom de Vries  <tdevries@suse.de>
6788
6789         PR gdb/24445
6790         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6791
6792 2019-06-16  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6795         (make_all_visible): Use address of member.
6796
6797 2019-06-16  Tom Tromey  <tom@tromey.com>
6798
6799         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6800         (tui_free_window, free_content, free_content_elements): Remove
6801         unnecessary cast.
6802         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6803         cast.
6804         * tui/tui-regs.c (tui_show_register_group)
6805         (tui_display_registers_from, tui_display_reg_element_at_line):
6806         Remove unnecessary cast.
6807
6808 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6809
6810         * linux-nat.c (normal_mask): Delete.
6811         (_initialize_linux_nat): Don't initialise normal_mask.
6812
6813 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6814
6815         PR gdb/24445
6816         * dwarf-index-write.h (write_psymtabs_to_index): Add
6817         dwz_basename parameter.
6818         * dwarf-index-write.c (write_gdbindex): Move file writing to
6819         write_gdbindex_1.  Change return type void.
6820         (assert_file_size): Move up, remove filename parameter.
6821         (write_gdbindex_1): New function.
6822         (write_debug_names): Change return type to void, call
6823         assert_file_size.
6824         (struct index_wip_file): New struct.
6825         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6826         file logic to index_wip_file.  Write index for dwz file if
6827         needed.
6828         (save_gdb_index_command): Pass basename of dwz file, if present.
6829         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6830         build-id of dwz file, if present.
6831         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6832         (dwarf2_get_dwz_file): Likewise.
6833         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6834         (dwarf2_get_dwz_file): Likewise.
6835
6836 2019-06-16  Tom Tromey  <tom@tromey.com>
6837
6838         * coffread.c (process_coff_symbol): Use xstrdup.
6839         * value.c (create_internalvar): Use xstrdup.
6840
6841 2019-06-16  Tom Tromey  <tom@tromey.com>
6842
6843         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6844         * breakpoint.c (stopin_command, stopat_command)
6845         (until_break_command, decode_location_default): Remove unnecessary
6846         cast.
6847         * utils.c (subset_compare): Remove unnecessary cast.
6848         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6849         cast.
6850         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6851         cast.
6852         * infcmd.c (path_command): Remove unnecessary cast.
6853         * coffread.c (decode_type): Remove unnecessary cast.
6854         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6855         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6856         * tui/tui-stack.c (tui_show_locator_content)
6857         (tui_show_frame_info): Remove unnecessary cast.
6858         * tui/tui-win.c (tui_scroll_forward_command)
6859         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6860         (parse_scrolling_args): Remove unnecessary cast.
6861         * tui/tui-data.c (init_win_info, tui_del_window)
6862         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6863         (free_content_elements): Remove unnecessary cast.
6864         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6865         unnecessary cast.
6866         * tui/tui-source.c (tui_set_source_content)
6867         (tui_vertical_source_scroll): Remove unnecessary cast.
6868         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6869         cast.
6870         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6871         * tui/tui-regs.c (tui_display_registers_from)
6872         (tui_display_register): Remove unnecessary cast.
6873         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6874         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6875         (make_visible): Remove unnecessary cast.
6876         * tui/tui-winsource.c (tui_erase_source_content)
6877         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6878         unnecessary cast.
6879         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6880         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6881         * stabsread.c (read_type, read_array_type, read_range_type):
6882         Remove unnecessary cast.
6883         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6884         (parse_symbol, parse_type, upgrade_type, parse_external)
6885         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6886         unnecessary cast.
6887         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6888
6889 2019-06-16  Tom Tromey  <tom@tromey.com>
6890
6891         * tui/tui-data.c (tui_alloc_generic_win_info)
6892         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6893         checks.
6894
6895 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6896             Andrew Burgess  <andrew.burgess@embecosm.com>
6897
6898         * f-typeprint.c (f_print_type): Don't return early for not
6899         associated or not allocated types.
6900         (f_type_print_varspec_suffix): Add print_rank parameter and print
6901         ranks of array types in case they dangling.
6902         (f_type_print_base): Add print_rank parameter.
6903
6904 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6905
6906         * NEWS: Mention new MI commands.
6907         * break-catch-throw.c (enum exception_event_kind): Move to
6908         breakpoint.h.
6909         (print_mention_exception_catchpoint): Output text as a single
6910         message.
6911         (catch_exception_command_1): Rename to...
6912         (catch_exception_event): ...this, make non-static, update header
6913         command, and change some parameter types.
6914         (catch_catch_command): Update for changes to
6915         catch_exception_command_1.
6916         (catch_throw_command): Likewise.
6917         (catch_rethrow_command): Likewise.
6918         * breakpoint.c (enum exception_event_kind): Delete.
6919         * breakpoint.h (enum exception_event_kind): Moved here from
6920         break-catch-throw.c.
6921         (catch_exception_event): Declare.
6922         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6923         (mi_cmd_catch_throw): New function.
6924         (mi_cmd_catch_rethrow): New function.
6925         (mi_cmd_catch_catch): New function.
6926         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6927         'catch-catch' entries.
6928         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6929         (mi_cmd_catch_rethrow): Declare.
6930         (mi_cmd_catch_catch): Declare.
6931
6932 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6933
6934         * annotate.c (annotate_source_line): Change return type to void,
6935         update implementation to match.
6936         * annotate.h (annotate_source_line): Change return type to void,
6937         update header comment.
6938         * stack.c (print_frame_info): Don't change what frame information
6939         is printed based on whether annotations are on or not.
6940
6941 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6942
6943         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6944         (annotate_source): Make static.
6945         (annotate_source_line): Moved from source.c and renamed from
6946         identify_source_line.  Update the return type.
6947         * annotate.h (annotate_source): Delete declaration.
6948         (annotate_source_line): Declaration moved from source.h, and
6949         renamed from identify_source_line.  Return type updated.
6950         * source.c (identify_source_line): Moved to annotate.c and renamed
6951         to annotate_source_line.
6952         (info_line_command): Remove check of annotation_level.
6953         * source.h (identify_source_line): Move declaration to annotate.h
6954         and rename to annotate_source_line.
6955         * stack.c: Add 'annotate.h' include.
6956         (print_frame_info): Remove check of annotation_level before
6957         calling annotate_source_line.
6958
6959 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6960
6961         * source-cache.c (source_cache::get_plain_source_lines): Use
6962         open_source_file_with_line_charpos instead of just
6963         open_source_file, remove call to find_source_lines.
6964         (source_cache::get_source_lines): Likewise.
6965         * source.c (find_source_lines): Make static.
6966         (get_filename_and_charpos): Renamed into...
6967         (open_source_file_with_line_charpos): ..this along with changes to
6968         return a scoped_fd, and some other minor clean ups.
6969         (identify_source_line): Use open_source_file_with_line_charpos.
6970         (search_command_helper): Use open_source_file_with_line_charpos
6971         instead of just open_source_file, remove call to
6972         find_source_lines.
6973         * source.h (open_source_file_with_line_charpos): Declare new
6974         function.
6975         (find_source_lines): Delete declaration.
6976
6977 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * source.c (get_filename_and_charpos): Remove fullname
6980         parameter.
6981         (identify_source_line): Update call to get_filename_and_charpos.
6982
6983 2019-06-14  Tom Tromey  <tromey@adacore.com>
6984
6985         PR gdb/24502:
6986         * ui-style.h (skip_ansi_escape): Update comment.
6987         * ui-file.h (class no_terminal_escape_file): New class.
6988         * ui-file.c (no_terminal_escape_file::write)
6989         (no_terminal_escape_file::puts): New methods.
6990         * cli/cli-logging.c (handle_redirections): Use
6991         no_terminal_escape_file.
6992
6993 2019-06-14  Tom Tromey  <tromey@adacore.com>
6994
6995         * NEWS: Move convenience variable news above Python news.
6996
6997 2019-06-14  Tom Tromey  <tom@tromey.com>
6998
6999         * gnulib: Move directory to top-level.
7000         * configure.ac: Don't configure gnulib.
7001         * configure: Rebuild.
7002         * common/common-defs.h: Use new path to gnulib.
7003         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7004         (GNULIB_H): Remove.
7005         (INCGNU): Look in new gnulib location.
7006         (HFILES_NO_SRCDIR): Remove gnulib files.
7007         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7008         (generated_files): Remove GNULIB_H.
7009         ($(LIBGNU), all-lib): Remove targets.
7010         (distclean): Don't mention GNULIB_BUILDDIR.
7011         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7012
7013 2019-06-14  Tom Tromey  <tromey@adacore.com>
7014
7015         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7016         Warn if symbol file does not provide any symbols.
7017
7018 2019-06-14  Tom Tromey  <tromey@adacore.com>
7019
7020         * source.c (find_and_open_source): Respect basenames_may_differ.
7021
7022 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * annotate.c (annotate_breakpoints_invalid): Make use of
7025         scoped_restore_terminal_state.
7026         (annotate_frames_invalid): Likewise.
7027
7028 2019-06-14  Tom Tromey  <tromey@adacore.com>
7029
7030         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7031         allow assignment to an internalvar.
7032
7033 2019-06-14  Tom Tromey  <tromey@adacore.com>
7034
7035         * ada-lex.l: Allow "_" in attribute names.
7036
7037 2019-06-14  Tom Tromey  <tromey@adacore.com>
7038
7039         PR gdb/24653:
7040         * regcache.c (registers_changed): Don't call alloca.
7041         * top.c (execute_command): Don't call alloca.
7042
7043 2019-06-13  Pedro Alves  <palves@redhat.com>
7044
7045         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7046         'expression'.  When parsing an expression, error out if there's
7047         junk after "unlimited".
7048         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7049         (do_set_command): Adjust calls to is_unlimited_literal.
7050
7051 2019-06-13  Pedro Alves  <palves@redhat.com>
7052
7053         * compile/compile.c (make_compile_options_def_group): Add braces
7054         around array_view initializer.
7055         * thread.c (make_thread_apply_all_options_def_group)
7056         (make_thread_apply_all_options_def_group): Likewise.
7057
7058 2019-06-13  Pedro Alves  <palves@redhat.com>
7059
7060         * NEWS (New commands): Mention "maint test-options
7061         require-delimiter", "maint test-options unknown-is-error", "maint
7062         test-options unknown-is-operand" and "maint show
7063         test-options-completion-result".
7064         (New command options, command completion): New section.
7065         (Completion improvements): New section.
7066         Mention that you can abbreviate "unlimited".
7067
7068 2019-06-13  Pedro Alves  <palves@redhat.com>
7069
7070         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7071         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7072         * unittests/cli-utils-selftests.c (test_parse_flags)
7073         (test_parse_flags_qcs): Delete.
7074         (test_cli_utils): Don't call deleted functions.
7075
7076 2019-06-13  Pedro Alves  <palves@redhat.com>
7077
7078         * thread.c: Include "cli/cli-option.h".
7079         (tp_array_compar_ascending): Global.
7080         (tp_array_compar): Delete function.
7081         (tp_array_compar_ascending, tp_array_compar_descending): New
7082         functions.
7083         (ascending_option_def, qcs_flag_option_def)
7084         (thr_qcs_flags_option_defs)
7085         (make_thread_apply_all_options_def_group)
7086         (make_thread_apply_options_def_group): New.
7087         (thread_apply_all_command): Use gdb::option::process_options.
7088         (thread_apply_command_completer)
7089         (thread_apply_all_command_completer): New.
7090         (thread_apply_command): Use gdb::option::process_options.
7091         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7092         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7093         to generate help text of "thread apply".  Adjust "taas"'s help.
7094         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7095         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7096
7097 2019-06-13  Pedro Alves  <palves@redhat.com>
7098
7099         * thread.c (thread_apply_command): Check for invalid TID with
7100         isdigit instead of !isalpha.
7101
7102 2019-06-13  Pedro Alves  <palves@redhat.com>
7103
7104         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7105         (validate_flags_qcs): New.
7106         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7107         (validate_flags_qcs): Declare.
7108         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7109         (make_frame_apply_options_def_group): New.
7110         (frame_apply_command_count): Process options with
7111         gdb::option::process_options.
7112         (frame_apply_completer): New.
7113         (frame_apply_level_completer, frame_apply_all_completer)
7114         (frame_apply_completer): New.
7115         (_initialize_stack): Update help of "frame apply", "frame apply
7116         level", "frame apply all" and "faas" to mention supported options
7117         and install command completers.
7118         * stack.h (frame_apply_all_completer): Declare.
7119         * thread.c: Include "stack.h".
7120         (tfaas_command): Add "--".
7121         (_initialize_thread): Update help "tfaas" to mention supported
7122         options and install command completer.
7123
7124 2019-06-13  Pedro Alves  <palves@redhat.com>
7125
7126         * completer.c (complete_nested_command_line): New.
7127         (gdb_completion_word_break_characters_throw): Add assertion.
7128         * completer.h (complete_nested_command_line): Declare.
7129
7130 2019-06-13  Pedro Alves  <palves@redhat.com>
7131
7132         * stack.c (parse_backtrace_qualifiers): New.
7133         (backtrace_command): Use it.
7134         (backtrace_command_completer): Complete on qualifiers.
7135
7136 2019-06-13  Pedro Alves  <palves@redhat.com>
7137
7138         * frame.c: Include "cli/cli-option.h.
7139         (user_set_backtrace_options): New.
7140         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7141         Delete.
7142         (get_prev_frame): Adjust.
7143         (boolean_option_def, uinteger_option_def)
7144         (set_backtrace_option_defs): New.
7145         (_initialize_frame): Adjust and use
7146         gdb::option::add_setshow_cmds_for_options to install "set
7147         backtrace past-main" and "set backtrace past-entry".
7148         * frame.h: Include "cli/cli-option.h".
7149         (struct frame_print_options): Forward declare.
7150         (print_frame_arguments_all, print_frame_arguments_scalars)
7151         (print_frame_arguments_none): Declare.
7152         (print_entry_values): Delete declaration.
7153         (struct frame_print_options, user_frame_print_options): New.
7154         (struct set_backtrace_options): New.
7155         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7156         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7157         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7158         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7159         (list_args_or_locals): Add frame_print_options parameter.
7160         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7161         * python/py-framefilter.c (enumerate_args): Pass down
7162         USER_FRAME_PRINT_OPTIONS.
7163         * stack.c: Include "cli/cli-option.h".
7164         (print_frame_arguments_all, print_frame_arguments_scalars)
7165         (print_frame_arguments_none): Declare.
7166         (print_raw_frame_arguments, print_entry_values): Delete.
7167         (user_frame_print_options): New.
7168         (boolean_option_def, enum_option_def, frame_print_option_defs):
7169         New.
7170         (struct backtrace_cmd_options): New.
7171         (bt_flag_option_def): New.
7172         (backtrace_command_option_defs): New.
7173         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7174         (print_frame_arg, read_frame_arg, print_frame_args)
7175         (print_frame_info, print_frame): Add frame_print_options parameter
7176         and use it.
7177         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7178         (backtrace_command_1): Add frame_print_options and
7179         backtrace_cmd_options parameters and use them.
7180         (make_backtrace_options_def_group): New.
7181         (backtrace_command): Process command options with
7182         gdb::option::process_options.
7183         (backtrace_command_completer): New.
7184         (_initialize_stack): Extend "backtrace"'s help to mention
7185         supported options.  Install completer for "backtrace".
7186         Install some settings commands with add_setshow_cmds_for_options.
7187
7188 2019-06-13  Pedro Alves  <palves@redhat.com>
7189
7190         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7191         and that "set/show print raw frame-arguments" are now deprecated.
7192
7193         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7194         command.
7195         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7196         * stack.c (_initialize_stack): Install "set/show print
7197         raw-frame-arguments", and deprecate "set/show print raw
7198         frame-arguments".
7199         * valprint.c (_initialize_valprint): Deprecate "set/show print
7200         raw".
7201
7202 2019-06-13  Pedro Alves  <palves@redhat.com>
7203
7204         * compile/compile.c (struct compile_options): New.
7205         (compile_flag_option_def, compile_command_option_defs)
7206         (make_compile_options_def_group): New.
7207         (compile_file_command): Handle options with
7208         gdb::option::process_options.
7209         (compile_file_command_completer): New function.
7210         (compile_code_command): Handle options with
7211         gdb::option::process_options.
7212         (compile_code_command_completer): New function.
7213         (_initialize_compiler): Install completers for "compile code" and
7214         "compile file".  Mention available options in "compile code" and
7215         "compile code"'s help.
7216         * completer.c (advance_to_completion_word): New, factored out from
7217         ...
7218         (advance_to_expression_complete_word_point): ... this.
7219         (advance_to_filename_complete_word_point): New.
7220         * completer.h (advance_to_filename_complete_word_point): New
7221         declaration.
7222
7223 2019-06-13  Pedro Alves  <palves@redhat.com>
7224
7225         * compile/compile.c: Include "cli/cli-option.h".
7226         (compile_print_value): Scope data pointer is now a
7227         value_print_options pointer; adjust.
7228         (compile_print_command): Process options.  Scope data pointer is
7229         now a value_print_options pointer; adjust.
7230         (_initialize_compile): Update "compile print"'s help to include
7231         supported options.  Install a completer for "compile print".
7232         * cp-valprint.c (show_vtblprint, show_objectprint)
7233         (show_static_field_print): Delete.
7234         (_initialize_cp_valprint): Don't install "set print
7235         static-members", "set print vtbl", "set print object" here.
7236         * printcmd.c: Include "cli/cli-option.h" and
7237         "common/gdb_optional.h".
7238         (print_command_parse_format): Rework to fill in a
7239         value_print_options instead of a format_data.
7240         (print_value): Change parameter type from format_data pointer to
7241         value_print_options reference.  Adjust.
7242         (print_command_1): Process options.  Adjust to pass down a
7243         value_print_options.
7244         (print_command_completer): New.
7245         (_initialize_printcmd): Install print_command_completer as
7246         handle_brkchars completer for the "print" command.  Update
7247         "print"'s help to include supported options.
7248         * valprint.c: Include "cli/cli-option.h".
7249         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7250         here from cp-valprint.c.
7251         (boolean_option_def, uinteger_option_def)
7252         (value_print_option_defs, make_value_print_options_def_group):
7253         New.  Use gdb::option::add_setshow_cmds_for_options to install
7254         "set print elements", "set print null-stop", "set print repeats",
7255         "set print pretty", "set print union", "set print array", "set
7256         print address", "set print symbol", "set print array-indexes".
7257         * valprint.h: Include <string> and "cli/cli-option.h".
7258         (make_value_print_options_def_group): Declare.
7259         (print_value): Change parameter type from format_data pointer to
7260         value_print_options reference.
7261         (print_command_completer): Declare.
7262
7263 2019-06-13  Pedro Alves  <palves@redhat.com>
7264
7265         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7266         (COMMON_SFILES): Add maint-test-settings.c.
7267         * cli/cli-decode.c (boolean_enums): New global, factored out from
7268         ...
7269         (add_setshow_boolean_cmd): ... here.
7270         * cli/cli-decode.h (boolean_enums): Declare.
7271         * cli/cli-option.c: New file.
7272         * cli/cli-option.h: New file.
7273         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7274         factored out from ...
7275         (parse_cli_boolean_value(const char *)): ... this.
7276         (is_unlimited_literal): Change parameter type to pointer to
7277         pointer.  Adjust and advance ARG pointer.
7278         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7279         (parse_cli_var_enum): New, factored out from ...
7280         (do_set_command): ... this.  Adjust.
7281         * cli/cli-setshow.h (parse_cli_boolean_value)
7282         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7283         (parse_cli_var_enum): Declare.
7284         * cli/cli-utils.c: Include "cli/cli-option.h".
7285         (get_ulongest): New.
7286         * cli/cli-utils.h (get_ulongest): Declare.
7287         (check_for_argument): New overloads.
7288         * maint-test-options.c: New file.
7289
7290 2019-06-13  Pedro Alves  <palves@redhat.com>
7291
7292         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7293         parse a range if "-" is at the end of the string.
7294
7295 2019-06-13  Pedro Alves  <palves@redhat.com>
7296
7297         * cli/cli-setshow.c (parse_auto_binary_operation)
7298         (parse_cli_boolean_value): Don't allow "o".
7299
7300 2019-06-13  Pedro Alves  <palves@redhat.com>
7301
7302         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7303         * NEWS: Mention maint test-settings KIND.
7304         * maint-test-settings.c: New file.
7305
7306 2019-06-13  Pedro Alves  <palves@redhat.com>
7307
7308         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7309         completer.
7310         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7311         "set" completers.
7312
7313 2019-06-13  Pedro Alves  <palves@redhat.com>
7314
7315         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7316         after item.
7317
7318 2019-06-13  Pedro Alves  <palves@redhat.com>
7319
7320         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7321
7322 2019-06-13  Pedro Alves <palves@redhat.com>
7323
7324         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7325         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7326         call.
7327         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7328         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7329         calls.
7330         (check_for_argument): Skip spaces after argument.
7331
7332 2019-06-13  Pedro Alves  <palves@redhat.com>
7333
7334         * thread.c (thread_apply_command): Adjust TID parsing.
7335         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7336         detected before end of string.
7337         (tid_is_in_list): Error out if LIST is invalid.
7338
7339 2019-06-13  Pedro Alves  <palves@redhat.com>
7340
7341         * completer.c (complete_line_internal_1): Rewind completion word
7342         point.
7343         (completion_tracker::advance_custom_word_point_by): Change
7344         parameter type to int.
7345         * completer.h (completion_tracker::advance_custom_word_point_by):
7346         Likewise.
7347
7348 2019-06-13  Pedro Alves  <palves@redhat.com>
7349
7350         * completer.c (advance_to_completion_word): Handle delimiters.
7351
7352 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7353
7354         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7355
7356 2019-06-11  Tom Tromey  <tom@tromey.com>
7357
7358         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7359         (xmalloc_failed): Move to alloc.c.
7360         * alloc.c: New file.
7361         * Makefile.in (COMMON_SFILES): Add alloc.c.
7362
7363 2019-06-11  Tom Tromey  <tom@tromey.com>
7364
7365         * nat/linux-waitpid.c: Don't include server.h.
7366         (linux_debug): Remove.
7367         (my_waitpid): Update.
7368
7369 2019-06-11  Tom Tromey  <tromey@adacore.com>
7370
7371         * infcall.c (_initialize_infcall): Remove trailing newline from
7372         help.
7373         * user-regs.c (_initialize_user_regs): Remove trailing newline
7374         from help.
7375         * typeprint.c (_initialize_typeprint): Remove trailing newline
7376         from help.
7377         * reverse.c (_initialize_reverse): Remove trailing newlines from
7378         help.
7379         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7380         from help.
7381         * language.c (add_set_language_command): Remove trailing newline
7382         from help.
7383         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7384         help.
7385         * disasm.c (_initialize_disasm): Remove trailing newline from
7386         help.
7387         * top.c (init_main): Remove trailing newline from help.
7388         * interps.c (_initialize_interpreter): Remove trailing newline
7389         from help.
7390         * btrace.c (_initialize_btrace): Remove trailing newlines from
7391         help.
7392         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7393         from help.
7394         * python/python.c (_initialize_python): Remove trailing newline
7395         from help.
7396         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7397         help.
7398         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7399         from help.  Reformat some text.
7400         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7401         from help.
7402         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7403         newline from help.
7404
7405 2019-06-11  Tom Tromey  <tromey@adacore.com>
7406
7407         * darwin-nat.c (darwin_decode_exception_message)
7408         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7409
7410 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7411
7412         * valops.c (value_slice): Check for not allocated or not
7413         associated values.
7414
7415 2019-06-10  Tom de Vries  <tdevries@suse.de>
7416
7417         PR gdb/24618
7418         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7419         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7420         invalid.
7421
7422 2019-06-10  Tom de Vries  <tdevries@suse.de>
7423
7424         PR gdb/24611
7425         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7426         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7427
7428 2019-06-10  Tom de Vries  <tdevries@suse.de>
7429
7430         PR symtab/24545
7431         * symtab.c (struct demangled_name_entry): Add language field.
7432         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7433         static minimal symbol".  Set and use language field.
7434
7435 2019-06-10  Tom Tromey  <tromey@adacore.com>
7436
7437         * ada-lang.c (_initialize_ada_language): Update help text.
7438
7439 2019-06-10  Tom Tromey  <tromey@adacore.com>
7440
7441         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7442         with a newline.
7443         * guile/guile.c (handle_boot_error): Don't end warning with a
7444         newline.
7445         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7446         warning with a newline.
7447         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7448         newline.
7449         (s12z_frame_cache): Likewise.
7450         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7451         a newline.
7452         * solib-svr4.c (disable_probes_interface): Don't end warning with
7453         a newline.
7454         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7455         newline.
7456         * python/python.c (do_finish_initialization): Don't end warning
7457         with a newline.
7458
7459 2019-06-10  Tom Tromey  <tom@tromey.com>
7460
7461         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7462         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7463         gdbpy_enter.
7464
7465 2019-06-10  Tom Tromey  <tromey@adacore.com>
7466
7467         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7468         data.
7469         (elf_new_init): Don't call stabsread_new_init.
7470         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7471         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7472         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7473
7474 2019-06-10  Tom de Vries  <tdevries@suse.de>
7475
7476         PR symtab/16264
7477         PR symtab/24517
7478         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7479
7480 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7481
7482         * source.c (find_and_open_source): Also rewrite relative file
7483         names.
7484
7485 2019-04-26  Amos Bird  <amosbird@gmail.com>
7486
7487         * annotate.c (annotate_thread_exited): Add "thread-exited"
7488         annotation.
7489
7490 2019-06-06  Tom Tromey  <tromey@adacore.com>
7491
7492         * maint.h (class scoped_command_stats): Use
7493         DISABLE_COPY_AND_ASSIGN.
7494         <print_time>: New method.
7495         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7496         print_time.
7497         (scoped_command_stats::print_time): New method.
7498
7499 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7500
7501         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7502         instructions of lengths 6 or 8 bytes.
7503
7504 2019-06-04  Pedro Alves  <palves@redhat.com>
7505
7506         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7507
7508         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7509         * breakpoint.c (condition_completer): Likewise.
7510         * cli/cli-dump.c (scan_expression): Likewise.
7511         * common/filestuff.c (mkdir_recursive): Likewise.
7512         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7513         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7514         (gdb_abspath): Likewise.
7515         * compile/compile-cplus-types.c
7516         (compile_cplus_instance::decl_name): Likewise.
7517         * completer.c (complete_explicit_location):
7518         (signal_completer, reg_or_group_completer_1): Likewise.
7519         * cp-support.c (cp_remove_params_if_any): Likewise.
7520         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7521         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7522         * infcmd.c (strip_bg_char): Likewise.
7523         * linespec.c (copy_token_string): Likewise.
7524         * mi/mi-main.c (output_cores): Likewise.
7525         * psymtab.c (psymtab_search_name):
7526         * symfile.c (test_set_ext_lang_command): Likewise.
7527         * target.c (target_fileio_read_stralloc): Likewise.
7528         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7529         * value.c (complete_internalvar): Likewise.
7530
7531 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7532
7533         Add objfile property to gdb.Type.
7534         * NEWS: Mention Python API addition.
7535         * python/py-type.c (typy_get_objfile): New method.
7536
7537 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7538
7539         * NEWS: Mention the new set|show style [title|highlight].
7540         Mention changes to "show style", "help" and "apropos".
7541
7542 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7543
7544         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7545         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7546         instead of print_help_for_command.
7547         (print_doc_of_command): New function.
7548         (help_list): Add 'apropos -v word' suggestion.
7549         (print_help_for_command): Style the command name using title style.
7550         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7551         (_initialize_cli_cmds): Describe -v in apropos_command help.
7552
7553 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7554
7555         * cli/cli-style.h (cli_style_option): Add name in constructor,
7556         add m_name class member, add constructor with intensity,
7557         add name class function.
7558         (cli_style_option::add_setshow_commands): Remove name argument.
7559         (highlight_style, title_style): New styles.
7560         * cli/cli-style.c (do_show): New function that shows a style
7561         characteristic styling the style name with itself.
7562         (set_style_name): New function.
7563         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7564         Update all callers according to the changes in cli/cli-style.h.
7565         * utils.h (fputs_highlighted): New function.
7566         * utils.c (fputs_highlighted): Likewise.
7567
7568 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7569
7570         * NEWS: Mention new pipe command and new convenience variables.
7571
7572 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7573
7574         * cli/cli-cmds.c (pipe_command): New function.
7575         (_initialize_cli_cmds): Call add_com for pipe_command.
7576         Define | as an alias for pipe.
7577         (exit_status_set_internal_vars): New function.
7578         (shell_escape): Call exit_status_set_internal_vars.
7579         cli/cli-decode.c (find_command_name_length): Recognize | as
7580         a single character command.
7581
7582 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7583
7584         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7585         top.c (execute_command_to_ui_file): New function, mostly a copy
7586         of execute_command_to_string.
7587         (execute_command_to_string): Implement by calling
7588         execute_command_to_ui_file.
7589
7590 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7591
7592         * top.h (saved_command_line): Remove declaration.
7593         * top.c (previous_saved_command_line, previous_repeat_arguments):
7594         New variables.
7595         (saved_command_line): Make static, define together with other
7596         'repeat variables'.
7597         (dont_repeat): Clear repeat_arguments.
7598         (repeat_previous, get_saved_command_line, save_command_line):
7599         New functions.
7600         (gdb_init): Initialize saved_command_line
7601         and previous_saved_command_line.
7602         * main.c (captured_main_1): Remove saved_command_line initialization.
7603         * event-top.c (handle_line_of_input): Update to use
7604         the new 'repeat' related functions instead of direct access to
7605         saved_command_line.
7606         * command.h (repeat_previous, get_saved_command_line,
7607         save_command_line): New declarations.
7608         (dont_repeat): Add comment.
7609
7610 2019-05-30  Tom Tromey  <tromey@adacore.com>
7611
7612         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7613         Fix comment.
7614         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7615
7616 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7617
7618         PR cli/24587
7619         * completer.c (complete): Initialize variable word.
7620
7621 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7622
7623         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7624         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7625         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7626         'body' is NULL to the outter 'if', protecting the '!is_define'
7627         situation as well.
7628
7629 2019-05-29  Tom Tromey  <tromey@adacore.com>
7630
7631         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7632         (dwarf_unknown): New function.
7633         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7634         (dwarf_type_encoding_name): Use dwarf_unknown.
7635
7636 2019-05-29  Tom Tromey  <tromey@adacore.com>
7637
7638         PR c++/20020:
7639         * cp-valprint.c (cp_print_value_fields): Call
7640         cp_print_static_field inside "try".
7641
7642 2019-05-29  Tom Tromey  <tromey@adacore.com>
7643
7644         * inflow.c (struct terminal_info): Add default operator=.
7645         * configure: Rebuild.
7646         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7647         -Wdeprecated-copy-dtor, -Wredundant-move.
7648
7649 2019-05-29  Tom Tromey  <tromey@adacore.com>
7650
7651         * NEWS: Add entry.
7652         * infcmd.c (print_return_value_1): Handle finish_print
7653         option.
7654         (show_print_finish): New function.
7655         (_initialize_infcmd): Add "set/show print finish" commands.
7656         * valprint.c (user_print_options): Initialize new member.
7657         * valprint.h (struct value_print_options) <finish_print>: New
7658         member.
7659
7660 2019-05-28  Tom Tromey  <tromey@adacore.com>
7661
7662         * ada-lang.c (ada_remove_Xbn_suffix)
7663         (find_old_style_renaming_symbol)
7664         (parse_old_style_renaming): Remove.
7665         (ada_find_renaming_symbol): Don't call
7666         find_old_style_renaming_symbol.
7667         (ada_is_renaming_symbol): Rename from
7668         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7669         bool.  Now static.
7670         (ada_read_var_value): Update and simplify.
7671         * ada-exp.y (write_var_or_type): Remove old code.
7672
7673 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7674
7675         PR gdb/25010
7676         * event-top.c: Remove include comment.
7677         * inflow.c (class scoped_ignore_sigttou): Move from here...
7678         * inflow.h (class scoped_ignore_sigttou): ...to here.
7679         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7680         * top.c:  Remove include comment.
7681
7682 2019-05-27  Tom Tromey  <tom@tromey.com>
7683
7684         * NEWS: Fix typo.
7685
7686 2019-05-22  Tom Tromey  <tromey@adacore.com>
7687
7688         * target.c (target_follow_exec): Constify parameter.
7689         * target-delegates.c: Rebuild.
7690         * remote.c (remote_target::follow_exec): Constify parameter.
7691         * infrun.c (follow_exec): Constify parameter.
7692         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7693         (target_follow_exec): Likewise.
7694
7695 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7696
7697         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7698         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7699
7700 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7701
7702         * NEWS: Add debugredirect and testsuite sections.
7703
7704 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7705
7706         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7707         target descriptions using exclusively floating point register name
7708         aliases.
7709
7710 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7711
7712         PR gdb/18644:
7713         * f-lang.c (build_fortran_types): Handle the case where
7714         gdbarch_floatformat_for_type returns a nullptr.
7715
7716 2019-05-21  Tom de Vries  <tdevries@suse.de>
7717
7718         PR cli/24587
7719         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7720
7721 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         PR gdb/18644:
7724         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7725         16-byte floats.
7726         * i386-tdep.c (i386_floatformat_for_type): Use
7727         floatformats_ia64_quad for the 16-byte floating point component
7728         within a fortran 32-byte complex number.
7729
7730 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7733         delete default constructor.
7734         (find_partial_die): Update to return const struct.
7735         (partial_die_parent_scope): Move variable declaration into scope
7736         of its use and change its type to auto.
7737         (guess_partial_die_structure_name): Likewise.
7738         (partial_die_info::fixup): Likewise.
7739
7740 2019-05-17  Tom Tromey  <tromey@adacore.com>
7741
7742         * source.c (find_and_open_source): Remove cast.
7743
7744 2019-05-17  Tom Tromey  <tromey@adacore.com>
7745
7746         * annotate.c (annotate_source): Make "filename" const.
7747         * annotate.h (annotate_source): Use const.
7748
7749 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7750
7751         * disasm.c (set_disassembler_options): Send errors to stderr.
7752
7753 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7754
7755         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7756         (cli_interp_base::set_logging): Check debug_redirect.
7757         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7758         * cli/cli-logging.c (debug_redirect): Add static variable.
7759         (pop_output_files): Add default param.
7760         (handle_redirections): Print debug setting.
7761         (show_logging_command): Likewise.
7762         (_initialize_cli_logging): Add debugredirect command.
7763         * interps.c (current_interp_set_logging): Add debug_redirect
7764         parameter.
7765         * interps.h (set_logging): Add debug_redirect parameter.
7766         (current_interp_set_logging): Likewise.
7767         * mi/mi-common.h: Likewise.
7768         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7769
7770 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7771             Tom Tromey  <tromey@adacore.com>
7772
7773         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7774         directly.
7775         * cli/cli-interp.h (make_logging_output): Remove declaration.
7776         * cli/cli-logging.c (make_logging_output): Remove function.
7777         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7778         directly.
7779         * ui-file.c (tee_file::tee_file): Remove bools.
7780         (tee_file::~tee_file): Remove deletes.
7781         * ui-file.h (tee_file): Remove bools.
7782
7783 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7784
7785         * mi/mi-cmds.h (mi_cmd_complete): New function.
7786         * mi/mi-main.c (mi_cmd_complete): Likewise.
7787         * mi/mi-cmds.c: Define new MI command -complete.
7788         * NEWS: Mention new -complete command.
7789
7790 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7791
7792         * completer.h (complete): New function.
7793         * completer.c (complete): Likewise.
7794         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7795         function defined in completer.h.
7796
7797 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7798
7799         * MAINTAINERS (Write After Approval): Add myself.
7800
7801 2019-05-17  Tom de Vries  <tdevries@suse.de>
7802
7803         PR gdb/24094
7804         * dwarf2read.c (struct cu_partial_die_info): New struct.
7805         (find_partial_die): Return cu_partial_die_info.
7806         (partial_die_parent_scope, guess_partial_die_structure_name)
7807         (partial_die_info::fixup): Handle new return type of find_partial_die.
7808
7809 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7810
7811         PR breakpoints/24541
7812         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7813         "std::string", simplifying the algorithm.
7814
7815 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7816
7817         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7818         (stap_static_probe_ops::get_probes): Likewise.
7819
7820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7821
7822         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7823         '-')" and "else if".
7824         (stap_parse_single_operand): Join checks for
7825         "gdbarch_stap_parse_special_token_p" and
7826         "gdbarch_stap_parse_special_token" in the same "if" statement.
7827         Invert check when verifying for operation on register
7828         displacement.
7829
7830 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7831
7832         * stap-probe.c (stap_get_opcode): Update comment.
7833         (stap_get_expected_argument_type): Likewise.
7834         (handle_stap_probe): Likewise.
7835
7836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7837
7838         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7839         return type to 'bool'.  Adjust comment.  Use 'bool' when
7840         appropriate.
7841         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7842         * stap-probe.c (stap_parse_argument_1): Likewise.
7843         (stap_is_operator): Likewise.
7844         (stap_is_generic_prefix): Likewise.
7845         (stap_is_register_prefix): Likewise.
7846         (stap_is_register_indirection_prefix): Likewise.
7847         (stap_is_integer_prefix): Likewise.
7848         (stap_generic_check_suffix): Likewise.
7849         (stap_check_integer_suffix): Likewise.
7850         (stap_check_register_suffix): Likewise.
7851         (stap_check_register_indirection_suffix): Likewise.
7852         (stap_parse_register_operand): Likewise.
7853         (stap_parse_single_operand): Likewise.
7854         (stap_parse_argument_1): Likewise.
7855         (stap_probe::get_argument_count): Likewise.
7856         (stap_is_operator): Likewise.
7857
7858 2019-05-16  Tom Tromey  <tromey@adacore.com>
7859
7860         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7861         keyword to foreach.
7862
7863 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7864
7865         * linux-thread-db.c (try_thread_db_load_1): Change return type
7866         to bool.
7867         (try_thread_db_load): Likewise.
7868         (try_thread_db_load_from_pdir_1): Likewise.
7869         (try_thread_db_load_from_pdir): Likewise.
7870         (try_thread_db_load_from_sdir): Likewise.
7871         (try_thread_db_load_from_dir): Likewise.
7872         (thread_db_load_search): Likewise.
7873         (has_libpthread): Likewise.
7874         (thread_db_load): Likewise.
7875
7876 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7877
7878         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7879         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7880         NULL, and complain/return if that's the case.
7881
7882 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7883
7884         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7885         (advance, posn, abstract_read_memory): New functions.
7886         [struct mem_read_abstraction]: New struct.
7887         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7888
7889 2019-05-14  Tom Tromey  <tromey@adacore.com>
7890
7891         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7892         value is not lval_memory.
7893
7894 2019-05-14  Tom Tromey  <tromey@adacore.com>
7895
7896         * solib.c (info_sharedlibrary_command): Style the file name.
7897
7898 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7899
7900         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7901         (aarch64_vnv_type): Likewise.
7902         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7903         * common/tdesc.c: Likewise.
7904         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7905         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7906         * features/aarch64-fpu.xml: Add ieee half view.
7907         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7908         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7909         * gdbtypes.h (struct builtin_type): Likewise.
7910         (struct objfile_type): Likewise.
7911
7912 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7913
7914         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7915         typo.
7916         * location.h (string_to_event_location): Likewise.
7917
7918 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7919
7920         GDB 8.3 released.
7921
7922 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7923
7924         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7925         New variable declaration.
7926         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7927         New variable.
7928         (print_one_breakpoint): Use ui_out::test_flags and new global
7929         variable to compute use_fixed_output.
7930         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7931         Remove.
7932         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7933         (mi_multi_location_breakpoint_output_fixed): Remove.
7934         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7935         new variable.
7936         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7937         fix_multi_location_breakpoint_output flag if version >= 3.
7938         * ui-out.h (enum ui_out_flag)
7939         <fix_multi_location_breakpoint_output>: New enumerator.
7940
7941 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7942
7943         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7944
7945 2019-05-10  Tom Tromey  <tromey@adacore.com>
7946
7947         * ada-lang.c (catch_ada_completer): New function.
7948         (_initialize_ada_language): Use it.
7949
7950 2019-05-10  Tom Tromey  <tromey@adacore.com>
7951
7952         * thread.c (print_thread_info): Make "requested_threads" const.
7953         * gdbthread.h (print_thread_info): Make "requested_threads"
7954         const.
7955         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7956         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7957
7958 2019-05-08  Tom Tromey  <tom@tromey.com>
7959
7960         * gdbtypes.c (objfile_type_data): Change type.
7961         (objfile_type, _initialize_gdbtypes): Update.
7962
7963 2019-05-08  Tom Tromey  <tom@tromey.com>
7964
7965         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7966         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7967         (_initialize_dwarf2_frame): Update.
7968
7969 2019-05-08  Tom Tromey  <tom@tromey.com>
7970
7971         * objc-lang.c (objc_objfile_data): Change type.
7972         (find_methods): Update.
7973         (_initialize_objc_lang): Remove.
7974
7975 2019-05-08  Tom Tromey  <tom@tromey.com>
7976
7977         * stabsread.c (rs6000_builtin_type_data): Change type.
7978         (rs6000_builtin_type, _initialize_stabsread): Update.
7979
7980 2019-05-08  Tom Tromey  <tom@tromey.com>
7981
7982         * mips-tdep.c (mips_pdr_data): Remove.
7983         (_initialize_mips_tdep): Update.
7984
7985 2019-05-08  Tom Tromey  <tom@tromey.com>
7986
7987         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7988         (hppa_init_objfile_priv_data, read_unwind_info)
7989         (find_unwind_entry, _initialize_hppa_tdep): Update.
7990
7991 2019-05-08  Tom Tromey  <tom@tromey.com>
7992
7993         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7994         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7995         on obstack.
7996         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7997
7998 2019-05-08  Tom Tromey  <tom@tromey.com>
7999
8000         * mdebugread.c (basic_type_data): Change type.
8001         (basic_type, _initialize_mdebugread): Update.
8002
8003 2019-05-08  Tom Tromey  <tom@tromey.com>
8004
8005         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8006
8007 2019-05-08  Tom Tromey  <tom@tromey.com>
8008
8009         * nto-tdep.c (nto_inferior_data_reg): Change type.
8010         (nto_inferior_data): Update.
8011         (nto_inferior_data_cleanup, nto_new_inferior_data)
8012         (_initialize_nto_tdep): Remove.
8013         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8014
8015 2019-05-08  Tom Tromey  <tom@tromey.com>
8016
8017         * ada-lang.c (struct ada_inferior_data): Add initializers.
8018         (ada_inferior_data): Change type.
8019         (ada_inferior_data_cleanup): Remove.
8020         (get_ada_inferior_data, ada_inferior_exit)
8021         (struct ada_pspace_data): Add initializers, destructor.
8022         (ada_pspace_data_handle): Change type.
8023         (get_ada_pspace_data): Update.
8024         (ada_pspace_data_cleanup): Remove.
8025
8026 2019-05-08  Tom Tromey  <tom@tromey.com>
8027
8028         * coffread.c (struct coff_symfile_info): Add initializers.
8029         (coff_objfile_data_key): Move lower.  Change type.
8030         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8031         Update.
8032         (coff_free_info): Remove.
8033
8034 2019-05-08  Tom Tromey  <tom@tromey.com>
8035
8036         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8037         (fbsd_pspace_data_handle): Move lower.  Change type.
8038         (get_fbsd_pspace_data): Update.
8039         (fbsd_pspace_data_cleanup): Remove.
8040         (_initialize_fbsd_tdep): Update.
8041
8042 2019-05-08  Tom Tromey  <tom@tromey.com>
8043
8044         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8045         (get_ada_tasks_pspace_data): Update.
8046         (ada_tasks_pspace_data_cleanup): Remove.
8047         (_initialize_tasks): Update.
8048         (ada_tasks_inferior_data_handle): Change type.
8049         (get_ada_tasks_inferior_data): Update.
8050         (ada_tasks_inferior_data_cleanup): Remove.
8051         (struct ada_tasks_pspace_data): Add initializers.
8052
8053 2019-05-08  Tom Tromey  <tom@tromey.com>
8054
8055         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8056         * symfile-debug.c (debug_sym_get_probes): Change type.
8057         * stap-probe.c (handle_stap_probe):
8058         (stap_static_probe_ops::get_probes): Change type.
8059         * probe.h (class static_probe_ops) <get_probes>: Change type.
8060         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8061         (parse_probes_in_pspace): Update.
8062         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8063         Update.
8064         (any_static_probe_ops::get_probes): Change type.
8065         * elfread.c (elfread_data): New typedef.
8066         (probe_key): Change type.
8067         (elf_get_probes): Likewise.  Update.
8068         (probe_key_free): Remove.
8069         (_initialize_elfread): Update.
8070         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8071         Change type.
8072         (dtrace_process_dof_probe, dtrace_process_dof)
8073         (dtrace_static_probe_ops::get_probe): Change type.
8074
8075 2019-05-08  Tom Tromey  <tom@tromey.com>
8076
8077         * xcoffread.c (struct xcoff_symfile_info): Rename from
8078         coff_symfile_info.  Add initializers.
8079         (xcoff_objfile_data_key): Move lower.  Change type.
8080         (XCOFF_DATA): Rewrite.
8081         (xcoff_free_info): Remove.
8082         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8083         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8084         (xcoff_initial_scan): Update.
8085
8086 2019-05-08  Tom Tromey  <tom@tromey.com>
8087
8088         * solib-svr4.c (struct svr4_info): Add initializers and
8089         destructor.
8090         <probes_table>: Now an htab_up.
8091         (solib_svr4_pspace_data): Change type.
8092         (free_probes_table): Simplify.
8093         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8094         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8095         (probes_table_remove_objfile_probes, register_solib_event_probe)
8096         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8097         (_initialize_svr4_solib): Update.
8098
8099 2019-05-08  Tom Tromey  <tom@tromey.com>
8100
8101         * remote.c (remote_pspace_data): Change type.
8102         (remote_pspace_data_cleanup): Remove.
8103         (get_remote_exec_file, set_pspace_remote_exec_file)
8104         (_initialize_remote): Update.
8105
8106 2019-05-08  Tom Tromey  <tom@tromey.com>
8107
8108         * breakpoint.c (breakpoint_objfile_key): Change type.
8109         (get_breakpoint_objfile_data): Update.
8110         (free_breakpoint_objfile_data): Remove.
8111         (_initialize_breakpoint): Update.
8112
8113 2019-05-08  Tom Tromey  <tom@tromey.com>
8114
8115         * linux-tdep.c (struct linux_info): Add initializers.
8116         (linux_inferior_data): Move.  Change type.
8117         (invalidate_linux_cache_inf): Update.
8118         (linux_inferior_data_cleanup): Remove.
8119         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8120
8121 2019-05-08  Tom Tromey  <tom@tromey.com>
8122
8123         * auxv.c (auxv_inferior_data): Move.  Change type.
8124         (auxv_inferior_data_cleanup): Remove.
8125         (invalidate_auxv_cache_inf): Rewrite.
8126         (get_auxv_inferior_data, _initialize_auxv): Update.
8127
8128 2019-05-08  Tom Tromey  <tom@tromey.com>
8129
8130         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8131         (symfile_debug_objfile_data_key): Change type.
8132         (symfile_debug_installed, debug_qf_has_symbols)
8133         (debug_qf_find_last_source_symtab)
8134         (debug_qf_forget_cached_source_info)
8135         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8136         (debug_qf_print_stats, debug_qf_dump)
8137         (debug_qf_expand_symtabs_for_function)
8138         (debug_qf_expand_all_symtabs)
8139         (debug_qf_expand_symtabs_with_fullname)
8140         (debug_qf_map_matching_symbols)
8141         (debug_qf_expand_symtabs_matching)
8142         (debug_qf_find_pc_sect_compunit_symtab)
8143         (debug_qf_map_symbol_filenames)
8144         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8145         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8146         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8147         (debug_sym_read_linetable, debug_sym_relocate): Update.
8148         (symfile_debug_free_objfile): Remove.
8149         (install_symfile_debug_logging, _initialize_symfile_debug):
8150         Update.
8151
8152 2019-05-08  Tom Tromey  <tom@tromey.com>
8153
8154         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8155         allocate_on_obstack.
8156         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8157         (get_dwarf2_per_objfile): Update.
8158         (set_dwarf2_per_objfile): Remove.
8159         (dwarf2_has_info, dwarf2_get_section_info): Update.
8160         (dwarf2_free_objfile): Remove.
8161         (_initialize_dwarf2_read): Update.
8162
8163 2019-05-08  Tom Tromey  <tom@tromey.com>
8164
8165         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8166         initializers.
8167         <unsupported_script_warning_printed,
8168         script_not_found_warning_printed>: Now bool.
8169         (auto_load_pspace_data): Change type.
8170         (~auto_load_pspace_info): Rename from
8171         auto_load_pspace_data_cleanup.
8172         (get_auto_load_pspace_data, init_loaded_scripts_info)
8173         (clear_section_scripts, maybe_print_unsupported_script_warning)
8174         (maybe_print_script_not_found_warning, _initialize_auto_load):
8175         Update.
8176
8177 2019-05-08  Tom Tromey  <tom@tromey.com>
8178
8179         * objfiles.c (objfile_pspace_info): Add destructor and
8180         initializers.
8181         (objfiles_pspace_data): Change type.
8182         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8183         (get_objfile_pspace_data): Update.
8184         (objfiles_bfd_data): Change type.
8185         (get_objfile_bfd_data): Update.
8186         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8187
8188 2019-05-08  Tom Tromey  <tom@tromey.com>
8189
8190         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8191         Change type.
8192         (get_catch_syscall_inferior_data): Update.
8193         (catch_syscall_inferior_data_cleanup): Remove.
8194         (_initialize_break_catch_syscall): Update.
8195
8196 2019-05-08  Tom Tromey  <tom@tromey.com>
8197
8198         * inflow.c (struct terminal_info): Add destructor and
8199         initializers.
8200         (inflow_inferior_data): Change type.
8201         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8202         (get_inflow_inferior_data, inflow_inferior_exit)
8203         (swap_terminal_info, _initialize_inflow): Update.
8204
8205 2019-05-08  Tom Tromey  <tom@tromey.com>
8206
8207         * target-dcache.c (target_dcache_cleanup): Remove.
8208         (target_dcache_aspace_key): Change type.
8209         (target_dcache_init_p, target_dcache_invalidate)
8210         (target_dcache_get, target_dcache_get_or_init)
8211         (_initialize_target_dcache): Update.
8212         * dcache.h (struct dcache_deleter): New.
8213
8214 2019-05-08  Tom Tromey  <tom@tromey.com>
8215
8216         * symtab.c (struct symbol_cache): Add destructor and
8217         initializers.
8218         (symbol_cache_key): Move.  Change type.
8219         (make_symbol_cache, free_symbol_cache): Remove.
8220         (get_symbol_cache): Update.
8221         (symbol_cache_cleanup): Remove.
8222         (ALL_PSPACES, symbol_cache_flush)
8223         (maintenance_print_symbol_cache)
8224         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8225         Update.
8226
8227 2019-05-08  Tom Tromey  <tom@tromey.com>
8228
8229         * symtab.c (struct main_info): Add destructor and initializers.
8230         (main_progspace_key): Move.  Change type.
8231         (get_main_info): Update.
8232         (main_info_cleanup): Remove.
8233         (_initialize_symtab): Update.
8234
8235 2019-05-08  Tom Tromey  <tom@tromey.com>
8236
8237         * registry.h (DECLARE_REGISTRY): Define the _key class.
8238
8239 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * NEWS: Merge two 'New commands' sections.
8242
8243 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8244
8245         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8246         parameter and use Ada language definition instead.
8247         (ada_val_print_ptr): Remove unused language parameter.
8248         (ada_val_print_num): Remove language parameter and use Ada language
8249         definition instead.
8250         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8251         parameter.
8252         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8253         parameter and use Ada language definition instead.
8254         (ada_val_print_1): Update all ada_val_print_xxx calls.
8255         Remove language parameter.
8256         (ada_val_print): Update ada_val_print_1 call.
8257
8258 2019-05-08  Tom Tromey  <tromey@adacore.com>
8259
8260         * remote.c (remote_hw_watchpoint_limit)
8261         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8262         Now static.
8263
8264 2019-05-08  Tom Tromey  <tromey@adacore.com>
8265
8266         * maint.c (_initialize_maint_cmds): Move initialization code to
8267         remote.c.
8268         (watchdog, show_watchdog): Move to remote.c.
8269         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8270         "watchdog" static.
8271         (_initialize_remote): Move initialization code from maint.c.
8272         * defs.h (watchdog): Don't declare.
8273
8274 2019-05-08  Tom Tromey  <tromey@adacore.com>
8275
8276         * tui/tui-interp.c: Include main.h.
8277         * interps.c: Include main.h.
8278         * main.h (interpreter_p): Declare.
8279         * defs.h (interpreter_p): Don't declare.
8280
8281 2019-05-08  Tom Tromey  <tromey@adacore.com>
8282
8283         * dwarf2loc.c: Include dwarf2read.h.
8284         * defs.h (read_unsigned_leb128): Don't declare.
8285         * dwarf2read.h (read_unsigned_leb128): Declare.
8286
8287 2019-05-08  Tom Tromey  <tromey@adacore.com>
8288
8289         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8290         method.
8291
8292 2019-05-08  Tom Tromey  <tromey@adacore.com>
8293
8294         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8295         when no wrap column is set.
8296
8297 2019-05-08  Tom Tromey  <tromey@adacore.com>
8298
8299         * c-lang.c (c_get_string): Handle non-C-style arrays.
8300
8301 2019-05-08  Tom Tromey  <tromey@adacore.com>
8302
8303         * typeprint.c (print_offset_data::update): Print the bit offset,
8304         not the number of bits remaining.
8305
8306 2019-05-08  Tom Tromey  <tromey@adacore.com>
8307
8308         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8309         padding at end of comment.
8310
8311 2019-05-08  Tom Tromey  <tromey@adacore.com>
8312
8313         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8314         Compare main types.
8315
8316 2019-05-06  Tom Tromey  <tom@tromey.com>
8317
8318         * common/scoped_mmap.c: Include common-defs.h.
8319         * common/scoped_mmap.h: Don't include config.h.
8320
8321 2019-05-04  Tom Tromey  <tom@tromey.com>
8322
8323         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8324         (struct aarch64_call_info): Add initializers.
8325         <si>: Now a std::vector.
8326         (pass_on_stack, aarch64_push_dummy_call): Update.
8327
8328 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8329             Tom Tromey  <tom@tromey.com>
8330
8331         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8332         (ppc_threads): Now a std::vector.  Now static.
8333         (hwdebug_find_thread_points_by_tid)
8334         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8335         Update.
8336
8337 2019-05-04  Tom Tromey  <tom@tromey.com>
8338
8339         * arc-tdep.c (arc_tdesc_init): Return bool.
8340
8341 2019-05-04  Tom Tromey  <tom@tromey.com>
8342
8343         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8344         Use gdb_assert_not_reached.
8345
8346 2019-05-04  Tom Tromey  <tom@tromey.com>
8347
8348         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8349         "false".
8350
8351 2019-05-04  Tom Tromey  <tom@tromey.com>
8352
8353         * arc-tdep.c (arc_tdesc_init): Use bool.
8354
8355 2019-05-04  Tom Tromey  <tom@tromey.com>
8356
8357         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8358
8359 2019-05-04  Tom Tromey  <tom@tromey.com>
8360
8361         * cli/cli-cmds.c (valid_command_p): Return bool.
8362
8363 2019-05-04  Tom Tromey  <tom@tromey.com>
8364
8365         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8366         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8367
8368 2019-05-04  Raul Tambre  <raul@tambre.ee>
8369
8370         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8371         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8372         operator for comparison.
8373
8374 2019-05-04  Tom Tromey  <tom@tromey.com>
8375
8376         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8377         (lookup_partial_symbol, print_partial_symbols)
8378         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8379         (psymbol_compare): Update.
8380         (add_psymbol_to_bcache): Clear the entire psymbol.
8381         (maintenance_check_psymtabs): Update.
8382         * psympriv.h (struct partial_symbol): Don't derive from
8383         general_symbol_info.
8384         <obj_section, unrelocated_address, address,
8385         set_unrelocated_address>: Update.
8386         <ginfo>: New member.
8387         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8388         (debug_names::write_psymbols): Update.
8389
8390 2019-05-04  Tom de Vries  <tdevries@suse.de>
8391
8392         * contrib/cc-with-tweaks.sh: Support -n arg.
8393
8394 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8395
8396         * corelow.c (core_target::detach): Ensure frame cache and
8397         register caches are cleared.
8398         inferior.c (exit_inferior_1): Likewise.
8399
8400 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8401             Tom Tromey  <tom@tromey.com>
8402
8403         * dictionary.c (collate_pending_symbols_by_language): Remove
8404         "struct" from foreach.
8405         * symtab.c (lookup_global_symbol_from_objfile)
8406         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8407         foreach.
8408         * ser-tcp.c (net_open): Remove "struct" from foreach.
8409         * objfiles.c (objfile_relocate, objfile_rebase)
8410         (objfile_has_symbols): Remove "struct" from foreach.
8411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8412         from foreach.
8413         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8414         foreach.
8415         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8416         "struct" from foreach.
8417         * ada-lang.c (create_excep_cond_exprs)
8418         (ada_exception_catchpoint_cond_string): Remove "struct" from
8419         foreach.
8420
8421 2019-05-03  Tom Tromey  <tromey@adacore.com>
8422
8423         * ada-exp.y (convert_char_literal): Check suffix of each
8424         enumerator.
8425
8426 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8427
8428         PR ada/21406:
8429         * ada-exp.y (yywrap): Don't define.
8430         * ada-lex.l (%option): Add noyywrap
8431         (yywrap): Remove.
8432
8433 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8434
8435         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8436         _WIN32_WINNT to the XP level, unless already defined to a higher
8437         level.
8438
8439         * unittests/parse-connection-spec-selftests.c:
8440         * ser-tcp.c:
8441         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8442         override.
8443
8444         * symfile.c (find_separate_debug_file): Remove colon from the
8445         drive spec of DOS/Windows file names of the target, so that the
8446         file name produced from DEBUGDIR and the target's directory will
8447         be valid on DOS/Windows systems.
8448
8449 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8450
8451         * rust-lang.c (val_print_struct): Handle printing structures
8452         containing strings.
8453
8454 2019-05-02  Tom Tromey  <tromey@adacore.com>
8455
8456         * valarith.c (_initialize_valarith): Remove.
8457
8458 2019-05-01  Tom Tromey  <tromey@adacore.com>
8459
8460         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8461         bitfields.
8462
8463 2019-05-01  Tom Tromey  <tromey@adacore.com>
8464
8465         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8466         for big-endian copies.
8467
8468 2019-04-30  Ali Tamur  <tamur@google.com>
8469         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8470         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8471         (read_3_bytes): New function.
8472
8473 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8474
8475         * windows-nat.c (main_thread_id): Delete.
8476         (handle_output_debug_string): Replace main_thread_id by
8477         current_event.dwThreadId.
8478         (fake_create_process): Likewise.
8479         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8480         Do not set main_thread_id.
8481         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8482         current_event.dwThreadId.
8483         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8484
8485 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8486
8487         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8488         Use current_event.dwThreadId instead of main_thread_id.
8489
8490 2019-04-30  Tom Tromey  <tromey@adacore.com>
8491
8492         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8493         (create_excep_cond_exprs): Iterate over program spaces.
8494         (ada_exception_catchpoint_cond_string): Examine all minimal
8495         symbols for exception types.
8496
8497 2019-04-30  Tom Tromey  <tromey@adacore.com>
8498
8499         PR c++/24470:
8500         * dwarf2read.c (process_structure_scope): Handle case where type
8501         has template parameters but no symbol was created.
8502
8503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8504             Chris January  <chris.january@arm.com>
8505
8506         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8507         qualifier.
8508         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8509
8510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8511
8512         * f-typeprint.c (f_print_type): Update rules for printing
8513         whitespace.
8514         (f_type_print_varspec_suffix): Likewise.
8515
8516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8517             Chris January  <chris.january@arm.com>
8518
8519         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8520         function arguments.
8521
8522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * f-lang.c (build_fortran_types): Change name of void type to
8525         lower case.
8526         * f-typeprint.c (f_type_print_base): Print the name of the void
8527         type, rather than a fixed string.
8528         * f-valprint.c (f_decorations): Use lower case void string.
8529
8530 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8531             Chris January  <chris.january@arm.com>
8532
8533         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8534         types for Fortran.
8535
8536 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8537             Chris January  <chris.january@arm.com>
8538             David Lecomber  <david.lecomber@arm.com>
8539
8540         * f-exp.y (BINOP_INTRINSIC): New token.
8541         (exp): New parser rule handling BINOP_INTRINSIC.
8542         (f77_keywords): Add new builtin procedures.
8543         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8544         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8545         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8546         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8547         (print_unop_subexp_f): New function.
8548         (print_binop_subexp_f): New function.
8549         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8550         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8551         (dump_subexp_body_f): Likewise.
8552         (operator_check_f): Likewise.
8553         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8554         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8555
8556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8557
8558         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8559         UNOP_KIND.
8560         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8561         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8562         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8563         (operator_length_f): New fuction.
8564         (print_subexp_f): New function.
8565         (op_name_f): New function.
8566         (dump_subexp_body_f): New function.
8567         (operator_check_f): New function.
8568         (exp_descriptor_f): Replace standard expression handling functions
8569         with new functions.
8570         * gdb/fortran-operator.def: New file.
8571         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8572         * gdb/std-operator.def: Remove UNOP_KIND.
8573
8574 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * std-operator.def: Remove unbalanced, stray double quote
8577         character.
8578
8579 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8580             Chris January  <chris.january@arm.com>
8581             Daniel Everett  <daniel.everett@arm.com>
8582             Nick Forrington  <nick.forrington@arm.com>
8583             Richard Bunt  <richard.bunt@arm.com>
8584
8585         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8586         of depth when printing anonymous structs or unions.
8587         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8588         Don't print either the top-level value, or the children if the
8589         max-depth is exceeded.
8590         (ppscm_print_children): When printing the key of a map, allow one
8591         extra level of depth.
8592         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8593         print either the top-level value, or the children if the max-depth
8594         is exceeded.
8595         (print_children): When printing the key of a map, allow one extra
8596         level of depth.
8597         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8598         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8599         (user_print_options): Initialise max_depth field.
8600         (val_print_scalar_or_string_type_p): New function.
8601         (val_print): Check to see if the max depth has been reached.
8602         (val_print_check_max_depth): Define new function.
8603         (show_print_max_depth): New function.
8604         (_initialize_valprint): Add 'print max-depth' option.
8605         * valprint.h (struct value_print_options) <max_depth>: New field.
8606         (val_print_check_max_depth): Declare new function.
8607         * NEWS: Document new feature.
8608
8609 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * ada-lang.c (ada_language_defn): Initialise new field.
8612         * c-lang.c (c_is_string_type_p): New function.
8613         (c_language_defn): Initialise new field.
8614         (cplus_language_defn): Initialise new field.
8615         (asm_language_defn): Initialise new field.
8616         (minimal_language_defn): Initialise new field.
8617         * c-lang.h (c_is_string_type_p): Declare new function.
8618         * d-lang.c (d_language_defn): Initialise new field.
8619         * f-lang.c (f_is_string_type_p): New function.
8620         (f_language_defn): Initialise new field.
8621         * go-lang.c (go_is_string_type_p): New function.
8622         (go_language_defn): Initialise new field.
8623         * language.c (default_is_string_type_p): New function.
8624         (unknown_language_defn): Initialise new field.
8625         (auto_language_defn): Initialise new field.
8626         * language.h (struct language_defn) <la_is_string_type_p>: New
8627         member variable.
8628         (default_is_string_type_p): Declare new function.
8629         * m2-lang.c (m2_language_defn): Initialise new field.
8630         * objc-lang.c (objc_language_defn): Initialise new field.
8631         * opencl-lang.c (opencl_language_defn): Initialise new field.
8632         * p-lang.c (pascal_is_string_type_p): New function.
8633         (pascal_language_defn): Initialise new field.
8634         * rust-lang.c (rust_is_string_type_p): New function.
8635         (rust_language_defn): Initialise new field.
8636
8637 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8638
8639         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8640         New field.
8641         * ada-lang.c (ada_language_defn): Initialise new field.
8642         * c-lang.c (c_language_defn): Likewise.
8643         (cplus_language_defn): Likewise.
8644         (asm_language_defn): Likewise.
8645         (minimal_language_defn): Likewise.
8646         * d-lang.c (d_language_defn): Likewise.
8647         * f-lang.c (f_language_defn): Likewise.
8648         * go-lang.c (go_language_defn): Likewise.
8649         * language.c (unknown_language_defn): Likewise.
8650         (auto_language_defn): Likewise.
8651         * m2-lang.c (m2_language_defn): Likewise.
8652         * objc-lang.c (objc_language_defn): Likewise.
8653         * opencl-lang.c (opencl_language_defn): Likewise.
8654         * p-lang.c (pascal_language_defn): Likewise.
8655         * rust-lang.c (rust_language_defn): Likewise.
8656
8657 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8658
8659         * ada-lang.c (ada_is_character_type): Change return type to bool.
8660         (ada_is_string_type): Likewise.
8661         * ada-lang.h (ada_is_character_type): Update declaration
8662         (ada_is_string_type): Likewise.
8663
8664 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8665
8666         Support style in 'frame|thread apply'
8667
8668         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8669         * record.c (record_start, record_stop): Update callers of
8670         execute_command_to_string with false.
8671         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8672         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8673         methods.
8674         (class string_file): New constructor with term_out parameter.
8675         Override methods term_out and can_emit_style_escape.  New member
8676         term_out.
8677         (class stdio_file): Override can_emit_style_escape.
8678         (class tee_file): Override term_out and can_emit_style_escape.
8679         * utils.h (can_emit_style_escape): Remove.
8680         * utils.c (can_emit_style_escape): Likewise.
8681         Update all callers of can_emit_style_escape (SOMESTREAM) to
8682         SOMESTREAM->can_emit_style_escape.
8683         * source-cache.c (source_cache::get_source_lines): Likewise.
8684         * stack.c (frame_apply_command_count): Call execute_command_to_string
8685         passing the term_out characteristic of the current gdb_stdout.
8686         * thread.c (thr_try_catch_cmd): Likewise.
8687         * top.c (execute_command_to_string): pass term_out parameter
8688         to construct the string_file for the command output.
8689         * ui-file.c (term_cli_styling): New function (most code moved
8690         from utils.c can_emit_style_escape).
8691         (string_file::string_file, string_file::can_emit_style_escape,
8692         stdio_file::can_emit_style_escape, tee_file::term_out,
8693         tee_file::can_emit_style_escape): New functions.
8694
8695 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8696
8697         * NEWS: Mention the new set|show may-call-functions.
8698         * infcall.c (may_call_functions_p): New variable.
8699         (show_may_call_functions_p): New function.
8700         (call_function_by_hand_dummy): Throws an error if not
8701         may-call-functions.
8702         (_initialize_infcall): Call add_setshow_boolean_cmd for
8703         may-call-functions.
8704
8705 2019-04-25  Keith Seitz  <keiths@redhat.com>
8706
8707         PR c++/24367
8708         * cp-support.c (inspect_type): Don't attempt substitutions
8709         of symbol with the same name.
8710
8711 2019-04-25  Tom Tromey  <tromey@adacore.com>
8712
8713         PR gdb/24475:
8714         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8715         static.
8716
8717 2019-04-25  Tom Tromey  <tromey@adacore.com>
8718
8719         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8720         rvalue reference.
8721         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8722         (gdb_xml_parser::parse): Use std::move.
8723         * python/python-internal.h (gdbpy_convert_exception): Take a const
8724         reference.
8725         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8726         std::move.
8727         * python/py-utils.c (gdbpy_convert_exception): Take a const
8728         reference.
8729         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8730         Use std::move.
8731         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8732         Use std::move.
8733         * mi/mi-main.c (mi_print_exception): Take a const reference.
8734         * main.c (handle_command_errors): Take a const reference.
8735         * linespec.c (parse_linespec): Use std::move.
8736         * infcall.c (run_inferior_call): Use std::move.
8737         (call_function_by_hand_dummy): Use std::move.
8738         * exec.c (try_open_exec_file): Use std::move.
8739         * exceptions.h (exception_print, exception_fprintf)
8740         (exception_print_same): Update.
8741         * exceptions.c (print_exception, exception_print)
8742         (exception_fprintf, exception_print_same): Change parameters to
8743         const reference.
8744         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8745         * common/new-op.c: Use std::move.
8746         * common/common-exceptions.h (struct gdb_exception): Add move
8747         constructor.
8748         (struct gdb_exception_error, struct gdb_exception_quit, struct
8749         gdb_quit_bad_alloc): Change constructor to move constructor.
8750         (throw_exception): Change parameter to rvalue reference.
8751         * common/common-exceptions.c (throw_exception): Take rvalue
8752         reference.
8753         * cli/cli-interp.c (safe_execute_command): Use std::move.
8754         * breakpoint.c (insert_bp_location, location_to_sals): Use
8755         std::move.
8756
8757 2019-04-25  Tom Tromey  <tromey@adacore.com>
8758
8759         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8760         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8761         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8762         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8763         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8764         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8765         guile/scm-value.c: Use unpack.
8766         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8767         gdbscm_gdb_exception.
8768         (gdbscm_throw_gdb_exception): Likewise.
8769         (struct gdbscm_gdb_exception): New.
8770         (unpack): New function.
8771         (gdbscm_wrap): Use unpack.
8772
8773 2019-04-25  Tom Tromey  <tromey@adacore.com>
8774
8775         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8776         (gdb_rl_callback_handler): Use std::move.
8777         * common/common-exceptions.h (struct gdb_exception): Add move
8778         assignment operator.
8779         (throw_exception_sjlj): Change "exception" to const reference.
8780         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8781         (throw_exception_sjlj): Change "exception" to const reference.
8782
8783 2019-04-25  Tom Tromey  <tromey@adacore.com>
8784
8785         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8786         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8787         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8788         Update.
8789         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8790         Update.
8791         * mi/mi-interp.c (mi_interp::exec): Update.
8792         * linespec.c (parse_linespec): Update.
8793         * infcall.c (run_inferior_call): Update.
8794         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8795         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8796         (gdbscm_lookup_global_symbol): Update.
8797         * guile/scm-param.c (gdbscm_parameter_value): Update.
8798         * guile/scm-frame.c (gdbscm_frame_read_register)
8799         (gdbscm_frame_read_var): Update.
8800         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8801         * exec.c (try_open_exec_file): Update.
8802         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8803         (gdb_rl_callback_handler): Update.
8804         * common/common-exceptions.h (exception_none): Don't declare.
8805         * common/common-exceptions.c (exception_none): Don't define.
8806         (struct catcher) <exception>: Update.
8807         * cli/cli-interp.c (safe_execute_command): Update.
8808         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8809
8810 2019-04-25  Ali Tamur  <tamur@google.com>
8811
8812         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8813         (read_attribute_value): Likewise.
8814         (dwarf2_read_addr_index): Update comment.
8815         (read_str_index): Add DW_FORM_strx.
8816         (dwarf2_string_attr): Likewise.
8817         (dwarf2_const_value_attr): Likewise.
8818         (dump_die_shallow): Likewise.
8819         (dwarf2_fetch_constant_bytes): Likewise.
8820         (skip_form_bytes): Likewise.
8821         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8822
8823 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8824
8825         PR corefiles/11608
8826         PR corefiles/18187
8827         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8828         OFFSET.  Verify if current mapping contains an ELF header.
8829         (linux_find_memory_regions_full): Adjust call to
8830         dump_mapping_p.
8831
8832 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8833             Kang Li <kanglictf@gmail.com>
8834
8835         PR gdb/21600
8836
8837         * dwarf2-frame.c (read_initial_length): Be consistent about using
8838         unsigned representation of length.
8839         (decode_frame_entry_1): Likewise.  Check for wraparound of
8840         end pointer as well as buffer overflow.
8841
8842 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8843
8844         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8845         "vq".
8846
8847 2019-04-24  Tom Tromey  <tromey@adacore.com>
8848
8849         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8850
8851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8852
8853         * s12z-tdep.c (s12z_unwind_pc): Delete.
8854         (s12z_unwind_sp): Delete.
8855         (s12z_gdbarch_init): Don't register deleted functions with
8856         gdbarch.
8857
8858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * rl78-tdep.c (rl78_unwind_sp): Delete.
8861         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8862
8863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8864
8865         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8866         (xstormy16_unwind_pc): Delete.
8867         (xstormy16_dummy_id): Delete.
8868         (xstormy16_gdbarch_init): Don't register deleted functions with
8869         gdbarch.
8870
8871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8872
8873         * vax-tdep.c (vax_unwind_pc): Delete.
8874         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8875
8876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8877
8878         * v850-tdep.c (v850_unwind_sp): Delete.
8879         (v850_unwind_pc): Delete.
8880         (v850_dummy_id): Delete.
8881         (v850_gdbarch_init): Don't register deleted functions with
8882         gdbarch.
8883
8884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8885
8886         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8887         (tilegx_unwind_pc): Delete.
8888         (tilegx_unwind_dummy_id): Delete.
8889         (tilegx_gdbarch_init): Don't register deleted functions with
8890         gdbarch.
8891
8892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8893
8894         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8895         (tic6x_dummy_id): Delete.
8896         (tic6x_gdbarch_init): Don't register deleted functions with
8897         gdbarch.
8898
8899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8900
8901         * sparc-tdep.c (sparc_unwind_pc): Delete.
8902         (sparc32_gdbarch_init): Don't register deleted function with
8903         gdbarch.
8904
8905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8906
8907         * sh-tdep.c (sh_unwind_sp): Delete.
8908         (sh_unwind_pc): Delete.
8909         (sh_dummy_id): Delete.
8910         (sh_gdbarch_init): Don't register deleted functions with
8911         gdbarch.
8912
8913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * score-tdep.c (score_unwind_sp): Delete.
8916         (score_unwind_pc): Delete.
8917         (score_dummy_id): Delete.
8918         (score_gdbarch_init): Don't register deleted functions with
8919         gdbarch.
8920
8921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8922
8923         * rx-tdep.c (rx_unwind_pc): Delete.
8924         (rx_unwind_sp): Delete.
8925         (rx_dummy_id): Delete.
8926         (rx_gdbarch_init): Don't register deleted functions with
8927         gdbarch.  Update comment.
8928
8929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8932         (rs6000_dummy_id): Delete.
8933         (rs6000_gdbarch_init): Don't register deleted functions with
8934         gdbarch.
8935
8936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * or1k-tdep.c (or1k_dummy_id): Delete.
8939         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8940
8941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8942
8943         * nios2-tdep.c (nios2_dummy_id): Delete.
8944         (nios2_unwind_sp): Delete.
8945         (nios2_gdbarch_init): Don't register deleted functions with
8946         gdbarch.
8947
8948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * nds32-tdep.c (nds32_dummy_id): Delete.
8951         (nds32_unwind_pc): Delete.
8952         (nds32_unwind_sp): Delete.
8953         (nds32_gdbarch_init): Don't register deleted functions with
8954         gdbarch.
8955
8956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * msp430-tdep.c (msp430_unwind_pc): Delete.
8959         (msp430_unwind_sp): Delete.
8960         (msp430_dummy_id): Delete.
8961         (msp430_gdbarch_init): Don't register deleted functions with
8962         gdbarch.
8963
8964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8965
8966         * moxie-tdep.c (moxie_unwind_sp): Delete.
8967         (moxie_unwind_pc): Delete.
8968         (moxie_dummy_id): Delete.
8969         (moxie_gdbarch_init): Don't register deleted functions with
8970         gdbarch.
8971
8972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8973
8974         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8975         (mn10300_unwind_pc): Delete.
8976         (mn10300_unwind_sp): Delete.
8977         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8978         mn10300_unwind_sp.
8979         (mn10300_frame_unwind_init): Don't register deleted functions with
8980         gdbarch.
8981
8982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8983
8984         * mep-tdep.c (mep_unwind_pc): Delete.
8985         (mep_unwind_sp): Delete.
8986         (mep_dummy_id): Delete.
8987         (mep_gdbarch_init): Don't register deleted functions with
8988         gdbarch.
8989
8990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8991
8992         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8993         (m68hc11_unwind_sp): Delete.
8994         (m68hc11_gdbarch_init): Don't register deleted functions with
8995         gdbarch.
8996
8997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * m32r-tdep.c (m32r_unwind_sp): Delete.
9000         (m32r_unwind_pc): Delete.
9001         (m32r_dummy_id): Delete.
9002         (m32r_gdbarch_init): Don't register deleted functions with
9003         gdbarch.
9004
9005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * m32c-tdep.c (m32c_unwind_pc): Delete.
9008         (m32c_unwind_sp): Delete.
9009         (m32c_dummy_id): Delete.
9010         (m32c_gdbarch_init): Don't register deleted functions with
9011         gdbarch.
9012
9013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9016         (lm32_unwind_pc): Delete.
9017         (lm32_dummy_id): Delete.
9018         (lm32_gdbarch_init): Don't register deleted functions with
9019         gdbarch.
9020
9021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9024         (iq2000_unwind_pc): Delete.
9025         (iq2000_dummy_id): Delete.
9026         (iq2000_gdbarch_init): Don't register deleted functions with
9027         gdbarch.
9028
9029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9030
9031         * nds32-tdep.c (nds32_type_align): Delete.
9032         (nds32_push_dummy_call): Use type_align instead.
9033
9034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9035
9036         * arm-tdep.c (arm_type_align): Only handle vector override case.
9037         (arm_push_dummy_call): Use type_align.
9038         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9039
9040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9041
9042         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9043         case.
9044         (pass_on_stack): Use type_align.
9045         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9046         function.
9047
9048 2019-04-23  Tom Tromey  <tromey@adacore.com>
9049
9050         * dwarf2read.c (line_header::file_name_at): Remove unused
9051         overload.
9052
9053 2019-04-23  Tom de Vries  <tdevries@suse.de>
9054
9055         PR gdb/24438
9056         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9057         invocation.
9058
9059
9060 2019-03-27  Ali Tamur  <tamur@google.com>
9061
9062         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9063         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9064         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9065         (dwarf_expr_context::get_addr_index): Likewise
9066         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9067         (symbol_needs_eval_context::get_addr_index): Likewise
9068         (disassemble_dwarf_expression): Add DW_OP_addrx
9069         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9070         (read_cutu_die_from_dwo): Update comment
9071         (skip_one_die): Add DW_FORM_addrx
9072         (read_attribute_value): Likewise
9073         (var_decode_location): Add DW_OP_addrx
9074         (dwarf2_const_value_attr): Add DW_FORM_addrx
9075         (dump_die_shallow): Likewise
9076         (dwarf2_fetch_constant_bytes): Likewise
9077         (decode_locdesc): Add DW_OP_addrx
9078         (skip_form_bytes): Add DW_FORM_addrx
9079
9080 2019-04-22  Ali Tamur  <tamur@google.com>
9081
9082         * MAINTAINERS (Write After Approval): Add self.
9083
9084 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9085
9086         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9087         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9088         (open_symbol_file_object): Likewise.
9089         (svr4_default_sos): Add info parameter.
9090         (svr4_read_so_list): Likewise.
9091         (svr4_current_sos_direct): Adjust functions calls to pass down
9092         info.
9093         (svr4_current_sos_1): Add info parameter.
9094         (svr4_current_sos): Call get_svr4_info, pass info down to
9095         svr4_current_sos_1.
9096         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9097         get_svr4_info.
9098         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9099         get_svr4_info.
9100         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9101         to get_svr4_info.
9102         (probes_table_remove_objfile_probes): Likewise.
9103         (register_solib_event_probe): Add info parameter.
9104         (solist_update_incremental): Pass info parameter down to
9105         svr4_read_so_list.
9106         (disable_probes_interface): Add info parameter.
9107         (svr4_handle_solib_event): Pass current_program_space to
9108         get_svr4_info.  Adjust disable_probes_interface cleanup.
9109         (svr4_create_probe_breakpoints): Add info parameter, pass it
9110         down to register_solib_event_probe.
9111         (svr4_create_solib_event_breakpoints): Add info parameter,
9112         pass it down to svr4_create_probe_breakpoints.
9113         (enable_break): Pass info down to
9114         svr4_create_solib_event_breakpoints.
9115         (svr4_solib_create_inferior_hook): Pass current_program_space to
9116         get_svr4_info.
9117         (svr4_clear_solib): Likewise.
9118
9119 2019-04-22  Pedro Alves  <palves@redhat.com>
9120
9121         * solib-svr4.c (svr4_free_objfile_observer): New.
9122         (probe_and_action::objfile): New field.
9123         (probes_table_htab_remove_objfile_probes)
9124         (probes_table_remove_objfile_probes): New functions.
9125         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9126         in the new probe_and_action.  Don't store the probe in 'lookup'.
9127         (svr4_create_probe_breakpoints): Pass objfile to
9128         register_solib_event_probe.
9129         (_initialize_svr4_solib): Register a free_objfile observer.
9130
9131 2019-04-19  Tom Tromey  <tom@tromey.com>
9132
9133         * common/queue.h: Remove.
9134
9135 2019-04-19  Tom Tromey  <tom@tromey.com>
9136
9137         * event-loop.c: Don't include "common/queue.h".
9138
9139 2019-04-19  Tom Tromey  <tom@tromey.com>
9140
9141         * remote.c (remote_target): Use delete.
9142         * remote-notif.h: Include <list>, not "common/queue.h".
9143         (notif_client_p): Remove typedef.
9144         (remote_notif_state): Add constructor, destructor, initializer.
9145         <notif_queue>: Now a std::list.
9146         (remote_notif_state_xfree): Don't declare.
9147         * remote-notif.c (remote_notif_process, handle_notification)
9148         (remote_notif_state_allocate): Update.
9149         (~remote_notif_state): Rename from remote_notif_state_xfree.
9150
9151 2019-04-19  Tom Tromey  <tom@tromey.com>
9152
9153         * symfile.c (reread_symbols): Update.
9154         * objfiles.c (objfile_register_static_link)
9155         (objfile_lookup_static_link): Update
9156         (~objfile) Don't delete static_links.
9157         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9158
9159 2019-04-19  Tom Tromey  <tom@tromey.com>
9160
9161         * type-stack.h (struct type_stack) <insert>: Constify string.
9162         * type-stack.c (type_stack::insert): Constify string.
9163         * gdbtypes.h (lookup_template_type): Update.
9164         (address_space_name_to_int): Update.
9165         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9166         const.
9167         (lookup_template_type): Make name const.
9168         * c-exp.y: Update rules.
9169         (lex_one_token, classify_name, classify_inner_name)
9170         (c_print_token): Update.
9171         * p-exp.y: Update rules.
9172         (yylex): Update.
9173         * f-exp.y: Update rules.
9174         (yylex): Update.
9175         * d-exp.y: Update rules.
9176         (lex_one_token, classify_name, classify_inner_name): Update.
9177         * parse.c (write_dollar_variable, copy_name): Return std::string.
9178         * parser-defs.h (copy_name): Change return type.
9179         * m2-exp.y: Update rules.
9180         (yylex): Update.
9181         * go-exp.y (lex_one_token): Update.
9182         Update rules.
9183         (classify_unsafe_function, classify_packaged_name)
9184         (classify_name, yylex): Update.
9185
9186 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9187
9188         * configure.ac: add --enable-source-highlight switch.
9189         * configure: Regenerate.
9190         * top.c (print_gdb_version): plumb --enable-source-highlight
9191         status to "show configuration".
9192
9193 2019-04-19  Tom Tromey  <tromey@adacore.com>
9194
9195         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9196         Check ADA_TYPE_P.
9197         (empty_record, ada_template_to_fixed_record_type_1)
9198         (template_to_static_fixed_type)
9199         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9200         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9201         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9202         macros.
9203
9204 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9205
9206         PR symtab/24423:
9207         * source.c (print_source_lines_base): Advance "iter" when a
9208         control character is seen.
9209
9210 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9211
9212         * inferior.h (struct infcall_suspend_state_deleter):
9213         Catch exception in destructor to avoid crash.
9214
9215 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9216
9217         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9218         close to the add_com "shell".
9219
9220 2019-04-18  Tom Tromey  <tromey@adacore.com>
9221
9222         * process-stratum-target.h (class process_stratum_target)
9223         <stratum>: Add "final".
9224
9225 2019-04-17  Tom Tromey  <tromey@adacore.com>
9226
9227         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9228         against nullptr before use.
9229
9230 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9231
9232         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9233
9234 2019-04-17  Jim Wilson  <jimw@sifive.com>
9235             Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9238         code read might fail, assume 4-byte breakpoint in that case.
9239
9240 2019-04-15  Leszek Swirski  <leszeks@google.com>
9241
9242         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9243         rather than a hand-rolled POD check when checking for forced MEMORY
9244         classification.
9245
9246 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9247
9248         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9249         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9250         function.
9251         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9252         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9253         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9254         declaration.
9255
9256 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9257
9258         * aarch64-linux-nat.c
9259         (aarch64_linux_nat_target::thread_architecture): Add override.
9260         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9261         each VQ.
9262
9263 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9264
9265         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9266
9267 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9270         target types of size 96-bits, add some additional comments, and
9271         check that the builtin type we found was the correct size.
9272
9273 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9274
9275         * utils.c (prompt_for_continue): Don't restore the styling at the
9276         end, as applied_style has the wrong value.  This fixes styling in
9277         long lists of file names that are interrupted by the "Continue?"
9278         prompt.
9279
9280 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9283         * c-lang.c (c_language_defn): Likewise.
9284         (cplus_language_defn): Likewise.
9285         (asm_language_defn): Likewise.
9286         (minimal_language_defn): Likewise.
9287         * d-lang.c (d_language_defn): Likewise.
9288         * f-lang.c (f_language_defn): Likewise.
9289         * go-lang.c (go_language_defn): Likewise.
9290         * language.c (unknown_language_defn): Likewise.
9291         (auto_language_defn): Likewise.
9292         * language.h (struct language_defn): Remove la_magic field.
9293         (LANG_MAGIC): Delete.
9294         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9295         * objc-lang.c (objc_language_defn): Likewise.
9296         * opencl-lang.c (opencl_language_defn): Likewise.
9297         * p-lang.c (pascal_language_defn): Likewise.
9298         * rust-lang.c (rust_language_defn): Likewise.
9299
9300 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * riscv-tdep.c (riscv_type_align): New function.
9303         (riscv_type_alignment): Delete.
9304         (riscv_arg_location): Use 'type_align'.
9305         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9306
9307 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * gdbtypes.c (type_align): A struct with no non-static fields also
9310         has alignment of 1.
9311
9312 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9315         component to 0.
9316         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9317         member.
9318         (riscv_struct_info::analyse): New implementation using new
9319         analyse_inner member function.
9320         (riscv_struct_info::field_offset): New member function.
9321         (riscv_struct_info::m_offsets): New member variable.
9322         (riscv_struct_info::analyse_inner): New private member function,
9323         takes the old implementation of riscv_struct_info::analyse but
9324         extended to track field offsets.
9325         (riscv_call_arg_struct): Update the struct folding special cases
9326         to handle cases where empty C++ structs, which are non-zero
9327         length, are found.
9328         (riscv_arg_location): Initialise the length of each location, a
9329         non-zero length now indicates the location is in use.
9330         (riscv_push_dummy_call): Allow for the first location having a
9331         non-zero offset when setting up arguments.
9332         (riscv_return_value): Likewise, but for return values.
9333
9334 2019-04-11  Tom Tromey  <tromey@adacore.com>
9335
9336         * utils.c (internal_vproblem): Make "msg" const.
9337
9338 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9339
9340         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9341         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9342         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9343         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9344
9345 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9346
9347         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9348         function.
9349         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9350         of amd64_collect_native_gregset.
9351         (amd64_linux_nat_target::store_registers): Likewise.
9352
9353 2019-04-10  Tom Tromey  <tom@tromey.com>
9354
9355         * symtab.c (lookup_global_symbol_from_objfile)
9356         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9357         * objfiles.h (class separate_debug_iterator): New.
9358         (class separate_debug_range): New.
9359         (struct objfile) <separate_debug_objfiles>: New method.
9360         (objfile_separate_debug_iterate): Don't declare.
9361         * objfiles.c (separate_debug_iterator::operator++): Rename from
9362         objfile_separate_debug_iterate.
9363         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9364         iterator.
9365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9366         iterator.
9367
9368 2019-04-10  Tom Tromey  <tom@tromey.com>
9369
9370         * symfile.c (reread_symbols): Remove old comment.
9371         * objfiles.c (free_all_objfiles): Fix a typo.
9372
9373 2019-04-10  Tom Tromey  <tom@tromey.com>
9374
9375         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9376         * minsyms.c (lookup_minimal_symbol): Use foreach.
9377         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9378         (lookup_minimal_symbol_solib_trampoline): Likewise.
9379         * symfile.c (reread_symbols): Use foreach.
9380
9381 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9382             Tom Tromey  <tromey@adacore.com>
9383
9384         PR rust/24414:
9385         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9386         (rust_lex_int_test): Change "value" to be LONGEST.
9387         (rust_lex_tests): Add test for long integer literal.
9388
9389 2019-04-09  Tom Tromey  <tromey@adacore.com>
9390
9391         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9392         to bool.
9393         (extended_remote_target::attach): Update.
9394         (remote_target::remote_notice_new_inferior): Update.
9395         (remote_target::add_current_inferior_and_thread): Update.
9396         * inferior.c (exit_inferior_1): Use "false".
9397         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9398
9399 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9400
9401         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9402         the "start" command.
9403
9404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9405
9406         * python/py-inferior.c (infpy_thread_from_thread_handle):
9407         Adjust comments to reflect renaming of thread_from_thread_handle
9408         to thread_from_handle.  Adjust keywords.  Fix type error message.
9409         (inferior_object_methods): Add thread_from_handle.  Retain
9410         thread_from_thread_handle, but mark it as deprecated.
9411
9412 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9413
9414         * gdbthread.h (find_thread_by_handle): Revise declaration.
9415         * thread.c (find_thread_by_handle): Likewise.  Adjust
9416         implementation too.
9417         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9418         support for buffer objects as handles.
9419
9420 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9421
9422         * python/py-infthread.c (thpy_thread_handle): New function.
9423         (thread_object_methods): Register thpy_thread_handle.
9424
9425 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9426
9427         * gdbthread.h (thread_to_thread_handle): Declare.
9428         * thread.c (gdbtypes.h): Include.
9429         (thread_to_thread_handle): New function.
9430
9431         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9432         (target_thread_info_to_thread_handle): Declare.
9433         * target.c (target_thread_info_to_thread_handle): New function.
9434         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9435         * target-delegates.c: Regenerate.
9436
9437         * linux-thread-db.c (class thread_db_target): Add method
9438         thread_info_to_thread_handle.
9439         (thread_db_target::thread_info_to_thread_handle): Define.
9440         * remote.c (class remote_target): Add new method
9441         thread_info_to_thread_handle.
9442         (remote_target::thread_info_to_thread_handle): Define.
9443
9444 2019-04-08  Pedro Alves  <palves@redhat.com>
9445
9446         * common/common-exceptions.c (throw_exception): Don't create
9447         named object to throw; throw directly.
9448         (throw_it): Likewise.  Don't initialize gdb_exception::message
9449         here, with new; pass FMT and AP to the ctor instead.
9450         * common/common-exceptions.h: Include <string>.
9451         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9452         const char *, va_list)): New ctor.  Use std::make_shared.
9453         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9454         errors)): Delete.
9455         (gdb_exception_error::gdb_exception_error(enum errors, const char
9456         *, va_list)): New.
9457         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9458         Add assertion.
9459         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9460         errors)): Delete.
9461         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9462         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9463         Add assertion.
9464
9465 2019-04-08  Tom Tromey  <tom@tromey.com>
9466
9467         * valops.c (value_rtti_indirect_type): Replace throw_exception
9468         with throw.
9469         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9470         with throw.
9471         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9472         throw.
9473         * target.c (target_translate_tls_address): Replace throw_exception
9474         with throw.
9475         * stack.c (frame_apply_command_count): Replace throw_exception
9476         with throw.
9477         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9478         throw.
9479         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9480         with throw.
9481         * rs6000-tdep.c (rs6000_frame_cache)
9482         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9483         * remote.c: Replace throw_exception with throw.
9484         * record-full.c (record_full_message, record_full_wait_1)
9485         (record_full_restore): Replace throw_exception with throw.
9486         * record-btrace.c:
9487         (get_thread_current_frame_id, record_btrace_start_replaying)
9488         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9489         (cmd_record_btrace_start): Replace throw_exception with throw.
9490         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9491         throw.
9492         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9493         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9494         * linespec.c:
9495         (find_linespec_symbols): Replace throw_exception with throw.
9496         * infrun.c (displaced_step_prepare, resume): Replace
9497         throw_exception with throw.
9498         * infcmd.c (post_create_inferior): Replace throw_exception with
9499         throw.
9500         * inf-loop.c (inferior_event_handler): Replace throw_exception
9501         with throw.
9502         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9503         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9504         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9505         (get_prev_frame_always, get_frame_pc_if_available)
9506         (get_frame_address_in_block_if_available, get_frame_language):
9507         Replace throw_exception with throw.
9508         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9509         throw_exception with throw.
9510         * eval.c (fetch_subexp_value, evaluate_var_value)
9511         (evaluate_funcall, evaluate_subexp_standard): Replace
9512         throw_exception with throw.
9513         * dwarf2loc.c (call_site_find_chain)
9514         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9515         Replace throw_exception with throw.
9516         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9517         with throw.
9518         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9519         throw.
9520         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9521         * completer.c (complete_line_internal): Replace throw_exception
9522         with throw.
9523         * compile/compile-object-run.c (compile_object_run): Replace
9524         throw_exception with throw.
9525         * cli/cli-script.c (process_next_line): Replace throw_exception
9526         with throw.
9527         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9528         (btrace_enable, btrace_maint_update_pt_packets): Replace
9529         throw_exception with throw.
9530         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9531         throw_exception with throw.
9532         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9533         throw_exception with throw.
9534         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9535         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9536         * aarch64-tdep.c (aarch64_make_prologue_cache)
9537         (aarch64_make_stub_cache): Replace throw_exception with throw.
9538
9539 2019-04-08  Tom Tromey  <tom@tromey.com>
9540
9541         * common/common-exceptions.c (throw_exception): Rename from
9542         throw_exception_cxx.  Remove old copy.  Make argument const.
9543         (throw_it): Create and throw exception objects directly.
9544         * common/common-exceptions.h (throw_exception): Make argument
9545         const.
9546         (struct gdb_exception_error): Add constructor.
9547         (struct gdb_exception_quit): Add constructor.
9548
9549 2019-04-08  Tom Tromey  <tom@tromey.com>
9550
9551         * common/common-exceptions.h (exception_rethrow): Don't declare.
9552         (TRY_SJLJ): Update comment.
9553         (TRY, CATCH, END_CATCH): Remove.
9554         * common/common-exceptions.c (exception_rethrow): Remove.
9555
9556 2019-04-08  Tom Tromey  <tom@tromey.com>
9557
9558         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9559         Remove.
9560         (gdb_exception_error): Rename from
9561         gdb_exception_RETURN_MASK_ERROR.
9562         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9563         (gdb_quit_bad_alloc): Update.
9564         * aarch64-tdep.c: Update.
9565         * ada-lang.c: Update.
9566         * ada-typeprint.c: Update.
9567         * ada-valprint.c: Update.
9568         * amd64-tdep.c: Update.
9569         * arch-utils.c: Update.
9570         * break-catch-throw.c: Update.
9571         * breakpoint.c: Update.
9572         * btrace.c: Update.
9573         * c-varobj.c: Update.
9574         * cli/cli-cmds.c: Update.
9575         * cli/cli-interp.c: Update.
9576         * cli/cli-script.c: Update.
9577         * common/common-exceptions.c: Update.
9578         * common/new-op.c: Update.
9579         * common/selftest.c: Update.
9580         * compile/compile-c-symbols.c: Update.
9581         * compile/compile-cplus-symbols.c: Update.
9582         * compile/compile-object-load.c: Update.
9583         * compile/compile-object-run.c: Update.
9584         * completer.c: Update.
9585         * corelow.c: Update.
9586         * cp-abi.c: Update.
9587         * cp-support.c: Update.
9588         * cp-valprint.c: Update.
9589         * darwin-nat.c: Update.
9590         * disasm-selftests.c: Update.
9591         * dtrace-probe.c: Update.
9592         * dwarf-index-cache.c: Update.
9593         * dwarf-index-write.c: Update.
9594         * dwarf2-frame-tailcall.c: Update.
9595         * dwarf2-frame.c: Update.
9596         * dwarf2loc.c: Update.
9597         * dwarf2read.c: Update.
9598         * eval.c: Update.
9599         * event-loop.c: Update.
9600         * event-top.c: Update.
9601         * exec.c: Update.
9602         * f-valprint.c: Update.
9603         * fbsd-tdep.c: Update.
9604         * frame-unwind.c: Update.
9605         * frame.c: Update.
9606         * gdbtypes.c: Update.
9607         * gnu-v3-abi.c: Update.
9608         * guile/guile-internal.h: Update.
9609         * guile/scm-block.c: Update.
9610         * guile/scm-breakpoint.c: Update.
9611         * guile/scm-cmd.c: Update.
9612         * guile/scm-disasm.c: Update.
9613         * guile/scm-frame.c: Update.
9614         * guile/scm-lazy-string.c: Update.
9615         * guile/scm-math.c: Update.
9616         * guile/scm-param.c: Update.
9617         * guile/scm-ports.c: Update.
9618         * guile/scm-pretty-print.c: Update.
9619         * guile/scm-symbol.c: Update.
9620         * guile/scm-symtab.c: Update.
9621         * guile/scm-type.c: Update.
9622         * guile/scm-value.c: Update.
9623         * i386-linux-tdep.c: Update.
9624         * i386-tdep.c: Update.
9625         * inf-loop.c: Update.
9626         * infcall.c: Update.
9627         * infcmd.c: Update.
9628         * infrun.c: Update.
9629         * jit.c: Update.
9630         * language.c: Update.
9631         * linespec.c: Update.
9632         * linux-fork.c: Update.
9633         * linux-nat.c: Update.
9634         * linux-tdep.c: Update.
9635         * linux-thread-db.c: Update.
9636         * main.c: Update.
9637         * mi/mi-cmd-break.c: Update.
9638         * mi/mi-cmd-stack.c: Update.
9639         * mi/mi-interp.c: Update.
9640         * mi/mi-main.c: Update.
9641         * objc-lang.c: Update.
9642         * p-valprint.c: Update.
9643         * parse.c: Update.
9644         * ppc-linux-tdep.c: Update.
9645         * printcmd.c: Update.
9646         * python/py-arch.c: Update.
9647         * python/py-breakpoint.c: Update.
9648         * python/py-cmd.c: Update.
9649         * python/py-finishbreakpoint.c: Update.
9650         * python/py-frame.c: Update.
9651         * python/py-framefilter.c: Update.
9652         * python/py-gdb-readline.c: Update.
9653         * python/py-inferior.c: Update.
9654         * python/py-infthread.c: Update.
9655         * python/py-lazy-string.c: Update.
9656         * python/py-linetable.c: Update.
9657         * python/py-objfile.c: Update.
9658         * python/py-param.c: Update.
9659         * python/py-prettyprint.c: Update.
9660         * python/py-progspace.c: Update.
9661         * python/py-record-btrace.c: Update.
9662         * python/py-record.c: Update.
9663         * python/py-symbol.c: Update.
9664         * python/py-type.c: Update.
9665         * python/py-unwind.c: Update.
9666         * python/py-utils.c: Update.
9667         * python/py-value.c: Update.
9668         * python/python.c: Update.
9669         * record-btrace.c: Update.
9670         * record-full.c: Update.
9671         * remote-fileio.c: Update.
9672         * remote.c: Update.
9673         * riscv-tdep.c: Update.
9674         * rs6000-aix-tdep.c: Update.
9675         * rs6000-tdep.c: Update.
9676         * rust-exp.y: Update.
9677         * rust-lang.c: Update.
9678         * s390-tdep.c: Update.
9679         * selftest-arch.c: Update.
9680         * solib-dsbt.c: Update.
9681         * solib-frv.c: Update.
9682         * solib-spu.c: Update.
9683         * solib-svr4.c: Update.
9684         * solib.c: Update.
9685         * sparc64-linux-tdep.c: Update.
9686         * stack.c: Update.
9687         * symfile-mem.c: Update.
9688         * symmisc.c: Update.
9689         * target.c: Update.
9690         * thread.c: Update.
9691         * top.c: Update.
9692         * tracefile-tfile.c: Update.
9693         * tui/tui.c: Update.
9694         * typeprint.c: Update.
9695         * unittests/cli-utils-selftests.c: Update.
9696         * unittests/parse-connection-spec-selftests.c: Update.
9697         * valops.c: Update.
9698         * valprint.c: Update.
9699         * value.c: Update.
9700         * varobj.c: Update.
9701         * windows-nat.c: Update.
9702         * x86-linux-nat.c: Update.
9703         * xml-support.c: Update.
9704
9705 2019-04-08  Tom Tromey  <tom@tromey.com>
9706
9707         * xml-support.c: Use C++ exception handling.
9708         * x86-linux-nat.c: Use C++ exception handling.
9709         * windows-nat.c: Use C++ exception handling.
9710         * varobj.c: Use C++ exception handling.
9711         * value.c: Use C++ exception handling.
9712         * valprint.c: Use C++ exception handling.
9713         * valops.c: Use C++ exception handling.
9714         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9715         handling.
9716         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9717         * typeprint.c: Use C++ exception handling.
9718         * tui/tui.c: Use C++ exception handling.
9719         * tracefile-tfile.c: Use C++ exception handling.
9720         * top.c: Use C++ exception handling.
9721         * thread.c: Use C++ exception handling.
9722         * target.c: Use C++ exception handling.
9723         * symmisc.c: Use C++ exception handling.
9724         * symfile-mem.c: Use C++ exception handling.
9725         * stack.c: Use C++ exception handling.
9726         * sparc64-linux-tdep.c: Use C++ exception handling.
9727         * solib.c: Use C++ exception handling.
9728         * solib-svr4.c: Use C++ exception handling.
9729         * solib-spu.c: Use C++ exception handling.
9730         * solib-frv.c: Use C++ exception handling.
9731         * solib-dsbt.c: Use C++ exception handling.
9732         * selftest-arch.c: Use C++ exception handling.
9733         * s390-tdep.c: Use C++ exception handling.
9734         * rust-lang.c: Use C++ exception handling.
9735         * rust-exp.y: Use C++ exception handling.
9736         * rs6000-tdep.c: Use C++ exception handling.
9737         * rs6000-aix-tdep.c: Use C++ exception handling.
9738         * riscv-tdep.c: Use C++ exception handling.
9739         * remote.c: Use C++ exception handling.
9740         * remote-fileio.c: Use C++ exception handling.
9741         * record-full.c: Use C++ exception handling.
9742         * record-btrace.c: Use C++ exception handling.
9743         * python/python.c: Use C++ exception handling.
9744         * python/py-value.c: Use C++ exception handling.
9745         * python/py-utils.c: Use C++ exception handling.
9746         * python/py-unwind.c: Use C++ exception handling.
9747         * python/py-type.c: Use C++ exception handling.
9748         * python/py-symbol.c: Use C++ exception handling.
9749         * python/py-record.c: Use C++ exception handling.
9750         * python/py-record-btrace.c: Use C++ exception handling.
9751         * python/py-progspace.c: Use C++ exception handling.
9752         * python/py-prettyprint.c: Use C++ exception handling.
9753         * python/py-param.c: Use C++ exception handling.
9754         * python/py-objfile.c: Use C++ exception handling.
9755         * python/py-linetable.c: Use C++ exception handling.
9756         * python/py-lazy-string.c: Use C++ exception handling.
9757         * python/py-infthread.c: Use C++ exception handling.
9758         * python/py-inferior.c: Use C++ exception handling.
9759         * python/py-gdb-readline.c: Use C++ exception handling.
9760         * python/py-framefilter.c: Use C++ exception handling.
9761         * python/py-frame.c: Use C++ exception handling.
9762         * python/py-finishbreakpoint.c: Use C++ exception handling.
9763         * python/py-cmd.c: Use C++ exception handling.
9764         * python/py-breakpoint.c: Use C++ exception handling.
9765         * python/py-arch.c: Use C++ exception handling.
9766         * printcmd.c: Use C++ exception handling.
9767         * ppc-linux-tdep.c: Use C++ exception handling.
9768         * parse.c: Use C++ exception handling.
9769         * p-valprint.c: Use C++ exception handling.
9770         * objc-lang.c: Use C++ exception handling.
9771         * mi/mi-main.c: Use C++ exception handling.
9772         * mi/mi-interp.c: Use C++ exception handling.
9773         * mi/mi-cmd-stack.c: Use C++ exception handling.
9774         * mi/mi-cmd-break.c: Use C++ exception handling.
9775         * main.c: Use C++ exception handling.
9776         * linux-thread-db.c: Use C++ exception handling.
9777         * linux-tdep.c: Use C++ exception handling.
9778         * linux-nat.c: Use C++ exception handling.
9779         * linux-fork.c: Use C++ exception handling.
9780         * linespec.c: Use C++ exception handling.
9781         * language.c: Use C++ exception handling.
9782         * jit.c: Use C++ exception handling.
9783         * infrun.c: Use C++ exception handling.
9784         * infcmd.c: Use C++ exception handling.
9785         * infcall.c: Use C++ exception handling.
9786         * inf-loop.c: Use C++ exception handling.
9787         * i386-tdep.c: Use C++ exception handling.
9788         * i386-linux-tdep.c: Use C++ exception handling.
9789         * guile/scm-value.c: Use C++ exception handling.
9790         * guile/scm-type.c: Use C++ exception handling.
9791         * guile/scm-symtab.c: Use C++ exception handling.
9792         * guile/scm-symbol.c: Use C++ exception handling.
9793         * guile/scm-pretty-print.c: Use C++ exception handling.
9794         * guile/scm-ports.c: Use C++ exception handling.
9795         * guile/scm-param.c: Use C++ exception handling.
9796         * guile/scm-math.c: Use C++ exception handling.
9797         * guile/scm-lazy-string.c: Use C++ exception handling.
9798         * guile/scm-frame.c: Use C++ exception handling.
9799         * guile/scm-disasm.c: Use C++ exception handling.
9800         * guile/scm-cmd.c: Use C++ exception handling.
9801         * guile/scm-breakpoint.c: Use C++ exception handling.
9802         * guile/scm-block.c: Use C++ exception handling.
9803         * guile/guile-internal.h: Use C++ exception handling.
9804         * gnu-v3-abi.c: Use C++ exception handling.
9805         * gdbtypes.c: Use C++ exception handling.
9806         * frame.c: Use C++ exception handling.
9807         * frame-unwind.c: Use C++ exception handling.
9808         * fbsd-tdep.c: Use C++ exception handling.
9809         * f-valprint.c: Use C++ exception handling.
9810         * exec.c: Use C++ exception handling.
9811         * event-top.c: Use C++ exception handling.
9812         * event-loop.c: Use C++ exception handling.
9813         * eval.c: Use C++ exception handling.
9814         * dwarf2read.c: Use C++ exception handling.
9815         * dwarf2loc.c: Use C++ exception handling.
9816         * dwarf2-frame.c: Use C++ exception handling.
9817         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9818         * dwarf-index-write.c: Use C++ exception handling.
9819         * dwarf-index-cache.c: Use C++ exception handling.
9820         * dtrace-probe.c: Use C++ exception handling.
9821         * disasm-selftests.c: Use C++ exception handling.
9822         * darwin-nat.c: Use C++ exception handling.
9823         * cp-valprint.c: Use C++ exception handling.
9824         * cp-support.c: Use C++ exception handling.
9825         * cp-abi.c: Use C++ exception handling.
9826         * corelow.c: Use C++ exception handling.
9827         * completer.c: Use C++ exception handling.
9828         * compile/compile-object-run.c: Use C++ exception handling.
9829         * compile/compile-object-load.c: Use C++ exception handling.
9830         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9831         * compile/compile-c-symbols.c: Use C++ exception handling.
9832         * common/selftest.c: Use C++ exception handling.
9833         * common/new-op.c: Use C++ exception handling.
9834         * cli/cli-script.c: Use C++ exception handling.
9835         * cli/cli-interp.c: Use C++ exception handling.
9836         * cli/cli-cmds.c: Use C++ exception handling.
9837         * c-varobj.c: Use C++ exception handling.
9838         * btrace.c: Use C++ exception handling.
9839         * breakpoint.c: Use C++ exception handling.
9840         * break-catch-throw.c: Use C++ exception handling.
9841         * arch-utils.c: Use C++ exception handling.
9842         * amd64-tdep.c: Use C++ exception handling.
9843         * ada-valprint.c: Use C++ exception handling.
9844         * ada-typeprint.c: Use C++ exception handling.
9845         * ada-lang.c: Use C++ exception handling.
9846         * aarch64-tdep.c: Use C++ exception handling.
9847
9848 2019-04-08  Tom Tromey  <tom@tromey.com>
9849
9850         * xml-support.c (gdb_xml_parser::parse): Update.
9851         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9852         * value.c (show_convenience): Update.
9853         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9854         (test_parse_flags_qcs): Update.
9855         * thread.c (thr_try_catch_cmd): Update.
9856         * target.c (target_translate_tls_address): Update.
9857         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9858         (info_frame_command_core, frame_apply_command_count): Update.
9859         * rust-exp.y (rust_lex_exception_test): Update.
9860         * riscv-tdep.c (riscv_print_one_register_info): Update.
9861         * remote.c (remote_target::enable_btrace): Update.
9862         * record-btrace.c (record_btrace_enable_warn): Update.
9863         * python/py-utils.c (gdbpy_convert_exception): Update.
9864         * printcmd.c (do_one_display, print_variable_and_value): Update.
9865         * mi/mi-main.c (mi_print_exception): Update.
9866         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9867         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9868         * linux-nat.c (linux_nat_target::attach): Update.
9869         * linux-fork.c (class scoped_switch_fork_info): Update.
9870         * infrun.c (displaced_step_prepare): Update.
9871         * infcall.c (call_function_by_hand_dummy): Update.
9872         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9873         * gnu-v3-abi.c (print_one_vtable): Update.
9874         * frame.c (get_prev_frame_always): Update.
9875         * f-valprint.c (info_common_command_for_block): Update.
9876         * exec.c (try_open_exec_file): Update.
9877         * exceptions.c (print_exception, exception_print)
9878         (exception_fprintf, exception_print_same): Update.
9879         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9880         * dwarf-index-cache.c (index_cache::store)
9881         (index_cache::lookup_gdb_index): Update.
9882         * darwin-nat.c (maybe_cache_shell): Update.
9883         * cp-valprint.c (cp_print_value_fields): Update.
9884         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9885         (gcc_cplus_symbol_address): Update.
9886         * compile/compile-c-symbols.c (gcc_convert_symbol)
9887         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9888         * common/selftest.c: Update.
9889         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9890         a std::string.
9891         (exception_try_scope_entry, exception_try_scope_exit): Don't
9892         declare.
9893         (struct exception_try_scope): Remove.
9894         (TRY): Don't use exception_try_scope.
9895         (struct gdb_exception): Add constructor, operator=.
9896         <what>: New method.
9897         (struct gdb_exception_RETURN_MASK_ALL)
9898         (struct gdb_exception_RETURN_MASK_ERROR)
9899         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9900         (struct gdb_quit_bad_alloc): Update.
9901         * common/common-exceptions.c (exception_none): Change
9902         initializer.
9903         (struct catcher) <state, exception>: Initialize inline.
9904         <prev>: Remove member.
9905         (current_catcher): Remove.
9906         (catchers): New global.
9907         (exceptions_state_mc_init): Simplify.
9908         (catcher_pop): Remove.
9909         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9910         (try_scope_depth, exception_try_scope_entry)
9911         (exception_try_scope_exit): Remove.
9912         (throw_exception_sjlj): Update.
9913         (exception_messages, exception_messages_size): Remove.
9914         (throw_it): Simplify.
9915         (gdb_exception_sliced_copy): Remove.
9916         (throw_exception_cxx): Update.
9917         * cli/cli-script.c (script_from_file): Update.
9918         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9919         Update.
9920         * ada-valprint.c (ada_val_print): Update.
9921         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9922         (create_excep_cond_exprs): Update.
9923
9924 2019-04-08  Tom Tromey  <tom@tromey.com>
9925
9926         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9927         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9928         (TRY, CATCH, END_CATCH): Remove some definitions.
9929         * common/common-exceptions.c: Don't use GDB_XCPT.
9930         (catcher_list_size): Remove.
9931         (throw_exception, throw_it): Simplify.
9932
9933 2019-04-05  Tom Tromey  <tom@tromey.com>
9934
9935         Revert the header-sorting patch.
9936         * ft32-tdep.c: Revert.
9937         * frv-tdep.c: Revert.
9938         * frv-linux-tdep.c: Revert.
9939         * frame.c: Revert.
9940         * frame-unwind.c: Revert.
9941         * frame-base.c: Revert.
9942         * fork-child.c: Revert.
9943         * findvar.c: Revert.
9944         * findcmd.c: Revert.
9945         * filesystem.c: Revert.
9946         * filename-seen-cache.h: Revert.
9947         * filename-seen-cache.c: Revert.
9948         * fbsd-tdep.c: Revert.
9949         * fbsd-nat.h: Revert.
9950         * fbsd-nat.c: Revert.
9951         * f-valprint.c: Revert.
9952         * f-typeprint.c: Revert.
9953         * f-lang.c: Revert.
9954         * extension.h: Revert.
9955         * extension.c: Revert.
9956         * extension-priv.h: Revert.
9957         * expprint.c: Revert.
9958         * exec.h: Revert.
9959         * exec.c: Revert.
9960         * exceptions.c: Revert.
9961         * event-top.c: Revert.
9962         * event-loop.c: Revert.
9963         * eval.c: Revert.
9964         * elfread.c: Revert.
9965         * dwarf2read.h: Revert.
9966         * dwarf2read.c: Revert.
9967         * dwarf2loc.c: Revert.
9968         * dwarf2expr.h: Revert.
9969         * dwarf2expr.c: Revert.
9970         * dwarf2-frame.c: Revert.
9971         * dwarf2-frame-tailcall.c: Revert.
9972         * dwarf-index-write.h: Revert.
9973         * dwarf-index-write.c: Revert.
9974         * dwarf-index-common.c: Revert.
9975         * dwarf-index-cache.h: Revert.
9976         * dwarf-index-cache.c: Revert.
9977         * dummy-frame.c: Revert.
9978         * dtrace-probe.c: Revert.
9979         * disasm.h: Revert.
9980         * disasm.c: Revert.
9981         * disasm-selftests.c: Revert.
9982         * dictionary.c: Revert.
9983         * dicos-tdep.c: Revert.
9984         * demangle.c: Revert.
9985         * dcache.h: Revert.
9986         * dcache.c: Revert.
9987         * darwin-nat.h: Revert.
9988         * darwin-nat.c: Revert.
9989         * darwin-nat-info.c: Revert.
9990         * d-valprint.c: Revert.
9991         * d-namespace.c: Revert.
9992         * d-lang.c: Revert.
9993         * ctf.c: Revert.
9994         * csky-tdep.c: Revert.
9995         * csky-linux-tdep.c: Revert.
9996         * cris-tdep.c: Revert.
9997         * cris-linux-tdep.c: Revert.
9998         * cp-valprint.c: Revert.
9999         * cp-support.c: Revert.
10000         * cp-namespace.c: Revert.
10001         * cp-abi.c: Revert.
10002         * corelow.c: Revert.
10003         * corefile.c: Revert.
10004         * continuations.c: Revert.
10005         * completer.h: Revert.
10006         * completer.c: Revert.
10007         * complaints.c: Revert.
10008         * coffread.c: Revert.
10009         * coff-pe-read.c: Revert.
10010         * cli-out.h: Revert.
10011         * cli-out.c: Revert.
10012         * charset.c: Revert.
10013         * c-varobj.c: Revert.
10014         * c-valprint.c: Revert.
10015         * c-typeprint.c: Revert.
10016         * c-lang.c: Revert.
10017         * buildsym.c: Revert.
10018         * buildsym-legacy.c: Revert.
10019         * build-id.h: Revert.
10020         * build-id.c: Revert.
10021         * btrace.c: Revert.
10022         * bsd-uthread.c: Revert.
10023         * breakpoint.h: Revert.
10024         * breakpoint.c: Revert.
10025         * break-catch-throw.c: Revert.
10026         * break-catch-syscall.c: Revert.
10027         * break-catch-sig.c: Revert.
10028         * blockframe.c: Revert.
10029         * block.c: Revert.
10030         * bfin-tdep.c: Revert.
10031         * bfin-linux-tdep.c: Revert.
10032         * bfd-target.c: Revert.
10033         * bcache.c: Revert.
10034         * ax-general.c: Revert.
10035         * ax-gdb.h: Revert.
10036         * ax-gdb.c: Revert.
10037         * avr-tdep.c: Revert.
10038         * auxv.c: Revert.
10039         * auto-load.c: Revert.
10040         * arm-wince-tdep.c: Revert.
10041         * arm-tdep.c: Revert.
10042         * arm-symbian-tdep.c: Revert.
10043         * arm-pikeos-tdep.c: Revert.
10044         * arm-obsd-tdep.c: Revert.
10045         * arm-nbsd-tdep.c: Revert.
10046         * arm-nbsd-nat.c: Revert.
10047         * arm-linux-tdep.c: Revert.
10048         * arm-linux-nat.c: Revert.
10049         * arm-fbsd-tdep.c: Revert.
10050         * arm-fbsd-nat.c: Revert.
10051         * arm-bsd-tdep.c: Revert.
10052         * arch-utils.c: Revert.
10053         * arc-tdep.c: Revert.
10054         * arc-newlib-tdep.c: Revert.
10055         * annotate.h: Revert.
10056         * annotate.c: Revert.
10057         * amd64-windows-tdep.c: Revert.
10058         * amd64-windows-nat.c: Revert.
10059         * amd64-tdep.c: Revert.
10060         * amd64-sol2-tdep.c: Revert.
10061         * amd64-obsd-tdep.c: Revert.
10062         * amd64-obsd-nat.c: Revert.
10063         * amd64-nbsd-tdep.c: Revert.
10064         * amd64-nbsd-nat.c: Revert.
10065         * amd64-nat.c: Revert.
10066         * amd64-linux-tdep.c: Revert.
10067         * amd64-linux-nat.c: Revert.
10068         * amd64-fbsd-tdep.c: Revert.
10069         * amd64-fbsd-nat.c: Revert.
10070         * amd64-dicos-tdep.c: Revert.
10071         * amd64-darwin-tdep.c: Revert.
10072         * amd64-bsd-nat.c: Revert.
10073         * alpha-tdep.c: Revert.
10074         * alpha-obsd-tdep.c: Revert.
10075         * alpha-nbsd-tdep.c: Revert.
10076         * alpha-mdebug-tdep.c: Revert.
10077         * alpha-linux-tdep.c: Revert.
10078         * alpha-linux-nat.c: Revert.
10079         * alpha-bsd-tdep.c: Revert.
10080         * alpha-bsd-nat.c: Revert.
10081         * aix-thread.c: Revert.
10082         * agent.c: Revert.
10083         * addrmap.c: Revert.
10084         * ada-varobj.c: Revert.
10085         * ada-valprint.c: Revert.
10086         * ada-typeprint.c: Revert.
10087         * ada-tasks.c: Revert.
10088         * ada-lang.c: Revert.
10089         * aarch64-tdep.c: Revert.
10090         * aarch64-ravenscar-thread.c: Revert.
10091         * aarch64-newlib-tdep.c: Revert.
10092         * aarch64-linux-tdep.c: Revert.
10093         * aarch64-linux-nat.c: Revert.
10094         * aarch64-fbsd-tdep.c: Revert.
10095         * aarch64-fbsd-nat.c: Revert.
10096         * aarch32-linux-nat.c: Revert.
10097
10098 2019-04-05  Tom Tromey  <tom@tromey.com>
10099
10100         * ft32-tdep.c: Sort headers.
10101         * frv-tdep.c: Sort headers.
10102         * frv-linux-tdep.c: Sort headers.
10103         * frame.c: Sort headers.
10104         * frame-unwind.c: Sort headers.
10105         * frame-base.c: Sort headers.
10106         * fork-child.c: Sort headers.
10107         * findvar.c: Sort headers.
10108         * findcmd.c: Sort headers.
10109         * filesystem.c: Sort headers.
10110         * filename-seen-cache.h: Sort headers.
10111         * filename-seen-cache.c: Sort headers.
10112         * fbsd-tdep.c: Sort headers.
10113         * fbsd-nat.h: Sort headers.
10114         * fbsd-nat.c: Sort headers.
10115         * f-valprint.c: Sort headers.
10116         * f-typeprint.c: Sort headers.
10117         * f-lang.c: Sort headers.
10118         * extension.h: Sort headers.
10119         * extension.c: Sort headers.
10120         * extension-priv.h: Sort headers.
10121         * expprint.c: Sort headers.
10122         * exec.h: Sort headers.
10123         * exec.c: Sort headers.
10124         * exceptions.c: Sort headers.
10125         * event-top.c: Sort headers.
10126         * event-loop.c: Sort headers.
10127         * eval.c: Sort headers.
10128         * elfread.c: Sort headers.
10129         * dwarf2read.h: Sort headers.
10130         * dwarf2read.c: Sort headers.
10131         * dwarf2loc.c: Sort headers.
10132         * dwarf2expr.h: Sort headers.
10133         * dwarf2expr.c: Sort headers.
10134         * dwarf2-frame.c: Sort headers.
10135         * dwarf2-frame-tailcall.c: Sort headers.
10136         * dwarf-index-write.h: Sort headers.
10137         * dwarf-index-write.c: Sort headers.
10138         * dwarf-index-common.c: Sort headers.
10139         * dwarf-index-cache.h: Sort headers.
10140         * dwarf-index-cache.c: Sort headers.
10141         * dummy-frame.c: Sort headers.
10142         * dtrace-probe.c: Sort headers.
10143         * disasm.h: Sort headers.
10144         * disasm.c: Sort headers.
10145         * disasm-selftests.c: Sort headers.
10146         * dictionary.c: Sort headers.
10147         * dicos-tdep.c: Sort headers.
10148         * demangle.c: Sort headers.
10149         * dcache.h: Sort headers.
10150         * dcache.c: Sort headers.
10151         * darwin-nat.h: Sort headers.
10152         * darwin-nat.c: Sort headers.
10153         * darwin-nat-info.c: Sort headers.
10154         * d-valprint.c: Sort headers.
10155         * d-namespace.c: Sort headers.
10156         * d-lang.c: Sort headers.
10157         * ctf.c: Sort headers.
10158         * csky-tdep.c: Sort headers.
10159         * csky-linux-tdep.c: Sort headers.
10160         * cris-tdep.c: Sort headers.
10161         * cris-linux-tdep.c: Sort headers.
10162         * cp-valprint.c: Sort headers.
10163         * cp-support.c: Sort headers.
10164         * cp-namespace.c: Sort headers.
10165         * cp-abi.c: Sort headers.
10166         * corelow.c: Sort headers.
10167         * corefile.c: Sort headers.
10168         * continuations.c: Sort headers.
10169         * completer.h: Sort headers.
10170         * completer.c: Sort headers.
10171         * complaints.c: Sort headers.
10172         * coffread.c: Sort headers.
10173         * coff-pe-read.c: Sort headers.
10174         * cli-out.h: Sort headers.
10175         * cli-out.c: Sort headers.
10176         * charset.c: Sort headers.
10177         * c-varobj.c: Sort headers.
10178         * c-valprint.c: Sort headers.
10179         * c-typeprint.c: Sort headers.
10180         * c-lang.c: Sort headers.
10181         * buildsym.c: Sort headers.
10182         * buildsym-legacy.c: Sort headers.
10183         * build-id.h: Sort headers.
10184         * build-id.c: Sort headers.
10185         * btrace.c: Sort headers.
10186         * bsd-uthread.c: Sort headers.
10187         * breakpoint.h: Sort headers.
10188         * breakpoint.c: Sort headers.
10189         * break-catch-throw.c: Sort headers.
10190         * break-catch-syscall.c: Sort headers.
10191         * break-catch-sig.c: Sort headers.
10192         * blockframe.c: Sort headers.
10193         * block.c: Sort headers.
10194         * bfin-tdep.c: Sort headers.
10195         * bfin-linux-tdep.c: Sort headers.
10196         * bfd-target.c: Sort headers.
10197         * bcache.c: Sort headers.
10198         * ax-general.c: Sort headers.
10199         * ax-gdb.h: Sort headers.
10200         * ax-gdb.c: Sort headers.
10201         * avr-tdep.c: Sort headers.
10202         * auxv.c: Sort headers.
10203         * auto-load.c: Sort headers.
10204         * arm-wince-tdep.c: Sort headers.
10205         * arm-tdep.c: Sort headers.
10206         * arm-symbian-tdep.c: Sort headers.
10207         * arm-pikeos-tdep.c: Sort headers.
10208         * arm-obsd-tdep.c: Sort headers.
10209         * arm-nbsd-tdep.c: Sort headers.
10210         * arm-nbsd-nat.c: Sort headers.
10211         * arm-linux-tdep.c: Sort headers.
10212         * arm-linux-nat.c: Sort headers.
10213         * arm-fbsd-tdep.c: Sort headers.
10214         * arm-fbsd-nat.c: Sort headers.
10215         * arm-bsd-tdep.c: Sort headers.
10216         * arch-utils.c: Sort headers.
10217         * arc-tdep.c: Sort headers.
10218         * arc-newlib-tdep.c: Sort headers.
10219         * annotate.h: Sort headers.
10220         * annotate.c: Sort headers.
10221         * amd64-windows-tdep.c: Sort headers.
10222         * amd64-windows-nat.c: Sort headers.
10223         * amd64-tdep.c: Sort headers.
10224         * amd64-sol2-tdep.c: Sort headers.
10225         * amd64-obsd-tdep.c: Sort headers.
10226         * amd64-obsd-nat.c: Sort headers.
10227         * amd64-nbsd-tdep.c: Sort headers.
10228         * amd64-nbsd-nat.c: Sort headers.
10229         * amd64-nat.c: Sort headers.
10230         * amd64-linux-tdep.c: Sort headers.
10231         * amd64-linux-nat.c: Sort headers.
10232         * amd64-fbsd-tdep.c: Sort headers.
10233         * amd64-fbsd-nat.c: Sort headers.
10234         * amd64-dicos-tdep.c: Sort headers.
10235         * amd64-darwin-tdep.c: Sort headers.
10236         * amd64-bsd-nat.c: Sort headers.
10237         * alpha-tdep.c: Sort headers.
10238         * alpha-obsd-tdep.c: Sort headers.
10239         * alpha-nbsd-tdep.c: Sort headers.
10240         * alpha-mdebug-tdep.c: Sort headers.
10241         * alpha-linux-tdep.c: Sort headers.
10242         * alpha-linux-nat.c: Sort headers.
10243         * alpha-bsd-tdep.c: Sort headers.
10244         * alpha-bsd-nat.c: Sort headers.
10245         * aix-thread.c: Sort headers.
10246         * agent.c: Sort headers.
10247         * addrmap.c: Sort headers.
10248         * ada-varobj.c: Sort headers.
10249         * ada-valprint.c: Sort headers.
10250         * ada-typeprint.c: Sort headers.
10251         * ada-tasks.c: Sort headers.
10252         * ada-lang.c: Sort headers.
10253         * aarch64-tdep.c: Sort headers.
10254         * aarch64-ravenscar-thread.c: Sort headers.
10255         * aarch64-newlib-tdep.c: Sort headers.
10256         * aarch64-linux-tdep.c: Sort headers.
10257         * aarch64-linux-nat.c: Sort headers.
10258         * aarch64-fbsd-tdep.c: Sort headers.
10259         * aarch64-fbsd-nat.c: Sort headers.
10260         * aarch32-linux-nat.c: Sort headers.
10261
10262 2019-04-04  Tom Tromey  <tom@tromey.com>
10263
10264         * varobj.c (varobj_create): Update.
10265         * rust-exp.y (struct rust_parser) <update_innermost_block,
10266         lookup_symbol>: New methods.
10267         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10268         Rename.
10269         (rust_parser::rust_lookup_type)
10270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10271         * printcmd.c (display_command, do_one_display): Update.
10272         * parser-defs.h (struct parser_state) <parser_state>: Add
10273         "tracker" parameter.
10274         (block_tracker): New member.
10275         (class innermost_block_tracker) <innermost_block_tracker>: Add
10276         "types" parameter.
10277         <reset>: Remove method.
10278         (innermost_block): Don't declare.
10279         (null_post_parser): Update.
10280         * parse.c (innermost_block): Remove global.
10281         (write_dollar_variable): Update.
10282         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10283         Remove "tracker_types" parameter.
10284         (parse_expression): Add "tracker" parameter.
10285         (parse_expression_for_completion): Update.
10286         (null_post_parser): Add "tracker" parameter.
10287         * p-exp.y: Update rules.
10288         * m2-exp.y: Update rules.
10289         * language.h (struct language_defn) <la_post_parser>: Add
10290         "tracker" parameter.
10291         * go-exp.y: Update rules.
10292         * f-exp.y: Update rules.
10293         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10294         parameter.
10295         * d-exp.y: Update rules.
10296         * c-exp.y: Update rules.
10297         * breakpoint.c (set_breakpoint_condition): Create an
10298         innermost_block_tracker.
10299         (watch_command_1): Likewise.
10300         * ada-lang.c (resolve): Add "tracker" parameter.
10301         (resolve_subexp): Likewise.
10302         * ada-exp.y (write_var_from_sym): Update.
10303
10304 2019-04-04  Tom Tromey  <tom@tromey.com>
10305
10306         * type-stack.h: New file.
10307         * type-stack.c: New file.
10308         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10309         type-stack.h.
10310         (insert_into_type_stack, insert_type, push_type, push_type_int)
10311         (insert_type_address_space, pop_type, pop_type_int)
10312         (pop_typelist, pop_type_stack, append_type_stack)
10313         (push_type_stack, get_type_stack, push_typelist)
10314         (follow_type_instance_flags, follow_types): Don't declare.
10315         * parse.c (type_stack): Remove global.
10316         (parse_exp_in_context): Update.
10317         (insert_into_type_stack, insert_type, push_type, push_type_int)
10318         (insert_type_address_space, pop_type, pop_type_int)
10319         (pop_typelist, pop_type_stack, append_type_stack)
10320         (push_type_stack, get_type_stack, push_typelist)
10321         (follow_type_instance_flags, follow_types): Remove (moved to
10322         type-stack.c).
10323         * f-exp.y (type_stack): New global.
10324         Update rules.
10325         (push_kind_type, f_parse): Update.
10326         * d-exp.y (type_stack): New global.
10327         Update rules.
10328         (d_parse): Update.
10329         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10330         Update rules.
10331         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10332         (HFILES_NO_SRCDIR): Add type-stack.h.
10333
10334 2019-04-04  Tom Tromey  <tom@tromey.com>
10335
10336         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10337         (rust_parser::convert_ast_to_expression, rust_parse)
10338         (rust_lex_test_completion, rust_lex_tests): Update.
10339         * parser-defs.h (struct expr_completion_state): New.
10340         (struct parser_state) <parser_state>: Add completion parameter.
10341         <mark_struct_expression, mark_completion_tag>: New methods.
10342         <parse_completion, m_completion_state>: New members.
10343         (prefixify_expression, null_post_parser): Update.
10344         (mark_struct_expression, mark_completion_tag): Don't declare.
10345         * parse.c (parse_completion, expout_last_struct)
10346         (expout_tag_completion_type, expout_completion_name): Remove
10347         globals.
10348         (parser_state::mark_struct_expression)
10349         (parser_state::mark_completion_tag): Now methods.
10350         (prefixify_expression): Add last_struct parameter.
10351         (prefixify_subexp): Likewise.
10352         (parse_exp_1): Update.
10353         (parse_exp_in_context): Add cstate parameter.  Update.
10354         (parse_expression_for_completion): Create an
10355         expr_completion_state.
10356         (null_post_parser): Add "completion" parameter.
10357         * p-exp.y: Update rules.
10358         (yylex): Update.
10359         * language.h (struct language_defn) <la_post_parser>: Add
10360         "completing" parameter.
10361         * go-exp.y: Update rules.
10362         (lex_one_token): Update.
10363         * expression.h (parse_completion): Don't declare.
10364         * d-exp.y: Update rules.
10365         (lex_one_token): Update rules.
10366         * c-exp.y: Update rules.
10367         (lex_one_token): Update.
10368         * ada-lang.c (resolve): Add "parse_completion" parameter.
10369         (resolve_subexp): Likewise.
10370         (ada_resolve_function): Likewise.
10371
10372 2019-04-04  Tom Tromey  <tom@tromey.com>
10373
10374         * parser-defs.h (struct parser_state) <start_arglist,
10375         end_arglist>: New methods.
10376         <arglist_len, m_funcall_chain>: New members.
10377         (arglist_len, start_arglist, end_arglist): Don't declare.
10378         * parse.c (arglist_len, funcall_chain): Remove global.
10379         (start_arglist, end_arglist): Remove functions.
10380         (parse_exp_in_context): Update.
10381         * p-exp.y: Update rules.
10382         * m2-exp.y: Update rules.
10383         * go-exp.y: Update rules.
10384         * f-exp.y: Update rules.
10385         * d-exp.y: Update rules.
10386         * c-exp.y: Update rules.
10387
10388 2019-04-04  Tom Tromey  <tom@tromey.com>
10389
10390         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10391         lex_operator, push_back>: New methods.
10392         Update all rules.
10393         (rust_parser::lex_hex, lex_escape): Rename and update.
10394         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10395         (rust_parser::lex_operator): Rename and update.
10396         (rust_parser::lex_number, rustyylex, rustyyerror)
10397         (rust_lex_test_init, rust_lex_test_sequence)
10398         (rust_lex_test_push_back, rust_lex_tests): Update.
10399         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10400         parameter.
10401         <lexptr, prev_lexptr>: New members.
10402         (lexptr, prev_lexptr): Don't declare.
10403         * parse.c (lexptr, prev_lexptr): Remove globals.
10404         (parse_exp_in_context): Update.
10405         * p-exp.y (yylex, yyerror): Update.
10406         * m2-exp.y (parse_number, yylex, yyerror): Update.
10407         * go-exp.y (lex_one_token, yyerror): Update.
10408         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10409         * d-exp.y (lex_one_token, yyerror): Update.
10410         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10411         (lex_one_token, yyerror): Update.
10412         * ada-lex.l (YY_INPUT): Update.
10413         (rewind_to_char): Update.
10414         * ada-exp.y (yyerror): Update.
10415
10416 2019-04-04  Tom Tromey  <tom@tromey.com>
10417
10418         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10419         * parser-defs.h (struct parser_state) <parser_state>: Add new
10420         parameter.
10421         <comma_terminates>: New member.
10422         (comma_terminates): Don't declare global.
10423         * parse.c (comma_terminates): Remove global.
10424         (parse_exp_in_context): Update.
10425         * p-exp.y (yylex): Update.
10426         * m2-exp.y (yylex): Update.
10427         * go-exp.y (lex_one_token): Update.
10428         * f-exp.y (yylex): Update.
10429         * d-exp.y (lex_one_token): Update.
10430         * c-exp.y (lex_one_token): Update.
10431         * ada-lex.l: Update.
10432
10433 2019-04-04  Tom Tromey  <tom@tromey.com>
10434
10435         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10436         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10437         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10438         * parser-defs.h (paren_depth): Don't declare.
10439         * parse.c (paren_depth): Remove global.
10440         (parse_exp_in_context): Update.
10441         * p-exp.y (paren_depth): New global.
10442         (pascal_parse): Initialize it.
10443         * m2-exp.y (paren_depth): New global.
10444         (m2_parse): Initialize it.
10445         * go-exp.y (paren_depth): New global.
10446         (go_parse): Initialize it.
10447         * f-exp.y (paren_depth): New global.
10448         (f_parse): Initialize it.
10449         * d-exp.y (paren_depth): New global.
10450         (d_parse): Initialize it.
10451         * c-exp.y (paren_depth): New global.
10452         (c_parse): Initialize it.
10453         * ada-lex.l (paren_depth): New global.
10454         (lexer_init): Initialize it.
10455
10456 2019-04-04  Tom Tromey  <tom@tromey.com>
10457
10458         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10459         (rust_parser::convert_ast_to_type)
10460         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10461         * parser-defs.h (struct parser_state) <parser_state>: Add
10462         parameters.  Initialize new members.
10463         <expression_context_block, expression_context_pc>: New members.
10464         * parse.c (expression_context_block, expression_context_pc):
10465         Remove globals.
10466         (parse_exp_in_context): Update.
10467         * p-exp.y: Update all rules.
10468         (yylex): Update.
10469         * m2-exp.y: Update all rules.
10470         (yylex): Update.
10471         * go-exp.y (yylex): Update.
10472         * f-exp.y (yylex): Update.
10473         * d-exp.y: Update all rules.
10474         (yylex): Update.
10475         * c-exp.y: Update all rules.
10476         (lex_one_token, classify_name, yylex, c_parse): Update.
10477         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10478
10479 2019-04-04  Tom Tromey  <tom@tromey.com>
10480
10481         * gdbarch.h, gdbarch.c: Rebuild.
10482         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10483         * stap-probe.h:
10484         (struct stap_parse_info): Replace "parser_state" with
10485         "expr_builder".
10486         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10487         (parser_state): New class.
10488         * parse.c (expr_builder): Rename.
10489         (expr_builder::release): Rename.
10490         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10491         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10492         (write_exp_elt_longcst, write_exp_elt_floatcst)
10493         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10494         (write_exp_string_vector, write_exp_bitstring)
10495         (write_exp_msymbol, mark_struct_expression)
10496         (write_dollar_variable)
10497         (insert_type_address_space, increase_expout_size): Replace
10498         "parser_state" with "expr_builder".
10499         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10500         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10501         "parser_state" with "expr_builder".
10502
10503 2019-04-04  Tom Tromey  <tom@tromey.com>
10504
10505         * rust-exp.y: Replace "parse_language" with method call.
10506         * p-exp.y:
10507         (yylex): Replace "parse_language" with method call.
10508         * m2-exp.y:
10509         (yylex): Replace "parse_language" with method call.
10510         * go-exp.y (classify_name): Replace "parse_language" with method
10511         call.
10512         * f-exp.y (yylex): Replace "parse_language" with method call.
10513         * d-exp.y (lex_one_token): Replace "parse_language" with method
10514         call.
10515         * c-exp.y:
10516         (lex_one_token, classify_name, yylex): Replace "parse_language"
10517         with method call.
10518         * ada-exp.y (find_primitive_type, type_char)
10519         (type_system_address): Replace "parse_language" with method call.
10520
10521 2019-04-04  Tom Tromey  <tom@tromey.com>
10522
10523         * rust-exp.y: Replace "parse_gdbarch" with method call.
10524         * parse.c (write_dollar_variable, insert_type_address_space):
10525         Replace "parse_gdbarch" with method call.
10526         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10527         call.
10528         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10529         call.
10530         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10531         "parse_gdbarch" with method call.
10532         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10533         with method call.
10534         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10535         "parse_gdbarch" with method call.
10536         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10537         "parse_gdbarch" with method call.
10538         * c-exp.y (parse_type, parse_number, classify_name): Replace
10539         "parse_gdbarch" with method call.
10540         * ada-lex.l: Replace "parse_gdbarch" with method call.
10541         * ada-exp.y (parse_type, find_primitive_type, type_char)
10542         (type_system_address): Replace "parse_gdbarch" with method call.
10543
10544 2019-04-04  Tom Tromey  <tom@tromey.com>
10545
10546         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10547         * stap-probe.c (stap_parse_argument): Update.
10548         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10549         initial_size parameter.
10550         * rust-exp.y (rust_lex_tests): Update.
10551         * parse.c (parser_state): Update.
10552         (parse_exp_in_context): Update.
10553         * parser-defs.h (struct parser_state) <parser_state>: Remove
10554         "initial_size" parameter.
10555
10556 2019-04-04  Tom Tromey  <tom@tromey.com>
10557
10558         * parser-defs.h (increase_expout_size): Don't declare.
10559         * parse.c (increase_expout_size): Now static.
10560
10561 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10562
10563         * gnu-nat.c (gnu_nat_target::wait): Fix
10564         target_waitstatus_to_string call.
10565
10566 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10567
10568         * eval.c (evaluate_subexp_standard): Handle internal functions
10569         during Fortran function call handling.
10570
10571 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * NEWS: Mention new internal functions.
10574         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10575         (read_base_type): Use dwarf2_init_complex_target_type.
10576         * value.c (creal_internal_fn): New function.
10577         (cimag_internal_fn): New function.
10578         (_initialize_values): Register new internal functions.
10579
10580 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10581
10582         * infrun.c (stop_all_threads): If debug_infrun, always
10583         trace the wait status after wait_one, using
10584         target_waitstatus_to_string and target_pid_to_str.
10585         (handle_inferior_event): Replace various trace of
10586         wait status kind by a single trace.
10587         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10588         wait status kind image by target_waitstatus_to_string.
10589         * target/waitstatus.c (target_waitstatus_to_string): Fix
10590         obsolete comment.
10591
10592 2019-04-01  Tom Tromey  <tromey@adacore.com>
10593
10594         PR symtab/23331:
10595         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10596
10597 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10598             Pedro Alves  <palves@redhat.com>
10599
10600         * top.c (quit_force): Call 'finalize_values'.
10601         * value.c (finalize_values): New function.
10602         * value.h (finalize_values): Declare.
10603
10604 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10605
10606         * NEWS: Announce $_gdb_major and $_gdb_minor.
10607
10608         * top.c (init_gdb_version_vars): New function.
10609         (gdb_init): Call init_gdb_version_vars.
10610
10611 2019-03-29  Tom Tromey  <tromey@adacore.com>
10612
10613         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10614         help text.  Remove dead code.
10615
10616 2019-03-29  Keith Seitz  <keiths@redhat.com>
10617
10618         From Siddhesh Poyarekar:
10619         * f-lang.h (f77_get_upperbound): Return LONGEST.
10620         (f77_get_lowerbound): Likewise.
10621         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10622         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10623         print them.
10624         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10625         plongest to format print it.
10626         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10627         (f77_get_upperbound): Likewise.
10628         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10629         LOWER_BOUND to LONGEST.
10630         (f77_create_arrayprint_offset_tbl): Likewise.
10631
10632 2019-03-29  Keith Seitz  <keiths@redhat.com>
10633
10634         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10635         %s/pulongest for TYPE_LENGTH instead of %d in format
10636         strings.
10637         * ada-typerint.c (ada_print_type): Likewise.
10638         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10639         * compile/compile-c-support.c (generate_register_struct): Likewise.
10640         * gdbtypes.c (recursive_dump_type): Likewise.
10641         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10642         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10643         instead of %d in format strings.
10644         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10645         to std::min to ULONGEST.
10646         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10647         instead of %d in format strings.
10648         * tracepoint.c (info_scope_command): Likewise.
10649         * typeprint.c (print_offset_data::update)
10650         (print_offset_data::finish): Likewise.
10651         * xtensa-tdep.c (xtensa_store_return_value)
10652         (xtensa_push_dummy_call): Likewise.
10653
10654 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10655
10656         * windows-nat.c (display_selector): Fixed format specifications
10657         for 64-bit Cygwin.
10658
10659 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10660
10661         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10662
10663 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10664
10665         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10666         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10667         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10668         (nios2_linux_init_abi): Install it.
10669
10670 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10671
10672         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10673
10674 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10675
10676         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10677
10678 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10679             Tom Tromey  <tromey@adacore.com>
10680
10681         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10682
10683 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10684
10685         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10686         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10687         method to compute the bounds of range types. Also print "[evaluated]"
10688         if the bounds' values come from a dynamic evaluation.
10689
10690 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10691
10692         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10693         whitespace when pretty printing is on.
10694
10695 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10696
10697         * ppc-linux-nat.c: Add include.
10698
10699 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10700
10701         * NEWS: Mention AArch64 Pointer Authentication.
10702
10703 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10704
10705         * arm-linux-nat.c: Add include.
10706
10707 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10708
10709         * source-cache.c (source_cache::get_source_lines): Re-read
10710         fullname after calling open_source_file.
10711
10712 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10713
10714         * NEWS: Mention TLS support for FreeBSD.
10715
10716 2019-03-25  Tom Tromey  <tromey@adacore.com>
10717
10718         * minsyms.c (BUNCH_SIZE): Update comment.
10719         (~minimal_symbol_reader): Remove old comment.
10720         (compact_minimal_symbols): Update comment.
10721         (minimal_symbol_reader::install): Remove old comment.  Update
10722         other comments.
10723
10724 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10725
10726         * s390-linux-nat.c: Add include.
10727
10728 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10729
10730         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10731         Call linux_get_hwcap.
10732         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10733         Likewise.
10734         (aarch64_linux_get_hwcap): Remove function.
10735         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10736         declaration.
10737         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10738         linux_get_hwcap.
10739         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10740         * linux-tdep.c (linux_get_hwcap): Add function.
10741         (linux_get_hwcap2): Likewise.
10742         * linux-tdep.h (linux_get_hwcap): Add declaration.
10743         (linux_get_hwcap2): Likewise.
10744         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10745         (ppc_linux_get_hwcap2): Likewise.
10746         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10747         linux_get_hwcap.
10748         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10749         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10750         (ppc_linux_nat_target::read_description): Likewise.
10751         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10752         * s390-linux-nat.c: Likewise.
10753         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10754
10755 2019-03-24  Tom Tromey  <tom@tromey.com>
10756
10757         * ada-lang.c (standard_lookup): Simplify initialization.
10758         (ada_lookup_symbol_nonlocal): Simplify return.
10759         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10760         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10761         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10762         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10763         initialization.
10764         * solib.c (solib_global_lookup): Simplify.
10765         * symtab.c (null_block_symbol): Remove.
10766         (symbol_cache_lookup): Simplify returns.
10767         (lookup_language_this): Simplify returns.
10768         (lookup_symbol_aux): Simplify return.
10769         (lookup_local_symbol): Simplify returns.
10770         (lookup_global_symbol_from_objfile): Simplify return.
10771         (lookup_symbol_in_objfile_symtabs)
10772         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10773         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10774         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10775         * cp-namespace.c (cp_lookup_bare_symbol)
10776         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10777         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10778         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10779         (cp_lookup_symbol_via_imports): Simplify initialization.
10780         (find_symbol_in_baseclass): Likewise.
10781         * symtab.h (null_block_symbol): Remove.
10782         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10783         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10784         (d_lookup_symbol_module): Likewise.
10785         (find_symbol_in_baseclass): Simplify initialization.
10786
10787 2019-03-24  Tom Tromey  <tom@tromey.com>
10788
10789         * expression.h: Don't include symtab.h.
10790         (struct block): Forward declare.
10791
10792 2019-03-24  Tom Tromey  <tom@tromey.com>
10793
10794         * c-exp.y (typebase): Remove casts.
10795         * gdbtypes.c (lookup_unsigned_typename, )
10796         (lookup_signed_typename): Remove cast.
10797         * eval.c (parse_to_comma_and_eval): Remove cast.
10798         * parse.c (write_dollar_variable): Remove cast.
10799         * block.h (struct block) <superblock>: Now const.
10800         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10801         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10802         (map_block): Make "block" const.
10803         * symfile.h (struct quick_symbol_functions)
10804         <map_matching_symbols>: Constify block argument to "callback".
10805         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10806         const.
10807         (find_pc_sect_compunit_symtab): Make "b" const.
10808         (find_symbol_at_address): Likewise.
10809         (search_symbols): Likewise.
10810         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10811         (dw2_debug_names_lookup_symbol): Likewise.
10812         (dw2_map_matching_symbols): Update.
10813         * p-valprint.c (pascal_val_print): Remove "block".
10814         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10815         (aux_add_nonlocal_symbols): Make "block" const.
10816         (resolve_subexp): Remove cast.
10817         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10818         const.
10819         (iterate_over_file_blocks): Likewise.
10820         * f-exp.y (%union) <bval>: Remove.
10821         * coffread.c (patch_opaque_types): Make "b" const.
10822         * spu-tdep.c (spu_catch_start): Make "block" const.
10823         * c-valprint.c (print_unpacked_pointer): Remove "block".
10824         * symmisc.c (dump_symtab_1): Make "b" const.
10825         (block_depth): Make "block" const.
10826         * d-exp.y (%union) <bval>: Remove.
10827         * cp-support.h (cp_lookup_rtti_type): Update.
10828         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10829         * psymtab.c (psym_lookup_symbol): Make "block" const.
10830         (maintenance_check_psymtabs): Make "b" const.
10831         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10832         (enumerate_locals, enumerate_args): Update.
10833         * python/py-symtab.c (stpy_global_block): Make "block" const.
10834         (stpy_static_block): Likewise.
10835         * inline-frame.c (block_starting_point_at): Make "new_block"
10836         const.
10837         * block.c (find_block_in_blockvector): Make return type const.
10838         (blockvector_for_pc_sect): Make "b" const.
10839         (find_block_in_blockvector): Make "b" const.
10840
10841 2019-03-23  Tom Tromey  <tom@tromey.com>
10842
10843         * varobj.c (varobj_create): Update.
10844         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10845         * printcmd.c (display_command, do_one_display): Don't reset
10846         innermost_block.
10847         * parser-defs.h (enum innermost_block_tracker_type): Move to
10848         expression.h.
10849         (innermost_block): Update comment.
10850         * parse.c (parse_exp_1): Add tracker_types parameter.
10851         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10852         tracker_types parameter.  Reset innermost_block.
10853         (parse_exp_in_context): Remove.
10854         (parse_expression_for_completion): Update.
10855         * objfiles.c (~objfile): Don't reset expression_context_block or
10856         innermost_block.
10857         * expression.h (enum innermost_block_tracker_type): Move from
10858         parser-defs.h.
10859         (parse_exp_1): Add tracker_types parameter.
10860         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10861         reset innermost_block.
10862
10863 2019-03-23  Tom Tromey  <tom@tromey.com>
10864
10865         * objfiles.h: Include bcache.h.
10866
10867 2019-03-23  Tom Tromey  <tom@tromey.com>
10868
10869         * linespec.c (get_current_search_block): Use
10870         scoped_restore_current_language.
10871         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10872
10873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10874             Jiong Wang  <jiong.wang@arm.com>
10875
10876         * aarch64-linux-tdep.c
10877         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10878         section.
10879         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10880
10881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10882             Jiong Wang  <jiong.wang@arm.com>
10883
10884         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10885         instructions.
10886         (aarch64_analyze_prologue_test): Add PACIASP test.
10887         (aarch64_prologue_prev_register): Unmask PC value.
10888
10889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10890             Jiong Wang  <jiong.wang@arm.com>
10891
10892         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10893         (aarch64_dwarf2_prev_register): Unmask PC value.
10894         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10895         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10896         DW_CFA_AARCH64_negate_ra_state.
10897         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10898
10899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10900             Jiong Wang  <jiong.wang@arm.com>
10901
10902         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10903         registers.
10904         (aarch64_pseudo_register_name): Likewise.
10905         (aarch64_pseudo_register_type): Likewise.
10906         (aarch64_pseudo_register_reggroup_p): Likewise.
10907         (aarch64_gdbarch_init): Add pauth registers.
10908         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10909         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10910         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10911         (struct gdbarch_tdep): Add regnum for ra_state.
10912
10913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10914             Jiong Wang  <jiong.wang@arm.com>
10915
10916         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10917
10918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10919             Jiong Wang  <jiong.wang@arm.com>
10920
10921         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10922         function.
10923         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10924         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10925         (aarch64_gdbarch_init): Add puth registers.
10926         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10927         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10928         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10929
10930 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10931             Jiong Wang  <jiong.wang@arm.com>
10932
10933         * aarch64-linux-nat.c
10934         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10935         * aarch64-linux-tdep.c
10936         (aarch64_linux_core_read_description): Likewise.
10937         (aarch64_linux_get_hwcap): New function.
10938         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10939         (aarch64_linux_get_hwcap): New declaration.
10940
10941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10942             Jiong Wang  <jiong.wang@arm.com>
10943
10944         * aarch64-linux-nat.c
10945         (aarch64_linux_nat_target::read_description): Add pauth param.
10946         * aarch64-linux-tdep.c
10947         (aarch64_linux_core_read_description): Likewise.
10948         * aarch64-tdep.c (struct target_desc): Add in pauth.
10949         (aarch64_read_description): Add pauth param.
10950         (aarch64_gdbarch_init): Likewise.
10951         * aarch64-tdep.h (aarch64_read_description): Likewise.
10952         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10953         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10954         * features/Makefile: Add new files.
10955         * features/aarch64-pauth.c: New file.
10956         * features/aarch64-pauth.xml: New file.
10957
10958 2019-03-20  Tom Tromey  <tromey@adacore.com>
10959
10960         * infrun.c (handle_inferior_event): Rename from
10961         handle_inferior_event_1.  Create a scoped_value_mark.
10962         (handle_inferior_event): Remove.
10963
10964 2019-03-19  Tom Tromey  <tromey@adacore.com>
10965
10966         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10967         * infrun.h (print_stop_event): Add "displays" parameter.
10968         * infrun.c (print_stop_event): Add "displays" parameter.
10969
10970 2019-03-19  Pedro Alves  <palves@redhat.com>
10971
10972         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10973         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10974         to -1.  Fix TABs vs spaces.
10975         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10976         * tui/tui-out.h (tui_ui_out) Add intro comments.
10977         <m_line, m_start_of_line>: In-class initialize, and add describing
10978         comment.
10979
10980 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10981
10982         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10983         variable names.
10984         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10985
10986 2019-03-18  Pedro Alves  <palves@redhat.com>
10987             Eli Zaretskii <eliz@gnu.org>
10988
10989         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10990         m_line and m_start_of_line.
10991
10992 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10993
10994         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10995         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10996         it returns a newline.  This fixes a regression in TU mode, whereby
10997         the next line is output on the same screen line as the user input.
10998
10999 2019-03-18  Tom Tromey  <tromey@adacore.com>
11000
11001         * minsyms.c (minimal_symbol_reader::install): Remove call to
11002         obstack_blank.
11003
11004 2019-03-18  Pedro Alves  <palves@redhat.com>
11005
11006         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11007         New globals.
11008         (apply_style): New, factored out from ...
11009         (apply_ansi_escape): ... this.  Handle reverse video mode.
11010         (tui_set_reverse_mode): New function.
11011         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11012         * tui/tui-winsource.c (tui_show_source_line): Use
11013         tui_set_reverse_mode instead of setting A_STANDOUT.
11014         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11015         New setter methods.
11016
11017 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11018
11019         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11020         Handle tabs.
11021
11022 2019-03-18  Tom Tromey  <tromey@adacore.com>
11023
11024         * ada-lang.c (empty_array): Add "high" parameter.
11025         (ada_evaluate_subexp): Update.
11026
11027 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11028
11029         * unittests/string_view-selftests.c: Define
11030         _initialize_string_view_selftests unconditionally.
11031
11032 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11033
11034         PR gdb/24350
11035         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11036
11037 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11038
11039         PR gdb/24351
11040         * windows-nat.c (display_selector): Fix format specifiers.
11041
11042 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11043
11044         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11045         tui_refill_source_window instead of tui_refresh_win, to update the
11046         current execution line.  This fixes redisplay of the current line
11047         when stepping through the code with "next" or "step".
11048
11049 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11050
11051         * source-cache.c (source_cache::get_source_lines): Call
11052         find_source_lines to initialize s->nlines.  This fixes vertical
11053         scrolling of TUI source window when the DOWN arrow is pressed.
11054
11055 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11056
11057         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11058         linux-thread-db.c (_initialize_thread_db): Likewise.
11059
11060 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11061
11062         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11063         wclrtoeol in tui_show_source_line".  This reverts changes made in
11064         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11065
11066 2019-03-15  Tom Tromey  <tom@tromey.com>
11067
11068         * symtab.h (struct minimal_symbol): Derive from
11069         general_symbol_info.
11070         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11071         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11072         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11073         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11074         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11075         (MSYMBOL_SEARCH_NAME): Update.
11076         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11077         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11078         * minsyms.c (minimal_symbol_reader::record_full): Update.
11079
11080 2019-03-15  Tom Tromey  <tom@tromey.com>
11081
11082         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11083
11084 2019-03-15  Tom Tromey  <tom@tromey.com>
11085
11086         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11087         unique_xmalloc_ptr.
11088         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11089         Update.
11090         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11091         (build_minimal_symbol_hash_tables)
11092         (minimal_symbol_reader::install): Update.
11093
11094 2019-03-15  Tom Tromey  <tom@tromey.com>
11095
11096         * symtab.c (create_demangled_names_hash): Update.
11097         (symbol_set_names): Update.
11098         * objfiles.h (struct objfile_per_bfd_storage)
11099         <demangled_names_hash>: Now an htab_up.
11100         * objfiles.c (objfile_per_bfd_storage): Simplify.
11101
11102 2019-03-15  Tom Tromey  <tom@tromey.com>
11103
11104         * objfiles.h (struct objfile_per_bfd_storage): Declare
11105         destructor.
11106         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11107         New.
11108         (get_objfile_bfd_data): Use new.  Don't initialize
11109         language_of_main.
11110         (free_objfile_per_bfd_storage): Remove.
11111         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11112
11113 2019-03-15  Tom Tromey  <tom@tromey.com>
11114
11115         * symfile.c (reread_symbols): Update.
11116         * objfiles.c (objfile::objfile): Update.
11117         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11118         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11119         comment.
11120         (minimal_symbol_reader::install): Update.
11121         (terminate_minimal_symbol_table): Remove.
11122         * jit.c (jit_object_close_impl): Update.
11123
11124 2019-03-15  Tom Tromey  <tom@tromey.com>
11125
11126         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11127         initializations.
11128
11129 2019-03-15  Tom Tromey  <tom@tromey.com>
11130
11131         * objfiles.h (struct objfile_per_bfd_storage)
11132         <demangled_hash_languages>: Now a bitset.
11133         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11134         (lookup_minimal_symbol): Update.
11135
11136 2019-03-15  Tom Tromey  <tom@tromey.com>
11137
11138         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11139         Don't return the symbol.
11140         * coffread.c (record_minimal_symbol): Use record_full.
11141
11142 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11143
11144         The MS-Windows port of ncurses fails to switch to a color pair if
11145         one or both of the colors are the implicit default colors.  This
11146         change records the default colors when TUI is initialized, and
11147         then specifies them explicitly when a color pair uses the default
11148         colors.  This allows color styling in TUI mode on MS-Windows.
11149
11150         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11151         ncurses_norm_attr.
11152         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11153         colors in ncurses_norm_attr.
11154         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11155         "none", replace it with the default color recorded in
11156         ncurses_norm_attr.
11157
11158 2019-03-14  Tom Tromey  <tromey@adacore.com>
11159
11160         * source-cache.h (class source_cache) <get_source_lines>: Return
11161         std::string.
11162         * source-cache.c (source_cache::extract_lines): Handle case where
11163         first_pos==npos.  Return std::string.
11164         (source_cache::get_source_lines): Update.
11165
11166 2019-03-14  Tom Tromey  <tromey@adacore.com>
11167
11168         * NEWS: Add item for "style sources" commands.
11169         * source-cache.c (source_cache::get_source_lines): Check
11170         source_styling.
11171         * cli/cli-style.c (source_styling): New global.
11172         (_initialize_cli_style): Add "style sources" commands.
11173         (show_style_sources): New function.
11174         * cli/cli-style.h (source_styling): Declare.
11175
11176 2019-03-14  Pedro Alves  <palves@redhat.com>
11177             Tom Tromey  <tromey@adacore.com>
11178
11179         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11180         * tui/tui-winsource.c (tui_refill_source_window): New function,
11181         from...
11182         (tui_horizontal_source_scroll): ... here.  Move some logic.
11183         * cli/cli-style.c (set_style_enabled): Notify new observable.
11184         * tui/tui-hooks.c (tui_redisplay_source): New function.
11185         (tui_attach_detach_observers): Attach or detach
11186         tui_redisplay_source.
11187         * observable.h (source_styling_changed): New observable.
11188         * observable.c: Define source_styling_changed observable.
11189
11190 2019-03-13  Tom Tromey  <tromey@adacore.com>
11191
11192         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11193         (i386_gnu_nat_target::store_registers): Update.
11194         * target-debug.h (target_debug_print_std_string): New macro.
11195         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11196         * windows-tdep.c (display_one_tib): Update.
11197         * tui/tui-stack.c (tui_make_status_line): Update.
11198         * top.c (print_inferior_quit_action): Update.
11199         * thread.c (thr_try_catch_cmd): Update.
11200         (add_thread_with_info): Update.
11201         (thread_target_id_str): Update.
11202         (thr_try_catch_cmd): Update.
11203         (thread_command): Update.
11204         (thread_find_command): Update.
11205         * record-btrace.c (record_btrace_target::info_record)
11206         (record_btrace_resume_thread, record_btrace_target::resume)
11207         (record_btrace_cancel_resume, record_btrace_step_thread)
11208         (record_btrace_target::wait, record_btrace_target::wait)
11209         (record_btrace_target::wait, record_btrace_target::stop): Update.
11210         * progspace.c (print_program_space): Update.
11211         * process-stratum-target.c
11212         (process_stratum_target::thread_address_space): Update.
11213         * linux-fork.c (linux_fork_mourn_inferior)
11214         (detach_checkpoint_command, info_checkpoints_command)
11215         (linux_fork_context): Update.
11216         (linux_fork_detach): Update.
11217         (class scoped_switch_fork_info): Update.
11218         (delete_checkpoint_command): Update.
11219         * infrun.c (follow_fork_inferior): Update.
11220         (follow_fork_inferior): Update.
11221         (proceed_after_vfork_done): Update.
11222         (handle_vfork_child_exec_or_exit): Update.
11223         (follow_exec): Update.
11224         (displaced_step_prepare_throw): Update.
11225         (displaced_step_restore): Update.
11226         (start_step_over): Update.
11227         (resume_1): Update.
11228         (clear_proceed_status_thread): Update.
11229         (proceed): Update.
11230         (print_target_wait_results): Update.
11231         (do_target_wait): Update.
11232         (context_switch): Update.
11233         (stop_all_threads): Update.
11234         (restart_threads): Update.
11235         (finish_step_over): Update.
11236         (handle_signal_stop): Update.
11237         (switch_back_to_stepped_thread): Update.
11238         (keep_going_pass_signal): Update.
11239         (print_exited_reason): Update.
11240         (normal_stop): Update.
11241         * inferior.c (inferior_pid_to_str): Change return type.
11242         (print_selected_inferior): Update.
11243         (add_inferior): Update.
11244         (detach_inferior): Update.
11245         * dummy-frame.c (fprint_dummy_frames): Update.
11246         * dcache.c (dcache_info_1): Update.
11247         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11248         (btrace_fetch, btrace_clear): Update.
11249         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11250         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11251         type.
11252         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11253         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11254         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11255         * gdbarch.c, gdbarch.h: Rebuild.
11256         * gdbarch.sh (core_pid_to_str): Change return type.
11257         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11258         return type.
11259         (windows_nat_target::pid_to_str): Change return type.
11260         (windows_delete_thread): Update.
11261         (windows_nat_target::attach): Update.
11262         (windows_nat_target::files_info): Update.
11263         * target-delegates.c: Rebuild.
11264         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11265         return type.
11266         (sol_thread_target::pid_to_str): Change return type.
11267         * remote.c (class remote_target) <pid_to_str>: Change return
11268         type.
11269         (remote_target::pid_to_str): Change return type.
11270         (extended_remote_target::attach, remote_target::remote_stop_ns)
11271         (remote_target::remote_notif_remove_queued_reply)
11272         (remote_target::push_stop_reply, remote_target::disable_btrace):
11273         Update.
11274         (extended_remote_target::attach): Update.
11275         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11276         type.
11277         (gdbsim_target::pid_to_str): Change return type.
11278         * ravenscar-thread.c (struct ravenscar_thread_target)
11279         <pid_to_str>: Change return type.
11280         (ravenscar_thread_target::pid_to_str): Change return type.
11281         * procfs.c (class procfs_target) <pid_to_str>: Change return
11282         type.
11283         (procfs_target::pid_to_str): Change return type.
11284         (procfs_target::attach): Update.
11285         (procfs_target::detach): Update.
11286         (procfs_target::fetch_registers): Update.
11287         (procfs_target::store_registers): Update.
11288         (procfs_target::wait): Update.
11289         (procfs_target::files_info): Update.
11290         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11291         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11292         return type.
11293         (nto_procfs_target::pid_to_str): Change return type.
11294         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11295         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11296         return type.
11297         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11298         (exit_lwp): Update.
11299         (attach_proc_task_lwp_callback, get_detach_signal)
11300         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11301         (linux_nat_target::resume, wait_lwp, stop_callback)
11302         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11303         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11304         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11305         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11306         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11307         type.
11308         (inf_ptrace_target::attach): Update.
11309         (inf_ptrace_target::files_info): Update.
11310         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11311         type.
11312         (go32_nat_target::pid_to_str): Change return type.
11313         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11314         (gnu_nat_target::wait): Update.
11315         (gnu_nat_target::wait): Update.
11316         (gnu_nat_target::resume): Update.
11317         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11318         (fbsd_nat_target::wait): Update.
11319         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11320         type.
11321         (darwin_nat_target::attach): Update.
11322         * corelow.c (class core_target) <pid_to_str>: Change return type.
11323         (core_target::pid_to_str): Change return type.
11324         * target.c (normal_pid_to_str): Change return type.
11325         (default_pid_to_str): Likewise.
11326         (target_pid_to_str): Change return type.
11327         (target_translate_tls_address): Update.
11328         (target_announce_detach): Update.
11329         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11330         return type.
11331         (bsd_uthread_target::pid_to_str): Change return type.
11332         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11333         type.
11334         (bsd_kvm_target::pid_to_str): Change return type.
11335         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11336         return type.
11337         (aix_thread_target::pid_to_str): Change return type.
11338         * target.h (struct target_ops) <pid_to_str>: Change return type.
11339         (target_pid_to_str, normal_pid_to_str): Likewise.
11340         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11341         type.
11342         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11343         type.
11344         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11345         return type.
11346         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11347         type.
11348         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11349         type.
11350         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11351         return type.
11352
11353 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11354
11355         * NEWS: Mention that the new default MI version is 3.  Mention
11356         changes to the output of commands and events that deal with
11357         multi-location breakpoints.
11358         * breakpoint.c: Include "mi/mi-out.h".
11359         (print_one_breakpoint): Change output syntax if using MI version
11360         >= 3.
11361         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11362         New.
11363         (mi_multi_location_breakpoint_output_fixed): New.
11364         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11365         (mi_cmd_fix_multi_location_breakpoint_output): New.
11366         (mi_multi_location_breakpoint_output_fixed): New.
11367         * mi/mi-cmds.c (mi_cmds): Register command
11368         -fix-multi-location-breakpoint-output.
11369         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11370         interpreter "mi".
11371
11372 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11373
11374         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11375         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11376         instantiate mi_ui_out based on interpreter name.
11377         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11378         * mi/mi-main.c (mi_load_progress): Likewise.
11379
11380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11381
11382         * NEWS: Combine separate "New targets" sections for 8.3.
11383
11384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11385
11386         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11387         (ppcfbsd_init_abi): Install gdbarch
11388         "fetch_tls_load_module_address" and "get_thread_local_address"
11389         methods.
11390
11391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11392
11393         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11394         (riscv_fbsd_init_abi): Install gdbarch
11395         "fetch_tls_load_module_address" and "get_thread_local_address"
11396         methods.
11397
11398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11399
11400         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11401         (i386fbsd_init_abi): Install gdbarch
11402         "fetch_tls_load_module_address" and "get_thread_local_address"
11403         methods.
11404
11405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11406
11407         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11408         (amd64fbsd_init_abi): Install gdbarch
11409         "fetch_tls_load_module_address" and "get_thread_local_address"
11410         methods.
11411
11412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11413
11414         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11415         (struct fbsd_pspace_data): New type.
11416         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11417         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11418         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11419         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11420         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11421
11422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11423
11424         * gdbtypes.c (lookup_struct_elt): New function.
11425         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11426         * gdbtypes.h (struct struct_elt): New type.
11427         (lookup_struct_elt): New prototype.
11428
11429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11430
11431         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11432         remove disabled code block.
11433
11434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11435
11436         * gdbarch.sh (get_thread_local_address): New method.
11437         * gdbarch.h, gdbarch.c: Regenerate.
11438         * target.c (target_translate_tls_address): Use
11439         gdbarch_get_thread_local_address if present instead of
11440         target::get_thread_local_address.
11441
11442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11443
11444         * target.h (target::get_thread_local_address): Update comment.
11445
11446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11447
11448         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11449         objfile->separate_debug_objfile_backlink if not NULL.
11450
11451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11452
11453         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11454         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11455         (amd64bsd_store_inferior_registers): Likewise.
11456         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11457         Enable segment base registers.
11458         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11459         PT_GETFSBASE and PT_GETGSBASE.
11460         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11461         PT_SETGSBASE.
11462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11463         segment base registers.
11464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11465
11466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11467
11468         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11469         Update calls to i386_target_description to add 'segments'
11470         parameter.
11471         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11472         add segment base registers.
11473         * arch/i386.c (i386_create_target_description): Add 'segments'
11474         parameter to enable segment base registers.
11475         * arch/i386.h (i386_create_target_description): Likewise.
11476         * features/i386/32bit-segments.xml: New file.
11477         * features/i386/32bit-segments.c: Generate.
11478         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11479         call to i386_target_description to add 'segments' parameter.
11480         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11481         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11482         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11483         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11484         if feature is present.
11485         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11486         Add 'segments' parameter to call to i386_target_description.
11487         (i386_target_description): Add 'segments' parameter to enable
11488         segment base registers.
11489         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11490         to call to i386_target_description.
11491         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11492         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11493         Define I386_NUM_REGS.
11494         (i386_target_description): Add 'segments' parameter to enable
11495         segment base registers.
11496
11497 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11498
11499         PR/24325
11500         * source-cache.c: #undef open and close, to avoid unresolved
11501         externals during linking.
11502
11503 2019-03-12  Tom Tromey  <tromey@adacore.com>
11504
11505         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11506         const.  Add initializers.
11507         (_initialize_remote): Don't initialize ptid globals.
11508
11509 2019-03-12  Pedro Alves  <palves@redhat.com>
11510
11511         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11512
11513 2019-03-12  Pedro Alves  <palves@redhat.com>
11514
11515         * cp-name-parser.y (main): Remove unused 'len' variable.
11516
11517 2019-03-12  Tom Tromey  <tromey@adacore.com>
11518
11519         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11520         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11521
11522 2019-03-12  Tom Tromey  <tromey@adacore.com>
11523
11524         * linux-nat.c (iterate_over_lwps): Update.
11525         (stop_callback): Remove parameter.
11526         (stop_wait_callback, detach_callback, resume_set_callback)
11527         (select_singlestep_lwp_callback, set_ignore_sigint)
11528         (status_callback, resumed_callback, resume_clear_callback)
11529         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11530         data parameter.
11531         (linux_nat_target::detach, linux_nat_target::resume)
11532         (linux_stop_and_wait_all_lwps, select_event_lwp)
11533         (linux_nat_filter_event, linux_nat_wait_1)
11534         (linux_nat_target::kill, linux_nat_target::stop)
11535         (linux_nat_target::stop): Update.
11536         (linux_nat_resume_callback): Change type.
11537         (resume_stopped_resumed_lwps, count_events_callback)
11538         (select_event_lwp_callback): Likewise.
11539         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11540         * arm-linux-nat.c (struct update_registers_data): Remove.
11541         (update_registers_callback): Change type.
11542         (arm_linux_insert_hw_breakpoint1): Update.
11543         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11544         parameter.
11545         (x86_linux_dr_set_addr): Update.
11546         (x86_linux_dr_set_control): Update.
11547         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11548         (iterate_over_lwps): Use gdb::function_view.
11549         * nat/aarch64-linux-hw-point.c (struct
11550         aarch64_dr_update_callback_param): Remove.
11551         (debug_reg_change_callback): Change type.
11552         (aarch64_notify_debug_reg_change): Update.
11553         * s390-linux-nat.c (s390_refresh_per_info): Update.
11554
11555 2019-03-11  Tom Tromey  <tromey@adacore.com>
11556
11557         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11558         redundant assignment to "this_cu".
11559
11560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11561
11562         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11563
11564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11565
11566         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11567         from...
11568         (rank_one_type): ... this.
11569
11570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11571
11572         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11573         from...
11574         (rank_one_type): ... this.
11575
11576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11577
11578         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11579         from...
11580         (rank_one_type): ... this.
11581
11582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11583
11584         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11585         from...
11586         (rank_one_type): ... this.
11587
11588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11589
11590         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11591         from...
11592         (rank_one_type): ... this.
11593
11594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11595
11596         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11597         from...
11598         (rank_one_type): ... this.
11599
11600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11601
11602         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11603         from...
11604         (rank_one_type): ... this.
11605
11606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11607
11608         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11609         from...
11610         (rank_one_type): ... this.
11611
11612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11613
11614         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11615         from...
11616         (rank_one_type): ... this.
11617
11618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11619
11620         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11621         from...
11622         (rank_one_type): ... this.
11623
11624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11625
11626         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11627         from...
11628         (rank_one_type): ... this.
11629
11630 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11631
11632         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11633         from...
11634         (rank_one_type): ... this.
11635
11636 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11637
11638         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11639         inferior-events' shows the example events.
11640
11641 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11642
11643         Support styling on native MS-Windows console
11644
11645         PR/24315
11646         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11647         on MS-Windows if $TERM is not defined.
11648
11649         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11650
11651         * posix-hdep.c (gdb_console_fputs):
11652         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11653         functions.
11654         * ui-file.h (gdb_console_fputs): Add prototype.
11655
11656         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11657         back to fputs only if the former returns zero.
11658
11659 2019-03-07  Tom Tromey  <tom@tromey.com>
11660
11661         * symmisc.c (print_symbol_bcache_statistics): Update.
11662         (print_objfile_statistics): Update.
11663         * symfile.c (allocate_symtab): Update.
11664         * stabsread.c: Don't include bcache.h.
11665         * psymtab.h (struct psymbol_bcache): Don't declare.
11666         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11667         (psymbol_bcache_init, psymbol_bcache_free)
11668         (psymbol_bcache_get_bcache): Don't declare.
11669         * psymtab.c (struct psymbol_bcache): Remove.
11670         (psymtab_storage::psymtab_storage): Update.
11671         (psymtab_storage::~psymtab_storage): Update.
11672         (psymbol_bcache_init, psymbol_bcache_free)
11673         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11674         (add_psymbol_to_bcache): Update.
11675         (allocate_psymtab): Update.
11676         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11677         macro_cache>: No longer pointers.
11678         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11679         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11680         * macrotab.c (macro_bcache): Update.
11681         * macroexp.c: Don't include bcache.h.
11682         * gdbtypes.c (check_types_worklist): Update.
11683         (types_deeply_equal): Remove TRY/CATCH.  Update.
11684         * elfread.c (elf_symtab_read): Update.
11685         * dwarf2read.c: Don't include bcache.h.
11686         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11687         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11688         (print_bcache_statistics, bcache_memory_used): Don't declare.
11689         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11690         methods.  Rename all data members.
11691         * bcache.c (struct bcache): Move to bcache.h.
11692         (bcache::expand_hash_table): Rename from expand_hash_table.
11693         (bcache): Remove.
11694         (bcache::insert): Rename from bcache_full.
11695         (bcache::compare): Rename from bcache_compare.
11696         (bcache_xmalloc): Remove.
11697         (bcache::~bcache): Rename from bcache_xfree.
11698         (bcache::print_statistics): Rename from print_bcache_statistics.
11699         (bcache::memory_used): Rename from bcache_memory_used.
11700
11701 2019-03-07  Pedro Alves  <palves@redhat.com>
11702
11703         * infrun.c (normal_stop): Also check for
11704         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11705
11706 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11707
11708         * f-lang.c (value_from_host_double): Moved to...
11709         * value.c (value_from_host_double): ...here.
11710         * value.h (value_from_host_double): Declare.
11711         * guile/scm-math.c (vlscm_convert_typed_number): Use
11712         value_from_host_double.
11713         (vlscm_convert_number): Likewise.
11714         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11715         * python/py-value.c (convert_value_from_python): Likewise.
11716
11717 2019-03-06  Tom Tromey  <tom@tromey.com>
11718
11719         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11720
11721 2019-03-06  Tom Tromey  <tom@tromey.com>
11722
11723         * utils.h (free_current_contents): Don't declare.
11724         * utils.c (free_current_contents): Remove.
11725
11726 2019-03-06  Tom Tromey  <tom@tromey.com>
11727
11728         * top.c (quit_force): Update.
11729         * main.c (captured_command_loop): Update.
11730         * common/new-op.c (operator new): Update.
11731         * common/common-exceptions.c (struct catcher)
11732         <save_cleanup_chain>: Remove member.
11733         (exceptions_state_mc_init): Update.
11734         (exception_try_scope_entry): Return nullptr.
11735         (exception_try_scope_exit, exception_rethrow)
11736         (throw_exception_sjlj, throw_exception_cxx): Update.
11737         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11738         (all_cleanups, do_cleanups, discard_cleanups)
11739         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11740         (restore_cleanups, restore_final_cleanups): Don't declare.
11741         (do_final_cleanups): Remove parameter.
11742         * common/cleanups.c (cleanup_chain, make_cleanup)
11743         (make_cleanup_dtor, all_cleanups, do_cleanups)
11744         (discard_my_cleanups, discard_cleanups)
11745         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11746         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11747         (null_cleanup): Remove.
11748         (do_final_cleanups): Remove parameter.
11749
11750 2019-03-06  Tom Tromey  <tom@tromey.com>
11751
11752         * remote.c (remote_target::remote_parse_stop_reply): Use
11753         unique_xmalloc_ptr.
11754
11755 2019-03-06  Tom Tromey  <tom@tromey.com>
11756
11757         * stabsread.c (struct stabs_field_info): Rename from field_info.
11758         <list, fnlist>: Add initializers.
11759         <obstack>: New member.
11760         (read_member_functions, read_struct_fields, read_baseclasses):
11761         Allocate on obstack.  Don't use cleanups.
11762         (read_one_struct_field, read_member_functions, read_struct_fields)
11763         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11764         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11765         (read_struct_type): Update.
11766
11767 2019-03-06  Tom Tromey  <tom@tromey.com>
11768
11769         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11770         * common/filestuff.h (make_cleanup_close): Don't declare.
11771         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11772         Remove.
11773
11774 2019-03-06  Tom Tromey  <tom@tromey.com>
11775
11776         * solib-aix.c: Use make_scope_exit.
11777
11778 2019-03-06  Tom Tromey  <tom@tromey.com>
11779
11780         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11781         Use make_scope_exit.
11782
11783 2019-03-06  Tom Tromey  <tom@tromey.com>
11784
11785         * solib-svr4.c (disable_probes_interface): Remove parameter.
11786         (svr4_handle_solib_event): Use make_scope_exit.
11787
11788 2019-03-06  Tom Tromey  <tom@tromey.com>
11789
11790         * remote.c (struct stop_reply_deleter): Remove.
11791         (stop_reply_up): Update.
11792         (struct stop_reply): Derive from notif_event.  Don't typedef.
11793         <regcache>: Now a std::vector.
11794         (stop_reply_xfree): Remove.
11795         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11796         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11797         (remote_target::discard_pending_stop_replies): Use delete.
11798         (remote_target::remote_parse_stop_reply): Update.
11799         (remote_target::process_stop_reply): Update.
11800         * remote-notif.h (struct notif_event): Add virtual destructor.
11801         Remove "dtr" member.
11802         (struct notif_client) <alloc_event>: Return a unique_ptr.
11803         (notif_event_xfree): Don't declare.
11804         (notif_event_up): New typedef.
11805         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11806         (notif_event_xfree, do_notif_event_xfree): Remove.
11807         (remote_notif_state_xfree): Update.
11808
11809 2019-03-06  Tom Tromey  <tom@tromey.com>
11810
11811         * infrun.c (displaced_step_clear_cleanup): Now a
11812         forward_scope_exit type.
11813         (displaced_step_prepare_throw): Update.
11814         (displaced_step_fixup): Update.
11815
11816 2019-03-06  Tom Tromey  <tom@tromey.com>
11817
11818         * inferior.h (class inferior): Update comment.
11819         * gdbthread.h (class thread_info): Update comment.
11820
11821 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11822             Tom Tromey  <tom@tromey.com>
11823
11824         * stabsread.h (struct stab_section_list): Remove.
11825         (coffstab_build_psymtabs): Update.
11826         * dbxread.c (symbuf_sections): Now a std::vector.
11827         (sect_idx): New global.
11828         (fill_symbuf): Update.
11829         (coffstab_build_psymtabs): Change type of stabsects parameter.
11830         Update.
11831         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11832         std::vector.
11833         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11834         (coff_locate_sections): Update.
11835         (coff_symfile_read): Remove cleanups.  Update.
11836         (init_stringtab): Add storage parameter.
11837         (free_stringtab, free_stringtab_cleanup): Remove.
11838         (init_lineno): Add storage parameter.
11839         (free_linetab, free_linetab_cleanup): Remove.
11840
11841 2019-03-06  Pedro Alves  <palves@redhat.com>
11842
11843         * linux-fork.c (fork_info::clobber_regs): Delete.
11844         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11845         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11846         comment.  Adjust.
11847         (scoped_switch_fork_info::scoped_switch_fork_info)
11848         (checkpoint_command, linux_fork_context): Adjust
11849         fork_save_infrun_state calls.
11850
11851 2019-03-06  Pedro Alves  <palves@redhat.com>
11852
11853         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11854         (inf_has_multiple_threads): Return 'bool' and rewrite using
11855         inferior_info::threads().
11856
11857 2019-03-06  Pedro Alves  <palves@redhat.com>
11858
11859         * linux-fork.c: Include <list>.
11860         (fork_list): Now a std::list instance.
11861         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11862         (forks_exist_p, find_last_fork): Adjust.
11863         (new_fork): Delete.
11864         (one_fork_p): New.
11865         (add_fork): Adjust.
11866         (free_fork): Delete, folded into fork_info::~fork_info().
11867         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11868         Adjust.
11869         (init_fork_list): Delete.
11870         (linux_fork_killall, linux_fork_mourn_inferior)
11871         (linux_fork_detach, info_checkpoints_command): Adjust.
11872         (_initialize_linux_fork): No longer call init_fork_list.
11873
11874 2019-03-06  Pedro Alves  <palves@redhat.com>
11875
11876         * linux-fork.c (new_fork): New, split out of ...
11877         (add_fork): ... this.  Return void.  Move "first fork" special
11878         case from here, to ...
11879         (checkpoint_command): ... here.
11880         * linux-linux.h (add_fork): Return void.
11881
11882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11883
11884         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11885
11886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11887             Chris January  <chris.january@arm.com>
11888             David Lecomber  <david.lecomber@arm.com>
11889
11890         * f-exp.y: New token, UNOP_INTRINSIC.
11891         (exp): New pattern using UNOP_INTRINSIC token.
11892         (f77_keywords): Add 'abs' keyword.
11893         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11894         (value_from_host_double): New function.
11895         (evaluate_subexp_f): Support UNOP_ABS.
11896
11897 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11898
11899         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11900         types.
11901
11902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11903
11904         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11905         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11906         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11907
11908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11909
11910         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11911
11912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11913             Chris January  <chris.january@arm.com>
11914
11915         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11916         * f-exp.y: Define 'KIND' token.
11917         (exp): New pattern for KIND expressions.
11918         (ptype): Handle types with a kind extension.
11919         (direct_abs_decl): Extend to spot kind extensions.
11920         (f77_keywords): Add 'kind' to the list.
11921         (push_kind_type): New function.
11922         (convert_to_kind_type): New function.
11923         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11924         * parse.c (operator_length_standard): Likewise.
11925         * parser-defs.h (enum type_pieces): Add tp_kind.
11926         * std-operator.def: Add UNOP_KIND.
11927
11928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11929
11930         * f-exp.y (f_parse): Set yydebug.
11931
11932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11933
11934         * f-lang.c (evaluate_subexp_f): New function.
11935         (exp_descriptor_f): New global.
11936         (f_language_defn): Use exp_descriptor_f instead of
11937         exp_descriptor_standard.
11938
11939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11940
11941         * f-exp.y (struct token): Add comments.
11942         (dot_ops): Remove uppercase versions and the end marker.
11943         (f77_keywords): Likewise.
11944         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11945         entries in the dot_ops array are case insensitive, and use
11946         strncasecmp to compare strings.  Also some whitespace cleanup in
11947         this area.  Similar for the f77_keywords array, except entries in
11948         this list might be case sensitive.
11949
11950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11951
11952         * f-exp.y (struct f77_boolean_val): Add comments.
11953         (boolean_values): Remove uppercase versions, and end marker.
11954         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11955         and use strncasecmp to achieve case insensitivity.  Additionally,
11956         perform whitespace cleanup around this code.
11957
11958 2019-03-06  Tom Tromey  <tromey@adacore.com>
11959
11960         * remote-sim.c (gdbsim_target_open): Use result of
11961         gdb_argv::release.
11962
11963 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11964         Dirk Schubert  <dirk.schubert@arm.com>
11965         Chris January  <chris.january@arm.com>
11966
11967         * eval.c (evaluate_subexp_standard): Call Fortran argument
11968         wrapping logic.
11969         * f-lang.c (struct value): A value which can be passed into a
11970         Fortran function call.
11971         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11972         where appropriate.
11973         (struct type): Value ready for a Fortran function call.
11974         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11975         is needed.
11976         * f-lang.h (fortran_argument_convert): Declaration.
11977         (fortran_preserve_arg_pointer): Declaration.
11978         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11979
11980 2019-03-05  Tom Tromey  <tromey@adacore.com>
11981
11982         * python/py-prettyprint.c (print_string_repr): Remove #if.
11983         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11984
11985 2019-03-05  Tom Tromey  <tromey@adacore.com>
11986
11987         * target.c (the_dummy_target): Move later.  Change type to
11988         "dummy_target".
11989         (initialize_targets): Don't initialize the_dummy_target.
11990
11991 2019-03-05  Tom Tromey  <tromey@adacore.com>
11992
11993         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11994         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11995
11996 2019-03-05  Tom Tromey  <tromey@adacore.com>
11997
11998         * windows-nat.c (windows_nat_target::attach)
11999         (windows_nat_target::detach): Don't call gdb_flush.
12000         * valprint.c (generic_val_print, val_print, val_print_string):
12001         Don't call gdb_flush.
12002         * utils.c (defaulted_query): Don't call gdb_flush.
12003         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12004         * target.c (target_announce_detach): Don't call gdb_flush.
12005         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12006         * remote.c (extended_remote_target::attach): Don't call
12007         gdb_flush.
12008         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12009         * printcmd.c (do_examine): Don't call gdb_flush.
12010         (info_display_command): Don't call gdb_flush.
12011         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12012         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12013         * memattr.c (info_mem_command): Don't call gdb_flush.
12014         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12015         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12016         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12017         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12018         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12019         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12020         (gnu_nat_target::detach): Don't call gdb_flush.
12021         * f-valprint.c (f_val_print): Don't call gdb_flush.
12022         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12023         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12024         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12025         gdb_flush.
12026         * c-valprint.c (c_val_print): Don't call gdb_flush.
12027         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12028
12029 2019-03-05  Tom Tromey  <tromey@adacore.com>
12030
12031         * varobj.c (update_dynamic_varobj_children): Update.
12032         (install_default_visualizer): Use reset, not release.
12033         * value.c (set_internalvar): Update.
12034         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12035         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12036         ATTRIBUTE_UNUSED_RESULT.
12037
12038 2019-03-05  Tom Tromey  <tromey@adacore.com>
12039
12040         * remote.c (class scoped_remote_fd) <release>: Add
12041         ATTRIBUTE_UNUSED_RESULT.
12042
12043 2019-03-05  Tom Tromey  <tromey@adacore.com>
12044
12045         * macroexp.c (struct macro_buffer) <release>: Add
12046         ATTRIBUTE_UNUSED_RESULT.
12047
12048 2019-03-05  Tom Tromey  <tromey@adacore.com>
12049
12050         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12051         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12052         ATTRIBUTE_UNUSED_RESULT.
12053
12054 2019-03-05  Tom Tromey  <tromey@adacore.com>
12055
12056         * common/scoped_fd.h (class scoped_fd) <release>: Add
12057         ATTRIBUTE_UNUSED_RESULT.
12058
12059 2019-03-05  Tom Tromey  <tromey@adacore.com>
12060
12061         * parser-defs.h (struct parser_state) <release>: Add
12062         ATTRIBUTE_UNUSED_RESULT.
12063
12064 2019-03-05  Tom Tromey  <tromey@adacore.com>
12065
12066         * utils.h (class gdb_argv) <release>: Add
12067         ATTRIBUTE_UNUSED_RESULT.
12068         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12069
12070 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12071
12072         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12073         for-loop range, to avoid compiler warnings.
12074
12075         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12076         avoid compiler warnings about unused variables.
12077
12078         * NEWS: Mention end of support for native debugging on MS-Windows
12079         before XP.
12080
12081         PR gdb/24292
12082         * common/netstuff.c:
12083         * gdbserver/gdbreplay.c
12084         * gdbserver/remote-utils.c:
12085         * ser-tcp.c:
12086         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12087         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12088         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12089         'getaddrinfo' and 'freeaddrinfo' were not available before
12090         Windows XP, and mingw.org's MinGW headers by default define
12091         _WIN32_WINNT to 0x500.
12092
12093 2019-03-01  Gary Benson <gbenson@redhat.com>
12094
12095         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12096
12097 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12098             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12099
12100         PR gdb/8527
12101         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12102         set_sigint_trap, clear_sigint_trap.
12103
12104 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12105
12106         * target.c (target_detach): Clear the regcache and the
12107         frame cache.
12108
12109 2019-02-27  Pedro Alves  <palves@redhat.com>
12110
12111         * utils.c (set_screen_size): When we cap the height/width sizes,
12112         tweak the corresponding command variable to show "unlimited":
12113
12114 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12115             Pedro Alves  <palves@redhat.com>
12116
12117         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12118         before calling rl_set_screen_size.
12119
12120 2019-02-27  Tom Tromey  <tromey@adacore.com>
12121
12122         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12123         define.
12124         * python/py-value.c: Remove Python 2.4 workaround.
12125         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12126         workaround.
12127         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12128         Python 2.4 workaround.
12129         * python/python-internal.h: Remove Python 2.4 comment.
12130         (Py_ssize_t): Don't define.
12131         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12132         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12133         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12134         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12135         * python/python.c (do_start_initialization): Remove Python 2.4
12136         workaround.
12137         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12138         (print_children): Remove Python 2.4 workaround.
12139         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12140         workaround.
12141         (CHARBUFFERPROC_NAME): Remove.
12142         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12143         Python 2.4 workaround.
12144
12145 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12146
12147         * NEWS: Note minimum Python version.
12148
12149 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12150
12151         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12152         code from these functions.  Remove corresponding ifdefs.  Use
12153         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12154         Remove gotos and target of gotos.
12155         (infpy_search_memory): Likewise.
12156
12157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12158
12159         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12160         (hppa_gdbarch_init): Don't register deleted functions with
12161         gdbarch.
12162
12163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12164
12165         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12166         (h8300_unwind_sp): Delete.
12167         (h8300_dummy_id): Delete.
12168         (h8300_gdbarch_init): Don't register deleted functions with
12169         gdbarch.
12170
12171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12172
12173         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12174         (ft32_unwind_pc): Delete.
12175         (ft32_unwind_sp): Delete.
12176         (ft32_gdbarch_init): Don't register deleted functions with
12177         gdbarch.
12178
12179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12180
12181         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12182         (frv_unwind_pc): Delete.
12183         (frv_unwind_sp): Delete.
12184         (frv_gdbarch_init): Don't register deleted functions with
12185         gdbarch.
12186
12187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12188
12189         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12190         (riscv_unwind_pc): Delete.
12191         (riscv_unwind_sp): Delete.
12192         (riscv_gdbarch_init): Don't register deleted functions with
12193         gdbarch.
12194
12195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12196
12197         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12198         (csky_unwind_pc): Delete.
12199         (csky_unwind_sp): Delete.
12200         (csky_gdbarch_init): Don't register deleted functions with
12201         gdbarch.
12202
12203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12204
12205         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12206         (cris_unwind_pc): Delete.
12207         (cris_unwind_sp): Delete.
12208         (cris_gdbarch_init): Don't register deleted functions with
12209         gdbarch.
12210
12211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12212
12213         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12214         (bfin_unwind_pc): Delete.
12215         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12216
12217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12218
12219         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12220         (arm_unwind_pc): Delete.
12221         (arm_unwind_sp): Delete.
12222         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12223
12224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12225
12226         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12227         (arc_unwind_pc): Delete.
12228         (arc_unwind_sp): Delete.
12229         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12230
12231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12232
12233         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12234         (alpha_unwind_pc): Delete.
12235         (alpha_gdbarch_init): Don't register deleted functions with
12236         gdbarch.
12237
12238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12239
12240         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12241         (aarch64_unwind_pc): Delete.
12242         (aarch64_unwind_sp): Delete.
12243         (aarch64_gdbarch_init): Don't register deleted functions with
12244         gdbarch.
12245
12246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12247
12248         * gdbtypes.c (type_align): Don't consider static members when
12249         computing structure alignment.
12250
12251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12252
12253         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12254         return 0 for other types.
12255         * arch-utils.c (default_type_align): Always return 0.
12256         * gdbarch.h: Regenerate.
12257         * gdbarch.sh (type_align): Extend comment.
12258         * gdbtypes.c (type_align): Add additional comments, always call
12259         gdbarch_type_align before applying the default rules.
12260         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12261         generic code will then apply a suitable default.
12262         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12263         types, return 0 for other types.
12264
12265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12266
12267         * NEWS: Create a new section for the next release branch.
12268         Rename the section of the current branch, now that it has
12269         been cut.
12270
12271 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12272
12273         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12274         * version.in: Bump version to 8.3.50.DATE-git.
12275
12276 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12277
12278         * aix-thread.c (ptid_cmp): Remove unused variable.
12279         (get_signaled_thread): Likewise.
12280         (store_regs_user_thread): Likewise.
12281         (store_regs_kernel_thread): Likewise.
12282         (fetch_regs_kernel_thread): Remove shadowed variable.
12283
12284 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12285
12286         * features/riscv/32bit-cpu.xml: Add register numbers.
12287         * features/riscv/32bit-fpu.c: Regenerate.
12288         * features/riscv/32bit-fpu.xml: Add register numbers.
12289         * features/riscv/64bit-cpu.xml: Add register numbers.
12290         * features/riscv/64bit-fpu.c: Regenerate.
12291         * features/riscv/64bit-fpu.xml: Add register numbers.
12292
12293 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12294
12295         * NEWS: Mention two argument form of gdb.Value constructor.
12296         * python/py-value.c (convert_buffer_and_type_to_value): New
12297         function.
12298         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12299         Add support for handling an optional second argument.  Call
12300         convert_buffer_and_type_to_value as appropriate.
12301         * python/python-internal.h (Py_buffer_deleter): New struct.
12302         (Py_buffer_up): New typedef.
12303
12304 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12305
12306         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12307         instead of releasing ownership.
12308
12309 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12310
12311         * dwarf2read.c (open_and_init_dwp_file): Call
12312         elf_numsections instead of bfd_count_sections to initialize
12313         dwp_file->num_sections.
12314
12315 2019-02-25  Tom Tromey  <tromey@adacore.com>
12316
12317         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12318
12319 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12320
12321         * gcore.in: Add '--readnever' option when invoking GDB.
12322
12323 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12324
12325         * MAINTAINERS: Update my email address.
12326
12327 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12328
12329         * build-id.c (build_id_to_debug_bfd_1): New function.
12330         (build_id_to_debug_bfd): Look for separate debug file in
12331         sysroot.
12332
12333 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12334
12335         * gdbarch.sh: Update the copyright year range that is placed into
12336         generated files.
12337
12338 2019-02-22  Keith Seitz  <keiths@redhat.com>
12339
12340         PR symtab/23853
12341         * linespec.c (create_sals_line_offset): Search for the default
12342         symtab's filename instead of its fullname.
12343
12344 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12345
12346         * NEWS: Update style defaults.
12347
12348 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12349
12350         * main.c (captured_main_1): Disable styling in batch mode.
12351
12352 2019-02-20  Tom Tromey  <tom@tromey.com>
12353
12354         * symtab.c (symtab_symbol_info): Fix typos.
12355
12356 2019-02-20  Tom Tromey  <tromey@adacore.com>
12357
12358         * findcmd.c (_initialize_mem_search): Use upper case for
12359         metasyntactic variables.
12360
12361 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12362
12363         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12364         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12365
12366 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12367
12368         * top.h (source_file_name): Change to std::string.
12369         * top.c (source_file_name): Likewise.
12370         (command_line_input): Adjust.
12371         * cli/cli-script.c (script_from_file): Adjust.
12372
12373 2019-02-19  Tom Tromey  <tromey@adacore.com>
12374
12375         * ravenscar-thread.c
12376         (ravenscar_thread_target::update_thread_list): Don't call
12377         ada_build_task_list.
12378         * ada-lang.h (ada_build_task_list): Don't declare.
12379         * ada-tasks.c (struct ada_tasks_inferior_data)
12380         <task_list_valid_p>: Now bool.
12381         (read_known_tasks, ada_task_list_changed)
12382         (ada_tasks_invalidate_inferior_data): Update.
12383         (read_known_tasks_array): Return bool.
12384         (read_known_tasks_list): Likewise.
12385         (read_known_tasks): Return void.
12386         (ada_build_task_list): Now static.
12387
12388 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12389
12390         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12391         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12392
12393 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12394
12395         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12396         variant for ada_tasks_pspace_data_handle and
12397         ada_tasks_inferior_data_handle.
12398         (ada_tasks_pspace_data_cleanup): New function.
12399         (ada_tasks_inferior_data_cleanup): New function.
12400
12401 2019-02-17  Tom Tromey  <tom@tromey.com>
12402
12403         * macrotab.h (macro_source_fullname): Return a std::string.
12404         * macrotab.c (macro_include, check_for_redefinition)
12405         (macro_undef, macro_lookup_definition, foreach_macro)
12406         (foreach_macro_in_scope): Update.
12407         (macro_source_fullname): Return a std::string.
12408         * macrocmd.c (show_pp_source_pos): Update.
12409
12410 2019-02-17  Tom Tromey  <tom@tromey.com>
12411
12412         * macrocmd.c (show_pp_source_pos): Style the file names.
12413
12414 2019-02-17  Tom Tromey  <tom@tromey.com>
12415
12416         PR tui/24197:
12417         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12418
12419 2019-02-17  Tom Tromey  <tom@tromey.com>
12420
12421         * ada-lang.c (user_select_syms): Use filtered printing.
12422         * utils.c (wrap_style): New global.
12423         (desired_style): Remove.
12424         (emit_style_escape): Add stream parameter.
12425         (set_output_style, reset_terminal_style, prompt_for_continue):
12426         Update.
12427         (flush_wrap_buffer): Only flush gdb_stdout.
12428         (wrap_here): Set wrap_style.
12429         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12430         treat escape sequences as a character.  Change when wrap buffer is
12431         flushed.
12432         (fputs_styled): Do not set the output style when the default is
12433         requested.
12434         * ui-style.h (struct ui_file_style) <is_default>: New method.
12435         * source.c (print_source_lines_base): Emit escape sequences in one
12436         piece.
12437
12438 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12439
12440         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12441         integers and enumeration types.
12442
12443 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12444
12445         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12446         instead of lookup_symbol_in_language
12447         (do_exact_match): New function.
12448         (ada_get_symbol_name_matcher): Return do_exact_match when
12449         doing a verbatim match.
12450
12451 2019-02-15  Tom Tromey  <tromey@adacore.com>
12452
12453         * ravenscar-thread.c (ravenscar_thread_target::resume)
12454         (ravenscar_thread_target::wait): Special case wildcard requests.
12455
12456 2019-02-15  Tom Tromey  <tromey@adacore.com>
12457
12458         * ravenscar-thread.c (base_ptid): Remove.
12459         (struct ravenscar_thread_target) <close>: New method.
12460         <m_base_ptid>: New member.
12461         <update_inferior_ptid, active_task, task_is_currently_active,
12462         runtime_initialized>: Declare methods.
12463         <ravenscar_thread_target>: Add constructor.
12464         (ravenscar_thread_target::task_is_currently_active)
12465         (ravenscar_thread_target::update_inferior_ptid)
12466         (ravenscar_runtime_initialized): Rename.  Now methods.
12467         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12468         (ravenscar_thread_target::update_thread_list): Update.
12469         (ravenscar_thread_target::active_task): Now method.
12470         (ravenscar_thread_target::store_registers)
12471         (ravenscar_thread_target::prepare_to_store)
12472         (ravenscar_thread_target::prepare_to_store)
12473         (ravenscar_thread_target::mourn_inferior): Update.
12474         (ravenscar_inferior_created): Use "new" to create target.
12475         (ravenscar_thread_target::get_ada_task_ptid): Update.
12476         (_initialize_ravenscar): Don't initialize base_ptid.
12477         (ravenscar_ops): Remove global.
12478
12479 2019-02-15  Tom Tromey  <tromey@adacore.com>
12480
12481         * target.h (push_target): Declare new overload.
12482         * target.c (push_target): New overload, taking an rvalue reference.
12483         * remote.c (remote_target::open_1): Use push_target overload.
12484         * corelow.c (core_target_open): Use push_target overload.
12485
12486 2019-02-15  Tom Tromey  <tromey@adacore.com>
12487
12488         * ravenscar-thread.c (is_ravenscar_task)
12489         (ravenscar_task_is_currently_active): Return bool.
12490         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12491         (_initialize_ravenscar): Remove "(void)".
12492         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12493         Return bool.
12494
12495 2019-02-15  Tom Tromey  <tromey@adacore.com>
12496
12497         * ravenscar-thread.c (ravenscar_runtime_initializer)
12498         (has_ravenscar_runtime, get_running_thread_id)
12499         (ravenscar_thread_target::resume): Fix indentation.
12500
12501 2019-02-15  Tom Tromey  <tromey@adacore.com>
12502
12503         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12504         from ravenscar_arch_ops.
12505         (sparc_ravenscar_ops::fetch_registers)
12506         (sparc_ravenscar_ops::store_registers): Now methods.
12507         (sparc_ravenscar_prepare_to_store): Remove.
12508         (sparc_ravenscar_ops): Redefine.
12509         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12510         methods and destructor.  Remove members.
12511         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12512         (ravenscar_thread_target::store_registers)
12513         (ravenscar_thread_target::prepare_to_store): Update.
12514         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12515         Remove.
12516         (struct ppc_ravenscar_powerpc_ops): Derive from
12517         ravenscar_arch_ops.
12518         (ppc_ravenscar_powerpc_ops::fetch_registers)
12519         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12520         (ppc_ravenscar_powerpc_ops): Redefine.
12521         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12522         (ppc_ravenscar_e500_ops::fetch_registers)
12523         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12524         (ppc_ravenscar_e500_ops): Redefine.
12525         * aarch64-ravenscar-thread.c
12526         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12527         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12528         (aarch64_ravenscar_fetch_registers)
12529         (aarch64_ravenscar_store_registers): Now methods.
12530         (aarch64_ravenscar_ops): Redefine.
12531
12532 2019-02-15  Tom Tromey  <tromey@adacore.com>
12533
12534         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12535         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12536         (ravenscar_thread_target::stopped_by_watchpoint)
12537         (ravenscar_thread_target::stopped_data_address)
12538         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12539
12540 2019-02-15  Tom Tromey  <tromey@adacore.com>
12541
12542         * ravenscar-thread.c: Fix some typos.
12543
12544 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12545             Tom Tromey  <tromey@adacore.com>
12546
12547         * ada-lang.c (ada_exception_sal): Change addr_string to a
12548         std::string.
12549         (create_ada_exception_catchpoint): Update.
12550
12551 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12552             Tom Tromey  <tromey@adacore.com>
12553
12554         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12555         (bp_location_ops): Remove.
12556         (base_breakpoint_allocate_location): Update.
12557         (free_bp_location): Update.
12558         * ada-lang.c (class ada_catchpoint_location)
12559         <ada_catchpoint_location>: Remove ops parameter.
12560         (ada_catchpoint_location_dtor): Remove.
12561         (ada_catchpoint_location_ops): Remove.
12562         (allocate_location_exception): Update.
12563         * breakpoint.h (struct bp_location_ops): Remove.
12564         (class bp_location) <bp_location>: Remove bp_location_ops
12565         parameter.
12566         <~bp_location>: Add destructor.
12567         <ops>: Remove.
12568
12569 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12570             Pedro Alves  <palves@redhat.com>
12571
12572         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12573         'PATH_MAX'.
12574
12575 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12576             Samuel Thibault  <samuel.thibault@gnu.org>
12577             Thomas Schwinge  <thomas@codesourcery.com>
12578
12579         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12580         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12581
12582 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12583
12584         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12585         (check_empty): Use "const char *".
12586
12587         * gnu-nat.c (gnu_nat_target::detach): Instead of
12588         'detach_inferior (pid)' call
12589         'detach_inferior (find_inferior_pid (pid))'.
12590
12591         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12592         'nat/fork-inferior.o'.
12593         * gnu-nat.c: #include "nat/fork-inferior.h".
12594
12595         * gnu-nat.c (gnu_nat_target::detach): Instead of
12596         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12597         * gnu-nat.h: #include "inf-child.h".
12598         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12599         'i386_gnu_nat_target::fetch_registers'.
12600         (gnu_store_registers): Rename/move to
12601         'i386_gnu_nat_target::store_registers'.
12602
12603         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12604         * gnu-nat.h (mach_thread_info): New function.
12605         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12606
12607         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12608
12609 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12610
12611         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12612
12613 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12614
12615         * windows-nat.c (windows_add_thread): Add new parameter
12616         "main_thread_p" with default value set to false.  Update
12617         function documentation as well as all callers.
12618         (windows_delete_thread): Likewise.
12619         (fake_create_process): Update call to windows_add_thread.
12620         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12621         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12622         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12623         call to windows_delete_thread.
12624
12625 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12626
12627         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12628
12629 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12630
12631         * symfile.c (find_separate_debug_file): Use canonical path of
12632         sysroot with child_path instead of gdb_sysroot if it is valid.
12633
12634 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12635
12636         * symfile.c (find_separate_debug_file): Use child_path to
12637         determine if an object file is under a sysroot.
12638
12639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12640
12641         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12642         unittests/child-path-selftests.c.
12643         * common/pathstuff.c (child_path): New function.
12644         * common/pathstuff.h (child_path): New prototype.
12645         * unittests/child-path-selftests.c: New file.
12646
12647 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12648
12649         * symfile.c (find_separate_debug_file): Look for separate debug
12650         files in debug directories under the sysroot.
12651
12652 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12653
12654         * symtab.h (struct minimal_symbol data_p): New const method.
12655         (struct minimal_symbol text_p): Likewise.
12656         * symtab.c (output_source_filename): Use file name style
12657         to print file name.
12658         (print_symbol_info): Likewise.
12659         (print_msymbol_info): Use address style to print addresses.
12660         Use function name style to print executable text symbols.
12661         (expand_symtab_containing_pc): Use data_p.
12662         (find_pc_sect_compunit_symtab): Likewise.
12663
12664 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12665
12666         * breakpoint.c (describe_other_breakpoints): Use address style
12667         to print addresses.
12668         (say_where): Likewise.
12669
12670 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12671
12672         * ada-typeprint.c (print_func_type): Print function name
12673         style to print function name.
12674         * c-typeprint.c (c_print_type_1): Likewise.
12675
12676 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12677
12678         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12679         for execve.
12680
12681 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12682
12683         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12684         type_stack.
12685
12686 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12687
12688         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12689         TYPE_CODE_REF types.
12690
12691 2019-02-08  Jim Wilson  <jimw@sifive.com>
12692
12693         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12694         (riscv_linux_fregset): New.
12695         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12696
12697 2019-02-07  Tom Tromey  <tom@tromey.com>
12698
12699         * thread.c (thread_cancel_execution_command): Update.
12700         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12701         methods.
12702         (struct thread_fsm_ops): Remove.
12703         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12704         (thread_fsm_should_stop, thread_fsm_return_value)
12705         (thread_fsm_set_finished, thread_fsm_finished_p)
12706         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12707         Don't declare.
12708         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12709         * infrun.c (clear_proceed_status_thread)
12710         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12711         (print_stop_event): Update.
12712         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12713         Add constructor.
12714         (step_command_fsm_ops): Remove.
12715         (new_step_command_fsm): Remove.
12716         (step_1): Update.
12717         (step_command_fsm::should_stop): Rename from
12718         step_command_fsm_should_stop.
12719         (step_command_fsm::clean_up): Rename from
12720         step_command_fsm_clean_up.
12721         (step_command_fsm::do_async_reply_reason): Rename from
12722         step_command_fsm_async_reply_reason.
12723         (struct until_next_fsm): Inherit from thread_fsm.  Add
12724         constructor.
12725         (until_next_fsm_ops): Remove.
12726         (new_until_next_fsm): Remove.
12727         (until_next_fsm::should_stop): Rename from
12728         until_next_fsm_should_stop.
12729         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12730         (until_next_fsm::do_async_reply_reason): Rename from
12731         until_next_fsm_async_reply_reason.
12732         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12733         constructor.  Change type of breakpoint.
12734         (finish_command_fsm_ops): Remove.
12735         (new_finish_command_fsm): Remove.
12736         (finish_command_fsm::should_stop): Rename from
12737         finish_command_fsm_should_stop.
12738         (finish_command_fsm::clean_up): Rename from
12739         finish_command_fsm_clean_up.
12740         (finish_command_fsm::return_value): Rename from
12741         finish_command_fsm_return_value.
12742         (finish_command_fsm::do_async_reply_reason): Rename from
12743         finish_command_fsm_async_reply_reason.
12744         (finish_command): Update.
12745         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12746         Add constructor.
12747         (call_thread_fsm_ops): Remove.
12748         (call_thread_fsm::call_thread_fsm): Rename from
12749         new_call_thread_fsm.
12750         (call_thread_fsm::should_stop): Rename from
12751         call_thread_fsm_should_stop.
12752         (call_thread_fsm::should_notify_stop): Rename from
12753         call_thread_fsm_should_notify_stop.
12754         (run_inferior_call, call_function_by_hand_dummy): Update.
12755         * cli/cli-interp.c (should_print_stop_to_console): Update.
12756         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12757         Add constructor.  Change type of location_breakpoint,
12758         caller_breakpoint.
12759         (until_break_fsm_ops): Remove.
12760         (new_until_break_fsm): Remove.
12761         (until_break_fsm::should_stop): Rename from
12762         until_break_fsm_should_stop.
12763         (until_break_fsm::clean_up): Rename from
12764         until_break_fsm_clean_up.
12765         (until_break_fsm::do_async_reply_reason): Rename from
12766         until_break_fsm_async_reply_reason.
12767         (until_break_command): Update.
12768         * thread-fsm.c: Remove.
12769         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12770
12771 2019-02-07  Tom Tromey  <tom@tromey.com>
12772
12773         * yy-remap.h: Add include guard.
12774         * xtensa-tdep.h: Add include guard.
12775         * xcoffread.h: Rename include guard.
12776         * varobj-iter.h: Add include guard.
12777         * tui/tui.h: Rename include guard.
12778         * tui/tui-winsource.h: Rename include guard.
12779         * tui/tui-wingeneral.h: Rename include guard.
12780         * tui/tui-windata.h: Rename include guard.
12781         * tui/tui-win.h: Rename include guard.
12782         * tui/tui-stack.h: Rename include guard.
12783         * tui/tui-source.h: Rename include guard.
12784         * tui/tui-regs.h: Rename include guard.
12785         * tui/tui-out.h: Rename include guard.
12786         * tui/tui-layout.h: Rename include guard.
12787         * tui/tui-io.h: Rename include guard.
12788         * tui/tui-hooks.h: Rename include guard.
12789         * tui/tui-file.h: Rename include guard.
12790         * tui/tui-disasm.h: Rename include guard.
12791         * tui/tui-data.h: Rename include guard.
12792         * tui/tui-command.h: Rename include guard.
12793         * tic6x-tdep.h: Add include guard.
12794         * target/waitstatus.h: Rename include guard.
12795         * target/wait.h: Rename include guard.
12796         * target/target.h: Rename include guard.
12797         * target/resume.h: Rename include guard.
12798         * target-float.h: Rename include guard.
12799         * stabsread.h: Add include guard.
12800         * rs6000-tdep.h: Add include guard.
12801         * riscv-fbsd-tdep.h: Add include guard.
12802         * regformats/regdef.h: Rename include guard.
12803         * record.h: Rename include guard.
12804         * python/python.h: Rename include guard.
12805         * python/python-internal.h: Rename include guard.
12806         * python/py-stopevent.h: Rename include guard.
12807         * python/py-ref.h: Rename include guard.
12808         * python/py-record.h: Rename include guard.
12809         * python/py-record-full.h: Rename include guard.
12810         * python/py-record-btrace.h: Rename include guard.
12811         * python/py-instruction.h: Rename include guard.
12812         * python/py-events.h: Rename include guard.
12813         * python/py-event.h: Rename include guard.
12814         * procfs.h: Add include guard.
12815         * proc-utils.h: Add include guard.
12816         * p-lang.h: Add include guard.
12817         * or1k-tdep.h: Rename include guard.
12818         * observable.h: Rename include guard.
12819         * nto-tdep.h: Rename include guard.
12820         * nat/x86-linux.h: Rename include guard.
12821         * nat/x86-linux-dregs.h: Rename include guard.
12822         * nat/x86-gcc-cpuid.h: Add include guard.
12823         * nat/x86-dregs.h: Rename include guard.
12824         * nat/x86-cpuid.h: Rename include guard.
12825         * nat/ppc-linux.h: Rename include guard.
12826         * nat/mips-linux-watch.h: Rename include guard.
12827         * nat/linux-waitpid.h: Rename include guard.
12828         * nat/linux-ptrace.h: Rename include guard.
12829         * nat/linux-procfs.h: Rename include guard.
12830         * nat/linux-osdata.h: Rename include guard.
12831         * nat/linux-nat.h: Rename include guard.
12832         * nat/linux-namespaces.h: Rename include guard.
12833         * nat/linux-btrace.h: Rename include guard.
12834         * nat/glibc_thread_db.h: Rename include guard.
12835         * nat/gdb_thread_db.h: Rename include guard.
12836         * nat/gdb_ptrace.h: Rename include guard.
12837         * nat/fork-inferior.h: Rename include guard.
12838         * nat/amd64-linux-siginfo.h: Rename include guard.
12839         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12840         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12841         * nat/aarch64-linux.h: Rename include guard.
12842         * nat/aarch64-linux-hw-point.h: Rename include guard.
12843         * mn10300-tdep.h: Add include guard.
12844         * mips-linux-tdep.h: Add include guard.
12845         * mi/mi-parse.h: Rename include guard.
12846         * mi/mi-out.h: Rename include guard.
12847         * mi/mi-main.h: Rename include guard.
12848         * mi/mi-interp.h: Rename include guard.
12849         * mi/mi-getopt.h: Rename include guard.
12850         * mi/mi-console.h: Rename include guard.
12851         * mi/mi-common.h: Rename include guard.
12852         * mi/mi-cmds.h: Rename include guard.
12853         * mi/mi-cmd-break.h: Rename include guard.
12854         * m2-lang.h: Add include guard.
12855         * location.h: Rename include guard.
12856         * linux-record.h: Rename include guard.
12857         * linux-nat.h: Add include guard.
12858         * linux-fork.h: Add include guard.
12859         * i386-darwin-tdep.h: Rename include guard.
12860         * hppa-linux-offsets.h: Add include guard.
12861         * guile/guile.h: Rename include guard.
12862         * guile/guile-internal.h: Rename include guard.
12863         * gnu-nat.h: Rename include guard.
12864         * gdb-stabs.h: Rename include guard.
12865         * frv-tdep.h: Add include guard.
12866         * f-lang.h: Add include guard.
12867         * event-loop.h: Add include guard.
12868         * darwin-nat.h: Rename include guard.
12869         * cp-abi.h: Rename include guard.
12870         * config/sparc/nm-sol2.h: Rename include guard.
12871         * config/nm-nto.h: Rename include guard.
12872         * config/nm-linux.h: Add include guard.
12873         * config/i386/nm-i386gnu.h: Rename include guard.
12874         * config/djgpp/nl_types.h: Rename include guard.
12875         * config/djgpp/langinfo.h: Rename include guard.
12876         * compile/gcc-cp-plugin.h: Add include guard.
12877         * compile/gcc-c-plugin.h: Add include guard.
12878         * compile/compile.h: Rename include guard.
12879         * compile/compile-object-run.h: Rename include guard.
12880         * compile/compile-object-load.h: Rename include guard.
12881         * compile/compile-internal.h: Rename include guard.
12882         * compile/compile-cplus.h: Rename include guard.
12883         * compile/compile-c.h: Rename include guard.
12884         * common/xml-utils.h: Rename include guard.
12885         * common/x86-xstate.h: Rename include guard.
12886         * common/version.h: Rename include guard.
12887         * common/vec.h: Rename include guard.
12888         * common/tdesc.h: Rename include guard.
12889         * common/selftest.h: Rename include guard.
12890         * common/scoped_restore.h: Rename include guard.
12891         * common/scoped_mmap.h: Rename include guard.
12892         * common/scoped_fd.h: Rename include guard.
12893         * common/safe-iterator.h: Rename include guard.
12894         * common/run-time-clock.h: Rename include guard.
12895         * common/refcounted-object.h: Rename include guard.
12896         * common/queue.h: Rename include guard.
12897         * common/ptid.h: Rename include guard.
12898         * common/print-utils.h: Rename include guard.
12899         * common/preprocessor.h: Rename include guard.
12900         * common/pathstuff.h: Rename include guard.
12901         * common/observable.h: Rename include guard.
12902         * common/netstuff.h: Rename include guard.
12903         * common/job-control.h: Rename include guard.
12904         * common/host-defs.h: Rename include guard.
12905         * common/gdb_wait.h: Rename include guard.
12906         * common/gdb_vecs.h: Rename include guard.
12907         * common/gdb_unlinker.h: Rename include guard.
12908         * common/gdb_unique_ptr.h: Rename include guard.
12909         * common/gdb_tilde_expand.h: Rename include guard.
12910         * common/gdb_sys_time.h: Rename include guard.
12911         * common/gdb_string_view.h: Rename include guard.
12912         * common/gdb_splay_tree.h: Rename include guard.
12913         * common/gdb_setjmp.h: Rename include guard.
12914         * common/gdb_ref_ptr.h: Rename include guard.
12915         * common/gdb_optional.h: Rename include guard.
12916         * common/gdb_locale.h: Rename include guard.
12917         * common/gdb_assert.h: Rename include guard.
12918         * common/filtered-iterator.h: Rename include guard.
12919         * common/filestuff.h: Rename include guard.
12920         * common/fileio.h: Rename include guard.
12921         * common/environ.h: Rename include guard.
12922         * common/common-utils.h: Rename include guard.
12923         * common/common-types.h: Rename include guard.
12924         * common/common-regcache.h: Rename include guard.
12925         * common/common-inferior.h: Rename include guard.
12926         * common/common-gdbthread.h: Rename include guard.
12927         * common/common-exceptions.h: Rename include guard.
12928         * common/common-defs.h: Rename include guard.
12929         * common/common-debug.h: Rename include guard.
12930         * common/cleanups.h: Rename include guard.
12931         * common/buffer.h: Rename include guard.
12932         * common/btrace-common.h: Rename include guard.
12933         * common/break-common.h: Rename include guard.
12934         * cli/cli-utils.h: Rename include guard.
12935         * cli/cli-style.h: Rename include guard.
12936         * cli/cli-setshow.h: Rename include guard.
12937         * cli/cli-script.h: Rename include guard.
12938         * cli/cli-interp.h: Rename include guard.
12939         * cli/cli-decode.h: Rename include guard.
12940         * cli/cli-cmds.h: Rename include guard.
12941         * charset-list.h: Add include guard.
12942         * buildsym-legacy.h: Rename include guard.
12943         * bfin-tdep.h: Add include guard.
12944         * ax.h: Rename include guard.
12945         * arm-linux-tdep.h: Add include guard.
12946         * arm-fbsd-tdep.h: Add include guard.
12947         * arch/xtensa.h: Rename include guard.
12948         * arch/tic6x.h: Add include guard.
12949         * arch/i386.h: Add include guard.
12950         * arch/arm.h: Rename include guard.
12951         * arch/arm-linux.h: Rename include guard.
12952         * arch/arm-get-next-pcs.h: Rename include guard.
12953         * arch/amd64.h: Add include guard.
12954         * arch/aarch64-insn.h: Rename include guard.
12955         * arch-utils.h: Rename include guard.
12956         * annotate.h: Add include guard.
12957         * amd64-darwin-tdep.h: Rename include guard.
12958         * aarch64-linux-tdep.h: Add include guard.
12959         * aarch64-fbsd-tdep.h: Add include guard.
12960         * aarch32-linux-nat.h: Add include guard.
12961
12962 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12963
12964         * macrotab.c (macro_define_internal): New function that
12965         factorizes macro_define_object_internal and macro_define_function
12966         code.
12967         (macro_define_object_internal): Use macro_define_internal.
12968         (macro_define_function): Likewise.
12969
12970 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12971
12972         * macrocmd.c (extract_identifier): Return
12973         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12974         callers.
12975
12976 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12977
12978         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12979
12980 2019-02-05  Tom Tromey  <tom@tromey.com>
12981
12982         * target.c (target_stack::unpush): Move assertion earlier.
12983
12984 2019-01-30  Tom Tromey  <tom@tromey.com>
12985
12986         PR python/23615:
12987         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12988         (gdbpy_parse_and_eval): Likewise.
12989         * python/python-internal.h (gdbpy_allow_threads): New class.
12990
12991 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12992
12993         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12994         (aarch64_fbsd_fpregmap): Move earlier.
12995         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12996         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12997         instead of individual calls to trad_frame_set_reg_addr.
12998         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12999         earlier.
13000         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13001         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13002         instead of individual calls to trad_frame_set_reg_addr.
13003
13004 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13005
13006         * CONTRIBUTE: Replace contribution list with wiki link.
13007
13008 2019-01-25  Tom Tromey  <tom@tromey.com>
13009
13010         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13011
13012 2019-01-25  Tom Tromey  <tom@tromey.com>
13013
13014         * xtensa-linux-nat.c: Fix common/ includes.
13015         * xml-support.h: Fix common/ includes.
13016         * xml-support.c: Fix common/ includes.
13017         * x86-linux-nat.c: Fix common/ includes.
13018         * windows-nat.c: Fix common/ includes.
13019         * varobj.h: Fix common/ includes.
13020         * varobj.c: Fix common/ includes.
13021         * value.c: Fix common/ includes.
13022         * valops.c: Fix common/ includes.
13023         * utils.c: Fix common/ includes.
13024         * unittests/xml-utils-selftests.c: Fix common/ includes.
13025         * unittests/utils-selftests.c: Fix common/ includes.
13026         * unittests/unpack-selftests.c: Fix common/ includes.
13027         * unittests/tracepoint-selftests.c: Fix common/ includes.
13028         * unittests/style-selftests.c: Fix common/ includes.
13029         * unittests/string_view-selftests.c: Fix common/ includes.
13030         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13031         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13032         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13033         * unittests/rsp-low-selftests.c: Fix common/ includes.
13034         * unittests/parse-connection-spec-selftests.c: Fix common/
13035         includes.
13036         * unittests/optional-selftests.c: Fix common/ includes.
13037         * unittests/offset-type-selftests.c: Fix common/ includes.
13038         * unittests/observable-selftests.c: Fix common/ includes.
13039         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13040         * unittests/memrange-selftests.c: Fix common/ includes.
13041         * unittests/memory-map-selftests.c: Fix common/ includes.
13042         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13043         * unittests/function-view-selftests.c: Fix common/ includes.
13044         * unittests/environ-selftests.c: Fix common/ includes.
13045         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13046         * unittests/common-utils-selftests.c: Fix common/ includes.
13047         * unittests/cli-utils-selftests.c: Fix common/ includes.
13048         * unittests/array-view-selftests.c: Fix common/ includes.
13049         * ui-file.c: Fix common/ includes.
13050         * tui/tui-io.c: Fix common/ includes.
13051         * tracepoint.h: Fix common/ includes.
13052         * tracepoint.c: Fix common/ includes.
13053         * tracefile-tfile.c: Fix common/ includes.
13054         * top.h: Fix common/ includes.
13055         * top.c: Fix common/ includes.
13056         * thread.c: Fix common/ includes.
13057         * target/waitstatus.h: Fix common/ includes.
13058         * target/waitstatus.c: Fix common/ includes.
13059         * target.h: Fix common/ includes.
13060         * target.c: Fix common/ includes.
13061         * target-memory.c: Fix common/ includes.
13062         * target-descriptions.c: Fix common/ includes.
13063         * symtab.h: Fix common/ includes.
13064         * symfile.c: Fix common/ includes.
13065         * stap-probe.c: Fix common/ includes.
13066         * spu-linux-nat.c: Fix common/ includes.
13067         * sparc-nat.c: Fix common/ includes.
13068         * source.c: Fix common/ includes.
13069         * solib.c: Fix common/ includes.
13070         * solib-target.c: Fix common/ includes.
13071         * ser-unix.c: Fix common/ includes.
13072         * ser-tcp.c: Fix common/ includes.
13073         * ser-pipe.c: Fix common/ includes.
13074         * ser-base.c: Fix common/ includes.
13075         * selftest-arch.c: Fix common/ includes.
13076         * s12z-tdep.c: Fix common/ includes.
13077         * rust-exp.y: Fix common/ includes.
13078         * rs6000-aix-tdep.c: Fix common/ includes.
13079         * riscv-tdep.c: Fix common/ includes.
13080         * remote.c: Fix common/ includes.
13081         * remote-notif.h: Fix common/ includes.
13082         * remote-fileio.h: Fix common/ includes.
13083         * remote-fileio.c: Fix common/ includes.
13084         * regcache.h: Fix common/ includes.
13085         * regcache.c: Fix common/ includes.
13086         * record-btrace.c: Fix common/ includes.
13087         * python/python.c: Fix common/ includes.
13088         * python/py-type.c: Fix common/ includes.
13089         * python/py-inferior.c: Fix common/ includes.
13090         * progspace.h: Fix common/ includes.
13091         * producer.c: Fix common/ includes.
13092         * procfs.c: Fix common/ includes.
13093         * proc-api.c: Fix common/ includes.
13094         * printcmd.c: Fix common/ includes.
13095         * ppc-linux-nat.c: Fix common/ includes.
13096         * parser-defs.h: Fix common/ includes.
13097         * osdata.c: Fix common/ includes.
13098         * obsd-nat.c: Fix common/ includes.
13099         * nat/x86-linux.c: Fix common/ includes.
13100         * nat/x86-linux-dregs.c: Fix common/ includes.
13101         * nat/x86-dregs.h: Fix common/ includes.
13102         * nat/x86-dregs.c: Fix common/ includes.
13103         * nat/ppc-linux.c: Fix common/ includes.
13104         * nat/mips-linux-watch.h: Fix common/ includes.
13105         * nat/mips-linux-watch.c: Fix common/ includes.
13106         * nat/linux-waitpid.c: Fix common/ includes.
13107         * nat/linux-ptrace.h: Fix common/ includes.
13108         * nat/linux-ptrace.c: Fix common/ includes.
13109         * nat/linux-procfs.c: Fix common/ includes.
13110         * nat/linux-personality.c: Fix common/ includes.
13111         * nat/linux-osdata.c: Fix common/ includes.
13112         * nat/linux-namespaces.c: Fix common/ includes.
13113         * nat/linux-btrace.h: Fix common/ includes.
13114         * nat/linux-btrace.c: Fix common/ includes.
13115         * nat/fork-inferior.c: Fix common/ includes.
13116         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13117         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13118         * nat/aarch64-linux.c: Fix common/ includes.
13119         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13120         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13121         * namespace.h: Fix common/ includes.
13122         * mips-linux-tdep.c: Fix common/ includes.
13123         * minsyms.c: Fix common/ includes.
13124         * mi/mi-parse.h: Fix common/ includes.
13125         * mi/mi-main.c: Fix common/ includes.
13126         * mi/mi-cmd-env.c: Fix common/ includes.
13127         * memrange.h: Fix common/ includes.
13128         * memattr.c: Fix common/ includes.
13129         * maint.h: Fix common/ includes.
13130         * maint.c: Fix common/ includes.
13131         * main.c: Fix common/ includes.
13132         * machoread.c: Fix common/ includes.
13133         * location.c: Fix common/ includes.
13134         * linux-thread-db.c: Fix common/ includes.
13135         * linux-nat.c: Fix common/ includes.
13136         * linux-fork.c: Fix common/ includes.
13137         * inline-frame.c: Fix common/ includes.
13138         * infrun.c: Fix common/ includes.
13139         * inflow.c: Fix common/ includes.
13140         * inferior.h: Fix common/ includes.
13141         * inferior.c: Fix common/ includes.
13142         * infcmd.c: Fix common/ includes.
13143         * inf-ptrace.c: Fix common/ includes.
13144         * inf-child.c: Fix common/ includes.
13145         * ia64-linux-nat.c: Fix common/ includes.
13146         * i387-tdep.c: Fix common/ includes.
13147         * i386-tdep.c: Fix common/ includes.
13148         * i386-linux-tdep.c: Fix common/ includes.
13149         * i386-linux-nat.c: Fix common/ includes.
13150         * i386-go32-tdep.c: Fix common/ includes.
13151         * i386-fbsd-tdep.c: Fix common/ includes.
13152         * i386-fbsd-nat.c: Fix common/ includes.
13153         * guile/scm-type.c: Fix common/ includes.
13154         * guile/guile.c: Fix common/ includes.
13155         * go32-nat.c: Fix common/ includes.
13156         * gnu-nat.c: Fix common/ includes.
13157         * gdbthread.h: Fix common/ includes.
13158         * gdbarch-selftests.c: Fix common/ includes.
13159         * gdb_usleep.c: Fix common/ includes.
13160         * gdb_select.h: Fix common/ includes.
13161         * gdb_bfd.c: Fix common/ includes.
13162         * gcore.c: Fix common/ includes.
13163         * fork-child.c: Fix common/ includes.
13164         * findvar.c: Fix common/ includes.
13165         * fbsd-nat.c: Fix common/ includes.
13166         * event-top.c: Fix common/ includes.
13167         * event-loop.c: Fix common/ includes.
13168         * dwarf2read.c: Fix common/ includes.
13169         * dwarf2loc.c: Fix common/ includes.
13170         * dwarf2-frame.c: Fix common/ includes.
13171         * dwarf-index-cache.c: Fix common/ includes.
13172         * dtrace-probe.c: Fix common/ includes.
13173         * disasm-selftests.c: Fix common/ includes.
13174         * defs.h: Fix common/ includes.
13175         * csky-tdep.c: Fix common/ includes.
13176         * cp-valprint.c: Fix common/ includes.
13177         * cp-support.h: Fix common/ includes.
13178         * cp-support.c: Fix common/ includes.
13179         * corelow.c: Fix common/ includes.
13180         * completer.h: Fix common/ includes.
13181         * completer.c: Fix common/ includes.
13182         * compile/compile.c: Fix common/ includes.
13183         * compile/compile-loc2c.c: Fix common/ includes.
13184         * compile/compile-cplus-types.c: Fix common/ includes.
13185         * compile/compile-cplus-symbols.c: Fix common/ includes.
13186         * command.h: Fix common/ includes.
13187         * cli/cli-dump.c: Fix common/ includes.
13188         * cli/cli-cmds.c: Fix common/ includes.
13189         * charset.c: Fix common/ includes.
13190         * build-id.c: Fix common/ includes.
13191         * btrace.h: Fix common/ includes.
13192         * btrace.c: Fix common/ includes.
13193         * breakpoint.h: Fix common/ includes.
13194         * breakpoint.c: Fix common/ includes.
13195         * ax.h:
13196         (enum agent_op): Fix common/ includes.
13197         * ax-general.c (struct aop_map): Fix common/ includes.
13198         * ax-gdb.c: Fix common/ includes.
13199         * auxv.c: Fix common/ includes.
13200         * auto-load.c: Fix common/ includes.
13201         * arm-tdep.c: Fix common/ includes.
13202         * arch/riscv.c: Fix common/ includes.
13203         * arch/ppc-linux-common.c: Fix common/ includes.
13204         * arch/i386.c: Fix common/ includes.
13205         * arch/arm.c: Fix common/ includes.
13206         * arch/arm-linux.c: Fix common/ includes.
13207         * arch/arm-get-next-pcs.c: Fix common/ includes.
13208         * arch/amd64.c: Fix common/ includes.
13209         * arch/aarch64.c: Fix common/ includes.
13210         * arch/aarch64-insn.c: Fix common/ includes.
13211         * arch-utils.c: Fix common/ includes.
13212         * amd64-windows-tdep.c: Fix common/ includes.
13213         * amd64-tdep.c: Fix common/ includes.
13214         * amd64-sol2-tdep.c: Fix common/ includes.
13215         * amd64-obsd-tdep.c: Fix common/ includes.
13216         * amd64-nbsd-tdep.c: Fix common/ includes.
13217         * amd64-linux-tdep.c: Fix common/ includes.
13218         * amd64-linux-nat.c: Fix common/ includes.
13219         * amd64-fbsd-tdep.c: Fix common/ includes.
13220         * amd64-fbsd-nat.c: Fix common/ includes.
13221         * amd64-dicos-tdep.c: Fix common/ includes.
13222         * amd64-darwin-tdep.c: Fix common/ includes.
13223         * agent.c: Fix common/ includes.
13224         * ada-lang.h: Fix common/ includes.
13225         * ada-lang.c: Fix common/ includes.
13226         * aarch64-tdep.c: Fix common/ includes.
13227
13228 2019-01-25  Tom Tromey  <tom@tromey.com>
13229
13230         * common/create-version.sh: Use common/version.h.
13231
13232 2019-01-24  Pedro Alves  <palves@redhat.com>
13233
13234         * infrun.c (signal_stop, signal_print, signal_program)
13235         (signal_catch, signal_pass): Now arrays instead of pointers.
13236         (update_signals_program_target, do_target_resume)
13237         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13238         * linux-nat.c (linux_nat_target::pass_signals)
13239         (linux_nat_target::create_inferior, linux_nat_target::attach):
13240         Adjust.
13241         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13242         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13243         * procfs.c (procfs_target::pass_signals): Adjust.
13244         * record-full.c (record_full_target::resume): Adjust.
13245         * remote.c (remote_target::pass_signals)
13246         (remote_target::program_signals): Adjust.
13247         * target-debug.h (target_debug_print_signals): Now takes a
13248         gdb::array_view as parameter.  Adjust.
13249         * target.h (target_ops) <pass_signals, program_signals>: Replace
13250         pointer and length parameters with gdb::array_view.
13251         (target_pass_signals, target_program_signals): Likewise.
13252         * target-delegates.c: Regenerate.
13253
13254 2019-01-24  Pedro Alves  <palves@redhat.com>
13255
13256         * common/forward-scope-exit.h
13257         (forward_scope_exit::forward_scope_exit): Pass arguments to
13258         m_bind_function directly, instead of creating a std::bind and
13259         copying that.
13260
13261 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13262
13263         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13264         for static members.
13265         (pass_in_v_vfp_candidate): Likewise.
13266
13267 2019-01-23  Tom Tromey  <tom@tromey.com>
13268             Pedro Alves  <palves@redhat.com>
13269
13270         * regcache.c (class regcache_invalidator): Remove.
13271         (regcache::raw_write): Use make_scope_exit.
13272
13273 2019-01-23  Tom Tromey  <tom@tromey.com>
13274
13275         * ui-out.h (class ui_out_emit_type): Update comment.
13276
13277 2019-01-23  Tom Tromey  <tom@tromey.com>
13278
13279         * infrun.c (fetch_inferior_event): Update comment.
13280
13281 2019-01-23  Tom Tromey  <tom@tromey.com>
13282             Pedro Alves  <palves@redhat.com>
13283
13284         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13285         parameter.
13286         (fetch_inferior_event): Use SCOPE_EXIT.
13287
13288
13289 2019-01-23  Tom Tromey  <tom@tromey.com>
13290             Pedro Alves  <palves@redhat.com>
13291
13292         * infrun.c (disable_thread_events): Delete.
13293         (stop_all_threads): Use SCOPE_EXIT.
13294
13295 2019-01-23  Tom Tromey  <tom@tromey.com>
13296             Pedro Alves  <palves@redhat.com>
13297
13298         * symfile.c: Include forward-scope-exit.h.
13299         (clear_symtab_users_cleanup): Replace forward declaration with
13300         a FORWARD_SCOPE_EXIT.
13301         (syms_from_objfile_1): Use the forward_scope_exit and
13302         gdb::optional instead of cleanup_function.
13303         (reread_symbols): Use the forward_scope_exit instead of
13304         cleanup_function.
13305         (clear_symtab_users_cleanup): Remove function.
13306
13307 2019-01-23  Tom Tromey  <tom@tromey.com>
13308             Pedro Alves  <palves@redhat.com>
13309
13310         * linux-nat.c: Include scope-exit.h.
13311         (cleanup_target_stop): Remove.
13312         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13313         SCOPE_EXIT.
13314
13315 2019-01-23  Tom Tromey  <tom@tromey.com>
13316             Pedro Alves  <palves@redhat.com>
13317
13318         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13319         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13320
13321 2019-01-23  Tom Tromey  <tom@tromey.com>
13322             Andrew Burgess  <andrew.burgess@embecosm.com>
13323             Pedro Alves  <palves@redhat.com>
13324
13325         * infrun.c (fetch_inferior_event): Use scope_exit.
13326         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13327         * top.c (execute_command): Use scope_exit.
13328         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13329         * utils.c (do_bpstat_clear_actions_cleanup)
13330         (make_bpstat_clear_actions_cleanup): Remove.
13331
13332 2019-01-23  Tom Tromey  <tom@tromey.com>
13333             Pedro Alves  <palves@redhat.com>
13334
13335         * infrun.c: Include "common/scope-exit.h"
13336         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13337         (wait_for_inferior): Use SCOPE_EXIT.
13338         (fetch_inferior_event): Use scope_exit.
13339
13340 2019-01-23  Tom Tromey  <tom@tromey.com>
13341             Pedro Alves  <palves@redhat.com>
13342
13343         * breakpoint.c (create_breakpoint): Remove cleanup.
13344
13345 2019-01-23  Tom Tromey  <tom@tromey.com>
13346             Andrew Burgess  <andrew.burgess@embecosm.com>
13347             Pedro Alves  <palves@redhat.com>
13348
13349 2019-01-23  Pedro Alves  <palves@redhat.com>
13350
13351         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13352
13353 2019-01-23  Pedro Alves  <palves@redhat.com>
13354             Andrew Burgess  <andrew.burgess@embecosm.com>
13355
13356         * gdbthread.h: Include "common/forward-scope-exit.h".
13357         (scoped_finish_thread_state): Redefine custom class in terms of
13358         forward_scope_exit.
13359
13360 2019-01-23  Pedro Alves  <palves@redhat.com>
13361             Andrew Burgess  <andrew.burgess@embecosm.com>
13362
13363         * common/forward-scope-exit.h: New file.
13364
13365 2019-01-23  Pedro Alves  <palves@redhat.com>
13366             Andrew Burgess  <andrew.burgess@embecosm.com>
13367             Tom Tromey  <tom@tromey.com>
13368
13369         * common/scope-exit.h: New file.
13370
13371 2019-01-23  Pedro Alves  <palves@redhat.com>
13372
13373         * common/preprocessor.h (ESC): Rename to ...
13374         (ESC_PARENS): ... this.
13375         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13376         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13377
13378 2019-01-23  Tom Tromey  <tom@tromey.com>
13379
13380         * language.h (class scoped_switch_to_sym_language_if_auto):
13381         Initialize m_lang in both cases.
13382
13383 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13384
13385         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13386         with XCNEW.
13387
13388 2019-01-22  Tom Tromey  <tom@tromey.com>
13389
13390         * corelow.c: Do not include sys/file.h.
13391
13392 2019-01-22  Tom Tromey  <tom@tromey.com>
13393
13394         * tui/tui-wingeneral.h: Include gdb_curses.h.
13395
13396 2019-01-22  Tom Tromey  <tom@tromey.com>
13397
13398         * source-cache.h (class source_cache) <get_source_lines,
13399         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13400
13401 2019-01-22  Tom Tromey  <tom@tromey.com>
13402
13403         * remote-fileio.h (struct remote_target): Declare.
13404
13405 2019-01-22  Tom Tromey  <tom@tromey.com>
13406
13407         * python/py-arch.c: Do not include py-ref.h.
13408         * python/py-bpevent.c: Do not include py-ref.h.
13409         * python/py-cmd.c: Do not include py-ref.h.
13410         * python/py-continueevent.c: Do not include py-ref.h.
13411         * python/py-event.h: Do not include py-ref.h.
13412         * python/py-evtregistry.c: Do not include py-ref.h.
13413         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13414         * python/py-frame.c: Do not include py-ref.h.
13415         * python/py-framefilter.c: Do not include py-ref.h.
13416         * python/py-function.c: Do not include py-ref.h.
13417         * python/py-infevents.c: Do not include py-ref.h.
13418         * python/py-linetable.c: Do not include py-ref.h.
13419         * python/py-objfile.c: Do not include py-ref.h.
13420         * python/py-param.c: Do not include py-ref.h.
13421         * python/py-prettyprint.c: Do not include py-ref.h.
13422         * python/py-progspace.c: Do not include py-ref.h.
13423         * python/py-symbol.c: Do not include py-ref.h.
13424         * python/py-symtab.c: Do not include py-ref.h.
13425         * python/py-type.c: Do not include py-ref.h.
13426         * python/py-unwind.c: Do not include py-ref.h.
13427         * python/py-utils.c: Do not include py-ref.h.
13428         * python/py-value.c: Do not include py-ref.h.
13429         * python/py-varobj.c: Do not include py-ref.h.
13430         * python/py-xmethods.c: Do not include py-ref.h.
13431         * python/python.c: Do not include py-ref.h.
13432         * varobj.c: Do not include py-ref.h.
13433
13434 2019-01-22  Tom Tromey  <tom@tromey.com>
13435
13436         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13437         keyword for bcache.
13438
13439 2019-01-22  Tom Tromey  <tom@tromey.com>
13440
13441         * compile/compile-cplus-types.c: Remove a comment by #include.
13442
13443 2019-01-22  Tom Tromey  <tom@tromey.com>
13444
13445         * compile/gcc-c-plugin.h: Include compile-internal.h.
13446
13447 2019-01-22  Tom Tromey  <tom@tromey.com>
13448
13449         * stabsread.c (EXTERN): Do not define.
13450         (symnum, next_symbol_text_func, processing_gcc_compilation)
13451         (within_function, global_sym_chain, global_stabs)
13452         (previous_stab_code, this_object_header_files)
13453         (n_this_object_header_files)
13454         (n_allocated_this_object_header_files): Define.
13455         * stabsread.h (EXTERN): Never define.  Use "extern".
13456
13457 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13458
13459         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13460         history_value.
13461
13462 2019-01-21  Tom Tromey  <tom@tromey.com>
13463
13464         * ui-out.c: Fix includes.
13465         * tui/tui-source.c: Fix includes.
13466         * target.c: Fix includes.
13467         * remote.c: Fix includes.
13468         * regcache.c: Fix includes.
13469         * python/py-block.c: Fix includes.
13470         * printcmd.c: Fix includes.
13471         * or1k-tdep.c: Fix includes.
13472         * mi/mi-main.c: Fix includes.
13473         * m32r-tdep.c: Fix includes.
13474         * csky-tdep.c: Fix includes.
13475         * compile/compile-cplus-types.c: Fix includes.
13476         * cli/cli-interp.c: Fix includes.
13477
13478 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13479
13480         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13481         for padding.
13482
13483 2019-01-16  Tom Tromey  <tom@tromey.com>
13484
13485         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13486         earlier.
13487         (struct objfile) <msymbols_range>: Move from top level.
13488         <msymbols>: New method.
13489         (class objfile_msymbols): Remove.
13490         * symtab.c (default_collect_symbol_completion_matches_break_on):
13491         Update.
13492         * symmisc.c (dump_msymbols): Update.
13493         * stabsread.c (scan_file_globals): Update.
13494         * objc-lang.c (info_selectors_command, info_classes_command)
13495         (find_methods): Update.
13496         * minsyms.c (find_solib_trampoline_target): Update.
13497         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13498         * coffread.c (coff_symfile_read): Update.
13499         * ada-lang.c (ada_lookup_simple_minsym)
13500         (ada_collect_symbol_completion_matches): Update.
13501
13502 2019-01-16  Tom Tromey  <tom@tromey.com>
13503
13504         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13505         type.  Remove no-argument constructor.
13506         <iterator::operator++>: Simplify.
13507         <begin>: Update.
13508         <end>: Use minimal_symbol_count.
13509
13510 2019-01-16  Tom Tromey  <tom@tromey.com>
13511
13512         * objfiles.h (struct objfile) <psymtabs>: New method.
13513         (class objfile_psymtabs): Remove.
13514         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13515         typedef.
13516         <range>: New method.
13517         (require_partial_symbols): Change return type.
13518         * psymtab.c (require_partial_symbols)
13519         (psym_expand_symtabs_matching): Update.
13520         * mdebugread.c (parse_partial_symbols): Update.
13521         * dbxread.c (dbx_end_psymtab): Update.
13522
13523 2019-01-15  Tom Tromey  <tom@tromey.com>
13524
13525         * symtab.c (lookup_objfile_from_block)
13526         (lookup_symbol_in_objfile_symtabs)
13527         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13528         (find_line_symtab, info_sources_command)
13529         (default_collect_symbol_completion_matches_break_on)
13530         (make_source_files_completion_list): Update.
13531         * symmisc.c (print_objfile_statistics, dump_objfile)
13532         (maintenance_print_symbols, maintenance_info_symtabs)
13533         (maintenance_check_symtabs, maintenance_info_line_tables):
13534         Update.
13535         * source.c (select_source_symtab)
13536         (forget_cached_source_info_for_objfile): Update.
13537         * objfiles.h (class objfile_compunits): Remove.
13538         (struct objfile) <compunits_range>: New typedef.
13539         (compunits): New method.
13540         * objfiles.c (objfile_relocate1): Update.
13541         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13542         * maint.c (count_symtabs_and_blocks): Update.
13543         * linespec.c (iterate_over_all_matching_symtabs): Update.
13544         * cp-support.c (add_symbol_overload_list_qualified): Update.
13545         * coffread.c (coff_symtab_read): Update.
13546         * ada-lang.c (add_nonlocal_symbols)
13547         (ada_collect_symbol_completion_matches)
13548         (ada_add_global_exceptions): Update.
13549
13550 2019-01-15  Tom Tromey  <tom@tromey.com>
13551
13552         * progspace.h (program_space) <objfiles_safe_range>: New
13553         typedef.
13554         <objfiles_safe>: New method.
13555         * objfiles.h (class all_objfiles_safe): Remove.
13556         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13557         * jit.c (jit_inferior_exit_hook): Update.
13558
13559 2019-01-17  Tom Tromey  <tom@tromey.com>
13560
13561         * progspace.h (program_space) <objfiles_range>: New typedef.
13562         <objfiles>: New method.
13563         <objfiles_head>: Rename from objfiles.
13564         (object_files): Update.
13565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13566         * guile/scm-pretty-print.c
13567         (ppscm_find_pretty_printer_from_objfiles): Update.
13568         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13569         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13570         Update.
13571         * python/py-progspace.c (pspy_get_objfiles): Update.
13572         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13573         Update.
13574         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13575         (objfpy_lookup_objfile_by_build_id): Update.
13576         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13577         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13578         Update.
13579         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13580         (expand_symtab_containing_pc, lookup_objfile_from_block)
13581         (lookup_static_symbol, basic_lookup_transparent_type)
13582         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13583         (find_line_symtab, info_sources_command)
13584         (default_collect_symbol_completion_matches_break_on)
13585         (make_source_files_completion_list, find_main_name): Update.
13586         * symmisc.c (print_symbol_bcache_statistics)
13587         (print_objfile_statistics, maintenance_print_symbols)
13588         (maintenance_print_msymbols, maintenance_print_objfiles)
13589         (maintenance_info_symtabs, maintenance_check_symtabs)
13590         (maintenance_expand_symtabs, maintenance_info_line_tables):
13591         Update.
13592         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13593         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13594         (map_overlay_command, unmap_overlay_command)
13595         (simple_overlay_update, expand_symtabs_matching)
13596         (map_symbol_filenames): Update.
13597         * symfile-debug.c (set_debug_symfile): Update.
13598         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13599         Update.
13600         * source.c (select_source_symtab, forget_cached_source_info):
13601         Update.
13602         * solib.c (solib_read_symbols): Update.
13603         * solib-spu.c (append_ocl_sos): Update.
13604         * psymtab.c (maintenance_print_psymbols)
13605         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13606         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13607         * printcmd.c (info_symbol_command): Update.
13608         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13609         Update.
13610         * objfiles.h (class all_objfiles): Remove.
13611         * objfiles.c (have_partial_symbols, have_full_symbols)
13612         (have_minimal_symbols, qsort_cmp, update_section_map)
13613         (shared_objfile_contains_address_p)
13614         (default_iterate_over_objfiles_in_search_order): Update.
13615         * objc-lang.c (info_selectors_command, info_classes_command)
13616         (find_methods): Update.
13617         * minsyms.c (find_solib_trampoline_target): Update.
13618         * maint.c (maintenance_info_sections)
13619         (maintenance_translate_address, count_symtabs_and_blocks):
13620         Update.
13621         * main.c (captured_main_1): Update.
13622         * linux-thread-db.c (try_thread_db_load_from_pdir)
13623         (has_libpthread): Update.
13624         * linespec.c (iterate_over_all_matching_symtabs)
13625         (search_minsyms_for_name): Update.
13626         * jit.c (jit_find_objf_with_entry_addr): Update.
13627         * hppa-tdep.c (find_unwind_entry)
13628         (hppa_lookup_stub_minimal_symbol): Update.
13629         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13630         Update.
13631         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13632         (elf_gnu_ifunc_resolve_by_got): Update.
13633         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13634         * dwarf-index-write.c (save_gdb_index_command): Update.
13635         * cp-support.c (add_symbol_overload_list_qualified): Update.
13636         * breakpoint.c (create_overlay_event_breakpoint)
13637         (create_longjmp_master_breakpoint)
13638         (create_std_terminate_master_breakpoint)
13639         (create_exception_master_breakpoint): Update.
13640         * blockframe.c (find_pc_partial_function): Update.
13641         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13642         (ada_collect_symbol_completion_matches)
13643         (ada_add_global_exceptions): Update.
13644
13645 2019-01-17  Tom Tromey  <tom@tromey.com>
13646
13647         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13648         declare VEC.
13649         (solib_target_parse_libraries): Change return type.
13650         (library_list_start_segment, library_list_start_section)
13651         (library_list_end_library, library_list_start_library); Update.
13652         (solib_target_free_library_list): Remove.
13653         (solib_target_parse_libraries): Remove cleanup.  Change return
13654         type.
13655         (solib_target_current_sos): Update.
13656
13657 2019-01-17  Tom Tromey  <tromey@bapiya>
13658
13659         * valprint.c: Replace "the the" with "the".
13660         * symtab.c: Replace "the the" with "the".
13661         * solib.c: Replace "the the" with "the".
13662         * solib-dsbt.c: Replace "the the" with "the".
13663         * linespec.c: Replace "the the" with "the".
13664         * dwarf2loc.h: Replace "the the" with "the".
13665         * amd64-windows-tdep.c: Replace "the the" with "the".
13666         * aarch64-tdep.c: Replace "the the" with "the".
13667
13668 2019-01-16  Keith Seitz  <keiths@redhat.com>
13669
13670         PR gdb/23773
13671         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13672         <builder>: Rename to ..
13673         <m_builder>: ... this and make private.
13674         (dwarf2_cu::get_builder): New method.  Change all users of
13675         `builder' to use this method.
13676         (dwarf2_start_symtab): Move to ...
13677         (dwarf2_cu::start_symtab): ... here.  Update all callers
13678         (setup_type_unit_groups): Move to ...
13679         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13680         callers.
13681         (dwarf2_cu::reset_builder): New method.
13682         (process_full_compunit, process_full_type_unit): Use
13683         dwarf2_cu::reset_builder.
13684         (follow_die_offset): Record the ancestor CU if it is different
13685         from the followed DIE's CU.
13686         (follow_die_sig_1): Likewise.
13687
13688 2019-01-15  Tom Tromey  <tom@tromey.com>
13689
13690         * remote.c (class remote_state) <buf>: Now a char_vector.
13691         <buf_size>: Remove.
13692         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13693         parameter.
13694         (remote_target::getpkt_or_notif_sane_1)
13695         (remote_target::getpkt_sane)
13696         (remote_target::getpkt_or_notif_sane): Likewise.
13697         (class remote_target) <putpkt>: New overload.
13698         (remote_target::read_frame): Change type of "buf_p".  Remove
13699         sizeof_p parameter.
13700         (packet_ok): New overload.
13701         (packet_check_result): New overload.
13702         Update all uses.
13703
13704 2019-01-14  Tom Tromey  <tom@tromey.com>
13705
13706         * remote-notif.c (handle_notification, remote_notif_ack)
13707         (remote_notif_parse): Make "buf" const.
13708         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13709         const.
13710         (remote_notif_parse, remote_notif_ack, handle_notification):
13711         Likewise.
13712         * remote.c (remote_notif_stop_parse): Make "buf" const.
13713         (remote_target::remote_parse_stop_reply): Make "buf" const.
13714         (remote_notif_stop_ack): Make "buf" const.
13715
13716 2019-01-14  Tom Tromey  <tom@tromey.com>
13717
13718         * remote.c (remote_console_output): Make parameter const.
13719
13720 2019-01-14  Tom Tromey  <tom@tromey.com>
13721
13722         * target-debug.h (target_debug_print_signals): Constify.
13723         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13724         * procfs.c (procfs_target::pass_signals): Update.
13725         * linux-nat.c (linux_nat_target::pass_signals): Update.
13726         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13727         * target-delegates.c: Rebuild.
13728         * remote.c (remote_target::program_signals): Update.
13729         (remote_target::pass_signals): Update.
13730         * target.c (target_pass_signals): Constify argument.
13731         (target_program_signals): Likewise.
13732         * target.h (struct target_ops) <pass_signals, program_signals>:
13733         Constify argument.
13734         (target_pass_signals, target_program_signals): Constify argument.
13735
13736 2019-01-14  Tom Tromey  <tom@tromey.com>
13737
13738         PR tui/28819:
13739         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13740
13741 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13742
13743         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13744         field.
13745         * rs6000-tdep.c: Include reggroups.h.
13746         (IS_V_ALIAS_PSEUDOREG): Define.
13747         (rs6000_register_name): Return names for the "vX" aliases.
13748         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13749         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13750         aliases.  Call default_register_reggroup_p for all other
13751         pseudo-registers.
13752         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13753         New functions.
13754         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13755         Handle "vX" aliases.
13756         (v_alias_pseudo_register_collect): New function.
13757         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13758         (rs6000_gdbarch_init): Initialize "vX" aliases as
13759         pseudo-registers.  Restore registration of
13760         rs6000_pseudo_register_reggroup_p with
13761         set_tdesc_pseudo_register_reggroup_p.
13762
13763 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13764
13765         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13766         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13767         set_gdbarch_num_pseudo_regs.
13768
13769 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13770
13771         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13772         Remove arg prefixname, add do_set and do_show.
13773         Add member functions set_list and show_list.
13774         * cli/cli-style.c (class cli_style_option): Update accordingly.
13775         (style_set_list): Move to file scope.
13776         (style_show_list): Likewise.
13777         (set_style): Call help_list.
13778         (show_style): Call cmd_show_list.
13779         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13780         Update to use the new macro.
13781
13782 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13783
13784         * ada-lang.c (_initialize_ada_language): Expand the help text
13785         for the "catch exception" command.
13786
13787 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13788
13789         * symtab.c (matching_obj_sections): Initialize obj,
13790         declare it closer to its usage.
13791
13792 2019-01-10  Tom Tromey  <tom@tromey.com>
13793
13794         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13795         (basic_inf_threads_range): Remove.
13796         (inf_threads_range, inf_non_exited_threads_range)
13797         (safe_inf_threads_range): Use next_adapter.
13798
13799 2019-01-10  Keith Seitz  <keiths@redhat.com>
13800
13801         PR gdb/23712
13802         PR symtab/23010
13803         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13804         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13805
13806 2019-01-10  Keith Seitz  <keiths@redhat.com>
13807
13808         PR gdb/23712
13809         PR symtab/23010
13810         * dictionary.c (pending_to_vector): Remove.
13811         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13812         Remove _1 suffix, replacing functions of the same name.  Update
13813         all callers.
13814         (dict_create_hashed, dict_create_hashed_expandable)
13815         (dict_create_linear, dict_create_linear_expandable, dict_free)
13816         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13817         Make functions static.
13818
13819 2019-01-10  Keith Seitz  <keiths@redhat.com>
13820
13821         PR gdb/23712
13822         PR symtab/23010
13823         * dictionary.h (struct dictionary): Replace declaration with
13824         multidictionary.
13825         (dict_create_hashed, dict_create_hashed_expandable)
13826         (dict_create_linear, dict_create_linear_expandable)
13827         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13828         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13829         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13830         taking multidictionary argument.
13831         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13832         * block.h (struct block) <dict>: Change to multidictionary
13833         and rename `multidict'.
13834         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13835         symmisc.c: Update all dictionary references to multidictionary.
13836
13837 2019-01-10  Keith Seitz  <keiths@redhat.com>
13838
13839         PR gdb/23712
13840         PR symtab/23010
13841         * dictionary.c: Include unordered_map.
13842         (pending_to_vector): New function.
13843         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13844         Rewrite the non-"_1" functions to take vector instead
13845         of linked list.
13846         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13847         "new" _1 versions of the same name.
13848         (multidictionary): Define.
13849         (std::hash<enum language): New definition.
13850         (collate_pending_symbols_by_language, mdict_create_hashed)
13851         (mdict_create_hashed_expandable, mdict_create_linear)
13852         (mdict_create_linear_expandable, mdict_free)
13853         (find_language_dictionary, create_new_language_dictionary)
13854         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13855         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13856         (mdict_size, mdict_empty): New functions.
13857         * dictionary.h (mdict_iterator): Define.
13858
13859 2019-01-10  Pedro Alves  <palves@redhat.com>
13860
13861         * breakpoint.c (read_uploaded_action)
13862         (create_tracepoint_from_upload): Adjust to use
13863         gdb::unique_xmalloc_ptr.
13864         * ctf.c (ctf_write_uploaded_tp):
13865         (SET_ARRAY_FIELD): Use emplace_back.
13866         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13867         * tracefile-tfile.c (tfile_write_uploaded_tp):
13868         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13869         gdb::unique_xmalloc_ptr.
13870         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13871         at_string, cond_string, cmd_strings>: Replace char pointers
13872         with gdb::unique_xmalloc_ptr.
13873
13874 2019-01-10  Pedro Alves  <palves@redhat.com>
13875
13876         * solib-target.c (library_list_start_library): Don't xstrdup name.
13877
13878 2019-01-10  Pedro Alves  <palves@redhat.com>
13879
13880         * mdebugread.c (parse_partial_symbols): Use
13881         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13882
13883 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13884
13885         * linux-fork.c (scoped_switch_fork_info)
13886         <~scoped_switch_fork_info>: Fix incorrect variable name.
13887
13888 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13889
13890         * linux-fork.c (scoped_switch_fork_info)
13891         <scoped_switch_fork_info>: Make explicit.
13892         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13893
13894 2019-01-10  Tom Tromey  <tom@tromey.com>
13895
13896         * objfiles.h (objfile::reset_psymtabs): Update.
13897         * objfiles.c (objfile::objfile): Update.
13898         * psymtab.h (psymtab_storage::obstack): Update.
13899         (psymtab_storage::m_obstack): Use gdb::optional.
13900         (class psymtab_storage): Update comment.  Remove objfile
13901         parameter.
13902         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13903
13904 2019-01-10  Tom Tromey  <tom@tromey.com>
13905
13906         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13907         <free_psymtabs>: Now private.
13908         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13909         (allocate_psymtab): Use new method.
13910
13911 2019-01-10  Tom Tromey  <tom@tromey.com>
13912
13913         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13914         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13915         * mdebugread.c (parse_partial_symbols): Use
13916         allocate_dependencies.
13917         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13918         allocate_dependencies.
13919         (process_psymtab_comp_unit_reader)
13920         (build_type_psymtab_dependencies): Likewise.
13921         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13922
13923 2019-01-10  Tom Tromey  <tom@tromey.com>
13924
13925         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13926         PSYMBOL_SET_LANGUAGE.
13927         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13928
13929 2019-01-10  Tom Tromey  <tom@tromey.com>
13930
13931         * psymtab.h (psymtab_storage::obstack): New method.
13932         <m_obstack>: Rename from obstack; now private.
13933         * psymtab.c (psymtab_storage): Update.
13934         * dwarf2read.c (create_addrmap_from_index)
13935         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13936         Update.
13937
13938 2019-01-10  Tom Tromey  <tom@tromey.com>
13939
13940         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13941         * objfiles.h (objfile::reset_psymtabs): New method.
13942
13943 2019-01-10  Tom Tromey  <tom@tromey.com>
13944
13945         * symmisc.c (print_symbol_bcache_statistics): Update.
13946         (print_objfile_statistics): Update.
13947         * symfile.c (reread_symbols): Update.
13948         * psymtab.h (class psymtab_storage): New.
13949         * psymtab.c (psymtab_storage): New constructor.
13950         (~psymtab_storage): New destructor.
13951         (require_partial_symbols): Update.
13952         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13953         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13954         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13955         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13956         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13957         (start_psymtab_common, end_psymtab_common)
13958         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13959         (allocate_psymtab): Update.
13960         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13961         Update.
13962         (dump_psymtab_addrmap, maintenance_print_psymbols)
13963         (maintenance_check_psymtabs): Update.
13964         (class objfile_psymtabs): Move to objfiles.h.
13965         * psympriv.h (discard_psymtab): Now inline.
13966         (psymtab_discarder::psymtab_discarder): Update.
13967         (psymtab_discarder::~psymtab_discarder): Update.
13968         (ALL_OBJFILE_PSYMTABS): Rewrite.
13969         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13970         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13971         Remove fields.
13972         <partial_symtabs>: New field.
13973         (class objfile_psymtabs): Move from psymtab.h.  Update.
13974         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13975         psymbol_cache.
13976         (objfile::~objfile): Don't destroy psymbol_cache.
13977         * mdebugread.c (parse_partial_symbols): Update.
13978         * dwarf2read.c (create_addrmap_from_index)
13979         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13980         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13981         (add_partial_subprogram, dwarf2_ranges_read): Update.
13982         * dwarf-index-write.c (write_address_map)
13983         (write_one_signatured_type, recursively_write_psymbols)
13984         (class debug_names, class debug_names, write_psymtabs_to_index):
13985         Update.
13986
13987 2019-01-10  Tom Tromey  <tom@tromey.com>
13988
13989         * symtab.h (SYMBOL_SET_NAMES): Update.
13990         (symbol_set_names): Update.
13991         (MSYMBOL_SET_NAMES): Update.
13992         * symtab.c (symbol_set_names): Change argument to be an
13993         objfile_per_bfd_storage.
13994         * psymtab.c (add_psymbol_to_bcache): Update.
13995         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13996
13997 2019-01-10  Tom Tromey  <tom@tromey.com>
13998
13999         * symtab.c (create_demangled_names_hash): Change argument to be an
14000         objfile_per_bfd_storage.
14001         (symbol_set_names): Update.
14002
14003 2019-01-10  Tom Tromey  <tom@tromey.com>
14004
14005         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14006         init_psymbol_list.
14007         * psymtab.c (init_psymbol_list): Do nothing if already called.
14008         * psympriv.h (init_psymbol_list): Add comment.
14009         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14010         init_psymbol_list.
14011         * dbxread.c (dbx_symfile_read): Unconditionally call
14012         init_psymbol_list.
14013
14014 2019-01-10  Tom Tromey  <tom@tromey.com>
14015
14016         * xcoffread.c (scan_xcoff_symtab): Update.
14017         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14018         "where".
14019         * mdebugread.c (parse_partial_symbols)
14020         (handle_psymbol_enumerators): Update.
14021         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14022         * dbxread.c (read_dbx_symtab): Update.
14023         * psympriv.h (psymbol_placement): New enum.
14024         (add_psymbol_to_list): Update.
14025
14026 2019-01-10  Tom Tromey  <tom@tromey.com>
14027
14028         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14029         static_psymbols parameters.
14030         (scan_xcoff_symtab): Update.
14031         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14032         static_psymbols parameters.
14033         * psympriv.h (start_psymtab_common): Update.
14034         * mdebugread.c (parse_partial_symbols): Update.
14035         * dwarf2read.c (create_partial_symtab): Update.
14036         * dbxread.c (read_dbx_symtab): Update.
14037         (start_psymtab): Remove global_psymbols and static_psymbols
14038         parameters.
14039
14040 2019-01-10  Tom Tromey  <tom@tromey.com>
14041
14042         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14043         * psymtab.c (allocate_psymtab): Add comment.
14044         * psympriv.h (allocate_psymtab): Add comment.
14045         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14046         initializations.
14047         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14048
14049 2019-01-10  Tom Tromey  <tom@tromey.com>
14050
14051         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14052         Don't declare.
14053         * mipsread.c: Include mdebugread.h.
14054         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14055         Declare.
14056         * elfread.c: Include mdebugread.h.
14057
14058 2019-01-09  Tom Tromey  <tom@tromey.com>
14059
14060         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14061         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14062         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14063         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14064         (psym_lookup_symbol, psym_find_last_source_symtab)
14065         (psym_forget_cached_source_info, psym_print_stats)
14066         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14067         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14068         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14069         (psym_find_compunit_symtab_by_address)
14070         (maintenance_print_psymbols, maintenance_info_psymtabs)
14071         (maintenance_check_psymtabs): Use ranged for.
14072         * psymtab.h (class objfile_psymtabs): New.
14073         (require_partial_symbols): Return objfile_psymtabs.
14074         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14075
14076 2019-01-09  Tom Tromey  <tom@tromey.com>
14077
14078         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14079         (find_pc_mapped_section, list_overlays_command)
14080         (map_overlay_command, unmap_overlay_command)
14081         (simple_overlay_update): Use all_objfiles.
14082         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14083         * printcmd.c (info_symbol_command): Use all_objfiles.
14084         * objfiles.h (ALL_OBJSECTIONS): Remove.
14085         * maint.c (maintenance_translate_address): Use all_objfiles.
14086         * gcore.c (gcore_create_callback): Use all_objfiles.
14087         (objfile_find_memory_regions): Likewise.
14088
14089 2019-01-09  Tom Tromey  <tom@tromey.com>
14090
14091         * symtab.c (find_line_symtab, info_sources_command)
14092         (make_source_files_completion_list): Use objfile_compunits.
14093         * source.c (select_source_symtab): Use objfile_compunits.
14094         * objfiles.h (struct objfile): Update comment.
14095         (ALL_OBJFILES): Remove.
14096         (ALL_FILETABS): Remove.
14097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14098         objfile_compunits.
14099
14100 2019-01-09  Tom Tromey  <tom@tromey.com>
14101
14102         * symmisc.c (print_objfile_statistics, dump_objfile)
14103         (maintenance_print_symbols): Use compunit_filetabs.
14104         * source.c (forget_cached_source_info_for_objfile): Use
14105         compunit_filetabs.
14106         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14107         (ALL_FILETABS): Use compunit_filetabs.
14108         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14109         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14110
14111 2019-01-09  Tom Tromey  <tom@tromey.com>
14112
14113         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14114         (compunit_filetabs): New.
14115         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14116         compunit_filetabs.
14117         (info_sources_command, make_source_files_completion_list): Remove
14118         declaration.
14119         * symmisc.c (print_objfile_statistics, dump_objfile)
14120         (maintenance_print_symbols): Remove declaration.
14121         (maintenance_info_symtabs): Use compunit_filetabs.
14122         (maintenance_info_line_tables): Likewise.
14123         * source.c (select_source_symtab): Change local variable name.
14124         (forget_cached_source_info_for_objfile): Remove declaration.
14125         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14126         * objfiles.c (objfile_relocate1): Remove declaration.
14127         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14128         declaration.
14129         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14130         * coffread.c (coff_symtab_read): Remove declaration.
14131         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14132         compunit_filetabs.
14133
14134 2019-01-09  Tom Tromey  <tom@tromey.com>
14135
14136         * symtab.c (lookup_objfile_from_block)
14137         (find_pc_sect_compunit_symtab, search_symbols)
14138         (default_collect_symbol_completion_matches_break_on): Use
14139         objfile_compunits.
14140         * objfiles.h (ALL_COMPUNITS): Remove.
14141         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14142         * cp-support.c (add_symbol_overload_list_qualified): Use
14143         objfile_compunits.
14144         * ada-lang.c (ada_collect_symbol_completion_matches)
14145         (ada_add_global_exceptions): Use objfile_compunits.
14146
14147 2019-01-09  Tom Tromey  <tom@tromey.com>
14148
14149         * source.c (select_source_symtab)
14150         (forget_cached_source_info_for_objfile): Remove declaration.
14151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14152         declaration.
14153         * maint.c (count_symtabs_and_blocks): Remove declaration.
14154         * cp-support.c (add_symbol_overload_list_qualified): Remove
14155         declaration.
14156         * coffread.c (coff_symtab_read): Remove declaration.
14157         * symtab.c (lookup_symbol_in_objfile_symtabs)
14158         (basic_lookup_transparent_type_1): Use objfile_compunits.
14159         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14160         (info_sources_command, search_symbols)
14161         (default_collect_symbol_completion_matches_break_on)
14162         (make_source_files_completion_list): Remove declaration.
14163         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14164         (ada_collect_symbol_completion_matches)
14165         (ada_add_global_exceptions): Remove declaration.
14166         * linespec.c (iterate_over_all_matching_symtabs): Use
14167         objfile_compunits.
14168         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14169         (class objfile_compunits): New.
14170         (ALL_COMPUNITS): Use objfile_compunits.
14171         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14172         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14173         objfile_compunits.
14174         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14175
14176 2019-01-09  Tom Tromey  <tom@tromey.com>
14177
14178         * symtab.c (search_symbols)
14179         (default_collect_symbol_completion_matches_break_on): Use
14180         objfile_msymbols.
14181         * ada-lang.c (ada_lookup_simple_minsym)
14182         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14183         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14184         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14185         objfile_msymbols.
14186         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14187         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14188         * objc-lang.c (find_methods): Use objfile_msymbols.
14189         (info_selectors_command, info_classes_command): Likewise.
14190         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14191         * objfiles.h (class objfile_msymbols): New.
14192         (ALL_OBJFILE_MSYMBOLS): Remove.
14193         (ALL_MSYMBOLS): Remove.
14194
14195 2019-01-09  Tom Tromey  <tom@tromey.com>
14196
14197         * common/next-iterator.h (next_adapter): Add Iterator template
14198         parameter.
14199         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14200         (class all_objfiles_safe): New.
14201         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14202         * objfiles.c (put_objfile_before): Update comment.
14203         (add_separate_debug_objfile): Likewise.
14204         (free_all_objfiles): Use all_objfiles_safe.
14205         (objfile_purge_solibs): Likewise.
14206
14207 2019-01-09  Tom Tromey  <tom@tromey.com>
14208
14209         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14210         (expand_symtab_containing_pc, lookup_static_symbol)
14211         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14212         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14213         all_objfiles.
14214         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14215         * breakpoint.c (create_overlay_event_breakpoint)
14216         (create_longjmp_master_breakpoint)
14217         (create_std_terminate_master_breakpoint)
14218         (create_exception_master_breakpoint): Use all_objfiles.
14219         * linux-thread-db.c (try_thread_db_load_from_pdir)
14220         (has_libpthread): Use all_objfiles.
14221         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14222         * linespec.c (iterate_over_all_matching_symtabs)
14223         (search_minsyms_for_name): Use all_objfiles.
14224         * maint.c (maintenance_info_sections): Use all_objfiles.
14225         * main.c (captured_main_1): Use all_objfiles.
14226         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14227         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14228         * guile/scm-pretty-print.c
14229         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14230         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14231         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14232         (maintenance_print_msymbols): Use all_objfiles.
14233         * source.c (select_source_symtab): Use all_objfiles.
14234         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14235         * symfile.c (remove_symbol_file_command)
14236         (expand_symtabs_matching, map_symbol_filenames): Use
14237         all_objfiles.
14238         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14239         all_objfiles.
14240         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14241         * objc-lang.c (find_methods): Use all_objfiles.
14242         * objfiles.c (have_partial_symbols, have_full_symbols)
14243         (have_minimal_symbols, qsort_cmp)
14244         (default_iterate_over_objfiles_in_search_order): Use
14245         all_objfiles.
14246         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14247         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14248         (maintenance_check_psymtabs): Use all_objfiles.
14249         (ALL_PSYMTABS): Remove.
14250         * compile/compile-object-run.c (do_module_cleanup): Use
14251         all_objfiles.
14252         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14253         * cp-support.c (add_symbol_overload_list_qualified): Use
14254         all_objfiles.
14255         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14256         Use all_objfiles.
14257         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14258         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14259         all_objfiles.
14260         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14261         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14262         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14263         Uses all_objfiles.
14264         * solib.c (solib_read_symbols): Use all_objfiles
14265
14266 2019-01-09  Tom Tromey  <tom@tromey.com>
14267
14268         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14269         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14270         all_objfiles.
14271         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14272         * symmisc.c (print_symbol_bcache_statistics)
14273         (print_objfile_statistics, maintenance_print_objfiles)
14274         (maintenance_info_symtabs, maintenance_check_symtabs)
14275         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14276         all_objfiles.
14277         * source.c (forget_cached_source_info): Use all_objfiles.
14278         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14279         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14280         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14281         * objfiles.c (update_section_map): Use all_objfiles.
14282         (shared_objfile_contains_address_p): Likewise.
14283         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14284         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14285
14286 2019-01-09  Tom Tromey  <tom@tromey.com>
14287
14288         * common/next-iterator.h: New file.
14289         * objfiles.h (class all_objfiles): New.
14290         (struct objfile_iterator): New.
14291
14292 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14293
14294         * NEWS: Move the description of the changed "frame", "select-frame",
14295          and "info frame" commands to the Changed commands section.
14296
14297 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14298
14299         * gdbtypes.c (check_stub_method_group): Remove handling of old
14300         mangling schemes.
14301         * linespec.c (find_methods): Likewise.
14302         * stabsread.c (read_member_functions): Likewise.
14303         * valops.c (search_struct_method): Likewise.
14304         (value_struct_elt_for_reference): Likewise.
14305         * NEWS: Mention this change.
14306
14307 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14308
14309         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14310         print_source_lines.
14311         * source.c (print_source_lines_base): Update line number check.
14312         (print_source_lines): New function.
14313         (source_lines_range::source_lines_range): New function.
14314         * source.h (class source_lines_range): New class.
14315         (print_source_lines): New declaration.
14316
14317 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14318
14319         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14320
14321 2019-01-08  Tom Tromey  <tom@tromey.com>
14322             Simon Marchi  <simon.marchi@ericsson.com>
14323
14324         PR gdb/24060
14325         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14326         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14327         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14328         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14329         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14330         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14331
14332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14333
14334         * source.c (select_source_symtab): Move header comment to
14335         declaration in source.h.
14336         (forget_cached_source_info_for_objfile): Likewise.
14337         (forget_cached_source_info): Likewise.
14338         (identify_source_line): Likewise.
14339         * source.h (identify_source_line): Move declaration from symtab.h
14340         and add comment from source.c
14341         (print_source_lines): Likewise.
14342         (forget_cached_source_info_for_objfile): Likewise.
14343         (forget_cached_source_info): Likewise.
14344         (select_source_symtab): Likewise.
14345         (enum print_source_lines_flag): Move definition from symtab.h.
14346         * symtab.h (identify_source_line): Move declaration to source.h.
14347         (print_source_lines): Likewise.
14348         (forget_cached_source_info_for_objfile): Likewise.
14349         (forget_cached_source_info): Likewise.
14350         (select_source_symtab): Likewise.
14351         (enum print_source_lines_flag): Move definition to source.h.
14352         * tui/tui-hooks.c: Add 'source.h' include.
14353
14354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14355
14356         * source.c (print_source_lines_base): Handle requests to print
14357         reverse line number sequences, and guard against empty lines
14358         string.
14359
14360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14361
14362         * source.c (print_source_lines_base): Fix skip of '\r' if next
14363         character is '\n'.
14364
14365 2019-01-06  Tom Tromey  <tom@tromey.com>
14366
14367         * c-exp.y (struct c_parse_state) <macro_original_text,
14368         expansion_obstack>: New member.
14369         (macro_original_text, expansion_obstack): Remove globals.
14370         (scan_macro_expansion, scanning_macro_expansion)
14371         (finished_macro_expansion): Update.
14372         (scan_macro_cleanup): Remove.
14373         (yylex, c_parse): Update.
14374
14375 2019-01-06  Tom Tromey  <tom@tromey.com>
14376
14377         * c-exp.y (struct c_parse_state) <strings>: New member.
14378         (operator_stoken): Update.
14379
14380 2019-01-06  Tom Tromey  <tom@tromey.com>
14381
14382         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14383         (union type_stack_elt) <typelist_val>: Now a pointer to
14384         std::vector.
14385         (type_stack_cleanup): Don't declare.
14386         (push_typelist): Update.
14387         * parse.c (pop_typelist): Return a std::vector.
14388         (push_typelist): Take a std::vector.
14389         (follow_types): Update.  Do not free args.
14390         (type_stack_cleanup): Remove.
14391         * c-exp.y (struct c_parse_state): New.
14392         (cpstate): New global.
14393         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14394         (nonempty_typelist): Update.
14395         (func_mod): Create a new vector.
14396         (c_parse): Create a c_parse_state.
14397         (check_parameter_typelist): Do not delete params.
14398         (function_method): Update.  Do not delete type_list.
14399
14400 2019-01-06  Tom Tromey  <tom@tromey.com>
14401
14402         PR gdb/28155:
14403         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14404         check_typedef.
14405         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14406         (print_return_value): Likewise.
14407
14408 2019-01-05  Tom Tromey  <tom@tromey.com>
14409
14410         * contrib/cleanup_check.py: Remove.
14411         * contrib/gcc-with-excheck: Remove.
14412         * contrib/exsummary.py: Remove.
14413         * contrib/excheck.py: Remove.
14414
14415 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14416
14417         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14418         NULL. Initialize tpprev to NULL instead of assigning it
14419         to NULL on the next statement.
14420         * windows-nat.c (windows_delete_thread): Remove check for
14421         main_thread_id before printing thread exit notifications.
14422         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14423         Remove thread ID check against main_thread_id.
14424         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14425         windows_delete_thread.
14426         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14427
14428 2019-01-04  Tom Tromey  <tom@tromey.com>
14429
14430         * compile/compile.c (_initialize_compile): Use upper case for
14431         metasyntactic variables.
14432         * symmisc.c (_initialize_symmisc): Use upper case for
14433         metasyntactic variables.
14434         * psymtab.c (_initialize_psymtab): Use upper case for
14435         metasyntactic variables.
14436         * demangle.c (demangle_command): Use upper case for metasyntactic
14437         variables.
14438         (_initialize_demangler): Likewise.
14439         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14440         variables.
14441
14442 2019-01-03  Tom Tromey  <tom@tromey.com>
14443
14444         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14445
14446 2019-01-03  Tom Tromey  <tom@tromey.com>
14447
14448         * python/py-symtab.c (salpy_str): Update.
14449         (struct salpy_sal_object) <symtab>: Now a PyObject.
14450         (salpy_dealloc): Update.
14451         (del_objfile_sal): Use gdbpy_ref.
14452
14453 2019-01-03  Tom Tromey  <tom@tromey.com>
14454
14455         * python/py-type.c (convert_field): Use new_reference.  Return
14456         gdbpy_ref.
14457         (make_fielditem): Return gdbpy_ref.
14458         (typy_fields): Update.
14459         (typy_getitem): Update.
14460         (field_name): Return gdbpy_ref.  Use new_reference.
14461         (typy_iterator_iternext): Update.
14462
14463 2019-01-03  Tom Tromey  <tom@tromey.com>
14464
14465         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14466
14467 2019-01-03  Tom Tromey  <tom@tromey.com>
14468
14469         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14470         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14471         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14472         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14473         (pspy_set_type_printers): Likewise.
14474         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14475         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14476         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14477         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14478         (objfpy_set_type_printers): Likewise.
14479
14480 2019-01-03  Tom Tromey  <tom@tromey.com>
14481
14482         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14483         (gdbpy_print_stack): Use gdbpy_err_fetch.
14484         * python/python-internal.h (class gdbpy_err_fetch): New class.
14485         (class gdbpy_enter) <m_error_type, m_error_value,
14486         m_error_traceback>: Remove.
14487         <m_error>: New member.
14488         (gdbpy_exception_to_string): Don't declare.
14489         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14490         * python/py-value.c (convert_value_from_python): Use
14491         gdbpy_err_fetch.
14492         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14493         gdbpy_exception_to_string.
14494         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14495         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14496         gdbpy_err_fetch.
14497
14498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14499
14500         * linux-nat.c (delete_lwp_cleanup): Delete.
14501         (struct lwp_deleter): New struct.
14502         (lwp_info_up): New typedef.
14503         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14504         lwp_info_up.
14505
14506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14507
14508         * linux-fork.c (class scoped_switch_fork_info): New class.
14509         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14510
14511 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14512
14513         * valops.c (find_overload_match): Remove use of null_cleanup, and
14514         calls to do_cleanups.
14515
14516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14517
14518         * compile/compile-cplus-types.c
14519         (compile_cplus_instance::decl_name): Handle changes to
14520         cp_func_name.
14521         * cp-support.c (cp_func_name): Update header comment, update
14522         return type.
14523         * cp-support.h (cp_func_name): Update return type in declaration.
14524         * valops.c (find_overload_match): Move temp_func local to top
14525         level of function and change its type.  Use temp_func to hold and
14526         delete temporary string obtained from cp_func_name.
14527
14528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14529
14530         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14531         gdb::char_vector, remove cleanup, and update uses of `msg`.
14532
14533 2019-01-03  Jim Wilson  <jimw@sifive.com>
14534
14535         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14536
14537 2019-01-02  Tom Tromey  <tom@tromey.com>
14538
14539         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14540         (tdesc_parse_xml): Remove cleanups.
14541         * target-descriptions.h (make_cleanup_free_target_description):
14542         Don't declare.
14543         (target_desc_deleter): New struct.
14544         (target_desc_up): New typedef.
14545         * target-descriptions.c (target_desc_deleter::operator()): Rename
14546         from free_target_description.
14547         (make_cleanup_free_target_description): Remove.
14548
14549 2019-01-02  Tom Tromey  <tom@tromey.com>
14550
14551         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14552         constructor, destructor.
14553         (linespec_parser): Remove typedef.
14554         (~linespec_parser): Rename from linespec_parser_delete.
14555         (linespec_lex_to_end, linespec_complete_label)
14556         (linespec_complete): Update.
14557         (decode_line_full): Remove cleanups.
14558         (decode_line_1): Update.
14559
14560 2019-01-02  Tom Tromey  <tom@tromey.com>
14561
14562         * python/python-internal.h (inferior_to_inferior_object): Change
14563         return type.
14564         * python/py-exitedevent.c (create_exited_event_object): Update.
14565         * python/py-inferior.c (inferior_to_inferior_object): Return
14566         gdbpy_ref.
14567         (python_new_inferior, python_inferior_deleted)
14568         (thread_to_thread_object, delete_thread_object)
14569         (build_inferior_list, gdbpy_selected_inferior): Update.
14570         * python/py-infthread.c (create_thread_object): Update.  Also fail
14571         if inferior_to_inferior_object fails.
14572
14573 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14574
14575         * inferior.h (class inferior) <displaced_step_state>: New field.
14576         * infrun.h (struct displaced_step_state): Move here from
14577         infrun.c.  Initialize fields, add constructor.
14578         <inf>: Remove field.
14579         <reset>: New method.
14580         * infrun.c (struct displaced_step_inferior_state): Move to
14581         infrun.h.
14582         (displaced_step_inferior_states): Remove.
14583         (get_displaced_stepping_state): Adust.
14584         (displaced_step_in_progress_any_inferior): Adjust.
14585         (displaced_step_in_progress_thread): Adjust.
14586         (displaced_step_in_progress): Adjust.
14587         (add_displaced_stepping_state): Remove.
14588         (get_displaced_step_closure_by_addr): Adjust.
14589         (remove_displaced_stepping_state): Remove.
14590         (infrun_inferior_exit): Call displaced_step_state.reset.
14591         (use_displaced_stepping): Don't check for NULL.
14592         (displaced_step_prepare_throw): Call
14593         get_displaced_stepping_state.
14594         (displaced_step_fixup): Don't check for NULL.
14595         (prepare_for_detach): Don't check for NULL.
14596
14597 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14598
14599         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14600          in case of call that did not complete.
14601
14602 2019-01-02  Andrey Utkin  <autkin@undo.io>
14603
14604         * symfile.c (find_separate_debug_file): Fix search of debug files for
14605         remote debuggee.
14606
14607 2019-01-02  Tom Tromey  <tom@tromey.com>
14608
14609         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14610         indentation.
14611         * python/py-frame.c (frapy_older): Remove cast.
14612         (frapy_newer): Likewise.
14613         * python/py-breakpoint.c (local_setattro): Remove cast.
14614         * python/py-arch.c (archpy_name): Remove local variable.
14615         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14616
14617 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14618
14619         * unittests/basic_string_view/element_access/char/empty.cc:
14620         Fix year range in copyright header.
14621
14622 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14623
14624         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14625         Delete.
14626         <operator==>: Update with for removed field.
14627         <hash>: Likewise.
14628         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14629         <isa_features>: ...this.
14630         <abi_features>: New field.
14631         (riscv_isa_flen): Update comment.
14632         (riscv_abi_xlen): New declaration.
14633         (riscv_abi_flen): New declaration.
14634         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14635         isa_features.
14636         (riscv_abi_xlen): New function.
14637         (riscv_isa_flen): Update to get answer from isa_features.
14638         (riscv_abi_flen): New function.
14639         (riscv_has_fp_abi): Update to get answer from abi_features.
14640         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14641         xlen and flen.
14642         (riscv_call_info) <xlen, flen>: Update comment.
14643         (riscv_call_arg_struct): Remove invalid assertions
14644         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14645         is removed.
14646         (riscv_gdbarch_init): Gather isa features and abi features
14647         separately, ensure both match on the gdbarch when reusing an old
14648         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14649         a target with 64-bit float hardware.
14650
14651 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14652
14653         * source.c (search_command_helper): Stop reverse search
14654         when line 1 has been searched.
14655
14656 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14657
14658         * record-full.c (record_full_base_target::close): Rewrite
14659         record_full_core_buf_list free logic.
14660
14661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14662
14663         * break-catch-syscall.c (print_one_catch_syscall): xfree
14664         the last text.
14665
14666 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14667
14668         * top.c (print_gdb_version): Update Copyright year in version
14669         message.
14670
14671 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14672
14673         Update copyright year range in all GDB files.
14674
14675 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14676
14677         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14678
14679 For older changes see ChangeLog-2018.
14680 \f
14681 Local Variables:
14682 mode: change-log
14683 left-margin: 8
14684 fill-column: 74
14685 version-control: never
14686 coding: utf-8
14687 End:
14688