gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * compile/compile.c (struct compile_options): New.
   4         (compile_flag_option_def, compile_command_option_defs)
   5         (make_compile_options_def_group): New.
   6         (compile_file_command): Handle options with
   7         gdb::option::process_options.
   8         (compile_file_command_completer): New function.
   9         (compile_code_command): Handle options with
  10         gdb::option::process_options.
  11         (compile_code_command_completer): New function.
  12         (_initialize_compiler): Install completers for "compile code" and
  13         "compile file".  Mention available options in "compile code" and
  14         "compile code"'s help.
  15         * completer.c (advance_to_completion_word): New, factored out from
  16         ...
  17         (advance_to_expression_complete_word_point): ... this.
  18         (advance_to_filename_complete_word_point): New.
  19         * completer.h (advance_to_filename_complete_word_point): New
  20         declaration.
  21
  22 2019-06-13  Pedro Alves  <palves@redhat.com>
  23
  24         * compile/compile.c: Include "cli/cli-option.h".
  25         (compile_print_value): Scope data pointer is now a
  26         value_print_options pointer; adjust.
  27         (compile_print_command): Process options.  Scope data pointer is
  28         now a value_print_options pointer; adjust.
  29         (_initialize_compile): Update "compile print"'s help to include
  30         supported options.  Install a completer for "compile print".
  31         * cp-valprint.c (show_vtblprint, show_objectprint)
  32         (show_static_field_print): Delete.
  33         (_initialize_cp_valprint): Don't install "set print
  34         static-members", "set print vtbl", "set print object" here.
  35         * printcmd.c: Include "cli/cli-option.h" and
  36         "common/gdb_optional.h".
  37         (print_command_parse_format): Rework to fill in a
  38         value_print_options instead of a format_data.
  39         (print_value): Change parameter type from format_data pointer to
  40         value_print_options reference.  Adjust.
  41         (print_command_1): Process options.  Adjust to pass down a
  42         value_print_options.
  43         (print_command_completer): New.
  44         (_initialize_printcmd): Install print_command_completer as
  45         handle_brkchars completer for the "print" command.  Update
  46         "print"'s help to include supported options.
  47         * valprint.c: Include "cli/cli-option.h".
  48         (show_vtblprint, show_objectprint, show_static_field_print): Moved
  49         here from cp-valprint.c.
  50         (boolean_option_def, uinteger_option_def)
  51         (value_print_option_defs, make_value_print_options_def_group):
  52         New.  Use gdb::option::add_setshow_cmds_for_options to install
  53         "set print elements", "set print null-stop", "set print repeats",
  54         "set print pretty", "set print union", "set print array", "set
  55         print address", "set print symbol", "set print array-indexes".
  56         * valprint.h: Include <string> and "cli/cli-option.h".
  57         (make_value_print_options_def_group): Declare.
  58         (print_value): Change parameter type from format_data pointer to
  59         value_print_options reference.
  60         (print_command_completer): Declare.
  61
  62 2019-06-13  Pedro Alves  <palves@redhat.com>
  63
  64         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
  65         (COMMON_SFILES): Add maint-test-settings.c.
  66         * cli/cli-decode.c (boolean_enums): New global, factored out from
  67         ...
  68         (add_setshow_boolean_cmd): ... here.
  69         * cli/cli-decode.h (boolean_enums): Declare.
  70         * cli/cli-option.c: New file.
  71         * cli/cli-option.h: New file.
  72         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
  73         factored out from ...
  74         (parse_cli_boolean_value(const char *)): ... this.
  75         (is_unlimited_literal): Change parameter type to pointer to
  76         pointer.  Adjust and advance ARG pointer.
  77         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  78         (parse_cli_var_enum): New, factored out from ...
  79         (do_set_command): ... this.  Adjust.
  80         * cli/cli-setshow.h (parse_cli_boolean_value)
  81         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  82         (parse_cli_var_enum): Declare.
  83         * cli/cli-utils.c: Include "cli/cli-option.h".
  84         (get_ulongest): New.
  85         * cli/cli-utils.h (get_ulongest): Declare.
  86         (check_for_argument): New overloads.
  87         * maint-test-options.c: New file.
  88
  89 2019-06-13  Pedro Alves  <palves@redhat.com>
  90
  91         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
  92         parse a range if "-" is at the end of the string.
  93
  94 2019-06-13  Pedro Alves  <palves@redhat.com>
  95
  96         * cli/cli-setshow.c (parse_auto_binary_operation)
  97         (parse_cli_boolean_value): Don't allow "o".
  98
  99 2019-06-13  Pedro Alves  <palves@redhat.com>
 100
 101         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 102         * NEWS: Mention maint test-settings KIND.
 103         * maint-test-settings.c: New file.
 104
 105 2019-06-13  Pedro Alves  <palves@redhat.com>
 106
 107         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 108         completer.
 109         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 110         "set" completers.
 111
 112 2019-06-13  Pedro Alves  <palves@redhat.com>
 113
 114         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 115         after item.
 116
 117 2019-06-13  Pedro Alves  <palves@redhat.com>
 118
 119         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 120
 121 2019-06-13  Pedro Alves <palves@redhat.com>
 122
 123         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 124         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 125         call.
 126         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 127         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 128         calls.
 129         (check_for_argument): Skip spaces after argument.
 130
 131 2019-06-13  Pedro Alves  <palves@redhat.com>
 132
 133         * thread.c (thread_apply_command): Adjust TID parsing.
 134         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 135         detected before end of string.
 136         (tid_is_in_list): Error out if LIST is invalid.
 137
 138 2019-06-13  Pedro Alves  <palves@redhat.com>
 139
 140         * completer.c (complete_line_internal_1): Rewind completion word
 141         point.
 142         (completion_tracker::advance_custom_word_point_by): Change
 143         parameter type to int.
 144         * completer.h (completion_tracker::advance_custom_word_point_by):
 145         Likewise.
 146
 147 2019-06-13  Pedro Alves  <palves@redhat.com>
 148
 149         * completer.c (advance_to_completion_word): Handle delimiters.
 150
 151 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 152
 153         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 154
 155 2019-06-11  Tom Tromey  <tom@tromey.com>
 156
 157         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 158         (xmalloc_failed): Move to alloc.c.
 159         * alloc.c: New file.
 160         * Makefile.in (COMMON_SFILES): Add alloc.c.
 161
 162 2019-06-11  Tom Tromey  <tom@tromey.com>
 163
 164         * nat/linux-waitpid.c: Don't include server.h.
 165         (linux_debug): Remove.
 166         (my_waitpid): Update.
 167
 168 2019-06-11  Tom Tromey  <tromey@adacore.com>
 169
 170         * infcall.c (_initialize_infcall): Remove trailing newline from
 171         help.
 172         * user-regs.c (_initialize_user_regs): Remove trailing newline
 173         from help.
 174         * typeprint.c (_initialize_typeprint): Remove trailing newline
 175         from help.
 176         * reverse.c (_initialize_reverse): Remove trailing newlines from
 177         help.
 178         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 179         from help.
 180         * language.c (add_set_language_command): Remove trailing newline
 181         from help.
 182         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 183         help.
 184         * disasm.c (_initialize_disasm): Remove trailing newline from
 185         help.
 186         * top.c (init_main): Remove trailing newline from help.
 187         * interps.c (_initialize_interpreter): Remove trailing newline
 188         from help.
 189         * btrace.c (_initialize_btrace): Remove trailing newlines from
 190         help.
 191         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 192         from help.
 193         * python/python.c (_initialize_python): Remove trailing newline
 194         from help.
 195         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 196         help.
 197         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 198         from help.  Reformat some text.
 199         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 200         from help.
 201         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 202         newline from help.
 203
 204 2019-06-11  Tom Tromey  <tromey@adacore.com>
 205
 206         * darwin-nat.c (darwin_decode_exception_message)
 207         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 208
 209 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 210
 211         * valops.c (value_slice): Check for not allocated or not
 212         associated values.
 213
 214 2019-06-10  Tom de Vries  <tdevries@suse.de>
 215
 216         PR gdb/24618
 217         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 218         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 219         invalid.
 220
 221 2019-06-10  Tom de Vries  <tdevries@suse.de>
 222
 223         PR gdb/24611
 224         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 225         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 226
 227 2019-06-10  Tom de Vries  <tdevries@suse.de>
 228
 229         PR symtab/24545
 230         * symtab.c (struct demangled_name_entry): Add language field.
 231         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 232         static minimal symbol".  Set and use language field.
 233
 234 2019-06-10  Tom Tromey  <tromey@adacore.com>
 235
 236         * ada-lang.c (_initialize_ada_language): Update help text.
 237
 238 2019-06-10  Tom Tromey  <tromey@adacore.com>
 239
 240         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 241         with a newline.
 242         * guile/guile.c (handle_boot_error): Don't end warning with a
 243         newline.
 244         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 245         warning with a newline.
 246         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 247         newline.
 248         (s12z_frame_cache): Likewise.
 249         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 250         a newline.
 251         * solib-svr4.c (disable_probes_interface): Don't end warning with
 252         a newline.
 253         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 254         newline.
 255         * python/python.c (do_finish_initialization): Don't end warning
 256         with a newline.
 257
 258 2019-06-10  Tom Tromey  <tom@tromey.com>
 259
 260         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 261         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 262         gdbpy_enter.
 263
 264 2019-06-10  Tom Tromey  <tromey@adacore.com>
 265
 266         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 267         data.
 268         (elf_new_init): Don't call stabsread_new_init.
 269         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 270         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 271         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 272
 273 2019-06-10  Tom de Vries  <tdevries@suse.de>
 274
 275         PR symtab/16264
 276         PR symtab/24517
 277         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 278
 279 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 280
 281         * source.c (find_and_open_source): Also rewrite relative file
 282         names.
 283
 284 2019-04-26  Amos Bird  <amosbird@gmail.com>
 285
 286         * annotate.c (annotate_thread_exited): Add "thread-exited"
 287         annotation.
 288
 289 2019-06-06  Tom Tromey  <tromey@adacore.com>
 290
 291         * maint.h (class scoped_command_stats): Use
 292         DISABLE_COPY_AND_ASSIGN.
 293         <print_time>: New method.
 294         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 295         print_time.
 296         (scoped_command_stats::print_time): New method.
 297
 298 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 299
 300         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 301         instructions of lengths 6 or 8 bytes.
 302
 303 2019-06-04  Pedro Alves  <palves@redhat.com>
 304
 305         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 306
 307         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 308         * breakpoint.c (condition_completer): Likewise.
 309         * cli/cli-dump.c (scan_expression): Likewise.
 310         * common/filestuff.c (mkdir_recursive): Likewise.
 311         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 312         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 313         (gdb_abspath): Likewise.
 314         * compile/compile-cplus-types.c
 315         (compile_cplus_instance::decl_name): Likewise.
 316         * completer.c (complete_explicit_location):
 317         (signal_completer, reg_or_group_completer_1): Likewise.
 318         * cp-support.c (cp_remove_params_if_any): Likewise.
 319         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 320         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 321         * infcmd.c (strip_bg_char): Likewise.
 322         * linespec.c (copy_token_string): Likewise.
 323         * mi/mi-main.c (output_cores): Likewise.
 324         * psymtab.c (psymtab_search_name):
 325         * symfile.c (test_set_ext_lang_command): Likewise.
 326         * target.c (target_fileio_read_stralloc): Likewise.
 327         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 328         * value.c (complete_internalvar): Likewise.
 329
 330 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 331
 332         Add objfile property to gdb.Type.
 333         * NEWS: Mention Python API addition.
 334         * python/py-type.c (typy_get_objfile): New method.
 335
 336 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 337
 338         * NEWS: Mention the new set|show style [title|highlight].
 339         Mention changes to "show style", "help" and "apropos".
 340
 341 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 342
 343         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 344         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 345         instead of print_help_for_command.
 346         (print_doc_of_command): New function.
 347         (help_list): Add 'apropos -v word' suggestion.
 348         (print_help_for_command): Style the command name using title style.
 349         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 350         (_initialize_cli_cmds): Describe -v in apropos_command help.
 351
 352 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 353
 354         * cli/cli-style.h (cli_style_option): Add name in constructor,
 355         add m_name class member, add constructor with intensity,
 356         add name class function.
 357         (cli_style_option::add_setshow_commands): Remove name argument.
 358         (highlight_style, title_style): New styles.
 359         * cli/cli-style.c (do_show): New function that shows a style
 360         characteristic styling the style name with itself.
 361         (set_style_name): New function.
 362         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 363         Update all callers according to the changes in cli/cli-style.h.
 364         * utils.h (fputs_highlighted): New function.
 365         * utils.c (fputs_highlighted): Likewise.
 366
 367 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 368
 369         * NEWS: Mention new pipe command and new convenience variables.
 370
 371 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 372
 373         * cli/cli-cmds.c (pipe_command): New function.
 374         (_initialize_cli_cmds): Call add_com for pipe_command.
 375         Define | as an alias for pipe.
 376         (exit_status_set_internal_vars): New function.
 377         (shell_escape): Call exit_status_set_internal_vars.
 378         cli/cli-decode.c (find_command_name_length): Recognize | as
 379         a single character command.
 380
 381 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 382
 383         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 384         top.c (execute_command_to_ui_file): New function, mostly a copy
 385         of execute_command_to_string.
 386         (execute_command_to_string): Implement by calling
 387         execute_command_to_ui_file.
 388
 389 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * top.h (saved_command_line): Remove declaration.
 392         * top.c (previous_saved_command_line, previous_repeat_arguments):
 393         New variables.
 394         (saved_command_line): Make static, define together with other
 395         'repeat variables'.
 396         (dont_repeat): Clear repeat_arguments.
 397         (repeat_previous, get_saved_command_line, save_command_line):
 398         New functions.
 399         (gdb_init): Initialize saved_command_line
 400         and previous_saved_command_line.
 401         * main.c (captured_main_1): Remove saved_command_line initialization.
 402         * event-top.c (handle_line_of_input): Update to use
 403         the new 'repeat' related functions instead of direct access to
 404         saved_command_line.
 405         * command.h (repeat_previous, get_saved_command_line,
 406         save_command_line): New declarations.
 407         (dont_repeat): Add comment.
 408
 409 2019-05-30  Tom Tromey  <tromey@adacore.com>
 410
 411         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 412         Fix comment.
 413         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 414
 415 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 416
 417         PR cli/24587
 418         * completer.c (complete): Initialize variable word.
 419
 420 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 421
 422         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 423         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 424         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 425         'body' is NULL to the outter 'if', protecting the '!is_define'
 426         situation as well.
 427
 428 2019-05-29  Tom Tromey  <tromey@adacore.com>
 429
 430         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 431         (dwarf_unknown): New function.
 432         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 433         (dwarf_type_encoding_name): Use dwarf_unknown.
 434
 435 2019-05-29  Tom Tromey  <tromey@adacore.com>
 436
 437         PR c++/20020:
 438         * cp-valprint.c (cp_print_value_fields): Call
 439         cp_print_static_field inside "try".
 440
 441 2019-05-29  Tom Tromey  <tromey@adacore.com>
 442
 443         * inflow.c (struct terminal_info): Add default operator=.
 444         * configure: Rebuild.
 445         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 446         -Wdeprecated-copy-dtor, -Wredundant-move.
 447
 448 2019-05-29  Tom Tromey  <tromey@adacore.com>
 449
 450         * NEWS: Add entry.
 451         * infcmd.c (print_return_value_1): Handle finish_print
 452         option.
 453         (show_print_finish): New function.
 454         (_initialize_infcmd): Add "set/show print finish" commands.
 455         * valprint.c (user_print_options): Initialize new member.
 456         * valprint.h (struct value_print_options) <finish_print>: New
 457         member.
 458
 459 2019-05-28  Tom Tromey  <tromey@adacore.com>
 460
 461         * ada-lang.c (ada_remove_Xbn_suffix)
 462         (find_old_style_renaming_symbol)
 463         (parse_old_style_renaming): Remove.
 464         (ada_find_renaming_symbol): Don't call
 465         find_old_style_renaming_symbol.
 466         (ada_is_renaming_symbol): Rename from
 467         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 468         bool.  Now static.
 469         (ada_read_var_value): Update and simplify.
 470         * ada-exp.y (write_var_or_type): Remove old code.
 471
 472 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 473
 474         * event-top.c: Remove include comment.
 475         * inflow.c (class scoped_ignore_sigttou): Move from here...
 476         * inflow.h (class scoped_ignore_sigttou): ...to here.
 477         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 478         * top.c:  Remove include comment.
 479
 480 2019-05-27  Tom Tromey  <tom@tromey.com>
 481
 482         * NEWS: Fix typo.
 483
 484 2019-05-22  Tom Tromey  <tromey@adacore.com>
 485
 486         * target.c (target_follow_exec): Constify parameter.
 487         * target-delegates.c: Rebuild.
 488         * remote.c (remote_target::follow_exec): Constify parameter.
 489         * infrun.c (follow_exec): Constify parameter.
 490         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 491         (target_follow_exec): Likewise.
 492
 493 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 494
 495         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 496         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 497
 498 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 499
 500         * NEWS: Add debugredirect and testsuite sections.
 501
 502 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 503
 504         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 505         target descriptions using exclusively floating point register name
 506         aliases.
 507
 508 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         PR gdb/18644:
 511         * f-lang.c (build_fortran_types): Handle the case where
 512         gdbarch_floatformat_for_type returns a nullptr.
 513
 514 2019-05-21  Tom de Vries  <tdevries@suse.de>
 515
 516         PR cli/24587
 517         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 518
 519 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         PR gdb/18644:
 522         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 523         16-byte floats.
 524         * i386-tdep.c (i386_floatformat_for_type): Use
 525         floatformats_ia64_quad for the 16-byte floating point component
 526         within a fortran 32-byte complex number.
 527
 528 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 531         delete default constructor.
 532         (find_partial_die): Update to return const struct.
 533         (partial_die_parent_scope): Move variable declaration into scope
 534         of its use and change its type to auto.
 535         (guess_partial_die_structure_name): Likewise.
 536         (partial_die_info::fixup): Likewise.
 537
 538 2019-05-17  Tom Tromey  <tromey@adacore.com>
 539
 540         * source.c (find_and_open_source): Remove cast.
 541
 542 2019-05-17  Tom Tromey  <tromey@adacore.com>
 543
 544         * annotate.c (annotate_source): Make "filename" const.
 545         * annotate.h (annotate_source): Use const.
 546
 547 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 548
 549         * disasm.c (set_disassembler_options): Send errors to stderr.
 550
 551 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 552
 553         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 554         (cli_interp_base::set_logging): Check debug_redirect.
 555         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 556         * cli/cli-logging.c (debug_redirect): Add static variable.
 557         (pop_output_files): Add default param.
 558         (handle_redirections): Print debug setting.
 559         (show_logging_command): Likewise.
 560         (_initialize_cli_logging): Add debugredirect command.
 561         * interps.c (current_interp_set_logging): Add debug_redirect
 562         parameter.
 563         * interps.h (set_logging): Add debug_redirect parameter.
 564         (current_interp_set_logging): Likewise.
 565         * mi/mi-common.h: Likewise.
 566         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 567
 568 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 569             Tom Tromey  <tromey@adacore.com>
 570
 571         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 572         directly.
 573         * cli/cli-interp.h (make_logging_output): Remove declaration.
 574         * cli/cli-logging.c (make_logging_output): Remove function.
 575         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 576         directly.
 577         * ui-file.c (tee_file::tee_file): Remove bools.
 578         (tee_file::~tee_file): Remove deletes.
 579         * ui-file.h (tee_file): Remove bools.
 580
 581 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 582
 583         * mi/mi-cmds.h (mi_cmd_complete): New function.
 584         * mi/mi-main.c (mi_cmd_complete): Likewise.
 585         * mi/mi-cmds.c: Define new MI command -complete.
 586         * NEWS: Mention new -complete command.
 587
 588 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 589
 590         * completer.h (complete): New function.
 591         * completer.c (complete): Likewise.
 592         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 593         function defined in completer.h.
 594
 595 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 596
 597        * MAINTAINERS (Write After Approval): Add myself.
 598
 599 2019-05-17  Tom de Vries  <tdevries@suse.de>
 600
 601         PR gdb/24094
 602         * dwarf2read.c (struct cu_partial_die_info): New struct.
 603         (find_partial_die): Return cu_partial_die_info.
 604         (partial_die_parent_scope, guess_partial_die_structure_name)
 605         (partial_die_info::fixup): Handle new return type of find_partial_die.
 606
 607 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 608
 609         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 610         "std::string", simplifying the algorithm.
 611
 612 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 613
 614         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 615         (stap_static_probe_ops::get_probes): Likewise.
 616
 617 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 618
 619         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 620         '-')" and "else if".
 621         (stap_parse_single_operand): Join checks for
 622         "gdbarch_stap_parse_special_token_p" and
 623         "gdbarch_stap_parse_special_token" in the same "if" statement.
 624         Invert check when verifying for operation on register
 625         displacement.
 626
 627 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 628
 629         * stap-probe.c (stap_get_opcode): Update comment.
 630         (stap_get_expected_argument_type): Likewise.
 631         (handle_stap_probe): Likewise.
 632
 633 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 634
 635         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 636         return type to 'bool'.  Adjust comment.  Use 'bool' when
 637         appropriate.
 638         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 639         * stap-probe.c (stap_parse_argument_1): Likewise.
 640         (stap_is_operator): Likewise.
 641         (stap_is_generic_prefix): Likewise.
 642         (stap_is_register_prefix): Likewise.
 643         (stap_is_register_indirection_prefix): Likewise.
 644         (stap_is_integer_prefix): Likewise.
 645         (stap_generic_check_suffix): Likewise.
 646         (stap_check_integer_suffix): Likewise.
 647         (stap_check_register_suffix): Likewise.
 648         (stap_check_register_indirection_suffix): Likewise.
 649         (stap_parse_register_operand): Likewise.
 650         (stap_parse_single_operand): Likewise.
 651         (stap_parse_argument_1): Likewise.
 652         (stap_probe::get_argument_count): Likewise.
 653         (stap_is_operator): Likewise.
 654
 655 2019-05-16  Tom Tromey  <tromey@adacore.com>
 656
 657         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 658         keyword to foreach.
 659
 660 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 661
 662         * linux-thread-db.c (try_thread_db_load_1): Change return type
 663         to bool.
 664         (try_thread_db_load): Likewise.
 665         (try_thread_db_load_from_pdir_1): Likewise.
 666         (try_thread_db_load_from_pdir): Likewise.
 667         (try_thread_db_load_from_sdir): Likewise.
 668         (try_thread_db_load_from_dir): Likewise.
 669         (thread_db_load_search): Likewise.
 670         (has_libpthread): Likewise.
 671         (thread_db_load): Likewise.
 672
 673 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 674
 675         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 676         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 677         NULL, and complain/return if that's the case.
 678
 679 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 680
 681         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 682         (advance, posn, abstract_read_memory): New functions.
 683         [struct mem_read_abstraction]: New struct.
 684         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 685
 686 2019-05-14  Tom Tromey  <tromey@adacore.com>
 687
 688         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 689         value is not lval_memory.
 690
 691 2019-05-14  Tom Tromey  <tromey@adacore.com>
 692
 693         * solib.c (info_sharedlibrary_command): Style the file name.
 694
 695 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 696
 697         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 698         (aarch64_vnv_type): Likewise.
 699         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 700         * common/tdesc.c: Likewise.
 701         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 702         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 703         * features/aarch64-fpu.xml: Add ieee half view.
 704         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 705         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 706         * gdbtypes.h (struct builtin_type): Likewise.
 707         (struct objfile_type): Likewise.
 708
 709 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 710
 711         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 712         typo.
 713         * location.h (string_to_event_location): Likewise.
 714
 715 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 716
 717         GDB 8.3 released.
 718
 719 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 720
 721         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 722         New variable declaration.
 723         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 724         New variable.
 725         (print_one_breakpoint): Use ui_out::test_flags and new global
 726         variable to compute use_fixed_output.
 727         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 728         Remove.
 729         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 730         (mi_multi_location_breakpoint_output_fixed): Remove.
 731         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 732         new variable.
 733         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 734         fix_multi_location_breakpoint_output flag if version >= 3.
 735         * ui-out.h (enum ui_out_flag)
 736         <fix_multi_location_breakpoint_output>: New enumerator.
 737
 738 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 739
 740         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 741
 742 2019-05-10  Tom Tromey  <tromey@adacore.com>
 743
 744         * ada-lang.c (catch_ada_completer): New function.
 745         (_initialize_ada_language): Use it.
 746
 747 2019-05-10  Tom Tromey  <tromey@adacore.com>
 748
 749         * thread.c (print_thread_info): Make "requested_threads" const.
 750         * gdbthread.h (print_thread_info): Make "requested_threads"
 751         const.
 752         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 753         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 754
 755 2019-05-08  Tom Tromey  <tom@tromey.com>
 756
 757         * gdbtypes.c (objfile_type_data): Change type.
 758         (objfile_type, _initialize_gdbtypes): Update.
 759
 760 2019-05-08  Tom Tromey  <tom@tromey.com>
 761
 762         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 763         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 764         (_initialize_dwarf2_frame): Update.
 765
 766 2019-05-08  Tom Tromey  <tom@tromey.com>
 767
 768         * objc-lang.c (objc_objfile_data): Change type.
 769         (find_methods): Update.
 770         (_initialize_objc_lang): Remove.
 771
 772 2019-05-08  Tom Tromey  <tom@tromey.com>
 773
 774         * stabsread.c (rs6000_builtin_type_data): Change type.
 775         (rs6000_builtin_type, _initialize_stabsread): Update.
 776
 777 2019-05-08  Tom Tromey  <tom@tromey.com>
 778
 779         * mips-tdep.c (mips_pdr_data): Remove.
 780         (_initialize_mips_tdep): Update.
 781
 782 2019-05-08  Tom Tromey  <tom@tromey.com>
 783
 784         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 785         (hppa_init_objfile_priv_data, read_unwind_info)
 786         (find_unwind_entry, _initialize_hppa_tdep): Update.
 787
 788 2019-05-08  Tom Tromey  <tom@tromey.com>
 789
 790         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 791         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 792         on obstack.
 793         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 794
 795 2019-05-08  Tom Tromey  <tom@tromey.com>
 796
 797         * mdebugread.c (basic_type_data): Change type.
 798         (basic_type, _initialize_mdebugread): Update.
 799
 800 2019-05-08  Tom Tromey  <tom@tromey.com>
 801
 802         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 803
 804 2019-05-08  Tom Tromey  <tom@tromey.com>
 805
 806         * nto-tdep.c (nto_inferior_data_reg): Change type.
 807         (nto_inferior_data): Update.
 808         (nto_inferior_data_cleanup, nto_new_inferior_data)
 809         (_initialize_nto_tdep): Remove.
 810         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 811
 812 2019-05-08  Tom Tromey  <tom@tromey.com>
 813
 814         * ada-lang.c (struct ada_inferior_data): Add initializers.
 815         (ada_inferior_data): Change type.
 816         (ada_inferior_data_cleanup): Remove.
 817         (get_ada_inferior_data, ada_inferior_exit)
 818         (struct ada_pspace_data): Add initializers, destructor.
 819         (ada_pspace_data_handle): Change type.
 820         (get_ada_pspace_data): Update.
 821         (ada_pspace_data_cleanup): Remove.
 822
 823 2019-05-08  Tom Tromey  <tom@tromey.com>
 824
 825         * coffread.c (struct coff_symfile_info): Add initializers.
 826         (coff_objfile_data_key): Move lower.  Change type.
 827         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 828         Update.
 829         (coff_free_info): Remove.
 830
 831 2019-05-08  Tom Tromey  <tom@tromey.com>
 832
 833         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 834         (fbsd_pspace_data_handle): Move lower.  Change type.
 835         (get_fbsd_pspace_data): Update.
 836         (fbsd_pspace_data_cleanup): Remove.
 837         (_initialize_fbsd_tdep): Update.
 838
 839 2019-05-08  Tom Tromey  <tom@tromey.com>
 840
 841         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 842         (get_ada_tasks_pspace_data): Update.
 843         (ada_tasks_pspace_data_cleanup): Remove.
 844         (_initialize_tasks): Update.
 845         (ada_tasks_inferior_data_handle): Change type.
 846         (get_ada_tasks_inferior_data): Update.
 847         (ada_tasks_inferior_data_cleanup): Remove.
 848         (struct ada_tasks_pspace_data): Add initializers.
 849
 850 2019-05-08  Tom Tromey  <tom@tromey.com>
 851
 852         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 853         * symfile-debug.c (debug_sym_get_probes): Change type.
 854         * stap-probe.c (handle_stap_probe):
 855         (stap_static_probe_ops::get_probes): Change type.
 856         * probe.h (class static_probe_ops) <get_probes>: Change type.
 857         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 858         (parse_probes_in_pspace): Update.
 859         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 860         Update.
 861         (any_static_probe_ops::get_probes): Change type.
 862         * elfread.c (elfread_data): New typedef.
 863         (probe_key): Change type.
 864         (elf_get_probes): Likewise.  Update.
 865         (probe_key_free): Remove.
 866         (_initialize_elfread): Update.
 867         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 868         Change type.
 869         (dtrace_process_dof_probe, dtrace_process_dof)
 870         (dtrace_static_probe_ops::get_probe): Change type.
 871
 872 2019-05-08  Tom Tromey  <tom@tromey.com>
 873
 874         * xcoffread.c (struct xcoff_symfile_info): Rename from
 875         coff_symfile_info.  Add initializers.
 876         (xcoff_objfile_data_key): Move lower.  Change type.
 877         (XCOFF_DATA): Rewrite.
 878         (xcoff_free_info): Remove.
 879         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 880         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 881         (xcoff_initial_scan): Update.
 882
 883 2019-05-08  Tom Tromey  <tom@tromey.com>
 884
 885         * solib-svr4.c (struct svr4_info): Add initializers and
 886         destructor.
 887         <probes_table>: Now an htab_up.
 888         (solib_svr4_pspace_data): Change type.
 889         (free_probes_table): Simplify.
 890         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 891         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 892         (probes_table_remove_objfile_probes, register_solib_event_probe)
 893         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 894         (_initialize_svr4_solib): Update.
 895
 896 2019-05-08  Tom Tromey  <tom@tromey.com>
 897
 898         * remote.c (remote_pspace_data): Change type.
 899         (remote_pspace_data_cleanup): Remove.
 900         (get_remote_exec_file, set_pspace_remote_exec_file)
 901         (_initialize_remote): Update.
 902
 903 2019-05-08  Tom Tromey  <tom@tromey.com>
 904
 905         * breakpoint.c (breakpoint_objfile_key): Change type.
 906         (get_breakpoint_objfile_data): Update.
 907         (free_breakpoint_objfile_data): Remove.
 908         (_initialize_breakpoint): Update.
 909
 910 2019-05-08  Tom Tromey  <tom@tromey.com>
 911
 912         * linux-tdep.c (struct linux_info): Add initializers.
 913         (linux_inferior_data): Move.  Change type.
 914         (invalidate_linux_cache_inf): Update.
 915         (linux_inferior_data_cleanup): Remove.
 916         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 917
 918 2019-05-08  Tom Tromey  <tom@tromey.com>
 919
 920         * auxv.c (auxv_inferior_data): Move.  Change type.
 921         (auxv_inferior_data_cleanup): Remove.
 922         (invalidate_auxv_cache_inf): Rewrite.
 923         (get_auxv_inferior_data, _initialize_auxv): Update.
 924
 925 2019-05-08  Tom Tromey  <tom@tromey.com>
 926
 927         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 928         (symfile_debug_objfile_data_key): Change type.
 929         (symfile_debug_installed, debug_qf_has_symbols)
 930         (debug_qf_find_last_source_symtab)
 931         (debug_qf_forget_cached_source_info)
 932         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 933         (debug_qf_print_stats, debug_qf_dump)
 934         (debug_qf_expand_symtabs_for_function)
 935         (debug_qf_expand_all_symtabs)
 936         (debug_qf_expand_symtabs_with_fullname)
 937         (debug_qf_map_matching_symbols)
 938         (debug_qf_expand_symtabs_matching)
 939         (debug_qf_find_pc_sect_compunit_symtab)
 940         (debug_qf_map_symbol_filenames)
 941         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 942         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 943         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 944         (debug_sym_read_linetable, debug_sym_relocate): Update.
 945         (symfile_debug_free_objfile): Remove.
 946         (install_symfile_debug_logging, _initialize_symfile_debug):
 947         Update.
 948
 949 2019-05-08  Tom Tromey  <tom@tromey.com>
 950
 951         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 952         allocate_on_obstack.
 953         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 954         (get_dwarf2_per_objfile): Update.
 955         (set_dwarf2_per_objfile): Remove.
 956         (dwarf2_has_info, dwarf2_get_section_info): Update.
 957         (dwarf2_free_objfile): Remove.
 958         (_initialize_dwarf2_read): Update.
 959
 960 2019-05-08  Tom Tromey  <tom@tromey.com>
 961
 962         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 963         initializers.
 964         <unsupported_script_warning_printed,
 965         script_not_found_warning_printed>: Now bool.
 966         (auto_load_pspace_data): Change type.
 967         (~auto_load_pspace_info): Rename from
 968         auto_load_pspace_data_cleanup.
 969         (get_auto_load_pspace_data, init_loaded_scripts_info)
 970         (clear_section_scripts, maybe_print_unsupported_script_warning)
 971         (maybe_print_script_not_found_warning, _initialize_auto_load):
 972         Update.
 973
 974 2019-05-08  Tom Tromey  <tom@tromey.com>
 975
 976         * objfiles.c (objfile_pspace_info): Add destructor and
 977         initializers.
 978         (objfiles_pspace_data): Change type.
 979         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 980         (get_objfile_pspace_data): Update.
 981         (objfiles_bfd_data): Change type.
 982         (get_objfile_bfd_data): Update.
 983         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 984
 985 2019-05-08  Tom Tromey  <tom@tromey.com>
 986
 987         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 988         Change type.
 989         (get_catch_syscall_inferior_data): Update.
 990         (catch_syscall_inferior_data_cleanup): Remove.
 991         (_initialize_break_catch_syscall): Update.
 992
 993 2019-05-08  Tom Tromey  <tom@tromey.com>
 994
 995         * inflow.c (struct terminal_info): Add destructor and
 996         initializers.
 997         (inflow_inferior_data): Change type.
 998         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 999         (get_inflow_inferior_data, inflow_inferior_exit)
1000         (swap_terminal_info, _initialize_inflow): Update.
1001
1002 2019-05-08  Tom Tromey  <tom@tromey.com>
1003
1004         * target-dcache.c (target_dcache_cleanup): Remove.
1005         (target_dcache_aspace_key): Change type.
1006         (target_dcache_init_p, target_dcache_invalidate)
1007         (target_dcache_get, target_dcache_get_or_init)
1008         (_initialize_target_dcache): Update.
1009         * dcache.h (struct dcache_deleter): New.
1010
1011 2019-05-08  Tom Tromey  <tom@tromey.com>
1012
1013         * symtab.c (struct symbol_cache): Add destructor and
1014         initializers.
1015         (symbol_cache_key): Move.  Change type.
1016         (make_symbol_cache, free_symbol_cache): Remove.
1017         (get_symbol_cache): Update.
1018         (symbol_cache_cleanup): Remove.
1019         (ALL_PSPACES, symbol_cache_flush)
1020         (maintenance_print_symbol_cache)
1021         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1022         Update.
1023
1024 2019-05-08  Tom Tromey  <tom@tromey.com>
1025
1026         * symtab.c (struct main_info): Add destructor and initializers.
1027         (main_progspace_key): Move.  Change type.
1028         (get_main_info): Update.
1029         (main_info_cleanup): Remove.
1030         (_initialize_symtab): Update.
1031
1032 2019-05-08  Tom Tromey  <tom@tromey.com>
1033
1034         * registry.h (DECLARE_REGISTRY): Define the _key class.
1035
1036 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * NEWS: Merge two 'New commands' sections.
1039
1040 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1041
1042         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1043         parameter and use Ada language definition instead.
1044         (ada_val_print_ptr): Remove unused language parameter.
1045         (ada_val_print_num): Remove language parameter and use Ada language
1046         definition instead.
1047         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1048         parameter.
1049         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1050         parameter and use Ada language definition instead.
1051         (ada_val_print_1): Update all ada_val_print_xxx calls.
1052         Remove language parameter.
1053         (ada_val_print): Update ada_val_print_1 call.
1054
1055 2019-05-08  Tom Tromey  <tromey@adacore.com>
1056
1057         * remote.c (remote_hw_watchpoint_limit)
1058         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1059         Now static.
1060
1061 2019-05-08  Tom Tromey  <tromey@adacore.com>
1062
1063         * maint.c (_initialize_maint_cmds): Move initialization code to
1064         remote.c.
1065         (watchdog, show_watchdog): Move to remote.c.
1066         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1067         "watchdog" static.
1068         (_initialize_remote): Move initialization code from maint.c.
1069         * defs.h (watchdog): Don't declare.
1070
1071 2019-05-08  Tom Tromey  <tromey@adacore.com>
1072
1073         * tui/tui-interp.c: Include main.h.
1074         * interps.c: Include main.h.
1075         * main.h (interpreter_p): Declare.
1076         * defs.h (interpreter_p): Don't declare.
1077
1078 2019-05-08  Tom Tromey  <tromey@adacore.com>
1079
1080         * dwarf2loc.c: Include dwarf2read.h.
1081         * defs.h (read_unsigned_leb128): Don't declare.
1082         * dwarf2read.h (read_unsigned_leb128): Declare.
1083
1084 2019-05-08  Tom Tromey  <tromey@adacore.com>
1085
1086         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1087         method.
1088
1089 2019-05-08  Tom Tromey  <tromey@adacore.com>
1090
1091         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1092         when no wrap column is set.
1093
1094 2019-05-08  Tom Tromey  <tromey@adacore.com>
1095
1096         * c-lang.c (c_get_string): Handle non-C-style arrays.
1097
1098 2019-05-08  Tom Tromey  <tromey@adacore.com>
1099
1100         * typeprint.c (print_offset_data::update): Print the bit offset,
1101         not the number of bits remaining.
1102
1103 2019-05-08  Tom Tromey  <tromey@adacore.com>
1104
1105         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1106         padding at end of comment.
1107
1108 2019-05-08  Tom Tromey  <tromey@adacore.com>
1109
1110         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1111         Compare main types.
1112
1113 2019-05-06  Tom Tromey  <tom@tromey.com>
1114
1115         * common/scoped_mmap.c: Include common-defs.h.
1116         * common/scoped_mmap.h: Don't include config.h.
1117
1118 2019-05-04  Tom Tromey  <tom@tromey.com>
1119
1120         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1121         (struct aarch64_call_info): Add initializers.
1122         <si>: Now a std::vector.
1123         (pass_on_stack, aarch64_push_dummy_call): Update.
1124
1125 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1126             Tom Tromey  <tom@tromey.com>
1127
1128         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1129         (ppc_threads): Now a std::vector.  Now static.
1130         (hwdebug_find_thread_points_by_tid)
1131         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1132         Update.
1133
1134 2019-05-04  Tom Tromey  <tom@tromey.com>
1135
1136         * arc-tdep.c (arc_tdesc_init): Return bool.
1137
1138 2019-05-04  Tom Tromey  <tom@tromey.com>
1139
1140         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1141         Use gdb_assert_not_reached.
1142
1143 2019-05-04  Tom Tromey  <tom@tromey.com>
1144
1145         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1146         "false".
1147
1148 2019-05-04  Tom Tromey  <tom@tromey.com>
1149
1150         * arc-tdep.c (arc_tdesc_init): Use bool.
1151
1152 2019-05-04  Tom Tromey  <tom@tromey.com>
1153
1154         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1155
1156 2019-05-04  Tom Tromey  <tom@tromey.com>
1157
1158         * cli/cli-cmds.c (valid_command_p): Return bool.
1159
1160 2019-05-04  Tom Tromey  <tom@tromey.com>
1161
1162         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1163         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1164
1165 2019-05-04  Raul Tambre  <raul@tambre.ee>
1166
1167         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1168         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1169         operator for comparison.
1170
1171 2019-05-04  Tom Tromey  <tom@tromey.com>
1172
1173         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1174         (lookup_partial_symbol, print_partial_symbols)
1175         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1176         (psymbol_compare): Update.
1177         (add_psymbol_to_bcache): Clear the entire psymbol.
1178         (maintenance_check_psymtabs): Update.
1179         * psympriv.h (struct partial_symbol): Don't derive from
1180         general_symbol_info.
1181         <obj_section, unrelocated_address, address,
1182         set_unrelocated_address>: Update.
1183         <ginfo>: New member.
1184         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1185         (debug_names::write_psymbols): Update.
1186
1187 2019-05-04  Tom de Vries  <tdevries@suse.de>
1188
1189         * contrib/cc-with-tweaks.sh: Support -n arg.
1190
1191 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1192
1193         * corelow.c (core_target::detach): Ensure frame cache and
1194         register caches are cleared.
1195         inferior.c (exit_inferior_1): Likewise.
1196
1197 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1198             Tom Tromey  <tom@tromey.com>
1199
1200         * dictionary.c (collate_pending_symbols_by_language): Remove
1201         "struct" from foreach.
1202         * symtab.c (lookup_global_symbol_from_objfile)
1203         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1204         foreach.
1205         * ser-tcp.c (net_open): Remove "struct" from foreach.
1206         * objfiles.c (objfile_relocate, objfile_rebase)
1207         (objfile_has_symbols): Remove "struct" from foreach.
1208         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1209         from foreach.
1210         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1211         foreach.
1212         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1213         "struct" from foreach.
1214         * ada-lang.c (create_excep_cond_exprs)
1215         (ada_exception_catchpoint_cond_string): Remove "struct" from
1216         foreach.
1217
1218 2019-05-03  Tom Tromey  <tromey@adacore.com>
1219
1220         * ada-exp.y (convert_char_literal): Check suffix of each
1221         enumerator.
1222
1223 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1224
1225         PR ada/21406:
1226         * ada-exp.y (yywrap): Don't define.
1227         * ada-lex.l (%option): Add noyywrap
1228         (yywrap): Remove.
1229
1230 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1231
1232         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1233         _WIN32_WINNT to the XP level, unless already defined to a higher
1234         level.
1235
1236         * unittests/parse-connection-spec-selftests.c:
1237         * ser-tcp.c:
1238         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1239         override.
1240
1241         * symfile.c (find_separate_debug_file): Remove colon from the
1242         drive spec of DOS/Windows file names of the target, so that the
1243         file name produced from DEBUGDIR and the target's directory will
1244         be valid on DOS/Windows systems.
1245
1246 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * rust-lang.c (val_print_struct): Handle printing structures
1249         containing strings.
1250
1251 2019-05-02  Tom Tromey  <tromey@adacore.com>
1252
1253         * valarith.c (_initialize_valarith): Remove.
1254
1255 2019-05-01  Tom Tromey  <tromey@adacore.com>
1256
1257         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1258         bitfields.
1259
1260 2019-05-01  Tom Tromey  <tromey@adacore.com>
1261
1262         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1263         for big-endian copies.
1264
1265 2019-04-30  Ali Tamur  <tamur@google.com>
1266         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1267         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1268         (read_3_bytes): New function.
1269
1270 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1271
1272         * windows-nat.c (main_thread_id): Delete.
1273         (handle_output_debug_string): Replace main_thread_id by
1274         current_event.dwThreadId.
1275         (fake_create_process): Likewise.
1276         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1277         Do not set main_thread_id.
1278         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1279         current_event.dwThreadId.
1280         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1281
1282 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1283
1284         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1285         Use current_event.dwThreadId instead of main_thread_id.
1286
1287 2019-04-30  Tom Tromey  <tromey@adacore.com>
1288
1289         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1290         (create_excep_cond_exprs): Iterate over program spaces.
1291         (ada_exception_catchpoint_cond_string): Examine all minimal
1292         symbols for exception types.
1293
1294 2019-04-30  Tom Tromey  <tromey@adacore.com>
1295
1296         PR c++/24470:
1297         * dwarf2read.c (process_structure_scope): Handle case where type
1298         has template parameters but no symbol was created.
1299
1300 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1301             Chris January  <chris.january@arm.com>
1302
1303         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1304         qualifier.
1305         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1306
1307 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * f-typeprint.c (f_print_type): Update rules for printing
1310         whitespace.
1311         (f_type_print_varspec_suffix): Likewise.
1312
1313 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1314             Chris January  <chris.january@arm.com>
1315
1316         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1317         function arguments.
1318
1319 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * f-lang.c (build_fortran_types): Change name of void type to
1322         lower case.
1323         * f-typeprint.c (f_type_print_base): Print the name of the void
1324         type, rather than a fixed string.
1325         * f-valprint.c (f_decorations): Use lower case void string.
1326
1327 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1328             Chris January  <chris.january@arm.com>
1329
1330         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1331         types for Fortran.
1332
1333 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1334             Chris January  <chris.january@arm.com>
1335             David Lecomber  <david.lecomber@arm.com>
1336
1337         * f-exp.y (BINOP_INTRINSIC): New token.
1338         (exp): New parser rule handling BINOP_INTRINSIC.
1339         (f77_keywords): Add new builtin procedures.
1340         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1341         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1342         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1343         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1344         (print_unop_subexp_f): New function.
1345         (print_binop_subexp_f): New function.
1346         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1347         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1348         (dump_subexp_body_f): Likewise.
1349         (operator_check_f): Likewise.
1350         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1351         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1352
1353 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1356         UNOP_KIND.
1357         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1358         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1359         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1360         (operator_length_f): New fuction.
1361         (print_subexp_f): New function.
1362         (op_name_f): New function.
1363         (dump_subexp_body_f): New function.
1364         (operator_check_f): New function.
1365         (exp_descriptor_f): Replace standard expression handling functions
1366         with new functions.
1367         * gdb/fortran-operator.def: New file.
1368         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1369         * gdb/std-operator.def: Remove UNOP_KIND.
1370
1371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * std-operator.def: Remove unbalanced, stray double quote
1374         character.
1375
1376 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1377             Chris January  <chris.january@arm.com>
1378             Daniel Everett  <daniel.everett@arm.com>
1379             Nick Forrington  <nick.forrington@arm.com>
1380             Richard Bunt  <richard.bunt@arm.com>
1381
1382         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1383         of depth when printing anonymous structs or unions.
1384         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1385         Don't print either the top-level value, or the children if the
1386         max-depth is exceeded.
1387         (ppscm_print_children): When printing the key of a map, allow one
1388         extra level of depth.
1389         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1390         print either the top-level value, or the children if the max-depth
1391         is exceeded.
1392         (print_children): When printing the key of a map, allow one extra
1393         level of depth.
1394         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1395         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1396         (user_print_options): Initialise max_depth field.
1397         (val_print_scalar_or_string_type_p): New function.
1398         (val_print): Check to see if the max depth has been reached.
1399         (val_print_check_max_depth): Define new function.
1400         (show_print_max_depth): New function.
1401         (_initialize_valprint): Add 'print max-depth' option.
1402         * valprint.h (struct value_print_options) <max_depth>: New field.
1403         (val_print_check_max_depth): Declare new function.
1404         * NEWS: Document new feature.
1405
1406 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * ada-lang.c (ada_language_defn): Initialise new field.
1409         * c-lang.c (c_is_string_type_p): New function.
1410         (c_language_defn): Initialise new field.
1411         (cplus_language_defn): Initialise new field.
1412         (asm_language_defn): Initialise new field.
1413         (minimal_language_defn): Initialise new field.
1414         * c-lang.h (c_is_string_type_p): Declare new function.
1415         * d-lang.c (d_language_defn): Initialise new field.
1416         * f-lang.c (f_is_string_type_p): New function.
1417         (f_language_defn): Initialise new field.
1418         * go-lang.c (go_is_string_type_p): New function.
1419         (go_language_defn): Initialise new field.
1420         * language.c (default_is_string_type_p): New function.
1421         (unknown_language_defn): Initialise new field.
1422         (auto_language_defn): Initialise new field.
1423         * language.h (struct language_defn) <la_is_string_type_p>: New
1424         member variable.
1425         (default_is_string_type_p): Declare new function.
1426         * m2-lang.c (m2_language_defn): Initialise new field.
1427         * objc-lang.c (objc_language_defn): Initialise new field.
1428         * opencl-lang.c (opencl_language_defn): Initialise new field.
1429         * p-lang.c (pascal_is_string_type_p): New function.
1430         (pascal_language_defn): Initialise new field.
1431         * rust-lang.c (rust_is_string_type_p): New function.
1432         (rust_language_defn): Initialise new field.
1433
1434 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1435
1436         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1437         New field.
1438         * ada-lang.c (ada_language_defn): Initialise new field.
1439         * c-lang.c (c_language_defn): Likewise.
1440         (cplus_language_defn): Likewise.
1441         (asm_language_defn): Likewise.
1442         (minimal_language_defn): Likewise.
1443         * d-lang.c (d_language_defn): Likewise.
1444         * f-lang.c (f_language_defn): Likewise.
1445         * go-lang.c (go_language_defn): Likewise.
1446         * language.c (unknown_language_defn): Likewise.
1447         (auto_language_defn): Likewise.
1448         * m2-lang.c (m2_language_defn): Likewise.
1449         * objc-lang.c (objc_language_defn): Likewise.
1450         * opencl-lang.c (opencl_language_defn): Likewise.
1451         * p-lang.c (pascal_language_defn): Likewise.
1452         * rust-lang.c (rust_language_defn): Likewise.
1453
1454 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1455
1456         * ada-lang.c (ada_is_character_type): Change return type to bool.
1457         (ada_is_string_type): Likewise.
1458         * ada-lang.h (ada_is_character_type): Update declaration
1459         (ada_is_string_type): Likewise.
1460
1461 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1462
1463         Support style in 'frame|thread apply'
1464
1465         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1466         * record.c (record_start, record_stop): Update callers of
1467         execute_command_to_string with false.
1468         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1469         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1470         methods.
1471         (class string_file): New constructor with term_out parameter.
1472         Override methods term_out and can_emit_style_escape.  New member
1473         term_out.
1474         (class stdio_file): Override can_emit_style_escape.
1475         (class tee_file): Override term_out and can_emit_style_escape.
1476         * utils.h (can_emit_style_escape): Remove.
1477         * utils.c (can_emit_style_escape): Likewise.
1478         Update all callers of can_emit_style_escape (SOMESTREAM) to
1479         SOMESTREAM->can_emit_style_escape.
1480         * source-cache.c (source_cache::get_source_lines): Likewise.
1481         * stack.c (frame_apply_command_count): Call execute_command_to_string
1482         passing the term_out characteristic of the current gdb_stdout.
1483         * thread.c (thr_try_catch_cmd): Likewise.
1484         * top.c (execute_command_to_string): pass term_out parameter
1485         to construct the string_file for the command output.
1486         * ui-file.c (term_cli_styling): New function (most code moved
1487         from utils.c can_emit_style_escape).
1488         (string_file::string_file, string_file::can_emit_style_escape,
1489         stdio_file::can_emit_style_escape, tee_file::term_out,
1490         tee_file::can_emit_style_escape): New functions.
1491
1492 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1493
1494         * NEWS: Mention the new set|show may-call-functions.
1495         * infcall.c (may_call_functions_p): New variable.
1496         (show_may_call_functions_p): New function.
1497         (call_function_by_hand_dummy): Throws an error if not
1498         may-call-functions.
1499         (_initialize_infcall): Call add_setshow_boolean_cmd for
1500         may-call-functions.
1501
1502 2019-04-25  Keith Seitz  <keiths@redhat.com>
1503
1504         PR c++/24367
1505         * cp-support.c (inspect_type): Don't attempt substitutions
1506         of symbol with the same name.
1507
1508 2019-04-25  Tom Tromey  <tromey@adacore.com>
1509
1510         PR gdb/24475:
1511         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1512         static.
1513
1514 2019-04-25  Tom Tromey  <tromey@adacore.com>
1515
1516         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1517         rvalue reference.
1518         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1519         (gdb_xml_parser::parse): Use std::move.
1520         * python/python-internal.h (gdbpy_convert_exception): Take a const
1521         reference.
1522         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1523         std::move.
1524         * python/py-utils.c (gdbpy_convert_exception): Take a const
1525         reference.
1526         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1527         Use std::move.
1528         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1529         Use std::move.
1530         * mi/mi-main.c (mi_print_exception): Take a const reference.
1531         * main.c (handle_command_errors): Take a const reference.
1532         * linespec.c (parse_linespec): Use std::move.
1533         * infcall.c (run_inferior_call): Use std::move.
1534         (call_function_by_hand_dummy): Use std::move.
1535         * exec.c (try_open_exec_file): Use std::move.
1536         * exceptions.h (exception_print, exception_fprintf)
1537         (exception_print_same): Update.
1538         * exceptions.c (print_exception, exception_print)
1539         (exception_fprintf, exception_print_same): Change parameters to
1540         const reference.
1541         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1542         * common/new-op.c: Use std::move.
1543         * common/common-exceptions.h (struct gdb_exception): Add move
1544         constructor.
1545         (struct gdb_exception_error, struct gdb_exception_quit, struct
1546         gdb_quit_bad_alloc): Change constructor to move constructor.
1547         (throw_exception): Change parameter to rvalue reference.
1548         * common/common-exceptions.c (throw_exception): Take rvalue
1549         reference.
1550         * cli/cli-interp.c (safe_execute_command): Use std::move.
1551         * breakpoint.c (insert_bp_location, location_to_sals): Use
1552         std::move.
1553
1554 2019-04-25  Tom Tromey  <tromey@adacore.com>
1555
1556         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1557         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1558         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1559         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1560         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1561         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1562         guile/scm-value.c: Use unpack.
1563         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1564         gdbscm_gdb_exception.
1565         (gdbscm_throw_gdb_exception): Likewise.
1566         (struct gdbscm_gdb_exception): New.
1567         (unpack): New function.
1568         (gdbscm_wrap): Use unpack.
1569
1570 2019-04-25  Tom Tromey  <tromey@adacore.com>
1571
1572         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1573         (gdb_rl_callback_handler): Use std::move.
1574         * common/common-exceptions.h (struct gdb_exception): Add move
1575         assignment operator.
1576         (throw_exception_sjlj): Change "exception" to const reference.
1577         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1578         (throw_exception_sjlj): Change "exception" to const reference.
1579
1580 2019-04-25  Tom Tromey  <tromey@adacore.com>
1581
1582         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1583         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1584         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1585         Update.
1586         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1587         Update.
1588         * mi/mi-interp.c (mi_interp::exec): Update.
1589         * linespec.c (parse_linespec): Update.
1590         * infcall.c (run_inferior_call): Update.
1591         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1592         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1593         (gdbscm_lookup_global_symbol): Update.
1594         * guile/scm-param.c (gdbscm_parameter_value): Update.
1595         * guile/scm-frame.c (gdbscm_frame_read_register)
1596         (gdbscm_frame_read_var): Update.
1597         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1598         * exec.c (try_open_exec_file): Update.
1599         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1600         (gdb_rl_callback_handler): Update.
1601         * common/common-exceptions.h (exception_none): Don't declare.
1602         * common/common-exceptions.c (exception_none): Don't define.
1603         (struct catcher) <exception>: Update.
1604         * cli/cli-interp.c (safe_execute_command): Update.
1605         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1606
1607 2019-04-25  Ali Tamur  <tamur@google.com>
1608
1609         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1610         (read_attribute_value): Likewise.
1611         (dwarf2_read_addr_index): Update comment.
1612         (read_str_index): Add DW_FORM_strx.
1613         (dwarf2_string_attr): Likewise.
1614         (dwarf2_const_value_attr): Likewise.
1615         (dump_die_shallow): Likewise.
1616         (dwarf2_fetch_constant_bytes): Likewise.
1617         (skip_form_bytes): Likewise.
1618         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1619
1620 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1621
1622         PR corefiles/11608
1623         PR corefiles/18187
1624         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1625         OFFSET.  Verify if current mapping contains an ELF header.
1626         (linux_find_memory_regions_full): Adjust call to
1627         dump_mapping_p.
1628
1629 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1630             Kang Li <kanglictf@gmail.com>
1631
1632         PR gdb/21600
1633
1634         * dwarf2-frame.c (read_initial_length): Be consistent about using
1635         unsigned representation of length.
1636         (decode_frame_entry_1): Likewise.  Check for wraparound of
1637         end pointer as well as buffer overflow.
1638
1639 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1640
1641         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1642         "vq".
1643
1644 2019-04-24  Tom Tromey  <tromey@adacore.com>
1645
1646         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1647
1648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * s12z-tdep.c (s12z_unwind_pc): Delete.
1651         (s12z_unwind_sp): Delete.
1652         (s12z_gdbarch_init): Don't register deleted functions with
1653         gdbarch.
1654
1655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1656
1657         * rl78-tdep.c (rl78_unwind_sp): Delete.
1658         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1659
1660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1663         (xstormy16_unwind_pc): Delete.
1664         (xstormy16_dummy_id): Delete.
1665         (xstormy16_gdbarch_init): Don't register deleted functions with
1666         gdbarch.
1667
1668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * vax-tdep.c (vax_unwind_pc): Delete.
1671         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1672
1673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1674
1675         * v850-tdep.c (v850_unwind_sp): Delete.
1676         (v850_unwind_pc): Delete.
1677         (v850_dummy_id): Delete.
1678         (v850_gdbarch_init): Don't register deleted functions with
1679         gdbarch.
1680
1681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1684         (tilegx_unwind_pc): Delete.
1685         (tilegx_unwind_dummy_id): Delete.
1686         (tilegx_gdbarch_init): Don't register deleted functions with
1687         gdbarch.
1688
1689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1690
1691         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1692         (tic6x_dummy_id): Delete.
1693         (tic6x_gdbarch_init): Don't register deleted functions with
1694         gdbarch.
1695
1696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1697
1698         * sparc-tdep.c (sparc_unwind_pc): Delete.
1699         (sparc32_gdbarch_init): Don't register deleted function with
1700         gdbarch.
1701
1702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1703
1704         * sh-tdep.c (sh_unwind_sp): Delete.
1705         (sh_unwind_pc): Delete.
1706         (sh_dummy_id): Delete.
1707         (sh_gdbarch_init): Don't register deleted functions with
1708         gdbarch.
1709
1710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * score-tdep.c (score_unwind_sp): Delete.
1713         (score_unwind_pc): Delete.
1714         (score_dummy_id): Delete.
1715         (score_gdbarch_init): Don't register deleted functions with
1716         gdbarch.
1717
1718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * rx-tdep.c (rx_unwind_pc): Delete.
1721         (rx_unwind_sp): Delete.
1722         (rx_dummy_id): Delete.
1723         (rx_gdbarch_init): Don't register deleted functions with
1724         gdbarch.  Update comment.
1725
1726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1729         (rs6000_dummy_id): Delete.
1730         (rs6000_gdbarch_init): Don't register deleted functions with
1731         gdbarch.
1732
1733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1734
1735         * or1k-tdep.c (or1k_dummy_id): Delete.
1736         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1737
1738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * nios2-tdep.c (nios2_dummy_id): Delete.
1741         (nios2_unwind_sp): Delete.
1742         (nios2_gdbarch_init): Don't register deleted functions with
1743         gdbarch.
1744
1745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1746
1747         * nds32-tdep.c (nds32_dummy_id): Delete.
1748         (nds32_unwind_pc): Delete.
1749         (nds32_unwind_sp): Delete.
1750         (nds32_gdbarch_init): Don't register deleted functions with
1751         gdbarch.
1752
1753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * msp430-tdep.c (msp430_unwind_pc): Delete.
1756         (msp430_unwind_sp): Delete.
1757         (msp430_dummy_id): Delete.
1758         (msp430_gdbarch_init): Don't register deleted functions with
1759         gdbarch.
1760
1761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * moxie-tdep.c (moxie_unwind_sp): Delete.
1764         (moxie_unwind_pc): Delete.
1765         (moxie_dummy_id): Delete.
1766         (moxie_gdbarch_init): Don't register deleted functions with
1767         gdbarch.
1768
1769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1772         (mn10300_unwind_pc): Delete.
1773         (mn10300_unwind_sp): Delete.
1774         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1775         mn10300_unwind_sp.
1776         (mn10300_frame_unwind_init): Don't register deleted functions with
1777         gdbarch.
1778
1779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * mep-tdep.c (mep_unwind_pc): Delete.
1782         (mep_unwind_sp): Delete.
1783         (mep_dummy_id): Delete.
1784         (mep_gdbarch_init): Don't register deleted functions with
1785         gdbarch.
1786
1787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1790         (m68hc11_unwind_sp): Delete.
1791         (m68hc11_gdbarch_init): Don't register deleted functions with
1792         gdbarch.
1793
1794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * m32r-tdep.c (m32r_unwind_sp): Delete.
1797         (m32r_unwind_pc): Delete.
1798         (m32r_dummy_id): Delete.
1799         (m32r_gdbarch_init): Don't register deleted functions with
1800         gdbarch.
1801
1802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * m32c-tdep.c (m32c_unwind_pc): Delete.
1805         (m32c_unwind_sp): Delete.
1806         (m32c_dummy_id): Delete.
1807         (m32c_gdbarch_init): Don't register deleted functions with
1808         gdbarch.
1809
1810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1813         (lm32_unwind_pc): Delete.
1814         (lm32_dummy_id): Delete.
1815         (lm32_gdbarch_init): Don't register deleted functions with
1816         gdbarch.
1817
1818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1819
1820         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1821         (iq2000_unwind_pc): Delete.
1822         (iq2000_dummy_id): Delete.
1823         (iq2000_gdbarch_init): Don't register deleted functions with
1824         gdbarch.
1825
1826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1827
1828         * nds32-tdep.c (nds32_type_align): Delete.
1829         (nds32_push_dummy_call): Use type_align instead.
1830
1831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * arm-tdep.c (arm_type_align): Only handle vector override case.
1834         (arm_push_dummy_call): Use type_align.
1835         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1836
1837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1838
1839         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1840         case.
1841         (pass_on_stack): Use type_align.
1842         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1843         function.
1844
1845 2019-04-23  Tom Tromey  <tromey@adacore.com>
1846
1847         * dwarf2read.c (line_header::file_name_at): Remove unused
1848         overload.
1849
1850 2019-04-23  Tom de Vries  <tdevries@suse.de>
1851
1852         PR gdb/24438
1853         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1854         invocation.
1855
1856
1857 2019-03-27  Ali Tamur  <tamur@google.com>
1858
1859         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1860         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1861         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1862         (dwarf_expr_context::get_addr_index): Likewise
1863         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1864         (symbol_needs_eval_context::get_addr_index): Likewise
1865         (disassemble_dwarf_expression): Add DW_OP_addrx
1866         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1867         (read_cutu_die_from_dwo): Update comment
1868         (skip_one_die): Add DW_FORM_addrx
1869         (read_attribute_value): Likewise
1870         (var_decode_location): Add DW_OP_addrx
1871         (dwarf2_const_value_attr): Add DW_FORM_addrx
1872         (dump_die_shallow): Likewise
1873         (dwarf2_fetch_constant_bytes): Likewise
1874         (decode_locdesc): Add DW_OP_addrx
1875         (skip_form_bytes): Add DW_FORM_addrx
1876
1877 2019-04-22  Ali Tamur  <tamur@google.com>
1878
1879         * MAINTAINERS (Write After Approval): Add self.
1880
1881 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1882
1883         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1884         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1885         (open_symbol_file_object): Likewise.
1886         (svr4_default_sos): Add info parameter.
1887         (svr4_read_so_list): Likewise.
1888         (svr4_current_sos_direct): Adjust functions calls to pass down
1889         info.
1890         (svr4_current_sos_1): Add info parameter.
1891         (svr4_current_sos): Call get_svr4_info, pass info down to
1892         svr4_current_sos_1.
1893         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1894         get_svr4_info.
1895         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1896         get_svr4_info.
1897         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1898         to get_svr4_info.
1899         (probes_table_remove_objfile_probes): Likewise.
1900         (register_solib_event_probe): Add info parameter.
1901         (solist_update_incremental): Pass info parameter down to
1902         svr4_read_so_list.
1903         (disable_probes_interface): Add info parameter.
1904         (svr4_handle_solib_event): Pass current_program_space to
1905         get_svr4_info.  Adjust disable_probes_interface cleanup.
1906         (svr4_create_probe_breakpoints): Add info parameter, pass it
1907         down to register_solib_event_probe.
1908         (svr4_create_solib_event_breakpoints): Add info parameter,
1909         pass it down to svr4_create_probe_breakpoints.
1910         (enable_break): Pass info down to
1911         svr4_create_solib_event_breakpoints.
1912         (svr4_solib_create_inferior_hook): Pass current_program_space to
1913         get_svr4_info.
1914         (svr4_clear_solib): Likewise.
1915
1916 2019-04-22  Pedro Alves  <palves@redhat.com>
1917
1918         * solib-svr4.c (svr4_free_objfile_observer): New.
1919         (probe_and_action::objfile): New field.
1920         (probes_table_htab_remove_objfile_probes)
1921         (probes_table_remove_objfile_probes): New functions.
1922         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1923         in the new probe_and_action.  Don't store the probe in 'lookup'.
1924         (svr4_create_probe_breakpoints): Pass objfile to
1925         register_solib_event_probe.
1926         (_initialize_svr4_solib): Register a free_objfile observer.
1927
1928 2019-04-19  Tom Tromey  <tom@tromey.com>
1929
1930         * common/queue.h: Remove.
1931
1932 2019-04-19  Tom Tromey  <tom@tromey.com>
1933
1934         * event-loop.c: Don't include "common/queue.h".
1935
1936 2019-04-19  Tom Tromey  <tom@tromey.com>
1937
1938         * remote.c (remote_target): Use delete.
1939         * remote-notif.h: Include <list>, not "common/queue.h".
1940         (notif_client_p): Remove typedef.
1941         (remote_notif_state): Add constructor, destructor, initializer.
1942         <notif_queue>: Now a std::list.
1943         (remote_notif_state_xfree): Don't declare.
1944         * remote-notif.c (remote_notif_process, handle_notification)
1945         (remote_notif_state_allocate): Update.
1946         (~remote_notif_state): Rename from remote_notif_state_xfree.
1947
1948 2019-04-19  Tom Tromey  <tom@tromey.com>
1949
1950         * symfile.c (reread_symbols): Update.
1951         * objfiles.c (objfile_register_static_link)
1952         (objfile_lookup_static_link): Update
1953         (~objfile) Don't delete static_links.
1954         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1955
1956 2019-04-19  Tom Tromey  <tom@tromey.com>
1957
1958         * type-stack.h (struct type_stack) <insert>: Constify string.
1959         * type-stack.c (type_stack::insert): Constify string.
1960         * gdbtypes.h (lookup_template_type): Update.
1961         (address_space_name_to_int): Update.
1962         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1963         const.
1964         (lookup_template_type): Make name const.
1965         * c-exp.y: Update rules.
1966         (lex_one_token, classify_name, classify_inner_name)
1967         (c_print_token): Update.
1968         * p-exp.y: Update rules.
1969         (yylex): Update.
1970         * f-exp.y: Update rules.
1971         (yylex): Update.
1972         * d-exp.y: Update rules.
1973         (lex_one_token, classify_name, classify_inner_name): Update.
1974         * parse.c (write_dollar_variable, copy_name): Return std::string.
1975         * parser-defs.h (copy_name): Change return type.
1976         * m2-exp.y: Update rules.
1977         (yylex): Update.
1978         * go-exp.y (lex_one_token): Update.
1979         Update rules.
1980         (classify_unsafe_function, classify_packaged_name)
1981         (classify_name, yylex): Update.
1982
1983 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1984
1985         * configure.ac: add --enable-source-highlight switch.
1986         * configure: Regenerate.
1987         * top.c (print_gdb_version): plumb --enable-source-highlight
1988         status to "show configuration".
1989
1990 2019-04-19  Tom Tromey  <tromey@adacore.com>
1991
1992         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1993         Check ADA_TYPE_P.
1994         (empty_record, ada_template_to_fixed_record_type_1)
1995         (template_to_static_fixed_type)
1996         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1997         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1998         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1999         macros.
2000
2001 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2002
2003         PR symtab/24423:
2004         * source.c (print_source_lines_base): Advance "iter" when a
2005         control character is seen.
2006
2007 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2008
2009         * inferior.h (struct infcall_suspend_state_deleter):
2010         Catch exception in destructor to avoid crash.
2011
2012 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2013
2014         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2015         close to the add_com "shell".
2016
2017 2019-04-18  Tom Tromey  <tromey@adacore.com>
2018
2019         * process-stratum-target.h (class process_stratum_target)
2020         <stratum>: Add "final".
2021
2022 2019-04-17  Tom Tromey  <tromey@adacore.com>
2023
2024         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2025         against nullptr before use.
2026
2027 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2028
2029         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2030
2031 2019-04-17  Jim Wilson  <jimw@sifive.com>
2032             Andrew Burgess  <andrew.burgess@embecosm.com>
2033
2034         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2035         code read might fail, assume 4-byte breakpoint in that case.
2036
2037 2019-04-15  Leszek Swirski  <leszeks@google.com>
2038
2039         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2040         rather than a hand-rolled POD check when checking for forced MEMORY
2041         classification.
2042
2043 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2044
2045         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2046         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2047         function.
2048         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2049         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2050         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2051         declaration.
2052
2053 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2054
2055         * aarch64-linux-nat.c
2056         (aarch64_linux_nat_target::thread_architecture): Add override.
2057         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2058         each VQ.
2059
2060 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2061
2062         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2063
2064 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2065
2066         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2067         target types of size 96-bits, add some additional comments, and
2068         check that the builtin type we found was the correct size.
2069
2070 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2071
2072         * utils.c (prompt_for_continue): Don't restore the styling at the
2073         end, as applied_style has the wrong value.  This fixes styling in
2074         long lists of file names that are interrupted by the "Continue?"
2075         prompt.
2076
2077 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2078
2079         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2080         * c-lang.c (c_language_defn): Likewise.
2081         (cplus_language_defn): Likewise.
2082         (asm_language_defn): Likewise.
2083         (minimal_language_defn): Likewise.
2084         * d-lang.c (d_language_defn): Likewise.
2085         * f-lang.c (f_language_defn): Likewise.
2086         * go-lang.c (go_language_defn): Likewise.
2087         * language.c (unknown_language_defn): Likewise.
2088         (auto_language_defn): Likewise.
2089         * language.h (struct language_defn): Remove la_magic field.
2090         (LANG_MAGIC): Delete.
2091         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2092         * objc-lang.c (objc_language_defn): Likewise.
2093         * opencl-lang.c (opencl_language_defn): Likewise.
2094         * p-lang.c (pascal_language_defn): Likewise.
2095         * rust-lang.c (rust_language_defn): Likewise.
2096
2097 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2098
2099         * riscv-tdep.c (riscv_type_align): New function.
2100         (riscv_type_alignment): Delete.
2101         (riscv_arg_location): Use 'type_align'.
2102         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2103
2104 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * gdbtypes.c (type_align): A struct with no non-static fields also
2107         has alignment of 1.
2108
2109 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2112         component to 0.
2113         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2114         member.
2115         (riscv_struct_info::analyse): New implementation using new
2116         analyse_inner member function.
2117         (riscv_struct_info::field_offset): New member function.
2118         (riscv_struct_info::m_offsets): New member variable.
2119         (riscv_struct_info::analyse_inner): New private member function,
2120         takes the old implementation of riscv_struct_info::analyse but
2121         extended to track field offsets.
2122         (riscv_call_arg_struct): Update the struct folding special cases
2123         to handle cases where empty C++ structs, which are non-zero
2124         length, are found.
2125         (riscv_arg_location): Initialise the length of each location, a
2126         non-zero length now indicates the location is in use.
2127         (riscv_push_dummy_call): Allow for the first location having a
2128         non-zero offset when setting up arguments.
2129         (riscv_return_value): Likewise, but for return values.
2130
2131 2019-04-11  Tom Tromey  <tromey@adacore.com>
2132
2133         * utils.c (internal_vproblem): Make "msg" const.
2134
2135 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2136
2137         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2138         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2139         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2140         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2141
2142 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2143
2144         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2145         function.
2146         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2147         of amd64_collect_native_gregset.
2148         (amd64_linux_nat_target::store_registers): Likewise.
2149
2150 2019-04-10  Tom Tromey  <tom@tromey.com>
2151
2152         * symtab.c (lookup_global_symbol_from_objfile)
2153         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2154         * objfiles.h (class separate_debug_iterator): New.
2155         (class separate_debug_range): New.
2156         (struct objfile) <separate_debug_objfiles>: New method.
2157         (objfile_separate_debug_iterate): Don't declare.
2158         * objfiles.c (separate_debug_iterator::operator++): Rename from
2159         objfile_separate_debug_iterate.
2160         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2161         iterator.
2162         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2163         iterator.
2164
2165 2019-04-10  Tom Tromey  <tom@tromey.com>
2166
2167         * symfile.c (reread_symbols): Remove old comment.
2168         * objfiles.c (free_all_objfiles): Fix a typo.
2169
2170 2019-04-10  Tom Tromey  <tom@tromey.com>
2171
2172         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2173         * minsyms.c (lookup_minimal_symbol): Use foreach.
2174         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2175         (lookup_minimal_symbol_solib_trampoline): Likewise.
2176         * symfile.c (reread_symbols): Use foreach.
2177
2178 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2179             Tom Tromey  <tromey@adacore.com>
2180
2181         PR rust/24414:
2182         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2183         (rust_lex_int_test): Change "value" to be LONGEST.
2184         (rust_lex_tests): Add test for long integer literal.
2185
2186 2019-04-09  Tom Tromey  <tromey@adacore.com>
2187
2188         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2189         to bool.
2190         (extended_remote_target::attach): Update.
2191         (remote_target::remote_notice_new_inferior): Update.
2192         (remote_target::add_current_inferior_and_thread): Update.
2193         * inferior.c (exit_inferior_1): Use "false".
2194         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2195
2196 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2197
2198         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2199         the "start" command.
2200
2201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2202
2203         * python/py-inferior.c (infpy_thread_from_thread_handle):
2204         Adjust comments to reflect renaming of thread_from_thread_handle
2205         to thread_from_handle.  Adjust keywords.  Fix type error message.
2206         (inferior_object_methods): Add thread_from_handle.  Retain
2207         thread_from_thread_handle, but mark it as deprecated.
2208
2209 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2210
2211         * gdbthread.h (find_thread_by_handle): Revise declaration.
2212         * thread.c (find_thread_by_handle): Likewise.  Adjust
2213         implementation too.
2214         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2215         support for buffer objects as handles.
2216
2217 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2218
2219         * python/py-infthread.c (thpy_thread_handle): New function.
2220         (thread_object_methods): Register thpy_thread_handle.
2221
2222 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2223
2224         * gdbthread.h (thread_to_thread_handle): Declare.
2225         * thread.c (gdbtypes.h): Include.
2226         (thread_to_thread_handle): New function.
2227
2228         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2229         (target_thread_info_to_thread_handle): Declare.
2230         * target.c (target_thread_info_to_thread_handle): New function.
2231         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2232         * target-delegates.c: Regenerate.
2233
2234         * linux-thread-db.c (class thread_db_target): Add method
2235         thread_info_to_thread_handle.
2236         (thread_db_target::thread_info_to_thread_handle): Define.
2237         * remote.c (class remote_target): Add new method
2238         thread_info_to_thread_handle.
2239         (remote_target::thread_info_to_thread_handle): Define.
2240
2241 2019-04-08  Pedro Alves  <palves@redhat.com>
2242
2243         * common/common-exceptions.c (throw_exception): Don't create
2244         named object to throw; throw directly.
2245         (throw_it): Likewise.  Don't initialize gdb_exception::message
2246         here, with new; pass FMT and AP to the ctor instead.
2247         * common/common-exceptions.h: Include <string>.
2248         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2249         const char *, va_list)): New ctor.  Use std::make_shared.
2250         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2251         errors)): Delete.
2252         (gdb_exception_error::gdb_exception_error(enum errors, const char
2253         *, va_list)): New.
2254         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2255         Add assertion.
2256         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2257         errors)): Delete.
2258         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2259         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2260         Add assertion.
2261
2262 2019-04-08  Tom Tromey  <tom@tromey.com>
2263
2264         * valops.c (value_rtti_indirect_type): Replace throw_exception
2265         with throw.
2266         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2267         with throw.
2268         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2269         throw.
2270         * target.c (target_translate_tls_address): Replace throw_exception
2271         with throw.
2272         * stack.c (frame_apply_command_count): Replace throw_exception
2273         with throw.
2274         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2275         throw.
2276         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2277         with throw.
2278         * rs6000-tdep.c (rs6000_frame_cache)
2279         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2280         * remote.c: Replace throw_exception with throw.
2281         * record-full.c (record_full_message, record_full_wait_1)
2282         (record_full_restore): Replace throw_exception with throw.
2283         * record-btrace.c:
2284         (get_thread_current_frame_id, record_btrace_start_replaying)
2285         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2286         (cmd_record_btrace_start): Replace throw_exception with throw.
2287         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2288         throw.
2289         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2290         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2291         * linespec.c:
2292         (find_linespec_symbols): Replace throw_exception with throw.
2293         * infrun.c (displaced_step_prepare, resume): Replace
2294         throw_exception with throw.
2295         * infcmd.c (post_create_inferior): Replace throw_exception with
2296         throw.
2297         * inf-loop.c (inferior_event_handler): Replace throw_exception
2298         with throw.
2299         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2300         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2301         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2302         (get_prev_frame_always, get_frame_pc_if_available)
2303         (get_frame_address_in_block_if_available, get_frame_language):
2304         Replace throw_exception with throw.
2305         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2306         throw_exception with throw.
2307         * eval.c (fetch_subexp_value, evaluate_var_value)
2308         (evaluate_funcall, evaluate_subexp_standard): Replace
2309         throw_exception with throw.
2310         * dwarf2loc.c (call_site_find_chain)
2311         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2312         Replace throw_exception with throw.
2313         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2314         with throw.
2315         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2316         throw.
2317         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2318         * completer.c (complete_line_internal): Replace throw_exception
2319         with throw.
2320         * compile/compile-object-run.c (compile_object_run): Replace
2321         throw_exception with throw.
2322         * cli/cli-script.c (process_next_line): Replace throw_exception
2323         with throw.
2324         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2325         (btrace_enable, btrace_maint_update_pt_packets): Replace
2326         throw_exception with throw.
2327         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2328         throw_exception with throw.
2329         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2330         throw_exception with throw.
2331         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2332         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2333         * aarch64-tdep.c (aarch64_make_prologue_cache)
2334         (aarch64_make_stub_cache): Replace throw_exception with throw.
2335
2336 2019-04-08  Tom Tromey  <tom@tromey.com>
2337
2338         * common/common-exceptions.c (throw_exception): Rename from
2339         throw_exception_cxx.  Remove old copy.  Make argument const.
2340         (throw_it): Create and throw exception objects directly.
2341         * common/common-exceptions.h (throw_exception): Make argument
2342         const.
2343         (struct gdb_exception_error): Add constructor.
2344         (struct gdb_exception_quit): Add constructor.
2345
2346 2019-04-08  Tom Tromey  <tom@tromey.com>
2347
2348         * common/common-exceptions.h (exception_rethrow): Don't declare.
2349         (TRY_SJLJ): Update comment.
2350         (TRY, CATCH, END_CATCH): Remove.
2351         * common/common-exceptions.c (exception_rethrow): Remove.
2352
2353 2019-04-08  Tom Tromey  <tom@tromey.com>
2354
2355         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2356         Remove.
2357         (gdb_exception_error): Rename from
2358         gdb_exception_RETURN_MASK_ERROR.
2359         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2360         (gdb_quit_bad_alloc): Update.
2361         * aarch64-tdep.c: Update.
2362         * ada-lang.c: Update.
2363         * ada-typeprint.c: Update.
2364         * ada-valprint.c: Update.
2365         * amd64-tdep.c: Update.
2366         * arch-utils.c: Update.
2367         * break-catch-throw.c: Update.
2368         * breakpoint.c: Update.
2369         * btrace.c: Update.
2370         * c-varobj.c: Update.
2371         * cli/cli-cmds.c: Update.
2372         * cli/cli-interp.c: Update.
2373         * cli/cli-script.c: Update.
2374         * common/common-exceptions.c: Update.
2375         * common/new-op.c: Update.
2376         * common/selftest.c: Update.
2377         * compile/compile-c-symbols.c: Update.
2378         * compile/compile-cplus-symbols.c: Update.
2379         * compile/compile-object-load.c: Update.
2380         * compile/compile-object-run.c: Update.
2381         * completer.c: Update.
2382         * corelow.c: Update.
2383         * cp-abi.c: Update.
2384         * cp-support.c: Update.
2385         * cp-valprint.c: Update.
2386         * darwin-nat.c: Update.
2387         * disasm-selftests.c: Update.
2388         * dtrace-probe.c: Update.
2389         * dwarf-index-cache.c: Update.
2390         * dwarf-index-write.c: Update.
2391         * dwarf2-frame-tailcall.c: Update.
2392         * dwarf2-frame.c: Update.
2393         * dwarf2loc.c: Update.
2394         * dwarf2read.c: Update.
2395         * eval.c: Update.
2396         * event-loop.c: Update.
2397         * event-top.c: Update.
2398         * exec.c: Update.
2399         * f-valprint.c: Update.
2400         * fbsd-tdep.c: Update.
2401         * frame-unwind.c: Update.
2402         * frame.c: Update.
2403         * gdbtypes.c: Update.
2404         * gnu-v3-abi.c: Update.
2405         * guile/guile-internal.h: Update.
2406         * guile/scm-block.c: Update.
2407         * guile/scm-breakpoint.c: Update.
2408         * guile/scm-cmd.c: Update.
2409         * guile/scm-disasm.c: Update.
2410         * guile/scm-frame.c: Update.
2411         * guile/scm-lazy-string.c: Update.
2412         * guile/scm-math.c: Update.
2413         * guile/scm-param.c: Update.
2414         * guile/scm-ports.c: Update.
2415         * guile/scm-pretty-print.c: Update.
2416         * guile/scm-symbol.c: Update.
2417         * guile/scm-symtab.c: Update.
2418         * guile/scm-type.c: Update.
2419         * guile/scm-value.c: Update.
2420         * i386-linux-tdep.c: Update.
2421         * i386-tdep.c: Update.
2422         * inf-loop.c: Update.
2423         * infcall.c: Update.
2424         * infcmd.c: Update.
2425         * infrun.c: Update.
2426         * jit.c: Update.
2427         * language.c: Update.
2428         * linespec.c: Update.
2429         * linux-fork.c: Update.
2430         * linux-nat.c: Update.
2431         * linux-tdep.c: Update.
2432         * linux-thread-db.c: Update.
2433         * main.c: Update.
2434         * mi/mi-cmd-break.c: Update.
2435         * mi/mi-cmd-stack.c: Update.
2436         * mi/mi-interp.c: Update.
2437         * mi/mi-main.c: Update.
2438         * objc-lang.c: Update.
2439         * p-valprint.c: Update.
2440         * parse.c: Update.
2441         * ppc-linux-tdep.c: Update.
2442         * printcmd.c: Update.
2443         * python/py-arch.c: Update.
2444         * python/py-breakpoint.c: Update.
2445         * python/py-cmd.c: Update.
2446         * python/py-finishbreakpoint.c: Update.
2447         * python/py-frame.c: Update.
2448         * python/py-framefilter.c: Update.
2449         * python/py-gdb-readline.c: Update.
2450         * python/py-inferior.c: Update.
2451         * python/py-infthread.c: Update.
2452         * python/py-lazy-string.c: Update.
2453         * python/py-linetable.c: Update.
2454         * python/py-objfile.c: Update.
2455         * python/py-param.c: Update.
2456         * python/py-prettyprint.c: Update.
2457         * python/py-progspace.c: Update.
2458         * python/py-record-btrace.c: Update.
2459         * python/py-record.c: Update.
2460         * python/py-symbol.c: Update.
2461         * python/py-type.c: Update.
2462         * python/py-unwind.c: Update.
2463         * python/py-utils.c: Update.
2464         * python/py-value.c: Update.
2465         * python/python.c: Update.
2466         * record-btrace.c: Update.
2467         * record-full.c: Update.
2468         * remote-fileio.c: Update.
2469         * remote.c: Update.
2470         * riscv-tdep.c: Update.
2471         * rs6000-aix-tdep.c: Update.
2472         * rs6000-tdep.c: Update.
2473         * rust-exp.y: Update.
2474         * rust-lang.c: Update.
2475         * s390-tdep.c: Update.
2476         * selftest-arch.c: Update.
2477         * solib-dsbt.c: Update.
2478         * solib-frv.c: Update.
2479         * solib-spu.c: Update.
2480         * solib-svr4.c: Update.
2481         * solib.c: Update.
2482         * sparc64-linux-tdep.c: Update.
2483         * stack.c: Update.
2484         * symfile-mem.c: Update.
2485         * symmisc.c: Update.
2486         * target.c: Update.
2487         * thread.c: Update.
2488         * top.c: Update.
2489         * tracefile-tfile.c: Update.
2490         * tui/tui.c: Update.
2491         * typeprint.c: Update.
2492         * unittests/cli-utils-selftests.c: Update.
2493         * unittests/parse-connection-spec-selftests.c: Update.
2494         * valops.c: Update.
2495         * valprint.c: Update.
2496         * value.c: Update.
2497         * varobj.c: Update.
2498         * windows-nat.c: Update.
2499         * x86-linux-nat.c: Update.
2500         * xml-support.c: Update.
2501
2502 2019-04-08  Tom Tromey  <tom@tromey.com>
2503
2504         * xml-support.c: Use C++ exception handling.
2505         * x86-linux-nat.c: Use C++ exception handling.
2506         * windows-nat.c: Use C++ exception handling.
2507         * varobj.c: Use C++ exception handling.
2508         * value.c: Use C++ exception handling.
2509         * valprint.c: Use C++ exception handling.
2510         * valops.c: Use C++ exception handling.
2511         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2512         handling.
2513         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2514         * typeprint.c: Use C++ exception handling.
2515         * tui/tui.c: Use C++ exception handling.
2516         * tracefile-tfile.c: Use C++ exception handling.
2517         * top.c: Use C++ exception handling.
2518         * thread.c: Use C++ exception handling.
2519         * target.c: Use C++ exception handling.
2520         * symmisc.c: Use C++ exception handling.
2521         * symfile-mem.c: Use C++ exception handling.
2522         * stack.c: Use C++ exception handling.
2523         * sparc64-linux-tdep.c: Use C++ exception handling.
2524         * solib.c: Use C++ exception handling.
2525         * solib-svr4.c: Use C++ exception handling.
2526         * solib-spu.c: Use C++ exception handling.
2527         * solib-frv.c: Use C++ exception handling.
2528         * solib-dsbt.c: Use C++ exception handling.
2529         * selftest-arch.c: Use C++ exception handling.
2530         * s390-tdep.c: Use C++ exception handling.
2531         * rust-lang.c: Use C++ exception handling.
2532         * rust-exp.y: Use C++ exception handling.
2533         * rs6000-tdep.c: Use C++ exception handling.
2534         * rs6000-aix-tdep.c: Use C++ exception handling.
2535         * riscv-tdep.c: Use C++ exception handling.
2536         * remote.c: Use C++ exception handling.
2537         * remote-fileio.c: Use C++ exception handling.
2538         * record-full.c: Use C++ exception handling.
2539         * record-btrace.c: Use C++ exception handling.
2540         * python/python.c: Use C++ exception handling.
2541         * python/py-value.c: Use C++ exception handling.
2542         * python/py-utils.c: Use C++ exception handling.
2543         * python/py-unwind.c: Use C++ exception handling.
2544         * python/py-type.c: Use C++ exception handling.
2545         * python/py-symbol.c: Use C++ exception handling.
2546         * python/py-record.c: Use C++ exception handling.
2547         * python/py-record-btrace.c: Use C++ exception handling.
2548         * python/py-progspace.c: Use C++ exception handling.
2549         * python/py-prettyprint.c: Use C++ exception handling.
2550         * python/py-param.c: Use C++ exception handling.
2551         * python/py-objfile.c: Use C++ exception handling.
2552         * python/py-linetable.c: Use C++ exception handling.
2553         * python/py-lazy-string.c: Use C++ exception handling.
2554         * python/py-infthread.c: Use C++ exception handling.
2555         * python/py-inferior.c: Use C++ exception handling.
2556         * python/py-gdb-readline.c: Use C++ exception handling.
2557         * python/py-framefilter.c: Use C++ exception handling.
2558         * python/py-frame.c: Use C++ exception handling.
2559         * python/py-finishbreakpoint.c: Use C++ exception handling.
2560         * python/py-cmd.c: Use C++ exception handling.
2561         * python/py-breakpoint.c: Use C++ exception handling.
2562         * python/py-arch.c: Use C++ exception handling.
2563         * printcmd.c: Use C++ exception handling.
2564         * ppc-linux-tdep.c: Use C++ exception handling.
2565         * parse.c: Use C++ exception handling.
2566         * p-valprint.c: Use C++ exception handling.
2567         * objc-lang.c: Use C++ exception handling.
2568         * mi/mi-main.c: Use C++ exception handling.
2569         * mi/mi-interp.c: Use C++ exception handling.
2570         * mi/mi-cmd-stack.c: Use C++ exception handling.
2571         * mi/mi-cmd-break.c: Use C++ exception handling.
2572         * main.c: Use C++ exception handling.
2573         * linux-thread-db.c: Use C++ exception handling.
2574         * linux-tdep.c: Use C++ exception handling.
2575         * linux-nat.c: Use C++ exception handling.
2576         * linux-fork.c: Use C++ exception handling.
2577         * linespec.c: Use C++ exception handling.
2578         * language.c: Use C++ exception handling.
2579         * jit.c: Use C++ exception handling.
2580         * infrun.c: Use C++ exception handling.
2581         * infcmd.c: Use C++ exception handling.
2582         * infcall.c: Use C++ exception handling.
2583         * inf-loop.c: Use C++ exception handling.
2584         * i386-tdep.c: Use C++ exception handling.
2585         * i386-linux-tdep.c: Use C++ exception handling.
2586         * guile/scm-value.c: Use C++ exception handling.
2587         * guile/scm-type.c: Use C++ exception handling.
2588         * guile/scm-symtab.c: Use C++ exception handling.
2589         * guile/scm-symbol.c: Use C++ exception handling.
2590         * guile/scm-pretty-print.c: Use C++ exception handling.
2591         * guile/scm-ports.c: Use C++ exception handling.
2592         * guile/scm-param.c: Use C++ exception handling.
2593         * guile/scm-math.c: Use C++ exception handling.
2594         * guile/scm-lazy-string.c: Use C++ exception handling.
2595         * guile/scm-frame.c: Use C++ exception handling.
2596         * guile/scm-disasm.c: Use C++ exception handling.
2597         * guile/scm-cmd.c: Use C++ exception handling.
2598         * guile/scm-breakpoint.c: Use C++ exception handling.
2599         * guile/scm-block.c: Use C++ exception handling.
2600         * guile/guile-internal.h: Use C++ exception handling.
2601         * gnu-v3-abi.c: Use C++ exception handling.
2602         * gdbtypes.c: Use C++ exception handling.
2603         * frame.c: Use C++ exception handling.
2604         * frame-unwind.c: Use C++ exception handling.
2605         * fbsd-tdep.c: Use C++ exception handling.
2606         * f-valprint.c: Use C++ exception handling.
2607         * exec.c: Use C++ exception handling.
2608         * event-top.c: Use C++ exception handling.
2609         * event-loop.c: Use C++ exception handling.
2610         * eval.c: Use C++ exception handling.
2611         * dwarf2read.c: Use C++ exception handling.
2612         * dwarf2loc.c: Use C++ exception handling.
2613         * dwarf2-frame.c: Use C++ exception handling.
2614         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2615         * dwarf-index-write.c: Use C++ exception handling.
2616         * dwarf-index-cache.c: Use C++ exception handling.
2617         * dtrace-probe.c: Use C++ exception handling.
2618         * disasm-selftests.c: Use C++ exception handling.
2619         * darwin-nat.c: Use C++ exception handling.
2620         * cp-valprint.c: Use C++ exception handling.
2621         * cp-support.c: Use C++ exception handling.
2622         * cp-abi.c: Use C++ exception handling.
2623         * corelow.c: Use C++ exception handling.
2624         * completer.c: Use C++ exception handling.
2625         * compile/compile-object-run.c: Use C++ exception handling.
2626         * compile/compile-object-load.c: Use C++ exception handling.
2627         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2628         * compile/compile-c-symbols.c: Use C++ exception handling.
2629         * common/selftest.c: Use C++ exception handling.
2630         * common/new-op.c: Use C++ exception handling.
2631         * cli/cli-script.c: Use C++ exception handling.
2632         * cli/cli-interp.c: Use C++ exception handling.
2633         * cli/cli-cmds.c: Use C++ exception handling.
2634         * c-varobj.c: Use C++ exception handling.
2635         * btrace.c: Use C++ exception handling.
2636         * breakpoint.c: Use C++ exception handling.
2637         * break-catch-throw.c: Use C++ exception handling.
2638         * arch-utils.c: Use C++ exception handling.
2639         * amd64-tdep.c: Use C++ exception handling.
2640         * ada-valprint.c: Use C++ exception handling.
2641         * ada-typeprint.c: Use C++ exception handling.
2642         * ada-lang.c: Use C++ exception handling.
2643         * aarch64-tdep.c: Use C++ exception handling.
2644
2645 2019-04-08  Tom Tromey  <tom@tromey.com>
2646
2647         * xml-support.c (gdb_xml_parser::parse): Update.
2648         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2649         * value.c (show_convenience): Update.
2650         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2651         (test_parse_flags_qcs): Update.
2652         * thread.c (thr_try_catch_cmd): Update.
2653         * target.c (target_translate_tls_address): Update.
2654         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2655         (info_frame_command_core, frame_apply_command_count): Update.
2656         * rust-exp.y (rust_lex_exception_test): Update.
2657         * riscv-tdep.c (riscv_print_one_register_info): Update.
2658         * remote.c (remote_target::enable_btrace): Update.
2659         * record-btrace.c (record_btrace_enable_warn): Update.
2660         * python/py-utils.c (gdbpy_convert_exception): Update.
2661         * printcmd.c (do_one_display, print_variable_and_value): Update.
2662         * mi/mi-main.c (mi_print_exception): Update.
2663         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2664         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2665         * linux-nat.c (linux_nat_target::attach): Update.
2666         * linux-fork.c (class scoped_switch_fork_info): Update.
2667         * infrun.c (displaced_step_prepare): Update.
2668         * infcall.c (call_function_by_hand_dummy): Update.
2669         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2670         * gnu-v3-abi.c (print_one_vtable): Update.
2671         * frame.c (get_prev_frame_always): Update.
2672         * f-valprint.c (info_common_command_for_block): Update.
2673         * exec.c (try_open_exec_file): Update.
2674         * exceptions.c (print_exception, exception_print)
2675         (exception_fprintf, exception_print_same): Update.
2676         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2677         * dwarf-index-cache.c (index_cache::store)
2678         (index_cache::lookup_gdb_index): Update.
2679         * darwin-nat.c (maybe_cache_shell): Update.
2680         * cp-valprint.c (cp_print_value_fields): Update.
2681         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2682         (gcc_cplus_symbol_address): Update.
2683         * compile/compile-c-symbols.c (gcc_convert_symbol)
2684         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2685         * common/selftest.c: Update.
2686         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2687         a std::string.
2688         (exception_try_scope_entry, exception_try_scope_exit): Don't
2689         declare.
2690         (struct exception_try_scope): Remove.
2691         (TRY): Don't use exception_try_scope.
2692         (struct gdb_exception): Add constructor, operator=.
2693         <what>: New method.
2694         (struct gdb_exception_RETURN_MASK_ALL)
2695         (struct gdb_exception_RETURN_MASK_ERROR)
2696         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2697         (struct gdb_quit_bad_alloc): Update.
2698         * common/common-exceptions.c (exception_none): Change
2699         initializer.
2700         (struct catcher) <state, exception>: Initialize inline.
2701         <prev>: Remove member.
2702         (current_catcher): Remove.
2703         (catchers): New global.
2704         (exceptions_state_mc_init): Simplify.
2705         (catcher_pop): Remove.
2706         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2707         (try_scope_depth, exception_try_scope_entry)
2708         (exception_try_scope_exit): Remove.
2709         (throw_exception_sjlj): Update.
2710         (exception_messages, exception_messages_size): Remove.
2711         (throw_it): Simplify.
2712         (gdb_exception_sliced_copy): Remove.
2713         (throw_exception_cxx): Update.
2714         * cli/cli-script.c (script_from_file): Update.
2715         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2716         Update.
2717         * ada-valprint.c (ada_val_print): Update.
2718         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2719         (create_excep_cond_exprs): Update.
2720
2721 2019-04-08  Tom Tromey  <tom@tromey.com>
2722
2723         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2724         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2725         (TRY, CATCH, END_CATCH): Remove some definitions.
2726         * common/common-exceptions.c: Don't use GDB_XCPT.
2727         (catcher_list_size): Remove.
2728         (throw_exception, throw_it): Simplify.
2729
2730 2019-04-05  Tom Tromey  <tom@tromey.com>
2731
2732         Revert the header-sorting patch.
2733         * ft32-tdep.c: Revert.
2734         * frv-tdep.c: Revert.
2735         * frv-linux-tdep.c: Revert.
2736         * frame.c: Revert.
2737         * frame-unwind.c: Revert.
2738         * frame-base.c: Revert.
2739         * fork-child.c: Revert.
2740         * findvar.c: Revert.
2741         * findcmd.c: Revert.
2742         * filesystem.c: Revert.
2743         * filename-seen-cache.h: Revert.
2744         * filename-seen-cache.c: Revert.
2745         * fbsd-tdep.c: Revert.
2746         * fbsd-nat.h: Revert.
2747         * fbsd-nat.c: Revert.
2748         * f-valprint.c: Revert.
2749         * f-typeprint.c: Revert.
2750         * f-lang.c: Revert.
2751         * extension.h: Revert.
2752         * extension.c: Revert.
2753         * extension-priv.h: Revert.
2754         * expprint.c: Revert.
2755         * exec.h: Revert.
2756         * exec.c: Revert.
2757         * exceptions.c: Revert.
2758         * event-top.c: Revert.
2759         * event-loop.c: Revert.
2760         * eval.c: Revert.
2761         * elfread.c: Revert.
2762         * dwarf2read.h: Revert.
2763         * dwarf2read.c: Revert.
2764         * dwarf2loc.c: Revert.
2765         * dwarf2expr.h: Revert.
2766         * dwarf2expr.c: Revert.
2767         * dwarf2-frame.c: Revert.
2768         * dwarf2-frame-tailcall.c: Revert.
2769         * dwarf-index-write.h: Revert.
2770         * dwarf-index-write.c: Revert.
2771         * dwarf-index-common.c: Revert.
2772         * dwarf-index-cache.h: Revert.
2773         * dwarf-index-cache.c: Revert.
2774         * dummy-frame.c: Revert.
2775         * dtrace-probe.c: Revert.
2776         * disasm.h: Revert.
2777         * disasm.c: Revert.
2778         * disasm-selftests.c: Revert.
2779         * dictionary.c: Revert.
2780         * dicos-tdep.c: Revert.
2781         * demangle.c: Revert.
2782         * dcache.h: Revert.
2783         * dcache.c: Revert.
2784         * darwin-nat.h: Revert.
2785         * darwin-nat.c: Revert.
2786         * darwin-nat-info.c: Revert.
2787         * d-valprint.c: Revert.
2788         * d-namespace.c: Revert.
2789         * d-lang.c: Revert.
2790         * ctf.c: Revert.
2791         * csky-tdep.c: Revert.
2792         * csky-linux-tdep.c: Revert.
2793         * cris-tdep.c: Revert.
2794         * cris-linux-tdep.c: Revert.
2795         * cp-valprint.c: Revert.
2796         * cp-support.c: Revert.
2797         * cp-namespace.c: Revert.
2798         * cp-abi.c: Revert.
2799         * corelow.c: Revert.
2800         * corefile.c: Revert.
2801         * continuations.c: Revert.
2802         * completer.h: Revert.
2803         * completer.c: Revert.
2804         * complaints.c: Revert.
2805         * coffread.c: Revert.
2806         * coff-pe-read.c: Revert.
2807         * cli-out.h: Revert.
2808         * cli-out.c: Revert.
2809         * charset.c: Revert.
2810         * c-varobj.c: Revert.
2811         * c-valprint.c: Revert.
2812         * c-typeprint.c: Revert.
2813         * c-lang.c: Revert.
2814         * buildsym.c: Revert.
2815         * buildsym-legacy.c: Revert.
2816         * build-id.h: Revert.
2817         * build-id.c: Revert.
2818         * btrace.c: Revert.
2819         * bsd-uthread.c: Revert.
2820         * breakpoint.h: Revert.
2821         * breakpoint.c: Revert.
2822         * break-catch-throw.c: Revert.
2823         * break-catch-syscall.c: Revert.
2824         * break-catch-sig.c: Revert.
2825         * blockframe.c: Revert.
2826         * block.c: Revert.
2827         * bfin-tdep.c: Revert.
2828         * bfin-linux-tdep.c: Revert.
2829         * bfd-target.c: Revert.
2830         * bcache.c: Revert.
2831         * ax-general.c: Revert.
2832         * ax-gdb.h: Revert.
2833         * ax-gdb.c: Revert.
2834         * avr-tdep.c: Revert.
2835         * auxv.c: Revert.
2836         * auto-load.c: Revert.
2837         * arm-wince-tdep.c: Revert.
2838         * arm-tdep.c: Revert.
2839         * arm-symbian-tdep.c: Revert.
2840         * arm-pikeos-tdep.c: Revert.
2841         * arm-obsd-tdep.c: Revert.
2842         * arm-nbsd-tdep.c: Revert.
2843         * arm-nbsd-nat.c: Revert.
2844         * arm-linux-tdep.c: Revert.
2845         * arm-linux-nat.c: Revert.
2846         * arm-fbsd-tdep.c: Revert.
2847         * arm-fbsd-nat.c: Revert.
2848         * arm-bsd-tdep.c: Revert.
2849         * arch-utils.c: Revert.
2850         * arc-tdep.c: Revert.
2851         * arc-newlib-tdep.c: Revert.
2852         * annotate.h: Revert.
2853         * annotate.c: Revert.
2854         * amd64-windows-tdep.c: Revert.
2855         * amd64-windows-nat.c: Revert.
2856         * amd64-tdep.c: Revert.
2857         * amd64-sol2-tdep.c: Revert.
2858         * amd64-obsd-tdep.c: Revert.
2859         * amd64-obsd-nat.c: Revert.
2860         * amd64-nbsd-tdep.c: Revert.
2861         * amd64-nbsd-nat.c: Revert.
2862         * amd64-nat.c: Revert.
2863         * amd64-linux-tdep.c: Revert.
2864         * amd64-linux-nat.c: Revert.
2865         * amd64-fbsd-tdep.c: Revert.
2866         * amd64-fbsd-nat.c: Revert.
2867         * amd64-dicos-tdep.c: Revert.
2868         * amd64-darwin-tdep.c: Revert.
2869         * amd64-bsd-nat.c: Revert.
2870         * alpha-tdep.c: Revert.
2871         * alpha-obsd-tdep.c: Revert.
2872         * alpha-nbsd-tdep.c: Revert.
2873         * alpha-mdebug-tdep.c: Revert.
2874         * alpha-linux-tdep.c: Revert.
2875         * alpha-linux-nat.c: Revert.
2876         * alpha-bsd-tdep.c: Revert.
2877         * alpha-bsd-nat.c: Revert.
2878         * aix-thread.c: Revert.
2879         * agent.c: Revert.
2880         * addrmap.c: Revert.
2881         * ada-varobj.c: Revert.
2882         * ada-valprint.c: Revert.
2883         * ada-typeprint.c: Revert.
2884         * ada-tasks.c: Revert.
2885         * ada-lang.c: Revert.
2886         * aarch64-tdep.c: Revert.
2887         * aarch64-ravenscar-thread.c: Revert.
2888         * aarch64-newlib-tdep.c: Revert.
2889         * aarch64-linux-tdep.c: Revert.
2890         * aarch64-linux-nat.c: Revert.
2891         * aarch64-fbsd-tdep.c: Revert.
2892         * aarch64-fbsd-nat.c: Revert.
2893         * aarch32-linux-nat.c: Revert.
2894
2895 2019-04-05  Tom Tromey  <tom@tromey.com>
2896
2897         * ft32-tdep.c: Sort headers.
2898         * frv-tdep.c: Sort headers.
2899         * frv-linux-tdep.c: Sort headers.
2900         * frame.c: Sort headers.
2901         * frame-unwind.c: Sort headers.
2902         * frame-base.c: Sort headers.
2903         * fork-child.c: Sort headers.
2904         * findvar.c: Sort headers.
2905         * findcmd.c: Sort headers.
2906         * filesystem.c: Sort headers.
2907         * filename-seen-cache.h: Sort headers.
2908         * filename-seen-cache.c: Sort headers.
2909         * fbsd-tdep.c: Sort headers.
2910         * fbsd-nat.h: Sort headers.
2911         * fbsd-nat.c: Sort headers.
2912         * f-valprint.c: Sort headers.
2913         * f-typeprint.c: Sort headers.
2914         * f-lang.c: Sort headers.
2915         * extension.h: Sort headers.
2916         * extension.c: Sort headers.
2917         * extension-priv.h: Sort headers.
2918         * expprint.c: Sort headers.
2919         * exec.h: Sort headers.
2920         * exec.c: Sort headers.
2921         * exceptions.c: Sort headers.
2922         * event-top.c: Sort headers.
2923         * event-loop.c: Sort headers.
2924         * eval.c: Sort headers.
2925         * elfread.c: Sort headers.
2926         * dwarf2read.h: Sort headers.
2927         * dwarf2read.c: Sort headers.
2928         * dwarf2loc.c: Sort headers.
2929         * dwarf2expr.h: Sort headers.
2930         * dwarf2expr.c: Sort headers.
2931         * dwarf2-frame.c: Sort headers.
2932         * dwarf2-frame-tailcall.c: Sort headers.
2933         * dwarf-index-write.h: Sort headers.
2934         * dwarf-index-write.c: Sort headers.
2935         * dwarf-index-common.c: Sort headers.
2936         * dwarf-index-cache.h: Sort headers.
2937         * dwarf-index-cache.c: Sort headers.
2938         * dummy-frame.c: Sort headers.
2939         * dtrace-probe.c: Sort headers.
2940         * disasm.h: Sort headers.
2941         * disasm.c: Sort headers.
2942         * disasm-selftests.c: Sort headers.
2943         * dictionary.c: Sort headers.
2944         * dicos-tdep.c: Sort headers.
2945         * demangle.c: Sort headers.
2946         * dcache.h: Sort headers.
2947         * dcache.c: Sort headers.
2948         * darwin-nat.h: Sort headers.
2949         * darwin-nat.c: Sort headers.
2950         * darwin-nat-info.c: Sort headers.
2951         * d-valprint.c: Sort headers.
2952         * d-namespace.c: Sort headers.
2953         * d-lang.c: Sort headers.
2954         * ctf.c: Sort headers.
2955         * csky-tdep.c: Sort headers.
2956         * csky-linux-tdep.c: Sort headers.
2957         * cris-tdep.c: Sort headers.
2958         * cris-linux-tdep.c: Sort headers.
2959         * cp-valprint.c: Sort headers.
2960         * cp-support.c: Sort headers.
2961         * cp-namespace.c: Sort headers.
2962         * cp-abi.c: Sort headers.
2963         * corelow.c: Sort headers.
2964         * corefile.c: Sort headers.
2965         * continuations.c: Sort headers.
2966         * completer.h: Sort headers.
2967         * completer.c: Sort headers.
2968         * complaints.c: Sort headers.
2969         * coffread.c: Sort headers.
2970         * coff-pe-read.c: Sort headers.
2971         * cli-out.h: Sort headers.
2972         * cli-out.c: Sort headers.
2973         * charset.c: Sort headers.
2974         * c-varobj.c: Sort headers.
2975         * c-valprint.c: Sort headers.
2976         * c-typeprint.c: Sort headers.
2977         * c-lang.c: Sort headers.
2978         * buildsym.c: Sort headers.
2979         * buildsym-legacy.c: Sort headers.
2980         * build-id.h: Sort headers.
2981         * build-id.c: Sort headers.
2982         * btrace.c: Sort headers.
2983         * bsd-uthread.c: Sort headers.
2984         * breakpoint.h: Sort headers.
2985         * breakpoint.c: Sort headers.
2986         * break-catch-throw.c: Sort headers.
2987         * break-catch-syscall.c: Sort headers.
2988         * break-catch-sig.c: Sort headers.
2989         * blockframe.c: Sort headers.
2990         * block.c: Sort headers.
2991         * bfin-tdep.c: Sort headers.
2992         * bfin-linux-tdep.c: Sort headers.
2993         * bfd-target.c: Sort headers.
2994         * bcache.c: Sort headers.
2995         * ax-general.c: Sort headers.
2996         * ax-gdb.h: Sort headers.
2997         * ax-gdb.c: Sort headers.
2998         * avr-tdep.c: Sort headers.
2999         * auxv.c: Sort headers.
3000         * auto-load.c: Sort headers.
3001         * arm-wince-tdep.c: Sort headers.
3002         * arm-tdep.c: Sort headers.
3003         * arm-symbian-tdep.c: Sort headers.
3004         * arm-pikeos-tdep.c: Sort headers.
3005         * arm-obsd-tdep.c: Sort headers.
3006         * arm-nbsd-tdep.c: Sort headers.
3007         * arm-nbsd-nat.c: Sort headers.
3008         * arm-linux-tdep.c: Sort headers.
3009         * arm-linux-nat.c: Sort headers.
3010         * arm-fbsd-tdep.c: Sort headers.
3011         * arm-fbsd-nat.c: Sort headers.
3012         * arm-bsd-tdep.c: Sort headers.
3013         * arch-utils.c: Sort headers.
3014         * arc-tdep.c: Sort headers.
3015         * arc-newlib-tdep.c: Sort headers.
3016         * annotate.h: Sort headers.
3017         * annotate.c: Sort headers.
3018         * amd64-windows-tdep.c: Sort headers.
3019         * amd64-windows-nat.c: Sort headers.
3020         * amd64-tdep.c: Sort headers.
3021         * amd64-sol2-tdep.c: Sort headers.
3022         * amd64-obsd-tdep.c: Sort headers.
3023         * amd64-obsd-nat.c: Sort headers.
3024         * amd64-nbsd-tdep.c: Sort headers.
3025         * amd64-nbsd-nat.c: Sort headers.
3026         * amd64-nat.c: Sort headers.
3027         * amd64-linux-tdep.c: Sort headers.
3028         * amd64-linux-nat.c: Sort headers.
3029         * amd64-fbsd-tdep.c: Sort headers.
3030         * amd64-fbsd-nat.c: Sort headers.
3031         * amd64-dicos-tdep.c: Sort headers.
3032         * amd64-darwin-tdep.c: Sort headers.
3033         * amd64-bsd-nat.c: Sort headers.
3034         * alpha-tdep.c: Sort headers.
3035         * alpha-obsd-tdep.c: Sort headers.
3036         * alpha-nbsd-tdep.c: Sort headers.
3037         * alpha-mdebug-tdep.c: Sort headers.
3038         * alpha-linux-tdep.c: Sort headers.
3039         * alpha-linux-nat.c: Sort headers.
3040         * alpha-bsd-tdep.c: Sort headers.
3041         * alpha-bsd-nat.c: Sort headers.
3042         * aix-thread.c: Sort headers.
3043         * agent.c: Sort headers.
3044         * addrmap.c: Sort headers.
3045         * ada-varobj.c: Sort headers.
3046         * ada-valprint.c: Sort headers.
3047         * ada-typeprint.c: Sort headers.
3048         * ada-tasks.c: Sort headers.
3049         * ada-lang.c: Sort headers.
3050         * aarch64-tdep.c: Sort headers.
3051         * aarch64-ravenscar-thread.c: Sort headers.
3052         * aarch64-newlib-tdep.c: Sort headers.
3053         * aarch64-linux-tdep.c: Sort headers.
3054         * aarch64-linux-nat.c: Sort headers.
3055         * aarch64-fbsd-tdep.c: Sort headers.
3056         * aarch64-fbsd-nat.c: Sort headers.
3057         * aarch32-linux-nat.c: Sort headers.
3058
3059 2019-04-04  Tom Tromey  <tom@tromey.com>
3060
3061         * varobj.c (varobj_create): Update.
3062         * rust-exp.y (struct rust_parser) <update_innermost_block,
3063         lookup_symbol>: New methods.
3064         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3065         Rename.
3066         (rust_parser::rust_lookup_type)
3067         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3068         * printcmd.c (display_command, do_one_display): Update.
3069         * parser-defs.h (struct parser_state) <parser_state>: Add
3070         "tracker" parameter.
3071         (block_tracker): New member.
3072         (class innermost_block_tracker) <innermost_block_tracker>: Add
3073         "types" parameter.
3074         <reset>: Remove method.
3075         (innermost_block): Don't declare.
3076         (null_post_parser): Update.
3077         * parse.c (innermost_block): Remove global.
3078         (write_dollar_variable): Update.
3079         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3080         Remove "tracker_types" parameter.
3081         (parse_expression): Add "tracker" parameter.
3082         (parse_expression_for_completion): Update.
3083         (null_post_parser): Add "tracker" parameter.
3084         * p-exp.y: Update rules.
3085         * m2-exp.y: Update rules.
3086         * language.h (struct language_defn) <la_post_parser>: Add
3087         "tracker" parameter.
3088         * go-exp.y: Update rules.
3089         * f-exp.y: Update rules.
3090         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3091         parameter.
3092         * d-exp.y: Update rules.
3093         * c-exp.y: Update rules.
3094         * breakpoint.c (set_breakpoint_condition): Create an
3095         innermost_block_tracker.
3096         (watch_command_1): Likewise.
3097         * ada-lang.c (resolve): Add "tracker" parameter.
3098         (resolve_subexp): Likewise.
3099         * ada-exp.y (write_var_from_sym): Update.
3100
3101 2019-04-04  Tom Tromey  <tom@tromey.com>
3102
3103         * type-stack.h: New file.
3104         * type-stack.c: New file.
3105         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3106         type-stack.h.
3107         (insert_into_type_stack, insert_type, push_type, push_type_int)
3108         (insert_type_address_space, pop_type, pop_type_int)
3109         (pop_typelist, pop_type_stack, append_type_stack)
3110         (push_type_stack, get_type_stack, push_typelist)
3111         (follow_type_instance_flags, follow_types): Don't declare.
3112         * parse.c (type_stack): Remove global.
3113         (parse_exp_in_context): Update.
3114         (insert_into_type_stack, insert_type, push_type, push_type_int)
3115         (insert_type_address_space, pop_type, pop_type_int)
3116         (pop_typelist, pop_type_stack, append_type_stack)
3117         (push_type_stack, get_type_stack, push_typelist)
3118         (follow_type_instance_flags, follow_types): Remove (moved to
3119         type-stack.c).
3120         * f-exp.y (type_stack): New global.
3121         Update rules.
3122         (push_kind_type, f_parse): Update.
3123         * d-exp.y (type_stack): New global.
3124         Update rules.
3125         (d_parse): Update.
3126         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3127         Update rules.
3128         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3129         (HFILES_NO_SRCDIR): Add type-stack.h.
3130
3131 2019-04-04  Tom Tromey  <tom@tromey.com>
3132
3133         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3134         (rust_parser::convert_ast_to_expression, rust_parse)
3135         (rust_lex_test_completion, rust_lex_tests): Update.
3136         * parser-defs.h (struct expr_completion_state): New.
3137         (struct parser_state) <parser_state>: Add completion parameter.
3138         <mark_struct_expression, mark_completion_tag>: New methods.
3139         <parse_completion, m_completion_state>: New members.
3140         (prefixify_expression, null_post_parser): Update.
3141         (mark_struct_expression, mark_completion_tag): Don't declare.
3142         * parse.c (parse_completion, expout_last_struct)
3143         (expout_tag_completion_type, expout_completion_name): Remove
3144         globals.
3145         (parser_state::mark_struct_expression)
3146         (parser_state::mark_completion_tag): Now methods.
3147         (prefixify_expression): Add last_struct parameter.
3148         (prefixify_subexp): Likewise.
3149         (parse_exp_1): Update.
3150         (parse_exp_in_context): Add cstate parameter.  Update.
3151         (parse_expression_for_completion): Create an
3152         expr_completion_state.
3153         (null_post_parser): Add "completion" parameter.
3154         * p-exp.y: Update rules.
3155         (yylex): Update.
3156         * language.h (struct language_defn) <la_post_parser>: Add
3157         "completing" parameter.
3158         * go-exp.y: Update rules.
3159         (lex_one_token): Update.
3160         * expression.h (parse_completion): Don't declare.
3161         * d-exp.y: Update rules.
3162         (lex_one_token): Update rules.
3163         * c-exp.y: Update rules.
3164         (lex_one_token): Update.
3165         * ada-lang.c (resolve): Add "parse_completion" parameter.
3166         (resolve_subexp): Likewise.
3167         (ada_resolve_function): Likewise.
3168
3169 2019-04-04  Tom Tromey  <tom@tromey.com>
3170
3171         * parser-defs.h (struct parser_state) <start_arglist,
3172         end_arglist>: New methods.
3173         <arglist_len, m_funcall_chain>: New members.
3174         (arglist_len, start_arglist, end_arglist): Don't declare.
3175         * parse.c (arglist_len, funcall_chain): Remove global.
3176         (start_arglist, end_arglist): Remove functions.
3177         (parse_exp_in_context): Update.
3178         * p-exp.y: Update rules.
3179         * m2-exp.y: Update rules.
3180         * go-exp.y: Update rules.
3181         * f-exp.y: Update rules.
3182         * d-exp.y: Update rules.
3183         * c-exp.y: Update rules.
3184
3185 2019-04-04  Tom Tromey  <tom@tromey.com>
3186
3187         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3188         lex_operator, push_back>: New methods.
3189         Update all rules.
3190         (rust_parser::lex_hex, lex_escape): Rename and update.
3191         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3192         (rust_parser::lex_operator): Rename and update.
3193         (rust_parser::lex_number, rustyylex, rustyyerror)
3194         (rust_lex_test_init, rust_lex_test_sequence)
3195         (rust_lex_test_push_back, rust_lex_tests): Update.
3196         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3197         parameter.
3198         <lexptr, prev_lexptr>: New members.
3199         (lexptr, prev_lexptr): Don't declare.
3200         * parse.c (lexptr, prev_lexptr): Remove globals.
3201         (parse_exp_in_context): Update.
3202         * p-exp.y (yylex, yyerror): Update.
3203         * m2-exp.y (parse_number, yylex, yyerror): Update.
3204         * go-exp.y (lex_one_token, yyerror): Update.
3205         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3206         * d-exp.y (lex_one_token, yyerror): Update.
3207         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3208         (lex_one_token, yyerror): Update.
3209         * ada-lex.l (YY_INPUT): Update.
3210         (rewind_to_char): Update.
3211         * ada-exp.y (yyerror): Update.
3212
3213 2019-04-04  Tom Tromey  <tom@tromey.com>
3214
3215         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3216         * parser-defs.h (struct parser_state) <parser_state>: Add new
3217         parameter.
3218         <comma_terminates>: New member.
3219         (comma_terminates): Don't declare global.
3220         * parse.c (comma_terminates): Remove global.
3221         (parse_exp_in_context): Update.
3222         * p-exp.y (yylex): Update.
3223         * m2-exp.y (yylex): Update.
3224         * go-exp.y (lex_one_token): Update.
3225         * f-exp.y (yylex): Update.
3226         * d-exp.y (lex_one_token): Update.
3227         * c-exp.y (lex_one_token): Update.
3228         * ada-lex.l: Update.
3229
3230 2019-04-04  Tom Tromey  <tom@tromey.com>
3231
3232         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3233         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3234         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3235         * parser-defs.h (paren_depth): Don't declare.
3236         * parse.c (paren_depth): Remove global.
3237         (parse_exp_in_context): Update.
3238         * p-exp.y (paren_depth): New global.
3239         (pascal_parse): Initialize it.
3240         * m2-exp.y (paren_depth): New global.
3241         (m2_parse): Initialize it.
3242         * go-exp.y (paren_depth): New global.
3243         (go_parse): Initialize it.
3244         * f-exp.y (paren_depth): New global.
3245         (f_parse): Initialize it.
3246         * d-exp.y (paren_depth): New global.
3247         (d_parse): Initialize it.
3248         * c-exp.y (paren_depth): New global.
3249         (c_parse): Initialize it.
3250         * ada-lex.l (paren_depth): New global.
3251         (lexer_init): Initialize it.
3252
3253 2019-04-04  Tom Tromey  <tom@tromey.com>
3254
3255         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3256         (rust_parser::convert_ast_to_type)
3257         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3258         * parser-defs.h (struct parser_state) <parser_state>: Add
3259         parameters.  Initialize new members.
3260         <expression_context_block, expression_context_pc>: New members.
3261         * parse.c (expression_context_block, expression_context_pc):
3262         Remove globals.
3263         (parse_exp_in_context): Update.
3264         * p-exp.y: Update all rules.
3265         (yylex): Update.
3266         * m2-exp.y: Update all rules.
3267         (yylex): Update.
3268         * go-exp.y (yylex): Update.
3269         * f-exp.y (yylex): Update.
3270         * d-exp.y: Update all rules.
3271         (yylex): Update.
3272         * c-exp.y: Update all rules.
3273         (lex_one_token, classify_name, yylex, c_parse): Update.
3274         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3275
3276 2019-04-04  Tom Tromey  <tom@tromey.com>
3277
3278         * gdbarch.h, gdbarch.c: Rebuild.
3279         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3280         * stap-probe.h:
3281         (struct stap_parse_info): Replace "parser_state" with
3282         "expr_builder".
3283         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3284         (parser_state): New class.
3285         * parse.c (expr_builder): Rename.
3286         (expr_builder::release): Rename.
3287         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3288         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3289         (write_exp_elt_longcst, write_exp_elt_floatcst)
3290         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3291         (write_exp_string_vector, write_exp_bitstring)
3292         (write_exp_msymbol, mark_struct_expression)
3293         (write_dollar_variable)
3294         (insert_type_address_space, increase_expout_size): Replace
3295         "parser_state" with "expr_builder".
3296         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3297         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3298         "parser_state" with "expr_builder".
3299
3300 2019-04-04  Tom Tromey  <tom@tromey.com>
3301
3302         * rust-exp.y: Replace "parse_language" with method call.
3303         * p-exp.y:
3304         (yylex): Replace "parse_language" with method call.
3305         * m2-exp.y:
3306         (yylex): Replace "parse_language" with method call.
3307         * go-exp.y (classify_name): Replace "parse_language" with method
3308         call.
3309         * f-exp.y (yylex): Replace "parse_language" with method call.
3310         * d-exp.y (lex_one_token): Replace "parse_language" with method
3311         call.
3312         * c-exp.y:
3313         (lex_one_token, classify_name, yylex): Replace "parse_language"
3314         with method call.
3315         * ada-exp.y (find_primitive_type, type_char)
3316         (type_system_address): Replace "parse_language" with method call.
3317
3318 2019-04-04  Tom Tromey  <tom@tromey.com>
3319
3320         * rust-exp.y: Replace "parse_gdbarch" with method call.
3321         * parse.c (write_dollar_variable, insert_type_address_space):
3322         Replace "parse_gdbarch" with method call.
3323         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3324         call.
3325         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3326         call.
3327         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3328         "parse_gdbarch" with method call.
3329         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3330         with method call.
3331         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3332         "parse_gdbarch" with method call.
3333         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3334         "parse_gdbarch" with method call.
3335         * c-exp.y (parse_type, parse_number, classify_name): Replace
3336         "parse_gdbarch" with method call.
3337         * ada-lex.l: Replace "parse_gdbarch" with method call.
3338         * ada-exp.y (parse_type, find_primitive_type, type_char)
3339         (type_system_address): Replace "parse_gdbarch" with method call.
3340
3341 2019-04-04  Tom Tromey  <tom@tromey.com>
3342
3343         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3344         * stap-probe.c (stap_parse_argument): Update.
3345         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3346         initial_size parameter.
3347         * rust-exp.y (rust_lex_tests): Update.
3348         * parse.c (parser_state): Update.
3349         (parse_exp_in_context): Update.
3350         * parser-defs.h (struct parser_state) <parser_state>: Remove
3351         "initial_size" parameter.
3352
3353 2019-04-04  Tom Tromey  <tom@tromey.com>
3354
3355         * parser-defs.h (increase_expout_size): Don't declare.
3356         * parse.c (increase_expout_size): Now static.
3357
3358 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3359
3360         * gnu-nat.c (gnu_nat_target::wait): Fix
3361         target_waitstatus_to_string call.
3362
3363 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * eval.c (evaluate_subexp_standard): Handle internal functions
3366         during Fortran function call handling.
3367
3368 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * NEWS: Mention new internal functions.
3371         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3372         (read_base_type): Use dwarf2_init_complex_target_type.
3373         * value.c (creal_internal_fn): New function.
3374         (cimag_internal_fn): New function.
3375         (_initialize_values): Register new internal functions.
3376
3377 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3378
3379         * infrun.c (stop_all_threads): If debug_infrun, always
3380         trace the wait status after wait_one, using
3381         target_waitstatus_to_string and target_pid_to_str.
3382         (handle_inferior_event): Replace various trace of
3383         wait status kind by a single trace.
3384         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3385         wait status kind image by target_waitstatus_to_string.
3386         * target/waitstatus.c (target_waitstatus_to_string): Fix
3387         obsolete comment.
3388
3389 2019-04-01  Tom Tromey  <tromey@adacore.com>
3390
3391         PR symtab/23331:
3392         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3393
3394 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3395             Pedro Alves  <palves@redhat.com>
3396
3397         * top.c (quit_force): Call 'finalize_values'.
3398         * value.c (finalize_values): New function.
3399         * value.h (finalize_values): Declare.
3400
3401 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3402
3403         * NEWS: Announce $_gdb_major and $_gdb_minor.
3404
3405         * top.c (init_gdb_version_vars): New function.
3406         (gdb_init): Call init_gdb_version_vars.
3407
3408 2019-03-29  Tom Tromey  <tromey@adacore.com>
3409
3410         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3411         help text.  Remove dead code.
3412
3413 2019-03-29  Keith Seitz  <keiths@redhat.com>
3414
3415         From Siddhesh Poyarekar:
3416         * f-lang.h (f77_get_upperbound): Return LONGEST.
3417         (f77_get_lowerbound): Likewise.
3418         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3419         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3420         print them.
3421         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3422         plongest to format print it.
3423         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3424         (f77_get_upperbound): Likewise.
3425         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3426         LOWER_BOUND to LONGEST.
3427         (f77_create_arrayprint_offset_tbl): Likewise.
3428
3429 2019-03-29  Keith Seitz  <keiths@redhat.com>
3430
3431         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3432         %s/pulongest for TYPE_LENGTH instead of %d in format
3433         strings.
3434         * ada-typerint.c (ada_print_type): Likewise.
3435         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3436         * compile/compile-c-support.c (generate_register_struct): Likewise.
3437         * gdbtypes.c (recursive_dump_type): Likewise.
3438         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3439         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3440         instead of %d in format strings.
3441         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3442         to std::min to ULONGEST.
3443         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3444         instead of %d in format strings.
3445         * tracepoint.c (info_scope_command): Likewise.
3446         * typeprint.c (print_offset_data::update)
3447         (print_offset_data::finish): Likewise.
3448         * xtensa-tdep.c (xtensa_store_return_value)
3449         (xtensa_push_dummy_call): Likewise.
3450
3451 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3452
3453         * windows-nat.c (display_selector): Fixed format specifications
3454         for 64-bit Cygwin.
3455
3456 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3459
3460 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3461
3462         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3463         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3464         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3465         (nios2_linux_init_abi): Install it.
3466
3467 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3468
3469         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3470
3471 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3472
3473         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3474
3475 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3476             Tom Tromey  <tromey@adacore.com>
3477
3478         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3479
3480 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3481
3482         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3483         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3484         method to compute the bounds of range types. Also print "[evaluated]"
3485         if the bounds' values come from a dynamic evaluation.
3486
3487 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3490         whitespace when pretty printing is on.
3491
3492 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3493
3494         * ppc-linux-nat.c: Add include.
3495
3496 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3497
3498         * NEWS: Mention AArch64 Pointer Authentication.
3499
3500 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3501
3502         * arm-linux-nat.c: Add include.
3503
3504 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3505
3506         * source-cache.c (source_cache::get_source_lines): Re-read
3507         fullname after calling open_source_file.
3508
3509 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3510
3511         * NEWS: Mention TLS support for FreeBSD.
3512
3513 2019-03-25  Tom Tromey  <tromey@adacore.com>
3514
3515         * minsyms.c (BUNCH_SIZE): Update comment.
3516         (~minimal_symbol_reader): Remove old comment.
3517         (compact_minimal_symbols): Update comment.
3518         (minimal_symbol_reader::install): Remove old comment.  Update
3519         other comments.
3520
3521 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3522
3523         * s390-linux-nat.c: Add include.
3524
3525 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3526
3527         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3528         Call linux_get_hwcap.
3529         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3530         Likewise.
3531         (aarch64_linux_get_hwcap): Remove function.
3532         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3533         declaration.
3534         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3535         linux_get_hwcap.
3536         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3537         * linux-tdep.c (linux_get_hwcap): Add function.
3538         (linux_get_hwcap2): Likewise.
3539         * linux-tdep.h (linux_get_hwcap): Add declaration.
3540         (linux_get_hwcap2): Likewise.
3541         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3542         (ppc_linux_get_hwcap2): Likewise.
3543         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3544         linux_get_hwcap.
3545         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3546         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3547         (ppc_linux_nat_target::read_description): Likewise.
3548         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3549         * s390-linux-nat.c: Likewise.
3550         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3551
3552 2019-03-24  Tom Tromey  <tom@tromey.com>
3553
3554         * ada-lang.c (standard_lookup): Simplify initialization.
3555         (ada_lookup_symbol_nonlocal): Simplify return.
3556         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3557         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3558         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3559         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3560         initialization.
3561         * solib.c (solib_global_lookup): Simplify.
3562         * symtab.c (null_block_symbol): Remove.
3563         (symbol_cache_lookup): Simplify returns.
3564         (lookup_language_this): Simplify returns.
3565         (lookup_symbol_aux): Simplify return.
3566         (lookup_local_symbol): Simplify returns.
3567         (lookup_global_symbol_from_objfile): Simplify return.
3568         (lookup_symbol_in_objfile_symtabs)
3569         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3570         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3571         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3572         * cp-namespace.c (cp_lookup_bare_symbol)
3573         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3574         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3575         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3576         (cp_lookup_symbol_via_imports): Simplify initialization.
3577         (find_symbol_in_baseclass): Likewise.
3578         * symtab.h (null_block_symbol): Remove.
3579         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3580         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3581         (d_lookup_symbol_module): Likewise.
3582         (find_symbol_in_baseclass): Simplify initialization.
3583
3584 2019-03-24  Tom Tromey  <tom@tromey.com>
3585
3586         * expression.h: Don't include symtab.h.
3587         (struct block): Forward declare.
3588
3589 2019-03-24  Tom Tromey  <tom@tromey.com>
3590
3591         * c-exp.y (typebase): Remove casts.
3592         * gdbtypes.c (lookup_unsigned_typename, )
3593         (lookup_signed_typename): Remove cast.
3594         * eval.c (parse_to_comma_and_eval): Remove cast.
3595         * parse.c (write_dollar_variable): Remove cast.
3596         * block.h (struct block) <superblock>: Now const.
3597         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3598         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3599         (map_block): Make "block" const.
3600         * symfile.h (struct quick_symbol_functions)
3601         <map_matching_symbols>: Constify block argument to "callback".
3602         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3603         const.
3604         (find_pc_sect_compunit_symtab): Make "b" const.
3605         (find_symbol_at_address): Likewise.
3606         (search_symbols): Likewise.
3607         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3608         (dw2_debug_names_lookup_symbol): Likewise.
3609         (dw2_map_matching_symbols): Update.
3610         * p-valprint.c (pascal_val_print): Remove "block".
3611         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3612         (aux_add_nonlocal_symbols): Make "block" const.
3613         (resolve_subexp): Remove cast.
3614         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3615         const.
3616         (iterate_over_file_blocks): Likewise.
3617         * f-exp.y (%union) <bval>: Remove.
3618         * coffread.c (patch_opaque_types): Make "b" const.
3619         * spu-tdep.c (spu_catch_start): Make "block" const.
3620         * c-valprint.c (print_unpacked_pointer): Remove "block".
3621         * symmisc.c (dump_symtab_1): Make "b" const.
3622         (block_depth): Make "block" const.
3623         * d-exp.y (%union) <bval>: Remove.
3624         * cp-support.h (cp_lookup_rtti_type): Update.
3625         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3626         * psymtab.c (psym_lookup_symbol): Make "block" const.
3627         (maintenance_check_psymtabs): Make "b" const.
3628         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3629         (enumerate_locals, enumerate_args): Update.
3630         * python/py-symtab.c (stpy_global_block): Make "block" const.
3631         (stpy_static_block): Likewise.
3632         * inline-frame.c (block_starting_point_at): Make "new_block"
3633         const.
3634         * block.c (find_block_in_blockvector): Make return type const.
3635         (blockvector_for_pc_sect): Make "b" const.
3636         (find_block_in_blockvector): Make "b" const.
3637
3638 2019-03-23  Tom Tromey  <tom@tromey.com>
3639
3640         * varobj.c (varobj_create): Update.
3641         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3642         * printcmd.c (display_command, do_one_display): Don't reset
3643         innermost_block.
3644         * parser-defs.h (enum innermost_block_tracker_type): Move to
3645         expression.h.
3646         (innermost_block): Update comment.
3647         * parse.c (parse_exp_1): Add tracker_types parameter.
3648         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3649         tracker_types parameter.  Reset innermost_block.
3650         (parse_exp_in_context): Remove.
3651         (parse_expression_for_completion): Update.
3652         * objfiles.c (~objfile): Don't reset expression_context_block or
3653         innermost_block.
3654         * expression.h (enum innermost_block_tracker_type): Move from
3655         parser-defs.h.
3656         (parse_exp_1): Add tracker_types parameter.
3657         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3658         reset innermost_block.
3659
3660 2019-03-23  Tom Tromey  <tom@tromey.com>
3661
3662         * objfiles.h: Include bcache.h.
3663
3664 2019-03-23  Tom Tromey  <tom@tromey.com>
3665
3666         * linespec.c (get_current_search_block): Use
3667         scoped_restore_current_language.
3668         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3669
3670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3671             Jiong Wang  <jiong.wang@arm.com>
3672
3673         * aarch64-linux-tdep.c
3674         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3675         section.
3676         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3677
3678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3679             Jiong Wang  <jiong.wang@arm.com>
3680
3681         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3682         instructions.
3683         (aarch64_analyze_prologue_test): Add PACIASP test.
3684         (aarch64_prologue_prev_register): Unmask PC value.
3685
3686 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3687             Jiong Wang  <jiong.wang@arm.com>
3688
3689         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3690         (aarch64_dwarf2_prev_register): Unmask PC value.
3691         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3692         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3693         DW_CFA_AARCH64_negate_ra_state.
3694         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3695
3696 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3697             Jiong Wang  <jiong.wang@arm.com>
3698
3699         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3700         registers.
3701         (aarch64_pseudo_register_name): Likewise.
3702         (aarch64_pseudo_register_type): Likewise.
3703         (aarch64_pseudo_register_reggroup_p): Likewise.
3704         (aarch64_gdbarch_init): Add pauth registers.
3705         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3706         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3707         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3708         (struct gdbarch_tdep): Add regnum for ra_state.
3709
3710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3711             Jiong Wang  <jiong.wang@arm.com>
3712
3713         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3714
3715 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3716             Jiong Wang  <jiong.wang@arm.com>
3717
3718         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3719         function.
3720         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3721         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3722         (aarch64_gdbarch_init): Add puth registers.
3723         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3724         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3725         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3726
3727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3728             Jiong Wang  <jiong.wang@arm.com>
3729
3730         * aarch64-linux-nat.c
3731         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3732         * aarch64-linux-tdep.c
3733         (aarch64_linux_core_read_description): Likewise.
3734         (aarch64_linux_get_hwcap): New function.
3735         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3736         (aarch64_linux_get_hwcap): New declaration.
3737
3738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3739             Jiong Wang  <jiong.wang@arm.com>
3740
3741         * aarch64-linux-nat.c
3742         (aarch64_linux_nat_target::read_description): Add pauth param.
3743         * aarch64-linux-tdep.c
3744         (aarch64_linux_core_read_description): Likewise.
3745         * aarch64-tdep.c (struct target_desc): Add in pauth.
3746         (aarch64_read_description): Add pauth param.
3747         (aarch64_gdbarch_init): Likewise.
3748         * aarch64-tdep.h (aarch64_read_description): Likewise.
3749         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3750         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3751         * features/Makefile: Add new files.
3752         * features/aarch64-pauth.c: New file.
3753         * features/aarch64-pauth.xml: New file.
3754
3755 2019-03-20  Tom Tromey  <tromey@adacore.com>
3756
3757         * infrun.c (handle_inferior_event): Rename from
3758         handle_inferior_event_1.  Create a scoped_value_mark.
3759         (handle_inferior_event): Remove.
3760
3761 2019-03-19  Tom Tromey  <tromey@adacore.com>
3762
3763         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3764         * infrun.h (print_stop_event): Add "displays" parameter.
3765         * infrun.c (print_stop_event): Add "displays" parameter.
3766
3767 2019-03-19  Pedro Alves  <palves@redhat.com>
3768
3769         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3770         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3771         to -1.  Fix TABs vs spaces.
3772         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3773         * tui/tui-out.h (tui_ui_out) Add intro comments.
3774         <m_line, m_start_of_line>: In-class initialize, and add describing
3775         comment.
3776
3777 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3778
3779         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3780         variable names.
3781         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3782
3783 2019-03-18  Pedro Alves  <palves@redhat.com>
3784             Eli Zaretskii <eliz@gnu.org>
3785
3786         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3787         m_line and m_start_of_line.
3788
3789 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3790
3791         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3792         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3793         it returns a newline.  This fixes a regression in TU mode, whereby
3794         the next line is output on the same screen line as the user input.
3795
3796 2019-03-18  Tom Tromey  <tromey@adacore.com>
3797
3798         * minsyms.c (minimal_symbol_reader::install): Remove call to
3799         obstack_blank.
3800
3801 2019-03-18  Pedro Alves  <palves@redhat.com>
3802
3803         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3804         New globals.
3805         (apply_style): New, factored out from ...
3806         (apply_ansi_escape): ... this.  Handle reverse video mode.
3807         (tui_set_reverse_mode): New function.
3808         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3809         * tui/tui-winsource.c (tui_show_source_line): Use
3810         tui_set_reverse_mode instead of setting A_STANDOUT.
3811         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3812         New setter methods.
3813
3814 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3815
3816         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3817         Handle tabs.
3818
3819 2019-03-18  Tom Tromey  <tromey@adacore.com>
3820
3821         * ada-lang.c (empty_array): Add "high" parameter.
3822         (ada_evaluate_subexp): Update.
3823
3824 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3825
3826         * unittests/string_view-selftests.c: Define
3827         _initialize_string_view_selftests unconditionally.
3828
3829 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3830
3831         PR gdb/24350
3832         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3833
3834 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3835
3836         PR gdb/24351
3837         * windows-nat.c (display_selector): Fix format specifiers.
3838
3839 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3840
3841         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3842         tui_refill_source_window instead of tui_refresh_win, to update the
3843         current execution line.  This fixes redisplay of the current line
3844         when stepping through the code with "next" or "step".
3845
3846 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3847
3848         * source-cache.c (source_cache::get_source_lines): Call
3849         find_source_lines to initialize s->nlines.  This fixes vertical
3850         scrolling of TUI source window when the DOWN arrow is pressed.
3851
3852 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3853
3854         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3855         linux-thread-db.c (_initialize_thread_db): Likewise.
3856
3857 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3858
3859         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3860         wclrtoeol in tui_show_source_line".  This reverts changes made in
3861         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3862
3863 2019-03-15  Tom Tromey  <tom@tromey.com>
3864
3865         * symtab.h (struct minimal_symbol): Derive from
3866         general_symbol_info.
3867         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3868         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3869         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3870         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3871         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3872         (MSYMBOL_SEARCH_NAME): Update.
3873         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3874         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3875         * minsyms.c (minimal_symbol_reader::record_full): Update.
3876
3877 2019-03-15  Tom Tromey  <tom@tromey.com>
3878
3879         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3880
3881 2019-03-15  Tom Tromey  <tom@tromey.com>
3882
3883         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3884         unique_xmalloc_ptr.
3885         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3886         Update.
3887         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3888         (build_minimal_symbol_hash_tables)
3889         (minimal_symbol_reader::install): Update.
3890
3891 2019-03-15  Tom Tromey  <tom@tromey.com>
3892
3893         * symtab.c (create_demangled_names_hash): Update.
3894         (symbol_set_names): Update.
3895         * objfiles.h (struct objfile_per_bfd_storage)
3896         <demangled_names_hash>: Now an htab_up.
3897         * objfiles.c (objfile_per_bfd_storage): Simplify.
3898
3899 2019-03-15  Tom Tromey  <tom@tromey.com>
3900
3901         * objfiles.h (struct objfile_per_bfd_storage): Declare
3902         destructor.
3903         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3904         New.
3905         (get_objfile_bfd_data): Use new.  Don't initialize
3906         language_of_main.
3907         (free_objfile_per_bfd_storage): Remove.
3908         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3909
3910 2019-03-15  Tom Tromey  <tom@tromey.com>
3911
3912         * symfile.c (reread_symbols): Update.
3913         * objfiles.c (objfile::objfile): Update.
3914         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3915         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3916         comment.
3917         (minimal_symbol_reader::install): Update.
3918         (terminate_minimal_symbol_table): Remove.
3919         * jit.c (jit_object_close_impl): Update.
3920
3921 2019-03-15  Tom Tromey  <tom@tromey.com>
3922
3923         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3924         initializations.
3925
3926 2019-03-15  Tom Tromey  <tom@tromey.com>
3927
3928         * objfiles.h (struct objfile_per_bfd_storage)
3929         <demangled_hash_languages>: Now a bitset.
3930         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3931         (lookup_minimal_symbol): Update.
3932
3933 2019-03-15  Tom Tromey  <tom@tromey.com>
3934
3935         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3936         Don't return the symbol.
3937         * coffread.c (record_minimal_symbol): Use record_full.
3938
3939 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3940
3941         The MS-Windows port of ncurses fails to switch to a color pair if
3942         one or both of the colors are the implicit default colors.  This
3943         change records the default colors when TUI is initialized, and
3944         then specifies them explicitly when a color pair uses the default
3945         colors.  This allows color styling in TUI mode on MS-Windows.
3946
3947         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3948         ncurses_norm_attr.
3949         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3950         colors in ncurses_norm_attr.
3951         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3952         "none", replace it with the default color recorded in
3953         ncurses_norm_attr.
3954
3955 2019-03-14  Tom Tromey  <tromey@adacore.com>
3956
3957         * source-cache.h (class source_cache) <get_source_lines>: Return
3958         std::string.
3959         * source-cache.c (source_cache::extract_lines): Handle case where
3960         first_pos==npos.  Return std::string.
3961         (source_cache::get_source_lines): Update.
3962
3963 2019-03-14  Tom Tromey  <tromey@adacore.com>
3964
3965         * NEWS: Add item for "style sources" commands.
3966         * source-cache.c (source_cache::get_source_lines): Check
3967         source_styling.
3968         * cli/cli-style.c (source_styling): New global.
3969         (_initialize_cli_style): Add "style sources" commands.
3970         (show_style_sources): New function.
3971         * cli/cli-style.h (source_styling): Declare.
3972
3973 2019-03-14  Pedro Alves  <palves@redhat.com>
3974             Tom Tromey  <tromey@adacore.com>
3975
3976         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3977         * tui/tui-winsource.c (tui_refill_source_window): New function,
3978         from...
3979         (tui_horizontal_source_scroll): ... here.  Move some logic.
3980         * cli/cli-style.c (set_style_enabled): Notify new observable.
3981         * tui/tui-hooks.c (tui_redisplay_source): New function.
3982         (tui_attach_detach_observers): Attach or detach
3983         tui_redisplay_source.
3984         * observable.h (source_styling_changed): New observable.
3985         * observable.c: Define source_styling_changed observable.
3986
3987 2019-03-13  Tom Tromey  <tromey@adacore.com>
3988
3989         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3990         (i386_gnu_nat_target::store_registers): Update.
3991         * target-debug.h (target_debug_print_std_string): New macro.
3992         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3993         * windows-tdep.c (display_one_tib): Update.
3994         * tui/tui-stack.c (tui_make_status_line): Update.
3995         * top.c (print_inferior_quit_action): Update.
3996         * thread.c (thr_try_catch_cmd): Update.
3997         (add_thread_with_info): Update.
3998         (thread_target_id_str): Update.
3999         (thr_try_catch_cmd): Update.
4000         (thread_command): Update.
4001         (thread_find_command): Update.
4002         * record-btrace.c (record_btrace_target::info_record)
4003         (record_btrace_resume_thread, record_btrace_target::resume)
4004         (record_btrace_cancel_resume, record_btrace_step_thread)
4005         (record_btrace_target::wait, record_btrace_target::wait)
4006         (record_btrace_target::wait, record_btrace_target::stop): Update.
4007         * progspace.c (print_program_space): Update.
4008         * process-stratum-target.c
4009         (process_stratum_target::thread_address_space): Update.
4010         * linux-fork.c (linux_fork_mourn_inferior)
4011         (detach_checkpoint_command, info_checkpoints_command)
4012         (linux_fork_context): Update.
4013         (linux_fork_detach): Update.
4014         (class scoped_switch_fork_info): Update.
4015         (delete_checkpoint_command): Update.
4016         * infrun.c (follow_fork_inferior): Update.
4017         (follow_fork_inferior): Update.
4018         (proceed_after_vfork_done): Update.
4019         (handle_vfork_child_exec_or_exit): Update.
4020         (follow_exec): Update.
4021         (displaced_step_prepare_throw): Update.
4022         (displaced_step_restore): Update.
4023         (start_step_over): Update.
4024         (resume_1): Update.
4025         (clear_proceed_status_thread): Update.
4026         (proceed): Update.
4027         (print_target_wait_results): Update.
4028         (do_target_wait): Update.
4029         (context_switch): Update.
4030         (stop_all_threads): Update.
4031         (restart_threads): Update.
4032         (finish_step_over): Update.
4033         (handle_signal_stop): Update.
4034         (switch_back_to_stepped_thread): Update.
4035         (keep_going_pass_signal): Update.
4036         (print_exited_reason): Update.
4037         (normal_stop): Update.
4038         * inferior.c (inferior_pid_to_str): Change return type.
4039         (print_selected_inferior): Update.
4040         (add_inferior): Update.
4041         (detach_inferior): Update.
4042         * dummy-frame.c (fprint_dummy_frames): Update.
4043         * dcache.c (dcache_info_1): Update.
4044         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4045         (btrace_fetch, btrace_clear): Update.
4046         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4047         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4048         type.
4049         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4050         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4051         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4052         * gdbarch.c, gdbarch.h: Rebuild.
4053         * gdbarch.sh (core_pid_to_str): Change return type.
4054         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4055         return type.
4056         (windows_nat_target::pid_to_str): Change return type.
4057         (windows_delete_thread): Update.
4058         (windows_nat_target::attach): Update.
4059         (windows_nat_target::files_info): Update.
4060         * target-delegates.c: Rebuild.
4061         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4062         return type.
4063         (sol_thread_target::pid_to_str): Change return type.
4064         * remote.c (class remote_target) <pid_to_str>: Change return
4065         type.
4066         (remote_target::pid_to_str): Change return type.
4067         (extended_remote_target::attach, remote_target::remote_stop_ns)
4068         (remote_target::remote_notif_remove_queued_reply)
4069         (remote_target::push_stop_reply, remote_target::disable_btrace):
4070         Update.
4071         (extended_remote_target::attach): Update.
4072         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4073         type.
4074         (gdbsim_target::pid_to_str): Change return type.
4075         * ravenscar-thread.c (struct ravenscar_thread_target)
4076         <pid_to_str>: Change return type.
4077         (ravenscar_thread_target::pid_to_str): Change return type.
4078         * procfs.c (class procfs_target) <pid_to_str>: Change return
4079         type.
4080         (procfs_target::pid_to_str): Change return type.
4081         (procfs_target::attach): Update.
4082         (procfs_target::detach): Update.
4083         (procfs_target::fetch_registers): Update.
4084         (procfs_target::store_registers): Update.
4085         (procfs_target::wait): Update.
4086         (procfs_target::files_info): Update.
4087         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4088         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4089         return type.
4090         (nto_procfs_target::pid_to_str): Change return type.
4091         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4092         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4093         return type.
4094         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4095         (exit_lwp): Update.
4096         (attach_proc_task_lwp_callback, get_detach_signal)
4097         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4098         (linux_nat_target::resume, wait_lwp, stop_callback)
4099         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4100         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4101         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4102         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4103         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4104         type.
4105         (inf_ptrace_target::attach): Update.
4106         (inf_ptrace_target::files_info): Update.
4107         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4108         type.
4109         (go32_nat_target::pid_to_str): Change return type.
4110         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4111         (gnu_nat_target::wait): Update.
4112         (gnu_nat_target::wait): Update.
4113         (gnu_nat_target::resume): Update.
4114         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4115         (fbsd_nat_target::wait): Update.
4116         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4117         type.
4118         (darwin_nat_target::attach): Update.
4119         * corelow.c (class core_target) <pid_to_str>: Change return type.
4120         (core_target::pid_to_str): Change return type.
4121         * target.c (normal_pid_to_str): Change return type.
4122         (default_pid_to_str): Likewise.
4123         (target_pid_to_str): Change return type.
4124         (target_translate_tls_address): Update.
4125         (target_announce_detach): Update.
4126         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4127         return type.
4128         (bsd_uthread_target::pid_to_str): Change return type.
4129         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4130         type.
4131         (bsd_kvm_target::pid_to_str): Change return type.
4132         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4133         return type.
4134         (aix_thread_target::pid_to_str): Change return type.
4135         * target.h (struct target_ops) <pid_to_str>: Change return type.
4136         (target_pid_to_str, normal_pid_to_str): Likewise.
4137         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4138         type.
4139         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4140         type.
4141         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4142         return type.
4143         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4144         type.
4145         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4146         type.
4147         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4148         return type.
4149
4150 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4151
4152         * NEWS: Mention that the new default MI version is 3.  Mention
4153         changes to the output of commands and events that deal with
4154         multi-location breakpoints.
4155         * breakpoint.c: Include "mi/mi-out.h".
4156         (print_one_breakpoint): Change output syntax if using MI version
4157         >= 3.
4158         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4159         New.
4160         (mi_multi_location_breakpoint_output_fixed): New.
4161         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4162         (mi_cmd_fix_multi_location_breakpoint_output): New.
4163         (mi_multi_location_breakpoint_output_fixed): New.
4164         * mi/mi-cmds.c (mi_cmds): Register command
4165         -fix-multi-location-breakpoint-output.
4166         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4167         interpreter "mi".
4168
4169 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4170
4171         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4172         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4173         instantiate mi_ui_out based on interpreter name.
4174         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4175         * mi/mi-main.c (mi_load_progress): Likewise.
4176
4177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4178
4179         * NEWS: Combine separate "New targets" sections for 8.3.
4180
4181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4182
4183         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4184         (ppcfbsd_init_abi): Install gdbarch
4185         "fetch_tls_load_module_address" and "get_thread_local_address"
4186         methods.
4187
4188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4189
4190         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4191         (riscv_fbsd_init_abi): Install gdbarch
4192         "fetch_tls_load_module_address" and "get_thread_local_address"
4193         methods.
4194
4195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4196
4197         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4198         (i386fbsd_init_abi): Install gdbarch
4199         "fetch_tls_load_module_address" and "get_thread_local_address"
4200         methods.
4201
4202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4203
4204         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4205         (amd64fbsd_init_abi): Install gdbarch
4206         "fetch_tls_load_module_address" and "get_thread_local_address"
4207         methods.
4208
4209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4210
4211         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4212         (struct fbsd_pspace_data): New type.
4213         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4214         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4215         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4216         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4217         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4218
4219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4220
4221         * gdbtypes.c (lookup_struct_elt): New function.
4222         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4223         * gdbtypes.h (struct struct_elt): New type.
4224         (lookup_struct_elt): New prototype.
4225
4226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4227
4228         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4229         remove disabled code block.
4230
4231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4232
4233         * gdbarch.sh (get_thread_local_address): New method.
4234         * gdbarch.h, gdbarch.c: Regenerate.
4235         * target.c (target_translate_tls_address): Use
4236         gdbarch_get_thread_local_address if present instead of
4237         target::get_thread_local_address.
4238
4239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4240
4241         * target.h (target::get_thread_local_address): Update comment.
4242
4243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4244
4245         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4246         objfile->separate_debug_objfile_backlink if not NULL.
4247
4248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4249
4250         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4251         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4252         (amd64bsd_store_inferior_registers): Likewise.
4253         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4254         Enable segment base registers.
4255         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4256         PT_GETFSBASE and PT_GETGSBASE.
4257         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4258         PT_SETGSBASE.
4259         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4260         segment base registers.
4261         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4262
4263 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4264
4265         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4266         Update calls to i386_target_description to add 'segments'
4267         parameter.
4268         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4269         add segment base registers.
4270         * arch/i386.c (i386_create_target_description): Add 'segments'
4271         parameter to enable segment base registers.
4272         * arch/i386.h (i386_create_target_description): Likewise.
4273         * features/i386/32bit-segments.xml: New file.
4274         * features/i386/32bit-segments.c: Generate.
4275         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4276         call to i386_target_description to add 'segments' parameter.
4277         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4278         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4279         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4280         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4281         if feature is present.
4282         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4283         Add 'segments' parameter to call to i386_target_description.
4284         (i386_target_description): Add 'segments' parameter to enable
4285         segment base registers.
4286         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4287         to call to i386_target_description.
4288         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4289         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4290         Define I386_NUM_REGS.
4291         (i386_target_description): Add 'segments' parameter to enable
4292         segment base registers.
4293
4294 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4295
4296         PR/24325
4297         * source-cache.c: #undef open and close, to avoid unresolved
4298         externals during linking.
4299
4300 2019-03-12  Tom Tromey  <tromey@adacore.com>
4301
4302         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4303         const.  Add initializers.
4304         (_initialize_remote): Don't initialize ptid globals.
4305
4306 2019-03-12  Pedro Alves  <palves@redhat.com>
4307
4308         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4309
4310 2019-03-12  Pedro Alves  <palves@redhat.com>
4311
4312         * cp-name-parser.y (main): Remove unused 'len' variable.
4313
4314 2019-03-12  Tom Tromey  <tromey@adacore.com>
4315
4316         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4317         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4318
4319 2019-03-12  Tom Tromey  <tromey@adacore.com>
4320
4321         * linux-nat.c (iterate_over_lwps): Update.
4322         (stop_callback): Remove parameter.
4323         (stop_wait_callback, detach_callback, resume_set_callback)
4324         (select_singlestep_lwp_callback, set_ignore_sigint)
4325         (status_callback, resumed_callback, resume_clear_callback)
4326         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4327         data parameter.
4328         (linux_nat_target::detach, linux_nat_target::resume)
4329         (linux_stop_and_wait_all_lwps, select_event_lwp)
4330         (linux_nat_filter_event, linux_nat_wait_1)
4331         (linux_nat_target::kill, linux_nat_target::stop)
4332         (linux_nat_target::stop): Update.
4333         (linux_nat_resume_callback): Change type.
4334         (resume_stopped_resumed_lwps, count_events_callback)
4335         (select_event_lwp_callback): Likewise.
4336         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4337         * arm-linux-nat.c (struct update_registers_data): Remove.
4338         (update_registers_callback): Change type.
4339         (arm_linux_insert_hw_breakpoint1): Update.
4340         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4341         parameter.
4342         (x86_linux_dr_set_addr): Update.
4343         (x86_linux_dr_set_control): Update.
4344         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4345         (iterate_over_lwps): Use gdb::function_view.
4346         * nat/aarch64-linux-hw-point.c (struct
4347         aarch64_dr_update_callback_param): Remove.
4348         (debug_reg_change_callback): Change type.
4349         (aarch64_notify_debug_reg_change): Update.
4350         * s390-linux-nat.c (s390_refresh_per_info): Update.
4351
4352 2019-03-11  Tom Tromey  <tromey@adacore.com>
4353
4354         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4355         redundant assignment to "this_cu".
4356
4357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4358
4359         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4360
4361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4362
4363         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4364         from...
4365         (rank_one_type): ... this.
4366
4367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4368
4369         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4370         from...
4371         (rank_one_type): ... this.
4372
4373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4374
4375         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4376         from...
4377         (rank_one_type): ... this.
4378
4379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4380
4381         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4382         from...
4383         (rank_one_type): ... this.
4384
4385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4386
4387         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4388         from...
4389         (rank_one_type): ... this.
4390
4391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4392
4393         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4394         from...
4395         (rank_one_type): ... this.
4396
4397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4398
4399         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4400         from...
4401         (rank_one_type): ... this.
4402
4403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4404
4405         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4406         from...
4407         (rank_one_type): ... this.
4408
4409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4410
4411         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4412         from...
4413         (rank_one_type): ... this.
4414
4415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4416
4417         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4418         from...
4419         (rank_one_type): ... this.
4420
4421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4422
4423         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4424         from...
4425         (rank_one_type): ... this.
4426
4427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4428
4429         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4430         from...
4431         (rank_one_type): ... this.
4432
4433 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4434
4435         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4436         inferior-events' shows the example events.
4437
4438 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4439
4440         Support styling on native MS-Windows console
4441
4442         PR/24315
4443         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4444         on MS-Windows if $TERM is not defined.
4445
4446         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4447
4448         * posix-hdep.c (gdb_console_fputs):
4449         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4450         functions.
4451         * ui-file.h (gdb_console_fputs): Add prototype.
4452
4453         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4454         back to fputs only if the former returns zero.
4455
4456 2019-03-07  Tom Tromey  <tom@tromey.com>
4457
4458         * symmisc.c (print_symbol_bcache_statistics): Update.
4459         (print_objfile_statistics): Update.
4460         * symfile.c (allocate_symtab): Update.
4461         * stabsread.c: Don't include bcache.h.
4462         * psymtab.h (struct psymbol_bcache): Don't declare.
4463         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4464         (psymbol_bcache_init, psymbol_bcache_free)
4465         (psymbol_bcache_get_bcache): Don't declare.
4466         * psymtab.c (struct psymbol_bcache): Remove.
4467         (psymtab_storage::psymtab_storage): Update.
4468         (psymtab_storage::~psymtab_storage): Update.
4469         (psymbol_bcache_init, psymbol_bcache_free)
4470         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4471         (add_psymbol_to_bcache): Update.
4472         (allocate_psymtab): Update.
4473         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4474         macro_cache>: No longer pointers.
4475         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4476         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4477         * macrotab.c (macro_bcache): Update.
4478         * macroexp.c: Don't include bcache.h.
4479         * gdbtypes.c (check_types_worklist): Update.
4480         (types_deeply_equal): Remove TRY/CATCH.  Update.
4481         * elfread.c (elf_symtab_read): Update.
4482         * dwarf2read.c: Don't include bcache.h.
4483         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4484         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4485         (print_bcache_statistics, bcache_memory_used): Don't declare.
4486         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4487         methods.  Rename all data members.
4488         * bcache.c (struct bcache): Move to bcache.h.
4489         (bcache::expand_hash_table): Rename from expand_hash_table.
4490         (bcache): Remove.
4491         (bcache::insert): Rename from bcache_full.
4492         (bcache::compare): Rename from bcache_compare.
4493         (bcache_xmalloc): Remove.
4494         (bcache::~bcache): Rename from bcache_xfree.
4495         (bcache::print_statistics): Rename from print_bcache_statistics.
4496         (bcache::memory_used): Rename from bcache_memory_used.
4497
4498 2019-03-07  Pedro Alves  <palves@redhat.com>
4499
4500         * infrun.c (normal_stop): Also check for
4501         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4502
4503 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * f-lang.c (value_from_host_double): Moved to...
4506         * value.c (value_from_host_double): ...here.
4507         * value.h (value_from_host_double): Declare.
4508         * guile/scm-math.c (vlscm_convert_typed_number): Use
4509         value_from_host_double.
4510         (vlscm_convert_number): Likewise.
4511         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4512         * python/py-value.c (convert_value_from_python): Likewise.
4513
4514 2019-03-06  Tom Tromey  <tom@tromey.com>
4515
4516         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4517
4518 2019-03-06  Tom Tromey  <tom@tromey.com>
4519
4520         * utils.h (free_current_contents): Don't declare.
4521         * utils.c (free_current_contents): Remove.
4522
4523 2019-03-06  Tom Tromey  <tom@tromey.com>
4524
4525         * top.c (quit_force): Update.
4526         * main.c (captured_command_loop): Update.
4527         * common/new-op.c (operator new): Update.
4528         * common/common-exceptions.c (struct catcher)
4529         <save_cleanup_chain>: Remove member.
4530         (exceptions_state_mc_init): Update.
4531         (exception_try_scope_entry): Return nullptr.
4532         (exception_try_scope_exit, exception_rethrow)
4533         (throw_exception_sjlj, throw_exception_cxx): Update.
4534         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4535         (all_cleanups, do_cleanups, discard_cleanups)
4536         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4537         (restore_cleanups, restore_final_cleanups): Don't declare.
4538         (do_final_cleanups): Remove parameter.
4539         * common/cleanups.c (cleanup_chain, make_cleanup)
4540         (make_cleanup_dtor, all_cleanups, do_cleanups)
4541         (discard_my_cleanups, discard_cleanups)
4542         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4543         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4544         (null_cleanup): Remove.
4545         (do_final_cleanups): Remove parameter.
4546
4547 2019-03-06  Tom Tromey  <tom@tromey.com>
4548
4549         * remote.c (remote_target::remote_parse_stop_reply): Use
4550         unique_xmalloc_ptr.
4551
4552 2019-03-06  Tom Tromey  <tom@tromey.com>
4553
4554         * stabsread.c (struct stabs_field_info): Rename from field_info.
4555         <list, fnlist>: Add initializers.
4556         <obstack>: New member.
4557         (read_member_functions, read_struct_fields, read_baseclasses):
4558         Allocate on obstack.  Don't use cleanups.
4559         (read_one_struct_field, read_member_functions, read_struct_fields)
4560         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4561         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4562         (read_struct_type): Update.
4563
4564 2019-03-06  Tom Tromey  <tom@tromey.com>
4565
4566         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4567         * common/filestuff.h (make_cleanup_close): Don't declare.
4568         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4569         Remove.
4570
4571 2019-03-06  Tom Tromey  <tom@tromey.com>
4572
4573         * solib-aix.c: Use make_scope_exit.
4574
4575 2019-03-06  Tom Tromey  <tom@tromey.com>
4576
4577         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4578         Use make_scope_exit.
4579
4580 2019-03-06  Tom Tromey  <tom@tromey.com>
4581
4582         * solib-svr4.c (disable_probes_interface): Remove parameter.
4583         (svr4_handle_solib_event): Use make_scope_exit.
4584
4585 2019-03-06  Tom Tromey  <tom@tromey.com>
4586
4587         * remote.c (struct stop_reply_deleter): Remove.
4588         (stop_reply_up): Update.
4589         (struct stop_reply): Derive from notif_event.  Don't typedef.
4590         <regcache>: Now a std::vector.
4591         (stop_reply_xfree): Remove.
4592         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4593         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4594         (remote_target::discard_pending_stop_replies): Use delete.
4595         (remote_target::remote_parse_stop_reply): Update.
4596         (remote_target::process_stop_reply): Update.
4597         * remote-notif.h (struct notif_event): Add virtual destructor.
4598         Remove "dtr" member.
4599         (struct notif_client) <alloc_event>: Return a unique_ptr.
4600         (notif_event_xfree): Don't declare.
4601         (notif_event_up): New typedef.
4602         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4603         (notif_event_xfree, do_notif_event_xfree): Remove.
4604         (remote_notif_state_xfree): Update.
4605
4606 2019-03-06  Tom Tromey  <tom@tromey.com>
4607
4608         * infrun.c (displaced_step_clear_cleanup): Now a
4609         forward_scope_exit type.
4610         (displaced_step_prepare_throw): Update.
4611         (displaced_step_fixup): Update.
4612
4613 2019-03-06  Tom Tromey  <tom@tromey.com>
4614
4615         * inferior.h (class inferior): Update comment.
4616         * gdbthread.h (class thread_info): Update comment.
4617
4618 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4619             Tom Tromey  <tom@tromey.com>
4620
4621         * stabsread.h (struct stab_section_list): Remove.
4622         (coffstab_build_psymtabs): Update.
4623         * dbxread.c (symbuf_sections): Now a std::vector.
4624         (sect_idx): New global.
4625         (fill_symbuf): Update.
4626         (coffstab_build_psymtabs): Change type of stabsects parameter.
4627         Update.
4628         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4629         std::vector.
4630         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4631         (coff_locate_sections): Update.
4632         (coff_symfile_read): Remove cleanups.  Update.
4633         (init_stringtab): Add storage parameter.
4634         (free_stringtab, free_stringtab_cleanup): Remove.
4635         (init_lineno): Add storage parameter.
4636         (free_linetab, free_linetab_cleanup): Remove.
4637
4638 2019-03-06  Pedro Alves  <palves@redhat.com>
4639
4640         * linux-fork.c (fork_info::clobber_regs): Delete.
4641         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4642         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4643         comment.  Adjust.
4644         (scoped_switch_fork_info::scoped_switch_fork_info)
4645         (checkpoint_command, linux_fork_context): Adjust
4646         fork_save_infrun_state calls.
4647
4648 2019-03-06  Pedro Alves  <palves@redhat.com>
4649
4650         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4651         (inf_has_multiple_threads): Return 'bool' and rewrite using
4652         inferior_info::threads().
4653
4654 2019-03-06  Pedro Alves  <palves@redhat.com>
4655
4656         * linux-fork.c: Include <list>.
4657         (fork_list): Now a std::list instance.
4658         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4659         (forks_exist_p, find_last_fork): Adjust.
4660         (new_fork): Delete.
4661         (one_fork_p): New.
4662         (add_fork): Adjust.
4663         (free_fork): Delete, folded into fork_info::~fork_info().
4664         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4665         Adjust.
4666         (init_fork_list): Delete.
4667         (linux_fork_killall, linux_fork_mourn_inferior)
4668         (linux_fork_detach, info_checkpoints_command): Adjust.
4669         (_initialize_linux_fork): No longer call init_fork_list.
4670
4671 2019-03-06  Pedro Alves  <palves@redhat.com>
4672
4673         * linux-fork.c (new_fork): New, split out of ...
4674         (add_fork): ... this.  Return void.  Move "first fork" special
4675         case from here, to ...
4676         (checkpoint_command): ... here.
4677         * linux-linux.h (add_fork): Return void.
4678
4679 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4680
4681         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4682
4683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4684             Chris January  <chris.january@arm.com>
4685             David Lecomber  <david.lecomber@arm.com>
4686
4687         * f-exp.y: New token, UNOP_INTRINSIC.
4688         (exp): New pattern using UNOP_INTRINSIC token.
4689         (f77_keywords): Add 'abs' keyword.
4690         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4691         (value_from_host_double): New function.
4692         (evaluate_subexp_f): Support UNOP_ABS.
4693
4694 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4695
4696         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4697         types.
4698
4699 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4702         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4703         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4704
4705 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4708
4709 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4710             Chris January  <chris.january@arm.com>
4711
4712         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4713         * f-exp.y: Define 'KIND' token.
4714         (exp): New pattern for KIND expressions.
4715         (ptype): Handle types with a kind extension.
4716         (direct_abs_decl): Extend to spot kind extensions.
4717         (f77_keywords): Add 'kind' to the list.
4718         (push_kind_type): New function.
4719         (convert_to_kind_type): New function.
4720         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4721         * parse.c (operator_length_standard): Likewise.
4722         * parser-defs.h (enum type_pieces): Add tp_kind.
4723         * std-operator.def: Add UNOP_KIND.
4724
4725 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * f-exp.y (f_parse): Set yydebug.
4728
4729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * f-lang.c (evaluate_subexp_f): New function.
4732         (exp_descriptor_f): New global.
4733         (f_language_defn): Use exp_descriptor_f instead of
4734         exp_descriptor_standard.
4735
4736 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * f-exp.y (struct token): Add comments.
4739         (dot_ops): Remove uppercase versions and the end marker.
4740         (f77_keywords): Likewise.
4741         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4742         entries in the dot_ops array are case insensitive, and use
4743         strncasecmp to compare strings.  Also some whitespace cleanup in
4744         this area.  Similar for the f77_keywords array, except entries in
4745         this list might be case sensitive.
4746
4747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * f-exp.y (struct f77_boolean_val): Add comments.
4750         (boolean_values): Remove uppercase versions, and end marker.
4751         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4752         and use strncasecmp to achieve case insensitivity.  Additionally,
4753         perform whitespace cleanup around this code.
4754
4755 2019-03-06  Tom Tromey  <tromey@adacore.com>
4756
4757         * remote-sim.c (gdbsim_target_open): Use result of
4758         gdb_argv::release.
4759
4760 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4761         Dirk Schubert  <dirk.schubert@arm.com>
4762         Chris January  <chris.january@arm.com>
4763
4764         * eval.c (evaluate_subexp_standard): Call Fortran argument
4765         wrapping logic.
4766         * f-lang.c (struct value): A value which can be passed into a
4767         Fortran function call.
4768         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4769         where appropriate.
4770         (struct type): Value ready for a Fortran function call.
4771         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4772         is needed.
4773         * f-lang.h (fortran_argument_convert): Declaration.
4774         (fortran_preserve_arg_pointer): Declaration.
4775         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4776
4777 2019-03-05  Tom Tromey  <tromey@adacore.com>
4778
4779         * python/py-prettyprint.c (print_string_repr): Remove #if.
4780         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4781
4782 2019-03-05  Tom Tromey  <tromey@adacore.com>
4783
4784         * target.c (the_dummy_target): Move later.  Change type to
4785         "dummy_target".
4786         (initialize_targets): Don't initialize the_dummy_target.
4787
4788 2019-03-05  Tom Tromey  <tromey@adacore.com>
4789
4790         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4791         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4792
4793 2019-03-05  Tom Tromey  <tromey@adacore.com>
4794
4795         * windows-nat.c (windows_nat_target::attach)
4796         (windows_nat_target::detach): Don't call gdb_flush.
4797         * valprint.c (generic_val_print, val_print, val_print_string):
4798         Don't call gdb_flush.
4799         * utils.c (defaulted_query): Don't call gdb_flush.
4800         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4801         * target.c (target_announce_detach): Don't call gdb_flush.
4802         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4803         * remote.c (extended_remote_target::attach): Don't call
4804         gdb_flush.
4805         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4806         * printcmd.c (do_examine): Don't call gdb_flush.
4807         (info_display_command): Don't call gdb_flush.
4808         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4809         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4810         * memattr.c (info_mem_command): Don't call gdb_flush.
4811         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4812         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4813         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4814         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4815         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4816         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4817         (gnu_nat_target::detach): Don't call gdb_flush.
4818         * f-valprint.c (f_val_print): Don't call gdb_flush.
4819         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4820         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4821         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4822         gdb_flush.
4823         * c-valprint.c (c_val_print): Don't call gdb_flush.
4824         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4825
4826 2019-03-05  Tom Tromey  <tromey@adacore.com>
4827
4828         * varobj.c (update_dynamic_varobj_children): Update.
4829         (install_default_visualizer): Use reset, not release.
4830         * value.c (set_internalvar): Update.
4831         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4832         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4833         ATTRIBUTE_UNUSED_RESULT.
4834
4835 2019-03-05  Tom Tromey  <tromey@adacore.com>
4836
4837         * remote.c (class scoped_remote_fd) <release>: Add
4838         ATTRIBUTE_UNUSED_RESULT.
4839
4840 2019-03-05  Tom Tromey  <tromey@adacore.com>
4841
4842         * macroexp.c (struct macro_buffer) <release>: Add
4843         ATTRIBUTE_UNUSED_RESULT.
4844
4845 2019-03-05  Tom Tromey  <tromey@adacore.com>
4846
4847         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4848         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4849         ATTRIBUTE_UNUSED_RESULT.
4850
4851 2019-03-05  Tom Tromey  <tromey@adacore.com>
4852
4853         * common/scoped_fd.h (class scoped_fd) <release>: Add
4854         ATTRIBUTE_UNUSED_RESULT.
4855
4856 2019-03-05  Tom Tromey  <tromey@adacore.com>
4857
4858         * parser-defs.h (struct parser_state) <release>: Add
4859         ATTRIBUTE_UNUSED_RESULT.
4860
4861 2019-03-05  Tom Tromey  <tromey@adacore.com>
4862
4863         * utils.h (class gdb_argv) <release>: Add
4864         ATTRIBUTE_UNUSED_RESULT.
4865         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4866
4867 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4868
4869         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4870         for-loop range, to avoid compiler warnings.
4871
4872         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4873         avoid compiler warnings about unused variables.
4874
4875         * NEWS: Mention end of support for native debugging on MS-Windows
4876         before XP.
4877
4878         PR gdb/24292
4879         * common/netstuff.c:
4880         * gdbserver/gdbreplay.c
4881         * gdbserver/remote-utils.c:
4882         * ser-tcp.c:
4883         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4884         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4885         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4886         'getaddrinfo' and 'freeaddrinfo' were not available before
4887         Windows XP, and mingw.org's MinGW headers by default define
4888         _WIN32_WINNT to 0x500.
4889
4890 2019-03-01  Gary Benson <gbenson@redhat.com>
4891
4892         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4893
4894 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4895             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4896
4897         PR gdb/8527
4898         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4899         set_sigint_trap, clear_sigint_trap.
4900
4901 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4902
4903         * target.c (target_detach): Clear the regcache and the
4904         frame cache.
4905
4906 2019-02-27  Pedro Alves  <palves@redhat.com>
4907
4908         * utils.c (set_screen_size): When we cap the height/width sizes,
4909         tweak the corresponding command variable to show "unlimited":
4910
4911 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4912             Pedro Alves  <palves@redhat.com>
4913
4914         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4915         before calling rl_set_screen_size.
4916
4917 2019-02-27  Tom Tromey  <tromey@adacore.com>
4918
4919         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4920         define.
4921         * python/py-value.c: Remove Python 2.4 workaround.
4922         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4923         workaround.
4924         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4925         Python 2.4 workaround.
4926         * python/python-internal.h: Remove Python 2.4 comment.
4927         (Py_ssize_t): Don't define.
4928         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4929         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4930         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4931         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4932         * python/python.c (do_start_initialization): Remove Python 2.4
4933         workaround.
4934         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4935         (print_children): Remove Python 2.4 workaround.
4936         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4937         workaround.
4938         (CHARBUFFERPROC_NAME): Remove.
4939         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4940         Python 2.4 workaround.
4941
4942 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4943
4944         * NEWS: Note minimum Python version.
4945
4946 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4947
4948         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4949         code from these functions.  Remove corresponding ifdefs.  Use
4950         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4951         Remove gotos and target of gotos.
4952         (infpy_search_memory): Likewise.
4953
4954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4957         (hppa_gdbarch_init): Don't register deleted functions with
4958         gdbarch.
4959
4960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4963         (h8300_unwind_sp): Delete.
4964         (h8300_dummy_id): Delete.
4965         (h8300_gdbarch_init): Don't register deleted functions with
4966         gdbarch.
4967
4968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4971         (ft32_unwind_pc): Delete.
4972         (ft32_unwind_sp): Delete.
4973         (ft32_gdbarch_init): Don't register deleted functions with
4974         gdbarch.
4975
4976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4979         (frv_unwind_pc): Delete.
4980         (frv_unwind_sp): Delete.
4981         (frv_gdbarch_init): Don't register deleted functions with
4982         gdbarch.
4983
4984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4987         (riscv_unwind_pc): Delete.
4988         (riscv_unwind_sp): Delete.
4989         (riscv_gdbarch_init): Don't register deleted functions with
4990         gdbarch.
4991
4992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4995         (csky_unwind_pc): Delete.
4996         (csky_unwind_sp): Delete.
4997         (csky_gdbarch_init): Don't register deleted functions with
4998         gdbarch.
4999
5000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5003         (cris_unwind_pc): Delete.
5004         (cris_unwind_sp): Delete.
5005         (cris_gdbarch_init): Don't register deleted functions with
5006         gdbarch.
5007
5008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5011         (bfin_unwind_pc): Delete.
5012         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5013
5014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5015
5016         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5017         (arm_unwind_pc): Delete.
5018         (arm_unwind_sp): Delete.
5019         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5020
5021 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5024         (arc_unwind_pc): Delete.
5025         (arc_unwind_sp): Delete.
5026         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5027
5028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5031         (alpha_unwind_pc): Delete.
5032         (alpha_gdbarch_init): Don't register deleted functions with
5033         gdbarch.
5034
5035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5038         (aarch64_unwind_pc): Delete.
5039         (aarch64_unwind_sp): Delete.
5040         (aarch64_gdbarch_init): Don't register deleted functions with
5041         gdbarch.
5042
5043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * gdbtypes.c (type_align): Don't consider static members when
5046         computing structure alignment.
5047
5048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5051         return 0 for other types.
5052         * arch-utils.c (default_type_align): Always return 0.
5053         * gdbarch.h: Regenerate.
5054         * gdbarch.sh (type_align): Extend comment.
5055         * gdbtypes.c (type_align): Add additional comments, always call
5056         gdbarch_type_align before applying the default rules.
5057         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5058         generic code will then apply a suitable default.
5059         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5060         types, return 0 for other types.
5061
5062 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5063
5064         * NEWS: Create a new section for the next release branch.
5065         Rename the section of the current branch, now that it has
5066         been cut.
5067
5068 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5069
5070         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5071         * version.in: Bump version to 8.3.50.DATE-git.
5072
5073 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5074
5075         * aix-thread.c (ptid_cmp): Remove unused variable.
5076         (get_signaled_thread): Likewise.
5077         (store_regs_user_thread): Likewise.
5078         (store_regs_kernel_thread): Likewise.
5079         (fetch_regs_kernel_thread): Remove shadowed variable.
5080
5081 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * features/riscv/32bit-cpu.xml: Add register numbers.
5084         * features/riscv/32bit-fpu.c: Regenerate.
5085         * features/riscv/32bit-fpu.xml: Add register numbers.
5086         * features/riscv/64bit-cpu.xml: Add register numbers.
5087         * features/riscv/64bit-fpu.c: Regenerate.
5088         * features/riscv/64bit-fpu.xml: Add register numbers.
5089
5090 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5091
5092         * NEWS: Mention two argument form of gdb.Value constructor.
5093         * python/py-value.c (convert_buffer_and_type_to_value): New
5094         function.
5095         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5096         Add support for handling an optional second argument.  Call
5097         convert_buffer_and_type_to_value as appropriate.
5098         * python/python-internal.h (Py_buffer_deleter): New struct.
5099         (Py_buffer_up): New typedef.
5100
5101 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5102
5103         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5104         instead of releasing ownership.
5105
5106 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5107
5108         * dwarf2read.c (open_and_init_dwp_file): Call
5109         elf_numsections instead of bfd_count_sections to initialize
5110         dwp_file->num_sections.
5111
5112 2019-02-25  Tom Tromey  <tromey@adacore.com>
5113
5114         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5115
5116 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5117
5118         * gcore.in: Add '--readnever' option when invoking GDB.
5119
5120 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5121
5122         * MAINTAINERS: Update my email address.
5123
5124 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5125
5126         * build-id.c (build_id_to_debug_bfd_1): New function.
5127         (build_id_to_debug_bfd): Look for separate debug file in
5128         sysroot.
5129
5130 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5131
5132         * gdbarch.sh: Update the copyright year range that is placed into
5133         generated files.
5134
5135 2019-02-22  Keith Seitz  <keiths@redhat.com>
5136
5137         PR symtab/23853
5138         * linespec.c (create_sals_line_offset): Search for the default
5139         symtab's filename instead of its fullname.
5140
5141 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5142
5143         * NEWS: Update style defaults.
5144
5145 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5146
5147         * main.c (captured_main_1): Disable styling in batch mode.
5148
5149 2019-02-20  Tom Tromey  <tom@tromey.com>
5150
5151         * symtab.c (symtab_symbol_info): Fix typos.
5152
5153 2019-02-20  Tom Tromey  <tromey@adacore.com>
5154
5155         * findcmd.c (_initialize_mem_search): Use upper case for
5156         metasyntactic variables.
5157
5158 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5159
5160         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5161         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5162
5163 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5164
5165         * top.h (source_file_name): Change to std::string.
5166         * top.c (source_file_name): Likewise.
5167         (command_line_input): Adjust.
5168         * cli/cli-script.c (script_from_file): Adjust.
5169
5170 2019-02-19  Tom Tromey  <tromey@adacore.com>
5171
5172         * ravenscar-thread.c
5173         (ravenscar_thread_target::update_thread_list): Don't call
5174         ada_build_task_list.
5175         * ada-lang.h (ada_build_task_list): Don't declare.
5176         * ada-tasks.c (struct ada_tasks_inferior_data)
5177         <task_list_valid_p>: Now bool.
5178         (read_known_tasks, ada_task_list_changed)
5179         (ada_tasks_invalidate_inferior_data): Update.
5180         (read_known_tasks_array): Return bool.
5181         (read_known_tasks_list): Likewise.
5182         (read_known_tasks): Return void.
5183         (ada_build_task_list): Now static.
5184
5185 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5188         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5189
5190 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5191
5192         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5193         variant for ada_tasks_pspace_data_handle and
5194         ada_tasks_inferior_data_handle.
5195         (ada_tasks_pspace_data_cleanup): New function.
5196         (ada_tasks_inferior_data_cleanup): New function.
5197
5198 2019-02-17  Tom Tromey  <tom@tromey.com>
5199
5200         * macrotab.h (macro_source_fullname): Return a std::string.
5201         * macrotab.c (macro_include, check_for_redefinition)
5202         (macro_undef, macro_lookup_definition, foreach_macro)
5203         (foreach_macro_in_scope): Update.
5204         (macro_source_fullname): Return a std::string.
5205         * macrocmd.c (show_pp_source_pos): Update.
5206
5207 2019-02-17  Tom Tromey  <tom@tromey.com>
5208
5209         * macrocmd.c (show_pp_source_pos): Style the file names.
5210
5211 2019-02-17  Tom Tromey  <tom@tromey.com>
5212
5213         PR tui/24197:
5214         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5215
5216 2019-02-17  Tom Tromey  <tom@tromey.com>
5217
5218         * ada-lang.c (user_select_syms): Use filtered printing.
5219         * utils.c (wrap_style): New global.
5220         (desired_style): Remove.
5221         (emit_style_escape): Add stream parameter.
5222         (set_output_style, reset_terminal_style, prompt_for_continue):
5223         Update.
5224         (flush_wrap_buffer): Only flush gdb_stdout.
5225         (wrap_here): Set wrap_style.
5226         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5227         treat escape sequences as a character.  Change when wrap buffer is
5228         flushed.
5229         (fputs_styled): Do not set the output style when the default is
5230         requested.
5231         * ui-style.h (struct ui_file_style) <is_default>: New method.
5232         * source.c (print_source_lines_base): Emit escape sequences in one
5233         piece.
5234
5235 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5236
5237         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5238         integers and enumeration types.
5239
5240 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5241
5242         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5243         instead of lookup_symbol_in_language
5244         (do_exact_match): New function.
5245         (ada_get_symbol_name_matcher): Return do_exact_match when
5246         doing a verbatim match.
5247
5248 2019-02-15  Tom Tromey  <tromey@adacore.com>
5249
5250         * ravenscar-thread.c (ravenscar_thread_target::resume)
5251         (ravenscar_thread_target::wait): Special case wildcard requests.
5252
5253 2019-02-15  Tom Tromey  <tromey@adacore.com>
5254
5255         * ravenscar-thread.c (base_ptid): Remove.
5256         (struct ravenscar_thread_target) <close>: New method.
5257         <m_base_ptid>: New member.
5258         <update_inferior_ptid, active_task, task_is_currently_active,
5259         runtime_initialized>: Declare methods.
5260         <ravenscar_thread_target>: Add constructor.
5261         (ravenscar_thread_target::task_is_currently_active)
5262         (ravenscar_thread_target::update_inferior_ptid)
5263         (ravenscar_runtime_initialized): Rename.  Now methods.
5264         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5265         (ravenscar_thread_target::update_thread_list): Update.
5266         (ravenscar_thread_target::active_task): Now method.
5267         (ravenscar_thread_target::store_registers)
5268         (ravenscar_thread_target::prepare_to_store)
5269         (ravenscar_thread_target::prepare_to_store)
5270         (ravenscar_thread_target::mourn_inferior): Update.
5271         (ravenscar_inferior_created): Use "new" to create target.
5272         (ravenscar_thread_target::get_ada_task_ptid): Update.
5273         (_initialize_ravenscar): Don't initialize base_ptid.
5274         (ravenscar_ops): Remove global.
5275
5276 2019-02-15  Tom Tromey  <tromey@adacore.com>
5277
5278         * target.h (push_target): Declare new overload.
5279         * target.c (push_target): New overload, taking an rvalue reference.
5280         * remote.c (remote_target::open_1): Use push_target overload.
5281         * corelow.c (core_target_open): Use push_target overload.
5282
5283 2019-02-15  Tom Tromey  <tromey@adacore.com>
5284
5285         * ravenscar-thread.c (is_ravenscar_task)
5286         (ravenscar_task_is_currently_active): Return bool.
5287         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5288         (_initialize_ravenscar): Remove "(void)".
5289         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5290         Return bool.
5291
5292 2019-02-15  Tom Tromey  <tromey@adacore.com>
5293
5294         * ravenscar-thread.c (ravenscar_runtime_initializer)
5295         (has_ravenscar_runtime, get_running_thread_id)
5296         (ravenscar_thread_target::resume): Fix indentation.
5297
5298 2019-02-15  Tom Tromey  <tromey@adacore.com>
5299
5300         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5301         from ravenscar_arch_ops.
5302         (sparc_ravenscar_ops::fetch_registers)
5303         (sparc_ravenscar_ops::store_registers): Now methods.
5304         (sparc_ravenscar_prepare_to_store): Remove.
5305         (sparc_ravenscar_ops): Redefine.
5306         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5307         methods and destructor.  Remove members.
5308         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5309         (ravenscar_thread_target::store_registers)
5310         (ravenscar_thread_target::prepare_to_store): Update.
5311         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5312         Remove.
5313         (struct ppc_ravenscar_powerpc_ops): Derive from
5314         ravenscar_arch_ops.
5315         (ppc_ravenscar_powerpc_ops::fetch_registers)
5316         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5317         (ppc_ravenscar_powerpc_ops): Redefine.
5318         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5319         (ppc_ravenscar_e500_ops::fetch_registers)
5320         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5321         (ppc_ravenscar_e500_ops): Redefine.
5322         * aarch64-ravenscar-thread.c
5323         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5324         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5325         (aarch64_ravenscar_fetch_registers)
5326         (aarch64_ravenscar_store_registers): Now methods.
5327         (aarch64_ravenscar_ops): Redefine.
5328
5329 2019-02-15  Tom Tromey  <tromey@adacore.com>
5330
5331         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5332         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5333         (ravenscar_thread_target::stopped_by_watchpoint)
5334         (ravenscar_thread_target::stopped_data_address)
5335         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5336
5337 2019-02-15  Tom Tromey  <tromey@adacore.com>
5338
5339         * ravenscar-thread.c: Fix some typos.
5340
5341 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5342             Tom Tromey  <tromey@adacore.com>
5343
5344         * ada-lang.c (ada_exception_sal): Change addr_string to a
5345         std::string.
5346         (create_ada_exception_catchpoint): Update.
5347
5348 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5349             Tom Tromey  <tromey@adacore.com>
5350
5351         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5352         (bp_location_ops): Remove.
5353         (base_breakpoint_allocate_location): Update.
5354         (free_bp_location): Update.
5355         * ada-lang.c (class ada_catchpoint_location)
5356         <ada_catchpoint_location>: Remove ops parameter.
5357         (ada_catchpoint_location_dtor): Remove.
5358         (ada_catchpoint_location_ops): Remove.
5359         (allocate_location_exception): Update.
5360         * breakpoint.h (struct bp_location_ops): Remove.
5361         (class bp_location) <bp_location>: Remove bp_location_ops
5362         parameter.
5363         <~bp_location>: Add destructor.
5364         <ops>: Remove.
5365
5366 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5367             Pedro Alves  <palves@redhat.com>
5368
5369         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5370         'PATH_MAX'.
5371
5372 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5373             Samuel Thibault  <samuel.thibault@gnu.org>
5374             Thomas Schwinge  <thomas@codesourcery.com>
5375
5376         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5377         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5378
5379 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5380
5381         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5382         (check_empty): Use "const char *".
5383
5384         * gnu-nat.c (gnu_nat_target::detach): Instead of
5385         'detach_inferior (pid)' call
5386         'detach_inferior (find_inferior_pid (pid))'.
5387
5388         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5389         'nat/fork-inferior.o'.
5390         * gnu-nat.c: #include "nat/fork-inferior.h".
5391
5392         * gnu-nat.c (gnu_nat_target::detach): Instead of
5393         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5394         * gnu-nat.h: #include "inf-child.h".
5395         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5396         'i386_gnu_nat_target::fetch_registers'.
5397         (gnu_store_registers): Rename/move to
5398         'i386_gnu_nat_target::store_registers'.
5399
5400         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5401         * gnu-nat.h (mach_thread_info): New function.
5402         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5403
5404         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5405
5406 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5407
5408         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5409
5410 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5411
5412         * windows-nat.c (windows_add_thread): Add new parameter
5413         "main_thread_p" with default value set to false.  Update
5414         function documentation as well as all callers.
5415         (windows_delete_thread): Likewise.
5416         (fake_create_process): Update call to windows_add_thread.
5417         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5418         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5419         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5420         call to windows_delete_thread.
5421
5422 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5423
5424         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5425
5426 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5427
5428         * symfile.c (find_separate_debug_file): Use canonical path of
5429         sysroot with child_path instead of gdb_sysroot if it is valid.
5430
5431 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5432
5433         * symfile.c (find_separate_debug_file): Use child_path to
5434         determine if an object file is under a sysroot.
5435
5436 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5437
5438         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5439         unittests/child-path-selftests.c.
5440         * common/pathstuff.c (child_path): New function.
5441         * common/pathstuff.h (child_path): New prototype.
5442         * unittests/child-path-selftests.c: New file.
5443
5444 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5445
5446         * symfile.c (find_separate_debug_file): Look for separate debug
5447         files in debug directories under the sysroot.
5448
5449 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5450
5451         * symtab.h (struct minimal_symbol data_p): New const method.
5452         (struct minimal_symbol text_p): Likewise.
5453         * symtab.c (output_source_filename): Use file name style
5454         to print file name.
5455         (print_symbol_info): Likewise.
5456         (print_msymbol_info): Use address style to print addresses.
5457         Use function name style to print executable text symbols.
5458         (expand_symtab_containing_pc): Use data_p.
5459         (find_pc_sect_compunit_symtab): Likewise.
5460
5461 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5462
5463         * breakpoint.c (describe_other_breakpoints): Use address style
5464         to print addresses.
5465         (say_where): Likewise.
5466
5467 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5468
5469         * ada-typeprint.c (print_func_type): Print function name
5470         style to print function name.
5471         * c-typeprint.c (c_print_type_1): Likewise.
5472
5473 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5474
5475         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5476         for execve.
5477
5478 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5479
5480         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5481         type_stack.
5482
5483 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5484
5485         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5486         TYPE_CODE_REF types.
5487
5488 2019-02-08  Jim Wilson  <jimw@sifive.com>
5489
5490         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5491         (riscv_linux_fregset): New.
5492         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5493
5494 2019-02-07  Tom Tromey  <tom@tromey.com>
5495
5496         * thread.c (thread_cancel_execution_command): Update.
5497         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5498         methods.
5499         (struct thread_fsm_ops): Remove.
5500         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5501         (thread_fsm_should_stop, thread_fsm_return_value)
5502         (thread_fsm_set_finished, thread_fsm_finished_p)
5503         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5504         Don't declare.
5505         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5506         * infrun.c (clear_proceed_status_thread)
5507         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5508         (print_stop_event): Update.
5509         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5510         Add constructor.
5511         (step_command_fsm_ops): Remove.
5512         (new_step_command_fsm): Remove.
5513         (step_1): Update.
5514         (step_command_fsm::should_stop): Rename from
5515         step_command_fsm_should_stop.
5516         (step_command_fsm::clean_up): Rename from
5517         step_command_fsm_clean_up.
5518         (step_command_fsm::do_async_reply_reason): Rename from
5519         step_command_fsm_async_reply_reason.
5520         (struct until_next_fsm): Inherit from thread_fsm.  Add
5521         constructor.
5522         (until_next_fsm_ops): Remove.
5523         (new_until_next_fsm): Remove.
5524         (until_next_fsm::should_stop): Rename from
5525         until_next_fsm_should_stop.
5526         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5527         (until_next_fsm::do_async_reply_reason): Rename from
5528         until_next_fsm_async_reply_reason.
5529         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5530         constructor.  Change type of breakpoint.
5531         (finish_command_fsm_ops): Remove.
5532         (new_finish_command_fsm): Remove.
5533         (finish_command_fsm::should_stop): Rename from
5534         finish_command_fsm_should_stop.
5535         (finish_command_fsm::clean_up): Rename from
5536         finish_command_fsm_clean_up.
5537         (finish_command_fsm::return_value): Rename from
5538         finish_command_fsm_return_value.
5539         (finish_command_fsm::do_async_reply_reason): Rename from
5540         finish_command_fsm_async_reply_reason.
5541         (finish_command): Update.
5542         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5543         Add constructor.
5544         (call_thread_fsm_ops): Remove.
5545         (call_thread_fsm::call_thread_fsm): Rename from
5546         new_call_thread_fsm.
5547         (call_thread_fsm::should_stop): Rename from
5548         call_thread_fsm_should_stop.
5549         (call_thread_fsm::should_notify_stop): Rename from
5550         call_thread_fsm_should_notify_stop.
5551         (run_inferior_call, call_function_by_hand_dummy): Update.
5552         * cli/cli-interp.c (should_print_stop_to_console): Update.
5553         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5554         Add constructor.  Change type of location_breakpoint,
5555         caller_breakpoint.
5556         (until_break_fsm_ops): Remove.
5557         (new_until_break_fsm): Remove.
5558         (until_break_fsm::should_stop): Rename from
5559         until_break_fsm_should_stop.
5560         (until_break_fsm::clean_up): Rename from
5561         until_break_fsm_clean_up.
5562         (until_break_fsm::do_async_reply_reason): Rename from
5563         until_break_fsm_async_reply_reason.
5564         (until_break_command): Update.
5565         * thread-fsm.c: Remove.
5566         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5567
5568 2019-02-07  Tom Tromey  <tom@tromey.com>
5569
5570         * yy-remap.h: Add include guard.
5571         * xtensa-tdep.h: Add include guard.
5572         * xcoffread.h: Rename include guard.
5573         * varobj-iter.h: Add include guard.
5574         * tui/tui.h: Rename include guard.
5575         * tui/tui-winsource.h: Rename include guard.
5576         * tui/tui-wingeneral.h: Rename include guard.
5577         * tui/tui-windata.h: Rename include guard.
5578         * tui/tui-win.h: Rename include guard.
5579         * tui/tui-stack.h: Rename include guard.
5580         * tui/tui-source.h: Rename include guard.
5581         * tui/tui-regs.h: Rename include guard.
5582         * tui/tui-out.h: Rename include guard.
5583         * tui/tui-layout.h: Rename include guard.
5584         * tui/tui-io.h: Rename include guard.
5585         * tui/tui-hooks.h: Rename include guard.
5586         * tui/tui-file.h: Rename include guard.
5587         * tui/tui-disasm.h: Rename include guard.
5588         * tui/tui-data.h: Rename include guard.
5589         * tui/tui-command.h: Rename include guard.
5590         * tic6x-tdep.h: Add include guard.
5591         * target/waitstatus.h: Rename include guard.
5592         * target/wait.h: Rename include guard.
5593         * target/target.h: Rename include guard.
5594         * target/resume.h: Rename include guard.
5595         * target-float.h: Rename include guard.
5596         * stabsread.h: Add include guard.
5597         * rs6000-tdep.h: Add include guard.
5598         * riscv-fbsd-tdep.h: Add include guard.
5599         * regformats/regdef.h: Rename include guard.
5600         * record.h: Rename include guard.
5601         * python/python.h: Rename include guard.
5602         * python/python-internal.h: Rename include guard.
5603         * python/py-stopevent.h: Rename include guard.
5604         * python/py-ref.h: Rename include guard.
5605         * python/py-record.h: Rename include guard.
5606         * python/py-record-full.h: Rename include guard.
5607         * python/py-record-btrace.h: Rename include guard.
5608         * python/py-instruction.h: Rename include guard.
5609         * python/py-events.h: Rename include guard.
5610         * python/py-event.h: Rename include guard.
5611         * procfs.h: Add include guard.
5612         * proc-utils.h: Add include guard.
5613         * p-lang.h: Add include guard.
5614         * or1k-tdep.h: Rename include guard.
5615         * observable.h: Rename include guard.
5616         * nto-tdep.h: Rename include guard.
5617         * nat/x86-linux.h: Rename include guard.
5618         * nat/x86-linux-dregs.h: Rename include guard.
5619         * nat/x86-gcc-cpuid.h: Add include guard.
5620         * nat/x86-dregs.h: Rename include guard.
5621         * nat/x86-cpuid.h: Rename include guard.
5622         * nat/ppc-linux.h: Rename include guard.
5623         * nat/mips-linux-watch.h: Rename include guard.
5624         * nat/linux-waitpid.h: Rename include guard.
5625         * nat/linux-ptrace.h: Rename include guard.
5626         * nat/linux-procfs.h: Rename include guard.
5627         * nat/linux-osdata.h: Rename include guard.
5628         * nat/linux-nat.h: Rename include guard.
5629         * nat/linux-namespaces.h: Rename include guard.
5630         * nat/linux-btrace.h: Rename include guard.
5631         * nat/glibc_thread_db.h: Rename include guard.
5632         * nat/gdb_thread_db.h: Rename include guard.
5633         * nat/gdb_ptrace.h: Rename include guard.
5634         * nat/fork-inferior.h: Rename include guard.
5635         * nat/amd64-linux-siginfo.h: Rename include guard.
5636         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5637         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5638         * nat/aarch64-linux.h: Rename include guard.
5639         * nat/aarch64-linux-hw-point.h: Rename include guard.
5640         * mn10300-tdep.h: Add include guard.
5641         * mips-linux-tdep.h: Add include guard.
5642         * mi/mi-parse.h: Rename include guard.
5643         * mi/mi-out.h: Rename include guard.
5644         * mi/mi-main.h: Rename include guard.
5645         * mi/mi-interp.h: Rename include guard.
5646         * mi/mi-getopt.h: Rename include guard.
5647         * mi/mi-console.h: Rename include guard.
5648         * mi/mi-common.h: Rename include guard.
5649         * mi/mi-cmds.h: Rename include guard.
5650         * mi/mi-cmd-break.h: Rename include guard.
5651         * m2-lang.h: Add include guard.
5652         * location.h: Rename include guard.
5653         * linux-record.h: Rename include guard.
5654         * linux-nat.h: Add include guard.
5655         * linux-fork.h: Add include guard.
5656         * i386-darwin-tdep.h: Rename include guard.
5657         * hppa-linux-offsets.h: Add include guard.
5658         * guile/guile.h: Rename include guard.
5659         * guile/guile-internal.h: Rename include guard.
5660         * gnu-nat.h: Rename include guard.
5661         * gdb-stabs.h: Rename include guard.
5662         * frv-tdep.h: Add include guard.
5663         * f-lang.h: Add include guard.
5664         * event-loop.h: Add include guard.
5665         * darwin-nat.h: Rename include guard.
5666         * cp-abi.h: Rename include guard.
5667         * config/sparc/nm-sol2.h: Rename include guard.
5668         * config/nm-nto.h: Rename include guard.
5669         * config/nm-linux.h: Add include guard.
5670         * config/i386/nm-i386gnu.h: Rename include guard.
5671         * config/djgpp/nl_types.h: Rename include guard.
5672         * config/djgpp/langinfo.h: Rename include guard.
5673         * compile/gcc-cp-plugin.h: Add include guard.
5674         * compile/gcc-c-plugin.h: Add include guard.
5675         * compile/compile.h: Rename include guard.
5676         * compile/compile-object-run.h: Rename include guard.
5677         * compile/compile-object-load.h: Rename include guard.
5678         * compile/compile-internal.h: Rename include guard.
5679         * compile/compile-cplus.h: Rename include guard.
5680         * compile/compile-c.h: Rename include guard.
5681         * common/xml-utils.h: Rename include guard.
5682         * common/x86-xstate.h: Rename include guard.
5683         * common/version.h: Rename include guard.
5684         * common/vec.h: Rename include guard.
5685         * common/tdesc.h: Rename include guard.
5686         * common/selftest.h: Rename include guard.
5687         * common/scoped_restore.h: Rename include guard.
5688         * common/scoped_mmap.h: Rename include guard.
5689         * common/scoped_fd.h: Rename include guard.
5690         * common/safe-iterator.h: Rename include guard.
5691         * common/run-time-clock.h: Rename include guard.
5692         * common/refcounted-object.h: Rename include guard.
5693         * common/queue.h: Rename include guard.
5694         * common/ptid.h: Rename include guard.
5695         * common/print-utils.h: Rename include guard.
5696         * common/preprocessor.h: Rename include guard.
5697         * common/pathstuff.h: Rename include guard.
5698         * common/observable.h: Rename include guard.
5699         * common/netstuff.h: Rename include guard.
5700         * common/job-control.h: Rename include guard.
5701         * common/host-defs.h: Rename include guard.
5702         * common/gdb_wait.h: Rename include guard.
5703         * common/gdb_vecs.h: Rename include guard.
5704         * common/gdb_unlinker.h: Rename include guard.
5705         * common/gdb_unique_ptr.h: Rename include guard.
5706         * common/gdb_tilde_expand.h: Rename include guard.
5707         * common/gdb_sys_time.h: Rename include guard.
5708         * common/gdb_string_view.h: Rename include guard.
5709         * common/gdb_splay_tree.h: Rename include guard.
5710         * common/gdb_setjmp.h: Rename include guard.
5711         * common/gdb_ref_ptr.h: Rename include guard.
5712         * common/gdb_optional.h: Rename include guard.
5713         * common/gdb_locale.h: Rename include guard.
5714         * common/gdb_assert.h: Rename include guard.
5715         * common/filtered-iterator.h: Rename include guard.
5716         * common/filestuff.h: Rename include guard.
5717         * common/fileio.h: Rename include guard.
5718         * common/environ.h: Rename include guard.
5719         * common/common-utils.h: Rename include guard.
5720         * common/common-types.h: Rename include guard.
5721         * common/common-regcache.h: Rename include guard.
5722         * common/common-inferior.h: Rename include guard.
5723         * common/common-gdbthread.h: Rename include guard.
5724         * common/common-exceptions.h: Rename include guard.
5725         * common/common-defs.h: Rename include guard.
5726         * common/common-debug.h: Rename include guard.
5727         * common/cleanups.h: Rename include guard.
5728         * common/buffer.h: Rename include guard.
5729         * common/btrace-common.h: Rename include guard.
5730         * common/break-common.h: Rename include guard.
5731         * cli/cli-utils.h: Rename include guard.
5732         * cli/cli-style.h: Rename include guard.
5733         * cli/cli-setshow.h: Rename include guard.
5734         * cli/cli-script.h: Rename include guard.
5735         * cli/cli-interp.h: Rename include guard.
5736         * cli/cli-decode.h: Rename include guard.
5737         * cli/cli-cmds.h: Rename include guard.
5738         * charset-list.h: Add include guard.
5739         * buildsym-legacy.h: Rename include guard.
5740         * bfin-tdep.h: Add include guard.
5741         * ax.h: Rename include guard.
5742         * arm-linux-tdep.h: Add include guard.
5743         * arm-fbsd-tdep.h: Add include guard.
5744         * arch/xtensa.h: Rename include guard.
5745         * arch/tic6x.h: Add include guard.
5746         * arch/i386.h: Add include guard.
5747         * arch/arm.h: Rename include guard.
5748         * arch/arm-linux.h: Rename include guard.
5749         * arch/arm-get-next-pcs.h: Rename include guard.
5750         * arch/amd64.h: Add include guard.
5751         * arch/aarch64-insn.h: Rename include guard.
5752         * arch-utils.h: Rename include guard.
5753         * annotate.h: Add include guard.
5754         * amd64-darwin-tdep.h: Rename include guard.
5755         * aarch64-linux-tdep.h: Add include guard.
5756         * aarch64-fbsd-tdep.h: Add include guard.
5757         * aarch32-linux-nat.h: Add include guard.
5758
5759 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5760
5761         * macrotab.c (macro_define_internal): New function that
5762         factorizes macro_define_object_internal and macro_define_function
5763         code.
5764         (macro_define_object_internal): Use macro_define_internal.
5765         (macro_define_function): Likewise.
5766
5767 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5768
5769         * macrocmd.c (extract_identifier): Return
5770         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5771         callers.
5772
5773 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5774
5775         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5776
5777 2019-02-05  Tom Tromey  <tom@tromey.com>
5778
5779         * target.c (target_stack::unpush): Move assertion earlier.
5780
5781 2019-01-30  Tom Tromey  <tom@tromey.com>
5782
5783         PR python/23615:
5784         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5785         (gdbpy_parse_and_eval): Likewise.
5786         * python/python-internal.h (gdbpy_allow_threads): New class.
5787
5788 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5789
5790         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5791         (aarch64_fbsd_fpregmap): Move earlier.
5792         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5793         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5794         instead of individual calls to trad_frame_set_reg_addr.
5795         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5796         earlier.
5797         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5798         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5799         instead of individual calls to trad_frame_set_reg_addr.
5800
5801 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5802
5803         * CONTRIBUTE: Replace contribution list with wiki link.
5804
5805 2019-01-25  Tom Tromey  <tom@tromey.com>
5806
5807         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5808
5809 2019-01-25  Tom Tromey  <tom@tromey.com>
5810
5811         * xtensa-linux-nat.c: Fix common/ includes.
5812         * xml-support.h: Fix common/ includes.
5813         * xml-support.c: Fix common/ includes.
5814         * x86-linux-nat.c: Fix common/ includes.
5815         * windows-nat.c: Fix common/ includes.
5816         * varobj.h: Fix common/ includes.
5817         * varobj.c: Fix common/ includes.
5818         * value.c: Fix common/ includes.
5819         * valops.c: Fix common/ includes.
5820         * utils.c: Fix common/ includes.
5821         * unittests/xml-utils-selftests.c: Fix common/ includes.
5822         * unittests/utils-selftests.c: Fix common/ includes.
5823         * unittests/unpack-selftests.c: Fix common/ includes.
5824         * unittests/tracepoint-selftests.c: Fix common/ includes.
5825         * unittests/style-selftests.c: Fix common/ includes.
5826         * unittests/string_view-selftests.c: Fix common/ includes.
5827         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5828         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5829         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5830         * unittests/rsp-low-selftests.c: Fix common/ includes.
5831         * unittests/parse-connection-spec-selftests.c: Fix common/
5832         includes.
5833         * unittests/optional-selftests.c: Fix common/ includes.
5834         * unittests/offset-type-selftests.c: Fix common/ includes.
5835         * unittests/observable-selftests.c: Fix common/ includes.
5836         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5837         * unittests/memrange-selftests.c: Fix common/ includes.
5838         * unittests/memory-map-selftests.c: Fix common/ includes.
5839         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5840         * unittests/function-view-selftests.c: Fix common/ includes.
5841         * unittests/environ-selftests.c: Fix common/ includes.
5842         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5843         * unittests/common-utils-selftests.c: Fix common/ includes.
5844         * unittests/cli-utils-selftests.c: Fix common/ includes.
5845         * unittests/array-view-selftests.c: Fix common/ includes.
5846         * ui-file.c: Fix common/ includes.
5847         * tui/tui-io.c: Fix common/ includes.
5848         * tracepoint.h: Fix common/ includes.
5849         * tracepoint.c: Fix common/ includes.
5850         * tracefile-tfile.c: Fix common/ includes.
5851         * top.h: Fix common/ includes.
5852         * top.c: Fix common/ includes.
5853         * thread.c: Fix common/ includes.
5854         * target/waitstatus.h: Fix common/ includes.
5855         * target/waitstatus.c: Fix common/ includes.
5856         * target.h: Fix common/ includes.
5857         * target.c: Fix common/ includes.
5858         * target-memory.c: Fix common/ includes.
5859         * target-descriptions.c: Fix common/ includes.
5860         * symtab.h: Fix common/ includes.
5861         * symfile.c: Fix common/ includes.
5862         * stap-probe.c: Fix common/ includes.
5863         * spu-linux-nat.c: Fix common/ includes.
5864         * sparc-nat.c: Fix common/ includes.
5865         * source.c: Fix common/ includes.
5866         * solib.c: Fix common/ includes.
5867         * solib-target.c: Fix common/ includes.
5868         * ser-unix.c: Fix common/ includes.
5869         * ser-tcp.c: Fix common/ includes.
5870         * ser-pipe.c: Fix common/ includes.
5871         * ser-base.c: Fix common/ includes.
5872         * selftest-arch.c: Fix common/ includes.
5873         * s12z-tdep.c: Fix common/ includes.
5874         * rust-exp.y: Fix common/ includes.
5875         * rs6000-aix-tdep.c: Fix common/ includes.
5876         * riscv-tdep.c: Fix common/ includes.
5877         * remote.c: Fix common/ includes.
5878         * remote-notif.h: Fix common/ includes.
5879         * remote-fileio.h: Fix common/ includes.
5880         * remote-fileio.c: Fix common/ includes.
5881         * regcache.h: Fix common/ includes.
5882         * regcache.c: Fix common/ includes.
5883         * record-btrace.c: Fix common/ includes.
5884         * python/python.c: Fix common/ includes.
5885         * python/py-type.c: Fix common/ includes.
5886         * python/py-inferior.c: Fix common/ includes.
5887         * progspace.h: Fix common/ includes.
5888         * producer.c: Fix common/ includes.
5889         * procfs.c: Fix common/ includes.
5890         * proc-api.c: Fix common/ includes.
5891         * printcmd.c: Fix common/ includes.
5892         * ppc-linux-nat.c: Fix common/ includes.
5893         * parser-defs.h: Fix common/ includes.
5894         * osdata.c: Fix common/ includes.
5895         * obsd-nat.c: Fix common/ includes.
5896         * nat/x86-linux.c: Fix common/ includes.
5897         * nat/x86-linux-dregs.c: Fix common/ includes.
5898         * nat/x86-dregs.h: Fix common/ includes.
5899         * nat/x86-dregs.c: Fix common/ includes.
5900         * nat/ppc-linux.c: Fix common/ includes.
5901         * nat/mips-linux-watch.h: Fix common/ includes.
5902         * nat/mips-linux-watch.c: Fix common/ includes.
5903         * nat/linux-waitpid.c: Fix common/ includes.
5904         * nat/linux-ptrace.h: Fix common/ includes.
5905         * nat/linux-ptrace.c: Fix common/ includes.
5906         * nat/linux-procfs.c: Fix common/ includes.
5907         * nat/linux-personality.c: Fix common/ includes.
5908         * nat/linux-osdata.c: Fix common/ includes.
5909         * nat/linux-namespaces.c: Fix common/ includes.
5910         * nat/linux-btrace.h: Fix common/ includes.
5911         * nat/linux-btrace.c: Fix common/ includes.
5912         * nat/fork-inferior.c: Fix common/ includes.
5913         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5914         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5915         * nat/aarch64-linux.c: Fix common/ includes.
5916         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5917         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5918         * namespace.h: Fix common/ includes.
5919         * mips-linux-tdep.c: Fix common/ includes.
5920         * minsyms.c: Fix common/ includes.
5921         * mi/mi-parse.h: Fix common/ includes.
5922         * mi/mi-main.c: Fix common/ includes.
5923         * mi/mi-cmd-env.c: Fix common/ includes.
5924         * memrange.h: Fix common/ includes.
5925         * memattr.c: Fix common/ includes.
5926         * maint.h: Fix common/ includes.
5927         * maint.c: Fix common/ includes.
5928         * main.c: Fix common/ includes.
5929         * machoread.c: Fix common/ includes.
5930         * location.c: Fix common/ includes.
5931         * linux-thread-db.c: Fix common/ includes.
5932         * linux-nat.c: Fix common/ includes.
5933         * linux-fork.c: Fix common/ includes.
5934         * inline-frame.c: Fix common/ includes.
5935         * infrun.c: Fix common/ includes.
5936         * inflow.c: Fix common/ includes.
5937         * inferior.h: Fix common/ includes.
5938         * inferior.c: Fix common/ includes.
5939         * infcmd.c: Fix common/ includes.
5940         * inf-ptrace.c: Fix common/ includes.
5941         * inf-child.c: Fix common/ includes.
5942         * ia64-linux-nat.c: Fix common/ includes.
5943         * i387-tdep.c: Fix common/ includes.
5944         * i386-tdep.c: Fix common/ includes.
5945         * i386-linux-tdep.c: Fix common/ includes.
5946         * i386-linux-nat.c: Fix common/ includes.
5947         * i386-go32-tdep.c: Fix common/ includes.
5948         * i386-fbsd-tdep.c: Fix common/ includes.
5949         * i386-fbsd-nat.c: Fix common/ includes.
5950         * guile/scm-type.c: Fix common/ includes.
5951         * guile/guile.c: Fix common/ includes.
5952         * go32-nat.c: Fix common/ includes.
5953         * gnu-nat.c: Fix common/ includes.
5954         * gdbthread.h: Fix common/ includes.
5955         * gdbarch-selftests.c: Fix common/ includes.
5956         * gdb_usleep.c: Fix common/ includes.
5957         * gdb_select.h: Fix common/ includes.
5958         * gdb_bfd.c: Fix common/ includes.
5959         * gcore.c: Fix common/ includes.
5960         * fork-child.c: Fix common/ includes.
5961         * findvar.c: Fix common/ includes.
5962         * fbsd-nat.c: Fix common/ includes.
5963         * event-top.c: Fix common/ includes.
5964         * event-loop.c: Fix common/ includes.
5965         * dwarf2read.c: Fix common/ includes.
5966         * dwarf2loc.c: Fix common/ includes.
5967         * dwarf2-frame.c: Fix common/ includes.
5968         * dwarf-index-cache.c: Fix common/ includes.
5969         * dtrace-probe.c: Fix common/ includes.
5970         * disasm-selftests.c: Fix common/ includes.
5971         * defs.h: Fix common/ includes.
5972         * csky-tdep.c: Fix common/ includes.
5973         * cp-valprint.c: Fix common/ includes.
5974         * cp-support.h: Fix common/ includes.
5975         * cp-support.c: Fix common/ includes.
5976         * corelow.c: Fix common/ includes.
5977         * completer.h: Fix common/ includes.
5978         * completer.c: Fix common/ includes.
5979         * compile/compile.c: Fix common/ includes.
5980         * compile/compile-loc2c.c: Fix common/ includes.
5981         * compile/compile-cplus-types.c: Fix common/ includes.
5982         * compile/compile-cplus-symbols.c: Fix common/ includes.
5983         * command.h: Fix common/ includes.
5984         * cli/cli-dump.c: Fix common/ includes.
5985         * cli/cli-cmds.c: Fix common/ includes.
5986         * charset.c: Fix common/ includes.
5987         * build-id.c: Fix common/ includes.
5988         * btrace.h: Fix common/ includes.
5989         * btrace.c: Fix common/ includes.
5990         * breakpoint.h: Fix common/ includes.
5991         * breakpoint.c: Fix common/ includes.
5992         * ax.h:
5993         (enum agent_op): Fix common/ includes.
5994         * ax-general.c (struct aop_map): Fix common/ includes.
5995         * ax-gdb.c: Fix common/ includes.
5996         * auxv.c: Fix common/ includes.
5997         * auto-load.c: Fix common/ includes.
5998         * arm-tdep.c: Fix common/ includes.
5999         * arch/riscv.c: Fix common/ includes.
6000         * arch/ppc-linux-common.c: Fix common/ includes.
6001         * arch/i386.c: Fix common/ includes.
6002         * arch/arm.c: Fix common/ includes.
6003         * arch/arm-linux.c: Fix common/ includes.
6004         * arch/arm-get-next-pcs.c: Fix common/ includes.
6005         * arch/amd64.c: Fix common/ includes.
6006         * arch/aarch64.c: Fix common/ includes.
6007         * arch/aarch64-insn.c: Fix common/ includes.
6008         * arch-utils.c: Fix common/ includes.
6009         * amd64-windows-tdep.c: Fix common/ includes.
6010         * amd64-tdep.c: Fix common/ includes.
6011         * amd64-sol2-tdep.c: Fix common/ includes.
6012         * amd64-obsd-tdep.c: Fix common/ includes.
6013         * amd64-nbsd-tdep.c: Fix common/ includes.
6014         * amd64-linux-tdep.c: Fix common/ includes.
6015         * amd64-linux-nat.c: Fix common/ includes.
6016         * amd64-fbsd-tdep.c: Fix common/ includes.
6017         * amd64-fbsd-nat.c: Fix common/ includes.
6018         * amd64-dicos-tdep.c: Fix common/ includes.
6019         * amd64-darwin-tdep.c: Fix common/ includes.
6020         * agent.c: Fix common/ includes.
6021         * ada-lang.h: Fix common/ includes.
6022         * ada-lang.c: Fix common/ includes.
6023         * aarch64-tdep.c: Fix common/ includes.
6024
6025 2019-01-25  Tom Tromey  <tom@tromey.com>
6026
6027         * common/create-version.sh: Use common/version.h.
6028
6029 2019-01-24  Pedro Alves  <palves@redhat.com>
6030
6031         * infrun.c (signal_stop, signal_print, signal_program)
6032         (signal_catch, signal_pass): Now arrays instead of pointers.
6033         (update_signals_program_target, do_target_resume)
6034         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6035         * linux-nat.c (linux_nat_target::pass_signals)
6036         (linux_nat_target::create_inferior, linux_nat_target::attach):
6037         Adjust.
6038         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6039         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6040         * procfs.c (procfs_target::pass_signals): Adjust.
6041         * record-full.c (record_full_target::resume): Adjust.
6042         * remote.c (remote_target::pass_signals)
6043         (remote_target::program_signals): Adjust.
6044         * target-debug.h (target_debug_print_signals): Now takes a
6045         gdb::array_view as parameter.  Adjust.
6046         * target.h (target_ops) <pass_signals, program_signals>: Replace
6047         pointer and length parameters with gdb::array_view.
6048         (target_pass_signals, target_program_signals): Likewise.
6049         * target-delegates.c: Regenerate.
6050
6051 2019-01-24  Pedro Alves  <palves@redhat.com>
6052
6053         * common/forward-scope-exit.h
6054         (forward_scope_exit::forward_scope_exit): Pass arguments to
6055         m_bind_function directly, instead of creating a std::bind and
6056         copying that.
6057
6058 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6059
6060         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6061         for static members.
6062         (pass_in_v_vfp_candidate): Likewise.
6063
6064 2019-01-23  Tom Tromey  <tom@tromey.com>
6065             Pedro Alves  <palves@redhat.com>
6066
6067         * regcache.c (class regcache_invalidator): Remove.
6068         (regcache::raw_write): Use make_scope_exit.
6069
6070 2019-01-23  Tom Tromey  <tom@tromey.com>
6071
6072         * ui-out.h (class ui_out_emit_type): Update comment.
6073
6074 2019-01-23  Tom Tromey  <tom@tromey.com>
6075
6076         * infrun.c (fetch_inferior_event): Update comment.
6077
6078 2019-01-23  Tom Tromey  <tom@tromey.com>
6079             Pedro Alves  <palves@redhat.com>
6080
6081         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6082         parameter.
6083         (fetch_inferior_event): Use SCOPE_EXIT.
6084
6085
6086 2019-01-23  Tom Tromey  <tom@tromey.com>
6087             Pedro Alves  <palves@redhat.com>
6088
6089         * infrun.c (disable_thread_events): Delete.
6090         (stop_all_threads): Use SCOPE_EXIT.
6091
6092 2019-01-23  Tom Tromey  <tom@tromey.com>
6093             Pedro Alves  <palves@redhat.com>
6094
6095         * symfile.c: Include forward-scope-exit.h.
6096         (clear_symtab_users_cleanup): Replace forward declaration with
6097         a FORWARD_SCOPE_EXIT.
6098         (syms_from_objfile_1): Use the forward_scope_exit and
6099         gdb::optional instead of cleanup_function.
6100         (reread_symbols): Use the forward_scope_exit instead of
6101         cleanup_function.
6102         (clear_symtab_users_cleanup): Remove function.
6103
6104 2019-01-23  Tom Tromey  <tom@tromey.com>
6105             Pedro Alves  <palves@redhat.com>
6106
6107         * linux-nat.c: Include scope-exit.h.
6108         (cleanup_target_stop): Remove.
6109         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6110         SCOPE_EXIT.
6111
6112 2019-01-23  Tom Tromey  <tom@tromey.com>
6113             Pedro Alves  <palves@redhat.com>
6114
6115         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6116         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6117
6118 2019-01-23  Tom Tromey  <tom@tromey.com>
6119             Andrew Burgess  <andrew.burgess@embecosm.com>
6120             Pedro Alves  <palves@redhat.com>
6121
6122         * infrun.c (fetch_inferior_event): Use scope_exit.
6123         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6124         * top.c (execute_command): Use scope_exit.
6125         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6126         * utils.c (do_bpstat_clear_actions_cleanup)
6127         (make_bpstat_clear_actions_cleanup): Remove.
6128
6129 2019-01-23  Tom Tromey  <tom@tromey.com>
6130             Pedro Alves  <palves@redhat.com>
6131
6132         * infrun.c: Include "common/scope-exit.h"
6133         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6134         (wait_for_inferior): Use SCOPE_EXIT.
6135         (fetch_inferior_event): Use scope_exit.
6136
6137 2019-01-23  Tom Tromey  <tom@tromey.com>
6138             Pedro Alves  <palves@redhat.com>
6139
6140         * breakpoint.c (create_breakpoint): Remove cleanup.
6141
6142 2019-01-23  Tom Tromey  <tom@tromey.com>
6143             Andrew Burgess  <andrew.burgess@embecosm.com>
6144             Pedro Alves  <palves@redhat.com>
6145
6146 2019-01-23  Pedro Alves  <palves@redhat.com>
6147
6148         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6149
6150 2019-01-23  Pedro Alves  <palves@redhat.com>
6151             Andrew Burgess  <andrew.burgess@embecosm.com>
6152
6153         * gdbthread.h: Include "common/forward-scope-exit.h".
6154         (scoped_finish_thread_state): Redefine custom class in terms of
6155         forward_scope_exit.
6156
6157 2019-01-23  Pedro Alves  <palves@redhat.com>
6158             Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         * common/forward-scope-exit.h: New file.
6161
6162 2019-01-23  Pedro Alves  <palves@redhat.com>
6163             Andrew Burgess  <andrew.burgess@embecosm.com>
6164             Tom Tromey  <tom@tromey.com>
6165
6166         * common/scope-exit.h: New file.
6167
6168 2019-01-23  Pedro Alves  <palves@redhat.com>
6169
6170         * common/preprocessor.h (ESC): Rename to ...
6171         (ESC_PARENS): ... this.
6172         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6173         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6174
6175 2019-01-23  Tom Tromey  <tom@tromey.com>
6176
6177         * language.h (class scoped_switch_to_sym_language_if_auto):
6178         Initialize m_lang in both cases.
6179
6180 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6181
6182         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6183         with XCNEW.
6184
6185 2019-01-22  Tom Tromey  <tom@tromey.com>
6186
6187         * corelow.c: Do not include sys/file.h.
6188
6189 2019-01-22  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-wingeneral.h: Include gdb_curses.h.
6192
6193 2019-01-22  Tom Tromey  <tom@tromey.com>
6194
6195         * source-cache.h (class source_cache) <get_source_lines,
6196         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6197
6198 2019-01-22  Tom Tromey  <tom@tromey.com>
6199
6200         * remote-fileio.h (struct remote_target): Declare.
6201
6202 2019-01-22  Tom Tromey  <tom@tromey.com>
6203
6204         * python/py-arch.c: Do not include py-ref.h.
6205         * python/py-bpevent.c: Do not include py-ref.h.
6206         * python/py-cmd.c: Do not include py-ref.h.
6207         * python/py-continueevent.c: Do not include py-ref.h.
6208         * python/py-event.h: Do not include py-ref.h.
6209         * python/py-evtregistry.c: Do not include py-ref.h.
6210         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6211         * python/py-frame.c: Do not include py-ref.h.
6212         * python/py-framefilter.c: Do not include py-ref.h.
6213         * python/py-function.c: Do not include py-ref.h.
6214         * python/py-infevents.c: Do not include py-ref.h.
6215         * python/py-linetable.c: Do not include py-ref.h.
6216         * python/py-objfile.c: Do not include py-ref.h.
6217         * python/py-param.c: Do not include py-ref.h.
6218         * python/py-prettyprint.c: Do not include py-ref.h.
6219         * python/py-progspace.c: Do not include py-ref.h.
6220         * python/py-symbol.c: Do not include py-ref.h.
6221         * python/py-symtab.c: Do not include py-ref.h.
6222         * python/py-type.c: Do not include py-ref.h.
6223         * python/py-unwind.c: Do not include py-ref.h.
6224         * python/py-utils.c: Do not include py-ref.h.
6225         * python/py-value.c: Do not include py-ref.h.
6226         * python/py-varobj.c: Do not include py-ref.h.
6227         * python/py-xmethods.c: Do not include py-ref.h.
6228         * python/python.c: Do not include py-ref.h.
6229         * varobj.c: Do not include py-ref.h.
6230
6231 2019-01-22  Tom Tromey  <tom@tromey.com>
6232
6233         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6234         keyword for bcache.
6235
6236 2019-01-22  Tom Tromey  <tom@tromey.com>
6237
6238         * compile/compile-cplus-types.c: Remove a comment by #include.
6239
6240 2019-01-22  Tom Tromey  <tom@tromey.com>
6241
6242         * compile/gcc-c-plugin.h: Include compile-internal.h.
6243
6244 2019-01-22  Tom Tromey  <tom@tromey.com>
6245
6246         * stabsread.c (EXTERN): Do not define.
6247         (symnum, next_symbol_text_func, processing_gcc_compilation)
6248         (within_function, global_sym_chain, global_stabs)
6249         (previous_stab_code, this_object_header_files)
6250         (n_this_object_header_files)
6251         (n_allocated_this_object_header_files): Define.
6252         * stabsread.h (EXTERN): Never define.  Use "extern".
6253
6254 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6255
6256         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6257         history_value.
6258
6259 2019-01-21  Tom Tromey  <tom@tromey.com>
6260
6261         * ui-out.c: Fix includes.
6262         * tui/tui-source.c: Fix includes.
6263         * target.c: Fix includes.
6264         * remote.c: Fix includes.
6265         * regcache.c: Fix includes.
6266         * python/py-block.c: Fix includes.
6267         * printcmd.c: Fix includes.
6268         * or1k-tdep.c: Fix includes.
6269         * mi/mi-main.c: Fix includes.
6270         * m32r-tdep.c: Fix includes.
6271         * csky-tdep.c: Fix includes.
6272         * compile/compile-cplus-types.c: Fix includes.
6273         * cli/cli-interp.c: Fix includes.
6274
6275 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6276
6277         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6278         for padding.
6279
6280 2019-01-16  Tom Tromey  <tom@tromey.com>
6281
6282         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6283         earlier.
6284         (struct objfile) <msymbols_range>: Move from top level.
6285         <msymbols>: New method.
6286         (class objfile_msymbols): Remove.
6287         * symtab.c (default_collect_symbol_completion_matches_break_on):
6288         Update.
6289         * symmisc.c (dump_msymbols): Update.
6290         * stabsread.c (scan_file_globals): Update.
6291         * objc-lang.c (info_selectors_command, info_classes_command)
6292         (find_methods): Update.
6293         * minsyms.c (find_solib_trampoline_target): Update.
6294         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6295         * coffread.c (coff_symfile_read): Update.
6296         * ada-lang.c (ada_lookup_simple_minsym)
6297         (ada_collect_symbol_completion_matches): Update.
6298
6299 2019-01-16  Tom Tromey  <tom@tromey.com>
6300
6301         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6302         type.  Remove no-argument constructor.
6303         <iterator::operator++>: Simplify.
6304         <begin>: Update.
6305         <end>: Use minimal_symbol_count.
6306
6307 2019-01-16  Tom Tromey  <tom@tromey.com>
6308
6309         * objfiles.h (struct objfile) <psymtabs>: New method.
6310         (class objfile_psymtabs): Remove.
6311         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6312         typedef.
6313         <range>: New method.
6314         (require_partial_symbols): Change return type.
6315         * psymtab.c (require_partial_symbols)
6316         (psym_expand_symtabs_matching): Update.
6317         * mdebugread.c (parse_partial_symbols): Update.
6318         * dbxread.c (dbx_end_psymtab): Update.
6319
6320 2019-01-15  Tom Tromey  <tom@tromey.com>
6321
6322         * symtab.c (lookup_objfile_from_block)
6323         (lookup_symbol_in_objfile_symtabs)
6324         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6325         (find_line_symtab, info_sources_command)
6326         (default_collect_symbol_completion_matches_break_on)
6327         (make_source_files_completion_list): Update.
6328         * symmisc.c (print_objfile_statistics, dump_objfile)
6329         (maintenance_print_symbols, maintenance_info_symtabs)
6330         (maintenance_check_symtabs, maintenance_info_line_tables):
6331         Update.
6332         * source.c (select_source_symtab)
6333         (forget_cached_source_info_for_objfile): Update.
6334         * objfiles.h (class objfile_compunits): Remove.
6335         (struct objfile) <compunits_range>: New typedef.
6336         (compunits): New method.
6337         * objfiles.c (objfile_relocate1): Update.
6338         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6339         * maint.c (count_symtabs_and_blocks): Update.
6340         * linespec.c (iterate_over_all_matching_symtabs): Update.
6341         * cp-support.c (add_symbol_overload_list_qualified): Update.
6342         * coffread.c (coff_symtab_read): Update.
6343         * ada-lang.c (add_nonlocal_symbols)
6344         (ada_collect_symbol_completion_matches)
6345         (ada_add_global_exceptions): Update.
6346
6347 2019-01-15  Tom Tromey  <tom@tromey.com>
6348
6349         * progspace.h (program_space) <objfiles_safe_range>: New
6350         typedef.
6351         <objfiles_safe>: New method.
6352         * objfiles.h (class all_objfiles_safe): Remove.
6353         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6354         * jit.c (jit_inferior_exit_hook): Update.
6355
6356 2019-01-17  Tom Tromey  <tom@tromey.com>
6357
6358         * progspace.h (program_space) <objfiles_range>: New typedef.
6359         <objfiles>: New method.
6360         <objfiles_head>: Rename from objfiles.
6361         (object_files): Update.
6362         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6363         * guile/scm-pretty-print.c
6364         (ppscm_find_pretty_printer_from_objfiles): Update.
6365         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6366         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6367         Update.
6368         * python/py-progspace.c (pspy_get_objfiles): Update.
6369         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6370         Update.
6371         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6372         (objfpy_lookup_objfile_by_build_id): Update.
6373         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6374         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6375         Update.
6376         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6377         (expand_symtab_containing_pc, lookup_objfile_from_block)
6378         (lookup_static_symbol, basic_lookup_transparent_type)
6379         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6380         (find_line_symtab, info_sources_command)
6381         (default_collect_symbol_completion_matches_break_on)
6382         (make_source_files_completion_list, find_main_name): Update.
6383         * symmisc.c (print_symbol_bcache_statistics)
6384         (print_objfile_statistics, maintenance_print_symbols)
6385         (maintenance_print_msymbols, maintenance_print_objfiles)
6386         (maintenance_info_symtabs, maintenance_check_symtabs)
6387         (maintenance_expand_symtabs, maintenance_info_line_tables):
6388         Update.
6389         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6390         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6391         (map_overlay_command, unmap_overlay_command)
6392         (simple_overlay_update, expand_symtabs_matching)
6393         (map_symbol_filenames): Update.
6394         * symfile-debug.c (set_debug_symfile): Update.
6395         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6396         Update.
6397         * source.c (select_source_symtab, forget_cached_source_info):
6398         Update.
6399         * solib.c (solib_read_symbols): Update.
6400         * solib-spu.c (append_ocl_sos): Update.
6401         * psymtab.c (maintenance_print_psymbols)
6402         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6403         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6404         * printcmd.c (info_symbol_command): Update.
6405         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6406         Update.
6407         * objfiles.h (class all_objfiles): Remove.
6408         * objfiles.c (have_partial_symbols, have_full_symbols)
6409         (have_minimal_symbols, qsort_cmp, update_section_map)
6410         (shared_objfile_contains_address_p)
6411         (default_iterate_over_objfiles_in_search_order): Update.
6412         * objc-lang.c (info_selectors_command, info_classes_command)
6413         (find_methods): Update.
6414         * minsyms.c (find_solib_trampoline_target): Update.
6415         * maint.c (maintenance_info_sections)
6416         (maintenance_translate_address, count_symtabs_and_blocks):
6417         Update.
6418         * main.c (captured_main_1): Update.
6419         * linux-thread-db.c (try_thread_db_load_from_pdir)
6420         (has_libpthread): Update.
6421         * linespec.c (iterate_over_all_matching_symtabs)
6422         (search_minsyms_for_name): Update.
6423         * jit.c (jit_find_objf_with_entry_addr): Update.
6424         * hppa-tdep.c (find_unwind_entry)
6425         (hppa_lookup_stub_minimal_symbol): Update.
6426         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6427         Update.
6428         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6429         (elf_gnu_ifunc_resolve_by_got): Update.
6430         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6431         * dwarf-index-write.c (save_gdb_index_command): Update.
6432         * cp-support.c (add_symbol_overload_list_qualified): Update.
6433         * breakpoint.c (create_overlay_event_breakpoint)
6434         (create_longjmp_master_breakpoint)
6435         (create_std_terminate_master_breakpoint)
6436         (create_exception_master_breakpoint): Update.
6437         * blockframe.c (find_pc_partial_function): Update.
6438         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6439         (ada_collect_symbol_completion_matches)
6440         (ada_add_global_exceptions): Update.
6441
6442 2019-01-17  Tom Tromey  <tom@tromey.com>
6443
6444         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6445         declare VEC.
6446         (solib_target_parse_libraries): Change return type.
6447         (library_list_start_segment, library_list_start_section)
6448         (library_list_end_library, library_list_start_library); Update.
6449         (solib_target_free_library_list): Remove.
6450         (solib_target_parse_libraries): Remove cleanup.  Change return
6451         type.
6452         (solib_target_current_sos): Update.
6453
6454 2019-01-17  Tom Tromey  <tromey@bapiya>
6455
6456         * valprint.c: Replace "the the" with "the".
6457         * symtab.c: Replace "the the" with "the".
6458         * solib.c: Replace "the the" with "the".
6459         * solib-dsbt.c: Replace "the the" with "the".
6460         * linespec.c: Replace "the the" with "the".
6461         * dwarf2loc.h: Replace "the the" with "the".
6462         * amd64-windows-tdep.c: Replace "the the" with "the".
6463         * aarch64-tdep.c: Replace "the the" with "the".
6464
6465 2019-01-16  Keith Seitz  <keiths@redhat.com>
6466
6467         PR gdb/23773
6468         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6469         <builder>: Rename to ..
6470         <m_builder>: ... this and make private.
6471         (dwarf2_cu::get_builder): New method.  Change all users of
6472         `builder' to use this method.
6473         (dwarf2_start_symtab): Move to ...
6474         (dwarf2_cu::start_symtab): ... here.  Update all callers
6475         (setup_type_unit_groups): Move to ...
6476         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6477         callers.
6478         (dwarf2_cu::reset_builder): New method.
6479         (process_full_compunit, process_full_type_unit): Use
6480         dwarf2_cu::reset_builder.
6481         (follow_die_offset): Record the ancestor CU if it is different
6482         from the followed DIE's CU.
6483         (follow_die_sig_1): Likewise.
6484
6485 2019-01-15  Tom Tromey  <tom@tromey.com>
6486
6487         * remote.c (class remote_state) <buf>: Now a char_vector.
6488         <buf_size>: Remove.
6489         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6490         parameter.
6491         (remote_target::getpkt_or_notif_sane_1)
6492         (remote_target::getpkt_sane)
6493         (remote_target::getpkt_or_notif_sane): Likewise.
6494         (class remote_target) <putpkt>: New overload.
6495         (remote_target::read_frame): Change type of "buf_p".  Remove
6496         sizeof_p parameter.
6497         (packet_ok): New overload.
6498         (packet_check_result): New overload.
6499         Update all uses.
6500
6501 2019-01-14  Tom Tromey  <tom@tromey.com>
6502
6503         * remote-notif.c (handle_notification, remote_notif_ack)
6504         (remote_notif_parse): Make "buf" const.
6505         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6506         const.
6507         (remote_notif_parse, remote_notif_ack, handle_notification):
6508         Likewise.
6509         * remote.c (remote_notif_stop_parse): Make "buf" const.
6510         (remote_target::remote_parse_stop_reply): Make "buf" const.
6511         (remote_notif_stop_ack): Make "buf" const.
6512
6513 2019-01-14  Tom Tromey  <tom@tromey.com>
6514
6515         * remote.c (remote_console_output): Make parameter const.
6516
6517 2019-01-14  Tom Tromey  <tom@tromey.com>
6518
6519         * target-debug.h (target_debug_print_signals): Constify.
6520         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6521         * procfs.c (procfs_target::pass_signals): Update.
6522         * linux-nat.c (linux_nat_target::pass_signals): Update.
6523         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6524         * target-delegates.c: Rebuild.
6525         * remote.c (remote_target::program_signals): Update.
6526         (remote_target::pass_signals): Update.
6527         * target.c (target_pass_signals): Constify argument.
6528         (target_program_signals): Likewise.
6529         * target.h (struct target_ops) <pass_signals, program_signals>:
6530         Constify argument.
6531         (target_pass_signals, target_program_signals): Constify argument.
6532
6533 2019-01-14  Tom Tromey  <tom@tromey.com>
6534
6535         PR tui/28819:
6536         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6537
6538 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6539
6540         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6541         field.
6542         * rs6000-tdep.c: Include reggroups.h.
6543         (IS_V_ALIAS_PSEUDOREG): Define.
6544         (rs6000_register_name): Return names for the "vX" aliases.
6545         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6546         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6547         aliases.  Call default_register_reggroup_p for all other
6548         pseudo-registers.
6549         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6550         New functions.
6551         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6552         Handle "vX" aliases.
6553         (v_alias_pseudo_register_collect): New function.
6554         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6555         (rs6000_gdbarch_init): Initialize "vX" aliases as
6556         pseudo-registers.  Restore registration of
6557         rs6000_pseudo_register_reggroup_p with
6558         set_tdesc_pseudo_register_reggroup_p.
6559
6560 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6561
6562         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6563         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6564         set_gdbarch_num_pseudo_regs.
6565
6566 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6567
6568         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6569         Remove arg prefixname, add do_set and do_show.
6570         Add member functions set_list and show_list.
6571         * cli/cli-style.c (class cli_style_option): Update accordingly.
6572         (style_set_list): Move to file scope.
6573         (style_show_list): Likewise.
6574         (set_style): Call help_list.
6575         (show_style): Call cmd_show_list.
6576         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6577         Update to use the new macro.
6578
6579 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6580
6581         * ada-lang.c (_initialize_ada_language): Expand the help text
6582         for the "catch exception" command.
6583
6584 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6585
6586         * symtab.c (matching_obj_sections): Initialize obj,
6587         declare it closer to its usage.
6588
6589 2019-01-10  Tom Tromey  <tom@tromey.com>
6590
6591         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6592         (basic_inf_threads_range): Remove.
6593         (inf_threads_range, inf_non_exited_threads_range)
6594         (safe_inf_threads_range): Use next_adapter.
6595
6596 2019-01-10  Keith Seitz  <keiths@redhat.com>
6597
6598         PR gdb/23712
6599         PR symtab/23010
6600         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6601         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6602
6603 2019-01-10  Keith Seitz  <keiths@redhat.com>
6604
6605         PR gdb/23712
6606         PR symtab/23010
6607         * dictionary.c (pending_to_vector): Remove.
6608         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6609         Remove _1 suffix, replacing functions of the same name.  Update
6610         all callers.
6611         (dict_create_hashed, dict_create_hashed_expandable)
6612         (dict_create_linear, dict_create_linear_expandable, dict_free)
6613         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6614         Make functions static.
6615
6616 2019-01-10  Keith Seitz  <keiths@redhat.com>
6617
6618         PR gdb/23712
6619         PR symtab/23010
6620         * dictionary.h (struct dictionary): Replace declaration with
6621         multidictionary.
6622         (dict_create_hashed, dict_create_hashed_expandable)
6623         (dict_create_linear, dict_create_linear_expandable)
6624         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6625         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6626         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6627         taking multidictionary argument.
6628         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6629         * block.h (struct block) <dict>: Change to multidictionary
6630         and rename `multidict'.
6631         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6632         symmisc.c: Update all dictionary references to multidictionary.
6633
6634 2019-01-10  Keith Seitz  <keiths@redhat.com>
6635
6636         PR gdb/23712
6637         PR symtab/23010
6638         * dictionary.c: Include unordered_map.
6639         (pending_to_vector): New function.
6640         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6641         Rewrite the non-"_1" functions to take vector instead
6642         of linked list.
6643         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6644         "new" _1 versions of the same name.
6645         (multidictionary): Define.
6646         (std::hash<enum language): New definition.
6647         (collate_pending_symbols_by_language, mdict_create_hashed)
6648         (mdict_create_hashed_expandable, mdict_create_linear)
6649         (mdict_create_linear_expandable, mdict_free)
6650         (find_language_dictionary, create_new_language_dictionary)
6651         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6652         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6653         (mdict_size, mdict_empty): New functions.
6654         * dictionary.h (mdict_iterator): Define.
6655
6656 2019-01-10  Pedro Alves  <palves@redhat.com>
6657
6658         * breakpoint.c (read_uploaded_action)
6659         (create_tracepoint_from_upload): Adjust to use
6660         gdb::unique_xmalloc_ptr.
6661         * ctf.c (ctf_write_uploaded_tp):
6662         (SET_ARRAY_FIELD): Use emplace_back.
6663         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6664         * tracefile-tfile.c (tfile_write_uploaded_tp):
6665         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6666         gdb::unique_xmalloc_ptr.
6667         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6668         at_string, cond_string, cmd_strings>: Replace char pointers
6669         with gdb::unique_xmalloc_ptr.
6670
6671 2019-01-10  Pedro Alves  <palves@redhat.com>
6672
6673         * solib-target.c (library_list_start_library): Don't xstrdup name.
6674
6675 2019-01-10  Pedro Alves  <palves@redhat.com>
6676
6677         * mdebugread.c (parse_partial_symbols): Use
6678         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6679
6680 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * linux-fork.c (scoped_switch_fork_info)
6683         <~scoped_switch_fork_info>: Fix incorrect variable name.
6684
6685 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6686
6687         * linux-fork.c (scoped_switch_fork_info)
6688         <scoped_switch_fork_info>: Make explicit.
6689         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6690
6691 2019-01-10  Tom Tromey  <tom@tromey.com>
6692
6693         * objfiles.h (objfile::reset_psymtabs): Update.
6694         * objfiles.c (objfile::objfile): Update.
6695         * psymtab.h (psymtab_storage::obstack): Update.
6696         (psymtab_storage::m_obstack): Use gdb::optional.
6697         (class psymtab_storage): Update comment.  Remove objfile
6698         parameter.
6699         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6700
6701 2019-01-10  Tom Tromey  <tom@tromey.com>
6702
6703         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6704         <free_psymtabs>: Now private.
6705         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6706         (allocate_psymtab): Use new method.
6707
6708 2019-01-10  Tom Tromey  <tom@tromey.com>
6709
6710         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6711         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6712         * mdebugread.c (parse_partial_symbols): Use
6713         allocate_dependencies.
6714         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6715         allocate_dependencies.
6716         (process_psymtab_comp_unit_reader)
6717         (build_type_psymtab_dependencies): Likewise.
6718         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6719
6720 2019-01-10  Tom Tromey  <tom@tromey.com>
6721
6722         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6723         PSYMBOL_SET_LANGUAGE.
6724         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6725
6726 2019-01-10  Tom Tromey  <tom@tromey.com>
6727
6728         * psymtab.h (psymtab_storage::obstack): New method.
6729         <m_obstack>: Rename from obstack; now private.
6730         * psymtab.c (psymtab_storage): Update.
6731         * dwarf2read.c (create_addrmap_from_index)
6732         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6733         Update.
6734
6735 2019-01-10  Tom Tromey  <tom@tromey.com>
6736
6737         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6738         * objfiles.h (objfile::reset_psymtabs): New method.
6739
6740 2019-01-10  Tom Tromey  <tom@tromey.com>
6741
6742         * symmisc.c (print_symbol_bcache_statistics): Update.
6743         (print_objfile_statistics): Update.
6744         * symfile.c (reread_symbols): Update.
6745         * psymtab.h (class psymtab_storage): New.
6746         * psymtab.c (psymtab_storage): New constructor.
6747         (~psymtab_storage): New destructor.
6748         (require_partial_symbols): Update.
6749         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6750         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6751         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6752         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6753         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6754         (start_psymtab_common, end_psymtab_common)
6755         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6756         (allocate_psymtab): Update.
6757         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6758         Update.
6759         (dump_psymtab_addrmap, maintenance_print_psymbols)
6760         (maintenance_check_psymtabs): Update.
6761         (class objfile_psymtabs): Move to objfiles.h.
6762         * psympriv.h (discard_psymtab): Now inline.
6763         (psymtab_discarder::psymtab_discarder): Update.
6764         (psymtab_discarder::~psymtab_discarder): Update.
6765         (ALL_OBJFILE_PSYMTABS): Rewrite.
6766         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6767         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6768         Remove fields.
6769         <partial_symtabs>: New field.
6770         (class objfile_psymtabs): Move from psymtab.h.  Update.
6771         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6772         psymbol_cache.
6773         (objfile::~objfile): Don't destroy psymbol_cache.
6774         * mdebugread.c (parse_partial_symbols): Update.
6775         * dwarf2read.c (create_addrmap_from_index)
6776         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6777         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6778         (add_partial_subprogram, dwarf2_ranges_read): Update.
6779         * dwarf-index-write.c (write_address_map)
6780         (write_one_signatured_type, recursively_write_psymbols)
6781         (class debug_names, class debug_names, write_psymtabs_to_index):
6782         Update.
6783
6784 2019-01-10  Tom Tromey  <tom@tromey.com>
6785
6786         * symtab.h (SYMBOL_SET_NAMES): Update.
6787         (symbol_set_names): Update.
6788         (MSYMBOL_SET_NAMES): Update.
6789         * symtab.c (symbol_set_names): Change argument to be an
6790         objfile_per_bfd_storage.
6791         * psymtab.c (add_psymbol_to_bcache): Update.
6792         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6793
6794 2019-01-10  Tom Tromey  <tom@tromey.com>
6795
6796         * symtab.c (create_demangled_names_hash): Change argument to be an
6797         objfile_per_bfd_storage.
6798         (symbol_set_names): Update.
6799
6800 2019-01-10  Tom Tromey  <tom@tromey.com>
6801
6802         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6803         init_psymbol_list.
6804         * psymtab.c (init_psymbol_list): Do nothing if already called.
6805         * psympriv.h (init_psymbol_list): Add comment.
6806         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6807         init_psymbol_list.
6808         * dbxread.c (dbx_symfile_read): Unconditionally call
6809         init_psymbol_list.
6810
6811 2019-01-10  Tom Tromey  <tom@tromey.com>
6812
6813         * xcoffread.c (scan_xcoff_symtab): Update.
6814         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6815         "where".
6816         * mdebugread.c (parse_partial_symbols)
6817         (handle_psymbol_enumerators): Update.
6818         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6819         * dbxread.c (read_dbx_symtab): Update.
6820         * psympriv.h (psymbol_placement): New enum.
6821         (add_psymbol_to_list): Update.
6822
6823 2019-01-10  Tom Tromey  <tom@tromey.com>
6824
6825         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6826         static_psymbols parameters.
6827         (scan_xcoff_symtab): Update.
6828         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6829         static_psymbols parameters.
6830         * psympriv.h (start_psymtab_common): Update.
6831         * mdebugread.c (parse_partial_symbols): Update.
6832         * dwarf2read.c (create_partial_symtab): Update.
6833         * dbxread.c (read_dbx_symtab): Update.
6834         (start_psymtab): Remove global_psymbols and static_psymbols
6835         parameters.
6836
6837 2019-01-10  Tom Tromey  <tom@tromey.com>
6838
6839         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6840         * psymtab.c (allocate_psymtab): Add comment.
6841         * psympriv.h (allocate_psymtab): Add comment.
6842         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6843         initializations.
6844         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6845
6846 2019-01-10  Tom Tromey  <tom@tromey.com>
6847
6848         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6849         Don't declare.
6850         * mipsread.c: Include mdebugread.h.
6851         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6852         Declare.
6853         * elfread.c: Include mdebugread.h.
6854
6855 2019-01-09  Tom Tromey  <tom@tromey.com>
6856
6857         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6858         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6859         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6860         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6861         (psym_lookup_symbol, psym_find_last_source_symtab)
6862         (psym_forget_cached_source_info, psym_print_stats)
6863         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6864         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6865         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6866         (psym_find_compunit_symtab_by_address)
6867         (maintenance_print_psymbols, maintenance_info_psymtabs)
6868         (maintenance_check_psymtabs): Use ranged for.
6869         * psymtab.h (class objfile_psymtabs): New.
6870         (require_partial_symbols): Return objfile_psymtabs.
6871         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6872
6873 2019-01-09  Tom Tromey  <tom@tromey.com>
6874
6875         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6876         (find_pc_mapped_section, list_overlays_command)
6877         (map_overlay_command, unmap_overlay_command)
6878         (simple_overlay_update): Use all_objfiles.
6879         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6880         * printcmd.c (info_symbol_command): Use all_objfiles.
6881         * objfiles.h (ALL_OBJSECTIONS): Remove.
6882         * maint.c (maintenance_translate_address): Use all_objfiles.
6883         * gcore.c (gcore_create_callback): Use all_objfiles.
6884         (objfile_find_memory_regions): Likewise.
6885
6886 2019-01-09  Tom Tromey  <tom@tromey.com>
6887
6888         * symtab.c (find_line_symtab, info_sources_command)
6889         (make_source_files_completion_list): Use objfile_compunits.
6890         * source.c (select_source_symtab): Use objfile_compunits.
6891         * objfiles.h (struct objfile): Update comment.
6892         (ALL_OBJFILES): Remove.
6893         (ALL_FILETABS): Remove.
6894         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6895         objfile_compunits.
6896
6897 2019-01-09  Tom Tromey  <tom@tromey.com>
6898
6899         * symmisc.c (print_objfile_statistics, dump_objfile)
6900         (maintenance_print_symbols): Use compunit_filetabs.
6901         * source.c (forget_cached_source_info_for_objfile): Use
6902         compunit_filetabs.
6903         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6904         (ALL_FILETABS): Use compunit_filetabs.
6905         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6906         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6907
6908 2019-01-09  Tom Tromey  <tom@tromey.com>
6909
6910         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6911         (compunit_filetabs): New.
6912         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6913         compunit_filetabs.
6914         (info_sources_command, make_source_files_completion_list): Remove
6915         declaration.
6916         * symmisc.c (print_objfile_statistics, dump_objfile)
6917         (maintenance_print_symbols): Remove declaration.
6918         (maintenance_info_symtabs): Use compunit_filetabs.
6919         (maintenance_info_line_tables): Likewise.
6920         * source.c (select_source_symtab): Change local variable name.
6921         (forget_cached_source_info_for_objfile): Remove declaration.
6922         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6923         * objfiles.c (objfile_relocate1): Remove declaration.
6924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6925         declaration.
6926         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6927         * coffread.c (coff_symtab_read): Remove declaration.
6928         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6929         compunit_filetabs.
6930
6931 2019-01-09  Tom Tromey  <tom@tromey.com>
6932
6933         * symtab.c (lookup_objfile_from_block)
6934         (find_pc_sect_compunit_symtab, search_symbols)
6935         (default_collect_symbol_completion_matches_break_on): Use
6936         objfile_compunits.
6937         * objfiles.h (ALL_COMPUNITS): Remove.
6938         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6939         * cp-support.c (add_symbol_overload_list_qualified): Use
6940         objfile_compunits.
6941         * ada-lang.c (ada_collect_symbol_completion_matches)
6942         (ada_add_global_exceptions): Use objfile_compunits.
6943
6944 2019-01-09  Tom Tromey  <tom@tromey.com>
6945
6946         * source.c (select_source_symtab)
6947         (forget_cached_source_info_for_objfile): Remove declaration.
6948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6949         declaration.
6950         * maint.c (count_symtabs_and_blocks): Remove declaration.
6951         * cp-support.c (add_symbol_overload_list_qualified): Remove
6952         declaration.
6953         * coffread.c (coff_symtab_read): Remove declaration.
6954         * symtab.c (lookup_symbol_in_objfile_symtabs)
6955         (basic_lookup_transparent_type_1): Use objfile_compunits.
6956         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6957         (info_sources_command, search_symbols)
6958         (default_collect_symbol_completion_matches_break_on)
6959         (make_source_files_completion_list): Remove declaration.
6960         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6961         (ada_collect_symbol_completion_matches)
6962         (ada_add_global_exceptions): Remove declaration.
6963         * linespec.c (iterate_over_all_matching_symtabs): Use
6964         objfile_compunits.
6965         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6966         (class objfile_compunits): New.
6967         (ALL_COMPUNITS): Use objfile_compunits.
6968         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6969         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6970         objfile_compunits.
6971         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6972
6973 2019-01-09  Tom Tromey  <tom@tromey.com>
6974
6975         * symtab.c (search_symbols)
6976         (default_collect_symbol_completion_matches_break_on): Use
6977         objfile_msymbols.
6978         * ada-lang.c (ada_lookup_simple_minsym)
6979         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6980         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6981         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6982         objfile_msymbols.
6983         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6984         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6985         * objc-lang.c (find_methods): Use objfile_msymbols.
6986         (info_selectors_command, info_classes_command): Likewise.
6987         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6988         * objfiles.h (class objfile_msymbols): New.
6989         (ALL_OBJFILE_MSYMBOLS): Remove.
6990         (ALL_MSYMBOLS): Remove.
6991
6992 2019-01-09  Tom Tromey  <tom@tromey.com>
6993
6994         * common/next-iterator.h (next_adapter): Add Iterator template
6995         parameter.
6996         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6997         (class all_objfiles_safe): New.
6998         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6999         * objfiles.c (put_objfile_before): Update comment.
7000         (add_separate_debug_objfile): Likewise.
7001         (free_all_objfiles): Use all_objfiles_safe.
7002         (objfile_purge_solibs): Likewise.
7003
7004 2019-01-09  Tom Tromey  <tom@tromey.com>
7005
7006         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7007         (expand_symtab_containing_pc, lookup_static_symbol)
7008         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7009         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7010         all_objfiles.
7011         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7012         * breakpoint.c (create_overlay_event_breakpoint)
7013         (create_longjmp_master_breakpoint)
7014         (create_std_terminate_master_breakpoint)
7015         (create_exception_master_breakpoint): Use all_objfiles.
7016         * linux-thread-db.c (try_thread_db_load_from_pdir)
7017         (has_libpthread): Use all_objfiles.
7018         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7019         * linespec.c (iterate_over_all_matching_symtabs)
7020         (search_minsyms_for_name): Use all_objfiles.
7021         * maint.c (maintenance_info_sections): Use all_objfiles.
7022         * main.c (captured_main_1): Use all_objfiles.
7023         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7024         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7025         * guile/scm-pretty-print.c
7026         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7027         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7028         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7029         (maintenance_print_msymbols): Use all_objfiles.
7030         * source.c (select_source_symtab): Use all_objfiles.
7031         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7032         * symfile.c (remove_symbol_file_command)
7033         (expand_symtabs_matching, map_symbol_filenames): Use
7034         all_objfiles.
7035         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7036         all_objfiles.
7037         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7038         * objc-lang.c (find_methods): Use all_objfiles.
7039         * objfiles.c (have_partial_symbols, have_full_symbols)
7040         (have_minimal_symbols, qsort_cmp)
7041         (default_iterate_over_objfiles_in_search_order): Use
7042         all_objfiles.
7043         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7044         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7045         (maintenance_check_psymtabs): Use all_objfiles.
7046         (ALL_PSYMTABS): Remove.
7047         * compile/compile-object-run.c (do_module_cleanup): Use
7048         all_objfiles.
7049         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7050         * cp-support.c (add_symbol_overload_list_qualified): Use
7051         all_objfiles.
7052         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7053         Use all_objfiles.
7054         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7055         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7056         all_objfiles.
7057         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7058         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7059         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7060         Uses all_objfiles.
7061         * solib.c (solib_read_symbols): Use all_objfiles
7062
7063 2019-01-09  Tom Tromey  <tom@tromey.com>
7064
7065         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7066         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7067         all_objfiles.
7068         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7069         * symmisc.c (print_symbol_bcache_statistics)
7070         (print_objfile_statistics, maintenance_print_objfiles)
7071         (maintenance_info_symtabs, maintenance_check_symtabs)
7072         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7073         all_objfiles.
7074         * source.c (forget_cached_source_info): Use all_objfiles.
7075         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7076         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7077         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7078         * objfiles.c (update_section_map): Use all_objfiles.
7079         (shared_objfile_contains_address_p): Likewise.
7080         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7081         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7082
7083 2019-01-09  Tom Tromey  <tom@tromey.com>
7084
7085         * common/next-iterator.h: New file.
7086         * objfiles.h (class all_objfiles): New.
7087         (struct objfile_iterator): New.
7088
7089 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7090
7091         * NEWS: Move the description of the changed "frame", "select-frame",
7092          and "info frame" commands to the Changed commands section.
7093
7094 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7095
7096         * gdbtypes.c (check_stub_method_group): Remove handling of old
7097         mangling schemes.
7098         * linespec.c (find_methods): Likewise.
7099         * stabsread.c (read_member_functions): Likewise.
7100         * valops.c (search_struct_method): Likewise.
7101         (value_struct_elt_for_reference): Likewise.
7102         * NEWS: Mention this change.
7103
7104 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7107         print_source_lines.
7108         * source.c (print_source_lines_base): Update line number check.
7109         (print_source_lines): New function.
7110         (source_lines_range::source_lines_range): New function.
7111         * source.h (class source_lines_range): New class.
7112         (print_source_lines): New declaration.
7113
7114 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7115
7116         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7117
7118 2019-01-08  Tom Tromey  <tom@tromey.com>
7119             Simon Marchi  <simon.marchi@ericsson.com>
7120
7121         PR gdb/24060
7122         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7123         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7124         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7125         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7126         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7127         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7128
7129 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7130
7131         * source.c (select_source_symtab): Move header comment to
7132         declaration in source.h.
7133         (forget_cached_source_info_for_objfile): Likewise.
7134         (forget_cached_source_info): Likewise.
7135         (identify_source_line): Likewise.
7136         * source.h (identify_source_line): Move declaration from symtab.h
7137         and add comment from source.c
7138         (print_source_lines): Likewise.
7139         (forget_cached_source_info_for_objfile): Likewise.
7140         (forget_cached_source_info): Likewise.
7141         (select_source_symtab): Likewise.
7142         (enum print_source_lines_flag): Move definition from symtab.h.
7143         * symtab.h (identify_source_line): Move declaration to source.h.
7144         (print_source_lines): Likewise.
7145         (forget_cached_source_info_for_objfile): Likewise.
7146         (forget_cached_source_info): Likewise.
7147         (select_source_symtab): Likewise.
7148         (enum print_source_lines_flag): Move definition to source.h.
7149         * tui/tui-hooks.c: Add 'source.h' include.
7150
7151 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * source.c (print_source_lines_base): Handle requests to print
7154         reverse line number sequences, and guard against empty lines
7155         string.
7156
7157 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * source.c (print_source_lines_base): Fix skip of '\r' if next
7160         character is '\n'.
7161
7162 2019-01-06  Tom Tromey  <tom@tromey.com>
7163
7164         * c-exp.y (struct c_parse_state) <macro_original_text,
7165         expansion_obstack>: New member.
7166         (macro_original_text, expansion_obstack): Remove globals.
7167         (scan_macro_expansion, scanning_macro_expansion)
7168         (finished_macro_expansion): Update.
7169         (scan_macro_cleanup): Remove.
7170         (yylex, c_parse): Update.
7171
7172 2019-01-06  Tom Tromey  <tom@tromey.com>
7173
7174         * c-exp.y (struct c_parse_state) <strings>: New member.
7175         (operator_stoken): Update.
7176
7177 2019-01-06  Tom Tromey  <tom@tromey.com>
7178
7179         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7180         (union type_stack_elt) <typelist_val>: Now a pointer to
7181         std::vector.
7182         (type_stack_cleanup): Don't declare.
7183         (push_typelist): Update.
7184         * parse.c (pop_typelist): Return a std::vector.
7185         (push_typelist): Take a std::vector.
7186         (follow_types): Update.  Do not free args.
7187         (type_stack_cleanup): Remove.
7188         * c-exp.y (struct c_parse_state): New.
7189         (cpstate): New global.
7190         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7191         (nonempty_typelist): Update.
7192         (func_mod): Create a new vector.
7193         (c_parse): Create a c_parse_state.
7194         (check_parameter_typelist): Do not delete params.
7195         (function_method): Update.  Do not delete type_list.
7196
7197 2019-01-06  Tom Tromey  <tom@tromey.com>
7198
7199         PR gdb/28155:
7200         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7201         check_typedef.
7202         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7203         (print_return_value): Likewise.
7204
7205 2019-01-05  Tom Tromey  <tom@tromey.com>
7206
7207         * contrib/cleanup_check.py: Remove.
7208         * contrib/gcc-with-excheck: Remove.
7209         * contrib/exsummary.py: Remove.
7210         * contrib/excheck.py: Remove.
7211
7212 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7213
7214         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7215         NULL. Initialize tpprev to NULL instead of assigning it
7216         to NULL on the next statement.
7217         * windows-nat.c (windows_delete_thread): Remove check for
7218         main_thread_id before printing thread exit notifications.
7219         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7220         Remove thread ID check against main_thread_id.
7221         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7222         windows_delete_thread.
7223         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7224
7225 2019-01-04  Tom Tromey  <tom@tromey.com>
7226
7227         * compile/compile.c (_initialize_compile): Use upper case for
7228         metasyntactic variables.
7229         * symmisc.c (_initialize_symmisc): Use upper case for
7230         metasyntactic variables.
7231         * psymtab.c (_initialize_psymtab): Use upper case for
7232         metasyntactic variables.
7233         * demangle.c (demangle_command): Use upper case for metasyntactic
7234         variables.
7235         (_initialize_demangler): Likewise.
7236         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7237         variables.
7238
7239 2019-01-03  Tom Tromey  <tom@tromey.com>
7240
7241         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7242
7243 2019-01-03  Tom Tromey  <tom@tromey.com>
7244
7245         * python/py-symtab.c (salpy_str): Update.
7246         (struct salpy_sal_object) <symtab>: Now a PyObject.
7247         (salpy_dealloc): Update.
7248         (del_objfile_sal): Use gdbpy_ref.
7249
7250 2019-01-03  Tom Tromey  <tom@tromey.com>
7251
7252         * python/py-type.c (convert_field): Use new_reference.  Return
7253         gdbpy_ref.
7254         (make_fielditem): Return gdbpy_ref.
7255         (typy_fields): Update.
7256         (typy_getitem): Update.
7257         (field_name): Return gdbpy_ref.  Use new_reference.
7258         (typy_iterator_iternext): Update.
7259
7260 2019-01-03  Tom Tromey  <tom@tromey.com>
7261
7262         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7263
7264 2019-01-03  Tom Tromey  <tom@tromey.com>
7265
7266         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7267         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7268         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7269         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7270         (pspy_set_type_printers): Likewise.
7271         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7272         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7273         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7274         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7275         (objfpy_set_type_printers): Likewise.
7276
7277 2019-01-03  Tom Tromey  <tom@tromey.com>
7278
7279         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7280         (gdbpy_print_stack): Use gdbpy_err_fetch.
7281         * python/python-internal.h (class gdbpy_err_fetch): New class.
7282         (class gdbpy_enter) <m_error_type, m_error_value,
7283         m_error_traceback>: Remove.
7284         <m_error>: New member.
7285         (gdbpy_exception_to_string): Don't declare.
7286         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7287         * python/py-value.c (convert_value_from_python): Use
7288         gdbpy_err_fetch.
7289         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7290         gdbpy_exception_to_string.
7291         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7292         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7293         gdbpy_err_fetch.
7294
7295 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7296
7297         * linux-nat.c (delete_lwp_cleanup): Delete.
7298         (struct lwp_deleter): New struct.
7299         (lwp_info_up): New typedef.
7300         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7301         lwp_info_up.
7302
7303 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7304
7305         * linux-fork.c (class scoped_switch_fork_info): New class.
7306         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7307
7308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7309
7310         * valops.c (find_overload_match): Remove use of null_cleanup, and
7311         calls to do_cleanups.
7312
7313 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * compile/compile-cplus-types.c
7316         (compile_cplus_instance::decl_name): Handle changes to
7317         cp_func_name.
7318         * cp-support.c (cp_func_name): Update header comment, update
7319         return type.
7320         * cp-support.h (cp_func_name): Update return type in declaration.
7321         * valops.c (find_overload_match): Move temp_func local to top
7322         level of function and change its type.  Use temp_func to hold and
7323         delete temporary string obtained from cp_func_name.
7324
7325 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7326
7327         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7328         gdb::char_vector, remove cleanup, and update uses of `msg`.
7329
7330 2019-01-03  Jim Wilson  <jimw@sifive.com>
7331
7332         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7333
7334 2019-01-02  Tom Tromey  <tom@tromey.com>
7335
7336         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7337         (tdesc_parse_xml): Remove cleanups.
7338         * target-descriptions.h (make_cleanup_free_target_description):
7339         Don't declare.
7340         (target_desc_deleter): New struct.
7341         (target_desc_up): New typedef.
7342         * target-descriptions.c (target_desc_deleter::operator()): Rename
7343         from free_target_description.
7344         (make_cleanup_free_target_description): Remove.
7345
7346 2019-01-02  Tom Tromey  <tom@tromey.com>
7347
7348         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7349         constructor, destructor.
7350         (linespec_parser): Remove typedef.
7351         (~linespec_parser): Rename from linespec_parser_delete.
7352         (linespec_lex_to_end, linespec_complete_label)
7353         (linespec_complete): Update.
7354         (decode_line_full): Remove cleanups.
7355         (decode_line_1): Update.
7356
7357 2019-01-02  Tom Tromey  <tom@tromey.com>
7358
7359         * python/python-internal.h (inferior_to_inferior_object): Change
7360         return type.
7361         * python/py-exitedevent.c (create_exited_event_object): Update.
7362         * python/py-inferior.c (inferior_to_inferior_object): Return
7363         gdbpy_ref.
7364         (python_new_inferior, python_inferior_deleted)
7365         (thread_to_thread_object, delete_thread_object)
7366         (build_inferior_list, gdbpy_selected_inferior): Update.
7367         * python/py-infthread.c (create_thread_object): Update.  Also fail
7368         if inferior_to_inferior_object fails.
7369
7370 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7371
7372         * inferior.h (class inferior) <displaced_step_state>: New field.
7373         * infrun.h (struct displaced_step_state): Move here from
7374         infrun.c.  Initialize fields, add constructor.
7375         <inf>: Remove field.
7376         <reset>: New method.
7377         * infrun.c (struct displaced_step_inferior_state): Move to
7378         infrun.h.
7379         (displaced_step_inferior_states): Remove.
7380         (get_displaced_stepping_state): Adust.
7381         (displaced_step_in_progress_any_inferior): Adjust.
7382         (displaced_step_in_progress_thread): Adjust.
7383         (displaced_step_in_progress): Adjust.
7384         (add_displaced_stepping_state): Remove.
7385         (get_displaced_step_closure_by_addr): Adjust.
7386         (remove_displaced_stepping_state): Remove.
7387         (infrun_inferior_exit): Call displaced_step_state.reset.
7388         (use_displaced_stepping): Don't check for NULL.
7389         (displaced_step_prepare_throw): Call
7390         get_displaced_stepping_state.
7391         (displaced_step_fixup): Don't check for NULL.
7392         (prepare_for_detach): Don't check for NULL.
7393
7394 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7395
7396         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7397          in case of call that did not complete.
7398
7399 2019-01-02  Andrey Utkin  <autkin@undo.io>
7400
7401         * symfile.c (find_separate_debug_file): Fix search of debug files for
7402         remote debuggee.
7403
7404 2019-01-02  Tom Tromey  <tom@tromey.com>
7405
7406         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7407         indentation.
7408         * python/py-frame.c (frapy_older): Remove cast.
7409         (frapy_newer): Likewise.
7410         * python/py-breakpoint.c (local_setattro): Remove cast.
7411         * python/py-arch.c (archpy_name): Remove local variable.
7412         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7413
7414 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7415
7416         * unittests/basic_string_view/element_access/char/empty.cc:
7417         Fix year range in copyright header.
7418
7419 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7422         Delete.
7423         <operator==>: Update with for removed field.
7424         <hash>: Likewise.
7425         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7426         <isa_features>: ...this.
7427         <abi_features>: New field.
7428         (riscv_isa_flen): Update comment.
7429         (riscv_abi_xlen): New declaration.
7430         (riscv_abi_flen): New declaration.
7431         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7432         isa_features.
7433         (riscv_abi_xlen): New function.
7434         (riscv_isa_flen): Update to get answer from isa_features.
7435         (riscv_abi_flen): New function.
7436         (riscv_has_fp_abi): Update to get answer from abi_features.
7437         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7438         xlen and flen.
7439         (riscv_call_info) <xlen, flen>: Update comment.
7440         (riscv_call_arg_struct): Remove invalid assertions
7441         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7442         is removed.
7443         (riscv_gdbarch_init): Gather isa features and abi features
7444         separately, ensure both match on the gdbarch when reusing an old
7445         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7446         a target with 64-bit float hardware.
7447
7448 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7449
7450         * source.c (search_command_helper): Stop reverse search
7451         when line 1 has been searched.
7452
7453 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7454
7455         * record-full.c (record_full_base_target::close): Rewrite
7456         record_full_core_buf_list free logic.
7457
7458 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7459
7460         * break-catch-syscall.c (print_one_catch_syscall): xfree
7461         the last text.
7462
7463 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7464
7465         * top.c (print_gdb_version): Update Copyright year in version
7466         message.
7467
7468 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7469
7470         Update copyright year range in all GDB files.
7471
7472 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7473
7474         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7475
7476 For older changes see ChangeLog-2018.
7477 \f
7478 Local Variables:
7479 mode: change-log
7480 left-margin: 8
7481 fill-column: 74
7482 version-control: never
7483 coding: utf-8
7484 End:
7485