gdb/ChangeLog

   1 2019-06-10  Tom de Vries  <tdevries@suse.de>
   2
   3         PR symtab/24545
   4         * symtab.c (struct demangled_name_entry): Add language field.
   5         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
   6         static minimal symbol".  Set and use language field.
   7
   8 2019-06-10  Tom Tromey  <tromey@adacore.com>
   9
  10         * ada-lang.c (_initialize_ada_language): Update help text.
  11
  12 2019-06-10  Tom Tromey  <tromey@adacore.com>
  13
  14         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
  15         with a newline.
  16         * guile/guile.c (handle_boot_error): Don't end warning with a
  17         newline.
  18         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
  19         warning with a newline.
  20         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
  21         newline.
  22         (s12z_frame_cache): Likewise.
  23         * dwarf-index-cache.c (index_cache::store): Don't end warning with
  24         a newline.
  25         * solib-svr4.c (disable_probes_interface): Don't end warning with
  26         a newline.
  27         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
  28         newline.
  29         * python/python.c (do_finish_initialization): Don't end warning
  30         with a newline.
  31
  32 2019-06-10  Tom Tromey  <tom@tromey.com>
  33
  34         * python/py-breakpoint.c (gdbpy_breakpoint_created)
  35         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
  36         gdbpy_enter.
  37
  38 2019-06-10  Tom Tromey  <tromey@adacore.com>
  39
  40         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
  41         data.
  42         (elf_new_init): Don't call stabsread_new_init.
  43         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
  44         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
  45         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
  46
  47 2019-06-10  Tom de Vries  <tdevries@suse.de>
  48
  49         PR symtab/16264
  50         PR symtab/24517
  51         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
  52
  53 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
  54
  55         * source.c (find_and_open_source): Also rewrite relative file
  56         names.
  57
  58 2019-04-26  Amos Bird  <amosbird@gmail.com>
  59
  60         * annotate.c (annotate_thread_exited): Add "thread-exited"
  61         annotation.
  62
  63 2019-06-06  Tom Tromey  <tromey@adacore.com>
  64
  65         * maint.h (class scoped_command_stats): Use
  66         DISABLE_COPY_AND_ASSIGN.
  67         <print_time>: New method.
  68         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
  69         print_time.
  70         (scoped_command_stats::print_time): New method.
  71
  72 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
  75         instructions of lengths 6 or 8 bytes.
  76
  77 2019-06-04  Pedro Alves  <palves@redhat.com>
  78
  79         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
  80
  81         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
  82         * breakpoint.c (condition_completer): Likewise.
  83         * cli/cli-dump.c (scan_expression): Likewise.
  84         * common/filestuff.c (mkdir_recursive): Likewise.
  85         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
  86         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
  87         (gdb_abspath): Likewise.
  88         * compile/compile-cplus-types.c
  89         (compile_cplus_instance::decl_name): Likewise.
  90         * completer.c (complete_explicit_location):
  91         (signal_completer, reg_or_group_completer_1): Likewise.
  92         * cp-support.c (cp_remove_params_if_any): Likewise.
  93         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
  94         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
  95         * infcmd.c (strip_bg_char): Likewise.
  96         * linespec.c (copy_token_string): Likewise.
  97         * mi/mi-main.c (output_cores): Likewise.
  98         * psymtab.c (psymtab_search_name):
  99         * symfile.c (test_set_ext_lang_command): Likewise.
 100         * target.c (target_fileio_read_stralloc): Likewise.
 101         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 102         * value.c (complete_internalvar): Likewise.
 103
 104 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 105
 106         Add objfile property to gdb.Type.
 107         * NEWS: Mention Python API addition.
 108         * python/py-type.c (typy_get_objfile): New method.
 109
 110 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 111
 112         * NEWS: Mention the new set|show style [title|highlight].
 113         Mention changes to "show style", "help" and "apropos".
 114
 115 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 116
 117         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 118         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 119         instead of print_help_for_command.
 120         (print_doc_of_command): New function.
 121         (help_list): Add 'apropos -v word' suggestion.
 122         (print_help_for_command): Style the command name using title style.
 123         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 124         (_initialize_cli_cmds): Describe -v in apropos_command help.
 125
 126 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127
 128         * cli/cli-style.h (cli_style_option): Add name in constructor,
 129         add m_name class member, add constructor with intensity,
 130         add name class function.
 131         (cli_style_option::add_setshow_commands): Remove name argument.
 132         (highlight_style, title_style): New styles.
 133         * cli/cli-style.c (do_show): New function that shows a style
 134         characteristic styling the style name with itself.
 135         (set_style_name): New function.
 136         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 137         Update all callers according to the changes in cli/cli-style.h.
 138         * utils.h (fputs_highlighted): New function.
 139         * utils.c (fputs_highlighted): Likewise.
 140
 141 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 142
 143         * NEWS: Mention new pipe command and new convenience variables.
 144
 145 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 146
 147         * cli/cli-cmds.c (pipe_command): New function.
 148         (_initialize_cli_cmds): Call add_com for pipe_command.
 149         Define | as an alias for pipe.
 150         (exit_status_set_internal_vars): New function.
 151         (shell_escape): Call exit_status_set_internal_vars.
 152         cli/cli-decode.c (find_command_name_length): Recognize | as
 153         a single character command.
 154
 155 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 156
 157         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 158         top.c (execute_command_to_ui_file): New function, mostly a copy
 159         of execute_command_to_string.
 160         (execute_command_to_string): Implement by calling
 161         execute_command_to_ui_file.
 162
 163 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 164
 165         * top.h (saved_command_line): Remove declaration.
 166         * top.c (previous_saved_command_line, previous_repeat_arguments):
 167         New variables.
 168         (saved_command_line): Make static, define together with other
 169         'repeat variables'.
 170         (dont_repeat): Clear repeat_arguments.
 171         (repeat_previous, get_saved_command_line, save_command_line):
 172         New functions.
 173         (gdb_init): Initialize saved_command_line
 174         and previous_saved_command_line.
 175         * main.c (captured_main_1): Remove saved_command_line initialization.
 176         * event-top.c (handle_line_of_input): Update to use
 177         the new 'repeat' related functions instead of direct access to
 178         saved_command_line.
 179         * command.h (repeat_previous, get_saved_command_line,
 180         save_command_line): New declarations.
 181         (dont_repeat): Add comment.
 182
 183 2019-05-30  Tom Tromey  <tromey@adacore.com>
 184
 185         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 186         Fix comment.
 187         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 188
 189 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 190
 191         PR cli/24587
 192         * completer.c (complete): Initialize variable word.
 193
 194 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 195
 196         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 197         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 198         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 199         'body' is NULL to the outter 'if', protecting the '!is_define'
 200         situation as well.
 201
 202 2019-05-29  Tom Tromey  <tromey@adacore.com>
 203
 204         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 205         (dwarf_unknown): New function.
 206         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 207         (dwarf_type_encoding_name): Use dwarf_unknown.
 208
 209 2019-05-29  Tom Tromey  <tromey@adacore.com>
 210
 211         PR c++/20020:
 212         * cp-valprint.c (cp_print_value_fields): Call
 213         cp_print_static_field inside "try".
 214
 215 2019-05-29  Tom Tromey  <tromey@adacore.com>
 216
 217         * inflow.c (struct terminal_info): Add default operator=.
 218         * configure: Rebuild.
 219         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 220         -Wdeprecated-copy-dtor, -Wredundant-move.
 221
 222 2019-05-29  Tom Tromey  <tromey@adacore.com>
 223
 224         * NEWS: Add entry.
 225         * infcmd.c (print_return_value_1): Handle finish_print
 226         option.
 227         (show_print_finish): New function.
 228         (_initialize_infcmd): Add "set/show print finish" commands.
 229         * valprint.c (user_print_options): Initialize new member.
 230         * valprint.h (struct value_print_options) <finish_print>: New
 231         member.
 232
 233 2019-05-28  Tom Tromey  <tromey@adacore.com>
 234
 235         * ada-lang.c (ada_remove_Xbn_suffix)
 236         (find_old_style_renaming_symbol)
 237         (parse_old_style_renaming): Remove.
 238         (ada_find_renaming_symbol): Don't call
 239         find_old_style_renaming_symbol.
 240         (ada_is_renaming_symbol): Rename from
 241         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 242         bool.  Now static.
 243         (ada_read_var_value): Update and simplify.
 244         * ada-exp.y (write_var_or_type): Remove old code.
 245
 246 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 247
 248         * event-top.c: Remove include comment.
 249         * inflow.c (class scoped_ignore_sigttou): Move from here...
 250         * inflow.h (class scoped_ignore_sigttou): ...to here.
 251         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 252         * top.c:  Remove include comment.
 253
 254 2019-05-27  Tom Tromey  <tom@tromey.com>
 255
 256         * NEWS: Fix typo.
 257
 258 2019-05-22  Tom Tromey  <tromey@adacore.com>
 259
 260         * target.c (target_follow_exec): Constify parameter.
 261         * target-delegates.c: Rebuild.
 262         * remote.c (remote_target::follow_exec): Constify parameter.
 263         * infrun.c (follow_exec): Constify parameter.
 264         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 265         (target_follow_exec): Likewise.
 266
 267 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 268
 269         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 270         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 271
 272 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 273
 274         * NEWS: Add debugredirect and testsuite sections.
 275
 276 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 277
 278         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 279         target descriptions using exclusively floating point register name
 280         aliases.
 281
 282 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         PR gdb/18644:
 285         * f-lang.c (build_fortran_types): Handle the case where
 286         gdbarch_floatformat_for_type returns a nullptr.
 287
 288 2019-05-21  Tom de Vries  <tdevries@suse.de>
 289
 290         PR cli/24587
 291         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 292
 293 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         PR gdb/18644:
 296         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 297         16-byte floats.
 298         * i386-tdep.c (i386_floatformat_for_type): Use
 299         floatformats_ia64_quad for the 16-byte floating point component
 300         within a fortran 32-byte complex number.
 301
 302 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 303
 304         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 305         delete default constructor.
 306         (find_partial_die): Update to return const struct.
 307         (partial_die_parent_scope): Move variable declaration into scope
 308         of its use and change its type to auto.
 309         (guess_partial_die_structure_name): Likewise.
 310         (partial_die_info::fixup): Likewise.
 311
 312 2019-05-17  Tom Tromey  <tromey@adacore.com>
 313
 314         * source.c (find_and_open_source): Remove cast.
 315
 316 2019-05-17  Tom Tromey  <tromey@adacore.com>
 317
 318         * annotate.c (annotate_source): Make "filename" const.
 319         * annotate.h (annotate_source): Use const.
 320
 321 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 322
 323         * disasm.c (set_disassembler_options): Send errors to stderr.
 324
 325 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 326
 327         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 328         (cli_interp_base::set_logging): Check debug_redirect.
 329         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 330         * cli/cli-logging.c (debug_redirect): Add static variable.
 331         (pop_output_files): Add default param.
 332         (handle_redirections): Print debug setting.
 333         (show_logging_command): Likewise.
 334         (_initialize_cli_logging): Add debugredirect command.
 335         * interps.c (current_interp_set_logging): Add debug_redirect
 336         parameter.
 337         * interps.h (set_logging): Add debug_redirect parameter.
 338         (current_interp_set_logging): Likewise.
 339         * mi/mi-common.h: Likewise.
 340         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 341
 342 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 343             Tom Tromey  <tromey@adacore.com>
 344
 345         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 346         directly.
 347         * cli/cli-interp.h (make_logging_output): Remove declaration.
 348         * cli/cli-logging.c (make_logging_output): Remove function.
 349         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 350         directly.
 351         * ui-file.c (tee_file::tee_file): Remove bools.
 352         (tee_file::~tee_file): Remove deletes.
 353         * ui-file.h (tee_file): Remove bools.
 354
 355 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 356
 357         * mi/mi-cmds.h (mi_cmd_complete): New function.
 358         * mi/mi-main.c (mi_cmd_complete): Likewise.
 359         * mi/mi-cmds.c: Define new MI command -complete.
 360         * NEWS: Mention new -complete command.
 361
 362 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 363
 364         * completer.h (complete): New function.
 365         * completer.c (complete): Likewise.
 366         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 367         function defined in completer.h.
 368
 369 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 370
 371        * MAINTAINERS (Write After Approval): Add myself.
 372
 373 2019-05-17  Tom de Vries  <tdevries@suse.de>
 374
 375         PR gdb/24094
 376         * dwarf2read.c (struct cu_partial_die_info): New struct.
 377         (find_partial_die): Return cu_partial_die_info.
 378         (partial_die_parent_scope, guess_partial_die_structure_name)
 379         (partial_die_info::fixup): Handle new return type of find_partial_die.
 380
 381 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 382
 383         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 384         "std::string", simplifying the algorithm.
 385
 386 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 387
 388         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 389         (stap_static_probe_ops::get_probes): Likewise.
 390
 391 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 392
 393         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 394         '-')" and "else if".
 395         (stap_parse_single_operand): Join checks for
 396         "gdbarch_stap_parse_special_token_p" and
 397         "gdbarch_stap_parse_special_token" in the same "if" statement.
 398         Invert check when verifying for operation on register
 399         displacement.
 400
 401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 402
 403         * stap-probe.c (stap_get_opcode): Update comment.
 404         (stap_get_expected_argument_type): Likewise.
 405         (handle_stap_probe): Likewise.
 406
 407 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 408
 409         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 410         return type to 'bool'.  Adjust comment.  Use 'bool' when
 411         appropriate.
 412         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 413         * stap-probe.c (stap_parse_argument_1): Likewise.
 414         (stap_is_operator): Likewise.
 415         (stap_is_generic_prefix): Likewise.
 416         (stap_is_register_prefix): Likewise.
 417         (stap_is_register_indirection_prefix): Likewise.
 418         (stap_is_integer_prefix): Likewise.
 419         (stap_generic_check_suffix): Likewise.
 420         (stap_check_integer_suffix): Likewise.
 421         (stap_check_register_suffix): Likewise.
 422         (stap_check_register_indirection_suffix): Likewise.
 423         (stap_parse_register_operand): Likewise.
 424         (stap_parse_single_operand): Likewise.
 425         (stap_parse_argument_1): Likewise.
 426         (stap_probe::get_argument_count): Likewise.
 427         (stap_is_operator): Likewise.
 428
 429 2019-05-16  Tom Tromey  <tromey@adacore.com>
 430
 431         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 432         keyword to foreach.
 433
 434 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 435
 436         * linux-thread-db.c (try_thread_db_load_1): Change return type
 437         to bool.
 438         (try_thread_db_load): Likewise.
 439         (try_thread_db_load_from_pdir_1): Likewise.
 440         (try_thread_db_load_from_pdir): Likewise.
 441         (try_thread_db_load_from_sdir): Likewise.
 442         (try_thread_db_load_from_dir): Likewise.
 443         (thread_db_load_search): Likewise.
 444         (has_libpthread): Likewise.
 445         (thread_db_load): Likewise.
 446
 447 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 448
 449         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 450         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 451         NULL, and complain/return if that's the case.
 452
 453 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 454
 455         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 456         (advance, posn, abstract_read_memory): New functions.
 457         [struct mem_read_abstraction]: New struct.
 458         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 459
 460 2019-05-14  Tom Tromey  <tromey@adacore.com>
 461
 462         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 463         value is not lval_memory.
 464
 465 2019-05-14  Tom Tromey  <tromey@adacore.com>
 466
 467         * solib.c (info_sharedlibrary_command): Style the file name.
 468
 469 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 470
 471         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 472         (aarch64_vnv_type): Likewise.
 473         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 474         * common/tdesc.c: Likewise.
 475         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 476         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 477         * features/aarch64-fpu.xml: Add ieee half view.
 478         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 479         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 480         * gdbtypes.h (struct builtin_type): Likewise.
 481         (struct objfile_type): Likewise.
 482
 483 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 484
 485         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 486         typo.
 487         * location.h (string_to_event_location): Likewise.
 488
 489 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 490
 491         GDB 8.3 released.
 492
 493 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 494
 495         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 496         New variable declaration.
 497         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 498         New variable.
 499         (print_one_breakpoint): Use ui_out::test_flags and new global
 500         variable to compute use_fixed_output.
 501         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 502         Remove.
 503         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 504         (mi_multi_location_breakpoint_output_fixed): Remove.
 505         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 506         new variable.
 507         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 508         fix_multi_location_breakpoint_output flag if version >= 3.
 509         * ui-out.h (enum ui_out_flag)
 510         <fix_multi_location_breakpoint_output>: New enumerator.
 511
 512 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 513
 514         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 515
 516 2019-05-10  Tom Tromey  <tromey@adacore.com>
 517
 518         * ada-lang.c (catch_ada_completer): New function.
 519         (_initialize_ada_language): Use it.
 520
 521 2019-05-10  Tom Tromey  <tromey@adacore.com>
 522
 523         * thread.c (print_thread_info): Make "requested_threads" const.
 524         * gdbthread.h (print_thread_info): Make "requested_threads"
 525         const.
 526         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 527         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 528
 529 2019-05-08  Tom Tromey  <tom@tromey.com>
 530
 531         * gdbtypes.c (objfile_type_data): Change type.
 532         (objfile_type, _initialize_gdbtypes): Update.
 533
 534 2019-05-08  Tom Tromey  <tom@tromey.com>
 535
 536         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 537         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 538         (_initialize_dwarf2_frame): Update.
 539
 540 2019-05-08  Tom Tromey  <tom@tromey.com>
 541
 542         * objc-lang.c (objc_objfile_data): Change type.
 543         (find_methods): Update.
 544         (_initialize_objc_lang): Remove.
 545
 546 2019-05-08  Tom Tromey  <tom@tromey.com>
 547
 548         * stabsread.c (rs6000_builtin_type_data): Change type.
 549         (rs6000_builtin_type, _initialize_stabsread): Update.
 550
 551 2019-05-08  Tom Tromey  <tom@tromey.com>
 552
 553         * mips-tdep.c (mips_pdr_data): Remove.
 554         (_initialize_mips_tdep): Update.
 555
 556 2019-05-08  Tom Tromey  <tom@tromey.com>
 557
 558         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 559         (hppa_init_objfile_priv_data, read_unwind_info)
 560         (find_unwind_entry, _initialize_hppa_tdep): Update.
 561
 562 2019-05-08  Tom Tromey  <tom@tromey.com>
 563
 564         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 565         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 566         on obstack.
 567         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 568
 569 2019-05-08  Tom Tromey  <tom@tromey.com>
 570
 571         * mdebugread.c (basic_type_data): Change type.
 572         (basic_type, _initialize_mdebugread): Update.
 573
 574 2019-05-08  Tom Tromey  <tom@tromey.com>
 575
 576         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 577
 578 2019-05-08  Tom Tromey  <tom@tromey.com>
 579
 580         * nto-tdep.c (nto_inferior_data_reg): Change type.
 581         (nto_inferior_data): Update.
 582         (nto_inferior_data_cleanup, nto_new_inferior_data)
 583         (_initialize_nto_tdep): Remove.
 584         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 585
 586 2019-05-08  Tom Tromey  <tom@tromey.com>
 587
 588         * ada-lang.c (struct ada_inferior_data): Add initializers.
 589         (ada_inferior_data): Change type.
 590         (ada_inferior_data_cleanup): Remove.
 591         (get_ada_inferior_data, ada_inferior_exit)
 592         (struct ada_pspace_data): Add initializers, destructor.
 593         (ada_pspace_data_handle): Change type.
 594         (get_ada_pspace_data): Update.
 595         (ada_pspace_data_cleanup): Remove.
 596
 597 2019-05-08  Tom Tromey  <tom@tromey.com>
 598
 599         * coffread.c (struct coff_symfile_info): Add initializers.
 600         (coff_objfile_data_key): Move lower.  Change type.
 601         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 602         Update.
 603         (coff_free_info): Remove.
 604
 605 2019-05-08  Tom Tromey  <tom@tromey.com>
 606
 607         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 608         (fbsd_pspace_data_handle): Move lower.  Change type.
 609         (get_fbsd_pspace_data): Update.
 610         (fbsd_pspace_data_cleanup): Remove.
 611         (_initialize_fbsd_tdep): Update.
 612
 613 2019-05-08  Tom Tromey  <tom@tromey.com>
 614
 615         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 616         (get_ada_tasks_pspace_data): Update.
 617         (ada_tasks_pspace_data_cleanup): Remove.
 618         (_initialize_tasks): Update.
 619         (ada_tasks_inferior_data_handle): Change type.
 620         (get_ada_tasks_inferior_data): Update.
 621         (ada_tasks_inferior_data_cleanup): Remove.
 622         (struct ada_tasks_pspace_data): Add initializers.
 623
 624 2019-05-08  Tom Tromey  <tom@tromey.com>
 625
 626         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 627         * symfile-debug.c (debug_sym_get_probes): Change type.
 628         * stap-probe.c (handle_stap_probe):
 629         (stap_static_probe_ops::get_probes): Change type.
 630         * probe.h (class static_probe_ops) <get_probes>: Change type.
 631         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 632         (parse_probes_in_pspace): Update.
 633         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 634         Update.
 635         (any_static_probe_ops::get_probes): Change type.
 636         * elfread.c (elfread_data): New typedef.
 637         (probe_key): Change type.
 638         (elf_get_probes): Likewise.  Update.
 639         (probe_key_free): Remove.
 640         (_initialize_elfread): Update.
 641         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 642         Change type.
 643         (dtrace_process_dof_probe, dtrace_process_dof)
 644         (dtrace_static_probe_ops::get_probe): Change type.
 645
 646 2019-05-08  Tom Tromey  <tom@tromey.com>
 647
 648         * xcoffread.c (struct xcoff_symfile_info): Rename from
 649         coff_symfile_info.  Add initializers.
 650         (xcoff_objfile_data_key): Move lower.  Change type.
 651         (XCOFF_DATA): Rewrite.
 652         (xcoff_free_info): Remove.
 653         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 654         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 655         (xcoff_initial_scan): Update.
 656
 657 2019-05-08  Tom Tromey  <tom@tromey.com>
 658
 659         * solib-svr4.c (struct svr4_info): Add initializers and
 660         destructor.
 661         <probes_table>: Now an htab_up.
 662         (solib_svr4_pspace_data): Change type.
 663         (free_probes_table): Simplify.
 664         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 665         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 666         (probes_table_remove_objfile_probes, register_solib_event_probe)
 667         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 668         (_initialize_svr4_solib): Update.
 669
 670 2019-05-08  Tom Tromey  <tom@tromey.com>
 671
 672         * remote.c (remote_pspace_data): Change type.
 673         (remote_pspace_data_cleanup): Remove.
 674         (get_remote_exec_file, set_pspace_remote_exec_file)
 675         (_initialize_remote): Update.
 676
 677 2019-05-08  Tom Tromey  <tom@tromey.com>
 678
 679         * breakpoint.c (breakpoint_objfile_key): Change type.
 680         (get_breakpoint_objfile_data): Update.
 681         (free_breakpoint_objfile_data): Remove.
 682         (_initialize_breakpoint): Update.
 683
 684 2019-05-08  Tom Tromey  <tom@tromey.com>
 685
 686         * linux-tdep.c (struct linux_info): Add initializers.
 687         (linux_inferior_data): Move.  Change type.
 688         (invalidate_linux_cache_inf): Update.
 689         (linux_inferior_data_cleanup): Remove.
 690         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 691
 692 2019-05-08  Tom Tromey  <tom@tromey.com>
 693
 694         * auxv.c (auxv_inferior_data): Move.  Change type.
 695         (auxv_inferior_data_cleanup): Remove.
 696         (invalidate_auxv_cache_inf): Rewrite.
 697         (get_auxv_inferior_data, _initialize_auxv): Update.
 698
 699 2019-05-08  Tom Tromey  <tom@tromey.com>
 700
 701         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 702         (symfile_debug_objfile_data_key): Change type.
 703         (symfile_debug_installed, debug_qf_has_symbols)
 704         (debug_qf_find_last_source_symtab)
 705         (debug_qf_forget_cached_source_info)
 706         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 707         (debug_qf_print_stats, debug_qf_dump)
 708         (debug_qf_expand_symtabs_for_function)
 709         (debug_qf_expand_all_symtabs)
 710         (debug_qf_expand_symtabs_with_fullname)
 711         (debug_qf_map_matching_symbols)
 712         (debug_qf_expand_symtabs_matching)
 713         (debug_qf_find_pc_sect_compunit_symtab)
 714         (debug_qf_map_symbol_filenames)
 715         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 716         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 717         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 718         (debug_sym_read_linetable, debug_sym_relocate): Update.
 719         (symfile_debug_free_objfile): Remove.
 720         (install_symfile_debug_logging, _initialize_symfile_debug):
 721         Update.
 722
 723 2019-05-08  Tom Tromey  <tom@tromey.com>
 724
 725         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 726         allocate_on_obstack.
 727         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 728         (get_dwarf2_per_objfile): Update.
 729         (set_dwarf2_per_objfile): Remove.
 730         (dwarf2_has_info, dwarf2_get_section_info): Update.
 731         (dwarf2_free_objfile): Remove.
 732         (_initialize_dwarf2_read): Update.
 733
 734 2019-05-08  Tom Tromey  <tom@tromey.com>
 735
 736         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 737         initializers.
 738         <unsupported_script_warning_printed,
 739         script_not_found_warning_printed>: Now bool.
 740         (auto_load_pspace_data): Change type.
 741         (~auto_load_pspace_info): Rename from
 742         auto_load_pspace_data_cleanup.
 743         (get_auto_load_pspace_data, init_loaded_scripts_info)
 744         (clear_section_scripts, maybe_print_unsupported_script_warning)
 745         (maybe_print_script_not_found_warning, _initialize_auto_load):
 746         Update.
 747
 748 2019-05-08  Tom Tromey  <tom@tromey.com>
 749
 750         * objfiles.c (objfile_pspace_info): Add destructor and
 751         initializers.
 752         (objfiles_pspace_data): Change type.
 753         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 754         (get_objfile_pspace_data): Update.
 755         (objfiles_bfd_data): Change type.
 756         (get_objfile_bfd_data): Update.
 757         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 758
 759 2019-05-08  Tom Tromey  <tom@tromey.com>
 760
 761         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 762         Change type.
 763         (get_catch_syscall_inferior_data): Update.
 764         (catch_syscall_inferior_data_cleanup): Remove.
 765         (_initialize_break_catch_syscall): Update.
 766
 767 2019-05-08  Tom Tromey  <tom@tromey.com>
 768
 769         * inflow.c (struct terminal_info): Add destructor and
 770         initializers.
 771         (inflow_inferior_data): Change type.
 772         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 773         (get_inflow_inferior_data, inflow_inferior_exit)
 774         (swap_terminal_info, _initialize_inflow): Update.
 775
 776 2019-05-08  Tom Tromey  <tom@tromey.com>
 777
 778         * target-dcache.c (target_dcache_cleanup): Remove.
 779         (target_dcache_aspace_key): Change type.
 780         (target_dcache_init_p, target_dcache_invalidate)
 781         (target_dcache_get, target_dcache_get_or_init)
 782         (_initialize_target_dcache): Update.
 783         * dcache.h (struct dcache_deleter): New.
 784
 785 2019-05-08  Tom Tromey  <tom@tromey.com>
 786
 787         * symtab.c (struct symbol_cache): Add destructor and
 788         initializers.
 789         (symbol_cache_key): Move.  Change type.
 790         (make_symbol_cache, free_symbol_cache): Remove.
 791         (get_symbol_cache): Update.
 792         (symbol_cache_cleanup): Remove.
 793         (ALL_PSPACES, symbol_cache_flush)
 794         (maintenance_print_symbol_cache)
 795         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 796         Update.
 797
 798 2019-05-08  Tom Tromey  <tom@tromey.com>
 799
 800         * symtab.c (struct main_info): Add destructor and initializers.
 801         (main_progspace_key): Move.  Change type.
 802         (get_main_info): Update.
 803         (main_info_cleanup): Remove.
 804         (_initialize_symtab): Update.
 805
 806 2019-05-08  Tom Tromey  <tom@tromey.com>
 807
 808         * registry.h (DECLARE_REGISTRY): Define the _key class.
 809
 810 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * NEWS: Merge two 'New commands' sections.
 813
 814 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 815
 816         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 817         parameter and use Ada language definition instead.
 818         (ada_val_print_ptr): Remove unused language parameter.
 819         (ada_val_print_num): Remove language parameter and use Ada language
 820         definition instead.
 821         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 822         parameter.
 823         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 824         parameter and use Ada language definition instead.
 825         (ada_val_print_1): Update all ada_val_print_xxx calls.
 826         Remove language parameter.
 827         (ada_val_print): Update ada_val_print_1 call.
 828
 829 2019-05-08  Tom Tromey  <tromey@adacore.com>
 830
 831         * remote.c (remote_hw_watchpoint_limit)
 832         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 833         Now static.
 834
 835 2019-05-08  Tom Tromey  <tromey@adacore.com>
 836
 837         * maint.c (_initialize_maint_cmds): Move initialization code to
 838         remote.c.
 839         (watchdog, show_watchdog): Move to remote.c.
 840         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 841         "watchdog" static.
 842         (_initialize_remote): Move initialization code from maint.c.
 843         * defs.h (watchdog): Don't declare.
 844
 845 2019-05-08  Tom Tromey  <tromey@adacore.com>
 846
 847         * tui/tui-interp.c: Include main.h.
 848         * interps.c: Include main.h.
 849         * main.h (interpreter_p): Declare.
 850         * defs.h (interpreter_p): Don't declare.
 851
 852 2019-05-08  Tom Tromey  <tromey@adacore.com>
 853
 854         * dwarf2loc.c: Include dwarf2read.h.
 855         * defs.h (read_unsigned_leb128): Don't declare.
 856         * dwarf2read.h (read_unsigned_leb128): Declare.
 857
 858 2019-05-08  Tom Tromey  <tromey@adacore.com>
 859
 860         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 861         method.
 862
 863 2019-05-08  Tom Tromey  <tromey@adacore.com>
 864
 865         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 866         when no wrap column is set.
 867
 868 2019-05-08  Tom Tromey  <tromey@adacore.com>
 869
 870         * c-lang.c (c_get_string): Handle non-C-style arrays.
 871
 872 2019-05-08  Tom Tromey  <tromey@adacore.com>
 873
 874         * typeprint.c (print_offset_data::update): Print the bit offset,
 875         not the number of bits remaining.
 876
 877 2019-05-08  Tom Tromey  <tromey@adacore.com>
 878
 879         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 880         padding at end of comment.
 881
 882 2019-05-08  Tom Tromey  <tromey@adacore.com>
 883
 884         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 885         Compare main types.
 886
 887 2019-05-06  Tom Tromey  <tom@tromey.com>
 888
 889         * common/scoped_mmap.c: Include common-defs.h.
 890         * common/scoped_mmap.h: Don't include config.h.
 891
 892 2019-05-04  Tom Tromey  <tom@tromey.com>
 893
 894         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 895         (struct aarch64_call_info): Add initializers.
 896         <si>: Now a std::vector.
 897         (pass_on_stack, aarch64_push_dummy_call): Update.
 898
 899 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 900             Tom Tromey  <tom@tromey.com>
 901
 902         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 903         (ppc_threads): Now a std::vector.  Now static.
 904         (hwdebug_find_thread_points_by_tid)
 905         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 906         Update.
 907
 908 2019-05-04  Tom Tromey  <tom@tromey.com>
 909
 910         * arc-tdep.c (arc_tdesc_init): Return bool.
 911
 912 2019-05-04  Tom Tromey  <tom@tromey.com>
 913
 914         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 915         Use gdb_assert_not_reached.
 916
 917 2019-05-04  Tom Tromey  <tom@tromey.com>
 918
 919         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 920         "false".
 921
 922 2019-05-04  Tom Tromey  <tom@tromey.com>
 923
 924         * arc-tdep.c (arc_tdesc_init): Use bool.
 925
 926 2019-05-04  Tom Tromey  <tom@tromey.com>
 927
 928         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 929
 930 2019-05-04  Tom Tromey  <tom@tromey.com>
 931
 932         * cli/cli-cmds.c (valid_command_p): Return bool.
 933
 934 2019-05-04  Tom Tromey  <tom@tromey.com>
 935
 936         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 937         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 938
 939 2019-05-04  Raul Tambre  <raul@tambre.ee>
 940
 941         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 942         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 943         operator for comparison.
 944
 945 2019-05-04  Tom Tromey  <tom@tromey.com>
 946
 947         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 948         (lookup_partial_symbol, print_partial_symbols)
 949         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 950         (psymbol_compare): Update.
 951         (add_psymbol_to_bcache): Clear the entire psymbol.
 952         (maintenance_check_psymtabs): Update.
 953         * psympriv.h (struct partial_symbol): Don't derive from
 954         general_symbol_info.
 955         <obj_section, unrelocated_address, address,
 956         set_unrelocated_address>: Update.
 957         <ginfo>: New member.
 958         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 959         (debug_names::write_psymbols): Update.
 960
 961 2019-05-04  Tom de Vries  <tdevries@suse.de>
 962
 963         * contrib/cc-with-tweaks.sh: Support -n arg.
 964
 965 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 966
 967         * corelow.c (core_target::detach): Ensure frame cache and
 968         register caches are cleared.
 969         inferior.c (exit_inferior_1): Likewise.
 970
 971 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 972             Tom Tromey  <tom@tromey.com>
 973
 974         * dictionary.c (collate_pending_symbols_by_language): Remove
 975         "struct" from foreach.
 976         * symtab.c (lookup_global_symbol_from_objfile)
 977         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 978         foreach.
 979         * ser-tcp.c (net_open): Remove "struct" from foreach.
 980         * objfiles.c (objfile_relocate, objfile_rebase)
 981         (objfile_has_symbols): Remove "struct" from foreach.
 982         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 983         from foreach.
 984         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 985         foreach.
 986         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 987         "struct" from foreach.
 988         * ada-lang.c (create_excep_cond_exprs)
 989         (ada_exception_catchpoint_cond_string): Remove "struct" from
 990         foreach.
 991
 992 2019-05-03  Tom Tromey  <tromey@adacore.com>
 993
 994         * ada-exp.y (convert_char_literal): Check suffix of each
 995         enumerator.
 996
 997 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 998
 999         PR ada/21406:
1000         * ada-exp.y (yywrap): Don't define.
1001         * ada-lex.l (%option): Add noyywrap
1002         (yywrap): Remove.
1003
1004 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1005
1006         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1007         _WIN32_WINNT to the XP level, unless already defined to a higher
1008         level.
1009
1010         * unittests/parse-connection-spec-selftests.c:
1011         * ser-tcp.c:
1012         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1013         override.
1014
1015         * symfile.c (find_separate_debug_file): Remove colon from the
1016         drive spec of DOS/Windows file names of the target, so that the
1017         file name produced from DEBUGDIR and the target's directory will
1018         be valid on DOS/Windows systems.
1019
1020 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * rust-lang.c (val_print_struct): Handle printing structures
1023         containing strings.
1024
1025 2019-05-02  Tom Tromey  <tromey@adacore.com>
1026
1027         * valarith.c (_initialize_valarith): Remove.
1028
1029 2019-05-01  Tom Tromey  <tromey@adacore.com>
1030
1031         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1032         bitfields.
1033
1034 2019-05-01  Tom Tromey  <tromey@adacore.com>
1035
1036         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1037         for big-endian copies.
1038
1039 2019-04-30  Ali Tamur  <tamur@google.com>
1040         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1041         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1042         (read_3_bytes): New function.
1043
1044 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1045
1046         * windows-nat.c (main_thread_id): Delete.
1047         (handle_output_debug_string): Replace main_thread_id by
1048         current_event.dwThreadId.
1049         (fake_create_process): Likewise.
1050         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1051         Do not set main_thread_id.
1052         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1053         current_event.dwThreadId.
1054         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1055
1056 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1057
1058         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1059         Use current_event.dwThreadId instead of main_thread_id.
1060
1061 2019-04-30  Tom Tromey  <tromey@adacore.com>
1062
1063         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1064         (create_excep_cond_exprs): Iterate over program spaces.
1065         (ada_exception_catchpoint_cond_string): Examine all minimal
1066         symbols for exception types.
1067
1068 2019-04-30  Tom Tromey  <tromey@adacore.com>
1069
1070         PR c++/24470:
1071         * dwarf2read.c (process_structure_scope): Handle case where type
1072         has template parameters but no symbol was created.
1073
1074 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1075             Chris January  <chris.january@arm.com>
1076
1077         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1078         qualifier.
1079         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1080
1081 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * f-typeprint.c (f_print_type): Update rules for printing
1084         whitespace.
1085         (f_type_print_varspec_suffix): Likewise.
1086
1087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1088             Chris January  <chris.january@arm.com>
1089
1090         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1091         function arguments.
1092
1093 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1094
1095         * f-lang.c (build_fortran_types): Change name of void type to
1096         lower case.
1097         * f-typeprint.c (f_type_print_base): Print the name of the void
1098         type, rather than a fixed string.
1099         * f-valprint.c (f_decorations): Use lower case void string.
1100
1101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1102             Chris January  <chris.january@arm.com>
1103
1104         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1105         types for Fortran.
1106
1107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1108             Chris January  <chris.january@arm.com>
1109             David Lecomber  <david.lecomber@arm.com>
1110
1111         * f-exp.y (BINOP_INTRINSIC): New token.
1112         (exp): New parser rule handling BINOP_INTRINSIC.
1113         (f77_keywords): Add new builtin procedures.
1114         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1115         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1116         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1117         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1118         (print_unop_subexp_f): New function.
1119         (print_binop_subexp_f): New function.
1120         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1121         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1122         (dump_subexp_body_f): Likewise.
1123         (operator_check_f): Likewise.
1124         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1125         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1126
1127 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1130         UNOP_KIND.
1131         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1132         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1133         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1134         (operator_length_f): New fuction.
1135         (print_subexp_f): New function.
1136         (op_name_f): New function.
1137         (dump_subexp_body_f): New function.
1138         (operator_check_f): New function.
1139         (exp_descriptor_f): Replace standard expression handling functions
1140         with new functions.
1141         * gdb/fortran-operator.def: New file.
1142         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1143         * gdb/std-operator.def: Remove UNOP_KIND.
1144
1145 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * std-operator.def: Remove unbalanced, stray double quote
1148         character.
1149
1150 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1151             Chris January  <chris.january@arm.com>
1152             Daniel Everett  <daniel.everett@arm.com>
1153             Nick Forrington  <nick.forrington@arm.com>
1154             Richard Bunt  <richard.bunt@arm.com>
1155
1156         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1157         of depth when printing anonymous structs or unions.
1158         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1159         Don't print either the top-level value, or the children if the
1160         max-depth is exceeded.
1161         (ppscm_print_children): When printing the key of a map, allow one
1162         extra level of depth.
1163         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1164         print either the top-level value, or the children if the max-depth
1165         is exceeded.
1166         (print_children): When printing the key of a map, allow one extra
1167         level of depth.
1168         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1169         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1170         (user_print_options): Initialise max_depth field.
1171         (val_print_scalar_or_string_type_p): New function.
1172         (val_print): Check to see if the max depth has been reached.
1173         (val_print_check_max_depth): Define new function.
1174         (show_print_max_depth): New function.
1175         (_initialize_valprint): Add 'print max-depth' option.
1176         * valprint.h (struct value_print_options) <max_depth>: New field.
1177         (val_print_check_max_depth): Declare new function.
1178         * NEWS: Document new feature.
1179
1180 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * ada-lang.c (ada_language_defn): Initialise new field.
1183         * c-lang.c (c_is_string_type_p): New function.
1184         (c_language_defn): Initialise new field.
1185         (cplus_language_defn): Initialise new field.
1186         (asm_language_defn): Initialise new field.
1187         (minimal_language_defn): Initialise new field.
1188         * c-lang.h (c_is_string_type_p): Declare new function.
1189         * d-lang.c (d_language_defn): Initialise new field.
1190         * f-lang.c (f_is_string_type_p): New function.
1191         (f_language_defn): Initialise new field.
1192         * go-lang.c (go_is_string_type_p): New function.
1193         (go_language_defn): Initialise new field.
1194         * language.c (default_is_string_type_p): New function.
1195         (unknown_language_defn): Initialise new field.
1196         (auto_language_defn): Initialise new field.
1197         * language.h (struct language_defn) <la_is_string_type_p>: New
1198         member variable.
1199         (default_is_string_type_p): Declare new function.
1200         * m2-lang.c (m2_language_defn): Initialise new field.
1201         * objc-lang.c (objc_language_defn): Initialise new field.
1202         * opencl-lang.c (opencl_language_defn): Initialise new field.
1203         * p-lang.c (pascal_is_string_type_p): New function.
1204         (pascal_language_defn): Initialise new field.
1205         * rust-lang.c (rust_is_string_type_p): New function.
1206         (rust_language_defn): Initialise new field.
1207
1208 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1211         New field.
1212         * ada-lang.c (ada_language_defn): Initialise new field.
1213         * c-lang.c (c_language_defn): Likewise.
1214         (cplus_language_defn): Likewise.
1215         (asm_language_defn): Likewise.
1216         (minimal_language_defn): Likewise.
1217         * d-lang.c (d_language_defn): Likewise.
1218         * f-lang.c (f_language_defn): Likewise.
1219         * go-lang.c (go_language_defn): Likewise.
1220         * language.c (unknown_language_defn): Likewise.
1221         (auto_language_defn): Likewise.
1222         * m2-lang.c (m2_language_defn): Likewise.
1223         * objc-lang.c (objc_language_defn): Likewise.
1224         * opencl-lang.c (opencl_language_defn): Likewise.
1225         * p-lang.c (pascal_language_defn): Likewise.
1226         * rust-lang.c (rust_language_defn): Likewise.
1227
1228 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * ada-lang.c (ada_is_character_type): Change return type to bool.
1231         (ada_is_string_type): Likewise.
1232         * ada-lang.h (ada_is_character_type): Update declaration
1233         (ada_is_string_type): Likewise.
1234
1235 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1236
1237         Support style in 'frame|thread apply'
1238
1239         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1240         * record.c (record_start, record_stop): Update callers of
1241         execute_command_to_string with false.
1242         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1243         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1244         methods.
1245         (class string_file): New constructor with term_out parameter.
1246         Override methods term_out and can_emit_style_escape.  New member
1247         term_out.
1248         (class stdio_file): Override can_emit_style_escape.
1249         (class tee_file): Override term_out and can_emit_style_escape.
1250         * utils.h (can_emit_style_escape): Remove.
1251         * utils.c (can_emit_style_escape): Likewise.
1252         Update all callers of can_emit_style_escape (SOMESTREAM) to
1253         SOMESTREAM->can_emit_style_escape.
1254         * source-cache.c (source_cache::get_source_lines): Likewise.
1255         * stack.c (frame_apply_command_count): Call execute_command_to_string
1256         passing the term_out characteristic of the current gdb_stdout.
1257         * thread.c (thr_try_catch_cmd): Likewise.
1258         * top.c (execute_command_to_string): pass term_out parameter
1259         to construct the string_file for the command output.
1260         * ui-file.c (term_cli_styling): New function (most code moved
1261         from utils.c can_emit_style_escape).
1262         (string_file::string_file, string_file::can_emit_style_escape,
1263         stdio_file::can_emit_style_escape, tee_file::term_out,
1264         tee_file::can_emit_style_escape): New functions.
1265
1266 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1267
1268         * NEWS: Mention the new set|show may-call-functions.
1269         * infcall.c (may_call_functions_p): New variable.
1270         (show_may_call_functions_p): New function.
1271         (call_function_by_hand_dummy): Throws an error if not
1272         may-call-functions.
1273         (_initialize_infcall): Call add_setshow_boolean_cmd for
1274         may-call-functions.
1275
1276 2019-04-25  Keith Seitz  <keiths@redhat.com>
1277
1278         PR c++/24367
1279         * cp-support.c (inspect_type): Don't attempt substitutions
1280         of symbol with the same name.
1281
1282 2019-04-25  Tom Tromey  <tromey@adacore.com>
1283
1284         PR gdb/24475:
1285         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1286         static.
1287
1288 2019-04-25  Tom Tromey  <tromey@adacore.com>
1289
1290         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1291         rvalue reference.
1292         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1293         (gdb_xml_parser::parse): Use std::move.
1294         * python/python-internal.h (gdbpy_convert_exception): Take a const
1295         reference.
1296         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1297         std::move.
1298         * python/py-utils.c (gdbpy_convert_exception): Take a const
1299         reference.
1300         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1301         Use std::move.
1302         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1303         Use std::move.
1304         * mi/mi-main.c (mi_print_exception): Take a const reference.
1305         * main.c (handle_command_errors): Take a const reference.
1306         * linespec.c (parse_linespec): Use std::move.
1307         * infcall.c (run_inferior_call): Use std::move.
1308         (call_function_by_hand_dummy): Use std::move.
1309         * exec.c (try_open_exec_file): Use std::move.
1310         * exceptions.h (exception_print, exception_fprintf)
1311         (exception_print_same): Update.
1312         * exceptions.c (print_exception, exception_print)
1313         (exception_fprintf, exception_print_same): Change parameters to
1314         const reference.
1315         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1316         * common/new-op.c: Use std::move.
1317         * common/common-exceptions.h (struct gdb_exception): Add move
1318         constructor.
1319         (struct gdb_exception_error, struct gdb_exception_quit, struct
1320         gdb_quit_bad_alloc): Change constructor to move constructor.
1321         (throw_exception): Change parameter to rvalue reference.
1322         * common/common-exceptions.c (throw_exception): Take rvalue
1323         reference.
1324         * cli/cli-interp.c (safe_execute_command): Use std::move.
1325         * breakpoint.c (insert_bp_location, location_to_sals): Use
1326         std::move.
1327
1328 2019-04-25  Tom Tromey  <tromey@adacore.com>
1329
1330         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1331         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1332         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1333         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1334         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1335         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1336         guile/scm-value.c: Use unpack.
1337         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1338         gdbscm_gdb_exception.
1339         (gdbscm_throw_gdb_exception): Likewise.
1340         (struct gdbscm_gdb_exception): New.
1341         (unpack): New function.
1342         (gdbscm_wrap): Use unpack.
1343
1344 2019-04-25  Tom Tromey  <tromey@adacore.com>
1345
1346         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1347         (gdb_rl_callback_handler): Use std::move.
1348         * common/common-exceptions.h (struct gdb_exception): Add move
1349         assignment operator.
1350         (throw_exception_sjlj): Change "exception" to const reference.
1351         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1352         (throw_exception_sjlj): Change "exception" to const reference.
1353
1354 2019-04-25  Tom Tromey  <tromey@adacore.com>
1355
1356         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1357         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1358         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1359         Update.
1360         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1361         Update.
1362         * mi/mi-interp.c (mi_interp::exec): Update.
1363         * linespec.c (parse_linespec): Update.
1364         * infcall.c (run_inferior_call): Update.
1365         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1366         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1367         (gdbscm_lookup_global_symbol): Update.
1368         * guile/scm-param.c (gdbscm_parameter_value): Update.
1369         * guile/scm-frame.c (gdbscm_frame_read_register)
1370         (gdbscm_frame_read_var): Update.
1371         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1372         * exec.c (try_open_exec_file): Update.
1373         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1374         (gdb_rl_callback_handler): Update.
1375         * common/common-exceptions.h (exception_none): Don't declare.
1376         * common/common-exceptions.c (exception_none): Don't define.
1377         (struct catcher) <exception>: Update.
1378         * cli/cli-interp.c (safe_execute_command): Update.
1379         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1380
1381 2019-04-25  Ali Tamur  <tamur@google.com>
1382
1383         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1384         (read_attribute_value): Likewise.
1385         (dwarf2_read_addr_index): Update comment.
1386         (read_str_index): Add DW_FORM_strx.
1387         (dwarf2_string_attr): Likewise.
1388         (dwarf2_const_value_attr): Likewise.
1389         (dump_die_shallow): Likewise.
1390         (dwarf2_fetch_constant_bytes): Likewise.
1391         (skip_form_bytes): Likewise.
1392         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1393
1394 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1395
1396         PR corefiles/11608
1397         PR corefiles/18187
1398         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1399         OFFSET.  Verify if current mapping contains an ELF header.
1400         (linux_find_memory_regions_full): Adjust call to
1401         dump_mapping_p.
1402
1403 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1404             Kang Li <kanglictf@gmail.com>
1405
1406         PR gdb/21600
1407
1408         * dwarf2-frame.c (read_initial_length): Be consistent about using
1409         unsigned representation of length.
1410         (decode_frame_entry_1): Likewise.  Check for wraparound of
1411         end pointer as well as buffer overflow.
1412
1413 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1414
1415         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1416         "vq".
1417
1418 2019-04-24  Tom Tromey  <tromey@adacore.com>
1419
1420         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1421
1422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1423
1424         * s12z-tdep.c (s12z_unwind_pc): Delete.
1425         (s12z_unwind_sp): Delete.
1426         (s12z_gdbarch_init): Don't register deleted functions with
1427         gdbarch.
1428
1429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1430
1431         * rl78-tdep.c (rl78_unwind_sp): Delete.
1432         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1433
1434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1435
1436         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1437         (xstormy16_unwind_pc): Delete.
1438         (xstormy16_dummy_id): Delete.
1439         (xstormy16_gdbarch_init): Don't register deleted functions with
1440         gdbarch.
1441
1442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * vax-tdep.c (vax_unwind_pc): Delete.
1445         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1446
1447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * v850-tdep.c (v850_unwind_sp): Delete.
1450         (v850_unwind_pc): Delete.
1451         (v850_dummy_id): Delete.
1452         (v850_gdbarch_init): Don't register deleted functions with
1453         gdbarch.
1454
1455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1458         (tilegx_unwind_pc): Delete.
1459         (tilegx_unwind_dummy_id): Delete.
1460         (tilegx_gdbarch_init): Don't register deleted functions with
1461         gdbarch.
1462
1463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1464
1465         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1466         (tic6x_dummy_id): Delete.
1467         (tic6x_gdbarch_init): Don't register deleted functions with
1468         gdbarch.
1469
1470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * sparc-tdep.c (sparc_unwind_pc): Delete.
1473         (sparc32_gdbarch_init): Don't register deleted function with
1474         gdbarch.
1475
1476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * sh-tdep.c (sh_unwind_sp): Delete.
1479         (sh_unwind_pc): Delete.
1480         (sh_dummy_id): Delete.
1481         (sh_gdbarch_init): Don't register deleted functions with
1482         gdbarch.
1483
1484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1485
1486         * score-tdep.c (score_unwind_sp): Delete.
1487         (score_unwind_pc): Delete.
1488         (score_dummy_id): Delete.
1489         (score_gdbarch_init): Don't register deleted functions with
1490         gdbarch.
1491
1492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1493
1494         * rx-tdep.c (rx_unwind_pc): Delete.
1495         (rx_unwind_sp): Delete.
1496         (rx_dummy_id): Delete.
1497         (rx_gdbarch_init): Don't register deleted functions with
1498         gdbarch.  Update comment.
1499
1500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1503         (rs6000_dummy_id): Delete.
1504         (rs6000_gdbarch_init): Don't register deleted functions with
1505         gdbarch.
1506
1507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1508
1509         * or1k-tdep.c (or1k_dummy_id): Delete.
1510         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1511
1512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1513
1514         * nios2-tdep.c (nios2_dummy_id): Delete.
1515         (nios2_unwind_sp): Delete.
1516         (nios2_gdbarch_init): Don't register deleted functions with
1517         gdbarch.
1518
1519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * nds32-tdep.c (nds32_dummy_id): Delete.
1522         (nds32_unwind_pc): Delete.
1523         (nds32_unwind_sp): Delete.
1524         (nds32_gdbarch_init): Don't register deleted functions with
1525         gdbarch.
1526
1527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * msp430-tdep.c (msp430_unwind_pc): Delete.
1530         (msp430_unwind_sp): Delete.
1531         (msp430_dummy_id): Delete.
1532         (msp430_gdbarch_init): Don't register deleted functions with
1533         gdbarch.
1534
1535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * moxie-tdep.c (moxie_unwind_sp): Delete.
1538         (moxie_unwind_pc): Delete.
1539         (moxie_dummy_id): Delete.
1540         (moxie_gdbarch_init): Don't register deleted functions with
1541         gdbarch.
1542
1543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1544
1545         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1546         (mn10300_unwind_pc): Delete.
1547         (mn10300_unwind_sp): Delete.
1548         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1549         mn10300_unwind_sp.
1550         (mn10300_frame_unwind_init): Don't register deleted functions with
1551         gdbarch.
1552
1553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * mep-tdep.c (mep_unwind_pc): Delete.
1556         (mep_unwind_sp): Delete.
1557         (mep_dummy_id): Delete.
1558         (mep_gdbarch_init): Don't register deleted functions with
1559         gdbarch.
1560
1561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1564         (m68hc11_unwind_sp): Delete.
1565         (m68hc11_gdbarch_init): Don't register deleted functions with
1566         gdbarch.
1567
1568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * m32r-tdep.c (m32r_unwind_sp): Delete.
1571         (m32r_unwind_pc): Delete.
1572         (m32r_dummy_id): Delete.
1573         (m32r_gdbarch_init): Don't register deleted functions with
1574         gdbarch.
1575
1576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * m32c-tdep.c (m32c_unwind_pc): Delete.
1579         (m32c_unwind_sp): Delete.
1580         (m32c_dummy_id): Delete.
1581         (m32c_gdbarch_init): Don't register deleted functions with
1582         gdbarch.
1583
1584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1587         (lm32_unwind_pc): Delete.
1588         (lm32_dummy_id): Delete.
1589         (lm32_gdbarch_init): Don't register deleted functions with
1590         gdbarch.
1591
1592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1593
1594         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1595         (iq2000_unwind_pc): Delete.
1596         (iq2000_dummy_id): Delete.
1597         (iq2000_gdbarch_init): Don't register deleted functions with
1598         gdbarch.
1599
1600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * nds32-tdep.c (nds32_type_align): Delete.
1603         (nds32_push_dummy_call): Use type_align instead.
1604
1605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * arm-tdep.c (arm_type_align): Only handle vector override case.
1608         (arm_push_dummy_call): Use type_align.
1609         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1610
1611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1614         case.
1615         (pass_on_stack): Use type_align.
1616         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1617         function.
1618
1619 2019-04-23  Tom Tromey  <tromey@adacore.com>
1620
1621         * dwarf2read.c (line_header::file_name_at): Remove unused
1622         overload.
1623
1624 2019-04-23  Tom de Vries  <tdevries@suse.de>
1625
1626         PR gdb/24438
1627         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1628         invocation.
1629
1630
1631 2019-03-27  Ali Tamur  <tamur@google.com>
1632
1633         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1634         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1635         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1636         (dwarf_expr_context::get_addr_index): Likewise
1637         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1638         (symbol_needs_eval_context::get_addr_index): Likewise
1639         (disassemble_dwarf_expression): Add DW_OP_addrx
1640         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1641         (read_cutu_die_from_dwo): Update comment
1642         (skip_one_die): Add DW_FORM_addrx
1643         (read_attribute_value): Likewise
1644         (var_decode_location): Add DW_OP_addrx
1645         (dwarf2_const_value_attr): Add DW_FORM_addrx
1646         (dump_die_shallow): Likewise
1647         (dwarf2_fetch_constant_bytes): Likewise
1648         (decode_locdesc): Add DW_OP_addrx
1649         (skip_form_bytes): Add DW_FORM_addrx
1650
1651 2019-04-22  Ali Tamur  <tamur@google.com>
1652
1653         * MAINTAINERS (Write After Approval): Add self.
1654
1655 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1656
1657         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1658         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1659         (open_symbol_file_object): Likewise.
1660         (svr4_default_sos): Add info parameter.
1661         (svr4_read_so_list): Likewise.
1662         (svr4_current_sos_direct): Adjust functions calls to pass down
1663         info.
1664         (svr4_current_sos_1): Add info parameter.
1665         (svr4_current_sos): Call get_svr4_info, pass info down to
1666         svr4_current_sos_1.
1667         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1668         get_svr4_info.
1669         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1670         get_svr4_info.
1671         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1672         to get_svr4_info.
1673         (probes_table_remove_objfile_probes): Likewise.
1674         (register_solib_event_probe): Add info parameter.
1675         (solist_update_incremental): Pass info parameter down to
1676         svr4_read_so_list.
1677         (disable_probes_interface): Add info parameter.
1678         (svr4_handle_solib_event): Pass current_program_space to
1679         get_svr4_info.  Adjust disable_probes_interface cleanup.
1680         (svr4_create_probe_breakpoints): Add info parameter, pass it
1681         down to register_solib_event_probe.
1682         (svr4_create_solib_event_breakpoints): Add info parameter,
1683         pass it down to svr4_create_probe_breakpoints.
1684         (enable_break): Pass info down to
1685         svr4_create_solib_event_breakpoints.
1686         (svr4_solib_create_inferior_hook): Pass current_program_space to
1687         get_svr4_info.
1688         (svr4_clear_solib): Likewise.
1689
1690 2019-04-22  Pedro Alves  <palves@redhat.com>
1691
1692         * solib-svr4.c (svr4_free_objfile_observer): New.
1693         (probe_and_action::objfile): New field.
1694         (probes_table_htab_remove_objfile_probes)
1695         (probes_table_remove_objfile_probes): New functions.
1696         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1697         in the new probe_and_action.  Don't store the probe in 'lookup'.
1698         (svr4_create_probe_breakpoints): Pass objfile to
1699         register_solib_event_probe.
1700         (_initialize_svr4_solib): Register a free_objfile observer.
1701
1702 2019-04-19  Tom Tromey  <tom@tromey.com>
1703
1704         * common/queue.h: Remove.
1705
1706 2019-04-19  Tom Tromey  <tom@tromey.com>
1707
1708         * event-loop.c: Don't include "common/queue.h".
1709
1710 2019-04-19  Tom Tromey  <tom@tromey.com>
1711
1712         * remote.c (remote_target): Use delete.
1713         * remote-notif.h: Include <list>, not "common/queue.h".
1714         (notif_client_p): Remove typedef.
1715         (remote_notif_state): Add constructor, destructor, initializer.
1716         <notif_queue>: Now a std::list.
1717         (remote_notif_state_xfree): Don't declare.
1718         * remote-notif.c (remote_notif_process, handle_notification)
1719         (remote_notif_state_allocate): Update.
1720         (~remote_notif_state): Rename from remote_notif_state_xfree.
1721
1722 2019-04-19  Tom Tromey  <tom@tromey.com>
1723
1724         * symfile.c (reread_symbols): Update.
1725         * objfiles.c (objfile_register_static_link)
1726         (objfile_lookup_static_link): Update
1727         (~objfile) Don't delete static_links.
1728         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1729
1730 2019-04-19  Tom Tromey  <tom@tromey.com>
1731
1732         * type-stack.h (struct type_stack) <insert>: Constify string.
1733         * type-stack.c (type_stack::insert): Constify string.
1734         * gdbtypes.h (lookup_template_type): Update.
1735         (address_space_name_to_int): Update.
1736         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1737         const.
1738         (lookup_template_type): Make name const.
1739         * c-exp.y: Update rules.
1740         (lex_one_token, classify_name, classify_inner_name)
1741         (c_print_token): Update.
1742         * p-exp.y: Update rules.
1743         (yylex): Update.
1744         * f-exp.y: Update rules.
1745         (yylex): Update.
1746         * d-exp.y: Update rules.
1747         (lex_one_token, classify_name, classify_inner_name): Update.
1748         * parse.c (write_dollar_variable, copy_name): Return std::string.
1749         * parser-defs.h (copy_name): Change return type.
1750         * m2-exp.y: Update rules.
1751         (yylex): Update.
1752         * go-exp.y (lex_one_token): Update.
1753         Update rules.
1754         (classify_unsafe_function, classify_packaged_name)
1755         (classify_name, yylex): Update.
1756
1757 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1758
1759         * configure.ac: add --enable-source-highlight switch.
1760         * configure: Regenerate.
1761         * top.c (print_gdb_version): plumb --enable-source-highlight
1762         status to "show configuration".
1763
1764 2019-04-19  Tom Tromey  <tromey@adacore.com>
1765
1766         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1767         Check ADA_TYPE_P.
1768         (empty_record, ada_template_to_fixed_record_type_1)
1769         (template_to_static_fixed_type)
1770         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1771         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1772         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1773         macros.
1774
1775 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1776
1777         PR symtab/24423:
1778         * source.c (print_source_lines_base): Advance "iter" when a
1779         control character is seen.
1780
1781 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1782
1783         * inferior.h (struct infcall_suspend_state_deleter):
1784         Catch exception in destructor to avoid crash.
1785
1786 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1787
1788         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1789         close to the add_com "shell".
1790
1791 2019-04-18  Tom Tromey  <tromey@adacore.com>
1792
1793         * process-stratum-target.h (class process_stratum_target)
1794         <stratum>: Add "final".
1795
1796 2019-04-17  Tom Tromey  <tromey@adacore.com>
1797
1798         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1799         against nullptr before use.
1800
1801 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1802
1803         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1804
1805 2019-04-17  Jim Wilson  <jimw@sifive.com>
1806             Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1809         code read might fail, assume 4-byte breakpoint in that case.
1810
1811 2019-04-15  Leszek Swirski  <leszeks@google.com>
1812
1813         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1814         rather than a hand-rolled POD check when checking for forced MEMORY
1815         classification.
1816
1817 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1818
1819         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1820         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1821         function.
1822         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1823         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1824         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1825         declaration.
1826
1827 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1828
1829         * aarch64-linux-nat.c
1830         (aarch64_linux_nat_target::thread_architecture): Add override.
1831         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1832         each VQ.
1833
1834 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1835
1836         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1837
1838 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1841         target types of size 96-bits, add some additional comments, and
1842         check that the builtin type we found was the correct size.
1843
1844 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1845
1846         * utils.c (prompt_for_continue): Don't restore the styling at the
1847         end, as applied_style has the wrong value.  This fixes styling in
1848         long lists of file names that are interrupted by the "Continue?"
1849         prompt.
1850
1851 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1854         * c-lang.c (c_language_defn): Likewise.
1855         (cplus_language_defn): Likewise.
1856         (asm_language_defn): Likewise.
1857         (minimal_language_defn): Likewise.
1858         * d-lang.c (d_language_defn): Likewise.
1859         * f-lang.c (f_language_defn): Likewise.
1860         * go-lang.c (go_language_defn): Likewise.
1861         * language.c (unknown_language_defn): Likewise.
1862         (auto_language_defn): Likewise.
1863         * language.h (struct language_defn): Remove la_magic field.
1864         (LANG_MAGIC): Delete.
1865         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1866         * objc-lang.c (objc_language_defn): Likewise.
1867         * opencl-lang.c (opencl_language_defn): Likewise.
1868         * p-lang.c (pascal_language_defn): Likewise.
1869         * rust-lang.c (rust_language_defn): Likewise.
1870
1871 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1872
1873         * riscv-tdep.c (riscv_type_align): New function.
1874         (riscv_type_alignment): Delete.
1875         (riscv_arg_location): Use 'type_align'.
1876         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1877
1878 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * gdbtypes.c (type_align): A struct with no non-static fields also
1881         has alignment of 1.
1882
1883 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1884
1885         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1886         component to 0.
1887         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1888         member.
1889         (riscv_struct_info::analyse): New implementation using new
1890         analyse_inner member function.
1891         (riscv_struct_info::field_offset): New member function.
1892         (riscv_struct_info::m_offsets): New member variable.
1893         (riscv_struct_info::analyse_inner): New private member function,
1894         takes the old implementation of riscv_struct_info::analyse but
1895         extended to track field offsets.
1896         (riscv_call_arg_struct): Update the struct folding special cases
1897         to handle cases where empty C++ structs, which are non-zero
1898         length, are found.
1899         (riscv_arg_location): Initialise the length of each location, a
1900         non-zero length now indicates the location is in use.
1901         (riscv_push_dummy_call): Allow for the first location having a
1902         non-zero offset when setting up arguments.
1903         (riscv_return_value): Likewise, but for return values.
1904
1905 2019-04-11  Tom Tromey  <tromey@adacore.com>
1906
1907         * utils.c (internal_vproblem): Make "msg" const.
1908
1909 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1910
1911         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1912         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1913         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1914         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1915
1916 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1917
1918         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1919         function.
1920         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1921         of amd64_collect_native_gregset.
1922         (amd64_linux_nat_target::store_registers): Likewise.
1923
1924 2019-04-10  Tom Tromey  <tom@tromey.com>
1925
1926         * symtab.c (lookup_global_symbol_from_objfile)
1927         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1928         * objfiles.h (class separate_debug_iterator): New.
1929         (class separate_debug_range): New.
1930         (struct objfile) <separate_debug_objfiles>: New method.
1931         (objfile_separate_debug_iterate): Don't declare.
1932         * objfiles.c (separate_debug_iterator::operator++): Rename from
1933         objfile_separate_debug_iterate.
1934         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1935         iterator.
1936         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1937         iterator.
1938
1939 2019-04-10  Tom Tromey  <tom@tromey.com>
1940
1941         * symfile.c (reread_symbols): Remove old comment.
1942         * objfiles.c (free_all_objfiles): Fix a typo.
1943
1944 2019-04-10  Tom Tromey  <tom@tromey.com>
1945
1946         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1947         * minsyms.c (lookup_minimal_symbol): Use foreach.
1948         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1949         (lookup_minimal_symbol_solib_trampoline): Likewise.
1950         * symfile.c (reread_symbols): Use foreach.
1951
1952 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1953             Tom Tromey  <tromey@adacore.com>
1954
1955         PR rust/24414:
1956         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1957         (rust_lex_int_test): Change "value" to be LONGEST.
1958         (rust_lex_tests): Add test for long integer literal.
1959
1960 2019-04-09  Tom Tromey  <tromey@adacore.com>
1961
1962         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1963         to bool.
1964         (extended_remote_target::attach): Update.
1965         (remote_target::remote_notice_new_inferior): Update.
1966         (remote_target::add_current_inferior_and_thread): Update.
1967         * inferior.c (exit_inferior_1): Use "false".
1968         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1969
1970 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1971
1972         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1973         the "start" command.
1974
1975 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1976
1977         * python/py-inferior.c (infpy_thread_from_thread_handle):
1978         Adjust comments to reflect renaming of thread_from_thread_handle
1979         to thread_from_handle.  Adjust keywords.  Fix type error message.
1980         (inferior_object_methods): Add thread_from_handle.  Retain
1981         thread_from_thread_handle, but mark it as deprecated.
1982
1983 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1984
1985         * gdbthread.h (find_thread_by_handle): Revise declaration.
1986         * thread.c (find_thread_by_handle): Likewise.  Adjust
1987         implementation too.
1988         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1989         support for buffer objects as handles.
1990
1991 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1992
1993         * python/py-infthread.c (thpy_thread_handle): New function.
1994         (thread_object_methods): Register thpy_thread_handle.
1995
1996 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1997
1998         * gdbthread.h (thread_to_thread_handle): Declare.
1999         * thread.c (gdbtypes.h): Include.
2000         (thread_to_thread_handle): New function.
2001
2002         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2003         (target_thread_info_to_thread_handle): Declare.
2004         * target.c (target_thread_info_to_thread_handle): New function.
2005         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2006         * target-delegates.c: Regenerate.
2007
2008         * linux-thread-db.c (class thread_db_target): Add method
2009         thread_info_to_thread_handle.
2010         (thread_db_target::thread_info_to_thread_handle): Define.
2011         * remote.c (class remote_target): Add new method
2012         thread_info_to_thread_handle.
2013         (remote_target::thread_info_to_thread_handle): Define.
2014
2015 2019-04-08  Pedro Alves  <palves@redhat.com>
2016
2017         * common/common-exceptions.c (throw_exception): Don't create
2018         named object to throw; throw directly.
2019         (throw_it): Likewise.  Don't initialize gdb_exception::message
2020         here, with new; pass FMT and AP to the ctor instead.
2021         * common/common-exceptions.h: Include <string>.
2022         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2023         const char *, va_list)): New ctor.  Use std::make_shared.
2024         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2025         errors)): Delete.
2026         (gdb_exception_error::gdb_exception_error(enum errors, const char
2027         *, va_list)): New.
2028         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2029         Add assertion.
2030         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2031         errors)): Delete.
2032         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2033         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2034         Add assertion.
2035
2036 2019-04-08  Tom Tromey  <tom@tromey.com>
2037
2038         * valops.c (value_rtti_indirect_type): Replace throw_exception
2039         with throw.
2040         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2041         with throw.
2042         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2043         throw.
2044         * target.c (target_translate_tls_address): Replace throw_exception
2045         with throw.
2046         * stack.c (frame_apply_command_count): Replace throw_exception
2047         with throw.
2048         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2049         throw.
2050         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2051         with throw.
2052         * rs6000-tdep.c (rs6000_frame_cache)
2053         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2054         * remote.c: Replace throw_exception with throw.
2055         * record-full.c (record_full_message, record_full_wait_1)
2056         (record_full_restore): Replace throw_exception with throw.
2057         * record-btrace.c:
2058         (get_thread_current_frame_id, record_btrace_start_replaying)
2059         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2060         (cmd_record_btrace_start): Replace throw_exception with throw.
2061         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2062         throw.
2063         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2064         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2065         * linespec.c:
2066         (find_linespec_symbols): Replace throw_exception with throw.
2067         * infrun.c (displaced_step_prepare, resume): Replace
2068         throw_exception with throw.
2069         * infcmd.c (post_create_inferior): Replace throw_exception with
2070         throw.
2071         * inf-loop.c (inferior_event_handler): Replace throw_exception
2072         with throw.
2073         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2074         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2075         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2076         (get_prev_frame_always, get_frame_pc_if_available)
2077         (get_frame_address_in_block_if_available, get_frame_language):
2078         Replace throw_exception with throw.
2079         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2080         throw_exception with throw.
2081         * eval.c (fetch_subexp_value, evaluate_var_value)
2082         (evaluate_funcall, evaluate_subexp_standard): Replace
2083         throw_exception with throw.
2084         * dwarf2loc.c (call_site_find_chain)
2085         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2086         Replace throw_exception with throw.
2087         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2088         with throw.
2089         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2090         throw.
2091         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2092         * completer.c (complete_line_internal): Replace throw_exception
2093         with throw.
2094         * compile/compile-object-run.c (compile_object_run): Replace
2095         throw_exception with throw.
2096         * cli/cli-script.c (process_next_line): Replace throw_exception
2097         with throw.
2098         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2099         (btrace_enable, btrace_maint_update_pt_packets): Replace
2100         throw_exception with throw.
2101         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2102         throw_exception with throw.
2103         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2104         throw_exception with throw.
2105         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2106         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2107         * aarch64-tdep.c (aarch64_make_prologue_cache)
2108         (aarch64_make_stub_cache): Replace throw_exception with throw.
2109
2110 2019-04-08  Tom Tromey  <tom@tromey.com>
2111
2112         * common/common-exceptions.c (throw_exception): Rename from
2113         throw_exception_cxx.  Remove old copy.  Make argument const.
2114         (throw_it): Create and throw exception objects directly.
2115         * common/common-exceptions.h (throw_exception): Make argument
2116         const.
2117         (struct gdb_exception_error): Add constructor.
2118         (struct gdb_exception_quit): Add constructor.
2119
2120 2019-04-08  Tom Tromey  <tom@tromey.com>
2121
2122         * common/common-exceptions.h (exception_rethrow): Don't declare.
2123         (TRY_SJLJ): Update comment.
2124         (TRY, CATCH, END_CATCH): Remove.
2125         * common/common-exceptions.c (exception_rethrow): Remove.
2126
2127 2019-04-08  Tom Tromey  <tom@tromey.com>
2128
2129         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2130         Remove.
2131         (gdb_exception_error): Rename from
2132         gdb_exception_RETURN_MASK_ERROR.
2133         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2134         (gdb_quit_bad_alloc): Update.
2135         * aarch64-tdep.c: Update.
2136         * ada-lang.c: Update.
2137         * ada-typeprint.c: Update.
2138         * ada-valprint.c: Update.
2139         * amd64-tdep.c: Update.
2140         * arch-utils.c: Update.
2141         * break-catch-throw.c: Update.
2142         * breakpoint.c: Update.
2143         * btrace.c: Update.
2144         * c-varobj.c: Update.
2145         * cli/cli-cmds.c: Update.
2146         * cli/cli-interp.c: Update.
2147         * cli/cli-script.c: Update.
2148         * common/common-exceptions.c: Update.
2149         * common/new-op.c: Update.
2150         * common/selftest.c: Update.
2151         * compile/compile-c-symbols.c: Update.
2152         * compile/compile-cplus-symbols.c: Update.
2153         * compile/compile-object-load.c: Update.
2154         * compile/compile-object-run.c: Update.
2155         * completer.c: Update.
2156         * corelow.c: Update.
2157         * cp-abi.c: Update.
2158         * cp-support.c: Update.
2159         * cp-valprint.c: Update.
2160         * darwin-nat.c: Update.
2161         * disasm-selftests.c: Update.
2162         * dtrace-probe.c: Update.
2163         * dwarf-index-cache.c: Update.
2164         * dwarf-index-write.c: Update.
2165         * dwarf2-frame-tailcall.c: Update.
2166         * dwarf2-frame.c: Update.
2167         * dwarf2loc.c: Update.
2168         * dwarf2read.c: Update.
2169         * eval.c: Update.
2170         * event-loop.c: Update.
2171         * event-top.c: Update.
2172         * exec.c: Update.
2173         * f-valprint.c: Update.
2174         * fbsd-tdep.c: Update.
2175         * frame-unwind.c: Update.
2176         * frame.c: Update.
2177         * gdbtypes.c: Update.
2178         * gnu-v3-abi.c: Update.
2179         * guile/guile-internal.h: Update.
2180         * guile/scm-block.c: Update.
2181         * guile/scm-breakpoint.c: Update.
2182         * guile/scm-cmd.c: Update.
2183         * guile/scm-disasm.c: Update.
2184         * guile/scm-frame.c: Update.
2185         * guile/scm-lazy-string.c: Update.
2186         * guile/scm-math.c: Update.
2187         * guile/scm-param.c: Update.
2188         * guile/scm-ports.c: Update.
2189         * guile/scm-pretty-print.c: Update.
2190         * guile/scm-symbol.c: Update.
2191         * guile/scm-symtab.c: Update.
2192         * guile/scm-type.c: Update.
2193         * guile/scm-value.c: Update.
2194         * i386-linux-tdep.c: Update.
2195         * i386-tdep.c: Update.
2196         * inf-loop.c: Update.
2197         * infcall.c: Update.
2198         * infcmd.c: Update.
2199         * infrun.c: Update.
2200         * jit.c: Update.
2201         * language.c: Update.
2202         * linespec.c: Update.
2203         * linux-fork.c: Update.
2204         * linux-nat.c: Update.
2205         * linux-tdep.c: Update.
2206         * linux-thread-db.c: Update.
2207         * main.c: Update.
2208         * mi/mi-cmd-break.c: Update.
2209         * mi/mi-cmd-stack.c: Update.
2210         * mi/mi-interp.c: Update.
2211         * mi/mi-main.c: Update.
2212         * objc-lang.c: Update.
2213         * p-valprint.c: Update.
2214         * parse.c: Update.
2215         * ppc-linux-tdep.c: Update.
2216         * printcmd.c: Update.
2217         * python/py-arch.c: Update.
2218         * python/py-breakpoint.c: Update.
2219         * python/py-cmd.c: Update.
2220         * python/py-finishbreakpoint.c: Update.
2221         * python/py-frame.c: Update.
2222         * python/py-framefilter.c: Update.
2223         * python/py-gdb-readline.c: Update.
2224         * python/py-inferior.c: Update.
2225         * python/py-infthread.c: Update.
2226         * python/py-lazy-string.c: Update.
2227         * python/py-linetable.c: Update.
2228         * python/py-objfile.c: Update.
2229         * python/py-param.c: Update.
2230         * python/py-prettyprint.c: Update.
2231         * python/py-progspace.c: Update.
2232         * python/py-record-btrace.c: Update.
2233         * python/py-record.c: Update.
2234         * python/py-symbol.c: Update.
2235         * python/py-type.c: Update.
2236         * python/py-unwind.c: Update.
2237         * python/py-utils.c: Update.
2238         * python/py-value.c: Update.
2239         * python/python.c: Update.
2240         * record-btrace.c: Update.
2241         * record-full.c: Update.
2242         * remote-fileio.c: Update.
2243         * remote.c: Update.
2244         * riscv-tdep.c: Update.
2245         * rs6000-aix-tdep.c: Update.
2246         * rs6000-tdep.c: Update.
2247         * rust-exp.y: Update.
2248         * rust-lang.c: Update.
2249         * s390-tdep.c: Update.
2250         * selftest-arch.c: Update.
2251         * solib-dsbt.c: Update.
2252         * solib-frv.c: Update.
2253         * solib-spu.c: Update.
2254         * solib-svr4.c: Update.
2255         * solib.c: Update.
2256         * sparc64-linux-tdep.c: Update.
2257         * stack.c: Update.
2258         * symfile-mem.c: Update.
2259         * symmisc.c: Update.
2260         * target.c: Update.
2261         * thread.c: Update.
2262         * top.c: Update.
2263         * tracefile-tfile.c: Update.
2264         * tui/tui.c: Update.
2265         * typeprint.c: Update.
2266         * unittests/cli-utils-selftests.c: Update.
2267         * unittests/parse-connection-spec-selftests.c: Update.
2268         * valops.c: Update.
2269         * valprint.c: Update.
2270         * value.c: Update.
2271         * varobj.c: Update.
2272         * windows-nat.c: Update.
2273         * x86-linux-nat.c: Update.
2274         * xml-support.c: Update.
2275
2276 2019-04-08  Tom Tromey  <tom@tromey.com>
2277
2278         * xml-support.c: Use C++ exception handling.
2279         * x86-linux-nat.c: Use C++ exception handling.
2280         * windows-nat.c: Use C++ exception handling.
2281         * varobj.c: Use C++ exception handling.
2282         * value.c: Use C++ exception handling.
2283         * valprint.c: Use C++ exception handling.
2284         * valops.c: Use C++ exception handling.
2285         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2286         handling.
2287         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2288         * typeprint.c: Use C++ exception handling.
2289         * tui/tui.c: Use C++ exception handling.
2290         * tracefile-tfile.c: Use C++ exception handling.
2291         * top.c: Use C++ exception handling.
2292         * thread.c: Use C++ exception handling.
2293         * target.c: Use C++ exception handling.
2294         * symmisc.c: Use C++ exception handling.
2295         * symfile-mem.c: Use C++ exception handling.
2296         * stack.c: Use C++ exception handling.
2297         * sparc64-linux-tdep.c: Use C++ exception handling.
2298         * solib.c: Use C++ exception handling.
2299         * solib-svr4.c: Use C++ exception handling.
2300         * solib-spu.c: Use C++ exception handling.
2301         * solib-frv.c: Use C++ exception handling.
2302         * solib-dsbt.c: Use C++ exception handling.
2303         * selftest-arch.c: Use C++ exception handling.
2304         * s390-tdep.c: Use C++ exception handling.
2305         * rust-lang.c: Use C++ exception handling.
2306         * rust-exp.y: Use C++ exception handling.
2307         * rs6000-tdep.c: Use C++ exception handling.
2308         * rs6000-aix-tdep.c: Use C++ exception handling.
2309         * riscv-tdep.c: Use C++ exception handling.
2310         * remote.c: Use C++ exception handling.
2311         * remote-fileio.c: Use C++ exception handling.
2312         * record-full.c: Use C++ exception handling.
2313         * record-btrace.c: Use C++ exception handling.
2314         * python/python.c: Use C++ exception handling.
2315         * python/py-value.c: Use C++ exception handling.
2316         * python/py-utils.c: Use C++ exception handling.
2317         * python/py-unwind.c: Use C++ exception handling.
2318         * python/py-type.c: Use C++ exception handling.
2319         * python/py-symbol.c: Use C++ exception handling.
2320         * python/py-record.c: Use C++ exception handling.
2321         * python/py-record-btrace.c: Use C++ exception handling.
2322         * python/py-progspace.c: Use C++ exception handling.
2323         * python/py-prettyprint.c: Use C++ exception handling.
2324         * python/py-param.c: Use C++ exception handling.
2325         * python/py-objfile.c: Use C++ exception handling.
2326         * python/py-linetable.c: Use C++ exception handling.
2327         * python/py-lazy-string.c: Use C++ exception handling.
2328         * python/py-infthread.c: Use C++ exception handling.
2329         * python/py-inferior.c: Use C++ exception handling.
2330         * python/py-gdb-readline.c: Use C++ exception handling.
2331         * python/py-framefilter.c: Use C++ exception handling.
2332         * python/py-frame.c: Use C++ exception handling.
2333         * python/py-finishbreakpoint.c: Use C++ exception handling.
2334         * python/py-cmd.c: Use C++ exception handling.
2335         * python/py-breakpoint.c: Use C++ exception handling.
2336         * python/py-arch.c: Use C++ exception handling.
2337         * printcmd.c: Use C++ exception handling.
2338         * ppc-linux-tdep.c: Use C++ exception handling.
2339         * parse.c: Use C++ exception handling.
2340         * p-valprint.c: Use C++ exception handling.
2341         * objc-lang.c: Use C++ exception handling.
2342         * mi/mi-main.c: Use C++ exception handling.
2343         * mi/mi-interp.c: Use C++ exception handling.
2344         * mi/mi-cmd-stack.c: Use C++ exception handling.
2345         * mi/mi-cmd-break.c: Use C++ exception handling.
2346         * main.c: Use C++ exception handling.
2347         * linux-thread-db.c: Use C++ exception handling.
2348         * linux-tdep.c: Use C++ exception handling.
2349         * linux-nat.c: Use C++ exception handling.
2350         * linux-fork.c: Use C++ exception handling.
2351         * linespec.c: Use C++ exception handling.
2352         * language.c: Use C++ exception handling.
2353         * jit.c: Use C++ exception handling.
2354         * infrun.c: Use C++ exception handling.
2355         * infcmd.c: Use C++ exception handling.
2356         * infcall.c: Use C++ exception handling.
2357         * inf-loop.c: Use C++ exception handling.
2358         * i386-tdep.c: Use C++ exception handling.
2359         * i386-linux-tdep.c: Use C++ exception handling.
2360         * guile/scm-value.c: Use C++ exception handling.
2361         * guile/scm-type.c: Use C++ exception handling.
2362         * guile/scm-symtab.c: Use C++ exception handling.
2363         * guile/scm-symbol.c: Use C++ exception handling.
2364         * guile/scm-pretty-print.c: Use C++ exception handling.
2365         * guile/scm-ports.c: Use C++ exception handling.
2366         * guile/scm-param.c: Use C++ exception handling.
2367         * guile/scm-math.c: Use C++ exception handling.
2368         * guile/scm-lazy-string.c: Use C++ exception handling.
2369         * guile/scm-frame.c: Use C++ exception handling.
2370         * guile/scm-disasm.c: Use C++ exception handling.
2371         * guile/scm-cmd.c: Use C++ exception handling.
2372         * guile/scm-breakpoint.c: Use C++ exception handling.
2373         * guile/scm-block.c: Use C++ exception handling.
2374         * guile/guile-internal.h: Use C++ exception handling.
2375         * gnu-v3-abi.c: Use C++ exception handling.
2376         * gdbtypes.c: Use C++ exception handling.
2377         * frame.c: Use C++ exception handling.
2378         * frame-unwind.c: Use C++ exception handling.
2379         * fbsd-tdep.c: Use C++ exception handling.
2380         * f-valprint.c: Use C++ exception handling.
2381         * exec.c: Use C++ exception handling.
2382         * event-top.c: Use C++ exception handling.
2383         * event-loop.c: Use C++ exception handling.
2384         * eval.c: Use C++ exception handling.
2385         * dwarf2read.c: Use C++ exception handling.
2386         * dwarf2loc.c: Use C++ exception handling.
2387         * dwarf2-frame.c: Use C++ exception handling.
2388         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2389         * dwarf-index-write.c: Use C++ exception handling.
2390         * dwarf-index-cache.c: Use C++ exception handling.
2391         * dtrace-probe.c: Use C++ exception handling.
2392         * disasm-selftests.c: Use C++ exception handling.
2393         * darwin-nat.c: Use C++ exception handling.
2394         * cp-valprint.c: Use C++ exception handling.
2395         * cp-support.c: Use C++ exception handling.
2396         * cp-abi.c: Use C++ exception handling.
2397         * corelow.c: Use C++ exception handling.
2398         * completer.c: Use C++ exception handling.
2399         * compile/compile-object-run.c: Use C++ exception handling.
2400         * compile/compile-object-load.c: Use C++ exception handling.
2401         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2402         * compile/compile-c-symbols.c: Use C++ exception handling.
2403         * common/selftest.c: Use C++ exception handling.
2404         * common/new-op.c: Use C++ exception handling.
2405         * cli/cli-script.c: Use C++ exception handling.
2406         * cli/cli-interp.c: Use C++ exception handling.
2407         * cli/cli-cmds.c: Use C++ exception handling.
2408         * c-varobj.c: Use C++ exception handling.
2409         * btrace.c: Use C++ exception handling.
2410         * breakpoint.c: Use C++ exception handling.
2411         * break-catch-throw.c: Use C++ exception handling.
2412         * arch-utils.c: Use C++ exception handling.
2413         * amd64-tdep.c: Use C++ exception handling.
2414         * ada-valprint.c: Use C++ exception handling.
2415         * ada-typeprint.c: Use C++ exception handling.
2416         * ada-lang.c: Use C++ exception handling.
2417         * aarch64-tdep.c: Use C++ exception handling.
2418
2419 2019-04-08  Tom Tromey  <tom@tromey.com>
2420
2421         * xml-support.c (gdb_xml_parser::parse): Update.
2422         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2423         * value.c (show_convenience): Update.
2424         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2425         (test_parse_flags_qcs): Update.
2426         * thread.c (thr_try_catch_cmd): Update.
2427         * target.c (target_translate_tls_address): Update.
2428         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2429         (info_frame_command_core, frame_apply_command_count): Update.
2430         * rust-exp.y (rust_lex_exception_test): Update.
2431         * riscv-tdep.c (riscv_print_one_register_info): Update.
2432         * remote.c (remote_target::enable_btrace): Update.
2433         * record-btrace.c (record_btrace_enable_warn): Update.
2434         * python/py-utils.c (gdbpy_convert_exception): Update.
2435         * printcmd.c (do_one_display, print_variable_and_value): Update.
2436         * mi/mi-main.c (mi_print_exception): Update.
2437         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2438         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2439         * linux-nat.c (linux_nat_target::attach): Update.
2440         * linux-fork.c (class scoped_switch_fork_info): Update.
2441         * infrun.c (displaced_step_prepare): Update.
2442         * infcall.c (call_function_by_hand_dummy): Update.
2443         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2444         * gnu-v3-abi.c (print_one_vtable): Update.
2445         * frame.c (get_prev_frame_always): Update.
2446         * f-valprint.c (info_common_command_for_block): Update.
2447         * exec.c (try_open_exec_file): Update.
2448         * exceptions.c (print_exception, exception_print)
2449         (exception_fprintf, exception_print_same): Update.
2450         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2451         * dwarf-index-cache.c (index_cache::store)
2452         (index_cache::lookup_gdb_index): Update.
2453         * darwin-nat.c (maybe_cache_shell): Update.
2454         * cp-valprint.c (cp_print_value_fields): Update.
2455         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2456         (gcc_cplus_symbol_address): Update.
2457         * compile/compile-c-symbols.c (gcc_convert_symbol)
2458         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2459         * common/selftest.c: Update.
2460         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2461         a std::string.
2462         (exception_try_scope_entry, exception_try_scope_exit): Don't
2463         declare.
2464         (struct exception_try_scope): Remove.
2465         (TRY): Don't use exception_try_scope.
2466         (struct gdb_exception): Add constructor, operator=.
2467         <what>: New method.
2468         (struct gdb_exception_RETURN_MASK_ALL)
2469         (struct gdb_exception_RETURN_MASK_ERROR)
2470         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2471         (struct gdb_quit_bad_alloc): Update.
2472         * common/common-exceptions.c (exception_none): Change
2473         initializer.
2474         (struct catcher) <state, exception>: Initialize inline.
2475         <prev>: Remove member.
2476         (current_catcher): Remove.
2477         (catchers): New global.
2478         (exceptions_state_mc_init): Simplify.
2479         (catcher_pop): Remove.
2480         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2481         (try_scope_depth, exception_try_scope_entry)
2482         (exception_try_scope_exit): Remove.
2483         (throw_exception_sjlj): Update.
2484         (exception_messages, exception_messages_size): Remove.
2485         (throw_it): Simplify.
2486         (gdb_exception_sliced_copy): Remove.
2487         (throw_exception_cxx): Update.
2488         * cli/cli-script.c (script_from_file): Update.
2489         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2490         Update.
2491         * ada-valprint.c (ada_val_print): Update.
2492         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2493         (create_excep_cond_exprs): Update.
2494
2495 2019-04-08  Tom Tromey  <tom@tromey.com>
2496
2497         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2498         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2499         (TRY, CATCH, END_CATCH): Remove some definitions.
2500         * common/common-exceptions.c: Don't use GDB_XCPT.
2501         (catcher_list_size): Remove.
2502         (throw_exception, throw_it): Simplify.
2503
2504 2019-04-05  Tom Tromey  <tom@tromey.com>
2505
2506         Revert the header-sorting patch.
2507         * ft32-tdep.c: Revert.
2508         * frv-tdep.c: Revert.
2509         * frv-linux-tdep.c: Revert.
2510         * frame.c: Revert.
2511         * frame-unwind.c: Revert.
2512         * frame-base.c: Revert.
2513         * fork-child.c: Revert.
2514         * findvar.c: Revert.
2515         * findcmd.c: Revert.
2516         * filesystem.c: Revert.
2517         * filename-seen-cache.h: Revert.
2518         * filename-seen-cache.c: Revert.
2519         * fbsd-tdep.c: Revert.
2520         * fbsd-nat.h: Revert.
2521         * fbsd-nat.c: Revert.
2522         * f-valprint.c: Revert.
2523         * f-typeprint.c: Revert.
2524         * f-lang.c: Revert.
2525         * extension.h: Revert.
2526         * extension.c: Revert.
2527         * extension-priv.h: Revert.
2528         * expprint.c: Revert.
2529         * exec.h: Revert.
2530         * exec.c: Revert.
2531         * exceptions.c: Revert.
2532         * event-top.c: Revert.
2533         * event-loop.c: Revert.
2534         * eval.c: Revert.
2535         * elfread.c: Revert.
2536         * dwarf2read.h: Revert.
2537         * dwarf2read.c: Revert.
2538         * dwarf2loc.c: Revert.
2539         * dwarf2expr.h: Revert.
2540         * dwarf2expr.c: Revert.
2541         * dwarf2-frame.c: Revert.
2542         * dwarf2-frame-tailcall.c: Revert.
2543         * dwarf-index-write.h: Revert.
2544         * dwarf-index-write.c: Revert.
2545         * dwarf-index-common.c: Revert.
2546         * dwarf-index-cache.h: Revert.
2547         * dwarf-index-cache.c: Revert.
2548         * dummy-frame.c: Revert.
2549         * dtrace-probe.c: Revert.
2550         * disasm.h: Revert.
2551         * disasm.c: Revert.
2552         * disasm-selftests.c: Revert.
2553         * dictionary.c: Revert.
2554         * dicos-tdep.c: Revert.
2555         * demangle.c: Revert.
2556         * dcache.h: Revert.
2557         * dcache.c: Revert.
2558         * darwin-nat.h: Revert.
2559         * darwin-nat.c: Revert.
2560         * darwin-nat-info.c: Revert.
2561         * d-valprint.c: Revert.
2562         * d-namespace.c: Revert.
2563         * d-lang.c: Revert.
2564         * ctf.c: Revert.
2565         * csky-tdep.c: Revert.
2566         * csky-linux-tdep.c: Revert.
2567         * cris-tdep.c: Revert.
2568         * cris-linux-tdep.c: Revert.
2569         * cp-valprint.c: Revert.
2570         * cp-support.c: Revert.
2571         * cp-namespace.c: Revert.
2572         * cp-abi.c: Revert.
2573         * corelow.c: Revert.
2574         * corefile.c: Revert.
2575         * continuations.c: Revert.
2576         * completer.h: Revert.
2577         * completer.c: Revert.
2578         * complaints.c: Revert.
2579         * coffread.c: Revert.
2580         * coff-pe-read.c: Revert.
2581         * cli-out.h: Revert.
2582         * cli-out.c: Revert.
2583         * charset.c: Revert.
2584         * c-varobj.c: Revert.
2585         * c-valprint.c: Revert.
2586         * c-typeprint.c: Revert.
2587         * c-lang.c: Revert.
2588         * buildsym.c: Revert.
2589         * buildsym-legacy.c: Revert.
2590         * build-id.h: Revert.
2591         * build-id.c: Revert.
2592         * btrace.c: Revert.
2593         * bsd-uthread.c: Revert.
2594         * breakpoint.h: Revert.
2595         * breakpoint.c: Revert.
2596         * break-catch-throw.c: Revert.
2597         * break-catch-syscall.c: Revert.
2598         * break-catch-sig.c: Revert.
2599         * blockframe.c: Revert.
2600         * block.c: Revert.
2601         * bfin-tdep.c: Revert.
2602         * bfin-linux-tdep.c: Revert.
2603         * bfd-target.c: Revert.
2604         * bcache.c: Revert.
2605         * ax-general.c: Revert.
2606         * ax-gdb.h: Revert.
2607         * ax-gdb.c: Revert.
2608         * avr-tdep.c: Revert.
2609         * auxv.c: Revert.
2610         * auto-load.c: Revert.
2611         * arm-wince-tdep.c: Revert.
2612         * arm-tdep.c: Revert.
2613         * arm-symbian-tdep.c: Revert.
2614         * arm-pikeos-tdep.c: Revert.
2615         * arm-obsd-tdep.c: Revert.
2616         * arm-nbsd-tdep.c: Revert.
2617         * arm-nbsd-nat.c: Revert.
2618         * arm-linux-tdep.c: Revert.
2619         * arm-linux-nat.c: Revert.
2620         * arm-fbsd-tdep.c: Revert.
2621         * arm-fbsd-nat.c: Revert.
2622         * arm-bsd-tdep.c: Revert.
2623         * arch-utils.c: Revert.
2624         * arc-tdep.c: Revert.
2625         * arc-newlib-tdep.c: Revert.
2626         * annotate.h: Revert.
2627         * annotate.c: Revert.
2628         * amd64-windows-tdep.c: Revert.
2629         * amd64-windows-nat.c: Revert.
2630         * amd64-tdep.c: Revert.
2631         * amd64-sol2-tdep.c: Revert.
2632         * amd64-obsd-tdep.c: Revert.
2633         * amd64-obsd-nat.c: Revert.
2634         * amd64-nbsd-tdep.c: Revert.
2635         * amd64-nbsd-nat.c: Revert.
2636         * amd64-nat.c: Revert.
2637         * amd64-linux-tdep.c: Revert.
2638         * amd64-linux-nat.c: Revert.
2639         * amd64-fbsd-tdep.c: Revert.
2640         * amd64-fbsd-nat.c: Revert.
2641         * amd64-dicos-tdep.c: Revert.
2642         * amd64-darwin-tdep.c: Revert.
2643         * amd64-bsd-nat.c: Revert.
2644         * alpha-tdep.c: Revert.
2645         * alpha-obsd-tdep.c: Revert.
2646         * alpha-nbsd-tdep.c: Revert.
2647         * alpha-mdebug-tdep.c: Revert.
2648         * alpha-linux-tdep.c: Revert.
2649         * alpha-linux-nat.c: Revert.
2650         * alpha-bsd-tdep.c: Revert.
2651         * alpha-bsd-nat.c: Revert.
2652         * aix-thread.c: Revert.
2653         * agent.c: Revert.
2654         * addrmap.c: Revert.
2655         * ada-varobj.c: Revert.
2656         * ada-valprint.c: Revert.
2657         * ada-typeprint.c: Revert.
2658         * ada-tasks.c: Revert.
2659         * ada-lang.c: Revert.
2660         * aarch64-tdep.c: Revert.
2661         * aarch64-ravenscar-thread.c: Revert.
2662         * aarch64-newlib-tdep.c: Revert.
2663         * aarch64-linux-tdep.c: Revert.
2664         * aarch64-linux-nat.c: Revert.
2665         * aarch64-fbsd-tdep.c: Revert.
2666         * aarch64-fbsd-nat.c: Revert.
2667         * aarch32-linux-nat.c: Revert.
2668
2669 2019-04-05  Tom Tromey  <tom@tromey.com>
2670
2671         * ft32-tdep.c: Sort headers.
2672         * frv-tdep.c: Sort headers.
2673         * frv-linux-tdep.c: Sort headers.
2674         * frame.c: Sort headers.
2675         * frame-unwind.c: Sort headers.
2676         * frame-base.c: Sort headers.
2677         * fork-child.c: Sort headers.
2678         * findvar.c: Sort headers.
2679         * findcmd.c: Sort headers.
2680         * filesystem.c: Sort headers.
2681         * filename-seen-cache.h: Sort headers.
2682         * filename-seen-cache.c: Sort headers.
2683         * fbsd-tdep.c: Sort headers.
2684         * fbsd-nat.h: Sort headers.
2685         * fbsd-nat.c: Sort headers.
2686         * f-valprint.c: Sort headers.
2687         * f-typeprint.c: Sort headers.
2688         * f-lang.c: Sort headers.
2689         * extension.h: Sort headers.
2690         * extension.c: Sort headers.
2691         * extension-priv.h: Sort headers.
2692         * expprint.c: Sort headers.
2693         * exec.h: Sort headers.
2694         * exec.c: Sort headers.
2695         * exceptions.c: Sort headers.
2696         * event-top.c: Sort headers.
2697         * event-loop.c: Sort headers.
2698         * eval.c: Sort headers.
2699         * elfread.c: Sort headers.
2700         * dwarf2read.h: Sort headers.
2701         * dwarf2read.c: Sort headers.
2702         * dwarf2loc.c: Sort headers.
2703         * dwarf2expr.h: Sort headers.
2704         * dwarf2expr.c: Sort headers.
2705         * dwarf2-frame.c: Sort headers.
2706         * dwarf2-frame-tailcall.c: Sort headers.
2707         * dwarf-index-write.h: Sort headers.
2708         * dwarf-index-write.c: Sort headers.
2709         * dwarf-index-common.c: Sort headers.
2710         * dwarf-index-cache.h: Sort headers.
2711         * dwarf-index-cache.c: Sort headers.
2712         * dummy-frame.c: Sort headers.
2713         * dtrace-probe.c: Sort headers.
2714         * disasm.h: Sort headers.
2715         * disasm.c: Sort headers.
2716         * disasm-selftests.c: Sort headers.
2717         * dictionary.c: Sort headers.
2718         * dicos-tdep.c: Sort headers.
2719         * demangle.c: Sort headers.
2720         * dcache.h: Sort headers.
2721         * dcache.c: Sort headers.
2722         * darwin-nat.h: Sort headers.
2723         * darwin-nat.c: Sort headers.
2724         * darwin-nat-info.c: Sort headers.
2725         * d-valprint.c: Sort headers.
2726         * d-namespace.c: Sort headers.
2727         * d-lang.c: Sort headers.
2728         * ctf.c: Sort headers.
2729         * csky-tdep.c: Sort headers.
2730         * csky-linux-tdep.c: Sort headers.
2731         * cris-tdep.c: Sort headers.
2732         * cris-linux-tdep.c: Sort headers.
2733         * cp-valprint.c: Sort headers.
2734         * cp-support.c: Sort headers.
2735         * cp-namespace.c: Sort headers.
2736         * cp-abi.c: Sort headers.
2737         * corelow.c: Sort headers.
2738         * corefile.c: Sort headers.
2739         * continuations.c: Sort headers.
2740         * completer.h: Sort headers.
2741         * completer.c: Sort headers.
2742         * complaints.c: Sort headers.
2743         * coffread.c: Sort headers.
2744         * coff-pe-read.c: Sort headers.
2745         * cli-out.h: Sort headers.
2746         * cli-out.c: Sort headers.
2747         * charset.c: Sort headers.
2748         * c-varobj.c: Sort headers.
2749         * c-valprint.c: Sort headers.
2750         * c-typeprint.c: Sort headers.
2751         * c-lang.c: Sort headers.
2752         * buildsym.c: Sort headers.
2753         * buildsym-legacy.c: Sort headers.
2754         * build-id.h: Sort headers.
2755         * build-id.c: Sort headers.
2756         * btrace.c: Sort headers.
2757         * bsd-uthread.c: Sort headers.
2758         * breakpoint.h: Sort headers.
2759         * breakpoint.c: Sort headers.
2760         * break-catch-throw.c: Sort headers.
2761         * break-catch-syscall.c: Sort headers.
2762         * break-catch-sig.c: Sort headers.
2763         * blockframe.c: Sort headers.
2764         * block.c: Sort headers.
2765         * bfin-tdep.c: Sort headers.
2766         * bfin-linux-tdep.c: Sort headers.
2767         * bfd-target.c: Sort headers.
2768         * bcache.c: Sort headers.
2769         * ax-general.c: Sort headers.
2770         * ax-gdb.h: Sort headers.
2771         * ax-gdb.c: Sort headers.
2772         * avr-tdep.c: Sort headers.
2773         * auxv.c: Sort headers.
2774         * auto-load.c: Sort headers.
2775         * arm-wince-tdep.c: Sort headers.
2776         * arm-tdep.c: Sort headers.
2777         * arm-symbian-tdep.c: Sort headers.
2778         * arm-pikeos-tdep.c: Sort headers.
2779         * arm-obsd-tdep.c: Sort headers.
2780         * arm-nbsd-tdep.c: Sort headers.
2781         * arm-nbsd-nat.c: Sort headers.
2782         * arm-linux-tdep.c: Sort headers.
2783         * arm-linux-nat.c: Sort headers.
2784         * arm-fbsd-tdep.c: Sort headers.
2785         * arm-fbsd-nat.c: Sort headers.
2786         * arm-bsd-tdep.c: Sort headers.
2787         * arch-utils.c: Sort headers.
2788         * arc-tdep.c: Sort headers.
2789         * arc-newlib-tdep.c: Sort headers.
2790         * annotate.h: Sort headers.
2791         * annotate.c: Sort headers.
2792         * amd64-windows-tdep.c: Sort headers.
2793         * amd64-windows-nat.c: Sort headers.
2794         * amd64-tdep.c: Sort headers.
2795         * amd64-sol2-tdep.c: Sort headers.
2796         * amd64-obsd-tdep.c: Sort headers.
2797         * amd64-obsd-nat.c: Sort headers.
2798         * amd64-nbsd-tdep.c: Sort headers.
2799         * amd64-nbsd-nat.c: Sort headers.
2800         * amd64-nat.c: Sort headers.
2801         * amd64-linux-tdep.c: Sort headers.
2802         * amd64-linux-nat.c: Sort headers.
2803         * amd64-fbsd-tdep.c: Sort headers.
2804         * amd64-fbsd-nat.c: Sort headers.
2805         * amd64-dicos-tdep.c: Sort headers.
2806         * amd64-darwin-tdep.c: Sort headers.
2807         * amd64-bsd-nat.c: Sort headers.
2808         * alpha-tdep.c: Sort headers.
2809         * alpha-obsd-tdep.c: Sort headers.
2810         * alpha-nbsd-tdep.c: Sort headers.
2811         * alpha-mdebug-tdep.c: Sort headers.
2812         * alpha-linux-tdep.c: Sort headers.
2813         * alpha-linux-nat.c: Sort headers.
2814         * alpha-bsd-tdep.c: Sort headers.
2815         * alpha-bsd-nat.c: Sort headers.
2816         * aix-thread.c: Sort headers.
2817         * agent.c: Sort headers.
2818         * addrmap.c: Sort headers.
2819         * ada-varobj.c: Sort headers.
2820         * ada-valprint.c: Sort headers.
2821         * ada-typeprint.c: Sort headers.
2822         * ada-tasks.c: Sort headers.
2823         * ada-lang.c: Sort headers.
2824         * aarch64-tdep.c: Sort headers.
2825         * aarch64-ravenscar-thread.c: Sort headers.
2826         * aarch64-newlib-tdep.c: Sort headers.
2827         * aarch64-linux-tdep.c: Sort headers.
2828         * aarch64-linux-nat.c: Sort headers.
2829         * aarch64-fbsd-tdep.c: Sort headers.
2830         * aarch64-fbsd-nat.c: Sort headers.
2831         * aarch32-linux-nat.c: Sort headers.
2832
2833 2019-04-04  Tom Tromey  <tom@tromey.com>
2834
2835         * varobj.c (varobj_create): Update.
2836         * rust-exp.y (struct rust_parser) <update_innermost_block,
2837         lookup_symbol>: New methods.
2838         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2839         Rename.
2840         (rust_parser::rust_lookup_type)
2841         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2842         * printcmd.c (display_command, do_one_display): Update.
2843         * parser-defs.h (struct parser_state) <parser_state>: Add
2844         "tracker" parameter.
2845         (block_tracker): New member.
2846         (class innermost_block_tracker) <innermost_block_tracker>: Add
2847         "types" parameter.
2848         <reset>: Remove method.
2849         (innermost_block): Don't declare.
2850         (null_post_parser): Update.
2851         * parse.c (innermost_block): Remove global.
2852         (write_dollar_variable): Update.
2853         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2854         Remove "tracker_types" parameter.
2855         (parse_expression): Add "tracker" parameter.
2856         (parse_expression_for_completion): Update.
2857         (null_post_parser): Add "tracker" parameter.
2858         * p-exp.y: Update rules.
2859         * m2-exp.y: Update rules.
2860         * language.h (struct language_defn) <la_post_parser>: Add
2861         "tracker" parameter.
2862         * go-exp.y: Update rules.
2863         * f-exp.y: Update rules.
2864         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2865         parameter.
2866         * d-exp.y: Update rules.
2867         * c-exp.y: Update rules.
2868         * breakpoint.c (set_breakpoint_condition): Create an
2869         innermost_block_tracker.
2870         (watch_command_1): Likewise.
2871         * ada-lang.c (resolve): Add "tracker" parameter.
2872         (resolve_subexp): Likewise.
2873         * ada-exp.y (write_var_from_sym): Update.
2874
2875 2019-04-04  Tom Tromey  <tom@tromey.com>
2876
2877         * type-stack.h: New file.
2878         * type-stack.c: New file.
2879         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2880         type-stack.h.
2881         (insert_into_type_stack, insert_type, push_type, push_type_int)
2882         (insert_type_address_space, pop_type, pop_type_int)
2883         (pop_typelist, pop_type_stack, append_type_stack)
2884         (push_type_stack, get_type_stack, push_typelist)
2885         (follow_type_instance_flags, follow_types): Don't declare.
2886         * parse.c (type_stack): Remove global.
2887         (parse_exp_in_context): Update.
2888         (insert_into_type_stack, insert_type, push_type, push_type_int)
2889         (insert_type_address_space, pop_type, pop_type_int)
2890         (pop_typelist, pop_type_stack, append_type_stack)
2891         (push_type_stack, get_type_stack, push_typelist)
2892         (follow_type_instance_flags, follow_types): Remove (moved to
2893         type-stack.c).
2894         * f-exp.y (type_stack): New global.
2895         Update rules.
2896         (push_kind_type, f_parse): Update.
2897         * d-exp.y (type_stack): New global.
2898         Update rules.
2899         (d_parse): Update.
2900         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2901         Update rules.
2902         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2903         (HFILES_NO_SRCDIR): Add type-stack.h.
2904
2905 2019-04-04  Tom Tromey  <tom@tromey.com>
2906
2907         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2908         (rust_parser::convert_ast_to_expression, rust_parse)
2909         (rust_lex_test_completion, rust_lex_tests): Update.
2910         * parser-defs.h (struct expr_completion_state): New.
2911         (struct parser_state) <parser_state>: Add completion parameter.
2912         <mark_struct_expression, mark_completion_tag>: New methods.
2913         <parse_completion, m_completion_state>: New members.
2914         (prefixify_expression, null_post_parser): Update.
2915         (mark_struct_expression, mark_completion_tag): Don't declare.
2916         * parse.c (parse_completion, expout_last_struct)
2917         (expout_tag_completion_type, expout_completion_name): Remove
2918         globals.
2919         (parser_state::mark_struct_expression)
2920         (parser_state::mark_completion_tag): Now methods.
2921         (prefixify_expression): Add last_struct parameter.
2922         (prefixify_subexp): Likewise.
2923         (parse_exp_1): Update.
2924         (parse_exp_in_context): Add cstate parameter.  Update.
2925         (parse_expression_for_completion): Create an
2926         expr_completion_state.
2927         (null_post_parser): Add "completion" parameter.
2928         * p-exp.y: Update rules.
2929         (yylex): Update.
2930         * language.h (struct language_defn) <la_post_parser>: Add
2931         "completing" parameter.
2932         * go-exp.y: Update rules.
2933         (lex_one_token): Update.
2934         * expression.h (parse_completion): Don't declare.
2935         * d-exp.y: Update rules.
2936         (lex_one_token): Update rules.
2937         * c-exp.y: Update rules.
2938         (lex_one_token): Update.
2939         * ada-lang.c (resolve): Add "parse_completion" parameter.
2940         (resolve_subexp): Likewise.
2941         (ada_resolve_function): Likewise.
2942
2943 2019-04-04  Tom Tromey  <tom@tromey.com>
2944
2945         * parser-defs.h (struct parser_state) <start_arglist,
2946         end_arglist>: New methods.
2947         <arglist_len, m_funcall_chain>: New members.
2948         (arglist_len, start_arglist, end_arglist): Don't declare.
2949         * parse.c (arglist_len, funcall_chain): Remove global.
2950         (start_arglist, end_arglist): Remove functions.
2951         (parse_exp_in_context): Update.
2952         * p-exp.y: Update rules.
2953         * m2-exp.y: Update rules.
2954         * go-exp.y: Update rules.
2955         * f-exp.y: Update rules.
2956         * d-exp.y: Update rules.
2957         * c-exp.y: Update rules.
2958
2959 2019-04-04  Tom Tromey  <tom@tromey.com>
2960
2961         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2962         lex_operator, push_back>: New methods.
2963         Update all rules.
2964         (rust_parser::lex_hex, lex_escape): Rename and update.
2965         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2966         (rust_parser::lex_operator): Rename and update.
2967         (rust_parser::lex_number, rustyylex, rustyyerror)
2968         (rust_lex_test_init, rust_lex_test_sequence)
2969         (rust_lex_test_push_back, rust_lex_tests): Update.
2970         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2971         parameter.
2972         <lexptr, prev_lexptr>: New members.
2973         (lexptr, prev_lexptr): Don't declare.
2974         * parse.c (lexptr, prev_lexptr): Remove globals.
2975         (parse_exp_in_context): Update.
2976         * p-exp.y (yylex, yyerror): Update.
2977         * m2-exp.y (parse_number, yylex, yyerror): Update.
2978         * go-exp.y (lex_one_token, yyerror): Update.
2979         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2980         * d-exp.y (lex_one_token, yyerror): Update.
2981         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2982         (lex_one_token, yyerror): Update.
2983         * ada-lex.l (YY_INPUT): Update.
2984         (rewind_to_char): Update.
2985         * ada-exp.y (yyerror): Update.
2986
2987 2019-04-04  Tom Tromey  <tom@tromey.com>
2988
2989         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2990         * parser-defs.h (struct parser_state) <parser_state>: Add new
2991         parameter.
2992         <comma_terminates>: New member.
2993         (comma_terminates): Don't declare global.
2994         * parse.c (comma_terminates): Remove global.
2995         (parse_exp_in_context): Update.
2996         * p-exp.y (yylex): Update.
2997         * m2-exp.y (yylex): Update.
2998         * go-exp.y (lex_one_token): Update.
2999         * f-exp.y (yylex): Update.
3000         * d-exp.y (lex_one_token): Update.
3001         * c-exp.y (lex_one_token): Update.
3002         * ada-lex.l: Update.
3003
3004 2019-04-04  Tom Tromey  <tom@tromey.com>
3005
3006         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3007         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3008         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3009         * parser-defs.h (paren_depth): Don't declare.
3010         * parse.c (paren_depth): Remove global.
3011         (parse_exp_in_context): Update.
3012         * p-exp.y (paren_depth): New global.
3013         (pascal_parse): Initialize it.
3014         * m2-exp.y (paren_depth): New global.
3015         (m2_parse): Initialize it.
3016         * go-exp.y (paren_depth): New global.
3017         (go_parse): Initialize it.
3018         * f-exp.y (paren_depth): New global.
3019         (f_parse): Initialize it.
3020         * d-exp.y (paren_depth): New global.
3021         (d_parse): Initialize it.
3022         * c-exp.y (paren_depth): New global.
3023         (c_parse): Initialize it.
3024         * ada-lex.l (paren_depth): New global.
3025         (lexer_init): Initialize it.
3026
3027 2019-04-04  Tom Tromey  <tom@tromey.com>
3028
3029         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3030         (rust_parser::convert_ast_to_type)
3031         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3032         * parser-defs.h (struct parser_state) <parser_state>: Add
3033         parameters.  Initialize new members.
3034         <expression_context_block, expression_context_pc>: New members.
3035         * parse.c (expression_context_block, expression_context_pc):
3036         Remove globals.
3037         (parse_exp_in_context): Update.
3038         * p-exp.y: Update all rules.
3039         (yylex): Update.
3040         * m2-exp.y: Update all rules.
3041         (yylex): Update.
3042         * go-exp.y (yylex): Update.
3043         * f-exp.y (yylex): Update.
3044         * d-exp.y: Update all rules.
3045         (yylex): Update.
3046         * c-exp.y: Update all rules.
3047         (lex_one_token, classify_name, yylex, c_parse): Update.
3048         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3049
3050 2019-04-04  Tom Tromey  <tom@tromey.com>
3051
3052         * gdbarch.h, gdbarch.c: Rebuild.
3053         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3054         * stap-probe.h:
3055         (struct stap_parse_info): Replace "parser_state" with
3056         "expr_builder".
3057         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3058         (parser_state): New class.
3059         * parse.c (expr_builder): Rename.
3060         (expr_builder::release): Rename.
3061         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3062         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3063         (write_exp_elt_longcst, write_exp_elt_floatcst)
3064         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3065         (write_exp_string_vector, write_exp_bitstring)
3066         (write_exp_msymbol, mark_struct_expression)
3067         (write_dollar_variable)
3068         (insert_type_address_space, increase_expout_size): Replace
3069         "parser_state" with "expr_builder".
3070         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3071         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3072         "parser_state" with "expr_builder".
3073
3074 2019-04-04  Tom Tromey  <tom@tromey.com>
3075
3076         * rust-exp.y: Replace "parse_language" with method call.
3077         * p-exp.y:
3078         (yylex): Replace "parse_language" with method call.
3079         * m2-exp.y:
3080         (yylex): Replace "parse_language" with method call.
3081         * go-exp.y (classify_name): Replace "parse_language" with method
3082         call.
3083         * f-exp.y (yylex): Replace "parse_language" with method call.
3084         * d-exp.y (lex_one_token): Replace "parse_language" with method
3085         call.
3086         * c-exp.y:
3087         (lex_one_token, classify_name, yylex): Replace "parse_language"
3088         with method call.
3089         * ada-exp.y (find_primitive_type, type_char)
3090         (type_system_address): Replace "parse_language" with method call.
3091
3092 2019-04-04  Tom Tromey  <tom@tromey.com>
3093
3094         * rust-exp.y: Replace "parse_gdbarch" with method call.
3095         * parse.c (write_dollar_variable, insert_type_address_space):
3096         Replace "parse_gdbarch" with method call.
3097         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3098         call.
3099         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3100         call.
3101         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3102         "parse_gdbarch" with method call.
3103         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3104         with method call.
3105         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3106         "parse_gdbarch" with method call.
3107         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3108         "parse_gdbarch" with method call.
3109         * c-exp.y (parse_type, parse_number, classify_name): Replace
3110         "parse_gdbarch" with method call.
3111         * ada-lex.l: Replace "parse_gdbarch" with method call.
3112         * ada-exp.y (parse_type, find_primitive_type, type_char)
3113         (type_system_address): Replace "parse_gdbarch" with method call.
3114
3115 2019-04-04  Tom Tromey  <tom@tromey.com>
3116
3117         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3118         * stap-probe.c (stap_parse_argument): Update.
3119         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3120         initial_size parameter.
3121         * rust-exp.y (rust_lex_tests): Update.
3122         * parse.c (parser_state): Update.
3123         (parse_exp_in_context): Update.
3124         * parser-defs.h (struct parser_state) <parser_state>: Remove
3125         "initial_size" parameter.
3126
3127 2019-04-04  Tom Tromey  <tom@tromey.com>
3128
3129         * parser-defs.h (increase_expout_size): Don't declare.
3130         * parse.c (increase_expout_size): Now static.
3131
3132 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3133
3134         * gnu-nat.c (gnu_nat_target::wait): Fix
3135         target_waitstatus_to_string call.
3136
3137 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * eval.c (evaluate_subexp_standard): Handle internal functions
3140         during Fortran function call handling.
3141
3142 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * NEWS: Mention new internal functions.
3145         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3146         (read_base_type): Use dwarf2_init_complex_target_type.
3147         * value.c (creal_internal_fn): New function.
3148         (cimag_internal_fn): New function.
3149         (_initialize_values): Register new internal functions.
3150
3151 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3152
3153         * infrun.c (stop_all_threads): If debug_infrun, always
3154         trace the wait status after wait_one, using
3155         target_waitstatus_to_string and target_pid_to_str.
3156         (handle_inferior_event): Replace various trace of
3157         wait status kind by a single trace.
3158         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3159         wait status kind image by target_waitstatus_to_string.
3160         * target/waitstatus.c (target_waitstatus_to_string): Fix
3161         obsolete comment.
3162
3163 2019-04-01  Tom Tromey  <tromey@adacore.com>
3164
3165         PR symtab/23331:
3166         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3167
3168 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3169             Pedro Alves  <palves@redhat.com>
3170
3171         * top.c (quit_force): Call 'finalize_values'.
3172         * value.c (finalize_values): New function.
3173         * value.h (finalize_values): Declare.
3174
3175 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3176
3177         * NEWS: Announce $_gdb_major and $_gdb_minor.
3178
3179         * top.c (init_gdb_version_vars): New function.
3180         (gdb_init): Call init_gdb_version_vars.
3181
3182 2019-03-29  Tom Tromey  <tromey@adacore.com>
3183
3184         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3185         help text.  Remove dead code.
3186
3187 2019-03-29  Keith Seitz  <keiths@redhat.com>
3188
3189         From Siddhesh Poyarekar:
3190         * f-lang.h (f77_get_upperbound): Return LONGEST.
3191         (f77_get_lowerbound): Likewise.
3192         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3193         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3194         print them.
3195         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3196         plongest to format print it.
3197         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3198         (f77_get_upperbound): Likewise.
3199         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3200         LOWER_BOUND to LONGEST.
3201         (f77_create_arrayprint_offset_tbl): Likewise.
3202
3203 2019-03-29  Keith Seitz  <keiths@redhat.com>
3204
3205         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3206         %s/pulongest for TYPE_LENGTH instead of %d in format
3207         strings.
3208         * ada-typerint.c (ada_print_type): Likewise.
3209         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3210         * compile/compile-c-support.c (generate_register_struct): Likewise.
3211         * gdbtypes.c (recursive_dump_type): Likewise.
3212         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3213         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3214         instead of %d in format strings.
3215         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3216         to std::min to ULONGEST.
3217         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3218         instead of %d in format strings.
3219         * tracepoint.c (info_scope_command): Likewise.
3220         * typeprint.c (print_offset_data::update)
3221         (print_offset_data::finish): Likewise.
3222         * xtensa-tdep.c (xtensa_store_return_value)
3223         (xtensa_push_dummy_call): Likewise.
3224
3225 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3226
3227         * windows-nat.c (display_selector): Fixed format specifications
3228         for 64-bit Cygwin.
3229
3230 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3231
3232         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3233
3234 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3235
3236         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3237         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3238         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3239         (nios2_linux_init_abi): Install it.
3240
3241 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3242
3243         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3244
3245 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3246
3247         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3248
3249 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3250             Tom Tromey  <tromey@adacore.com>
3251
3252         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3253
3254 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3255
3256         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3257         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3258         method to compute the bounds of range types. Also print "[evaluated]"
3259         if the bounds' values come from a dynamic evaluation.
3260
3261 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3264         whitespace when pretty printing is on.
3265
3266 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3267
3268         * ppc-linux-nat.c: Add include.
3269
3270 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3271
3272         * NEWS: Mention AArch64 Pointer Authentication.
3273
3274 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3275
3276         * arm-linux-nat.c: Add include.
3277
3278 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3279
3280         * source-cache.c (source_cache::get_source_lines): Re-read
3281         fullname after calling open_source_file.
3282
3283 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3284
3285         * NEWS: Mention TLS support for FreeBSD.
3286
3287 2019-03-25  Tom Tromey  <tromey@adacore.com>
3288
3289         * minsyms.c (BUNCH_SIZE): Update comment.
3290         (~minimal_symbol_reader): Remove old comment.
3291         (compact_minimal_symbols): Update comment.
3292         (minimal_symbol_reader::install): Remove old comment.  Update
3293         other comments.
3294
3295 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3296
3297         * s390-linux-nat.c: Add include.
3298
3299 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3300
3301         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3302         Call linux_get_hwcap.
3303         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3304         Likewise.
3305         (aarch64_linux_get_hwcap): Remove function.
3306         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3307         declaration.
3308         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3309         linux_get_hwcap.
3310         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3311         * linux-tdep.c (linux_get_hwcap): Add function.
3312         (linux_get_hwcap2): Likewise.
3313         * linux-tdep.h (linux_get_hwcap): Add declaration.
3314         (linux_get_hwcap2): Likewise.
3315         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3316         (ppc_linux_get_hwcap2): Likewise.
3317         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3318         linux_get_hwcap.
3319         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3320         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3321         (ppc_linux_nat_target::read_description): Likewise.
3322         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3323         * s390-linux-nat.c: Likewise.
3324         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3325
3326 2019-03-24  Tom Tromey  <tom@tromey.com>
3327
3328         * ada-lang.c (standard_lookup): Simplify initialization.
3329         (ada_lookup_symbol_nonlocal): Simplify return.
3330         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3331         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3332         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3333         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3334         initialization.
3335         * solib.c (solib_global_lookup): Simplify.
3336         * symtab.c (null_block_symbol): Remove.
3337         (symbol_cache_lookup): Simplify returns.
3338         (lookup_language_this): Simplify returns.
3339         (lookup_symbol_aux): Simplify return.
3340         (lookup_local_symbol): Simplify returns.
3341         (lookup_global_symbol_from_objfile): Simplify return.
3342         (lookup_symbol_in_objfile_symtabs)
3343         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3344         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3345         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3346         * cp-namespace.c (cp_lookup_bare_symbol)
3347         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3348         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3349         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3350         (cp_lookup_symbol_via_imports): Simplify initialization.
3351         (find_symbol_in_baseclass): Likewise.
3352         * symtab.h (null_block_symbol): Remove.
3353         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3354         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3355         (d_lookup_symbol_module): Likewise.
3356         (find_symbol_in_baseclass): Simplify initialization.
3357
3358 2019-03-24  Tom Tromey  <tom@tromey.com>
3359
3360         * expression.h: Don't include symtab.h.
3361         (struct block): Forward declare.
3362
3363 2019-03-24  Tom Tromey  <tom@tromey.com>
3364
3365         * c-exp.y (typebase): Remove casts.
3366         * gdbtypes.c (lookup_unsigned_typename, )
3367         (lookup_signed_typename): Remove cast.
3368         * eval.c (parse_to_comma_and_eval): Remove cast.
3369         * parse.c (write_dollar_variable): Remove cast.
3370         * block.h (struct block) <superblock>: Now const.
3371         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3372         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3373         (map_block): Make "block" const.
3374         * symfile.h (struct quick_symbol_functions)
3375         <map_matching_symbols>: Constify block argument to "callback".
3376         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3377         const.
3378         (find_pc_sect_compunit_symtab): Make "b" const.
3379         (find_symbol_at_address): Likewise.
3380         (search_symbols): Likewise.
3381         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3382         (dw2_debug_names_lookup_symbol): Likewise.
3383         (dw2_map_matching_symbols): Update.
3384         * p-valprint.c (pascal_val_print): Remove "block".
3385         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3386         (aux_add_nonlocal_symbols): Make "block" const.
3387         (resolve_subexp): Remove cast.
3388         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3389         const.
3390         (iterate_over_file_blocks): Likewise.
3391         * f-exp.y (%union) <bval>: Remove.
3392         * coffread.c (patch_opaque_types): Make "b" const.
3393         * spu-tdep.c (spu_catch_start): Make "block" const.
3394         * c-valprint.c (print_unpacked_pointer): Remove "block".
3395         * symmisc.c (dump_symtab_1): Make "b" const.
3396         (block_depth): Make "block" const.
3397         * d-exp.y (%union) <bval>: Remove.
3398         * cp-support.h (cp_lookup_rtti_type): Update.
3399         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3400         * psymtab.c (psym_lookup_symbol): Make "block" const.
3401         (maintenance_check_psymtabs): Make "b" const.
3402         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3403         (enumerate_locals, enumerate_args): Update.
3404         * python/py-symtab.c (stpy_global_block): Make "block" const.
3405         (stpy_static_block): Likewise.
3406         * inline-frame.c (block_starting_point_at): Make "new_block"
3407         const.
3408         * block.c (find_block_in_blockvector): Make return type const.
3409         (blockvector_for_pc_sect): Make "b" const.
3410         (find_block_in_blockvector): Make "b" const.
3411
3412 2019-03-23  Tom Tromey  <tom@tromey.com>
3413
3414         * varobj.c (varobj_create): Update.
3415         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3416         * printcmd.c (display_command, do_one_display): Don't reset
3417         innermost_block.
3418         * parser-defs.h (enum innermost_block_tracker_type): Move to
3419         expression.h.
3420         (innermost_block): Update comment.
3421         * parse.c (parse_exp_1): Add tracker_types parameter.
3422         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3423         tracker_types parameter.  Reset innermost_block.
3424         (parse_exp_in_context): Remove.
3425         (parse_expression_for_completion): Update.
3426         * objfiles.c (~objfile): Don't reset expression_context_block or
3427         innermost_block.
3428         * expression.h (enum innermost_block_tracker_type): Move from
3429         parser-defs.h.
3430         (parse_exp_1): Add tracker_types parameter.
3431         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3432         reset innermost_block.
3433
3434 2019-03-23  Tom Tromey  <tom@tromey.com>
3435
3436         * objfiles.h: Include bcache.h.
3437
3438 2019-03-23  Tom Tromey  <tom@tromey.com>
3439
3440         * linespec.c (get_current_search_block): Use
3441         scoped_restore_current_language.
3442         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3443
3444 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3445             Jiong Wang  <jiong.wang@arm.com>
3446
3447         * aarch64-linux-tdep.c
3448         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3449         section.
3450         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3451
3452 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3453             Jiong Wang  <jiong.wang@arm.com>
3454
3455         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3456         instructions.
3457         (aarch64_analyze_prologue_test): Add PACIASP test.
3458         (aarch64_prologue_prev_register): Unmask PC value.
3459
3460 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3461             Jiong Wang  <jiong.wang@arm.com>
3462
3463         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3464         (aarch64_dwarf2_prev_register): Unmask PC value.
3465         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3466         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3467         DW_CFA_AARCH64_negate_ra_state.
3468         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3469
3470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3471             Jiong Wang  <jiong.wang@arm.com>
3472
3473         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3474         registers.
3475         (aarch64_pseudo_register_name): Likewise.
3476         (aarch64_pseudo_register_type): Likewise.
3477         (aarch64_pseudo_register_reggroup_p): Likewise.
3478         (aarch64_gdbarch_init): Add pauth registers.
3479         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3480         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3481         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3482         (struct gdbarch_tdep): Add regnum for ra_state.
3483
3484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3485             Jiong Wang  <jiong.wang@arm.com>
3486
3487         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3488
3489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3490             Jiong Wang  <jiong.wang@arm.com>
3491
3492         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3493         function.
3494         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3495         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3496         (aarch64_gdbarch_init): Add puth registers.
3497         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3498         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3499         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3500
3501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3502             Jiong Wang  <jiong.wang@arm.com>
3503
3504         * aarch64-linux-nat.c
3505         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3506         * aarch64-linux-tdep.c
3507         (aarch64_linux_core_read_description): Likewise.
3508         (aarch64_linux_get_hwcap): New function.
3509         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3510         (aarch64_linux_get_hwcap): New declaration.
3511
3512 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3513             Jiong Wang  <jiong.wang@arm.com>
3514
3515         * aarch64-linux-nat.c
3516         (aarch64_linux_nat_target::read_description): Add pauth param.
3517         * aarch64-linux-tdep.c
3518         (aarch64_linux_core_read_description): Likewise.
3519         * aarch64-tdep.c (struct target_desc): Add in pauth.
3520         (aarch64_read_description): Add pauth param.
3521         (aarch64_gdbarch_init): Likewise.
3522         * aarch64-tdep.h (aarch64_read_description): Likewise.
3523         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3524         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3525         * features/Makefile: Add new files.
3526         * features/aarch64-pauth.c: New file.
3527         * features/aarch64-pauth.xml: New file.
3528
3529 2019-03-20  Tom Tromey  <tromey@adacore.com>
3530
3531         * infrun.c (handle_inferior_event): Rename from
3532         handle_inferior_event_1.  Create a scoped_value_mark.
3533         (handle_inferior_event): Remove.
3534
3535 2019-03-19  Tom Tromey  <tromey@adacore.com>
3536
3537         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3538         * infrun.h (print_stop_event): Add "displays" parameter.
3539         * infrun.c (print_stop_event): Add "displays" parameter.
3540
3541 2019-03-19  Pedro Alves  <palves@redhat.com>
3542
3543         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3544         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3545         to -1.  Fix TABs vs spaces.
3546         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3547         * tui/tui-out.h (tui_ui_out) Add intro comments.
3548         <m_line, m_start_of_line>: In-class initialize, and add describing
3549         comment.
3550
3551 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3552
3553         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3554         variable names.
3555         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3556
3557 2019-03-18  Pedro Alves  <palves@redhat.com>
3558             Eli Zaretskii <eliz@gnu.org>
3559
3560         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3561         m_line and m_start_of_line.
3562
3563 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3564
3565         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3566         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3567         it returns a newline.  This fixes a regression in TU mode, whereby
3568         the next line is output on the same screen line as the user input.
3569
3570 2019-03-18  Tom Tromey  <tromey@adacore.com>
3571
3572         * minsyms.c (minimal_symbol_reader::install): Remove call to
3573         obstack_blank.
3574
3575 2019-03-18  Pedro Alves  <palves@redhat.com>
3576
3577         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3578         New globals.
3579         (apply_style): New, factored out from ...
3580         (apply_ansi_escape): ... this.  Handle reverse video mode.
3581         (tui_set_reverse_mode): New function.
3582         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3583         * tui/tui-winsource.c (tui_show_source_line): Use
3584         tui_set_reverse_mode instead of setting A_STANDOUT.
3585         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3586         New setter methods.
3587
3588 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3589
3590         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3591         Handle tabs.
3592
3593 2019-03-18  Tom Tromey  <tromey@adacore.com>
3594
3595         * ada-lang.c (empty_array): Add "high" parameter.
3596         (ada_evaluate_subexp): Update.
3597
3598 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3599
3600         * unittests/string_view-selftests.c: Define
3601         _initialize_string_view_selftests unconditionally.
3602
3603 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3604
3605         PR gdb/24350
3606         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3607
3608 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3609
3610         PR gdb/24351
3611         * windows-nat.c (display_selector): Fix format specifiers.
3612
3613 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3614
3615         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3616         tui_refill_source_window instead of tui_refresh_win, to update the
3617         current execution line.  This fixes redisplay of the current line
3618         when stepping through the code with "next" or "step".
3619
3620 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3621
3622         * source-cache.c (source_cache::get_source_lines): Call
3623         find_source_lines to initialize s->nlines.  This fixes vertical
3624         scrolling of TUI source window when the DOWN arrow is pressed.
3625
3626 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3627
3628         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3629         linux-thread-db.c (_initialize_thread_db): Likewise.
3630
3631 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3632
3633         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3634         wclrtoeol in tui_show_source_line".  This reverts changes made in
3635         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3636
3637 2019-03-15  Tom Tromey  <tom@tromey.com>
3638
3639         * symtab.h (struct minimal_symbol): Derive from
3640         general_symbol_info.
3641         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3642         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3643         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3644         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3645         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3646         (MSYMBOL_SEARCH_NAME): Update.
3647         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3648         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3649         * minsyms.c (minimal_symbol_reader::record_full): Update.
3650
3651 2019-03-15  Tom Tromey  <tom@tromey.com>
3652
3653         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3654
3655 2019-03-15  Tom Tromey  <tom@tromey.com>
3656
3657         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3658         unique_xmalloc_ptr.
3659         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3660         Update.
3661         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3662         (build_minimal_symbol_hash_tables)
3663         (minimal_symbol_reader::install): Update.
3664
3665 2019-03-15  Tom Tromey  <tom@tromey.com>
3666
3667         * symtab.c (create_demangled_names_hash): Update.
3668         (symbol_set_names): Update.
3669         * objfiles.h (struct objfile_per_bfd_storage)
3670         <demangled_names_hash>: Now an htab_up.
3671         * objfiles.c (objfile_per_bfd_storage): Simplify.
3672
3673 2019-03-15  Tom Tromey  <tom@tromey.com>
3674
3675         * objfiles.h (struct objfile_per_bfd_storage): Declare
3676         destructor.
3677         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3678         New.
3679         (get_objfile_bfd_data): Use new.  Don't initialize
3680         language_of_main.
3681         (free_objfile_per_bfd_storage): Remove.
3682         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3683
3684 2019-03-15  Tom Tromey  <tom@tromey.com>
3685
3686         * symfile.c (reread_symbols): Update.
3687         * objfiles.c (objfile::objfile): Update.
3688         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3689         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3690         comment.
3691         (minimal_symbol_reader::install): Update.
3692         (terminate_minimal_symbol_table): Remove.
3693         * jit.c (jit_object_close_impl): Update.
3694
3695 2019-03-15  Tom Tromey  <tom@tromey.com>
3696
3697         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3698         initializations.
3699
3700 2019-03-15  Tom Tromey  <tom@tromey.com>
3701
3702         * objfiles.h (struct objfile_per_bfd_storage)
3703         <demangled_hash_languages>: Now a bitset.
3704         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3705         (lookup_minimal_symbol): Update.
3706
3707 2019-03-15  Tom Tromey  <tom@tromey.com>
3708
3709         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3710         Don't return the symbol.
3711         * coffread.c (record_minimal_symbol): Use record_full.
3712
3713 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3714
3715         The MS-Windows port of ncurses fails to switch to a color pair if
3716         one or both of the colors are the implicit default colors.  This
3717         change records the default colors when TUI is initialized, and
3718         then specifies them explicitly when a color pair uses the default
3719         colors.  This allows color styling in TUI mode on MS-Windows.
3720
3721         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3722         ncurses_norm_attr.
3723         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3724         colors in ncurses_norm_attr.
3725         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3726         "none", replace it with the default color recorded in
3727         ncurses_norm_attr.
3728
3729 2019-03-14  Tom Tromey  <tromey@adacore.com>
3730
3731         * source-cache.h (class source_cache) <get_source_lines>: Return
3732         std::string.
3733         * source-cache.c (source_cache::extract_lines): Handle case where
3734         first_pos==npos.  Return std::string.
3735         (source_cache::get_source_lines): Update.
3736
3737 2019-03-14  Tom Tromey  <tromey@adacore.com>
3738
3739         * NEWS: Add item for "style sources" commands.
3740         * source-cache.c (source_cache::get_source_lines): Check
3741         source_styling.
3742         * cli/cli-style.c (source_styling): New global.
3743         (_initialize_cli_style): Add "style sources" commands.
3744         (show_style_sources): New function.
3745         * cli/cli-style.h (source_styling): Declare.
3746
3747 2019-03-14  Pedro Alves  <palves@redhat.com>
3748             Tom Tromey  <tromey@adacore.com>
3749
3750         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3751         * tui/tui-winsource.c (tui_refill_source_window): New function,
3752         from...
3753         (tui_horizontal_source_scroll): ... here.  Move some logic.
3754         * cli/cli-style.c (set_style_enabled): Notify new observable.
3755         * tui/tui-hooks.c (tui_redisplay_source): New function.
3756         (tui_attach_detach_observers): Attach or detach
3757         tui_redisplay_source.
3758         * observable.h (source_styling_changed): New observable.
3759         * observable.c: Define source_styling_changed observable.
3760
3761 2019-03-13  Tom Tromey  <tromey@adacore.com>
3762
3763         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3764         (i386_gnu_nat_target::store_registers): Update.
3765         * target-debug.h (target_debug_print_std_string): New macro.
3766         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3767         * windows-tdep.c (display_one_tib): Update.
3768         * tui/tui-stack.c (tui_make_status_line): Update.
3769         * top.c (print_inferior_quit_action): Update.
3770         * thread.c (thr_try_catch_cmd): Update.
3771         (add_thread_with_info): Update.
3772         (thread_target_id_str): Update.
3773         (thr_try_catch_cmd): Update.
3774         (thread_command): Update.
3775         (thread_find_command): Update.
3776         * record-btrace.c (record_btrace_target::info_record)
3777         (record_btrace_resume_thread, record_btrace_target::resume)
3778         (record_btrace_cancel_resume, record_btrace_step_thread)
3779         (record_btrace_target::wait, record_btrace_target::wait)
3780         (record_btrace_target::wait, record_btrace_target::stop): Update.
3781         * progspace.c (print_program_space): Update.
3782         * process-stratum-target.c
3783         (process_stratum_target::thread_address_space): Update.
3784         * linux-fork.c (linux_fork_mourn_inferior)
3785         (detach_checkpoint_command, info_checkpoints_command)
3786         (linux_fork_context): Update.
3787         (linux_fork_detach): Update.
3788         (class scoped_switch_fork_info): Update.
3789         (delete_checkpoint_command): Update.
3790         * infrun.c (follow_fork_inferior): Update.
3791         (follow_fork_inferior): Update.
3792         (proceed_after_vfork_done): Update.
3793         (handle_vfork_child_exec_or_exit): Update.
3794         (follow_exec): Update.
3795         (displaced_step_prepare_throw): Update.
3796         (displaced_step_restore): Update.
3797         (start_step_over): Update.
3798         (resume_1): Update.
3799         (clear_proceed_status_thread): Update.
3800         (proceed): Update.
3801         (print_target_wait_results): Update.
3802         (do_target_wait): Update.
3803         (context_switch): Update.
3804         (stop_all_threads): Update.
3805         (restart_threads): Update.
3806         (finish_step_over): Update.
3807         (handle_signal_stop): Update.
3808         (switch_back_to_stepped_thread): Update.
3809         (keep_going_pass_signal): Update.
3810         (print_exited_reason): Update.
3811         (normal_stop): Update.
3812         * inferior.c (inferior_pid_to_str): Change return type.
3813         (print_selected_inferior): Update.
3814         (add_inferior): Update.
3815         (detach_inferior): Update.
3816         * dummy-frame.c (fprint_dummy_frames): Update.
3817         * dcache.c (dcache_info_1): Update.
3818         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3819         (btrace_fetch, btrace_clear): Update.
3820         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3821         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3822         type.
3823         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3824         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3825         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3826         * gdbarch.c, gdbarch.h: Rebuild.
3827         * gdbarch.sh (core_pid_to_str): Change return type.
3828         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3829         return type.
3830         (windows_nat_target::pid_to_str): Change return type.
3831         (windows_delete_thread): Update.
3832         (windows_nat_target::attach): Update.
3833         (windows_nat_target::files_info): Update.
3834         * target-delegates.c: Rebuild.
3835         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3836         return type.
3837         (sol_thread_target::pid_to_str): Change return type.
3838         * remote.c (class remote_target) <pid_to_str>: Change return
3839         type.
3840         (remote_target::pid_to_str): Change return type.
3841         (extended_remote_target::attach, remote_target::remote_stop_ns)
3842         (remote_target::remote_notif_remove_queued_reply)
3843         (remote_target::push_stop_reply, remote_target::disable_btrace):
3844         Update.
3845         (extended_remote_target::attach): Update.
3846         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3847         type.
3848         (gdbsim_target::pid_to_str): Change return type.
3849         * ravenscar-thread.c (struct ravenscar_thread_target)
3850         <pid_to_str>: Change return type.
3851         (ravenscar_thread_target::pid_to_str): Change return type.
3852         * procfs.c (class procfs_target) <pid_to_str>: Change return
3853         type.
3854         (procfs_target::pid_to_str): Change return type.
3855         (procfs_target::attach): Update.
3856         (procfs_target::detach): Update.
3857         (procfs_target::fetch_registers): Update.
3858         (procfs_target::store_registers): Update.
3859         (procfs_target::wait): Update.
3860         (procfs_target::files_info): Update.
3861         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3862         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3863         return type.
3864         (nto_procfs_target::pid_to_str): Change return type.
3865         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3866         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3867         return type.
3868         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3869         (exit_lwp): Update.
3870         (attach_proc_task_lwp_callback, get_detach_signal)
3871         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3872         (linux_nat_target::resume, wait_lwp, stop_callback)
3873         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3874         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3875         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3876         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3877         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3878         type.
3879         (inf_ptrace_target::attach): Update.
3880         (inf_ptrace_target::files_info): Update.
3881         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3882         type.
3883         (go32_nat_target::pid_to_str): Change return type.
3884         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3885         (gnu_nat_target::wait): Update.
3886         (gnu_nat_target::wait): Update.
3887         (gnu_nat_target::resume): Update.
3888         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3889         (fbsd_nat_target::wait): Update.
3890         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3891         type.
3892         (darwin_nat_target::attach): Update.
3893         * corelow.c (class core_target) <pid_to_str>: Change return type.
3894         (core_target::pid_to_str): Change return type.
3895         * target.c (normal_pid_to_str): Change return type.
3896         (default_pid_to_str): Likewise.
3897         (target_pid_to_str): Change return type.
3898         (target_translate_tls_address): Update.
3899         (target_announce_detach): Update.
3900         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3901         return type.
3902         (bsd_uthread_target::pid_to_str): Change return type.
3903         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3904         type.
3905         (bsd_kvm_target::pid_to_str): Change return type.
3906         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3907         return type.
3908         (aix_thread_target::pid_to_str): Change return type.
3909         * target.h (struct target_ops) <pid_to_str>: Change return type.
3910         (target_pid_to_str, normal_pid_to_str): Likewise.
3911         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3912         type.
3913         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3914         type.
3915         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3916         return type.
3917         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3918         type.
3919         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3920         type.
3921         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3922         return type.
3923
3924 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3925
3926         * NEWS: Mention that the new default MI version is 3.  Mention
3927         changes to the output of commands and events that deal with
3928         multi-location breakpoints.
3929         * breakpoint.c: Include "mi/mi-out.h".
3930         (print_one_breakpoint): Change output syntax if using MI version
3931         >= 3.
3932         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3933         New.
3934         (mi_multi_location_breakpoint_output_fixed): New.
3935         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3936         (mi_cmd_fix_multi_location_breakpoint_output): New.
3937         (mi_multi_location_breakpoint_output_fixed): New.
3938         * mi/mi-cmds.c (mi_cmds): Register command
3939         -fix-multi-location-breakpoint-output.
3940         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3941         interpreter "mi".
3942
3943 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3944
3945         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3946         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3947         instantiate mi_ui_out based on interpreter name.
3948         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3949         * mi/mi-main.c (mi_load_progress): Likewise.
3950
3951 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3952
3953         * NEWS: Combine separate "New targets" sections for 8.3.
3954
3955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3956
3957         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3958         (ppcfbsd_init_abi): Install gdbarch
3959         "fetch_tls_load_module_address" and "get_thread_local_address"
3960         methods.
3961
3962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3963
3964         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3965         (riscv_fbsd_init_abi): Install gdbarch
3966         "fetch_tls_load_module_address" and "get_thread_local_address"
3967         methods.
3968
3969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3970
3971         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3972         (i386fbsd_init_abi): Install gdbarch
3973         "fetch_tls_load_module_address" and "get_thread_local_address"
3974         methods.
3975
3976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3977
3978         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3979         (amd64fbsd_init_abi): Install gdbarch
3980         "fetch_tls_load_module_address" and "get_thread_local_address"
3981         methods.
3982
3983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3984
3985         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3986         (struct fbsd_pspace_data): New type.
3987         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3988         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3989         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3990         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3991         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3992
3993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3994
3995         * gdbtypes.c (lookup_struct_elt): New function.
3996         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3997         * gdbtypes.h (struct struct_elt): New type.
3998         (lookup_struct_elt): New prototype.
3999
4000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4001
4002         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4003         remove disabled code block.
4004
4005 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4006
4007         * gdbarch.sh (get_thread_local_address): New method.
4008         * gdbarch.h, gdbarch.c: Regenerate.
4009         * target.c (target_translate_tls_address): Use
4010         gdbarch_get_thread_local_address if present instead of
4011         target::get_thread_local_address.
4012
4013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4014
4015         * target.h (target::get_thread_local_address): Update comment.
4016
4017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4018
4019         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4020         objfile->separate_debug_objfile_backlink if not NULL.
4021
4022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4023
4024         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4025         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4026         (amd64bsd_store_inferior_registers): Likewise.
4027         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4028         Enable segment base registers.
4029         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4030         PT_GETFSBASE and PT_GETGSBASE.
4031         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4032         PT_SETGSBASE.
4033         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4034         segment base registers.
4035         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4036
4037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4038
4039         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4040         Update calls to i386_target_description to add 'segments'
4041         parameter.
4042         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4043         add segment base registers.
4044         * arch/i386.c (i386_create_target_description): Add 'segments'
4045         parameter to enable segment base registers.
4046         * arch/i386.h (i386_create_target_description): Likewise.
4047         * features/i386/32bit-segments.xml: New file.
4048         * features/i386/32bit-segments.c: Generate.
4049         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4050         call to i386_target_description to add 'segments' parameter.
4051         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4052         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4053         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4054         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4055         if feature is present.
4056         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4057         Add 'segments' parameter to call to i386_target_description.
4058         (i386_target_description): Add 'segments' parameter to enable
4059         segment base registers.
4060         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4061         to call to i386_target_description.
4062         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4063         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4064         Define I386_NUM_REGS.
4065         (i386_target_description): Add 'segments' parameter to enable
4066         segment base registers.
4067
4068 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4069
4070         PR/24325
4071         * source-cache.c: #undef open and close, to avoid unresolved
4072         externals during linking.
4073
4074 2019-03-12  Tom Tromey  <tromey@adacore.com>
4075
4076         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4077         const.  Add initializers.
4078         (_initialize_remote): Don't initialize ptid globals.
4079
4080 2019-03-12  Pedro Alves  <palves@redhat.com>
4081
4082         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4083
4084 2019-03-12  Pedro Alves  <palves@redhat.com>
4085
4086         * cp-name-parser.y (main): Remove unused 'len' variable.
4087
4088 2019-03-12  Tom Tromey  <tromey@adacore.com>
4089
4090         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4091         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4092
4093 2019-03-12  Tom Tromey  <tromey@adacore.com>
4094
4095         * linux-nat.c (iterate_over_lwps): Update.
4096         (stop_callback): Remove parameter.
4097         (stop_wait_callback, detach_callback, resume_set_callback)
4098         (select_singlestep_lwp_callback, set_ignore_sigint)
4099         (status_callback, resumed_callback, resume_clear_callback)
4100         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4101         data parameter.
4102         (linux_nat_target::detach, linux_nat_target::resume)
4103         (linux_stop_and_wait_all_lwps, select_event_lwp)
4104         (linux_nat_filter_event, linux_nat_wait_1)
4105         (linux_nat_target::kill, linux_nat_target::stop)
4106         (linux_nat_target::stop): Update.
4107         (linux_nat_resume_callback): Change type.
4108         (resume_stopped_resumed_lwps, count_events_callback)
4109         (select_event_lwp_callback): Likewise.
4110         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4111         * arm-linux-nat.c (struct update_registers_data): Remove.
4112         (update_registers_callback): Change type.
4113         (arm_linux_insert_hw_breakpoint1): Update.
4114         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4115         parameter.
4116         (x86_linux_dr_set_addr): Update.
4117         (x86_linux_dr_set_control): Update.
4118         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4119         (iterate_over_lwps): Use gdb::function_view.
4120         * nat/aarch64-linux-hw-point.c (struct
4121         aarch64_dr_update_callback_param): Remove.
4122         (debug_reg_change_callback): Change type.
4123         (aarch64_notify_debug_reg_change): Update.
4124         * s390-linux-nat.c (s390_refresh_per_info): Update.
4125
4126 2019-03-11  Tom Tromey  <tromey@adacore.com>
4127
4128         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4129         redundant assignment to "this_cu".
4130
4131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4132
4133         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4134
4135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4136
4137         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4138         from...
4139         (rank_one_type): ... this.
4140
4141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4142
4143         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4144         from...
4145         (rank_one_type): ... this.
4146
4147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4148
4149         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4150         from...
4151         (rank_one_type): ... this.
4152
4153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4154
4155         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4156         from...
4157         (rank_one_type): ... this.
4158
4159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4160
4161         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4162         from...
4163         (rank_one_type): ... this.
4164
4165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4166
4167         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4168         from...
4169         (rank_one_type): ... this.
4170
4171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4172
4173         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4174         from...
4175         (rank_one_type): ... this.
4176
4177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4178
4179         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4180         from...
4181         (rank_one_type): ... this.
4182
4183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4184
4185         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4186         from...
4187         (rank_one_type): ... this.
4188
4189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4190
4191         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4192         from...
4193         (rank_one_type): ... this.
4194
4195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4196
4197         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4198         from...
4199         (rank_one_type): ... this.
4200
4201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4202
4203         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4204         from...
4205         (rank_one_type): ... this.
4206
4207 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4208
4209         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4210         inferior-events' shows the example events.
4211
4212 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4213
4214         Support styling on native MS-Windows console
4215
4216         PR/24315
4217         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4218         on MS-Windows if $TERM is not defined.
4219
4220         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4221
4222         * posix-hdep.c (gdb_console_fputs):
4223         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4224         functions.
4225         * ui-file.h (gdb_console_fputs): Add prototype.
4226
4227         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4228         back to fputs only if the former returns zero.
4229
4230 2019-03-07  Tom Tromey  <tom@tromey.com>
4231
4232         * symmisc.c (print_symbol_bcache_statistics): Update.
4233         (print_objfile_statistics): Update.
4234         * symfile.c (allocate_symtab): Update.
4235         * stabsread.c: Don't include bcache.h.
4236         * psymtab.h (struct psymbol_bcache): Don't declare.
4237         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4238         (psymbol_bcache_init, psymbol_bcache_free)
4239         (psymbol_bcache_get_bcache): Don't declare.
4240         * psymtab.c (struct psymbol_bcache): Remove.
4241         (psymtab_storage::psymtab_storage): Update.
4242         (psymtab_storage::~psymtab_storage): Update.
4243         (psymbol_bcache_init, psymbol_bcache_free)
4244         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4245         (add_psymbol_to_bcache): Update.
4246         (allocate_psymtab): Update.
4247         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4248         macro_cache>: No longer pointers.
4249         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4250         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4251         * macrotab.c (macro_bcache): Update.
4252         * macroexp.c: Don't include bcache.h.
4253         * gdbtypes.c (check_types_worklist): Update.
4254         (types_deeply_equal): Remove TRY/CATCH.  Update.
4255         * elfread.c (elf_symtab_read): Update.
4256         * dwarf2read.c: Don't include bcache.h.
4257         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4258         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4259         (print_bcache_statistics, bcache_memory_used): Don't declare.
4260         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4261         methods.  Rename all data members.
4262         * bcache.c (struct bcache): Move to bcache.h.
4263         (bcache::expand_hash_table): Rename from expand_hash_table.
4264         (bcache): Remove.
4265         (bcache::insert): Rename from bcache_full.
4266         (bcache::compare): Rename from bcache_compare.
4267         (bcache_xmalloc): Remove.
4268         (bcache::~bcache): Rename from bcache_xfree.
4269         (bcache::print_statistics): Rename from print_bcache_statistics.
4270         (bcache::memory_used): Rename from bcache_memory_used.
4271
4272 2019-03-07  Pedro Alves  <palves@redhat.com>
4273
4274         * infrun.c (normal_stop): Also check for
4275         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4276
4277 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * f-lang.c (value_from_host_double): Moved to...
4280         * value.c (value_from_host_double): ...here.
4281         * value.h (value_from_host_double): Declare.
4282         * guile/scm-math.c (vlscm_convert_typed_number): Use
4283         value_from_host_double.
4284         (vlscm_convert_number): Likewise.
4285         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4286         * python/py-value.c (convert_value_from_python): Likewise.
4287
4288 2019-03-06  Tom Tromey  <tom@tromey.com>
4289
4290         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4291
4292 2019-03-06  Tom Tromey  <tom@tromey.com>
4293
4294         * utils.h (free_current_contents): Don't declare.
4295         * utils.c (free_current_contents): Remove.
4296
4297 2019-03-06  Tom Tromey  <tom@tromey.com>
4298
4299         * top.c (quit_force): Update.
4300         * main.c (captured_command_loop): Update.
4301         * common/new-op.c (operator new): Update.
4302         * common/common-exceptions.c (struct catcher)
4303         <save_cleanup_chain>: Remove member.
4304         (exceptions_state_mc_init): Update.
4305         (exception_try_scope_entry): Return nullptr.
4306         (exception_try_scope_exit, exception_rethrow)
4307         (throw_exception_sjlj, throw_exception_cxx): Update.
4308         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4309         (all_cleanups, do_cleanups, discard_cleanups)
4310         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4311         (restore_cleanups, restore_final_cleanups): Don't declare.
4312         (do_final_cleanups): Remove parameter.
4313         * common/cleanups.c (cleanup_chain, make_cleanup)
4314         (make_cleanup_dtor, all_cleanups, do_cleanups)
4315         (discard_my_cleanups, discard_cleanups)
4316         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4317         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4318         (null_cleanup): Remove.
4319         (do_final_cleanups): Remove parameter.
4320
4321 2019-03-06  Tom Tromey  <tom@tromey.com>
4322
4323         * remote.c (remote_target::remote_parse_stop_reply): Use
4324         unique_xmalloc_ptr.
4325
4326 2019-03-06  Tom Tromey  <tom@tromey.com>
4327
4328         * stabsread.c (struct stabs_field_info): Rename from field_info.
4329         <list, fnlist>: Add initializers.
4330         <obstack>: New member.
4331         (read_member_functions, read_struct_fields, read_baseclasses):
4332         Allocate on obstack.  Don't use cleanups.
4333         (read_one_struct_field, read_member_functions, read_struct_fields)
4334         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4335         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4336         (read_struct_type): Update.
4337
4338 2019-03-06  Tom Tromey  <tom@tromey.com>
4339
4340         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4341         * common/filestuff.h (make_cleanup_close): Don't declare.
4342         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4343         Remove.
4344
4345 2019-03-06  Tom Tromey  <tom@tromey.com>
4346
4347         * solib-aix.c: Use make_scope_exit.
4348
4349 2019-03-06  Tom Tromey  <tom@tromey.com>
4350
4351         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4352         Use make_scope_exit.
4353
4354 2019-03-06  Tom Tromey  <tom@tromey.com>
4355
4356         * solib-svr4.c (disable_probes_interface): Remove parameter.
4357         (svr4_handle_solib_event): Use make_scope_exit.
4358
4359 2019-03-06  Tom Tromey  <tom@tromey.com>
4360
4361         * remote.c (struct stop_reply_deleter): Remove.
4362         (stop_reply_up): Update.
4363         (struct stop_reply): Derive from notif_event.  Don't typedef.
4364         <regcache>: Now a std::vector.
4365         (stop_reply_xfree): Remove.
4366         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4367         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4368         (remote_target::discard_pending_stop_replies): Use delete.
4369         (remote_target::remote_parse_stop_reply): Update.
4370         (remote_target::process_stop_reply): Update.
4371         * remote-notif.h (struct notif_event): Add virtual destructor.
4372         Remove "dtr" member.
4373         (struct notif_client) <alloc_event>: Return a unique_ptr.
4374         (notif_event_xfree): Don't declare.
4375         (notif_event_up): New typedef.
4376         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4377         (notif_event_xfree, do_notif_event_xfree): Remove.
4378         (remote_notif_state_xfree): Update.
4379
4380 2019-03-06  Tom Tromey  <tom@tromey.com>
4381
4382         * infrun.c (displaced_step_clear_cleanup): Now a
4383         forward_scope_exit type.
4384         (displaced_step_prepare_throw): Update.
4385         (displaced_step_fixup): Update.
4386
4387 2019-03-06  Tom Tromey  <tom@tromey.com>
4388
4389         * inferior.h (class inferior): Update comment.
4390         * gdbthread.h (class thread_info): Update comment.
4391
4392 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4393             Tom Tromey  <tom@tromey.com>
4394
4395         * stabsread.h (struct stab_section_list): Remove.
4396         (coffstab_build_psymtabs): Update.
4397         * dbxread.c (symbuf_sections): Now a std::vector.
4398         (sect_idx): New global.
4399         (fill_symbuf): Update.
4400         (coffstab_build_psymtabs): Change type of stabsects parameter.
4401         Update.
4402         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4403         std::vector.
4404         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4405         (coff_locate_sections): Update.
4406         (coff_symfile_read): Remove cleanups.  Update.
4407         (init_stringtab): Add storage parameter.
4408         (free_stringtab, free_stringtab_cleanup): Remove.
4409         (init_lineno): Add storage parameter.
4410         (free_linetab, free_linetab_cleanup): Remove.
4411
4412 2019-03-06  Pedro Alves  <palves@redhat.com>
4413
4414         * linux-fork.c (fork_info::clobber_regs): Delete.
4415         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4416         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4417         comment.  Adjust.
4418         (scoped_switch_fork_info::scoped_switch_fork_info)
4419         (checkpoint_command, linux_fork_context): Adjust
4420         fork_save_infrun_state calls.
4421
4422 2019-03-06  Pedro Alves  <palves@redhat.com>
4423
4424         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4425         (inf_has_multiple_threads): Return 'bool' and rewrite using
4426         inferior_info::threads().
4427
4428 2019-03-06  Pedro Alves  <palves@redhat.com>
4429
4430         * linux-fork.c: Include <list>.
4431         (fork_list): Now a std::list instance.
4432         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4433         (forks_exist_p, find_last_fork): Adjust.
4434         (new_fork): Delete.
4435         (one_fork_p): New.
4436         (add_fork): Adjust.
4437         (free_fork): Delete, folded into fork_info::~fork_info().
4438         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4439         Adjust.
4440         (init_fork_list): Delete.
4441         (linux_fork_killall, linux_fork_mourn_inferior)
4442         (linux_fork_detach, info_checkpoints_command): Adjust.
4443         (_initialize_linux_fork): No longer call init_fork_list.
4444
4445 2019-03-06  Pedro Alves  <palves@redhat.com>
4446
4447         * linux-fork.c (new_fork): New, split out of ...
4448         (add_fork): ... this.  Return void.  Move "first fork" special
4449         case from here, to ...
4450         (checkpoint_command): ... here.
4451         * linux-linux.h (add_fork): Return void.
4452
4453 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4456
4457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4458             Chris January  <chris.january@arm.com>
4459             David Lecomber  <david.lecomber@arm.com>
4460
4461         * f-exp.y: New token, UNOP_INTRINSIC.
4462         (exp): New pattern using UNOP_INTRINSIC token.
4463         (f77_keywords): Add 'abs' keyword.
4464         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4465         (value_from_host_double): New function.
4466         (evaluate_subexp_f): Support UNOP_ABS.
4467
4468 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4471         types.
4472
4473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4476         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4477         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4478
4479 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4482
4483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4484             Chris January  <chris.january@arm.com>
4485
4486         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4487         * f-exp.y: Define 'KIND' token.
4488         (exp): New pattern for KIND expressions.
4489         (ptype): Handle types with a kind extension.
4490         (direct_abs_decl): Extend to spot kind extensions.
4491         (f77_keywords): Add 'kind' to the list.
4492         (push_kind_type): New function.
4493         (convert_to_kind_type): New function.
4494         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4495         * parse.c (operator_length_standard): Likewise.
4496         * parser-defs.h (enum type_pieces): Add tp_kind.
4497         * std-operator.def: Add UNOP_KIND.
4498
4499 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4500
4501         * f-exp.y (f_parse): Set yydebug.
4502
4503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * f-lang.c (evaluate_subexp_f): New function.
4506         (exp_descriptor_f): New global.
4507         (f_language_defn): Use exp_descriptor_f instead of
4508         exp_descriptor_standard.
4509
4510 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * f-exp.y (struct token): Add comments.
4513         (dot_ops): Remove uppercase versions and the end marker.
4514         (f77_keywords): Likewise.
4515         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4516         entries in the dot_ops array are case insensitive, and use
4517         strncasecmp to compare strings.  Also some whitespace cleanup in
4518         this area.  Similar for the f77_keywords array, except entries in
4519         this list might be case sensitive.
4520
4521 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * f-exp.y (struct f77_boolean_val): Add comments.
4524         (boolean_values): Remove uppercase versions, and end marker.
4525         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4526         and use strncasecmp to achieve case insensitivity.  Additionally,
4527         perform whitespace cleanup around this code.
4528
4529 2019-03-06  Tom Tromey  <tromey@adacore.com>
4530
4531         * remote-sim.c (gdbsim_target_open): Use result of
4532         gdb_argv::release.
4533
4534 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4535         Dirk Schubert  <dirk.schubert@arm.com>
4536         Chris January  <chris.january@arm.com>
4537
4538         * eval.c (evaluate_subexp_standard): Call Fortran argument
4539         wrapping logic.
4540         * f-lang.c (struct value): A value which can be passed into a
4541         Fortran function call.
4542         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4543         where appropriate.
4544         (struct type): Value ready for a Fortran function call.
4545         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4546         is needed.
4547         * f-lang.h (fortran_argument_convert): Declaration.
4548         (fortran_preserve_arg_pointer): Declaration.
4549         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4550
4551 2019-03-05  Tom Tromey  <tromey@adacore.com>
4552
4553         * python/py-prettyprint.c (print_string_repr): Remove #if.
4554         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4555
4556 2019-03-05  Tom Tromey  <tromey@adacore.com>
4557
4558         * target.c (the_dummy_target): Move later.  Change type to
4559         "dummy_target".
4560         (initialize_targets): Don't initialize the_dummy_target.
4561
4562 2019-03-05  Tom Tromey  <tromey@adacore.com>
4563
4564         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4565         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4566
4567 2019-03-05  Tom Tromey  <tromey@adacore.com>
4568
4569         * windows-nat.c (windows_nat_target::attach)
4570         (windows_nat_target::detach): Don't call gdb_flush.
4571         * valprint.c (generic_val_print, val_print, val_print_string):
4572         Don't call gdb_flush.
4573         * utils.c (defaulted_query): Don't call gdb_flush.
4574         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4575         * target.c (target_announce_detach): Don't call gdb_flush.
4576         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4577         * remote.c (extended_remote_target::attach): Don't call
4578         gdb_flush.
4579         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4580         * printcmd.c (do_examine): Don't call gdb_flush.
4581         (info_display_command): Don't call gdb_flush.
4582         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4583         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4584         * memattr.c (info_mem_command): Don't call gdb_flush.
4585         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4586         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4587         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4588         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4589         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4590         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4591         (gnu_nat_target::detach): Don't call gdb_flush.
4592         * f-valprint.c (f_val_print): Don't call gdb_flush.
4593         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4594         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4595         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4596         gdb_flush.
4597         * c-valprint.c (c_val_print): Don't call gdb_flush.
4598         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4599
4600 2019-03-05  Tom Tromey  <tromey@adacore.com>
4601
4602         * varobj.c (update_dynamic_varobj_children): Update.
4603         (install_default_visualizer): Use reset, not release.
4604         * value.c (set_internalvar): Update.
4605         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4606         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4607         ATTRIBUTE_UNUSED_RESULT.
4608
4609 2019-03-05  Tom Tromey  <tromey@adacore.com>
4610
4611         * remote.c (class scoped_remote_fd) <release>: Add
4612         ATTRIBUTE_UNUSED_RESULT.
4613
4614 2019-03-05  Tom Tromey  <tromey@adacore.com>
4615
4616         * macroexp.c (struct macro_buffer) <release>: Add
4617         ATTRIBUTE_UNUSED_RESULT.
4618
4619 2019-03-05  Tom Tromey  <tromey@adacore.com>
4620
4621         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4622         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4623         ATTRIBUTE_UNUSED_RESULT.
4624
4625 2019-03-05  Tom Tromey  <tromey@adacore.com>
4626
4627         * common/scoped_fd.h (class scoped_fd) <release>: Add
4628         ATTRIBUTE_UNUSED_RESULT.
4629
4630 2019-03-05  Tom Tromey  <tromey@adacore.com>
4631
4632         * parser-defs.h (struct parser_state) <release>: Add
4633         ATTRIBUTE_UNUSED_RESULT.
4634
4635 2019-03-05  Tom Tromey  <tromey@adacore.com>
4636
4637         * utils.h (class gdb_argv) <release>: Add
4638         ATTRIBUTE_UNUSED_RESULT.
4639         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4640
4641 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4642
4643         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4644         for-loop range, to avoid compiler warnings.
4645
4646         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4647         avoid compiler warnings about unused variables.
4648
4649         * NEWS: Mention end of support for native debugging on MS-Windows
4650         before XP.
4651
4652         PR gdb/24292
4653         * common/netstuff.c:
4654         * gdbserver/gdbreplay.c
4655         * gdbserver/remote-utils.c:
4656         * ser-tcp.c:
4657         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4658         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4659         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4660         'getaddrinfo' and 'freeaddrinfo' were not available before
4661         Windows XP, and mingw.org's MinGW headers by default define
4662         _WIN32_WINNT to 0x500.
4663
4664 2019-03-01  Gary Benson <gbenson@redhat.com>
4665
4666         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4667
4668 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4669             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4670
4671         PR gdb/8527
4672         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4673         set_sigint_trap, clear_sigint_trap.
4674
4675 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4676
4677         * target.c (target_detach): Clear the regcache and the
4678         frame cache.
4679
4680 2019-02-27  Pedro Alves  <palves@redhat.com>
4681
4682         * utils.c (set_screen_size): When we cap the height/width sizes,
4683         tweak the corresponding command variable to show "unlimited":
4684
4685 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4686             Pedro Alves  <palves@redhat.com>
4687
4688         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4689         before calling rl_set_screen_size.
4690
4691 2019-02-27  Tom Tromey  <tromey@adacore.com>
4692
4693         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4694         define.
4695         * python/py-value.c: Remove Python 2.4 workaround.
4696         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4697         workaround.
4698         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4699         Python 2.4 workaround.
4700         * python/python-internal.h: Remove Python 2.4 comment.
4701         (Py_ssize_t): Don't define.
4702         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4703         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4704         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4705         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4706         * python/python.c (do_start_initialization): Remove Python 2.4
4707         workaround.
4708         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4709         (print_children): Remove Python 2.4 workaround.
4710         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4711         workaround.
4712         (CHARBUFFERPROC_NAME): Remove.
4713         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4714         Python 2.4 workaround.
4715
4716 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4717
4718         * NEWS: Note minimum Python version.
4719
4720 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4721
4722         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4723         code from these functions.  Remove corresponding ifdefs.  Use
4724         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4725         Remove gotos and target of gotos.
4726         (infpy_search_memory): Likewise.
4727
4728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4729
4730         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4731         (hppa_gdbarch_init): Don't register deleted functions with
4732         gdbarch.
4733
4734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4735
4736         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4737         (h8300_unwind_sp): Delete.
4738         (h8300_dummy_id): Delete.
4739         (h8300_gdbarch_init): Don't register deleted functions with
4740         gdbarch.
4741
4742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4745         (ft32_unwind_pc): Delete.
4746         (ft32_unwind_sp): Delete.
4747         (ft32_gdbarch_init): Don't register deleted functions with
4748         gdbarch.
4749
4750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4753         (frv_unwind_pc): Delete.
4754         (frv_unwind_sp): Delete.
4755         (frv_gdbarch_init): Don't register deleted functions with
4756         gdbarch.
4757
4758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4761         (riscv_unwind_pc): Delete.
4762         (riscv_unwind_sp): Delete.
4763         (riscv_gdbarch_init): Don't register deleted functions with
4764         gdbarch.
4765
4766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4769         (csky_unwind_pc): Delete.
4770         (csky_unwind_sp): Delete.
4771         (csky_gdbarch_init): Don't register deleted functions with
4772         gdbarch.
4773
4774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4777         (cris_unwind_pc): Delete.
4778         (cris_unwind_sp): Delete.
4779         (cris_gdbarch_init): Don't register deleted functions with
4780         gdbarch.
4781
4782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4785         (bfin_unwind_pc): Delete.
4786         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4787
4788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4789
4790         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4791         (arm_unwind_pc): Delete.
4792         (arm_unwind_sp): Delete.
4793         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4794
4795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4796
4797         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4798         (arc_unwind_pc): Delete.
4799         (arc_unwind_sp): Delete.
4800         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4801
4802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4805         (alpha_unwind_pc): Delete.
4806         (alpha_gdbarch_init): Don't register deleted functions with
4807         gdbarch.
4808
4809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4812         (aarch64_unwind_pc): Delete.
4813         (aarch64_unwind_sp): Delete.
4814         (aarch64_gdbarch_init): Don't register deleted functions with
4815         gdbarch.
4816
4817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * gdbtypes.c (type_align): Don't consider static members when
4820         computing structure alignment.
4821
4822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4825         return 0 for other types.
4826         * arch-utils.c (default_type_align): Always return 0.
4827         * gdbarch.h: Regenerate.
4828         * gdbarch.sh (type_align): Extend comment.
4829         * gdbtypes.c (type_align): Add additional comments, always call
4830         gdbarch_type_align before applying the default rules.
4831         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4832         generic code will then apply a suitable default.
4833         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4834         types, return 0 for other types.
4835
4836 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4837
4838         * NEWS: Create a new section for the next release branch.
4839         Rename the section of the current branch, now that it has
4840         been cut.
4841
4842 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4843
4844         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4845         * version.in: Bump version to 8.3.50.DATE-git.
4846
4847 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4848
4849         * aix-thread.c (ptid_cmp): Remove unused variable.
4850         (get_signaled_thread): Likewise.
4851         (store_regs_user_thread): Likewise.
4852         (store_regs_kernel_thread): Likewise.
4853         (fetch_regs_kernel_thread): Remove shadowed variable.
4854
4855 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         * features/riscv/32bit-cpu.xml: Add register numbers.
4858         * features/riscv/32bit-fpu.c: Regenerate.
4859         * features/riscv/32bit-fpu.xml: Add register numbers.
4860         * features/riscv/64bit-cpu.xml: Add register numbers.
4861         * features/riscv/64bit-fpu.c: Regenerate.
4862         * features/riscv/64bit-fpu.xml: Add register numbers.
4863
4864 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4865
4866         * NEWS: Mention two argument form of gdb.Value constructor.
4867         * python/py-value.c (convert_buffer_and_type_to_value): New
4868         function.
4869         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4870         Add support for handling an optional second argument.  Call
4871         convert_buffer_and_type_to_value as appropriate.
4872         * python/python-internal.h (Py_buffer_deleter): New struct.
4873         (Py_buffer_up): New typedef.
4874
4875 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4876
4877         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4878         instead of releasing ownership.
4879
4880 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4881
4882         * dwarf2read.c (open_and_init_dwp_file): Call
4883         elf_numsections instead of bfd_count_sections to initialize
4884         dwp_file->num_sections.
4885
4886 2019-02-25  Tom Tromey  <tromey@adacore.com>
4887
4888         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4889
4890 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4891
4892         * gcore.in: Add '--readnever' option when invoking GDB.
4893
4894 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4895
4896         * MAINTAINERS: Update my email address.
4897
4898 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4899
4900         * build-id.c (build_id_to_debug_bfd_1): New function.
4901         (build_id_to_debug_bfd): Look for separate debug file in
4902         sysroot.
4903
4904 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * gdbarch.sh: Update the copyright year range that is placed into
4907         generated files.
4908
4909 2019-02-22  Keith Seitz  <keiths@redhat.com>
4910
4911         PR symtab/23853
4912         * linespec.c (create_sals_line_offset): Search for the default
4913         symtab's filename instead of its fullname.
4914
4915 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4916
4917         * NEWS: Update style defaults.
4918
4919 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4920
4921         * main.c (captured_main_1): Disable styling in batch mode.
4922
4923 2019-02-20  Tom Tromey  <tom@tromey.com>
4924
4925         * symtab.c (symtab_symbol_info): Fix typos.
4926
4927 2019-02-20  Tom Tromey  <tromey@adacore.com>
4928
4929         * findcmd.c (_initialize_mem_search): Use upper case for
4930         metasyntactic variables.
4931
4932 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4933
4934         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4935         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4936
4937 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4938
4939         * top.h (source_file_name): Change to std::string.
4940         * top.c (source_file_name): Likewise.
4941         (command_line_input): Adjust.
4942         * cli/cli-script.c (script_from_file): Adjust.
4943
4944 2019-02-19  Tom Tromey  <tromey@adacore.com>
4945
4946         * ravenscar-thread.c
4947         (ravenscar_thread_target::update_thread_list): Don't call
4948         ada_build_task_list.
4949         * ada-lang.h (ada_build_task_list): Don't declare.
4950         * ada-tasks.c (struct ada_tasks_inferior_data)
4951         <task_list_valid_p>: Now bool.
4952         (read_known_tasks, ada_task_list_changed)
4953         (ada_tasks_invalidate_inferior_data): Update.
4954         (read_known_tasks_array): Return bool.
4955         (read_known_tasks_list): Likewise.
4956         (read_known_tasks): Return void.
4957         (ada_build_task_list): Now static.
4958
4959 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4960
4961         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4962         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4963
4964 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4965
4966         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4967         variant for ada_tasks_pspace_data_handle and
4968         ada_tasks_inferior_data_handle.
4969         (ada_tasks_pspace_data_cleanup): New function.
4970         (ada_tasks_inferior_data_cleanup): New function.
4971
4972 2019-02-17  Tom Tromey  <tom@tromey.com>
4973
4974         * macrotab.h (macro_source_fullname): Return a std::string.
4975         * macrotab.c (macro_include, check_for_redefinition)
4976         (macro_undef, macro_lookup_definition, foreach_macro)
4977         (foreach_macro_in_scope): Update.
4978         (macro_source_fullname): Return a std::string.
4979         * macrocmd.c (show_pp_source_pos): Update.
4980
4981 2019-02-17  Tom Tromey  <tom@tromey.com>
4982
4983         * macrocmd.c (show_pp_source_pos): Style the file names.
4984
4985 2019-02-17  Tom Tromey  <tom@tromey.com>
4986
4987         PR tui/24197:
4988         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4989
4990 2019-02-17  Tom Tromey  <tom@tromey.com>
4991
4992         * ada-lang.c (user_select_syms): Use filtered printing.
4993         * utils.c (wrap_style): New global.
4994         (desired_style): Remove.
4995         (emit_style_escape): Add stream parameter.
4996         (set_output_style, reset_terminal_style, prompt_for_continue):
4997         Update.
4998         (flush_wrap_buffer): Only flush gdb_stdout.
4999         (wrap_here): Set wrap_style.
5000         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5001         treat escape sequences as a character.  Change when wrap buffer is
5002         flushed.
5003         (fputs_styled): Do not set the output style when the default is
5004         requested.
5005         * ui-style.h (struct ui_file_style) <is_default>: New method.
5006         * source.c (print_source_lines_base): Emit escape sequences in one
5007         piece.
5008
5009 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5010
5011         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5012         integers and enumeration types.
5013
5014 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5015
5016         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5017         instead of lookup_symbol_in_language
5018         (do_exact_match): New function.
5019         (ada_get_symbol_name_matcher): Return do_exact_match when
5020         doing a verbatim match.
5021
5022 2019-02-15  Tom Tromey  <tromey@adacore.com>
5023
5024         * ravenscar-thread.c (ravenscar_thread_target::resume)
5025         (ravenscar_thread_target::wait): Special case wildcard requests.
5026
5027 2019-02-15  Tom Tromey  <tromey@adacore.com>
5028
5029         * ravenscar-thread.c (base_ptid): Remove.
5030         (struct ravenscar_thread_target) <close>: New method.
5031         <m_base_ptid>: New member.
5032         <update_inferior_ptid, active_task, task_is_currently_active,
5033         runtime_initialized>: Declare methods.
5034         <ravenscar_thread_target>: Add constructor.
5035         (ravenscar_thread_target::task_is_currently_active)
5036         (ravenscar_thread_target::update_inferior_ptid)
5037         (ravenscar_runtime_initialized): Rename.  Now methods.
5038         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5039         (ravenscar_thread_target::update_thread_list): Update.
5040         (ravenscar_thread_target::active_task): Now method.
5041         (ravenscar_thread_target::store_registers)
5042         (ravenscar_thread_target::prepare_to_store)
5043         (ravenscar_thread_target::prepare_to_store)
5044         (ravenscar_thread_target::mourn_inferior): Update.
5045         (ravenscar_inferior_created): Use "new" to create target.
5046         (ravenscar_thread_target::get_ada_task_ptid): Update.
5047         (_initialize_ravenscar): Don't initialize base_ptid.
5048         (ravenscar_ops): Remove global.
5049
5050 2019-02-15  Tom Tromey  <tromey@adacore.com>
5051
5052         * target.h (push_target): Declare new overload.
5053         * target.c (push_target): New overload, taking an rvalue reference.
5054         * remote.c (remote_target::open_1): Use push_target overload.
5055         * corelow.c (core_target_open): Use push_target overload.
5056
5057 2019-02-15  Tom Tromey  <tromey@adacore.com>
5058
5059         * ravenscar-thread.c (is_ravenscar_task)
5060         (ravenscar_task_is_currently_active): Return bool.
5061         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5062         (_initialize_ravenscar): Remove "(void)".
5063         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5064         Return bool.
5065
5066 2019-02-15  Tom Tromey  <tromey@adacore.com>
5067
5068         * ravenscar-thread.c (ravenscar_runtime_initializer)
5069         (has_ravenscar_runtime, get_running_thread_id)
5070         (ravenscar_thread_target::resume): Fix indentation.
5071
5072 2019-02-15  Tom Tromey  <tromey@adacore.com>
5073
5074         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5075         from ravenscar_arch_ops.
5076         (sparc_ravenscar_ops::fetch_registers)
5077         (sparc_ravenscar_ops::store_registers): Now methods.
5078         (sparc_ravenscar_prepare_to_store): Remove.
5079         (sparc_ravenscar_ops): Redefine.
5080         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5081         methods and destructor.  Remove members.
5082         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5083         (ravenscar_thread_target::store_registers)
5084         (ravenscar_thread_target::prepare_to_store): Update.
5085         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5086         Remove.
5087         (struct ppc_ravenscar_powerpc_ops): Derive from
5088         ravenscar_arch_ops.
5089         (ppc_ravenscar_powerpc_ops::fetch_registers)
5090         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5091         (ppc_ravenscar_powerpc_ops): Redefine.
5092         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5093         (ppc_ravenscar_e500_ops::fetch_registers)
5094         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5095         (ppc_ravenscar_e500_ops): Redefine.
5096         * aarch64-ravenscar-thread.c
5097         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5098         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5099         (aarch64_ravenscar_fetch_registers)
5100         (aarch64_ravenscar_store_registers): Now methods.
5101         (aarch64_ravenscar_ops): Redefine.
5102
5103 2019-02-15  Tom Tromey  <tromey@adacore.com>
5104
5105         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5106         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5107         (ravenscar_thread_target::stopped_by_watchpoint)
5108         (ravenscar_thread_target::stopped_data_address)
5109         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5110
5111 2019-02-15  Tom Tromey  <tromey@adacore.com>
5112
5113         * ravenscar-thread.c: Fix some typos.
5114
5115 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5116             Tom Tromey  <tromey@adacore.com>
5117
5118         * ada-lang.c (ada_exception_sal): Change addr_string to a
5119         std::string.
5120         (create_ada_exception_catchpoint): Update.
5121
5122 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5123             Tom Tromey  <tromey@adacore.com>
5124
5125         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5126         (bp_location_ops): Remove.
5127         (base_breakpoint_allocate_location): Update.
5128         (free_bp_location): Update.
5129         * ada-lang.c (class ada_catchpoint_location)
5130         <ada_catchpoint_location>: Remove ops parameter.
5131         (ada_catchpoint_location_dtor): Remove.
5132         (ada_catchpoint_location_ops): Remove.
5133         (allocate_location_exception): Update.
5134         * breakpoint.h (struct bp_location_ops): Remove.
5135         (class bp_location) <bp_location>: Remove bp_location_ops
5136         parameter.
5137         <~bp_location>: Add destructor.
5138         <ops>: Remove.
5139
5140 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5141             Pedro Alves  <palves@redhat.com>
5142
5143         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5144         'PATH_MAX'.
5145
5146 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5147             Samuel Thibault  <samuel.thibault@gnu.org>
5148             Thomas Schwinge  <thomas@codesourcery.com>
5149
5150         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5151         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5152
5153 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5154
5155         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5156         (check_empty): Use "const char *".
5157
5158         * gnu-nat.c (gnu_nat_target::detach): Instead of
5159         'detach_inferior (pid)' call
5160         'detach_inferior (find_inferior_pid (pid))'.
5161
5162         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5163         'nat/fork-inferior.o'.
5164         * gnu-nat.c: #include "nat/fork-inferior.h".
5165
5166         * gnu-nat.c (gnu_nat_target::detach): Instead of
5167         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5168         * gnu-nat.h: #include "inf-child.h".
5169         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5170         'i386_gnu_nat_target::fetch_registers'.
5171         (gnu_store_registers): Rename/move to
5172         'i386_gnu_nat_target::store_registers'.
5173
5174         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5175         * gnu-nat.h (mach_thread_info): New function.
5176         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5177
5178         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5179
5180 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5181
5182         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5183
5184 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5185
5186         * windows-nat.c (windows_add_thread): Add new parameter
5187         "main_thread_p" with default value set to false.  Update
5188         function documentation as well as all callers.
5189         (windows_delete_thread): Likewise.
5190         (fake_create_process): Update call to windows_add_thread.
5191         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5192         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5193         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5194         call to windows_delete_thread.
5195
5196 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5197
5198         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5199
5200 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5201
5202         * symfile.c (find_separate_debug_file): Use canonical path of
5203         sysroot with child_path instead of gdb_sysroot if it is valid.
5204
5205 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5206
5207         * symfile.c (find_separate_debug_file): Use child_path to
5208         determine if an object file is under a sysroot.
5209
5210 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5211
5212         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5213         unittests/child-path-selftests.c.
5214         * common/pathstuff.c (child_path): New function.
5215         * common/pathstuff.h (child_path): New prototype.
5216         * unittests/child-path-selftests.c: New file.
5217
5218 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5219
5220         * symfile.c (find_separate_debug_file): Look for separate debug
5221         files in debug directories under the sysroot.
5222
5223 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5224
5225         * symtab.h (struct minimal_symbol data_p): New const method.
5226         (struct minimal_symbol text_p): Likewise.
5227         * symtab.c (output_source_filename): Use file name style
5228         to print file name.
5229         (print_symbol_info): Likewise.
5230         (print_msymbol_info): Use address style to print addresses.
5231         Use function name style to print executable text symbols.
5232         (expand_symtab_containing_pc): Use data_p.
5233         (find_pc_sect_compunit_symtab): Likewise.
5234
5235 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5236
5237         * breakpoint.c (describe_other_breakpoints): Use address style
5238         to print addresses.
5239         (say_where): Likewise.
5240
5241 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5242
5243         * ada-typeprint.c (print_func_type): Print function name
5244         style to print function name.
5245         * c-typeprint.c (c_print_type_1): Likewise.
5246
5247 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5248
5249         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5250         for execve.
5251
5252 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5253
5254         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5255         type_stack.
5256
5257 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5258
5259         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5260         TYPE_CODE_REF types.
5261
5262 2019-02-08  Jim Wilson  <jimw@sifive.com>
5263
5264         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5265         (riscv_linux_fregset): New.
5266         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5267
5268 2019-02-07  Tom Tromey  <tom@tromey.com>
5269
5270         * thread.c (thread_cancel_execution_command): Update.
5271         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5272         methods.
5273         (struct thread_fsm_ops): Remove.
5274         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5275         (thread_fsm_should_stop, thread_fsm_return_value)
5276         (thread_fsm_set_finished, thread_fsm_finished_p)
5277         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5278         Don't declare.
5279         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5280         * infrun.c (clear_proceed_status_thread)
5281         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5282         (print_stop_event): Update.
5283         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5284         Add constructor.
5285         (step_command_fsm_ops): Remove.
5286         (new_step_command_fsm): Remove.
5287         (step_1): Update.
5288         (step_command_fsm::should_stop): Rename from
5289         step_command_fsm_should_stop.
5290         (step_command_fsm::clean_up): Rename from
5291         step_command_fsm_clean_up.
5292         (step_command_fsm::do_async_reply_reason): Rename from
5293         step_command_fsm_async_reply_reason.
5294         (struct until_next_fsm): Inherit from thread_fsm.  Add
5295         constructor.
5296         (until_next_fsm_ops): Remove.
5297         (new_until_next_fsm): Remove.
5298         (until_next_fsm::should_stop): Rename from
5299         until_next_fsm_should_stop.
5300         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5301         (until_next_fsm::do_async_reply_reason): Rename from
5302         until_next_fsm_async_reply_reason.
5303         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5304         constructor.  Change type of breakpoint.
5305         (finish_command_fsm_ops): Remove.
5306         (new_finish_command_fsm): Remove.
5307         (finish_command_fsm::should_stop): Rename from
5308         finish_command_fsm_should_stop.
5309         (finish_command_fsm::clean_up): Rename from
5310         finish_command_fsm_clean_up.
5311         (finish_command_fsm::return_value): Rename from
5312         finish_command_fsm_return_value.
5313         (finish_command_fsm::do_async_reply_reason): Rename from
5314         finish_command_fsm_async_reply_reason.
5315         (finish_command): Update.
5316         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5317         Add constructor.
5318         (call_thread_fsm_ops): Remove.
5319         (call_thread_fsm::call_thread_fsm): Rename from
5320         new_call_thread_fsm.
5321         (call_thread_fsm::should_stop): Rename from
5322         call_thread_fsm_should_stop.
5323         (call_thread_fsm::should_notify_stop): Rename from
5324         call_thread_fsm_should_notify_stop.
5325         (run_inferior_call, call_function_by_hand_dummy): Update.
5326         * cli/cli-interp.c (should_print_stop_to_console): Update.
5327         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5328         Add constructor.  Change type of location_breakpoint,
5329         caller_breakpoint.
5330         (until_break_fsm_ops): Remove.
5331         (new_until_break_fsm): Remove.
5332         (until_break_fsm::should_stop): Rename from
5333         until_break_fsm_should_stop.
5334         (until_break_fsm::clean_up): Rename from
5335         until_break_fsm_clean_up.
5336         (until_break_fsm::do_async_reply_reason): Rename from
5337         until_break_fsm_async_reply_reason.
5338         (until_break_command): Update.
5339         * thread-fsm.c: Remove.
5340         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5341
5342 2019-02-07  Tom Tromey  <tom@tromey.com>
5343
5344         * yy-remap.h: Add include guard.
5345         * xtensa-tdep.h: Add include guard.
5346         * xcoffread.h: Rename include guard.
5347         * varobj-iter.h: Add include guard.
5348         * tui/tui.h: Rename include guard.
5349         * tui/tui-winsource.h: Rename include guard.
5350         * tui/tui-wingeneral.h: Rename include guard.
5351         * tui/tui-windata.h: Rename include guard.
5352         * tui/tui-win.h: Rename include guard.
5353         * tui/tui-stack.h: Rename include guard.
5354         * tui/tui-source.h: Rename include guard.
5355         * tui/tui-regs.h: Rename include guard.
5356         * tui/tui-out.h: Rename include guard.
5357         * tui/tui-layout.h: Rename include guard.
5358         * tui/tui-io.h: Rename include guard.
5359         * tui/tui-hooks.h: Rename include guard.
5360         * tui/tui-file.h: Rename include guard.
5361         * tui/tui-disasm.h: Rename include guard.
5362         * tui/tui-data.h: Rename include guard.
5363         * tui/tui-command.h: Rename include guard.
5364         * tic6x-tdep.h: Add include guard.
5365         * target/waitstatus.h: Rename include guard.
5366         * target/wait.h: Rename include guard.
5367         * target/target.h: Rename include guard.
5368         * target/resume.h: Rename include guard.
5369         * target-float.h: Rename include guard.
5370         * stabsread.h: Add include guard.
5371         * rs6000-tdep.h: Add include guard.
5372         * riscv-fbsd-tdep.h: Add include guard.
5373         * regformats/regdef.h: Rename include guard.
5374         * record.h: Rename include guard.
5375         * python/python.h: Rename include guard.
5376         * python/python-internal.h: Rename include guard.
5377         * python/py-stopevent.h: Rename include guard.
5378         * python/py-ref.h: Rename include guard.
5379         * python/py-record.h: Rename include guard.
5380         * python/py-record-full.h: Rename include guard.
5381         * python/py-record-btrace.h: Rename include guard.
5382         * python/py-instruction.h: Rename include guard.
5383         * python/py-events.h: Rename include guard.
5384         * python/py-event.h: Rename include guard.
5385         * procfs.h: Add include guard.
5386         * proc-utils.h: Add include guard.
5387         * p-lang.h: Add include guard.
5388         * or1k-tdep.h: Rename include guard.
5389         * observable.h: Rename include guard.
5390         * nto-tdep.h: Rename include guard.
5391         * nat/x86-linux.h: Rename include guard.
5392         * nat/x86-linux-dregs.h: Rename include guard.
5393         * nat/x86-gcc-cpuid.h: Add include guard.
5394         * nat/x86-dregs.h: Rename include guard.
5395         * nat/x86-cpuid.h: Rename include guard.
5396         * nat/ppc-linux.h: Rename include guard.
5397         * nat/mips-linux-watch.h: Rename include guard.
5398         * nat/linux-waitpid.h: Rename include guard.
5399         * nat/linux-ptrace.h: Rename include guard.
5400         * nat/linux-procfs.h: Rename include guard.
5401         * nat/linux-osdata.h: Rename include guard.
5402         * nat/linux-nat.h: Rename include guard.
5403         * nat/linux-namespaces.h: Rename include guard.
5404         * nat/linux-btrace.h: Rename include guard.
5405         * nat/glibc_thread_db.h: Rename include guard.
5406         * nat/gdb_thread_db.h: Rename include guard.
5407         * nat/gdb_ptrace.h: Rename include guard.
5408         * nat/fork-inferior.h: Rename include guard.
5409         * nat/amd64-linux-siginfo.h: Rename include guard.
5410         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5411         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5412         * nat/aarch64-linux.h: Rename include guard.
5413         * nat/aarch64-linux-hw-point.h: Rename include guard.
5414         * mn10300-tdep.h: Add include guard.
5415         * mips-linux-tdep.h: Add include guard.
5416         * mi/mi-parse.h: Rename include guard.
5417         * mi/mi-out.h: Rename include guard.
5418         * mi/mi-main.h: Rename include guard.
5419         * mi/mi-interp.h: Rename include guard.
5420         * mi/mi-getopt.h: Rename include guard.
5421         * mi/mi-console.h: Rename include guard.
5422         * mi/mi-common.h: Rename include guard.
5423         * mi/mi-cmds.h: Rename include guard.
5424         * mi/mi-cmd-break.h: Rename include guard.
5425         * m2-lang.h: Add include guard.
5426         * location.h: Rename include guard.
5427         * linux-record.h: Rename include guard.
5428         * linux-nat.h: Add include guard.
5429         * linux-fork.h: Add include guard.
5430         * i386-darwin-tdep.h: Rename include guard.
5431         * hppa-linux-offsets.h: Add include guard.
5432         * guile/guile.h: Rename include guard.
5433         * guile/guile-internal.h: Rename include guard.
5434         * gnu-nat.h: Rename include guard.
5435         * gdb-stabs.h: Rename include guard.
5436         * frv-tdep.h: Add include guard.
5437         * f-lang.h: Add include guard.
5438         * event-loop.h: Add include guard.
5439         * darwin-nat.h: Rename include guard.
5440         * cp-abi.h: Rename include guard.
5441         * config/sparc/nm-sol2.h: Rename include guard.
5442         * config/nm-nto.h: Rename include guard.
5443         * config/nm-linux.h: Add include guard.
5444         * config/i386/nm-i386gnu.h: Rename include guard.
5445         * config/djgpp/nl_types.h: Rename include guard.
5446         * config/djgpp/langinfo.h: Rename include guard.
5447         * compile/gcc-cp-plugin.h: Add include guard.
5448         * compile/gcc-c-plugin.h: Add include guard.
5449         * compile/compile.h: Rename include guard.
5450         * compile/compile-object-run.h: Rename include guard.
5451         * compile/compile-object-load.h: Rename include guard.
5452         * compile/compile-internal.h: Rename include guard.
5453         * compile/compile-cplus.h: Rename include guard.
5454         * compile/compile-c.h: Rename include guard.
5455         * common/xml-utils.h: Rename include guard.
5456         * common/x86-xstate.h: Rename include guard.
5457         * common/version.h: Rename include guard.
5458         * common/vec.h: Rename include guard.
5459         * common/tdesc.h: Rename include guard.
5460         * common/selftest.h: Rename include guard.
5461         * common/scoped_restore.h: Rename include guard.
5462         * common/scoped_mmap.h: Rename include guard.
5463         * common/scoped_fd.h: Rename include guard.
5464         * common/safe-iterator.h: Rename include guard.
5465         * common/run-time-clock.h: Rename include guard.
5466         * common/refcounted-object.h: Rename include guard.
5467         * common/queue.h: Rename include guard.
5468         * common/ptid.h: Rename include guard.
5469         * common/print-utils.h: Rename include guard.
5470         * common/preprocessor.h: Rename include guard.
5471         * common/pathstuff.h: Rename include guard.
5472         * common/observable.h: Rename include guard.
5473         * common/netstuff.h: Rename include guard.
5474         * common/job-control.h: Rename include guard.
5475         * common/host-defs.h: Rename include guard.
5476         * common/gdb_wait.h: Rename include guard.
5477         * common/gdb_vecs.h: Rename include guard.
5478         * common/gdb_unlinker.h: Rename include guard.
5479         * common/gdb_unique_ptr.h: Rename include guard.
5480         * common/gdb_tilde_expand.h: Rename include guard.
5481         * common/gdb_sys_time.h: Rename include guard.
5482         * common/gdb_string_view.h: Rename include guard.
5483         * common/gdb_splay_tree.h: Rename include guard.
5484         * common/gdb_setjmp.h: Rename include guard.
5485         * common/gdb_ref_ptr.h: Rename include guard.
5486         * common/gdb_optional.h: Rename include guard.
5487         * common/gdb_locale.h: Rename include guard.
5488         * common/gdb_assert.h: Rename include guard.
5489         * common/filtered-iterator.h: Rename include guard.
5490         * common/filestuff.h: Rename include guard.
5491         * common/fileio.h: Rename include guard.
5492         * common/environ.h: Rename include guard.
5493         * common/common-utils.h: Rename include guard.
5494         * common/common-types.h: Rename include guard.
5495         * common/common-regcache.h: Rename include guard.
5496         * common/common-inferior.h: Rename include guard.
5497         * common/common-gdbthread.h: Rename include guard.
5498         * common/common-exceptions.h: Rename include guard.
5499         * common/common-defs.h: Rename include guard.
5500         * common/common-debug.h: Rename include guard.
5501         * common/cleanups.h: Rename include guard.
5502         * common/buffer.h: Rename include guard.
5503         * common/btrace-common.h: Rename include guard.
5504         * common/break-common.h: Rename include guard.
5505         * cli/cli-utils.h: Rename include guard.
5506         * cli/cli-style.h: Rename include guard.
5507         * cli/cli-setshow.h: Rename include guard.
5508         * cli/cli-script.h: Rename include guard.
5509         * cli/cli-interp.h: Rename include guard.
5510         * cli/cli-decode.h: Rename include guard.
5511         * cli/cli-cmds.h: Rename include guard.
5512         * charset-list.h: Add include guard.
5513         * buildsym-legacy.h: Rename include guard.
5514         * bfin-tdep.h: Add include guard.
5515         * ax.h: Rename include guard.
5516         * arm-linux-tdep.h: Add include guard.
5517         * arm-fbsd-tdep.h: Add include guard.
5518         * arch/xtensa.h: Rename include guard.
5519         * arch/tic6x.h: Add include guard.
5520         * arch/i386.h: Add include guard.
5521         * arch/arm.h: Rename include guard.
5522         * arch/arm-linux.h: Rename include guard.
5523         * arch/arm-get-next-pcs.h: Rename include guard.
5524         * arch/amd64.h: Add include guard.
5525         * arch/aarch64-insn.h: Rename include guard.
5526         * arch-utils.h: Rename include guard.
5527         * annotate.h: Add include guard.
5528         * amd64-darwin-tdep.h: Rename include guard.
5529         * aarch64-linux-tdep.h: Add include guard.
5530         * aarch64-fbsd-tdep.h: Add include guard.
5531         * aarch32-linux-nat.h: Add include guard.
5532
5533 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * macrotab.c (macro_define_internal): New function that
5536         factorizes macro_define_object_internal and macro_define_function
5537         code.
5538         (macro_define_object_internal): Use macro_define_internal.
5539         (macro_define_function): Likewise.
5540
5541 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5542
5543         * macrocmd.c (extract_identifier): Return
5544         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5545         callers.
5546
5547 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5548
5549         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5550
5551 2019-02-05  Tom Tromey  <tom@tromey.com>
5552
5553         * target.c (target_stack::unpush): Move assertion earlier.
5554
5555 2019-01-30  Tom Tromey  <tom@tromey.com>
5556
5557         PR python/23615:
5558         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5559         (gdbpy_parse_and_eval): Likewise.
5560         * python/python-internal.h (gdbpy_allow_threads): New class.
5561
5562 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5563
5564         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5565         (aarch64_fbsd_fpregmap): Move earlier.
5566         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5567         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5568         instead of individual calls to trad_frame_set_reg_addr.
5569         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5570         earlier.
5571         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5572         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5573         instead of individual calls to trad_frame_set_reg_addr.
5574
5575 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5576
5577         * CONTRIBUTE: Replace contribution list with wiki link.
5578
5579 2019-01-25  Tom Tromey  <tom@tromey.com>
5580
5581         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5582
5583 2019-01-25  Tom Tromey  <tom@tromey.com>
5584
5585         * xtensa-linux-nat.c: Fix common/ includes.
5586         * xml-support.h: Fix common/ includes.
5587         * xml-support.c: Fix common/ includes.
5588         * x86-linux-nat.c: Fix common/ includes.
5589         * windows-nat.c: Fix common/ includes.
5590         * varobj.h: Fix common/ includes.
5591         * varobj.c: Fix common/ includes.
5592         * value.c: Fix common/ includes.
5593         * valops.c: Fix common/ includes.
5594         * utils.c: Fix common/ includes.
5595         * unittests/xml-utils-selftests.c: Fix common/ includes.
5596         * unittests/utils-selftests.c: Fix common/ includes.
5597         * unittests/unpack-selftests.c: Fix common/ includes.
5598         * unittests/tracepoint-selftests.c: Fix common/ includes.
5599         * unittests/style-selftests.c: Fix common/ includes.
5600         * unittests/string_view-selftests.c: Fix common/ includes.
5601         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5602         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5603         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5604         * unittests/rsp-low-selftests.c: Fix common/ includes.
5605         * unittests/parse-connection-spec-selftests.c: Fix common/
5606         includes.
5607         * unittests/optional-selftests.c: Fix common/ includes.
5608         * unittests/offset-type-selftests.c: Fix common/ includes.
5609         * unittests/observable-selftests.c: Fix common/ includes.
5610         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5611         * unittests/memrange-selftests.c: Fix common/ includes.
5612         * unittests/memory-map-selftests.c: Fix common/ includes.
5613         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5614         * unittests/function-view-selftests.c: Fix common/ includes.
5615         * unittests/environ-selftests.c: Fix common/ includes.
5616         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5617         * unittests/common-utils-selftests.c: Fix common/ includes.
5618         * unittests/cli-utils-selftests.c: Fix common/ includes.
5619         * unittests/array-view-selftests.c: Fix common/ includes.
5620         * ui-file.c: Fix common/ includes.
5621         * tui/tui-io.c: Fix common/ includes.
5622         * tracepoint.h: Fix common/ includes.
5623         * tracepoint.c: Fix common/ includes.
5624         * tracefile-tfile.c: Fix common/ includes.
5625         * top.h: Fix common/ includes.
5626         * top.c: Fix common/ includes.
5627         * thread.c: Fix common/ includes.
5628         * target/waitstatus.h: Fix common/ includes.
5629         * target/waitstatus.c: Fix common/ includes.
5630         * target.h: Fix common/ includes.
5631         * target.c: Fix common/ includes.
5632         * target-memory.c: Fix common/ includes.
5633         * target-descriptions.c: Fix common/ includes.
5634         * symtab.h: Fix common/ includes.
5635         * symfile.c: Fix common/ includes.
5636         * stap-probe.c: Fix common/ includes.
5637         * spu-linux-nat.c: Fix common/ includes.
5638         * sparc-nat.c: Fix common/ includes.
5639         * source.c: Fix common/ includes.
5640         * solib.c: Fix common/ includes.
5641         * solib-target.c: Fix common/ includes.
5642         * ser-unix.c: Fix common/ includes.
5643         * ser-tcp.c: Fix common/ includes.
5644         * ser-pipe.c: Fix common/ includes.
5645         * ser-base.c: Fix common/ includes.
5646         * selftest-arch.c: Fix common/ includes.
5647         * s12z-tdep.c: Fix common/ includes.
5648         * rust-exp.y: Fix common/ includes.
5649         * rs6000-aix-tdep.c: Fix common/ includes.
5650         * riscv-tdep.c: Fix common/ includes.
5651         * remote.c: Fix common/ includes.
5652         * remote-notif.h: Fix common/ includes.
5653         * remote-fileio.h: Fix common/ includes.
5654         * remote-fileio.c: Fix common/ includes.
5655         * regcache.h: Fix common/ includes.
5656         * regcache.c: Fix common/ includes.
5657         * record-btrace.c: Fix common/ includes.
5658         * python/python.c: Fix common/ includes.
5659         * python/py-type.c: Fix common/ includes.
5660         * python/py-inferior.c: Fix common/ includes.
5661         * progspace.h: Fix common/ includes.
5662         * producer.c: Fix common/ includes.
5663         * procfs.c: Fix common/ includes.
5664         * proc-api.c: Fix common/ includes.
5665         * printcmd.c: Fix common/ includes.
5666         * ppc-linux-nat.c: Fix common/ includes.
5667         * parser-defs.h: Fix common/ includes.
5668         * osdata.c: Fix common/ includes.
5669         * obsd-nat.c: Fix common/ includes.
5670         * nat/x86-linux.c: Fix common/ includes.
5671         * nat/x86-linux-dregs.c: Fix common/ includes.
5672         * nat/x86-dregs.h: Fix common/ includes.
5673         * nat/x86-dregs.c: Fix common/ includes.
5674         * nat/ppc-linux.c: Fix common/ includes.
5675         * nat/mips-linux-watch.h: Fix common/ includes.
5676         * nat/mips-linux-watch.c: Fix common/ includes.
5677         * nat/linux-waitpid.c: Fix common/ includes.
5678         * nat/linux-ptrace.h: Fix common/ includes.
5679         * nat/linux-ptrace.c: Fix common/ includes.
5680         * nat/linux-procfs.c: Fix common/ includes.
5681         * nat/linux-personality.c: Fix common/ includes.
5682         * nat/linux-osdata.c: Fix common/ includes.
5683         * nat/linux-namespaces.c: Fix common/ includes.
5684         * nat/linux-btrace.h: Fix common/ includes.
5685         * nat/linux-btrace.c: Fix common/ includes.
5686         * nat/fork-inferior.c: Fix common/ includes.
5687         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5688         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5689         * nat/aarch64-linux.c: Fix common/ includes.
5690         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5691         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5692         * namespace.h: Fix common/ includes.
5693         * mips-linux-tdep.c: Fix common/ includes.
5694         * minsyms.c: Fix common/ includes.
5695         * mi/mi-parse.h: Fix common/ includes.
5696         * mi/mi-main.c: Fix common/ includes.
5697         * mi/mi-cmd-env.c: Fix common/ includes.
5698         * memrange.h: Fix common/ includes.
5699         * memattr.c: Fix common/ includes.
5700         * maint.h: Fix common/ includes.
5701         * maint.c: Fix common/ includes.
5702         * main.c: Fix common/ includes.
5703         * machoread.c: Fix common/ includes.
5704         * location.c: Fix common/ includes.
5705         * linux-thread-db.c: Fix common/ includes.
5706         * linux-nat.c: Fix common/ includes.
5707         * linux-fork.c: Fix common/ includes.
5708         * inline-frame.c: Fix common/ includes.
5709         * infrun.c: Fix common/ includes.
5710         * inflow.c: Fix common/ includes.
5711         * inferior.h: Fix common/ includes.
5712         * inferior.c: Fix common/ includes.
5713         * infcmd.c: Fix common/ includes.
5714         * inf-ptrace.c: Fix common/ includes.
5715         * inf-child.c: Fix common/ includes.
5716         * ia64-linux-nat.c: Fix common/ includes.
5717         * i387-tdep.c: Fix common/ includes.
5718         * i386-tdep.c: Fix common/ includes.
5719         * i386-linux-tdep.c: Fix common/ includes.
5720         * i386-linux-nat.c: Fix common/ includes.
5721         * i386-go32-tdep.c: Fix common/ includes.
5722         * i386-fbsd-tdep.c: Fix common/ includes.
5723         * i386-fbsd-nat.c: Fix common/ includes.
5724         * guile/scm-type.c: Fix common/ includes.
5725         * guile/guile.c: Fix common/ includes.
5726         * go32-nat.c: Fix common/ includes.
5727         * gnu-nat.c: Fix common/ includes.
5728         * gdbthread.h: Fix common/ includes.
5729         * gdbarch-selftests.c: Fix common/ includes.
5730         * gdb_usleep.c: Fix common/ includes.
5731         * gdb_select.h: Fix common/ includes.
5732         * gdb_bfd.c: Fix common/ includes.
5733         * gcore.c: Fix common/ includes.
5734         * fork-child.c: Fix common/ includes.
5735         * findvar.c: Fix common/ includes.
5736         * fbsd-nat.c: Fix common/ includes.
5737         * event-top.c: Fix common/ includes.
5738         * event-loop.c: Fix common/ includes.
5739         * dwarf2read.c: Fix common/ includes.
5740         * dwarf2loc.c: Fix common/ includes.
5741         * dwarf2-frame.c: Fix common/ includes.
5742         * dwarf-index-cache.c: Fix common/ includes.
5743         * dtrace-probe.c: Fix common/ includes.
5744         * disasm-selftests.c: Fix common/ includes.
5745         * defs.h: Fix common/ includes.
5746         * csky-tdep.c: Fix common/ includes.
5747         * cp-valprint.c: Fix common/ includes.
5748         * cp-support.h: Fix common/ includes.
5749         * cp-support.c: Fix common/ includes.
5750         * corelow.c: Fix common/ includes.
5751         * completer.h: Fix common/ includes.
5752         * completer.c: Fix common/ includes.
5753         * compile/compile.c: Fix common/ includes.
5754         * compile/compile-loc2c.c: Fix common/ includes.
5755         * compile/compile-cplus-types.c: Fix common/ includes.
5756         * compile/compile-cplus-symbols.c: Fix common/ includes.
5757         * command.h: Fix common/ includes.
5758         * cli/cli-dump.c: Fix common/ includes.
5759         * cli/cli-cmds.c: Fix common/ includes.
5760         * charset.c: Fix common/ includes.
5761         * build-id.c: Fix common/ includes.
5762         * btrace.h: Fix common/ includes.
5763         * btrace.c: Fix common/ includes.
5764         * breakpoint.h: Fix common/ includes.
5765         * breakpoint.c: Fix common/ includes.
5766         * ax.h:
5767         (enum agent_op): Fix common/ includes.
5768         * ax-general.c (struct aop_map): Fix common/ includes.
5769         * ax-gdb.c: Fix common/ includes.
5770         * auxv.c: Fix common/ includes.
5771         * auto-load.c: Fix common/ includes.
5772         * arm-tdep.c: Fix common/ includes.
5773         * arch/riscv.c: Fix common/ includes.
5774         * arch/ppc-linux-common.c: Fix common/ includes.
5775         * arch/i386.c: Fix common/ includes.
5776         * arch/arm.c: Fix common/ includes.
5777         * arch/arm-linux.c: Fix common/ includes.
5778         * arch/arm-get-next-pcs.c: Fix common/ includes.
5779         * arch/amd64.c: Fix common/ includes.
5780         * arch/aarch64.c: Fix common/ includes.
5781         * arch/aarch64-insn.c: Fix common/ includes.
5782         * arch-utils.c: Fix common/ includes.
5783         * amd64-windows-tdep.c: Fix common/ includes.
5784         * amd64-tdep.c: Fix common/ includes.
5785         * amd64-sol2-tdep.c: Fix common/ includes.
5786         * amd64-obsd-tdep.c: Fix common/ includes.
5787         * amd64-nbsd-tdep.c: Fix common/ includes.
5788         * amd64-linux-tdep.c: Fix common/ includes.
5789         * amd64-linux-nat.c: Fix common/ includes.
5790         * amd64-fbsd-tdep.c: Fix common/ includes.
5791         * amd64-fbsd-nat.c: Fix common/ includes.
5792         * amd64-dicos-tdep.c: Fix common/ includes.
5793         * amd64-darwin-tdep.c: Fix common/ includes.
5794         * agent.c: Fix common/ includes.
5795         * ada-lang.h: Fix common/ includes.
5796         * ada-lang.c: Fix common/ includes.
5797         * aarch64-tdep.c: Fix common/ includes.
5798
5799 2019-01-25  Tom Tromey  <tom@tromey.com>
5800
5801         * common/create-version.sh: Use common/version.h.
5802
5803 2019-01-24  Pedro Alves  <palves@redhat.com>
5804
5805         * infrun.c (signal_stop, signal_print, signal_program)
5806         (signal_catch, signal_pass): Now arrays instead of pointers.
5807         (update_signals_program_target, do_target_resume)
5808         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5809         * linux-nat.c (linux_nat_target::pass_signals)
5810         (linux_nat_target::create_inferior, linux_nat_target::attach):
5811         Adjust.
5812         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5813         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5814         * procfs.c (procfs_target::pass_signals): Adjust.
5815         * record-full.c (record_full_target::resume): Adjust.
5816         * remote.c (remote_target::pass_signals)
5817         (remote_target::program_signals): Adjust.
5818         * target-debug.h (target_debug_print_signals): Now takes a
5819         gdb::array_view as parameter.  Adjust.
5820         * target.h (target_ops) <pass_signals, program_signals>: Replace
5821         pointer and length parameters with gdb::array_view.
5822         (target_pass_signals, target_program_signals): Likewise.
5823         * target-delegates.c: Regenerate.
5824
5825 2019-01-24  Pedro Alves  <palves@redhat.com>
5826
5827         * common/forward-scope-exit.h
5828         (forward_scope_exit::forward_scope_exit): Pass arguments to
5829         m_bind_function directly, instead of creating a std::bind and
5830         copying that.
5831
5832 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5833
5834         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5835         for static members.
5836         (pass_in_v_vfp_candidate): Likewise.
5837
5838 2019-01-23  Tom Tromey  <tom@tromey.com>
5839             Pedro Alves  <palves@redhat.com>
5840
5841         * regcache.c (class regcache_invalidator): Remove.
5842         (regcache::raw_write): Use make_scope_exit.
5843
5844 2019-01-23  Tom Tromey  <tom@tromey.com>
5845
5846         * ui-out.h (class ui_out_emit_type): Update comment.
5847
5848 2019-01-23  Tom Tromey  <tom@tromey.com>
5849
5850         * infrun.c (fetch_inferior_event): Update comment.
5851
5852 2019-01-23  Tom Tromey  <tom@tromey.com>
5853             Pedro Alves  <palves@redhat.com>
5854
5855         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5856         parameter.
5857         (fetch_inferior_event): Use SCOPE_EXIT.
5858
5859
5860 2019-01-23  Tom Tromey  <tom@tromey.com>
5861             Pedro Alves  <palves@redhat.com>
5862
5863         * infrun.c (disable_thread_events): Delete.
5864         (stop_all_threads): Use SCOPE_EXIT.
5865
5866 2019-01-23  Tom Tromey  <tom@tromey.com>
5867             Pedro Alves  <palves@redhat.com>
5868
5869         * symfile.c: Include forward-scope-exit.h.
5870         (clear_symtab_users_cleanup): Replace forward declaration with
5871         a FORWARD_SCOPE_EXIT.
5872         (syms_from_objfile_1): Use the forward_scope_exit and
5873         gdb::optional instead of cleanup_function.
5874         (reread_symbols): Use the forward_scope_exit instead of
5875         cleanup_function.
5876         (clear_symtab_users_cleanup): Remove function.
5877
5878 2019-01-23  Tom Tromey  <tom@tromey.com>
5879             Pedro Alves  <palves@redhat.com>
5880
5881         * linux-nat.c: Include scope-exit.h.
5882         (cleanup_target_stop): Remove.
5883         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5884         SCOPE_EXIT.
5885
5886 2019-01-23  Tom Tromey  <tom@tromey.com>
5887             Pedro Alves  <palves@redhat.com>
5888
5889         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5890         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5891
5892 2019-01-23  Tom Tromey  <tom@tromey.com>
5893             Andrew Burgess  <andrew.burgess@embecosm.com>
5894             Pedro Alves  <palves@redhat.com>
5895
5896         * infrun.c (fetch_inferior_event): Use scope_exit.
5897         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5898         * top.c (execute_command): Use scope_exit.
5899         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5900         * utils.c (do_bpstat_clear_actions_cleanup)
5901         (make_bpstat_clear_actions_cleanup): Remove.
5902
5903 2019-01-23  Tom Tromey  <tom@tromey.com>
5904             Pedro Alves  <palves@redhat.com>
5905
5906         * infrun.c: Include "common/scope-exit.h"
5907         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5908         (wait_for_inferior): Use SCOPE_EXIT.
5909         (fetch_inferior_event): Use scope_exit.
5910
5911 2019-01-23  Tom Tromey  <tom@tromey.com>
5912             Pedro Alves  <palves@redhat.com>
5913
5914         * breakpoint.c (create_breakpoint): Remove cleanup.
5915
5916 2019-01-23  Tom Tromey  <tom@tromey.com>
5917             Andrew Burgess  <andrew.burgess@embecosm.com>
5918             Pedro Alves  <palves@redhat.com>
5919
5920 2019-01-23  Pedro Alves  <palves@redhat.com>
5921
5922         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5923
5924 2019-01-23  Pedro Alves  <palves@redhat.com>
5925             Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * gdbthread.h: Include "common/forward-scope-exit.h".
5928         (scoped_finish_thread_state): Redefine custom class in terms of
5929         forward_scope_exit.
5930
5931 2019-01-23  Pedro Alves  <palves@redhat.com>
5932             Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * common/forward-scope-exit.h: New file.
5935
5936 2019-01-23  Pedro Alves  <palves@redhat.com>
5937             Andrew Burgess  <andrew.burgess@embecosm.com>
5938             Tom Tromey  <tom@tromey.com>
5939
5940         * common/scope-exit.h: New file.
5941
5942 2019-01-23  Pedro Alves  <palves@redhat.com>
5943
5944         * common/preprocessor.h (ESC): Rename to ...
5945         (ESC_PARENS): ... this.
5946         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5947         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5948
5949 2019-01-23  Tom Tromey  <tom@tromey.com>
5950
5951         * language.h (class scoped_switch_to_sym_language_if_auto):
5952         Initialize m_lang in both cases.
5953
5954 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5955
5956         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5957         with XCNEW.
5958
5959 2019-01-22  Tom Tromey  <tom@tromey.com>
5960
5961         * corelow.c: Do not include sys/file.h.
5962
5963 2019-01-22  Tom Tromey  <tom@tromey.com>
5964
5965         * tui/tui-wingeneral.h: Include gdb_curses.h.
5966
5967 2019-01-22  Tom Tromey  <tom@tromey.com>
5968
5969         * source-cache.h (class source_cache) <get_source_lines,
5970         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5971
5972 2019-01-22  Tom Tromey  <tom@tromey.com>
5973
5974         * remote-fileio.h (struct remote_target): Declare.
5975
5976 2019-01-22  Tom Tromey  <tom@tromey.com>
5977
5978         * python/py-arch.c: Do not include py-ref.h.
5979         * python/py-bpevent.c: Do not include py-ref.h.
5980         * python/py-cmd.c: Do not include py-ref.h.
5981         * python/py-continueevent.c: Do not include py-ref.h.
5982         * python/py-event.h: Do not include py-ref.h.
5983         * python/py-evtregistry.c: Do not include py-ref.h.
5984         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5985         * python/py-frame.c: Do not include py-ref.h.
5986         * python/py-framefilter.c: Do not include py-ref.h.
5987         * python/py-function.c: Do not include py-ref.h.
5988         * python/py-infevents.c: Do not include py-ref.h.
5989         * python/py-linetable.c: Do not include py-ref.h.
5990         * python/py-objfile.c: Do not include py-ref.h.
5991         * python/py-param.c: Do not include py-ref.h.
5992         * python/py-prettyprint.c: Do not include py-ref.h.
5993         * python/py-progspace.c: Do not include py-ref.h.
5994         * python/py-symbol.c: Do not include py-ref.h.
5995         * python/py-symtab.c: Do not include py-ref.h.
5996         * python/py-type.c: Do not include py-ref.h.
5997         * python/py-unwind.c: Do not include py-ref.h.
5998         * python/py-utils.c: Do not include py-ref.h.
5999         * python/py-value.c: Do not include py-ref.h.
6000         * python/py-varobj.c: Do not include py-ref.h.
6001         * python/py-xmethods.c: Do not include py-ref.h.
6002         * python/python.c: Do not include py-ref.h.
6003         * varobj.c: Do not include py-ref.h.
6004
6005 2019-01-22  Tom Tromey  <tom@tromey.com>
6006
6007         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6008         keyword for bcache.
6009
6010 2019-01-22  Tom Tromey  <tom@tromey.com>
6011
6012         * compile/compile-cplus-types.c: Remove a comment by #include.
6013
6014 2019-01-22  Tom Tromey  <tom@tromey.com>
6015
6016         * compile/gcc-c-plugin.h: Include compile-internal.h.
6017
6018 2019-01-22  Tom Tromey  <tom@tromey.com>
6019
6020         * stabsread.c (EXTERN): Do not define.
6021         (symnum, next_symbol_text_func, processing_gcc_compilation)
6022         (within_function, global_sym_chain, global_stabs)
6023         (previous_stab_code, this_object_header_files)
6024         (n_this_object_header_files)
6025         (n_allocated_this_object_header_files): Define.
6026         * stabsread.h (EXTERN): Never define.  Use "extern".
6027
6028 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6029
6030         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6031         history_value.
6032
6033 2019-01-21  Tom Tromey  <tom@tromey.com>
6034
6035         * ui-out.c: Fix includes.
6036         * tui/tui-source.c: Fix includes.
6037         * target.c: Fix includes.
6038         * remote.c: Fix includes.
6039         * regcache.c: Fix includes.
6040         * python/py-block.c: Fix includes.
6041         * printcmd.c: Fix includes.
6042         * or1k-tdep.c: Fix includes.
6043         * mi/mi-main.c: Fix includes.
6044         * m32r-tdep.c: Fix includes.
6045         * csky-tdep.c: Fix includes.
6046         * compile/compile-cplus-types.c: Fix includes.
6047         * cli/cli-interp.c: Fix includes.
6048
6049 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6050
6051         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6052         for padding.
6053
6054 2019-01-16  Tom Tromey  <tom@tromey.com>
6055
6056         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6057         earlier.
6058         (struct objfile) <msymbols_range>: Move from top level.
6059         <msymbols>: New method.
6060         (class objfile_msymbols): Remove.
6061         * symtab.c (default_collect_symbol_completion_matches_break_on):
6062         Update.
6063         * symmisc.c (dump_msymbols): Update.
6064         * stabsread.c (scan_file_globals): Update.
6065         * objc-lang.c (info_selectors_command, info_classes_command)
6066         (find_methods): Update.
6067         * minsyms.c (find_solib_trampoline_target): Update.
6068         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6069         * coffread.c (coff_symfile_read): Update.
6070         * ada-lang.c (ada_lookup_simple_minsym)
6071         (ada_collect_symbol_completion_matches): Update.
6072
6073 2019-01-16  Tom Tromey  <tom@tromey.com>
6074
6075         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6076         type.  Remove no-argument constructor.
6077         <iterator::operator++>: Simplify.
6078         <begin>: Update.
6079         <end>: Use minimal_symbol_count.
6080
6081 2019-01-16  Tom Tromey  <tom@tromey.com>
6082
6083         * objfiles.h (struct objfile) <psymtabs>: New method.
6084         (class objfile_psymtabs): Remove.
6085         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6086         typedef.
6087         <range>: New method.
6088         (require_partial_symbols): Change return type.
6089         * psymtab.c (require_partial_symbols)
6090         (psym_expand_symtabs_matching): Update.
6091         * mdebugread.c (parse_partial_symbols): Update.
6092         * dbxread.c (dbx_end_psymtab): Update.
6093
6094 2019-01-15  Tom Tromey  <tom@tromey.com>
6095
6096         * symtab.c (lookup_objfile_from_block)
6097         (lookup_symbol_in_objfile_symtabs)
6098         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6099         (find_line_symtab, info_sources_command)
6100         (default_collect_symbol_completion_matches_break_on)
6101         (make_source_files_completion_list): Update.
6102         * symmisc.c (print_objfile_statistics, dump_objfile)
6103         (maintenance_print_symbols, maintenance_info_symtabs)
6104         (maintenance_check_symtabs, maintenance_info_line_tables):
6105         Update.
6106         * source.c (select_source_symtab)
6107         (forget_cached_source_info_for_objfile): Update.
6108         * objfiles.h (class objfile_compunits): Remove.
6109         (struct objfile) <compunits_range>: New typedef.
6110         (compunits): New method.
6111         * objfiles.c (objfile_relocate1): Update.
6112         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6113         * maint.c (count_symtabs_and_blocks): Update.
6114         * linespec.c (iterate_over_all_matching_symtabs): Update.
6115         * cp-support.c (add_symbol_overload_list_qualified): Update.
6116         * coffread.c (coff_symtab_read): Update.
6117         * ada-lang.c (add_nonlocal_symbols)
6118         (ada_collect_symbol_completion_matches)
6119         (ada_add_global_exceptions): Update.
6120
6121 2019-01-15  Tom Tromey  <tom@tromey.com>
6122
6123         * progspace.h (program_space) <objfiles_safe_range>: New
6124         typedef.
6125         <objfiles_safe>: New method.
6126         * objfiles.h (class all_objfiles_safe): Remove.
6127         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6128         * jit.c (jit_inferior_exit_hook): Update.
6129
6130 2019-01-17  Tom Tromey  <tom@tromey.com>
6131
6132         * progspace.h (program_space) <objfiles_range>: New typedef.
6133         <objfiles>: New method.
6134         <objfiles_head>: Rename from objfiles.
6135         (object_files): Update.
6136         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6137         * guile/scm-pretty-print.c
6138         (ppscm_find_pretty_printer_from_objfiles): Update.
6139         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6140         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6141         Update.
6142         * python/py-progspace.c (pspy_get_objfiles): Update.
6143         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6144         Update.
6145         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6146         (objfpy_lookup_objfile_by_build_id): Update.
6147         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6148         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6149         Update.
6150         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6151         (expand_symtab_containing_pc, lookup_objfile_from_block)
6152         (lookup_static_symbol, basic_lookup_transparent_type)
6153         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6154         (find_line_symtab, info_sources_command)
6155         (default_collect_symbol_completion_matches_break_on)
6156         (make_source_files_completion_list, find_main_name): Update.
6157         * symmisc.c (print_symbol_bcache_statistics)
6158         (print_objfile_statistics, maintenance_print_symbols)
6159         (maintenance_print_msymbols, maintenance_print_objfiles)
6160         (maintenance_info_symtabs, maintenance_check_symtabs)
6161         (maintenance_expand_symtabs, maintenance_info_line_tables):
6162         Update.
6163         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6164         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6165         (map_overlay_command, unmap_overlay_command)
6166         (simple_overlay_update, expand_symtabs_matching)
6167         (map_symbol_filenames): Update.
6168         * symfile-debug.c (set_debug_symfile): Update.
6169         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6170         Update.
6171         * source.c (select_source_symtab, forget_cached_source_info):
6172         Update.
6173         * solib.c (solib_read_symbols): Update.
6174         * solib-spu.c (append_ocl_sos): Update.
6175         * psymtab.c (maintenance_print_psymbols)
6176         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6177         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6178         * printcmd.c (info_symbol_command): Update.
6179         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6180         Update.
6181         * objfiles.h (class all_objfiles): Remove.
6182         * objfiles.c (have_partial_symbols, have_full_symbols)
6183         (have_minimal_symbols, qsort_cmp, update_section_map)
6184         (shared_objfile_contains_address_p)
6185         (default_iterate_over_objfiles_in_search_order): Update.
6186         * objc-lang.c (info_selectors_command, info_classes_command)
6187         (find_methods): Update.
6188         * minsyms.c (find_solib_trampoline_target): Update.
6189         * maint.c (maintenance_info_sections)
6190         (maintenance_translate_address, count_symtabs_and_blocks):
6191         Update.
6192         * main.c (captured_main_1): Update.
6193         * linux-thread-db.c (try_thread_db_load_from_pdir)
6194         (has_libpthread): Update.
6195         * linespec.c (iterate_over_all_matching_symtabs)
6196         (search_minsyms_for_name): Update.
6197         * jit.c (jit_find_objf_with_entry_addr): Update.
6198         * hppa-tdep.c (find_unwind_entry)
6199         (hppa_lookup_stub_minimal_symbol): Update.
6200         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6201         Update.
6202         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6203         (elf_gnu_ifunc_resolve_by_got): Update.
6204         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6205         * dwarf-index-write.c (save_gdb_index_command): Update.
6206         * cp-support.c (add_symbol_overload_list_qualified): Update.
6207         * breakpoint.c (create_overlay_event_breakpoint)
6208         (create_longjmp_master_breakpoint)
6209         (create_std_terminate_master_breakpoint)
6210         (create_exception_master_breakpoint): Update.
6211         * blockframe.c (find_pc_partial_function): Update.
6212         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6213         (ada_collect_symbol_completion_matches)
6214         (ada_add_global_exceptions): Update.
6215
6216 2019-01-17  Tom Tromey  <tom@tromey.com>
6217
6218         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6219         declare VEC.
6220         (solib_target_parse_libraries): Change return type.
6221         (library_list_start_segment, library_list_start_section)
6222         (library_list_end_library, library_list_start_library); Update.
6223         (solib_target_free_library_list): Remove.
6224         (solib_target_parse_libraries): Remove cleanup.  Change return
6225         type.
6226         (solib_target_current_sos): Update.
6227
6228 2019-01-17  Tom Tromey  <tromey@bapiya>
6229
6230         * valprint.c: Replace "the the" with "the".
6231         * symtab.c: Replace "the the" with "the".
6232         * solib.c: Replace "the the" with "the".
6233         * solib-dsbt.c: Replace "the the" with "the".
6234         * linespec.c: Replace "the the" with "the".
6235         * dwarf2loc.h: Replace "the the" with "the".
6236         * amd64-windows-tdep.c: Replace "the the" with "the".
6237         * aarch64-tdep.c: Replace "the the" with "the".
6238
6239 2019-01-16  Keith Seitz  <keiths@redhat.com>
6240
6241         PR gdb/23773
6242         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6243         <builder>: Rename to ..
6244         <m_builder>: ... this and make private.
6245         (dwarf2_cu::get_builder): New method.  Change all users of
6246         `builder' to use this method.
6247         (dwarf2_start_symtab): Move to ...
6248         (dwarf2_cu::start_symtab): ... here.  Update all callers
6249         (setup_type_unit_groups): Move to ...
6250         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6251         callers.
6252         (dwarf2_cu::reset_builder): New method.
6253         (process_full_compunit, process_full_type_unit): Use
6254         dwarf2_cu::reset_builder.
6255         (follow_die_offset): Record the ancestor CU if it is different
6256         from the followed DIE's CU.
6257         (follow_die_sig_1): Likewise.
6258
6259 2019-01-15  Tom Tromey  <tom@tromey.com>
6260
6261         * remote.c (class remote_state) <buf>: Now a char_vector.
6262         <buf_size>: Remove.
6263         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6264         parameter.
6265         (remote_target::getpkt_or_notif_sane_1)
6266         (remote_target::getpkt_sane)
6267         (remote_target::getpkt_or_notif_sane): Likewise.
6268         (class remote_target) <putpkt>: New overload.
6269         (remote_target::read_frame): Change type of "buf_p".  Remove
6270         sizeof_p parameter.
6271         (packet_ok): New overload.
6272         (packet_check_result): New overload.
6273         Update all uses.
6274
6275 2019-01-14  Tom Tromey  <tom@tromey.com>
6276
6277         * remote-notif.c (handle_notification, remote_notif_ack)
6278         (remote_notif_parse): Make "buf" const.
6279         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6280         const.
6281         (remote_notif_parse, remote_notif_ack, handle_notification):
6282         Likewise.
6283         * remote.c (remote_notif_stop_parse): Make "buf" const.
6284         (remote_target::remote_parse_stop_reply): Make "buf" const.
6285         (remote_notif_stop_ack): Make "buf" const.
6286
6287 2019-01-14  Tom Tromey  <tom@tromey.com>
6288
6289         * remote.c (remote_console_output): Make parameter const.
6290
6291 2019-01-14  Tom Tromey  <tom@tromey.com>
6292
6293         * target-debug.h (target_debug_print_signals): Constify.
6294         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6295         * procfs.c (procfs_target::pass_signals): Update.
6296         * linux-nat.c (linux_nat_target::pass_signals): Update.
6297         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6298         * target-delegates.c: Rebuild.
6299         * remote.c (remote_target::program_signals): Update.
6300         (remote_target::pass_signals): Update.
6301         * target.c (target_pass_signals): Constify argument.
6302         (target_program_signals): Likewise.
6303         * target.h (struct target_ops) <pass_signals, program_signals>:
6304         Constify argument.
6305         (target_pass_signals, target_program_signals): Constify argument.
6306
6307 2019-01-14  Tom Tromey  <tom@tromey.com>
6308
6309         PR tui/28819:
6310         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6311
6312 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6313
6314         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6315         field.
6316         * rs6000-tdep.c: Include reggroups.h.
6317         (IS_V_ALIAS_PSEUDOREG): Define.
6318         (rs6000_register_name): Return names for the "vX" aliases.
6319         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6320         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6321         aliases.  Call default_register_reggroup_p for all other
6322         pseudo-registers.
6323         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6324         New functions.
6325         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6326         Handle "vX" aliases.
6327         (v_alias_pseudo_register_collect): New function.
6328         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6329         (rs6000_gdbarch_init): Initialize "vX" aliases as
6330         pseudo-registers.  Restore registration of
6331         rs6000_pseudo_register_reggroup_p with
6332         set_tdesc_pseudo_register_reggroup_p.
6333
6334 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6335
6336         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6337         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6338         set_gdbarch_num_pseudo_regs.
6339
6340 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6341
6342         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6343         Remove arg prefixname, add do_set and do_show.
6344         Add member functions set_list and show_list.
6345         * cli/cli-style.c (class cli_style_option): Update accordingly.
6346         (style_set_list): Move to file scope.
6347         (style_show_list): Likewise.
6348         (set_style): Call help_list.
6349         (show_style): Call cmd_show_list.
6350         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6351         Update to use the new macro.
6352
6353 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6354
6355         * ada-lang.c (_initialize_ada_language): Expand the help text
6356         for the "catch exception" command.
6357
6358 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6359
6360         * symtab.c (matching_obj_sections): Initialize obj,
6361         declare it closer to its usage.
6362
6363 2019-01-10  Tom Tromey  <tom@tromey.com>
6364
6365         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6366         (basic_inf_threads_range): Remove.
6367         (inf_threads_range, inf_non_exited_threads_range)
6368         (safe_inf_threads_range): Use next_adapter.
6369
6370 2019-01-10  Keith Seitz  <keiths@redhat.com>
6371
6372         PR gdb/23712
6373         PR symtab/23010
6374         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6375         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6376
6377 2019-01-10  Keith Seitz  <keiths@redhat.com>
6378
6379         PR gdb/23712
6380         PR symtab/23010
6381         * dictionary.c (pending_to_vector): Remove.
6382         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6383         Remove _1 suffix, replacing functions of the same name.  Update
6384         all callers.
6385         (dict_create_hashed, dict_create_hashed_expandable)
6386         (dict_create_linear, dict_create_linear_expandable, dict_free)
6387         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6388         Make functions static.
6389
6390 2019-01-10  Keith Seitz  <keiths@redhat.com>
6391
6392         PR gdb/23712
6393         PR symtab/23010
6394         * dictionary.h (struct dictionary): Replace declaration with
6395         multidictionary.
6396         (dict_create_hashed, dict_create_hashed_expandable)
6397         (dict_create_linear, dict_create_linear_expandable)
6398         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6399         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6400         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6401         taking multidictionary argument.
6402         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6403         * block.h (struct block) <dict>: Change to multidictionary
6404         and rename `multidict'.
6405         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6406         symmisc.c: Update all dictionary references to multidictionary.
6407
6408 2019-01-10  Keith Seitz  <keiths@redhat.com>
6409
6410         PR gdb/23712
6411         PR symtab/23010
6412         * dictionary.c: Include unordered_map.
6413         (pending_to_vector): New function.
6414         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6415         Rewrite the non-"_1" functions to take vector instead
6416         of linked list.
6417         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6418         "new" _1 versions of the same name.
6419         (multidictionary): Define.
6420         (std::hash<enum language): New definition.
6421         (collate_pending_symbols_by_language, mdict_create_hashed)
6422         (mdict_create_hashed_expandable, mdict_create_linear)
6423         (mdict_create_linear_expandable, mdict_free)
6424         (find_language_dictionary, create_new_language_dictionary)
6425         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6426         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6427         (mdict_size, mdict_empty): New functions.
6428         * dictionary.h (mdict_iterator): Define.
6429
6430 2019-01-10  Pedro Alves  <palves@redhat.com>
6431
6432         * breakpoint.c (read_uploaded_action)
6433         (create_tracepoint_from_upload): Adjust to use
6434         gdb::unique_xmalloc_ptr.
6435         * ctf.c (ctf_write_uploaded_tp):
6436         (SET_ARRAY_FIELD): Use emplace_back.
6437         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6438         * tracefile-tfile.c (tfile_write_uploaded_tp):
6439         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6440         gdb::unique_xmalloc_ptr.
6441         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6442         at_string, cond_string, cmd_strings>: Replace char pointers
6443         with gdb::unique_xmalloc_ptr.
6444
6445 2019-01-10  Pedro Alves  <palves@redhat.com>
6446
6447         * solib-target.c (library_list_start_library): Don't xstrdup name.
6448
6449 2019-01-10  Pedro Alves  <palves@redhat.com>
6450
6451         * mdebugread.c (parse_partial_symbols): Use
6452         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6453
6454 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * linux-fork.c (scoped_switch_fork_info)
6457         <~scoped_switch_fork_info>: Fix incorrect variable name.
6458
6459 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * linux-fork.c (scoped_switch_fork_info)
6462         <scoped_switch_fork_info>: Make explicit.
6463         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6464
6465 2019-01-10  Tom Tromey  <tom@tromey.com>
6466
6467         * objfiles.h (objfile::reset_psymtabs): Update.
6468         * objfiles.c (objfile::objfile): Update.
6469         * psymtab.h (psymtab_storage::obstack): Update.
6470         (psymtab_storage::m_obstack): Use gdb::optional.
6471         (class psymtab_storage): Update comment.  Remove objfile
6472         parameter.
6473         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6474
6475 2019-01-10  Tom Tromey  <tom@tromey.com>
6476
6477         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6478         <free_psymtabs>: Now private.
6479         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6480         (allocate_psymtab): Use new method.
6481
6482 2019-01-10  Tom Tromey  <tom@tromey.com>
6483
6484         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6485         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6486         * mdebugread.c (parse_partial_symbols): Use
6487         allocate_dependencies.
6488         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6489         allocate_dependencies.
6490         (process_psymtab_comp_unit_reader)
6491         (build_type_psymtab_dependencies): Likewise.
6492         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6493
6494 2019-01-10  Tom Tromey  <tom@tromey.com>
6495
6496         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6497         PSYMBOL_SET_LANGUAGE.
6498         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6499
6500 2019-01-10  Tom Tromey  <tom@tromey.com>
6501
6502         * psymtab.h (psymtab_storage::obstack): New method.
6503         <m_obstack>: Rename from obstack; now private.
6504         * psymtab.c (psymtab_storage): Update.
6505         * dwarf2read.c (create_addrmap_from_index)
6506         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6507         Update.
6508
6509 2019-01-10  Tom Tromey  <tom@tromey.com>
6510
6511         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6512         * objfiles.h (objfile::reset_psymtabs): New method.
6513
6514 2019-01-10  Tom Tromey  <tom@tromey.com>
6515
6516         * symmisc.c (print_symbol_bcache_statistics): Update.
6517         (print_objfile_statistics): Update.
6518         * symfile.c (reread_symbols): Update.
6519         * psymtab.h (class psymtab_storage): New.
6520         * psymtab.c (psymtab_storage): New constructor.
6521         (~psymtab_storage): New destructor.
6522         (require_partial_symbols): Update.
6523         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6524         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6525         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6526         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6527         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6528         (start_psymtab_common, end_psymtab_common)
6529         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6530         (allocate_psymtab): Update.
6531         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6532         Update.
6533         (dump_psymtab_addrmap, maintenance_print_psymbols)
6534         (maintenance_check_psymtabs): Update.
6535         (class objfile_psymtabs): Move to objfiles.h.
6536         * psympriv.h (discard_psymtab): Now inline.
6537         (psymtab_discarder::psymtab_discarder): Update.
6538         (psymtab_discarder::~psymtab_discarder): Update.
6539         (ALL_OBJFILE_PSYMTABS): Rewrite.
6540         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6541         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6542         Remove fields.
6543         <partial_symtabs>: New field.
6544         (class objfile_psymtabs): Move from psymtab.h.  Update.
6545         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6546         psymbol_cache.
6547         (objfile::~objfile): Don't destroy psymbol_cache.
6548         * mdebugread.c (parse_partial_symbols): Update.
6549         * dwarf2read.c (create_addrmap_from_index)
6550         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6551         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6552         (add_partial_subprogram, dwarf2_ranges_read): Update.
6553         * dwarf-index-write.c (write_address_map)
6554         (write_one_signatured_type, recursively_write_psymbols)
6555         (class debug_names, class debug_names, write_psymtabs_to_index):
6556         Update.
6557
6558 2019-01-10  Tom Tromey  <tom@tromey.com>
6559
6560         * symtab.h (SYMBOL_SET_NAMES): Update.
6561         (symbol_set_names): Update.
6562         (MSYMBOL_SET_NAMES): Update.
6563         * symtab.c (symbol_set_names): Change argument to be an
6564         objfile_per_bfd_storage.
6565         * psymtab.c (add_psymbol_to_bcache): Update.
6566         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6567
6568 2019-01-10  Tom Tromey  <tom@tromey.com>
6569
6570         * symtab.c (create_demangled_names_hash): Change argument to be an
6571         objfile_per_bfd_storage.
6572         (symbol_set_names): Update.
6573
6574 2019-01-10  Tom Tromey  <tom@tromey.com>
6575
6576         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6577         init_psymbol_list.
6578         * psymtab.c (init_psymbol_list): Do nothing if already called.
6579         * psympriv.h (init_psymbol_list): Add comment.
6580         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6581         init_psymbol_list.
6582         * dbxread.c (dbx_symfile_read): Unconditionally call
6583         init_psymbol_list.
6584
6585 2019-01-10  Tom Tromey  <tom@tromey.com>
6586
6587         * xcoffread.c (scan_xcoff_symtab): Update.
6588         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6589         "where".
6590         * mdebugread.c (parse_partial_symbols)
6591         (handle_psymbol_enumerators): Update.
6592         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6593         * dbxread.c (read_dbx_symtab): Update.
6594         * psympriv.h (psymbol_placement): New enum.
6595         (add_psymbol_to_list): Update.
6596
6597 2019-01-10  Tom Tromey  <tom@tromey.com>
6598
6599         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6600         static_psymbols parameters.
6601         (scan_xcoff_symtab): Update.
6602         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6603         static_psymbols parameters.
6604         * psympriv.h (start_psymtab_common): Update.
6605         * mdebugread.c (parse_partial_symbols): Update.
6606         * dwarf2read.c (create_partial_symtab): Update.
6607         * dbxread.c (read_dbx_symtab): Update.
6608         (start_psymtab): Remove global_psymbols and static_psymbols
6609         parameters.
6610
6611 2019-01-10  Tom Tromey  <tom@tromey.com>
6612
6613         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6614         * psymtab.c (allocate_psymtab): Add comment.
6615         * psympriv.h (allocate_psymtab): Add comment.
6616         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6617         initializations.
6618         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6619
6620 2019-01-10  Tom Tromey  <tom@tromey.com>
6621
6622         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6623         Don't declare.
6624         * mipsread.c: Include mdebugread.h.
6625         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6626         Declare.
6627         * elfread.c: Include mdebugread.h.
6628
6629 2019-01-09  Tom Tromey  <tom@tromey.com>
6630
6631         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6632         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6633         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6634         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6635         (psym_lookup_symbol, psym_find_last_source_symtab)
6636         (psym_forget_cached_source_info, psym_print_stats)
6637         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6638         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6639         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6640         (psym_find_compunit_symtab_by_address)
6641         (maintenance_print_psymbols, maintenance_info_psymtabs)
6642         (maintenance_check_psymtabs): Use ranged for.
6643         * psymtab.h (class objfile_psymtabs): New.
6644         (require_partial_symbols): Return objfile_psymtabs.
6645         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6646
6647 2019-01-09  Tom Tromey  <tom@tromey.com>
6648
6649         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6650         (find_pc_mapped_section, list_overlays_command)
6651         (map_overlay_command, unmap_overlay_command)
6652         (simple_overlay_update): Use all_objfiles.
6653         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6654         * printcmd.c (info_symbol_command): Use all_objfiles.
6655         * objfiles.h (ALL_OBJSECTIONS): Remove.
6656         * maint.c (maintenance_translate_address): Use all_objfiles.
6657         * gcore.c (gcore_create_callback): Use all_objfiles.
6658         (objfile_find_memory_regions): Likewise.
6659
6660 2019-01-09  Tom Tromey  <tom@tromey.com>
6661
6662         * symtab.c (find_line_symtab, info_sources_command)
6663         (make_source_files_completion_list): Use objfile_compunits.
6664         * source.c (select_source_symtab): Use objfile_compunits.
6665         * objfiles.h (struct objfile): Update comment.
6666         (ALL_OBJFILES): Remove.
6667         (ALL_FILETABS): Remove.
6668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6669         objfile_compunits.
6670
6671 2019-01-09  Tom Tromey  <tom@tromey.com>
6672
6673         * symmisc.c (print_objfile_statistics, dump_objfile)
6674         (maintenance_print_symbols): Use compunit_filetabs.
6675         * source.c (forget_cached_source_info_for_objfile): Use
6676         compunit_filetabs.
6677         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6678         (ALL_FILETABS): Use compunit_filetabs.
6679         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6680         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6681
6682 2019-01-09  Tom Tromey  <tom@tromey.com>
6683
6684         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6685         (compunit_filetabs): New.
6686         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6687         compunit_filetabs.
6688         (info_sources_command, make_source_files_completion_list): Remove
6689         declaration.
6690         * symmisc.c (print_objfile_statistics, dump_objfile)
6691         (maintenance_print_symbols): Remove declaration.
6692         (maintenance_info_symtabs): Use compunit_filetabs.
6693         (maintenance_info_line_tables): Likewise.
6694         * source.c (select_source_symtab): Change local variable name.
6695         (forget_cached_source_info_for_objfile): Remove declaration.
6696         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6697         * objfiles.c (objfile_relocate1): Remove declaration.
6698         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6699         declaration.
6700         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6701         * coffread.c (coff_symtab_read): Remove declaration.
6702         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6703         compunit_filetabs.
6704
6705 2019-01-09  Tom Tromey  <tom@tromey.com>
6706
6707         * symtab.c (lookup_objfile_from_block)
6708         (find_pc_sect_compunit_symtab, search_symbols)
6709         (default_collect_symbol_completion_matches_break_on): Use
6710         objfile_compunits.
6711         * objfiles.h (ALL_COMPUNITS): Remove.
6712         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6713         * cp-support.c (add_symbol_overload_list_qualified): Use
6714         objfile_compunits.
6715         * ada-lang.c (ada_collect_symbol_completion_matches)
6716         (ada_add_global_exceptions): Use objfile_compunits.
6717
6718 2019-01-09  Tom Tromey  <tom@tromey.com>
6719
6720         * source.c (select_source_symtab)
6721         (forget_cached_source_info_for_objfile): Remove declaration.
6722         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6723         declaration.
6724         * maint.c (count_symtabs_and_blocks): Remove declaration.
6725         * cp-support.c (add_symbol_overload_list_qualified): Remove
6726         declaration.
6727         * coffread.c (coff_symtab_read): Remove declaration.
6728         * symtab.c (lookup_symbol_in_objfile_symtabs)
6729         (basic_lookup_transparent_type_1): Use objfile_compunits.
6730         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6731         (info_sources_command, search_symbols)
6732         (default_collect_symbol_completion_matches_break_on)
6733         (make_source_files_completion_list): Remove declaration.
6734         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6735         (ada_collect_symbol_completion_matches)
6736         (ada_add_global_exceptions): Remove declaration.
6737         * linespec.c (iterate_over_all_matching_symtabs): Use
6738         objfile_compunits.
6739         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6740         (class objfile_compunits): New.
6741         (ALL_COMPUNITS): Use objfile_compunits.
6742         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6743         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6744         objfile_compunits.
6745         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6746
6747 2019-01-09  Tom Tromey  <tom@tromey.com>
6748
6749         * symtab.c (search_symbols)
6750         (default_collect_symbol_completion_matches_break_on): Use
6751         objfile_msymbols.
6752         * ada-lang.c (ada_lookup_simple_minsym)
6753         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6754         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6755         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6756         objfile_msymbols.
6757         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6758         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6759         * objc-lang.c (find_methods): Use objfile_msymbols.
6760         (info_selectors_command, info_classes_command): Likewise.
6761         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6762         * objfiles.h (class objfile_msymbols): New.
6763         (ALL_OBJFILE_MSYMBOLS): Remove.
6764         (ALL_MSYMBOLS): Remove.
6765
6766 2019-01-09  Tom Tromey  <tom@tromey.com>
6767
6768         * common/next-iterator.h (next_adapter): Add Iterator template
6769         parameter.
6770         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6771         (class all_objfiles_safe): New.
6772         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6773         * objfiles.c (put_objfile_before): Update comment.
6774         (add_separate_debug_objfile): Likewise.
6775         (free_all_objfiles): Use all_objfiles_safe.
6776         (objfile_purge_solibs): Likewise.
6777
6778 2019-01-09  Tom Tromey  <tom@tromey.com>
6779
6780         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6781         (expand_symtab_containing_pc, lookup_static_symbol)
6782         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6783         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6784         all_objfiles.
6785         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6786         * breakpoint.c (create_overlay_event_breakpoint)
6787         (create_longjmp_master_breakpoint)
6788         (create_std_terminate_master_breakpoint)
6789         (create_exception_master_breakpoint): Use all_objfiles.
6790         * linux-thread-db.c (try_thread_db_load_from_pdir)
6791         (has_libpthread): Use all_objfiles.
6792         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6793         * linespec.c (iterate_over_all_matching_symtabs)
6794         (search_minsyms_for_name): Use all_objfiles.
6795         * maint.c (maintenance_info_sections): Use all_objfiles.
6796         * main.c (captured_main_1): Use all_objfiles.
6797         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6798         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6799         * guile/scm-pretty-print.c
6800         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6801         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6802         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6803         (maintenance_print_msymbols): Use all_objfiles.
6804         * source.c (select_source_symtab): Use all_objfiles.
6805         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6806         * symfile.c (remove_symbol_file_command)
6807         (expand_symtabs_matching, map_symbol_filenames): Use
6808         all_objfiles.
6809         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6810         all_objfiles.
6811         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6812         * objc-lang.c (find_methods): Use all_objfiles.
6813         * objfiles.c (have_partial_symbols, have_full_symbols)
6814         (have_minimal_symbols, qsort_cmp)
6815         (default_iterate_over_objfiles_in_search_order): Use
6816         all_objfiles.
6817         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6818         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6819         (maintenance_check_psymtabs): Use all_objfiles.
6820         (ALL_PSYMTABS): Remove.
6821         * compile/compile-object-run.c (do_module_cleanup): Use
6822         all_objfiles.
6823         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6824         * cp-support.c (add_symbol_overload_list_qualified): Use
6825         all_objfiles.
6826         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6827         Use all_objfiles.
6828         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6829         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6830         all_objfiles.
6831         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6832         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6833         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6834         Uses all_objfiles.
6835         * solib.c (solib_read_symbols): Use all_objfiles
6836
6837 2019-01-09  Tom Tromey  <tom@tromey.com>
6838
6839         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6840         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6841         all_objfiles.
6842         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6843         * symmisc.c (print_symbol_bcache_statistics)
6844         (print_objfile_statistics, maintenance_print_objfiles)
6845         (maintenance_info_symtabs, maintenance_check_symtabs)
6846         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6847         all_objfiles.
6848         * source.c (forget_cached_source_info): Use all_objfiles.
6849         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6850         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6851         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6852         * objfiles.c (update_section_map): Use all_objfiles.
6853         (shared_objfile_contains_address_p): Likewise.
6854         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6855         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6856
6857 2019-01-09  Tom Tromey  <tom@tromey.com>
6858
6859         * common/next-iterator.h: New file.
6860         * objfiles.h (class all_objfiles): New.
6861         (struct objfile_iterator): New.
6862
6863 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6864
6865         * NEWS: Move the description of the changed "frame", "select-frame",
6866          and "info frame" commands to the Changed commands section.
6867
6868 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6869
6870         * gdbtypes.c (check_stub_method_group): Remove handling of old
6871         mangling schemes.
6872         * linespec.c (find_methods): Likewise.
6873         * stabsread.c (read_member_functions): Likewise.
6874         * valops.c (search_struct_method): Likewise.
6875         (value_struct_elt_for_reference): Likewise.
6876         * NEWS: Mention this change.
6877
6878 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6881         print_source_lines.
6882         * source.c (print_source_lines_base): Update line number check.
6883         (print_source_lines): New function.
6884         (source_lines_range::source_lines_range): New function.
6885         * source.h (class source_lines_range): New class.
6886         (print_source_lines): New declaration.
6887
6888 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6889
6890         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6891
6892 2019-01-08  Tom Tromey  <tom@tromey.com>
6893             Simon Marchi  <simon.marchi@ericsson.com>
6894
6895         PR gdb/24060
6896         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6897         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6898         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6899         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6900         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6901         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6902
6903 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6904
6905         * source.c (select_source_symtab): Move header comment to
6906         declaration in source.h.
6907         (forget_cached_source_info_for_objfile): Likewise.
6908         (forget_cached_source_info): Likewise.
6909         (identify_source_line): Likewise.
6910         * source.h (identify_source_line): Move declaration from symtab.h
6911         and add comment from source.c
6912         (print_source_lines): Likewise.
6913         (forget_cached_source_info_for_objfile): Likewise.
6914         (forget_cached_source_info): Likewise.
6915         (select_source_symtab): Likewise.
6916         (enum print_source_lines_flag): Move definition from symtab.h.
6917         * symtab.h (identify_source_line): Move declaration to source.h.
6918         (print_source_lines): Likewise.
6919         (forget_cached_source_info_for_objfile): Likewise.
6920         (forget_cached_source_info): Likewise.
6921         (select_source_symtab): Likewise.
6922         (enum print_source_lines_flag): Move definition to source.h.
6923         * tui/tui-hooks.c: Add 'source.h' include.
6924
6925 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * source.c (print_source_lines_base): Handle requests to print
6928         reverse line number sequences, and guard against empty lines
6929         string.
6930
6931 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * source.c (print_source_lines_base): Fix skip of '\r' if next
6934         character is '\n'.
6935
6936 2019-01-06  Tom Tromey  <tom@tromey.com>
6937
6938         * c-exp.y (struct c_parse_state) <macro_original_text,
6939         expansion_obstack>: New member.
6940         (macro_original_text, expansion_obstack): Remove globals.
6941         (scan_macro_expansion, scanning_macro_expansion)
6942         (finished_macro_expansion): Update.
6943         (scan_macro_cleanup): Remove.
6944         (yylex, c_parse): Update.
6945
6946 2019-01-06  Tom Tromey  <tom@tromey.com>
6947
6948         * c-exp.y (struct c_parse_state) <strings>: New member.
6949         (operator_stoken): Update.
6950
6951 2019-01-06  Tom Tromey  <tom@tromey.com>
6952
6953         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6954         (union type_stack_elt) <typelist_val>: Now a pointer to
6955         std::vector.
6956         (type_stack_cleanup): Don't declare.
6957         (push_typelist): Update.
6958         * parse.c (pop_typelist): Return a std::vector.
6959         (push_typelist): Take a std::vector.
6960         (follow_types): Update.  Do not free args.
6961         (type_stack_cleanup): Remove.
6962         * c-exp.y (struct c_parse_state): New.
6963         (cpstate): New global.
6964         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6965         (nonempty_typelist): Update.
6966         (func_mod): Create a new vector.
6967         (c_parse): Create a c_parse_state.
6968         (check_parameter_typelist): Do not delete params.
6969         (function_method): Update.  Do not delete type_list.
6970
6971 2019-01-06  Tom Tromey  <tom@tromey.com>
6972
6973         PR gdb/28155:
6974         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6975         check_typedef.
6976         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6977         (print_return_value): Likewise.
6978
6979 2019-01-05  Tom Tromey  <tom@tromey.com>
6980
6981         * contrib/cleanup_check.py: Remove.
6982         * contrib/gcc-with-excheck: Remove.
6983         * contrib/exsummary.py: Remove.
6984         * contrib/excheck.py: Remove.
6985
6986 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6987
6988         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6989         NULL. Initialize tpprev to NULL instead of assigning it
6990         to NULL on the next statement.
6991         * windows-nat.c (windows_delete_thread): Remove check for
6992         main_thread_id before printing thread exit notifications.
6993         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6994         Remove thread ID check against main_thread_id.
6995         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6996         windows_delete_thread.
6997         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6998
6999 2019-01-04  Tom Tromey  <tom@tromey.com>
7000
7001         * compile/compile.c (_initialize_compile): Use upper case for
7002         metasyntactic variables.
7003         * symmisc.c (_initialize_symmisc): Use upper case for
7004         metasyntactic variables.
7005         * psymtab.c (_initialize_psymtab): Use upper case for
7006         metasyntactic variables.
7007         * demangle.c (demangle_command): Use upper case for metasyntactic
7008         variables.
7009         (_initialize_demangler): Likewise.
7010         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7011         variables.
7012
7013 2019-01-03  Tom Tromey  <tom@tromey.com>
7014
7015         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7016
7017 2019-01-03  Tom Tromey  <tom@tromey.com>
7018
7019         * python/py-symtab.c (salpy_str): Update.
7020         (struct salpy_sal_object) <symtab>: Now a PyObject.
7021         (salpy_dealloc): Update.
7022         (del_objfile_sal): Use gdbpy_ref.
7023
7024 2019-01-03  Tom Tromey  <tom@tromey.com>
7025
7026         * python/py-type.c (convert_field): Use new_reference.  Return
7027         gdbpy_ref.
7028         (make_fielditem): Return gdbpy_ref.
7029         (typy_fields): Update.
7030         (typy_getitem): Update.
7031         (field_name): Return gdbpy_ref.  Use new_reference.
7032         (typy_iterator_iternext): Update.
7033
7034 2019-01-03  Tom Tromey  <tom@tromey.com>
7035
7036         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7037
7038 2019-01-03  Tom Tromey  <tom@tromey.com>
7039
7040         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7041         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7042         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7043         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7044         (pspy_set_type_printers): Likewise.
7045         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7046         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7047         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7048         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7049         (objfpy_set_type_printers): Likewise.
7050
7051 2019-01-03  Tom Tromey  <tom@tromey.com>
7052
7053         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7054         (gdbpy_print_stack): Use gdbpy_err_fetch.
7055         * python/python-internal.h (class gdbpy_err_fetch): New class.
7056         (class gdbpy_enter) <m_error_type, m_error_value,
7057         m_error_traceback>: Remove.
7058         <m_error>: New member.
7059         (gdbpy_exception_to_string): Don't declare.
7060         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7061         * python/py-value.c (convert_value_from_python): Use
7062         gdbpy_err_fetch.
7063         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7064         gdbpy_exception_to_string.
7065         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7066         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7067         gdbpy_err_fetch.
7068
7069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7070
7071         * linux-nat.c (delete_lwp_cleanup): Delete.
7072         (struct lwp_deleter): New struct.
7073         (lwp_info_up): New typedef.
7074         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7075         lwp_info_up.
7076
7077 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * linux-fork.c (class scoped_switch_fork_info): New class.
7080         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7081
7082 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7083
7084         * valops.c (find_overload_match): Remove use of null_cleanup, and
7085         calls to do_cleanups.
7086
7087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7088
7089         * compile/compile-cplus-types.c
7090         (compile_cplus_instance::decl_name): Handle changes to
7091         cp_func_name.
7092         * cp-support.c (cp_func_name): Update header comment, update
7093         return type.
7094         * cp-support.h (cp_func_name): Update return type in declaration.
7095         * valops.c (find_overload_match): Move temp_func local to top
7096         level of function and change its type.  Use temp_func to hold and
7097         delete temporary string obtained from cp_func_name.
7098
7099 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7100
7101         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7102         gdb::char_vector, remove cleanup, and update uses of `msg`.
7103
7104 2019-01-03  Jim Wilson  <jimw@sifive.com>
7105
7106         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7107
7108 2019-01-02  Tom Tromey  <tom@tromey.com>
7109
7110         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7111         (tdesc_parse_xml): Remove cleanups.
7112         * target-descriptions.h (make_cleanup_free_target_description):
7113         Don't declare.
7114         (target_desc_deleter): New struct.
7115         (target_desc_up): New typedef.
7116         * target-descriptions.c (target_desc_deleter::operator()): Rename
7117         from free_target_description.
7118         (make_cleanup_free_target_description): Remove.
7119
7120 2019-01-02  Tom Tromey  <tom@tromey.com>
7121
7122         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7123         constructor, destructor.
7124         (linespec_parser): Remove typedef.
7125         (~linespec_parser): Rename from linespec_parser_delete.
7126         (linespec_lex_to_end, linespec_complete_label)
7127         (linespec_complete): Update.
7128         (decode_line_full): Remove cleanups.
7129         (decode_line_1): Update.
7130
7131 2019-01-02  Tom Tromey  <tom@tromey.com>
7132
7133         * python/python-internal.h (inferior_to_inferior_object): Change
7134         return type.
7135         * python/py-exitedevent.c (create_exited_event_object): Update.
7136         * python/py-inferior.c (inferior_to_inferior_object): Return
7137         gdbpy_ref.
7138         (python_new_inferior, python_inferior_deleted)
7139         (thread_to_thread_object, delete_thread_object)
7140         (build_inferior_list, gdbpy_selected_inferior): Update.
7141         * python/py-infthread.c (create_thread_object): Update.  Also fail
7142         if inferior_to_inferior_object fails.
7143
7144 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7145
7146         * inferior.h (class inferior) <displaced_step_state>: New field.
7147         * infrun.h (struct displaced_step_state): Move here from
7148         infrun.c.  Initialize fields, add constructor.
7149         <inf>: Remove field.
7150         <reset>: New method.
7151         * infrun.c (struct displaced_step_inferior_state): Move to
7152         infrun.h.
7153         (displaced_step_inferior_states): Remove.
7154         (get_displaced_stepping_state): Adust.
7155         (displaced_step_in_progress_any_inferior): Adjust.
7156         (displaced_step_in_progress_thread): Adjust.
7157         (displaced_step_in_progress): Adjust.
7158         (add_displaced_stepping_state): Remove.
7159         (get_displaced_step_closure_by_addr): Adjust.
7160         (remove_displaced_stepping_state): Remove.
7161         (infrun_inferior_exit): Call displaced_step_state.reset.
7162         (use_displaced_stepping): Don't check for NULL.
7163         (displaced_step_prepare_throw): Call
7164         get_displaced_stepping_state.
7165         (displaced_step_fixup): Don't check for NULL.
7166         (prepare_for_detach): Don't check for NULL.
7167
7168 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7169
7170         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7171          in case of call that did not complete.
7172
7173 2019-01-02  Andrey Utkin  <autkin@undo.io>
7174
7175         * symfile.c (find_separate_debug_file): Fix search of debug files for
7176         remote debuggee.
7177
7178 2019-01-02  Tom Tromey  <tom@tromey.com>
7179
7180         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7181         indentation.
7182         * python/py-frame.c (frapy_older): Remove cast.
7183         (frapy_newer): Likewise.
7184         * python/py-breakpoint.c (local_setattro): Remove cast.
7185         * python/py-arch.c (archpy_name): Remove local variable.
7186         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7187
7188 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7189
7190         * unittests/basic_string_view/element_access/char/empty.cc:
7191         Fix year range in copyright header.
7192
7193 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7196         Delete.
7197         <operator==>: Update with for removed field.
7198         <hash>: Likewise.
7199         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7200         <isa_features>: ...this.
7201         <abi_features>: New field.
7202         (riscv_isa_flen): Update comment.
7203         (riscv_abi_xlen): New declaration.
7204         (riscv_abi_flen): New declaration.
7205         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7206         isa_features.
7207         (riscv_abi_xlen): New function.
7208         (riscv_isa_flen): Update to get answer from isa_features.
7209         (riscv_abi_flen): New function.
7210         (riscv_has_fp_abi): Update to get answer from abi_features.
7211         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7212         xlen and flen.
7213         (riscv_call_info) <xlen, flen>: Update comment.
7214         (riscv_call_arg_struct): Remove invalid assertions
7215         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7216         is removed.
7217         (riscv_gdbarch_init): Gather isa features and abi features
7218         separately, ensure both match on the gdbarch when reusing an old
7219         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7220         a target with 64-bit float hardware.
7221
7222 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7223
7224         * source.c (search_command_helper): Stop reverse search
7225         when line 1 has been searched.
7226
7227 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7228
7229         * record-full.c (record_full_base_target::close): Rewrite
7230         record_full_core_buf_list free logic.
7231
7232 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7233
7234         * break-catch-syscall.c (print_one_catch_syscall): xfree
7235         the last text.
7236
7237 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7238
7239         * top.c (print_gdb_version): Update Copyright year in version
7240         message.
7241
7242 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7243
7244         Update copyright year range in all GDB files.
7245
7246 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7247
7248         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7249
7250 For older changes see ChangeLog-2018.
7251 \f
7252 Local Variables:
7253 mode: change-log
7254 left-margin: 8
7255 fill-column: 74
7256 version-control: never
7257 coding: utf-8
7258 End:
7259