gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * auxv.c (auxv_inferior_data): Move.  Change type.
   4         (auxv_inferior_data_cleanup): Remove.
   5         (invalidate_auxv_cache_inf): Rewrite.
   6         (get_auxv_inferior_data, _initialize_auxv): Update.
   7
   8 2019-05-08  Tom Tromey  <tom@tromey.com>
   9
  10         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
  11         (symfile_debug_objfile_data_key): Change type.
  12         (symfile_debug_installed, debug_qf_has_symbols)
  13         (debug_qf_find_last_source_symtab)
  14         (debug_qf_forget_cached_source_info)
  15         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
  16         (debug_qf_print_stats, debug_qf_dump)
  17         (debug_qf_expand_symtabs_for_function)
  18         (debug_qf_expand_all_symtabs)
  19         (debug_qf_expand_symtabs_with_fullname)
  20         (debug_qf_map_matching_symbols)
  21         (debug_qf_expand_symtabs_matching)
  22         (debug_qf_find_pc_sect_compunit_symtab)
  23         (debug_qf_map_symbol_filenames)
  24         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
  25         (debug_sym_new_init, debug_sym_init, debug_sym_read)
  26         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
  27         (debug_sym_read_linetable, debug_sym_relocate): Update.
  28         (symfile_debug_free_objfile): Remove.
  29         (install_symfile_debug_logging, _initialize_symfile_debug):
  30         Update.
  31
  32 2019-05-08  Tom Tromey  <tom@tromey.com>
  33
  34         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
  35         allocate_on_obstack.
  36         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
  37         (get_dwarf2_per_objfile): Update.
  38         (set_dwarf2_per_objfile): Remove.
  39         (dwarf2_has_info, dwarf2_get_section_info): Update.
  40         (dwarf2_free_objfile): Remove.
  41         (_initialize_dwarf2_read): Update.
  42
  43 2019-05-08  Tom Tromey  <tom@tromey.com>
  44
  45         * auto-load.c (struct auto_load_pspace_info): Add destructor and
  46         initializers.
  47         <unsupported_script_warning_printed,
  48         script_not_found_warning_printed>: Now bool.
  49         (auto_load_pspace_data): Change type.
  50         (~auto_load_pspace_info): Rename from
  51         auto_load_pspace_data_cleanup.
  52         (get_auto_load_pspace_data, init_loaded_scripts_info)
  53         (clear_section_scripts, maybe_print_unsupported_script_warning)
  54         (maybe_print_script_not_found_warning, _initialize_auto_load):
  55         Update.
  56
  57 2019-05-08  Tom Tromey  <tom@tromey.com>
  58
  59         * objfiles.c (objfile_pspace_info): Add destructor and
  60         initializers.
  61         (objfiles_pspace_data): Change type.
  62         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
  63         (get_objfile_pspace_data): Update.
  64         (objfiles_bfd_data): Change type.
  65         (get_objfile_bfd_data): Update.
  66         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  67
  68 2019-05-08  Tom Tromey  <tom@tromey.com>
  69
  70         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  71         Change type.
  72         (get_catch_syscall_inferior_data): Update.
  73         (catch_syscall_inferior_data_cleanup): Remove.
  74         (_initialize_break_catch_syscall): Update.
  75
  76 2019-05-08  Tom Tromey  <tom@tromey.com>
  77
  78         * inflow.c (struct terminal_info): Add destructor and
  79         initializers.
  80         (inflow_inferior_data): Change type.
  81         (~terminal_info): Rename from inflow_inferior_data_cleanup.
  82         (get_inflow_inferior_data, inflow_inferior_exit)
  83         (swap_terminal_info, _initialize_inflow): Update.
  84
  85 2019-05-08  Tom Tromey  <tom@tromey.com>
  86
  87         * target-dcache.c (target_dcache_cleanup): Remove.
  88         (target_dcache_aspace_key): Change type.
  89         (target_dcache_init_p, target_dcache_invalidate)
  90         (target_dcache_get, target_dcache_get_or_init)
  91         (_initialize_target_dcache): Update.
  92         * dcache.h (struct dcache_deleter): New.
  93
  94 2019-05-08  Tom Tromey  <tom@tromey.com>
  95
  96         * symtab.c (struct symbol_cache): Add destructor and
  97         initializers.
  98         (symbol_cache_key): Move.  Change type.
  99         (make_symbol_cache, free_symbol_cache): Remove.
 100         (get_symbol_cache): Update.
 101         (symbol_cache_cleanup): Remove.
 102         (ALL_PSPACES, symbol_cache_flush)
 103         (maintenance_print_symbol_cache)
 104         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 105         Update.
 106
 107 2019-05-08  Tom Tromey  <tom@tromey.com>
 108
 109         * symtab.c (struct main_info): Add destructor and initializers.
 110         (main_progspace_key): Move.  Change type.
 111         (get_main_info): Update.
 112         (main_info_cleanup): Remove.
 113         (_initialize_symtab): Update.
 114
 115 2019-05-08  Tom Tromey  <tom@tromey.com>
 116
 117         * registry.h (DECLARE_REGISTRY): Define the _key class.
 118
 119 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 120
 121         * NEWS: Merge two 'New commands' sections.
 122
 123 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 124
 125         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 126         parameter and use Ada language definition instead.
 127         (ada_val_print_ptr): Remove unused language parameter.
 128         (ada_val_print_num): Remove language parameter and use Ada language
 129         definition instead.
 130         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 131         parameter.
 132         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 133         parameter and use Ada language definition instead.
 134         (ada_val_print_1): Update all ada_val_print_xxx calls.
 135         Remove language parameter.
 136         (ada_val_print): Update ada_val_print_1 call.
 137
 138 2019-05-08  Tom Tromey  <tromey@adacore.com>
 139
 140         * remote.c (remote_hw_watchpoint_limit)
 141         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 142         Now static.
 143
 144 2019-05-08  Tom Tromey  <tromey@adacore.com>
 145
 146         * maint.c (_initialize_maint_cmds): Move initialization code to
 147         remote.c.
 148         (watchdog, show_watchdog): Move to remote.c.
 149         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 150         "watchdog" static.
 151         (_initialize_remote): Move initialization code from maint.c.
 152         * defs.h (watchdog): Don't declare.
 153
 154 2019-05-08  Tom Tromey  <tromey@adacore.com>
 155
 156         * tui/tui-interp.c: Include main.h.
 157         * interps.c: Include main.h.
 158         * main.h (interpreter_p): Declare.
 159         * defs.h (interpreter_p): Don't declare.
 160
 161 2019-05-08  Tom Tromey  <tromey@adacore.com>
 162
 163         * dwarf2loc.c: Include dwarf2read.h.
 164         * defs.h (read_unsigned_leb128): Don't declare.
 165         * dwarf2read.h (read_unsigned_leb128): Declare.
 166
 167 2019-05-08  Tom Tromey  <tromey@adacore.com>
 168
 169         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 170         method.
 171
 172 2019-05-08  Tom Tromey  <tromey@adacore.com>
 173
 174         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 175         when no wrap column is set.
 176
 177 2019-05-08  Tom Tromey  <tromey@adacore.com>
 178
 179         * c-lang.c (c_get_string): Handle non-C-style arrays.
 180
 181 2019-05-08  Tom Tromey  <tromey@adacore.com>
 182
 183         * typeprint.c (print_offset_data::update): Print the bit offset,
 184         not the number of bits remaining.
 185
 186 2019-05-08  Tom Tromey  <tromey@adacore.com>
 187
 188         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 189         padding at end of comment.
 190
 191 2019-05-08  Tom Tromey  <tromey@adacore.com>
 192
 193         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 194         Compare main types.
 195
 196 2019-05-06  Tom Tromey  <tom@tromey.com>
 197
 198         * common/scoped_mmap.c: Include common-defs.h.
 199         * common/scoped_mmap.h: Don't include config.h.
 200
 201 2019-05-04  Tom Tromey  <tom@tromey.com>
 202
 203         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 204         (struct aarch64_call_info): Add initializers.
 205         <si>: Now a std::vector.
 206         (pass_on_stack, aarch64_push_dummy_call): Update.
 207
 208 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 209             Tom Tromey  <tom@tromey.com>
 210
 211         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 212         (ppc_threads): Now a std::vector.  Now static.
 213         (hwdebug_find_thread_points_by_tid)
 214         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 215         Update.
 216
 217 2019-05-04  Tom Tromey  <tom@tromey.com>
 218
 219         * arc-tdep.c (arc_tdesc_init): Return bool.
 220
 221 2019-05-04  Tom Tromey  <tom@tromey.com>
 222
 223         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 224         Use gdb_assert_not_reached.
 225
 226 2019-05-04  Tom Tromey  <tom@tromey.com>
 227
 228         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 229         "false".
 230
 231 2019-05-04  Tom Tromey  <tom@tromey.com>
 232
 233         * arc-tdep.c (arc_tdesc_init): Use bool.
 234
 235 2019-05-04  Tom Tromey  <tom@tromey.com>
 236
 237         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 238
 239 2019-05-04  Tom Tromey  <tom@tromey.com>
 240
 241         * cli/cli-cmds.c (valid_command_p): Return bool.
 242
 243 2019-05-04  Tom Tromey  <tom@tromey.com>
 244
 245         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 246         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 247
 248 2019-05-04  Raul Tambre  <raul@tambre.ee>
 249
 250         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 251         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 252         operator for comparison.
 253
 254 2019-05-04  Tom Tromey  <tom@tromey.com>
 255
 256         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 257         (lookup_partial_symbol, print_partial_symbols)
 258         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 259         (psymbol_compare): Update.
 260         (add_psymbol_to_bcache): Clear the entire psymbol.
 261         (maintenance_check_psymtabs): Update.
 262         * psympriv.h (struct partial_symbol): Don't derive from
 263         general_symbol_info.
 264         <obj_section, unrelocated_address, address,
 265         set_unrelocated_address>: Update.
 266         <ginfo>: New member.
 267         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 268         (debug_names::write_psymbols): Update.
 269
 270 2019-05-04  Tom de Vries  <tdevries@suse.de>
 271
 272         * contrib/cc-with-tweaks.sh: Support -n arg.
 273
 274 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 275
 276         * corelow.c (core_target::detach): Ensure frame cache and
 277         register caches are cleared.
 278         inferior.c (exit_inferior_1): Likewise.
 279
 280 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 281             Tom Tromey  <tom@tromey.com>
 282
 283         * dictionary.c (collate_pending_symbols_by_language): Remove
 284         "struct" from foreach.
 285         * symtab.c (lookup_global_symbol_from_objfile)
 286         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 287         foreach.
 288         * ser-tcp.c (net_open): Remove "struct" from foreach.
 289         * objfiles.c (objfile_relocate, objfile_rebase)
 290         (objfile_has_symbols): Remove "struct" from foreach.
 291         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 292         from foreach.
 293         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 294         foreach.
 295         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 296         "struct" from foreach.
 297         * ada-lang.c (create_excep_cond_exprs)
 298         (ada_exception_catchpoint_cond_string): Remove "struct" from
 299         foreach.
 300
 301 2019-05-03  Tom Tromey  <tromey@adacore.com>
 302
 303         * ada-exp.y (convert_char_literal): Check suffix of each
 304         enumerator.
 305
 306 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 307
 308         PR ada/21406:
 309         * ada-exp.y (yywrap): Don't define.
 310         * ada-lex.l (%option): Add noyywrap
 311         (yywrap): Remove.
 312
 313 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 314
 315         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 316         _WIN32_WINNT to the XP level, unless already defined to a higher
 317         level.
 318
 319         * unittests/parse-connection-spec-selftests.c:
 320         * ser-tcp.c:
 321         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 322         override.
 323
 324         * symfile.c (find_separate_debug_file): Remove colon from the
 325         drive spec of DOS/Windows file names of the target, so that the
 326         file name produced from DEBUGDIR and the target's directory will
 327         be valid on DOS/Windows systems.
 328
 329 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * rust-lang.c (val_print_struct): Handle printing structures
 332         containing strings.
 333
 334 2019-05-02  Tom Tromey  <tromey@adacore.com>
 335
 336         * valarith.c (_initialize_valarith): Remove.
 337
 338 2019-05-01  Tom Tromey  <tromey@adacore.com>
 339
 340         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 341         bitfields.
 342
 343 2019-05-01  Tom Tromey  <tromey@adacore.com>
 344
 345         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 346         for big-endian copies.
 347
 348 2019-04-30  Ali Tamur  <tamur@google.com>
 349         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 350         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 351         (read_3_bytes): New function.
 352
 353 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 354
 355         * windows-nat.c (main_thread_id): Delete.
 356         (handle_output_debug_string): Replace main_thread_id by
 357         current_event.dwThreadId.
 358         (fake_create_process): Likewise.
 359         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 360         Do not set main_thread_id.
 361         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 362         current_event.dwThreadId.
 363         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 364
 365 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 366
 367         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 368         Use current_event.dwThreadId instead of main_thread_id.
 369
 370 2019-04-30  Tom Tromey  <tromey@adacore.com>
 371
 372         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 373         (create_excep_cond_exprs): Iterate over program spaces.
 374         (ada_exception_catchpoint_cond_string): Examine all minimal
 375         symbols for exception types.
 376
 377 2019-04-30  Tom Tromey  <tromey@adacore.com>
 378
 379         PR c++/24470:
 380         * dwarf2read.c (process_structure_scope): Handle case where type
 381         has template parameters but no symbol was created.
 382
 383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 384             Chris January  <chris.january@arm.com>
 385
 386         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 387         qualifier.
 388         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 389
 390 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * f-typeprint.c (f_print_type): Update rules for printing
 393         whitespace.
 394         (f_type_print_varspec_suffix): Likewise.
 395
 396 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 397             Chris January  <chris.january@arm.com>
 398
 399         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 400         function arguments.
 401
 402 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 403
 404         * f-lang.c (build_fortran_types): Change name of void type to
 405         lower case.
 406         * f-typeprint.c (f_type_print_base): Print the name of the void
 407         type, rather than a fixed string.
 408         * f-valprint.c (f_decorations): Use lower case void string.
 409
 410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 411             Chris January  <chris.january@arm.com>
 412
 413         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 414         types for Fortran.
 415
 416 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 417             Chris January  <chris.january@arm.com>
 418             David Lecomber  <david.lecomber@arm.com>
 419
 420         * f-exp.y (BINOP_INTRINSIC): New token.
 421         (exp): New parser rule handling BINOP_INTRINSIC.
 422         (f77_keywords): Add new builtin procedures.
 423         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 424         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 425         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 426         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 427         (print_unop_subexp_f): New function.
 428         (print_binop_subexp_f): New function.
 429         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 430         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 431         (dump_subexp_body_f): Likewise.
 432         (operator_check_f): Likewise.
 433         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 434         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 435
 436 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 439         UNOP_KIND.
 440         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 441         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 442         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 443         (operator_length_f): New fuction.
 444         (print_subexp_f): New function.
 445         (op_name_f): New function.
 446         (dump_subexp_body_f): New function.
 447         (operator_check_f): New function.
 448         (exp_descriptor_f): Replace standard expression handling functions
 449         with new functions.
 450         * gdb/fortran-operator.def: New file.
 451         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 452         * gdb/std-operator.def: Remove UNOP_KIND.
 453
 454 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * std-operator.def: Remove unbalanced, stray double quote
 457         character.
 458
 459 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 460             Chris January  <chris.january@arm.com>
 461             Daniel Everett  <daniel.everett@arm.com>
 462             Nick Forrington  <nick.forrington@arm.com>
 463             Richard Bunt  <richard.bunt@arm.com>
 464
 465         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 466         of depth when printing anonymous structs or unions.
 467         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 468         Don't print either the top-level value, or the children if the
 469         max-depth is exceeded.
 470         (ppscm_print_children): When printing the key of a map, allow one
 471         extra level of depth.
 472         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 473         print either the top-level value, or the children if the max-depth
 474         is exceeded.
 475         (print_children): When printing the key of a map, allow one extra
 476         level of depth.
 477         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 478         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 479         (user_print_options): Initialise max_depth field.
 480         (val_print_scalar_or_string_type_p): New function.
 481         (val_print): Check to see if the max depth has been reached.
 482         (val_print_check_max_depth): Define new function.
 483         (show_print_max_depth): New function.
 484         (_initialize_valprint): Add 'print max-depth' option.
 485         * valprint.h (struct value_print_options) <max_depth>: New field.
 486         (val_print_check_max_depth): Declare new function.
 487         * NEWS: Document new feature.
 488
 489 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 490
 491         * ada-lang.c (ada_language_defn): Initialise new field.
 492         * c-lang.c (c_is_string_type_p): New function.
 493         (c_language_defn): Initialise new field.
 494         (cplus_language_defn): Initialise new field.
 495         (asm_language_defn): Initialise new field.
 496         (minimal_language_defn): Initialise new field.
 497         * c-lang.h (c_is_string_type_p): Declare new function.
 498         * d-lang.c (d_language_defn): Initialise new field.
 499         * f-lang.c (f_is_string_type_p): New function.
 500         (f_language_defn): Initialise new field.
 501         * go-lang.c (go_is_string_type_p): New function.
 502         (go_language_defn): Initialise new field.
 503         * language.c (default_is_string_type_p): New function.
 504         (unknown_language_defn): Initialise new field.
 505         (auto_language_defn): Initialise new field.
 506         * language.h (struct language_defn) <la_is_string_type_p>: New
 507         member variable.
 508         (default_is_string_type_p): Declare new function.
 509         * m2-lang.c (m2_language_defn): Initialise new field.
 510         * objc-lang.c (objc_language_defn): Initialise new field.
 511         * opencl-lang.c (opencl_language_defn): Initialise new field.
 512         * p-lang.c (pascal_is_string_type_p): New function.
 513         (pascal_language_defn): Initialise new field.
 514         * rust-lang.c (rust_is_string_type_p): New function.
 515         (rust_language_defn): Initialise new field.
 516
 517 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 520         New field.
 521         * ada-lang.c (ada_language_defn): Initialise new field.
 522         * c-lang.c (c_language_defn): Likewise.
 523         (cplus_language_defn): Likewise.
 524         (asm_language_defn): Likewise.
 525         (minimal_language_defn): Likewise.
 526         * d-lang.c (d_language_defn): Likewise.
 527         * f-lang.c (f_language_defn): Likewise.
 528         * go-lang.c (go_language_defn): Likewise.
 529         * language.c (unknown_language_defn): Likewise.
 530         (auto_language_defn): Likewise.
 531         * m2-lang.c (m2_language_defn): Likewise.
 532         * objc-lang.c (objc_language_defn): Likewise.
 533         * opencl-lang.c (opencl_language_defn): Likewise.
 534         * p-lang.c (pascal_language_defn): Likewise.
 535         * rust-lang.c (rust_language_defn): Likewise.
 536
 537 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * ada-lang.c (ada_is_character_type): Change return type to bool.
 540         (ada_is_string_type): Likewise.
 541         * ada-lang.h (ada_is_character_type): Update declaration
 542         (ada_is_string_type): Likewise.
 543
 544 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 545
 546         Support style in 'frame|thread apply'
 547
 548         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 549         * record.c (record_start, record_stop): Update callers of
 550         execute_command_to_string with false.
 551         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 552         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 553         methods.
 554         (class string_file): New constructor with term_out parameter.
 555         Override methods term_out and can_emit_style_escape.  New member
 556         term_out.
 557         (class stdio_file): Override can_emit_style_escape.
 558         (class tee_file): Override term_out and can_emit_style_escape.
 559         * utils.h (can_emit_style_escape): Remove.
 560         * utils.c (can_emit_style_escape): Likewise.
 561         Update all callers of can_emit_style_escape (SOMESTREAM) to
 562         SOMESTREAM->can_emit_style_escape.
 563         * source-cache.c (source_cache::get_source_lines): Likewise.
 564         * stack.c (frame_apply_command_count): Call execute_command_to_string
 565         passing the term_out characteristic of the current gdb_stdout.
 566         * thread.c (thr_try_catch_cmd): Likewise.
 567         * top.c (execute_command_to_string): pass term_out parameter
 568         to construct the string_file for the command output.
 569         * ui-file.c (term_cli_styling): New function (most code moved
 570         from utils.c can_emit_style_escape).
 571         (string_file::string_file, string_file::can_emit_style_escape,
 572         stdio_file::can_emit_style_escape, tee_file::term_out,
 573         tee_file::can_emit_style_escape): New functions.
 574
 575 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 576
 577         * NEWS: Mention the new set|show may-call-functions.
 578         * infcall.c (may_call_functions_p): New variable.
 579         (show_may_call_functions_p): New function.
 580         (call_function_by_hand_dummy): Throws an error if not
 581         may-call-functions.
 582         (_initialize_infcall): Call add_setshow_boolean_cmd for
 583         may-call-functions.
 584
 585 2019-04-25  Keith Seitz  <keiths@redhat.com>
 586
 587         PR c++/24367
 588         * cp-support.c (inspect_type): Don't attempt substitutions
 589         of symbol with the same name.
 590
 591 2019-04-25  Tom Tromey  <tromey@adacore.com>
 592
 593         PR gdb/24475:
 594         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 595         static.
 596
 597 2019-04-25  Tom Tromey  <tromey@adacore.com>
 598
 599         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 600         rvalue reference.
 601         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 602         (gdb_xml_parser::parse): Use std::move.
 603         * python/python-internal.h (gdbpy_convert_exception): Take a const
 604         reference.
 605         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 606         std::move.
 607         * python/py-utils.c (gdbpy_convert_exception): Take a const
 608         reference.
 609         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 610         Use std::move.
 611         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 612         Use std::move.
 613         * mi/mi-main.c (mi_print_exception): Take a const reference.
 614         * main.c (handle_command_errors): Take a const reference.
 615         * linespec.c (parse_linespec): Use std::move.
 616         * infcall.c (run_inferior_call): Use std::move.
 617         (call_function_by_hand_dummy): Use std::move.
 618         * exec.c (try_open_exec_file): Use std::move.
 619         * exceptions.h (exception_print, exception_fprintf)
 620         (exception_print_same): Update.
 621         * exceptions.c (print_exception, exception_print)
 622         (exception_fprintf, exception_print_same): Change parameters to
 623         const reference.
 624         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 625         * common/new-op.c: Use std::move.
 626         * common/common-exceptions.h (struct gdb_exception): Add move
 627         constructor.
 628         (struct gdb_exception_error, struct gdb_exception_quit, struct
 629         gdb_quit_bad_alloc): Change constructor to move constructor.
 630         (throw_exception): Change parameter to rvalue reference.
 631         * common/common-exceptions.c (throw_exception): Take rvalue
 632         reference.
 633         * cli/cli-interp.c (safe_execute_command): Use std::move.
 634         * breakpoint.c (insert_bp_location, location_to_sals): Use
 635         std::move.
 636
 637 2019-04-25  Tom Tromey  <tromey@adacore.com>
 638
 639         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 640         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 641         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 642         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 643         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 644         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 645         guile/scm-value.c: Use unpack.
 646         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 647         gdbscm_gdb_exception.
 648         (gdbscm_throw_gdb_exception): Likewise.
 649         (struct gdbscm_gdb_exception): New.
 650         (unpack): New function.
 651         (gdbscm_wrap): Use unpack.
 652
 653 2019-04-25  Tom Tromey  <tromey@adacore.com>
 654
 655         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 656         (gdb_rl_callback_handler): Use std::move.
 657         * common/common-exceptions.h (struct gdb_exception): Add move
 658         assignment operator.
 659         (throw_exception_sjlj): Change "exception" to const reference.
 660         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 661         (throw_exception_sjlj): Change "exception" to const reference.
 662
 663 2019-04-25  Tom Tromey  <tromey@adacore.com>
 664
 665         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 666         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 667         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 668         Update.
 669         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 670         Update.
 671         * mi/mi-interp.c (mi_interp::exec): Update.
 672         * linespec.c (parse_linespec): Update.
 673         * infcall.c (run_inferior_call): Update.
 674         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 675         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 676         (gdbscm_lookup_global_symbol): Update.
 677         * guile/scm-param.c (gdbscm_parameter_value): Update.
 678         * guile/scm-frame.c (gdbscm_frame_read_register)
 679         (gdbscm_frame_read_var): Update.
 680         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 681         * exec.c (try_open_exec_file): Update.
 682         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 683         (gdb_rl_callback_handler): Update.
 684         * common/common-exceptions.h (exception_none): Don't declare.
 685         * common/common-exceptions.c (exception_none): Don't define.
 686         (struct catcher) <exception>: Update.
 687         * cli/cli-interp.c (safe_execute_command): Update.
 688         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 689
 690 2019-04-25  Ali Tamur  <tamur@google.com>
 691
 692         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 693         (read_attribute_value): Likewise.
 694         (dwarf2_read_addr_index): Update comment.
 695         (read_str_index): Add DW_FORM_strx.
 696         (dwarf2_string_attr): Likewise.
 697         (dwarf2_const_value_attr): Likewise.
 698         (dump_die_shallow): Likewise.
 699         (dwarf2_fetch_constant_bytes): Likewise.
 700         (skip_form_bytes): Likewise.
 701         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 702
 703 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 704
 705         PR corefiles/11608
 706         PR corefiles/18187
 707         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 708         OFFSET.  Verify if current mapping contains an ELF header.
 709         (linux_find_memory_regions_full): Adjust call to
 710         dump_mapping_p.
 711
 712 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 713             Kang Li <kanglictf@gmail.com>
 714
 715         PR gdb/21600
 716
 717         * dwarf2-frame.c (read_initial_length): Be consistent about using
 718         unsigned representation of length.
 719         (decode_frame_entry_1): Likewise.  Check for wraparound of
 720         end pointer as well as buffer overflow.
 721
 722 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 723
 724         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 725         "vq".
 726
 727 2019-04-24  Tom Tromey  <tromey@adacore.com>
 728
 729         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 730
 731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * s12z-tdep.c (s12z_unwind_pc): Delete.
 734         (s12z_unwind_sp): Delete.
 735         (s12z_gdbarch_init): Don't register deleted functions with
 736         gdbarch.
 737
 738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * rl78-tdep.c (rl78_unwind_sp): Delete.
 741         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 742
 743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 746         (xstormy16_unwind_pc): Delete.
 747         (xstormy16_dummy_id): Delete.
 748         (xstormy16_gdbarch_init): Don't register deleted functions with
 749         gdbarch.
 750
 751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * vax-tdep.c (vax_unwind_pc): Delete.
 754         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 755
 756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * v850-tdep.c (v850_unwind_sp): Delete.
 759         (v850_unwind_pc): Delete.
 760         (v850_dummy_id): Delete.
 761         (v850_gdbarch_init): Don't register deleted functions with
 762         gdbarch.
 763
 764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 765
 766         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 767         (tilegx_unwind_pc): Delete.
 768         (tilegx_unwind_dummy_id): Delete.
 769         (tilegx_gdbarch_init): Don't register deleted functions with
 770         gdbarch.
 771
 772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 773
 774         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 775         (tic6x_dummy_id): Delete.
 776         (tic6x_gdbarch_init): Don't register deleted functions with
 777         gdbarch.
 778
 779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * sparc-tdep.c (sparc_unwind_pc): Delete.
 782         (sparc32_gdbarch_init): Don't register deleted function with
 783         gdbarch.
 784
 785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * sh-tdep.c (sh_unwind_sp): Delete.
 788         (sh_unwind_pc): Delete.
 789         (sh_dummy_id): Delete.
 790         (sh_gdbarch_init): Don't register deleted functions with
 791         gdbarch.
 792
 793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * score-tdep.c (score_unwind_sp): Delete.
 796         (score_unwind_pc): Delete.
 797         (score_dummy_id): Delete.
 798         (score_gdbarch_init): Don't register deleted functions with
 799         gdbarch.
 800
 801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * rx-tdep.c (rx_unwind_pc): Delete.
 804         (rx_unwind_sp): Delete.
 805         (rx_dummy_id): Delete.
 806         (rx_gdbarch_init): Don't register deleted functions with
 807         gdbarch.  Update comment.
 808
 809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 812         (rs6000_dummy_id): Delete.
 813         (rs6000_gdbarch_init): Don't register deleted functions with
 814         gdbarch.
 815
 816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * or1k-tdep.c (or1k_dummy_id): Delete.
 819         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 820
 821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * nios2-tdep.c (nios2_dummy_id): Delete.
 824         (nios2_unwind_sp): Delete.
 825         (nios2_gdbarch_init): Don't register deleted functions with
 826         gdbarch.
 827
 828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * nds32-tdep.c (nds32_dummy_id): Delete.
 831         (nds32_unwind_pc): Delete.
 832         (nds32_unwind_sp): Delete.
 833         (nds32_gdbarch_init): Don't register deleted functions with
 834         gdbarch.
 835
 836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * msp430-tdep.c (msp430_unwind_pc): Delete.
 839         (msp430_unwind_sp): Delete.
 840         (msp430_dummy_id): Delete.
 841         (msp430_gdbarch_init): Don't register deleted functions with
 842         gdbarch.
 843
 844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 845
 846         * moxie-tdep.c (moxie_unwind_sp): Delete.
 847         (moxie_unwind_pc): Delete.
 848         (moxie_dummy_id): Delete.
 849         (moxie_gdbarch_init): Don't register deleted functions with
 850         gdbarch.
 851
 852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 855         (mn10300_unwind_pc): Delete.
 856         (mn10300_unwind_sp): Delete.
 857         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 858         mn10300_unwind_sp.
 859         (mn10300_frame_unwind_init): Don't register deleted functions with
 860         gdbarch.
 861
 862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * mep-tdep.c (mep_unwind_pc): Delete.
 865         (mep_unwind_sp): Delete.
 866         (mep_dummy_id): Delete.
 867         (mep_gdbarch_init): Don't register deleted functions with
 868         gdbarch.
 869
 870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 873         (m68hc11_unwind_sp): Delete.
 874         (m68hc11_gdbarch_init): Don't register deleted functions with
 875         gdbarch.
 876
 877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * m32r-tdep.c (m32r_unwind_sp): Delete.
 880         (m32r_unwind_pc): Delete.
 881         (m32r_dummy_id): Delete.
 882         (m32r_gdbarch_init): Don't register deleted functions with
 883         gdbarch.
 884
 885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * m32c-tdep.c (m32c_unwind_pc): Delete.
 888         (m32c_unwind_sp): Delete.
 889         (m32c_dummy_id): Delete.
 890         (m32c_gdbarch_init): Don't register deleted functions with
 891         gdbarch.
 892
 893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 896         (lm32_unwind_pc): Delete.
 897         (lm32_dummy_id): Delete.
 898         (lm32_gdbarch_init): Don't register deleted functions with
 899         gdbarch.
 900
 901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 904         (iq2000_unwind_pc): Delete.
 905         (iq2000_dummy_id): Delete.
 906         (iq2000_gdbarch_init): Don't register deleted functions with
 907         gdbarch.
 908
 909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * nds32-tdep.c (nds32_type_align): Delete.
 912         (nds32_push_dummy_call): Use type_align instead.
 913
 914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * arm-tdep.c (arm_type_align): Only handle vector override case.
 917         (arm_push_dummy_call): Use type_align.
 918         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 919
 920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 923         case.
 924         (pass_on_stack): Use type_align.
 925         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 926         function.
 927
 928 2019-04-23  Tom Tromey  <tromey@adacore.com>
 929
 930         * dwarf2read.c (line_header::file_name_at): Remove unused
 931         overload.
 932
 933 2019-04-23  Tom de Vries  <tdevries@suse.de>
 934
 935         PR gdb/24438
 936         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 937         invocation.
 938
 939
 940 2019-03-27  Ali Tamur  <tamur@google.com>
 941
 942         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 943         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 944         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 945         (dwarf_expr_context::get_addr_index): Likewise
 946         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 947         (symbol_needs_eval_context::get_addr_index): Likewise
 948         (disassemble_dwarf_expression): Add DW_OP_addrx
 949         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 950         (read_cutu_die_from_dwo): Update comment
 951         (skip_one_die): Add DW_FORM_addrx
 952         (read_attribute_value): Likewise
 953         (var_decode_location): Add DW_OP_addrx
 954         (dwarf2_const_value_attr): Add DW_FORM_addrx
 955         (dump_die_shallow): Likewise
 956         (dwarf2_fetch_constant_bytes): Likewise
 957         (decode_locdesc): Add DW_OP_addrx
 958         (skip_form_bytes): Add DW_FORM_addrx
 959
 960 2019-04-22  Ali Tamur  <tamur@google.com>
 961
 962         * MAINTAINERS (Write After Approval): Add self.
 963
 964 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 965
 966         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 967         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 968         (open_symbol_file_object): Likewise.
 969         (svr4_default_sos): Add info parameter.
 970         (svr4_read_so_list): Likewise.
 971         (svr4_current_sos_direct): Adjust functions calls to pass down
 972         info.
 973         (svr4_current_sos_1): Add info parameter.
 974         (svr4_current_sos): Call get_svr4_info, pass info down to
 975         svr4_current_sos_1.
 976         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 977         get_svr4_info.
 978         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 979         get_svr4_info.
 980         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 981         to get_svr4_info.
 982         (probes_table_remove_objfile_probes): Likewise.
 983         (register_solib_event_probe): Add info parameter.
 984         (solist_update_incremental): Pass info parameter down to
 985         svr4_read_so_list.
 986         (disable_probes_interface): Add info parameter.
 987         (svr4_handle_solib_event): Pass current_program_space to
 988         get_svr4_info.  Adjust disable_probes_interface cleanup.
 989         (svr4_create_probe_breakpoints): Add info parameter, pass it
 990         down to register_solib_event_probe.
 991         (svr4_create_solib_event_breakpoints): Add info parameter,
 992         pass it down to svr4_create_probe_breakpoints.
 993         (enable_break): Pass info down to
 994         svr4_create_solib_event_breakpoints.
 995         (svr4_solib_create_inferior_hook): Pass current_program_space to
 996         get_svr4_info.
 997         (svr4_clear_solib): Likewise.
 998
 999 2019-04-22  Pedro Alves  <palves@redhat.com>
1000
1001         * solib-svr4.c (svr4_free_objfile_observer): New.
1002         (probe_and_action::objfile): New field.
1003         (probes_table_htab_remove_objfile_probes)
1004         (probes_table_remove_objfile_probes): New functions.
1005         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1006         in the new probe_and_action.  Don't store the probe in 'lookup'.
1007         (svr4_create_probe_breakpoints): Pass objfile to
1008         register_solib_event_probe.
1009         (_initialize_svr4_solib): Register a free_objfile observer.
1010
1011 2019-04-19  Tom Tromey  <tom@tromey.com>
1012
1013         * common/queue.h: Remove.
1014
1015 2019-04-19  Tom Tromey  <tom@tromey.com>
1016
1017         * event-loop.c: Don't include "common/queue.h".
1018
1019 2019-04-19  Tom Tromey  <tom@tromey.com>
1020
1021         * remote.c (remote_target): Use delete.
1022         * remote-notif.h: Include <list>, not "common/queue.h".
1023         (notif_client_p): Remove typedef.
1024         (remote_notif_state): Add constructor, destructor, initializer.
1025         <notif_queue>: Now a std::list.
1026         (remote_notif_state_xfree): Don't declare.
1027         * remote-notif.c (remote_notif_process, handle_notification)
1028         (remote_notif_state_allocate): Update.
1029         (~remote_notif_state): Rename from remote_notif_state_xfree.
1030
1031 2019-04-19  Tom Tromey  <tom@tromey.com>
1032
1033         * symfile.c (reread_symbols): Update.
1034         * objfiles.c (objfile_register_static_link)
1035         (objfile_lookup_static_link): Update
1036         (~objfile) Don't delete static_links.
1037         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1038
1039 2019-04-19  Tom Tromey  <tom@tromey.com>
1040
1041         * type-stack.h (struct type_stack) <insert>: Constify string.
1042         * type-stack.c (type_stack::insert): Constify string.
1043         * gdbtypes.h (lookup_template_type): Update.
1044         (address_space_name_to_int): Update.
1045         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1046         const.
1047         (lookup_template_type): Make name const.
1048         * c-exp.y: Update rules.
1049         (lex_one_token, classify_name, classify_inner_name)
1050         (c_print_token): Update.
1051         * p-exp.y: Update rules.
1052         (yylex): Update.
1053         * f-exp.y: Update rules.
1054         (yylex): Update.
1055         * d-exp.y: Update rules.
1056         (lex_one_token, classify_name, classify_inner_name): Update.
1057         * parse.c (write_dollar_variable, copy_name): Return std::string.
1058         * parser-defs.h (copy_name): Change return type.
1059         * m2-exp.y: Update rules.
1060         (yylex): Update.
1061         * go-exp.y (lex_one_token): Update.
1062         Update rules.
1063         (classify_unsafe_function, classify_packaged_name)
1064         (classify_name, yylex): Update.
1065
1066 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1067
1068         * configure.ac: add --enable-source-highlight switch.
1069         * configure: Regenerate.
1070         * top.c (print_gdb_version): plumb --enable-source-highlight
1071         status to "show configuration".
1072
1073 2019-04-19  Tom Tromey  <tromey@adacore.com>
1074
1075         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1076         Check ADA_TYPE_P.
1077         (empty_record, ada_template_to_fixed_record_type_1)
1078         (template_to_static_fixed_type)
1079         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1080         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1081         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1082         macros.
1083
1084 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1085
1086         PR symtab/24423:
1087         * source.c (print_source_lines_base): Advance "iter" when a
1088         control character is seen.
1089
1090 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1091
1092         * inferior.h (struct infcall_suspend_state_deleter):
1093         Catch exception in destructor to avoid crash.
1094
1095 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1096
1097         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1098         close to the add_com "shell".
1099
1100 2019-04-18  Tom Tromey  <tromey@adacore.com>
1101
1102         * process-stratum-target.h (class process_stratum_target)
1103         <stratum>: Add "final".
1104
1105 2019-04-17  Tom Tromey  <tromey@adacore.com>
1106
1107         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1108         against nullptr before use.
1109
1110 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1111
1112         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1113
1114 2019-04-17  Jim Wilson  <jimw@sifive.com>
1115             Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1118         code read might fail, assume 4-byte breakpoint in that case.
1119
1120 2019-04-15  Leszek Swirski  <leszeks@google.com>
1121
1122         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1123         rather than a hand-rolled POD check when checking for forced MEMORY
1124         classification.
1125
1126 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1129         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1130         function.
1131         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1132         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1133         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1134         declaration.
1135
1136 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * aarch64-linux-nat.c
1139         (aarch64_linux_nat_target::thread_architecture): Add override.
1140         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1141         each VQ.
1142
1143 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1144
1145         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1146
1147 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1150         target types of size 96-bits, add some additional comments, and
1151         check that the builtin type we found was the correct size.
1152
1153 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1154
1155         * utils.c (prompt_for_continue): Don't restore the styling at the
1156         end, as applied_style has the wrong value.  This fixes styling in
1157         long lists of file names that are interrupted by the "Continue?"
1158         prompt.
1159
1160 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1163         * c-lang.c (c_language_defn): Likewise.
1164         (cplus_language_defn): Likewise.
1165         (asm_language_defn): Likewise.
1166         (minimal_language_defn): Likewise.
1167         * d-lang.c (d_language_defn): Likewise.
1168         * f-lang.c (f_language_defn): Likewise.
1169         * go-lang.c (go_language_defn): Likewise.
1170         * language.c (unknown_language_defn): Likewise.
1171         (auto_language_defn): Likewise.
1172         * language.h (struct language_defn): Remove la_magic field.
1173         (LANG_MAGIC): Delete.
1174         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1175         * objc-lang.c (objc_language_defn): Likewise.
1176         * opencl-lang.c (opencl_language_defn): Likewise.
1177         * p-lang.c (pascal_language_defn): Likewise.
1178         * rust-lang.c (rust_language_defn): Likewise.
1179
1180 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * riscv-tdep.c (riscv_type_align): New function.
1183         (riscv_type_alignment): Delete.
1184         (riscv_arg_location): Use 'type_align'.
1185         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1186
1187 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * gdbtypes.c (type_align): A struct with no non-static fields also
1190         has alignment of 1.
1191
1192 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1195         component to 0.
1196         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1197         member.
1198         (riscv_struct_info::analyse): New implementation using new
1199         analyse_inner member function.
1200         (riscv_struct_info::field_offset): New member function.
1201         (riscv_struct_info::m_offsets): New member variable.
1202         (riscv_struct_info::analyse_inner): New private member function,
1203         takes the old implementation of riscv_struct_info::analyse but
1204         extended to track field offsets.
1205         (riscv_call_arg_struct): Update the struct folding special cases
1206         to handle cases where empty C++ structs, which are non-zero
1207         length, are found.
1208         (riscv_arg_location): Initialise the length of each location, a
1209         non-zero length now indicates the location is in use.
1210         (riscv_push_dummy_call): Allow for the first location having a
1211         non-zero offset when setting up arguments.
1212         (riscv_return_value): Likewise, but for return values.
1213
1214 2019-04-11  Tom Tromey  <tromey@adacore.com>
1215
1216         * utils.c (internal_vproblem): Make "msg" const.
1217
1218 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1219
1220         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1221         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1222         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1223         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1224
1225 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1226
1227         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1228         function.
1229         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1230         of amd64_collect_native_gregset.
1231         (amd64_linux_nat_target::store_registers): Likewise.
1232
1233 2019-04-10  Tom Tromey  <tom@tromey.com>
1234
1235         * symtab.c (lookup_global_symbol_from_objfile)
1236         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1237         * objfiles.h (class separate_debug_iterator): New.
1238         (class separate_debug_range): New.
1239         (struct objfile) <separate_debug_objfiles>: New method.
1240         (objfile_separate_debug_iterate): Don't declare.
1241         * objfiles.c (separate_debug_iterator::operator++): Rename from
1242         objfile_separate_debug_iterate.
1243         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1244         iterator.
1245         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1246         iterator.
1247
1248 2019-04-10  Tom Tromey  <tom@tromey.com>
1249
1250         * symfile.c (reread_symbols): Remove old comment.
1251         * objfiles.c (free_all_objfiles): Fix a typo.
1252
1253 2019-04-10  Tom Tromey  <tom@tromey.com>
1254
1255         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1256         * minsyms.c (lookup_minimal_symbol): Use foreach.
1257         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1258         (lookup_minimal_symbol_solib_trampoline): Likewise.
1259         * symfile.c (reread_symbols): Use foreach.
1260
1261 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1262             Tom Tromey  <tromey@adacore.com>
1263
1264         PR rust/24414:
1265         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1266         (rust_lex_int_test): Change "value" to be LONGEST.
1267         (rust_lex_tests): Add test for long integer literal.
1268
1269 2019-04-09  Tom Tromey  <tromey@adacore.com>
1270
1271         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1272         to bool.
1273         (extended_remote_target::attach): Update.
1274         (remote_target::remote_notice_new_inferior): Update.
1275         (remote_target::add_current_inferior_and_thread): Update.
1276         * inferior.c (exit_inferior_1): Use "false".
1277         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1278
1279 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1280
1281         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1282         the "start" command.
1283
1284 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1285
1286         * python/py-inferior.c (infpy_thread_from_thread_handle):
1287         Adjust comments to reflect renaming of thread_from_thread_handle
1288         to thread_from_handle.  Adjust keywords.  Fix type error message.
1289         (inferior_object_methods): Add thread_from_handle.  Retain
1290         thread_from_thread_handle, but mark it as deprecated.
1291
1292 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1293
1294         * gdbthread.h (find_thread_by_handle): Revise declaration.
1295         * thread.c (find_thread_by_handle): Likewise.  Adjust
1296         implementation too.
1297         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1298         support for buffer objects as handles.
1299
1300 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1301
1302         * python/py-infthread.c (thpy_thread_handle): New function.
1303         (thread_object_methods): Register thpy_thread_handle.
1304
1305 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1306
1307         * gdbthread.h (thread_to_thread_handle): Declare.
1308         * thread.c (gdbtypes.h): Include.
1309         (thread_to_thread_handle): New function.
1310
1311         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1312         (target_thread_info_to_thread_handle): Declare.
1313         * target.c (target_thread_info_to_thread_handle): New function.
1314         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1315         * target-delegates.c: Regenerate.
1316
1317         * linux-thread-db.c (class thread_db_target): Add method
1318         thread_info_to_thread_handle.
1319         (thread_db_target::thread_info_to_thread_handle): Define.
1320         * remote.c (class remote_target): Add new method
1321         thread_info_to_thread_handle.
1322         (remote_target::thread_info_to_thread_handle): Define.
1323
1324 2019-04-08  Pedro Alves  <palves@redhat.com>
1325
1326         * common/common-exceptions.c (throw_exception): Don't create
1327         named object to throw; throw directly.
1328         (throw_it): Likewise.  Don't initialize gdb_exception::message
1329         here, with new; pass FMT and AP to the ctor instead.
1330         * common/common-exceptions.h: Include <string>.
1331         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1332         const char *, va_list)): New ctor.  Use std::make_shared.
1333         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1334         errors)): Delete.
1335         (gdb_exception_error::gdb_exception_error(enum errors, const char
1336         *, va_list)): New.
1337         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1338         Add assertion.
1339         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1340         errors)): Delete.
1341         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1342         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1343         Add assertion.
1344
1345 2019-04-08  Tom Tromey  <tom@tromey.com>
1346
1347         * valops.c (value_rtti_indirect_type): Replace throw_exception
1348         with throw.
1349         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1350         with throw.
1351         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1352         throw.
1353         * target.c (target_translate_tls_address): Replace throw_exception
1354         with throw.
1355         * stack.c (frame_apply_command_count): Replace throw_exception
1356         with throw.
1357         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1358         throw.
1359         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1360         with throw.
1361         * rs6000-tdep.c (rs6000_frame_cache)
1362         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1363         * remote.c: Replace throw_exception with throw.
1364         * record-full.c (record_full_message, record_full_wait_1)
1365         (record_full_restore): Replace throw_exception with throw.
1366         * record-btrace.c:
1367         (get_thread_current_frame_id, record_btrace_start_replaying)
1368         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1369         (cmd_record_btrace_start): Replace throw_exception with throw.
1370         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1371         throw.
1372         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1373         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1374         * linespec.c:
1375         (find_linespec_symbols): Replace throw_exception with throw.
1376         * infrun.c (displaced_step_prepare, resume): Replace
1377         throw_exception with throw.
1378         * infcmd.c (post_create_inferior): Replace throw_exception with
1379         throw.
1380         * inf-loop.c (inferior_event_handler): Replace throw_exception
1381         with throw.
1382         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1383         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1384         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1385         (get_prev_frame_always, get_frame_pc_if_available)
1386         (get_frame_address_in_block_if_available, get_frame_language):
1387         Replace throw_exception with throw.
1388         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1389         throw_exception with throw.
1390         * eval.c (fetch_subexp_value, evaluate_var_value)
1391         (evaluate_funcall, evaluate_subexp_standard): Replace
1392         throw_exception with throw.
1393         * dwarf2loc.c (call_site_find_chain)
1394         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1395         Replace throw_exception with throw.
1396         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1397         with throw.
1398         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1399         throw.
1400         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1401         * completer.c (complete_line_internal): Replace throw_exception
1402         with throw.
1403         * compile/compile-object-run.c (compile_object_run): Replace
1404         throw_exception with throw.
1405         * cli/cli-script.c (process_next_line): Replace throw_exception
1406         with throw.
1407         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1408         (btrace_enable, btrace_maint_update_pt_packets): Replace
1409         throw_exception with throw.
1410         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1411         throw_exception with throw.
1412         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1413         throw_exception with throw.
1414         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1415         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1416         * aarch64-tdep.c (aarch64_make_prologue_cache)
1417         (aarch64_make_stub_cache): Replace throw_exception with throw.
1418
1419 2019-04-08  Tom Tromey  <tom@tromey.com>
1420
1421         * common/common-exceptions.c (throw_exception): Rename from
1422         throw_exception_cxx.  Remove old copy.  Make argument const.
1423         (throw_it): Create and throw exception objects directly.
1424         * common/common-exceptions.h (throw_exception): Make argument
1425         const.
1426         (struct gdb_exception_error): Add constructor.
1427         (struct gdb_exception_quit): Add constructor.
1428
1429 2019-04-08  Tom Tromey  <tom@tromey.com>
1430
1431         * common/common-exceptions.h (exception_rethrow): Don't declare.
1432         (TRY_SJLJ): Update comment.
1433         (TRY, CATCH, END_CATCH): Remove.
1434         * common/common-exceptions.c (exception_rethrow): Remove.
1435
1436 2019-04-08  Tom Tromey  <tom@tromey.com>
1437
1438         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1439         Remove.
1440         (gdb_exception_error): Rename from
1441         gdb_exception_RETURN_MASK_ERROR.
1442         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1443         (gdb_quit_bad_alloc): Update.
1444         * aarch64-tdep.c: Update.
1445         * ada-lang.c: Update.
1446         * ada-typeprint.c: Update.
1447         * ada-valprint.c: Update.
1448         * amd64-tdep.c: Update.
1449         * arch-utils.c: Update.
1450         * break-catch-throw.c: Update.
1451         * breakpoint.c: Update.
1452         * btrace.c: Update.
1453         * c-varobj.c: Update.
1454         * cli/cli-cmds.c: Update.
1455         * cli/cli-interp.c: Update.
1456         * cli/cli-script.c: Update.
1457         * common/common-exceptions.c: Update.
1458         * common/new-op.c: Update.
1459         * common/selftest.c: Update.
1460         * compile/compile-c-symbols.c: Update.
1461         * compile/compile-cplus-symbols.c: Update.
1462         * compile/compile-object-load.c: Update.
1463         * compile/compile-object-run.c: Update.
1464         * completer.c: Update.
1465         * corelow.c: Update.
1466         * cp-abi.c: Update.
1467         * cp-support.c: Update.
1468         * cp-valprint.c: Update.
1469         * darwin-nat.c: Update.
1470         * disasm-selftests.c: Update.
1471         * dtrace-probe.c: Update.
1472         * dwarf-index-cache.c: Update.
1473         * dwarf-index-write.c: Update.
1474         * dwarf2-frame-tailcall.c: Update.
1475         * dwarf2-frame.c: Update.
1476         * dwarf2loc.c: Update.
1477         * dwarf2read.c: Update.
1478         * eval.c: Update.
1479         * event-loop.c: Update.
1480         * event-top.c: Update.
1481         * exec.c: Update.
1482         * f-valprint.c: Update.
1483         * fbsd-tdep.c: Update.
1484         * frame-unwind.c: Update.
1485         * frame.c: Update.
1486         * gdbtypes.c: Update.
1487         * gnu-v3-abi.c: Update.
1488         * guile/guile-internal.h: Update.
1489         * guile/scm-block.c: Update.
1490         * guile/scm-breakpoint.c: Update.
1491         * guile/scm-cmd.c: Update.
1492         * guile/scm-disasm.c: Update.
1493         * guile/scm-frame.c: Update.
1494         * guile/scm-lazy-string.c: Update.
1495         * guile/scm-math.c: Update.
1496         * guile/scm-param.c: Update.
1497         * guile/scm-ports.c: Update.
1498         * guile/scm-pretty-print.c: Update.
1499         * guile/scm-symbol.c: Update.
1500         * guile/scm-symtab.c: Update.
1501         * guile/scm-type.c: Update.
1502         * guile/scm-value.c: Update.
1503         * i386-linux-tdep.c: Update.
1504         * i386-tdep.c: Update.
1505         * inf-loop.c: Update.
1506         * infcall.c: Update.
1507         * infcmd.c: Update.
1508         * infrun.c: Update.
1509         * jit.c: Update.
1510         * language.c: Update.
1511         * linespec.c: Update.
1512         * linux-fork.c: Update.
1513         * linux-nat.c: Update.
1514         * linux-tdep.c: Update.
1515         * linux-thread-db.c: Update.
1516         * main.c: Update.
1517         * mi/mi-cmd-break.c: Update.
1518         * mi/mi-cmd-stack.c: Update.
1519         * mi/mi-interp.c: Update.
1520         * mi/mi-main.c: Update.
1521         * objc-lang.c: Update.
1522         * p-valprint.c: Update.
1523         * parse.c: Update.
1524         * ppc-linux-tdep.c: Update.
1525         * printcmd.c: Update.
1526         * python/py-arch.c: Update.
1527         * python/py-breakpoint.c: Update.
1528         * python/py-cmd.c: Update.
1529         * python/py-finishbreakpoint.c: Update.
1530         * python/py-frame.c: Update.
1531         * python/py-framefilter.c: Update.
1532         * python/py-gdb-readline.c: Update.
1533         * python/py-inferior.c: Update.
1534         * python/py-infthread.c: Update.
1535         * python/py-lazy-string.c: Update.
1536         * python/py-linetable.c: Update.
1537         * python/py-objfile.c: Update.
1538         * python/py-param.c: Update.
1539         * python/py-prettyprint.c: Update.
1540         * python/py-progspace.c: Update.
1541         * python/py-record-btrace.c: Update.
1542         * python/py-record.c: Update.
1543         * python/py-symbol.c: Update.
1544         * python/py-type.c: Update.
1545         * python/py-unwind.c: Update.
1546         * python/py-utils.c: Update.
1547         * python/py-value.c: Update.
1548         * python/python.c: Update.
1549         * record-btrace.c: Update.
1550         * record-full.c: Update.
1551         * remote-fileio.c: Update.
1552         * remote.c: Update.
1553         * riscv-tdep.c: Update.
1554         * rs6000-aix-tdep.c: Update.
1555         * rs6000-tdep.c: Update.
1556         * rust-exp.y: Update.
1557         * rust-lang.c: Update.
1558         * s390-tdep.c: Update.
1559         * selftest-arch.c: Update.
1560         * solib-dsbt.c: Update.
1561         * solib-frv.c: Update.
1562         * solib-spu.c: Update.
1563         * solib-svr4.c: Update.
1564         * solib.c: Update.
1565         * sparc64-linux-tdep.c: Update.
1566         * stack.c: Update.
1567         * symfile-mem.c: Update.
1568         * symmisc.c: Update.
1569         * target.c: Update.
1570         * thread.c: Update.
1571         * top.c: Update.
1572         * tracefile-tfile.c: Update.
1573         * tui/tui.c: Update.
1574         * typeprint.c: Update.
1575         * unittests/cli-utils-selftests.c: Update.
1576         * unittests/parse-connection-spec-selftests.c: Update.
1577         * valops.c: Update.
1578         * valprint.c: Update.
1579         * value.c: Update.
1580         * varobj.c: Update.
1581         * windows-nat.c: Update.
1582         * x86-linux-nat.c: Update.
1583         * xml-support.c: Update.
1584
1585 2019-04-08  Tom Tromey  <tom@tromey.com>
1586
1587         * xml-support.c: Use C++ exception handling.
1588         * x86-linux-nat.c: Use C++ exception handling.
1589         * windows-nat.c: Use C++ exception handling.
1590         * varobj.c: Use C++ exception handling.
1591         * value.c: Use C++ exception handling.
1592         * valprint.c: Use C++ exception handling.
1593         * valops.c: Use C++ exception handling.
1594         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1595         handling.
1596         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1597         * typeprint.c: Use C++ exception handling.
1598         * tui/tui.c: Use C++ exception handling.
1599         * tracefile-tfile.c: Use C++ exception handling.
1600         * top.c: Use C++ exception handling.
1601         * thread.c: Use C++ exception handling.
1602         * target.c: Use C++ exception handling.
1603         * symmisc.c: Use C++ exception handling.
1604         * symfile-mem.c: Use C++ exception handling.
1605         * stack.c: Use C++ exception handling.
1606         * sparc64-linux-tdep.c: Use C++ exception handling.
1607         * solib.c: Use C++ exception handling.
1608         * solib-svr4.c: Use C++ exception handling.
1609         * solib-spu.c: Use C++ exception handling.
1610         * solib-frv.c: Use C++ exception handling.
1611         * solib-dsbt.c: Use C++ exception handling.
1612         * selftest-arch.c: Use C++ exception handling.
1613         * s390-tdep.c: Use C++ exception handling.
1614         * rust-lang.c: Use C++ exception handling.
1615         * rust-exp.y: Use C++ exception handling.
1616         * rs6000-tdep.c: Use C++ exception handling.
1617         * rs6000-aix-tdep.c: Use C++ exception handling.
1618         * riscv-tdep.c: Use C++ exception handling.
1619         * remote.c: Use C++ exception handling.
1620         * remote-fileio.c: Use C++ exception handling.
1621         * record-full.c: Use C++ exception handling.
1622         * record-btrace.c: Use C++ exception handling.
1623         * python/python.c: Use C++ exception handling.
1624         * python/py-value.c: Use C++ exception handling.
1625         * python/py-utils.c: Use C++ exception handling.
1626         * python/py-unwind.c: Use C++ exception handling.
1627         * python/py-type.c: Use C++ exception handling.
1628         * python/py-symbol.c: Use C++ exception handling.
1629         * python/py-record.c: Use C++ exception handling.
1630         * python/py-record-btrace.c: Use C++ exception handling.
1631         * python/py-progspace.c: Use C++ exception handling.
1632         * python/py-prettyprint.c: Use C++ exception handling.
1633         * python/py-param.c: Use C++ exception handling.
1634         * python/py-objfile.c: Use C++ exception handling.
1635         * python/py-linetable.c: Use C++ exception handling.
1636         * python/py-lazy-string.c: Use C++ exception handling.
1637         * python/py-infthread.c: Use C++ exception handling.
1638         * python/py-inferior.c: Use C++ exception handling.
1639         * python/py-gdb-readline.c: Use C++ exception handling.
1640         * python/py-framefilter.c: Use C++ exception handling.
1641         * python/py-frame.c: Use C++ exception handling.
1642         * python/py-finishbreakpoint.c: Use C++ exception handling.
1643         * python/py-cmd.c: Use C++ exception handling.
1644         * python/py-breakpoint.c: Use C++ exception handling.
1645         * python/py-arch.c: Use C++ exception handling.
1646         * printcmd.c: Use C++ exception handling.
1647         * ppc-linux-tdep.c: Use C++ exception handling.
1648         * parse.c: Use C++ exception handling.
1649         * p-valprint.c: Use C++ exception handling.
1650         * objc-lang.c: Use C++ exception handling.
1651         * mi/mi-main.c: Use C++ exception handling.
1652         * mi/mi-interp.c: Use C++ exception handling.
1653         * mi/mi-cmd-stack.c: Use C++ exception handling.
1654         * mi/mi-cmd-break.c: Use C++ exception handling.
1655         * main.c: Use C++ exception handling.
1656         * linux-thread-db.c: Use C++ exception handling.
1657         * linux-tdep.c: Use C++ exception handling.
1658         * linux-nat.c: Use C++ exception handling.
1659         * linux-fork.c: Use C++ exception handling.
1660         * linespec.c: Use C++ exception handling.
1661         * language.c: Use C++ exception handling.
1662         * jit.c: Use C++ exception handling.
1663         * infrun.c: Use C++ exception handling.
1664         * infcmd.c: Use C++ exception handling.
1665         * infcall.c: Use C++ exception handling.
1666         * inf-loop.c: Use C++ exception handling.
1667         * i386-tdep.c: Use C++ exception handling.
1668         * i386-linux-tdep.c: Use C++ exception handling.
1669         * guile/scm-value.c: Use C++ exception handling.
1670         * guile/scm-type.c: Use C++ exception handling.
1671         * guile/scm-symtab.c: Use C++ exception handling.
1672         * guile/scm-symbol.c: Use C++ exception handling.
1673         * guile/scm-pretty-print.c: Use C++ exception handling.
1674         * guile/scm-ports.c: Use C++ exception handling.
1675         * guile/scm-param.c: Use C++ exception handling.
1676         * guile/scm-math.c: Use C++ exception handling.
1677         * guile/scm-lazy-string.c: Use C++ exception handling.
1678         * guile/scm-frame.c: Use C++ exception handling.
1679         * guile/scm-disasm.c: Use C++ exception handling.
1680         * guile/scm-cmd.c: Use C++ exception handling.
1681         * guile/scm-breakpoint.c: Use C++ exception handling.
1682         * guile/scm-block.c: Use C++ exception handling.
1683         * guile/guile-internal.h: Use C++ exception handling.
1684         * gnu-v3-abi.c: Use C++ exception handling.
1685         * gdbtypes.c: Use C++ exception handling.
1686         * frame.c: Use C++ exception handling.
1687         * frame-unwind.c: Use C++ exception handling.
1688         * fbsd-tdep.c: Use C++ exception handling.
1689         * f-valprint.c: Use C++ exception handling.
1690         * exec.c: Use C++ exception handling.
1691         * event-top.c: Use C++ exception handling.
1692         * event-loop.c: Use C++ exception handling.
1693         * eval.c: Use C++ exception handling.
1694         * dwarf2read.c: Use C++ exception handling.
1695         * dwarf2loc.c: Use C++ exception handling.
1696         * dwarf2-frame.c: Use C++ exception handling.
1697         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1698         * dwarf-index-write.c: Use C++ exception handling.
1699         * dwarf-index-cache.c: Use C++ exception handling.
1700         * dtrace-probe.c: Use C++ exception handling.
1701         * disasm-selftests.c: Use C++ exception handling.
1702         * darwin-nat.c: Use C++ exception handling.
1703         * cp-valprint.c: Use C++ exception handling.
1704         * cp-support.c: Use C++ exception handling.
1705         * cp-abi.c: Use C++ exception handling.
1706         * corelow.c: Use C++ exception handling.
1707         * completer.c: Use C++ exception handling.
1708         * compile/compile-object-run.c: Use C++ exception handling.
1709         * compile/compile-object-load.c: Use C++ exception handling.
1710         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1711         * compile/compile-c-symbols.c: Use C++ exception handling.
1712         * common/selftest.c: Use C++ exception handling.
1713         * common/new-op.c: Use C++ exception handling.
1714         * cli/cli-script.c: Use C++ exception handling.
1715         * cli/cli-interp.c: Use C++ exception handling.
1716         * cli/cli-cmds.c: Use C++ exception handling.
1717         * c-varobj.c: Use C++ exception handling.
1718         * btrace.c: Use C++ exception handling.
1719         * breakpoint.c: Use C++ exception handling.
1720         * break-catch-throw.c: Use C++ exception handling.
1721         * arch-utils.c: Use C++ exception handling.
1722         * amd64-tdep.c: Use C++ exception handling.
1723         * ada-valprint.c: Use C++ exception handling.
1724         * ada-typeprint.c: Use C++ exception handling.
1725         * ada-lang.c: Use C++ exception handling.
1726         * aarch64-tdep.c: Use C++ exception handling.
1727
1728 2019-04-08  Tom Tromey  <tom@tromey.com>
1729
1730         * xml-support.c (gdb_xml_parser::parse): Update.
1731         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1732         * value.c (show_convenience): Update.
1733         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1734         (test_parse_flags_qcs): Update.
1735         * thread.c (thr_try_catch_cmd): Update.
1736         * target.c (target_translate_tls_address): Update.
1737         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1738         (info_frame_command_core, frame_apply_command_count): Update.
1739         * rust-exp.y (rust_lex_exception_test): Update.
1740         * riscv-tdep.c (riscv_print_one_register_info): Update.
1741         * remote.c (remote_target::enable_btrace): Update.
1742         * record-btrace.c (record_btrace_enable_warn): Update.
1743         * python/py-utils.c (gdbpy_convert_exception): Update.
1744         * printcmd.c (do_one_display, print_variable_and_value): Update.
1745         * mi/mi-main.c (mi_print_exception): Update.
1746         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1747         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1748         * linux-nat.c (linux_nat_target::attach): Update.
1749         * linux-fork.c (class scoped_switch_fork_info): Update.
1750         * infrun.c (displaced_step_prepare): Update.
1751         * infcall.c (call_function_by_hand_dummy): Update.
1752         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1753         * gnu-v3-abi.c (print_one_vtable): Update.
1754         * frame.c (get_prev_frame_always): Update.
1755         * f-valprint.c (info_common_command_for_block): Update.
1756         * exec.c (try_open_exec_file): Update.
1757         * exceptions.c (print_exception, exception_print)
1758         (exception_fprintf, exception_print_same): Update.
1759         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1760         * dwarf-index-cache.c (index_cache::store)
1761         (index_cache::lookup_gdb_index): Update.
1762         * darwin-nat.c (maybe_cache_shell): Update.
1763         * cp-valprint.c (cp_print_value_fields): Update.
1764         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1765         (gcc_cplus_symbol_address): Update.
1766         * compile/compile-c-symbols.c (gcc_convert_symbol)
1767         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1768         * common/selftest.c: Update.
1769         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1770         a std::string.
1771         (exception_try_scope_entry, exception_try_scope_exit): Don't
1772         declare.
1773         (struct exception_try_scope): Remove.
1774         (TRY): Don't use exception_try_scope.
1775         (struct gdb_exception): Add constructor, operator=.
1776         <what>: New method.
1777         (struct gdb_exception_RETURN_MASK_ALL)
1778         (struct gdb_exception_RETURN_MASK_ERROR)
1779         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1780         (struct gdb_quit_bad_alloc): Update.
1781         * common/common-exceptions.c (exception_none): Change
1782         initializer.
1783         (struct catcher) <state, exception>: Initialize inline.
1784         <prev>: Remove member.
1785         (current_catcher): Remove.
1786         (catchers): New global.
1787         (exceptions_state_mc_init): Simplify.
1788         (catcher_pop): Remove.
1789         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1790         (try_scope_depth, exception_try_scope_entry)
1791         (exception_try_scope_exit): Remove.
1792         (throw_exception_sjlj): Update.
1793         (exception_messages, exception_messages_size): Remove.
1794         (throw_it): Simplify.
1795         (gdb_exception_sliced_copy): Remove.
1796         (throw_exception_cxx): Update.
1797         * cli/cli-script.c (script_from_file): Update.
1798         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1799         Update.
1800         * ada-valprint.c (ada_val_print): Update.
1801         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1802         (create_excep_cond_exprs): Update.
1803
1804 2019-04-08  Tom Tromey  <tom@tromey.com>
1805
1806         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1807         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1808         (TRY, CATCH, END_CATCH): Remove some definitions.
1809         * common/common-exceptions.c: Don't use GDB_XCPT.
1810         (catcher_list_size): Remove.
1811         (throw_exception, throw_it): Simplify.
1812
1813 2019-04-05  Tom Tromey  <tom@tromey.com>
1814
1815         Revert the header-sorting patch.
1816         * ft32-tdep.c: Revert.
1817         * frv-tdep.c: Revert.
1818         * frv-linux-tdep.c: Revert.
1819         * frame.c: Revert.
1820         * frame-unwind.c: Revert.
1821         * frame-base.c: Revert.
1822         * fork-child.c: Revert.
1823         * findvar.c: Revert.
1824         * findcmd.c: Revert.
1825         * filesystem.c: Revert.
1826         * filename-seen-cache.h: Revert.
1827         * filename-seen-cache.c: Revert.
1828         * fbsd-tdep.c: Revert.
1829         * fbsd-nat.h: Revert.
1830         * fbsd-nat.c: Revert.
1831         * f-valprint.c: Revert.
1832         * f-typeprint.c: Revert.
1833         * f-lang.c: Revert.
1834         * extension.h: Revert.
1835         * extension.c: Revert.
1836         * extension-priv.h: Revert.
1837         * expprint.c: Revert.
1838         * exec.h: Revert.
1839         * exec.c: Revert.
1840         * exceptions.c: Revert.
1841         * event-top.c: Revert.
1842         * event-loop.c: Revert.
1843         * eval.c: Revert.
1844         * elfread.c: Revert.
1845         * dwarf2read.h: Revert.
1846         * dwarf2read.c: Revert.
1847         * dwarf2loc.c: Revert.
1848         * dwarf2expr.h: Revert.
1849         * dwarf2expr.c: Revert.
1850         * dwarf2-frame.c: Revert.
1851         * dwarf2-frame-tailcall.c: Revert.
1852         * dwarf-index-write.h: Revert.
1853         * dwarf-index-write.c: Revert.
1854         * dwarf-index-common.c: Revert.
1855         * dwarf-index-cache.h: Revert.
1856         * dwarf-index-cache.c: Revert.
1857         * dummy-frame.c: Revert.
1858         * dtrace-probe.c: Revert.
1859         * disasm.h: Revert.
1860         * disasm.c: Revert.
1861         * disasm-selftests.c: Revert.
1862         * dictionary.c: Revert.
1863         * dicos-tdep.c: Revert.
1864         * demangle.c: Revert.
1865         * dcache.h: Revert.
1866         * dcache.c: Revert.
1867         * darwin-nat.h: Revert.
1868         * darwin-nat.c: Revert.
1869         * darwin-nat-info.c: Revert.
1870         * d-valprint.c: Revert.
1871         * d-namespace.c: Revert.
1872         * d-lang.c: Revert.
1873         * ctf.c: Revert.
1874         * csky-tdep.c: Revert.
1875         * csky-linux-tdep.c: Revert.
1876         * cris-tdep.c: Revert.
1877         * cris-linux-tdep.c: Revert.
1878         * cp-valprint.c: Revert.
1879         * cp-support.c: Revert.
1880         * cp-namespace.c: Revert.
1881         * cp-abi.c: Revert.
1882         * corelow.c: Revert.
1883         * corefile.c: Revert.
1884         * continuations.c: Revert.
1885         * completer.h: Revert.
1886         * completer.c: Revert.
1887         * complaints.c: Revert.
1888         * coffread.c: Revert.
1889         * coff-pe-read.c: Revert.
1890         * cli-out.h: Revert.
1891         * cli-out.c: Revert.
1892         * charset.c: Revert.
1893         * c-varobj.c: Revert.
1894         * c-valprint.c: Revert.
1895         * c-typeprint.c: Revert.
1896         * c-lang.c: Revert.
1897         * buildsym.c: Revert.
1898         * buildsym-legacy.c: Revert.
1899         * build-id.h: Revert.
1900         * build-id.c: Revert.
1901         * btrace.c: Revert.
1902         * bsd-uthread.c: Revert.
1903         * breakpoint.h: Revert.
1904         * breakpoint.c: Revert.
1905         * break-catch-throw.c: Revert.
1906         * break-catch-syscall.c: Revert.
1907         * break-catch-sig.c: Revert.
1908         * blockframe.c: Revert.
1909         * block.c: Revert.
1910         * bfin-tdep.c: Revert.
1911         * bfin-linux-tdep.c: Revert.
1912         * bfd-target.c: Revert.
1913         * bcache.c: Revert.
1914         * ax-general.c: Revert.
1915         * ax-gdb.h: Revert.
1916         * ax-gdb.c: Revert.
1917         * avr-tdep.c: Revert.
1918         * auxv.c: Revert.
1919         * auto-load.c: Revert.
1920         * arm-wince-tdep.c: Revert.
1921         * arm-tdep.c: Revert.
1922         * arm-symbian-tdep.c: Revert.
1923         * arm-pikeos-tdep.c: Revert.
1924         * arm-obsd-tdep.c: Revert.
1925         * arm-nbsd-tdep.c: Revert.
1926         * arm-nbsd-nat.c: Revert.
1927         * arm-linux-tdep.c: Revert.
1928         * arm-linux-nat.c: Revert.
1929         * arm-fbsd-tdep.c: Revert.
1930         * arm-fbsd-nat.c: Revert.
1931         * arm-bsd-tdep.c: Revert.
1932         * arch-utils.c: Revert.
1933         * arc-tdep.c: Revert.
1934         * arc-newlib-tdep.c: Revert.
1935         * annotate.h: Revert.
1936         * annotate.c: Revert.
1937         * amd64-windows-tdep.c: Revert.
1938         * amd64-windows-nat.c: Revert.
1939         * amd64-tdep.c: Revert.
1940         * amd64-sol2-tdep.c: Revert.
1941         * amd64-obsd-tdep.c: Revert.
1942         * amd64-obsd-nat.c: Revert.
1943         * amd64-nbsd-tdep.c: Revert.
1944         * amd64-nbsd-nat.c: Revert.
1945         * amd64-nat.c: Revert.
1946         * amd64-linux-tdep.c: Revert.
1947         * amd64-linux-nat.c: Revert.
1948         * amd64-fbsd-tdep.c: Revert.
1949         * amd64-fbsd-nat.c: Revert.
1950         * amd64-dicos-tdep.c: Revert.
1951         * amd64-darwin-tdep.c: Revert.
1952         * amd64-bsd-nat.c: Revert.
1953         * alpha-tdep.c: Revert.
1954         * alpha-obsd-tdep.c: Revert.
1955         * alpha-nbsd-tdep.c: Revert.
1956         * alpha-mdebug-tdep.c: Revert.
1957         * alpha-linux-tdep.c: Revert.
1958         * alpha-linux-nat.c: Revert.
1959         * alpha-bsd-tdep.c: Revert.
1960         * alpha-bsd-nat.c: Revert.
1961         * aix-thread.c: Revert.
1962         * agent.c: Revert.
1963         * addrmap.c: Revert.
1964         * ada-varobj.c: Revert.
1965         * ada-valprint.c: Revert.
1966         * ada-typeprint.c: Revert.
1967         * ada-tasks.c: Revert.
1968         * ada-lang.c: Revert.
1969         * aarch64-tdep.c: Revert.
1970         * aarch64-ravenscar-thread.c: Revert.
1971         * aarch64-newlib-tdep.c: Revert.
1972         * aarch64-linux-tdep.c: Revert.
1973         * aarch64-linux-nat.c: Revert.
1974         * aarch64-fbsd-tdep.c: Revert.
1975         * aarch64-fbsd-nat.c: Revert.
1976         * aarch32-linux-nat.c: Revert.
1977
1978 2019-04-05  Tom Tromey  <tom@tromey.com>
1979
1980         * ft32-tdep.c: Sort headers.
1981         * frv-tdep.c: Sort headers.
1982         * frv-linux-tdep.c: Sort headers.
1983         * frame.c: Sort headers.
1984         * frame-unwind.c: Sort headers.
1985         * frame-base.c: Sort headers.
1986         * fork-child.c: Sort headers.
1987         * findvar.c: Sort headers.
1988         * findcmd.c: Sort headers.
1989         * filesystem.c: Sort headers.
1990         * filename-seen-cache.h: Sort headers.
1991         * filename-seen-cache.c: Sort headers.
1992         * fbsd-tdep.c: Sort headers.
1993         * fbsd-nat.h: Sort headers.
1994         * fbsd-nat.c: Sort headers.
1995         * f-valprint.c: Sort headers.
1996         * f-typeprint.c: Sort headers.
1997         * f-lang.c: Sort headers.
1998         * extension.h: Sort headers.
1999         * extension.c: Sort headers.
2000         * extension-priv.h: Sort headers.
2001         * expprint.c: Sort headers.
2002         * exec.h: Sort headers.
2003         * exec.c: Sort headers.
2004         * exceptions.c: Sort headers.
2005         * event-top.c: Sort headers.
2006         * event-loop.c: Sort headers.
2007         * eval.c: Sort headers.
2008         * elfread.c: Sort headers.
2009         * dwarf2read.h: Sort headers.
2010         * dwarf2read.c: Sort headers.
2011         * dwarf2loc.c: Sort headers.
2012         * dwarf2expr.h: Sort headers.
2013         * dwarf2expr.c: Sort headers.
2014         * dwarf2-frame.c: Sort headers.
2015         * dwarf2-frame-tailcall.c: Sort headers.
2016         * dwarf-index-write.h: Sort headers.
2017         * dwarf-index-write.c: Sort headers.
2018         * dwarf-index-common.c: Sort headers.
2019         * dwarf-index-cache.h: Sort headers.
2020         * dwarf-index-cache.c: Sort headers.
2021         * dummy-frame.c: Sort headers.
2022         * dtrace-probe.c: Sort headers.
2023         * disasm.h: Sort headers.
2024         * disasm.c: Sort headers.
2025         * disasm-selftests.c: Sort headers.
2026         * dictionary.c: Sort headers.
2027         * dicos-tdep.c: Sort headers.
2028         * demangle.c: Sort headers.
2029         * dcache.h: Sort headers.
2030         * dcache.c: Sort headers.
2031         * darwin-nat.h: Sort headers.
2032         * darwin-nat.c: Sort headers.
2033         * darwin-nat-info.c: Sort headers.
2034         * d-valprint.c: Sort headers.
2035         * d-namespace.c: Sort headers.
2036         * d-lang.c: Sort headers.
2037         * ctf.c: Sort headers.
2038         * csky-tdep.c: Sort headers.
2039         * csky-linux-tdep.c: Sort headers.
2040         * cris-tdep.c: Sort headers.
2041         * cris-linux-tdep.c: Sort headers.
2042         * cp-valprint.c: Sort headers.
2043         * cp-support.c: Sort headers.
2044         * cp-namespace.c: Sort headers.
2045         * cp-abi.c: Sort headers.
2046         * corelow.c: Sort headers.
2047         * corefile.c: Sort headers.
2048         * continuations.c: Sort headers.
2049         * completer.h: Sort headers.
2050         * completer.c: Sort headers.
2051         * complaints.c: Sort headers.
2052         * coffread.c: Sort headers.
2053         * coff-pe-read.c: Sort headers.
2054         * cli-out.h: Sort headers.
2055         * cli-out.c: Sort headers.
2056         * charset.c: Sort headers.
2057         * c-varobj.c: Sort headers.
2058         * c-valprint.c: Sort headers.
2059         * c-typeprint.c: Sort headers.
2060         * c-lang.c: Sort headers.
2061         * buildsym.c: Sort headers.
2062         * buildsym-legacy.c: Sort headers.
2063         * build-id.h: Sort headers.
2064         * build-id.c: Sort headers.
2065         * btrace.c: Sort headers.
2066         * bsd-uthread.c: Sort headers.
2067         * breakpoint.h: Sort headers.
2068         * breakpoint.c: Sort headers.
2069         * break-catch-throw.c: Sort headers.
2070         * break-catch-syscall.c: Sort headers.
2071         * break-catch-sig.c: Sort headers.
2072         * blockframe.c: Sort headers.
2073         * block.c: Sort headers.
2074         * bfin-tdep.c: Sort headers.
2075         * bfin-linux-tdep.c: Sort headers.
2076         * bfd-target.c: Sort headers.
2077         * bcache.c: Sort headers.
2078         * ax-general.c: Sort headers.
2079         * ax-gdb.h: Sort headers.
2080         * ax-gdb.c: Sort headers.
2081         * avr-tdep.c: Sort headers.
2082         * auxv.c: Sort headers.
2083         * auto-load.c: Sort headers.
2084         * arm-wince-tdep.c: Sort headers.
2085         * arm-tdep.c: Sort headers.
2086         * arm-symbian-tdep.c: Sort headers.
2087         * arm-pikeos-tdep.c: Sort headers.
2088         * arm-obsd-tdep.c: Sort headers.
2089         * arm-nbsd-tdep.c: Sort headers.
2090         * arm-nbsd-nat.c: Sort headers.
2091         * arm-linux-tdep.c: Sort headers.
2092         * arm-linux-nat.c: Sort headers.
2093         * arm-fbsd-tdep.c: Sort headers.
2094         * arm-fbsd-nat.c: Sort headers.
2095         * arm-bsd-tdep.c: Sort headers.
2096         * arch-utils.c: Sort headers.
2097         * arc-tdep.c: Sort headers.
2098         * arc-newlib-tdep.c: Sort headers.
2099         * annotate.h: Sort headers.
2100         * annotate.c: Sort headers.
2101         * amd64-windows-tdep.c: Sort headers.
2102         * amd64-windows-nat.c: Sort headers.
2103         * amd64-tdep.c: Sort headers.
2104         * amd64-sol2-tdep.c: Sort headers.
2105         * amd64-obsd-tdep.c: Sort headers.
2106         * amd64-obsd-nat.c: Sort headers.
2107         * amd64-nbsd-tdep.c: Sort headers.
2108         * amd64-nbsd-nat.c: Sort headers.
2109         * amd64-nat.c: Sort headers.
2110         * amd64-linux-tdep.c: Sort headers.
2111         * amd64-linux-nat.c: Sort headers.
2112         * amd64-fbsd-tdep.c: Sort headers.
2113         * amd64-fbsd-nat.c: Sort headers.
2114         * amd64-dicos-tdep.c: Sort headers.
2115         * amd64-darwin-tdep.c: Sort headers.
2116         * amd64-bsd-nat.c: Sort headers.
2117         * alpha-tdep.c: Sort headers.
2118         * alpha-obsd-tdep.c: Sort headers.
2119         * alpha-nbsd-tdep.c: Sort headers.
2120         * alpha-mdebug-tdep.c: Sort headers.
2121         * alpha-linux-tdep.c: Sort headers.
2122         * alpha-linux-nat.c: Sort headers.
2123         * alpha-bsd-tdep.c: Sort headers.
2124         * alpha-bsd-nat.c: Sort headers.
2125         * aix-thread.c: Sort headers.
2126         * agent.c: Sort headers.
2127         * addrmap.c: Sort headers.
2128         * ada-varobj.c: Sort headers.
2129         * ada-valprint.c: Sort headers.
2130         * ada-typeprint.c: Sort headers.
2131         * ada-tasks.c: Sort headers.
2132         * ada-lang.c: Sort headers.
2133         * aarch64-tdep.c: Sort headers.
2134         * aarch64-ravenscar-thread.c: Sort headers.
2135         * aarch64-newlib-tdep.c: Sort headers.
2136         * aarch64-linux-tdep.c: Sort headers.
2137         * aarch64-linux-nat.c: Sort headers.
2138         * aarch64-fbsd-tdep.c: Sort headers.
2139         * aarch64-fbsd-nat.c: Sort headers.
2140         * aarch32-linux-nat.c: Sort headers.
2141
2142 2019-04-04  Tom Tromey  <tom@tromey.com>
2143
2144         * varobj.c (varobj_create): Update.
2145         * rust-exp.y (struct rust_parser) <update_innermost_block,
2146         lookup_symbol>: New methods.
2147         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2148         Rename.
2149         (rust_parser::rust_lookup_type)
2150         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2151         * printcmd.c (display_command, do_one_display): Update.
2152         * parser-defs.h (struct parser_state) <parser_state>: Add
2153         "tracker" parameter.
2154         (block_tracker): New member.
2155         (class innermost_block_tracker) <innermost_block_tracker>: Add
2156         "types" parameter.
2157         <reset>: Remove method.
2158         (innermost_block): Don't declare.
2159         (null_post_parser): Update.
2160         * parse.c (innermost_block): Remove global.
2161         (write_dollar_variable): Update.
2162         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2163         Remove "tracker_types" parameter.
2164         (parse_expression): Add "tracker" parameter.
2165         (parse_expression_for_completion): Update.
2166         (null_post_parser): Add "tracker" parameter.
2167         * p-exp.y: Update rules.
2168         * m2-exp.y: Update rules.
2169         * language.h (struct language_defn) <la_post_parser>: Add
2170         "tracker" parameter.
2171         * go-exp.y: Update rules.
2172         * f-exp.y: Update rules.
2173         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2174         parameter.
2175         * d-exp.y: Update rules.
2176         * c-exp.y: Update rules.
2177         * breakpoint.c (set_breakpoint_condition): Create an
2178         innermost_block_tracker.
2179         (watch_command_1): Likewise.
2180         * ada-lang.c (resolve): Add "tracker" parameter.
2181         (resolve_subexp): Likewise.
2182         * ada-exp.y (write_var_from_sym): Update.
2183
2184 2019-04-04  Tom Tromey  <tom@tromey.com>
2185
2186         * type-stack.h: New file.
2187         * type-stack.c: New file.
2188         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2189         type-stack.h.
2190         (insert_into_type_stack, insert_type, push_type, push_type_int)
2191         (insert_type_address_space, pop_type, pop_type_int)
2192         (pop_typelist, pop_type_stack, append_type_stack)
2193         (push_type_stack, get_type_stack, push_typelist)
2194         (follow_type_instance_flags, follow_types): Don't declare.
2195         * parse.c (type_stack): Remove global.
2196         (parse_exp_in_context): Update.
2197         (insert_into_type_stack, insert_type, push_type, push_type_int)
2198         (insert_type_address_space, pop_type, pop_type_int)
2199         (pop_typelist, pop_type_stack, append_type_stack)
2200         (push_type_stack, get_type_stack, push_typelist)
2201         (follow_type_instance_flags, follow_types): Remove (moved to
2202         type-stack.c).
2203         * f-exp.y (type_stack): New global.
2204         Update rules.
2205         (push_kind_type, f_parse): Update.
2206         * d-exp.y (type_stack): New global.
2207         Update rules.
2208         (d_parse): Update.
2209         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2210         Update rules.
2211         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2212         (HFILES_NO_SRCDIR): Add type-stack.h.
2213
2214 2019-04-04  Tom Tromey  <tom@tromey.com>
2215
2216         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2217         (rust_parser::convert_ast_to_expression, rust_parse)
2218         (rust_lex_test_completion, rust_lex_tests): Update.
2219         * parser-defs.h (struct expr_completion_state): New.
2220         (struct parser_state) <parser_state>: Add completion parameter.
2221         <mark_struct_expression, mark_completion_tag>: New methods.
2222         <parse_completion, m_completion_state>: New members.
2223         (prefixify_expression, null_post_parser): Update.
2224         (mark_struct_expression, mark_completion_tag): Don't declare.
2225         * parse.c (parse_completion, expout_last_struct)
2226         (expout_tag_completion_type, expout_completion_name): Remove
2227         globals.
2228         (parser_state::mark_struct_expression)
2229         (parser_state::mark_completion_tag): Now methods.
2230         (prefixify_expression): Add last_struct parameter.
2231         (prefixify_subexp): Likewise.
2232         (parse_exp_1): Update.
2233         (parse_exp_in_context): Add cstate parameter.  Update.
2234         (parse_expression_for_completion): Create an
2235         expr_completion_state.
2236         (null_post_parser): Add "completion" parameter.
2237         * p-exp.y: Update rules.
2238         (yylex): Update.
2239         * language.h (struct language_defn) <la_post_parser>: Add
2240         "completing" parameter.
2241         * go-exp.y: Update rules.
2242         (lex_one_token): Update.
2243         * expression.h (parse_completion): Don't declare.
2244         * d-exp.y: Update rules.
2245         (lex_one_token): Update rules.
2246         * c-exp.y: Update rules.
2247         (lex_one_token): Update.
2248         * ada-lang.c (resolve): Add "parse_completion" parameter.
2249         (resolve_subexp): Likewise.
2250         (ada_resolve_function): Likewise.
2251
2252 2019-04-04  Tom Tromey  <tom@tromey.com>
2253
2254         * parser-defs.h (struct parser_state) <start_arglist,
2255         end_arglist>: New methods.
2256         <arglist_len, m_funcall_chain>: New members.
2257         (arglist_len, start_arglist, end_arglist): Don't declare.
2258         * parse.c (arglist_len, funcall_chain): Remove global.
2259         (start_arglist, end_arglist): Remove functions.
2260         (parse_exp_in_context): Update.
2261         * p-exp.y: Update rules.
2262         * m2-exp.y: Update rules.
2263         * go-exp.y: Update rules.
2264         * f-exp.y: Update rules.
2265         * d-exp.y: Update rules.
2266         * c-exp.y: Update rules.
2267
2268 2019-04-04  Tom Tromey  <tom@tromey.com>
2269
2270         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2271         lex_operator, push_back>: New methods.
2272         Update all rules.
2273         (rust_parser::lex_hex, lex_escape): Rename and update.
2274         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2275         (rust_parser::lex_operator): Rename and update.
2276         (rust_parser::lex_number, rustyylex, rustyyerror)
2277         (rust_lex_test_init, rust_lex_test_sequence)
2278         (rust_lex_test_push_back, rust_lex_tests): Update.
2279         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2280         parameter.
2281         <lexptr, prev_lexptr>: New members.
2282         (lexptr, prev_lexptr): Don't declare.
2283         * parse.c (lexptr, prev_lexptr): Remove globals.
2284         (parse_exp_in_context): Update.
2285         * p-exp.y (yylex, yyerror): Update.
2286         * m2-exp.y (parse_number, yylex, yyerror): Update.
2287         * go-exp.y (lex_one_token, yyerror): Update.
2288         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2289         * d-exp.y (lex_one_token, yyerror): Update.
2290         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2291         (lex_one_token, yyerror): Update.
2292         * ada-lex.l (YY_INPUT): Update.
2293         (rewind_to_char): Update.
2294         * ada-exp.y (yyerror): Update.
2295
2296 2019-04-04  Tom Tromey  <tom@tromey.com>
2297
2298         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2299         * parser-defs.h (struct parser_state) <parser_state>: Add new
2300         parameter.
2301         <comma_terminates>: New member.
2302         (comma_terminates): Don't declare global.
2303         * parse.c (comma_terminates): Remove global.
2304         (parse_exp_in_context): Update.
2305         * p-exp.y (yylex): Update.
2306         * m2-exp.y (yylex): Update.
2307         * go-exp.y (lex_one_token): Update.
2308         * f-exp.y (yylex): Update.
2309         * d-exp.y (lex_one_token): Update.
2310         * c-exp.y (lex_one_token): Update.
2311         * ada-lex.l: Update.
2312
2313 2019-04-04  Tom Tromey  <tom@tromey.com>
2314
2315         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2316         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2317         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2318         * parser-defs.h (paren_depth): Don't declare.
2319         * parse.c (paren_depth): Remove global.
2320         (parse_exp_in_context): Update.
2321         * p-exp.y (paren_depth): New global.
2322         (pascal_parse): Initialize it.
2323         * m2-exp.y (paren_depth): New global.
2324         (m2_parse): Initialize it.
2325         * go-exp.y (paren_depth): New global.
2326         (go_parse): Initialize it.
2327         * f-exp.y (paren_depth): New global.
2328         (f_parse): Initialize it.
2329         * d-exp.y (paren_depth): New global.
2330         (d_parse): Initialize it.
2331         * c-exp.y (paren_depth): New global.
2332         (c_parse): Initialize it.
2333         * ada-lex.l (paren_depth): New global.
2334         (lexer_init): Initialize it.
2335
2336 2019-04-04  Tom Tromey  <tom@tromey.com>
2337
2338         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2339         (rust_parser::convert_ast_to_type)
2340         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2341         * parser-defs.h (struct parser_state) <parser_state>: Add
2342         parameters.  Initialize new members.
2343         <expression_context_block, expression_context_pc>: New members.
2344         * parse.c (expression_context_block, expression_context_pc):
2345         Remove globals.
2346         (parse_exp_in_context): Update.
2347         * p-exp.y: Update all rules.
2348         (yylex): Update.
2349         * m2-exp.y: Update all rules.
2350         (yylex): Update.
2351         * go-exp.y (yylex): Update.
2352         * f-exp.y (yylex): Update.
2353         * d-exp.y: Update all rules.
2354         (yylex): Update.
2355         * c-exp.y: Update all rules.
2356         (lex_one_token, classify_name, yylex, c_parse): Update.
2357         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2358
2359 2019-04-04  Tom Tromey  <tom@tromey.com>
2360
2361         * gdbarch.h, gdbarch.c: Rebuild.
2362         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2363         * stap-probe.h:
2364         (struct stap_parse_info): Replace "parser_state" with
2365         "expr_builder".
2366         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2367         (parser_state): New class.
2368         * parse.c (expr_builder): Rename.
2369         (expr_builder::release): Rename.
2370         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2371         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2372         (write_exp_elt_longcst, write_exp_elt_floatcst)
2373         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2374         (write_exp_string_vector, write_exp_bitstring)
2375         (write_exp_msymbol, mark_struct_expression)
2376         (write_dollar_variable)
2377         (insert_type_address_space, increase_expout_size): Replace
2378         "parser_state" with "expr_builder".
2379         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2380         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2381         "parser_state" with "expr_builder".
2382
2383 2019-04-04  Tom Tromey  <tom@tromey.com>
2384
2385         * rust-exp.y: Replace "parse_language" with method call.
2386         * p-exp.y:
2387         (yylex): Replace "parse_language" with method call.
2388         * m2-exp.y:
2389         (yylex): Replace "parse_language" with method call.
2390         * go-exp.y (classify_name): Replace "parse_language" with method
2391         call.
2392         * f-exp.y (yylex): Replace "parse_language" with method call.
2393         * d-exp.y (lex_one_token): Replace "parse_language" with method
2394         call.
2395         * c-exp.y:
2396         (lex_one_token, classify_name, yylex): Replace "parse_language"
2397         with method call.
2398         * ada-exp.y (find_primitive_type, type_char)
2399         (type_system_address): Replace "parse_language" with method call.
2400
2401 2019-04-04  Tom Tromey  <tom@tromey.com>
2402
2403         * rust-exp.y: Replace "parse_gdbarch" with method call.
2404         * parse.c (write_dollar_variable, insert_type_address_space):
2405         Replace "parse_gdbarch" with method call.
2406         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2407         call.
2408         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2409         call.
2410         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2411         "parse_gdbarch" with method call.
2412         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2413         with method call.
2414         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2415         "parse_gdbarch" with method call.
2416         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2417         "parse_gdbarch" with method call.
2418         * c-exp.y (parse_type, parse_number, classify_name): Replace
2419         "parse_gdbarch" with method call.
2420         * ada-lex.l: Replace "parse_gdbarch" with method call.
2421         * ada-exp.y (parse_type, find_primitive_type, type_char)
2422         (type_system_address): Replace "parse_gdbarch" with method call.
2423
2424 2019-04-04  Tom Tromey  <tom@tromey.com>
2425
2426         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2427         * stap-probe.c (stap_parse_argument): Update.
2428         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2429         initial_size parameter.
2430         * rust-exp.y (rust_lex_tests): Update.
2431         * parse.c (parser_state): Update.
2432         (parse_exp_in_context): Update.
2433         * parser-defs.h (struct parser_state) <parser_state>: Remove
2434         "initial_size" parameter.
2435
2436 2019-04-04  Tom Tromey  <tom@tromey.com>
2437
2438         * parser-defs.h (increase_expout_size): Don't declare.
2439         * parse.c (increase_expout_size): Now static.
2440
2441 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2442
2443         * gnu-nat.c (gnu_nat_target::wait): Fix
2444         target_waitstatus_to_string call.
2445
2446 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2447
2448         * eval.c (evaluate_subexp_standard): Handle internal functions
2449         during Fortran function call handling.
2450
2451 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2452
2453         * NEWS: Mention new internal functions.
2454         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2455         (read_base_type): Use dwarf2_init_complex_target_type.
2456         * value.c (creal_internal_fn): New function.
2457         (cimag_internal_fn): New function.
2458         (_initialize_values): Register new internal functions.
2459
2460 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2461
2462         * infrun.c (stop_all_threads): If debug_infrun, always
2463         trace the wait status after wait_one, using
2464         target_waitstatus_to_string and target_pid_to_str.
2465         (handle_inferior_event): Replace various trace of
2466         wait status kind by a single trace.
2467         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2468         wait status kind image by target_waitstatus_to_string.
2469         * target/waitstatus.c (target_waitstatus_to_string): Fix
2470         obsolete comment.
2471
2472 2019-04-01  Tom Tromey  <tromey@adacore.com>
2473
2474         PR symtab/23331:
2475         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2476
2477 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2478             Pedro Alves  <palves@redhat.com>
2479
2480         * top.c (quit_force): Call 'finalize_values'.
2481         * value.c (finalize_values): New function.
2482         * value.h (finalize_values): Declare.
2483
2484 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2485
2486         * NEWS: Announce $_gdb_major and $_gdb_minor.
2487
2488         * top.c (init_gdb_version_vars): New function.
2489         (gdb_init): Call init_gdb_version_vars.
2490
2491 2019-03-29  Tom Tromey  <tromey@adacore.com>
2492
2493         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2494         help text.  Remove dead code.
2495
2496 2019-03-29  Keith Seitz  <keiths@redhat.com>
2497
2498         From Siddhesh Poyarekar:
2499         * f-lang.h (f77_get_upperbound): Return LONGEST.
2500         (f77_get_lowerbound): Likewise.
2501         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2502         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2503         print them.
2504         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2505         plongest to format print it.
2506         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2507         (f77_get_upperbound): Likewise.
2508         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2509         LOWER_BOUND to LONGEST.
2510         (f77_create_arrayprint_offset_tbl): Likewise.
2511
2512 2019-03-29  Keith Seitz  <keiths@redhat.com>
2513
2514         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2515         %s/pulongest for TYPE_LENGTH instead of %d in format
2516         strings.
2517         * ada-typerint.c (ada_print_type): Likewise.
2518         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2519         * compile/compile-c-support.c (generate_register_struct): Likewise.
2520         * gdbtypes.c (recursive_dump_type): Likewise.
2521         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2522         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2523         instead of %d in format strings.
2524         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2525         to std::min to ULONGEST.
2526         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2527         instead of %d in format strings.
2528         * tracepoint.c (info_scope_command): Likewise.
2529         * typeprint.c (print_offset_data::update)
2530         (print_offset_data::finish): Likewise.
2531         * xtensa-tdep.c (xtensa_store_return_value)
2532         (xtensa_push_dummy_call): Likewise.
2533
2534 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2535
2536         * windows-nat.c (display_selector): Fixed format specifications
2537         for 64-bit Cygwin.
2538
2539 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2540
2541         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2542
2543 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2544
2545         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2546         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2547         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2548         (nios2_linux_init_abi): Install it.
2549
2550 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2551
2552         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2553
2554 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2555
2556         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2557
2558 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2559             Tom Tromey  <tromey@adacore.com>
2560
2561         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2562
2563 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2564
2565         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2566         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2567         method to compute the bounds of range types. Also print "[evaluated]"
2568         if the bounds' values come from a dynamic evaluation.
2569
2570 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2573         whitespace when pretty printing is on.
2574
2575 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2576
2577         * ppc-linux-nat.c: Add include.
2578
2579 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2580
2581         * NEWS: Mention AArch64 Pointer Authentication.
2582
2583 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2584
2585         * arm-linux-nat.c: Add include.
2586
2587 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2588
2589         * source-cache.c (source_cache::get_source_lines): Re-read
2590         fullname after calling open_source_file.
2591
2592 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2593
2594         * NEWS: Mention TLS support for FreeBSD.
2595
2596 2019-03-25  Tom Tromey  <tromey@adacore.com>
2597
2598         * minsyms.c (BUNCH_SIZE): Update comment.
2599         (~minimal_symbol_reader): Remove old comment.
2600         (compact_minimal_symbols): Update comment.
2601         (minimal_symbol_reader::install): Remove old comment.  Update
2602         other comments.
2603
2604 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2605
2606         * s390-linux-nat.c: Add include.
2607
2608 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2609
2610         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2611         Call linux_get_hwcap.
2612         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2613         Likewise.
2614         (aarch64_linux_get_hwcap): Remove function.
2615         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2616         declaration.
2617         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2618         linux_get_hwcap.
2619         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2620         * linux-tdep.c (linux_get_hwcap): Add function.
2621         (linux_get_hwcap2): Likewise.
2622         * linux-tdep.h (linux_get_hwcap): Add declaration.
2623         (linux_get_hwcap2): Likewise.
2624         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2625         (ppc_linux_get_hwcap2): Likewise.
2626         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2627         linux_get_hwcap.
2628         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2629         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2630         (ppc_linux_nat_target::read_description): Likewise.
2631         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2632         * s390-linux-nat.c: Likewise.
2633         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2634
2635 2019-03-24  Tom Tromey  <tom@tromey.com>
2636
2637         * ada-lang.c (standard_lookup): Simplify initialization.
2638         (ada_lookup_symbol_nonlocal): Simplify return.
2639         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2640         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2641         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2642         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2643         initialization.
2644         * solib.c (solib_global_lookup): Simplify.
2645         * symtab.c (null_block_symbol): Remove.
2646         (symbol_cache_lookup): Simplify returns.
2647         (lookup_language_this): Simplify returns.
2648         (lookup_symbol_aux): Simplify return.
2649         (lookup_local_symbol): Simplify returns.
2650         (lookup_global_symbol_from_objfile): Simplify return.
2651         (lookup_symbol_in_objfile_symtabs)
2652         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2653         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2654         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2655         * cp-namespace.c (cp_lookup_bare_symbol)
2656         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2657         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2658         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2659         (cp_lookup_symbol_via_imports): Simplify initialization.
2660         (find_symbol_in_baseclass): Likewise.
2661         * symtab.h (null_block_symbol): Remove.
2662         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2663         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2664         (d_lookup_symbol_module): Likewise.
2665         (find_symbol_in_baseclass): Simplify initialization.
2666
2667 2019-03-24  Tom Tromey  <tom@tromey.com>
2668
2669         * expression.h: Don't include symtab.h.
2670         (struct block): Forward declare.
2671
2672 2019-03-24  Tom Tromey  <tom@tromey.com>
2673
2674         * c-exp.y (typebase): Remove casts.
2675         * gdbtypes.c (lookup_unsigned_typename, )
2676         (lookup_signed_typename): Remove cast.
2677         * eval.c (parse_to_comma_and_eval): Remove cast.
2678         * parse.c (write_dollar_variable): Remove cast.
2679         * block.h (struct block) <superblock>: Now const.
2680         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2681         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2682         (map_block): Make "block" const.
2683         * symfile.h (struct quick_symbol_functions)
2684         <map_matching_symbols>: Constify block argument to "callback".
2685         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2686         const.
2687         (find_pc_sect_compunit_symtab): Make "b" const.
2688         (find_symbol_at_address): Likewise.
2689         (search_symbols): Likewise.
2690         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2691         (dw2_debug_names_lookup_symbol): Likewise.
2692         (dw2_map_matching_symbols): Update.
2693         * p-valprint.c (pascal_val_print): Remove "block".
2694         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2695         (aux_add_nonlocal_symbols): Make "block" const.
2696         (resolve_subexp): Remove cast.
2697         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2698         const.
2699         (iterate_over_file_blocks): Likewise.
2700         * f-exp.y (%union) <bval>: Remove.
2701         * coffread.c (patch_opaque_types): Make "b" const.
2702         * spu-tdep.c (spu_catch_start): Make "block" const.
2703         * c-valprint.c (print_unpacked_pointer): Remove "block".
2704         * symmisc.c (dump_symtab_1): Make "b" const.
2705         (block_depth): Make "block" const.
2706         * d-exp.y (%union) <bval>: Remove.
2707         * cp-support.h (cp_lookup_rtti_type): Update.
2708         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2709         * psymtab.c (psym_lookup_symbol): Make "block" const.
2710         (maintenance_check_psymtabs): Make "b" const.
2711         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2712         (enumerate_locals, enumerate_args): Update.
2713         * python/py-symtab.c (stpy_global_block): Make "block" const.
2714         (stpy_static_block): Likewise.
2715         * inline-frame.c (block_starting_point_at): Make "new_block"
2716         const.
2717         * block.c (find_block_in_blockvector): Make return type const.
2718         (blockvector_for_pc_sect): Make "b" const.
2719         (find_block_in_blockvector): Make "b" const.
2720
2721 2019-03-23  Tom Tromey  <tom@tromey.com>
2722
2723         * varobj.c (varobj_create): Update.
2724         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2725         * printcmd.c (display_command, do_one_display): Don't reset
2726         innermost_block.
2727         * parser-defs.h (enum innermost_block_tracker_type): Move to
2728         expression.h.
2729         (innermost_block): Update comment.
2730         * parse.c (parse_exp_1): Add tracker_types parameter.
2731         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2732         tracker_types parameter.  Reset innermost_block.
2733         (parse_exp_in_context): Remove.
2734         (parse_expression_for_completion): Update.
2735         * objfiles.c (~objfile): Don't reset expression_context_block or
2736         innermost_block.
2737         * expression.h (enum innermost_block_tracker_type): Move from
2738         parser-defs.h.
2739         (parse_exp_1): Add tracker_types parameter.
2740         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2741         reset innermost_block.
2742
2743 2019-03-23  Tom Tromey  <tom@tromey.com>
2744
2745         * objfiles.h: Include bcache.h.
2746
2747 2019-03-23  Tom Tromey  <tom@tromey.com>
2748
2749         * linespec.c (get_current_search_block): Use
2750         scoped_restore_current_language.
2751         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2752
2753 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2754             Jiong Wang  <jiong.wang@arm.com>
2755
2756         * aarch64-linux-tdep.c
2757         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2758         section.
2759         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2760
2761 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2762             Jiong Wang  <jiong.wang@arm.com>
2763
2764         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2765         instructions.
2766         (aarch64_analyze_prologue_test): Add PACIASP test.
2767         (aarch64_prologue_prev_register): Unmask PC value.
2768
2769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2770             Jiong Wang  <jiong.wang@arm.com>
2771
2772         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2773         (aarch64_dwarf2_prev_register): Unmask PC value.
2774         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2775         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2776         DW_CFA_AARCH64_negate_ra_state.
2777         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2778
2779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2780             Jiong Wang  <jiong.wang@arm.com>
2781
2782         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2783         registers.
2784         (aarch64_pseudo_register_name): Likewise.
2785         (aarch64_pseudo_register_type): Likewise.
2786         (aarch64_pseudo_register_reggroup_p): Likewise.
2787         (aarch64_gdbarch_init): Add pauth registers.
2788         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2789         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2790         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2791         (struct gdbarch_tdep): Add regnum for ra_state.
2792
2793 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2794             Jiong Wang  <jiong.wang@arm.com>
2795
2796         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2797
2798 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2799             Jiong Wang  <jiong.wang@arm.com>
2800
2801         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2802         function.
2803         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2804         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2805         (aarch64_gdbarch_init): Add puth registers.
2806         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2807         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2808         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2809
2810 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2811             Jiong Wang  <jiong.wang@arm.com>
2812
2813         * aarch64-linux-nat.c
2814         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2815         * aarch64-linux-tdep.c
2816         (aarch64_linux_core_read_description): Likewise.
2817         (aarch64_linux_get_hwcap): New function.
2818         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2819         (aarch64_linux_get_hwcap): New declaration.
2820
2821 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2822             Jiong Wang  <jiong.wang@arm.com>
2823
2824         * aarch64-linux-nat.c
2825         (aarch64_linux_nat_target::read_description): Add pauth param.
2826         * aarch64-linux-tdep.c
2827         (aarch64_linux_core_read_description): Likewise.
2828         * aarch64-tdep.c (struct target_desc): Add in pauth.
2829         (aarch64_read_description): Add pauth param.
2830         (aarch64_gdbarch_init): Likewise.
2831         * aarch64-tdep.h (aarch64_read_description): Likewise.
2832         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2833         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2834         * features/Makefile: Add new files.
2835         * features/aarch64-pauth.c: New file.
2836         * features/aarch64-pauth.xml: New file.
2837
2838 2019-03-20  Tom Tromey  <tromey@adacore.com>
2839
2840         * infrun.c (handle_inferior_event): Rename from
2841         handle_inferior_event_1.  Create a scoped_value_mark.
2842         (handle_inferior_event): Remove.
2843
2844 2019-03-19  Tom Tromey  <tromey@adacore.com>
2845
2846         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2847         * infrun.h (print_stop_event): Add "displays" parameter.
2848         * infrun.c (print_stop_event): Add "displays" parameter.
2849
2850 2019-03-19  Pedro Alves  <palves@redhat.com>
2851
2852         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2853         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2854         to -1.  Fix TABs vs spaces.
2855         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2856         * tui/tui-out.h (tui_ui_out) Add intro comments.
2857         <m_line, m_start_of_line>: In-class initialize, and add describing
2858         comment.
2859
2860 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2861
2862         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2863         variable names.
2864         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2865
2866 2019-03-18  Pedro Alves  <palves@redhat.com>
2867             Eli Zaretskii <eliz@gnu.org>
2868
2869         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2870         m_line and m_start_of_line.
2871
2872 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2873
2874         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2875         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2876         it returns a newline.  This fixes a regression in TU mode, whereby
2877         the next line is output on the same screen line as the user input.
2878
2879 2019-03-18  Tom Tromey  <tromey@adacore.com>
2880
2881         * minsyms.c (minimal_symbol_reader::install): Remove call to
2882         obstack_blank.
2883
2884 2019-03-18  Pedro Alves  <palves@redhat.com>
2885
2886         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2887         New globals.
2888         (apply_style): New, factored out from ...
2889         (apply_ansi_escape): ... this.  Handle reverse video mode.
2890         (tui_set_reverse_mode): New function.
2891         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2892         * tui/tui-winsource.c (tui_show_source_line): Use
2893         tui_set_reverse_mode instead of setting A_STANDOUT.
2894         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2895         New setter methods.
2896
2897 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2898
2899         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2900         Handle tabs.
2901
2902 2019-03-18  Tom Tromey  <tromey@adacore.com>
2903
2904         * ada-lang.c (empty_array): Add "high" parameter.
2905         (ada_evaluate_subexp): Update.
2906
2907 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2908
2909         * unittests/string_view-selftests.c: Define
2910         _initialize_string_view_selftests unconditionally.
2911
2912 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2913
2914         PR gdb/24350
2915         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2916
2917 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2918
2919         PR gdb/24351
2920         * windows-nat.c (display_selector): Fix format specifiers.
2921
2922 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2923
2924         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2925         tui_refill_source_window instead of tui_refresh_win, to update the
2926         current execution line.  This fixes redisplay of the current line
2927         when stepping through the code with "next" or "step".
2928
2929 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2930
2931         * source-cache.c (source_cache::get_source_lines): Call
2932         find_source_lines to initialize s->nlines.  This fixes vertical
2933         scrolling of TUI source window when the DOWN arrow is pressed.
2934
2935 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2936
2937         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2938         linux-thread-db.c (_initialize_thread_db): Likewise.
2939
2940 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2941
2942         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2943         wclrtoeol in tui_show_source_line".  This reverts changes made in
2944         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2945
2946 2019-03-15  Tom Tromey  <tom@tromey.com>
2947
2948         * symtab.h (struct minimal_symbol): Derive from
2949         general_symbol_info.
2950         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2951         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2952         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2953         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2954         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2955         (MSYMBOL_SEARCH_NAME): Update.
2956         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2957         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2958         * minsyms.c (minimal_symbol_reader::record_full): Update.
2959
2960 2019-03-15  Tom Tromey  <tom@tromey.com>
2961
2962         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2963
2964 2019-03-15  Tom Tromey  <tom@tromey.com>
2965
2966         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2967         unique_xmalloc_ptr.
2968         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2969         Update.
2970         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2971         (build_minimal_symbol_hash_tables)
2972         (minimal_symbol_reader::install): Update.
2973
2974 2019-03-15  Tom Tromey  <tom@tromey.com>
2975
2976         * symtab.c (create_demangled_names_hash): Update.
2977         (symbol_set_names): Update.
2978         * objfiles.h (struct objfile_per_bfd_storage)
2979         <demangled_names_hash>: Now an htab_up.
2980         * objfiles.c (objfile_per_bfd_storage): Simplify.
2981
2982 2019-03-15  Tom Tromey  <tom@tromey.com>
2983
2984         * objfiles.h (struct objfile_per_bfd_storage): Declare
2985         destructor.
2986         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2987         New.
2988         (get_objfile_bfd_data): Use new.  Don't initialize
2989         language_of_main.
2990         (free_objfile_per_bfd_storage): Remove.
2991         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2992
2993 2019-03-15  Tom Tromey  <tom@tromey.com>
2994
2995         * symfile.c (reread_symbols): Update.
2996         * objfiles.c (objfile::objfile): Update.
2997         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2998         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2999         comment.
3000         (minimal_symbol_reader::install): Update.
3001         (terminate_minimal_symbol_table): Remove.
3002         * jit.c (jit_object_close_impl): Update.
3003
3004 2019-03-15  Tom Tromey  <tom@tromey.com>
3005
3006         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3007         initializations.
3008
3009 2019-03-15  Tom Tromey  <tom@tromey.com>
3010
3011         * objfiles.h (struct objfile_per_bfd_storage)
3012         <demangled_hash_languages>: Now a bitset.
3013         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3014         (lookup_minimal_symbol): Update.
3015
3016 2019-03-15  Tom Tromey  <tom@tromey.com>
3017
3018         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3019         Don't return the symbol.
3020         * coffread.c (record_minimal_symbol): Use record_full.
3021
3022 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3023
3024         The MS-Windows port of ncurses fails to switch to a color pair if
3025         one or both of the colors are the implicit default colors.  This
3026         change records the default colors when TUI is initialized, and
3027         then specifies them explicitly when a color pair uses the default
3028         colors.  This allows color styling in TUI mode on MS-Windows.
3029
3030         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3031         ncurses_norm_attr.
3032         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3033         colors in ncurses_norm_attr.
3034         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3035         "none", replace it with the default color recorded in
3036         ncurses_norm_attr.
3037
3038 2019-03-14  Tom Tromey  <tromey@adacore.com>
3039
3040         * source-cache.h (class source_cache) <get_source_lines>: Return
3041         std::string.
3042         * source-cache.c (source_cache::extract_lines): Handle case where
3043         first_pos==npos.  Return std::string.
3044         (source_cache::get_source_lines): Update.
3045
3046 2019-03-14  Tom Tromey  <tromey@adacore.com>
3047
3048         * NEWS: Add item for "style sources" commands.
3049         * source-cache.c (source_cache::get_source_lines): Check
3050         source_styling.
3051         * cli/cli-style.c (source_styling): New global.
3052         (_initialize_cli_style): Add "style sources" commands.
3053         (show_style_sources): New function.
3054         * cli/cli-style.h (source_styling): Declare.
3055
3056 2019-03-14  Pedro Alves  <palves@redhat.com>
3057             Tom Tromey  <tromey@adacore.com>
3058
3059         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3060         * tui/tui-winsource.c (tui_refill_source_window): New function,
3061         from...
3062         (tui_horizontal_source_scroll): ... here.  Move some logic.
3063         * cli/cli-style.c (set_style_enabled): Notify new observable.
3064         * tui/tui-hooks.c (tui_redisplay_source): New function.
3065         (tui_attach_detach_observers): Attach or detach
3066         tui_redisplay_source.
3067         * observable.h (source_styling_changed): New observable.
3068         * observable.c: Define source_styling_changed observable.
3069
3070 2019-03-13  Tom Tromey  <tromey@adacore.com>
3071
3072         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3073         (i386_gnu_nat_target::store_registers): Update.
3074         * target-debug.h (target_debug_print_std_string): New macro.
3075         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3076         * windows-tdep.c (display_one_tib): Update.
3077         * tui/tui-stack.c (tui_make_status_line): Update.
3078         * top.c (print_inferior_quit_action): Update.
3079         * thread.c (thr_try_catch_cmd): Update.
3080         (add_thread_with_info): Update.
3081         (thread_target_id_str): Update.
3082         (thr_try_catch_cmd): Update.
3083         (thread_command): Update.
3084         (thread_find_command): Update.
3085         * record-btrace.c (record_btrace_target::info_record)
3086         (record_btrace_resume_thread, record_btrace_target::resume)
3087         (record_btrace_cancel_resume, record_btrace_step_thread)
3088         (record_btrace_target::wait, record_btrace_target::wait)
3089         (record_btrace_target::wait, record_btrace_target::stop): Update.
3090         * progspace.c (print_program_space): Update.
3091         * process-stratum-target.c
3092         (process_stratum_target::thread_address_space): Update.
3093         * linux-fork.c (linux_fork_mourn_inferior)
3094         (detach_checkpoint_command, info_checkpoints_command)
3095         (linux_fork_context): Update.
3096         (linux_fork_detach): Update.
3097         (class scoped_switch_fork_info): Update.
3098         (delete_checkpoint_command): Update.
3099         * infrun.c (follow_fork_inferior): Update.
3100         (follow_fork_inferior): Update.
3101         (proceed_after_vfork_done): Update.
3102         (handle_vfork_child_exec_or_exit): Update.
3103         (follow_exec): Update.
3104         (displaced_step_prepare_throw): Update.
3105         (displaced_step_restore): Update.
3106         (start_step_over): Update.
3107         (resume_1): Update.
3108         (clear_proceed_status_thread): Update.
3109         (proceed): Update.
3110         (print_target_wait_results): Update.
3111         (do_target_wait): Update.
3112         (context_switch): Update.
3113         (stop_all_threads): Update.
3114         (restart_threads): Update.
3115         (finish_step_over): Update.
3116         (handle_signal_stop): Update.
3117         (switch_back_to_stepped_thread): Update.
3118         (keep_going_pass_signal): Update.
3119         (print_exited_reason): Update.
3120         (normal_stop): Update.
3121         * inferior.c (inferior_pid_to_str): Change return type.
3122         (print_selected_inferior): Update.
3123         (add_inferior): Update.
3124         (detach_inferior): Update.
3125         * dummy-frame.c (fprint_dummy_frames): Update.
3126         * dcache.c (dcache_info_1): Update.
3127         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3128         (btrace_fetch, btrace_clear): Update.
3129         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3130         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3131         type.
3132         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3133         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3134         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3135         * gdbarch.c, gdbarch.h: Rebuild.
3136         * gdbarch.sh (core_pid_to_str): Change return type.
3137         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3138         return type.
3139         (windows_nat_target::pid_to_str): Change return type.
3140         (windows_delete_thread): Update.
3141         (windows_nat_target::attach): Update.
3142         (windows_nat_target::files_info): Update.
3143         * target-delegates.c: Rebuild.
3144         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3145         return type.
3146         (sol_thread_target::pid_to_str): Change return type.
3147         * remote.c (class remote_target) <pid_to_str>: Change return
3148         type.
3149         (remote_target::pid_to_str): Change return type.
3150         (extended_remote_target::attach, remote_target::remote_stop_ns)
3151         (remote_target::remote_notif_remove_queued_reply)
3152         (remote_target::push_stop_reply, remote_target::disable_btrace):
3153         Update.
3154         (extended_remote_target::attach): Update.
3155         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3156         type.
3157         (gdbsim_target::pid_to_str): Change return type.
3158         * ravenscar-thread.c (struct ravenscar_thread_target)
3159         <pid_to_str>: Change return type.
3160         (ravenscar_thread_target::pid_to_str): Change return type.
3161         * procfs.c (class procfs_target) <pid_to_str>: Change return
3162         type.
3163         (procfs_target::pid_to_str): Change return type.
3164         (procfs_target::attach): Update.
3165         (procfs_target::detach): Update.
3166         (procfs_target::fetch_registers): Update.
3167         (procfs_target::store_registers): Update.
3168         (procfs_target::wait): Update.
3169         (procfs_target::files_info): Update.
3170         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3171         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3172         return type.
3173         (nto_procfs_target::pid_to_str): Change return type.
3174         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3175         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3176         return type.
3177         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3178         (exit_lwp): Update.
3179         (attach_proc_task_lwp_callback, get_detach_signal)
3180         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3181         (linux_nat_target::resume, wait_lwp, stop_callback)
3182         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3183         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3184         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3185         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3186         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3187         type.
3188         (inf_ptrace_target::attach): Update.
3189         (inf_ptrace_target::files_info): Update.
3190         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3191         type.
3192         (go32_nat_target::pid_to_str): Change return type.
3193         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3194         (gnu_nat_target::wait): Update.
3195         (gnu_nat_target::wait): Update.
3196         (gnu_nat_target::resume): Update.
3197         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3198         (fbsd_nat_target::wait): Update.
3199         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3200         type.
3201         (darwin_nat_target::attach): Update.
3202         * corelow.c (class core_target) <pid_to_str>: Change return type.
3203         (core_target::pid_to_str): Change return type.
3204         * target.c (normal_pid_to_str): Change return type.
3205         (default_pid_to_str): Likewise.
3206         (target_pid_to_str): Change return type.
3207         (target_translate_tls_address): Update.
3208         (target_announce_detach): Update.
3209         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3210         return type.
3211         (bsd_uthread_target::pid_to_str): Change return type.
3212         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3213         type.
3214         (bsd_kvm_target::pid_to_str): Change return type.
3215         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3216         return type.
3217         (aix_thread_target::pid_to_str): Change return type.
3218         * target.h (struct target_ops) <pid_to_str>: Change return type.
3219         (target_pid_to_str, normal_pid_to_str): Likewise.
3220         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3221         type.
3222         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3223         type.
3224         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3225         return type.
3226         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3227         type.
3228         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3229         type.
3230         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3231         return type.
3232
3233 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3234
3235         * NEWS: Mention that the new default MI version is 3.  Mention
3236         changes to the output of commands and events that deal with
3237         multi-location breakpoints.
3238         * breakpoint.c: Include "mi/mi-out.h".
3239         (print_one_breakpoint): Change output syntax if using MI version
3240         >= 3.
3241         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3242         New.
3243         (mi_multi_location_breakpoint_output_fixed): New.
3244         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3245         (mi_cmd_fix_multi_location_breakpoint_output): New.
3246         (mi_multi_location_breakpoint_output_fixed): New.
3247         * mi/mi-cmds.c (mi_cmds): Register command
3248         -fix-multi-location-breakpoint-output.
3249         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3250         interpreter "mi".
3251
3252 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3253
3254         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3255         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3256         instantiate mi_ui_out based on interpreter name.
3257         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3258         * mi/mi-main.c (mi_load_progress): Likewise.
3259
3260 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3261
3262         * NEWS: Combine separate "New targets" sections for 8.3.
3263
3264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3265
3266         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3267         (ppcfbsd_init_abi): Install gdbarch
3268         "fetch_tls_load_module_address" and "get_thread_local_address"
3269         methods.
3270
3271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3272
3273         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3274         (riscv_fbsd_init_abi): Install gdbarch
3275         "fetch_tls_load_module_address" and "get_thread_local_address"
3276         methods.
3277
3278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3279
3280         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3281         (i386fbsd_init_abi): Install gdbarch
3282         "fetch_tls_load_module_address" and "get_thread_local_address"
3283         methods.
3284
3285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3286
3287         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3288         (amd64fbsd_init_abi): Install gdbarch
3289         "fetch_tls_load_module_address" and "get_thread_local_address"
3290         methods.
3291
3292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3293
3294         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3295         (struct fbsd_pspace_data): New type.
3296         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3297         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3298         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3299         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3300         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3301
3302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3303
3304         * gdbtypes.c (lookup_struct_elt): New function.
3305         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3306         * gdbtypes.h (struct struct_elt): New type.
3307         (lookup_struct_elt): New prototype.
3308
3309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3310
3311         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3312         remove disabled code block.
3313
3314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3315
3316         * gdbarch.sh (get_thread_local_address): New method.
3317         * gdbarch.h, gdbarch.c: Regenerate.
3318         * target.c (target_translate_tls_address): Use
3319         gdbarch_get_thread_local_address if present instead of
3320         target::get_thread_local_address.
3321
3322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3323
3324         * target.h (target::get_thread_local_address): Update comment.
3325
3326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3327
3328         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3329         objfile->separate_debug_objfile_backlink if not NULL.
3330
3331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3332
3333         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3334         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3335         (amd64bsd_store_inferior_registers): Likewise.
3336         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3337         Enable segment base registers.
3338         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3339         PT_GETFSBASE and PT_GETGSBASE.
3340         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3341         PT_SETGSBASE.
3342         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3343         segment base registers.
3344         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3345
3346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3347
3348         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3349         Update calls to i386_target_description to add 'segments'
3350         parameter.
3351         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3352         add segment base registers.
3353         * arch/i386.c (i386_create_target_description): Add 'segments'
3354         parameter to enable segment base registers.
3355         * arch/i386.h (i386_create_target_description): Likewise.
3356         * features/i386/32bit-segments.xml: New file.
3357         * features/i386/32bit-segments.c: Generate.
3358         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3359         call to i386_target_description to add 'segments' parameter.
3360         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3361         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3362         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3363         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3364         if feature is present.
3365         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3366         Add 'segments' parameter to call to i386_target_description.
3367         (i386_target_description): Add 'segments' parameter to enable
3368         segment base registers.
3369         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3370         to call to i386_target_description.
3371         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3372         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3373         Define I386_NUM_REGS.
3374         (i386_target_description): Add 'segments' parameter to enable
3375         segment base registers.
3376
3377 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3378
3379         PR/24325
3380         * source-cache.c: #undef open and close, to avoid unresolved
3381         externals during linking.
3382
3383 2019-03-12  Tom Tromey  <tromey@adacore.com>
3384
3385         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3386         const.  Add initializers.
3387         (_initialize_remote): Don't initialize ptid globals.
3388
3389 2019-03-12  Pedro Alves  <palves@redhat.com>
3390
3391         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3392
3393 2019-03-12  Pedro Alves  <palves@redhat.com>
3394
3395         * cp-name-parser.y (main): Remove unused 'len' variable.
3396
3397 2019-03-12  Tom Tromey  <tromey@adacore.com>
3398
3399         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3400         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3401
3402 2019-03-12  Tom Tromey  <tromey@adacore.com>
3403
3404         * linux-nat.c (iterate_over_lwps): Update.
3405         (stop_callback): Remove parameter.
3406         (stop_wait_callback, detach_callback, resume_set_callback)
3407         (select_singlestep_lwp_callback, set_ignore_sigint)
3408         (status_callback, resumed_callback, resume_clear_callback)
3409         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3410         data parameter.
3411         (linux_nat_target::detach, linux_nat_target::resume)
3412         (linux_stop_and_wait_all_lwps, select_event_lwp)
3413         (linux_nat_filter_event, linux_nat_wait_1)
3414         (linux_nat_target::kill, linux_nat_target::stop)
3415         (linux_nat_target::stop): Update.
3416         (linux_nat_resume_callback): Change type.
3417         (resume_stopped_resumed_lwps, count_events_callback)
3418         (select_event_lwp_callback): Likewise.
3419         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3420         * arm-linux-nat.c (struct update_registers_data): Remove.
3421         (update_registers_callback): Change type.
3422         (arm_linux_insert_hw_breakpoint1): Update.
3423         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3424         parameter.
3425         (x86_linux_dr_set_addr): Update.
3426         (x86_linux_dr_set_control): Update.
3427         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3428         (iterate_over_lwps): Use gdb::function_view.
3429         * nat/aarch64-linux-hw-point.c (struct
3430         aarch64_dr_update_callback_param): Remove.
3431         (debug_reg_change_callback): Change type.
3432         (aarch64_notify_debug_reg_change): Update.
3433         * s390-linux-nat.c (s390_refresh_per_info): Update.
3434
3435 2019-03-11  Tom Tromey  <tromey@adacore.com>
3436
3437         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3438         redundant assignment to "this_cu".
3439
3440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3441
3442         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3443
3444 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3445
3446         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3447         from...
3448         (rank_one_type): ... this.
3449
3450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3451
3452         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3453         from...
3454         (rank_one_type): ... this.
3455
3456 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3457
3458         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3459         from...
3460         (rank_one_type): ... this.
3461
3462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3463
3464         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3465         from...
3466         (rank_one_type): ... this.
3467
3468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3469
3470         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3471         from...
3472         (rank_one_type): ... this.
3473
3474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3475
3476         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3477         from...
3478         (rank_one_type): ... this.
3479
3480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3481
3482         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3483         from...
3484         (rank_one_type): ... this.
3485
3486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3487
3488         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3489         from...
3490         (rank_one_type): ... this.
3491
3492 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3493
3494         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3495         from...
3496         (rank_one_type): ... this.
3497
3498 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3499
3500         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3501         from...
3502         (rank_one_type): ... this.
3503
3504 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3505
3506         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3507         from...
3508         (rank_one_type): ... this.
3509
3510 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3511
3512         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3513         from...
3514         (rank_one_type): ... this.
3515
3516 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3517
3518         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3519         inferior-events' shows the example events.
3520
3521 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3522
3523         Support styling on native MS-Windows console
3524
3525         PR/24315
3526         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3527         on MS-Windows if $TERM is not defined.
3528
3529         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3530
3531         * posix-hdep.c (gdb_console_fputs):
3532         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3533         functions.
3534         * ui-file.h (gdb_console_fputs): Add prototype.
3535
3536         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3537         back to fputs only if the former returns zero.
3538
3539 2019-03-07  Tom Tromey  <tom@tromey.com>
3540
3541         * symmisc.c (print_symbol_bcache_statistics): Update.
3542         (print_objfile_statistics): Update.
3543         * symfile.c (allocate_symtab): Update.
3544         * stabsread.c: Don't include bcache.h.
3545         * psymtab.h (struct psymbol_bcache): Don't declare.
3546         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3547         (psymbol_bcache_init, psymbol_bcache_free)
3548         (psymbol_bcache_get_bcache): Don't declare.
3549         * psymtab.c (struct psymbol_bcache): Remove.
3550         (psymtab_storage::psymtab_storage): Update.
3551         (psymtab_storage::~psymtab_storage): Update.
3552         (psymbol_bcache_init, psymbol_bcache_free)
3553         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3554         (add_psymbol_to_bcache): Update.
3555         (allocate_psymtab): Update.
3556         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3557         macro_cache>: No longer pointers.
3558         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3559         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3560         * macrotab.c (macro_bcache): Update.
3561         * macroexp.c: Don't include bcache.h.
3562         * gdbtypes.c (check_types_worklist): Update.
3563         (types_deeply_equal): Remove TRY/CATCH.  Update.
3564         * elfread.c (elf_symtab_read): Update.
3565         * dwarf2read.c: Don't include bcache.h.
3566         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3567         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3568         (print_bcache_statistics, bcache_memory_used): Don't declare.
3569         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3570         methods.  Rename all data members.
3571         * bcache.c (struct bcache): Move to bcache.h.
3572         (bcache::expand_hash_table): Rename from expand_hash_table.
3573         (bcache): Remove.
3574         (bcache::insert): Rename from bcache_full.
3575         (bcache::compare): Rename from bcache_compare.
3576         (bcache_xmalloc): Remove.
3577         (bcache::~bcache): Rename from bcache_xfree.
3578         (bcache::print_statistics): Rename from print_bcache_statistics.
3579         (bcache::memory_used): Rename from bcache_memory_used.
3580
3581 2019-03-07  Pedro Alves  <palves@redhat.com>
3582
3583         * infrun.c (normal_stop): Also check for
3584         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3585
3586 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * f-lang.c (value_from_host_double): Moved to...
3589         * value.c (value_from_host_double): ...here.
3590         * value.h (value_from_host_double): Declare.
3591         * guile/scm-math.c (vlscm_convert_typed_number): Use
3592         value_from_host_double.
3593         (vlscm_convert_number): Likewise.
3594         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3595         * python/py-value.c (convert_value_from_python): Likewise.
3596
3597 2019-03-06  Tom Tromey  <tom@tromey.com>
3598
3599         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3600
3601 2019-03-06  Tom Tromey  <tom@tromey.com>
3602
3603         * utils.h (free_current_contents): Don't declare.
3604         * utils.c (free_current_contents): Remove.
3605
3606 2019-03-06  Tom Tromey  <tom@tromey.com>
3607
3608         * top.c (quit_force): Update.
3609         * main.c (captured_command_loop): Update.
3610         * common/new-op.c (operator new): Update.
3611         * common/common-exceptions.c (struct catcher)
3612         <save_cleanup_chain>: Remove member.
3613         (exceptions_state_mc_init): Update.
3614         (exception_try_scope_entry): Return nullptr.
3615         (exception_try_scope_exit, exception_rethrow)
3616         (throw_exception_sjlj, throw_exception_cxx): Update.
3617         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3618         (all_cleanups, do_cleanups, discard_cleanups)
3619         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3620         (restore_cleanups, restore_final_cleanups): Don't declare.
3621         (do_final_cleanups): Remove parameter.
3622         * common/cleanups.c (cleanup_chain, make_cleanup)
3623         (make_cleanup_dtor, all_cleanups, do_cleanups)
3624         (discard_my_cleanups, discard_cleanups)
3625         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3626         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3627         (null_cleanup): Remove.
3628         (do_final_cleanups): Remove parameter.
3629
3630 2019-03-06  Tom Tromey  <tom@tromey.com>
3631
3632         * remote.c (remote_target::remote_parse_stop_reply): Use
3633         unique_xmalloc_ptr.
3634
3635 2019-03-06  Tom Tromey  <tom@tromey.com>
3636
3637         * stabsread.c (struct stabs_field_info): Rename from field_info.
3638         <list, fnlist>: Add initializers.
3639         <obstack>: New member.
3640         (read_member_functions, read_struct_fields, read_baseclasses):
3641         Allocate on obstack.  Don't use cleanups.
3642         (read_one_struct_field, read_member_functions, read_struct_fields)
3643         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3644         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3645         (read_struct_type): Update.
3646
3647 2019-03-06  Tom Tromey  <tom@tromey.com>
3648
3649         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3650         * common/filestuff.h (make_cleanup_close): Don't declare.
3651         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3652         Remove.
3653
3654 2019-03-06  Tom Tromey  <tom@tromey.com>
3655
3656         * solib-aix.c: Use make_scope_exit.
3657
3658 2019-03-06  Tom Tromey  <tom@tromey.com>
3659
3660         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3661         Use make_scope_exit.
3662
3663 2019-03-06  Tom Tromey  <tom@tromey.com>
3664
3665         * solib-svr4.c (disable_probes_interface): Remove parameter.
3666         (svr4_handle_solib_event): Use make_scope_exit.
3667
3668 2019-03-06  Tom Tromey  <tom@tromey.com>
3669
3670         * remote.c (struct stop_reply_deleter): Remove.
3671         (stop_reply_up): Update.
3672         (struct stop_reply): Derive from notif_event.  Don't typedef.
3673         <regcache>: Now a std::vector.
3674         (stop_reply_xfree): Remove.
3675         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3676         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3677         (remote_target::discard_pending_stop_replies): Use delete.
3678         (remote_target::remote_parse_stop_reply): Update.
3679         (remote_target::process_stop_reply): Update.
3680         * remote-notif.h (struct notif_event): Add virtual destructor.
3681         Remove "dtr" member.
3682         (struct notif_client) <alloc_event>: Return a unique_ptr.
3683         (notif_event_xfree): Don't declare.
3684         (notif_event_up): New typedef.
3685         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3686         (notif_event_xfree, do_notif_event_xfree): Remove.
3687         (remote_notif_state_xfree): Update.
3688
3689 2019-03-06  Tom Tromey  <tom@tromey.com>
3690
3691         * infrun.c (displaced_step_clear_cleanup): Now a
3692         forward_scope_exit type.
3693         (displaced_step_prepare_throw): Update.
3694         (displaced_step_fixup): Update.
3695
3696 2019-03-06  Tom Tromey  <tom@tromey.com>
3697
3698         * inferior.h (class inferior): Update comment.
3699         * gdbthread.h (class thread_info): Update comment.
3700
3701 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3702             Tom Tromey  <tom@tromey.com>
3703
3704         * stabsread.h (struct stab_section_list): Remove.
3705         (coffstab_build_psymtabs): Update.
3706         * dbxread.c (symbuf_sections): Now a std::vector.
3707         (sect_idx): New global.
3708         (fill_symbuf): Update.
3709         (coffstab_build_psymtabs): Change type of stabsects parameter.
3710         Update.
3711         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3712         std::vector.
3713         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3714         (coff_locate_sections): Update.
3715         (coff_symfile_read): Remove cleanups.  Update.
3716         (init_stringtab): Add storage parameter.
3717         (free_stringtab, free_stringtab_cleanup): Remove.
3718         (init_lineno): Add storage parameter.
3719         (free_linetab, free_linetab_cleanup): Remove.
3720
3721 2019-03-06  Pedro Alves  <palves@redhat.com>
3722
3723         * linux-fork.c (fork_info::clobber_regs): Delete.
3724         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3725         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3726         comment.  Adjust.
3727         (scoped_switch_fork_info::scoped_switch_fork_info)
3728         (checkpoint_command, linux_fork_context): Adjust
3729         fork_save_infrun_state calls.
3730
3731 2019-03-06  Pedro Alves  <palves@redhat.com>
3732
3733         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3734         (inf_has_multiple_threads): Return 'bool' and rewrite using
3735         inferior_info::threads().
3736
3737 2019-03-06  Pedro Alves  <palves@redhat.com>
3738
3739         * linux-fork.c: Include <list>.
3740         (fork_list): Now a std::list instance.
3741         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3742         (forks_exist_p, find_last_fork): Adjust.
3743         (new_fork): Delete.
3744         (one_fork_p): New.
3745         (add_fork): Adjust.
3746         (free_fork): Delete, folded into fork_info::~fork_info().
3747         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3748         Adjust.
3749         (init_fork_list): Delete.
3750         (linux_fork_killall, linux_fork_mourn_inferior)
3751         (linux_fork_detach, info_checkpoints_command): Adjust.
3752         (_initialize_linux_fork): No longer call init_fork_list.
3753
3754 2019-03-06  Pedro Alves  <palves@redhat.com>
3755
3756         * linux-fork.c (new_fork): New, split out of ...
3757         (add_fork): ... this.  Return void.  Move "first fork" special
3758         case from here, to ...
3759         (checkpoint_command): ... here.
3760         * linux-linux.h (add_fork): Return void.
3761
3762 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3765
3766 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3767             Chris January  <chris.january@arm.com>
3768             David Lecomber  <david.lecomber@arm.com>
3769
3770         * f-exp.y: New token, UNOP_INTRINSIC.
3771         (exp): New pattern using UNOP_INTRINSIC token.
3772         (f77_keywords): Add 'abs' keyword.
3773         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3774         (value_from_host_double): New function.
3775         (evaluate_subexp_f): Support UNOP_ABS.
3776
3777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3780         types.
3781
3782 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3785         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3786         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3787
3788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3791
3792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3793             Chris January  <chris.january@arm.com>
3794
3795         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3796         * f-exp.y: Define 'KIND' token.
3797         (exp): New pattern for KIND expressions.
3798         (ptype): Handle types with a kind extension.
3799         (direct_abs_decl): Extend to spot kind extensions.
3800         (f77_keywords): Add 'kind' to the list.
3801         (push_kind_type): New function.
3802         (convert_to_kind_type): New function.
3803         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3804         * parse.c (operator_length_standard): Likewise.
3805         * parser-defs.h (enum type_pieces): Add tp_kind.
3806         * std-operator.def: Add UNOP_KIND.
3807
3808 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3809
3810         * f-exp.y (f_parse): Set yydebug.
3811
3812 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * f-lang.c (evaluate_subexp_f): New function.
3815         (exp_descriptor_f): New global.
3816         (f_language_defn): Use exp_descriptor_f instead of
3817         exp_descriptor_standard.
3818
3819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * f-exp.y (struct token): Add comments.
3822         (dot_ops): Remove uppercase versions and the end marker.
3823         (f77_keywords): Likewise.
3824         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3825         entries in the dot_ops array are case insensitive, and use
3826         strncasecmp to compare strings.  Also some whitespace cleanup in
3827         this area.  Similar for the f77_keywords array, except entries in
3828         this list might be case sensitive.
3829
3830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * f-exp.y (struct f77_boolean_val): Add comments.
3833         (boolean_values): Remove uppercase versions, and end marker.
3834         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3835         and use strncasecmp to achieve case insensitivity.  Additionally,
3836         perform whitespace cleanup around this code.
3837
3838 2019-03-06  Tom Tromey  <tromey@adacore.com>
3839
3840         * remote-sim.c (gdbsim_target_open): Use result of
3841         gdb_argv::release.
3842
3843 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3844         Dirk Schubert  <dirk.schubert@arm.com>
3845         Chris January  <chris.january@arm.com>
3846
3847         * eval.c (evaluate_subexp_standard): Call Fortran argument
3848         wrapping logic.
3849         * f-lang.c (struct value): A value which can be passed into a
3850         Fortran function call.
3851         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3852         where appropriate.
3853         (struct type): Value ready for a Fortran function call.
3854         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3855         is needed.
3856         * f-lang.h (fortran_argument_convert): Declaration.
3857         (fortran_preserve_arg_pointer): Declaration.
3858         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3859
3860 2019-03-05  Tom Tromey  <tromey@adacore.com>
3861
3862         * python/py-prettyprint.c (print_string_repr): Remove #if.
3863         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3864
3865 2019-03-05  Tom Tromey  <tromey@adacore.com>
3866
3867         * target.c (the_dummy_target): Move later.  Change type to
3868         "dummy_target".
3869         (initialize_targets): Don't initialize the_dummy_target.
3870
3871 2019-03-05  Tom Tromey  <tromey@adacore.com>
3872
3873         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3874         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3875
3876 2019-03-05  Tom Tromey  <tromey@adacore.com>
3877
3878         * windows-nat.c (windows_nat_target::attach)
3879         (windows_nat_target::detach): Don't call gdb_flush.
3880         * valprint.c (generic_val_print, val_print, val_print_string):
3881         Don't call gdb_flush.
3882         * utils.c (defaulted_query): Don't call gdb_flush.
3883         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3884         * target.c (target_announce_detach): Don't call gdb_flush.
3885         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3886         * remote.c (extended_remote_target::attach): Don't call
3887         gdb_flush.
3888         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3889         * printcmd.c (do_examine): Don't call gdb_flush.
3890         (info_display_command): Don't call gdb_flush.
3891         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3892         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3893         * memattr.c (info_mem_command): Don't call gdb_flush.
3894         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3895         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3896         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3897         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3898         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3899         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3900         (gnu_nat_target::detach): Don't call gdb_flush.
3901         * f-valprint.c (f_val_print): Don't call gdb_flush.
3902         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3903         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3904         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3905         gdb_flush.
3906         * c-valprint.c (c_val_print): Don't call gdb_flush.
3907         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3908
3909 2019-03-05  Tom Tromey  <tromey@adacore.com>
3910
3911         * varobj.c (update_dynamic_varobj_children): Update.
3912         (install_default_visualizer): Use reset, not release.
3913         * value.c (set_internalvar): Update.
3914         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3915         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3916         ATTRIBUTE_UNUSED_RESULT.
3917
3918 2019-03-05  Tom Tromey  <tromey@adacore.com>
3919
3920         * remote.c (class scoped_remote_fd) <release>: Add
3921         ATTRIBUTE_UNUSED_RESULT.
3922
3923 2019-03-05  Tom Tromey  <tromey@adacore.com>
3924
3925         * macroexp.c (struct macro_buffer) <release>: Add
3926         ATTRIBUTE_UNUSED_RESULT.
3927
3928 2019-03-05  Tom Tromey  <tromey@adacore.com>
3929
3930         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3931         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3932         ATTRIBUTE_UNUSED_RESULT.
3933
3934 2019-03-05  Tom Tromey  <tromey@adacore.com>
3935
3936         * common/scoped_fd.h (class scoped_fd) <release>: Add
3937         ATTRIBUTE_UNUSED_RESULT.
3938
3939 2019-03-05  Tom Tromey  <tromey@adacore.com>
3940
3941         * parser-defs.h (struct parser_state) <release>: Add
3942         ATTRIBUTE_UNUSED_RESULT.
3943
3944 2019-03-05  Tom Tromey  <tromey@adacore.com>
3945
3946         * utils.h (class gdb_argv) <release>: Add
3947         ATTRIBUTE_UNUSED_RESULT.
3948         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3949
3950 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3951
3952         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3953         for-loop range, to avoid compiler warnings.
3954
3955         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3956         avoid compiler warnings about unused variables.
3957
3958         * NEWS: Mention end of support for native debugging on MS-Windows
3959         before XP.
3960
3961         PR gdb/24292
3962         * common/netstuff.c:
3963         * gdbserver/gdbreplay.c
3964         * gdbserver/remote-utils.c:
3965         * ser-tcp.c:
3966         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3967         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3968         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3969         'getaddrinfo' and 'freeaddrinfo' were not available before
3970         Windows XP, and mingw.org's MinGW headers by default define
3971         _WIN32_WINNT to 0x500.
3972
3973 2019-03-01  Gary Benson <gbenson@redhat.com>
3974
3975         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3976
3977 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3978             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3979
3980         PR gdb/8527
3981         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3982         set_sigint_trap, clear_sigint_trap.
3983
3984 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * target.c (target_detach): Clear the regcache and the
3987         frame cache.
3988
3989 2019-02-27  Pedro Alves  <palves@redhat.com>
3990
3991         * utils.c (set_screen_size): When we cap the height/width sizes,
3992         tweak the corresponding command variable to show "unlimited":
3993
3994 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3995             Pedro Alves  <palves@redhat.com>
3996
3997         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3998         before calling rl_set_screen_size.
3999
4000 2019-02-27  Tom Tromey  <tromey@adacore.com>
4001
4002         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4003         define.
4004         * python/py-value.c: Remove Python 2.4 workaround.
4005         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4006         workaround.
4007         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4008         Python 2.4 workaround.
4009         * python/python-internal.h: Remove Python 2.4 comment.
4010         (Py_ssize_t): Don't define.
4011         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4012         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4013         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4014         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4015         * python/python.c (do_start_initialization): Remove Python 2.4
4016         workaround.
4017         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4018         (print_children): Remove Python 2.4 workaround.
4019         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4020         workaround.
4021         (CHARBUFFERPROC_NAME): Remove.
4022         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4023         Python 2.4 workaround.
4024
4025 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4026
4027         * NEWS: Note minimum Python version.
4028
4029 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4030
4031         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4032         code from these functions.  Remove corresponding ifdefs.  Use
4033         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4034         Remove gotos and target of gotos.
4035         (infpy_search_memory): Likewise.
4036
4037 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4038
4039         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4040         (hppa_gdbarch_init): Don't register deleted functions with
4041         gdbarch.
4042
4043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4046         (h8300_unwind_sp): Delete.
4047         (h8300_dummy_id): Delete.
4048         (h8300_gdbarch_init): Don't register deleted functions with
4049         gdbarch.
4050
4051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4054         (ft32_unwind_pc): Delete.
4055         (ft32_unwind_sp): Delete.
4056         (ft32_gdbarch_init): Don't register deleted functions with
4057         gdbarch.
4058
4059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4062         (frv_unwind_pc): Delete.
4063         (frv_unwind_sp): Delete.
4064         (frv_gdbarch_init): Don't register deleted functions with
4065         gdbarch.
4066
4067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4068
4069         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4070         (riscv_unwind_pc): Delete.
4071         (riscv_unwind_sp): Delete.
4072         (riscv_gdbarch_init): Don't register deleted functions with
4073         gdbarch.
4074
4075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4078         (csky_unwind_pc): Delete.
4079         (csky_unwind_sp): Delete.
4080         (csky_gdbarch_init): Don't register deleted functions with
4081         gdbarch.
4082
4083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4086         (cris_unwind_pc): Delete.
4087         (cris_unwind_sp): Delete.
4088         (cris_gdbarch_init): Don't register deleted functions with
4089         gdbarch.
4090
4091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4094         (bfin_unwind_pc): Delete.
4095         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4096
4097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4100         (arm_unwind_pc): Delete.
4101         (arm_unwind_sp): Delete.
4102         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4103
4104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4105
4106         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4107         (arc_unwind_pc): Delete.
4108         (arc_unwind_sp): Delete.
4109         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4110
4111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4114         (alpha_unwind_pc): Delete.
4115         (alpha_gdbarch_init): Don't register deleted functions with
4116         gdbarch.
4117
4118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4119
4120         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4121         (aarch64_unwind_pc): Delete.
4122         (aarch64_unwind_sp): Delete.
4123         (aarch64_gdbarch_init): Don't register deleted functions with
4124         gdbarch.
4125
4126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * gdbtypes.c (type_align): Don't consider static members when
4129         computing structure alignment.
4130
4131 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4134         return 0 for other types.
4135         * arch-utils.c (default_type_align): Always return 0.
4136         * gdbarch.h: Regenerate.
4137         * gdbarch.sh (type_align): Extend comment.
4138         * gdbtypes.c (type_align): Add additional comments, always call
4139         gdbarch_type_align before applying the default rules.
4140         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4141         generic code will then apply a suitable default.
4142         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4143         types, return 0 for other types.
4144
4145 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4146
4147         * NEWS: Create a new section for the next release branch.
4148         Rename the section of the current branch, now that it has
4149         been cut.
4150
4151 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4152
4153         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4154         * version.in: Bump version to 8.3.50.DATE-git.
4155
4156 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4157
4158         * aix-thread.c (ptid_cmp): Remove unused variable.
4159         (get_signaled_thread): Likewise.
4160         (store_regs_user_thread): Likewise.
4161         (store_regs_kernel_thread): Likewise.
4162         (fetch_regs_kernel_thread): Remove shadowed variable.
4163
4164 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * features/riscv/32bit-cpu.xml: Add register numbers.
4167         * features/riscv/32bit-fpu.c: Regenerate.
4168         * features/riscv/32bit-fpu.xml: Add register numbers.
4169         * features/riscv/64bit-cpu.xml: Add register numbers.
4170         * features/riscv/64bit-fpu.c: Regenerate.
4171         * features/riscv/64bit-fpu.xml: Add register numbers.
4172
4173 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4174
4175         * NEWS: Mention two argument form of gdb.Value constructor.
4176         * python/py-value.c (convert_buffer_and_type_to_value): New
4177         function.
4178         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4179         Add support for handling an optional second argument.  Call
4180         convert_buffer_and_type_to_value as appropriate.
4181         * python/python-internal.h (Py_buffer_deleter): New struct.
4182         (Py_buffer_up): New typedef.
4183
4184 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4185
4186         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4187         instead of releasing ownership.
4188
4189 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4190
4191         * dwarf2read.c (open_and_init_dwp_file): Call
4192         elf_numsections instead of bfd_count_sections to initialize
4193         dwp_file->num_sections.
4194
4195 2019-02-25  Tom Tromey  <tromey@adacore.com>
4196
4197         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4198
4199 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4200
4201         * gcore.in: Add '--readnever' option when invoking GDB.
4202
4203 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4204
4205         * MAINTAINERS: Update my email address.
4206
4207 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4208
4209         * build-id.c (build_id_to_debug_bfd_1): New function.
4210         (build_id_to_debug_bfd): Look for separate debug file in
4211         sysroot.
4212
4213 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * gdbarch.sh: Update the copyright year range that is placed into
4216         generated files.
4217
4218 2019-02-22  Keith Seitz  <keiths@redhat.com>
4219
4220         PR symtab/23853
4221         * linespec.c (create_sals_line_offset): Search for the default
4222         symtab's filename instead of its fullname.
4223
4224 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4225
4226         * NEWS: Update style defaults.
4227
4228 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4229
4230         * main.c (captured_main_1): Disable styling in batch mode.
4231
4232 2019-02-20  Tom Tromey  <tom@tromey.com>
4233
4234         * symtab.c (symtab_symbol_info): Fix typos.
4235
4236 2019-02-20  Tom Tromey  <tromey@adacore.com>
4237
4238         * findcmd.c (_initialize_mem_search): Use upper case for
4239         metasyntactic variables.
4240
4241 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4242
4243         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4244         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4245
4246 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4247
4248         * top.h (source_file_name): Change to std::string.
4249         * top.c (source_file_name): Likewise.
4250         (command_line_input): Adjust.
4251         * cli/cli-script.c (script_from_file): Adjust.
4252
4253 2019-02-19  Tom Tromey  <tromey@adacore.com>
4254
4255         * ravenscar-thread.c
4256         (ravenscar_thread_target::update_thread_list): Don't call
4257         ada_build_task_list.
4258         * ada-lang.h (ada_build_task_list): Don't declare.
4259         * ada-tasks.c (struct ada_tasks_inferior_data)
4260         <task_list_valid_p>: Now bool.
4261         (read_known_tasks, ada_task_list_changed)
4262         (ada_tasks_invalidate_inferior_data): Update.
4263         (read_known_tasks_array): Return bool.
4264         (read_known_tasks_list): Likewise.
4265         (read_known_tasks): Return void.
4266         (ada_build_task_list): Now static.
4267
4268 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4271         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4272
4273 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4274
4275         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4276         variant for ada_tasks_pspace_data_handle and
4277         ada_tasks_inferior_data_handle.
4278         (ada_tasks_pspace_data_cleanup): New function.
4279         (ada_tasks_inferior_data_cleanup): New function.
4280
4281 2019-02-17  Tom Tromey  <tom@tromey.com>
4282
4283         * macrotab.h (macro_source_fullname): Return a std::string.
4284         * macrotab.c (macro_include, check_for_redefinition)
4285         (macro_undef, macro_lookup_definition, foreach_macro)
4286         (foreach_macro_in_scope): Update.
4287         (macro_source_fullname): Return a std::string.
4288         * macrocmd.c (show_pp_source_pos): Update.
4289
4290 2019-02-17  Tom Tromey  <tom@tromey.com>
4291
4292         * macrocmd.c (show_pp_source_pos): Style the file names.
4293
4294 2019-02-17  Tom Tromey  <tom@tromey.com>
4295
4296         PR tui/24197:
4297         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4298
4299 2019-02-17  Tom Tromey  <tom@tromey.com>
4300
4301         * ada-lang.c (user_select_syms): Use filtered printing.
4302         * utils.c (wrap_style): New global.
4303         (desired_style): Remove.
4304         (emit_style_escape): Add stream parameter.
4305         (set_output_style, reset_terminal_style, prompt_for_continue):
4306         Update.
4307         (flush_wrap_buffer): Only flush gdb_stdout.
4308         (wrap_here): Set wrap_style.
4309         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4310         treat escape sequences as a character.  Change when wrap buffer is
4311         flushed.
4312         (fputs_styled): Do not set the output style when the default is
4313         requested.
4314         * ui-style.h (struct ui_file_style) <is_default>: New method.
4315         * source.c (print_source_lines_base): Emit escape sequences in one
4316         piece.
4317
4318 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4319
4320         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4321         integers and enumeration types.
4322
4323 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4324
4325         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4326         instead of lookup_symbol_in_language
4327         (do_exact_match): New function.
4328         (ada_get_symbol_name_matcher): Return do_exact_match when
4329         doing a verbatim match.
4330
4331 2019-02-15  Tom Tromey  <tromey@adacore.com>
4332
4333         * ravenscar-thread.c (ravenscar_thread_target::resume)
4334         (ravenscar_thread_target::wait): Special case wildcard requests.
4335
4336 2019-02-15  Tom Tromey  <tromey@adacore.com>
4337
4338         * ravenscar-thread.c (base_ptid): Remove.
4339         (struct ravenscar_thread_target) <close>: New method.
4340         <m_base_ptid>: New member.
4341         <update_inferior_ptid, active_task, task_is_currently_active,
4342         runtime_initialized>: Declare methods.
4343         <ravenscar_thread_target>: Add constructor.
4344         (ravenscar_thread_target::task_is_currently_active)
4345         (ravenscar_thread_target::update_inferior_ptid)
4346         (ravenscar_runtime_initialized): Rename.  Now methods.
4347         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4348         (ravenscar_thread_target::update_thread_list): Update.
4349         (ravenscar_thread_target::active_task): Now method.
4350         (ravenscar_thread_target::store_registers)
4351         (ravenscar_thread_target::prepare_to_store)
4352         (ravenscar_thread_target::prepare_to_store)
4353         (ravenscar_thread_target::mourn_inferior): Update.
4354         (ravenscar_inferior_created): Use "new" to create target.
4355         (ravenscar_thread_target::get_ada_task_ptid): Update.
4356         (_initialize_ravenscar): Don't initialize base_ptid.
4357         (ravenscar_ops): Remove global.
4358
4359 2019-02-15  Tom Tromey  <tromey@adacore.com>
4360
4361         * target.h (push_target): Declare new overload.
4362         * target.c (push_target): New overload, taking an rvalue reference.
4363         * remote.c (remote_target::open_1): Use push_target overload.
4364         * corelow.c (core_target_open): Use push_target overload.
4365
4366 2019-02-15  Tom Tromey  <tromey@adacore.com>
4367
4368         * ravenscar-thread.c (is_ravenscar_task)
4369         (ravenscar_task_is_currently_active): Return bool.
4370         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4371         (_initialize_ravenscar): Remove "(void)".
4372         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4373         Return bool.
4374
4375 2019-02-15  Tom Tromey  <tromey@adacore.com>
4376
4377         * ravenscar-thread.c (ravenscar_runtime_initializer)
4378         (has_ravenscar_runtime, get_running_thread_id)
4379         (ravenscar_thread_target::resume): Fix indentation.
4380
4381 2019-02-15  Tom Tromey  <tromey@adacore.com>
4382
4383         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4384         from ravenscar_arch_ops.
4385         (sparc_ravenscar_ops::fetch_registers)
4386         (sparc_ravenscar_ops::store_registers): Now methods.
4387         (sparc_ravenscar_prepare_to_store): Remove.
4388         (sparc_ravenscar_ops): Redefine.
4389         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4390         methods and destructor.  Remove members.
4391         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4392         (ravenscar_thread_target::store_registers)
4393         (ravenscar_thread_target::prepare_to_store): Update.
4394         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4395         Remove.
4396         (struct ppc_ravenscar_powerpc_ops): Derive from
4397         ravenscar_arch_ops.
4398         (ppc_ravenscar_powerpc_ops::fetch_registers)
4399         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4400         (ppc_ravenscar_powerpc_ops): Redefine.
4401         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4402         (ppc_ravenscar_e500_ops::fetch_registers)
4403         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4404         (ppc_ravenscar_e500_ops): Redefine.
4405         * aarch64-ravenscar-thread.c
4406         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4407         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4408         (aarch64_ravenscar_fetch_registers)
4409         (aarch64_ravenscar_store_registers): Now methods.
4410         (aarch64_ravenscar_ops): Redefine.
4411
4412 2019-02-15  Tom Tromey  <tromey@adacore.com>
4413
4414         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4415         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4416         (ravenscar_thread_target::stopped_by_watchpoint)
4417         (ravenscar_thread_target::stopped_data_address)
4418         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4419
4420 2019-02-15  Tom Tromey  <tromey@adacore.com>
4421
4422         * ravenscar-thread.c: Fix some typos.
4423
4424 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4425             Tom Tromey  <tromey@adacore.com>
4426
4427         * ada-lang.c (ada_exception_sal): Change addr_string to a
4428         std::string.
4429         (create_ada_exception_catchpoint): Update.
4430
4431 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4432             Tom Tromey  <tromey@adacore.com>
4433
4434         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4435         (bp_location_ops): Remove.
4436         (base_breakpoint_allocate_location): Update.
4437         (free_bp_location): Update.
4438         * ada-lang.c (class ada_catchpoint_location)
4439         <ada_catchpoint_location>: Remove ops parameter.
4440         (ada_catchpoint_location_dtor): Remove.
4441         (ada_catchpoint_location_ops): Remove.
4442         (allocate_location_exception): Update.
4443         * breakpoint.h (struct bp_location_ops): Remove.
4444         (class bp_location) <bp_location>: Remove bp_location_ops
4445         parameter.
4446         <~bp_location>: Add destructor.
4447         <ops>: Remove.
4448
4449 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4450             Pedro Alves  <palves@redhat.com>
4451
4452         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4453         'PATH_MAX'.
4454
4455 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4456             Samuel Thibault  <samuel.thibault@gnu.org>
4457             Thomas Schwinge  <thomas@codesourcery.com>
4458
4459         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4460         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4461
4462 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4463
4464         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4465         (check_empty): Use "const char *".
4466
4467         * gnu-nat.c (gnu_nat_target::detach): Instead of
4468         'detach_inferior (pid)' call
4469         'detach_inferior (find_inferior_pid (pid))'.
4470
4471         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4472         'nat/fork-inferior.o'.
4473         * gnu-nat.c: #include "nat/fork-inferior.h".
4474
4475         * gnu-nat.c (gnu_nat_target::detach): Instead of
4476         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4477         * gnu-nat.h: #include "inf-child.h".
4478         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4479         'i386_gnu_nat_target::fetch_registers'.
4480         (gnu_store_registers): Rename/move to
4481         'i386_gnu_nat_target::store_registers'.
4482
4483         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4484         * gnu-nat.h (mach_thread_info): New function.
4485         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4486
4487         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4488
4489 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4490
4491         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4492
4493 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4494
4495         * windows-nat.c (windows_add_thread): Add new parameter
4496         "main_thread_p" with default value set to false.  Update
4497         function documentation as well as all callers.
4498         (windows_delete_thread): Likewise.
4499         (fake_create_process): Update call to windows_add_thread.
4500         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4501         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4502         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4503         call to windows_delete_thread.
4504
4505 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4506
4507         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4508
4509 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4510
4511         * symfile.c (find_separate_debug_file): Use canonical path of
4512         sysroot with child_path instead of gdb_sysroot if it is valid.
4513
4514 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4515
4516         * symfile.c (find_separate_debug_file): Use child_path to
4517         determine if an object file is under a sysroot.
4518
4519 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4520
4521         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4522         unittests/child-path-selftests.c.
4523         * common/pathstuff.c (child_path): New function.
4524         * common/pathstuff.h (child_path): New prototype.
4525         * unittests/child-path-selftests.c: New file.
4526
4527 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4528
4529         * symfile.c (find_separate_debug_file): Look for separate debug
4530         files in debug directories under the sysroot.
4531
4532 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4533
4534         * symtab.h (struct minimal_symbol data_p): New const method.
4535         (struct minimal_symbol text_p): Likewise.
4536         * symtab.c (output_source_filename): Use file name style
4537         to print file name.
4538         (print_symbol_info): Likewise.
4539         (print_msymbol_info): Use address style to print addresses.
4540         Use function name style to print executable text symbols.
4541         (expand_symtab_containing_pc): Use data_p.
4542         (find_pc_sect_compunit_symtab): Likewise.
4543
4544 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4545
4546         * breakpoint.c (describe_other_breakpoints): Use address style
4547         to print addresses.
4548         (say_where): Likewise.
4549
4550 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4551
4552         * ada-typeprint.c (print_func_type): Print function name
4553         style to print function name.
4554         * c-typeprint.c (c_print_type_1): Likewise.
4555
4556 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4557
4558         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4559         for execve.
4560
4561 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4562
4563         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4564         type_stack.
4565
4566 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4567
4568         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4569         TYPE_CODE_REF types.
4570
4571 2019-02-08  Jim Wilson  <jimw@sifive.com>
4572
4573         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4574         (riscv_linux_fregset): New.
4575         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4576
4577 2019-02-07  Tom Tromey  <tom@tromey.com>
4578
4579         * thread.c (thread_cancel_execution_command): Update.
4580         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4581         methods.
4582         (struct thread_fsm_ops): Remove.
4583         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4584         (thread_fsm_should_stop, thread_fsm_return_value)
4585         (thread_fsm_set_finished, thread_fsm_finished_p)
4586         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4587         Don't declare.
4588         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4589         * infrun.c (clear_proceed_status_thread)
4590         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4591         (print_stop_event): Update.
4592         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4593         Add constructor.
4594         (step_command_fsm_ops): Remove.
4595         (new_step_command_fsm): Remove.
4596         (step_1): Update.
4597         (step_command_fsm::should_stop): Rename from
4598         step_command_fsm_should_stop.
4599         (step_command_fsm::clean_up): Rename from
4600         step_command_fsm_clean_up.
4601         (step_command_fsm::do_async_reply_reason): Rename from
4602         step_command_fsm_async_reply_reason.
4603         (struct until_next_fsm): Inherit from thread_fsm.  Add
4604         constructor.
4605         (until_next_fsm_ops): Remove.
4606         (new_until_next_fsm): Remove.
4607         (until_next_fsm::should_stop): Rename from
4608         until_next_fsm_should_stop.
4609         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4610         (until_next_fsm::do_async_reply_reason): Rename from
4611         until_next_fsm_async_reply_reason.
4612         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4613         constructor.  Change type of breakpoint.
4614         (finish_command_fsm_ops): Remove.
4615         (new_finish_command_fsm): Remove.
4616         (finish_command_fsm::should_stop): Rename from
4617         finish_command_fsm_should_stop.
4618         (finish_command_fsm::clean_up): Rename from
4619         finish_command_fsm_clean_up.
4620         (finish_command_fsm::return_value): Rename from
4621         finish_command_fsm_return_value.
4622         (finish_command_fsm::do_async_reply_reason): Rename from
4623         finish_command_fsm_async_reply_reason.
4624         (finish_command): Update.
4625         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4626         Add constructor.
4627         (call_thread_fsm_ops): Remove.
4628         (call_thread_fsm::call_thread_fsm): Rename from
4629         new_call_thread_fsm.
4630         (call_thread_fsm::should_stop): Rename from
4631         call_thread_fsm_should_stop.
4632         (call_thread_fsm::should_notify_stop): Rename from
4633         call_thread_fsm_should_notify_stop.
4634         (run_inferior_call, call_function_by_hand_dummy): Update.
4635         * cli/cli-interp.c (should_print_stop_to_console): Update.
4636         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4637         Add constructor.  Change type of location_breakpoint,
4638         caller_breakpoint.
4639         (until_break_fsm_ops): Remove.
4640         (new_until_break_fsm): Remove.
4641         (until_break_fsm::should_stop): Rename from
4642         until_break_fsm_should_stop.
4643         (until_break_fsm::clean_up): Rename from
4644         until_break_fsm_clean_up.
4645         (until_break_fsm::do_async_reply_reason): Rename from
4646         until_break_fsm_async_reply_reason.
4647         (until_break_command): Update.
4648         * thread-fsm.c: Remove.
4649         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4650
4651 2019-02-07  Tom Tromey  <tom@tromey.com>
4652
4653         * yy-remap.h: Add include guard.
4654         * xtensa-tdep.h: Add include guard.
4655         * xcoffread.h: Rename include guard.
4656         * varobj-iter.h: Add include guard.
4657         * tui/tui.h: Rename include guard.
4658         * tui/tui-winsource.h: Rename include guard.
4659         * tui/tui-wingeneral.h: Rename include guard.
4660         * tui/tui-windata.h: Rename include guard.
4661         * tui/tui-win.h: Rename include guard.
4662         * tui/tui-stack.h: Rename include guard.
4663         * tui/tui-source.h: Rename include guard.
4664         * tui/tui-regs.h: Rename include guard.
4665         * tui/tui-out.h: Rename include guard.
4666         * tui/tui-layout.h: Rename include guard.
4667         * tui/tui-io.h: Rename include guard.
4668         * tui/tui-hooks.h: Rename include guard.
4669         * tui/tui-file.h: Rename include guard.
4670         * tui/tui-disasm.h: Rename include guard.
4671         * tui/tui-data.h: Rename include guard.
4672         * tui/tui-command.h: Rename include guard.
4673         * tic6x-tdep.h: Add include guard.
4674         * target/waitstatus.h: Rename include guard.
4675         * target/wait.h: Rename include guard.
4676         * target/target.h: Rename include guard.
4677         * target/resume.h: Rename include guard.
4678         * target-float.h: Rename include guard.
4679         * stabsread.h: Add include guard.
4680         * rs6000-tdep.h: Add include guard.
4681         * riscv-fbsd-tdep.h: Add include guard.
4682         * regformats/regdef.h: Rename include guard.
4683         * record.h: Rename include guard.
4684         * python/python.h: Rename include guard.
4685         * python/python-internal.h: Rename include guard.
4686         * python/py-stopevent.h: Rename include guard.
4687         * python/py-ref.h: Rename include guard.
4688         * python/py-record.h: Rename include guard.
4689         * python/py-record-full.h: Rename include guard.
4690         * python/py-record-btrace.h: Rename include guard.
4691         * python/py-instruction.h: Rename include guard.
4692         * python/py-events.h: Rename include guard.
4693         * python/py-event.h: Rename include guard.
4694         * procfs.h: Add include guard.
4695         * proc-utils.h: Add include guard.
4696         * p-lang.h: Add include guard.
4697         * or1k-tdep.h: Rename include guard.
4698         * observable.h: Rename include guard.
4699         * nto-tdep.h: Rename include guard.
4700         * nat/x86-linux.h: Rename include guard.
4701         * nat/x86-linux-dregs.h: Rename include guard.
4702         * nat/x86-gcc-cpuid.h: Add include guard.
4703         * nat/x86-dregs.h: Rename include guard.
4704         * nat/x86-cpuid.h: Rename include guard.
4705         * nat/ppc-linux.h: Rename include guard.
4706         * nat/mips-linux-watch.h: Rename include guard.
4707         * nat/linux-waitpid.h: Rename include guard.
4708         * nat/linux-ptrace.h: Rename include guard.
4709         * nat/linux-procfs.h: Rename include guard.
4710         * nat/linux-osdata.h: Rename include guard.
4711         * nat/linux-nat.h: Rename include guard.
4712         * nat/linux-namespaces.h: Rename include guard.
4713         * nat/linux-btrace.h: Rename include guard.
4714         * nat/glibc_thread_db.h: Rename include guard.
4715         * nat/gdb_thread_db.h: Rename include guard.
4716         * nat/gdb_ptrace.h: Rename include guard.
4717         * nat/fork-inferior.h: Rename include guard.
4718         * nat/amd64-linux-siginfo.h: Rename include guard.
4719         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4720         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4721         * nat/aarch64-linux.h: Rename include guard.
4722         * nat/aarch64-linux-hw-point.h: Rename include guard.
4723         * mn10300-tdep.h: Add include guard.
4724         * mips-linux-tdep.h: Add include guard.
4725         * mi/mi-parse.h: Rename include guard.
4726         * mi/mi-out.h: Rename include guard.
4727         * mi/mi-main.h: Rename include guard.
4728         * mi/mi-interp.h: Rename include guard.
4729         * mi/mi-getopt.h: Rename include guard.
4730         * mi/mi-console.h: Rename include guard.
4731         * mi/mi-common.h: Rename include guard.
4732         * mi/mi-cmds.h: Rename include guard.
4733         * mi/mi-cmd-break.h: Rename include guard.
4734         * m2-lang.h: Add include guard.
4735         * location.h: Rename include guard.
4736         * linux-record.h: Rename include guard.
4737         * linux-nat.h: Add include guard.
4738         * linux-fork.h: Add include guard.
4739         * i386-darwin-tdep.h: Rename include guard.
4740         * hppa-linux-offsets.h: Add include guard.
4741         * guile/guile.h: Rename include guard.
4742         * guile/guile-internal.h: Rename include guard.
4743         * gnu-nat.h: Rename include guard.
4744         * gdb-stabs.h: Rename include guard.
4745         * frv-tdep.h: Add include guard.
4746         * f-lang.h: Add include guard.
4747         * event-loop.h: Add include guard.
4748         * darwin-nat.h: Rename include guard.
4749         * cp-abi.h: Rename include guard.
4750         * config/sparc/nm-sol2.h: Rename include guard.
4751         * config/nm-nto.h: Rename include guard.
4752         * config/nm-linux.h: Add include guard.
4753         * config/i386/nm-i386gnu.h: Rename include guard.
4754         * config/djgpp/nl_types.h: Rename include guard.
4755         * config/djgpp/langinfo.h: Rename include guard.
4756         * compile/gcc-cp-plugin.h: Add include guard.
4757         * compile/gcc-c-plugin.h: Add include guard.
4758         * compile/compile.h: Rename include guard.
4759         * compile/compile-object-run.h: Rename include guard.
4760         * compile/compile-object-load.h: Rename include guard.
4761         * compile/compile-internal.h: Rename include guard.
4762         * compile/compile-cplus.h: Rename include guard.
4763         * compile/compile-c.h: Rename include guard.
4764         * common/xml-utils.h: Rename include guard.
4765         * common/x86-xstate.h: Rename include guard.
4766         * common/version.h: Rename include guard.
4767         * common/vec.h: Rename include guard.
4768         * common/tdesc.h: Rename include guard.
4769         * common/selftest.h: Rename include guard.
4770         * common/scoped_restore.h: Rename include guard.
4771         * common/scoped_mmap.h: Rename include guard.
4772         * common/scoped_fd.h: Rename include guard.
4773         * common/safe-iterator.h: Rename include guard.
4774         * common/run-time-clock.h: Rename include guard.
4775         * common/refcounted-object.h: Rename include guard.
4776         * common/queue.h: Rename include guard.
4777         * common/ptid.h: Rename include guard.
4778         * common/print-utils.h: Rename include guard.
4779         * common/preprocessor.h: Rename include guard.
4780         * common/pathstuff.h: Rename include guard.
4781         * common/observable.h: Rename include guard.
4782         * common/netstuff.h: Rename include guard.
4783         * common/job-control.h: Rename include guard.
4784         * common/host-defs.h: Rename include guard.
4785         * common/gdb_wait.h: Rename include guard.
4786         * common/gdb_vecs.h: Rename include guard.
4787         * common/gdb_unlinker.h: Rename include guard.
4788         * common/gdb_unique_ptr.h: Rename include guard.
4789         * common/gdb_tilde_expand.h: Rename include guard.
4790         * common/gdb_sys_time.h: Rename include guard.
4791         * common/gdb_string_view.h: Rename include guard.
4792         * common/gdb_splay_tree.h: Rename include guard.
4793         * common/gdb_setjmp.h: Rename include guard.
4794         * common/gdb_ref_ptr.h: Rename include guard.
4795         * common/gdb_optional.h: Rename include guard.
4796         * common/gdb_locale.h: Rename include guard.
4797         * common/gdb_assert.h: Rename include guard.
4798         * common/filtered-iterator.h: Rename include guard.
4799         * common/filestuff.h: Rename include guard.
4800         * common/fileio.h: Rename include guard.
4801         * common/environ.h: Rename include guard.
4802         * common/common-utils.h: Rename include guard.
4803         * common/common-types.h: Rename include guard.
4804         * common/common-regcache.h: Rename include guard.
4805         * common/common-inferior.h: Rename include guard.
4806         * common/common-gdbthread.h: Rename include guard.
4807         * common/common-exceptions.h: Rename include guard.
4808         * common/common-defs.h: Rename include guard.
4809         * common/common-debug.h: Rename include guard.
4810         * common/cleanups.h: Rename include guard.
4811         * common/buffer.h: Rename include guard.
4812         * common/btrace-common.h: Rename include guard.
4813         * common/break-common.h: Rename include guard.
4814         * cli/cli-utils.h: Rename include guard.
4815         * cli/cli-style.h: Rename include guard.
4816         * cli/cli-setshow.h: Rename include guard.
4817         * cli/cli-script.h: Rename include guard.
4818         * cli/cli-interp.h: Rename include guard.
4819         * cli/cli-decode.h: Rename include guard.
4820         * cli/cli-cmds.h: Rename include guard.
4821         * charset-list.h: Add include guard.
4822         * buildsym-legacy.h: Rename include guard.
4823         * bfin-tdep.h: Add include guard.
4824         * ax.h: Rename include guard.
4825         * arm-linux-tdep.h: Add include guard.
4826         * arm-fbsd-tdep.h: Add include guard.
4827         * arch/xtensa.h: Rename include guard.
4828         * arch/tic6x.h: Add include guard.
4829         * arch/i386.h: Add include guard.
4830         * arch/arm.h: Rename include guard.
4831         * arch/arm-linux.h: Rename include guard.
4832         * arch/arm-get-next-pcs.h: Rename include guard.
4833         * arch/amd64.h: Add include guard.
4834         * arch/aarch64-insn.h: Rename include guard.
4835         * arch-utils.h: Rename include guard.
4836         * annotate.h: Add include guard.
4837         * amd64-darwin-tdep.h: Rename include guard.
4838         * aarch64-linux-tdep.h: Add include guard.
4839         * aarch64-fbsd-tdep.h: Add include guard.
4840         * aarch32-linux-nat.h: Add include guard.
4841
4842 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4843
4844         * macrotab.c (macro_define_internal): New function that
4845         factorizes macro_define_object_internal and macro_define_function
4846         code.
4847         (macro_define_object_internal): Use macro_define_internal.
4848         (macro_define_function): Likewise.
4849
4850 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4851
4852         * macrocmd.c (extract_identifier): Return
4853         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4854         callers.
4855
4856 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4857
4858         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4859
4860 2019-02-05  Tom Tromey  <tom@tromey.com>
4861
4862         * target.c (target_stack::unpush): Move assertion earlier.
4863
4864 2019-01-30  Tom Tromey  <tom@tromey.com>
4865
4866         PR python/23615:
4867         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4868         (gdbpy_parse_and_eval): Likewise.
4869         * python/python-internal.h (gdbpy_allow_threads): New class.
4870
4871 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4872
4873         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4874         (aarch64_fbsd_fpregmap): Move earlier.
4875         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4876         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4877         instead of individual calls to trad_frame_set_reg_addr.
4878         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4879         earlier.
4880         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4881         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4882         instead of individual calls to trad_frame_set_reg_addr.
4883
4884 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4885
4886         * CONTRIBUTE: Replace contribution list with wiki link.
4887
4888 2019-01-25  Tom Tromey  <tom@tromey.com>
4889
4890         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4891
4892 2019-01-25  Tom Tromey  <tom@tromey.com>
4893
4894         * xtensa-linux-nat.c: Fix common/ includes.
4895         * xml-support.h: Fix common/ includes.
4896         * xml-support.c: Fix common/ includes.
4897         * x86-linux-nat.c: Fix common/ includes.
4898         * windows-nat.c: Fix common/ includes.
4899         * varobj.h: Fix common/ includes.
4900         * varobj.c: Fix common/ includes.
4901         * value.c: Fix common/ includes.
4902         * valops.c: Fix common/ includes.
4903         * utils.c: Fix common/ includes.
4904         * unittests/xml-utils-selftests.c: Fix common/ includes.
4905         * unittests/utils-selftests.c: Fix common/ includes.
4906         * unittests/unpack-selftests.c: Fix common/ includes.
4907         * unittests/tracepoint-selftests.c: Fix common/ includes.
4908         * unittests/style-selftests.c: Fix common/ includes.
4909         * unittests/string_view-selftests.c: Fix common/ includes.
4910         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4911         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4912         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4913         * unittests/rsp-low-selftests.c: Fix common/ includes.
4914         * unittests/parse-connection-spec-selftests.c: Fix common/
4915         includes.
4916         * unittests/optional-selftests.c: Fix common/ includes.
4917         * unittests/offset-type-selftests.c: Fix common/ includes.
4918         * unittests/observable-selftests.c: Fix common/ includes.
4919         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4920         * unittests/memrange-selftests.c: Fix common/ includes.
4921         * unittests/memory-map-selftests.c: Fix common/ includes.
4922         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4923         * unittests/function-view-selftests.c: Fix common/ includes.
4924         * unittests/environ-selftests.c: Fix common/ includes.
4925         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4926         * unittests/common-utils-selftests.c: Fix common/ includes.
4927         * unittests/cli-utils-selftests.c: Fix common/ includes.
4928         * unittests/array-view-selftests.c: Fix common/ includes.
4929         * ui-file.c: Fix common/ includes.
4930         * tui/tui-io.c: Fix common/ includes.
4931         * tracepoint.h: Fix common/ includes.
4932         * tracepoint.c: Fix common/ includes.
4933         * tracefile-tfile.c: Fix common/ includes.
4934         * top.h: Fix common/ includes.
4935         * top.c: Fix common/ includes.
4936         * thread.c: Fix common/ includes.
4937         * target/waitstatus.h: Fix common/ includes.
4938         * target/waitstatus.c: Fix common/ includes.
4939         * target.h: Fix common/ includes.
4940         * target.c: Fix common/ includes.
4941         * target-memory.c: Fix common/ includes.
4942         * target-descriptions.c: Fix common/ includes.
4943         * symtab.h: Fix common/ includes.
4944         * symfile.c: Fix common/ includes.
4945         * stap-probe.c: Fix common/ includes.
4946         * spu-linux-nat.c: Fix common/ includes.
4947         * sparc-nat.c: Fix common/ includes.
4948         * source.c: Fix common/ includes.
4949         * solib.c: Fix common/ includes.
4950         * solib-target.c: Fix common/ includes.
4951         * ser-unix.c: Fix common/ includes.
4952         * ser-tcp.c: Fix common/ includes.
4953         * ser-pipe.c: Fix common/ includes.
4954         * ser-base.c: Fix common/ includes.
4955         * selftest-arch.c: Fix common/ includes.
4956         * s12z-tdep.c: Fix common/ includes.
4957         * rust-exp.y: Fix common/ includes.
4958         * rs6000-aix-tdep.c: Fix common/ includes.
4959         * riscv-tdep.c: Fix common/ includes.
4960         * remote.c: Fix common/ includes.
4961         * remote-notif.h: Fix common/ includes.
4962         * remote-fileio.h: Fix common/ includes.
4963         * remote-fileio.c: Fix common/ includes.
4964         * regcache.h: Fix common/ includes.
4965         * regcache.c: Fix common/ includes.
4966         * record-btrace.c: Fix common/ includes.
4967         * python/python.c: Fix common/ includes.
4968         * python/py-type.c: Fix common/ includes.
4969         * python/py-inferior.c: Fix common/ includes.
4970         * progspace.h: Fix common/ includes.
4971         * producer.c: Fix common/ includes.
4972         * procfs.c: Fix common/ includes.
4973         * proc-api.c: Fix common/ includes.
4974         * printcmd.c: Fix common/ includes.
4975         * ppc-linux-nat.c: Fix common/ includes.
4976         * parser-defs.h: Fix common/ includes.
4977         * osdata.c: Fix common/ includes.
4978         * obsd-nat.c: Fix common/ includes.
4979         * nat/x86-linux.c: Fix common/ includes.
4980         * nat/x86-linux-dregs.c: Fix common/ includes.
4981         * nat/x86-dregs.h: Fix common/ includes.
4982         * nat/x86-dregs.c: Fix common/ includes.
4983         * nat/ppc-linux.c: Fix common/ includes.
4984         * nat/mips-linux-watch.h: Fix common/ includes.
4985         * nat/mips-linux-watch.c: Fix common/ includes.
4986         * nat/linux-waitpid.c: Fix common/ includes.
4987         * nat/linux-ptrace.h: Fix common/ includes.
4988         * nat/linux-ptrace.c: Fix common/ includes.
4989         * nat/linux-procfs.c: Fix common/ includes.
4990         * nat/linux-personality.c: Fix common/ includes.
4991         * nat/linux-osdata.c: Fix common/ includes.
4992         * nat/linux-namespaces.c: Fix common/ includes.
4993         * nat/linux-btrace.h: Fix common/ includes.
4994         * nat/linux-btrace.c: Fix common/ includes.
4995         * nat/fork-inferior.c: Fix common/ includes.
4996         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4997         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4998         * nat/aarch64-linux.c: Fix common/ includes.
4999         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5000         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5001         * namespace.h: Fix common/ includes.
5002         * mips-linux-tdep.c: Fix common/ includes.
5003         * minsyms.c: Fix common/ includes.
5004         * mi/mi-parse.h: Fix common/ includes.
5005         * mi/mi-main.c: Fix common/ includes.
5006         * mi/mi-cmd-env.c: Fix common/ includes.
5007         * memrange.h: Fix common/ includes.
5008         * memattr.c: Fix common/ includes.
5009         * maint.h: Fix common/ includes.
5010         * maint.c: Fix common/ includes.
5011         * main.c: Fix common/ includes.
5012         * machoread.c: Fix common/ includes.
5013         * location.c: Fix common/ includes.
5014         * linux-thread-db.c: Fix common/ includes.
5015         * linux-nat.c: Fix common/ includes.
5016         * linux-fork.c: Fix common/ includes.
5017         * inline-frame.c: Fix common/ includes.
5018         * infrun.c: Fix common/ includes.
5019         * inflow.c: Fix common/ includes.
5020         * inferior.h: Fix common/ includes.
5021         * inferior.c: Fix common/ includes.
5022         * infcmd.c: Fix common/ includes.
5023         * inf-ptrace.c: Fix common/ includes.
5024         * inf-child.c: Fix common/ includes.
5025         * ia64-linux-nat.c: Fix common/ includes.
5026         * i387-tdep.c: Fix common/ includes.
5027         * i386-tdep.c: Fix common/ includes.
5028         * i386-linux-tdep.c: Fix common/ includes.
5029         * i386-linux-nat.c: Fix common/ includes.
5030         * i386-go32-tdep.c: Fix common/ includes.
5031         * i386-fbsd-tdep.c: Fix common/ includes.
5032         * i386-fbsd-nat.c: Fix common/ includes.
5033         * guile/scm-type.c: Fix common/ includes.
5034         * guile/guile.c: Fix common/ includes.
5035         * go32-nat.c: Fix common/ includes.
5036         * gnu-nat.c: Fix common/ includes.
5037         * gdbthread.h: Fix common/ includes.
5038         * gdbarch-selftests.c: Fix common/ includes.
5039         * gdb_usleep.c: Fix common/ includes.
5040         * gdb_select.h: Fix common/ includes.
5041         * gdb_bfd.c: Fix common/ includes.
5042         * gcore.c: Fix common/ includes.
5043         * fork-child.c: Fix common/ includes.
5044         * findvar.c: Fix common/ includes.
5045         * fbsd-nat.c: Fix common/ includes.
5046         * event-top.c: Fix common/ includes.
5047         * event-loop.c: Fix common/ includes.
5048         * dwarf2read.c: Fix common/ includes.
5049         * dwarf2loc.c: Fix common/ includes.
5050         * dwarf2-frame.c: Fix common/ includes.
5051         * dwarf-index-cache.c: Fix common/ includes.
5052         * dtrace-probe.c: Fix common/ includes.
5053         * disasm-selftests.c: Fix common/ includes.
5054         * defs.h: Fix common/ includes.
5055         * csky-tdep.c: Fix common/ includes.
5056         * cp-valprint.c: Fix common/ includes.
5057         * cp-support.h: Fix common/ includes.
5058         * cp-support.c: Fix common/ includes.
5059         * corelow.c: Fix common/ includes.
5060         * completer.h: Fix common/ includes.
5061         * completer.c: Fix common/ includes.
5062         * compile/compile.c: Fix common/ includes.
5063         * compile/compile-loc2c.c: Fix common/ includes.
5064         * compile/compile-cplus-types.c: Fix common/ includes.
5065         * compile/compile-cplus-symbols.c: Fix common/ includes.
5066         * command.h: Fix common/ includes.
5067         * cli/cli-dump.c: Fix common/ includes.
5068         * cli/cli-cmds.c: Fix common/ includes.
5069         * charset.c: Fix common/ includes.
5070         * build-id.c: Fix common/ includes.
5071         * btrace.h: Fix common/ includes.
5072         * btrace.c: Fix common/ includes.
5073         * breakpoint.h: Fix common/ includes.
5074         * breakpoint.c: Fix common/ includes.
5075         * ax.h:
5076         (enum agent_op): Fix common/ includes.
5077         * ax-general.c (struct aop_map): Fix common/ includes.
5078         * ax-gdb.c: Fix common/ includes.
5079         * auxv.c: Fix common/ includes.
5080         * auto-load.c: Fix common/ includes.
5081         * arm-tdep.c: Fix common/ includes.
5082         * arch/riscv.c: Fix common/ includes.
5083         * arch/ppc-linux-common.c: Fix common/ includes.
5084         * arch/i386.c: Fix common/ includes.
5085         * arch/arm.c: Fix common/ includes.
5086         * arch/arm-linux.c: Fix common/ includes.
5087         * arch/arm-get-next-pcs.c: Fix common/ includes.
5088         * arch/amd64.c: Fix common/ includes.
5089         * arch/aarch64.c: Fix common/ includes.
5090         * arch/aarch64-insn.c: Fix common/ includes.
5091         * arch-utils.c: Fix common/ includes.
5092         * amd64-windows-tdep.c: Fix common/ includes.
5093         * amd64-tdep.c: Fix common/ includes.
5094         * amd64-sol2-tdep.c: Fix common/ includes.
5095         * amd64-obsd-tdep.c: Fix common/ includes.
5096         * amd64-nbsd-tdep.c: Fix common/ includes.
5097         * amd64-linux-tdep.c: Fix common/ includes.
5098         * amd64-linux-nat.c: Fix common/ includes.
5099         * amd64-fbsd-tdep.c: Fix common/ includes.
5100         * amd64-fbsd-nat.c: Fix common/ includes.
5101         * amd64-dicos-tdep.c: Fix common/ includes.
5102         * amd64-darwin-tdep.c: Fix common/ includes.
5103         * agent.c: Fix common/ includes.
5104         * ada-lang.h: Fix common/ includes.
5105         * ada-lang.c: Fix common/ includes.
5106         * aarch64-tdep.c: Fix common/ includes.
5107
5108 2019-01-25  Tom Tromey  <tom@tromey.com>
5109
5110         * common/create-version.sh: Use common/version.h.
5111
5112 2019-01-24  Pedro Alves  <palves@redhat.com>
5113
5114         * infrun.c (signal_stop, signal_print, signal_program)
5115         (signal_catch, signal_pass): Now arrays instead of pointers.
5116         (update_signals_program_target, do_target_resume)
5117         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5118         * linux-nat.c (linux_nat_target::pass_signals)
5119         (linux_nat_target::create_inferior, linux_nat_target::attach):
5120         Adjust.
5121         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5122         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5123         * procfs.c (procfs_target::pass_signals): Adjust.
5124         * record-full.c (record_full_target::resume): Adjust.
5125         * remote.c (remote_target::pass_signals)
5126         (remote_target::program_signals): Adjust.
5127         * target-debug.h (target_debug_print_signals): Now takes a
5128         gdb::array_view as parameter.  Adjust.
5129         * target.h (target_ops) <pass_signals, program_signals>: Replace
5130         pointer and length parameters with gdb::array_view.
5131         (target_pass_signals, target_program_signals): Likewise.
5132         * target-delegates.c: Regenerate.
5133
5134 2019-01-24  Pedro Alves  <palves@redhat.com>
5135
5136         * common/forward-scope-exit.h
5137         (forward_scope_exit::forward_scope_exit): Pass arguments to
5138         m_bind_function directly, instead of creating a std::bind and
5139         copying that.
5140
5141 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5142
5143         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5144         for static members.
5145         (pass_in_v_vfp_candidate): Likewise.
5146
5147 2019-01-23  Tom Tromey  <tom@tromey.com>
5148             Pedro Alves  <palves@redhat.com>
5149
5150         * regcache.c (class regcache_invalidator): Remove.
5151         (regcache::raw_write): Use make_scope_exit.
5152
5153 2019-01-23  Tom Tromey  <tom@tromey.com>
5154
5155         * ui-out.h (class ui_out_emit_type): Update comment.
5156
5157 2019-01-23  Tom Tromey  <tom@tromey.com>
5158
5159         * infrun.c (fetch_inferior_event): Update comment.
5160
5161 2019-01-23  Tom Tromey  <tom@tromey.com>
5162             Pedro Alves  <palves@redhat.com>
5163
5164         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5165         parameter.
5166         (fetch_inferior_event): Use SCOPE_EXIT.
5167
5168
5169 2019-01-23  Tom Tromey  <tom@tromey.com>
5170             Pedro Alves  <palves@redhat.com>
5171
5172         * infrun.c (disable_thread_events): Delete.
5173         (stop_all_threads): Use SCOPE_EXIT.
5174
5175 2019-01-23  Tom Tromey  <tom@tromey.com>
5176             Pedro Alves  <palves@redhat.com>
5177
5178         * symfile.c: Include forward-scope-exit.h.
5179         (clear_symtab_users_cleanup): Replace forward declaration with
5180         a FORWARD_SCOPE_EXIT.
5181         (syms_from_objfile_1): Use the forward_scope_exit and
5182         gdb::optional instead of cleanup_function.
5183         (reread_symbols): Use the forward_scope_exit instead of
5184         cleanup_function.
5185         (clear_symtab_users_cleanup): Remove function.
5186
5187 2019-01-23  Tom Tromey  <tom@tromey.com>
5188             Pedro Alves  <palves@redhat.com>
5189
5190         * linux-nat.c: Include scope-exit.h.
5191         (cleanup_target_stop): Remove.
5192         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5193         SCOPE_EXIT.
5194
5195 2019-01-23  Tom Tromey  <tom@tromey.com>
5196             Pedro Alves  <palves@redhat.com>
5197
5198         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5199         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5200
5201 2019-01-23  Tom Tromey  <tom@tromey.com>
5202             Andrew Burgess  <andrew.burgess@embecosm.com>
5203             Pedro Alves  <palves@redhat.com>
5204
5205         * infrun.c (fetch_inferior_event): Use scope_exit.
5206         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5207         * top.c (execute_command): Use scope_exit.
5208         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5209         * utils.c (do_bpstat_clear_actions_cleanup)
5210         (make_bpstat_clear_actions_cleanup): Remove.
5211
5212 2019-01-23  Tom Tromey  <tom@tromey.com>
5213             Pedro Alves  <palves@redhat.com>
5214
5215         * infrun.c: Include "common/scope-exit.h"
5216         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5217         (wait_for_inferior): Use SCOPE_EXIT.
5218         (fetch_inferior_event): Use scope_exit.
5219
5220 2019-01-23  Tom Tromey  <tom@tromey.com>
5221             Pedro Alves  <palves@redhat.com>
5222
5223         * breakpoint.c (create_breakpoint): Remove cleanup.
5224
5225 2019-01-23  Tom Tromey  <tom@tromey.com>
5226             Andrew Burgess  <andrew.burgess@embecosm.com>
5227             Pedro Alves  <palves@redhat.com>
5228
5229 2019-01-23  Pedro Alves  <palves@redhat.com>
5230
5231         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5232
5233 2019-01-23  Pedro Alves  <palves@redhat.com>
5234             Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * gdbthread.h: Include "common/forward-scope-exit.h".
5237         (scoped_finish_thread_state): Redefine custom class in terms of
5238         forward_scope_exit.
5239
5240 2019-01-23  Pedro Alves  <palves@redhat.com>
5241             Andrew Burgess  <andrew.burgess@embecosm.com>
5242
5243         * common/forward-scope-exit.h: New file.
5244
5245 2019-01-23  Pedro Alves  <palves@redhat.com>
5246             Andrew Burgess  <andrew.burgess@embecosm.com>
5247             Tom Tromey  <tom@tromey.com>
5248
5249         * common/scope-exit.h: New file.
5250
5251 2019-01-23  Pedro Alves  <palves@redhat.com>
5252
5253         * common/preprocessor.h (ESC): Rename to ...
5254         (ESC_PARENS): ... this.
5255         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5256         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5257
5258 2019-01-23  Tom Tromey  <tom@tromey.com>
5259
5260         * language.h (class scoped_switch_to_sym_language_if_auto):
5261         Initialize m_lang in both cases.
5262
5263 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5264
5265         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5266         with XCNEW.
5267
5268 2019-01-22  Tom Tromey  <tom@tromey.com>
5269
5270         * corelow.c: Do not include sys/file.h.
5271
5272 2019-01-22  Tom Tromey  <tom@tromey.com>
5273
5274         * tui/tui-wingeneral.h: Include gdb_curses.h.
5275
5276 2019-01-22  Tom Tromey  <tom@tromey.com>
5277
5278         * source-cache.h (class source_cache) <get_source_lines,
5279         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5280
5281 2019-01-22  Tom Tromey  <tom@tromey.com>
5282
5283         * remote-fileio.h (struct remote_target): Declare.
5284
5285 2019-01-22  Tom Tromey  <tom@tromey.com>
5286
5287         * python/py-arch.c: Do not include py-ref.h.
5288         * python/py-bpevent.c: Do not include py-ref.h.
5289         * python/py-cmd.c: Do not include py-ref.h.
5290         * python/py-continueevent.c: Do not include py-ref.h.
5291         * python/py-event.h: Do not include py-ref.h.
5292         * python/py-evtregistry.c: Do not include py-ref.h.
5293         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5294         * python/py-frame.c: Do not include py-ref.h.
5295         * python/py-framefilter.c: Do not include py-ref.h.
5296         * python/py-function.c: Do not include py-ref.h.
5297         * python/py-infevents.c: Do not include py-ref.h.
5298         * python/py-linetable.c: Do not include py-ref.h.
5299         * python/py-objfile.c: Do not include py-ref.h.
5300         * python/py-param.c: Do not include py-ref.h.
5301         * python/py-prettyprint.c: Do not include py-ref.h.
5302         * python/py-progspace.c: Do not include py-ref.h.
5303         * python/py-symbol.c: Do not include py-ref.h.
5304         * python/py-symtab.c: Do not include py-ref.h.
5305         * python/py-type.c: Do not include py-ref.h.
5306         * python/py-unwind.c: Do not include py-ref.h.
5307         * python/py-utils.c: Do not include py-ref.h.
5308         * python/py-value.c: Do not include py-ref.h.
5309         * python/py-varobj.c: Do not include py-ref.h.
5310         * python/py-xmethods.c: Do not include py-ref.h.
5311         * python/python.c: Do not include py-ref.h.
5312         * varobj.c: Do not include py-ref.h.
5313
5314 2019-01-22  Tom Tromey  <tom@tromey.com>
5315
5316         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5317         keyword for bcache.
5318
5319 2019-01-22  Tom Tromey  <tom@tromey.com>
5320
5321         * compile/compile-cplus-types.c: Remove a comment by #include.
5322
5323 2019-01-22  Tom Tromey  <tom@tromey.com>
5324
5325         * compile/gcc-c-plugin.h: Include compile-internal.h.
5326
5327 2019-01-22  Tom Tromey  <tom@tromey.com>
5328
5329         * stabsread.c (EXTERN): Do not define.
5330         (symnum, next_symbol_text_func, processing_gcc_compilation)
5331         (within_function, global_sym_chain, global_stabs)
5332         (previous_stab_code, this_object_header_files)
5333         (n_this_object_header_files)
5334         (n_allocated_this_object_header_files): Define.
5335         * stabsread.h (EXTERN): Never define.  Use "extern".
5336
5337 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5338
5339         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5340         history_value.
5341
5342 2019-01-21  Tom Tromey  <tom@tromey.com>
5343
5344         * ui-out.c: Fix includes.
5345         * tui/tui-source.c: Fix includes.
5346         * target.c: Fix includes.
5347         * remote.c: Fix includes.
5348         * regcache.c: Fix includes.
5349         * python/py-block.c: Fix includes.
5350         * printcmd.c: Fix includes.
5351         * or1k-tdep.c: Fix includes.
5352         * mi/mi-main.c: Fix includes.
5353         * m32r-tdep.c: Fix includes.
5354         * csky-tdep.c: Fix includes.
5355         * compile/compile-cplus-types.c: Fix includes.
5356         * cli/cli-interp.c: Fix includes.
5357
5358 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5359
5360         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5361         for padding.
5362
5363 2019-01-16  Tom Tromey  <tom@tromey.com>
5364
5365         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5366         earlier.
5367         (struct objfile) <msymbols_range>: Move from top level.
5368         <msymbols>: New method.
5369         (class objfile_msymbols): Remove.
5370         * symtab.c (default_collect_symbol_completion_matches_break_on):
5371         Update.
5372         * symmisc.c (dump_msymbols): Update.
5373         * stabsread.c (scan_file_globals): Update.
5374         * objc-lang.c (info_selectors_command, info_classes_command)
5375         (find_methods): Update.
5376         * minsyms.c (find_solib_trampoline_target): Update.
5377         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5378         * coffread.c (coff_symfile_read): Update.
5379         * ada-lang.c (ada_lookup_simple_minsym)
5380         (ada_collect_symbol_completion_matches): Update.
5381
5382 2019-01-16  Tom Tromey  <tom@tromey.com>
5383
5384         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5385         type.  Remove no-argument constructor.
5386         <iterator::operator++>: Simplify.
5387         <begin>: Update.
5388         <end>: Use minimal_symbol_count.
5389
5390 2019-01-16  Tom Tromey  <tom@tromey.com>
5391
5392         * objfiles.h (struct objfile) <psymtabs>: New method.
5393         (class objfile_psymtabs): Remove.
5394         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5395         typedef.
5396         <range>: New method.
5397         (require_partial_symbols): Change return type.
5398         * psymtab.c (require_partial_symbols)
5399         (psym_expand_symtabs_matching): Update.
5400         * mdebugread.c (parse_partial_symbols): Update.
5401         * dbxread.c (dbx_end_psymtab): Update.
5402
5403 2019-01-15  Tom Tromey  <tom@tromey.com>
5404
5405         * symtab.c (lookup_objfile_from_block)
5406         (lookup_symbol_in_objfile_symtabs)
5407         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5408         (find_line_symtab, info_sources_command)
5409         (default_collect_symbol_completion_matches_break_on)
5410         (make_source_files_completion_list): Update.
5411         * symmisc.c (print_objfile_statistics, dump_objfile)
5412         (maintenance_print_symbols, maintenance_info_symtabs)
5413         (maintenance_check_symtabs, maintenance_info_line_tables):
5414         Update.
5415         * source.c (select_source_symtab)
5416         (forget_cached_source_info_for_objfile): Update.
5417         * objfiles.h (class objfile_compunits): Remove.
5418         (struct objfile) <compunits_range>: New typedef.
5419         (compunits): New method.
5420         * objfiles.c (objfile_relocate1): Update.
5421         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5422         * maint.c (count_symtabs_and_blocks): Update.
5423         * linespec.c (iterate_over_all_matching_symtabs): Update.
5424         * cp-support.c (add_symbol_overload_list_qualified): Update.
5425         * coffread.c (coff_symtab_read): Update.
5426         * ada-lang.c (add_nonlocal_symbols)
5427         (ada_collect_symbol_completion_matches)
5428         (ada_add_global_exceptions): Update.
5429
5430 2019-01-15  Tom Tromey  <tom@tromey.com>
5431
5432         * progspace.h (program_space) <objfiles_safe_range>: New
5433         typedef.
5434         <objfiles_safe>: New method.
5435         * objfiles.h (class all_objfiles_safe): Remove.
5436         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5437         * jit.c (jit_inferior_exit_hook): Update.
5438
5439 2019-01-17  Tom Tromey  <tom@tromey.com>
5440
5441         * progspace.h (program_space) <objfiles_range>: New typedef.
5442         <objfiles>: New method.
5443         <objfiles_head>: Rename from objfiles.
5444         (object_files): Update.
5445         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5446         * guile/scm-pretty-print.c
5447         (ppscm_find_pretty_printer_from_objfiles): Update.
5448         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5449         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5450         Update.
5451         * python/py-progspace.c (pspy_get_objfiles): Update.
5452         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5453         Update.
5454         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5455         (objfpy_lookup_objfile_by_build_id): Update.
5456         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5457         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5458         Update.
5459         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5460         (expand_symtab_containing_pc, lookup_objfile_from_block)
5461         (lookup_static_symbol, basic_lookup_transparent_type)
5462         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5463         (find_line_symtab, info_sources_command)
5464         (default_collect_symbol_completion_matches_break_on)
5465         (make_source_files_completion_list, find_main_name): Update.
5466         * symmisc.c (print_symbol_bcache_statistics)
5467         (print_objfile_statistics, maintenance_print_symbols)
5468         (maintenance_print_msymbols, maintenance_print_objfiles)
5469         (maintenance_info_symtabs, maintenance_check_symtabs)
5470         (maintenance_expand_symtabs, maintenance_info_line_tables):
5471         Update.
5472         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5473         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5474         (map_overlay_command, unmap_overlay_command)
5475         (simple_overlay_update, expand_symtabs_matching)
5476         (map_symbol_filenames): Update.
5477         * symfile-debug.c (set_debug_symfile): Update.
5478         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5479         Update.
5480         * source.c (select_source_symtab, forget_cached_source_info):
5481         Update.
5482         * solib.c (solib_read_symbols): Update.
5483         * solib-spu.c (append_ocl_sos): Update.
5484         * psymtab.c (maintenance_print_psymbols)
5485         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5486         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5487         * printcmd.c (info_symbol_command): Update.
5488         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5489         Update.
5490         * objfiles.h (class all_objfiles): Remove.
5491         * objfiles.c (have_partial_symbols, have_full_symbols)
5492         (have_minimal_symbols, qsort_cmp, update_section_map)
5493         (shared_objfile_contains_address_p)
5494         (default_iterate_over_objfiles_in_search_order): Update.
5495         * objc-lang.c (info_selectors_command, info_classes_command)
5496         (find_methods): Update.
5497         * minsyms.c (find_solib_trampoline_target): Update.
5498         * maint.c (maintenance_info_sections)
5499         (maintenance_translate_address, count_symtabs_and_blocks):
5500         Update.
5501         * main.c (captured_main_1): Update.
5502         * linux-thread-db.c (try_thread_db_load_from_pdir)
5503         (has_libpthread): Update.
5504         * linespec.c (iterate_over_all_matching_symtabs)
5505         (search_minsyms_for_name): Update.
5506         * jit.c (jit_find_objf_with_entry_addr): Update.
5507         * hppa-tdep.c (find_unwind_entry)
5508         (hppa_lookup_stub_minimal_symbol): Update.
5509         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5510         Update.
5511         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5512         (elf_gnu_ifunc_resolve_by_got): Update.
5513         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5514         * dwarf-index-write.c (save_gdb_index_command): Update.
5515         * cp-support.c (add_symbol_overload_list_qualified): Update.
5516         * breakpoint.c (create_overlay_event_breakpoint)
5517         (create_longjmp_master_breakpoint)
5518         (create_std_terminate_master_breakpoint)
5519         (create_exception_master_breakpoint): Update.
5520         * blockframe.c (find_pc_partial_function): Update.
5521         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5522         (ada_collect_symbol_completion_matches)
5523         (ada_add_global_exceptions): Update.
5524
5525 2019-01-17  Tom Tromey  <tom@tromey.com>
5526
5527         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5528         declare VEC.
5529         (solib_target_parse_libraries): Change return type.
5530         (library_list_start_segment, library_list_start_section)
5531         (library_list_end_library, library_list_start_library); Update.
5532         (solib_target_free_library_list): Remove.
5533         (solib_target_parse_libraries): Remove cleanup.  Change return
5534         type.
5535         (solib_target_current_sos): Update.
5536
5537 2019-01-17  Tom Tromey  <tromey@bapiya>
5538
5539         * valprint.c: Replace "the the" with "the".
5540         * symtab.c: Replace "the the" with "the".
5541         * solib.c: Replace "the the" with "the".
5542         * solib-dsbt.c: Replace "the the" with "the".
5543         * linespec.c: Replace "the the" with "the".
5544         * dwarf2loc.h: Replace "the the" with "the".
5545         * amd64-windows-tdep.c: Replace "the the" with "the".
5546         * aarch64-tdep.c: Replace "the the" with "the".
5547
5548 2019-01-16  Keith Seitz  <keiths@redhat.com>
5549
5550         PR gdb/23773
5551         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5552         <builder>: Rename to ..
5553         <m_builder>: ... this and make private.
5554         (dwarf2_cu::get_builder): New method.  Change all users of
5555         `builder' to use this method.
5556         (dwarf2_start_symtab): Move to ...
5557         (dwarf2_cu::start_symtab): ... here.  Update all callers
5558         (setup_type_unit_groups): Move to ...
5559         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5560         callers.
5561         (dwarf2_cu::reset_builder): New method.
5562         (process_full_compunit, process_full_type_unit): Use
5563         dwarf2_cu::reset_builder.
5564         (follow_die_offset): Record the ancestor CU if it is different
5565         from the followed DIE's CU.
5566         (follow_die_sig_1): Likewise.
5567
5568 2019-01-15  Tom Tromey  <tom@tromey.com>
5569
5570         * remote.c (class remote_state) <buf>: Now a char_vector.
5571         <buf_size>: Remove.
5572         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5573         parameter.
5574         (remote_target::getpkt_or_notif_sane_1)
5575         (remote_target::getpkt_sane)
5576         (remote_target::getpkt_or_notif_sane): Likewise.
5577         (class remote_target) <putpkt>: New overload.
5578         (remote_target::read_frame): Change type of "buf_p".  Remove
5579         sizeof_p parameter.
5580         (packet_ok): New overload.
5581         (packet_check_result): New overload.
5582         Update all uses.
5583
5584 2019-01-14  Tom Tromey  <tom@tromey.com>
5585
5586         * remote-notif.c (handle_notification, remote_notif_ack)
5587         (remote_notif_parse): Make "buf" const.
5588         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5589         const.
5590         (remote_notif_parse, remote_notif_ack, handle_notification):
5591         Likewise.
5592         * remote.c (remote_notif_stop_parse): Make "buf" const.
5593         (remote_target::remote_parse_stop_reply): Make "buf" const.
5594         (remote_notif_stop_ack): Make "buf" const.
5595
5596 2019-01-14  Tom Tromey  <tom@tromey.com>
5597
5598         * remote.c (remote_console_output): Make parameter const.
5599
5600 2019-01-14  Tom Tromey  <tom@tromey.com>
5601
5602         * target-debug.h (target_debug_print_signals): Constify.
5603         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5604         * procfs.c (procfs_target::pass_signals): Update.
5605         * linux-nat.c (linux_nat_target::pass_signals): Update.
5606         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5607         * target-delegates.c: Rebuild.
5608         * remote.c (remote_target::program_signals): Update.
5609         (remote_target::pass_signals): Update.
5610         * target.c (target_pass_signals): Constify argument.
5611         (target_program_signals): Likewise.
5612         * target.h (struct target_ops) <pass_signals, program_signals>:
5613         Constify argument.
5614         (target_pass_signals, target_program_signals): Constify argument.
5615
5616 2019-01-14  Tom Tromey  <tom@tromey.com>
5617
5618         PR tui/28819:
5619         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5620
5621 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5622
5623         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5624         field.
5625         * rs6000-tdep.c: Include reggroups.h.
5626         (IS_V_ALIAS_PSEUDOREG): Define.
5627         (rs6000_register_name): Return names for the "vX" aliases.
5628         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5629         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5630         aliases.  Call default_register_reggroup_p for all other
5631         pseudo-registers.
5632         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5633         New functions.
5634         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5635         Handle "vX" aliases.
5636         (v_alias_pseudo_register_collect): New function.
5637         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5638         (rs6000_gdbarch_init): Initialize "vX" aliases as
5639         pseudo-registers.  Restore registration of
5640         rs6000_pseudo_register_reggroup_p with
5641         set_tdesc_pseudo_register_reggroup_p.
5642
5643 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5644
5645         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5646         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5647         set_gdbarch_num_pseudo_regs.
5648
5649 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5650
5651         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5652         Remove arg prefixname, add do_set and do_show.
5653         Add member functions set_list and show_list.
5654         * cli/cli-style.c (class cli_style_option): Update accordingly.
5655         (style_set_list): Move to file scope.
5656         (style_show_list): Likewise.
5657         (set_style): Call help_list.
5658         (show_style): Call cmd_show_list.
5659         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5660         Update to use the new macro.
5661
5662 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5663
5664         * ada-lang.c (_initialize_ada_language): Expand the help text
5665         for the "catch exception" command.
5666
5667 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5668
5669         * symtab.c (matching_obj_sections): Initialize obj,
5670         declare it closer to its usage.
5671
5672 2019-01-10  Tom Tromey  <tom@tromey.com>
5673
5674         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5675         (basic_inf_threads_range): Remove.
5676         (inf_threads_range, inf_non_exited_threads_range)
5677         (safe_inf_threads_range): Use next_adapter.
5678
5679 2019-01-10  Keith Seitz  <keiths@redhat.com>
5680
5681         PR gdb/23712
5682         PR symtab/23010
5683         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5684         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5685
5686 2019-01-10  Keith Seitz  <keiths@redhat.com>
5687
5688         PR gdb/23712
5689         PR symtab/23010
5690         * dictionary.c (pending_to_vector): Remove.
5691         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5692         Remove _1 suffix, replacing functions of the same name.  Update
5693         all callers.
5694         (dict_create_hashed, dict_create_hashed_expandable)
5695         (dict_create_linear, dict_create_linear_expandable, dict_free)
5696         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5697         Make functions static.
5698
5699 2019-01-10  Keith Seitz  <keiths@redhat.com>
5700
5701         PR gdb/23712
5702         PR symtab/23010
5703         * dictionary.h (struct dictionary): Replace declaration with
5704         multidictionary.
5705         (dict_create_hashed, dict_create_hashed_expandable)
5706         (dict_create_linear, dict_create_linear_expandable)
5707         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5708         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5709         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5710         taking multidictionary argument.
5711         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5712         * block.h (struct block) <dict>: Change to multidictionary
5713         and rename `multidict'.
5714         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5715         symmisc.c: Update all dictionary references to multidictionary.
5716
5717 2019-01-10  Keith Seitz  <keiths@redhat.com>
5718
5719         PR gdb/23712
5720         PR symtab/23010
5721         * dictionary.c: Include unordered_map.
5722         (pending_to_vector): New function.
5723         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5724         Rewrite the non-"_1" functions to take vector instead
5725         of linked list.
5726         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5727         "new" _1 versions of the same name.
5728         (multidictionary): Define.
5729         (std::hash<enum language): New definition.
5730         (collate_pending_symbols_by_language, mdict_create_hashed)
5731         (mdict_create_hashed_expandable, mdict_create_linear)
5732         (mdict_create_linear_expandable, mdict_free)
5733         (find_language_dictionary, create_new_language_dictionary)
5734         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5735         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5736         (mdict_size, mdict_empty): New functions.
5737         * dictionary.h (mdict_iterator): Define.
5738
5739 2019-01-10  Pedro Alves  <palves@redhat.com>
5740
5741         * breakpoint.c (read_uploaded_action)
5742         (create_tracepoint_from_upload): Adjust to use
5743         gdb::unique_xmalloc_ptr.
5744         * ctf.c (ctf_write_uploaded_tp):
5745         (SET_ARRAY_FIELD): Use emplace_back.
5746         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5747         * tracefile-tfile.c (tfile_write_uploaded_tp):
5748         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5749         gdb::unique_xmalloc_ptr.
5750         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5751         at_string, cond_string, cmd_strings>: Replace char pointers
5752         with gdb::unique_xmalloc_ptr.
5753
5754 2019-01-10  Pedro Alves  <palves@redhat.com>
5755
5756         * solib-target.c (library_list_start_library): Don't xstrdup name.
5757
5758 2019-01-10  Pedro Alves  <palves@redhat.com>
5759
5760         * mdebugread.c (parse_partial_symbols): Use
5761         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5762
5763 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         * linux-fork.c (scoped_switch_fork_info)
5766         <~scoped_switch_fork_info>: Fix incorrect variable name.
5767
5768 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5769
5770         * linux-fork.c (scoped_switch_fork_info)
5771         <scoped_switch_fork_info>: Make explicit.
5772         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5773
5774 2019-01-10  Tom Tromey  <tom@tromey.com>
5775
5776         * objfiles.h (objfile::reset_psymtabs): Update.
5777         * objfiles.c (objfile::objfile): Update.
5778         * psymtab.h (psymtab_storage::obstack): Update.
5779         (psymtab_storage::m_obstack): Use gdb::optional.
5780         (class psymtab_storage): Update comment.  Remove objfile
5781         parameter.
5782         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5783
5784 2019-01-10  Tom Tromey  <tom@tromey.com>
5785
5786         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5787         <free_psymtabs>: Now private.
5788         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5789         (allocate_psymtab): Use new method.
5790
5791 2019-01-10  Tom Tromey  <tom@tromey.com>
5792
5793         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5794         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5795         * mdebugread.c (parse_partial_symbols): Use
5796         allocate_dependencies.
5797         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5798         allocate_dependencies.
5799         (process_psymtab_comp_unit_reader)
5800         (build_type_psymtab_dependencies): Likewise.
5801         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5802
5803 2019-01-10  Tom Tromey  <tom@tromey.com>
5804
5805         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5806         PSYMBOL_SET_LANGUAGE.
5807         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5808
5809 2019-01-10  Tom Tromey  <tom@tromey.com>
5810
5811         * psymtab.h (psymtab_storage::obstack): New method.
5812         <m_obstack>: Rename from obstack; now private.
5813         * psymtab.c (psymtab_storage): Update.
5814         * dwarf2read.c (create_addrmap_from_index)
5815         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5816         Update.
5817
5818 2019-01-10  Tom Tromey  <tom@tromey.com>
5819
5820         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5821         * objfiles.h (objfile::reset_psymtabs): New method.
5822
5823 2019-01-10  Tom Tromey  <tom@tromey.com>
5824
5825         * symmisc.c (print_symbol_bcache_statistics): Update.
5826         (print_objfile_statistics): Update.
5827         * symfile.c (reread_symbols): Update.
5828         * psymtab.h (class psymtab_storage): New.
5829         * psymtab.c (psymtab_storage): New constructor.
5830         (~psymtab_storage): New destructor.
5831         (require_partial_symbols): Update.
5832         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5833         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5834         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5835         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5836         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5837         (start_psymtab_common, end_psymtab_common)
5838         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5839         (allocate_psymtab): Update.
5840         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5841         Update.
5842         (dump_psymtab_addrmap, maintenance_print_psymbols)
5843         (maintenance_check_psymtabs): Update.
5844         (class objfile_psymtabs): Move to objfiles.h.
5845         * psympriv.h (discard_psymtab): Now inline.
5846         (psymtab_discarder::psymtab_discarder): Update.
5847         (psymtab_discarder::~psymtab_discarder): Update.
5848         (ALL_OBJFILE_PSYMTABS): Rewrite.
5849         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5850         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5851         Remove fields.
5852         <partial_symtabs>: New field.
5853         (class objfile_psymtabs): Move from psymtab.h.  Update.
5854         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5855         psymbol_cache.
5856         (objfile::~objfile): Don't destroy psymbol_cache.
5857         * mdebugread.c (parse_partial_symbols): Update.
5858         * dwarf2read.c (create_addrmap_from_index)
5859         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5860         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5861         (add_partial_subprogram, dwarf2_ranges_read): Update.
5862         * dwarf-index-write.c (write_address_map)
5863         (write_one_signatured_type, recursively_write_psymbols)
5864         (class debug_names, class debug_names, write_psymtabs_to_index):
5865         Update.
5866
5867 2019-01-10  Tom Tromey  <tom@tromey.com>
5868
5869         * symtab.h (SYMBOL_SET_NAMES): Update.
5870         (symbol_set_names): Update.
5871         (MSYMBOL_SET_NAMES): Update.
5872         * symtab.c (symbol_set_names): Change argument to be an
5873         objfile_per_bfd_storage.
5874         * psymtab.c (add_psymbol_to_bcache): Update.
5875         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5876
5877 2019-01-10  Tom Tromey  <tom@tromey.com>
5878
5879         * symtab.c (create_demangled_names_hash): Change argument to be an
5880         objfile_per_bfd_storage.
5881         (symbol_set_names): Update.
5882
5883 2019-01-10  Tom Tromey  <tom@tromey.com>
5884
5885         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5886         init_psymbol_list.
5887         * psymtab.c (init_psymbol_list): Do nothing if already called.
5888         * psympriv.h (init_psymbol_list): Add comment.
5889         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5890         init_psymbol_list.
5891         * dbxread.c (dbx_symfile_read): Unconditionally call
5892         init_psymbol_list.
5893
5894 2019-01-10  Tom Tromey  <tom@tromey.com>
5895
5896         * xcoffread.c (scan_xcoff_symtab): Update.
5897         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5898         "where".
5899         * mdebugread.c (parse_partial_symbols)
5900         (handle_psymbol_enumerators): Update.
5901         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5902         * dbxread.c (read_dbx_symtab): Update.
5903         * psympriv.h (psymbol_placement): New enum.
5904         (add_psymbol_to_list): Update.
5905
5906 2019-01-10  Tom Tromey  <tom@tromey.com>
5907
5908         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5909         static_psymbols parameters.
5910         (scan_xcoff_symtab): Update.
5911         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5912         static_psymbols parameters.
5913         * psympriv.h (start_psymtab_common): Update.
5914         * mdebugread.c (parse_partial_symbols): Update.
5915         * dwarf2read.c (create_partial_symtab): Update.
5916         * dbxread.c (read_dbx_symtab): Update.
5917         (start_psymtab): Remove global_psymbols and static_psymbols
5918         parameters.
5919
5920 2019-01-10  Tom Tromey  <tom@tromey.com>
5921
5922         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5923         * psymtab.c (allocate_psymtab): Add comment.
5924         * psympriv.h (allocate_psymtab): Add comment.
5925         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5926         initializations.
5927         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5928
5929 2019-01-10  Tom Tromey  <tom@tromey.com>
5930
5931         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5932         Don't declare.
5933         * mipsread.c: Include mdebugread.h.
5934         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5935         Declare.
5936         * elfread.c: Include mdebugread.h.
5937
5938 2019-01-09  Tom Tromey  <tom@tromey.com>
5939
5940         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5941         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5942         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5943         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5944         (psym_lookup_symbol, psym_find_last_source_symtab)
5945         (psym_forget_cached_source_info, psym_print_stats)
5946         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5947         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5948         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5949         (psym_find_compunit_symtab_by_address)
5950         (maintenance_print_psymbols, maintenance_info_psymtabs)
5951         (maintenance_check_psymtabs): Use ranged for.
5952         * psymtab.h (class objfile_psymtabs): New.
5953         (require_partial_symbols): Return objfile_psymtabs.
5954         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5955
5956 2019-01-09  Tom Tromey  <tom@tromey.com>
5957
5958         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5959         (find_pc_mapped_section, list_overlays_command)
5960         (map_overlay_command, unmap_overlay_command)
5961         (simple_overlay_update): Use all_objfiles.
5962         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5963         * printcmd.c (info_symbol_command): Use all_objfiles.
5964         * objfiles.h (ALL_OBJSECTIONS): Remove.
5965         * maint.c (maintenance_translate_address): Use all_objfiles.
5966         * gcore.c (gcore_create_callback): Use all_objfiles.
5967         (objfile_find_memory_regions): Likewise.
5968
5969 2019-01-09  Tom Tromey  <tom@tromey.com>
5970
5971         * symtab.c (find_line_symtab, info_sources_command)
5972         (make_source_files_completion_list): Use objfile_compunits.
5973         * source.c (select_source_symtab): Use objfile_compunits.
5974         * objfiles.h (struct objfile): Update comment.
5975         (ALL_OBJFILES): Remove.
5976         (ALL_FILETABS): Remove.
5977         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5978         objfile_compunits.
5979
5980 2019-01-09  Tom Tromey  <tom@tromey.com>
5981
5982         * symmisc.c (print_objfile_statistics, dump_objfile)
5983         (maintenance_print_symbols): Use compunit_filetabs.
5984         * source.c (forget_cached_source_info_for_objfile): Use
5985         compunit_filetabs.
5986         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5987         (ALL_FILETABS): Use compunit_filetabs.
5988         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5989         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5990
5991 2019-01-09  Tom Tromey  <tom@tromey.com>
5992
5993         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5994         (compunit_filetabs): New.
5995         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5996         compunit_filetabs.
5997         (info_sources_command, make_source_files_completion_list): Remove
5998         declaration.
5999         * symmisc.c (print_objfile_statistics, dump_objfile)
6000         (maintenance_print_symbols): Remove declaration.
6001         (maintenance_info_symtabs): Use compunit_filetabs.
6002         (maintenance_info_line_tables): Likewise.
6003         * source.c (select_source_symtab): Change local variable name.
6004         (forget_cached_source_info_for_objfile): Remove declaration.
6005         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6006         * objfiles.c (objfile_relocate1): Remove declaration.
6007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6008         declaration.
6009         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6010         * coffread.c (coff_symtab_read): Remove declaration.
6011         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6012         compunit_filetabs.
6013
6014 2019-01-09  Tom Tromey  <tom@tromey.com>
6015
6016         * symtab.c (lookup_objfile_from_block)
6017         (find_pc_sect_compunit_symtab, search_symbols)
6018         (default_collect_symbol_completion_matches_break_on): Use
6019         objfile_compunits.
6020         * objfiles.h (ALL_COMPUNITS): Remove.
6021         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6022         * cp-support.c (add_symbol_overload_list_qualified): Use
6023         objfile_compunits.
6024         * ada-lang.c (ada_collect_symbol_completion_matches)
6025         (ada_add_global_exceptions): Use objfile_compunits.
6026
6027 2019-01-09  Tom Tromey  <tom@tromey.com>
6028
6029         * source.c (select_source_symtab)
6030         (forget_cached_source_info_for_objfile): Remove declaration.
6031         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6032         declaration.
6033         * maint.c (count_symtabs_and_blocks): Remove declaration.
6034         * cp-support.c (add_symbol_overload_list_qualified): Remove
6035         declaration.
6036         * coffread.c (coff_symtab_read): Remove declaration.
6037         * symtab.c (lookup_symbol_in_objfile_symtabs)
6038         (basic_lookup_transparent_type_1): Use objfile_compunits.
6039         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6040         (info_sources_command, search_symbols)
6041         (default_collect_symbol_completion_matches_break_on)
6042         (make_source_files_completion_list): Remove declaration.
6043         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6044         (ada_collect_symbol_completion_matches)
6045         (ada_add_global_exceptions): Remove declaration.
6046         * linespec.c (iterate_over_all_matching_symtabs): Use
6047         objfile_compunits.
6048         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6049         (class objfile_compunits): New.
6050         (ALL_COMPUNITS): Use objfile_compunits.
6051         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6052         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6053         objfile_compunits.
6054         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6055
6056 2019-01-09  Tom Tromey  <tom@tromey.com>
6057
6058         * symtab.c (search_symbols)
6059         (default_collect_symbol_completion_matches_break_on): Use
6060         objfile_msymbols.
6061         * ada-lang.c (ada_lookup_simple_minsym)
6062         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6063         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6064         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6065         objfile_msymbols.
6066         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6067         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6068         * objc-lang.c (find_methods): Use objfile_msymbols.
6069         (info_selectors_command, info_classes_command): Likewise.
6070         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6071         * objfiles.h (class objfile_msymbols): New.
6072         (ALL_OBJFILE_MSYMBOLS): Remove.
6073         (ALL_MSYMBOLS): Remove.
6074
6075 2019-01-09  Tom Tromey  <tom@tromey.com>
6076
6077         * common/next-iterator.h (next_adapter): Add Iterator template
6078         parameter.
6079         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6080         (class all_objfiles_safe): New.
6081         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6082         * objfiles.c (put_objfile_before): Update comment.
6083         (add_separate_debug_objfile): Likewise.
6084         (free_all_objfiles): Use all_objfiles_safe.
6085         (objfile_purge_solibs): Likewise.
6086
6087 2019-01-09  Tom Tromey  <tom@tromey.com>
6088
6089         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6090         (expand_symtab_containing_pc, lookup_static_symbol)
6091         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6092         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6093         all_objfiles.
6094         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6095         * breakpoint.c (create_overlay_event_breakpoint)
6096         (create_longjmp_master_breakpoint)
6097         (create_std_terminate_master_breakpoint)
6098         (create_exception_master_breakpoint): Use all_objfiles.
6099         * linux-thread-db.c (try_thread_db_load_from_pdir)
6100         (has_libpthread): Use all_objfiles.
6101         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6102         * linespec.c (iterate_over_all_matching_symtabs)
6103         (search_minsyms_for_name): Use all_objfiles.
6104         * maint.c (maintenance_info_sections): Use all_objfiles.
6105         * main.c (captured_main_1): Use all_objfiles.
6106         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6107         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6108         * guile/scm-pretty-print.c
6109         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6110         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6111         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6112         (maintenance_print_msymbols): Use all_objfiles.
6113         * source.c (select_source_symtab): Use all_objfiles.
6114         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6115         * symfile.c (remove_symbol_file_command)
6116         (expand_symtabs_matching, map_symbol_filenames): Use
6117         all_objfiles.
6118         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6119         all_objfiles.
6120         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6121         * objc-lang.c (find_methods): Use all_objfiles.
6122         * objfiles.c (have_partial_symbols, have_full_symbols)
6123         (have_minimal_symbols, qsort_cmp)
6124         (default_iterate_over_objfiles_in_search_order): Use
6125         all_objfiles.
6126         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6127         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6128         (maintenance_check_psymtabs): Use all_objfiles.
6129         (ALL_PSYMTABS): Remove.
6130         * compile/compile-object-run.c (do_module_cleanup): Use
6131         all_objfiles.
6132         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6133         * cp-support.c (add_symbol_overload_list_qualified): Use
6134         all_objfiles.
6135         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6136         Use all_objfiles.
6137         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6138         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6139         all_objfiles.
6140         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6141         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6142         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6143         Uses all_objfiles.
6144         * solib.c (solib_read_symbols): Use all_objfiles
6145
6146 2019-01-09  Tom Tromey  <tom@tromey.com>
6147
6148         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6149         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6150         all_objfiles.
6151         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6152         * symmisc.c (print_symbol_bcache_statistics)
6153         (print_objfile_statistics, maintenance_print_objfiles)
6154         (maintenance_info_symtabs, maintenance_check_symtabs)
6155         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6156         all_objfiles.
6157         * source.c (forget_cached_source_info): Use all_objfiles.
6158         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6159         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6160         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6161         * objfiles.c (update_section_map): Use all_objfiles.
6162         (shared_objfile_contains_address_p): Likewise.
6163         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6164         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6165
6166 2019-01-09  Tom Tromey  <tom@tromey.com>
6167
6168         * common/next-iterator.h: New file.
6169         * objfiles.h (class all_objfiles): New.
6170         (struct objfile_iterator): New.
6171
6172 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * NEWS: Move the description of the changed "frame", "select-frame",
6175          and "info frame" commands to the Changed commands section.
6176
6177 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6178
6179         * gdbtypes.c (check_stub_method_group): Remove handling of old
6180         mangling schemes.
6181         * linespec.c (find_methods): Likewise.
6182         * stabsread.c (read_member_functions): Likewise.
6183         * valops.c (search_struct_method): Likewise.
6184         (value_struct_elt_for_reference): Likewise.
6185         * NEWS: Mention this change.
6186
6187 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6190         print_source_lines.
6191         * source.c (print_source_lines_base): Update line number check.
6192         (print_source_lines): New function.
6193         (source_lines_range::source_lines_range): New function.
6194         * source.h (class source_lines_range): New class.
6195         (print_source_lines): New declaration.
6196
6197 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6198
6199         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6200
6201 2019-01-08  Tom Tromey  <tom@tromey.com>
6202             Simon Marchi  <simon.marchi@ericsson.com>
6203
6204         PR gdb/24060
6205         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6206         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6207         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6208         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6209         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6210         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6211
6212 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * source.c (select_source_symtab): Move header comment to
6215         declaration in source.h.
6216         (forget_cached_source_info_for_objfile): Likewise.
6217         (forget_cached_source_info): Likewise.
6218         (identify_source_line): Likewise.
6219         * source.h (identify_source_line): Move declaration from symtab.h
6220         and add comment from source.c
6221         (print_source_lines): Likewise.
6222         (forget_cached_source_info_for_objfile): Likewise.
6223         (forget_cached_source_info): Likewise.
6224         (select_source_symtab): Likewise.
6225         (enum print_source_lines_flag): Move definition from symtab.h.
6226         * symtab.h (identify_source_line): Move declaration to source.h.
6227         (print_source_lines): Likewise.
6228         (forget_cached_source_info_for_objfile): Likewise.
6229         (forget_cached_source_info): Likewise.
6230         (select_source_symtab): Likewise.
6231         (enum print_source_lines_flag): Move definition to source.h.
6232         * tui/tui-hooks.c: Add 'source.h' include.
6233
6234 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * source.c (print_source_lines_base): Handle requests to print
6237         reverse line number sequences, and guard against empty lines
6238         string.
6239
6240 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * source.c (print_source_lines_base): Fix skip of '\r' if next
6243         character is '\n'.
6244
6245 2019-01-06  Tom Tromey  <tom@tromey.com>
6246
6247         * c-exp.y (struct c_parse_state) <macro_original_text,
6248         expansion_obstack>: New member.
6249         (macro_original_text, expansion_obstack): Remove globals.
6250         (scan_macro_expansion, scanning_macro_expansion)
6251         (finished_macro_expansion): Update.
6252         (scan_macro_cleanup): Remove.
6253         (yylex, c_parse): Update.
6254
6255 2019-01-06  Tom Tromey  <tom@tromey.com>
6256
6257         * c-exp.y (struct c_parse_state) <strings>: New member.
6258         (operator_stoken): Update.
6259
6260 2019-01-06  Tom Tromey  <tom@tromey.com>
6261
6262         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6263         (union type_stack_elt) <typelist_val>: Now a pointer to
6264         std::vector.
6265         (type_stack_cleanup): Don't declare.
6266         (push_typelist): Update.
6267         * parse.c (pop_typelist): Return a std::vector.
6268         (push_typelist): Take a std::vector.
6269         (follow_types): Update.  Do not free args.
6270         (type_stack_cleanup): Remove.
6271         * c-exp.y (struct c_parse_state): New.
6272         (cpstate): New global.
6273         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6274         (nonempty_typelist): Update.
6275         (func_mod): Create a new vector.
6276         (c_parse): Create a c_parse_state.
6277         (check_parameter_typelist): Do not delete params.
6278         (function_method): Update.  Do not delete type_list.
6279
6280 2019-01-06  Tom Tromey  <tom@tromey.com>
6281
6282         PR gdb/28155:
6283         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6284         check_typedef.
6285         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6286         (print_return_value): Likewise.
6287
6288 2019-01-05  Tom Tromey  <tom@tromey.com>
6289
6290         * contrib/cleanup_check.py: Remove.
6291         * contrib/gcc-with-excheck: Remove.
6292         * contrib/exsummary.py: Remove.
6293         * contrib/excheck.py: Remove.
6294
6295 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6296
6297         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6298         NULL. Initialize tpprev to NULL instead of assigning it
6299         to NULL on the next statement.
6300         * windows-nat.c (windows_delete_thread): Remove check for
6301         main_thread_id before printing thread exit notifications.
6302         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6303         Remove thread ID check against main_thread_id.
6304         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6305         windows_delete_thread.
6306         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6307
6308 2019-01-04  Tom Tromey  <tom@tromey.com>
6309
6310         * compile/compile.c (_initialize_compile): Use upper case for
6311         metasyntactic variables.
6312         * symmisc.c (_initialize_symmisc): Use upper case for
6313         metasyntactic variables.
6314         * psymtab.c (_initialize_psymtab): Use upper case for
6315         metasyntactic variables.
6316         * demangle.c (demangle_command): Use upper case for metasyntactic
6317         variables.
6318         (_initialize_demangler): Likewise.
6319         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6320         variables.
6321
6322 2019-01-03  Tom Tromey  <tom@tromey.com>
6323
6324         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6325
6326 2019-01-03  Tom Tromey  <tom@tromey.com>
6327
6328         * python/py-symtab.c (salpy_str): Update.
6329         (struct salpy_sal_object) <symtab>: Now a PyObject.
6330         (salpy_dealloc): Update.
6331         (del_objfile_sal): Use gdbpy_ref.
6332
6333 2019-01-03  Tom Tromey  <tom@tromey.com>
6334
6335         * python/py-type.c (convert_field): Use new_reference.  Return
6336         gdbpy_ref.
6337         (make_fielditem): Return gdbpy_ref.
6338         (typy_fields): Update.
6339         (typy_getitem): Update.
6340         (field_name): Return gdbpy_ref.  Use new_reference.
6341         (typy_iterator_iternext): Update.
6342
6343 2019-01-03  Tom Tromey  <tom@tromey.com>
6344
6345         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6346
6347 2019-01-03  Tom Tromey  <tom@tromey.com>
6348
6349         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6350         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6351         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6352         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6353         (pspy_set_type_printers): Likewise.
6354         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6355         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6356         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6357         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6358         (objfpy_set_type_printers): Likewise.
6359
6360 2019-01-03  Tom Tromey  <tom@tromey.com>
6361
6362         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6363         (gdbpy_print_stack): Use gdbpy_err_fetch.
6364         * python/python-internal.h (class gdbpy_err_fetch): New class.
6365         (class gdbpy_enter) <m_error_type, m_error_value,
6366         m_error_traceback>: Remove.
6367         <m_error>: New member.
6368         (gdbpy_exception_to_string): Don't declare.
6369         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6370         * python/py-value.c (convert_value_from_python): Use
6371         gdbpy_err_fetch.
6372         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6373         gdbpy_exception_to_string.
6374         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6375         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6376         gdbpy_err_fetch.
6377
6378 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6379
6380         * linux-nat.c (delete_lwp_cleanup): Delete.
6381         (struct lwp_deleter): New struct.
6382         (lwp_info_up): New typedef.
6383         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6384         lwp_info_up.
6385
6386 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * linux-fork.c (class scoped_switch_fork_info): New class.
6389         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6390
6391 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * valops.c (find_overload_match): Remove use of null_cleanup, and
6394         calls to do_cleanups.
6395
6396 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * compile/compile-cplus-types.c
6399         (compile_cplus_instance::decl_name): Handle changes to
6400         cp_func_name.
6401         * cp-support.c (cp_func_name): Update header comment, update
6402         return type.
6403         * cp-support.h (cp_func_name): Update return type in declaration.
6404         * valops.c (find_overload_match): Move temp_func local to top
6405         level of function and change its type.  Use temp_func to hold and
6406         delete temporary string obtained from cp_func_name.
6407
6408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6411         gdb::char_vector, remove cleanup, and update uses of `msg`.
6412
6413 2019-01-03  Jim Wilson  <jimw@sifive.com>
6414
6415         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6416
6417 2019-01-02  Tom Tromey  <tom@tromey.com>
6418
6419         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6420         (tdesc_parse_xml): Remove cleanups.
6421         * target-descriptions.h (make_cleanup_free_target_description):
6422         Don't declare.
6423         (target_desc_deleter): New struct.
6424         (target_desc_up): New typedef.
6425         * target-descriptions.c (target_desc_deleter::operator()): Rename
6426         from free_target_description.
6427         (make_cleanup_free_target_description): Remove.
6428
6429 2019-01-02  Tom Tromey  <tom@tromey.com>
6430
6431         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6432         constructor, destructor.
6433         (linespec_parser): Remove typedef.
6434         (~linespec_parser): Rename from linespec_parser_delete.
6435         (linespec_lex_to_end, linespec_complete_label)
6436         (linespec_complete): Update.
6437         (decode_line_full): Remove cleanups.
6438         (decode_line_1): Update.
6439
6440 2019-01-02  Tom Tromey  <tom@tromey.com>
6441
6442         * python/python-internal.h (inferior_to_inferior_object): Change
6443         return type.
6444         * python/py-exitedevent.c (create_exited_event_object): Update.
6445         * python/py-inferior.c (inferior_to_inferior_object): Return
6446         gdbpy_ref.
6447         (python_new_inferior, python_inferior_deleted)
6448         (thread_to_thread_object, delete_thread_object)
6449         (build_inferior_list, gdbpy_selected_inferior): Update.
6450         * python/py-infthread.c (create_thread_object): Update.  Also fail
6451         if inferior_to_inferior_object fails.
6452
6453 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6454
6455         * inferior.h (class inferior) <displaced_step_state>: New field.
6456         * infrun.h (struct displaced_step_state): Move here from
6457         infrun.c.  Initialize fields, add constructor.
6458         <inf>: Remove field.
6459         <reset>: New method.
6460         * infrun.c (struct displaced_step_inferior_state): Move to
6461         infrun.h.
6462         (displaced_step_inferior_states): Remove.
6463         (get_displaced_stepping_state): Adust.
6464         (displaced_step_in_progress_any_inferior): Adjust.
6465         (displaced_step_in_progress_thread): Adjust.
6466         (displaced_step_in_progress): Adjust.
6467         (add_displaced_stepping_state): Remove.
6468         (get_displaced_step_closure_by_addr): Adjust.
6469         (remove_displaced_stepping_state): Remove.
6470         (infrun_inferior_exit): Call displaced_step_state.reset.
6471         (use_displaced_stepping): Don't check for NULL.
6472         (displaced_step_prepare_throw): Call
6473         get_displaced_stepping_state.
6474         (displaced_step_fixup): Don't check for NULL.
6475         (prepare_for_detach): Don't check for NULL.
6476
6477 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6478
6479         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6480          in case of call that did not complete.
6481
6482 2019-01-02  Andrey Utkin  <autkin@undo.io>
6483
6484         * symfile.c (find_separate_debug_file): Fix search of debug files for
6485         remote debuggee.
6486
6487 2019-01-02  Tom Tromey  <tom@tromey.com>
6488
6489         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6490         indentation.
6491         * python/py-frame.c (frapy_older): Remove cast.
6492         (frapy_newer): Likewise.
6493         * python/py-breakpoint.c (local_setattro): Remove cast.
6494         * python/py-arch.c (archpy_name): Remove local variable.
6495         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6496
6497 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6498
6499         * unittests/basic_string_view/element_access/char/empty.cc:
6500         Fix year range in copyright header.
6501
6502 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6505         Delete.
6506         <operator==>: Update with for removed field.
6507         <hash>: Likewise.
6508         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6509         <isa_features>: ...this.
6510         <abi_features>: New field.
6511         (riscv_isa_flen): Update comment.
6512         (riscv_abi_xlen): New declaration.
6513         (riscv_abi_flen): New declaration.
6514         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6515         isa_features.
6516         (riscv_abi_xlen): New function.
6517         (riscv_isa_flen): Update to get answer from isa_features.
6518         (riscv_abi_flen): New function.
6519         (riscv_has_fp_abi): Update to get answer from abi_features.
6520         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6521         xlen and flen.
6522         (riscv_call_info) <xlen, flen>: Update comment.
6523         (riscv_call_arg_struct): Remove invalid assertions
6524         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6525         is removed.
6526         (riscv_gdbarch_init): Gather isa features and abi features
6527         separately, ensure both match on the gdbarch when reusing an old
6528         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6529         a target with 64-bit float hardware.
6530
6531 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6532
6533         * source.c (search_command_helper): Stop reverse search
6534         when line 1 has been searched.
6535
6536 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6537
6538         * record-full.c (record_full_base_target::close): Rewrite
6539         record_full_core_buf_list free logic.
6540
6541 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6542
6543         * break-catch-syscall.c (print_one_catch_syscall): xfree
6544         the last text.
6545
6546 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6547
6548         * top.c (print_gdb_version): Update Copyright year in version
6549         message.
6550
6551 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6552
6553         Update copyright year range in all GDB files.
6554
6555 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6556
6557         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6558
6559 For older changes see ChangeLog-2018.
6560 \f
6561 Local Variables:
6562 mode: change-log
6563 left-margin: 8
6564 fill-column: 74
6565 version-control: never
6566 coding: utf-8
6567 End:
6568