gdb/ChangeLog

   1 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
   2
   3         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
   4         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
   5         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
   6         (nios2_linux_init_abi): Install it.
   7
   8 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
   9
  10         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  11
  12 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  13
  14         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  15
  16 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  17             Tom Tromey  <tromey@adacore.com>
  18
  19         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  20
  21 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  22
  23         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  24         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  25         method to compute the bounds of range types. Also print "[evaluated]"
  26         if the bounds' values come from a dynamic evaluation.
  27
  28 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  31         whitespace when pretty printing is on.
  32
  33 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  34
  35         * ppc-linux-nat.c: Add include.
  36
  37 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  38
  39         * NEWS: Mention AArch64 Pointer Authentication.
  40
  41 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  42
  43         * arm-linux-nat.c: Add include.
  44
  45 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         * source-cache.c (source_cache::get_source_lines): Re-read
  48         fullname after calling open_source_file.
  49
  50 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  51
  52         * NEWS: Mention TLS support for FreeBSD.
  53
  54 2019-03-25  Tom Tromey  <tromey@adacore.com>
  55
  56         * minsyms.c (BUNCH_SIZE): Update comment.
  57         (~minimal_symbol_reader): Remove old comment.
  58         (compact_minimal_symbols): Update comment.
  59         (minimal_symbol_reader::install): Remove old comment.  Update
  60         other comments.
  61
  62 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  63
  64         * s390-linux-nat.c: Add include.
  65
  66 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  67
  68         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  69         Call linux_get_hwcap.
  70         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  71         Likewise.
  72         (aarch64_linux_get_hwcap): Remove function.
  73         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  74         declaration.
  75         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  76         linux_get_hwcap.
  77         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  78         * linux-tdep.c (linux_get_hwcap): Add function.
  79         (linux_get_hwcap2): Likewise.
  80         * linux-tdep.h (linux_get_hwcap): Add declaration.
  81         (linux_get_hwcap2): Likewise.
  82         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  83         (ppc_linux_get_hwcap2): Likewise.
  84         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  85         linux_get_hwcap.
  86         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  87         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  88         (ppc_linux_nat_target::read_description): Likewise.
  89         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  90         * s390-linux-nat.c: Likewise.
  91         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  92
  93 2019-03-24  Tom Tromey  <tom@tromey.com>
  94
  95         * ada-lang.c (standard_lookup): Simplify initialization.
  96         (ada_lookup_symbol_nonlocal): Simplify return.
  97         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  98         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  99         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 100         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 101         initialization.
 102         * solib.c (solib_global_lookup): Simplify.
 103         * symtab.c (null_block_symbol): Remove.
 104         (symbol_cache_lookup): Simplify returns.
 105         (lookup_language_this): Simplify returns.
 106         (lookup_symbol_aux): Simplify return.
 107         (lookup_local_symbol): Simplify returns.
 108         (lookup_global_symbol_from_objfile): Simplify return.
 109         (lookup_symbol_in_objfile_symtabs)
 110         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 111         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 112         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 113         * cp-namespace.c (cp_lookup_bare_symbol)
 114         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 115         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 116         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 117         (cp_lookup_symbol_via_imports): Simplify initialization.
 118         (find_symbol_in_baseclass): Likewise.
 119         * symtab.h (null_block_symbol): Remove.
 120         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 121         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 122         (d_lookup_symbol_module): Likewise.
 123         (find_symbol_in_baseclass): Simplify initialization.
 124
 125 2019-03-24  Tom Tromey  <tom@tromey.com>
 126
 127         * expression.h: Don't include symtab.h.
 128         (struct block): Forward declare.
 129
 130 2019-03-24  Tom Tromey  <tom@tromey.com>
 131
 132         * c-exp.y (typebase): Remove casts.
 133         * gdbtypes.c (lookup_unsigned_typename, )
 134         (lookup_signed_typename): Remove cast.
 135         * eval.c (parse_to_comma_and_eval): Remove cast.
 136         * parse.c (write_dollar_variable): Remove cast.
 137         * block.h (struct block) <superblock>: Now const.
 138         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 139         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 140         (map_block): Make "block" const.
 141         * symfile.h (struct quick_symbol_functions)
 142         <map_matching_symbols>: Constify block argument to "callback".
 143         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 144         const.
 145         (find_pc_sect_compunit_symtab): Make "b" const.
 146         (find_symbol_at_address): Likewise.
 147         (search_symbols): Likewise.
 148         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 149         (dw2_debug_names_lookup_symbol): Likewise.
 150         (dw2_map_matching_symbols): Update.
 151         * p-valprint.c (pascal_val_print): Remove "block".
 152         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 153         (aux_add_nonlocal_symbols): Make "block" const.
 154         (resolve_subexp): Remove cast.
 155         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 156         const.
 157         (iterate_over_file_blocks): Likewise.
 158         * f-exp.y (%union) <bval>: Remove.
 159         * coffread.c (patch_opaque_types): Make "b" const.
 160         * spu-tdep.c (spu_catch_start): Make "block" const.
 161         * c-valprint.c (print_unpacked_pointer): Remove "block".
 162         * symmisc.c (dump_symtab_1): Make "b" const.
 163         (block_depth): Make "block" const.
 164         * d-exp.y (%union) <bval>: Remove.
 165         * cp-support.h (cp_lookup_rtti_type): Update.
 166         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 167         * psymtab.c (psym_lookup_symbol): Make "block" const.
 168         (maintenance_check_psymtabs): Make "b" const.
 169         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 170         (enumerate_locals, enumerate_args): Update.
 171         * python/py-symtab.c (stpy_global_block): Make "block" const.
 172         (stpy_static_block): Likewise.
 173         * inline-frame.c (block_starting_point_at): Make "new_block"
 174         const.
 175         * block.c (find_block_in_blockvector): Make return type const.
 176         (blockvector_for_pc_sect): Make "b" const.
 177         (find_block_in_blockvector): Make "b" const.
 178
 179 2019-03-23  Tom Tromey  <tom@tromey.com>
 180
 181         * varobj.c (varobj_create): Update.
 182         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 183         * printcmd.c (display_command, do_one_display): Don't reset
 184         innermost_block.
 185         * parser-defs.h (enum innermost_block_tracker_type): Move to
 186         expression.h.
 187         (innermost_block): Update comment.
 188         * parse.c (parse_exp_1): Add tracker_types parameter.
 189         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 190         tracker_types parameter.  Reset innermost_block.
 191         (parse_exp_in_context): Remove.
 192         (parse_expression_for_completion): Update.
 193         * objfiles.c (~objfile): Don't reset expression_context_block or
 194         innermost_block.
 195         * expression.h (enum innermost_block_tracker_type): Move from
 196         parser-defs.h.
 197         (parse_exp_1): Add tracker_types parameter.
 198         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 199         reset innermost_block.
 200
 201 2019-03-23  Tom Tromey  <tom@tromey.com>
 202
 203         * objfiles.h: Include bcache.h.
 204
 205 2019-03-23  Tom Tromey  <tom@tromey.com>
 206
 207         * linespec.c (get_current_search_block): Use
 208         scoped_restore_current_language.
 209         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 210
 211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 212             Jiong Wang  <jiong.wang@arm.com>
 213
 214         * aarch64-linux-tdep.c
 215         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 216         section.
 217         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 218
 219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 220             Jiong Wang  <jiong.wang@arm.com>
 221
 222         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 223         instructions.
 224         (aarch64_analyze_prologue_test): Add PACIASP test.
 225         (aarch64_prologue_prev_register): Unmask PC value.
 226
 227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 228             Jiong Wang  <jiong.wang@arm.com>
 229
 230         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 231         (aarch64_dwarf2_prev_register): Unmask PC value.
 232         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 233         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 234         DW_CFA_AARCH64_negate_ra_state.
 235         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 236
 237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 238             Jiong Wang  <jiong.wang@arm.com>
 239
 240         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 241         registers.
 242         (aarch64_pseudo_register_name): Likewise.
 243         (aarch64_pseudo_register_type): Likewise.
 244         (aarch64_pseudo_register_reggroup_p): Likewise.
 245         (aarch64_gdbarch_init): Add pauth registers.
 246         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 247         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 248         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 249         (struct gdbarch_tdep): Add regnum for ra_state.
 250
 251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 252             Jiong Wang  <jiong.wang@arm.com>
 253
 254         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 255
 256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 257             Jiong Wang  <jiong.wang@arm.com>
 258
 259         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 260         function.
 261         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 262         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 263         (aarch64_gdbarch_init): Add puth registers.
 264         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 265         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 266         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 267
 268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 269             Jiong Wang  <jiong.wang@arm.com>
 270
 271         * aarch64-linux-nat.c
 272         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 273         * aarch64-linux-tdep.c
 274         (aarch64_linux_core_read_description): Likewise.
 275         (aarch64_linux_get_hwcap): New function.
 276         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 277         (aarch64_linux_get_hwcap): New declaration.
 278
 279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 280             Jiong Wang  <jiong.wang@arm.com>
 281
 282         * aarch64-linux-nat.c
 283         (aarch64_linux_nat_target::read_description): Add pauth param.
 284         * aarch64-linux-tdep.c
 285         (aarch64_linux_core_read_description): Likewise.
 286         * aarch64-tdep.c (struct target_desc): Add in pauth.
 287         (aarch64_read_description): Add pauth param.
 288         (aarch64_gdbarch_init): Likewise.
 289         * aarch64-tdep.h (aarch64_read_description): Likewise.
 290         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 291         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 292         * features/Makefile: Add new files.
 293         * features/aarch64-pauth.c: New file.
 294         * features/aarch64-pauth.xml: New file.
 295
 296 2019-03-20  Tom Tromey  <tromey@adacore.com>
 297
 298         * infrun.c (handle_inferior_event): Rename from
 299         handle_inferior_event_1.  Create a scoped_value_mark.
 300         (handle_inferior_event): Remove.
 301
 302 2019-03-19  Tom Tromey  <tromey@adacore.com>
 303
 304         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 305         * infrun.h (print_stop_event): Add "displays" parameter.
 306         * infrun.c (print_stop_event): Add "displays" parameter.
 307
 308 2019-03-19  Pedro Alves  <palves@redhat.com>
 309
 310         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 311         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 312         to -1.  Fix TABs vs spaces.
 313         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 314         * tui/tui-out.h (tui_ui_out) Add intro comments.
 315         <m_line, m_start_of_line>: In-class initialize, and add describing
 316         comment.
 317
 318 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 319
 320         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 321         variable names.
 322         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 323
 324 2019-03-18  Pedro Alves  <palves@redhat.com>
 325             Eli Zaretskii <eliz@gnu.org>
 326
 327         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 328         m_line and m_start_of_line.
 329
 330 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 331
 332         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 333         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 334         it returns a newline.  This fixes a regression in TU mode, whereby
 335         the next line is output on the same screen line as the user input.
 336
 337 2019-03-18  Tom Tromey  <tromey@adacore.com>
 338
 339         * minsyms.c (minimal_symbol_reader::install): Remove call to
 340         obstack_blank.
 341
 342 2019-03-18  Pedro Alves  <palves@redhat.com>
 343
 344         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 345         New globals.
 346         (apply_style): New, factored out from ...
 347         (apply_ansi_escape): ... this.  Handle reverse video mode.
 348         (tui_set_reverse_mode): New function.
 349         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 350         * tui/tui-winsource.c (tui_show_source_line): Use
 351         tui_set_reverse_mode instead of setting A_STANDOUT.
 352         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 353         New setter methods.
 354
 355 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 356
 357         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 358         Handle tabs.
 359
 360 2019-03-18  Tom Tromey  <tromey@adacore.com>
 361
 362         * ada-lang.c (empty_array): Add "high" parameter.
 363         (ada_evaluate_subexp): Update.
 364
 365 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 366
 367         * unittests/string_view-selftests.c: Define
 368         _initialize_string_view_selftests unconditionally.
 369
 370 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 371
 372         PR gdb/24350
 373         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 374
 375 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 376
 377         PR gdb/24351
 378         * windows-nat.c (display_selector): Fix format specifiers.
 379
 380 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 381
 382         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 383         tui_refill_source_window instead of tui_refresh_win, to update the
 384         current execution line.  This fixes redisplay of the current line
 385         when stepping through the code with "next" or "step".
 386
 387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 388
 389         * source-cache.c (source_cache::get_source_lines): Call
 390         find_source_lines to initialize s->nlines.  This fixes vertical
 391         scrolling of TUI source window when the DOWN arrow is pressed.
 392
 393 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 394
 395         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 396         linux-thread-db.c (_initialize_thread_db): Likewise.
 397
 398 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 399
 400         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 401         wclrtoeol in tui_show_source_line".  This reverts changes made in
 402         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 403
 404 2019-03-15  Tom Tromey  <tom@tromey.com>
 405
 406         * symtab.h (struct minimal_symbol): Derive from
 407         general_symbol_info.
 408         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 409         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 410         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 411         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 412         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 413         (MSYMBOL_SEARCH_NAME): Update.
 414         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 415         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 416         * minsyms.c (minimal_symbol_reader::record_full): Update.
 417
 418 2019-03-15  Tom Tromey  <tom@tromey.com>
 419
 420         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 421
 422 2019-03-15  Tom Tromey  <tom@tromey.com>
 423
 424         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 425         unique_xmalloc_ptr.
 426         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 427         Update.
 428         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 429         (build_minimal_symbol_hash_tables)
 430         (minimal_symbol_reader::install): Update.
 431
 432 2019-03-15  Tom Tromey  <tom@tromey.com>
 433
 434         * symtab.c (create_demangled_names_hash): Update.
 435         (symbol_set_names): Update.
 436         * objfiles.h (struct objfile_per_bfd_storage)
 437         <demangled_names_hash>: Now an htab_up.
 438         * objfiles.c (objfile_per_bfd_storage): Simplify.
 439
 440 2019-03-15  Tom Tromey  <tom@tromey.com>
 441
 442         * objfiles.h (struct objfile_per_bfd_storage): Declare
 443         destructor.
 444         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 445         New.
 446         (get_objfile_bfd_data): Use new.  Don't initialize
 447         language_of_main.
 448         (free_objfile_per_bfd_storage): Remove.
 449         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 450
 451 2019-03-15  Tom Tromey  <tom@tromey.com>
 452
 453         * symfile.c (reread_symbols): Update.
 454         * objfiles.c (objfile::objfile): Update.
 455         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 456         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 457         comment.
 458         (minimal_symbol_reader::install): Update.
 459         (terminate_minimal_symbol_table): Remove.
 460         * jit.c (jit_object_close_impl): Update.
 461
 462 2019-03-15  Tom Tromey  <tom@tromey.com>
 463
 464         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 465         initializations.
 466
 467 2019-03-15  Tom Tromey  <tom@tromey.com>
 468
 469         * objfiles.h (struct objfile_per_bfd_storage)
 470         <demangled_hash_languages>: Now a bitset.
 471         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 472         (lookup_minimal_symbol): Update.
 473
 474 2019-03-15  Tom Tromey  <tom@tromey.com>
 475
 476         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 477         Don't return the symbol.
 478         * coffread.c (record_minimal_symbol): Use record_full.
 479
 480 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 481
 482         The MS-Windows port of ncurses fails to switch to a color pair if
 483         one or both of the colors are the implicit default colors.  This
 484         change records the default colors when TUI is initialized, and
 485         then specifies them explicitly when a color pair uses the default
 486         colors.  This allows color styling in TUI mode on MS-Windows.
 487
 488         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 489         ncurses_norm_attr.
 490         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 491         colors in ncurses_norm_attr.
 492         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 493         "none", replace it with the default color recorded in
 494         ncurses_norm_attr.
 495
 496 2019-03-14  Tom Tromey  <tromey@adacore.com>
 497
 498         * source-cache.h (class source_cache) <get_source_lines>: Return
 499         std::string.
 500         * source-cache.c (source_cache::extract_lines): Handle case where
 501         first_pos==npos.  Return std::string.
 502         (source_cache::get_source_lines): Update.
 503
 504 2019-03-14  Tom Tromey  <tromey@adacore.com>
 505
 506         * NEWS: Add item for "style sources" commands.
 507         * source-cache.c (source_cache::get_source_lines): Check
 508         source_styling.
 509         * cli/cli-style.c (source_styling): New global.
 510         (_initialize_cli_style): Add "style sources" commands.
 511         (show_style_sources): New function.
 512         * cli/cli-style.h (source_styling): Declare.
 513
 514 2019-03-14  Pedro Alves  <palves@redhat.com>
 515             Tom Tromey  <tromey@adacore.com>
 516
 517         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 518         * tui/tui-winsource.c (tui_refill_source_window): New function,
 519         from...
 520         (tui_horizontal_source_scroll): ... here.  Move some logic.
 521         * cli/cli-style.c (set_style_enabled): Notify new observable.
 522         * tui/tui-hooks.c (tui_redisplay_source): New function.
 523         (tui_attach_detach_observers): Attach or detach
 524         tui_redisplay_source.
 525         * observable.h (source_styling_changed): New observable.
 526         * observable.c: Define source_styling_changed observable.
 527
 528 2019-03-13  Tom Tromey  <tromey@adacore.com>
 529
 530         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 531         (i386_gnu_nat_target::store_registers): Update.
 532         * target-debug.h (target_debug_print_std_string): New macro.
 533         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 534         * windows-tdep.c (display_one_tib): Update.
 535         * tui/tui-stack.c (tui_make_status_line): Update.
 536         * top.c (print_inferior_quit_action): Update.
 537         * thread.c (thr_try_catch_cmd): Update.
 538         (add_thread_with_info): Update.
 539         (thread_target_id_str): Update.
 540         (thr_try_catch_cmd): Update.
 541         (thread_command): Update.
 542         (thread_find_command): Update.
 543         * record-btrace.c (record_btrace_target::info_record)
 544         (record_btrace_resume_thread, record_btrace_target::resume)
 545         (record_btrace_cancel_resume, record_btrace_step_thread)
 546         (record_btrace_target::wait, record_btrace_target::wait)
 547         (record_btrace_target::wait, record_btrace_target::stop): Update.
 548         * progspace.c (print_program_space): Update.
 549         * process-stratum-target.c
 550         (process_stratum_target::thread_address_space): Update.
 551         * linux-fork.c (linux_fork_mourn_inferior)
 552         (detach_checkpoint_command, info_checkpoints_command)
 553         (linux_fork_context): Update.
 554         (linux_fork_detach): Update.
 555         (class scoped_switch_fork_info): Update.
 556         (delete_checkpoint_command): Update.
 557         * infrun.c (follow_fork_inferior): Update.
 558         (follow_fork_inferior): Update.
 559         (proceed_after_vfork_done): Update.
 560         (handle_vfork_child_exec_or_exit): Update.
 561         (follow_exec): Update.
 562         (displaced_step_prepare_throw): Update.
 563         (displaced_step_restore): Update.
 564         (start_step_over): Update.
 565         (resume_1): Update.
 566         (clear_proceed_status_thread): Update.
 567         (proceed): Update.
 568         (print_target_wait_results): Update.
 569         (do_target_wait): Update.
 570         (context_switch): Update.
 571         (stop_all_threads): Update.
 572         (restart_threads): Update.
 573         (finish_step_over): Update.
 574         (handle_signal_stop): Update.
 575         (switch_back_to_stepped_thread): Update.
 576         (keep_going_pass_signal): Update.
 577         (print_exited_reason): Update.
 578         (normal_stop): Update.
 579         * inferior.c (inferior_pid_to_str): Change return type.
 580         (print_selected_inferior): Update.
 581         (add_inferior): Update.
 582         (detach_inferior): Update.
 583         * dummy-frame.c (fprint_dummy_frames): Update.
 584         * dcache.c (dcache_info_1): Update.
 585         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 586         (btrace_fetch, btrace_clear): Update.
 587         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 588         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 589         type.
 590         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 591         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 592         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 593         * gdbarch.c, gdbarch.h: Rebuild.
 594         * gdbarch.sh (core_pid_to_str): Change return type.
 595         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 596         return type.
 597         (windows_nat_target::pid_to_str): Change return type.
 598         (windows_delete_thread): Update.
 599         (windows_nat_target::attach): Update.
 600         (windows_nat_target::files_info): Update.
 601         * target-delegates.c: Rebuild.
 602         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 603         return type.
 604         (sol_thread_target::pid_to_str): Change return type.
 605         * remote.c (class remote_target) <pid_to_str>: Change return
 606         type.
 607         (remote_target::pid_to_str): Change return type.
 608         (extended_remote_target::attach, remote_target::remote_stop_ns)
 609         (remote_target::remote_notif_remove_queued_reply)
 610         (remote_target::push_stop_reply, remote_target::disable_btrace):
 611         Update.
 612         (extended_remote_target::attach): Update.
 613         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 614         type.
 615         (gdbsim_target::pid_to_str): Change return type.
 616         * ravenscar-thread.c (struct ravenscar_thread_target)
 617         <pid_to_str>: Change return type.
 618         (ravenscar_thread_target::pid_to_str): Change return type.
 619         * procfs.c (class procfs_target) <pid_to_str>: Change return
 620         type.
 621         (procfs_target::pid_to_str): Change return type.
 622         (procfs_target::attach): Update.
 623         (procfs_target::detach): Update.
 624         (procfs_target::fetch_registers): Update.
 625         (procfs_target::store_registers): Update.
 626         (procfs_target::wait): Update.
 627         (procfs_target::files_info): Update.
 628         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 629         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 630         return type.
 631         (nto_procfs_target::pid_to_str): Change return type.
 632         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 633         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 634         return type.
 635         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 636         (exit_lwp): Update.
 637         (attach_proc_task_lwp_callback, get_detach_signal)
 638         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 639         (linux_nat_target::resume, wait_lwp, stop_callback)
 640         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 641         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 642         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 643         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 644         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 645         type.
 646         (inf_ptrace_target::attach): Update.
 647         (inf_ptrace_target::files_info): Update.
 648         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 649         type.
 650         (go32_nat_target::pid_to_str): Change return type.
 651         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 652         (gnu_nat_target::wait): Update.
 653         (gnu_nat_target::wait): Update.
 654         (gnu_nat_target::resume): Update.
 655         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 656         (fbsd_nat_target::wait): Update.
 657         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 658         type.
 659         (darwin_nat_target::attach): Update.
 660         * corelow.c (class core_target) <pid_to_str>: Change return type.
 661         (core_target::pid_to_str): Change return type.
 662         * target.c (normal_pid_to_str): Change return type.
 663         (default_pid_to_str): Likewise.
 664         (target_pid_to_str): Change return type.
 665         (target_translate_tls_address): Update.
 666         (target_announce_detach): Update.
 667         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 668         return type.
 669         (bsd_uthread_target::pid_to_str): Change return type.
 670         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 671         type.
 672         (bsd_kvm_target::pid_to_str): Change return type.
 673         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 674         return type.
 675         (aix_thread_target::pid_to_str): Change return type.
 676         * target.h (struct target_ops) <pid_to_str>: Change return type.
 677         (target_pid_to_str, normal_pid_to_str): Likewise.
 678         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 679         type.
 680         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 681         type.
 682         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 683         return type.
 684         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 685         type.
 686         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 687         type.
 688         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 689         return type.
 690
 691 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 692
 693         * NEWS: Mention that the new default MI version is 3.  Mention
 694         changes to the output of commands and events that deal with
 695         multi-location breakpoints.
 696         * breakpoint.c: Include "mi/mi-out.h".
 697         (print_one_breakpoint): Change output syntax if using MI version
 698         >= 3.
 699         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 700         New.
 701         (mi_multi_location_breakpoint_output_fixed): New.
 702         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 703         (mi_cmd_fix_multi_location_breakpoint_output): New.
 704         (mi_multi_location_breakpoint_output_fixed): New.
 705         * mi/mi-cmds.c (mi_cmds): Register command
 706         -fix-multi-location-breakpoint-output.
 707         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 708         interpreter "mi".
 709
 710 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 711
 712         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 713         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 714         instantiate mi_ui_out based on interpreter name.
 715         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 716         * mi/mi-main.c (mi_load_progress): Likewise.
 717
 718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 719
 720         * NEWS: Combine separate "New targets" sections for 8.3.
 721
 722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 723
 724         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 725         (ppcfbsd_init_abi): Install gdbarch
 726         "fetch_tls_load_module_address" and "get_thread_local_address"
 727         methods.
 728
 729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 730
 731         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 732         (riscv_fbsd_init_abi): Install gdbarch
 733         "fetch_tls_load_module_address" and "get_thread_local_address"
 734         methods.
 735
 736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 737
 738         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 739         (i386fbsd_init_abi): Install gdbarch
 740         "fetch_tls_load_module_address" and "get_thread_local_address"
 741         methods.
 742
 743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 744
 745         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 746         (amd64fbsd_init_abi): Install gdbarch
 747         "fetch_tls_load_module_address" and "get_thread_local_address"
 748         methods.
 749
 750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 751
 752         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 753         (struct fbsd_pspace_data): New type.
 754         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 755         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 756         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 757         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 758         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 759
 760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * gdbtypes.c (lookup_struct_elt): New function.
 763         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 764         * gdbtypes.h (struct struct_elt): New type.
 765         (lookup_struct_elt): New prototype.
 766
 767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 768
 769         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 770         remove disabled code block.
 771
 772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 773
 774         * gdbarch.sh (get_thread_local_address): New method.
 775         * gdbarch.h, gdbarch.c: Regenerate.
 776         * target.c (target_translate_tls_address): Use
 777         gdbarch_get_thread_local_address if present instead of
 778         target::get_thread_local_address.
 779
 780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 781
 782         * target.h (target::get_thread_local_address): Update comment.
 783
 784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 785
 786         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 787         objfile->separate_debug_objfile_backlink if not NULL.
 788
 789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 790
 791         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 792         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 793         (amd64bsd_store_inferior_registers): Likewise.
 794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 795         Enable segment base registers.
 796         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 797         PT_GETFSBASE and PT_GETGSBASE.
 798         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 799         PT_SETGSBASE.
 800         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 801         segment base registers.
 802         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 803
 804 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 805
 806         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 807         Update calls to i386_target_description to add 'segments'
 808         parameter.
 809         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 810         add segment base registers.
 811         * arch/i386.c (i386_create_target_description): Add 'segments'
 812         parameter to enable segment base registers.
 813         * arch/i386.h (i386_create_target_description): Likewise.
 814         * features/i386/32bit-segments.xml: New file.
 815         * features/i386/32bit-segments.c: Generate.
 816         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 817         call to i386_target_description to add 'segments' parameter.
 818         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 819         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 820         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 821         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 822         if feature is present.
 823         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 824         Add 'segments' parameter to call to i386_target_description.
 825         (i386_target_description): Add 'segments' parameter to enable
 826         segment base registers.
 827         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 828         to call to i386_target_description.
 829         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 830         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 831         Define I386_NUM_REGS.
 832         (i386_target_description): Add 'segments' parameter to enable
 833         segment base registers.
 834
 835 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 836
 837         PR/24325
 838         * source-cache.c: #undef open and close, to avoid unresolved
 839         externals during linking.
 840
 841 2019-03-12  Tom Tromey  <tromey@adacore.com>
 842
 843         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 844         const.  Add initializers.
 845         (_initialize_remote): Don't initialize ptid globals.
 846
 847 2019-03-12  Pedro Alves  <palves@redhat.com>
 848
 849         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 850
 851 2019-03-12  Pedro Alves  <palves@redhat.com>
 852
 853         * cp-name-parser.y (main): Remove unused 'len' variable.
 854
 855 2019-03-12  Tom Tromey  <tromey@adacore.com>
 856
 857         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 858         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 859
 860 2019-03-12  Tom Tromey  <tromey@adacore.com>
 861
 862         * linux-nat.c (iterate_over_lwps): Update.
 863         (stop_callback): Remove parameter.
 864         (stop_wait_callback, detach_callback, resume_set_callback)
 865         (select_singlestep_lwp_callback, set_ignore_sigint)
 866         (status_callback, resumed_callback, resume_clear_callback)
 867         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 868         data parameter.
 869         (linux_nat_target::detach, linux_nat_target::resume)
 870         (linux_stop_and_wait_all_lwps, select_event_lwp)
 871         (linux_nat_filter_event, linux_nat_wait_1)
 872         (linux_nat_target::kill, linux_nat_target::stop)
 873         (linux_nat_target::stop): Update.
 874         (linux_nat_resume_callback): Change type.
 875         (resume_stopped_resumed_lwps, count_events_callback)
 876         (select_event_lwp_callback): Likewise.
 877         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 878         * arm-linux-nat.c (struct update_registers_data): Remove.
 879         (update_registers_callback): Change type.
 880         (arm_linux_insert_hw_breakpoint1): Update.
 881         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 882         parameter.
 883         (x86_linux_dr_set_addr): Update.
 884         (x86_linux_dr_set_control): Update.
 885         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 886         (iterate_over_lwps): Use gdb::function_view.
 887         * nat/aarch64-linux-hw-point.c (struct
 888         aarch64_dr_update_callback_param): Remove.
 889         (debug_reg_change_callback): Change type.
 890         (aarch64_notify_debug_reg_change): Update.
 891         * s390-linux-nat.c (s390_refresh_per_info): Update.
 892
 893 2019-03-11  Tom Tromey  <tromey@adacore.com>
 894
 895         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 896         redundant assignment to "this_cu".
 897
 898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 899
 900         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 901
 902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 903
 904         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 905         from...
 906         (rank_one_type): ... this.
 907
 908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 909
 910         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 911         from...
 912         (rank_one_type): ... this.
 913
 914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 915
 916         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 917         from...
 918         (rank_one_type): ... this.
 919
 920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 921
 922         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 923         from...
 924         (rank_one_type): ... this.
 925
 926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 927
 928         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 929         from...
 930         (rank_one_type): ... this.
 931
 932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 933
 934         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 935         from...
 936         (rank_one_type): ... this.
 937
 938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 939
 940         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 941         from...
 942         (rank_one_type): ... this.
 943
 944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 945
 946         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 947         from...
 948         (rank_one_type): ... this.
 949
 950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 951
 952         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 953         from...
 954         (rank_one_type): ... this.
 955
 956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 957
 958         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 959         from...
 960         (rank_one_type): ... this.
 961
 962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 963
 964         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 965         from...
 966         (rank_one_type): ... this.
 967
 968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 969
 970         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 971         from...
 972         (rank_one_type): ... this.
 973
 974 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 975
 976         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 977         inferior-events' shows the example events.
 978
 979 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 980
 981         Support styling on native MS-Windows console
 982
 983         PR/24315
 984         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 985         on MS-Windows if $TERM is not defined.
 986
 987         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 988
 989         * posix-hdep.c (gdb_console_fputs):
 990         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 991         functions.
 992         * ui-file.h (gdb_console_fputs): Add prototype.
 993
 994         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 995         back to fputs only if the former returns zero.
 996
 997 2019-03-07  Tom Tromey  <tom@tromey.com>
 998
 999         * symmisc.c (print_symbol_bcache_statistics): Update.
1000         (print_objfile_statistics): Update.
1001         * symfile.c (allocate_symtab): Update.
1002         * stabsread.c: Don't include bcache.h.
1003         * psymtab.h (struct psymbol_bcache): Don't declare.
1004         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1005         (psymbol_bcache_init, psymbol_bcache_free)
1006         (psymbol_bcache_get_bcache): Don't declare.
1007         * psymtab.c (struct psymbol_bcache): Remove.
1008         (psymtab_storage::psymtab_storage): Update.
1009         (psymtab_storage::~psymtab_storage): Update.
1010         (psymbol_bcache_init, psymbol_bcache_free)
1011         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1012         (add_psymbol_to_bcache): Update.
1013         (allocate_psymtab): Update.
1014         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1015         macro_cache>: No longer pointers.
1016         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1017         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1018         * macrotab.c (macro_bcache): Update.
1019         * macroexp.c: Don't include bcache.h.
1020         * gdbtypes.c (check_types_worklist): Update.
1021         (types_deeply_equal): Remove TRY/CATCH.  Update.
1022         * elfread.c (elf_symtab_read): Update.
1023         * dwarf2read.c: Don't include bcache.h.
1024         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1025         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1026         (print_bcache_statistics, bcache_memory_used): Don't declare.
1027         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1028         methods.  Rename all data members.
1029         * bcache.c (struct bcache): Move to bcache.h.
1030         (bcache::expand_hash_table): Rename from expand_hash_table.
1031         (bcache): Remove.
1032         (bcache::insert): Rename from bcache_full.
1033         (bcache::compare): Rename from bcache_compare.
1034         (bcache_xmalloc): Remove.
1035         (bcache::~bcache): Rename from bcache_xfree.
1036         (bcache::print_statistics): Rename from print_bcache_statistics.
1037         (bcache::memory_used): Rename from bcache_memory_used.
1038
1039 2019-03-07  Pedro Alves  <palves@redhat.com>
1040
1041         * infrun.c (normal_stop): Also check for
1042         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1043
1044 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * f-lang.c (value_from_host_double): Moved to...
1047         * value.c (value_from_host_double): ...here.
1048         * value.h (value_from_host_double): Declare.
1049         * guile/scm-math.c (vlscm_convert_typed_number): Use
1050         value_from_host_double.
1051         (vlscm_convert_number): Likewise.
1052         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1053         * python/py-value.c (convert_value_from_python): Likewise.
1054
1055 2019-03-06  Tom Tromey  <tom@tromey.com>
1056
1057         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1058
1059 2019-03-06  Tom Tromey  <tom@tromey.com>
1060
1061         * utils.h (free_current_contents): Don't declare.
1062         * utils.c (free_current_contents): Remove.
1063
1064 2019-03-06  Tom Tromey  <tom@tromey.com>
1065
1066         * top.c (quit_force): Update.
1067         * main.c (captured_command_loop): Update.
1068         * common/new-op.c (operator new): Update.
1069         * common/common-exceptions.c (struct catcher)
1070         <save_cleanup_chain>: Remove member.
1071         (exceptions_state_mc_init): Update.
1072         (exception_try_scope_entry): Return nullptr.
1073         (exception_try_scope_exit, exception_rethrow)
1074         (throw_exception_sjlj, throw_exception_cxx): Update.
1075         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1076         (all_cleanups, do_cleanups, discard_cleanups)
1077         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1078         (restore_cleanups, restore_final_cleanups): Don't declare.
1079         (do_final_cleanups): Remove parameter.
1080         * common/cleanups.c (cleanup_chain, make_cleanup)
1081         (make_cleanup_dtor, all_cleanups, do_cleanups)
1082         (discard_my_cleanups, discard_cleanups)
1083         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1084         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1085         (null_cleanup): Remove.
1086         (do_final_cleanups): Remove parameter.
1087
1088 2019-03-06  Tom Tromey  <tom@tromey.com>
1089
1090         * remote.c (remote_target::remote_parse_stop_reply): Use
1091         unique_xmalloc_ptr.
1092
1093 2019-03-06  Tom Tromey  <tom@tromey.com>
1094
1095         * stabsread.c (struct stabs_field_info): Rename from field_info.
1096         <list, fnlist>: Add initializers.
1097         <obstack>: New member.
1098         (read_member_functions, read_struct_fields, read_baseclasses):
1099         Allocate on obstack.  Don't use cleanups.
1100         (read_one_struct_field, read_member_functions, read_struct_fields)
1101         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1102         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1103         (read_struct_type): Update.
1104
1105 2019-03-06  Tom Tromey  <tom@tromey.com>
1106
1107         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1108         * common/filestuff.h (make_cleanup_close): Don't declare.
1109         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1110         Remove.
1111
1112 2019-03-06  Tom Tromey  <tom@tromey.com>
1113
1114         * solib-aix.c: Use make_scope_exit.
1115
1116 2019-03-06  Tom Tromey  <tom@tromey.com>
1117
1118         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1119         Use make_scope_exit.
1120
1121 2019-03-06  Tom Tromey  <tom@tromey.com>
1122
1123         * solib-svr4.c (disable_probes_interface): Remove parameter.
1124         (svr4_handle_solib_event): Use make_scope_exit.
1125
1126 2019-03-06  Tom Tromey  <tom@tromey.com>
1127
1128         * remote.c (struct stop_reply_deleter): Remove.
1129         (stop_reply_up): Update.
1130         (struct stop_reply): Derive from notif_event.  Don't typedef.
1131         <regcache>: Now a std::vector.
1132         (stop_reply_xfree): Remove.
1133         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1134         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1135         (remote_target::discard_pending_stop_replies): Use delete.
1136         (remote_target::remote_parse_stop_reply): Update.
1137         (remote_target::process_stop_reply): Update.
1138         * remote-notif.h (struct notif_event): Add virtual destructor.
1139         Remove "dtr" member.
1140         (struct notif_client) <alloc_event>: Return a unique_ptr.
1141         (notif_event_xfree): Don't declare.
1142         (notif_event_up): New typedef.
1143         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1144         (notif_event_xfree, do_notif_event_xfree): Remove.
1145         (remote_notif_state_xfree): Update.
1146
1147 2019-03-06  Tom Tromey  <tom@tromey.com>
1148
1149         * infrun.c (displaced_step_clear_cleanup): Now a
1150         forward_scope_exit type.
1151         (displaced_step_prepare_throw): Update.
1152         (displaced_step_fixup): Update.
1153
1154 2019-03-06  Tom Tromey  <tom@tromey.com>
1155
1156         * inferior.h (class inferior): Update comment.
1157         * gdbthread.h (class thread_info): Update comment.
1158
1159 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1160             Tom Tromey  <tom@tromey.com>
1161
1162         * stabsread.h (struct stab_section_list): Remove.
1163         (coffstab_build_psymtabs): Update.
1164         * dbxread.c (symbuf_sections): Now a std::vector.
1165         (sect_idx): New global.
1166         (fill_symbuf): Update.
1167         (coffstab_build_psymtabs): Change type of stabsects parameter.
1168         Update.
1169         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1170         std::vector.
1171         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1172         (coff_locate_sections): Update.
1173         (coff_symfile_read): Remove cleanups.  Update.
1174         (init_stringtab): Add storage parameter.
1175         (free_stringtab, free_stringtab_cleanup): Remove.
1176         (init_lineno): Add storage parameter.
1177         (free_linetab, free_linetab_cleanup): Remove.
1178
1179 2019-03-06  Pedro Alves  <palves@redhat.com>
1180
1181         * linux-fork.c (fork_info::clobber_regs): Delete.
1182         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1183         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1184         comment.  Adjust.
1185         (scoped_switch_fork_info::scoped_switch_fork_info)
1186         (checkpoint_command, linux_fork_context): Adjust
1187         fork_save_infrun_state calls.
1188
1189 2019-03-06  Pedro Alves  <palves@redhat.com>
1190
1191         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1192         (inf_has_multiple_threads): Return 'bool' and rewrite using
1193         inferior_info::threads().
1194
1195 2019-03-06  Pedro Alves  <palves@redhat.com>
1196
1197         * linux-fork.c: Include <list>.
1198         (fork_list): Now a std::list instance.
1199         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1200         (forks_exist_p, find_last_fork): Adjust.
1201         (new_fork): Delete.
1202         (one_fork_p): New.
1203         (add_fork): Adjust.
1204         (free_fork): Delete, folded into fork_info::~fork_info().
1205         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1206         Adjust.
1207         (init_fork_list): Delete.
1208         (linux_fork_killall, linux_fork_mourn_inferior)
1209         (linux_fork_detach, info_checkpoints_command): Adjust.
1210         (_initialize_linux_fork): No longer call init_fork_list.
1211
1212 2019-03-06  Pedro Alves  <palves@redhat.com>
1213
1214         * linux-fork.c (new_fork): New, split out of ...
1215         (add_fork): ... this.  Return void.  Move "first fork" special
1216         case from here, to ...
1217         (checkpoint_command): ... here.
1218         * linux-linux.h (add_fork): Return void.
1219
1220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1223
1224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1225             Chris January  <chris.january@arm.com>
1226             David Lecomber  <david.lecomber@arm.com>
1227
1228         * f-exp.y: New token, UNOP_INTRINSIC.
1229         (exp): New pattern using UNOP_INTRINSIC token.
1230         (f77_keywords): Add 'abs' keyword.
1231         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1232         (value_from_host_double): New function.
1233         (evaluate_subexp_f): Support UNOP_ABS.
1234
1235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1238         types.
1239
1240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1243         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1244         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1245
1246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1249
1250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1251             Chris January  <chris.january@arm.com>
1252
1253         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1254         * f-exp.y: Define 'KIND' token.
1255         (exp): New pattern for KIND expressions.
1256         (ptype): Handle types with a kind extension.
1257         (direct_abs_decl): Extend to spot kind extensions.
1258         (f77_keywords): Add 'kind' to the list.
1259         (push_kind_type): New function.
1260         (convert_to_kind_type): New function.
1261         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1262         * parse.c (operator_length_standard): Likewise.
1263         * parser-defs.h (enum type_pieces): Add tp_kind.
1264         * std-operator.def: Add UNOP_KIND.
1265
1266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * f-exp.y (f_parse): Set yydebug.
1269
1270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * f-lang.c (evaluate_subexp_f): New function.
1273         (exp_descriptor_f): New global.
1274         (f_language_defn): Use exp_descriptor_f instead of
1275         exp_descriptor_standard.
1276
1277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * f-exp.y (struct token): Add comments.
1280         (dot_ops): Remove uppercase versions and the end marker.
1281         (f77_keywords): Likewise.
1282         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1283         entries in the dot_ops array are case insensitive, and use
1284         strncasecmp to compare strings.  Also some whitespace cleanup in
1285         this area.  Similar for the f77_keywords array, except entries in
1286         this list might be case sensitive.
1287
1288 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * f-exp.y (struct f77_boolean_val): Add comments.
1291         (boolean_values): Remove uppercase versions, and end marker.
1292         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1293         and use strncasecmp to achieve case insensitivity.  Additionally,
1294         perform whitespace cleanup around this code.
1295
1296 2019-03-06  Tom Tromey  <tromey@adacore.com>
1297
1298         * remote-sim.c (gdbsim_target_open): Use result of
1299         gdb_argv::release.
1300
1301 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1302         Dirk Schubert  <dirk.schubert@arm.com>
1303         Chris January  <chris.january@arm.com>
1304
1305         * eval.c (evaluate_subexp_standard): Call Fortran argument
1306         wrapping logic.
1307         * f-lang.c (struct value): A value which can be passed into a
1308         Fortran function call.
1309         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1310         where appropriate.
1311         (struct type): Value ready for a Fortran function call.
1312         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1313         is needed.
1314         * f-lang.h (fortran_argument_convert): Declaration.
1315         (fortran_preserve_arg_pointer): Declaration.
1316         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1317
1318 2019-03-05  Tom Tromey  <tromey@adacore.com>
1319
1320         * python/py-prettyprint.c (print_string_repr): Remove #if.
1321         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1322
1323 2019-03-05  Tom Tromey  <tromey@adacore.com>
1324
1325         * target.c (the_dummy_target): Move later.  Change type to
1326         "dummy_target".
1327         (initialize_targets): Don't initialize the_dummy_target.
1328
1329 2019-03-05  Tom Tromey  <tromey@adacore.com>
1330
1331         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1332         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1333
1334 2019-03-05  Tom Tromey  <tromey@adacore.com>
1335
1336         * windows-nat.c (windows_nat_target::attach)
1337         (windows_nat_target::detach): Don't call gdb_flush.
1338         * valprint.c (generic_val_print, val_print, val_print_string):
1339         Don't call gdb_flush.
1340         * utils.c (defaulted_query): Don't call gdb_flush.
1341         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1342         * target.c (target_announce_detach): Don't call gdb_flush.
1343         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1344         * remote.c (extended_remote_target::attach): Don't call
1345         gdb_flush.
1346         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1347         * printcmd.c (do_examine): Don't call gdb_flush.
1348         (info_display_command): Don't call gdb_flush.
1349         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1350         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1351         * memattr.c (info_mem_command): Don't call gdb_flush.
1352         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1353         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1354         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1355         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1356         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1357         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1358         (gnu_nat_target::detach): Don't call gdb_flush.
1359         * f-valprint.c (f_val_print): Don't call gdb_flush.
1360         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1361         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1362         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1363         gdb_flush.
1364         * c-valprint.c (c_val_print): Don't call gdb_flush.
1365         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1366
1367 2019-03-05  Tom Tromey  <tromey@adacore.com>
1368
1369         * varobj.c (update_dynamic_varobj_children): Update.
1370         (install_default_visualizer): Use reset, not release.
1371         * value.c (set_internalvar): Update.
1372         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1373         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1374         ATTRIBUTE_UNUSED_RESULT.
1375
1376 2019-03-05  Tom Tromey  <tromey@adacore.com>
1377
1378         * remote.c (class scoped_remote_fd) <release>: Add
1379         ATTRIBUTE_UNUSED_RESULT.
1380
1381 2019-03-05  Tom Tromey  <tromey@adacore.com>
1382
1383         * macroexp.c (struct macro_buffer) <release>: Add
1384         ATTRIBUTE_UNUSED_RESULT.
1385
1386 2019-03-05  Tom Tromey  <tromey@adacore.com>
1387
1388         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1389         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1390         ATTRIBUTE_UNUSED_RESULT.
1391
1392 2019-03-05  Tom Tromey  <tromey@adacore.com>
1393
1394         * common/scoped_fd.h (class scoped_fd) <release>: Add
1395         ATTRIBUTE_UNUSED_RESULT.
1396
1397 2019-03-05  Tom Tromey  <tromey@adacore.com>
1398
1399         * parser-defs.h (struct parser_state) <release>: Add
1400         ATTRIBUTE_UNUSED_RESULT.
1401
1402 2019-03-05  Tom Tromey  <tromey@adacore.com>
1403
1404         * utils.h (class gdb_argv) <release>: Add
1405         ATTRIBUTE_UNUSED_RESULT.
1406         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1407
1408 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1409
1410         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1411         for-loop range, to avoid compiler warnings.
1412
1413         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1414         avoid compiler warnings about unused variables.
1415
1416         * NEWS: Mention end of support for native debugging on MS-Windows
1417         before XP.
1418
1419         PR gdb/24292
1420         * common/netstuff.c:
1421         * gdbserver/gdbreplay.c
1422         * gdbserver/remote-utils.c:
1423         * ser-tcp.c:
1424         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1425         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1426         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1427         'getaddrinfo' and 'freeaddrinfo' were not available before
1428         Windows XP, and mingw.org's MinGW headers by default define
1429         _WIN32_WINNT to 0x500.
1430
1431 2019-03-01  Gary Benson <gbenson@redhat.com>
1432
1433         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1434
1435 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1436             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1437
1438         PR gdb/8527
1439         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1440         set_sigint_trap, clear_sigint_trap.
1441
1442 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1443
1444         * target.c (target_detach): Clear the regcache and the
1445         frame cache.
1446
1447 2019-02-27  Pedro Alves  <palves@redhat.com>
1448
1449         * utils.c (set_screen_size): When we cap the height/width sizes,
1450         tweak the corresponding command variable to show "unlimited":
1451
1452 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1453             Pedro Alves  <palves@redhat.com>
1454
1455         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1456         before calling rl_set_screen_size.
1457
1458 2019-02-27  Tom Tromey  <tromey@adacore.com>
1459
1460         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1461         define.
1462         * python/py-value.c: Remove Python 2.4 workaround.
1463         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1464         workaround.
1465         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1466         Python 2.4 workaround.
1467         * python/python-internal.h: Remove Python 2.4 comment.
1468         (Py_ssize_t): Don't define.
1469         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1470         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1471         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1472         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1473         * python/python.c (do_start_initialization): Remove Python 2.4
1474         workaround.
1475         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1476         (print_children): Remove Python 2.4 workaround.
1477         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1478         workaround.
1479         (CHARBUFFERPROC_NAME): Remove.
1480         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1481         Python 2.4 workaround.
1482
1483 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1484
1485         * NEWS: Note minimum Python version.
1486
1487 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1488
1489         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1490         code from these functions.  Remove corresponding ifdefs.  Use
1491         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1492         Remove gotos and target of gotos.
1493         (infpy_search_memory): Likewise.
1494
1495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1498         (hppa_gdbarch_init): Don't register deleted functions with
1499         gdbarch.
1500
1501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1504         (h8300_unwind_sp): Delete.
1505         (h8300_dummy_id): Delete.
1506         (h8300_gdbarch_init): Don't register deleted functions with
1507         gdbarch.
1508
1509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1512         (ft32_unwind_pc): Delete.
1513         (ft32_unwind_sp): Delete.
1514         (ft32_gdbarch_init): Don't register deleted functions with
1515         gdbarch.
1516
1517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1520         (frv_unwind_pc): Delete.
1521         (frv_unwind_sp): Delete.
1522         (frv_gdbarch_init): Don't register deleted functions with
1523         gdbarch.
1524
1525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1526
1527         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1528         (riscv_unwind_pc): Delete.
1529         (riscv_unwind_sp): Delete.
1530         (riscv_gdbarch_init): Don't register deleted functions with
1531         gdbarch.
1532
1533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1536         (csky_unwind_pc): Delete.
1537         (csky_unwind_sp): Delete.
1538         (csky_gdbarch_init): Don't register deleted functions with
1539         gdbarch.
1540
1541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1544         (cris_unwind_pc): Delete.
1545         (cris_unwind_sp): Delete.
1546         (cris_gdbarch_init): Don't register deleted functions with
1547         gdbarch.
1548
1549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1552         (bfin_unwind_pc): Delete.
1553         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1554
1555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1558         (arm_unwind_pc): Delete.
1559         (arm_unwind_sp): Delete.
1560         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1561
1562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1565         (arc_unwind_pc): Delete.
1566         (arc_unwind_sp): Delete.
1567         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1568
1569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1572         (alpha_unwind_pc): Delete.
1573         (alpha_gdbarch_init): Don't register deleted functions with
1574         gdbarch.
1575
1576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1579         (aarch64_unwind_pc): Delete.
1580         (aarch64_unwind_sp): Delete.
1581         (aarch64_gdbarch_init): Don't register deleted functions with
1582         gdbarch.
1583
1584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * gdbtypes.c (type_align): Don't consider static members when
1587         computing structure alignment.
1588
1589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1590
1591         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1592         return 0 for other types.
1593         * arch-utils.c (default_type_align): Always return 0.
1594         * gdbarch.h: Regenerate.
1595         * gdbarch.sh (type_align): Extend comment.
1596         * gdbtypes.c (type_align): Add additional comments, always call
1597         gdbarch_type_align before applying the default rules.
1598         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1599         generic code will then apply a suitable default.
1600         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1601         types, return 0 for other types.
1602
1603 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1604
1605         * NEWS: Create a new section for the next release branch.
1606         Rename the section of the current branch, now that it has
1607         been cut.
1608
1609 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1610
1611         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1612         * version.in: Bump version to 8.3.50.DATE-git.
1613
1614 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1615
1616         * aix-thread.c (ptid_cmp): Remove unused variable.
1617         (get_signaled_thread): Likewise.
1618         (store_regs_user_thread): Likewise.
1619         (store_regs_kernel_thread): Likewise.
1620         (fetch_regs_kernel_thread): Remove shadowed variable.
1621
1622 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1623
1624         * features/riscv/32bit-cpu.xml: Add register numbers.
1625         * features/riscv/32bit-fpu.c: Regenerate.
1626         * features/riscv/32bit-fpu.xml: Add register numbers.
1627         * features/riscv/64bit-cpu.xml: Add register numbers.
1628         * features/riscv/64bit-fpu.c: Regenerate.
1629         * features/riscv/64bit-fpu.xml: Add register numbers.
1630
1631 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1632
1633         * NEWS: Mention two argument form of gdb.Value constructor.
1634         * python/py-value.c (convert_buffer_and_type_to_value): New
1635         function.
1636         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1637         Add support for handling an optional second argument.  Call
1638         convert_buffer_and_type_to_value as appropriate.
1639         * python/python-internal.h (Py_buffer_deleter): New struct.
1640         (Py_buffer_up): New typedef.
1641
1642 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1643
1644         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1645         instead of releasing ownership.
1646
1647 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1648
1649         * dwarf2read.c (open_and_init_dwp_file): Call
1650         elf_numsections instead of bfd_count_sections to initialize
1651         dwp_file->num_sections.
1652
1653 2019-02-25  Tom Tromey  <tromey@adacore.com>
1654
1655         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1656
1657 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1658
1659         * gcore.in: Add '--readnever' option when invoking GDB.
1660
1661 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1662
1663         * MAINTAINERS: Update my email address.
1664
1665 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1666
1667         * build-id.c (build_id_to_debug_bfd_1): New function.
1668         (build_id_to_debug_bfd): Look for separate debug file in
1669         sysroot.
1670
1671 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1672
1673         * gdbarch.sh: Update the copyright year range that is placed into
1674         generated files.
1675
1676 2019-02-22  Keith Seitz  <keiths@redhat.com>
1677
1678         PR symtab/23853
1679         * linespec.c (create_sals_line_offset): Search for the default
1680         symtab's filename instead of its fullname.
1681
1682 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1683
1684         * NEWS: Update style defaults.
1685
1686 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1687
1688         * main.c (captured_main_1): Disable styling in batch mode.
1689
1690 2019-02-20  Tom Tromey  <tom@tromey.com>
1691
1692         * symtab.c (symtab_symbol_info): Fix typos.
1693
1694 2019-02-20  Tom Tromey  <tromey@adacore.com>
1695
1696         * findcmd.c (_initialize_mem_search): Use upper case for
1697         metasyntactic variables.
1698
1699 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1700
1701         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1702         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1703
1704 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1705
1706         * top.h (source_file_name): Change to std::string.
1707         * top.c (source_file_name): Likewise.
1708         (command_line_input): Adjust.
1709         * cli/cli-script.c (script_from_file): Adjust.
1710
1711 2019-02-19  Tom Tromey  <tromey@adacore.com>
1712
1713         * ravenscar-thread.c
1714         (ravenscar_thread_target::update_thread_list): Don't call
1715         ada_build_task_list.
1716         * ada-lang.h (ada_build_task_list): Don't declare.
1717         * ada-tasks.c (struct ada_tasks_inferior_data)
1718         <task_list_valid_p>: Now bool.
1719         (read_known_tasks, ada_task_list_changed)
1720         (ada_tasks_invalidate_inferior_data): Update.
1721         (read_known_tasks_array): Return bool.
1722         (read_known_tasks_list): Likewise.
1723         (read_known_tasks): Return void.
1724         (ada_build_task_list): Now static.
1725
1726 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1729         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1730
1731 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1732
1733         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1734         variant for ada_tasks_pspace_data_handle and
1735         ada_tasks_inferior_data_handle.
1736         (ada_tasks_pspace_data_cleanup): New function.
1737         (ada_tasks_inferior_data_cleanup): New function.
1738
1739 2019-02-17  Tom Tromey  <tom@tromey.com>
1740
1741         * macrotab.h (macro_source_fullname): Return a std::string.
1742         * macrotab.c (macro_include, check_for_redefinition)
1743         (macro_undef, macro_lookup_definition, foreach_macro)
1744         (foreach_macro_in_scope): Update.
1745         (macro_source_fullname): Return a std::string.
1746         * macrocmd.c (show_pp_source_pos): Update.
1747
1748 2019-02-17  Tom Tromey  <tom@tromey.com>
1749
1750         * macrocmd.c (show_pp_source_pos): Style the file names.
1751
1752 2019-02-17  Tom Tromey  <tom@tromey.com>
1753
1754         PR tui/24197:
1755         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1756
1757 2019-02-17  Tom Tromey  <tom@tromey.com>
1758
1759         * ada-lang.c (user_select_syms): Use filtered printing.
1760         * utils.c (wrap_style): New global.
1761         (desired_style): Remove.
1762         (emit_style_escape): Add stream parameter.
1763         (set_output_style, reset_terminal_style, prompt_for_continue):
1764         Update.
1765         (flush_wrap_buffer): Only flush gdb_stdout.
1766         (wrap_here): Set wrap_style.
1767         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1768         treat escape sequences as a character.  Change when wrap buffer is
1769         flushed.
1770         (fputs_styled): Do not set the output style when the default is
1771         requested.
1772         * ui-style.h (struct ui_file_style) <is_default>: New method.
1773         * source.c (print_source_lines_base): Emit escape sequences in one
1774         piece.
1775
1776 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1777
1778         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1779         integers and enumeration types.
1780
1781 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1782
1783         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1784         instead of lookup_symbol_in_language
1785         (do_exact_match): New function.
1786         (ada_get_symbol_name_matcher): Return do_exact_match when
1787         doing a verbatim match.
1788
1789 2019-02-15  Tom Tromey  <tromey@adacore.com>
1790
1791         * ravenscar-thread.c (ravenscar_thread_target::resume)
1792         (ravenscar_thread_target::wait): Special case wildcard requests.
1793
1794 2019-02-15  Tom Tromey  <tromey@adacore.com>
1795
1796         * ravenscar-thread.c (base_ptid): Remove.
1797         (struct ravenscar_thread_target) <close>: New method.
1798         <m_base_ptid>: New member.
1799         <update_inferior_ptid, active_task, task_is_currently_active,
1800         runtime_initialized>: Declare methods.
1801         <ravenscar_thread_target>: Add constructor.
1802         (ravenscar_thread_target::task_is_currently_active)
1803         (ravenscar_thread_target::update_inferior_ptid)
1804         (ravenscar_runtime_initialized): Rename.  Now methods.
1805         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1806         (ravenscar_thread_target::update_thread_list): Update.
1807         (ravenscar_thread_target::active_task): Now method.
1808         (ravenscar_thread_target::store_registers)
1809         (ravenscar_thread_target::prepare_to_store)
1810         (ravenscar_thread_target::prepare_to_store)
1811         (ravenscar_thread_target::mourn_inferior): Update.
1812         (ravenscar_inferior_created): Use "new" to create target.
1813         (ravenscar_thread_target::get_ada_task_ptid): Update.
1814         (_initialize_ravenscar): Don't initialize base_ptid.
1815         (ravenscar_ops): Remove global.
1816
1817 2019-02-15  Tom Tromey  <tromey@adacore.com>
1818
1819         * target.h (push_target): Declare new overload.
1820         * target.c (push_target): New overload, taking an rvalue reference.
1821         * remote.c (remote_target::open_1): Use push_target overload.
1822         * corelow.c (core_target_open): Use push_target overload.
1823
1824 2019-02-15  Tom Tromey  <tromey@adacore.com>
1825
1826         * ravenscar-thread.c (is_ravenscar_task)
1827         (ravenscar_task_is_currently_active): Return bool.
1828         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1829         (_initialize_ravenscar): Remove "(void)".
1830         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1831         Return bool.
1832
1833 2019-02-15  Tom Tromey  <tromey@adacore.com>
1834
1835         * ravenscar-thread.c (ravenscar_runtime_initializer)
1836         (has_ravenscar_runtime, get_running_thread_id)
1837         (ravenscar_thread_target::resume): Fix indentation.
1838
1839 2019-02-15  Tom Tromey  <tromey@adacore.com>
1840
1841         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1842         from ravenscar_arch_ops.
1843         (sparc_ravenscar_ops::fetch_registers)
1844         (sparc_ravenscar_ops::store_registers): Now methods.
1845         (sparc_ravenscar_prepare_to_store): Remove.
1846         (sparc_ravenscar_ops): Redefine.
1847         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1848         methods and destructor.  Remove members.
1849         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1850         (ravenscar_thread_target::store_registers)
1851         (ravenscar_thread_target::prepare_to_store): Update.
1852         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1853         Remove.
1854         (struct ppc_ravenscar_powerpc_ops): Derive from
1855         ravenscar_arch_ops.
1856         (ppc_ravenscar_powerpc_ops::fetch_registers)
1857         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1858         (ppc_ravenscar_powerpc_ops): Redefine.
1859         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1860         (ppc_ravenscar_e500_ops::fetch_registers)
1861         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1862         (ppc_ravenscar_e500_ops): Redefine.
1863         * aarch64-ravenscar-thread.c
1864         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1865         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1866         (aarch64_ravenscar_fetch_registers)
1867         (aarch64_ravenscar_store_registers): Now methods.
1868         (aarch64_ravenscar_ops): Redefine.
1869
1870 2019-02-15  Tom Tromey  <tromey@adacore.com>
1871
1872         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1873         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1874         (ravenscar_thread_target::stopped_by_watchpoint)
1875         (ravenscar_thread_target::stopped_data_address)
1876         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1877
1878 2019-02-15  Tom Tromey  <tromey@adacore.com>
1879
1880         * ravenscar-thread.c: Fix some typos.
1881
1882 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1883             Tom Tromey  <tromey@adacore.com>
1884
1885         * ada-lang.c (ada_exception_sal): Change addr_string to a
1886         std::string.
1887         (create_ada_exception_catchpoint): Update.
1888
1889 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1890             Tom Tromey  <tromey@adacore.com>
1891
1892         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1893         (bp_location_ops): Remove.
1894         (base_breakpoint_allocate_location): Update.
1895         (free_bp_location): Update.
1896         * ada-lang.c (class ada_catchpoint_location)
1897         <ada_catchpoint_location>: Remove ops parameter.
1898         (ada_catchpoint_location_dtor): Remove.
1899         (ada_catchpoint_location_ops): Remove.
1900         (allocate_location_exception): Update.
1901         * breakpoint.h (struct bp_location_ops): Remove.
1902         (class bp_location) <bp_location>: Remove bp_location_ops
1903         parameter.
1904         <~bp_location>: Add destructor.
1905         <ops>: Remove.
1906
1907 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1908             Pedro Alves  <palves@redhat.com>
1909
1910         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1911         'PATH_MAX'.
1912
1913 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1914             Samuel Thibault  <samuel.thibault@gnu.org>
1915             Thomas Schwinge  <thomas@codesourcery.com>
1916
1917         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1918         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1919
1920 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1921
1922         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1923         (check_empty): Use "const char *".
1924
1925         * gnu-nat.c (gnu_nat_target::detach): Instead of
1926         'detach_inferior (pid)' call
1927         'detach_inferior (find_inferior_pid (pid))'.
1928
1929         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1930         'nat/fork-inferior.o'.
1931         * gnu-nat.c: #include "nat/fork-inferior.h".
1932
1933         * gnu-nat.c (gnu_nat_target::detach): Instead of
1934         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1935         * gnu-nat.h: #include "inf-child.h".
1936         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1937         'i386_gnu_nat_target::fetch_registers'.
1938         (gnu_store_registers): Rename/move to
1939         'i386_gnu_nat_target::store_registers'.
1940
1941         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1942         * gnu-nat.h (mach_thread_info): New function.
1943         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1944
1945         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1946
1947 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1948
1949         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1950
1951 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1952
1953         * windows-nat.c (windows_add_thread): Add new parameter
1954         "main_thread_p" with default value set to false.  Update
1955         function documentation as well as all callers.
1956         (windows_delete_thread): Likewise.
1957         (fake_create_process): Update call to windows_add_thread.
1958         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1959         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1960         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1961         call to windows_delete_thread.
1962
1963 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1964
1965         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1966
1967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1968
1969         * symfile.c (find_separate_debug_file): Use canonical path of
1970         sysroot with child_path instead of gdb_sysroot if it is valid.
1971
1972 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1973
1974         * symfile.c (find_separate_debug_file): Use child_path to
1975         determine if an object file is under a sysroot.
1976
1977 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1978
1979         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1980         unittests/child-path-selftests.c.
1981         * common/pathstuff.c (child_path): New function.
1982         * common/pathstuff.h (child_path): New prototype.
1983         * unittests/child-path-selftests.c: New file.
1984
1985 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1986
1987         * symfile.c (find_separate_debug_file): Look for separate debug
1988         files in debug directories under the sysroot.
1989
1990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1991
1992         * symtab.h (struct minimal_symbol data_p): New const method.
1993         (struct minimal_symbol text_p): Likewise.
1994         * symtab.c (output_source_filename): Use file name style
1995         to print file name.
1996         (print_symbol_info): Likewise.
1997         (print_msymbol_info): Use address style to print addresses.
1998         Use function name style to print executable text symbols.
1999         (expand_symtab_containing_pc): Use data_p.
2000         (find_pc_sect_compunit_symtab): Likewise.
2001
2002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2003
2004         * breakpoint.c (describe_other_breakpoints): Use address style
2005         to print addresses.
2006         (say_where): Likewise.
2007
2008 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2009
2010         * ada-typeprint.c (print_func_type): Print function name
2011         style to print function name.
2012         * c-typeprint.c (c_print_type_1): Likewise.
2013
2014 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2015
2016         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2017         for execve.
2018
2019 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2020
2021         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2022         type_stack.
2023
2024 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2025
2026         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2027         TYPE_CODE_REF types.
2028
2029 2019-02-08  Jim Wilson  <jimw@sifive.com>
2030
2031         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2032         (riscv_linux_fregset): New.
2033         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2034
2035 2019-02-07  Tom Tromey  <tom@tromey.com>
2036
2037         * thread.c (thread_cancel_execution_command): Update.
2038         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2039         methods.
2040         (struct thread_fsm_ops): Remove.
2041         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2042         (thread_fsm_should_stop, thread_fsm_return_value)
2043         (thread_fsm_set_finished, thread_fsm_finished_p)
2044         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2045         Don't declare.
2046         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2047         * infrun.c (clear_proceed_status_thread)
2048         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2049         (print_stop_event): Update.
2050         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2051         Add constructor.
2052         (step_command_fsm_ops): Remove.
2053         (new_step_command_fsm): Remove.
2054         (step_1): Update.
2055         (step_command_fsm::should_stop): Rename from
2056         step_command_fsm_should_stop.
2057         (step_command_fsm::clean_up): Rename from
2058         step_command_fsm_clean_up.
2059         (step_command_fsm::do_async_reply_reason): Rename from
2060         step_command_fsm_async_reply_reason.
2061         (struct until_next_fsm): Inherit from thread_fsm.  Add
2062         constructor.
2063         (until_next_fsm_ops): Remove.
2064         (new_until_next_fsm): Remove.
2065         (until_next_fsm::should_stop): Rename from
2066         until_next_fsm_should_stop.
2067         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2068         (until_next_fsm::do_async_reply_reason): Rename from
2069         until_next_fsm_async_reply_reason.
2070         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2071         constructor.  Change type of breakpoint.
2072         (finish_command_fsm_ops): Remove.
2073         (new_finish_command_fsm): Remove.
2074         (finish_command_fsm::should_stop): Rename from
2075         finish_command_fsm_should_stop.
2076         (finish_command_fsm::clean_up): Rename from
2077         finish_command_fsm_clean_up.
2078         (finish_command_fsm::return_value): Rename from
2079         finish_command_fsm_return_value.
2080         (finish_command_fsm::do_async_reply_reason): Rename from
2081         finish_command_fsm_async_reply_reason.
2082         (finish_command): Update.
2083         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2084         Add constructor.
2085         (call_thread_fsm_ops): Remove.
2086         (call_thread_fsm::call_thread_fsm): Rename from
2087         new_call_thread_fsm.
2088         (call_thread_fsm::should_stop): Rename from
2089         call_thread_fsm_should_stop.
2090         (call_thread_fsm::should_notify_stop): Rename from
2091         call_thread_fsm_should_notify_stop.
2092         (run_inferior_call, call_function_by_hand_dummy): Update.
2093         * cli/cli-interp.c (should_print_stop_to_console): Update.
2094         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2095         Add constructor.  Change type of location_breakpoint,
2096         caller_breakpoint.
2097         (until_break_fsm_ops): Remove.
2098         (new_until_break_fsm): Remove.
2099         (until_break_fsm::should_stop): Rename from
2100         until_break_fsm_should_stop.
2101         (until_break_fsm::clean_up): Rename from
2102         until_break_fsm_clean_up.
2103         (until_break_fsm::do_async_reply_reason): Rename from
2104         until_break_fsm_async_reply_reason.
2105         (until_break_command): Update.
2106         * thread-fsm.c: Remove.
2107         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2108
2109 2019-02-07  Tom Tromey  <tom@tromey.com>
2110
2111         * yy-remap.h: Add include guard.
2112         * xtensa-tdep.h: Add include guard.
2113         * xcoffread.h: Rename include guard.
2114         * varobj-iter.h: Add include guard.
2115         * tui/tui.h: Rename include guard.
2116         * tui/tui-winsource.h: Rename include guard.
2117         * tui/tui-wingeneral.h: Rename include guard.
2118         * tui/tui-windata.h: Rename include guard.
2119         * tui/tui-win.h: Rename include guard.
2120         * tui/tui-stack.h: Rename include guard.
2121         * tui/tui-source.h: Rename include guard.
2122         * tui/tui-regs.h: Rename include guard.
2123         * tui/tui-out.h: Rename include guard.
2124         * tui/tui-layout.h: Rename include guard.
2125         * tui/tui-io.h: Rename include guard.
2126         * tui/tui-hooks.h: Rename include guard.
2127         * tui/tui-file.h: Rename include guard.
2128         * tui/tui-disasm.h: Rename include guard.
2129         * tui/tui-data.h: Rename include guard.
2130         * tui/tui-command.h: Rename include guard.
2131         * tic6x-tdep.h: Add include guard.
2132         * target/waitstatus.h: Rename include guard.
2133         * target/wait.h: Rename include guard.
2134         * target/target.h: Rename include guard.
2135         * target/resume.h: Rename include guard.
2136         * target-float.h: Rename include guard.
2137         * stabsread.h: Add include guard.
2138         * rs6000-tdep.h: Add include guard.
2139         * riscv-fbsd-tdep.h: Add include guard.
2140         * regformats/regdef.h: Rename include guard.
2141         * record.h: Rename include guard.
2142         * python/python.h: Rename include guard.
2143         * python/python-internal.h: Rename include guard.
2144         * python/py-stopevent.h: Rename include guard.
2145         * python/py-ref.h: Rename include guard.
2146         * python/py-record.h: Rename include guard.
2147         * python/py-record-full.h: Rename include guard.
2148         * python/py-record-btrace.h: Rename include guard.
2149         * python/py-instruction.h: Rename include guard.
2150         * python/py-events.h: Rename include guard.
2151         * python/py-event.h: Rename include guard.
2152         * procfs.h: Add include guard.
2153         * proc-utils.h: Add include guard.
2154         * p-lang.h: Add include guard.
2155         * or1k-tdep.h: Rename include guard.
2156         * observable.h: Rename include guard.
2157         * nto-tdep.h: Rename include guard.
2158         * nat/x86-linux.h: Rename include guard.
2159         * nat/x86-linux-dregs.h: Rename include guard.
2160         * nat/x86-gcc-cpuid.h: Add include guard.
2161         * nat/x86-dregs.h: Rename include guard.
2162         * nat/x86-cpuid.h: Rename include guard.
2163         * nat/ppc-linux.h: Rename include guard.
2164         * nat/mips-linux-watch.h: Rename include guard.
2165         * nat/linux-waitpid.h: Rename include guard.
2166         * nat/linux-ptrace.h: Rename include guard.
2167         * nat/linux-procfs.h: Rename include guard.
2168         * nat/linux-osdata.h: Rename include guard.
2169         * nat/linux-nat.h: Rename include guard.
2170         * nat/linux-namespaces.h: Rename include guard.
2171         * nat/linux-btrace.h: Rename include guard.
2172         * nat/glibc_thread_db.h: Rename include guard.
2173         * nat/gdb_thread_db.h: Rename include guard.
2174         * nat/gdb_ptrace.h: Rename include guard.
2175         * nat/fork-inferior.h: Rename include guard.
2176         * nat/amd64-linux-siginfo.h: Rename include guard.
2177         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2178         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2179         * nat/aarch64-linux.h: Rename include guard.
2180         * nat/aarch64-linux-hw-point.h: Rename include guard.
2181         * mn10300-tdep.h: Add include guard.
2182         * mips-linux-tdep.h: Add include guard.
2183         * mi/mi-parse.h: Rename include guard.
2184         * mi/mi-out.h: Rename include guard.
2185         * mi/mi-main.h: Rename include guard.
2186         * mi/mi-interp.h: Rename include guard.
2187         * mi/mi-getopt.h: Rename include guard.
2188         * mi/mi-console.h: Rename include guard.
2189         * mi/mi-common.h: Rename include guard.
2190         * mi/mi-cmds.h: Rename include guard.
2191         * mi/mi-cmd-break.h: Rename include guard.
2192         * m2-lang.h: Add include guard.
2193         * location.h: Rename include guard.
2194         * linux-record.h: Rename include guard.
2195         * linux-nat.h: Add include guard.
2196         * linux-fork.h: Add include guard.
2197         * i386-darwin-tdep.h: Rename include guard.
2198         * hppa-linux-offsets.h: Add include guard.
2199         * guile/guile.h: Rename include guard.
2200         * guile/guile-internal.h: Rename include guard.
2201         * gnu-nat.h: Rename include guard.
2202         * gdb-stabs.h: Rename include guard.
2203         * frv-tdep.h: Add include guard.
2204         * f-lang.h: Add include guard.
2205         * event-loop.h: Add include guard.
2206         * darwin-nat.h: Rename include guard.
2207         * cp-abi.h: Rename include guard.
2208         * config/sparc/nm-sol2.h: Rename include guard.
2209         * config/nm-nto.h: Rename include guard.
2210         * config/nm-linux.h: Add include guard.
2211         * config/i386/nm-i386gnu.h: Rename include guard.
2212         * config/djgpp/nl_types.h: Rename include guard.
2213         * config/djgpp/langinfo.h: Rename include guard.
2214         * compile/gcc-cp-plugin.h: Add include guard.
2215         * compile/gcc-c-plugin.h: Add include guard.
2216         * compile/compile.h: Rename include guard.
2217         * compile/compile-object-run.h: Rename include guard.
2218         * compile/compile-object-load.h: Rename include guard.
2219         * compile/compile-internal.h: Rename include guard.
2220         * compile/compile-cplus.h: Rename include guard.
2221         * compile/compile-c.h: Rename include guard.
2222         * common/xml-utils.h: Rename include guard.
2223         * common/x86-xstate.h: Rename include guard.
2224         * common/version.h: Rename include guard.
2225         * common/vec.h: Rename include guard.
2226         * common/tdesc.h: Rename include guard.
2227         * common/selftest.h: Rename include guard.
2228         * common/scoped_restore.h: Rename include guard.
2229         * common/scoped_mmap.h: Rename include guard.
2230         * common/scoped_fd.h: Rename include guard.
2231         * common/safe-iterator.h: Rename include guard.
2232         * common/run-time-clock.h: Rename include guard.
2233         * common/refcounted-object.h: Rename include guard.
2234         * common/queue.h: Rename include guard.
2235         * common/ptid.h: Rename include guard.
2236         * common/print-utils.h: Rename include guard.
2237         * common/preprocessor.h: Rename include guard.
2238         * common/pathstuff.h: Rename include guard.
2239         * common/observable.h: Rename include guard.
2240         * common/netstuff.h: Rename include guard.
2241         * common/job-control.h: Rename include guard.
2242         * common/host-defs.h: Rename include guard.
2243         * common/gdb_wait.h: Rename include guard.
2244         * common/gdb_vecs.h: Rename include guard.
2245         * common/gdb_unlinker.h: Rename include guard.
2246         * common/gdb_unique_ptr.h: Rename include guard.
2247         * common/gdb_tilde_expand.h: Rename include guard.
2248         * common/gdb_sys_time.h: Rename include guard.
2249         * common/gdb_string_view.h: Rename include guard.
2250         * common/gdb_splay_tree.h: Rename include guard.
2251         * common/gdb_setjmp.h: Rename include guard.
2252         * common/gdb_ref_ptr.h: Rename include guard.
2253         * common/gdb_optional.h: Rename include guard.
2254         * common/gdb_locale.h: Rename include guard.
2255         * common/gdb_assert.h: Rename include guard.
2256         * common/filtered-iterator.h: Rename include guard.
2257         * common/filestuff.h: Rename include guard.
2258         * common/fileio.h: Rename include guard.
2259         * common/environ.h: Rename include guard.
2260         * common/common-utils.h: Rename include guard.
2261         * common/common-types.h: Rename include guard.
2262         * common/common-regcache.h: Rename include guard.
2263         * common/common-inferior.h: Rename include guard.
2264         * common/common-gdbthread.h: Rename include guard.
2265         * common/common-exceptions.h: Rename include guard.
2266         * common/common-defs.h: Rename include guard.
2267         * common/common-debug.h: Rename include guard.
2268         * common/cleanups.h: Rename include guard.
2269         * common/buffer.h: Rename include guard.
2270         * common/btrace-common.h: Rename include guard.
2271         * common/break-common.h: Rename include guard.
2272         * cli/cli-utils.h: Rename include guard.
2273         * cli/cli-style.h: Rename include guard.
2274         * cli/cli-setshow.h: Rename include guard.
2275         * cli/cli-script.h: Rename include guard.
2276         * cli/cli-interp.h: Rename include guard.
2277         * cli/cli-decode.h: Rename include guard.
2278         * cli/cli-cmds.h: Rename include guard.
2279         * charset-list.h: Add include guard.
2280         * buildsym-legacy.h: Rename include guard.
2281         * bfin-tdep.h: Add include guard.
2282         * ax.h: Rename include guard.
2283         * arm-linux-tdep.h: Add include guard.
2284         * arm-fbsd-tdep.h: Add include guard.
2285         * arch/xtensa.h: Rename include guard.
2286         * arch/tic6x.h: Add include guard.
2287         * arch/i386.h: Add include guard.
2288         * arch/arm.h: Rename include guard.
2289         * arch/arm-linux.h: Rename include guard.
2290         * arch/arm-get-next-pcs.h: Rename include guard.
2291         * arch/amd64.h: Add include guard.
2292         * arch/aarch64-insn.h: Rename include guard.
2293         * arch-utils.h: Rename include guard.
2294         * annotate.h: Add include guard.
2295         * amd64-darwin-tdep.h: Rename include guard.
2296         * aarch64-linux-tdep.h: Add include guard.
2297         * aarch64-fbsd-tdep.h: Add include guard.
2298         * aarch32-linux-nat.h: Add include guard.
2299
2300 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2301
2302         * macrotab.c (macro_define_internal): New function that
2303         factorizes macro_define_object_internal and macro_define_function
2304         code.
2305         (macro_define_object_internal): Use macro_define_internal.
2306         (macro_define_function): Likewise.
2307
2308 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2309
2310         * macrocmd.c (extract_identifier): Return
2311         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2312         callers.
2313
2314 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2315
2316         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2317
2318 2019-02-05  Tom Tromey  <tom@tromey.com>
2319
2320         * target.c (target_stack::unpush): Move assertion earlier.
2321
2322 2019-01-30  Tom Tromey  <tom@tromey.com>
2323
2324         PR python/23615:
2325         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2326         (gdbpy_parse_and_eval): Likewise.
2327         * python/python-internal.h (gdbpy_allow_threads): New class.
2328
2329 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2330
2331         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2332         (aarch64_fbsd_fpregmap): Move earlier.
2333         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2334         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2335         instead of individual calls to trad_frame_set_reg_addr.
2336         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2337         earlier.
2338         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2339         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2340         instead of individual calls to trad_frame_set_reg_addr.
2341
2342 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2343
2344         * CONTRIBUTE: Replace contribution list with wiki link.
2345
2346 2019-01-25  Tom Tromey  <tom@tromey.com>
2347
2348         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2349
2350 2019-01-25  Tom Tromey  <tom@tromey.com>
2351
2352         * xtensa-linux-nat.c: Fix common/ includes.
2353         * xml-support.h: Fix common/ includes.
2354         * xml-support.c: Fix common/ includes.
2355         * x86-linux-nat.c: Fix common/ includes.
2356         * windows-nat.c: Fix common/ includes.
2357         * varobj.h: Fix common/ includes.
2358         * varobj.c: Fix common/ includes.
2359         * value.c: Fix common/ includes.
2360         * valops.c: Fix common/ includes.
2361         * utils.c: Fix common/ includes.
2362         * unittests/xml-utils-selftests.c: Fix common/ includes.
2363         * unittests/utils-selftests.c: Fix common/ includes.
2364         * unittests/unpack-selftests.c: Fix common/ includes.
2365         * unittests/tracepoint-selftests.c: Fix common/ includes.
2366         * unittests/style-selftests.c: Fix common/ includes.
2367         * unittests/string_view-selftests.c: Fix common/ includes.
2368         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2369         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2370         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2371         * unittests/rsp-low-selftests.c: Fix common/ includes.
2372         * unittests/parse-connection-spec-selftests.c: Fix common/
2373         includes.
2374         * unittests/optional-selftests.c: Fix common/ includes.
2375         * unittests/offset-type-selftests.c: Fix common/ includes.
2376         * unittests/observable-selftests.c: Fix common/ includes.
2377         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2378         * unittests/memrange-selftests.c: Fix common/ includes.
2379         * unittests/memory-map-selftests.c: Fix common/ includes.
2380         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2381         * unittests/function-view-selftests.c: Fix common/ includes.
2382         * unittests/environ-selftests.c: Fix common/ includes.
2383         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2384         * unittests/common-utils-selftests.c: Fix common/ includes.
2385         * unittests/cli-utils-selftests.c: Fix common/ includes.
2386         * unittests/array-view-selftests.c: Fix common/ includes.
2387         * ui-file.c: Fix common/ includes.
2388         * tui/tui-io.c: Fix common/ includes.
2389         * tracepoint.h: Fix common/ includes.
2390         * tracepoint.c: Fix common/ includes.
2391         * tracefile-tfile.c: Fix common/ includes.
2392         * top.h: Fix common/ includes.
2393         * top.c: Fix common/ includes.
2394         * thread.c: Fix common/ includes.
2395         * target/waitstatus.h: Fix common/ includes.
2396         * target/waitstatus.c: Fix common/ includes.
2397         * target.h: Fix common/ includes.
2398         * target.c: Fix common/ includes.
2399         * target-memory.c: Fix common/ includes.
2400         * target-descriptions.c: Fix common/ includes.
2401         * symtab.h: Fix common/ includes.
2402         * symfile.c: Fix common/ includes.
2403         * stap-probe.c: Fix common/ includes.
2404         * spu-linux-nat.c: Fix common/ includes.
2405         * sparc-nat.c: Fix common/ includes.
2406         * source.c: Fix common/ includes.
2407         * solib.c: Fix common/ includes.
2408         * solib-target.c: Fix common/ includes.
2409         * ser-unix.c: Fix common/ includes.
2410         * ser-tcp.c: Fix common/ includes.
2411         * ser-pipe.c: Fix common/ includes.
2412         * ser-base.c: Fix common/ includes.
2413         * selftest-arch.c: Fix common/ includes.
2414         * s12z-tdep.c: Fix common/ includes.
2415         * rust-exp.y: Fix common/ includes.
2416         * rs6000-aix-tdep.c: Fix common/ includes.
2417         * riscv-tdep.c: Fix common/ includes.
2418         * remote.c: Fix common/ includes.
2419         * remote-notif.h: Fix common/ includes.
2420         * remote-fileio.h: Fix common/ includes.
2421         * remote-fileio.c: Fix common/ includes.
2422         * regcache.h: Fix common/ includes.
2423         * regcache.c: Fix common/ includes.
2424         * record-btrace.c: Fix common/ includes.
2425         * python/python.c: Fix common/ includes.
2426         * python/py-type.c: Fix common/ includes.
2427         * python/py-inferior.c: Fix common/ includes.
2428         * progspace.h: Fix common/ includes.
2429         * producer.c: Fix common/ includes.
2430         * procfs.c: Fix common/ includes.
2431         * proc-api.c: Fix common/ includes.
2432         * printcmd.c: Fix common/ includes.
2433         * ppc-linux-nat.c: Fix common/ includes.
2434         * parser-defs.h: Fix common/ includes.
2435         * osdata.c: Fix common/ includes.
2436         * obsd-nat.c: Fix common/ includes.
2437         * nat/x86-linux.c: Fix common/ includes.
2438         * nat/x86-linux-dregs.c: Fix common/ includes.
2439         * nat/x86-dregs.h: Fix common/ includes.
2440         * nat/x86-dregs.c: Fix common/ includes.
2441         * nat/ppc-linux.c: Fix common/ includes.
2442         * nat/mips-linux-watch.h: Fix common/ includes.
2443         * nat/mips-linux-watch.c: Fix common/ includes.
2444         * nat/linux-waitpid.c: Fix common/ includes.
2445         * nat/linux-ptrace.h: Fix common/ includes.
2446         * nat/linux-ptrace.c: Fix common/ includes.
2447         * nat/linux-procfs.c: Fix common/ includes.
2448         * nat/linux-personality.c: Fix common/ includes.
2449         * nat/linux-osdata.c: Fix common/ includes.
2450         * nat/linux-namespaces.c: Fix common/ includes.
2451         * nat/linux-btrace.h: Fix common/ includes.
2452         * nat/linux-btrace.c: Fix common/ includes.
2453         * nat/fork-inferior.c: Fix common/ includes.
2454         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2455         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2456         * nat/aarch64-linux.c: Fix common/ includes.
2457         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2458         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2459         * namespace.h: Fix common/ includes.
2460         * mips-linux-tdep.c: Fix common/ includes.
2461         * minsyms.c: Fix common/ includes.
2462         * mi/mi-parse.h: Fix common/ includes.
2463         * mi/mi-main.c: Fix common/ includes.
2464         * mi/mi-cmd-env.c: Fix common/ includes.
2465         * memrange.h: Fix common/ includes.
2466         * memattr.c: Fix common/ includes.
2467         * maint.h: Fix common/ includes.
2468         * maint.c: Fix common/ includes.
2469         * main.c: Fix common/ includes.
2470         * machoread.c: Fix common/ includes.
2471         * location.c: Fix common/ includes.
2472         * linux-thread-db.c: Fix common/ includes.
2473         * linux-nat.c: Fix common/ includes.
2474         * linux-fork.c: Fix common/ includes.
2475         * inline-frame.c: Fix common/ includes.
2476         * infrun.c: Fix common/ includes.
2477         * inflow.c: Fix common/ includes.
2478         * inferior.h: Fix common/ includes.
2479         * inferior.c: Fix common/ includes.
2480         * infcmd.c: Fix common/ includes.
2481         * inf-ptrace.c: Fix common/ includes.
2482         * inf-child.c: Fix common/ includes.
2483         * ia64-linux-nat.c: Fix common/ includes.
2484         * i387-tdep.c: Fix common/ includes.
2485         * i386-tdep.c: Fix common/ includes.
2486         * i386-linux-tdep.c: Fix common/ includes.
2487         * i386-linux-nat.c: Fix common/ includes.
2488         * i386-go32-tdep.c: Fix common/ includes.
2489         * i386-fbsd-tdep.c: Fix common/ includes.
2490         * i386-fbsd-nat.c: Fix common/ includes.
2491         * guile/scm-type.c: Fix common/ includes.
2492         * guile/guile.c: Fix common/ includes.
2493         * go32-nat.c: Fix common/ includes.
2494         * gnu-nat.c: Fix common/ includes.
2495         * gdbthread.h: Fix common/ includes.
2496         * gdbarch-selftests.c: Fix common/ includes.
2497         * gdb_usleep.c: Fix common/ includes.
2498         * gdb_select.h: Fix common/ includes.
2499         * gdb_bfd.c: Fix common/ includes.
2500         * gcore.c: Fix common/ includes.
2501         * fork-child.c: Fix common/ includes.
2502         * findvar.c: Fix common/ includes.
2503         * fbsd-nat.c: Fix common/ includes.
2504         * event-top.c: Fix common/ includes.
2505         * event-loop.c: Fix common/ includes.
2506         * dwarf2read.c: Fix common/ includes.
2507         * dwarf2loc.c: Fix common/ includes.
2508         * dwarf2-frame.c: Fix common/ includes.
2509         * dwarf-index-cache.c: Fix common/ includes.
2510         * dtrace-probe.c: Fix common/ includes.
2511         * disasm-selftests.c: Fix common/ includes.
2512         * defs.h: Fix common/ includes.
2513         * csky-tdep.c: Fix common/ includes.
2514         * cp-valprint.c: Fix common/ includes.
2515         * cp-support.h: Fix common/ includes.
2516         * cp-support.c: Fix common/ includes.
2517         * corelow.c: Fix common/ includes.
2518         * completer.h: Fix common/ includes.
2519         * completer.c: Fix common/ includes.
2520         * compile/compile.c: Fix common/ includes.
2521         * compile/compile-loc2c.c: Fix common/ includes.
2522         * compile/compile-cplus-types.c: Fix common/ includes.
2523         * compile/compile-cplus-symbols.c: Fix common/ includes.
2524         * command.h: Fix common/ includes.
2525         * cli/cli-dump.c: Fix common/ includes.
2526         * cli/cli-cmds.c: Fix common/ includes.
2527         * charset.c: Fix common/ includes.
2528         * build-id.c: Fix common/ includes.
2529         * btrace.h: Fix common/ includes.
2530         * btrace.c: Fix common/ includes.
2531         * breakpoint.h: Fix common/ includes.
2532         * breakpoint.c: Fix common/ includes.
2533         * ax.h:
2534         (enum agent_op): Fix common/ includes.
2535         * ax-general.c (struct aop_map): Fix common/ includes.
2536         * ax-gdb.c: Fix common/ includes.
2537         * auxv.c: Fix common/ includes.
2538         * auto-load.c: Fix common/ includes.
2539         * arm-tdep.c: Fix common/ includes.
2540         * arch/riscv.c: Fix common/ includes.
2541         * arch/ppc-linux-common.c: Fix common/ includes.
2542         * arch/i386.c: Fix common/ includes.
2543         * arch/arm.c: Fix common/ includes.
2544         * arch/arm-linux.c: Fix common/ includes.
2545         * arch/arm-get-next-pcs.c: Fix common/ includes.
2546         * arch/amd64.c: Fix common/ includes.
2547         * arch/aarch64.c: Fix common/ includes.
2548         * arch/aarch64-insn.c: Fix common/ includes.
2549         * arch-utils.c: Fix common/ includes.
2550         * amd64-windows-tdep.c: Fix common/ includes.
2551         * amd64-tdep.c: Fix common/ includes.
2552         * amd64-sol2-tdep.c: Fix common/ includes.
2553         * amd64-obsd-tdep.c: Fix common/ includes.
2554         * amd64-nbsd-tdep.c: Fix common/ includes.
2555         * amd64-linux-tdep.c: Fix common/ includes.
2556         * amd64-linux-nat.c: Fix common/ includes.
2557         * amd64-fbsd-tdep.c: Fix common/ includes.
2558         * amd64-fbsd-nat.c: Fix common/ includes.
2559         * amd64-dicos-tdep.c: Fix common/ includes.
2560         * amd64-darwin-tdep.c: Fix common/ includes.
2561         * agent.c: Fix common/ includes.
2562         * ada-lang.h: Fix common/ includes.
2563         * ada-lang.c: Fix common/ includes.
2564         * aarch64-tdep.c: Fix common/ includes.
2565
2566 2019-01-25  Tom Tromey  <tom@tromey.com>
2567
2568         * common/create-version.sh: Use common/version.h.
2569
2570 2019-01-24  Pedro Alves  <palves@redhat.com>
2571
2572         * infrun.c (signal_stop, signal_print, signal_program)
2573         (signal_catch, signal_pass): Now arrays instead of pointers.
2574         (update_signals_program_target, do_target_resume)
2575         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2576         * linux-nat.c (linux_nat_target::pass_signals)
2577         (linux_nat_target::create_inferior, linux_nat_target::attach):
2578         Adjust.
2579         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2580         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2581         * procfs.c (procfs_target::pass_signals): Adjust.
2582         * record-full.c (record_full_target::resume): Adjust.
2583         * remote.c (remote_target::pass_signals)
2584         (remote_target::program_signals): Adjust.
2585         * target-debug.h (target_debug_print_signals): Now takes a
2586         gdb::array_view as parameter.  Adjust.
2587         * target.h (target_ops) <pass_signals, program_signals>: Replace
2588         pointer and length parameters with gdb::array_view.
2589         (target_pass_signals, target_program_signals): Likewise.
2590         * target-delegates.c: Regenerate.
2591
2592 2019-01-24  Pedro Alves  <palves@redhat.com>
2593
2594         * common/forward-scope-exit.h
2595         (forward_scope_exit::forward_scope_exit): Pass arguments to
2596         m_bind_function directly, instead of creating a std::bind and
2597         copying that.
2598
2599 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2602         for static members.
2603         (pass_in_v_vfp_candidate): Likewise.
2604
2605 2019-01-23  Tom Tromey  <tom@tromey.com>
2606             Pedro Alves  <palves@redhat.com>
2607
2608         * regcache.c (class regcache_invalidator): Remove.
2609         (regcache::raw_write): Use make_scope_exit.
2610
2611 2019-01-23  Tom Tromey  <tom@tromey.com>
2612
2613         * ui-out.h (class ui_out_emit_type): Update comment.
2614
2615 2019-01-23  Tom Tromey  <tom@tromey.com>
2616
2617         * infrun.c (fetch_inferior_event): Update comment.
2618
2619 2019-01-23  Tom Tromey  <tom@tromey.com>
2620             Pedro Alves  <palves@redhat.com>
2621
2622         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2623         parameter.
2624         (fetch_inferior_event): Use SCOPE_EXIT.
2625
2626
2627 2019-01-23  Tom Tromey  <tom@tromey.com>
2628             Pedro Alves  <palves@redhat.com>
2629
2630         * infrun.c (disable_thread_events): Delete.
2631         (stop_all_threads): Use SCOPE_EXIT.
2632
2633 2019-01-23  Tom Tromey  <tom@tromey.com>
2634             Pedro Alves  <palves@redhat.com>
2635
2636         * symfile.c: Include forward-scope-exit.h.
2637         (clear_symtab_users_cleanup): Replace forward declaration with
2638         a FORWARD_SCOPE_EXIT.
2639         (syms_from_objfile_1): Use the forward_scope_exit and
2640         gdb::optional instead of cleanup_function.
2641         (reread_symbols): Use the forward_scope_exit instead of
2642         cleanup_function.
2643         (clear_symtab_users_cleanup): Remove function.
2644
2645 2019-01-23  Tom Tromey  <tom@tromey.com>
2646             Pedro Alves  <palves@redhat.com>
2647
2648         * linux-nat.c: Include scope-exit.h.
2649         (cleanup_target_stop): Remove.
2650         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2651         SCOPE_EXIT.
2652
2653 2019-01-23  Tom Tromey  <tom@tromey.com>
2654             Pedro Alves  <palves@redhat.com>
2655
2656         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2657         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2658
2659 2019-01-23  Tom Tromey  <tom@tromey.com>
2660             Andrew Burgess  <andrew.burgess@embecosm.com>
2661             Pedro Alves  <palves@redhat.com>
2662
2663         * infrun.c (fetch_inferior_event): Use scope_exit.
2664         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2665         * top.c (execute_command): Use scope_exit.
2666         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2667         * utils.c (do_bpstat_clear_actions_cleanup)
2668         (make_bpstat_clear_actions_cleanup): Remove.
2669
2670 2019-01-23  Tom Tromey  <tom@tromey.com>
2671             Pedro Alves  <palves@redhat.com>
2672
2673         * infrun.c: Include "common/scope-exit.h"
2674         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2675         (wait_for_inferior): Use SCOPE_EXIT.
2676         (fetch_inferior_event): Use scope_exit.
2677
2678 2019-01-23  Tom Tromey  <tom@tromey.com>
2679             Pedro Alves  <palves@redhat.com>
2680
2681         * breakpoint.c (create_breakpoint): Remove cleanup.
2682
2683 2019-01-23  Tom Tromey  <tom@tromey.com>
2684             Andrew Burgess  <andrew.burgess@embecosm.com>
2685             Pedro Alves  <palves@redhat.com>
2686
2687 2019-01-23  Pedro Alves  <palves@redhat.com>
2688
2689         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2690
2691 2019-01-23  Pedro Alves  <palves@redhat.com>
2692             Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * gdbthread.h: Include "common/forward-scope-exit.h".
2695         (scoped_finish_thread_state): Redefine custom class in terms of
2696         forward_scope_exit.
2697
2698 2019-01-23  Pedro Alves  <palves@redhat.com>
2699             Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * common/forward-scope-exit.h: New file.
2702
2703 2019-01-23  Pedro Alves  <palves@redhat.com>
2704             Andrew Burgess  <andrew.burgess@embecosm.com>
2705             Tom Tromey  <tom@tromey.com>
2706
2707         * common/scope-exit.h: New file.
2708
2709 2019-01-23  Pedro Alves  <palves@redhat.com>
2710
2711         * common/preprocessor.h (ESC): Rename to ...
2712         (ESC_PARENS): ... this.
2713         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2714         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2715
2716 2019-01-23  Tom Tromey  <tom@tromey.com>
2717
2718         * language.h (class scoped_switch_to_sym_language_if_auto):
2719         Initialize m_lang in both cases.
2720
2721 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2722
2723         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2724         with XCNEW.
2725
2726 2019-01-22  Tom Tromey  <tom@tromey.com>
2727
2728         * corelow.c: Do not include sys/file.h.
2729
2730 2019-01-22  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-wingeneral.h: Include gdb_curses.h.
2733
2734 2019-01-22  Tom Tromey  <tom@tromey.com>
2735
2736         * source-cache.h (class source_cache) <get_source_lines,
2737         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2738
2739 2019-01-22  Tom Tromey  <tom@tromey.com>
2740
2741         * remote-fileio.h (struct remote_target): Declare.
2742
2743 2019-01-22  Tom Tromey  <tom@tromey.com>
2744
2745         * python/py-arch.c: Do not include py-ref.h.
2746         * python/py-bpevent.c: Do not include py-ref.h.
2747         * python/py-cmd.c: Do not include py-ref.h.
2748         * python/py-continueevent.c: Do not include py-ref.h.
2749         * python/py-event.h: Do not include py-ref.h.
2750         * python/py-evtregistry.c: Do not include py-ref.h.
2751         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2752         * python/py-frame.c: Do not include py-ref.h.
2753         * python/py-framefilter.c: Do not include py-ref.h.
2754         * python/py-function.c: Do not include py-ref.h.
2755         * python/py-infevents.c: Do not include py-ref.h.
2756         * python/py-linetable.c: Do not include py-ref.h.
2757         * python/py-objfile.c: Do not include py-ref.h.
2758         * python/py-param.c: Do not include py-ref.h.
2759         * python/py-prettyprint.c: Do not include py-ref.h.
2760         * python/py-progspace.c: Do not include py-ref.h.
2761         * python/py-symbol.c: Do not include py-ref.h.
2762         * python/py-symtab.c: Do not include py-ref.h.
2763         * python/py-type.c: Do not include py-ref.h.
2764         * python/py-unwind.c: Do not include py-ref.h.
2765         * python/py-utils.c: Do not include py-ref.h.
2766         * python/py-value.c: Do not include py-ref.h.
2767         * python/py-varobj.c: Do not include py-ref.h.
2768         * python/py-xmethods.c: Do not include py-ref.h.
2769         * python/python.c: Do not include py-ref.h.
2770         * varobj.c: Do not include py-ref.h.
2771
2772 2019-01-22  Tom Tromey  <tom@tromey.com>
2773
2774         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2775         keyword for bcache.
2776
2777 2019-01-22  Tom Tromey  <tom@tromey.com>
2778
2779         * compile/compile-cplus-types.c: Remove a comment by #include.
2780
2781 2019-01-22  Tom Tromey  <tom@tromey.com>
2782
2783         * compile/gcc-c-plugin.h: Include compile-internal.h.
2784
2785 2019-01-22  Tom Tromey  <tom@tromey.com>
2786
2787         * stabsread.c (EXTERN): Do not define.
2788         (symnum, next_symbol_text_func, processing_gcc_compilation)
2789         (within_function, global_sym_chain, global_stabs)
2790         (previous_stab_code, this_object_header_files)
2791         (n_this_object_header_files)
2792         (n_allocated_this_object_header_files): Define.
2793         * stabsread.h (EXTERN): Never define.  Use "extern".
2794
2795 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2796
2797         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2798         history_value.
2799
2800 2019-01-21  Tom Tromey  <tom@tromey.com>
2801
2802         * ui-out.c: Fix includes.
2803         * tui/tui-source.c: Fix includes.
2804         * target.c: Fix includes.
2805         * remote.c: Fix includes.
2806         * regcache.c: Fix includes.
2807         * python/py-block.c: Fix includes.
2808         * printcmd.c: Fix includes.
2809         * or1k-tdep.c: Fix includes.
2810         * mi/mi-main.c: Fix includes.
2811         * m32r-tdep.c: Fix includes.
2812         * csky-tdep.c: Fix includes.
2813         * compile/compile-cplus-types.c: Fix includes.
2814         * cli/cli-interp.c: Fix includes.
2815
2816 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2817
2818         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2819         for padding.
2820
2821 2019-01-16  Tom Tromey  <tom@tromey.com>
2822
2823         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2824         earlier.
2825         (struct objfile) <msymbols_range>: Move from top level.
2826         <msymbols>: New method.
2827         (class objfile_msymbols): Remove.
2828         * symtab.c (default_collect_symbol_completion_matches_break_on):
2829         Update.
2830         * symmisc.c (dump_msymbols): Update.
2831         * stabsread.c (scan_file_globals): Update.
2832         * objc-lang.c (info_selectors_command, info_classes_command)
2833         (find_methods): Update.
2834         * minsyms.c (find_solib_trampoline_target): Update.
2835         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2836         * coffread.c (coff_symfile_read): Update.
2837         * ada-lang.c (ada_lookup_simple_minsym)
2838         (ada_collect_symbol_completion_matches): Update.
2839
2840 2019-01-16  Tom Tromey  <tom@tromey.com>
2841
2842         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2843         type.  Remove no-argument constructor.
2844         <iterator::operator++>: Simplify.
2845         <begin>: Update.
2846         <end>: Use minimal_symbol_count.
2847
2848 2019-01-16  Tom Tromey  <tom@tromey.com>
2849
2850         * objfiles.h (struct objfile) <psymtabs>: New method.
2851         (class objfile_psymtabs): Remove.
2852         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2853         typedef.
2854         <range>: New method.
2855         (require_partial_symbols): Change return type.
2856         * psymtab.c (require_partial_symbols)
2857         (psym_expand_symtabs_matching): Update.
2858         * mdebugread.c (parse_partial_symbols): Update.
2859         * dbxread.c (dbx_end_psymtab): Update.
2860
2861 2019-01-15  Tom Tromey  <tom@tromey.com>
2862
2863         * symtab.c (lookup_objfile_from_block)
2864         (lookup_symbol_in_objfile_symtabs)
2865         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2866         (find_line_symtab, info_sources_command)
2867         (default_collect_symbol_completion_matches_break_on)
2868         (make_source_files_completion_list): Update.
2869         * symmisc.c (print_objfile_statistics, dump_objfile)
2870         (maintenance_print_symbols, maintenance_info_symtabs)
2871         (maintenance_check_symtabs, maintenance_info_line_tables):
2872         Update.
2873         * source.c (select_source_symtab)
2874         (forget_cached_source_info_for_objfile): Update.
2875         * objfiles.h (class objfile_compunits): Remove.
2876         (struct objfile) <compunits_range>: New typedef.
2877         (compunits): New method.
2878         * objfiles.c (objfile_relocate1): Update.
2879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2880         * maint.c (count_symtabs_and_blocks): Update.
2881         * linespec.c (iterate_over_all_matching_symtabs): Update.
2882         * cp-support.c (add_symbol_overload_list_qualified): Update.
2883         * coffread.c (coff_symtab_read): Update.
2884         * ada-lang.c (add_nonlocal_symbols)
2885         (ada_collect_symbol_completion_matches)
2886         (ada_add_global_exceptions): Update.
2887
2888 2019-01-15  Tom Tromey  <tom@tromey.com>
2889
2890         * progspace.h (program_space) <objfiles_safe_range>: New
2891         typedef.
2892         <objfiles_safe>: New method.
2893         * objfiles.h (class all_objfiles_safe): Remove.
2894         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2895         * jit.c (jit_inferior_exit_hook): Update.
2896
2897 2019-01-17  Tom Tromey  <tom@tromey.com>
2898
2899         * progspace.h (program_space) <objfiles_range>: New typedef.
2900         <objfiles>: New method.
2901         <objfiles_head>: Rename from objfiles.
2902         (object_files): Update.
2903         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2904         * guile/scm-pretty-print.c
2905         (ppscm_find_pretty_printer_from_objfiles): Update.
2906         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2907         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2908         Update.
2909         * python/py-progspace.c (pspy_get_objfiles): Update.
2910         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2911         Update.
2912         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2913         (objfpy_lookup_objfile_by_build_id): Update.
2914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2915         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2916         Update.
2917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2918         (expand_symtab_containing_pc, lookup_objfile_from_block)
2919         (lookup_static_symbol, basic_lookup_transparent_type)
2920         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2921         (find_line_symtab, info_sources_command)
2922         (default_collect_symbol_completion_matches_break_on)
2923         (make_source_files_completion_list, find_main_name): Update.
2924         * symmisc.c (print_symbol_bcache_statistics)
2925         (print_objfile_statistics, maintenance_print_symbols)
2926         (maintenance_print_msymbols, maintenance_print_objfiles)
2927         (maintenance_info_symtabs, maintenance_check_symtabs)
2928         (maintenance_expand_symtabs, maintenance_info_line_tables):
2929         Update.
2930         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2931         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2932         (map_overlay_command, unmap_overlay_command)
2933         (simple_overlay_update, expand_symtabs_matching)
2934         (map_symbol_filenames): Update.
2935         * symfile-debug.c (set_debug_symfile): Update.
2936         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2937         Update.
2938         * source.c (select_source_symtab, forget_cached_source_info):
2939         Update.
2940         * solib.c (solib_read_symbols): Update.
2941         * solib-spu.c (append_ocl_sos): Update.
2942         * psymtab.c (maintenance_print_psymbols)
2943         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2944         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2945         * printcmd.c (info_symbol_command): Update.
2946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2947         Update.
2948         * objfiles.h (class all_objfiles): Remove.
2949         * objfiles.c (have_partial_symbols, have_full_symbols)
2950         (have_minimal_symbols, qsort_cmp, update_section_map)
2951         (shared_objfile_contains_address_p)
2952         (default_iterate_over_objfiles_in_search_order): Update.
2953         * objc-lang.c (info_selectors_command, info_classes_command)
2954         (find_methods): Update.
2955         * minsyms.c (find_solib_trampoline_target): Update.
2956         * maint.c (maintenance_info_sections)
2957         (maintenance_translate_address, count_symtabs_and_blocks):
2958         Update.
2959         * main.c (captured_main_1): Update.
2960         * linux-thread-db.c (try_thread_db_load_from_pdir)
2961         (has_libpthread): Update.
2962         * linespec.c (iterate_over_all_matching_symtabs)
2963         (search_minsyms_for_name): Update.
2964         * jit.c (jit_find_objf_with_entry_addr): Update.
2965         * hppa-tdep.c (find_unwind_entry)
2966         (hppa_lookup_stub_minimal_symbol): Update.
2967         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2968         Update.
2969         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2970         (elf_gnu_ifunc_resolve_by_got): Update.
2971         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2972         * dwarf-index-write.c (save_gdb_index_command): Update.
2973         * cp-support.c (add_symbol_overload_list_qualified): Update.
2974         * breakpoint.c (create_overlay_event_breakpoint)
2975         (create_longjmp_master_breakpoint)
2976         (create_std_terminate_master_breakpoint)
2977         (create_exception_master_breakpoint): Update.
2978         * blockframe.c (find_pc_partial_function): Update.
2979         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2980         (ada_collect_symbol_completion_matches)
2981         (ada_add_global_exceptions): Update.
2982
2983 2019-01-17  Tom Tromey  <tom@tromey.com>
2984
2985         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2986         declare VEC.
2987         (solib_target_parse_libraries): Change return type.
2988         (library_list_start_segment, library_list_start_section)
2989         (library_list_end_library, library_list_start_library); Update.
2990         (solib_target_free_library_list): Remove.
2991         (solib_target_parse_libraries): Remove cleanup.  Change return
2992         type.
2993         (solib_target_current_sos): Update.
2994
2995 2019-01-17  Tom Tromey  <tromey@bapiya>
2996
2997         * valprint.c: Replace "the the" with "the".
2998         * symtab.c: Replace "the the" with "the".
2999         * solib.c: Replace "the the" with "the".
3000         * solib-dsbt.c: Replace "the the" with "the".
3001         * linespec.c: Replace "the the" with "the".
3002         * dwarf2loc.h: Replace "the the" with "the".
3003         * amd64-windows-tdep.c: Replace "the the" with "the".
3004         * aarch64-tdep.c: Replace "the the" with "the".
3005
3006 2019-01-16  Keith Seitz  <keiths@redhat.com>
3007
3008         PR gdb/23773
3009         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3010         <builder>: Rename to ..
3011         <m_builder>: ... this and make private.
3012         (dwarf2_cu::get_builder): New method.  Change all users of
3013         `builder' to use this method.
3014         (dwarf2_start_symtab): Move to ...
3015         (dwarf2_cu::start_symtab): ... here.  Update all callers
3016         (setup_type_unit_groups): Move to ...
3017         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3018         callers.
3019         (dwarf2_cu::reset_builder): New method.
3020         (process_full_compunit, process_full_type_unit): Use
3021         dwarf2_cu::reset_builder.
3022         (follow_die_offset): Record the ancestor CU if it is different
3023         from the followed DIE's CU.
3024         (follow_die_sig_1): Likewise.
3025
3026 2019-01-15  Tom Tromey  <tom@tromey.com>
3027
3028         * remote.c (class remote_state) <buf>: Now a char_vector.
3029         <buf_size>: Remove.
3030         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3031         parameter.
3032         (remote_target::getpkt_or_notif_sane_1)
3033         (remote_target::getpkt_sane)
3034         (remote_target::getpkt_or_notif_sane): Likewise.
3035         (class remote_target) <putpkt>: New overload.
3036         (remote_target::read_frame): Change type of "buf_p".  Remove
3037         sizeof_p parameter.
3038         (packet_ok): New overload.
3039         (packet_check_result): New overload.
3040         Update all uses.
3041
3042 2019-01-14  Tom Tromey  <tom@tromey.com>
3043
3044         * remote-notif.c (handle_notification, remote_notif_ack)
3045         (remote_notif_parse): Make "buf" const.
3046         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3047         const.
3048         (remote_notif_parse, remote_notif_ack, handle_notification):
3049         Likewise.
3050         * remote.c (remote_notif_stop_parse): Make "buf" const.
3051         (remote_target::remote_parse_stop_reply): Make "buf" const.
3052         (remote_notif_stop_ack): Make "buf" const.
3053
3054 2019-01-14  Tom Tromey  <tom@tromey.com>
3055
3056         * remote.c (remote_console_output): Make parameter const.
3057
3058 2019-01-14  Tom Tromey  <tom@tromey.com>
3059
3060         * target-debug.h (target_debug_print_signals): Constify.
3061         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3062         * procfs.c (procfs_target::pass_signals): Update.
3063         * linux-nat.c (linux_nat_target::pass_signals): Update.
3064         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3065         * target-delegates.c: Rebuild.
3066         * remote.c (remote_target::program_signals): Update.
3067         (remote_target::pass_signals): Update.
3068         * target.c (target_pass_signals): Constify argument.
3069         (target_program_signals): Likewise.
3070         * target.h (struct target_ops) <pass_signals, program_signals>:
3071         Constify argument.
3072         (target_pass_signals, target_program_signals): Constify argument.
3073
3074 2019-01-14  Tom Tromey  <tom@tromey.com>
3075
3076         PR tui/28819:
3077         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3078
3079 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3080
3081         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3082         field.
3083         * rs6000-tdep.c: Include reggroups.h.
3084         (IS_V_ALIAS_PSEUDOREG): Define.
3085         (rs6000_register_name): Return names for the "vX" aliases.
3086         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3087         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3088         aliases.  Call default_register_reggroup_p for all other
3089         pseudo-registers.
3090         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3091         New functions.
3092         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3093         Handle "vX" aliases.
3094         (v_alias_pseudo_register_collect): New function.
3095         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3096         (rs6000_gdbarch_init): Initialize "vX" aliases as
3097         pseudo-registers.  Restore registration of
3098         rs6000_pseudo_register_reggroup_p with
3099         set_tdesc_pseudo_register_reggroup_p.
3100
3101 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3102
3103         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3104         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3105         set_gdbarch_num_pseudo_regs.
3106
3107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3108
3109         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3110         Remove arg prefixname, add do_set and do_show.
3111         Add member functions set_list and show_list.
3112         * cli/cli-style.c (class cli_style_option): Update accordingly.
3113         (style_set_list): Move to file scope.
3114         (style_show_list): Likewise.
3115         (set_style): Call help_list.
3116         (show_style): Call cmd_show_list.
3117         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3118         Update to use the new macro.
3119
3120 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3121
3122         * ada-lang.c (_initialize_ada_language): Expand the help text
3123         for the "catch exception" command.
3124
3125 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3126
3127         * symtab.c (matching_obj_sections): Initialize obj,
3128         declare it closer to its usage.
3129
3130 2019-01-10  Tom Tromey  <tom@tromey.com>
3131
3132         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3133         (basic_inf_threads_range): Remove.
3134         (inf_threads_range, inf_non_exited_threads_range)
3135         (safe_inf_threads_range): Use next_adapter.
3136
3137 2019-01-10  Keith Seitz  <keiths@redhat.com>
3138
3139         PR gdb/23712
3140         PR symtab/23010
3141         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3142         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3143
3144 2019-01-10  Keith Seitz  <keiths@redhat.com>
3145
3146         PR gdb/23712
3147         PR symtab/23010
3148         * dictionary.c (pending_to_vector): Remove.
3149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3150         Remove _1 suffix, replacing functions of the same name.  Update
3151         all callers.
3152         (dict_create_hashed, dict_create_hashed_expandable)
3153         (dict_create_linear, dict_create_linear_expandable, dict_free)
3154         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3155         Make functions static.
3156
3157 2019-01-10  Keith Seitz  <keiths@redhat.com>
3158
3159         PR gdb/23712
3160         PR symtab/23010
3161         * dictionary.h (struct dictionary): Replace declaration with
3162         multidictionary.
3163         (dict_create_hashed, dict_create_hashed_expandable)
3164         (dict_create_linear, dict_create_linear_expandable)
3165         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3166         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3167         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3168         taking multidictionary argument.
3169         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3170         * block.h (struct block) <dict>: Change to multidictionary
3171         and rename `multidict'.
3172         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3173         symmisc.c: Update all dictionary references to multidictionary.
3174
3175 2019-01-10  Keith Seitz  <keiths@redhat.com>
3176
3177         PR gdb/23712
3178         PR symtab/23010
3179         * dictionary.c: Include unordered_map.
3180         (pending_to_vector): New function.
3181         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3182         Rewrite the non-"_1" functions to take vector instead
3183         of linked list.
3184         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3185         "new" _1 versions of the same name.
3186         (multidictionary): Define.
3187         (std::hash<enum language): New definition.
3188         (collate_pending_symbols_by_language, mdict_create_hashed)
3189         (mdict_create_hashed_expandable, mdict_create_linear)
3190         (mdict_create_linear_expandable, mdict_free)
3191         (find_language_dictionary, create_new_language_dictionary)
3192         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3193         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3194         (mdict_size, mdict_empty): New functions.
3195         * dictionary.h (mdict_iterator): Define.
3196
3197 2019-01-10  Pedro Alves  <palves@redhat.com>
3198
3199         * breakpoint.c (read_uploaded_action)
3200         (create_tracepoint_from_upload): Adjust to use
3201         gdb::unique_xmalloc_ptr.
3202         * ctf.c (ctf_write_uploaded_tp):
3203         (SET_ARRAY_FIELD): Use emplace_back.
3204         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3205         * tracefile-tfile.c (tfile_write_uploaded_tp):
3206         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3207         gdb::unique_xmalloc_ptr.
3208         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3209         at_string, cond_string, cmd_strings>: Replace char pointers
3210         with gdb::unique_xmalloc_ptr.
3211
3212 2019-01-10  Pedro Alves  <palves@redhat.com>
3213
3214         * solib-target.c (library_list_start_library): Don't xstrdup name.
3215
3216 2019-01-10  Pedro Alves  <palves@redhat.com>
3217
3218         * mdebugread.c (parse_partial_symbols): Use
3219         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3220
3221 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3222
3223         * linux-fork.c (scoped_switch_fork_info)
3224         <~scoped_switch_fork_info>: Fix incorrect variable name.
3225
3226 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * linux-fork.c (scoped_switch_fork_info)
3229         <scoped_switch_fork_info>: Make explicit.
3230         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3231
3232 2019-01-10  Tom Tromey  <tom@tromey.com>
3233
3234         * objfiles.h (objfile::reset_psymtabs): Update.
3235         * objfiles.c (objfile::objfile): Update.
3236         * psymtab.h (psymtab_storage::obstack): Update.
3237         (psymtab_storage::m_obstack): Use gdb::optional.
3238         (class psymtab_storage): Update comment.  Remove objfile
3239         parameter.
3240         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3241
3242 2019-01-10  Tom Tromey  <tom@tromey.com>
3243
3244         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3245         <free_psymtabs>: Now private.
3246         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3247         (allocate_psymtab): Use new method.
3248
3249 2019-01-10  Tom Tromey  <tom@tromey.com>
3250
3251         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3252         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3253         * mdebugread.c (parse_partial_symbols): Use
3254         allocate_dependencies.
3255         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3256         allocate_dependencies.
3257         (process_psymtab_comp_unit_reader)
3258         (build_type_psymtab_dependencies): Likewise.
3259         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3260
3261 2019-01-10  Tom Tromey  <tom@tromey.com>
3262
3263         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3264         PSYMBOL_SET_LANGUAGE.
3265         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3266
3267 2019-01-10  Tom Tromey  <tom@tromey.com>
3268
3269         * psymtab.h (psymtab_storage::obstack): New method.
3270         <m_obstack>: Rename from obstack; now private.
3271         * psymtab.c (psymtab_storage): Update.
3272         * dwarf2read.c (create_addrmap_from_index)
3273         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3274         Update.
3275
3276 2019-01-10  Tom Tromey  <tom@tromey.com>
3277
3278         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3279         * objfiles.h (objfile::reset_psymtabs): New method.
3280
3281 2019-01-10  Tom Tromey  <tom@tromey.com>
3282
3283         * symmisc.c (print_symbol_bcache_statistics): Update.
3284         (print_objfile_statistics): Update.
3285         * symfile.c (reread_symbols): Update.
3286         * psymtab.h (class psymtab_storage): New.
3287         * psymtab.c (psymtab_storage): New constructor.
3288         (~psymtab_storage): New destructor.
3289         (require_partial_symbols): Update.
3290         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3291         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3292         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3293         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3294         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3295         (start_psymtab_common, end_psymtab_common)
3296         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3297         (allocate_psymtab): Update.
3298         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3299         Update.
3300         (dump_psymtab_addrmap, maintenance_print_psymbols)
3301         (maintenance_check_psymtabs): Update.
3302         (class objfile_psymtabs): Move to objfiles.h.
3303         * psympriv.h (discard_psymtab): Now inline.
3304         (psymtab_discarder::psymtab_discarder): Update.
3305         (psymtab_discarder::~psymtab_discarder): Update.
3306         (ALL_OBJFILE_PSYMTABS): Rewrite.
3307         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3308         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3309         Remove fields.
3310         <partial_symtabs>: New field.
3311         (class objfile_psymtabs): Move from psymtab.h.  Update.
3312         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3313         psymbol_cache.
3314         (objfile::~objfile): Don't destroy psymbol_cache.
3315         * mdebugread.c (parse_partial_symbols): Update.
3316         * dwarf2read.c (create_addrmap_from_index)
3317         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3318         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3319         (add_partial_subprogram, dwarf2_ranges_read): Update.
3320         * dwarf-index-write.c (write_address_map)
3321         (write_one_signatured_type, recursively_write_psymbols)
3322         (class debug_names, class debug_names, write_psymtabs_to_index):
3323         Update.
3324
3325 2019-01-10  Tom Tromey  <tom@tromey.com>
3326
3327         * symtab.h (SYMBOL_SET_NAMES): Update.
3328         (symbol_set_names): Update.
3329         (MSYMBOL_SET_NAMES): Update.
3330         * symtab.c (symbol_set_names): Change argument to be an
3331         objfile_per_bfd_storage.
3332         * psymtab.c (add_psymbol_to_bcache): Update.
3333         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3334
3335 2019-01-10  Tom Tromey  <tom@tromey.com>
3336
3337         * symtab.c (create_demangled_names_hash): Change argument to be an
3338         objfile_per_bfd_storage.
3339         (symbol_set_names): Update.
3340
3341 2019-01-10  Tom Tromey  <tom@tromey.com>
3342
3343         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3344         init_psymbol_list.
3345         * psymtab.c (init_psymbol_list): Do nothing if already called.
3346         * psympriv.h (init_psymbol_list): Add comment.
3347         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3348         init_psymbol_list.
3349         * dbxread.c (dbx_symfile_read): Unconditionally call
3350         init_psymbol_list.
3351
3352 2019-01-10  Tom Tromey  <tom@tromey.com>
3353
3354         * xcoffread.c (scan_xcoff_symtab): Update.
3355         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3356         "where".
3357         * mdebugread.c (parse_partial_symbols)
3358         (handle_psymbol_enumerators): Update.
3359         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3360         * dbxread.c (read_dbx_symtab): Update.
3361         * psympriv.h (psymbol_placement): New enum.
3362         (add_psymbol_to_list): Update.
3363
3364 2019-01-10  Tom Tromey  <tom@tromey.com>
3365
3366         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3367         static_psymbols parameters.
3368         (scan_xcoff_symtab): Update.
3369         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3370         static_psymbols parameters.
3371         * psympriv.h (start_psymtab_common): Update.
3372         * mdebugread.c (parse_partial_symbols): Update.
3373         * dwarf2read.c (create_partial_symtab): Update.
3374         * dbxread.c (read_dbx_symtab): Update.
3375         (start_psymtab): Remove global_psymbols and static_psymbols
3376         parameters.
3377
3378 2019-01-10  Tom Tromey  <tom@tromey.com>
3379
3380         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3381         * psymtab.c (allocate_psymtab): Add comment.
3382         * psympriv.h (allocate_psymtab): Add comment.
3383         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3384         initializations.
3385         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3386
3387 2019-01-10  Tom Tromey  <tom@tromey.com>
3388
3389         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3390         Don't declare.
3391         * mipsread.c: Include mdebugread.h.
3392         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3393         Declare.
3394         * elfread.c: Include mdebugread.h.
3395
3396 2019-01-09  Tom Tromey  <tom@tromey.com>
3397
3398         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3399         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3400         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3401         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3402         (psym_lookup_symbol, psym_find_last_source_symtab)
3403         (psym_forget_cached_source_info, psym_print_stats)
3404         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3405         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3406         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3407         (psym_find_compunit_symtab_by_address)
3408         (maintenance_print_psymbols, maintenance_info_psymtabs)
3409         (maintenance_check_psymtabs): Use ranged for.
3410         * psymtab.h (class objfile_psymtabs): New.
3411         (require_partial_symbols): Return objfile_psymtabs.
3412         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3413
3414 2019-01-09  Tom Tromey  <tom@tromey.com>
3415
3416         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3417         (find_pc_mapped_section, list_overlays_command)
3418         (map_overlay_command, unmap_overlay_command)
3419         (simple_overlay_update): Use all_objfiles.
3420         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3421         * printcmd.c (info_symbol_command): Use all_objfiles.
3422         * objfiles.h (ALL_OBJSECTIONS): Remove.
3423         * maint.c (maintenance_translate_address): Use all_objfiles.
3424         * gcore.c (gcore_create_callback): Use all_objfiles.
3425         (objfile_find_memory_regions): Likewise.
3426
3427 2019-01-09  Tom Tromey  <tom@tromey.com>
3428
3429         * symtab.c (find_line_symtab, info_sources_command)
3430         (make_source_files_completion_list): Use objfile_compunits.
3431         * source.c (select_source_symtab): Use objfile_compunits.
3432         * objfiles.h (struct objfile): Update comment.
3433         (ALL_OBJFILES): Remove.
3434         (ALL_FILETABS): Remove.
3435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3436         objfile_compunits.
3437
3438 2019-01-09  Tom Tromey  <tom@tromey.com>
3439
3440         * symmisc.c (print_objfile_statistics, dump_objfile)
3441         (maintenance_print_symbols): Use compunit_filetabs.
3442         * source.c (forget_cached_source_info_for_objfile): Use
3443         compunit_filetabs.
3444         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3445         (ALL_FILETABS): Use compunit_filetabs.
3446         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3447         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3448
3449 2019-01-09  Tom Tromey  <tom@tromey.com>
3450
3451         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3452         (compunit_filetabs): New.
3453         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3454         compunit_filetabs.
3455         (info_sources_command, make_source_files_completion_list): Remove
3456         declaration.
3457         * symmisc.c (print_objfile_statistics, dump_objfile)
3458         (maintenance_print_symbols): Remove declaration.
3459         (maintenance_info_symtabs): Use compunit_filetabs.
3460         (maintenance_info_line_tables): Likewise.
3461         * source.c (select_source_symtab): Change local variable name.
3462         (forget_cached_source_info_for_objfile): Remove declaration.
3463         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3464         * objfiles.c (objfile_relocate1): Remove declaration.
3465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3466         declaration.
3467         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3468         * coffread.c (coff_symtab_read): Remove declaration.
3469         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3470         compunit_filetabs.
3471
3472 2019-01-09  Tom Tromey  <tom@tromey.com>
3473
3474         * symtab.c (lookup_objfile_from_block)
3475         (find_pc_sect_compunit_symtab, search_symbols)
3476         (default_collect_symbol_completion_matches_break_on): Use
3477         objfile_compunits.
3478         * objfiles.h (ALL_COMPUNITS): Remove.
3479         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3480         * cp-support.c (add_symbol_overload_list_qualified): Use
3481         objfile_compunits.
3482         * ada-lang.c (ada_collect_symbol_completion_matches)
3483         (ada_add_global_exceptions): Use objfile_compunits.
3484
3485 2019-01-09  Tom Tromey  <tom@tromey.com>
3486
3487         * source.c (select_source_symtab)
3488         (forget_cached_source_info_for_objfile): Remove declaration.
3489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3490         declaration.
3491         * maint.c (count_symtabs_and_blocks): Remove declaration.
3492         * cp-support.c (add_symbol_overload_list_qualified): Remove
3493         declaration.
3494         * coffread.c (coff_symtab_read): Remove declaration.
3495         * symtab.c (lookup_symbol_in_objfile_symtabs)
3496         (basic_lookup_transparent_type_1): Use objfile_compunits.
3497         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3498         (info_sources_command, search_symbols)
3499         (default_collect_symbol_completion_matches_break_on)
3500         (make_source_files_completion_list): Remove declaration.
3501         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3502         (ada_collect_symbol_completion_matches)
3503         (ada_add_global_exceptions): Remove declaration.
3504         * linespec.c (iterate_over_all_matching_symtabs): Use
3505         objfile_compunits.
3506         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3507         (class objfile_compunits): New.
3508         (ALL_COMPUNITS): Use objfile_compunits.
3509         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3510         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3511         objfile_compunits.
3512         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3513
3514 2019-01-09  Tom Tromey  <tom@tromey.com>
3515
3516         * symtab.c (search_symbols)
3517         (default_collect_symbol_completion_matches_break_on): Use
3518         objfile_msymbols.
3519         * ada-lang.c (ada_lookup_simple_minsym)
3520         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3521         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3522         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3523         objfile_msymbols.
3524         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3525         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3526         * objc-lang.c (find_methods): Use objfile_msymbols.
3527         (info_selectors_command, info_classes_command): Likewise.
3528         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3529         * objfiles.h (class objfile_msymbols): New.
3530         (ALL_OBJFILE_MSYMBOLS): Remove.
3531         (ALL_MSYMBOLS): Remove.
3532
3533 2019-01-09  Tom Tromey  <tom@tromey.com>
3534
3535         * common/next-iterator.h (next_adapter): Add Iterator template
3536         parameter.
3537         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3538         (class all_objfiles_safe): New.
3539         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3540         * objfiles.c (put_objfile_before): Update comment.
3541         (add_separate_debug_objfile): Likewise.
3542         (free_all_objfiles): Use all_objfiles_safe.
3543         (objfile_purge_solibs): Likewise.
3544
3545 2019-01-09  Tom Tromey  <tom@tromey.com>
3546
3547         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3548         (expand_symtab_containing_pc, lookup_static_symbol)
3549         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3550         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3551         all_objfiles.
3552         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3553         * breakpoint.c (create_overlay_event_breakpoint)
3554         (create_longjmp_master_breakpoint)
3555         (create_std_terminate_master_breakpoint)
3556         (create_exception_master_breakpoint): Use all_objfiles.
3557         * linux-thread-db.c (try_thread_db_load_from_pdir)
3558         (has_libpthread): Use all_objfiles.
3559         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3560         * linespec.c (iterate_over_all_matching_symtabs)
3561         (search_minsyms_for_name): Use all_objfiles.
3562         * maint.c (maintenance_info_sections): Use all_objfiles.
3563         * main.c (captured_main_1): Use all_objfiles.
3564         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3565         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3566         * guile/scm-pretty-print.c
3567         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3568         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3569         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3570         (maintenance_print_msymbols): Use all_objfiles.
3571         * source.c (select_source_symtab): Use all_objfiles.
3572         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3573         * symfile.c (remove_symbol_file_command)
3574         (expand_symtabs_matching, map_symbol_filenames): Use
3575         all_objfiles.
3576         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3577         all_objfiles.
3578         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3579         * objc-lang.c (find_methods): Use all_objfiles.
3580         * objfiles.c (have_partial_symbols, have_full_symbols)
3581         (have_minimal_symbols, qsort_cmp)
3582         (default_iterate_over_objfiles_in_search_order): Use
3583         all_objfiles.
3584         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3585         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3586         (maintenance_check_psymtabs): Use all_objfiles.
3587         (ALL_PSYMTABS): Remove.
3588         * compile/compile-object-run.c (do_module_cleanup): Use
3589         all_objfiles.
3590         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3591         * cp-support.c (add_symbol_overload_list_qualified): Use
3592         all_objfiles.
3593         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3594         Use all_objfiles.
3595         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3596         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3597         all_objfiles.
3598         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3599         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3600         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3601         Uses all_objfiles.
3602         * solib.c (solib_read_symbols): Use all_objfiles
3603
3604 2019-01-09  Tom Tromey  <tom@tromey.com>
3605
3606         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3607         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3608         all_objfiles.
3609         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3610         * symmisc.c (print_symbol_bcache_statistics)
3611         (print_objfile_statistics, maintenance_print_objfiles)
3612         (maintenance_info_symtabs, maintenance_check_symtabs)
3613         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3614         all_objfiles.
3615         * source.c (forget_cached_source_info): Use all_objfiles.
3616         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3617         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3618         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3619         * objfiles.c (update_section_map): Use all_objfiles.
3620         (shared_objfile_contains_address_p): Likewise.
3621         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3622         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3623
3624 2019-01-09  Tom Tromey  <tom@tromey.com>
3625
3626         * common/next-iterator.h: New file.
3627         * objfiles.h (class all_objfiles): New.
3628         (struct objfile_iterator): New.
3629
3630 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3631
3632         * NEWS: Move the description of the changed "frame", "select-frame",
3633          and "info frame" commands to the Changed commands section.
3634
3635 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3636
3637         * gdbtypes.c (check_stub_method_group): Remove handling of old
3638         mangling schemes.
3639         * linespec.c (find_methods): Likewise.
3640         * stabsread.c (read_member_functions): Likewise.
3641         * valops.c (search_struct_method): Likewise.
3642         (value_struct_elt_for_reference): Likewise.
3643         * NEWS: Mention this change.
3644
3645 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3648         print_source_lines.
3649         * source.c (print_source_lines_base): Update line number check.
3650         (print_source_lines): New function.
3651         (source_lines_range::source_lines_range): New function.
3652         * source.h (class source_lines_range): New class.
3653         (print_source_lines): New declaration.
3654
3655 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3656
3657         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3658
3659 2019-01-08  Tom Tromey  <tom@tromey.com>
3660             Simon Marchi  <simon.marchi@ericsson.com>
3661
3662         PR gdb/24060
3663         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3664         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3665         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3666         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3667         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3668         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3669
3670 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * source.c (select_source_symtab): Move header comment to
3673         declaration in source.h.
3674         (forget_cached_source_info_for_objfile): Likewise.
3675         (forget_cached_source_info): Likewise.
3676         (identify_source_line): Likewise.
3677         * source.h (identify_source_line): Move declaration from symtab.h
3678         and add comment from source.c
3679         (print_source_lines): Likewise.
3680         (forget_cached_source_info_for_objfile): Likewise.
3681         (forget_cached_source_info): Likewise.
3682         (select_source_symtab): Likewise.
3683         (enum print_source_lines_flag): Move definition from symtab.h.
3684         * symtab.h (identify_source_line): Move declaration to source.h.
3685         (print_source_lines): Likewise.
3686         (forget_cached_source_info_for_objfile): Likewise.
3687         (forget_cached_source_info): Likewise.
3688         (select_source_symtab): Likewise.
3689         (enum print_source_lines_flag): Move definition to source.h.
3690         * tui/tui-hooks.c: Add 'source.h' include.
3691
3692 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * source.c (print_source_lines_base): Handle requests to print
3695         reverse line number sequences, and guard against empty lines
3696         string.
3697
3698 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * source.c (print_source_lines_base): Fix skip of '\r' if next
3701         character is '\n'.
3702
3703 2019-01-06  Tom Tromey  <tom@tromey.com>
3704
3705         * c-exp.y (struct c_parse_state) <macro_original_text,
3706         expansion_obstack>: New member.
3707         (macro_original_text, expansion_obstack): Remove globals.
3708         (scan_macro_expansion, scanning_macro_expansion)
3709         (finished_macro_expansion): Update.
3710         (scan_macro_cleanup): Remove.
3711         (yylex, c_parse): Update.
3712
3713 2019-01-06  Tom Tromey  <tom@tromey.com>
3714
3715         * c-exp.y (struct c_parse_state) <strings>: New member.
3716         (operator_stoken): Update.
3717
3718 2019-01-06  Tom Tromey  <tom@tromey.com>
3719
3720         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3721         (union type_stack_elt) <typelist_val>: Now a pointer to
3722         std::vector.
3723         (type_stack_cleanup): Don't declare.
3724         (push_typelist): Update.
3725         * parse.c (pop_typelist): Return a std::vector.
3726         (push_typelist): Take a std::vector.
3727         (follow_types): Update.  Do not free args.
3728         (type_stack_cleanup): Remove.
3729         * c-exp.y (struct c_parse_state): New.
3730         (cpstate): New global.
3731         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3732         (nonempty_typelist): Update.
3733         (func_mod): Create a new vector.
3734         (c_parse): Create a c_parse_state.
3735         (check_parameter_typelist): Do not delete params.
3736         (function_method): Update.  Do not delete type_list.
3737
3738 2019-01-06  Tom Tromey  <tom@tromey.com>
3739
3740         PR gdb/28155:
3741         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3742         check_typedef.
3743         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3744         (print_return_value): Likewise.
3745
3746 2019-01-05  Tom Tromey  <tom@tromey.com>
3747
3748         * contrib/cleanup_check.py: Remove.
3749         * contrib/gcc-with-excheck: Remove.
3750         * contrib/exsummary.py: Remove.
3751         * contrib/excheck.py: Remove.
3752
3753 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3754
3755         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3756         NULL. Initialize tpprev to NULL instead of assigning it
3757         to NULL on the next statement.
3758         * windows-nat.c (windows_delete_thread): Remove check for
3759         main_thread_id before printing thread exit notifications.
3760         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3761         Remove thread ID check against main_thread_id.
3762         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3763         windows_delete_thread.
3764         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3765
3766 2019-01-04  Tom Tromey  <tom@tromey.com>
3767
3768         * compile/compile.c (_initialize_compile): Use upper case for
3769         metasyntactic variables.
3770         * symmisc.c (_initialize_symmisc): Use upper case for
3771         metasyntactic variables.
3772         * psymtab.c (_initialize_psymtab): Use upper case for
3773         metasyntactic variables.
3774         * demangle.c (demangle_command): Use upper case for metasyntactic
3775         variables.
3776         (_initialize_demangler): Likewise.
3777         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3778         variables.
3779
3780 2019-01-03  Tom Tromey  <tom@tromey.com>
3781
3782         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3783
3784 2019-01-03  Tom Tromey  <tom@tromey.com>
3785
3786         * python/py-symtab.c (salpy_str): Update.
3787         (struct salpy_sal_object) <symtab>: Now a PyObject.
3788         (salpy_dealloc): Update.
3789         (del_objfile_sal): Use gdbpy_ref.
3790
3791 2019-01-03  Tom Tromey  <tom@tromey.com>
3792
3793         * python/py-type.c (convert_field): Use new_reference.  Return
3794         gdbpy_ref.
3795         (make_fielditem): Return gdbpy_ref.
3796         (typy_fields): Update.
3797         (typy_getitem): Update.
3798         (field_name): Return gdbpy_ref.  Use new_reference.
3799         (typy_iterator_iternext): Update.
3800
3801 2019-01-03  Tom Tromey  <tom@tromey.com>
3802
3803         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3804
3805 2019-01-03  Tom Tromey  <tom@tromey.com>
3806
3807         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3808         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3809         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3810         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3811         (pspy_set_type_printers): Likewise.
3812         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3813         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3814         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3815         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3816         (objfpy_set_type_printers): Likewise.
3817
3818 2019-01-03  Tom Tromey  <tom@tromey.com>
3819
3820         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3821         (gdbpy_print_stack): Use gdbpy_err_fetch.
3822         * python/python-internal.h (class gdbpy_err_fetch): New class.
3823         (class gdbpy_enter) <m_error_type, m_error_value,
3824         m_error_traceback>: Remove.
3825         <m_error>: New member.
3826         (gdbpy_exception_to_string): Don't declare.
3827         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3828         * python/py-value.c (convert_value_from_python): Use
3829         gdbpy_err_fetch.
3830         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3831         gdbpy_exception_to_string.
3832         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3833         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3834         gdbpy_err_fetch.
3835
3836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * linux-nat.c (delete_lwp_cleanup): Delete.
3839         (struct lwp_deleter): New struct.
3840         (lwp_info_up): New typedef.
3841         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3842         lwp_info_up.
3843
3844 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * linux-fork.c (class scoped_switch_fork_info): New class.
3847         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3848
3849 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * valops.c (find_overload_match): Remove use of null_cleanup, and
3852         calls to do_cleanups.
3853
3854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * compile/compile-cplus-types.c
3857         (compile_cplus_instance::decl_name): Handle changes to
3858         cp_func_name.
3859         * cp-support.c (cp_func_name): Update header comment, update
3860         return type.
3861         * cp-support.h (cp_func_name): Update return type in declaration.
3862         * valops.c (find_overload_match): Move temp_func local to top
3863         level of function and change its type.  Use temp_func to hold and
3864         delete temporary string obtained from cp_func_name.
3865
3866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3869         gdb::char_vector, remove cleanup, and update uses of `msg`.
3870
3871 2019-01-03  Jim Wilson  <jimw@sifive.com>
3872
3873         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3874
3875 2019-01-02  Tom Tromey  <tom@tromey.com>
3876
3877         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3878         (tdesc_parse_xml): Remove cleanups.
3879         * target-descriptions.h (make_cleanup_free_target_description):
3880         Don't declare.
3881         (target_desc_deleter): New struct.
3882         (target_desc_up): New typedef.
3883         * target-descriptions.c (target_desc_deleter::operator()): Rename
3884         from free_target_description.
3885         (make_cleanup_free_target_description): Remove.
3886
3887 2019-01-02  Tom Tromey  <tom@tromey.com>
3888
3889         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3890         constructor, destructor.
3891         (linespec_parser): Remove typedef.
3892         (~linespec_parser): Rename from linespec_parser_delete.
3893         (linespec_lex_to_end, linespec_complete_label)
3894         (linespec_complete): Update.
3895         (decode_line_full): Remove cleanups.
3896         (decode_line_1): Update.
3897
3898 2019-01-02  Tom Tromey  <tom@tromey.com>
3899
3900         * python/python-internal.h (inferior_to_inferior_object): Change
3901         return type.
3902         * python/py-exitedevent.c (create_exited_event_object): Update.
3903         * python/py-inferior.c (inferior_to_inferior_object): Return
3904         gdbpy_ref.
3905         (python_new_inferior, python_inferior_deleted)
3906         (thread_to_thread_object, delete_thread_object)
3907         (build_inferior_list, gdbpy_selected_inferior): Update.
3908         * python/py-infthread.c (create_thread_object): Update.  Also fail
3909         if inferior_to_inferior_object fails.
3910
3911 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3912
3913         * inferior.h (class inferior) <displaced_step_state>: New field.
3914         * infrun.h (struct displaced_step_state): Move here from
3915         infrun.c.  Initialize fields, add constructor.
3916         <inf>: Remove field.
3917         <reset>: New method.
3918         * infrun.c (struct displaced_step_inferior_state): Move to
3919         infrun.h.
3920         (displaced_step_inferior_states): Remove.
3921         (get_displaced_stepping_state): Adust.
3922         (displaced_step_in_progress_any_inferior): Adjust.
3923         (displaced_step_in_progress_thread): Adjust.
3924         (displaced_step_in_progress): Adjust.
3925         (add_displaced_stepping_state): Remove.
3926         (get_displaced_step_closure_by_addr): Adjust.
3927         (remove_displaced_stepping_state): Remove.
3928         (infrun_inferior_exit): Call displaced_step_state.reset.
3929         (use_displaced_stepping): Don't check for NULL.
3930         (displaced_step_prepare_throw): Call
3931         get_displaced_stepping_state.
3932         (displaced_step_fixup): Don't check for NULL.
3933         (prepare_for_detach): Don't check for NULL.
3934
3935 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3936
3937         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3938          in case of call that did not complete.
3939
3940 2019-01-02  Andrey Utkin  <autkin@undo.io>
3941
3942         * symfile.c (find_separate_debug_file): Fix search of debug files for
3943         remote debuggee.
3944
3945 2019-01-02  Tom Tromey  <tom@tromey.com>
3946
3947         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3948         indentation.
3949         * python/py-frame.c (frapy_older): Remove cast.
3950         (frapy_newer): Likewise.
3951         * python/py-breakpoint.c (local_setattro): Remove cast.
3952         * python/py-arch.c (archpy_name): Remove local variable.
3953         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3954
3955 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3956
3957         * unittests/basic_string_view/element_access/char/empty.cc:
3958         Fix year range in copyright header.
3959
3960 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3963         Delete.
3964         <operator==>: Update with for removed field.
3965         <hash>: Likewise.
3966         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3967         <isa_features>: ...this.
3968         <abi_features>: New field.
3969         (riscv_isa_flen): Update comment.
3970         (riscv_abi_xlen): New declaration.
3971         (riscv_abi_flen): New declaration.
3972         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3973         isa_features.
3974         (riscv_abi_xlen): New function.
3975         (riscv_isa_flen): Update to get answer from isa_features.
3976         (riscv_abi_flen): New function.
3977         (riscv_has_fp_abi): Update to get answer from abi_features.
3978         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3979         xlen and flen.
3980         (riscv_call_info) <xlen, flen>: Update comment.
3981         (riscv_call_arg_struct): Remove invalid assertions
3982         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3983         is removed.
3984         (riscv_gdbarch_init): Gather isa features and abi features
3985         separately, ensure both match on the gdbarch when reusing an old
3986         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3987         a target with 64-bit float hardware.
3988
3989 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3990
3991         * source.c (search_command_helper): Stop reverse search
3992         when line 1 has been searched.
3993
3994 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3995
3996         * record-full.c (record_full_base_target::close): Rewrite
3997         record_full_core_buf_list free logic.
3998
3999 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4000
4001         * break-catch-syscall.c (print_one_catch_syscall): xfree
4002         the last text.
4003
4004 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4005
4006         * top.c (print_gdb_version): Update Copyright year in version
4007         message.
4008
4009 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4010
4011         Update copyright year range in all GDB files.
4012
4013 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4014
4015         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4016
4017 For older changes see ChangeLog-2018.
4018 \f
4019 Local Variables:
4020 mode: change-log
4021 left-margin: 8
4022 fill-column: 74
4023 version-control: never
4024 coding: utf-8
4025 End:
4026