gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * thread.c (thread_apply_command): Check for invalid TID with
   4         isdigit instead of !isalpha.
   5
   6 2019-06-13  Pedro Alves  <palves@redhat.com>
   7
   8         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
   9         (validate_flags_qcs): New.
  10         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
  11         (validate_flags_qcs): Declare.
  12         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
  13         (make_frame_apply_options_def_group): New.
  14         (frame_apply_command_count): Process options with
  15         gdb::option::process_options.
  16         (frame_apply_completer): New.
  17         (frame_apply_level_completer, frame_apply_all_completer)
  18         (frame_apply_completer): New.
  19         (_initialize_stack): Update help of "frame apply", "frame apply
  20         level", "frame apply all" and "faas" to mention supported options
  21         and install command completers.
  22         * stack.h (frame_apply_all_completer): Declare.
  23         * thread.c: Include "stack.h".
  24         (tfaas_command): Add "--".
  25         (_initialize_thread): Update help "tfaas" to mention supported
  26         options and install command completer.
  27
  28 2019-06-13  Pedro Alves  <palves@redhat.com>
  29
  30         * completer.c (complete_nested_command_line): New.
  31         (gdb_completion_word_break_characters_throw): Add assertion.
  32         * completer.h (complete_nested_command_line): Declare.
  33
  34 2019-06-13  Pedro Alves  <palves@redhat.com>
  35
  36         * stack.c (parse_backtrace_qualifiers): New.
  37         (backtrace_command): Use it.
  38         (backtrace_command_completer): Complete on qualifiers.
  39
  40 2019-06-13  Pedro Alves  <palves@redhat.com>
  41
  42         * frame.c: Include "cli/cli-option.h.
  43         (user_set_backtrace_options): New.
  44         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
  45         Delete.
  46         (get_prev_frame): Adjust.
  47         (boolean_option_def, uinteger_option_def)
  48         (set_backtrace_option_defs): New.
  49         (_initialize_frame): Adjust and use
  50         gdb::option::add_setshow_cmds_for_options to install "set
  51         backtrace past-main" and "set backtrace past-entry".
  52         * frame.h: Include "cli/cli-option.h".
  53         (struct frame_print_options): Forward declare.
  54         (print_frame_arguments_all, print_frame_arguments_scalars)
  55         (print_frame_arguments_none): Declare.
  56         (print_entry_values): Delete declaration.
  57         (struct frame_print_options, user_frame_print_options): New.
  58         (struct set_backtrace_options): New.
  59         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
  60         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
  61         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
  62         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
  63         (list_args_or_locals): Add frame_print_options parameter.
  64         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  65         * python/py-framefilter.c (enumerate_args): Pass down
  66         USER_FRAME_PRINT_OPTIONS.
  67         * stack.c: Include "cli/cli-option.h".
  68         (print_frame_arguments_all, print_frame_arguments_scalars)
  69         (print_frame_arguments_none): Declare.
  70         (print_raw_frame_arguments, print_entry_values): Delete.
  71         (user_frame_print_options): New.
  72         (boolean_option_def, enum_option_def, frame_print_option_defs):
  73         New.
  74         (struct backtrace_cmd_options): New.
  75         (bt_flag_option_def): New.
  76         (backtrace_command_option_defs): New.
  77         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  78         (print_frame_arg, read_frame_arg, print_frame_args)
  79         (print_frame_info, print_frame): Add frame_print_options parameter
  80         and use it.
  81         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
  82         (backtrace_command_1): Add frame_print_options and
  83         backtrace_cmd_options parameters and use them.
  84         (make_backtrace_options_def_group): New.
  85         (backtrace_command): Process command options with
  86         gdb::option::process_options.
  87         (backtrace_command_completer): New.
  88         (_initialize_stack): Extend "backtrace"'s help to mention
  89         supported options.  Install completer for "backtrace".
  90         Install some settings commands with add_setshow_cmds_for_options.
  91
  92 2019-06-13  Pedro Alves  <palves@redhat.com>
  93
  94         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
  95         and that "set/show print raw frame-arguments" are now deprecated.
  96
  97         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
  98         command.
  99         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 100         * stack.c (_initialize_stack): Install "set/show print
 101         raw-frame-arguments", and deprecate "set/show print raw
 102         frame-arguments".
 103         * valprint.c (_initialize_valprint): Deprecate "set/show print
 104         raw".
 105
 106 2019-06-13  Pedro Alves  <palves@redhat.com>
 107
 108         * compile/compile.c (struct compile_options): New.
 109         (compile_flag_option_def, compile_command_option_defs)
 110         (make_compile_options_def_group): New.
 111         (compile_file_command): Handle options with
 112         gdb::option::process_options.
 113         (compile_file_command_completer): New function.
 114         (compile_code_command): Handle options with
 115         gdb::option::process_options.
 116         (compile_code_command_completer): New function.
 117         (_initialize_compiler): Install completers for "compile code" and
 118         "compile file".  Mention available options in "compile code" and
 119         "compile code"'s help.
 120         * completer.c (advance_to_completion_word): New, factored out from
 121         ...
 122         (advance_to_expression_complete_word_point): ... this.
 123         (advance_to_filename_complete_word_point): New.
 124         * completer.h (advance_to_filename_complete_word_point): New
 125         declaration.
 126
 127 2019-06-13  Pedro Alves  <palves@redhat.com>
 128
 129         * compile/compile.c: Include "cli/cli-option.h".
 130         (compile_print_value): Scope data pointer is now a
 131         value_print_options pointer; adjust.
 132         (compile_print_command): Process options.  Scope data pointer is
 133         now a value_print_options pointer; adjust.
 134         (_initialize_compile): Update "compile print"'s help to include
 135         supported options.  Install a completer for "compile print".
 136         * cp-valprint.c (show_vtblprint, show_objectprint)
 137         (show_static_field_print): Delete.
 138         (_initialize_cp_valprint): Don't install "set print
 139         static-members", "set print vtbl", "set print object" here.
 140         * printcmd.c: Include "cli/cli-option.h" and
 141         "common/gdb_optional.h".
 142         (print_command_parse_format): Rework to fill in a
 143         value_print_options instead of a format_data.
 144         (print_value): Change parameter type from format_data pointer to
 145         value_print_options reference.  Adjust.
 146         (print_command_1): Process options.  Adjust to pass down a
 147         value_print_options.
 148         (print_command_completer): New.
 149         (_initialize_printcmd): Install print_command_completer as
 150         handle_brkchars completer for the "print" command.  Update
 151         "print"'s help to include supported options.
 152         * valprint.c: Include "cli/cli-option.h".
 153         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 154         here from cp-valprint.c.
 155         (boolean_option_def, uinteger_option_def)
 156         (value_print_option_defs, make_value_print_options_def_group):
 157         New.  Use gdb::option::add_setshow_cmds_for_options to install
 158         "set print elements", "set print null-stop", "set print repeats",
 159         "set print pretty", "set print union", "set print array", "set
 160         print address", "set print symbol", "set print array-indexes".
 161         * valprint.h: Include <string> and "cli/cli-option.h".
 162         (make_value_print_options_def_group): Declare.
 163         (print_value): Change parameter type from format_data pointer to
 164         value_print_options reference.
 165         (print_command_completer): Declare.
 166
 167 2019-06-13  Pedro Alves  <palves@redhat.com>
 168
 169         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 170         (COMMON_SFILES): Add maint-test-settings.c.
 171         * cli/cli-decode.c (boolean_enums): New global, factored out from
 172         ...
 173         (add_setshow_boolean_cmd): ... here.
 174         * cli/cli-decode.h (boolean_enums): Declare.
 175         * cli/cli-option.c: New file.
 176         * cli/cli-option.h: New file.
 177         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 178         factored out from ...
 179         (parse_cli_boolean_value(const char *)): ... this.
 180         (is_unlimited_literal): Change parameter type to pointer to
 181         pointer.  Adjust and advance ARG pointer.
 182         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 183         (parse_cli_var_enum): New, factored out from ...
 184         (do_set_command): ... this.  Adjust.
 185         * cli/cli-setshow.h (parse_cli_boolean_value)
 186         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 187         (parse_cli_var_enum): Declare.
 188         * cli/cli-utils.c: Include "cli/cli-option.h".
 189         (get_ulongest): New.
 190         * cli/cli-utils.h (get_ulongest): Declare.
 191         (check_for_argument): New overloads.
 192         * maint-test-options.c: New file.
 193
 194 2019-06-13  Pedro Alves  <palves@redhat.com>
 195
 196         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 197         parse a range if "-" is at the end of the string.
 198
 199 2019-06-13  Pedro Alves  <palves@redhat.com>
 200
 201         * cli/cli-setshow.c (parse_auto_binary_operation)
 202         (parse_cli_boolean_value): Don't allow "o".
 203
 204 2019-06-13  Pedro Alves  <palves@redhat.com>
 205
 206         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 207         * NEWS: Mention maint test-settings KIND.
 208         * maint-test-settings.c: New file.
 209
 210 2019-06-13  Pedro Alves  <palves@redhat.com>
 211
 212         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 213         completer.
 214         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 215         "set" completers.
 216
 217 2019-06-13  Pedro Alves  <palves@redhat.com>
 218
 219         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 220         after item.
 221
 222 2019-06-13  Pedro Alves  <palves@redhat.com>
 223
 224         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 225
 226 2019-06-13  Pedro Alves <palves@redhat.com>
 227
 228         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 229         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 230         call.
 231         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 232         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 233         calls.
 234         (check_for_argument): Skip spaces after argument.
 235
 236 2019-06-13  Pedro Alves  <palves@redhat.com>
 237
 238         * thread.c (thread_apply_command): Adjust TID parsing.
 239         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 240         detected before end of string.
 241         (tid_is_in_list): Error out if LIST is invalid.
 242
 243 2019-06-13  Pedro Alves  <palves@redhat.com>
 244
 245         * completer.c (complete_line_internal_1): Rewind completion word
 246         point.
 247         (completion_tracker::advance_custom_word_point_by): Change
 248         parameter type to int.
 249         * completer.h (completion_tracker::advance_custom_word_point_by):
 250         Likewise.
 251
 252 2019-06-13  Pedro Alves  <palves@redhat.com>
 253
 254         * completer.c (advance_to_completion_word): Handle delimiters.
 255
 256 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 257
 258         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 259
 260 2019-06-11  Tom Tromey  <tom@tromey.com>
 261
 262         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 263         (xmalloc_failed): Move to alloc.c.
 264         * alloc.c: New file.
 265         * Makefile.in (COMMON_SFILES): Add alloc.c.
 266
 267 2019-06-11  Tom Tromey  <tom@tromey.com>
 268
 269         * nat/linux-waitpid.c: Don't include server.h.
 270         (linux_debug): Remove.
 271         (my_waitpid): Update.
 272
 273 2019-06-11  Tom Tromey  <tromey@adacore.com>
 274
 275         * infcall.c (_initialize_infcall): Remove trailing newline from
 276         help.
 277         * user-regs.c (_initialize_user_regs): Remove trailing newline
 278         from help.
 279         * typeprint.c (_initialize_typeprint): Remove trailing newline
 280         from help.
 281         * reverse.c (_initialize_reverse): Remove trailing newlines from
 282         help.
 283         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 284         from help.
 285         * language.c (add_set_language_command): Remove trailing newline
 286         from help.
 287         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 288         help.
 289         * disasm.c (_initialize_disasm): Remove trailing newline from
 290         help.
 291         * top.c (init_main): Remove trailing newline from help.
 292         * interps.c (_initialize_interpreter): Remove trailing newline
 293         from help.
 294         * btrace.c (_initialize_btrace): Remove trailing newlines from
 295         help.
 296         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 297         from help.
 298         * python/python.c (_initialize_python): Remove trailing newline
 299         from help.
 300         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 301         help.
 302         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 303         from help.  Reformat some text.
 304         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 305         from help.
 306         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 307         newline from help.
 308
 309 2019-06-11  Tom Tromey  <tromey@adacore.com>
 310
 311         * darwin-nat.c (darwin_decode_exception_message)
 312         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 313
 314 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * valops.c (value_slice): Check for not allocated or not
 317         associated values.
 318
 319 2019-06-10  Tom de Vries  <tdevries@suse.de>
 320
 321         PR gdb/24618
 322         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 323         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 324         invalid.
 325
 326 2019-06-10  Tom de Vries  <tdevries@suse.de>
 327
 328         PR gdb/24611
 329         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 330         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 331
 332 2019-06-10  Tom de Vries  <tdevries@suse.de>
 333
 334         PR symtab/24545
 335         * symtab.c (struct demangled_name_entry): Add language field.
 336         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 337         static minimal symbol".  Set and use language field.
 338
 339 2019-06-10  Tom Tromey  <tromey@adacore.com>
 340
 341         * ada-lang.c (_initialize_ada_language): Update help text.
 342
 343 2019-06-10  Tom Tromey  <tromey@adacore.com>
 344
 345         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 346         with a newline.
 347         * guile/guile.c (handle_boot_error): Don't end warning with a
 348         newline.
 349         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 350         warning with a newline.
 351         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 352         newline.
 353         (s12z_frame_cache): Likewise.
 354         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 355         a newline.
 356         * solib-svr4.c (disable_probes_interface): Don't end warning with
 357         a newline.
 358         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 359         newline.
 360         * python/python.c (do_finish_initialization): Don't end warning
 361         with a newline.
 362
 363 2019-06-10  Tom Tromey  <tom@tromey.com>
 364
 365         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 366         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 367         gdbpy_enter.
 368
 369 2019-06-10  Tom Tromey  <tromey@adacore.com>
 370
 371         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 372         data.
 373         (elf_new_init): Don't call stabsread_new_init.
 374         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 375         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 376         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 377
 378 2019-06-10  Tom de Vries  <tdevries@suse.de>
 379
 380         PR symtab/16264
 381         PR symtab/24517
 382         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 383
 384 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 385
 386         * source.c (find_and_open_source): Also rewrite relative file
 387         names.
 388
 389 2019-04-26  Amos Bird  <amosbird@gmail.com>
 390
 391         * annotate.c (annotate_thread_exited): Add "thread-exited"
 392         annotation.
 393
 394 2019-06-06  Tom Tromey  <tromey@adacore.com>
 395
 396         * maint.h (class scoped_command_stats): Use
 397         DISABLE_COPY_AND_ASSIGN.
 398         <print_time>: New method.
 399         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 400         print_time.
 401         (scoped_command_stats::print_time): New method.
 402
 403 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 406         instructions of lengths 6 or 8 bytes.
 407
 408 2019-06-04  Pedro Alves  <palves@redhat.com>
 409
 410         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 411
 412         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 413         * breakpoint.c (condition_completer): Likewise.
 414         * cli/cli-dump.c (scan_expression): Likewise.
 415         * common/filestuff.c (mkdir_recursive): Likewise.
 416         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 417         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 418         (gdb_abspath): Likewise.
 419         * compile/compile-cplus-types.c
 420         (compile_cplus_instance::decl_name): Likewise.
 421         * completer.c (complete_explicit_location):
 422         (signal_completer, reg_or_group_completer_1): Likewise.
 423         * cp-support.c (cp_remove_params_if_any): Likewise.
 424         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 425         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 426         * infcmd.c (strip_bg_char): Likewise.
 427         * linespec.c (copy_token_string): Likewise.
 428         * mi/mi-main.c (output_cores): Likewise.
 429         * psymtab.c (psymtab_search_name):
 430         * symfile.c (test_set_ext_lang_command): Likewise.
 431         * target.c (target_fileio_read_stralloc): Likewise.
 432         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 433         * value.c (complete_internalvar): Likewise.
 434
 435 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 436
 437         Add objfile property to gdb.Type.
 438         * NEWS: Mention Python API addition.
 439         * python/py-type.c (typy_get_objfile): New method.
 440
 441 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 442
 443         * NEWS: Mention the new set|show style [title|highlight].
 444         Mention changes to "show style", "help" and "apropos".
 445
 446 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 447
 448         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 449         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 450         instead of print_help_for_command.
 451         (print_doc_of_command): New function.
 452         (help_list): Add 'apropos -v word' suggestion.
 453         (print_help_for_command): Style the command name using title style.
 454         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 455         (_initialize_cli_cmds): Describe -v in apropos_command help.
 456
 457 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 458
 459         * cli/cli-style.h (cli_style_option): Add name in constructor,
 460         add m_name class member, add constructor with intensity,
 461         add name class function.
 462         (cli_style_option::add_setshow_commands): Remove name argument.
 463         (highlight_style, title_style): New styles.
 464         * cli/cli-style.c (do_show): New function that shows a style
 465         characteristic styling the style name with itself.
 466         (set_style_name): New function.
 467         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 468         Update all callers according to the changes in cli/cli-style.h.
 469         * utils.h (fputs_highlighted): New function.
 470         * utils.c (fputs_highlighted): Likewise.
 471
 472 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 473
 474         * NEWS: Mention new pipe command and new convenience variables.
 475
 476 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 477
 478         * cli/cli-cmds.c (pipe_command): New function.
 479         (_initialize_cli_cmds): Call add_com for pipe_command.
 480         Define | as an alias for pipe.
 481         (exit_status_set_internal_vars): New function.
 482         (shell_escape): Call exit_status_set_internal_vars.
 483         cli/cli-decode.c (find_command_name_length): Recognize | as
 484         a single character command.
 485
 486 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 487
 488         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 489         top.c (execute_command_to_ui_file): New function, mostly a copy
 490         of execute_command_to_string.
 491         (execute_command_to_string): Implement by calling
 492         execute_command_to_ui_file.
 493
 494 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 495
 496         * top.h (saved_command_line): Remove declaration.
 497         * top.c (previous_saved_command_line, previous_repeat_arguments):
 498         New variables.
 499         (saved_command_line): Make static, define together with other
 500         'repeat variables'.
 501         (dont_repeat): Clear repeat_arguments.
 502         (repeat_previous, get_saved_command_line, save_command_line):
 503         New functions.
 504         (gdb_init): Initialize saved_command_line
 505         and previous_saved_command_line.
 506         * main.c (captured_main_1): Remove saved_command_line initialization.
 507         * event-top.c (handle_line_of_input): Update to use
 508         the new 'repeat' related functions instead of direct access to
 509         saved_command_line.
 510         * command.h (repeat_previous, get_saved_command_line,
 511         save_command_line): New declarations.
 512         (dont_repeat): Add comment.
 513
 514 2019-05-30  Tom Tromey  <tromey@adacore.com>
 515
 516         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 517         Fix comment.
 518         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 519
 520 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 521
 522         PR cli/24587
 523         * completer.c (complete): Initialize variable word.
 524
 525 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 526
 527         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 528         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 529         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 530         'body' is NULL to the outter 'if', protecting the '!is_define'
 531         situation as well.
 532
 533 2019-05-29  Tom Tromey  <tromey@adacore.com>
 534
 535         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 536         (dwarf_unknown): New function.
 537         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 538         (dwarf_type_encoding_name): Use dwarf_unknown.
 539
 540 2019-05-29  Tom Tromey  <tromey@adacore.com>
 541
 542         PR c++/20020:
 543         * cp-valprint.c (cp_print_value_fields): Call
 544         cp_print_static_field inside "try".
 545
 546 2019-05-29  Tom Tromey  <tromey@adacore.com>
 547
 548         * inflow.c (struct terminal_info): Add default operator=.
 549         * configure: Rebuild.
 550         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 551         -Wdeprecated-copy-dtor, -Wredundant-move.
 552
 553 2019-05-29  Tom Tromey  <tromey@adacore.com>
 554
 555         * NEWS: Add entry.
 556         * infcmd.c (print_return_value_1): Handle finish_print
 557         option.
 558         (show_print_finish): New function.
 559         (_initialize_infcmd): Add "set/show print finish" commands.
 560         * valprint.c (user_print_options): Initialize new member.
 561         * valprint.h (struct value_print_options) <finish_print>: New
 562         member.
 563
 564 2019-05-28  Tom Tromey  <tromey@adacore.com>
 565
 566         * ada-lang.c (ada_remove_Xbn_suffix)
 567         (find_old_style_renaming_symbol)
 568         (parse_old_style_renaming): Remove.
 569         (ada_find_renaming_symbol): Don't call
 570         find_old_style_renaming_symbol.
 571         (ada_is_renaming_symbol): Rename from
 572         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 573         bool.  Now static.
 574         (ada_read_var_value): Update and simplify.
 575         * ada-exp.y (write_var_or_type): Remove old code.
 576
 577 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 578
 579         * event-top.c: Remove include comment.
 580         * inflow.c (class scoped_ignore_sigttou): Move from here...
 581         * inflow.h (class scoped_ignore_sigttou): ...to here.
 582         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 583         * top.c:  Remove include comment.
 584
 585 2019-05-27  Tom Tromey  <tom@tromey.com>
 586
 587         * NEWS: Fix typo.
 588
 589 2019-05-22  Tom Tromey  <tromey@adacore.com>
 590
 591         * target.c (target_follow_exec): Constify parameter.
 592         * target-delegates.c: Rebuild.
 593         * remote.c (remote_target::follow_exec): Constify parameter.
 594         * infrun.c (follow_exec): Constify parameter.
 595         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 596         (target_follow_exec): Likewise.
 597
 598 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 599
 600         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 601         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 602
 603 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 604
 605         * NEWS: Add debugredirect and testsuite sections.
 606
 607 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 608
 609         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 610         target descriptions using exclusively floating point register name
 611         aliases.
 612
 613 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         PR gdb/18644:
 616         * f-lang.c (build_fortran_types): Handle the case where
 617         gdbarch_floatformat_for_type returns a nullptr.
 618
 619 2019-05-21  Tom de Vries  <tdevries@suse.de>
 620
 621         PR cli/24587
 622         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 623
 624 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         PR gdb/18644:
 627         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 628         16-byte floats.
 629         * i386-tdep.c (i386_floatformat_for_type): Use
 630         floatformats_ia64_quad for the 16-byte floating point component
 631         within a fortran 32-byte complex number.
 632
 633 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 634
 635         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 636         delete default constructor.
 637         (find_partial_die): Update to return const struct.
 638         (partial_die_parent_scope): Move variable declaration into scope
 639         of its use and change its type to auto.
 640         (guess_partial_die_structure_name): Likewise.
 641         (partial_die_info::fixup): Likewise.
 642
 643 2019-05-17  Tom Tromey  <tromey@adacore.com>
 644
 645         * source.c (find_and_open_source): Remove cast.
 646
 647 2019-05-17  Tom Tromey  <tromey@adacore.com>
 648
 649         * annotate.c (annotate_source): Make "filename" const.
 650         * annotate.h (annotate_source): Use const.
 651
 652 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 653
 654         * disasm.c (set_disassembler_options): Send errors to stderr.
 655
 656 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 657
 658         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 659         (cli_interp_base::set_logging): Check debug_redirect.
 660         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 661         * cli/cli-logging.c (debug_redirect): Add static variable.
 662         (pop_output_files): Add default param.
 663         (handle_redirections): Print debug setting.
 664         (show_logging_command): Likewise.
 665         (_initialize_cli_logging): Add debugredirect command.
 666         * interps.c (current_interp_set_logging): Add debug_redirect
 667         parameter.
 668         * interps.h (set_logging): Add debug_redirect parameter.
 669         (current_interp_set_logging): Likewise.
 670         * mi/mi-common.h: Likewise.
 671         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 672
 673 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 674             Tom Tromey  <tromey@adacore.com>
 675
 676         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 677         directly.
 678         * cli/cli-interp.h (make_logging_output): Remove declaration.
 679         * cli/cli-logging.c (make_logging_output): Remove function.
 680         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 681         directly.
 682         * ui-file.c (tee_file::tee_file): Remove bools.
 683         (tee_file::~tee_file): Remove deletes.
 684         * ui-file.h (tee_file): Remove bools.
 685
 686 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 687
 688         * mi/mi-cmds.h (mi_cmd_complete): New function.
 689         * mi/mi-main.c (mi_cmd_complete): Likewise.
 690         * mi/mi-cmds.c: Define new MI command -complete.
 691         * NEWS: Mention new -complete command.
 692
 693 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 694
 695         * completer.h (complete): New function.
 696         * completer.c (complete): Likewise.
 697         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 698         function defined in completer.h.
 699
 700 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 701
 702        * MAINTAINERS (Write After Approval): Add myself.
 703
 704 2019-05-17  Tom de Vries  <tdevries@suse.de>
 705
 706         PR gdb/24094
 707         * dwarf2read.c (struct cu_partial_die_info): New struct.
 708         (find_partial_die): Return cu_partial_die_info.
 709         (partial_die_parent_scope, guess_partial_die_structure_name)
 710         (partial_die_info::fixup): Handle new return type of find_partial_die.
 711
 712 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 713
 714         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 715         "std::string", simplifying the algorithm.
 716
 717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 718
 719         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 720         (stap_static_probe_ops::get_probes): Likewise.
 721
 722 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 723
 724         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 725         '-')" and "else if".
 726         (stap_parse_single_operand): Join checks for
 727         "gdbarch_stap_parse_special_token_p" and
 728         "gdbarch_stap_parse_special_token" in the same "if" statement.
 729         Invert check when verifying for operation on register
 730         displacement.
 731
 732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 733
 734         * stap-probe.c (stap_get_opcode): Update comment.
 735         (stap_get_expected_argument_type): Likewise.
 736         (handle_stap_probe): Likewise.
 737
 738 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 739
 740         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 741         return type to 'bool'.  Adjust comment.  Use 'bool' when
 742         appropriate.
 743         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 744         * stap-probe.c (stap_parse_argument_1): Likewise.
 745         (stap_is_operator): Likewise.
 746         (stap_is_generic_prefix): Likewise.
 747         (stap_is_register_prefix): Likewise.
 748         (stap_is_register_indirection_prefix): Likewise.
 749         (stap_is_integer_prefix): Likewise.
 750         (stap_generic_check_suffix): Likewise.
 751         (stap_check_integer_suffix): Likewise.
 752         (stap_check_register_suffix): Likewise.
 753         (stap_check_register_indirection_suffix): Likewise.
 754         (stap_parse_register_operand): Likewise.
 755         (stap_parse_single_operand): Likewise.
 756         (stap_parse_argument_1): Likewise.
 757         (stap_probe::get_argument_count): Likewise.
 758         (stap_is_operator): Likewise.
 759
 760 2019-05-16  Tom Tromey  <tromey@adacore.com>
 761
 762         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 763         keyword to foreach.
 764
 765 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 766
 767         * linux-thread-db.c (try_thread_db_load_1): Change return type
 768         to bool.
 769         (try_thread_db_load): Likewise.
 770         (try_thread_db_load_from_pdir_1): Likewise.
 771         (try_thread_db_load_from_pdir): Likewise.
 772         (try_thread_db_load_from_sdir): Likewise.
 773         (try_thread_db_load_from_dir): Likewise.
 774         (thread_db_load_search): Likewise.
 775         (has_libpthread): Likewise.
 776         (thread_db_load): Likewise.
 777
 778 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 779
 780         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 781         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 782         NULL, and complain/return if that's the case.
 783
 784 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 785
 786         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 787         (advance, posn, abstract_read_memory): New functions.
 788         [struct mem_read_abstraction]: New struct.
 789         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 790
 791 2019-05-14  Tom Tromey  <tromey@adacore.com>
 792
 793         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 794         value is not lval_memory.
 795
 796 2019-05-14  Tom Tromey  <tromey@adacore.com>
 797
 798         * solib.c (info_sharedlibrary_command): Style the file name.
 799
 800 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 801
 802         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 803         (aarch64_vnv_type): Likewise.
 804         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 805         * common/tdesc.c: Likewise.
 806         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 807         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 808         * features/aarch64-fpu.xml: Add ieee half view.
 809         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 810         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 811         * gdbtypes.h (struct builtin_type): Likewise.
 812         (struct objfile_type): Likewise.
 813
 814 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 815
 816         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 817         typo.
 818         * location.h (string_to_event_location): Likewise.
 819
 820 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 821
 822         GDB 8.3 released.
 823
 824 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 825
 826         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 827         New variable declaration.
 828         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 829         New variable.
 830         (print_one_breakpoint): Use ui_out::test_flags and new global
 831         variable to compute use_fixed_output.
 832         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 833         Remove.
 834         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 835         (mi_multi_location_breakpoint_output_fixed): Remove.
 836         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 837         new variable.
 838         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 839         fix_multi_location_breakpoint_output flag if version >= 3.
 840         * ui-out.h (enum ui_out_flag)
 841         <fix_multi_location_breakpoint_output>: New enumerator.
 842
 843 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 844
 845         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 846
 847 2019-05-10  Tom Tromey  <tromey@adacore.com>
 848
 849         * ada-lang.c (catch_ada_completer): New function.
 850         (_initialize_ada_language): Use it.
 851
 852 2019-05-10  Tom Tromey  <tromey@adacore.com>
 853
 854         * thread.c (print_thread_info): Make "requested_threads" const.
 855         * gdbthread.h (print_thread_info): Make "requested_threads"
 856         const.
 857         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 858         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 859
 860 2019-05-08  Tom Tromey  <tom@tromey.com>
 861
 862         * gdbtypes.c (objfile_type_data): Change type.
 863         (objfile_type, _initialize_gdbtypes): Update.
 864
 865 2019-05-08  Tom Tromey  <tom@tromey.com>
 866
 867         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 868         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 869         (_initialize_dwarf2_frame): Update.
 870
 871 2019-05-08  Tom Tromey  <tom@tromey.com>
 872
 873         * objc-lang.c (objc_objfile_data): Change type.
 874         (find_methods): Update.
 875         (_initialize_objc_lang): Remove.
 876
 877 2019-05-08  Tom Tromey  <tom@tromey.com>
 878
 879         * stabsread.c (rs6000_builtin_type_data): Change type.
 880         (rs6000_builtin_type, _initialize_stabsread): Update.
 881
 882 2019-05-08  Tom Tromey  <tom@tromey.com>
 883
 884         * mips-tdep.c (mips_pdr_data): Remove.
 885         (_initialize_mips_tdep): Update.
 886
 887 2019-05-08  Tom Tromey  <tom@tromey.com>
 888
 889         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 890         (hppa_init_objfile_priv_data, read_unwind_info)
 891         (find_unwind_entry, _initialize_hppa_tdep): Update.
 892
 893 2019-05-08  Tom Tromey  <tom@tromey.com>
 894
 895         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 896         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 897         on obstack.
 898         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 899
 900 2019-05-08  Tom Tromey  <tom@tromey.com>
 901
 902         * mdebugread.c (basic_type_data): Change type.
 903         (basic_type, _initialize_mdebugread): Update.
 904
 905 2019-05-08  Tom Tromey  <tom@tromey.com>
 906
 907         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 908
 909 2019-05-08  Tom Tromey  <tom@tromey.com>
 910
 911         * nto-tdep.c (nto_inferior_data_reg): Change type.
 912         (nto_inferior_data): Update.
 913         (nto_inferior_data_cleanup, nto_new_inferior_data)
 914         (_initialize_nto_tdep): Remove.
 915         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 916
 917 2019-05-08  Tom Tromey  <tom@tromey.com>
 918
 919         * ada-lang.c (struct ada_inferior_data): Add initializers.
 920         (ada_inferior_data): Change type.
 921         (ada_inferior_data_cleanup): Remove.
 922         (get_ada_inferior_data, ada_inferior_exit)
 923         (struct ada_pspace_data): Add initializers, destructor.
 924         (ada_pspace_data_handle): Change type.
 925         (get_ada_pspace_data): Update.
 926         (ada_pspace_data_cleanup): Remove.
 927
 928 2019-05-08  Tom Tromey  <tom@tromey.com>
 929
 930         * coffread.c (struct coff_symfile_info): Add initializers.
 931         (coff_objfile_data_key): Move lower.  Change type.
 932         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 933         Update.
 934         (coff_free_info): Remove.
 935
 936 2019-05-08  Tom Tromey  <tom@tromey.com>
 937
 938         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 939         (fbsd_pspace_data_handle): Move lower.  Change type.
 940         (get_fbsd_pspace_data): Update.
 941         (fbsd_pspace_data_cleanup): Remove.
 942         (_initialize_fbsd_tdep): Update.
 943
 944 2019-05-08  Tom Tromey  <tom@tromey.com>
 945
 946         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 947         (get_ada_tasks_pspace_data): Update.
 948         (ada_tasks_pspace_data_cleanup): Remove.
 949         (_initialize_tasks): Update.
 950         (ada_tasks_inferior_data_handle): Change type.
 951         (get_ada_tasks_inferior_data): Update.
 952         (ada_tasks_inferior_data_cleanup): Remove.
 953         (struct ada_tasks_pspace_data): Add initializers.
 954
 955 2019-05-08  Tom Tromey  <tom@tromey.com>
 956
 957         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 958         * symfile-debug.c (debug_sym_get_probes): Change type.
 959         * stap-probe.c (handle_stap_probe):
 960         (stap_static_probe_ops::get_probes): Change type.
 961         * probe.h (class static_probe_ops) <get_probes>: Change type.
 962         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 963         (parse_probes_in_pspace): Update.
 964         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 965         Update.
 966         (any_static_probe_ops::get_probes): Change type.
 967         * elfread.c (elfread_data): New typedef.
 968         (probe_key): Change type.
 969         (elf_get_probes): Likewise.  Update.
 970         (probe_key_free): Remove.
 971         (_initialize_elfread): Update.
 972         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 973         Change type.
 974         (dtrace_process_dof_probe, dtrace_process_dof)
 975         (dtrace_static_probe_ops::get_probe): Change type.
 976
 977 2019-05-08  Tom Tromey  <tom@tromey.com>
 978
 979         * xcoffread.c (struct xcoff_symfile_info): Rename from
 980         coff_symfile_info.  Add initializers.
 981         (xcoff_objfile_data_key): Move lower.  Change type.
 982         (XCOFF_DATA): Rewrite.
 983         (xcoff_free_info): Remove.
 984         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 985         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 986         (xcoff_initial_scan): Update.
 987
 988 2019-05-08  Tom Tromey  <tom@tromey.com>
 989
 990         * solib-svr4.c (struct svr4_info): Add initializers and
 991         destructor.
 992         <probes_table>: Now an htab_up.
 993         (solib_svr4_pspace_data): Change type.
 994         (free_probes_table): Simplify.
 995         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 996         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 997         (probes_table_remove_objfile_probes, register_solib_event_probe)
 998         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 999         (_initialize_svr4_solib): Update.
1000
1001 2019-05-08  Tom Tromey  <tom@tromey.com>
1002
1003         * remote.c (remote_pspace_data): Change type.
1004         (remote_pspace_data_cleanup): Remove.
1005         (get_remote_exec_file, set_pspace_remote_exec_file)
1006         (_initialize_remote): Update.
1007
1008 2019-05-08  Tom Tromey  <tom@tromey.com>
1009
1010         * breakpoint.c (breakpoint_objfile_key): Change type.
1011         (get_breakpoint_objfile_data): Update.
1012         (free_breakpoint_objfile_data): Remove.
1013         (_initialize_breakpoint): Update.
1014
1015 2019-05-08  Tom Tromey  <tom@tromey.com>
1016
1017         * linux-tdep.c (struct linux_info): Add initializers.
1018         (linux_inferior_data): Move.  Change type.
1019         (invalidate_linux_cache_inf): Update.
1020         (linux_inferior_data_cleanup): Remove.
1021         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1022
1023 2019-05-08  Tom Tromey  <tom@tromey.com>
1024
1025         * auxv.c (auxv_inferior_data): Move.  Change type.
1026         (auxv_inferior_data_cleanup): Remove.
1027         (invalidate_auxv_cache_inf): Rewrite.
1028         (get_auxv_inferior_data, _initialize_auxv): Update.
1029
1030 2019-05-08  Tom Tromey  <tom@tromey.com>
1031
1032         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1033         (symfile_debug_objfile_data_key): Change type.
1034         (symfile_debug_installed, debug_qf_has_symbols)
1035         (debug_qf_find_last_source_symtab)
1036         (debug_qf_forget_cached_source_info)
1037         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1038         (debug_qf_print_stats, debug_qf_dump)
1039         (debug_qf_expand_symtabs_for_function)
1040         (debug_qf_expand_all_symtabs)
1041         (debug_qf_expand_symtabs_with_fullname)
1042         (debug_qf_map_matching_symbols)
1043         (debug_qf_expand_symtabs_matching)
1044         (debug_qf_find_pc_sect_compunit_symtab)
1045         (debug_qf_map_symbol_filenames)
1046         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1047         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1048         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1049         (debug_sym_read_linetable, debug_sym_relocate): Update.
1050         (symfile_debug_free_objfile): Remove.
1051         (install_symfile_debug_logging, _initialize_symfile_debug):
1052         Update.
1053
1054 2019-05-08  Tom Tromey  <tom@tromey.com>
1055
1056         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1057         allocate_on_obstack.
1058         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1059         (get_dwarf2_per_objfile): Update.
1060         (set_dwarf2_per_objfile): Remove.
1061         (dwarf2_has_info, dwarf2_get_section_info): Update.
1062         (dwarf2_free_objfile): Remove.
1063         (_initialize_dwarf2_read): Update.
1064
1065 2019-05-08  Tom Tromey  <tom@tromey.com>
1066
1067         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1068         initializers.
1069         <unsupported_script_warning_printed,
1070         script_not_found_warning_printed>: Now bool.
1071         (auto_load_pspace_data): Change type.
1072         (~auto_load_pspace_info): Rename from
1073         auto_load_pspace_data_cleanup.
1074         (get_auto_load_pspace_data, init_loaded_scripts_info)
1075         (clear_section_scripts, maybe_print_unsupported_script_warning)
1076         (maybe_print_script_not_found_warning, _initialize_auto_load):
1077         Update.
1078
1079 2019-05-08  Tom Tromey  <tom@tromey.com>
1080
1081         * objfiles.c (objfile_pspace_info): Add destructor and
1082         initializers.
1083         (objfiles_pspace_data): Change type.
1084         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1085         (get_objfile_pspace_data): Update.
1086         (objfiles_bfd_data): Change type.
1087         (get_objfile_bfd_data): Update.
1088         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1089
1090 2019-05-08  Tom Tromey  <tom@tromey.com>
1091
1092         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1093         Change type.
1094         (get_catch_syscall_inferior_data): Update.
1095         (catch_syscall_inferior_data_cleanup): Remove.
1096         (_initialize_break_catch_syscall): Update.
1097
1098 2019-05-08  Tom Tromey  <tom@tromey.com>
1099
1100         * inflow.c (struct terminal_info): Add destructor and
1101         initializers.
1102         (inflow_inferior_data): Change type.
1103         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1104         (get_inflow_inferior_data, inflow_inferior_exit)
1105         (swap_terminal_info, _initialize_inflow): Update.
1106
1107 2019-05-08  Tom Tromey  <tom@tromey.com>
1108
1109         * target-dcache.c (target_dcache_cleanup): Remove.
1110         (target_dcache_aspace_key): Change type.
1111         (target_dcache_init_p, target_dcache_invalidate)
1112         (target_dcache_get, target_dcache_get_or_init)
1113         (_initialize_target_dcache): Update.
1114         * dcache.h (struct dcache_deleter): New.
1115
1116 2019-05-08  Tom Tromey  <tom@tromey.com>
1117
1118         * symtab.c (struct symbol_cache): Add destructor and
1119         initializers.
1120         (symbol_cache_key): Move.  Change type.
1121         (make_symbol_cache, free_symbol_cache): Remove.
1122         (get_symbol_cache): Update.
1123         (symbol_cache_cleanup): Remove.
1124         (ALL_PSPACES, symbol_cache_flush)
1125         (maintenance_print_symbol_cache)
1126         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1127         Update.
1128
1129 2019-05-08  Tom Tromey  <tom@tromey.com>
1130
1131         * symtab.c (struct main_info): Add destructor and initializers.
1132         (main_progspace_key): Move.  Change type.
1133         (get_main_info): Update.
1134         (main_info_cleanup): Remove.
1135         (_initialize_symtab): Update.
1136
1137 2019-05-08  Tom Tromey  <tom@tromey.com>
1138
1139         * registry.h (DECLARE_REGISTRY): Define the _key class.
1140
1141 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * NEWS: Merge two 'New commands' sections.
1144
1145 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1146
1147         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1148         parameter and use Ada language definition instead.
1149         (ada_val_print_ptr): Remove unused language parameter.
1150         (ada_val_print_num): Remove language parameter and use Ada language
1151         definition instead.
1152         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1153         parameter.
1154         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1155         parameter and use Ada language definition instead.
1156         (ada_val_print_1): Update all ada_val_print_xxx calls.
1157         Remove language parameter.
1158         (ada_val_print): Update ada_val_print_1 call.
1159
1160 2019-05-08  Tom Tromey  <tromey@adacore.com>
1161
1162         * remote.c (remote_hw_watchpoint_limit)
1163         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1164         Now static.
1165
1166 2019-05-08  Tom Tromey  <tromey@adacore.com>
1167
1168         * maint.c (_initialize_maint_cmds): Move initialization code to
1169         remote.c.
1170         (watchdog, show_watchdog): Move to remote.c.
1171         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1172         "watchdog" static.
1173         (_initialize_remote): Move initialization code from maint.c.
1174         * defs.h (watchdog): Don't declare.
1175
1176 2019-05-08  Tom Tromey  <tromey@adacore.com>
1177
1178         * tui/tui-interp.c: Include main.h.
1179         * interps.c: Include main.h.
1180         * main.h (interpreter_p): Declare.
1181         * defs.h (interpreter_p): Don't declare.
1182
1183 2019-05-08  Tom Tromey  <tromey@adacore.com>
1184
1185         * dwarf2loc.c: Include dwarf2read.h.
1186         * defs.h (read_unsigned_leb128): Don't declare.
1187         * dwarf2read.h (read_unsigned_leb128): Declare.
1188
1189 2019-05-08  Tom Tromey  <tromey@adacore.com>
1190
1191         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1192         method.
1193
1194 2019-05-08  Tom Tromey  <tromey@adacore.com>
1195
1196         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1197         when no wrap column is set.
1198
1199 2019-05-08  Tom Tromey  <tromey@adacore.com>
1200
1201         * c-lang.c (c_get_string): Handle non-C-style arrays.
1202
1203 2019-05-08  Tom Tromey  <tromey@adacore.com>
1204
1205         * typeprint.c (print_offset_data::update): Print the bit offset,
1206         not the number of bits remaining.
1207
1208 2019-05-08  Tom Tromey  <tromey@adacore.com>
1209
1210         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1211         padding at end of comment.
1212
1213 2019-05-08  Tom Tromey  <tromey@adacore.com>
1214
1215         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1216         Compare main types.
1217
1218 2019-05-06  Tom Tromey  <tom@tromey.com>
1219
1220         * common/scoped_mmap.c: Include common-defs.h.
1221         * common/scoped_mmap.h: Don't include config.h.
1222
1223 2019-05-04  Tom Tromey  <tom@tromey.com>
1224
1225         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1226         (struct aarch64_call_info): Add initializers.
1227         <si>: Now a std::vector.
1228         (pass_on_stack, aarch64_push_dummy_call): Update.
1229
1230 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1231             Tom Tromey  <tom@tromey.com>
1232
1233         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1234         (ppc_threads): Now a std::vector.  Now static.
1235         (hwdebug_find_thread_points_by_tid)
1236         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1237         Update.
1238
1239 2019-05-04  Tom Tromey  <tom@tromey.com>
1240
1241         * arc-tdep.c (arc_tdesc_init): Return bool.
1242
1243 2019-05-04  Tom Tromey  <tom@tromey.com>
1244
1245         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1246         Use gdb_assert_not_reached.
1247
1248 2019-05-04  Tom Tromey  <tom@tromey.com>
1249
1250         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1251         "false".
1252
1253 2019-05-04  Tom Tromey  <tom@tromey.com>
1254
1255         * arc-tdep.c (arc_tdesc_init): Use bool.
1256
1257 2019-05-04  Tom Tromey  <tom@tromey.com>
1258
1259         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1260
1261 2019-05-04  Tom Tromey  <tom@tromey.com>
1262
1263         * cli/cli-cmds.c (valid_command_p): Return bool.
1264
1265 2019-05-04  Tom Tromey  <tom@tromey.com>
1266
1267         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1268         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1269
1270 2019-05-04  Raul Tambre  <raul@tambre.ee>
1271
1272         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1273         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1274         operator for comparison.
1275
1276 2019-05-04  Tom Tromey  <tom@tromey.com>
1277
1278         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1279         (lookup_partial_symbol, print_partial_symbols)
1280         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1281         (psymbol_compare): Update.
1282         (add_psymbol_to_bcache): Clear the entire psymbol.
1283         (maintenance_check_psymtabs): Update.
1284         * psympriv.h (struct partial_symbol): Don't derive from
1285         general_symbol_info.
1286         <obj_section, unrelocated_address, address,
1287         set_unrelocated_address>: Update.
1288         <ginfo>: New member.
1289         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1290         (debug_names::write_psymbols): Update.
1291
1292 2019-05-04  Tom de Vries  <tdevries@suse.de>
1293
1294         * contrib/cc-with-tweaks.sh: Support -n arg.
1295
1296 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1297
1298         * corelow.c (core_target::detach): Ensure frame cache and
1299         register caches are cleared.
1300         inferior.c (exit_inferior_1): Likewise.
1301
1302 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1303             Tom Tromey  <tom@tromey.com>
1304
1305         * dictionary.c (collate_pending_symbols_by_language): Remove
1306         "struct" from foreach.
1307         * symtab.c (lookup_global_symbol_from_objfile)
1308         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1309         foreach.
1310         * ser-tcp.c (net_open): Remove "struct" from foreach.
1311         * objfiles.c (objfile_relocate, objfile_rebase)
1312         (objfile_has_symbols): Remove "struct" from foreach.
1313         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1314         from foreach.
1315         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1316         foreach.
1317         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1318         "struct" from foreach.
1319         * ada-lang.c (create_excep_cond_exprs)
1320         (ada_exception_catchpoint_cond_string): Remove "struct" from
1321         foreach.
1322
1323 2019-05-03  Tom Tromey  <tromey@adacore.com>
1324
1325         * ada-exp.y (convert_char_literal): Check suffix of each
1326         enumerator.
1327
1328 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1329
1330         PR ada/21406:
1331         * ada-exp.y (yywrap): Don't define.
1332         * ada-lex.l (%option): Add noyywrap
1333         (yywrap): Remove.
1334
1335 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1336
1337         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1338         _WIN32_WINNT to the XP level, unless already defined to a higher
1339         level.
1340
1341         * unittests/parse-connection-spec-selftests.c:
1342         * ser-tcp.c:
1343         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1344         override.
1345
1346         * symfile.c (find_separate_debug_file): Remove colon from the
1347         drive spec of DOS/Windows file names of the target, so that the
1348         file name produced from DEBUGDIR and the target's directory will
1349         be valid on DOS/Windows systems.
1350
1351 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * rust-lang.c (val_print_struct): Handle printing structures
1354         containing strings.
1355
1356 2019-05-02  Tom Tromey  <tromey@adacore.com>
1357
1358         * valarith.c (_initialize_valarith): Remove.
1359
1360 2019-05-01  Tom Tromey  <tromey@adacore.com>
1361
1362         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1363         bitfields.
1364
1365 2019-05-01  Tom Tromey  <tromey@adacore.com>
1366
1367         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1368         for big-endian copies.
1369
1370 2019-04-30  Ali Tamur  <tamur@google.com>
1371         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1372         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1373         (read_3_bytes): New function.
1374
1375 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1376
1377         * windows-nat.c (main_thread_id): Delete.
1378         (handle_output_debug_string): Replace main_thread_id by
1379         current_event.dwThreadId.
1380         (fake_create_process): Likewise.
1381         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1382         Do not set main_thread_id.
1383         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1384         current_event.dwThreadId.
1385         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1386
1387 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1388
1389         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1390         Use current_event.dwThreadId instead of main_thread_id.
1391
1392 2019-04-30  Tom Tromey  <tromey@adacore.com>
1393
1394         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1395         (create_excep_cond_exprs): Iterate over program spaces.
1396         (ada_exception_catchpoint_cond_string): Examine all minimal
1397         symbols for exception types.
1398
1399 2019-04-30  Tom Tromey  <tromey@adacore.com>
1400
1401         PR c++/24470:
1402         * dwarf2read.c (process_structure_scope): Handle case where type
1403         has template parameters but no symbol was created.
1404
1405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1406             Chris January  <chris.january@arm.com>
1407
1408         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1409         qualifier.
1410         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1411
1412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * f-typeprint.c (f_print_type): Update rules for printing
1415         whitespace.
1416         (f_type_print_varspec_suffix): Likewise.
1417
1418 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1419             Chris January  <chris.january@arm.com>
1420
1421         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1422         function arguments.
1423
1424 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * f-lang.c (build_fortran_types): Change name of void type to
1427         lower case.
1428         * f-typeprint.c (f_type_print_base): Print the name of the void
1429         type, rather than a fixed string.
1430         * f-valprint.c (f_decorations): Use lower case void string.
1431
1432 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1433             Chris January  <chris.january@arm.com>
1434
1435         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1436         types for Fortran.
1437
1438 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1439             Chris January  <chris.january@arm.com>
1440             David Lecomber  <david.lecomber@arm.com>
1441
1442         * f-exp.y (BINOP_INTRINSIC): New token.
1443         (exp): New parser rule handling BINOP_INTRINSIC.
1444         (f77_keywords): Add new builtin procedures.
1445         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1446         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1447         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1448         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1449         (print_unop_subexp_f): New function.
1450         (print_binop_subexp_f): New function.
1451         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1452         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1453         (dump_subexp_body_f): Likewise.
1454         (operator_check_f): Likewise.
1455         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1456         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1457
1458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1461         UNOP_KIND.
1462         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1463         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1464         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1465         (operator_length_f): New fuction.
1466         (print_subexp_f): New function.
1467         (op_name_f): New function.
1468         (dump_subexp_body_f): New function.
1469         (operator_check_f): New function.
1470         (exp_descriptor_f): Replace standard expression handling functions
1471         with new functions.
1472         * gdb/fortran-operator.def: New file.
1473         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1474         * gdb/std-operator.def: Remove UNOP_KIND.
1475
1476 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * std-operator.def: Remove unbalanced, stray double quote
1479         character.
1480
1481 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1482             Chris January  <chris.january@arm.com>
1483             Daniel Everett  <daniel.everett@arm.com>
1484             Nick Forrington  <nick.forrington@arm.com>
1485             Richard Bunt  <richard.bunt@arm.com>
1486
1487         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1488         of depth when printing anonymous structs or unions.
1489         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1490         Don't print either the top-level value, or the children if the
1491         max-depth is exceeded.
1492         (ppscm_print_children): When printing the key of a map, allow one
1493         extra level of depth.
1494         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1495         print either the top-level value, or the children if the max-depth
1496         is exceeded.
1497         (print_children): When printing the key of a map, allow one extra
1498         level of depth.
1499         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1500         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1501         (user_print_options): Initialise max_depth field.
1502         (val_print_scalar_or_string_type_p): New function.
1503         (val_print): Check to see if the max depth has been reached.
1504         (val_print_check_max_depth): Define new function.
1505         (show_print_max_depth): New function.
1506         (_initialize_valprint): Add 'print max-depth' option.
1507         * valprint.h (struct value_print_options) <max_depth>: New field.
1508         (val_print_check_max_depth): Declare new function.
1509         * NEWS: Document new feature.
1510
1511 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * ada-lang.c (ada_language_defn): Initialise new field.
1514         * c-lang.c (c_is_string_type_p): New function.
1515         (c_language_defn): Initialise new field.
1516         (cplus_language_defn): Initialise new field.
1517         (asm_language_defn): Initialise new field.
1518         (minimal_language_defn): Initialise new field.
1519         * c-lang.h (c_is_string_type_p): Declare new function.
1520         * d-lang.c (d_language_defn): Initialise new field.
1521         * f-lang.c (f_is_string_type_p): New function.
1522         (f_language_defn): Initialise new field.
1523         * go-lang.c (go_is_string_type_p): New function.
1524         (go_language_defn): Initialise new field.
1525         * language.c (default_is_string_type_p): New function.
1526         (unknown_language_defn): Initialise new field.
1527         (auto_language_defn): Initialise new field.
1528         * language.h (struct language_defn) <la_is_string_type_p>: New
1529         member variable.
1530         (default_is_string_type_p): Declare new function.
1531         * m2-lang.c (m2_language_defn): Initialise new field.
1532         * objc-lang.c (objc_language_defn): Initialise new field.
1533         * opencl-lang.c (opencl_language_defn): Initialise new field.
1534         * p-lang.c (pascal_is_string_type_p): New function.
1535         (pascal_language_defn): Initialise new field.
1536         * rust-lang.c (rust_is_string_type_p): New function.
1537         (rust_language_defn): Initialise new field.
1538
1539 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1540
1541         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1542         New field.
1543         * ada-lang.c (ada_language_defn): Initialise new field.
1544         * c-lang.c (c_language_defn): Likewise.
1545         (cplus_language_defn): Likewise.
1546         (asm_language_defn): Likewise.
1547         (minimal_language_defn): Likewise.
1548         * d-lang.c (d_language_defn): Likewise.
1549         * f-lang.c (f_language_defn): Likewise.
1550         * go-lang.c (go_language_defn): Likewise.
1551         * language.c (unknown_language_defn): Likewise.
1552         (auto_language_defn): Likewise.
1553         * m2-lang.c (m2_language_defn): Likewise.
1554         * objc-lang.c (objc_language_defn): Likewise.
1555         * opencl-lang.c (opencl_language_defn): Likewise.
1556         * p-lang.c (pascal_language_defn): Likewise.
1557         * rust-lang.c (rust_language_defn): Likewise.
1558
1559 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * ada-lang.c (ada_is_character_type): Change return type to bool.
1562         (ada_is_string_type): Likewise.
1563         * ada-lang.h (ada_is_character_type): Update declaration
1564         (ada_is_string_type): Likewise.
1565
1566 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1567
1568         Support style in 'frame|thread apply'
1569
1570         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1571         * record.c (record_start, record_stop): Update callers of
1572         execute_command_to_string with false.
1573         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1574         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1575         methods.
1576         (class string_file): New constructor with term_out parameter.
1577         Override methods term_out and can_emit_style_escape.  New member
1578         term_out.
1579         (class stdio_file): Override can_emit_style_escape.
1580         (class tee_file): Override term_out and can_emit_style_escape.
1581         * utils.h (can_emit_style_escape): Remove.
1582         * utils.c (can_emit_style_escape): Likewise.
1583         Update all callers of can_emit_style_escape (SOMESTREAM) to
1584         SOMESTREAM->can_emit_style_escape.
1585         * source-cache.c (source_cache::get_source_lines): Likewise.
1586         * stack.c (frame_apply_command_count): Call execute_command_to_string
1587         passing the term_out characteristic of the current gdb_stdout.
1588         * thread.c (thr_try_catch_cmd): Likewise.
1589         * top.c (execute_command_to_string): pass term_out parameter
1590         to construct the string_file for the command output.
1591         * ui-file.c (term_cli_styling): New function (most code moved
1592         from utils.c can_emit_style_escape).
1593         (string_file::string_file, string_file::can_emit_style_escape,
1594         stdio_file::can_emit_style_escape, tee_file::term_out,
1595         tee_file::can_emit_style_escape): New functions.
1596
1597 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1598
1599         * NEWS: Mention the new set|show may-call-functions.
1600         * infcall.c (may_call_functions_p): New variable.
1601         (show_may_call_functions_p): New function.
1602         (call_function_by_hand_dummy): Throws an error if not
1603         may-call-functions.
1604         (_initialize_infcall): Call add_setshow_boolean_cmd for
1605         may-call-functions.
1606
1607 2019-04-25  Keith Seitz  <keiths@redhat.com>
1608
1609         PR c++/24367
1610         * cp-support.c (inspect_type): Don't attempt substitutions
1611         of symbol with the same name.
1612
1613 2019-04-25  Tom Tromey  <tromey@adacore.com>
1614
1615         PR gdb/24475:
1616         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1617         static.
1618
1619 2019-04-25  Tom Tromey  <tromey@adacore.com>
1620
1621         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1622         rvalue reference.
1623         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1624         (gdb_xml_parser::parse): Use std::move.
1625         * python/python-internal.h (gdbpy_convert_exception): Take a const
1626         reference.
1627         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1628         std::move.
1629         * python/py-utils.c (gdbpy_convert_exception): Take a const
1630         reference.
1631         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1632         Use std::move.
1633         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1634         Use std::move.
1635         * mi/mi-main.c (mi_print_exception): Take a const reference.
1636         * main.c (handle_command_errors): Take a const reference.
1637         * linespec.c (parse_linespec): Use std::move.
1638         * infcall.c (run_inferior_call): Use std::move.
1639         (call_function_by_hand_dummy): Use std::move.
1640         * exec.c (try_open_exec_file): Use std::move.
1641         * exceptions.h (exception_print, exception_fprintf)
1642         (exception_print_same): Update.
1643         * exceptions.c (print_exception, exception_print)
1644         (exception_fprintf, exception_print_same): Change parameters to
1645         const reference.
1646         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1647         * common/new-op.c: Use std::move.
1648         * common/common-exceptions.h (struct gdb_exception): Add move
1649         constructor.
1650         (struct gdb_exception_error, struct gdb_exception_quit, struct
1651         gdb_quit_bad_alloc): Change constructor to move constructor.
1652         (throw_exception): Change parameter to rvalue reference.
1653         * common/common-exceptions.c (throw_exception): Take rvalue
1654         reference.
1655         * cli/cli-interp.c (safe_execute_command): Use std::move.
1656         * breakpoint.c (insert_bp_location, location_to_sals): Use
1657         std::move.
1658
1659 2019-04-25  Tom Tromey  <tromey@adacore.com>
1660
1661         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1662         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1663         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1664         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1665         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1666         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1667         guile/scm-value.c: Use unpack.
1668         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1669         gdbscm_gdb_exception.
1670         (gdbscm_throw_gdb_exception): Likewise.
1671         (struct gdbscm_gdb_exception): New.
1672         (unpack): New function.
1673         (gdbscm_wrap): Use unpack.
1674
1675 2019-04-25  Tom Tromey  <tromey@adacore.com>
1676
1677         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1678         (gdb_rl_callback_handler): Use std::move.
1679         * common/common-exceptions.h (struct gdb_exception): Add move
1680         assignment operator.
1681         (throw_exception_sjlj): Change "exception" to const reference.
1682         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1683         (throw_exception_sjlj): Change "exception" to const reference.
1684
1685 2019-04-25  Tom Tromey  <tromey@adacore.com>
1686
1687         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1688         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1689         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1690         Update.
1691         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1692         Update.
1693         * mi/mi-interp.c (mi_interp::exec): Update.
1694         * linespec.c (parse_linespec): Update.
1695         * infcall.c (run_inferior_call): Update.
1696         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1697         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1698         (gdbscm_lookup_global_symbol): Update.
1699         * guile/scm-param.c (gdbscm_parameter_value): Update.
1700         * guile/scm-frame.c (gdbscm_frame_read_register)
1701         (gdbscm_frame_read_var): Update.
1702         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1703         * exec.c (try_open_exec_file): Update.
1704         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1705         (gdb_rl_callback_handler): Update.
1706         * common/common-exceptions.h (exception_none): Don't declare.
1707         * common/common-exceptions.c (exception_none): Don't define.
1708         (struct catcher) <exception>: Update.
1709         * cli/cli-interp.c (safe_execute_command): Update.
1710         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1711
1712 2019-04-25  Ali Tamur  <tamur@google.com>
1713
1714         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1715         (read_attribute_value): Likewise.
1716         (dwarf2_read_addr_index): Update comment.
1717         (read_str_index): Add DW_FORM_strx.
1718         (dwarf2_string_attr): Likewise.
1719         (dwarf2_const_value_attr): Likewise.
1720         (dump_die_shallow): Likewise.
1721         (dwarf2_fetch_constant_bytes): Likewise.
1722         (skip_form_bytes): Likewise.
1723         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1724
1725 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1726
1727         PR corefiles/11608
1728         PR corefiles/18187
1729         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1730         OFFSET.  Verify if current mapping contains an ELF header.
1731         (linux_find_memory_regions_full): Adjust call to
1732         dump_mapping_p.
1733
1734 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1735             Kang Li <kanglictf@gmail.com>
1736
1737         PR gdb/21600
1738
1739         * dwarf2-frame.c (read_initial_length): Be consistent about using
1740         unsigned representation of length.
1741         (decode_frame_entry_1): Likewise.  Check for wraparound of
1742         end pointer as well as buffer overflow.
1743
1744 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1745
1746         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1747         "vq".
1748
1749 2019-04-24  Tom Tromey  <tromey@adacore.com>
1750
1751         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1752
1753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * s12z-tdep.c (s12z_unwind_pc): Delete.
1756         (s12z_unwind_sp): Delete.
1757         (s12z_gdbarch_init): Don't register deleted functions with
1758         gdbarch.
1759
1760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1761
1762         * rl78-tdep.c (rl78_unwind_sp): Delete.
1763         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1764
1765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1766
1767         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1768         (xstormy16_unwind_pc): Delete.
1769         (xstormy16_dummy_id): Delete.
1770         (xstormy16_gdbarch_init): Don't register deleted functions with
1771         gdbarch.
1772
1773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * vax-tdep.c (vax_unwind_pc): Delete.
1776         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1777
1778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1779
1780         * v850-tdep.c (v850_unwind_sp): Delete.
1781         (v850_unwind_pc): Delete.
1782         (v850_dummy_id): Delete.
1783         (v850_gdbarch_init): Don't register deleted functions with
1784         gdbarch.
1785
1786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1789         (tilegx_unwind_pc): Delete.
1790         (tilegx_unwind_dummy_id): Delete.
1791         (tilegx_gdbarch_init): Don't register deleted functions with
1792         gdbarch.
1793
1794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1797         (tic6x_dummy_id): Delete.
1798         (tic6x_gdbarch_init): Don't register deleted functions with
1799         gdbarch.
1800
1801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * sparc-tdep.c (sparc_unwind_pc): Delete.
1804         (sparc32_gdbarch_init): Don't register deleted function with
1805         gdbarch.
1806
1807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * sh-tdep.c (sh_unwind_sp): Delete.
1810         (sh_unwind_pc): Delete.
1811         (sh_dummy_id): Delete.
1812         (sh_gdbarch_init): Don't register deleted functions with
1813         gdbarch.
1814
1815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1816
1817         * score-tdep.c (score_unwind_sp): Delete.
1818         (score_unwind_pc): Delete.
1819         (score_dummy_id): Delete.
1820         (score_gdbarch_init): Don't register deleted functions with
1821         gdbarch.
1822
1823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * rx-tdep.c (rx_unwind_pc): Delete.
1826         (rx_unwind_sp): Delete.
1827         (rx_dummy_id): Delete.
1828         (rx_gdbarch_init): Don't register deleted functions with
1829         gdbarch.  Update comment.
1830
1831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1834         (rs6000_dummy_id): Delete.
1835         (rs6000_gdbarch_init): Don't register deleted functions with
1836         gdbarch.
1837
1838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * or1k-tdep.c (or1k_dummy_id): Delete.
1841         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1842
1843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * nios2-tdep.c (nios2_dummy_id): Delete.
1846         (nios2_unwind_sp): Delete.
1847         (nios2_gdbarch_init): Don't register deleted functions with
1848         gdbarch.
1849
1850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1851
1852         * nds32-tdep.c (nds32_dummy_id): Delete.
1853         (nds32_unwind_pc): Delete.
1854         (nds32_unwind_sp): Delete.
1855         (nds32_gdbarch_init): Don't register deleted functions with
1856         gdbarch.
1857
1858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1859
1860         * msp430-tdep.c (msp430_unwind_pc): Delete.
1861         (msp430_unwind_sp): Delete.
1862         (msp430_dummy_id): Delete.
1863         (msp430_gdbarch_init): Don't register deleted functions with
1864         gdbarch.
1865
1866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         * moxie-tdep.c (moxie_unwind_sp): Delete.
1869         (moxie_unwind_pc): Delete.
1870         (moxie_dummy_id): Delete.
1871         (moxie_gdbarch_init): Don't register deleted functions with
1872         gdbarch.
1873
1874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1877         (mn10300_unwind_pc): Delete.
1878         (mn10300_unwind_sp): Delete.
1879         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1880         mn10300_unwind_sp.
1881         (mn10300_frame_unwind_init): Don't register deleted functions with
1882         gdbarch.
1883
1884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * mep-tdep.c (mep_unwind_pc): Delete.
1887         (mep_unwind_sp): Delete.
1888         (mep_dummy_id): Delete.
1889         (mep_gdbarch_init): Don't register deleted functions with
1890         gdbarch.
1891
1892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1893
1894         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1895         (m68hc11_unwind_sp): Delete.
1896         (m68hc11_gdbarch_init): Don't register deleted functions with
1897         gdbarch.
1898
1899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1900
1901         * m32r-tdep.c (m32r_unwind_sp): Delete.
1902         (m32r_unwind_pc): Delete.
1903         (m32r_dummy_id): Delete.
1904         (m32r_gdbarch_init): Don't register deleted functions with
1905         gdbarch.
1906
1907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * m32c-tdep.c (m32c_unwind_pc): Delete.
1910         (m32c_unwind_sp): Delete.
1911         (m32c_dummy_id): Delete.
1912         (m32c_gdbarch_init): Don't register deleted functions with
1913         gdbarch.
1914
1915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1916
1917         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1918         (lm32_unwind_pc): Delete.
1919         (lm32_dummy_id): Delete.
1920         (lm32_gdbarch_init): Don't register deleted functions with
1921         gdbarch.
1922
1923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1926         (iq2000_unwind_pc): Delete.
1927         (iq2000_dummy_id): Delete.
1928         (iq2000_gdbarch_init): Don't register deleted functions with
1929         gdbarch.
1930
1931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * nds32-tdep.c (nds32_type_align): Delete.
1934         (nds32_push_dummy_call): Use type_align instead.
1935
1936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * arm-tdep.c (arm_type_align): Only handle vector override case.
1939         (arm_push_dummy_call): Use type_align.
1940         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1941
1942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1943
1944         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1945         case.
1946         (pass_on_stack): Use type_align.
1947         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1948         function.
1949
1950 2019-04-23  Tom Tromey  <tromey@adacore.com>
1951
1952         * dwarf2read.c (line_header::file_name_at): Remove unused
1953         overload.
1954
1955 2019-04-23  Tom de Vries  <tdevries@suse.de>
1956
1957         PR gdb/24438
1958         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1959         invocation.
1960
1961
1962 2019-03-27  Ali Tamur  <tamur@google.com>
1963
1964         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1965         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1966         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1967         (dwarf_expr_context::get_addr_index): Likewise
1968         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1969         (symbol_needs_eval_context::get_addr_index): Likewise
1970         (disassemble_dwarf_expression): Add DW_OP_addrx
1971         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1972         (read_cutu_die_from_dwo): Update comment
1973         (skip_one_die): Add DW_FORM_addrx
1974         (read_attribute_value): Likewise
1975         (var_decode_location): Add DW_OP_addrx
1976         (dwarf2_const_value_attr): Add DW_FORM_addrx
1977         (dump_die_shallow): Likewise
1978         (dwarf2_fetch_constant_bytes): Likewise
1979         (decode_locdesc): Add DW_OP_addrx
1980         (skip_form_bytes): Add DW_FORM_addrx
1981
1982 2019-04-22  Ali Tamur  <tamur@google.com>
1983
1984         * MAINTAINERS (Write After Approval): Add self.
1985
1986 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1987
1988         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1989         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1990         (open_symbol_file_object): Likewise.
1991         (svr4_default_sos): Add info parameter.
1992         (svr4_read_so_list): Likewise.
1993         (svr4_current_sos_direct): Adjust functions calls to pass down
1994         info.
1995         (svr4_current_sos_1): Add info parameter.
1996         (svr4_current_sos): Call get_svr4_info, pass info down to
1997         svr4_current_sos_1.
1998         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1999         get_svr4_info.
2000         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2001         get_svr4_info.
2002         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2003         to get_svr4_info.
2004         (probes_table_remove_objfile_probes): Likewise.
2005         (register_solib_event_probe): Add info parameter.
2006         (solist_update_incremental): Pass info parameter down to
2007         svr4_read_so_list.
2008         (disable_probes_interface): Add info parameter.
2009         (svr4_handle_solib_event): Pass current_program_space to
2010         get_svr4_info.  Adjust disable_probes_interface cleanup.
2011         (svr4_create_probe_breakpoints): Add info parameter, pass it
2012         down to register_solib_event_probe.
2013         (svr4_create_solib_event_breakpoints): Add info parameter,
2014         pass it down to svr4_create_probe_breakpoints.
2015         (enable_break): Pass info down to
2016         svr4_create_solib_event_breakpoints.
2017         (svr4_solib_create_inferior_hook): Pass current_program_space to
2018         get_svr4_info.
2019         (svr4_clear_solib): Likewise.
2020
2021 2019-04-22  Pedro Alves  <palves@redhat.com>
2022
2023         * solib-svr4.c (svr4_free_objfile_observer): New.
2024         (probe_and_action::objfile): New field.
2025         (probes_table_htab_remove_objfile_probes)
2026         (probes_table_remove_objfile_probes): New functions.
2027         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2028         in the new probe_and_action.  Don't store the probe in 'lookup'.
2029         (svr4_create_probe_breakpoints): Pass objfile to
2030         register_solib_event_probe.
2031         (_initialize_svr4_solib): Register a free_objfile observer.
2032
2033 2019-04-19  Tom Tromey  <tom@tromey.com>
2034
2035         * common/queue.h: Remove.
2036
2037 2019-04-19  Tom Tromey  <tom@tromey.com>
2038
2039         * event-loop.c: Don't include "common/queue.h".
2040
2041 2019-04-19  Tom Tromey  <tom@tromey.com>
2042
2043         * remote.c (remote_target): Use delete.
2044         * remote-notif.h: Include <list>, not "common/queue.h".
2045         (notif_client_p): Remove typedef.
2046         (remote_notif_state): Add constructor, destructor, initializer.
2047         <notif_queue>: Now a std::list.
2048         (remote_notif_state_xfree): Don't declare.
2049         * remote-notif.c (remote_notif_process, handle_notification)
2050         (remote_notif_state_allocate): Update.
2051         (~remote_notif_state): Rename from remote_notif_state_xfree.
2052
2053 2019-04-19  Tom Tromey  <tom@tromey.com>
2054
2055         * symfile.c (reread_symbols): Update.
2056         * objfiles.c (objfile_register_static_link)
2057         (objfile_lookup_static_link): Update
2058         (~objfile) Don't delete static_links.
2059         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2060
2061 2019-04-19  Tom Tromey  <tom@tromey.com>
2062
2063         * type-stack.h (struct type_stack) <insert>: Constify string.
2064         * type-stack.c (type_stack::insert): Constify string.
2065         * gdbtypes.h (lookup_template_type): Update.
2066         (address_space_name_to_int): Update.
2067         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2068         const.
2069         (lookup_template_type): Make name const.
2070         * c-exp.y: Update rules.
2071         (lex_one_token, classify_name, classify_inner_name)
2072         (c_print_token): Update.
2073         * p-exp.y: Update rules.
2074         (yylex): Update.
2075         * f-exp.y: Update rules.
2076         (yylex): Update.
2077         * d-exp.y: Update rules.
2078         (lex_one_token, classify_name, classify_inner_name): Update.
2079         * parse.c (write_dollar_variable, copy_name): Return std::string.
2080         * parser-defs.h (copy_name): Change return type.
2081         * m2-exp.y: Update rules.
2082         (yylex): Update.
2083         * go-exp.y (lex_one_token): Update.
2084         Update rules.
2085         (classify_unsafe_function, classify_packaged_name)
2086         (classify_name, yylex): Update.
2087
2088 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2089
2090         * configure.ac: add --enable-source-highlight switch.
2091         * configure: Regenerate.
2092         * top.c (print_gdb_version): plumb --enable-source-highlight
2093         status to "show configuration".
2094
2095 2019-04-19  Tom Tromey  <tromey@adacore.com>
2096
2097         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2098         Check ADA_TYPE_P.
2099         (empty_record, ada_template_to_fixed_record_type_1)
2100         (template_to_static_fixed_type)
2101         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2102         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2103         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2104         macros.
2105
2106 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2107
2108         PR symtab/24423:
2109         * source.c (print_source_lines_base): Advance "iter" when a
2110         control character is seen.
2111
2112 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2113
2114         * inferior.h (struct infcall_suspend_state_deleter):
2115         Catch exception in destructor to avoid crash.
2116
2117 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2118
2119         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2120         close to the add_com "shell".
2121
2122 2019-04-18  Tom Tromey  <tromey@adacore.com>
2123
2124         * process-stratum-target.h (class process_stratum_target)
2125         <stratum>: Add "final".
2126
2127 2019-04-17  Tom Tromey  <tromey@adacore.com>
2128
2129         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2130         against nullptr before use.
2131
2132 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2133
2134         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2135
2136 2019-04-17  Jim Wilson  <jimw@sifive.com>
2137             Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2140         code read might fail, assume 4-byte breakpoint in that case.
2141
2142 2019-04-15  Leszek Swirski  <leszeks@google.com>
2143
2144         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2145         rather than a hand-rolled POD check when checking for forced MEMORY
2146         classification.
2147
2148 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2149
2150         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2151         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2152         function.
2153         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2154         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2155         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2156         declaration.
2157
2158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2159
2160         * aarch64-linux-nat.c
2161         (aarch64_linux_nat_target::thread_architecture): Add override.
2162         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2163         each VQ.
2164
2165 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2166
2167         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2168
2169 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2172         target types of size 96-bits, add some additional comments, and
2173         check that the builtin type we found was the correct size.
2174
2175 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2176
2177         * utils.c (prompt_for_continue): Don't restore the styling at the
2178         end, as applied_style has the wrong value.  This fixes styling in
2179         long lists of file names that are interrupted by the "Continue?"
2180         prompt.
2181
2182 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2183
2184         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2185         * c-lang.c (c_language_defn): Likewise.
2186         (cplus_language_defn): Likewise.
2187         (asm_language_defn): Likewise.
2188         (minimal_language_defn): Likewise.
2189         * d-lang.c (d_language_defn): Likewise.
2190         * f-lang.c (f_language_defn): Likewise.
2191         * go-lang.c (go_language_defn): Likewise.
2192         * language.c (unknown_language_defn): Likewise.
2193         (auto_language_defn): Likewise.
2194         * language.h (struct language_defn): Remove la_magic field.
2195         (LANG_MAGIC): Delete.
2196         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2197         * objc-lang.c (objc_language_defn): Likewise.
2198         * opencl-lang.c (opencl_language_defn): Likewise.
2199         * p-lang.c (pascal_language_defn): Likewise.
2200         * rust-lang.c (rust_language_defn): Likewise.
2201
2202 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * riscv-tdep.c (riscv_type_align): New function.
2205         (riscv_type_alignment): Delete.
2206         (riscv_arg_location): Use 'type_align'.
2207         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2208
2209 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * gdbtypes.c (type_align): A struct with no non-static fields also
2212         has alignment of 1.
2213
2214 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2217         component to 0.
2218         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2219         member.
2220         (riscv_struct_info::analyse): New implementation using new
2221         analyse_inner member function.
2222         (riscv_struct_info::field_offset): New member function.
2223         (riscv_struct_info::m_offsets): New member variable.
2224         (riscv_struct_info::analyse_inner): New private member function,
2225         takes the old implementation of riscv_struct_info::analyse but
2226         extended to track field offsets.
2227         (riscv_call_arg_struct): Update the struct folding special cases
2228         to handle cases where empty C++ structs, which are non-zero
2229         length, are found.
2230         (riscv_arg_location): Initialise the length of each location, a
2231         non-zero length now indicates the location is in use.
2232         (riscv_push_dummy_call): Allow for the first location having a
2233         non-zero offset when setting up arguments.
2234         (riscv_return_value): Likewise, but for return values.
2235
2236 2019-04-11  Tom Tromey  <tromey@adacore.com>
2237
2238         * utils.c (internal_vproblem): Make "msg" const.
2239
2240 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2241
2242         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2243         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2244         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2245         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2246
2247 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2248
2249         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2250         function.
2251         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2252         of amd64_collect_native_gregset.
2253         (amd64_linux_nat_target::store_registers): Likewise.
2254
2255 2019-04-10  Tom Tromey  <tom@tromey.com>
2256
2257         * symtab.c (lookup_global_symbol_from_objfile)
2258         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2259         * objfiles.h (class separate_debug_iterator): New.
2260         (class separate_debug_range): New.
2261         (struct objfile) <separate_debug_objfiles>: New method.
2262         (objfile_separate_debug_iterate): Don't declare.
2263         * objfiles.c (separate_debug_iterator::operator++): Rename from
2264         objfile_separate_debug_iterate.
2265         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2266         iterator.
2267         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2268         iterator.
2269
2270 2019-04-10  Tom Tromey  <tom@tromey.com>
2271
2272         * symfile.c (reread_symbols): Remove old comment.
2273         * objfiles.c (free_all_objfiles): Fix a typo.
2274
2275 2019-04-10  Tom Tromey  <tom@tromey.com>
2276
2277         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2278         * minsyms.c (lookup_minimal_symbol): Use foreach.
2279         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2280         (lookup_minimal_symbol_solib_trampoline): Likewise.
2281         * symfile.c (reread_symbols): Use foreach.
2282
2283 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2284             Tom Tromey  <tromey@adacore.com>
2285
2286         PR rust/24414:
2287         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2288         (rust_lex_int_test): Change "value" to be LONGEST.
2289         (rust_lex_tests): Add test for long integer literal.
2290
2291 2019-04-09  Tom Tromey  <tromey@adacore.com>
2292
2293         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2294         to bool.
2295         (extended_remote_target::attach): Update.
2296         (remote_target::remote_notice_new_inferior): Update.
2297         (remote_target::add_current_inferior_and_thread): Update.
2298         * inferior.c (exit_inferior_1): Use "false".
2299         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2300
2301 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2302
2303         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2304         the "start" command.
2305
2306 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2307
2308         * python/py-inferior.c (infpy_thread_from_thread_handle):
2309         Adjust comments to reflect renaming of thread_from_thread_handle
2310         to thread_from_handle.  Adjust keywords.  Fix type error message.
2311         (inferior_object_methods): Add thread_from_handle.  Retain
2312         thread_from_thread_handle, but mark it as deprecated.
2313
2314 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2315
2316         * gdbthread.h (find_thread_by_handle): Revise declaration.
2317         * thread.c (find_thread_by_handle): Likewise.  Adjust
2318         implementation too.
2319         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2320         support for buffer objects as handles.
2321
2322 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2323
2324         * python/py-infthread.c (thpy_thread_handle): New function.
2325         (thread_object_methods): Register thpy_thread_handle.
2326
2327 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2328
2329         * gdbthread.h (thread_to_thread_handle): Declare.
2330         * thread.c (gdbtypes.h): Include.
2331         (thread_to_thread_handle): New function.
2332
2333         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2334         (target_thread_info_to_thread_handle): Declare.
2335         * target.c (target_thread_info_to_thread_handle): New function.
2336         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2337         * target-delegates.c: Regenerate.
2338
2339         * linux-thread-db.c (class thread_db_target): Add method
2340         thread_info_to_thread_handle.
2341         (thread_db_target::thread_info_to_thread_handle): Define.
2342         * remote.c (class remote_target): Add new method
2343         thread_info_to_thread_handle.
2344         (remote_target::thread_info_to_thread_handle): Define.
2345
2346 2019-04-08  Pedro Alves  <palves@redhat.com>
2347
2348         * common/common-exceptions.c (throw_exception): Don't create
2349         named object to throw; throw directly.
2350         (throw_it): Likewise.  Don't initialize gdb_exception::message
2351         here, with new; pass FMT and AP to the ctor instead.
2352         * common/common-exceptions.h: Include <string>.
2353         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2354         const char *, va_list)): New ctor.  Use std::make_shared.
2355         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2356         errors)): Delete.
2357         (gdb_exception_error::gdb_exception_error(enum errors, const char
2358         *, va_list)): New.
2359         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2360         Add assertion.
2361         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2362         errors)): Delete.
2363         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2364         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2365         Add assertion.
2366
2367 2019-04-08  Tom Tromey  <tom@tromey.com>
2368
2369         * valops.c (value_rtti_indirect_type): Replace throw_exception
2370         with throw.
2371         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2372         with throw.
2373         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2374         throw.
2375         * target.c (target_translate_tls_address): Replace throw_exception
2376         with throw.
2377         * stack.c (frame_apply_command_count): Replace throw_exception
2378         with throw.
2379         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2380         throw.
2381         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2382         with throw.
2383         * rs6000-tdep.c (rs6000_frame_cache)
2384         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2385         * remote.c: Replace throw_exception with throw.
2386         * record-full.c (record_full_message, record_full_wait_1)
2387         (record_full_restore): Replace throw_exception with throw.
2388         * record-btrace.c:
2389         (get_thread_current_frame_id, record_btrace_start_replaying)
2390         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2391         (cmd_record_btrace_start): Replace throw_exception with throw.
2392         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2393         throw.
2394         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2395         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2396         * linespec.c:
2397         (find_linespec_symbols): Replace throw_exception with throw.
2398         * infrun.c (displaced_step_prepare, resume): Replace
2399         throw_exception with throw.
2400         * infcmd.c (post_create_inferior): Replace throw_exception with
2401         throw.
2402         * inf-loop.c (inferior_event_handler): Replace throw_exception
2403         with throw.
2404         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2405         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2406         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2407         (get_prev_frame_always, get_frame_pc_if_available)
2408         (get_frame_address_in_block_if_available, get_frame_language):
2409         Replace throw_exception with throw.
2410         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2411         throw_exception with throw.
2412         * eval.c (fetch_subexp_value, evaluate_var_value)
2413         (evaluate_funcall, evaluate_subexp_standard): Replace
2414         throw_exception with throw.
2415         * dwarf2loc.c (call_site_find_chain)
2416         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2417         Replace throw_exception with throw.
2418         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2419         with throw.
2420         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2421         throw.
2422         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2423         * completer.c (complete_line_internal): Replace throw_exception
2424         with throw.
2425         * compile/compile-object-run.c (compile_object_run): Replace
2426         throw_exception with throw.
2427         * cli/cli-script.c (process_next_line): Replace throw_exception
2428         with throw.
2429         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2430         (btrace_enable, btrace_maint_update_pt_packets): Replace
2431         throw_exception with throw.
2432         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2433         throw_exception with throw.
2434         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2435         throw_exception with throw.
2436         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2437         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2438         * aarch64-tdep.c (aarch64_make_prologue_cache)
2439         (aarch64_make_stub_cache): Replace throw_exception with throw.
2440
2441 2019-04-08  Tom Tromey  <tom@tromey.com>
2442
2443         * common/common-exceptions.c (throw_exception): Rename from
2444         throw_exception_cxx.  Remove old copy.  Make argument const.
2445         (throw_it): Create and throw exception objects directly.
2446         * common/common-exceptions.h (throw_exception): Make argument
2447         const.
2448         (struct gdb_exception_error): Add constructor.
2449         (struct gdb_exception_quit): Add constructor.
2450
2451 2019-04-08  Tom Tromey  <tom@tromey.com>
2452
2453         * common/common-exceptions.h (exception_rethrow): Don't declare.
2454         (TRY_SJLJ): Update comment.
2455         (TRY, CATCH, END_CATCH): Remove.
2456         * common/common-exceptions.c (exception_rethrow): Remove.
2457
2458 2019-04-08  Tom Tromey  <tom@tromey.com>
2459
2460         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2461         Remove.
2462         (gdb_exception_error): Rename from
2463         gdb_exception_RETURN_MASK_ERROR.
2464         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2465         (gdb_quit_bad_alloc): Update.
2466         * aarch64-tdep.c: Update.
2467         * ada-lang.c: Update.
2468         * ada-typeprint.c: Update.
2469         * ada-valprint.c: Update.
2470         * amd64-tdep.c: Update.
2471         * arch-utils.c: Update.
2472         * break-catch-throw.c: Update.
2473         * breakpoint.c: Update.
2474         * btrace.c: Update.
2475         * c-varobj.c: Update.
2476         * cli/cli-cmds.c: Update.
2477         * cli/cli-interp.c: Update.
2478         * cli/cli-script.c: Update.
2479         * common/common-exceptions.c: Update.
2480         * common/new-op.c: Update.
2481         * common/selftest.c: Update.
2482         * compile/compile-c-symbols.c: Update.
2483         * compile/compile-cplus-symbols.c: Update.
2484         * compile/compile-object-load.c: Update.
2485         * compile/compile-object-run.c: Update.
2486         * completer.c: Update.
2487         * corelow.c: Update.
2488         * cp-abi.c: Update.
2489         * cp-support.c: Update.
2490         * cp-valprint.c: Update.
2491         * darwin-nat.c: Update.
2492         * disasm-selftests.c: Update.
2493         * dtrace-probe.c: Update.
2494         * dwarf-index-cache.c: Update.
2495         * dwarf-index-write.c: Update.
2496         * dwarf2-frame-tailcall.c: Update.
2497         * dwarf2-frame.c: Update.
2498         * dwarf2loc.c: Update.
2499         * dwarf2read.c: Update.
2500         * eval.c: Update.
2501         * event-loop.c: Update.
2502         * event-top.c: Update.
2503         * exec.c: Update.
2504         * f-valprint.c: Update.
2505         * fbsd-tdep.c: Update.
2506         * frame-unwind.c: Update.
2507         * frame.c: Update.
2508         * gdbtypes.c: Update.
2509         * gnu-v3-abi.c: Update.
2510         * guile/guile-internal.h: Update.
2511         * guile/scm-block.c: Update.
2512         * guile/scm-breakpoint.c: Update.
2513         * guile/scm-cmd.c: Update.
2514         * guile/scm-disasm.c: Update.
2515         * guile/scm-frame.c: Update.
2516         * guile/scm-lazy-string.c: Update.
2517         * guile/scm-math.c: Update.
2518         * guile/scm-param.c: Update.
2519         * guile/scm-ports.c: Update.
2520         * guile/scm-pretty-print.c: Update.
2521         * guile/scm-symbol.c: Update.
2522         * guile/scm-symtab.c: Update.
2523         * guile/scm-type.c: Update.
2524         * guile/scm-value.c: Update.
2525         * i386-linux-tdep.c: Update.
2526         * i386-tdep.c: Update.
2527         * inf-loop.c: Update.
2528         * infcall.c: Update.
2529         * infcmd.c: Update.
2530         * infrun.c: Update.
2531         * jit.c: Update.
2532         * language.c: Update.
2533         * linespec.c: Update.
2534         * linux-fork.c: Update.
2535         * linux-nat.c: Update.
2536         * linux-tdep.c: Update.
2537         * linux-thread-db.c: Update.
2538         * main.c: Update.
2539         * mi/mi-cmd-break.c: Update.
2540         * mi/mi-cmd-stack.c: Update.
2541         * mi/mi-interp.c: Update.
2542         * mi/mi-main.c: Update.
2543         * objc-lang.c: Update.
2544         * p-valprint.c: Update.
2545         * parse.c: Update.
2546         * ppc-linux-tdep.c: Update.
2547         * printcmd.c: Update.
2548         * python/py-arch.c: Update.
2549         * python/py-breakpoint.c: Update.
2550         * python/py-cmd.c: Update.
2551         * python/py-finishbreakpoint.c: Update.
2552         * python/py-frame.c: Update.
2553         * python/py-framefilter.c: Update.
2554         * python/py-gdb-readline.c: Update.
2555         * python/py-inferior.c: Update.
2556         * python/py-infthread.c: Update.
2557         * python/py-lazy-string.c: Update.
2558         * python/py-linetable.c: Update.
2559         * python/py-objfile.c: Update.
2560         * python/py-param.c: Update.
2561         * python/py-prettyprint.c: Update.
2562         * python/py-progspace.c: Update.
2563         * python/py-record-btrace.c: Update.
2564         * python/py-record.c: Update.
2565         * python/py-symbol.c: Update.
2566         * python/py-type.c: Update.
2567         * python/py-unwind.c: Update.
2568         * python/py-utils.c: Update.
2569         * python/py-value.c: Update.
2570         * python/python.c: Update.
2571         * record-btrace.c: Update.
2572         * record-full.c: Update.
2573         * remote-fileio.c: Update.
2574         * remote.c: Update.
2575         * riscv-tdep.c: Update.
2576         * rs6000-aix-tdep.c: Update.
2577         * rs6000-tdep.c: Update.
2578         * rust-exp.y: Update.
2579         * rust-lang.c: Update.
2580         * s390-tdep.c: Update.
2581         * selftest-arch.c: Update.
2582         * solib-dsbt.c: Update.
2583         * solib-frv.c: Update.
2584         * solib-spu.c: Update.
2585         * solib-svr4.c: Update.
2586         * solib.c: Update.
2587         * sparc64-linux-tdep.c: Update.
2588         * stack.c: Update.
2589         * symfile-mem.c: Update.
2590         * symmisc.c: Update.
2591         * target.c: Update.
2592         * thread.c: Update.
2593         * top.c: Update.
2594         * tracefile-tfile.c: Update.
2595         * tui/tui.c: Update.
2596         * typeprint.c: Update.
2597         * unittests/cli-utils-selftests.c: Update.
2598         * unittests/parse-connection-spec-selftests.c: Update.
2599         * valops.c: Update.
2600         * valprint.c: Update.
2601         * value.c: Update.
2602         * varobj.c: Update.
2603         * windows-nat.c: Update.
2604         * x86-linux-nat.c: Update.
2605         * xml-support.c: Update.
2606
2607 2019-04-08  Tom Tromey  <tom@tromey.com>
2608
2609         * xml-support.c: Use C++ exception handling.
2610         * x86-linux-nat.c: Use C++ exception handling.
2611         * windows-nat.c: Use C++ exception handling.
2612         * varobj.c: Use C++ exception handling.
2613         * value.c: Use C++ exception handling.
2614         * valprint.c: Use C++ exception handling.
2615         * valops.c: Use C++ exception handling.
2616         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2617         handling.
2618         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2619         * typeprint.c: Use C++ exception handling.
2620         * tui/tui.c: Use C++ exception handling.
2621         * tracefile-tfile.c: Use C++ exception handling.
2622         * top.c: Use C++ exception handling.
2623         * thread.c: Use C++ exception handling.
2624         * target.c: Use C++ exception handling.
2625         * symmisc.c: Use C++ exception handling.
2626         * symfile-mem.c: Use C++ exception handling.
2627         * stack.c: Use C++ exception handling.
2628         * sparc64-linux-tdep.c: Use C++ exception handling.
2629         * solib.c: Use C++ exception handling.
2630         * solib-svr4.c: Use C++ exception handling.
2631         * solib-spu.c: Use C++ exception handling.
2632         * solib-frv.c: Use C++ exception handling.
2633         * solib-dsbt.c: Use C++ exception handling.
2634         * selftest-arch.c: Use C++ exception handling.
2635         * s390-tdep.c: Use C++ exception handling.
2636         * rust-lang.c: Use C++ exception handling.
2637         * rust-exp.y: Use C++ exception handling.
2638         * rs6000-tdep.c: Use C++ exception handling.
2639         * rs6000-aix-tdep.c: Use C++ exception handling.
2640         * riscv-tdep.c: Use C++ exception handling.
2641         * remote.c: Use C++ exception handling.
2642         * remote-fileio.c: Use C++ exception handling.
2643         * record-full.c: Use C++ exception handling.
2644         * record-btrace.c: Use C++ exception handling.
2645         * python/python.c: Use C++ exception handling.
2646         * python/py-value.c: Use C++ exception handling.
2647         * python/py-utils.c: Use C++ exception handling.
2648         * python/py-unwind.c: Use C++ exception handling.
2649         * python/py-type.c: Use C++ exception handling.
2650         * python/py-symbol.c: Use C++ exception handling.
2651         * python/py-record.c: Use C++ exception handling.
2652         * python/py-record-btrace.c: Use C++ exception handling.
2653         * python/py-progspace.c: Use C++ exception handling.
2654         * python/py-prettyprint.c: Use C++ exception handling.
2655         * python/py-param.c: Use C++ exception handling.
2656         * python/py-objfile.c: Use C++ exception handling.
2657         * python/py-linetable.c: Use C++ exception handling.
2658         * python/py-lazy-string.c: Use C++ exception handling.
2659         * python/py-infthread.c: Use C++ exception handling.
2660         * python/py-inferior.c: Use C++ exception handling.
2661         * python/py-gdb-readline.c: Use C++ exception handling.
2662         * python/py-framefilter.c: Use C++ exception handling.
2663         * python/py-frame.c: Use C++ exception handling.
2664         * python/py-finishbreakpoint.c: Use C++ exception handling.
2665         * python/py-cmd.c: Use C++ exception handling.
2666         * python/py-breakpoint.c: Use C++ exception handling.
2667         * python/py-arch.c: Use C++ exception handling.
2668         * printcmd.c: Use C++ exception handling.
2669         * ppc-linux-tdep.c: Use C++ exception handling.
2670         * parse.c: Use C++ exception handling.
2671         * p-valprint.c: Use C++ exception handling.
2672         * objc-lang.c: Use C++ exception handling.
2673         * mi/mi-main.c: Use C++ exception handling.
2674         * mi/mi-interp.c: Use C++ exception handling.
2675         * mi/mi-cmd-stack.c: Use C++ exception handling.
2676         * mi/mi-cmd-break.c: Use C++ exception handling.
2677         * main.c: Use C++ exception handling.
2678         * linux-thread-db.c: Use C++ exception handling.
2679         * linux-tdep.c: Use C++ exception handling.
2680         * linux-nat.c: Use C++ exception handling.
2681         * linux-fork.c: Use C++ exception handling.
2682         * linespec.c: Use C++ exception handling.
2683         * language.c: Use C++ exception handling.
2684         * jit.c: Use C++ exception handling.
2685         * infrun.c: Use C++ exception handling.
2686         * infcmd.c: Use C++ exception handling.
2687         * infcall.c: Use C++ exception handling.
2688         * inf-loop.c: Use C++ exception handling.
2689         * i386-tdep.c: Use C++ exception handling.
2690         * i386-linux-tdep.c: Use C++ exception handling.
2691         * guile/scm-value.c: Use C++ exception handling.
2692         * guile/scm-type.c: Use C++ exception handling.
2693         * guile/scm-symtab.c: Use C++ exception handling.
2694         * guile/scm-symbol.c: Use C++ exception handling.
2695         * guile/scm-pretty-print.c: Use C++ exception handling.
2696         * guile/scm-ports.c: Use C++ exception handling.
2697         * guile/scm-param.c: Use C++ exception handling.
2698         * guile/scm-math.c: Use C++ exception handling.
2699         * guile/scm-lazy-string.c: Use C++ exception handling.
2700         * guile/scm-frame.c: Use C++ exception handling.
2701         * guile/scm-disasm.c: Use C++ exception handling.
2702         * guile/scm-cmd.c: Use C++ exception handling.
2703         * guile/scm-breakpoint.c: Use C++ exception handling.
2704         * guile/scm-block.c: Use C++ exception handling.
2705         * guile/guile-internal.h: Use C++ exception handling.
2706         * gnu-v3-abi.c: Use C++ exception handling.
2707         * gdbtypes.c: Use C++ exception handling.
2708         * frame.c: Use C++ exception handling.
2709         * frame-unwind.c: Use C++ exception handling.
2710         * fbsd-tdep.c: Use C++ exception handling.
2711         * f-valprint.c: Use C++ exception handling.
2712         * exec.c: Use C++ exception handling.
2713         * event-top.c: Use C++ exception handling.
2714         * event-loop.c: Use C++ exception handling.
2715         * eval.c: Use C++ exception handling.
2716         * dwarf2read.c: Use C++ exception handling.
2717         * dwarf2loc.c: Use C++ exception handling.
2718         * dwarf2-frame.c: Use C++ exception handling.
2719         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2720         * dwarf-index-write.c: Use C++ exception handling.
2721         * dwarf-index-cache.c: Use C++ exception handling.
2722         * dtrace-probe.c: Use C++ exception handling.
2723         * disasm-selftests.c: Use C++ exception handling.
2724         * darwin-nat.c: Use C++ exception handling.
2725         * cp-valprint.c: Use C++ exception handling.
2726         * cp-support.c: Use C++ exception handling.
2727         * cp-abi.c: Use C++ exception handling.
2728         * corelow.c: Use C++ exception handling.
2729         * completer.c: Use C++ exception handling.
2730         * compile/compile-object-run.c: Use C++ exception handling.
2731         * compile/compile-object-load.c: Use C++ exception handling.
2732         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2733         * compile/compile-c-symbols.c: Use C++ exception handling.
2734         * common/selftest.c: Use C++ exception handling.
2735         * common/new-op.c: Use C++ exception handling.
2736         * cli/cli-script.c: Use C++ exception handling.
2737         * cli/cli-interp.c: Use C++ exception handling.
2738         * cli/cli-cmds.c: Use C++ exception handling.
2739         * c-varobj.c: Use C++ exception handling.
2740         * btrace.c: Use C++ exception handling.
2741         * breakpoint.c: Use C++ exception handling.
2742         * break-catch-throw.c: Use C++ exception handling.
2743         * arch-utils.c: Use C++ exception handling.
2744         * amd64-tdep.c: Use C++ exception handling.
2745         * ada-valprint.c: Use C++ exception handling.
2746         * ada-typeprint.c: Use C++ exception handling.
2747         * ada-lang.c: Use C++ exception handling.
2748         * aarch64-tdep.c: Use C++ exception handling.
2749
2750 2019-04-08  Tom Tromey  <tom@tromey.com>
2751
2752         * xml-support.c (gdb_xml_parser::parse): Update.
2753         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2754         * value.c (show_convenience): Update.
2755         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2756         (test_parse_flags_qcs): Update.
2757         * thread.c (thr_try_catch_cmd): Update.
2758         * target.c (target_translate_tls_address): Update.
2759         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2760         (info_frame_command_core, frame_apply_command_count): Update.
2761         * rust-exp.y (rust_lex_exception_test): Update.
2762         * riscv-tdep.c (riscv_print_one_register_info): Update.
2763         * remote.c (remote_target::enable_btrace): Update.
2764         * record-btrace.c (record_btrace_enable_warn): Update.
2765         * python/py-utils.c (gdbpy_convert_exception): Update.
2766         * printcmd.c (do_one_display, print_variable_and_value): Update.
2767         * mi/mi-main.c (mi_print_exception): Update.
2768         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2769         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2770         * linux-nat.c (linux_nat_target::attach): Update.
2771         * linux-fork.c (class scoped_switch_fork_info): Update.
2772         * infrun.c (displaced_step_prepare): Update.
2773         * infcall.c (call_function_by_hand_dummy): Update.
2774         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2775         * gnu-v3-abi.c (print_one_vtable): Update.
2776         * frame.c (get_prev_frame_always): Update.
2777         * f-valprint.c (info_common_command_for_block): Update.
2778         * exec.c (try_open_exec_file): Update.
2779         * exceptions.c (print_exception, exception_print)
2780         (exception_fprintf, exception_print_same): Update.
2781         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2782         * dwarf-index-cache.c (index_cache::store)
2783         (index_cache::lookup_gdb_index): Update.
2784         * darwin-nat.c (maybe_cache_shell): Update.
2785         * cp-valprint.c (cp_print_value_fields): Update.
2786         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2787         (gcc_cplus_symbol_address): Update.
2788         * compile/compile-c-symbols.c (gcc_convert_symbol)
2789         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2790         * common/selftest.c: Update.
2791         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2792         a std::string.
2793         (exception_try_scope_entry, exception_try_scope_exit): Don't
2794         declare.
2795         (struct exception_try_scope): Remove.
2796         (TRY): Don't use exception_try_scope.
2797         (struct gdb_exception): Add constructor, operator=.
2798         <what>: New method.
2799         (struct gdb_exception_RETURN_MASK_ALL)
2800         (struct gdb_exception_RETURN_MASK_ERROR)
2801         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2802         (struct gdb_quit_bad_alloc): Update.
2803         * common/common-exceptions.c (exception_none): Change
2804         initializer.
2805         (struct catcher) <state, exception>: Initialize inline.
2806         <prev>: Remove member.
2807         (current_catcher): Remove.
2808         (catchers): New global.
2809         (exceptions_state_mc_init): Simplify.
2810         (catcher_pop): Remove.
2811         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2812         (try_scope_depth, exception_try_scope_entry)
2813         (exception_try_scope_exit): Remove.
2814         (throw_exception_sjlj): Update.
2815         (exception_messages, exception_messages_size): Remove.
2816         (throw_it): Simplify.
2817         (gdb_exception_sliced_copy): Remove.
2818         (throw_exception_cxx): Update.
2819         * cli/cli-script.c (script_from_file): Update.
2820         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2821         Update.
2822         * ada-valprint.c (ada_val_print): Update.
2823         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2824         (create_excep_cond_exprs): Update.
2825
2826 2019-04-08  Tom Tromey  <tom@tromey.com>
2827
2828         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2829         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2830         (TRY, CATCH, END_CATCH): Remove some definitions.
2831         * common/common-exceptions.c: Don't use GDB_XCPT.
2832         (catcher_list_size): Remove.
2833         (throw_exception, throw_it): Simplify.
2834
2835 2019-04-05  Tom Tromey  <tom@tromey.com>
2836
2837         Revert the header-sorting patch.
2838         * ft32-tdep.c: Revert.
2839         * frv-tdep.c: Revert.
2840         * frv-linux-tdep.c: Revert.
2841         * frame.c: Revert.
2842         * frame-unwind.c: Revert.
2843         * frame-base.c: Revert.
2844         * fork-child.c: Revert.
2845         * findvar.c: Revert.
2846         * findcmd.c: Revert.
2847         * filesystem.c: Revert.
2848         * filename-seen-cache.h: Revert.
2849         * filename-seen-cache.c: Revert.
2850         * fbsd-tdep.c: Revert.
2851         * fbsd-nat.h: Revert.
2852         * fbsd-nat.c: Revert.
2853         * f-valprint.c: Revert.
2854         * f-typeprint.c: Revert.
2855         * f-lang.c: Revert.
2856         * extension.h: Revert.
2857         * extension.c: Revert.
2858         * extension-priv.h: Revert.
2859         * expprint.c: Revert.
2860         * exec.h: Revert.
2861         * exec.c: Revert.
2862         * exceptions.c: Revert.
2863         * event-top.c: Revert.
2864         * event-loop.c: Revert.
2865         * eval.c: Revert.
2866         * elfread.c: Revert.
2867         * dwarf2read.h: Revert.
2868         * dwarf2read.c: Revert.
2869         * dwarf2loc.c: Revert.
2870         * dwarf2expr.h: Revert.
2871         * dwarf2expr.c: Revert.
2872         * dwarf2-frame.c: Revert.
2873         * dwarf2-frame-tailcall.c: Revert.
2874         * dwarf-index-write.h: Revert.
2875         * dwarf-index-write.c: Revert.
2876         * dwarf-index-common.c: Revert.
2877         * dwarf-index-cache.h: Revert.
2878         * dwarf-index-cache.c: Revert.
2879         * dummy-frame.c: Revert.
2880         * dtrace-probe.c: Revert.
2881         * disasm.h: Revert.
2882         * disasm.c: Revert.
2883         * disasm-selftests.c: Revert.
2884         * dictionary.c: Revert.
2885         * dicos-tdep.c: Revert.
2886         * demangle.c: Revert.
2887         * dcache.h: Revert.
2888         * dcache.c: Revert.
2889         * darwin-nat.h: Revert.
2890         * darwin-nat.c: Revert.
2891         * darwin-nat-info.c: Revert.
2892         * d-valprint.c: Revert.
2893         * d-namespace.c: Revert.
2894         * d-lang.c: Revert.
2895         * ctf.c: Revert.
2896         * csky-tdep.c: Revert.
2897         * csky-linux-tdep.c: Revert.
2898         * cris-tdep.c: Revert.
2899         * cris-linux-tdep.c: Revert.
2900         * cp-valprint.c: Revert.
2901         * cp-support.c: Revert.
2902         * cp-namespace.c: Revert.
2903         * cp-abi.c: Revert.
2904         * corelow.c: Revert.
2905         * corefile.c: Revert.
2906         * continuations.c: Revert.
2907         * completer.h: Revert.
2908         * completer.c: Revert.
2909         * complaints.c: Revert.
2910         * coffread.c: Revert.
2911         * coff-pe-read.c: Revert.
2912         * cli-out.h: Revert.
2913         * cli-out.c: Revert.
2914         * charset.c: Revert.
2915         * c-varobj.c: Revert.
2916         * c-valprint.c: Revert.
2917         * c-typeprint.c: Revert.
2918         * c-lang.c: Revert.
2919         * buildsym.c: Revert.
2920         * buildsym-legacy.c: Revert.
2921         * build-id.h: Revert.
2922         * build-id.c: Revert.
2923         * btrace.c: Revert.
2924         * bsd-uthread.c: Revert.
2925         * breakpoint.h: Revert.
2926         * breakpoint.c: Revert.
2927         * break-catch-throw.c: Revert.
2928         * break-catch-syscall.c: Revert.
2929         * break-catch-sig.c: Revert.
2930         * blockframe.c: Revert.
2931         * block.c: Revert.
2932         * bfin-tdep.c: Revert.
2933         * bfin-linux-tdep.c: Revert.
2934         * bfd-target.c: Revert.
2935         * bcache.c: Revert.
2936         * ax-general.c: Revert.
2937         * ax-gdb.h: Revert.
2938         * ax-gdb.c: Revert.
2939         * avr-tdep.c: Revert.
2940         * auxv.c: Revert.
2941         * auto-load.c: Revert.
2942         * arm-wince-tdep.c: Revert.
2943         * arm-tdep.c: Revert.
2944         * arm-symbian-tdep.c: Revert.
2945         * arm-pikeos-tdep.c: Revert.
2946         * arm-obsd-tdep.c: Revert.
2947         * arm-nbsd-tdep.c: Revert.
2948         * arm-nbsd-nat.c: Revert.
2949         * arm-linux-tdep.c: Revert.
2950         * arm-linux-nat.c: Revert.
2951         * arm-fbsd-tdep.c: Revert.
2952         * arm-fbsd-nat.c: Revert.
2953         * arm-bsd-tdep.c: Revert.
2954         * arch-utils.c: Revert.
2955         * arc-tdep.c: Revert.
2956         * arc-newlib-tdep.c: Revert.
2957         * annotate.h: Revert.
2958         * annotate.c: Revert.
2959         * amd64-windows-tdep.c: Revert.
2960         * amd64-windows-nat.c: Revert.
2961         * amd64-tdep.c: Revert.
2962         * amd64-sol2-tdep.c: Revert.
2963         * amd64-obsd-tdep.c: Revert.
2964         * amd64-obsd-nat.c: Revert.
2965         * amd64-nbsd-tdep.c: Revert.
2966         * amd64-nbsd-nat.c: Revert.
2967         * amd64-nat.c: Revert.
2968         * amd64-linux-tdep.c: Revert.
2969         * amd64-linux-nat.c: Revert.
2970         * amd64-fbsd-tdep.c: Revert.
2971         * amd64-fbsd-nat.c: Revert.
2972         * amd64-dicos-tdep.c: Revert.
2973         * amd64-darwin-tdep.c: Revert.
2974         * amd64-bsd-nat.c: Revert.
2975         * alpha-tdep.c: Revert.
2976         * alpha-obsd-tdep.c: Revert.
2977         * alpha-nbsd-tdep.c: Revert.
2978         * alpha-mdebug-tdep.c: Revert.
2979         * alpha-linux-tdep.c: Revert.
2980         * alpha-linux-nat.c: Revert.
2981         * alpha-bsd-tdep.c: Revert.
2982         * alpha-bsd-nat.c: Revert.
2983         * aix-thread.c: Revert.
2984         * agent.c: Revert.
2985         * addrmap.c: Revert.
2986         * ada-varobj.c: Revert.
2987         * ada-valprint.c: Revert.
2988         * ada-typeprint.c: Revert.
2989         * ada-tasks.c: Revert.
2990         * ada-lang.c: Revert.
2991         * aarch64-tdep.c: Revert.
2992         * aarch64-ravenscar-thread.c: Revert.
2993         * aarch64-newlib-tdep.c: Revert.
2994         * aarch64-linux-tdep.c: Revert.
2995         * aarch64-linux-nat.c: Revert.
2996         * aarch64-fbsd-tdep.c: Revert.
2997         * aarch64-fbsd-nat.c: Revert.
2998         * aarch32-linux-nat.c: Revert.
2999
3000 2019-04-05  Tom Tromey  <tom@tromey.com>
3001
3002         * ft32-tdep.c: Sort headers.
3003         * frv-tdep.c: Sort headers.
3004         * frv-linux-tdep.c: Sort headers.
3005         * frame.c: Sort headers.
3006         * frame-unwind.c: Sort headers.
3007         * frame-base.c: Sort headers.
3008         * fork-child.c: Sort headers.
3009         * findvar.c: Sort headers.
3010         * findcmd.c: Sort headers.
3011         * filesystem.c: Sort headers.
3012         * filename-seen-cache.h: Sort headers.
3013         * filename-seen-cache.c: Sort headers.
3014         * fbsd-tdep.c: Sort headers.
3015         * fbsd-nat.h: Sort headers.
3016         * fbsd-nat.c: Sort headers.
3017         * f-valprint.c: Sort headers.
3018         * f-typeprint.c: Sort headers.
3019         * f-lang.c: Sort headers.
3020         * extension.h: Sort headers.
3021         * extension.c: Sort headers.
3022         * extension-priv.h: Sort headers.
3023         * expprint.c: Sort headers.
3024         * exec.h: Sort headers.
3025         * exec.c: Sort headers.
3026         * exceptions.c: Sort headers.
3027         * event-top.c: Sort headers.
3028         * event-loop.c: Sort headers.
3029         * eval.c: Sort headers.
3030         * elfread.c: Sort headers.
3031         * dwarf2read.h: Sort headers.
3032         * dwarf2read.c: Sort headers.
3033         * dwarf2loc.c: Sort headers.
3034         * dwarf2expr.h: Sort headers.
3035         * dwarf2expr.c: Sort headers.
3036         * dwarf2-frame.c: Sort headers.
3037         * dwarf2-frame-tailcall.c: Sort headers.
3038         * dwarf-index-write.h: Sort headers.
3039         * dwarf-index-write.c: Sort headers.
3040         * dwarf-index-common.c: Sort headers.
3041         * dwarf-index-cache.h: Sort headers.
3042         * dwarf-index-cache.c: Sort headers.
3043         * dummy-frame.c: Sort headers.
3044         * dtrace-probe.c: Sort headers.
3045         * disasm.h: Sort headers.
3046         * disasm.c: Sort headers.
3047         * disasm-selftests.c: Sort headers.
3048         * dictionary.c: Sort headers.
3049         * dicos-tdep.c: Sort headers.
3050         * demangle.c: Sort headers.
3051         * dcache.h: Sort headers.
3052         * dcache.c: Sort headers.
3053         * darwin-nat.h: Sort headers.
3054         * darwin-nat.c: Sort headers.
3055         * darwin-nat-info.c: Sort headers.
3056         * d-valprint.c: Sort headers.
3057         * d-namespace.c: Sort headers.
3058         * d-lang.c: Sort headers.
3059         * ctf.c: Sort headers.
3060         * csky-tdep.c: Sort headers.
3061         * csky-linux-tdep.c: Sort headers.
3062         * cris-tdep.c: Sort headers.
3063         * cris-linux-tdep.c: Sort headers.
3064         * cp-valprint.c: Sort headers.
3065         * cp-support.c: Sort headers.
3066         * cp-namespace.c: Sort headers.
3067         * cp-abi.c: Sort headers.
3068         * corelow.c: Sort headers.
3069         * corefile.c: Sort headers.
3070         * continuations.c: Sort headers.
3071         * completer.h: Sort headers.
3072         * completer.c: Sort headers.
3073         * complaints.c: Sort headers.
3074         * coffread.c: Sort headers.
3075         * coff-pe-read.c: Sort headers.
3076         * cli-out.h: Sort headers.
3077         * cli-out.c: Sort headers.
3078         * charset.c: Sort headers.
3079         * c-varobj.c: Sort headers.
3080         * c-valprint.c: Sort headers.
3081         * c-typeprint.c: Sort headers.
3082         * c-lang.c: Sort headers.
3083         * buildsym.c: Sort headers.
3084         * buildsym-legacy.c: Sort headers.
3085         * build-id.h: Sort headers.
3086         * build-id.c: Sort headers.
3087         * btrace.c: Sort headers.
3088         * bsd-uthread.c: Sort headers.
3089         * breakpoint.h: Sort headers.
3090         * breakpoint.c: Sort headers.
3091         * break-catch-throw.c: Sort headers.
3092         * break-catch-syscall.c: Sort headers.
3093         * break-catch-sig.c: Sort headers.
3094         * blockframe.c: Sort headers.
3095         * block.c: Sort headers.
3096         * bfin-tdep.c: Sort headers.
3097         * bfin-linux-tdep.c: Sort headers.
3098         * bfd-target.c: Sort headers.
3099         * bcache.c: Sort headers.
3100         * ax-general.c: Sort headers.
3101         * ax-gdb.h: Sort headers.
3102         * ax-gdb.c: Sort headers.
3103         * avr-tdep.c: Sort headers.
3104         * auxv.c: Sort headers.
3105         * auto-load.c: Sort headers.
3106         * arm-wince-tdep.c: Sort headers.
3107         * arm-tdep.c: Sort headers.
3108         * arm-symbian-tdep.c: Sort headers.
3109         * arm-pikeos-tdep.c: Sort headers.
3110         * arm-obsd-tdep.c: Sort headers.
3111         * arm-nbsd-tdep.c: Sort headers.
3112         * arm-nbsd-nat.c: Sort headers.
3113         * arm-linux-tdep.c: Sort headers.
3114         * arm-linux-nat.c: Sort headers.
3115         * arm-fbsd-tdep.c: Sort headers.
3116         * arm-fbsd-nat.c: Sort headers.
3117         * arm-bsd-tdep.c: Sort headers.
3118         * arch-utils.c: Sort headers.
3119         * arc-tdep.c: Sort headers.
3120         * arc-newlib-tdep.c: Sort headers.
3121         * annotate.h: Sort headers.
3122         * annotate.c: Sort headers.
3123         * amd64-windows-tdep.c: Sort headers.
3124         * amd64-windows-nat.c: Sort headers.
3125         * amd64-tdep.c: Sort headers.
3126         * amd64-sol2-tdep.c: Sort headers.
3127         * amd64-obsd-tdep.c: Sort headers.
3128         * amd64-obsd-nat.c: Sort headers.
3129         * amd64-nbsd-tdep.c: Sort headers.
3130         * amd64-nbsd-nat.c: Sort headers.
3131         * amd64-nat.c: Sort headers.
3132         * amd64-linux-tdep.c: Sort headers.
3133         * amd64-linux-nat.c: Sort headers.
3134         * amd64-fbsd-tdep.c: Sort headers.
3135         * amd64-fbsd-nat.c: Sort headers.
3136         * amd64-dicos-tdep.c: Sort headers.
3137         * amd64-darwin-tdep.c: Sort headers.
3138         * amd64-bsd-nat.c: Sort headers.
3139         * alpha-tdep.c: Sort headers.
3140         * alpha-obsd-tdep.c: Sort headers.
3141         * alpha-nbsd-tdep.c: Sort headers.
3142         * alpha-mdebug-tdep.c: Sort headers.
3143         * alpha-linux-tdep.c: Sort headers.
3144         * alpha-linux-nat.c: Sort headers.
3145         * alpha-bsd-tdep.c: Sort headers.
3146         * alpha-bsd-nat.c: Sort headers.
3147         * aix-thread.c: Sort headers.
3148         * agent.c: Sort headers.
3149         * addrmap.c: Sort headers.
3150         * ada-varobj.c: Sort headers.
3151         * ada-valprint.c: Sort headers.
3152         * ada-typeprint.c: Sort headers.
3153         * ada-tasks.c: Sort headers.
3154         * ada-lang.c: Sort headers.
3155         * aarch64-tdep.c: Sort headers.
3156         * aarch64-ravenscar-thread.c: Sort headers.
3157         * aarch64-newlib-tdep.c: Sort headers.
3158         * aarch64-linux-tdep.c: Sort headers.
3159         * aarch64-linux-nat.c: Sort headers.
3160         * aarch64-fbsd-tdep.c: Sort headers.
3161         * aarch64-fbsd-nat.c: Sort headers.
3162         * aarch32-linux-nat.c: Sort headers.
3163
3164 2019-04-04  Tom Tromey  <tom@tromey.com>
3165
3166         * varobj.c (varobj_create): Update.
3167         * rust-exp.y (struct rust_parser) <update_innermost_block,
3168         lookup_symbol>: New methods.
3169         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3170         Rename.
3171         (rust_parser::rust_lookup_type)
3172         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3173         * printcmd.c (display_command, do_one_display): Update.
3174         * parser-defs.h (struct parser_state) <parser_state>: Add
3175         "tracker" parameter.
3176         (block_tracker): New member.
3177         (class innermost_block_tracker) <innermost_block_tracker>: Add
3178         "types" parameter.
3179         <reset>: Remove method.
3180         (innermost_block): Don't declare.
3181         (null_post_parser): Update.
3182         * parse.c (innermost_block): Remove global.
3183         (write_dollar_variable): Update.
3184         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3185         Remove "tracker_types" parameter.
3186         (parse_expression): Add "tracker" parameter.
3187         (parse_expression_for_completion): Update.
3188         (null_post_parser): Add "tracker" parameter.
3189         * p-exp.y: Update rules.
3190         * m2-exp.y: Update rules.
3191         * language.h (struct language_defn) <la_post_parser>: Add
3192         "tracker" parameter.
3193         * go-exp.y: Update rules.
3194         * f-exp.y: Update rules.
3195         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3196         parameter.
3197         * d-exp.y: Update rules.
3198         * c-exp.y: Update rules.
3199         * breakpoint.c (set_breakpoint_condition): Create an
3200         innermost_block_tracker.
3201         (watch_command_1): Likewise.
3202         * ada-lang.c (resolve): Add "tracker" parameter.
3203         (resolve_subexp): Likewise.
3204         * ada-exp.y (write_var_from_sym): Update.
3205
3206 2019-04-04  Tom Tromey  <tom@tromey.com>
3207
3208         * type-stack.h: New file.
3209         * type-stack.c: New file.
3210         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3211         type-stack.h.
3212         (insert_into_type_stack, insert_type, push_type, push_type_int)
3213         (insert_type_address_space, pop_type, pop_type_int)
3214         (pop_typelist, pop_type_stack, append_type_stack)
3215         (push_type_stack, get_type_stack, push_typelist)
3216         (follow_type_instance_flags, follow_types): Don't declare.
3217         * parse.c (type_stack): Remove global.
3218         (parse_exp_in_context): Update.
3219         (insert_into_type_stack, insert_type, push_type, push_type_int)
3220         (insert_type_address_space, pop_type, pop_type_int)
3221         (pop_typelist, pop_type_stack, append_type_stack)
3222         (push_type_stack, get_type_stack, push_typelist)
3223         (follow_type_instance_flags, follow_types): Remove (moved to
3224         type-stack.c).
3225         * f-exp.y (type_stack): New global.
3226         Update rules.
3227         (push_kind_type, f_parse): Update.
3228         * d-exp.y (type_stack): New global.
3229         Update rules.
3230         (d_parse): Update.
3231         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3232         Update rules.
3233         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3234         (HFILES_NO_SRCDIR): Add type-stack.h.
3235
3236 2019-04-04  Tom Tromey  <tom@tromey.com>
3237
3238         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3239         (rust_parser::convert_ast_to_expression, rust_parse)
3240         (rust_lex_test_completion, rust_lex_tests): Update.
3241         * parser-defs.h (struct expr_completion_state): New.
3242         (struct parser_state) <parser_state>: Add completion parameter.
3243         <mark_struct_expression, mark_completion_tag>: New methods.
3244         <parse_completion, m_completion_state>: New members.
3245         (prefixify_expression, null_post_parser): Update.
3246         (mark_struct_expression, mark_completion_tag): Don't declare.
3247         * parse.c (parse_completion, expout_last_struct)
3248         (expout_tag_completion_type, expout_completion_name): Remove
3249         globals.
3250         (parser_state::mark_struct_expression)
3251         (parser_state::mark_completion_tag): Now methods.
3252         (prefixify_expression): Add last_struct parameter.
3253         (prefixify_subexp): Likewise.
3254         (parse_exp_1): Update.
3255         (parse_exp_in_context): Add cstate parameter.  Update.
3256         (parse_expression_for_completion): Create an
3257         expr_completion_state.
3258         (null_post_parser): Add "completion" parameter.
3259         * p-exp.y: Update rules.
3260         (yylex): Update.
3261         * language.h (struct language_defn) <la_post_parser>: Add
3262         "completing" parameter.
3263         * go-exp.y: Update rules.
3264         (lex_one_token): Update.
3265         * expression.h (parse_completion): Don't declare.
3266         * d-exp.y: Update rules.
3267         (lex_one_token): Update rules.
3268         * c-exp.y: Update rules.
3269         (lex_one_token): Update.
3270         * ada-lang.c (resolve): Add "parse_completion" parameter.
3271         (resolve_subexp): Likewise.
3272         (ada_resolve_function): Likewise.
3273
3274 2019-04-04  Tom Tromey  <tom@tromey.com>
3275
3276         * parser-defs.h (struct parser_state) <start_arglist,
3277         end_arglist>: New methods.
3278         <arglist_len, m_funcall_chain>: New members.
3279         (arglist_len, start_arglist, end_arglist): Don't declare.
3280         * parse.c (arglist_len, funcall_chain): Remove global.
3281         (start_arglist, end_arglist): Remove functions.
3282         (parse_exp_in_context): Update.
3283         * p-exp.y: Update rules.
3284         * m2-exp.y: Update rules.
3285         * go-exp.y: Update rules.
3286         * f-exp.y: Update rules.
3287         * d-exp.y: Update rules.
3288         * c-exp.y: Update rules.
3289
3290 2019-04-04  Tom Tromey  <tom@tromey.com>
3291
3292         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3293         lex_operator, push_back>: New methods.
3294         Update all rules.
3295         (rust_parser::lex_hex, lex_escape): Rename and update.
3296         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3297         (rust_parser::lex_operator): Rename and update.
3298         (rust_parser::lex_number, rustyylex, rustyyerror)
3299         (rust_lex_test_init, rust_lex_test_sequence)
3300         (rust_lex_test_push_back, rust_lex_tests): Update.
3301         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3302         parameter.
3303         <lexptr, prev_lexptr>: New members.
3304         (lexptr, prev_lexptr): Don't declare.
3305         * parse.c (lexptr, prev_lexptr): Remove globals.
3306         (parse_exp_in_context): Update.
3307         * p-exp.y (yylex, yyerror): Update.
3308         * m2-exp.y (parse_number, yylex, yyerror): Update.
3309         * go-exp.y (lex_one_token, yyerror): Update.
3310         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3311         * d-exp.y (lex_one_token, yyerror): Update.
3312         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3313         (lex_one_token, yyerror): Update.
3314         * ada-lex.l (YY_INPUT): Update.
3315         (rewind_to_char): Update.
3316         * ada-exp.y (yyerror): Update.
3317
3318 2019-04-04  Tom Tromey  <tom@tromey.com>
3319
3320         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3321         * parser-defs.h (struct parser_state) <parser_state>: Add new
3322         parameter.
3323         <comma_terminates>: New member.
3324         (comma_terminates): Don't declare global.
3325         * parse.c (comma_terminates): Remove global.
3326         (parse_exp_in_context): Update.
3327         * p-exp.y (yylex): Update.
3328         * m2-exp.y (yylex): Update.
3329         * go-exp.y (lex_one_token): Update.
3330         * f-exp.y (yylex): Update.
3331         * d-exp.y (lex_one_token): Update.
3332         * c-exp.y (lex_one_token): Update.
3333         * ada-lex.l: Update.
3334
3335 2019-04-04  Tom Tromey  <tom@tromey.com>
3336
3337         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3338         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3339         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3340         * parser-defs.h (paren_depth): Don't declare.
3341         * parse.c (paren_depth): Remove global.
3342         (parse_exp_in_context): Update.
3343         * p-exp.y (paren_depth): New global.
3344         (pascal_parse): Initialize it.
3345         * m2-exp.y (paren_depth): New global.
3346         (m2_parse): Initialize it.
3347         * go-exp.y (paren_depth): New global.
3348         (go_parse): Initialize it.
3349         * f-exp.y (paren_depth): New global.
3350         (f_parse): Initialize it.
3351         * d-exp.y (paren_depth): New global.
3352         (d_parse): Initialize it.
3353         * c-exp.y (paren_depth): New global.
3354         (c_parse): Initialize it.
3355         * ada-lex.l (paren_depth): New global.
3356         (lexer_init): Initialize it.
3357
3358 2019-04-04  Tom Tromey  <tom@tromey.com>
3359
3360         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3361         (rust_parser::convert_ast_to_type)
3362         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3363         * parser-defs.h (struct parser_state) <parser_state>: Add
3364         parameters.  Initialize new members.
3365         <expression_context_block, expression_context_pc>: New members.
3366         * parse.c (expression_context_block, expression_context_pc):
3367         Remove globals.
3368         (parse_exp_in_context): Update.
3369         * p-exp.y: Update all rules.
3370         (yylex): Update.
3371         * m2-exp.y: Update all rules.
3372         (yylex): Update.
3373         * go-exp.y (yylex): Update.
3374         * f-exp.y (yylex): Update.
3375         * d-exp.y: Update all rules.
3376         (yylex): Update.
3377         * c-exp.y: Update all rules.
3378         (lex_one_token, classify_name, yylex, c_parse): Update.
3379         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3380
3381 2019-04-04  Tom Tromey  <tom@tromey.com>
3382
3383         * gdbarch.h, gdbarch.c: Rebuild.
3384         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3385         * stap-probe.h:
3386         (struct stap_parse_info): Replace "parser_state" with
3387         "expr_builder".
3388         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3389         (parser_state): New class.
3390         * parse.c (expr_builder): Rename.
3391         (expr_builder::release): Rename.
3392         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3393         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3394         (write_exp_elt_longcst, write_exp_elt_floatcst)
3395         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3396         (write_exp_string_vector, write_exp_bitstring)
3397         (write_exp_msymbol, mark_struct_expression)
3398         (write_dollar_variable)
3399         (insert_type_address_space, increase_expout_size): Replace
3400         "parser_state" with "expr_builder".
3401         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3402         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3403         "parser_state" with "expr_builder".
3404
3405 2019-04-04  Tom Tromey  <tom@tromey.com>
3406
3407         * rust-exp.y: Replace "parse_language" with method call.
3408         * p-exp.y:
3409         (yylex): Replace "parse_language" with method call.
3410         * m2-exp.y:
3411         (yylex): Replace "parse_language" with method call.
3412         * go-exp.y (classify_name): Replace "parse_language" with method
3413         call.
3414         * f-exp.y (yylex): Replace "parse_language" with method call.
3415         * d-exp.y (lex_one_token): Replace "parse_language" with method
3416         call.
3417         * c-exp.y:
3418         (lex_one_token, classify_name, yylex): Replace "parse_language"
3419         with method call.
3420         * ada-exp.y (find_primitive_type, type_char)
3421         (type_system_address): Replace "parse_language" with method call.
3422
3423 2019-04-04  Tom Tromey  <tom@tromey.com>
3424
3425         * rust-exp.y: Replace "parse_gdbarch" with method call.
3426         * parse.c (write_dollar_variable, insert_type_address_space):
3427         Replace "parse_gdbarch" with method call.
3428         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3429         call.
3430         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3431         call.
3432         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3433         "parse_gdbarch" with method call.
3434         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3435         with method call.
3436         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3437         "parse_gdbarch" with method call.
3438         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3439         "parse_gdbarch" with method call.
3440         * c-exp.y (parse_type, parse_number, classify_name): Replace
3441         "parse_gdbarch" with method call.
3442         * ada-lex.l: Replace "parse_gdbarch" with method call.
3443         * ada-exp.y (parse_type, find_primitive_type, type_char)
3444         (type_system_address): Replace "parse_gdbarch" with method call.
3445
3446 2019-04-04  Tom Tromey  <tom@tromey.com>
3447
3448         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3449         * stap-probe.c (stap_parse_argument): Update.
3450         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3451         initial_size parameter.
3452         * rust-exp.y (rust_lex_tests): Update.
3453         * parse.c (parser_state): Update.
3454         (parse_exp_in_context): Update.
3455         * parser-defs.h (struct parser_state) <parser_state>: Remove
3456         "initial_size" parameter.
3457
3458 2019-04-04  Tom Tromey  <tom@tromey.com>
3459
3460         * parser-defs.h (increase_expout_size): Don't declare.
3461         * parse.c (increase_expout_size): Now static.
3462
3463 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3464
3465         * gnu-nat.c (gnu_nat_target::wait): Fix
3466         target_waitstatus_to_string call.
3467
3468 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3469
3470         * eval.c (evaluate_subexp_standard): Handle internal functions
3471         during Fortran function call handling.
3472
3473 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * NEWS: Mention new internal functions.
3476         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3477         (read_base_type): Use dwarf2_init_complex_target_type.
3478         * value.c (creal_internal_fn): New function.
3479         (cimag_internal_fn): New function.
3480         (_initialize_values): Register new internal functions.
3481
3482 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3483
3484         * infrun.c (stop_all_threads): If debug_infrun, always
3485         trace the wait status after wait_one, using
3486         target_waitstatus_to_string and target_pid_to_str.
3487         (handle_inferior_event): Replace various trace of
3488         wait status kind by a single trace.
3489         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3490         wait status kind image by target_waitstatus_to_string.
3491         * target/waitstatus.c (target_waitstatus_to_string): Fix
3492         obsolete comment.
3493
3494 2019-04-01  Tom Tromey  <tromey@adacore.com>
3495
3496         PR symtab/23331:
3497         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3498
3499 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3500             Pedro Alves  <palves@redhat.com>
3501
3502         * top.c (quit_force): Call 'finalize_values'.
3503         * value.c (finalize_values): New function.
3504         * value.h (finalize_values): Declare.
3505
3506 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3507
3508         * NEWS: Announce $_gdb_major and $_gdb_minor.
3509
3510         * top.c (init_gdb_version_vars): New function.
3511         (gdb_init): Call init_gdb_version_vars.
3512
3513 2019-03-29  Tom Tromey  <tromey@adacore.com>
3514
3515         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3516         help text.  Remove dead code.
3517
3518 2019-03-29  Keith Seitz  <keiths@redhat.com>
3519
3520         From Siddhesh Poyarekar:
3521         * f-lang.h (f77_get_upperbound): Return LONGEST.
3522         (f77_get_lowerbound): Likewise.
3523         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3524         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3525         print them.
3526         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3527         plongest to format print it.
3528         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3529         (f77_get_upperbound): Likewise.
3530         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3531         LOWER_BOUND to LONGEST.
3532         (f77_create_arrayprint_offset_tbl): Likewise.
3533
3534 2019-03-29  Keith Seitz  <keiths@redhat.com>
3535
3536         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3537         %s/pulongest for TYPE_LENGTH instead of %d in format
3538         strings.
3539         * ada-typerint.c (ada_print_type): Likewise.
3540         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3541         * compile/compile-c-support.c (generate_register_struct): Likewise.
3542         * gdbtypes.c (recursive_dump_type): Likewise.
3543         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3544         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3545         instead of %d in format strings.
3546         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3547         to std::min to ULONGEST.
3548         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3549         instead of %d in format strings.
3550         * tracepoint.c (info_scope_command): Likewise.
3551         * typeprint.c (print_offset_data::update)
3552         (print_offset_data::finish): Likewise.
3553         * xtensa-tdep.c (xtensa_store_return_value)
3554         (xtensa_push_dummy_call): Likewise.
3555
3556 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3557
3558         * windows-nat.c (display_selector): Fixed format specifications
3559         for 64-bit Cygwin.
3560
3561 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3562
3563         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3564
3565 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3566
3567         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3568         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3569         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3570         (nios2_linux_init_abi): Install it.
3571
3572 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3573
3574         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3575
3576 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3577
3578         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3579
3580 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3581             Tom Tromey  <tromey@adacore.com>
3582
3583         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3584
3585 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3586
3587         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3588         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3589         method to compute the bounds of range types. Also print "[evaluated]"
3590         if the bounds' values come from a dynamic evaluation.
3591
3592 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3595         whitespace when pretty printing is on.
3596
3597 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3598
3599         * ppc-linux-nat.c: Add include.
3600
3601 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3602
3603         * NEWS: Mention AArch64 Pointer Authentication.
3604
3605 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3606
3607         * arm-linux-nat.c: Add include.
3608
3609 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3610
3611         * source-cache.c (source_cache::get_source_lines): Re-read
3612         fullname after calling open_source_file.
3613
3614 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3615
3616         * NEWS: Mention TLS support for FreeBSD.
3617
3618 2019-03-25  Tom Tromey  <tromey@adacore.com>
3619
3620         * minsyms.c (BUNCH_SIZE): Update comment.
3621         (~minimal_symbol_reader): Remove old comment.
3622         (compact_minimal_symbols): Update comment.
3623         (minimal_symbol_reader::install): Remove old comment.  Update
3624         other comments.
3625
3626 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3627
3628         * s390-linux-nat.c: Add include.
3629
3630 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3631
3632         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3633         Call linux_get_hwcap.
3634         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3635         Likewise.
3636         (aarch64_linux_get_hwcap): Remove function.
3637         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3638         declaration.
3639         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3640         linux_get_hwcap.
3641         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3642         * linux-tdep.c (linux_get_hwcap): Add function.
3643         (linux_get_hwcap2): Likewise.
3644         * linux-tdep.h (linux_get_hwcap): Add declaration.
3645         (linux_get_hwcap2): Likewise.
3646         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3647         (ppc_linux_get_hwcap2): Likewise.
3648         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3649         linux_get_hwcap.
3650         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3651         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3652         (ppc_linux_nat_target::read_description): Likewise.
3653         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3654         * s390-linux-nat.c: Likewise.
3655         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3656
3657 2019-03-24  Tom Tromey  <tom@tromey.com>
3658
3659         * ada-lang.c (standard_lookup): Simplify initialization.
3660         (ada_lookup_symbol_nonlocal): Simplify return.
3661         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3662         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3663         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3664         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3665         initialization.
3666         * solib.c (solib_global_lookup): Simplify.
3667         * symtab.c (null_block_symbol): Remove.
3668         (symbol_cache_lookup): Simplify returns.
3669         (lookup_language_this): Simplify returns.
3670         (lookup_symbol_aux): Simplify return.
3671         (lookup_local_symbol): Simplify returns.
3672         (lookup_global_symbol_from_objfile): Simplify return.
3673         (lookup_symbol_in_objfile_symtabs)
3674         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3675         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3676         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3677         * cp-namespace.c (cp_lookup_bare_symbol)
3678         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3679         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3680         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3681         (cp_lookup_symbol_via_imports): Simplify initialization.
3682         (find_symbol_in_baseclass): Likewise.
3683         * symtab.h (null_block_symbol): Remove.
3684         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3685         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3686         (d_lookup_symbol_module): Likewise.
3687         (find_symbol_in_baseclass): Simplify initialization.
3688
3689 2019-03-24  Tom Tromey  <tom@tromey.com>
3690
3691         * expression.h: Don't include symtab.h.
3692         (struct block): Forward declare.
3693
3694 2019-03-24  Tom Tromey  <tom@tromey.com>
3695
3696         * c-exp.y (typebase): Remove casts.
3697         * gdbtypes.c (lookup_unsigned_typename, )
3698         (lookup_signed_typename): Remove cast.
3699         * eval.c (parse_to_comma_and_eval): Remove cast.
3700         * parse.c (write_dollar_variable): Remove cast.
3701         * block.h (struct block) <superblock>: Now const.
3702         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3703         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3704         (map_block): Make "block" const.
3705         * symfile.h (struct quick_symbol_functions)
3706         <map_matching_symbols>: Constify block argument to "callback".
3707         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3708         const.
3709         (find_pc_sect_compunit_symtab): Make "b" const.
3710         (find_symbol_at_address): Likewise.
3711         (search_symbols): Likewise.
3712         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3713         (dw2_debug_names_lookup_symbol): Likewise.
3714         (dw2_map_matching_symbols): Update.
3715         * p-valprint.c (pascal_val_print): Remove "block".
3716         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3717         (aux_add_nonlocal_symbols): Make "block" const.
3718         (resolve_subexp): Remove cast.
3719         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3720         const.
3721         (iterate_over_file_blocks): Likewise.
3722         * f-exp.y (%union) <bval>: Remove.
3723         * coffread.c (patch_opaque_types): Make "b" const.
3724         * spu-tdep.c (spu_catch_start): Make "block" const.
3725         * c-valprint.c (print_unpacked_pointer): Remove "block".
3726         * symmisc.c (dump_symtab_1): Make "b" const.
3727         (block_depth): Make "block" const.
3728         * d-exp.y (%union) <bval>: Remove.
3729         * cp-support.h (cp_lookup_rtti_type): Update.
3730         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3731         * psymtab.c (psym_lookup_symbol): Make "block" const.
3732         (maintenance_check_psymtabs): Make "b" const.
3733         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3734         (enumerate_locals, enumerate_args): Update.
3735         * python/py-symtab.c (stpy_global_block): Make "block" const.
3736         (stpy_static_block): Likewise.
3737         * inline-frame.c (block_starting_point_at): Make "new_block"
3738         const.
3739         * block.c (find_block_in_blockvector): Make return type const.
3740         (blockvector_for_pc_sect): Make "b" const.
3741         (find_block_in_blockvector): Make "b" const.
3742
3743 2019-03-23  Tom Tromey  <tom@tromey.com>
3744
3745         * varobj.c (varobj_create): Update.
3746         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3747         * printcmd.c (display_command, do_one_display): Don't reset
3748         innermost_block.
3749         * parser-defs.h (enum innermost_block_tracker_type): Move to
3750         expression.h.
3751         (innermost_block): Update comment.
3752         * parse.c (parse_exp_1): Add tracker_types parameter.
3753         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3754         tracker_types parameter.  Reset innermost_block.
3755         (parse_exp_in_context): Remove.
3756         (parse_expression_for_completion): Update.
3757         * objfiles.c (~objfile): Don't reset expression_context_block or
3758         innermost_block.
3759         * expression.h (enum innermost_block_tracker_type): Move from
3760         parser-defs.h.
3761         (parse_exp_1): Add tracker_types parameter.
3762         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3763         reset innermost_block.
3764
3765 2019-03-23  Tom Tromey  <tom@tromey.com>
3766
3767         * objfiles.h: Include bcache.h.
3768
3769 2019-03-23  Tom Tromey  <tom@tromey.com>
3770
3771         * linespec.c (get_current_search_block): Use
3772         scoped_restore_current_language.
3773         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3774
3775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3776             Jiong Wang  <jiong.wang@arm.com>
3777
3778         * aarch64-linux-tdep.c
3779         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3780         section.
3781         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3782
3783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3784             Jiong Wang  <jiong.wang@arm.com>
3785
3786         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3787         instructions.
3788         (aarch64_analyze_prologue_test): Add PACIASP test.
3789         (aarch64_prologue_prev_register): Unmask PC value.
3790
3791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3792             Jiong Wang  <jiong.wang@arm.com>
3793
3794         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3795         (aarch64_dwarf2_prev_register): Unmask PC value.
3796         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3797         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3798         DW_CFA_AARCH64_negate_ra_state.
3799         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3800
3801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3802             Jiong Wang  <jiong.wang@arm.com>
3803
3804         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3805         registers.
3806         (aarch64_pseudo_register_name): Likewise.
3807         (aarch64_pseudo_register_type): Likewise.
3808         (aarch64_pseudo_register_reggroup_p): Likewise.
3809         (aarch64_gdbarch_init): Add pauth registers.
3810         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3811         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3812         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3813         (struct gdbarch_tdep): Add regnum for ra_state.
3814
3815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3816             Jiong Wang  <jiong.wang@arm.com>
3817
3818         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3819
3820 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3821             Jiong Wang  <jiong.wang@arm.com>
3822
3823         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3824         function.
3825         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3826         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3827         (aarch64_gdbarch_init): Add puth registers.
3828         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3829         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3830         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3831
3832 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3833             Jiong Wang  <jiong.wang@arm.com>
3834
3835         * aarch64-linux-nat.c
3836         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3837         * aarch64-linux-tdep.c
3838         (aarch64_linux_core_read_description): Likewise.
3839         (aarch64_linux_get_hwcap): New function.
3840         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3841         (aarch64_linux_get_hwcap): New declaration.
3842
3843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3844             Jiong Wang  <jiong.wang@arm.com>
3845
3846         * aarch64-linux-nat.c
3847         (aarch64_linux_nat_target::read_description): Add pauth param.
3848         * aarch64-linux-tdep.c
3849         (aarch64_linux_core_read_description): Likewise.
3850         * aarch64-tdep.c (struct target_desc): Add in pauth.
3851         (aarch64_read_description): Add pauth param.
3852         (aarch64_gdbarch_init): Likewise.
3853         * aarch64-tdep.h (aarch64_read_description): Likewise.
3854         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3855         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3856         * features/Makefile: Add new files.
3857         * features/aarch64-pauth.c: New file.
3858         * features/aarch64-pauth.xml: New file.
3859
3860 2019-03-20  Tom Tromey  <tromey@adacore.com>
3861
3862         * infrun.c (handle_inferior_event): Rename from
3863         handle_inferior_event_1.  Create a scoped_value_mark.
3864         (handle_inferior_event): Remove.
3865
3866 2019-03-19  Tom Tromey  <tromey@adacore.com>
3867
3868         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3869         * infrun.h (print_stop_event): Add "displays" parameter.
3870         * infrun.c (print_stop_event): Add "displays" parameter.
3871
3872 2019-03-19  Pedro Alves  <palves@redhat.com>
3873
3874         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3875         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3876         to -1.  Fix TABs vs spaces.
3877         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3878         * tui/tui-out.h (tui_ui_out) Add intro comments.
3879         <m_line, m_start_of_line>: In-class initialize, and add describing
3880         comment.
3881
3882 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3883
3884         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3885         variable names.
3886         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3887
3888 2019-03-18  Pedro Alves  <palves@redhat.com>
3889             Eli Zaretskii <eliz@gnu.org>
3890
3891         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3892         m_line and m_start_of_line.
3893
3894 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3895
3896         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3897         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3898         it returns a newline.  This fixes a regression in TU mode, whereby
3899         the next line is output on the same screen line as the user input.
3900
3901 2019-03-18  Tom Tromey  <tromey@adacore.com>
3902
3903         * minsyms.c (minimal_symbol_reader::install): Remove call to
3904         obstack_blank.
3905
3906 2019-03-18  Pedro Alves  <palves@redhat.com>
3907
3908         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3909         New globals.
3910         (apply_style): New, factored out from ...
3911         (apply_ansi_escape): ... this.  Handle reverse video mode.
3912         (tui_set_reverse_mode): New function.
3913         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3914         * tui/tui-winsource.c (tui_show_source_line): Use
3915         tui_set_reverse_mode instead of setting A_STANDOUT.
3916         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3917         New setter methods.
3918
3919 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3920
3921         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3922         Handle tabs.
3923
3924 2019-03-18  Tom Tromey  <tromey@adacore.com>
3925
3926         * ada-lang.c (empty_array): Add "high" parameter.
3927         (ada_evaluate_subexp): Update.
3928
3929 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3930
3931         * unittests/string_view-selftests.c: Define
3932         _initialize_string_view_selftests unconditionally.
3933
3934 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3935
3936         PR gdb/24350
3937         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3938
3939 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3940
3941         PR gdb/24351
3942         * windows-nat.c (display_selector): Fix format specifiers.
3943
3944 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3945
3946         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3947         tui_refill_source_window instead of tui_refresh_win, to update the
3948         current execution line.  This fixes redisplay of the current line
3949         when stepping through the code with "next" or "step".
3950
3951 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3952
3953         * source-cache.c (source_cache::get_source_lines): Call
3954         find_source_lines to initialize s->nlines.  This fixes vertical
3955         scrolling of TUI source window when the DOWN arrow is pressed.
3956
3957 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3958
3959         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3960         linux-thread-db.c (_initialize_thread_db): Likewise.
3961
3962 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3963
3964         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3965         wclrtoeol in tui_show_source_line".  This reverts changes made in
3966         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3967
3968 2019-03-15  Tom Tromey  <tom@tromey.com>
3969
3970         * symtab.h (struct minimal_symbol): Derive from
3971         general_symbol_info.
3972         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3973         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3974         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3975         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3976         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3977         (MSYMBOL_SEARCH_NAME): Update.
3978         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3979         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3980         * minsyms.c (minimal_symbol_reader::record_full): Update.
3981
3982 2019-03-15  Tom Tromey  <tom@tromey.com>
3983
3984         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3985
3986 2019-03-15  Tom Tromey  <tom@tromey.com>
3987
3988         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3989         unique_xmalloc_ptr.
3990         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3991         Update.
3992         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3993         (build_minimal_symbol_hash_tables)
3994         (minimal_symbol_reader::install): Update.
3995
3996 2019-03-15  Tom Tromey  <tom@tromey.com>
3997
3998         * symtab.c (create_demangled_names_hash): Update.
3999         (symbol_set_names): Update.
4000         * objfiles.h (struct objfile_per_bfd_storage)
4001         <demangled_names_hash>: Now an htab_up.
4002         * objfiles.c (objfile_per_bfd_storage): Simplify.
4003
4004 2019-03-15  Tom Tromey  <tom@tromey.com>
4005
4006         * objfiles.h (struct objfile_per_bfd_storage): Declare
4007         destructor.
4008         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4009         New.
4010         (get_objfile_bfd_data): Use new.  Don't initialize
4011         language_of_main.
4012         (free_objfile_per_bfd_storage): Remove.
4013         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4014
4015 2019-03-15  Tom Tromey  <tom@tromey.com>
4016
4017         * symfile.c (reread_symbols): Update.
4018         * objfiles.c (objfile::objfile): Update.
4019         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4020         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4021         comment.
4022         (minimal_symbol_reader::install): Update.
4023         (terminate_minimal_symbol_table): Remove.
4024         * jit.c (jit_object_close_impl): Update.
4025
4026 2019-03-15  Tom Tromey  <tom@tromey.com>
4027
4028         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4029         initializations.
4030
4031 2019-03-15  Tom Tromey  <tom@tromey.com>
4032
4033         * objfiles.h (struct objfile_per_bfd_storage)
4034         <demangled_hash_languages>: Now a bitset.
4035         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4036         (lookup_minimal_symbol): Update.
4037
4038 2019-03-15  Tom Tromey  <tom@tromey.com>
4039
4040         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4041         Don't return the symbol.
4042         * coffread.c (record_minimal_symbol): Use record_full.
4043
4044 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4045
4046         The MS-Windows port of ncurses fails to switch to a color pair if
4047         one or both of the colors are the implicit default colors.  This
4048         change records the default colors when TUI is initialized, and
4049         then specifies them explicitly when a color pair uses the default
4050         colors.  This allows color styling in TUI mode on MS-Windows.
4051
4052         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4053         ncurses_norm_attr.
4054         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4055         colors in ncurses_norm_attr.
4056         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4057         "none", replace it with the default color recorded in
4058         ncurses_norm_attr.
4059
4060 2019-03-14  Tom Tromey  <tromey@adacore.com>
4061
4062         * source-cache.h (class source_cache) <get_source_lines>: Return
4063         std::string.
4064         * source-cache.c (source_cache::extract_lines): Handle case where
4065         first_pos==npos.  Return std::string.
4066         (source_cache::get_source_lines): Update.
4067
4068 2019-03-14  Tom Tromey  <tromey@adacore.com>
4069
4070         * NEWS: Add item for "style sources" commands.
4071         * source-cache.c (source_cache::get_source_lines): Check
4072         source_styling.
4073         * cli/cli-style.c (source_styling): New global.
4074         (_initialize_cli_style): Add "style sources" commands.
4075         (show_style_sources): New function.
4076         * cli/cli-style.h (source_styling): Declare.
4077
4078 2019-03-14  Pedro Alves  <palves@redhat.com>
4079             Tom Tromey  <tromey@adacore.com>
4080
4081         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4082         * tui/tui-winsource.c (tui_refill_source_window): New function,
4083         from...
4084         (tui_horizontal_source_scroll): ... here.  Move some logic.
4085         * cli/cli-style.c (set_style_enabled): Notify new observable.
4086         * tui/tui-hooks.c (tui_redisplay_source): New function.
4087         (tui_attach_detach_observers): Attach or detach
4088         tui_redisplay_source.
4089         * observable.h (source_styling_changed): New observable.
4090         * observable.c: Define source_styling_changed observable.
4091
4092 2019-03-13  Tom Tromey  <tromey@adacore.com>
4093
4094         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4095         (i386_gnu_nat_target::store_registers): Update.
4096         * target-debug.h (target_debug_print_std_string): New macro.
4097         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4098         * windows-tdep.c (display_one_tib): Update.
4099         * tui/tui-stack.c (tui_make_status_line): Update.
4100         * top.c (print_inferior_quit_action): Update.
4101         * thread.c (thr_try_catch_cmd): Update.
4102         (add_thread_with_info): Update.
4103         (thread_target_id_str): Update.
4104         (thr_try_catch_cmd): Update.
4105         (thread_command): Update.
4106         (thread_find_command): Update.
4107         * record-btrace.c (record_btrace_target::info_record)
4108         (record_btrace_resume_thread, record_btrace_target::resume)
4109         (record_btrace_cancel_resume, record_btrace_step_thread)
4110         (record_btrace_target::wait, record_btrace_target::wait)
4111         (record_btrace_target::wait, record_btrace_target::stop): Update.
4112         * progspace.c (print_program_space): Update.
4113         * process-stratum-target.c
4114         (process_stratum_target::thread_address_space): Update.
4115         * linux-fork.c (linux_fork_mourn_inferior)
4116         (detach_checkpoint_command, info_checkpoints_command)
4117         (linux_fork_context): Update.
4118         (linux_fork_detach): Update.
4119         (class scoped_switch_fork_info): Update.
4120         (delete_checkpoint_command): Update.
4121         * infrun.c (follow_fork_inferior): Update.
4122         (follow_fork_inferior): Update.
4123         (proceed_after_vfork_done): Update.
4124         (handle_vfork_child_exec_or_exit): Update.
4125         (follow_exec): Update.
4126         (displaced_step_prepare_throw): Update.
4127         (displaced_step_restore): Update.
4128         (start_step_over): Update.
4129         (resume_1): Update.
4130         (clear_proceed_status_thread): Update.
4131         (proceed): Update.
4132         (print_target_wait_results): Update.
4133         (do_target_wait): Update.
4134         (context_switch): Update.
4135         (stop_all_threads): Update.
4136         (restart_threads): Update.
4137         (finish_step_over): Update.
4138         (handle_signal_stop): Update.
4139         (switch_back_to_stepped_thread): Update.
4140         (keep_going_pass_signal): Update.
4141         (print_exited_reason): Update.
4142         (normal_stop): Update.
4143         * inferior.c (inferior_pid_to_str): Change return type.
4144         (print_selected_inferior): Update.
4145         (add_inferior): Update.
4146         (detach_inferior): Update.
4147         * dummy-frame.c (fprint_dummy_frames): Update.
4148         * dcache.c (dcache_info_1): Update.
4149         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4150         (btrace_fetch, btrace_clear): Update.
4151         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4152         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4153         type.
4154         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4155         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4156         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4157         * gdbarch.c, gdbarch.h: Rebuild.
4158         * gdbarch.sh (core_pid_to_str): Change return type.
4159         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4160         return type.
4161         (windows_nat_target::pid_to_str): Change return type.
4162         (windows_delete_thread): Update.
4163         (windows_nat_target::attach): Update.
4164         (windows_nat_target::files_info): Update.
4165         * target-delegates.c: Rebuild.
4166         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4167         return type.
4168         (sol_thread_target::pid_to_str): Change return type.
4169         * remote.c (class remote_target) <pid_to_str>: Change return
4170         type.
4171         (remote_target::pid_to_str): Change return type.
4172         (extended_remote_target::attach, remote_target::remote_stop_ns)
4173         (remote_target::remote_notif_remove_queued_reply)
4174         (remote_target::push_stop_reply, remote_target::disable_btrace):
4175         Update.
4176         (extended_remote_target::attach): Update.
4177         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4178         type.
4179         (gdbsim_target::pid_to_str): Change return type.
4180         * ravenscar-thread.c (struct ravenscar_thread_target)
4181         <pid_to_str>: Change return type.
4182         (ravenscar_thread_target::pid_to_str): Change return type.
4183         * procfs.c (class procfs_target) <pid_to_str>: Change return
4184         type.
4185         (procfs_target::pid_to_str): Change return type.
4186         (procfs_target::attach): Update.
4187         (procfs_target::detach): Update.
4188         (procfs_target::fetch_registers): Update.
4189         (procfs_target::store_registers): Update.
4190         (procfs_target::wait): Update.
4191         (procfs_target::files_info): Update.
4192         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4193         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4194         return type.
4195         (nto_procfs_target::pid_to_str): Change return type.
4196         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4197         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4198         return type.
4199         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4200         (exit_lwp): Update.
4201         (attach_proc_task_lwp_callback, get_detach_signal)
4202         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4203         (linux_nat_target::resume, wait_lwp, stop_callback)
4204         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4205         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4206         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4207         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4208         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4209         type.
4210         (inf_ptrace_target::attach): Update.
4211         (inf_ptrace_target::files_info): Update.
4212         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4213         type.
4214         (go32_nat_target::pid_to_str): Change return type.
4215         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4216         (gnu_nat_target::wait): Update.
4217         (gnu_nat_target::wait): Update.
4218         (gnu_nat_target::resume): Update.
4219         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4220         (fbsd_nat_target::wait): Update.
4221         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4222         type.
4223         (darwin_nat_target::attach): Update.
4224         * corelow.c (class core_target) <pid_to_str>: Change return type.
4225         (core_target::pid_to_str): Change return type.
4226         * target.c (normal_pid_to_str): Change return type.
4227         (default_pid_to_str): Likewise.
4228         (target_pid_to_str): Change return type.
4229         (target_translate_tls_address): Update.
4230         (target_announce_detach): Update.
4231         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4232         return type.
4233         (bsd_uthread_target::pid_to_str): Change return type.
4234         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4235         type.
4236         (bsd_kvm_target::pid_to_str): Change return type.
4237         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4238         return type.
4239         (aix_thread_target::pid_to_str): Change return type.
4240         * target.h (struct target_ops) <pid_to_str>: Change return type.
4241         (target_pid_to_str, normal_pid_to_str): Likewise.
4242         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4243         type.
4244         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4245         type.
4246         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4247         return type.
4248         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4249         type.
4250         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4251         type.
4252         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4253         return type.
4254
4255 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4256
4257         * NEWS: Mention that the new default MI version is 3.  Mention
4258         changes to the output of commands and events that deal with
4259         multi-location breakpoints.
4260         * breakpoint.c: Include "mi/mi-out.h".
4261         (print_one_breakpoint): Change output syntax if using MI version
4262         >= 3.
4263         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4264         New.
4265         (mi_multi_location_breakpoint_output_fixed): New.
4266         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4267         (mi_cmd_fix_multi_location_breakpoint_output): New.
4268         (mi_multi_location_breakpoint_output_fixed): New.
4269         * mi/mi-cmds.c (mi_cmds): Register command
4270         -fix-multi-location-breakpoint-output.
4271         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4272         interpreter "mi".
4273
4274 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4275
4276         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4277         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4278         instantiate mi_ui_out based on interpreter name.
4279         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4280         * mi/mi-main.c (mi_load_progress): Likewise.
4281
4282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4283
4284         * NEWS: Combine separate "New targets" sections for 8.3.
4285
4286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4287
4288         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4289         (ppcfbsd_init_abi): Install gdbarch
4290         "fetch_tls_load_module_address" and "get_thread_local_address"
4291         methods.
4292
4293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4294
4295         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4296         (riscv_fbsd_init_abi): Install gdbarch
4297         "fetch_tls_load_module_address" and "get_thread_local_address"
4298         methods.
4299
4300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4301
4302         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4303         (i386fbsd_init_abi): Install gdbarch
4304         "fetch_tls_load_module_address" and "get_thread_local_address"
4305         methods.
4306
4307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4308
4309         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4310         (amd64fbsd_init_abi): Install gdbarch
4311         "fetch_tls_load_module_address" and "get_thread_local_address"
4312         methods.
4313
4314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4315
4316         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4317         (struct fbsd_pspace_data): New type.
4318         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4319         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4320         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4321         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4322         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4323
4324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4325
4326         * gdbtypes.c (lookup_struct_elt): New function.
4327         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4328         * gdbtypes.h (struct struct_elt): New type.
4329         (lookup_struct_elt): New prototype.
4330
4331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4332
4333         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4334         remove disabled code block.
4335
4336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4337
4338         * gdbarch.sh (get_thread_local_address): New method.
4339         * gdbarch.h, gdbarch.c: Regenerate.
4340         * target.c (target_translate_tls_address): Use
4341         gdbarch_get_thread_local_address if present instead of
4342         target::get_thread_local_address.
4343
4344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4345
4346         * target.h (target::get_thread_local_address): Update comment.
4347
4348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4349
4350         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4351         objfile->separate_debug_objfile_backlink if not NULL.
4352
4353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4354
4355         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4356         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4357         (amd64bsd_store_inferior_registers): Likewise.
4358         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4359         Enable segment base registers.
4360         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4361         PT_GETFSBASE and PT_GETGSBASE.
4362         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4363         PT_SETGSBASE.
4364         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4365         segment base registers.
4366         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4367
4368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4369
4370         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4371         Update calls to i386_target_description to add 'segments'
4372         parameter.
4373         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4374         add segment base registers.
4375         * arch/i386.c (i386_create_target_description): Add 'segments'
4376         parameter to enable segment base registers.
4377         * arch/i386.h (i386_create_target_description): Likewise.
4378         * features/i386/32bit-segments.xml: New file.
4379         * features/i386/32bit-segments.c: Generate.
4380         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4381         call to i386_target_description to add 'segments' parameter.
4382         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4383         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4384         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4385         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4386         if feature is present.
4387         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4388         Add 'segments' parameter to call to i386_target_description.
4389         (i386_target_description): Add 'segments' parameter to enable
4390         segment base registers.
4391         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4392         to call to i386_target_description.
4393         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4394         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4395         Define I386_NUM_REGS.
4396         (i386_target_description): Add 'segments' parameter to enable
4397         segment base registers.
4398
4399 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4400
4401         PR/24325
4402         * source-cache.c: #undef open and close, to avoid unresolved
4403         externals during linking.
4404
4405 2019-03-12  Tom Tromey  <tromey@adacore.com>
4406
4407         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4408         const.  Add initializers.
4409         (_initialize_remote): Don't initialize ptid globals.
4410
4411 2019-03-12  Pedro Alves  <palves@redhat.com>
4412
4413         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4414
4415 2019-03-12  Pedro Alves  <palves@redhat.com>
4416
4417         * cp-name-parser.y (main): Remove unused 'len' variable.
4418
4419 2019-03-12  Tom Tromey  <tromey@adacore.com>
4420
4421         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4422         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4423
4424 2019-03-12  Tom Tromey  <tromey@adacore.com>
4425
4426         * linux-nat.c (iterate_over_lwps): Update.
4427         (stop_callback): Remove parameter.
4428         (stop_wait_callback, detach_callback, resume_set_callback)
4429         (select_singlestep_lwp_callback, set_ignore_sigint)
4430         (status_callback, resumed_callback, resume_clear_callback)
4431         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4432         data parameter.
4433         (linux_nat_target::detach, linux_nat_target::resume)
4434         (linux_stop_and_wait_all_lwps, select_event_lwp)
4435         (linux_nat_filter_event, linux_nat_wait_1)
4436         (linux_nat_target::kill, linux_nat_target::stop)
4437         (linux_nat_target::stop): Update.
4438         (linux_nat_resume_callback): Change type.
4439         (resume_stopped_resumed_lwps, count_events_callback)
4440         (select_event_lwp_callback): Likewise.
4441         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4442         * arm-linux-nat.c (struct update_registers_data): Remove.
4443         (update_registers_callback): Change type.
4444         (arm_linux_insert_hw_breakpoint1): Update.
4445         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4446         parameter.
4447         (x86_linux_dr_set_addr): Update.
4448         (x86_linux_dr_set_control): Update.
4449         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4450         (iterate_over_lwps): Use gdb::function_view.
4451         * nat/aarch64-linux-hw-point.c (struct
4452         aarch64_dr_update_callback_param): Remove.
4453         (debug_reg_change_callback): Change type.
4454         (aarch64_notify_debug_reg_change): Update.
4455         * s390-linux-nat.c (s390_refresh_per_info): Update.
4456
4457 2019-03-11  Tom Tromey  <tromey@adacore.com>
4458
4459         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4460         redundant assignment to "this_cu".
4461
4462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4463
4464         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4465
4466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4467
4468         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4469         from...
4470         (rank_one_type): ... this.
4471
4472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4473
4474         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4475         from...
4476         (rank_one_type): ... this.
4477
4478 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4479
4480         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4481         from...
4482         (rank_one_type): ... this.
4483
4484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4485
4486         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4487         from...
4488         (rank_one_type): ... this.
4489
4490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4491
4492         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4493         from...
4494         (rank_one_type): ... this.
4495
4496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4497
4498         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4499         from...
4500         (rank_one_type): ... this.
4501
4502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4503
4504         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4505         from...
4506         (rank_one_type): ... this.
4507
4508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4509
4510         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4511         from...
4512         (rank_one_type): ... this.
4513
4514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4515
4516         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4517         from...
4518         (rank_one_type): ... this.
4519
4520 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4521
4522         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4523         from...
4524         (rank_one_type): ... this.
4525
4526 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4527
4528         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4529         from...
4530         (rank_one_type): ... this.
4531
4532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4533
4534         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4535         from...
4536         (rank_one_type): ... this.
4537
4538 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4539
4540         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4541         inferior-events' shows the example events.
4542
4543 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4544
4545         Support styling on native MS-Windows console
4546
4547         PR/24315
4548         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4549         on MS-Windows if $TERM is not defined.
4550
4551         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4552
4553         * posix-hdep.c (gdb_console_fputs):
4554         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4555         functions.
4556         * ui-file.h (gdb_console_fputs): Add prototype.
4557
4558         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4559         back to fputs only if the former returns zero.
4560
4561 2019-03-07  Tom Tromey  <tom@tromey.com>
4562
4563         * symmisc.c (print_symbol_bcache_statistics): Update.
4564         (print_objfile_statistics): Update.
4565         * symfile.c (allocate_symtab): Update.
4566         * stabsread.c: Don't include bcache.h.
4567         * psymtab.h (struct psymbol_bcache): Don't declare.
4568         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4569         (psymbol_bcache_init, psymbol_bcache_free)
4570         (psymbol_bcache_get_bcache): Don't declare.
4571         * psymtab.c (struct psymbol_bcache): Remove.
4572         (psymtab_storage::psymtab_storage): Update.
4573         (psymtab_storage::~psymtab_storage): Update.
4574         (psymbol_bcache_init, psymbol_bcache_free)
4575         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4576         (add_psymbol_to_bcache): Update.
4577         (allocate_psymtab): Update.
4578         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4579         macro_cache>: No longer pointers.
4580         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4581         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4582         * macrotab.c (macro_bcache): Update.
4583         * macroexp.c: Don't include bcache.h.
4584         * gdbtypes.c (check_types_worklist): Update.
4585         (types_deeply_equal): Remove TRY/CATCH.  Update.
4586         * elfread.c (elf_symtab_read): Update.
4587         * dwarf2read.c: Don't include bcache.h.
4588         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4589         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4590         (print_bcache_statistics, bcache_memory_used): Don't declare.
4591         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4592         methods.  Rename all data members.
4593         * bcache.c (struct bcache): Move to bcache.h.
4594         (bcache::expand_hash_table): Rename from expand_hash_table.
4595         (bcache): Remove.
4596         (bcache::insert): Rename from bcache_full.
4597         (bcache::compare): Rename from bcache_compare.
4598         (bcache_xmalloc): Remove.
4599         (bcache::~bcache): Rename from bcache_xfree.
4600         (bcache::print_statistics): Rename from print_bcache_statistics.
4601         (bcache::memory_used): Rename from bcache_memory_used.
4602
4603 2019-03-07  Pedro Alves  <palves@redhat.com>
4604
4605         * infrun.c (normal_stop): Also check for
4606         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4607
4608 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * f-lang.c (value_from_host_double): Moved to...
4611         * value.c (value_from_host_double): ...here.
4612         * value.h (value_from_host_double): Declare.
4613         * guile/scm-math.c (vlscm_convert_typed_number): Use
4614         value_from_host_double.
4615         (vlscm_convert_number): Likewise.
4616         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4617         * python/py-value.c (convert_value_from_python): Likewise.
4618
4619 2019-03-06  Tom Tromey  <tom@tromey.com>
4620
4621         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4622
4623 2019-03-06  Tom Tromey  <tom@tromey.com>
4624
4625         * utils.h (free_current_contents): Don't declare.
4626         * utils.c (free_current_contents): Remove.
4627
4628 2019-03-06  Tom Tromey  <tom@tromey.com>
4629
4630         * top.c (quit_force): Update.
4631         * main.c (captured_command_loop): Update.
4632         * common/new-op.c (operator new): Update.
4633         * common/common-exceptions.c (struct catcher)
4634         <save_cleanup_chain>: Remove member.
4635         (exceptions_state_mc_init): Update.
4636         (exception_try_scope_entry): Return nullptr.
4637         (exception_try_scope_exit, exception_rethrow)
4638         (throw_exception_sjlj, throw_exception_cxx): Update.
4639         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4640         (all_cleanups, do_cleanups, discard_cleanups)
4641         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4642         (restore_cleanups, restore_final_cleanups): Don't declare.
4643         (do_final_cleanups): Remove parameter.
4644         * common/cleanups.c (cleanup_chain, make_cleanup)
4645         (make_cleanup_dtor, all_cleanups, do_cleanups)
4646         (discard_my_cleanups, discard_cleanups)
4647         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4648         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4649         (null_cleanup): Remove.
4650         (do_final_cleanups): Remove parameter.
4651
4652 2019-03-06  Tom Tromey  <tom@tromey.com>
4653
4654         * remote.c (remote_target::remote_parse_stop_reply): Use
4655         unique_xmalloc_ptr.
4656
4657 2019-03-06  Tom Tromey  <tom@tromey.com>
4658
4659         * stabsread.c (struct stabs_field_info): Rename from field_info.
4660         <list, fnlist>: Add initializers.
4661         <obstack>: New member.
4662         (read_member_functions, read_struct_fields, read_baseclasses):
4663         Allocate on obstack.  Don't use cleanups.
4664         (read_one_struct_field, read_member_functions, read_struct_fields)
4665         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4666         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4667         (read_struct_type): Update.
4668
4669 2019-03-06  Tom Tromey  <tom@tromey.com>
4670
4671         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4672         * common/filestuff.h (make_cleanup_close): Don't declare.
4673         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4674         Remove.
4675
4676 2019-03-06  Tom Tromey  <tom@tromey.com>
4677
4678         * solib-aix.c: Use make_scope_exit.
4679
4680 2019-03-06  Tom Tromey  <tom@tromey.com>
4681
4682         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4683         Use make_scope_exit.
4684
4685 2019-03-06  Tom Tromey  <tom@tromey.com>
4686
4687         * solib-svr4.c (disable_probes_interface): Remove parameter.
4688         (svr4_handle_solib_event): Use make_scope_exit.
4689
4690 2019-03-06  Tom Tromey  <tom@tromey.com>
4691
4692         * remote.c (struct stop_reply_deleter): Remove.
4693         (stop_reply_up): Update.
4694         (struct stop_reply): Derive from notif_event.  Don't typedef.
4695         <regcache>: Now a std::vector.
4696         (stop_reply_xfree): Remove.
4697         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4698         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4699         (remote_target::discard_pending_stop_replies): Use delete.
4700         (remote_target::remote_parse_stop_reply): Update.
4701         (remote_target::process_stop_reply): Update.
4702         * remote-notif.h (struct notif_event): Add virtual destructor.
4703         Remove "dtr" member.
4704         (struct notif_client) <alloc_event>: Return a unique_ptr.
4705         (notif_event_xfree): Don't declare.
4706         (notif_event_up): New typedef.
4707         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4708         (notif_event_xfree, do_notif_event_xfree): Remove.
4709         (remote_notif_state_xfree): Update.
4710
4711 2019-03-06  Tom Tromey  <tom@tromey.com>
4712
4713         * infrun.c (displaced_step_clear_cleanup): Now a
4714         forward_scope_exit type.
4715         (displaced_step_prepare_throw): Update.
4716         (displaced_step_fixup): Update.
4717
4718 2019-03-06  Tom Tromey  <tom@tromey.com>
4719
4720         * inferior.h (class inferior): Update comment.
4721         * gdbthread.h (class thread_info): Update comment.
4722
4723 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4724             Tom Tromey  <tom@tromey.com>
4725
4726         * stabsread.h (struct stab_section_list): Remove.
4727         (coffstab_build_psymtabs): Update.
4728         * dbxread.c (symbuf_sections): Now a std::vector.
4729         (sect_idx): New global.
4730         (fill_symbuf): Update.
4731         (coffstab_build_psymtabs): Change type of stabsects parameter.
4732         Update.
4733         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4734         std::vector.
4735         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4736         (coff_locate_sections): Update.
4737         (coff_symfile_read): Remove cleanups.  Update.
4738         (init_stringtab): Add storage parameter.
4739         (free_stringtab, free_stringtab_cleanup): Remove.
4740         (init_lineno): Add storage parameter.
4741         (free_linetab, free_linetab_cleanup): Remove.
4742
4743 2019-03-06  Pedro Alves  <palves@redhat.com>
4744
4745         * linux-fork.c (fork_info::clobber_regs): Delete.
4746         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4747         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4748         comment.  Adjust.
4749         (scoped_switch_fork_info::scoped_switch_fork_info)
4750         (checkpoint_command, linux_fork_context): Adjust
4751         fork_save_infrun_state calls.
4752
4753 2019-03-06  Pedro Alves  <palves@redhat.com>
4754
4755         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4756         (inf_has_multiple_threads): Return 'bool' and rewrite using
4757         inferior_info::threads().
4758
4759 2019-03-06  Pedro Alves  <palves@redhat.com>
4760
4761         * linux-fork.c: Include <list>.
4762         (fork_list): Now a std::list instance.
4763         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4764         (forks_exist_p, find_last_fork): Adjust.
4765         (new_fork): Delete.
4766         (one_fork_p): New.
4767         (add_fork): Adjust.
4768         (free_fork): Delete, folded into fork_info::~fork_info().
4769         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4770         Adjust.
4771         (init_fork_list): Delete.
4772         (linux_fork_killall, linux_fork_mourn_inferior)
4773         (linux_fork_detach, info_checkpoints_command): Adjust.
4774         (_initialize_linux_fork): No longer call init_fork_list.
4775
4776 2019-03-06  Pedro Alves  <palves@redhat.com>
4777
4778         * linux-fork.c (new_fork): New, split out of ...
4779         (add_fork): ... this.  Return void.  Move "first fork" special
4780         case from here, to ...
4781         (checkpoint_command): ... here.
4782         * linux-linux.h (add_fork): Return void.
4783
4784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4785
4786         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4787
4788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4789             Chris January  <chris.january@arm.com>
4790             David Lecomber  <david.lecomber@arm.com>
4791
4792         * f-exp.y: New token, UNOP_INTRINSIC.
4793         (exp): New pattern using UNOP_INTRINSIC token.
4794         (f77_keywords): Add 'abs' keyword.
4795         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4796         (value_from_host_double): New function.
4797         (evaluate_subexp_f): Support UNOP_ABS.
4798
4799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4802         types.
4803
4804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4805
4806         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4807         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4808         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4809
4810 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4813
4814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4815             Chris January  <chris.january@arm.com>
4816
4817         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4818         * f-exp.y: Define 'KIND' token.
4819         (exp): New pattern for KIND expressions.
4820         (ptype): Handle types with a kind extension.
4821         (direct_abs_decl): Extend to spot kind extensions.
4822         (f77_keywords): Add 'kind' to the list.
4823         (push_kind_type): New function.
4824         (convert_to_kind_type): New function.
4825         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4826         * parse.c (operator_length_standard): Likewise.
4827         * parser-defs.h (enum type_pieces): Add tp_kind.
4828         * std-operator.def: Add UNOP_KIND.
4829
4830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * f-exp.y (f_parse): Set yydebug.
4833
4834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * f-lang.c (evaluate_subexp_f): New function.
4837         (exp_descriptor_f): New global.
4838         (f_language_defn): Use exp_descriptor_f instead of
4839         exp_descriptor_standard.
4840
4841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * f-exp.y (struct token): Add comments.
4844         (dot_ops): Remove uppercase versions and the end marker.
4845         (f77_keywords): Likewise.
4846         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4847         entries in the dot_ops array are case insensitive, and use
4848         strncasecmp to compare strings.  Also some whitespace cleanup in
4849         this area.  Similar for the f77_keywords array, except entries in
4850         this list might be case sensitive.
4851
4852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * f-exp.y (struct f77_boolean_val): Add comments.
4855         (boolean_values): Remove uppercase versions, and end marker.
4856         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4857         and use strncasecmp to achieve case insensitivity.  Additionally,
4858         perform whitespace cleanup around this code.
4859
4860 2019-03-06  Tom Tromey  <tromey@adacore.com>
4861
4862         * remote-sim.c (gdbsim_target_open): Use result of
4863         gdb_argv::release.
4864
4865 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4866         Dirk Schubert  <dirk.schubert@arm.com>
4867         Chris January  <chris.january@arm.com>
4868
4869         * eval.c (evaluate_subexp_standard): Call Fortran argument
4870         wrapping logic.
4871         * f-lang.c (struct value): A value which can be passed into a
4872         Fortran function call.
4873         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4874         where appropriate.
4875         (struct type): Value ready for a Fortran function call.
4876         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4877         is needed.
4878         * f-lang.h (fortran_argument_convert): Declaration.
4879         (fortran_preserve_arg_pointer): Declaration.
4880         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4881
4882 2019-03-05  Tom Tromey  <tromey@adacore.com>
4883
4884         * python/py-prettyprint.c (print_string_repr): Remove #if.
4885         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4886
4887 2019-03-05  Tom Tromey  <tromey@adacore.com>
4888
4889         * target.c (the_dummy_target): Move later.  Change type to
4890         "dummy_target".
4891         (initialize_targets): Don't initialize the_dummy_target.
4892
4893 2019-03-05  Tom Tromey  <tromey@adacore.com>
4894
4895         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4896         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4897
4898 2019-03-05  Tom Tromey  <tromey@adacore.com>
4899
4900         * windows-nat.c (windows_nat_target::attach)
4901         (windows_nat_target::detach): Don't call gdb_flush.
4902         * valprint.c (generic_val_print, val_print, val_print_string):
4903         Don't call gdb_flush.
4904         * utils.c (defaulted_query): Don't call gdb_flush.
4905         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4906         * target.c (target_announce_detach): Don't call gdb_flush.
4907         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4908         * remote.c (extended_remote_target::attach): Don't call
4909         gdb_flush.
4910         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4911         * printcmd.c (do_examine): Don't call gdb_flush.
4912         (info_display_command): Don't call gdb_flush.
4913         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4914         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4915         * memattr.c (info_mem_command): Don't call gdb_flush.
4916         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4917         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4918         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4919         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4920         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4921         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4922         (gnu_nat_target::detach): Don't call gdb_flush.
4923         * f-valprint.c (f_val_print): Don't call gdb_flush.
4924         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4925         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4926         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4927         gdb_flush.
4928         * c-valprint.c (c_val_print): Don't call gdb_flush.
4929         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4930
4931 2019-03-05  Tom Tromey  <tromey@adacore.com>
4932
4933         * varobj.c (update_dynamic_varobj_children): Update.
4934         (install_default_visualizer): Use reset, not release.
4935         * value.c (set_internalvar): Update.
4936         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4937         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4938         ATTRIBUTE_UNUSED_RESULT.
4939
4940 2019-03-05  Tom Tromey  <tromey@adacore.com>
4941
4942         * remote.c (class scoped_remote_fd) <release>: Add
4943         ATTRIBUTE_UNUSED_RESULT.
4944
4945 2019-03-05  Tom Tromey  <tromey@adacore.com>
4946
4947         * macroexp.c (struct macro_buffer) <release>: Add
4948         ATTRIBUTE_UNUSED_RESULT.
4949
4950 2019-03-05  Tom Tromey  <tromey@adacore.com>
4951
4952         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4953         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4954         ATTRIBUTE_UNUSED_RESULT.
4955
4956 2019-03-05  Tom Tromey  <tromey@adacore.com>
4957
4958         * common/scoped_fd.h (class scoped_fd) <release>: Add
4959         ATTRIBUTE_UNUSED_RESULT.
4960
4961 2019-03-05  Tom Tromey  <tromey@adacore.com>
4962
4963         * parser-defs.h (struct parser_state) <release>: Add
4964         ATTRIBUTE_UNUSED_RESULT.
4965
4966 2019-03-05  Tom Tromey  <tromey@adacore.com>
4967
4968         * utils.h (class gdb_argv) <release>: Add
4969         ATTRIBUTE_UNUSED_RESULT.
4970         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4971
4972 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4973
4974         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4975         for-loop range, to avoid compiler warnings.
4976
4977         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4978         avoid compiler warnings about unused variables.
4979
4980         * NEWS: Mention end of support for native debugging on MS-Windows
4981         before XP.
4982
4983         PR gdb/24292
4984         * common/netstuff.c:
4985         * gdbserver/gdbreplay.c
4986         * gdbserver/remote-utils.c:
4987         * ser-tcp.c:
4988         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4989         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4990         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4991         'getaddrinfo' and 'freeaddrinfo' were not available before
4992         Windows XP, and mingw.org's MinGW headers by default define
4993         _WIN32_WINNT to 0x500.
4994
4995 2019-03-01  Gary Benson <gbenson@redhat.com>
4996
4997         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4998
4999 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5000             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5001
5002         PR gdb/8527
5003         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5004         set_sigint_trap, clear_sigint_trap.
5005
5006 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5007
5008         * target.c (target_detach): Clear the regcache and the
5009         frame cache.
5010
5011 2019-02-27  Pedro Alves  <palves@redhat.com>
5012
5013         * utils.c (set_screen_size): When we cap the height/width sizes,
5014         tweak the corresponding command variable to show "unlimited":
5015
5016 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5017             Pedro Alves  <palves@redhat.com>
5018
5019         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5020         before calling rl_set_screen_size.
5021
5022 2019-02-27  Tom Tromey  <tromey@adacore.com>
5023
5024         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5025         define.
5026         * python/py-value.c: Remove Python 2.4 workaround.
5027         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5028         workaround.
5029         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5030         Python 2.4 workaround.
5031         * python/python-internal.h: Remove Python 2.4 comment.
5032         (Py_ssize_t): Don't define.
5033         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5034         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5035         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5036         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5037         * python/python.c (do_start_initialization): Remove Python 2.4
5038         workaround.
5039         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5040         (print_children): Remove Python 2.4 workaround.
5041         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5042         workaround.
5043         (CHARBUFFERPROC_NAME): Remove.
5044         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5045         Python 2.4 workaround.
5046
5047 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5048
5049         * NEWS: Note minimum Python version.
5050
5051 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5052
5053         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5054         code from these functions.  Remove corresponding ifdefs.  Use
5055         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5056         Remove gotos and target of gotos.
5057         (infpy_search_memory): Likewise.
5058
5059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5062         (hppa_gdbarch_init): Don't register deleted functions with
5063         gdbarch.
5064
5065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5068         (h8300_unwind_sp): Delete.
5069         (h8300_dummy_id): Delete.
5070         (h8300_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5076         (ft32_unwind_pc): Delete.
5077         (ft32_unwind_sp): Delete.
5078         (ft32_gdbarch_init): Don't register deleted functions with
5079         gdbarch.
5080
5081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5084         (frv_unwind_pc): Delete.
5085         (frv_unwind_sp): Delete.
5086         (frv_gdbarch_init): Don't register deleted functions with
5087         gdbarch.
5088
5089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5092         (riscv_unwind_pc): Delete.
5093         (riscv_unwind_sp): Delete.
5094         (riscv_gdbarch_init): Don't register deleted functions with
5095         gdbarch.
5096
5097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5100         (csky_unwind_pc): Delete.
5101         (csky_unwind_sp): Delete.
5102         (csky_gdbarch_init): Don't register deleted functions with
5103         gdbarch.
5104
5105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5106
5107         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5108         (cris_unwind_pc): Delete.
5109         (cris_unwind_sp): Delete.
5110         (cris_gdbarch_init): Don't register deleted functions with
5111         gdbarch.
5112
5113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5114
5115         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5116         (bfin_unwind_pc): Delete.
5117         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5118
5119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5122         (arm_unwind_pc): Delete.
5123         (arm_unwind_sp): Delete.
5124         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5125
5126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5129         (arc_unwind_pc): Delete.
5130         (arc_unwind_sp): Delete.
5131         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5132
5133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5136         (alpha_unwind_pc): Delete.
5137         (alpha_gdbarch_init): Don't register deleted functions with
5138         gdbarch.
5139
5140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5143         (aarch64_unwind_pc): Delete.
5144         (aarch64_unwind_sp): Delete.
5145         (aarch64_gdbarch_init): Don't register deleted functions with
5146         gdbarch.
5147
5148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * gdbtypes.c (type_align): Don't consider static members when
5151         computing structure alignment.
5152
5153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5154
5155         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5156         return 0 for other types.
5157         * arch-utils.c (default_type_align): Always return 0.
5158         * gdbarch.h: Regenerate.
5159         * gdbarch.sh (type_align): Extend comment.
5160         * gdbtypes.c (type_align): Add additional comments, always call
5161         gdbarch_type_align before applying the default rules.
5162         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5163         generic code will then apply a suitable default.
5164         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5165         types, return 0 for other types.
5166
5167 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5168
5169         * NEWS: Create a new section for the next release branch.
5170         Rename the section of the current branch, now that it has
5171         been cut.
5172
5173 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5174
5175         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5176         * version.in: Bump version to 8.3.50.DATE-git.
5177
5178 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5179
5180         * aix-thread.c (ptid_cmp): Remove unused variable.
5181         (get_signaled_thread): Likewise.
5182         (store_regs_user_thread): Likewise.
5183         (store_regs_kernel_thread): Likewise.
5184         (fetch_regs_kernel_thread): Remove shadowed variable.
5185
5186 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5187
5188         * features/riscv/32bit-cpu.xml: Add register numbers.
5189         * features/riscv/32bit-fpu.c: Regenerate.
5190         * features/riscv/32bit-fpu.xml: Add register numbers.
5191         * features/riscv/64bit-cpu.xml: Add register numbers.
5192         * features/riscv/64bit-fpu.c: Regenerate.
5193         * features/riscv/64bit-fpu.xml: Add register numbers.
5194
5195 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5196
5197         * NEWS: Mention two argument form of gdb.Value constructor.
5198         * python/py-value.c (convert_buffer_and_type_to_value): New
5199         function.
5200         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5201         Add support for handling an optional second argument.  Call
5202         convert_buffer_and_type_to_value as appropriate.
5203         * python/python-internal.h (Py_buffer_deleter): New struct.
5204         (Py_buffer_up): New typedef.
5205
5206 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5207
5208         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5209         instead of releasing ownership.
5210
5211 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5212
5213         * dwarf2read.c (open_and_init_dwp_file): Call
5214         elf_numsections instead of bfd_count_sections to initialize
5215         dwp_file->num_sections.
5216
5217 2019-02-25  Tom Tromey  <tromey@adacore.com>
5218
5219         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5220
5221 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5222
5223         * gcore.in: Add '--readnever' option when invoking GDB.
5224
5225 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5226
5227         * MAINTAINERS: Update my email address.
5228
5229 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5230
5231         * build-id.c (build_id_to_debug_bfd_1): New function.
5232         (build_id_to_debug_bfd): Look for separate debug file in
5233         sysroot.
5234
5235 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5236
5237         * gdbarch.sh: Update the copyright year range that is placed into
5238         generated files.
5239
5240 2019-02-22  Keith Seitz  <keiths@redhat.com>
5241
5242         PR symtab/23853
5243         * linespec.c (create_sals_line_offset): Search for the default
5244         symtab's filename instead of its fullname.
5245
5246 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5247
5248         * NEWS: Update style defaults.
5249
5250 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5251
5252         * main.c (captured_main_1): Disable styling in batch mode.
5253
5254 2019-02-20  Tom Tromey  <tom@tromey.com>
5255
5256         * symtab.c (symtab_symbol_info): Fix typos.
5257
5258 2019-02-20  Tom Tromey  <tromey@adacore.com>
5259
5260         * findcmd.c (_initialize_mem_search): Use upper case for
5261         metasyntactic variables.
5262
5263 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5264
5265         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5266         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5267
5268 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5269
5270         * top.h (source_file_name): Change to std::string.
5271         * top.c (source_file_name): Likewise.
5272         (command_line_input): Adjust.
5273         * cli/cli-script.c (script_from_file): Adjust.
5274
5275 2019-02-19  Tom Tromey  <tromey@adacore.com>
5276
5277         * ravenscar-thread.c
5278         (ravenscar_thread_target::update_thread_list): Don't call
5279         ada_build_task_list.
5280         * ada-lang.h (ada_build_task_list): Don't declare.
5281         * ada-tasks.c (struct ada_tasks_inferior_data)
5282         <task_list_valid_p>: Now bool.
5283         (read_known_tasks, ada_task_list_changed)
5284         (ada_tasks_invalidate_inferior_data): Update.
5285         (read_known_tasks_array): Return bool.
5286         (read_known_tasks_list): Likewise.
5287         (read_known_tasks): Return void.
5288         (ada_build_task_list): Now static.
5289
5290 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5293         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5294
5295 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5296
5297         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5298         variant for ada_tasks_pspace_data_handle and
5299         ada_tasks_inferior_data_handle.
5300         (ada_tasks_pspace_data_cleanup): New function.
5301         (ada_tasks_inferior_data_cleanup): New function.
5302
5303 2019-02-17  Tom Tromey  <tom@tromey.com>
5304
5305         * macrotab.h (macro_source_fullname): Return a std::string.
5306         * macrotab.c (macro_include, check_for_redefinition)
5307         (macro_undef, macro_lookup_definition, foreach_macro)
5308         (foreach_macro_in_scope): Update.
5309         (macro_source_fullname): Return a std::string.
5310         * macrocmd.c (show_pp_source_pos): Update.
5311
5312 2019-02-17  Tom Tromey  <tom@tromey.com>
5313
5314         * macrocmd.c (show_pp_source_pos): Style the file names.
5315
5316 2019-02-17  Tom Tromey  <tom@tromey.com>
5317
5318         PR tui/24197:
5319         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5320
5321 2019-02-17  Tom Tromey  <tom@tromey.com>
5322
5323         * ada-lang.c (user_select_syms): Use filtered printing.
5324         * utils.c (wrap_style): New global.
5325         (desired_style): Remove.
5326         (emit_style_escape): Add stream parameter.
5327         (set_output_style, reset_terminal_style, prompt_for_continue):
5328         Update.
5329         (flush_wrap_buffer): Only flush gdb_stdout.
5330         (wrap_here): Set wrap_style.
5331         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5332         treat escape sequences as a character.  Change when wrap buffer is
5333         flushed.
5334         (fputs_styled): Do not set the output style when the default is
5335         requested.
5336         * ui-style.h (struct ui_file_style) <is_default>: New method.
5337         * source.c (print_source_lines_base): Emit escape sequences in one
5338         piece.
5339
5340 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5341
5342         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5343         integers and enumeration types.
5344
5345 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5346
5347         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5348         instead of lookup_symbol_in_language
5349         (do_exact_match): New function.
5350         (ada_get_symbol_name_matcher): Return do_exact_match when
5351         doing a verbatim match.
5352
5353 2019-02-15  Tom Tromey  <tromey@adacore.com>
5354
5355         * ravenscar-thread.c (ravenscar_thread_target::resume)
5356         (ravenscar_thread_target::wait): Special case wildcard requests.
5357
5358 2019-02-15  Tom Tromey  <tromey@adacore.com>
5359
5360         * ravenscar-thread.c (base_ptid): Remove.
5361         (struct ravenscar_thread_target) <close>: New method.
5362         <m_base_ptid>: New member.
5363         <update_inferior_ptid, active_task, task_is_currently_active,
5364         runtime_initialized>: Declare methods.
5365         <ravenscar_thread_target>: Add constructor.
5366         (ravenscar_thread_target::task_is_currently_active)
5367         (ravenscar_thread_target::update_inferior_ptid)
5368         (ravenscar_runtime_initialized): Rename.  Now methods.
5369         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5370         (ravenscar_thread_target::update_thread_list): Update.
5371         (ravenscar_thread_target::active_task): Now method.
5372         (ravenscar_thread_target::store_registers)
5373         (ravenscar_thread_target::prepare_to_store)
5374         (ravenscar_thread_target::prepare_to_store)
5375         (ravenscar_thread_target::mourn_inferior): Update.
5376         (ravenscar_inferior_created): Use "new" to create target.
5377         (ravenscar_thread_target::get_ada_task_ptid): Update.
5378         (_initialize_ravenscar): Don't initialize base_ptid.
5379         (ravenscar_ops): Remove global.
5380
5381 2019-02-15  Tom Tromey  <tromey@adacore.com>
5382
5383         * target.h (push_target): Declare new overload.
5384         * target.c (push_target): New overload, taking an rvalue reference.
5385         * remote.c (remote_target::open_1): Use push_target overload.
5386         * corelow.c (core_target_open): Use push_target overload.
5387
5388 2019-02-15  Tom Tromey  <tromey@adacore.com>
5389
5390         * ravenscar-thread.c (is_ravenscar_task)
5391         (ravenscar_task_is_currently_active): Return bool.
5392         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5393         (_initialize_ravenscar): Remove "(void)".
5394         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5395         Return bool.
5396
5397 2019-02-15  Tom Tromey  <tromey@adacore.com>
5398
5399         * ravenscar-thread.c (ravenscar_runtime_initializer)
5400         (has_ravenscar_runtime, get_running_thread_id)
5401         (ravenscar_thread_target::resume): Fix indentation.
5402
5403 2019-02-15  Tom Tromey  <tromey@adacore.com>
5404
5405         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5406         from ravenscar_arch_ops.
5407         (sparc_ravenscar_ops::fetch_registers)
5408         (sparc_ravenscar_ops::store_registers): Now methods.
5409         (sparc_ravenscar_prepare_to_store): Remove.
5410         (sparc_ravenscar_ops): Redefine.
5411         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5412         methods and destructor.  Remove members.
5413         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5414         (ravenscar_thread_target::store_registers)
5415         (ravenscar_thread_target::prepare_to_store): Update.
5416         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5417         Remove.
5418         (struct ppc_ravenscar_powerpc_ops): Derive from
5419         ravenscar_arch_ops.
5420         (ppc_ravenscar_powerpc_ops::fetch_registers)
5421         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5422         (ppc_ravenscar_powerpc_ops): Redefine.
5423         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5424         (ppc_ravenscar_e500_ops::fetch_registers)
5425         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5426         (ppc_ravenscar_e500_ops): Redefine.
5427         * aarch64-ravenscar-thread.c
5428         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5429         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5430         (aarch64_ravenscar_fetch_registers)
5431         (aarch64_ravenscar_store_registers): Now methods.
5432         (aarch64_ravenscar_ops): Redefine.
5433
5434 2019-02-15  Tom Tromey  <tromey@adacore.com>
5435
5436         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5437         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5438         (ravenscar_thread_target::stopped_by_watchpoint)
5439         (ravenscar_thread_target::stopped_data_address)
5440         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5441
5442 2019-02-15  Tom Tromey  <tromey@adacore.com>
5443
5444         * ravenscar-thread.c: Fix some typos.
5445
5446 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5447             Tom Tromey  <tromey@adacore.com>
5448
5449         * ada-lang.c (ada_exception_sal): Change addr_string to a
5450         std::string.
5451         (create_ada_exception_catchpoint): Update.
5452
5453 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5454             Tom Tromey  <tromey@adacore.com>
5455
5456         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5457         (bp_location_ops): Remove.
5458         (base_breakpoint_allocate_location): Update.
5459         (free_bp_location): Update.
5460         * ada-lang.c (class ada_catchpoint_location)
5461         <ada_catchpoint_location>: Remove ops parameter.
5462         (ada_catchpoint_location_dtor): Remove.
5463         (ada_catchpoint_location_ops): Remove.
5464         (allocate_location_exception): Update.
5465         * breakpoint.h (struct bp_location_ops): Remove.
5466         (class bp_location) <bp_location>: Remove bp_location_ops
5467         parameter.
5468         <~bp_location>: Add destructor.
5469         <ops>: Remove.
5470
5471 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5472             Pedro Alves  <palves@redhat.com>
5473
5474         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5475         'PATH_MAX'.
5476
5477 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5478             Samuel Thibault  <samuel.thibault@gnu.org>
5479             Thomas Schwinge  <thomas@codesourcery.com>
5480
5481         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5482         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5483
5484 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5485
5486         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5487         (check_empty): Use "const char *".
5488
5489         * gnu-nat.c (gnu_nat_target::detach): Instead of
5490         'detach_inferior (pid)' call
5491         'detach_inferior (find_inferior_pid (pid))'.
5492
5493         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5494         'nat/fork-inferior.o'.
5495         * gnu-nat.c: #include "nat/fork-inferior.h".
5496
5497         * gnu-nat.c (gnu_nat_target::detach): Instead of
5498         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5499         * gnu-nat.h: #include "inf-child.h".
5500         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5501         'i386_gnu_nat_target::fetch_registers'.
5502         (gnu_store_registers): Rename/move to
5503         'i386_gnu_nat_target::store_registers'.
5504
5505         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5506         * gnu-nat.h (mach_thread_info): New function.
5507         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5508
5509         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5510
5511 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5512
5513         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5514
5515 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5516
5517         * windows-nat.c (windows_add_thread): Add new parameter
5518         "main_thread_p" with default value set to false.  Update
5519         function documentation as well as all callers.
5520         (windows_delete_thread): Likewise.
5521         (fake_create_process): Update call to windows_add_thread.
5522         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5523         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5524         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5525         call to windows_delete_thread.
5526
5527 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5528
5529         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5530
5531 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5532
5533         * symfile.c (find_separate_debug_file): Use canonical path of
5534         sysroot with child_path instead of gdb_sysroot if it is valid.
5535
5536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5537
5538         * symfile.c (find_separate_debug_file): Use child_path to
5539         determine if an object file is under a sysroot.
5540
5541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5542
5543         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5544         unittests/child-path-selftests.c.
5545         * common/pathstuff.c (child_path): New function.
5546         * common/pathstuff.h (child_path): New prototype.
5547         * unittests/child-path-selftests.c: New file.
5548
5549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5550
5551         * symfile.c (find_separate_debug_file): Look for separate debug
5552         files in debug directories under the sysroot.
5553
5554 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5555
5556         * symtab.h (struct minimal_symbol data_p): New const method.
5557         (struct minimal_symbol text_p): Likewise.
5558         * symtab.c (output_source_filename): Use file name style
5559         to print file name.
5560         (print_symbol_info): Likewise.
5561         (print_msymbol_info): Use address style to print addresses.
5562         Use function name style to print executable text symbols.
5563         (expand_symtab_containing_pc): Use data_p.
5564         (find_pc_sect_compunit_symtab): Likewise.
5565
5566 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5567
5568         * breakpoint.c (describe_other_breakpoints): Use address style
5569         to print addresses.
5570         (say_where): Likewise.
5571
5572 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5573
5574         * ada-typeprint.c (print_func_type): Print function name
5575         style to print function name.
5576         * c-typeprint.c (c_print_type_1): Likewise.
5577
5578 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5579
5580         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5581         for execve.
5582
5583 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5584
5585         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5586         type_stack.
5587
5588 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5589
5590         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5591         TYPE_CODE_REF types.
5592
5593 2019-02-08  Jim Wilson  <jimw@sifive.com>
5594
5595         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5596         (riscv_linux_fregset): New.
5597         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5598
5599 2019-02-07  Tom Tromey  <tom@tromey.com>
5600
5601         * thread.c (thread_cancel_execution_command): Update.
5602         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5603         methods.
5604         (struct thread_fsm_ops): Remove.
5605         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5606         (thread_fsm_should_stop, thread_fsm_return_value)
5607         (thread_fsm_set_finished, thread_fsm_finished_p)
5608         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5609         Don't declare.
5610         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5611         * infrun.c (clear_proceed_status_thread)
5612         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5613         (print_stop_event): Update.
5614         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5615         Add constructor.
5616         (step_command_fsm_ops): Remove.
5617         (new_step_command_fsm): Remove.
5618         (step_1): Update.
5619         (step_command_fsm::should_stop): Rename from
5620         step_command_fsm_should_stop.
5621         (step_command_fsm::clean_up): Rename from
5622         step_command_fsm_clean_up.
5623         (step_command_fsm::do_async_reply_reason): Rename from
5624         step_command_fsm_async_reply_reason.
5625         (struct until_next_fsm): Inherit from thread_fsm.  Add
5626         constructor.
5627         (until_next_fsm_ops): Remove.
5628         (new_until_next_fsm): Remove.
5629         (until_next_fsm::should_stop): Rename from
5630         until_next_fsm_should_stop.
5631         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5632         (until_next_fsm::do_async_reply_reason): Rename from
5633         until_next_fsm_async_reply_reason.
5634         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5635         constructor.  Change type of breakpoint.
5636         (finish_command_fsm_ops): Remove.
5637         (new_finish_command_fsm): Remove.
5638         (finish_command_fsm::should_stop): Rename from
5639         finish_command_fsm_should_stop.
5640         (finish_command_fsm::clean_up): Rename from
5641         finish_command_fsm_clean_up.
5642         (finish_command_fsm::return_value): Rename from
5643         finish_command_fsm_return_value.
5644         (finish_command_fsm::do_async_reply_reason): Rename from
5645         finish_command_fsm_async_reply_reason.
5646         (finish_command): Update.
5647         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5648         Add constructor.
5649         (call_thread_fsm_ops): Remove.
5650         (call_thread_fsm::call_thread_fsm): Rename from
5651         new_call_thread_fsm.
5652         (call_thread_fsm::should_stop): Rename from
5653         call_thread_fsm_should_stop.
5654         (call_thread_fsm::should_notify_stop): Rename from
5655         call_thread_fsm_should_notify_stop.
5656         (run_inferior_call, call_function_by_hand_dummy): Update.
5657         * cli/cli-interp.c (should_print_stop_to_console): Update.
5658         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5659         Add constructor.  Change type of location_breakpoint,
5660         caller_breakpoint.
5661         (until_break_fsm_ops): Remove.
5662         (new_until_break_fsm): Remove.
5663         (until_break_fsm::should_stop): Rename from
5664         until_break_fsm_should_stop.
5665         (until_break_fsm::clean_up): Rename from
5666         until_break_fsm_clean_up.
5667         (until_break_fsm::do_async_reply_reason): Rename from
5668         until_break_fsm_async_reply_reason.
5669         (until_break_command): Update.
5670         * thread-fsm.c: Remove.
5671         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5672
5673 2019-02-07  Tom Tromey  <tom@tromey.com>
5674
5675         * yy-remap.h: Add include guard.
5676         * xtensa-tdep.h: Add include guard.
5677         * xcoffread.h: Rename include guard.
5678         * varobj-iter.h: Add include guard.
5679         * tui/tui.h: Rename include guard.
5680         * tui/tui-winsource.h: Rename include guard.
5681         * tui/tui-wingeneral.h: Rename include guard.
5682         * tui/tui-windata.h: Rename include guard.
5683         * tui/tui-win.h: Rename include guard.
5684         * tui/tui-stack.h: Rename include guard.
5685         * tui/tui-source.h: Rename include guard.
5686         * tui/tui-regs.h: Rename include guard.
5687         * tui/tui-out.h: Rename include guard.
5688         * tui/tui-layout.h: Rename include guard.
5689         * tui/tui-io.h: Rename include guard.
5690         * tui/tui-hooks.h: Rename include guard.
5691         * tui/tui-file.h: Rename include guard.
5692         * tui/tui-disasm.h: Rename include guard.
5693         * tui/tui-data.h: Rename include guard.
5694         * tui/tui-command.h: Rename include guard.
5695         * tic6x-tdep.h: Add include guard.
5696         * target/waitstatus.h: Rename include guard.
5697         * target/wait.h: Rename include guard.
5698         * target/target.h: Rename include guard.
5699         * target/resume.h: Rename include guard.
5700         * target-float.h: Rename include guard.
5701         * stabsread.h: Add include guard.
5702         * rs6000-tdep.h: Add include guard.
5703         * riscv-fbsd-tdep.h: Add include guard.
5704         * regformats/regdef.h: Rename include guard.
5705         * record.h: Rename include guard.
5706         * python/python.h: Rename include guard.
5707         * python/python-internal.h: Rename include guard.
5708         * python/py-stopevent.h: Rename include guard.
5709         * python/py-ref.h: Rename include guard.
5710         * python/py-record.h: Rename include guard.
5711         * python/py-record-full.h: Rename include guard.
5712         * python/py-record-btrace.h: Rename include guard.
5713         * python/py-instruction.h: Rename include guard.
5714         * python/py-events.h: Rename include guard.
5715         * python/py-event.h: Rename include guard.
5716         * procfs.h: Add include guard.
5717         * proc-utils.h: Add include guard.
5718         * p-lang.h: Add include guard.
5719         * or1k-tdep.h: Rename include guard.
5720         * observable.h: Rename include guard.
5721         * nto-tdep.h: Rename include guard.
5722         * nat/x86-linux.h: Rename include guard.
5723         * nat/x86-linux-dregs.h: Rename include guard.
5724         * nat/x86-gcc-cpuid.h: Add include guard.
5725         * nat/x86-dregs.h: Rename include guard.
5726         * nat/x86-cpuid.h: Rename include guard.
5727         * nat/ppc-linux.h: Rename include guard.
5728         * nat/mips-linux-watch.h: Rename include guard.
5729         * nat/linux-waitpid.h: Rename include guard.
5730         * nat/linux-ptrace.h: Rename include guard.
5731         * nat/linux-procfs.h: Rename include guard.
5732         * nat/linux-osdata.h: Rename include guard.
5733         * nat/linux-nat.h: Rename include guard.
5734         * nat/linux-namespaces.h: Rename include guard.
5735         * nat/linux-btrace.h: Rename include guard.
5736         * nat/glibc_thread_db.h: Rename include guard.
5737         * nat/gdb_thread_db.h: Rename include guard.
5738         * nat/gdb_ptrace.h: Rename include guard.
5739         * nat/fork-inferior.h: Rename include guard.
5740         * nat/amd64-linux-siginfo.h: Rename include guard.
5741         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5742         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5743         * nat/aarch64-linux.h: Rename include guard.
5744         * nat/aarch64-linux-hw-point.h: Rename include guard.
5745         * mn10300-tdep.h: Add include guard.
5746         * mips-linux-tdep.h: Add include guard.
5747         * mi/mi-parse.h: Rename include guard.
5748         * mi/mi-out.h: Rename include guard.
5749         * mi/mi-main.h: Rename include guard.
5750         * mi/mi-interp.h: Rename include guard.
5751         * mi/mi-getopt.h: Rename include guard.
5752         * mi/mi-console.h: Rename include guard.
5753         * mi/mi-common.h: Rename include guard.
5754         * mi/mi-cmds.h: Rename include guard.
5755         * mi/mi-cmd-break.h: Rename include guard.
5756         * m2-lang.h: Add include guard.
5757         * location.h: Rename include guard.
5758         * linux-record.h: Rename include guard.
5759         * linux-nat.h: Add include guard.
5760         * linux-fork.h: Add include guard.
5761         * i386-darwin-tdep.h: Rename include guard.
5762         * hppa-linux-offsets.h: Add include guard.
5763         * guile/guile.h: Rename include guard.
5764         * guile/guile-internal.h: Rename include guard.
5765         * gnu-nat.h: Rename include guard.
5766         * gdb-stabs.h: Rename include guard.
5767         * frv-tdep.h: Add include guard.
5768         * f-lang.h: Add include guard.
5769         * event-loop.h: Add include guard.
5770         * darwin-nat.h: Rename include guard.
5771         * cp-abi.h: Rename include guard.
5772         * config/sparc/nm-sol2.h: Rename include guard.
5773         * config/nm-nto.h: Rename include guard.
5774         * config/nm-linux.h: Add include guard.
5775         * config/i386/nm-i386gnu.h: Rename include guard.
5776         * config/djgpp/nl_types.h: Rename include guard.
5777         * config/djgpp/langinfo.h: Rename include guard.
5778         * compile/gcc-cp-plugin.h: Add include guard.
5779         * compile/gcc-c-plugin.h: Add include guard.
5780         * compile/compile.h: Rename include guard.
5781         * compile/compile-object-run.h: Rename include guard.
5782         * compile/compile-object-load.h: Rename include guard.
5783         * compile/compile-internal.h: Rename include guard.
5784         * compile/compile-cplus.h: Rename include guard.
5785         * compile/compile-c.h: Rename include guard.
5786         * common/xml-utils.h: Rename include guard.
5787         * common/x86-xstate.h: Rename include guard.
5788         * common/version.h: Rename include guard.
5789         * common/vec.h: Rename include guard.
5790         * common/tdesc.h: Rename include guard.
5791         * common/selftest.h: Rename include guard.
5792         * common/scoped_restore.h: Rename include guard.
5793         * common/scoped_mmap.h: Rename include guard.
5794         * common/scoped_fd.h: Rename include guard.
5795         * common/safe-iterator.h: Rename include guard.
5796         * common/run-time-clock.h: Rename include guard.
5797         * common/refcounted-object.h: Rename include guard.
5798         * common/queue.h: Rename include guard.
5799         * common/ptid.h: Rename include guard.
5800         * common/print-utils.h: Rename include guard.
5801         * common/preprocessor.h: Rename include guard.
5802         * common/pathstuff.h: Rename include guard.
5803         * common/observable.h: Rename include guard.
5804         * common/netstuff.h: Rename include guard.
5805         * common/job-control.h: Rename include guard.
5806         * common/host-defs.h: Rename include guard.
5807         * common/gdb_wait.h: Rename include guard.
5808         * common/gdb_vecs.h: Rename include guard.
5809         * common/gdb_unlinker.h: Rename include guard.
5810         * common/gdb_unique_ptr.h: Rename include guard.
5811         * common/gdb_tilde_expand.h: Rename include guard.
5812         * common/gdb_sys_time.h: Rename include guard.
5813         * common/gdb_string_view.h: Rename include guard.
5814         * common/gdb_splay_tree.h: Rename include guard.
5815         * common/gdb_setjmp.h: Rename include guard.
5816         * common/gdb_ref_ptr.h: Rename include guard.
5817         * common/gdb_optional.h: Rename include guard.
5818         * common/gdb_locale.h: Rename include guard.
5819         * common/gdb_assert.h: Rename include guard.
5820         * common/filtered-iterator.h: Rename include guard.
5821         * common/filestuff.h: Rename include guard.
5822         * common/fileio.h: Rename include guard.
5823         * common/environ.h: Rename include guard.
5824         * common/common-utils.h: Rename include guard.
5825         * common/common-types.h: Rename include guard.
5826         * common/common-regcache.h: Rename include guard.
5827         * common/common-inferior.h: Rename include guard.
5828         * common/common-gdbthread.h: Rename include guard.
5829         * common/common-exceptions.h: Rename include guard.
5830         * common/common-defs.h: Rename include guard.
5831         * common/common-debug.h: Rename include guard.
5832         * common/cleanups.h: Rename include guard.
5833         * common/buffer.h: Rename include guard.
5834         * common/btrace-common.h: Rename include guard.
5835         * common/break-common.h: Rename include guard.
5836         * cli/cli-utils.h: Rename include guard.
5837         * cli/cli-style.h: Rename include guard.
5838         * cli/cli-setshow.h: Rename include guard.
5839         * cli/cli-script.h: Rename include guard.
5840         * cli/cli-interp.h: Rename include guard.
5841         * cli/cli-decode.h: Rename include guard.
5842         * cli/cli-cmds.h: Rename include guard.
5843         * charset-list.h: Add include guard.
5844         * buildsym-legacy.h: Rename include guard.
5845         * bfin-tdep.h: Add include guard.
5846         * ax.h: Rename include guard.
5847         * arm-linux-tdep.h: Add include guard.
5848         * arm-fbsd-tdep.h: Add include guard.
5849         * arch/xtensa.h: Rename include guard.
5850         * arch/tic6x.h: Add include guard.
5851         * arch/i386.h: Add include guard.
5852         * arch/arm.h: Rename include guard.
5853         * arch/arm-linux.h: Rename include guard.
5854         * arch/arm-get-next-pcs.h: Rename include guard.
5855         * arch/amd64.h: Add include guard.
5856         * arch/aarch64-insn.h: Rename include guard.
5857         * arch-utils.h: Rename include guard.
5858         * annotate.h: Add include guard.
5859         * amd64-darwin-tdep.h: Rename include guard.
5860         * aarch64-linux-tdep.h: Add include guard.
5861         * aarch64-fbsd-tdep.h: Add include guard.
5862         * aarch32-linux-nat.h: Add include guard.
5863
5864 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5865
5866         * macrotab.c (macro_define_internal): New function that
5867         factorizes macro_define_object_internal and macro_define_function
5868         code.
5869         (macro_define_object_internal): Use macro_define_internal.
5870         (macro_define_function): Likewise.
5871
5872 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5873
5874         * macrocmd.c (extract_identifier): Return
5875         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5876         callers.
5877
5878 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5879
5880         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5881
5882 2019-02-05  Tom Tromey  <tom@tromey.com>
5883
5884         * target.c (target_stack::unpush): Move assertion earlier.
5885
5886 2019-01-30  Tom Tromey  <tom@tromey.com>
5887
5888         PR python/23615:
5889         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5890         (gdbpy_parse_and_eval): Likewise.
5891         * python/python-internal.h (gdbpy_allow_threads): New class.
5892
5893 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5894
5895         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5896         (aarch64_fbsd_fpregmap): Move earlier.
5897         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5898         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5899         instead of individual calls to trad_frame_set_reg_addr.
5900         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5901         earlier.
5902         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5903         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5904         instead of individual calls to trad_frame_set_reg_addr.
5905
5906 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5907
5908         * CONTRIBUTE: Replace contribution list with wiki link.
5909
5910 2019-01-25  Tom Tromey  <tom@tromey.com>
5911
5912         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5913
5914 2019-01-25  Tom Tromey  <tom@tromey.com>
5915
5916         * xtensa-linux-nat.c: Fix common/ includes.
5917         * xml-support.h: Fix common/ includes.
5918         * xml-support.c: Fix common/ includes.
5919         * x86-linux-nat.c: Fix common/ includes.
5920         * windows-nat.c: Fix common/ includes.
5921         * varobj.h: Fix common/ includes.
5922         * varobj.c: Fix common/ includes.
5923         * value.c: Fix common/ includes.
5924         * valops.c: Fix common/ includes.
5925         * utils.c: Fix common/ includes.
5926         * unittests/xml-utils-selftests.c: Fix common/ includes.
5927         * unittests/utils-selftests.c: Fix common/ includes.
5928         * unittests/unpack-selftests.c: Fix common/ includes.
5929         * unittests/tracepoint-selftests.c: Fix common/ includes.
5930         * unittests/style-selftests.c: Fix common/ includes.
5931         * unittests/string_view-selftests.c: Fix common/ includes.
5932         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5933         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5934         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5935         * unittests/rsp-low-selftests.c: Fix common/ includes.
5936         * unittests/parse-connection-spec-selftests.c: Fix common/
5937         includes.
5938         * unittests/optional-selftests.c: Fix common/ includes.
5939         * unittests/offset-type-selftests.c: Fix common/ includes.
5940         * unittests/observable-selftests.c: Fix common/ includes.
5941         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5942         * unittests/memrange-selftests.c: Fix common/ includes.
5943         * unittests/memory-map-selftests.c: Fix common/ includes.
5944         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5945         * unittests/function-view-selftests.c: Fix common/ includes.
5946         * unittests/environ-selftests.c: Fix common/ includes.
5947         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5948         * unittests/common-utils-selftests.c: Fix common/ includes.
5949         * unittests/cli-utils-selftests.c: Fix common/ includes.
5950         * unittests/array-view-selftests.c: Fix common/ includes.
5951         * ui-file.c: Fix common/ includes.
5952         * tui/tui-io.c: Fix common/ includes.
5953         * tracepoint.h: Fix common/ includes.
5954         * tracepoint.c: Fix common/ includes.
5955         * tracefile-tfile.c: Fix common/ includes.
5956         * top.h: Fix common/ includes.
5957         * top.c: Fix common/ includes.
5958         * thread.c: Fix common/ includes.
5959         * target/waitstatus.h: Fix common/ includes.
5960         * target/waitstatus.c: Fix common/ includes.
5961         * target.h: Fix common/ includes.
5962         * target.c: Fix common/ includes.
5963         * target-memory.c: Fix common/ includes.
5964         * target-descriptions.c: Fix common/ includes.
5965         * symtab.h: Fix common/ includes.
5966         * symfile.c: Fix common/ includes.
5967         * stap-probe.c: Fix common/ includes.
5968         * spu-linux-nat.c: Fix common/ includes.
5969         * sparc-nat.c: Fix common/ includes.
5970         * source.c: Fix common/ includes.
5971         * solib.c: Fix common/ includes.
5972         * solib-target.c: Fix common/ includes.
5973         * ser-unix.c: Fix common/ includes.
5974         * ser-tcp.c: Fix common/ includes.
5975         * ser-pipe.c: Fix common/ includes.
5976         * ser-base.c: Fix common/ includes.
5977         * selftest-arch.c: Fix common/ includes.
5978         * s12z-tdep.c: Fix common/ includes.
5979         * rust-exp.y: Fix common/ includes.
5980         * rs6000-aix-tdep.c: Fix common/ includes.
5981         * riscv-tdep.c: Fix common/ includes.
5982         * remote.c: Fix common/ includes.
5983         * remote-notif.h: Fix common/ includes.
5984         * remote-fileio.h: Fix common/ includes.
5985         * remote-fileio.c: Fix common/ includes.
5986         * regcache.h: Fix common/ includes.
5987         * regcache.c: Fix common/ includes.
5988         * record-btrace.c: Fix common/ includes.
5989         * python/python.c: Fix common/ includes.
5990         * python/py-type.c: Fix common/ includes.
5991         * python/py-inferior.c: Fix common/ includes.
5992         * progspace.h: Fix common/ includes.
5993         * producer.c: Fix common/ includes.
5994         * procfs.c: Fix common/ includes.
5995         * proc-api.c: Fix common/ includes.
5996         * printcmd.c: Fix common/ includes.
5997         * ppc-linux-nat.c: Fix common/ includes.
5998         * parser-defs.h: Fix common/ includes.
5999         * osdata.c: Fix common/ includes.
6000         * obsd-nat.c: Fix common/ includes.
6001         * nat/x86-linux.c: Fix common/ includes.
6002         * nat/x86-linux-dregs.c: Fix common/ includes.
6003         * nat/x86-dregs.h: Fix common/ includes.
6004         * nat/x86-dregs.c: Fix common/ includes.
6005         * nat/ppc-linux.c: Fix common/ includes.
6006         * nat/mips-linux-watch.h: Fix common/ includes.
6007         * nat/mips-linux-watch.c: Fix common/ includes.
6008         * nat/linux-waitpid.c: Fix common/ includes.
6009         * nat/linux-ptrace.h: Fix common/ includes.
6010         * nat/linux-ptrace.c: Fix common/ includes.
6011         * nat/linux-procfs.c: Fix common/ includes.
6012         * nat/linux-personality.c: Fix common/ includes.
6013         * nat/linux-osdata.c: Fix common/ includes.
6014         * nat/linux-namespaces.c: Fix common/ includes.
6015         * nat/linux-btrace.h: Fix common/ includes.
6016         * nat/linux-btrace.c: Fix common/ includes.
6017         * nat/fork-inferior.c: Fix common/ includes.
6018         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6019         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6020         * nat/aarch64-linux.c: Fix common/ includes.
6021         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6022         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6023         * namespace.h: Fix common/ includes.
6024         * mips-linux-tdep.c: Fix common/ includes.
6025         * minsyms.c: Fix common/ includes.
6026         * mi/mi-parse.h: Fix common/ includes.
6027         * mi/mi-main.c: Fix common/ includes.
6028         * mi/mi-cmd-env.c: Fix common/ includes.
6029         * memrange.h: Fix common/ includes.
6030         * memattr.c: Fix common/ includes.
6031         * maint.h: Fix common/ includes.
6032         * maint.c: Fix common/ includes.
6033         * main.c: Fix common/ includes.
6034         * machoread.c: Fix common/ includes.
6035         * location.c: Fix common/ includes.
6036         * linux-thread-db.c: Fix common/ includes.
6037         * linux-nat.c: Fix common/ includes.
6038         * linux-fork.c: Fix common/ includes.
6039         * inline-frame.c: Fix common/ includes.
6040         * infrun.c: Fix common/ includes.
6041         * inflow.c: Fix common/ includes.
6042         * inferior.h: Fix common/ includes.
6043         * inferior.c: Fix common/ includes.
6044         * infcmd.c: Fix common/ includes.
6045         * inf-ptrace.c: Fix common/ includes.
6046         * inf-child.c: Fix common/ includes.
6047         * ia64-linux-nat.c: Fix common/ includes.
6048         * i387-tdep.c: Fix common/ includes.
6049         * i386-tdep.c: Fix common/ includes.
6050         * i386-linux-tdep.c: Fix common/ includes.
6051         * i386-linux-nat.c: Fix common/ includes.
6052         * i386-go32-tdep.c: Fix common/ includes.
6053         * i386-fbsd-tdep.c: Fix common/ includes.
6054         * i386-fbsd-nat.c: Fix common/ includes.
6055         * guile/scm-type.c: Fix common/ includes.
6056         * guile/guile.c: Fix common/ includes.
6057         * go32-nat.c: Fix common/ includes.
6058         * gnu-nat.c: Fix common/ includes.
6059         * gdbthread.h: Fix common/ includes.
6060         * gdbarch-selftests.c: Fix common/ includes.
6061         * gdb_usleep.c: Fix common/ includes.
6062         * gdb_select.h: Fix common/ includes.
6063         * gdb_bfd.c: Fix common/ includes.
6064         * gcore.c: Fix common/ includes.
6065         * fork-child.c: Fix common/ includes.
6066         * findvar.c: Fix common/ includes.
6067         * fbsd-nat.c: Fix common/ includes.
6068         * event-top.c: Fix common/ includes.
6069         * event-loop.c: Fix common/ includes.
6070         * dwarf2read.c: Fix common/ includes.
6071         * dwarf2loc.c: Fix common/ includes.
6072         * dwarf2-frame.c: Fix common/ includes.
6073         * dwarf-index-cache.c: Fix common/ includes.
6074         * dtrace-probe.c: Fix common/ includes.
6075         * disasm-selftests.c: Fix common/ includes.
6076         * defs.h: Fix common/ includes.
6077         * csky-tdep.c: Fix common/ includes.
6078         * cp-valprint.c: Fix common/ includes.
6079         * cp-support.h: Fix common/ includes.
6080         * cp-support.c: Fix common/ includes.
6081         * corelow.c: Fix common/ includes.
6082         * completer.h: Fix common/ includes.
6083         * completer.c: Fix common/ includes.
6084         * compile/compile.c: Fix common/ includes.
6085         * compile/compile-loc2c.c: Fix common/ includes.
6086         * compile/compile-cplus-types.c: Fix common/ includes.
6087         * compile/compile-cplus-symbols.c: Fix common/ includes.
6088         * command.h: Fix common/ includes.
6089         * cli/cli-dump.c: Fix common/ includes.
6090         * cli/cli-cmds.c: Fix common/ includes.
6091         * charset.c: Fix common/ includes.
6092         * build-id.c: Fix common/ includes.
6093         * btrace.h: Fix common/ includes.
6094         * btrace.c: Fix common/ includes.
6095         * breakpoint.h: Fix common/ includes.
6096         * breakpoint.c: Fix common/ includes.
6097         * ax.h:
6098         (enum agent_op): Fix common/ includes.
6099         * ax-general.c (struct aop_map): Fix common/ includes.
6100         * ax-gdb.c: Fix common/ includes.
6101         * auxv.c: Fix common/ includes.
6102         * auto-load.c: Fix common/ includes.
6103         * arm-tdep.c: Fix common/ includes.
6104         * arch/riscv.c: Fix common/ includes.
6105         * arch/ppc-linux-common.c: Fix common/ includes.
6106         * arch/i386.c: Fix common/ includes.
6107         * arch/arm.c: Fix common/ includes.
6108         * arch/arm-linux.c: Fix common/ includes.
6109         * arch/arm-get-next-pcs.c: Fix common/ includes.
6110         * arch/amd64.c: Fix common/ includes.
6111         * arch/aarch64.c: Fix common/ includes.
6112         * arch/aarch64-insn.c: Fix common/ includes.
6113         * arch-utils.c: Fix common/ includes.
6114         * amd64-windows-tdep.c: Fix common/ includes.
6115         * amd64-tdep.c: Fix common/ includes.
6116         * amd64-sol2-tdep.c: Fix common/ includes.
6117         * amd64-obsd-tdep.c: Fix common/ includes.
6118         * amd64-nbsd-tdep.c: Fix common/ includes.
6119         * amd64-linux-tdep.c: Fix common/ includes.
6120         * amd64-linux-nat.c: Fix common/ includes.
6121         * amd64-fbsd-tdep.c: Fix common/ includes.
6122         * amd64-fbsd-nat.c: Fix common/ includes.
6123         * amd64-dicos-tdep.c: Fix common/ includes.
6124         * amd64-darwin-tdep.c: Fix common/ includes.
6125         * agent.c: Fix common/ includes.
6126         * ada-lang.h: Fix common/ includes.
6127         * ada-lang.c: Fix common/ includes.
6128         * aarch64-tdep.c: Fix common/ includes.
6129
6130 2019-01-25  Tom Tromey  <tom@tromey.com>
6131
6132         * common/create-version.sh: Use common/version.h.
6133
6134 2019-01-24  Pedro Alves  <palves@redhat.com>
6135
6136         * infrun.c (signal_stop, signal_print, signal_program)
6137         (signal_catch, signal_pass): Now arrays instead of pointers.
6138         (update_signals_program_target, do_target_resume)
6139         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6140         * linux-nat.c (linux_nat_target::pass_signals)
6141         (linux_nat_target::create_inferior, linux_nat_target::attach):
6142         Adjust.
6143         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6144         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6145         * procfs.c (procfs_target::pass_signals): Adjust.
6146         * record-full.c (record_full_target::resume): Adjust.
6147         * remote.c (remote_target::pass_signals)
6148         (remote_target::program_signals): Adjust.
6149         * target-debug.h (target_debug_print_signals): Now takes a
6150         gdb::array_view as parameter.  Adjust.
6151         * target.h (target_ops) <pass_signals, program_signals>: Replace
6152         pointer and length parameters with gdb::array_view.
6153         (target_pass_signals, target_program_signals): Likewise.
6154         * target-delegates.c: Regenerate.
6155
6156 2019-01-24  Pedro Alves  <palves@redhat.com>
6157
6158         * common/forward-scope-exit.h
6159         (forward_scope_exit::forward_scope_exit): Pass arguments to
6160         m_bind_function directly, instead of creating a std::bind and
6161         copying that.
6162
6163 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6164
6165         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6166         for static members.
6167         (pass_in_v_vfp_candidate): Likewise.
6168
6169 2019-01-23  Tom Tromey  <tom@tromey.com>
6170             Pedro Alves  <palves@redhat.com>
6171
6172         * regcache.c (class regcache_invalidator): Remove.
6173         (regcache::raw_write): Use make_scope_exit.
6174
6175 2019-01-23  Tom Tromey  <tom@tromey.com>
6176
6177         * ui-out.h (class ui_out_emit_type): Update comment.
6178
6179 2019-01-23  Tom Tromey  <tom@tromey.com>
6180
6181         * infrun.c (fetch_inferior_event): Update comment.
6182
6183 2019-01-23  Tom Tromey  <tom@tromey.com>
6184             Pedro Alves  <palves@redhat.com>
6185
6186         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6187         parameter.
6188         (fetch_inferior_event): Use SCOPE_EXIT.
6189
6190
6191 2019-01-23  Tom Tromey  <tom@tromey.com>
6192             Pedro Alves  <palves@redhat.com>
6193
6194         * infrun.c (disable_thread_events): Delete.
6195         (stop_all_threads): Use SCOPE_EXIT.
6196
6197 2019-01-23  Tom Tromey  <tom@tromey.com>
6198             Pedro Alves  <palves@redhat.com>
6199
6200         * symfile.c: Include forward-scope-exit.h.
6201         (clear_symtab_users_cleanup): Replace forward declaration with
6202         a FORWARD_SCOPE_EXIT.
6203         (syms_from_objfile_1): Use the forward_scope_exit and
6204         gdb::optional instead of cleanup_function.
6205         (reread_symbols): Use the forward_scope_exit instead of
6206         cleanup_function.
6207         (clear_symtab_users_cleanup): Remove function.
6208
6209 2019-01-23  Tom Tromey  <tom@tromey.com>
6210             Pedro Alves  <palves@redhat.com>
6211
6212         * linux-nat.c: Include scope-exit.h.
6213         (cleanup_target_stop): Remove.
6214         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6215         SCOPE_EXIT.
6216
6217 2019-01-23  Tom Tromey  <tom@tromey.com>
6218             Pedro Alves  <palves@redhat.com>
6219
6220         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6221         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6222
6223 2019-01-23  Tom Tromey  <tom@tromey.com>
6224             Andrew Burgess  <andrew.burgess@embecosm.com>
6225             Pedro Alves  <palves@redhat.com>
6226
6227         * infrun.c (fetch_inferior_event): Use scope_exit.
6228         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6229         * top.c (execute_command): Use scope_exit.
6230         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6231         * utils.c (do_bpstat_clear_actions_cleanup)
6232         (make_bpstat_clear_actions_cleanup): Remove.
6233
6234 2019-01-23  Tom Tromey  <tom@tromey.com>
6235             Pedro Alves  <palves@redhat.com>
6236
6237         * infrun.c: Include "common/scope-exit.h"
6238         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6239         (wait_for_inferior): Use SCOPE_EXIT.
6240         (fetch_inferior_event): Use scope_exit.
6241
6242 2019-01-23  Tom Tromey  <tom@tromey.com>
6243             Pedro Alves  <palves@redhat.com>
6244
6245         * breakpoint.c (create_breakpoint): Remove cleanup.
6246
6247 2019-01-23  Tom Tromey  <tom@tromey.com>
6248             Andrew Burgess  <andrew.burgess@embecosm.com>
6249             Pedro Alves  <palves@redhat.com>
6250
6251 2019-01-23  Pedro Alves  <palves@redhat.com>
6252
6253         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6254
6255 2019-01-23  Pedro Alves  <palves@redhat.com>
6256             Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * gdbthread.h: Include "common/forward-scope-exit.h".
6259         (scoped_finish_thread_state): Redefine custom class in terms of
6260         forward_scope_exit.
6261
6262 2019-01-23  Pedro Alves  <palves@redhat.com>
6263             Andrew Burgess  <andrew.burgess@embecosm.com>
6264
6265         * common/forward-scope-exit.h: New file.
6266
6267 2019-01-23  Pedro Alves  <palves@redhat.com>
6268             Andrew Burgess  <andrew.burgess@embecosm.com>
6269             Tom Tromey  <tom@tromey.com>
6270
6271         * common/scope-exit.h: New file.
6272
6273 2019-01-23  Pedro Alves  <palves@redhat.com>
6274
6275         * common/preprocessor.h (ESC): Rename to ...
6276         (ESC_PARENS): ... this.
6277         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6278         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6279
6280 2019-01-23  Tom Tromey  <tom@tromey.com>
6281
6282         * language.h (class scoped_switch_to_sym_language_if_auto):
6283         Initialize m_lang in both cases.
6284
6285 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6286
6287         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6288         with XCNEW.
6289
6290 2019-01-22  Tom Tromey  <tom@tromey.com>
6291
6292         * corelow.c: Do not include sys/file.h.
6293
6294 2019-01-22  Tom Tromey  <tom@tromey.com>
6295
6296         * tui/tui-wingeneral.h: Include gdb_curses.h.
6297
6298 2019-01-22  Tom Tromey  <tom@tromey.com>
6299
6300         * source-cache.h (class source_cache) <get_source_lines,
6301         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6302
6303 2019-01-22  Tom Tromey  <tom@tromey.com>
6304
6305         * remote-fileio.h (struct remote_target): Declare.
6306
6307 2019-01-22  Tom Tromey  <tom@tromey.com>
6308
6309         * python/py-arch.c: Do not include py-ref.h.
6310         * python/py-bpevent.c: Do not include py-ref.h.
6311         * python/py-cmd.c: Do not include py-ref.h.
6312         * python/py-continueevent.c: Do not include py-ref.h.
6313         * python/py-event.h: Do not include py-ref.h.
6314         * python/py-evtregistry.c: Do not include py-ref.h.
6315         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6316         * python/py-frame.c: Do not include py-ref.h.
6317         * python/py-framefilter.c: Do not include py-ref.h.
6318         * python/py-function.c: Do not include py-ref.h.
6319         * python/py-infevents.c: Do not include py-ref.h.
6320         * python/py-linetable.c: Do not include py-ref.h.
6321         * python/py-objfile.c: Do not include py-ref.h.
6322         * python/py-param.c: Do not include py-ref.h.
6323         * python/py-prettyprint.c: Do not include py-ref.h.
6324         * python/py-progspace.c: Do not include py-ref.h.
6325         * python/py-symbol.c: Do not include py-ref.h.
6326         * python/py-symtab.c: Do not include py-ref.h.
6327         * python/py-type.c: Do not include py-ref.h.
6328         * python/py-unwind.c: Do not include py-ref.h.
6329         * python/py-utils.c: Do not include py-ref.h.
6330         * python/py-value.c: Do not include py-ref.h.
6331         * python/py-varobj.c: Do not include py-ref.h.
6332         * python/py-xmethods.c: Do not include py-ref.h.
6333         * python/python.c: Do not include py-ref.h.
6334         * varobj.c: Do not include py-ref.h.
6335
6336 2019-01-22  Tom Tromey  <tom@tromey.com>
6337
6338         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6339         keyword for bcache.
6340
6341 2019-01-22  Tom Tromey  <tom@tromey.com>
6342
6343         * compile/compile-cplus-types.c: Remove a comment by #include.
6344
6345 2019-01-22  Tom Tromey  <tom@tromey.com>
6346
6347         * compile/gcc-c-plugin.h: Include compile-internal.h.
6348
6349 2019-01-22  Tom Tromey  <tom@tromey.com>
6350
6351         * stabsread.c (EXTERN): Do not define.
6352         (symnum, next_symbol_text_func, processing_gcc_compilation)
6353         (within_function, global_sym_chain, global_stabs)
6354         (previous_stab_code, this_object_header_files)
6355         (n_this_object_header_files)
6356         (n_allocated_this_object_header_files): Define.
6357         * stabsread.h (EXTERN): Never define.  Use "extern".
6358
6359 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6360
6361         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6362         history_value.
6363
6364 2019-01-21  Tom Tromey  <tom@tromey.com>
6365
6366         * ui-out.c: Fix includes.
6367         * tui/tui-source.c: Fix includes.
6368         * target.c: Fix includes.
6369         * remote.c: Fix includes.
6370         * regcache.c: Fix includes.
6371         * python/py-block.c: Fix includes.
6372         * printcmd.c: Fix includes.
6373         * or1k-tdep.c: Fix includes.
6374         * mi/mi-main.c: Fix includes.
6375         * m32r-tdep.c: Fix includes.
6376         * csky-tdep.c: Fix includes.
6377         * compile/compile-cplus-types.c: Fix includes.
6378         * cli/cli-interp.c: Fix includes.
6379
6380 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6381
6382         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6383         for padding.
6384
6385 2019-01-16  Tom Tromey  <tom@tromey.com>
6386
6387         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6388         earlier.
6389         (struct objfile) <msymbols_range>: Move from top level.
6390         <msymbols>: New method.
6391         (class objfile_msymbols): Remove.
6392         * symtab.c (default_collect_symbol_completion_matches_break_on):
6393         Update.
6394         * symmisc.c (dump_msymbols): Update.
6395         * stabsread.c (scan_file_globals): Update.
6396         * objc-lang.c (info_selectors_command, info_classes_command)
6397         (find_methods): Update.
6398         * minsyms.c (find_solib_trampoline_target): Update.
6399         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6400         * coffread.c (coff_symfile_read): Update.
6401         * ada-lang.c (ada_lookup_simple_minsym)
6402         (ada_collect_symbol_completion_matches): Update.
6403
6404 2019-01-16  Tom Tromey  <tom@tromey.com>
6405
6406         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6407         type.  Remove no-argument constructor.
6408         <iterator::operator++>: Simplify.
6409         <begin>: Update.
6410         <end>: Use minimal_symbol_count.
6411
6412 2019-01-16  Tom Tromey  <tom@tromey.com>
6413
6414         * objfiles.h (struct objfile) <psymtabs>: New method.
6415         (class objfile_psymtabs): Remove.
6416         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6417         typedef.
6418         <range>: New method.
6419         (require_partial_symbols): Change return type.
6420         * psymtab.c (require_partial_symbols)
6421         (psym_expand_symtabs_matching): Update.
6422         * mdebugread.c (parse_partial_symbols): Update.
6423         * dbxread.c (dbx_end_psymtab): Update.
6424
6425 2019-01-15  Tom Tromey  <tom@tromey.com>
6426
6427         * symtab.c (lookup_objfile_from_block)
6428         (lookup_symbol_in_objfile_symtabs)
6429         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6430         (find_line_symtab, info_sources_command)
6431         (default_collect_symbol_completion_matches_break_on)
6432         (make_source_files_completion_list): Update.
6433         * symmisc.c (print_objfile_statistics, dump_objfile)
6434         (maintenance_print_symbols, maintenance_info_symtabs)
6435         (maintenance_check_symtabs, maintenance_info_line_tables):
6436         Update.
6437         * source.c (select_source_symtab)
6438         (forget_cached_source_info_for_objfile): Update.
6439         * objfiles.h (class objfile_compunits): Remove.
6440         (struct objfile) <compunits_range>: New typedef.
6441         (compunits): New method.
6442         * objfiles.c (objfile_relocate1): Update.
6443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6444         * maint.c (count_symtabs_and_blocks): Update.
6445         * linespec.c (iterate_over_all_matching_symtabs): Update.
6446         * cp-support.c (add_symbol_overload_list_qualified): Update.
6447         * coffread.c (coff_symtab_read): Update.
6448         * ada-lang.c (add_nonlocal_symbols)
6449         (ada_collect_symbol_completion_matches)
6450         (ada_add_global_exceptions): Update.
6451
6452 2019-01-15  Tom Tromey  <tom@tromey.com>
6453
6454         * progspace.h (program_space) <objfiles_safe_range>: New
6455         typedef.
6456         <objfiles_safe>: New method.
6457         * objfiles.h (class all_objfiles_safe): Remove.
6458         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6459         * jit.c (jit_inferior_exit_hook): Update.
6460
6461 2019-01-17  Tom Tromey  <tom@tromey.com>
6462
6463         * progspace.h (program_space) <objfiles_range>: New typedef.
6464         <objfiles>: New method.
6465         <objfiles_head>: Rename from objfiles.
6466         (object_files): Update.
6467         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6468         * guile/scm-pretty-print.c
6469         (ppscm_find_pretty_printer_from_objfiles): Update.
6470         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6471         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6472         Update.
6473         * python/py-progspace.c (pspy_get_objfiles): Update.
6474         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6475         Update.
6476         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6477         (objfpy_lookup_objfile_by_build_id): Update.
6478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6479         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6480         Update.
6481         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6482         (expand_symtab_containing_pc, lookup_objfile_from_block)
6483         (lookup_static_symbol, basic_lookup_transparent_type)
6484         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6485         (find_line_symtab, info_sources_command)
6486         (default_collect_symbol_completion_matches_break_on)
6487         (make_source_files_completion_list, find_main_name): Update.
6488         * symmisc.c (print_symbol_bcache_statistics)
6489         (print_objfile_statistics, maintenance_print_symbols)
6490         (maintenance_print_msymbols, maintenance_print_objfiles)
6491         (maintenance_info_symtabs, maintenance_check_symtabs)
6492         (maintenance_expand_symtabs, maintenance_info_line_tables):
6493         Update.
6494         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6495         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6496         (map_overlay_command, unmap_overlay_command)
6497         (simple_overlay_update, expand_symtabs_matching)
6498         (map_symbol_filenames): Update.
6499         * symfile-debug.c (set_debug_symfile): Update.
6500         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6501         Update.
6502         * source.c (select_source_symtab, forget_cached_source_info):
6503         Update.
6504         * solib.c (solib_read_symbols): Update.
6505         * solib-spu.c (append_ocl_sos): Update.
6506         * psymtab.c (maintenance_print_psymbols)
6507         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6508         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6509         * printcmd.c (info_symbol_command): Update.
6510         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6511         Update.
6512         * objfiles.h (class all_objfiles): Remove.
6513         * objfiles.c (have_partial_symbols, have_full_symbols)
6514         (have_minimal_symbols, qsort_cmp, update_section_map)
6515         (shared_objfile_contains_address_p)
6516         (default_iterate_over_objfiles_in_search_order): Update.
6517         * objc-lang.c (info_selectors_command, info_classes_command)
6518         (find_methods): Update.
6519         * minsyms.c (find_solib_trampoline_target): Update.
6520         * maint.c (maintenance_info_sections)
6521         (maintenance_translate_address, count_symtabs_and_blocks):
6522         Update.
6523         * main.c (captured_main_1): Update.
6524         * linux-thread-db.c (try_thread_db_load_from_pdir)
6525         (has_libpthread): Update.
6526         * linespec.c (iterate_over_all_matching_symtabs)
6527         (search_minsyms_for_name): Update.
6528         * jit.c (jit_find_objf_with_entry_addr): Update.
6529         * hppa-tdep.c (find_unwind_entry)
6530         (hppa_lookup_stub_minimal_symbol): Update.
6531         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6532         Update.
6533         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6534         (elf_gnu_ifunc_resolve_by_got): Update.
6535         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6536         * dwarf-index-write.c (save_gdb_index_command): Update.
6537         * cp-support.c (add_symbol_overload_list_qualified): Update.
6538         * breakpoint.c (create_overlay_event_breakpoint)
6539         (create_longjmp_master_breakpoint)
6540         (create_std_terminate_master_breakpoint)
6541         (create_exception_master_breakpoint): Update.
6542         * blockframe.c (find_pc_partial_function): Update.
6543         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6544         (ada_collect_symbol_completion_matches)
6545         (ada_add_global_exceptions): Update.
6546
6547 2019-01-17  Tom Tromey  <tom@tromey.com>
6548
6549         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6550         declare VEC.
6551         (solib_target_parse_libraries): Change return type.
6552         (library_list_start_segment, library_list_start_section)
6553         (library_list_end_library, library_list_start_library); Update.
6554         (solib_target_free_library_list): Remove.
6555         (solib_target_parse_libraries): Remove cleanup.  Change return
6556         type.
6557         (solib_target_current_sos): Update.
6558
6559 2019-01-17  Tom Tromey  <tromey@bapiya>
6560
6561         * valprint.c: Replace "the the" with "the".
6562         * symtab.c: Replace "the the" with "the".
6563         * solib.c: Replace "the the" with "the".
6564         * solib-dsbt.c: Replace "the the" with "the".
6565         * linespec.c: Replace "the the" with "the".
6566         * dwarf2loc.h: Replace "the the" with "the".
6567         * amd64-windows-tdep.c: Replace "the the" with "the".
6568         * aarch64-tdep.c: Replace "the the" with "the".
6569
6570 2019-01-16  Keith Seitz  <keiths@redhat.com>
6571
6572         PR gdb/23773
6573         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6574         <builder>: Rename to ..
6575         <m_builder>: ... this and make private.
6576         (dwarf2_cu::get_builder): New method.  Change all users of
6577         `builder' to use this method.
6578         (dwarf2_start_symtab): Move to ...
6579         (dwarf2_cu::start_symtab): ... here.  Update all callers
6580         (setup_type_unit_groups): Move to ...
6581         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6582         callers.
6583         (dwarf2_cu::reset_builder): New method.
6584         (process_full_compunit, process_full_type_unit): Use
6585         dwarf2_cu::reset_builder.
6586         (follow_die_offset): Record the ancestor CU if it is different
6587         from the followed DIE's CU.
6588         (follow_die_sig_1): Likewise.
6589
6590 2019-01-15  Tom Tromey  <tom@tromey.com>
6591
6592         * remote.c (class remote_state) <buf>: Now a char_vector.
6593         <buf_size>: Remove.
6594         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6595         parameter.
6596         (remote_target::getpkt_or_notif_sane_1)
6597         (remote_target::getpkt_sane)
6598         (remote_target::getpkt_or_notif_sane): Likewise.
6599         (class remote_target) <putpkt>: New overload.
6600         (remote_target::read_frame): Change type of "buf_p".  Remove
6601         sizeof_p parameter.
6602         (packet_ok): New overload.
6603         (packet_check_result): New overload.
6604         Update all uses.
6605
6606 2019-01-14  Tom Tromey  <tom@tromey.com>
6607
6608         * remote-notif.c (handle_notification, remote_notif_ack)
6609         (remote_notif_parse): Make "buf" const.
6610         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6611         const.
6612         (remote_notif_parse, remote_notif_ack, handle_notification):
6613         Likewise.
6614         * remote.c (remote_notif_stop_parse): Make "buf" const.
6615         (remote_target::remote_parse_stop_reply): Make "buf" const.
6616         (remote_notif_stop_ack): Make "buf" const.
6617
6618 2019-01-14  Tom Tromey  <tom@tromey.com>
6619
6620         * remote.c (remote_console_output): Make parameter const.
6621
6622 2019-01-14  Tom Tromey  <tom@tromey.com>
6623
6624         * target-debug.h (target_debug_print_signals): Constify.
6625         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6626         * procfs.c (procfs_target::pass_signals): Update.
6627         * linux-nat.c (linux_nat_target::pass_signals): Update.
6628         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6629         * target-delegates.c: Rebuild.
6630         * remote.c (remote_target::program_signals): Update.
6631         (remote_target::pass_signals): Update.
6632         * target.c (target_pass_signals): Constify argument.
6633         (target_program_signals): Likewise.
6634         * target.h (struct target_ops) <pass_signals, program_signals>:
6635         Constify argument.
6636         (target_pass_signals, target_program_signals): Constify argument.
6637
6638 2019-01-14  Tom Tromey  <tom@tromey.com>
6639
6640         PR tui/28819:
6641         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6642
6643 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6644
6645         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6646         field.
6647         * rs6000-tdep.c: Include reggroups.h.
6648         (IS_V_ALIAS_PSEUDOREG): Define.
6649         (rs6000_register_name): Return names for the "vX" aliases.
6650         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6651         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6652         aliases.  Call default_register_reggroup_p for all other
6653         pseudo-registers.
6654         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6655         New functions.
6656         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6657         Handle "vX" aliases.
6658         (v_alias_pseudo_register_collect): New function.
6659         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6660         (rs6000_gdbarch_init): Initialize "vX" aliases as
6661         pseudo-registers.  Restore registration of
6662         rs6000_pseudo_register_reggroup_p with
6663         set_tdesc_pseudo_register_reggroup_p.
6664
6665 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6666
6667         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6668         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6669         set_gdbarch_num_pseudo_regs.
6670
6671 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6672
6673         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6674         Remove arg prefixname, add do_set and do_show.
6675         Add member functions set_list and show_list.
6676         * cli/cli-style.c (class cli_style_option): Update accordingly.
6677         (style_set_list): Move to file scope.
6678         (style_show_list): Likewise.
6679         (set_style): Call help_list.
6680         (show_style): Call cmd_show_list.
6681         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6682         Update to use the new macro.
6683
6684 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6685
6686         * ada-lang.c (_initialize_ada_language): Expand the help text
6687         for the "catch exception" command.
6688
6689 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6690
6691         * symtab.c (matching_obj_sections): Initialize obj,
6692         declare it closer to its usage.
6693
6694 2019-01-10  Tom Tromey  <tom@tromey.com>
6695
6696         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6697         (basic_inf_threads_range): Remove.
6698         (inf_threads_range, inf_non_exited_threads_range)
6699         (safe_inf_threads_range): Use next_adapter.
6700
6701 2019-01-10  Keith Seitz  <keiths@redhat.com>
6702
6703         PR gdb/23712
6704         PR symtab/23010
6705         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6706         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6707
6708 2019-01-10  Keith Seitz  <keiths@redhat.com>
6709
6710         PR gdb/23712
6711         PR symtab/23010
6712         * dictionary.c (pending_to_vector): Remove.
6713         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6714         Remove _1 suffix, replacing functions of the same name.  Update
6715         all callers.
6716         (dict_create_hashed, dict_create_hashed_expandable)
6717         (dict_create_linear, dict_create_linear_expandable, dict_free)
6718         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6719         Make functions static.
6720
6721 2019-01-10  Keith Seitz  <keiths@redhat.com>
6722
6723         PR gdb/23712
6724         PR symtab/23010
6725         * dictionary.h (struct dictionary): Replace declaration with
6726         multidictionary.
6727         (dict_create_hashed, dict_create_hashed_expandable)
6728         (dict_create_linear, dict_create_linear_expandable)
6729         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6730         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6731         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6732         taking multidictionary argument.
6733         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6734         * block.h (struct block) <dict>: Change to multidictionary
6735         and rename `multidict'.
6736         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6737         symmisc.c: Update all dictionary references to multidictionary.
6738
6739 2019-01-10  Keith Seitz  <keiths@redhat.com>
6740
6741         PR gdb/23712
6742         PR symtab/23010
6743         * dictionary.c: Include unordered_map.
6744         (pending_to_vector): New function.
6745         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6746         Rewrite the non-"_1" functions to take vector instead
6747         of linked list.
6748         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6749         "new" _1 versions of the same name.
6750         (multidictionary): Define.
6751         (std::hash<enum language): New definition.
6752         (collate_pending_symbols_by_language, mdict_create_hashed)
6753         (mdict_create_hashed_expandable, mdict_create_linear)
6754         (mdict_create_linear_expandable, mdict_free)
6755         (find_language_dictionary, create_new_language_dictionary)
6756         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6757         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6758         (mdict_size, mdict_empty): New functions.
6759         * dictionary.h (mdict_iterator): Define.
6760
6761 2019-01-10  Pedro Alves  <palves@redhat.com>
6762
6763         * breakpoint.c (read_uploaded_action)
6764         (create_tracepoint_from_upload): Adjust to use
6765         gdb::unique_xmalloc_ptr.
6766         * ctf.c (ctf_write_uploaded_tp):
6767         (SET_ARRAY_FIELD): Use emplace_back.
6768         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6769         * tracefile-tfile.c (tfile_write_uploaded_tp):
6770         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6771         gdb::unique_xmalloc_ptr.
6772         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6773         at_string, cond_string, cmd_strings>: Replace char pointers
6774         with gdb::unique_xmalloc_ptr.
6775
6776 2019-01-10  Pedro Alves  <palves@redhat.com>
6777
6778         * solib-target.c (library_list_start_library): Don't xstrdup name.
6779
6780 2019-01-10  Pedro Alves  <palves@redhat.com>
6781
6782         * mdebugread.c (parse_partial_symbols): Use
6783         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6784
6785 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6786
6787         * linux-fork.c (scoped_switch_fork_info)
6788         <~scoped_switch_fork_info>: Fix incorrect variable name.
6789
6790 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * linux-fork.c (scoped_switch_fork_info)
6793         <scoped_switch_fork_info>: Make explicit.
6794         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6795
6796 2019-01-10  Tom Tromey  <tom@tromey.com>
6797
6798         * objfiles.h (objfile::reset_psymtabs): Update.
6799         * objfiles.c (objfile::objfile): Update.
6800         * psymtab.h (psymtab_storage::obstack): Update.
6801         (psymtab_storage::m_obstack): Use gdb::optional.
6802         (class psymtab_storage): Update comment.  Remove objfile
6803         parameter.
6804         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6805
6806 2019-01-10  Tom Tromey  <tom@tromey.com>
6807
6808         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6809         <free_psymtabs>: Now private.
6810         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6811         (allocate_psymtab): Use new method.
6812
6813 2019-01-10  Tom Tromey  <tom@tromey.com>
6814
6815         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6816         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6817         * mdebugread.c (parse_partial_symbols): Use
6818         allocate_dependencies.
6819         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6820         allocate_dependencies.
6821         (process_psymtab_comp_unit_reader)
6822         (build_type_psymtab_dependencies): Likewise.
6823         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6824
6825 2019-01-10  Tom Tromey  <tom@tromey.com>
6826
6827         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6828         PSYMBOL_SET_LANGUAGE.
6829         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6830
6831 2019-01-10  Tom Tromey  <tom@tromey.com>
6832
6833         * psymtab.h (psymtab_storage::obstack): New method.
6834         <m_obstack>: Rename from obstack; now private.
6835         * psymtab.c (psymtab_storage): Update.
6836         * dwarf2read.c (create_addrmap_from_index)
6837         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6838         Update.
6839
6840 2019-01-10  Tom Tromey  <tom@tromey.com>
6841
6842         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6843         * objfiles.h (objfile::reset_psymtabs): New method.
6844
6845 2019-01-10  Tom Tromey  <tom@tromey.com>
6846
6847         * symmisc.c (print_symbol_bcache_statistics): Update.
6848         (print_objfile_statistics): Update.
6849         * symfile.c (reread_symbols): Update.
6850         * psymtab.h (class psymtab_storage): New.
6851         * psymtab.c (psymtab_storage): New constructor.
6852         (~psymtab_storage): New destructor.
6853         (require_partial_symbols): Update.
6854         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6855         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6856         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6857         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6858         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6859         (start_psymtab_common, end_psymtab_common)
6860         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6861         (allocate_psymtab): Update.
6862         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6863         Update.
6864         (dump_psymtab_addrmap, maintenance_print_psymbols)
6865         (maintenance_check_psymtabs): Update.
6866         (class objfile_psymtabs): Move to objfiles.h.
6867         * psympriv.h (discard_psymtab): Now inline.
6868         (psymtab_discarder::psymtab_discarder): Update.
6869         (psymtab_discarder::~psymtab_discarder): Update.
6870         (ALL_OBJFILE_PSYMTABS): Rewrite.
6871         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6872         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6873         Remove fields.
6874         <partial_symtabs>: New field.
6875         (class objfile_psymtabs): Move from psymtab.h.  Update.
6876         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6877         psymbol_cache.
6878         (objfile::~objfile): Don't destroy psymbol_cache.
6879         * mdebugread.c (parse_partial_symbols): Update.
6880         * dwarf2read.c (create_addrmap_from_index)
6881         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6882         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6883         (add_partial_subprogram, dwarf2_ranges_read): Update.
6884         * dwarf-index-write.c (write_address_map)
6885         (write_one_signatured_type, recursively_write_psymbols)
6886         (class debug_names, class debug_names, write_psymtabs_to_index):
6887         Update.
6888
6889 2019-01-10  Tom Tromey  <tom@tromey.com>
6890
6891         * symtab.h (SYMBOL_SET_NAMES): Update.
6892         (symbol_set_names): Update.
6893         (MSYMBOL_SET_NAMES): Update.
6894         * symtab.c (symbol_set_names): Change argument to be an
6895         objfile_per_bfd_storage.
6896         * psymtab.c (add_psymbol_to_bcache): Update.
6897         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6898
6899 2019-01-10  Tom Tromey  <tom@tromey.com>
6900
6901         * symtab.c (create_demangled_names_hash): Change argument to be an
6902         objfile_per_bfd_storage.
6903         (symbol_set_names): Update.
6904
6905 2019-01-10  Tom Tromey  <tom@tromey.com>
6906
6907         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6908         init_psymbol_list.
6909         * psymtab.c (init_psymbol_list): Do nothing if already called.
6910         * psympriv.h (init_psymbol_list): Add comment.
6911         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6912         init_psymbol_list.
6913         * dbxread.c (dbx_symfile_read): Unconditionally call
6914         init_psymbol_list.
6915
6916 2019-01-10  Tom Tromey  <tom@tromey.com>
6917
6918         * xcoffread.c (scan_xcoff_symtab): Update.
6919         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6920         "where".
6921         * mdebugread.c (parse_partial_symbols)
6922         (handle_psymbol_enumerators): Update.
6923         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6924         * dbxread.c (read_dbx_symtab): Update.
6925         * psympriv.h (psymbol_placement): New enum.
6926         (add_psymbol_to_list): Update.
6927
6928 2019-01-10  Tom Tromey  <tom@tromey.com>
6929
6930         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6931         static_psymbols parameters.
6932         (scan_xcoff_symtab): Update.
6933         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6934         static_psymbols parameters.
6935         * psympriv.h (start_psymtab_common): Update.
6936         * mdebugread.c (parse_partial_symbols): Update.
6937         * dwarf2read.c (create_partial_symtab): Update.
6938         * dbxread.c (read_dbx_symtab): Update.
6939         (start_psymtab): Remove global_psymbols and static_psymbols
6940         parameters.
6941
6942 2019-01-10  Tom Tromey  <tom@tromey.com>
6943
6944         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6945         * psymtab.c (allocate_psymtab): Add comment.
6946         * psympriv.h (allocate_psymtab): Add comment.
6947         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6948         initializations.
6949         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6950
6951 2019-01-10  Tom Tromey  <tom@tromey.com>
6952
6953         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6954         Don't declare.
6955         * mipsread.c: Include mdebugread.h.
6956         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6957         Declare.
6958         * elfread.c: Include mdebugread.h.
6959
6960 2019-01-09  Tom Tromey  <tom@tromey.com>
6961
6962         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6963         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6964         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6965         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6966         (psym_lookup_symbol, psym_find_last_source_symtab)
6967         (psym_forget_cached_source_info, psym_print_stats)
6968         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6969         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6970         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6971         (psym_find_compunit_symtab_by_address)
6972         (maintenance_print_psymbols, maintenance_info_psymtabs)
6973         (maintenance_check_psymtabs): Use ranged for.
6974         * psymtab.h (class objfile_psymtabs): New.
6975         (require_partial_symbols): Return objfile_psymtabs.
6976         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6977
6978 2019-01-09  Tom Tromey  <tom@tromey.com>
6979
6980         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6981         (find_pc_mapped_section, list_overlays_command)
6982         (map_overlay_command, unmap_overlay_command)
6983         (simple_overlay_update): Use all_objfiles.
6984         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6985         * printcmd.c (info_symbol_command): Use all_objfiles.
6986         * objfiles.h (ALL_OBJSECTIONS): Remove.
6987         * maint.c (maintenance_translate_address): Use all_objfiles.
6988         * gcore.c (gcore_create_callback): Use all_objfiles.
6989         (objfile_find_memory_regions): Likewise.
6990
6991 2019-01-09  Tom Tromey  <tom@tromey.com>
6992
6993         * symtab.c (find_line_symtab, info_sources_command)
6994         (make_source_files_completion_list): Use objfile_compunits.
6995         * source.c (select_source_symtab): Use objfile_compunits.
6996         * objfiles.h (struct objfile): Update comment.
6997         (ALL_OBJFILES): Remove.
6998         (ALL_FILETABS): Remove.
6999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7000         objfile_compunits.
7001
7002 2019-01-09  Tom Tromey  <tom@tromey.com>
7003
7004         * symmisc.c (print_objfile_statistics, dump_objfile)
7005         (maintenance_print_symbols): Use compunit_filetabs.
7006         * source.c (forget_cached_source_info_for_objfile): Use
7007         compunit_filetabs.
7008         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7009         (ALL_FILETABS): Use compunit_filetabs.
7010         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7011         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7012
7013 2019-01-09  Tom Tromey  <tom@tromey.com>
7014
7015         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7016         (compunit_filetabs): New.
7017         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7018         compunit_filetabs.
7019         (info_sources_command, make_source_files_completion_list): Remove
7020         declaration.
7021         * symmisc.c (print_objfile_statistics, dump_objfile)
7022         (maintenance_print_symbols): Remove declaration.
7023         (maintenance_info_symtabs): Use compunit_filetabs.
7024         (maintenance_info_line_tables): Likewise.
7025         * source.c (select_source_symtab): Change local variable name.
7026         (forget_cached_source_info_for_objfile): Remove declaration.
7027         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7028         * objfiles.c (objfile_relocate1): Remove declaration.
7029         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7030         declaration.
7031         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7032         * coffread.c (coff_symtab_read): Remove declaration.
7033         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7034         compunit_filetabs.
7035
7036 2019-01-09  Tom Tromey  <tom@tromey.com>
7037
7038         * symtab.c (lookup_objfile_from_block)
7039         (find_pc_sect_compunit_symtab, search_symbols)
7040         (default_collect_symbol_completion_matches_break_on): Use
7041         objfile_compunits.
7042         * objfiles.h (ALL_COMPUNITS): Remove.
7043         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7044         * cp-support.c (add_symbol_overload_list_qualified): Use
7045         objfile_compunits.
7046         * ada-lang.c (ada_collect_symbol_completion_matches)
7047         (ada_add_global_exceptions): Use objfile_compunits.
7048
7049 2019-01-09  Tom Tromey  <tom@tromey.com>
7050
7051         * source.c (select_source_symtab)
7052         (forget_cached_source_info_for_objfile): Remove declaration.
7053         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7054         declaration.
7055         * maint.c (count_symtabs_and_blocks): Remove declaration.
7056         * cp-support.c (add_symbol_overload_list_qualified): Remove
7057         declaration.
7058         * coffread.c (coff_symtab_read): Remove declaration.
7059         * symtab.c (lookup_symbol_in_objfile_symtabs)
7060         (basic_lookup_transparent_type_1): Use objfile_compunits.
7061         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7062         (info_sources_command, search_symbols)
7063         (default_collect_symbol_completion_matches_break_on)
7064         (make_source_files_completion_list): Remove declaration.
7065         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7066         (ada_collect_symbol_completion_matches)
7067         (ada_add_global_exceptions): Remove declaration.
7068         * linespec.c (iterate_over_all_matching_symtabs): Use
7069         objfile_compunits.
7070         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7071         (class objfile_compunits): New.
7072         (ALL_COMPUNITS): Use objfile_compunits.
7073         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7074         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7075         objfile_compunits.
7076         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7077
7078 2019-01-09  Tom Tromey  <tom@tromey.com>
7079
7080         * symtab.c (search_symbols)
7081         (default_collect_symbol_completion_matches_break_on): Use
7082         objfile_msymbols.
7083         * ada-lang.c (ada_lookup_simple_minsym)
7084         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7085         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7086         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7087         objfile_msymbols.
7088         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7089         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7090         * objc-lang.c (find_methods): Use objfile_msymbols.
7091         (info_selectors_command, info_classes_command): Likewise.
7092         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7093         * objfiles.h (class objfile_msymbols): New.
7094         (ALL_OBJFILE_MSYMBOLS): Remove.
7095         (ALL_MSYMBOLS): Remove.
7096
7097 2019-01-09  Tom Tromey  <tom@tromey.com>
7098
7099         * common/next-iterator.h (next_adapter): Add Iterator template
7100         parameter.
7101         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7102         (class all_objfiles_safe): New.
7103         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7104         * objfiles.c (put_objfile_before): Update comment.
7105         (add_separate_debug_objfile): Likewise.
7106         (free_all_objfiles): Use all_objfiles_safe.
7107         (objfile_purge_solibs): Likewise.
7108
7109 2019-01-09  Tom Tromey  <tom@tromey.com>
7110
7111         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7112         (expand_symtab_containing_pc, lookup_static_symbol)
7113         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7114         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7115         all_objfiles.
7116         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7117         * breakpoint.c (create_overlay_event_breakpoint)
7118         (create_longjmp_master_breakpoint)
7119         (create_std_terminate_master_breakpoint)
7120         (create_exception_master_breakpoint): Use all_objfiles.
7121         * linux-thread-db.c (try_thread_db_load_from_pdir)
7122         (has_libpthread): Use all_objfiles.
7123         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7124         * linespec.c (iterate_over_all_matching_symtabs)
7125         (search_minsyms_for_name): Use all_objfiles.
7126         * maint.c (maintenance_info_sections): Use all_objfiles.
7127         * main.c (captured_main_1): Use all_objfiles.
7128         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7129         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7130         * guile/scm-pretty-print.c
7131         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7132         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7133         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7134         (maintenance_print_msymbols): Use all_objfiles.
7135         * source.c (select_source_symtab): Use all_objfiles.
7136         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7137         * symfile.c (remove_symbol_file_command)
7138         (expand_symtabs_matching, map_symbol_filenames): Use
7139         all_objfiles.
7140         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7141         all_objfiles.
7142         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7143         * objc-lang.c (find_methods): Use all_objfiles.
7144         * objfiles.c (have_partial_symbols, have_full_symbols)
7145         (have_minimal_symbols, qsort_cmp)
7146         (default_iterate_over_objfiles_in_search_order): Use
7147         all_objfiles.
7148         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7149         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7150         (maintenance_check_psymtabs): Use all_objfiles.
7151         (ALL_PSYMTABS): Remove.
7152         * compile/compile-object-run.c (do_module_cleanup): Use
7153         all_objfiles.
7154         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7155         * cp-support.c (add_symbol_overload_list_qualified): Use
7156         all_objfiles.
7157         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7158         Use all_objfiles.
7159         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7160         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7161         all_objfiles.
7162         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7163         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7164         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7165         Uses all_objfiles.
7166         * solib.c (solib_read_symbols): Use all_objfiles
7167
7168 2019-01-09  Tom Tromey  <tom@tromey.com>
7169
7170         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7171         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7172         all_objfiles.
7173         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7174         * symmisc.c (print_symbol_bcache_statistics)
7175         (print_objfile_statistics, maintenance_print_objfiles)
7176         (maintenance_info_symtabs, maintenance_check_symtabs)
7177         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7178         all_objfiles.
7179         * source.c (forget_cached_source_info): Use all_objfiles.
7180         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7181         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7182         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7183         * objfiles.c (update_section_map): Use all_objfiles.
7184         (shared_objfile_contains_address_p): Likewise.
7185         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7186         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7187
7188 2019-01-09  Tom Tromey  <tom@tromey.com>
7189
7190         * common/next-iterator.h: New file.
7191         * objfiles.h (class all_objfiles): New.
7192         (struct objfile_iterator): New.
7193
7194 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7195
7196         * NEWS: Move the description of the changed "frame", "select-frame",
7197          and "info frame" commands to the Changed commands section.
7198
7199 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7200
7201         * gdbtypes.c (check_stub_method_group): Remove handling of old
7202         mangling schemes.
7203         * linespec.c (find_methods): Likewise.
7204         * stabsread.c (read_member_functions): Likewise.
7205         * valops.c (search_struct_method): Likewise.
7206         (value_struct_elt_for_reference): Likewise.
7207         * NEWS: Mention this change.
7208
7209 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7210
7211         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7212         print_source_lines.
7213         * source.c (print_source_lines_base): Update line number check.
7214         (print_source_lines): New function.
7215         (source_lines_range::source_lines_range): New function.
7216         * source.h (class source_lines_range): New class.
7217         (print_source_lines): New declaration.
7218
7219 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7220
7221         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7222
7223 2019-01-08  Tom Tromey  <tom@tromey.com>
7224             Simon Marchi  <simon.marchi@ericsson.com>
7225
7226         PR gdb/24060
7227         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7228         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7229         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7230         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7231         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7232         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7233
7234 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * source.c (select_source_symtab): Move header comment to
7237         declaration in source.h.
7238         (forget_cached_source_info_for_objfile): Likewise.
7239         (forget_cached_source_info): Likewise.
7240         (identify_source_line): Likewise.
7241         * source.h (identify_source_line): Move declaration from symtab.h
7242         and add comment from source.c
7243         (print_source_lines): Likewise.
7244         (forget_cached_source_info_for_objfile): Likewise.
7245         (forget_cached_source_info): Likewise.
7246         (select_source_symtab): Likewise.
7247         (enum print_source_lines_flag): Move definition from symtab.h.
7248         * symtab.h (identify_source_line): Move declaration to source.h.
7249         (print_source_lines): Likewise.
7250         (forget_cached_source_info_for_objfile): Likewise.
7251         (forget_cached_source_info): Likewise.
7252         (select_source_symtab): Likewise.
7253         (enum print_source_lines_flag): Move definition to source.h.
7254         * tui/tui-hooks.c: Add 'source.h' include.
7255
7256 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * source.c (print_source_lines_base): Handle requests to print
7259         reverse line number sequences, and guard against empty lines
7260         string.
7261
7262 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * source.c (print_source_lines_base): Fix skip of '\r' if next
7265         character is '\n'.
7266
7267 2019-01-06  Tom Tromey  <tom@tromey.com>
7268
7269         * c-exp.y (struct c_parse_state) <macro_original_text,
7270         expansion_obstack>: New member.
7271         (macro_original_text, expansion_obstack): Remove globals.
7272         (scan_macro_expansion, scanning_macro_expansion)
7273         (finished_macro_expansion): Update.
7274         (scan_macro_cleanup): Remove.
7275         (yylex, c_parse): Update.
7276
7277 2019-01-06  Tom Tromey  <tom@tromey.com>
7278
7279         * c-exp.y (struct c_parse_state) <strings>: New member.
7280         (operator_stoken): Update.
7281
7282 2019-01-06  Tom Tromey  <tom@tromey.com>
7283
7284         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7285         (union type_stack_elt) <typelist_val>: Now a pointer to
7286         std::vector.
7287         (type_stack_cleanup): Don't declare.
7288         (push_typelist): Update.
7289         * parse.c (pop_typelist): Return a std::vector.
7290         (push_typelist): Take a std::vector.
7291         (follow_types): Update.  Do not free args.
7292         (type_stack_cleanup): Remove.
7293         * c-exp.y (struct c_parse_state): New.
7294         (cpstate): New global.
7295         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7296         (nonempty_typelist): Update.
7297         (func_mod): Create a new vector.
7298         (c_parse): Create a c_parse_state.
7299         (check_parameter_typelist): Do not delete params.
7300         (function_method): Update.  Do not delete type_list.
7301
7302 2019-01-06  Tom Tromey  <tom@tromey.com>
7303
7304         PR gdb/28155:
7305         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7306         check_typedef.
7307         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7308         (print_return_value): Likewise.
7309
7310 2019-01-05  Tom Tromey  <tom@tromey.com>
7311
7312         * contrib/cleanup_check.py: Remove.
7313         * contrib/gcc-with-excheck: Remove.
7314         * contrib/exsummary.py: Remove.
7315         * contrib/excheck.py: Remove.
7316
7317 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7318
7319         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7320         NULL. Initialize tpprev to NULL instead of assigning it
7321         to NULL on the next statement.
7322         * windows-nat.c (windows_delete_thread): Remove check for
7323         main_thread_id before printing thread exit notifications.
7324         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7325         Remove thread ID check against main_thread_id.
7326         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7327         windows_delete_thread.
7328         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7329
7330 2019-01-04  Tom Tromey  <tom@tromey.com>
7331
7332         * compile/compile.c (_initialize_compile): Use upper case for
7333         metasyntactic variables.
7334         * symmisc.c (_initialize_symmisc): Use upper case for
7335         metasyntactic variables.
7336         * psymtab.c (_initialize_psymtab): Use upper case for
7337         metasyntactic variables.
7338         * demangle.c (demangle_command): Use upper case for metasyntactic
7339         variables.
7340         (_initialize_demangler): Likewise.
7341         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7342         variables.
7343
7344 2019-01-03  Tom Tromey  <tom@tromey.com>
7345
7346         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7347
7348 2019-01-03  Tom Tromey  <tom@tromey.com>
7349
7350         * python/py-symtab.c (salpy_str): Update.
7351         (struct salpy_sal_object) <symtab>: Now a PyObject.
7352         (salpy_dealloc): Update.
7353         (del_objfile_sal): Use gdbpy_ref.
7354
7355 2019-01-03  Tom Tromey  <tom@tromey.com>
7356
7357         * python/py-type.c (convert_field): Use new_reference.  Return
7358         gdbpy_ref.
7359         (make_fielditem): Return gdbpy_ref.
7360         (typy_fields): Update.
7361         (typy_getitem): Update.
7362         (field_name): Return gdbpy_ref.  Use new_reference.
7363         (typy_iterator_iternext): Update.
7364
7365 2019-01-03  Tom Tromey  <tom@tromey.com>
7366
7367         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7368
7369 2019-01-03  Tom Tromey  <tom@tromey.com>
7370
7371         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7372         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7373         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7374         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7375         (pspy_set_type_printers): Likewise.
7376         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7377         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7378         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7379         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7380         (objfpy_set_type_printers): Likewise.
7381
7382 2019-01-03  Tom Tromey  <tom@tromey.com>
7383
7384         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7385         (gdbpy_print_stack): Use gdbpy_err_fetch.
7386         * python/python-internal.h (class gdbpy_err_fetch): New class.
7387         (class gdbpy_enter) <m_error_type, m_error_value,
7388         m_error_traceback>: Remove.
7389         <m_error>: New member.
7390         (gdbpy_exception_to_string): Don't declare.
7391         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7392         * python/py-value.c (convert_value_from_python): Use
7393         gdbpy_err_fetch.
7394         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7395         gdbpy_exception_to_string.
7396         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7397         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7398         gdbpy_err_fetch.
7399
7400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7401
7402         * linux-nat.c (delete_lwp_cleanup): Delete.
7403         (struct lwp_deleter): New struct.
7404         (lwp_info_up): New typedef.
7405         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7406         lwp_info_up.
7407
7408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7409
7410         * linux-fork.c (class scoped_switch_fork_info): New class.
7411         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7412
7413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * valops.c (find_overload_match): Remove use of null_cleanup, and
7416         calls to do_cleanups.
7417
7418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7419
7420         * compile/compile-cplus-types.c
7421         (compile_cplus_instance::decl_name): Handle changes to
7422         cp_func_name.
7423         * cp-support.c (cp_func_name): Update header comment, update
7424         return type.
7425         * cp-support.h (cp_func_name): Update return type in declaration.
7426         * valops.c (find_overload_match): Move temp_func local to top
7427         level of function and change its type.  Use temp_func to hold and
7428         delete temporary string obtained from cp_func_name.
7429
7430 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7433         gdb::char_vector, remove cleanup, and update uses of `msg`.
7434
7435 2019-01-03  Jim Wilson  <jimw@sifive.com>
7436
7437         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7438
7439 2019-01-02  Tom Tromey  <tom@tromey.com>
7440
7441         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7442         (tdesc_parse_xml): Remove cleanups.
7443         * target-descriptions.h (make_cleanup_free_target_description):
7444         Don't declare.
7445         (target_desc_deleter): New struct.
7446         (target_desc_up): New typedef.
7447         * target-descriptions.c (target_desc_deleter::operator()): Rename
7448         from free_target_description.
7449         (make_cleanup_free_target_description): Remove.
7450
7451 2019-01-02  Tom Tromey  <tom@tromey.com>
7452
7453         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7454         constructor, destructor.
7455         (linespec_parser): Remove typedef.
7456         (~linespec_parser): Rename from linespec_parser_delete.
7457         (linespec_lex_to_end, linespec_complete_label)
7458         (linespec_complete): Update.
7459         (decode_line_full): Remove cleanups.
7460         (decode_line_1): Update.
7461
7462 2019-01-02  Tom Tromey  <tom@tromey.com>
7463
7464         * python/python-internal.h (inferior_to_inferior_object): Change
7465         return type.
7466         * python/py-exitedevent.c (create_exited_event_object): Update.
7467         * python/py-inferior.c (inferior_to_inferior_object): Return
7468         gdbpy_ref.
7469         (python_new_inferior, python_inferior_deleted)
7470         (thread_to_thread_object, delete_thread_object)
7471         (build_inferior_list, gdbpy_selected_inferior): Update.
7472         * python/py-infthread.c (create_thread_object): Update.  Also fail
7473         if inferior_to_inferior_object fails.
7474
7475 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7476
7477         * inferior.h (class inferior) <displaced_step_state>: New field.
7478         * infrun.h (struct displaced_step_state): Move here from
7479         infrun.c.  Initialize fields, add constructor.
7480         <inf>: Remove field.
7481         <reset>: New method.
7482         * infrun.c (struct displaced_step_inferior_state): Move to
7483         infrun.h.
7484         (displaced_step_inferior_states): Remove.
7485         (get_displaced_stepping_state): Adust.
7486         (displaced_step_in_progress_any_inferior): Adjust.
7487         (displaced_step_in_progress_thread): Adjust.
7488         (displaced_step_in_progress): Adjust.
7489         (add_displaced_stepping_state): Remove.
7490         (get_displaced_step_closure_by_addr): Adjust.
7491         (remove_displaced_stepping_state): Remove.
7492         (infrun_inferior_exit): Call displaced_step_state.reset.
7493         (use_displaced_stepping): Don't check for NULL.
7494         (displaced_step_prepare_throw): Call
7495         get_displaced_stepping_state.
7496         (displaced_step_fixup): Don't check for NULL.
7497         (prepare_for_detach): Don't check for NULL.
7498
7499 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7500
7501         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7502          in case of call that did not complete.
7503
7504 2019-01-02  Andrey Utkin  <autkin@undo.io>
7505
7506         * symfile.c (find_separate_debug_file): Fix search of debug files for
7507         remote debuggee.
7508
7509 2019-01-02  Tom Tromey  <tom@tromey.com>
7510
7511         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7512         indentation.
7513         * python/py-frame.c (frapy_older): Remove cast.
7514         (frapy_newer): Likewise.
7515         * python/py-breakpoint.c (local_setattro): Remove cast.
7516         * python/py-arch.c (archpy_name): Remove local variable.
7517         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7518
7519 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7520
7521         * unittests/basic_string_view/element_access/char/empty.cc:
7522         Fix year range in copyright header.
7523
7524 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7527         Delete.
7528         <operator==>: Update with for removed field.
7529         <hash>: Likewise.
7530         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7531         <isa_features>: ...this.
7532         <abi_features>: New field.
7533         (riscv_isa_flen): Update comment.
7534         (riscv_abi_xlen): New declaration.
7535         (riscv_abi_flen): New declaration.
7536         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7537         isa_features.
7538         (riscv_abi_xlen): New function.
7539         (riscv_isa_flen): Update to get answer from isa_features.
7540         (riscv_abi_flen): New function.
7541         (riscv_has_fp_abi): Update to get answer from abi_features.
7542         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7543         xlen and flen.
7544         (riscv_call_info) <xlen, flen>: Update comment.
7545         (riscv_call_arg_struct): Remove invalid assertions
7546         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7547         is removed.
7548         (riscv_gdbarch_init): Gather isa features and abi features
7549         separately, ensure both match on the gdbarch when reusing an old
7550         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7551         a target with 64-bit float hardware.
7552
7553 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7554
7555         * source.c (search_command_helper): Stop reverse search
7556         when line 1 has been searched.
7557
7558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7559
7560         * record-full.c (record_full_base_target::close): Rewrite
7561         record_full_core_buf_list free logic.
7562
7563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7564
7565         * break-catch-syscall.c (print_one_catch_syscall): xfree
7566         the last text.
7567
7568 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7569
7570         * top.c (print_gdb_version): Update Copyright year in version
7571         message.
7572
7573 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7574
7575         Update copyright year range in all GDB files.
7576
7577 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7578
7579         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7580
7581 For older changes see ChangeLog-2018.
7582 \f
7583 Local Variables:
7584 mode: change-log
7585 left-margin: 8
7586 fill-column: 74
7587 version-control: never
7588 coding: utf-8
7589 End:
7590