gdb/ChangeLog

   1 2010-01-18  Joel Brobecker  <brobecker@adacore.com>
   2
   3         Use XVS field type instead of doing a parallel lookup.
   4         * ada-lang.c (ada_get_base_type): Follow the XVS field type
   5         if it is a reference type instead of doing a type lookup using
   6         the XVS field name.
   7
   8 2010-01-18  Joel Brobecker  <brobecker@adacore.com>
   9
  10         Trust PAD types instead of using PAD___XVS.
  11         * ada-lang.c (trust_pad_over_xvs): New static variable.
  12         (ada_is_aligner_type): If !trust_pad_over_xvs and there is a
  13         parallel XVS type, follow the XVS type instead of the PAD type.
  14         (unwrap_value): Make sure that there is no parallel XVE type
  15         before returning the value as is.
  16         (set_ada_list, show_ada_list): New static variables.
  17         (set_ada_command, show_ada_command): New functions.
  18         (_initialize_ada_language): Add new "set/show ada" prefix commands.
  19         Add new "set/show ada trust-PAD-over-XVS" setting.
  20
  21 2010-01-18  Tom Tromey  <tromey@redhat.com>
  22             Thiago Jung Bauermann  <bauerman@br.ibm.com>
  23
  24         Allow "source" to load python scripts.
  25         * exceptions.h (enum errors): Add UNSUPPORTED_ERROR.
  26         * python/python.c (source_python_script): New function.
  27         * python/python.h (source_python_script): Add declaration.
  28         * cli/cli-cmds.c: #include exceptions.h and python/python.h.
  29         (script_ext_off, script_ext_soft, script_ext_strict)
  30         (script_ext_enums, script_ext_mode): New static constants.
  31         (show_script_ext_mode, find_and_open_script): New functions.
  32         (source_script): Enhance to handle Python scripts.
  33         (init_cli_cmds): Add set/show script-extension commands.
  34
  35 2010-01-16  Stan Shebs  <stan@codesourcery.com>
  36
  37         * tracepoint.h (struct trace_status): Use unsigned long long
  38         instead of size_t.
  39         * tracepoint.c (trace_status_command): Fix printf directive.
  40         (trace_save_command): Check fwrite returns, fix printf directive.
  41         (trace_filename): New global.
  42         (tfile_open): Set it, check read returns.
  43         (tfile_close): Free trace_filename.
  44         (tfile_get_traceframe_address): Check read returns.
  45         (tfile_trace_find): Ditto.
  46         (tfile_fetch_registers): Ditto.
  47         (tfile_xfer_partial): Ditto.
  48         (tfile_get_trace_state_variable_value): Ditto.
  49
  50 2010-01-15  Stan Shebs  <stan@codesourcery.com>
  51
  52         Add trace file support.
  53         * tracepoint.h (enum trace_stop_reason): New enum.
  54         (struct trace_status): New struct.
  55         (parse_trace_status): Declare.
  56         (struct uploaded_tp): Move here from remote.c,
  57         add fields for actions.
  58         (struct uploaded_tsv): New struct.
  59         * tracepoint.c (tfile_ops): New target vector.
  60         (trace_fd): New global.
  61         (tfile_open): New function.
  62         (tfile_close): New function.
  63         (tfile_files_info): New function.
  64         (tfile_get_trace_status): New function.
  65         (tfile_get_traceframe_address): New function.
  66         (tfile_trace_find): New function.
  67         (tfile_fetch_registers): New function.
  68         (tfile_xfer_partial): New function.
  69         (tfile_get_trace_state_variable_value): New function.
  70         (init_tfile_ops): New function.
  71         (_initialize_tracepoint): Call it, add tfile target.
  72         (trace_status): New global.
  73         (current_trace_status): New function.
  74         (trace_running_p): Remove, change all users to get from
  75         current_trace_status()->running.
  76         (get_trace_status): Remove.
  77         (trace_status_command): Call target_get_trace_status directly,
  78         report more detail including tracing stop reasons.
  79         (trace_find_command): Always allow tfind on a file.
  80         (trace_find_pc_command): Ditto.
  81         (trace_find_tracepoint_command): Ditto.
  82         (trace_find_line_command): Ditto.
  83         (trace_find_range_command): Ditto.
  84         (trace_find_outside_command): Ditto.
  85         (trace_frames_offset, cur_offset): Declare as off_t.
  86         (trace_regblock_size): Rename from reg_size, update users.
  87         (parse_trace_status): New function.
  88         (tfile_interp_line): New function.
  89         (disconnect_or_stop_tracing): Ensure current trace
  90         status before asking what to do.
  91         (stop_reason_names): New global.
  92         (trace_save_command): New command.
  93         (get_uploaded_tp): Move here from remote.c.
  94         (find_matching_tracepoint): Ditto.
  95         (merge_uploaded_tracepoints): New function.
  96         (parse_trace_status): Use stop_reason_names.
  97         (_initialize_tracepoint): Define tsave command.
  98         * target.h (target_ops): New fields to_save_trace_data,
  99         to_upload_tracepoints, to_upload_trace_state_variables,
 100         to_get_raw_trace_data, change to_get_trace_status
 101         to take a pointer to a status struct.
 102         (target_save_trace_data): New macro.
 103         (target_upload_tracepoints): New macro.
 104         (target_upload_trace_state_variables): New macro.
 105         (target_get_raw_trace_data): New macro.
 106         * target.c (update_current_target): Add new methods, change
 107         signature of to_get_trace_status.
 108         * remote.c (hex2bin): Make globally visible.
 109         (bin2hex): Ditto.
 110         (remote_download_trace_state_variable): Download name also.
 111         (remote_get_trace_status): Update parameter, use
 112         parse_trace_status.
 113         (remote_save_trace_data): New function.
 114         (remote_upload_tracepoints): New function.
 115         (remote_upload_trace_state_variables): New function.
 116         (remote_get_raw_trace_data): New function.
 117         (remote_start_remote): Use them.
 118         (_initialize_remote_ops): Add operations.
 119         * ax-gdb.c: Include breakpoint.h.
 120         * breakpoint.c (create_tracepoint_from_upload): Use
 121         break_command_really, return tracepoint, warn about unimplemented
 122         parts.
 123         * NEWS: Mention trace file addition.
 124
 125 2010-01-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
 126
 127         Fix compilation warning on gcc-3.4.
 128         * exec.c (print_section_info): Move the `displacement' variable
 129         initialization to its declaration.
 130
 131 2010-01-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
 132
 133         * gdb-gdb.py (StructMainTypePrettyPrinter): Fix TYPE_CODE_RANGE
 134         comparison.
 135
 136 2010-01-15  Eric Botcazou  <botcazou@adacore.com>
 137
 138         "info tasks" broken by typedefs in ATCB type definitions.
 139         * ada-lang.c (ada_template_to_fixed_record_type_1): Add call to
 140         ada_check_typedef before retrieving the length of the type for
 141         regular fields.
 142
 143 2010-01-15  Joel Brobecker  <brobecker@adacore.com>
 144
 145         Do not use name-based lookup for unconstrained packed arrays.
 146         * ada-lang.c (find_parallel_type_by_descriptive_type):
 147         Limit the fallback to name-based lookups to the case where
 148         the type is a constrained packed array.
 149
 150 2010-01-15  Joel Brobecker  <brobecker@adacore.com>
 151
 152         Enhance gdb-gdb.py to handle main_type.type_specific.
 153         * gdb-gdb.py: Print the type-specific part of struct main_type.
 154
 155 2010-01-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
 156
 157         * configure.ac (AC_CHECK_FUNCS): Check for setrlimit and getrlimit.
 158         * configure: Regenerate.
 159         * config.in: Regenerate.
 160         * utils.c: Include sys/resource.h.
 161         (dump_core, can_dump_core): New.
 162         (internal_vproblem): Update the comment.  Check can_dump_core while
 163         setting dump_core_p.  Replace two abort calls by dump_core calls.
 164
 165 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 166             Eli Zaretskii  <eliz@gnu.org>
 167
 168         * NEWS: Document the PIE support.
 169
 170 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 171
 172         * linux-tdep.c: Remove includes gdbcore.h, observer.h and elf-bfd.h.
 173         (check_is_pie_binary, _initialize_linux_tdep): Remove.
 174
 175 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 176
 177         * solib-svr4.c (svr4_exec_displacement): New comment for entry_point.
 178         Replace exec_entry_point call by bfd_get_start_address.
 179
 180 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 181
 182         Support Valgrind attachments broken by the PIE support.
 183         * auxv.c: Include gdbcore.h.
 184         (procfs_xfer_auxv): Make static.  Reduce its comment.  Drop its
 185         parameters ops, object and annex.  Remove their assertions.
 186         (ld_so_xfer_auxv, memory_xfer_auxv): New function.
 187         * auxv.h (procfs_xfer_auxv): Remove comment.  Rename to ...
 188         (memory_xfer_auxv): ... here.
 189         * linux-nat.c (linux_xfer_partial): Rename procfs_xfer_auxv to
 190         memory_xfer_auxv.
 191         * procfs.c (procfs_xfer_partial): Likewise.
 192         * solib-svr4.c (svr4_relocate_main_executable): New prototype.
 193         (svr4_special_symbol_handling): Call svr4_relocate_main_executable.
 194         (svr4_solib_create_inferior_hook): Conditionalize the
 195         svr4_relocate_main_executable call.
 196
 197 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 198
 199         * solib-svr4.c (scan_dyntag): Remove variable dyn_addr.  New variable
 200         target_section.  Find SECT in current_target_sections, gdb_assert it.
 201         (elf_lookup_lib_symbol): Pass the binary file if given symfile_objfile.
 202         New variable abfd.
 203         * symtab.c (lookup_objfile_from_block): Return the binary file instead
 204         of separate debug info file.
 205
 206 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 207
 208         Support PIEs with no symfile_objfile.
 209         * exec.c (print_section_info <abfd == exec_bfd>): Relocate Entry point.
 210         * solib-svr4.c (svr4_relocate_main_executable <exec_bfd>): New block.
 211
 212 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 213
 214         * solib-svr4.c (svr4_relocate_main_executable): Move the static exec
 215         code part to ...
 216         (svr4_static_exec_displacement): ... a new function.
 217         (svr4_exec_displacement): New function.
 218         (svr4_relocate_main_executable): Call svr4_exec_displacement.  Allocate
 219         new_offsets using alloca now.  Remove variable old_chain and changed.
 220         Call objfile_relocate unconditionally now.
 221
 222 2010-01-14  Doug Evans  <dje@google.com>
 223
 224         * gdbtypes.c (arch_flags_type): Fix comment.
 225         * gdbtypes.h (arch_composite_type): Fix comment.
 226
 227 2009-01-14  Tristan Gingold  <gingold@adacore.com>
 228
 229         * machoread.c (macho_add_oso_symfile): Add symfile_flags parameter.
 230         Call xstrdup for abfd->filename.  Pass symfile_flags and objfile flags
 231         to symbol_file_add_from_bfd.  Add OSO as separate objfile.
 232         (macho_oso_symfile): Add symfile_flags parameter.  Pass it to
 233         macho_add_oso_symfile.
 234         (macho_symfile_read): Pass symfile_flags to macho_oso_symfile.
 235
 236 2010-01-14  Joel Brobecker  <brobecker@adacore.com>
 237
 238         Tru64: Dead threads are never deleted.
 239         * dec-thread.c (dec_thread_ptid_is_alive): New function.
 240         (dec_thread_count_gdb_threads): Fix counter increment.
 241         (dec_thread_add_gdb_thread): Fix *listp increment.
 242         (resync_thread_list): Fix bug in deletion of dead threads that
 243         caused all threads to be deleted, instead of just the dead ones.
 244
 245 2010-01-13  Phil Muldoon  <pmuldoon@redhat.com>
 246
 247         PR python/10705
 248
 249         * python/python-internal.h: Add lazy_string_object_type
 250         definition.
 251         (create_lazy_string_object, gdbpy_initialize_lazy_string)
 252         (gdbpy_is_lazystring, gdbpy_extract_lazy_string): Define.
 253         * python/py-value.c (valpy_lazy_string): New function.
 254         (convert_value_from_python): Add lazy string conversion.
 255         * python/py-prettyprint.c (pretty_print_one_value): Check if
 256         return is also a lazy string.
 257         (print_string_repr): Add lazy string printing branch.
 258         (print_children): Likewise.
 259         * python/py-lazy-string.c: New file. Implement lazy strings.
 260         * python/python.c (_initialize_python): Call
 261         gdbpy_initialize_lazy_string.
 262         * varobj.c (value_get_print_value): Add lazy string printing
 263         branch.  Account for encoding.
 264         * c-lang.c (c_printstr): Account for new encoding argument.  If
 265         encoding is NULL, find encoding suited for type, otherwise use
 266         user encoding.
 267         * language.h (language_defn): Add encoding argument.
 268         (LA_PRINT_STRING): Likewise.
 269         * language.c (unk_lang_printstr): Update to reflect new encoding
 270         argument to language_defn.
 271         * ada-lang.h (ada_printstr): Likewise.
 272         * c-lang.h (c_printstr): Likewise.
 273         * p-lang.h (pascal_printstr);
 274         * f-lang.c (f_printstr): Likewise.
 275         * m2-lang.c (m2_printstr): Likewise.
 276         * objc-lang.c (objc_printstr): Likewise.
 277         * p-lang.c (pascal_printstr): Likewise.
 278         * scm-lang.c (scm_printstr): Likewise.
 279         * c-valprint.c (c_val_print): Update LA_PRINT_STRING call for
 280         encoding argument.
 281         * ada-valprint.c (ada_printstr): Likewise.
 282         * f-valprint.c (f_val_print): Likewise
 283         * m2-valprint.c (m2_val_print): Likewise.
 284         * p-valprint.c (pascal_val_print): Likewise.
 285         * expprint.c (print_subexp_standard): Likewise.
 286         * valprint.c (val_print_string): Likewise.
 287         * Makefile.in (SUBDIR_PYTHON_OBS): Add py-lazy-string.
 288         (SUBDIR_PYTHON_SRCS): Likewise.
 289         (py-lazy-string.o): New rule.
 290
 291 2010-01-13  Doug Evans  <dje@google.com>
 292
 293         * mi/mi-main.c (list_available_thread_groups): Avoid "may be used
 294         uninitialized" warning from gcc on local `tree'.
 295
 296 2010-01-13  Vladimir Prus  <vladimir@codesourcery.com>
 297
 298         Implement core awareness.
 299
 300         * bcache.c (compare_ints): Remove
 301         (print_percentage): Use compare_positive_ints.
 302         * defs.h (compare_positive_ints): Declare.
 303         * linux-nat.h (struct lin_lwp): New field core.
 304         (linux_nat_core_of_thread_1): Declare.
 305         * linux-nat.c (add_lwp): Init the 'core' field.
 306         (linux_nat_wait_1): Record the core.
 307         (linux_nat_core_of_thread_1, linux_nat_core_of_thread): New.
 308         (linux_nat_add_target): Register the above.
 309         * linux-thread-db.c (update_thread_core): New.
 310         (thread_db_find_new_threads): Update core information for
 311         every thread.
 312         * remote.c (struct private_thread_info): New.
 313         (free_private_thread_info, demand_private_info): New.
 314         (PACKET_qXfer_threads, use_osdata_threads): New.
 315         (struct thread_item, threads_parsing_context
 316         (start_thread, end_thread, thread_attributes)
 317         (thread_children, threads_children, threads_elements): New.
 318         (remote_threads_info): Try qXfer:threads before anything
 319         else.
 320         (remote_protocol_packets): Register qXfer:threads.
 321         (remote_open_1): Init use_osdata_threads.
 322         (struct stop_reply): New field 'core'.
 323         (remote_parse_stop_reply): Parse core number.
 324         (process_stop_reply): Record core number.
 325         (remote_xfer_partial): Handle qXfer:threads.
 326         (remote_core_of_thread): New.
 327         (init_remote_ops): Register remote_core_of_thread.
 328         (_initialize_remote): Register qXfer:read.
 329         * target.c (target_core_of_thread): New
 330         * target.h (enum target_object): New value TARGET_OBJECT_THREADS.
 331         (struct target_ops): New field to_core_of_threads.
 332         (target_core_of_thread): Declare.
 333         * gdbthread.h (struct thread_info): New field private_dtor.
 334         * thread.c (print_thread_info): Report the core.
 335         * ui-out.c (MAX_UI_OUT_LEVELS): Increase.
 336         * utils.c (compare_positive_ints): New.
 337         * features/threads.dtd: New.
 338         * mi/mi-interp.c (mi_on_normal_stop): Report the core.
 339         * mi/mi-main.c (struct collect_cores_data, collect_cores)
 340         (do_nothing, free_vector_of_osdata_items)
 341         (splay_tree_int_comparator, free_splay_tree): New.
 342         (print_one_inferior_data): Implemented printing of selected
 343         inferiors.  Collect and print cores.
 344         (output_cores): New.
 345         (mi_cmd_list_thread_groups): Support --recurse.  Permit specifying
 346         thread groups together with --available.
 347
 348 2010-01-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
 349
 350         * configure: Regenerate (for _STRUCTURED_PROC).
 351
 352 2010-01-12  Joel Brobecker  <brobecker@adacore.com>
 353
 354         Delete dead function.
 355         * ada-lang.c (extract_string): Delete.  No longer used.
 356
 357 2010-01-12  Joel Brobecker  <brobecker@adacore.com>
 358
 359         Fix -Wunused warning in dec-thread.c.
 360         * dec-thread.c (dec_thread_count_gdb_threads)
 361         (dec_thread_add_gdb_thread): Prevent -Wunused warning.
 362
 363 2010-01-12  Joel Brobecker  <brobecker@adacore.com>
 364
 365         * ada-valprint.c (ada_print_floating): Remove trailing space.
 366
 367 2010-01-12  Joel Brobecker  <brobecker@adacore.com>
 368
 369         Add support for DW_AT_GNAT_descriptive_type.
 370         * gdbtypes.h (enum type_specific_kind): New enum.
 371         (struct main_type) [type_specific_field]: New component.
 372         [type_specific]: Add new component "gnat_stuff".
 373         (struct gnat_aux_type): New type.
 374         (INIT_CPLUS_SPECIFIC): Also set TYPE_SPECIFIC_FIELD (type).
 375         (HAVE_CPLUS_STRUCT): Also check TYPE_SPECIFIC_FIELD (type).
 376         (gnat_aux_default, allocate_gnat_aux_type): Add declaration.
 377         (INIT_GNAT_SPECIFIC, ALLOCATE_GNAT_AUX_TYPE, HAVE_GNAT_AUX_INFO)
 378         (TYPE_SPECIFIC_FIELD): New macros.
 379         (TYPE_CPLUS_SPECIFIC): Return cplus_struct_default if the given
 380         type does not hold any cplus-specific data.
 381         (TYPE_RAW_CPLUS_SPECIFIC): New macro.
 382         (TYPE_GNAT_SPECIFIC, TYPE_DESCRIPTIVE_TYPE): New macros.
 383         (TYPE_IS_OPAQUE): Use HAVE_CPLUS_STRUCT to check if type has
 384         cplus-specific data.
 385         * gdbtypes.c (allocate_cplus_struct_type): Minor stylistic rewrite.
 386         Set new component TYPE_SPECIFIC_FIELD (type).
 387         (gnat_aux_default): New constant.
 388         (allocate_gnat_aux_type): New function.
 389         (init_type): Add initialization the type-specific stuff for
 390         TYPE_CODE_FLT and TYPE_CODE_FUNC types.
 391         (print_gnat_stuff): New function.
 392         (recursive_dump_type): Use HAVE_CPLUS_STRUCT to check for cplus-
 393         specific data.  Adjust code that prints the contents of the
 394         type-specific union using the TYPE_SPECIFIC_FIELD value.
 395         * dwarf2read.c (dwarf2_attach_fields_to_type): Do not allocate
 396         the type cplus stuff for Ada types.
 397         (dwarf2_add_member_fn, dwarf2_attach_fn_fields_to_type):
 398         Error out if these routines are called with an Ada type.
 399         (read_structure_type, read_array_type, read_subrange_type):
 400         Add call to set_descriptive_type.
 401         (set_die_type): Initialize the gnat-specific data if necessary.
 402         (need_gnat_info, die_descriptive_type, set_descriptive_type):
 403         New functions.
 404         * ada-lang.c (decode_constrained_packed_array_type): Use
 405         decode_constrained_packed_array_type instead of doing a standard
 406         lookup to locate a parallel type.
 407         (find_parallel_type_by_descriptive_type): New function.
 408         (ada_find_parallel_type_with_name): New function.
 409         (ada_find_parallel_type): Reimplement using
 410         ada_find_parallel_type_with_name.
 411         * ada-valprint.c (print_field_values): Use HAVE_CPLUS_STRUCT
 412         to check if type has a cplus stuff.
 413         * linespec.c (total_number_of_methods): Likewise.
 414         * mdebugread.c (new_type): Likewise.
 415
 416 2010-01-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
 417
 418         * NEWS: Document the 0b binary number prefix parsing.
 419
 420 2010-01-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
 421
 422         * objfiles.c (objfile_relocate1): Change the return type to int.
 423         Describe the new return value.  Return non-zero if data changed.
 424         (objfile_relocate): New variable changed.  Set it.  Call
 425         breakpoint_re_set depending on CHANGED.
 426
 427 2010-01-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
 428
 429         Implement binary numbers parsing.
 430         * c-exp.y (parse_number): New case 'b' and 'B'.
 431
 432 2010-01-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
 433             Tristan Gingold  <gingold@adacore.com>
 434
 435         * solib.c (info_sharedlibrary_command): Replace
 436         objfile_has_partial_symbols and objfile_has_full_symbols calls by
 437         objfile_has_symbols.
 438
 439 2010-01-10  Joel Brobecker  <brobecker@adacore.com>
 440
 441         * NEWS: Document the improvements made to the mips-irix port.
 442
 443 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 444
 445         Fix the documentation of valprint.c:value_print.
 446         * valprint.c (value_print): Update the function description to
 447         mention that the syntax of the output follows the current_language,
 448         not necessarily C.
 449
 450 2010-01-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
 451
 452         Fix displacement of separate debug info files.
 453         * objfiles.c (objfile_relocate): Rename to ...
 454         (objfile_relocate1): ... here and make it static.  Extend the comment.
 455         (objfile_relocate): New function.
 456         * solib-spu.c (spu_relocate_main_executable): Explicitly check if
 457         SYMFILE_OBJFILE is NULL.  Remove variables objfile and old_chain.
 458         Remove following of SEPARATE_DEBUG_OBJFILE.  new_offsets is now
 459         allocated using alloca.
 460         * symfile.c (copy_section_addr_info): Remove.
 461         (build_section_addr_info_from_objfile): Make it global.  New variables
 462         addr_bit and mask, use them.
 463         * symfile.h (build_section_addr_info_from_objfile): New prototype.
 464         (copy_section_addr_info): Remove.
 465
 466 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 467
 468         Signal unwinder for mips-irix N32.
 469         * mips-irix-tdep.c: #include mips-tdep.h, trad-frame.h, and
 470         tramp-frame.h.
 471         (SIGTRAMP_FRAME_SIZE, SIGCONTEXT_PC_OFF, SIGCONTEXT_REGS_OFF)
 472         (SIGCONTEXT_FPREGS_OFF, SIGCONTEXT_FPCSR_OFF, SIGCONTEXT_HI_OFF)
 473         (SIGCONTEXT_LO_OFF): New macros.
 474         (mips_irix_n32_tramp_frame_init): New function.
 475         (mips_irix_n32_tramp_frame): New static constant.
 476         (mips_irix_init_abi): Prepend the mips_irix_n32_tramp_frame unwinder.
 477
 478 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 479
 480         Breakpoint in shared library does not work on mips-irix.
 481         * procfs.c: #include "observer.h".
 482         (procfs_inferior_created): New function, moving here the code
 483         which unsets the syssgi syscall-exit notifications.
 484         (procfs_create_inferior): Remove the code which unsets the syssgi
 485         syscall-exit notifications. It is too early to do this here.
 486         (_initialize_procfs): Attach the procfs_inferior_created observer.
 487
 488 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 489
 490         Wrong return convention for arrays (mips-irix).
 491         * mips-tdep.c (mips_n32n64_return_value): Arrays whose size is
 492         128 bits or smaller are returned the same way as structs
 493         and unions of the the same size.
 494
 495 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 496
 497         Cannot set the PC on mips-irix.
 498         * irix5-nat.c (fill_gregset): Check regno against the raw PC
 499         register number, no the cooked one.
 500
 501 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 502
 503         Error while loading core file on mips-irix.
 504         * solib-irix.c (irix_solib_create_inferior_hook): Do nothing
 505         if debugging from a core file.
 506
 507 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 508
 509         GDB hangs when attaching to process on mips-irix.
 510         * solib-irix.c (irix_solib_create_inferior_hook): Do nothing if
 511         attaching to a process.
 512
 513 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 514
 515         Use the correct breakpoint instruction on mips-irix.
 516         * mips-tdep.c (mips_breakpoint_from_pc): Add new static variable
 517         containing the correct breakpoint instruction to use on mips-irix.
 518         Use it when the osabi is GDB_OSABI_IRIX.
 519
 520 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 521
 522         -Wunused warning in procfs.c (mips-irix only).
 523         * procfs.c (gdb_praddset, gdb_prdelset): New macros.  Use them
 524         throughout instead of using praddset and prdelset respectively.
 525
 526 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 527
 528         GDB crash while stepping into function.
 529         * infrun.c (handle_inferior_event): Refetch the current frame
 530         after handling what.main_action, in case that pointer became
 531         dangling.
 532
 533 2010-01-09  Joel Brobecker  <brobecker@adacore.com>
 534
 535         Fix build failure of solaris-hosted cross debuggers.
 536         * ada-valprint.c, parse.c: Include defs.h before including ctype.h.
 537
 538 2010-01-09  Daniel Gutson  <dgutson@codesourcery.com>
 539
 540         Fix build failure on sparc-solaris.
 541         * procfs.c: (procfs_do_thread_registers) Use elfcore_write_lwpstatus.
 542
 543 2010-01-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
 544
 545         Move some symfile code into subroutines.
 546         * symfile.h (relative_addr_info_to_section_offsets)
 547         (addr_info_make_relative): New prototypes.
 548         * symfile.c (default_symfile_offsets): Move a part to ...
 549         (relative_addr_info_to_section_offsets): ... this new function.
 550         (default_symfile_offsets): Call it.
 551         (syms_from_objfile <!mainline && addrs && addrs->other[0].name>): Move
 552         this part to ...
 553         (addr_info_make_relative): ... this new function.
 554
 555 2010-01-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
 556
 557         Add from_tty to solib_create_inferior_hook.
 558         * infcmd.c (post_create_inferior): Move solib_add after
 559         solib_create_inferior_hook.  Pass from_tty to
 560         solib_create_inferior_hook.  Call solib_add and SOLIB_ADD with
 561         0 from_tty and comment why.
 562         * infrun.c (follow_exec): Pass from_tty solib_create_inferior_hook as 0.
 563         * linux-nat.c (linux_child_follow_fork): Likewise.
 564         * nto-procfs.c (procfs_post_attach, procfs_create_inferior): Likewise.
 565         * solib-darwin.c (darwin_solib_create_inferior_hook): New parameter
 566         from_tty.
 567         * solib-frv.c (frv_solib_create_inferior_hook): Likewise.
 568         * solib-irix.c (irix_solib_create_inferior_hook): Likewise.
 569         * solib-null.c (null_solib_create_inferior_hook): Likewise.
 570         * solib-osf.c (osf_solib_create_inferior_hook): Likewise.
 571         * solib-pa64.c (pa64_solib_create_inferior_hook): Likewise.
 572         * solib-som.c (som_solib_create_inferior_hook): Likewise.
 573         * solib-spu.c (spu_solib_create_inferior_hook): New parameter from_tty.
 574         Pass it to svr4_so_ops.solib_create_inferior_hook.
 575         * solib-sunos.c (sunos_solib_create_inferior_hook): New parameter
 576         from_tty.
 577         * solib-svr4.c (enable_break): New parameter from_tty.  Pass it to
 578         solib_add.
 579         (svr4_solib_create_inferior_hook): New parameter from_tty.  Pass it to
 580         enable_break.
 581         * solib-target.c (solib_target_solib_create_inferior_hook): New
 582         parameter from_tty.
 583         * solib.c (solib_create_inferior_hook): New parameter from_tty.  Pass
 584         it to ops->solib_create_inferior_hook.
 585         (reload_shared_libraries): Pass from_tty to solib_create_inferior_hook.
 586         Move solib_add after solib_create_inferior_hook, call it now with
 587         from_tty as 0.  New comment there.
 588         * solib.h (solib_create_inferior_hook): New parameter from_tty.
 589         * solist.h (struct target_so_ops <solib_create_inferior_hook>):
 590         Likewise.
 591
 592 2010-01-08  Vladimir Prus  <vladimir@codesourcery.com>
 593
 594         Fix multiexec race.
 595         * infrun.c (handle_inferior_event): Use get_thread_regcache
 596         with events ptid, not get_current_regcache.
 597
 598 2009-01-08  Joel Brobecker  <brobecker@adacore.com>
 599
 600         GDB crash with empty executable name (MinGW).
 601         * source.c (openp): Add assert that parameter string is not NULL.
 602         if parameter string is an empty string, then return with a failure
 603         immediately.
 604
 605 2009-01-08  Joel Brobecker  <brobecker@adacore.com>
 606
 607         Get rid of support for VAX Floats.
 608         * ada-lang.h (ada_is_vax_floating_type, ada_vax_float_type_suffix)
 609         (ada_vax_float_print_function): Delete.
 610         * ada-lang.c (ada_is_vax_floating_type, ada_vax_float_type_suffix)
 611         (ada_vax_float_print_function): Delete.
 612         * ada-typeprint.c (print_vax_floating_point_type): Delete.
 613         (ada_print_type): Remove support for VAX floats.
 614         * ada-valprint.c (ada_val_print_1): Remove support for VAX floats.
 615
 616 2010-01-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
 617
 618         * stabsread.c (read_args): Handle zero arguments.
 619
 620 2009-01-08  Joel Brobecker  <brobecker@adacore.com>
 621
 622         Cannot find in-tree libiconv.a after reconfigure.
 623         * acinclude.m4 (AM_ICONV): If we find an in-tree libiconv.a
 624         that we can use, then cache the path to this archive.
 625         * configure: Regenerate.
 626
 627 2010-01-07  Stan Shebs  <stan@codesourcery.com>
 628
 629         Make tracepoint operations go through target vector.
 630         * target.h (enum trace_find_type): New enum.
 631         (struct target_ops): New fields to_trace_init,
 632         to_download_tracepoint, to_download_trace_state_variable,
 633         to_trace_set_readonly_regions, to_trace_start, to_get_trace_status,
 634         to_trace_stop, to_trace_find, to_get_trace_state_variable_value,
 635         to_set_disconnected_tracing.
 636         (target_trace_init): New macro.
 637         (target_download_tracepoint): New macro.
 638         (target_download_trace_state_variable): New macro.
 639         (target_trace_start): New macro.
 640         (target_trace_set_readonly_regions): New macro.
 641         (target_get_trace_status): New macro.
 642         (target_trace_stop): New macro.
 643         (target_trace_find): New macro.
 644         (target_get_trace_state_variable_value): New macro.
 645         (target_set_disconnected_tracing): New macro.
 646         * target.c (update_current_target): Inherit and set defaults for
 647         tracepoint operations.
 648         * tracepoint.c (default_collect): Make globally visible.
 649         (target_is_remote): Remove, along with all calls.
 650         (tvariables_info): Call target_get_trace_state_variable_value.
 651         (remote_set_transparent_ranges): Remove.
 652         (trace_start_command): Call target_trace_init,
 653         target_download_tracepoint, etc.
 654         (download_tracepoint): Remove.
 655         (trace_stop_command): Simplify.
 656         (stop_tracing): Call target_trace_stop.
 657         (get_trace_status): Call target_get_trace_status.
 658         (trace_status_command): Add case for targets that cannot trace.
 659         (finish_tfind_command): Change to take numerical arguments, call
 660         target_trace_find.
 661         (trace_find_command): Update call to finish_tfind_command.
 662         (trace_find_pc_command): Ditto.
 663         (trace_find_tracepoint_command): Ditto.
 664         (trace_find_line_command): Ditto.
 665         (trace_find_range_command): Ditto.
 666         (trace_find_outside_command): Ditto.
 667         (set_disconnected_tracing_value): Call
 668         target_set_disconnected_tracing.
 669         * remote.c: Add protocol encoding bits from tracepoint.c.
 670         (trace_error): Move from tracepoint.c.
 671         (remote_get_noisy_reply): Ditto.
 672         (free_actions_list_cleanup_wrapper): Ditto.
 673         (free_actions_list): Ditto.
 674         (remote_trace_init): New function.
 675         (remote_download_tracepoint): New function.
 676         (remote_download_trace_state_variable): New function.
 677         (remote_trace_set_readonly_regions): New function.
 678         (remote_trace_start): New function.
 679         (remote_get_trace_status): New function.
 680         (remote_trace_stop): New function.
 681         (remote_trace_find): New function.
 682         (remote_download_trace_state_variable): New function.
 683         (remote_set_disconnected_tracing): New function.
 684         (init_remote_ops): Add tracepoint operations.
 685
 686         * tracepoint.c (trace_dump_command): Don't decr_pc_after_break.
 687
 688 2010-01-07  Tristan Gingold  <gingold@adacore.com>
 689
 690         * symfile.c (build_section_addr_info_from_objfile): New function.
 691         (symbol_file_add_separate): Don't use offsets from objfile but
 692         built an addr info.
 693
 694 2010-01-06  Stan Shebs  <stan@codesourcery.com>
 695
 696         Support disconnected tracing.
 697         * infcmd.c (detach_command): Ask whether to stop tracing.
 698         * cli/cli-cmds.c (quit_command): Ditto.
 699         * breakpoint.h (struct breakpoint): New field number_on_target.
 700         * breakpoint.c (create_tracepoint_from_upload): New function.
 701         (get_tracepoint_by_number_on_target): New function.
 702         * remote.c (struct remote): New field disconnected_tracing.
 703         (remote_disconnected_tracing_feature): New function.
 704         (remote_protocol_features): Add DisconnectedTracing.
 705         (struct uploaded_tp): New struct.
 706         (uploaded_tps): New global.
 707         (get_uploaded_tp): New function.
 708         (find_matching_tracepoint): New function.
 709         (remote_get_tracing_state): New function.
 710         (remote_start_remote): Call it.
 711         * tracepoint.c (disconnected_tracing): New global.
 712         (trace_start_command): Initialize number_on_target.
 713         (stop_tracing): New function, split out from...
 714         (trace_stop_command): Call stop_tracing.
 715         (get_trace_status): New function, split out from...
 716         (trace_status_command): Call get_trace_status, add info on
 717         disconnection behavior.
 718         (disconnect_or_stop_tracing): New function.
 719         (finish_tfind_command): Translate from number on target.
 720         (trace_find_tracepoint_command): Translate to number on target.
 721         (send_disconnected_tracing_value): New function.
 722         (set_disconnected_tracing): New function.
 723         (_initialize_tracepoint): Add disconnected-tracing variable.
 724         * NEWS: Mention disconnected tracing.
 725
 726 2010-01-06  Tristan Gingold  <gingold@adacore.com>
 727
 728         * symtab.c (lookup_global_symbol_from_objfile): Rename objfile
 729         parameter to main_objfile.  Iterate on all separate debug objfiles.
 730         * symfile.h (symbol_file_add_separate)
 731         (find_separate_debug_file_by_debuglink): Remove parameter names.
 732         * symfile.c (symbol_file_add_separate): Use add_separate_objfile.
 733         (reread_symbols): Use free_objfile_separate_debug.
 734         * objfiles.h (struct objfile): Add separate_debug_objfile_link.
 735         Adjust comment.
 736         (objfile_separate_debug_iterate, add_separate_debug_objfile)
 737         (free_objfile_separate_debug): New prototypes.
 738         * objfiles.c (objfile_separate_debug_iterate): New function.
 739         (add_separate_debug_objfile, free_objfile_separate_debug): New
 740         functions.
 741         (free_objfile): Use free_objfile_separate_debug.  Adjust for
 742         multiple separate debug objfile.
 743         (objfile_has_symbols): Adjust comment.  Iterate on all separate
 744         debug objfiles.
 745         * minsyms.c (lookup_minimal_symbol): Adjust for multiple separate
 746         debug objfile.
 747         (lookup_minimal_symbol_text): Ditto.
 748         (lookup_minimal_symbol_by_pc_name): Ditto.
 749         (lookup_minimal_symbol_solib_trampoline): Ditto.
 750         (lookup_minimal_symbol_by_pc_section_1): Iterate on all separate
 751         debug objfiles.
 752
 753 2010-01-05  Stan Shebs  <stan@codesourcery.com>
 754
 755         Add fast tracepoints.
 756         * arch-utils.h (default_fast_tracepoint_valid_at): Declare.
 757         * arch-utils.c (default_fast_tracepoint_valid_at): New function.
 758         * breakpoint.h (enum bptype): Add bp_fast_tracepoint.
 759         * breakpoint.c (tracepoint_type): New function.
 760         (ALL_TRACEPOINTS): Use it.
 761         (should_be_inserted): Ditto.
 762         (bpstat_check_location): Ditto.
 763         (print_one_breakpoint_location): Ditto.
 764         (user_settable_breakpoint): Ditto.
 765         (set_breakpoint_location_function): Ditto.
 766         (disable_breakpoints_in_shlibs): Ditto.
 767         (delete_trace_command): Ditto.
 768         (print_it_typical): Add bp_fast_tracepoint case.
 769         (bpstat_what): Ditto.
 770         (print_one_breakpoint_location): Ditto.
 771         (allocate_bp_location): Ditto.
 772         (mention): Ditto.
 773         (breakpoint_re_set_one): Ditto.
 774         (disable_command): Ditto.
 775         (enable_command): Ditto.
 776         (check_fast_tracepoint_sals): New function.
 777         (break_command_really): Call it.
 778         (ftrace_command): New function.
 779         (_initialize_breakpoint): Add ftrace command.
 780         * gdbarch.sh (fast_tracepoint_valid_at): New.
 781         * gdbarch.h, gdbarch.c: Regenerate.
 782         * i386-tdep.c (i386_fast_tracepoint_valid_at): New function.
 783         (i386_gdbarch_init): Use it.
 784         * remote.c (struct remote_state): New field fast_tracepoints.
 785         (PACKET_FastTracepoints): New packet config type.
 786         (remote_fast_tracepoint_feature): New function.
 787         (remote_protocol_features): Add FastTracepoints.
 788         (remote_supports_fast_tracepoints): New function.
 789         (_initialize_remote): Add FastTracepoints.
 790         * tracepoint.c (download_tracepoint): Add fast tracepoint option.
 791         * NEWS: Mention fast tracepoints.
 792
 793 2010-01-06  Joel Brobecker  <brobecker@adacore.com>
 794
 795         * gdb-gdb.py: New file.
 796
 797 2010-01-05  Michael Snyder  <msnyder@vmware.com>
 798
 799         * infrun.c (handle_inferior_event): Fix typo in comment.
 800
 801 2010-01-05  Jan Kratochvil  <jan.kratochvil@redhat.com>
 802
 803         * symfile.c (syms_from_objfile): Remove the !MAINLINE conditional.
 804
 805 2010-01-04  Ulrich Weigand  <uweigand@de.ibm.com>
 806
 807         * features/Makefile (WHICH): Add s390-linux32, s390-linux64,
 808         and s390x-linux64.
 809         (s390-linux32-expedite): Define.
 810         (s390-linux64-expedite): Define.
 811         (s390x-linux64-expedite): Define.
 812         * features/s390-acr.xml: New file.
 813         * features/s390-fpr.xml: New file.
 814         * features/s390-core32.xml: New file.
 815         * features/s390-core64.xml: New file.
 816         * features/s390x-core64.xml: New file.
 817         * features/s390-linux32.xml: New file.
 818         * features/s390-linux64.xml: New file.
 819         * features/s390x-linux64.xml: New file.
 820         * features/s390-linux32.c: New generated file.
 821         * features/s390-linux64.c: New generated file.
 822         * features/s390x-linux64.c: New generated file.
 823
 824         * regformats/s390-linux32.dat: New generated file.
 825         * regformats/s390-linux64.dat: New generated file.
 826         * regformats/s390x-linux64.dat: New generated file.
 827         * regformats/reg-s390.dat: Remove.
 828         * regformats/reg-s390x.dat: Remove.
 829
 830         * s390-nat.c: Include "auxv.h" and <elf.h>.
 831         (HWCAP_S390_HIGH_GPRS): Define if undefined.
 832         (s390_target_wordsize): New function.
 833         (s390_auxv_parse): Likewise.
 834         (s390_get_hwcap): Likewise.
 835         (s390_read_description): Likewise.
 836         (_initialize_s390_nat): Install s390_auxv_parse and
 837         s390_read_description.
 838
 839         * s390-tdep.c: Include "features/s390-linux32.c",
 840         "features/s390-linux64.c", and "features/s390x-linux64.c".
 841         (struct gdbarch_tdep): Add gpr_full_regnum, pc_regnum, and cc_regnum.
 842         (s390_register_call_saved): New function.
 843         (s390_register_name): Remove.
 844         (s390_register_type): Remove.
 845         (s390_dwarf_regmap): Add lower half GPR pseudo DWARF CFI regnums.
 846         (s390_dwarf_reg_to_regnum): Remap GPR regnums to full GPRs.
 847         (s390_adjust_frame_regnum): Remap GPR regnums to lower halves for CFI.
 848         (s390_pseudo_register_name): New function.
 849         (s390_pseudo_register_type): New function.
 850         (s390_pseudo_register_read): Handle both 32-bit and 64-bit cases.
 851         Handle full GPR pesudos and varying pseudo register numbers.
 852         (s390_pseudo_register_write): Likewise
 853         (s390x_pseudo_register_read): Remove.
 854         (s390x_pseudo_register_write): Likewise.
 855         (s390_register_group): Remove.
 856         (s390_pseudo_register_group): New function.
 857         (s390_regmap_gregset): Add GPR upper halves.
 858         (s390x_regmap_gregset): Likewise.
 859         (s390_regmap_fpregset): Likewise.
 860         (s390_regmap_upper): New global variable.
 861         (s390_upper_regset): New global variable.
 862         (s390_upper_regset_sections): New global variable.
 863         (s390_regset_from_core_section): Handle GPR upper halves.
 864         (s390_core_read_description): New function.
 865         (s390_prologue_frame_unwind_cache): Set up ABI call-saved/clobbered
 866         register information.  Handle varying pseudo register numbers.
 867         (s390_backchain_frame_unwind_cache): Likewise.
 868         (s390_frame_prev_register): Unwind full GPRs to show lower halves.
 869         (s390_stub_frame_unwind_cache): Handle varying pseudo register numbers.
 870         (s390_sigtramp_frame_unwind_cache): Unwind PSWM and PSWA as well as
 871         PC and CC pseudos.  Unwind upper halves and full GPRs as appropriate.
 872         Handle varying pseudo register numbers.
 873         (s390_unwind_pc): Handle varying pseudo register numbers.
 874         (s390_dwarf2_prev_register): New function.
 875         (s390_dwarf2_frame_init_reg): Set up ABI call-saved/clobbered
 876         register information.  Handle varying pseudo register numbers.
 877         Install s390_dwarf2_prev_register to unwind full GPRs.
 878         (s390_gdbarch_init): Handle target descriptions.  Assign varying
 879         pseudo register numbers.  Install s390_adjust_frame_regnum.
 880         (_initialize_s390_tdep): Initialize target descriptions.
 881
 882         * s390-tdep.h (S390_R0_UPPER_REGNUM .. S390_R15_UPPER_REGNUM): Define.
 883         (S390_NUM_REGS): Redefine to include upper half registers.
 884         (S390_PC_REGNUM, S390_CC_REGNUM): Remove.
 885         (S390_NUM_PSEUDO_REGS, S390_NUM_TOTAL_REGS): Likewise.
 886         (tdesc_s390_linux32): Add declaration.
 887         (tdesc_s390_linux64): Likewise.
 888         (tdesc_s390x_linux64): Likewise.
 889
 890 2010-01-04  Ulrich Weigand  <uweigand@de.ibm.com>
 891
 892         * regset.h (struct core_regset_section): Add HUMAN_NAME.
 893         * i386-linux-tdep.c (i386_linux_regset_sections): Fill in HUMAN_NAME.
 894         * ppc-linux-tdep.c (ppc_linux_vsx_regset_sections): Likewise.
 895         (ppc_linux_vmx_regset_sections): Likewise.
 896         (ppc_linux_fp_regset_sections): Likewise.
 897
 898         * corelow.c (get_core_register_section): Constify arguments.
 899         (get_core_registers): Use gdbarch_core_regset_sections instead
 900         of hard-coded platform-specific register section names.
 901
 902 2010-01-04  Ulrich Weigand  <uweigand@de.ibm.com>
 903
 904         * dwarf2loc.c (read_pieced_value): If a piece occupies part of
 905         a register, assume the least-significant part is used.
 906         (write_pieced_value): Likewise.
 907
 908 2010-01-04  Ulrich Weigand  <uweigand@de.ibm.com>
 909
 910         * printcmd.c: Include "arch-utils.h".
 911         (do_one_display): Re-parse expression if current architecture changed.
 912
 913 2010-01-03  Jan Kratochvil  <jan.kratochvil@redhat.com>
 914             Joel Brobecker  <brobecker@adacore.com>
 915
 916         * gdbtypes.c (check_typedef): New comment on type length.
 917         * value.c (allocate_value_lazy): Remove the unused atype variable.  New
 918         comment on type length.
 919         (value_primitive_field): Keep the original TYPE value, new comment.
 920
 921 2010-01-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 922
 923         * cli/cli-script.c (process_next_line): Rename p1 as p_end and p2 as
 924         p_start.  Change != comparisons to > and < comparisons.
 925
 926 2010-01-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 927
 928         * cli/cli-script.c (process_next_line): Check P2 overrun.
 929
 930 2009-01-01  Joel Brobecker  <brobecker@adacore.com>
 931
 932         Update the copyright hearder to add year 2010 for most GDB files.
 933
 934 2009-01-01  Joel Brobecker  <brobecker@adacore.com>
 935
 936         Fix build failure in inf-ptrace.c.
 937         * inf-ptrace.c (inf_ptrace_follow_fork): Fix typo.
 938
 939 2010-01-01  Joel Brobecker  <brobecker@adacore.com>
 940
 941         * top.c (print_gdb_version): Update copyright year.
 942
 943 2010-01-01  Joel Brobecker  <brobecker@adacore.com>
 944
 945         Fix break *FUN'address thread NUM.
 946         * ada-lex.l (task): Expand rule to also match the thread keyword.
 947
 948 2010-01-01  Joel Brobecker  <brobecker@adacore.com>
 949
 950         Fix break *FUN'address task NUM.
 951         * ada-lex.l (task): New rule.
 952         * ada-lang.c (valid_task_id): Make sure the Ada task list has
 953         been built before using it.
 954
 955 For older changes see ChangeLog-2009.
 956 \f
 957 Local Variables:
 958 mode: change-log
 959 left-margin: 8
 960 fill-column: 74
 961 version-control: never
 962 coding: utf-8
 963 End: