ld/ChangeLog

   1 2015-04-09  H.J. Lu  <hongjiu.lu@intel.com>
   2
   3         * emulparams/elf_x86_64.sh (BNDPLT): Removed.
   4         (PARSE_AND_LIST_OPTIONS): New.
   5         (PARSE_AND_LIST_ARGS_CASE_Z): Likewise.
   6         * emultempl/elf32.em (gld${EMULATION_NAME}_handle_option): Remove
   7         BNDPLT check.  Handle PARSE_AND_LIST_ARGS_CASE_Z.
   8         (gld${EMULATION_NAME}_list_options): Remove BNDPLT check.
   9
  10 2015-04-09  Nick Clifton  <nickc@redhat.com>
  11
  12         * po/fr.po: Updated French translation.
  13
  14 2015-04-08  H.J. Lu  <hongjiu.lu@intel.com>
  15
  16         * configure.ac (elf_list_options): Set to TRUE for
  17         --enable-targets=all.
  18         (elf_shlib_list_options): Likewise.
  19         (elf_plt_unwind_list_options): Likewise.
  20         * configure: Regenerated.
  21
  22 2015-04-08  H.J. Lu  <hongjiu.lu@intel.com>
  23
  24         * emulparams/elf32bmipn32-defs.sh: Skip empty EMULATION_NAME.
  25
  26 2015-04-08  H.J. Lu  <hongjiu.lu@intel.com>
  27
  28         * Makefile.am (ELF_CLFAGS): New.
  29         (AM_CFLAGS): Add $(ELF_CLFAGS).
  30         * configure.ac (elf_list_options): New.  AC_SUBST.
  31         (elf_shlib_list_options): Likewise.
  32         (elf_plt_unwind_list_options): Likewise.
  33         * lexsup.c (elf_shlib_list_options): New.
  34         (elf_static_list_options): Likewise.
  35         (elf_plt_unwind_list_options): Likewise.
  36         (ld_list_options): Likewise.
  37         (help): Call ld_list_options.
  38         * Makefile.in: Regenerated.
  39         * configure: Likewise.
  40         * emulparams/plt_unwind.sh (PLT_UNWIND): New.
  41         (PARSE_AND_LIST_OPTIONS): Removed.
  42         * emultempl/elf32.em (gld_list_options): New.
  43         (gld${EMULATION_NAME}_list_options): Define only if BNDPLT or
  44         PARSE_AND_LIST_OPTIONS is defined.
  45         (ld_${EMULATION_NAME}_emulation): Replace
  46         gld${EMULATION_NAME}_list_options with ${gld_list_options.
  47
  48 2015-04-07  Alan Modra  <amodra@gmail.com>
  49
  50         PR ld/18176
  51         * ldlang.c (lang_size_sections): Cast shift expression.
  52
  53 2015-04-07  Alan Modra  <amodra@gmail.com>
  54
  55         * emultempl/ppc32elf.em: Handle --no-pic-fixup.
  56         (params): Init new field.
  57         (ppc_before_allocation): Enable relaxation for pic_fixup.
  58
  59 2015-04-07  Nick Clifton  <nickc@redhat.com>
  60
  61         * ld.h (struct ld_config_type): Add new field: warn_orphan.
  62         * ldlex.h (enum option_values): Add OPTION_WARN_ORPHAN and
  63         OPTION_NO_WARN_ORPHAN.
  64         * lexsup.c (ld_options): Add --warn-orphan and --no-warn-orphan.
  65         (parse_args): Handle the new options.
  66         * ldemul.c (ldemul_place_orphan): If requested, generate a warning
  67         message when an orphan section is placed in the output file.
  68         * ld.texinfo: Document the new option.
  69         * NEWS: Mention the new feature.
  70
  71 2015-04-02  Andrew Turner <andrew@freebsd.org>
  72
  73         * Makefile.am: Add FreeBSD aarch64 files.
  74         * Makefile.in: Regenerate.
  75         * configure.tgt: Add aarch64-*-freebsd* target triple.
  76         * emulparams/aarch64fbsd.sh: New file.
  77         * emulparams/aarch64fbsdb.sh: New file.
  78
  79 2015-04-01  H.J. Lu  <hongjiu.lu@intel.com>
  80
  81         * emultempl/elf32.em (gld${EMULATION_NAME}_before_allocation): Work
  82         around a GCC uninitialized warning bug fixed in GCC 4.6.
  83
  84 2015-04-01  Tejas Belagod  <tejas.belagod@arm.com>
  85
  86         * emultempl/aarch64elf.em
  87         (aarch64_elf_create_output_section_statements): Add parameter in
  88         bfd_elf${ELFSIZE}_aarch64_set_options call.
  89         (OPTION_FIX_ERRATUM_843419): Define.
  90         (PARSE_AND_LIST_LONGOPTS): Add fix-cortex-a53-843419.
  91         (PARSE_AND_LIST_ARGS_CASES): Add OPTION_FIX_ERRATUM_843419.
  92
  93 2015-04-01  Chen Gang  <gang.chen.5i5j@gmail.com>
  94
  95         * emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for
  96         relocating operation.
  97
  98 2015-04-01  Alan Modra  <amodra@gmail.com>
  99
 100         PR ld/18176
 101         * ldlang.c (lang_size_sections): When alignment of sections
 102         results in relro base adjustment being too large, don't go lower
 103         than the initial value.
 104         * ldexp.c (fold_binary <DATA_SEGMENT_RELRO_END>): Comment.
 105         * scripttempl/elf.sc (DATA_SEGMENT_ALIGN): Omit SEGMENT_SIZE
 106         alignment when SEGMENT_SIZE is the same as MAXPAGESIZE.
 107
 108 2015-04-01  Alan Modra  <amodra@gmail.com>
 109
 110         * emultempl/elf32.em (gld${EMULATION_NAME}_before_allocation): Don't
 111         init ehdr_start_save.
 112
 113 2015-04-01  Alan Modra  <amodra@gmail.com>
 114
 115         * Makefile.am (eelf32ppcvxworks.c): Depend on ppc32elf.em and
 116         ldemul-list.h.
 117         (eelf32lppc.c, eelf32lppclinux.c, eelf32lppcnto.c, eelf32lppcsim.c,
 118         eelf32ppc.c, eelf32ppc_fbsd.c, eelf32ppclinux.c, eelf32ppcnto.c,
 119         eelf32ppcsim.c): Rearrange deps for consistency.
 120         * Makefile.in: Regenerate.
 121
 122 2015-04-01  Ed Schouten  <ed@nuxi.nl>
 123
 124         * emultempl/elf32.em (gld*_before_allocation): Zero-initialize
 125         the ehdr_start_save variable.
 126
 127 2015-03-31  Ed Schouten  <ed@nuxi.nl>
 128
 129         * Makefile.am (ALL_64_EMULATION_SOURCES): Add
 130         eelf_x86_64_cloudabi.c.
 131         (eelf_x86_64_cloudabi.c): New.
 132         * configure.tgt (targ_emul): Set to elf_x86_64_cloudabi for
 133         x86_64-*-cloudabi*.
 134         * Makefile.in: Regenerated.
 135         * emulparams/elf_x86_64_cloudabi.sh: New file.
 136
 137 2015-03-31  H.J. Lu  <hongjiu.lu@intel.com>
 138
 139         * configure.ac (AM_ZLIB): Removed.
 140         * Makefile.in: Regenerated.
 141         * config.in: Likewise.
 142         * configure: Likewise.
 143
 144 2015-03-24  Marcus Shawcroft  <marcus.shawcroft@arm.com>
 145
 146         * emultempl/aarch64elf.em (_aarch64_add_stub_section): Set section
 147         alignment to 2.
 148
 149 2015-03-23  Marcus Shawcroft  <marcus.shawcroft@arm.com>
 150
 151         * emultempl/aarch64elf.em
 152         (elf${ELFSIZE}_aarch64_add_stub_section): Adjust layout.
 153
 154 2015-03-18  Chen Gang  <gang.chen.5i5j@gmail.com>
 155
 156         * ldmain.c (main): Use %F instead of %X for einfo.
 157
 158 2015-03-02  Alan Modra  <amodra@gmail.com>
 159
 160         * ld.texinfo (Options <-z nocopyreloc>): Rewrite.
 161
 162 2015-02-27  Nick Clifton  <nickc@redhat.com>
 163
 164         PR ld/17900
 165         * ldlang.c (lang_set_flags): Allow exclamation mark to reverse the
 166         sense of the following memory region attribute characters.
 167
 168 2015-02-27  Alan Modra  <amodra@gmail.com>
 169
 170         * Makefile.am (ALL_EMULATION_SOURCES): Sort new h8300 entries.
 171         (eh8300elf_linux.c, eh8300helf_linux.c, eh8300self_linux.c,
 172         eh8300sxelf_linux.c): Do not invoke genscripts here.
 173         * Makefile.in: Regenerate.
 174
 175 2015-02-24  Nick Clifton  <nickc@redhat.com>
 176
 177         * Makefile.am (ev850.c): Add dependency upon
 178         $(srcdir)/emultempl/v850elf.em.
 179         (ev850_rh850.c): Likewise.
 180         * Makefile.in: Regenerate.
 181         * emultempl/v850elf.em: New file.
 182         * emulparams/v850.sh (EXTRA_EM_FILE): Define.
 183         * emulparams/v850_rh850.sh (EXTRA_EM_FILE): Define.
 184         * scripttempl/v850.sc: Add .note.renesas section.
 185         * scripttempl/v850_rh850.sc: Likewise.
 186
 187 2015-02-24  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
 188
 189         * scripttempl/avr.sc: Add new user_signatures region.  Define and
 190         use symbols for all region lengths.
 191         * scripttempl/avrtiny.sc: Define and use symbols for all region
 192         lengths.
 193
 194 2015-01-21  Yoshinori Sato <ysato@users.sourceforge.jp>
 195
 196         * Makefile.am: (ALL_EMULATION_SOURCES): Add new emulations.
 197         * Makefile.in: Regenerate.
 198         * configure.tgt: Add h8300-*-linux
 199         * emulparams/h8300elf_linux.sh: Add new emulation.
 200         * emulparams/h8300helf_linux.sh: Likewise.
 201         * emulparams/h8300self_linux.sh: Likewise.
 202         * emulparams/h8300sxelf_linux.sh: Likewise.
 203
 204 2015-02-23  Nick Clifton  <nickc@redhat.com>
 205
 206         * lexsup.c (parse_args): Produce a more reasonable error message
 207         when -ixxx or -rxxx is the last option on the linker command line.
 208
 209 2015-02-14  H.J. Lu  <hongjiu.lu@intel.com>
 210
 211         PR ld/17973
 212         * testplug2.c (allsymbolsread_silent): New.
 213         (set_register_hook): Handle allsymbolsreadsilent.
 214         (onall_symbols_read): Skip a message if allsymbolsread_silent is
 215         TRUE.
 216
 217 2015-02-14  Alan Modra  <amodra@gmail.com>
 218
 219         PR ld/17973
 220         * ldlang.h (struct lang_input_statement_flags): Add lto_output.
 221         * ldlang.c (lang_process): Don't set loading_lto_outputs.
 222         * ldfile.c (ldfile_try_open_bfd): Transfer entry flags.lto_output
 223         to bfd.
 224         * plugin.c (add_input_file, add_input_library): Set flags.lto_output.
 225
 226 2015-02-13  H.J. Lu  <hongjiu.lu@intel.com>
 227
 228         * NEWS: Mention support for LLVM plugin.
 229
 230 2015-02-13  Alan Modra  <amodra@gmail.com>
 231
 232         * ld.texinfo (Options <--defsym>): Correct cross reference.
 233
 234 2015-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 235
 236         * lexsup.c (ld_options): Add --[no-]map-whole-files for gold
 237         option compatibility.
 238
 239 2015-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 240
 241         * plugin.c (message): Output "warning:" for LDPL_WARNING. Output
 242         "error:" for LDPL_FATAL and LDPL_ERROR.
 243         * testplug2.c (parse_option): Handle fatal, error and warning.
 244
 245 2015-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 246
 247         * testplug2.c (dump_tv_tag): Removed.
 248         (onall_symbols_read): Return LDPS_ERR if the file descriptor isn't
 249         closed.
 250         * testplug3.c (dump_tv_tag): Removed.
 251         (onclaim_file): Fix typo.
 252
 253 2015-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 254
 255         PR ld/17878
 256         * Makefile.am (noinst_LTLIBRARIES): Add libldtestplug2.la and
 257         libldtestplug3.la.
 258         (libldtestplug2_la_SOURCES): New.
 259         (libldtestplug2_la_CFLAGS): Likewise.
 260         (libldtestplug2_la_LDFLAGS): Likewise.
 261         (libldtestplug3_la_SOURCES): New.
 262         (libldtestplug3_la_CFLAGS): Likewise.
 263         (libldtestplug3_la_LDFLAGS): Likewise.
 264         * Makefile.in: Regenerated.
 265         * testplug2.c: New file.
 266         * testplug3.c: Likewise.
 267
 268 2015-02-11  H.J. Lu  <hongjiu.lu@intel.com>
 269
 270         PR ld/17878
 271         * plugin.c: Include ../bfd/plugin.h.
 272         (plugin_get_ir_dummy_bfd): Call bfd_create with
 273         link_info.output_bfd instead of srctemplate.  Copy BFD info
 274         from srctemplate only if it doesn't use BFD plugin target
 275         vector.
 276         (plugin_load_plugins): Call register_ld_plugin_object_p with
 277         (plugin_object_p)
 278         (plugin_maybe_claim): Renamed to ...
 279         (plugin_object_p): This.  Return dummy BFD target vector if
 280         input is calimed by plugin library, otherwise return NULL.
 281         Update plugin_format and plugin_dummy_bfd.
 282         (plugin_maybe_claim): New.  Use plugin_object_p.
 283
 284 2015-02-10  H.J. Lu  <hongjiu.lu@intel.com>
 285
 286         * plugin.c (plugin_maybe_claim): Initialize use_mmap.
 287
 288 2015-02-10  H.J. Lu  <hongjiu.lu@intel.com>
 289
 290         * plugin.c (plugin_input_file_t): Add use_mmap.
 291         (plugin_pagesize): New.
 292         (get_view): Use plugin_pagesize.  Set use_mmap if mmap is used.
 293         (plugin_load_plugins): Initialize plugin_pagesize.
 294         (plugin_maybe_claim): Unmap the buffer if plugin didn't claim the
 295         file.
 296
 297 2015-02-10  H.J. Lu  <hongjiu.lu@intel.com>
 298
 299         * plugin.c (get_view): Align offset passed to mmap.
 300
 301 2015-02-08  H.J. Lu  <hongjiu.lu@intel.com>
 302
 303         * ldfile.c (ldfile_try_open_bfd): Don't call bfd_check_format
 304         if plugin isn't active or there is no thing more to claim.
 305
 306 2015-02-08  H.J. Lu  <hongjiu.lu@intel.com>
 307
 308         * plugin.c (plugin_maybe_claim): Check format against bfd_object
 309         directly.
 310
 311 2015-02-07  H.J. Lu  <hongjiu.lu@intel.com>
 312
 313         * plugin.c (plugin_maybe_claim): Replace entry->the_bfd with
 314         ibfd.
 315
 316 2015-02-07  H.J. Lu  <hongjiu.lu@intel.com>
 317
 318         * plugin.c: Include "libbfd.h".
 319         (plugin_strdup): New.
 320         (plugin_maybe_claim): Remove the argument of pointer to struct
 321         ld_plugin_input_file.  Open and handle input entry.
 322         * plugin.h (plugin_maybe_claim): Updated.
 323         * ldfile.c (ldfile_try_open_bfd): Call plugin_maybe_claim directly
 324         without passing a pointer to struct ld_plugin_input_file.
 325         * ldmain.c: Don't include "libbfd.h".
 326         (add_archive_element): Call plugin_maybe_claim directly without
 327         passing a pointer to struct ld_plugin_input_file.
 328
 329 2015-02-06  H.J. Lu  <hongjiu.lu@intel.com>
 330
 331         * ld.texinfo: Document -z text, -z notext and -z textoff.
 332         * emultempl/elf32.em (gld${EMULATION_NAME}_list_options): Add
 333         -z text, -z notext and -z textoff.
 334
 335 2015-02-06  H.J. Lu  <hongjiu.lu@intel.com>
 336
 337         * configure.ac: Add AC_FUNC_MMAP.
 338         * config.in: Regenerated.
 339         * configure: Likewise.
 340         * plugin.c: Include <sys/mman.h>.
 341         (MAP_FAILED): New.  Defined if not defined.
 342         (PROT_READ): Likewise.
 343         (MAP_PRIVATE): Likewise.
 344         (view_buffer_t): New.
 345         (plugin_input_file_t): Add view_buffer.
 346         (get_view): Try mmap and cache the view buffer.
 347         (plugin_maybe_claim): Initialize view_buffer.
 348
 349 2015-02-05  H.J. Lu  <hongjiu.lu@intel.com>
 350
 351         * plugin.c (release_input_file): Set fd to -1 after closing it.
 352         (plugin_maybe_claim): Close fd only if fd != -1.
 353
 354 2015-02-05  H.J. Lu  <hongjiu.lu@intel.com>
 355
 356         PR ld/17878
 357         * plugin.c: Include <errno.h>.
 358         (errno): New.  Declare if needed.
 359         (plugin_input_file_t): New.
 360         (get_input_file): Implemented.
 361         (get_view): Likewise.
 362         (release_input_file): Likewise.
 363         (add_symbols): Updated.
 364         (get_symbols): Likewise.
 365         (plugin_maybe_claim): Allocate a plugin_input_file_t.  Close fd
 366         only for a bfd_object input.
 367
 368 2015-02-02  Alan Modra  <amodra@gmail.com>
 369
 370         * emultempl/ppc64elf.em (toc_section_name): New var.
 371         (ppc_after_open): Set it.
 372         (ppc_before_allocation): Use it.
 373         (gld${EMULATION_NAME}_after_allocation): Here too.
 374
 375 2015-01-29  H.J. Lu  <hongjiu.lu@intel.com>
 376
 377         * ldfile.c (ldfile_try_open_bfd): Replace plugin_active_plugins_p()
 378         with link_info.lto_plugin_active.
 379         * ldlang.c (lang_process): Likewise.
 380         * ldmain.c (add_archive_element): Likewise.
 381         * plugin.c (plugin_active_plugins_p): Removed.
 382         * plugin.h (plugin_active_plugins_p): Likewise.
 383
 384 2015-01-28  H.J. Lu  <hongjiu.lu@intel.com>
 385
 386         * plugin.h (plugin_get_ir_dummy_bfd): Removed.  Move comments to
 387         ...
 388         * plugin.c (plugin_get_ir_dummy_bfd): Here.  Make it static.
 389
 390 2015-01-28  H.J. Lu  <hongjiu.lu@intel.com>
 391
 392         PR ld/17878
 393         * plugin.c (tv_header_tags(): Add LDPT_GET_VIEW.
 394         (get_view): New function.
 395         (set_tv_header): Handle LDPT_GET_VIEW.
 396         * testplug.c (tag_names): Add LDPT_GET_VIEW.
 397         (tv_get_view): New.
 398         (dump_tv_tag): Handle LDPT_GET_VIEW.
 399         (parse_tv_tag): Likewise.
 400
 401 2015-01-28  Alan Modra  <amodra@gmail.com>
 402
 403         * emulparams/elf64ppc.sh (INITIAL_READWRITE_SECTIONS): Define.
 404         * emultempl/ppc64elf.em (params): Init new field.
 405         (ppc_after_open): New function.
 406         (LDEMUL_AFTER_OPEN): Define.
 407         * ldlang.c (lang_final): Whitespace fix.
 408
 409 2015-01-28  James Bowman  <james.bowman@ftdichip.com>
 410
 411         * Makefile.am: Add FT32 files.
 412         * configure.tgt: Handle FT32 target.
 413         * emulparams/elf32ft32.sh: New file.
 414         * scripttempl/ft32.sc: New file.
 415         * Makefile.in: Regenerate.
 416
 417 2015-01-28  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
 418
 419         PR 4643
 420         * ldexp.c (fold_name): Fold LENGTH only after
 421         lang_first_phase_enum.
 422         * ldgram.y (memory_spec): Don't evaluate ORIGIN and LENGTH
 423         rightaway.
 424         * ldlang.h (struct memory_region_struct): Add origin_exp and
 425         length_exp fields.
 426         * ldlang.c (lang_do_memory_regions): New.
 427         (lang_memory_region_lookup): Initialize origin_exp and
 428         length_exp fields.
 429         (lang_process): Call lang_do_memory_regions.
 430
 431 2015-01-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * ldlang.c (print_assignment): Only evaluate the expression for a
 434         PROVIDE'd assignment when the destination is being defined.
 435         Display a special message for PROVIDE'd symbols that are not being
 436         provided.
 437
 438 2015-01-20  Alan Modra  <amodra@gmail.com>
 439
 440         * emulparams/elf64ppc.sh (OTHER_SDATA_SECTIONS): Use in place of..
 441         (OTHER_BSS_SYMBOLS): ..this.
 442         (OTHER_PLT_RELOC_SECTIONS): Don't define.
 443         (OTHER_GOT_RELOC_SECTIONS): Add rela.toc1 and rela.tocbss.
 444         (OTHER_READWRITE_SECTIONS): Don't define.  Move .toc1 to..
 445         (OTHER_RELRO_SECTIONS_2): ..here.
 446         * scripttempl/elf.sc: Move SBSS too when DATA_SDATA.
 447
 448 2015-01-20  Alan Modra  <amodra@gmail.com>
 449
 450         * emulparams/elf64ppc.sh (BSS_PLT): Don't define.
 451         (OTHER_READWRITE_SECTIONS): Move .branch_lt to..
 452         (OTHER_RELRO_SECTIONS_2): ..here.
 453         (DATA_GOT, SEPARATE_GOTPLT, DATA_SDATA, DATA_PLT,
 454         PLT_BEFORE_GOT): Define.
 455         * scripttempl/elf.sc: Handle DATA_SDATA and DATA_GOT/DATA_PLT/
 456         PLT_BEFORE_GOT combination.
 457         (DATA_GOT, SDATA_GOT): Don't define if either is already defined.
 458
 459 2015-01-20  Alan Modra  <amodra@gmail.com>
 460
 461         * emulparams/elf64ppc.sh (OTHER_READWRITE_SECTIONS): Move .opd to..
 462         (OTHER_RELRO_SECTIONS_2): ..here, new define.
 463         * scripttempl/elf.sc: Add OTHER_RELRO_SECTIONS_2.
 464
 465 2015-01-19  Alan Modra  <amodra@gmail.com>
 466
 467         PR ld/17615
 468         * ldlang.c (lang_process): Run lang_common before lang_gc_sections.
 469
 470 2015-01-14  Jiong Wang  <jiong.wang@arm.com>
 471
 472         * ld-arm/elf32-reject.s: New testcase.
 473         * ld-arm/elf32-reject.d: Likewise.
 474         * ld-arm/elf32-reject-pie.s: Likewise.
 475         * ld-arm/elf32-reject-pie.d: Likewise.
 476         * ld-arm/arm-elf.exp: Run new testcases.
 477         * ld-arm/ifunc-7.s: Delete f2/f4 test items.
 478         * ld-arm/ifunc-7.rd: Likewise.
 479         * ld-arm/ifunc-7.gd: Likewise.
 480         * ld-arm/ifunc-7.dd: Likewise.
 481         * ld-arm/ifunc-8.s: Likewise.
 482         * ld-arm/ifunc-8.rd: Likewise.
 483         * ld-arm/ifunc-8.gd: Likewise.
 484         * ld-arm/ifunc-8.dd: Likewise.
 485
 486 2015-01-01  Alan Modra  <amodra@gmail.com>
 487
 488         * ldver.c (ldversion): Just print current year.
 489
 490 2015-01-01  Alan Modra  <amodra@gmail.com>
 491
 492         Update year range in copyright notice of all files.
 493
 494 For older changes see ChangeLog-2014
 495 \f
 496 Copyright (C) 2015 Free Software Foundation, Inc.
 497
 498 Copying and distribution of this file, with or without modification,
 499 are permitted in any medium without royalty provided the copyright
 500 notice and this notice are preserved.
 501
 502 Local Variables:
 503 mode: change-log
 504 left-margin: 8
 505 fill-column: 74
 506 version-control: never
 507 End: