libctf/ChangeLog

   1 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
   4         * Makefile.in: Regenerated.
   5         * ctf-impl.h (ctf_link_input_name): New.
   6         (ctf_file_t) <ctf_link_flags>: New.
   7         * ctf-create.c (ctf_serialize): Adjust accordingly.
   8         * ctf-link.c: Define ctf_open as weak when PIC.
   9         (ctf_arc_close_thunk): Remove unnecessary thunk.
  10         (ctf_file_close_thunk): Likewise.
  11         (ctf_link_input_name): New.
  12         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
  13         (ctf_link_input_close): Adjust accordingly.
  14         (ctf_link_add_ctf_internal): New, split from...
  15         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
  16         CTF is not possible.  Change to just call...
  17         (ctf_link_add): ... this new function.
  18         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
  19         ctf_file_close_thunk.
  20         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
  21         <in_file_name>: ... this.
  22         <arcname>: Drop.
  23         <share_mode>: Likewise (migrated to ctf_link_flags).
  24         <done_main_member>: Rename to...
  25         <done_parent>: ... this.
  26         <main_input_fp>: Rename to...
  27         <in_fp_parent>: ... this.
  28         <cu_mapped>: New.
  29         (ctf_link_one_type): Adjuwt accordingly.  Transition to
  30         ctf_err_warn, removing a TODO.
  31         (ctf_link_one_variable): Note a case too common to warn about.
  32         Report in the debug stream if a cu-mapped link prevents addition
  33         of a conflicting variable.
  34         (ctf_link_one_input_archive_member): Adjust.
  35         (ctf_link_lazy_open): New, open a CTF archive for linking when
  36         needed.
  37         (ctf_link_close_one_input_archive): New, close it again.
  38         (ctf_link_one_input_archive): Adjust for lazy opening, member
  39         renames, and ctf_err_warn transition.  Move the
  40         empty_link_type_mapping call to...
  41         (ctf_link): ... here.  Adjut for renamings and thunk removal.
  42         Don't spuriously fail if some input contains no CTF data.
  43         (ctf_link_write): ctf_err_warn transition.
  44         * libctf.ver: Remove not-yet-stable comment.
  45
  46 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  47
  48         * ctf-impl.h (ctf_strerror): Delete.
  49         * ctf-subr.c (ctf_strerror): Likewise.
  50         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
  51         strerror directly.
  52
  53 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  54
  55         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
  56         (ctf_import_unref): New.
  57         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
  58         zero.  Don't recurse back in if the refcount is already zero.
  59         (ctf_import): Check ctf_parent_unreffed before deciding whether
  60         to close a pre-existing parent.  Set it to zero.
  61         (ctf_import_unreffed): New, as above, setting
  62         ctf_parent_unreffed to 1.
  63         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
  64         child: use direct assignment, and set unreffed on the new and
  65         old children.
  66         * ctf-link.c (ctf_create_per_cu): Import the parent using
  67         ctf_import_unreffed.
  68
  69 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  70
  71         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
  72         (ctf_link_type_key): ... this, adjusting member prefixes to
  73         match.
  74         (ctf_hash_type_mapping_key): Rename to...
  75         (ctf_hash_type_key): ... this.
  76         (ctf_hash_eq_type_mapping_key): Rename to...
  77         (ctf_hash_eq_type_key): ... this.
  78         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
  79         (ctf_hash_type_key): ... this, and adjust for member name
  80         changes.
  81         (ctf_hash_eq_type_mapping_key): Rename to...
  82         (ctf_hash_eq_type_key): ... this, and adjust for member name
  83         changes.
  84         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
  85         need for out-of-memory checking in this code.
  86         (ctf_type_mapping): Adjust.
  87
  88 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  89
  90         configure.ac: Check for vasprintf.
  91         configure: Regenerated.
  92         config.h.in: Likewise.
  93
  94 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  95
  96         * ctf-archive.c (ctf_arc_bufopen): Fix message.
  97
  98 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  99
 100         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 101         New.
 102         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 103         if the input has no symtab, rather than dividing by
 104         zero. Arrange to free it later via ctfi_free_ctfsect.
 105         * ctf-archive.c (ctf_new_archive_internal): Do not
 106         ctfi_free_strsect by default.
 107         (ctf_arc_close): Possibly free it here.
 108
 109 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 110
 111         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 112         (ctf_dump_format_type): improve slice formatting.  Always print
 113         the type size, even of slices.
 114         (ctf_dump_member): Print slices (-> bitfields) differently from
 115         non-slices.  Failure to format a type is not an OOM.
 116
 117 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 118
 119         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 120         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 121         (ctf_dump_objts): Likewise.
 122         (ctf_dump_var): Likewise.
 123         (ctf_dump_type): Do not emit a duplicate message.  Move to
 124         ctf_err_warning, and swallow all errors.
 125
 126 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 127
 128         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 129         (ctf_decl_buf): Once it escapes, don't try to free it later.
 130
 131 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 132
 133         * ctf-types.c (ctf_type_aname): Print arg types here...
 134         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 135         in the type name here.
 136
 137 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 138
 139         * ctf-impl.h (ctf_assert): New.
 140         (ctf_err_warning_t): Likewise.
 141         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 142         (ctf_err_warn): New prototype.
 143         (ctf_assert_fail_internal): Likewise.
 144         * ctf-inlines.h (ctf_assert_internal): Likewise.
 145         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 146         * ctf-create.c (ctf_serialize): Copy it on serialization.
 147         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 148         (ctf_errwarning_next): New iterator, free and pass back
 149         errors/warnings in succession.
 150         * libctf.ver (ctf_errwarning_next): Add.
 151
 152 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 153
 154         * ctf-types.c (ctf_variable_iter): Fix error return.
 155
 156 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 157
 158         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 159
 160 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 161
 162         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 163
 164 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 165
 166         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 167         sorting functions.
 168         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 169         ctf_dynhash_next_sorted.
 170         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 171         <cu.ctn_s>: New, pointer to the dynset under iteration.
 172         (ctf_hash_sort_f): Sorting function passed to...
 173         (ctf_dynhash_next_sorted): ... this new function.
 174         (ctf_dynhash_next): New.
 175         (ctf_dynset_next): New.
 176         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 177         (ctf_dynhash_cnext): New.
 178         (ctf_dynset_cnext): New.
 179         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 180         (ctf_dynhash_next): New.
 181         (ctf_dynset_next): New.
 182         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 183         needed.
 184         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 185
 186 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 187
 188         * ctf-impl.h (ctf_next): New.
 189         (ctf_get_dict): New prototype.
 190         * ctf-lookup.c (ctf_get_dict): New, split out of...
 191         (ctf_lookup_by_id): ... here.
 192         * ctf-util.c (ctf_next_create): New.
 193         (ctf_next_destroy): New.
 194         (ctf_next_copy): New.
 195         * ctf-types.c (includes): Add <assert.h>.
 196         (ctf_member_next): New.
 197         (ctf_enum_next): New.
 198         (ctf_type_iter): Document the lack of iteration over parent
 199         types.
 200         (ctf_type_next): New.
 201         (ctf_variable_next): New.
 202         * ctf-archive.c (ctf_archive_next): New.
 203         * libctf.ver: Add new public functions.
 204
 205 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 206
 207         * libctf.ver (ctf_ref): New.
 208         * ctf-open.c (ctf_ref): Implement it.
 209
 210 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 211
 212         * ctf-inlines.h (ctf_forwardable_kind): New.
 213         * ctf-create.c (ctf_add_forward): Use it.
 214
 215 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 216
 217         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 218         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 219
 220 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 221
 222         * ctf-hash.c (ctf_dynset_eq_string): New.
 223         (ctf_dynset_create): New.
 224         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 225         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 226         (key_to_internal): New.
 227         (internal_to_key): New.
 228         (ctf_dynset_insert): New.
 229         (ctf_dynset_remove): New.
 230         (ctf_dynset_destroy): New.
 231         (ctf_dynset_lookup): New.
 232         (ctf_dynset_exists): New.
 233         (ctf_dynset_lookup_any): New.
 234         (ctf_hash_insert_type): Coding style.
 235         (ctf_hash_define_type): Likewise.
 236         * ctf-impl.h (ctf_dynset_t): New.
 237         (ctf_dynset_eq_string): New.
 238         (ctf_dynset_create): New.
 239         (ctf_dynset_insert): New.
 240         (ctf_dynset_remove): New.
 241         (ctf_dynset_destroy): New.
 242         (ctf_dynset_lookup): New.
 243         (ctf_dynset_exists): New.
 244         (ctf_dynset_lookup_any): New.
 245         * ctf-inlines.h (ctf_dynset_cinsert): New.
 246
 247 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 248
 249         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 250         <value_free>: Likewise.
 251         <owner>: New.
 252         (ctf_dynhash_item_free): Indirect through the owner.
 253         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 254         allocate space for the key_free and value_free fields fields
 255         if necessary.
 256         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 257         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 258         value_free if they will exist.  Set the slot's owner, but only
 259         if it exists.
 260         (ctf_dynhash_remove): Adjust.
 261
 262 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 263
 264         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 265         there is a key-freeing function and the key already exists.
 266
 267 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 268
 269         * ctf-inlines.h: New file.
 270         * ctf-impl.h: Include it.
 271         (ctf_hash_iter_find_f): New typedef.
 272         (ctf_dynhash_elements): New.
 273         (ctf_dynhash_lookup_kv): New.
 274         (ctf_dynhash_iter_find): New.
 275         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 276         (ctf_traverse_find_cb_arg_t): New.
 277         (ctf_hashtab_traverse_find): New.
 278         (ctf_dynhash_iter_find): New.
 279         (ctf_dynhash_elements): New.
 280
 281 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 282
 283         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 284
 285 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 286
 287         * ctf-archive.c (ctf_archive_count): New.
 288         * libctf.ver: New public function.
 289
 290 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 291
 292         * ctf-types.c (ctf_member_count): New.
 293         * libctf.ver: New public function.
 294
 295 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 296
 297         * ctf-types.c (ctf_type_kind_forwarded): New.
 298
 299 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 300
 301         * ctf-types.c (ctf_type_name_raw): New.
 302         (ctf_type_aname_raw): Reimplement accordingly.
 303
 304 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 305
 306         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 307
 308 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 309
 310         * ctf-impl.h (struct ctf_archive_internal)
 311         <ctfi_unmap_on_close>: New.
 312         (ctf_new_archive_internal): Adjust.
 313         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 314         Initialize ctfi_unmap_on_close.  Adjust error path.
 315         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 316         (unmap_on_close is 0).
 317         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 318         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 319
 320 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 321
 322         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 323         ints, floats or typedefs have no name.  Fix comment typo.
 324
 325 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 326
 327         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 328         resolves to an integral type.
 329         * ctf-types.c (ctf_type_encoding): Resolve the type before
 330         fishing its encoding out.
 331
 332 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 333
 334         * ctf-create.c (ctf_create): Mark dirty.
 335
 336 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 337
 338         * ctf-create.c (membcmp)  Skip nameless members.
 339
 340 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 341
 342         * ctf-create.c (ctf_add_member_offset): Support names of ""
 343         as if they were the null pointer.
 344
 345 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 346
 347         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 348         special-casing.
 349
 350 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 351
 352         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 353
 354 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 355
 356         * ctf-create.c (ctf_serialize): Add cast.
 357         (ctf_add_slice): Likewise.
 358
 359 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 360
 361         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 362         * ctf-create.c (ctf_add_function): Check for unimplemented type
 363         and populate at the same time.  Populate one-by-one, not via
 364         memcpy.
 365         (ctf_serialize): Remove unnecessary cast.
 366         * ctf-types.c (ctf_func_type_info): Likewise.
 367         (ctf_func_type_args): Likewise.  Fix comment typo.
 368
 369 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 370
 371         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 372         (ctf_add_array): Support array contents of type zero.
 373         (ctf_add_function): Support arguments and return types of
 374         type zero.
 375         (ctf_add_typedef): Support typedefs to type zero.
 376         (ctf_add_member_offset): Support members of type zero,
 377         unless added at unspecified (naturally-aligned) offset.
 378
 379 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 380
 381         * ctf-error.c: Include <stddef.h>, for offsetof.
 382         (_ctf_errlist): Migrate to...
 383         (_ctf_errlist_t): ... this.
 384         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 385         (_ctf_nerr): Remove.
 386         (ctf_errmsg): Adjust accordingly.
 387         * Makefile.am (BUILT_SOURCES): Note...
 388         (ctf-error.h): ... this new rule.
 389         * Makefile.in: Regenerate.
 390         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 391         * .gitignore: New, ignore ctf-error.h.
 392
 393 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 394
 395         * ctf-impl.h: Fix typos in comments.
 396
 397 2020-07-22  Nick Clifton  <nickc@redhat.com>
 398
 399         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 400         same file descriptor.
 401
 402 2020-07-04  Nick Clifton  <nickc@redhat.com>
 403
 404         Binutils 2.35 branch created.
 405
 406 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 407
 408         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 409         alphabetical order.
 410         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 411         * config.h.in: Regenerated.
 412         * Makefile.in: Likewise.
 413         * configure: Likewise.
 414
 415 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 416
 417         * ctf-create.c: Include <unistd.h>.
 418         * ctf-open-bfd.c: Likewise.
 419
 420 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 421
 422         PR libctf/25120
 423         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 424         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 425         means this is declared.
 426         (bswap_32): Likewise.
 427         (bswap_64): Likewise.
 428         (bswap_identity_64): Remove, unused.
 429         * configure: Regenerated.
 430         * config.h.in: Likewise.
 431
 432 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 433
 434         PR libctf/25120
 435         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 436         (_libctf_unlikely_): Likewise.
 437         (_libctf_unused): Likewise.
 438         (_libctf_malloc_): Likewise.
 439
 440 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 441
 442         PR libctf/25120
 443         * ctf-archive.c (search_nametbl): No longer global: declare...
 444         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 445         (search_modent_by_name): Take and use ARG for the nametbl.
 446
 447 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 448
 449         * ctf-impl.h (ctf_new_archive_internal): Declare.
 450         (ctf_arc_bufopen): Remove.
 451         (ctf_archive_internal) <ctfi_free_symsect>: New.
 452         * ctf-archive.c (ctf_arc_close): Use it.
 453         (ctf_arc_bufopen): Fuse into...
 454         (ctf_new_archive_internal): ... this, moved across from...
 455         * ctf-open-bfd.c: ... here.
 456         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 457         * libctf.ver: Add it.
 458
 459 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 460
 461         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 462         (ctf_dtd_delete): Remove correspondingly.
 463         (ctf_rollback): Likewise.
 464
 465 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 466
 467         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 468         unchanged.
 469
 470 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 471
 472         * ctf-create.c (ctf_add_forward): Don't add forwards to
 473         types that already exist.
 474
 475 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 476
 477         * ctf-open.c (init_types): Only intern root-visible types.
 478         * ctf-create.c (ctf_dtd_insert): Likewise.
 479         (ctf_dtd_delete): Only remove root-visible types.
 480         (ctf_rollback): Likewise.
 481         (ctf_add_generic): Adjust.
 482         (ctf_add_struct_sized): Adjust comment.
 483         (ctf_add_union_sized): Likewise.
 484         (ctf_add_enum): Likewise.
 485         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 486
 487 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 488
 489         * swap.h (bswap_identity_64): Make static.
 490
 491 2020-01-18  Nick Clifton  <nickc@redhat.com>
 492
 493         Binutils 2.34 branch created.
 494
 495 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 496
 497         PR binutils/25155:
 498         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 499         * configure, config.h.in: Regenerate.
 500
 501 2020-01-01  Alan Modra  <amodra@gmail.com>
 502
 503         Update year range in copyright notice of all files.
 504
 505 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 506
 507         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 508
 509 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 510
 511         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 512         * ctf-types.c (ctf_type_lname): Likewise.
 513
 514 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 515
 516         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 517         ctf_import after the first for a given file.
 518
 519 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 520
 521         * ctf-impl.h (ctf_str_append_noerr): Declare.
 522         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 523         ctf_str_append.
 524         * ctf-dump.c (str_append): New, call it.
 525         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 526         (ctf_dump_label): Likewise.
 527         (ctf_dump_objts): Likewise.
 528         (ctf_dump_funcs): Likewise.
 529         (ctf_dump_var): Likewise.
 530         (ctf_dump_member): Likewise.
 531         (ctf_dump_type): Likewise.
 532         (ctf_dump): Likewise.
 533
 534 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 535
 536         * ctf-impl.h (ctf_alloc): Remove.
 537         (ctf_free): Likewise.
 538         (ctf_strdup): Likewise.
 539         * ctf-subr.c (ctf_alloc): Remove.
 540         (ctf_free): Likewise.
 541         * ctf-util.c (ctf_strdup): Remove.
 542
 543         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 544         ctf_free; strdup, not ctf_strdup.
 545         (ctf_dtd_delete): Likewise.
 546         (ctf_dvd_delete): Likewise.
 547         (ctf_add_generic): Likewise.
 548         (ctf_add_function): Likewise.
 549         (ctf_add_enumerator): Likewise.
 550         (ctf_add_member_offset): Likewise.
 551         (ctf_add_variable): Likewise.
 552         (membadd): Likewise.
 553         (ctf_compress_write): Likewise.
 554         (ctf_write_mem): Likewise.
 555         * ctf-decl.c (ctf_decl_push): Likewise.
 556         (ctf_decl_fini): Likewise.
 557         (ctf_decl_sprintf): Likewise.  Check for OOM.
 558         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 559         ctf_free; strdup, not ctf_strdup.
 560         (ctf_dump_free): Likewise.
 561         (ctf_dump): Likewise.
 562         * ctf-open.c (upgrade_types_v1): Likewise.
 563         (init_types): Likewise.
 564         (ctf_file_close): Likewise.
 565         (ctf_bufopen_internal): Likewise.  Check for OOM.
 566         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 567         (ctf_cuname_set): Likewise.
 568         (ctf_import): Likewise.
 569         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 570         free, not ctf_free; strdup, not ctf_strdup.
 571         (ctf_str_free_atom): Likewise.
 572         (ctf_str_create_atoms): Likewise.
 573         (ctf_str_add_ref_internal): Likewise.
 574         (ctf_str_remove_ref): Likewise.
 575         (ctf_str_write_strtab): Likewise.
 576
 577 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 578
 579         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 580         work right for non-int/fps.
 581
 582 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 583
 584         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 585         null pointer.
 586
 587 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 588
 589         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 590         * ctf-open.c (ctf_file_close): Free it.
 591         * ctf-create.c (ctf_serialize): Adjust.
 592         (membcmp): When reporting a conflict due to an error, report the
 593         error.
 594         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 595         (ctf_add_type_internal): ... this.  Hand back types we are already
 596         in the middle of adding immediately.  Hand back structs/unions with
 597         the same number of members immediately.  Do not walk the dynamic
 598         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 599         forwards promoted to other types and the inverse case identically.
 600         Add structs to the mapping as soon as we intern them, before they
 601         gain any members.
 602
 603 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 604
 605         * ctf-impl.h (ctf_names_t): New.
 606         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 607         (ctf_file_t) <ctf_structs>: Likewise.
 608         <ctf_unions>: Likewise.
 609         <ctf_enums>: Likewise.
 610         <ctf_names>: Likewise.
 611         <ctf_lookups>: Improve comment.
 612         <ctf_ptrtab_len>: New.
 613         <ctf_prov_strtab>: New.
 614         <ctf_str_prov_offset>: New.
 615         <ctf_dtbyname>: Remove, redundant to the names hashes.
 616         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 617         (ctf_dtdef_t) <dtd_name>: Remove.
 618         <dtd_data>: Note that the ctt_name is now populated.
 619         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 620         offset for internal strings too.
 621         <csa_external_offset>: New, the external strtab offset.
 622         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 623         (ctf_name_table): New declaration.
 624         (ctf_lookup_by_rawname): Likewise.
 625         (ctf_lookup_by_rawhash): Likewise.
 626         (ctf_set_ctl_hashes): Likewise.
 627         (ctf_serialize): Likewise.
 628         (ctf_dtd_insert): Adjust.
 629         (ctf_simple_open_internal): Likewise.
 630         (ctf_bufopen_internal): Likewise.
 631         (ctf_list_empty_p): Likewise.
 632         (ctf_str_remove_ref): Likewise.
 633         (ctf_str_add): Returns uint32_t now.
 634         (ctf_str_add_ref): Likewise.
 635         (ctf_str_add_external): Now returns a boolean (int).
 636         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 637         for strings in the appropriate range.
 638         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 639         when adding the null string to the new strtab.
 640         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 641         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 642         make_provisional, populate the offset and fill in the
 643         ctf_prov_strtab accordingly.
 644         (ctf_str_add): Return the offset, not the string.
 645         (ctf_str_add_ref): Likewise.
 646         (ctf_str_add_external): Return a success integer.
 647         (ctf_str_remove_ref): New, remove a single ref.
 648         (ctf_str_count_strtab): Do not count the initial null string's
 649         length or the existence or length of any unreferenced internal
 650         atoms.
 651         (ctf_str_populate_sorttab): Skip atoms with no refs.
 652         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 653         to the cts_len for the null string, since it is no longer done
 654         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 655         Populate the csa_offset for both internal and external cases.
 656         Flush the ctf_prov_strtab afterwards, and reset the
 657         ctf_str_prov_offset.
 658         * ctf-create.c (ctf_grow_ptrtab): New.
 659         (ctf_create): Call it.  Initialize new fields rather than old
 660         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 661         Set the ctl hashes and data model.
 662         (ctf_update): Rename to...
 663         (ctf_serialize): ... this.  Leave a compatibility function behind.
 664         Tell ctf_simple_open_internal that this is a writable dictionary.
 665         Pass the new fields along from the old dictionary.  Drop
 666         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 667         Do not zero out the DTD's ctt_name.
 668         (ctf_prefixed_name): Rename to...
 669         (ctf_name_table): ... this.  No longer return a prefixed name: return
 670         the applicable name table instead.
 671         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 672         kind we're adding.  Migrate away from dtd_name.
 673         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 674         deleted ctt_name.
 675         (ctf_dtd_lookup_type_by_name): Remove.
 676         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 677         No longer check ctf_dtnextid: check ctf_typemax instead.
 678         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 679         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 680         ctf_name_table and the right name table, and migrate away from
 681         dtd_name as in ctf_dtd_delete.
 682         (ctf_add_generic): Pass in the kind explicitly and pass it to
 683         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 684         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 685         Grow the ptrtab if needed.
 686         (ctf_add_encoded): Pass in the kind.
 687         (ctf_add_slice): Likewise.
 688         (ctf_add_array): Likewise.
 689         (ctf_add_function): Likewise.
 690         (ctf_add_typedef): Likewise.
 691         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 692         ctt_name rather than dtd_name.
 693         (ctf_add_struct_sized): Pass in the kind.  Use
 694         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 695         ctf_dtd_lookup_type_by_name.
 696         (ctf_add_union_sized): Likewise.
 697         (ctf_add_enum): Likewise.
 698         (ctf_add_enum_encoded): Likewise.
 699         (ctf_add_forward): Likewise.
 700         (ctf_add_type): Likewise.
 701         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 702         being initialized until after the call.
 703         (ctf_write_mem): Likewise.
 704         (ctf_write): Likewise.
 705         * ctf-archive.c (arc_write_one_ctf): Likewise.
 706         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 707         ctf_hash_lookup_type.
 708         (ctf_lookup_by_id): No longer check the readonly types if the
 709         dictionary is writable.
 710         * ctf-open.c (init_types): Assert that this dictionary is not
 711         writable.  Adjust to use the new name hashes, ctf_name_table,
 712         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 713         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 714         if set.  Drop out early when dictionary is writable.  Split the
 715         ctf_lookups initialization into...
 716         (ctf_set_cth_hashes): ... this new function.
 717         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 718         (ctf_simple_open): Adjust accordingly.
 719         (ctf_bufopen): Likewise.
 720         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 721         destroy ctf_dtbyname, which is gone.
 722         (ctf_getdatasect): Remove spurious "extern".
 723         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 724         specified name table, given a kind.
 725         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 726         (ctf_member_iter): Add support for iterating over the
 727         dynamic type list.
 728         (ctf_enum_iter): Likewise.
 729         (ctf_variable_iter): Likewise.
 730         (ctf_type_rvisit): Likewise.
 731         (ctf_member_info): Add support for types in the dynamic type list.
 732         (ctf_enum_name): Likewise.
 733         (ctf_enum_value): Likewise.
 734         (ctf_func_type_info): Likewise.
 735         (ctf_func_type_args): Likewise.
 736         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 737         ctf_update.
 738         (ctf_link_write): Likewise.
 739         (ctf_link_intern_extern_string): Adjust for new
 740         ctf_str_add_external return value.
 741         (ctf_link_add_strtab): Likewise.
 742         * ctf-util.c (ctf_list_empty_p): New.
 743
 744 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 745
 746         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 747         type zero.
 748         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 749         members and types.
 750         (ctf_add_variable): Likewise for variables pointing to them.
 751         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 752         type link failure, but do warn for others.
 753         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 754         errors to be ENOMEM.
 755         (ctf_dump_member): Likewise.
 756         (ctf_dump_type): Likewise.
 757         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 758         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 759         (ctf_dump_header): Likewise.
 760         (ctf_dump_label): likewise.
 761         (ctf_dump_objts): likewise.
 762         (ctf_dump_funcs): likewise.
 763         (ctf_dump_var): likewise.
 764         (ctf_dump_str): Likewise.
 765
 766 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 767
 768         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 769         (LT_INIT): Likewise.
 770         (AM_INSTALL_LIBBFD): Likewise.
 771         (dlopen): Note why this is necessary in a comment.
 772         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 773         opcodes/.
 774         (SHARED_LDFLAGS): Likewise.
 775         (BFD_LIBADD): Likewise, for libbfd.
 776         (BFD_DEPENDENCIES): Likewise.
 777         (VERSION_FLAGS): Initialize, using a version script if ld supports
 778         one, or libtool -export-symbols-regex otherwise.
 779         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 780         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 781         (INCDIR): New.
 782         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 783         (noinst_LIBRARIES): Replace with...
 784         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 785         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 786         libctf-nobfd.la as well.
 787         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 788         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 789         (libctf_a_SOURCES): Rename to...
 790         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 791         ctf-open-bfd.c.
 792         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 793         with ctf-open-bfd.c added.
 794         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 795         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 796         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 797         * Makefile.am [INSTALL_LIBCTF]: Use it.
 798         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 799         libtool macros.
 800         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 801         the unstable components).
 802         * Makefile.in: Regenerated.
 803         * config.h.in: Likewise.
 804         * configure: Likewise.
 805
 806 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 807
 808         * configure.ac (INSTALL_LIBCTF): New, controlled by
 809         --enable-install-libctf.
 810         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 811         * Makefile.in: Regenerated.
 812         * configure: Regenerated.
 813
 814 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 815
 816         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 817         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 818
 819 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 820
 821         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 822
 823 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 824
 825         * ctf-impl.h (includes): Include <sys/param.h> here.
 826
 827 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 828
 829         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 830         (flip_objts): Likewise.
 831         (flip_vars): Likewise.
 832         (flip_types): Likewise.
 833
 834 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 835
 836         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 837         freeing functions: if set, free the key and value if the slot
 838         already exists.  Always reassign the key.
 839         (ctf_dynhash_insert): Adjust call appropriately.
 840         (ctf_hash_insert_type): Likewise.
 841
 842 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 843
 844         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 845         type kind.  Allow forwards to unify with pre-existing structs/
 846         unions/enums.
 847
 848 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 849
 850         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 851         <ctf_link_memb_name_changer>: Likewise.
 852         <ctf_link_memb_name_changer_arg>: Likewise.
 853         * ctf-create.c (ctf_update): Update accordingly.
 854         * ctf-open.c (ctf_file_close): Likewise.
 855         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 856         (ctf_link_add_cu_mapping): New.
 857         (ctf_link_set_memb_name_changer): Likewise.
 858         (ctf_change_parent_name): New.
 859         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 860         allocated by the caller's ctf_link_memb_name_changer.
 861         <ndynames>: Likewise.
 862         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 863         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 864         ctf_change_parent_name.  Free any resulting names.
 865
 866 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 867
 868         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 869         (ctf_link_one_type): ... here, with parent-name setting added.
 870         (check_variable): New.
 871         (ctf_link_one_variable): Likewise.
 872         (ctf_link_one_input_archive_member): Call it.
 873         * ctf-error.c (_ctf_errlist): Updated with new errors.
 874
 875 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 876
 877         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 878         (struct ctf_link_type_mapping_key): New.
 879         (ctf_hash_type_mapping_key): Likewise.
 880         (ctf_hash_eq_type_mapping_key): Likewise.
 881         (ctf_add_type_mapping): Likewise.
 882         (ctf_type_mapping): Likewise.
 883         (ctf_dynhash_empty): Likewise.
 884         * ctf-open.c (ctf_file_close): Update accordingly.
 885         * ctf-create.c (ctf_update): Likewise.
 886         (ctf_add_type): Populate the mapping.
 887         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 888         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 889         (ctf_dynhash_insert): Fix comment typo.
 890         (ctf_dynhash_empty): New.
 891         * ctf-link.c (ctf_add_type_mapping): New.
 892         (ctf_type_mapping): Likewise.
 893         (empty_link_type_mapping): New.
 894         (ctf_link_one_input_archive): Call it.
 895
 896 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 897
 898         * ctf-link.c: New file, linking of the string and type sections.
 899         * Makefile.am (libctf_a_SOURCES): Add it.
 900         * Makefile.in: Regenerate.
 901
 902         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 903         ctf_link_outputs.
 904         * ctf-create.c (ctf_update): Update accordingly.
 905         * ctf-open.c (ctf_file_close): Likewise.
 906         * ctf-error.c (_ctf_errlist): Updated with new errors.
 907
 908 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 909
 910         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 911
 912 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 913
 914         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 915         ctf_type_iter.
 916         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 917         (ctf_dump_format_type): Add non-root-type { } notation.
 918         Add root flag to prototype.
 919         (ctf_dump_label): Adjust accordingly.
 920         (ctf_dump_objts): Likewise.
 921         (ctf_dump_var): Likewise.
 922
 923 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 924
 925         * ctf-create.c (ctf_compress_write): Fix double-free.
 926
 927 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 928
 929         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 930         of...
 931         (ctf_arc_write_fd): ... this new function.
 932         * ctf-create.c (ctf_write_mem): New.
 933
 934 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 935
 936         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 937         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 938         (ctf_str_add_ref): Name the last arg.
 939         (ctf_str_add_external) New.
 940         (ctf_str_add_strraw_explicit): Likewise.
 941         (ctf_simple_open_internal): Likewise.
 942         (ctf_bufopen_internal): Likewise.
 943
 944         * ctf-string.c (ctf_strraw_explicit): Split from...
 945         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 946         (ctf_str_add_ref_internal): Return the atom, not the
 947         string.
 948         (ctf_str_add): Adjust accordingly.
 949         (ctf_str_add_ref): Likewise.  Move up in the file.
 950         (ctf_str_add_external): New: update the csa_offset.
 951         (ctf_str_count_strtab): Only account for strings with no csa_offset
 952         in the internal strtab length.
 953         (ctf_str_write_strtab): If the csa_offset is set, update the
 954         string's refs without writing the string out, and update the
 955         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 956         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 957         (ctf_update): Handle failure to populate the strtab.  Pass in the
 958         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 959         Call ctf_simple_open_internal, not ctf_simple_open.
 960         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 961         strings by hand.
 962         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 963         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 964         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 965         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 966         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 967         (ctf_simple_open_internal): ... this new function, which calls
 968         ctf_bufopen_internal.
 969         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 970         (ctf_bufopen_internal): ... this new function, which sets
 971         ctf_syn_ext_strtab.
 972
 973 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 974
 975         * ctf_types.c (ctf_type_iter_all): New.
 976
 977 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 978
 979         * ctf-open.c (init_symtab): Check for overflow against the right
 980         section.
 981         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 982         (upgrade_types_v1): Note that these sections are not checked.
 983         (flip_header): Endian-swap the header fields.
 984         (flip_ctf): Endian-swap the sections.
 985         (flip_objts): Update comment.
 986         (ctf_bufopen): Check header offsets and alignment for validity.
 987
 988 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 989
 990         * ctf-open-bfd.c: Add <assert.h>.
 991         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 992         techniques borrowed from bfd_elf_sym_name.
 993         (ctf_new_archive_internal): Improve comment.
 994         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 995         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 996         no symbol section, but not vice versa.
 997
 998 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 999
1000         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1001         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1002         * ctf-dump.c (dump_header): New function, dump the CTF header.
1003         (ctf_dump): Call it.
1004         (ctf_dump_header_strfield): New function.
1005         (ctf_dump_header_sectfield): Likewise.
1006
1007 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1008
1009         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1010         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1011         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1012         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1013         Print out ctf_cuname: only print out ctf_parname if set.
1014         (ctf_free_base): Removed, ctf_base is no longer freed: free
1015         ctf_dynbase instead.
1016         (ctf_set_version): Fix spacing.
1017         (upgrade_header): New, in-place header upgrading.
1018         (upgrade_types): Rename to...
1019         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1020         longer track old and new headers separately.  No longer allow for
1021         header sizes explicitly: squeeze the headers out on upgrade (they
1022         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1023         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1024         (upgrade_types): New, also handle ctf_parmax updating.
1025         (flip_header): Flip ctf_cuname.
1026         (flip_types): Flip BUF explicitly rather than deriving BUF from
1027         BASE.
1028         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1029         required alignment of objtoff and funcoff.  No longer store it in
1030         the ctf_buf unless that buf is derived unmodified from the input.
1031         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1032         that duplicate fields in ctf_file: move allocation of ctf_file
1033         further up instead.  Call upgrade_header as needed.  Move
1034         version-specific ctf_parmax initialization into upgrade_types.  More
1035         concise error handling.
1036         (ctf_file_close): No longer test for null pointers before freeing.
1037         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1038         ctf_free_base.
1039         (ctf_cuname): New.
1040         (ctf_cuname_set): New.
1041         * ctf-create.c (ctf_update): Populate ctf_cuname.
1042         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1043         comment.
1044         (ctf_write): Likewise.
1045         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1046         Fix the compression length: fp->ctf_size never counted the CTF
1047         header.  Simplify the compress call accordingly.
1048
1049 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1050
1051         * ctf-endian.h: Don't assume htole64 and le64toh are always
1052         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1053         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1054         not bswap_identity_64.
1055
1056 2019-09-18  Alan Modra  <amodra@gmail.com>
1057
1058         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1059
1060 2019-09-09  Phil Blundell  <pb@pbcl.net>
1061
1062         binutils 2.33 branch created.
1063
1064 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1065
1066         * ctf-types.c (ctf_type_aname_raw): New.
1067         (ctf_func_type_info): Likewise.
1068         (ctf_func_type_args): Likewise.
1069         * ctf-error.c (_ctf_errlist): Fix description.
1070         * ctf-lookup.c: Fix file description.
1071
1072 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1073
1074         * ctf-create.c (ctf_create): Fix off-by-one error.
1075
1076 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1077
1078         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1079         struct ctf_strs.
1080         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1081         (struct ctf_str_atom): New, disambiguated single string.
1082         (struct ctf_str_atom_ref): New, points to some other location that
1083         references this string's offset.
1084         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1085         Remove member ctf_dtvstrlen: we no longer track the total strlen
1086         as we add strings.
1087         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1088         (ctf_str_free_atoms): Likewise.
1089         (ctf_str_add): Likewise.
1090         (ctf_str_add_ref): Likewise.
1091         (ctf_str_rollback): Likewise.
1092         (ctf_str_purge_refs): Likewise.
1093         (ctf_str_write_strtab): Likewise.
1094         (ctf_realloc): Declare new function in ctf-util.c.
1095
1096         * ctf-open.c (ctf_bufopen): Create the atoms table.
1097         (ctf_file_close): Destroy it.
1098         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1099         special-case the position of the parname string.  Construct the
1100         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1101         rest of each buffer element is constructed, not via open-coding:
1102         realloc the CTF buffer and append the strtab to it.  No longer
1103         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1104         strtab construction.
1105         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1106         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1107         after buffer element construction instead.
1108         (ctf_copy_lmembers): Likewise.
1109         (ctf_copy_emembers): Likewise.
1110         (ctf_create): No longer maintain the ctf_dtvstrlen.
1111         (ctf_dtd_delete): Likewise.
1112         (ctf_dvd_delete): Likewise.
1113         (ctf_add_generic): Likewise.
1114         (ctf_add_enumerator): Likewise.
1115         (ctf_add_member_offset): Likewise.
1116         (ctf_add_variable): Likewise.
1117         (membadd): Likewise.
1118         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1119         if there are active ctf_str_num_refs.
1120         (ctf_strraw): Move to ctf-string.c.
1121         (ctf_strptr): Likewise.
1122         * ctf-string.c: New file, strtab manipulation.
1123
1124         * Makefile.am (libctf_a_SOURCES): Add it.
1125         * Makefile.in: Regenerate.
1126
1127 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1128
1129         * ctf-impl.h (ctf_hash_iter_f): New.
1130         (ctf_dynhash_iter): New declaration.
1131         (ctf_dynhash_iter_remove): New declaration.
1132         * ctf-hash.c (ctf_dynhash_iter): Define.
1133         (ctf_dynhash_iter_remove): Likewise.
1134         (ctf_hashtab_traverse): New.
1135         (ctf_hashtab_traverse_remove): Likewise.
1136         (struct ctf_traverse_cb_arg): Likewise.
1137         (struct ctf_traverse_remove_cb_arg): Likewise.
1138
1139 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1140
1141         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1142
1143 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1144
1145         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1146         (ctf_dump_funcs): Likewise.
1147
1148 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1149
1150         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1151         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1152         little-endian CTF archive magic.  Do not check the CTF version:
1153         ctf_simple_open does that in endian-safe ways.  Do not dereference
1154         null pointers on open failure.
1155
1156 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1157
1158         * ctf-open.c (get_vbytes_common): Return the new slice size.
1159         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1160         Remember to copy in the CTF data when opening an uncompressed
1161         foreign-endian CTF file.  Prune useless variable manipulation.
1162
1163 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1164
1165         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1166         seen.
1167
1168 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1169
1170         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1171         output.
1172
1173 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1174
1175         * ctf-subr.c (_PAGESIZE): Remove.
1176         (ctf_data_alloc): Likewise.
1177         (ctf_data_free): Likewise.
1178         (ctf_data_protect): Likewise.
1179         * ctf-impl.h: Remove declarations.
1180         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1181         ctf_free, not ctf_data_free.
1182         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1183         the buffer again on compression error.
1184         * ctf-open.c (ctf_set_base): No longer track the size: call
1185         ctf_free, not ctf_data_free.
1186         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1187         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1188
1189 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1190
1191         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1192         ctf_dynhash_insert.
1193         (ctf_dvd_insert): Likewise.
1194         (ctf_add_generic): Likewise.
1195         (ctf_add_variable): Likewise.
1196         * ctf-impl.h: Adjust declarations.
1197
1198 2019-06-14  Alan Modra  <amodra@gmail.com>
1199
1200         * configure: Regenerate.
1201
1202 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1203
1204         * ctf-decls.h: Include <libiberty.h>.
1205         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1206
1207 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1208
1209         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1210         (ctf_dump_objts): Likewise.
1211         (ctf_dump_funcs): Likewise.
1212         (ctf_dump_member): Likewise.
1213         (ctf_dump_str): Likewise.
1214
1215 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1216
1217         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1218         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1219
1220 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1221
1222         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1223         (ctf_arc_open_by_offset): Likewise.
1224         * ctf-create.c (ctf_add_type): Likewise.
1225
1226 2019-06-04  Tom Tromey  <tromey@adacore.com>
1227
1228         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1229         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1230
1231 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1232
1233         * configure.ac: Check for O_CLOEXEC.
1234         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1235         * config.h.in: Regenerate.
1236         * configure: Likewise.
1237
1238 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1239
1240         * qsort_r.c: Rename to...
1241         * ctf-qsort_r.c: ... this.
1242         (_quicksort): Define to ctf_qsort_r.
1243         * ctf-decls.h (qsort_r): Remove.
1244         (ctf_qsort_r): Add.
1245         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1246         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1247         * Makefile.am (libctf_a_LIBADD): Remove.
1248         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1249         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1250         * ctf-create.c (ctf_update): Likewise.
1251         * configure.ac: Check for BSD versus GNU qsort_r signature.
1252         * Makefile.in: Regenerate.
1253         * config.h.in: Likewise.
1254         * configure: Likewise.
1255
1256 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1257
1258         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1259
1260 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1261
1262         * Makefile.am (ZLIB): New.
1263         (ZLIBINC): Likewise.
1264         (AM_CFLAGS): Use them.
1265         (libctf_a_LIBADD): New, for LIBOBJS.
1266         * configure.ac: Check for zlib, endian.h, and qsort_r.
1267         * ctf-endian.h: New, providing htole64 and le64toh.
1268         * swap.h: Code style fixes.
1269         (bswap_identity_64): New.
1270         * qsort_r.c: New, from gnulib (with one added #include).
1271         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1272         and unconditional definitions of MIN and MAX.
1273         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1274         (ctf_set_errno): Now returns unsigned long.
1275         * ctf-util.c (ctf_set_errno): Adjust here too.
1276         * ctf-archive.c: Use ctf-endian.h.
1277         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1278         cts_flags and cts_offset.
1279         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1280         * ctf-create.c: Provide a definition of roundup if not defined.
1281         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1282         (ctf_add_reftype): Do not check if type IDs are below zero.
1283         (ctf_add_slice): Likewise.
1284         (ctf_add_typedef): Likewise.
1285         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1286         when known error-free.  Drop CTF_ERR usage for functions returning
1287         int.
1288         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1289         int.
1290         (ctf_add_variable): Likewise.
1291         (enumcmp): Likewise.
1292         (enumadd): Likewise.
1293         (membcmp): Likewise.
1294         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1295         when known error-free.
1296         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1297         returning int: use CTF_ERR for functions returning ctf_type_id.
1298         (ctf_dump_label): Likewise.
1299         (ctf_dump_objts): Likewise.
1300         * ctf-labels.c (ctf_label_topmost): Likewise.
1301         (ctf_label_iter): Likewise.
1302         (ctf_label_info): Likewise.
1303         * ctf-lookup.c (ctf_func_args): Likewise.
1304         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1305         (ctf_bufopen): Likewise.  Use zlib types as needed.
1306         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1307         returning int.
1308         (ctf_enum_iter): Likewise.
1309         (ctf_type_size): Likewise.
1310         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1311         (ctf_type_kind_unsliced): Likewise.
1312         (ctf_type_kind): Likewise.
1313         (ctf_type_encoding): Likewise.
1314         (ctf_member_info): Likewise.
1315         (ctf_array_info): Likewise.
1316         (ctf_enum_value): Likewise.
1317         (ctf_type_rvisit): Likewise.
1318         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1319         cts_offset.
1320         (ctf_simple_open): Likewise.
1321         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1322         * Makefile.in: Regenerate.
1323         * aclocal.m4: Likewise.
1324         * config.h: Likewise.
1325         * configure: Likewise.
1326
1327 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1328
1329         * configure.in: Check for bfd_section_from_elf_index.
1330         * configure: Regenerate.
1331         * config.h.in [HAVE_BFD_ELF]: Likewise.
1332         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1333         abfd is potentially unused now.
1334
1335 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1336
1337         * Makefile.am: New.
1338         * Makefile.in: Regenerated.
1339         * config.h.in: Likewise.
1340         * aclocal.m4: Likewise.
1341         * configure: Likewise.
1342
1343 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1344
1345         * ctf-dump.c: New.
1346
1347 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1348
1349         * ctf-labels.c: New.
1350
1351 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1352
1353         * ctf-impl.h (_libctf_version): New declaration.
1354         * ctf-subr.c (_libctf_version): Define it.
1355         (ctf_version): New.
1356
1357 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1358
1359         * ctf-create.c (enumcmp): New.
1360         (enumadd): Likewise.
1361         (membcmp): Likewise.
1362         (membadd): Likewise.
1363         (ctf_add_type): Likewise.
1364
1365 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1366
1367         * ctf-lookup.c (isqualifier): New.
1368         (ctf_lookup_by_name): Likewise.
1369         (struct ctf_lookup_var_key): Likewise.
1370         (ctf_lookup_var): Likewise.
1371         (ctf_lookup_variable): Likewise.
1372         (ctf_lookup_symbol_name): Likewise.
1373         (ctf_lookup_by_symbol): Likewise.
1374         (ctf_func_info): Likewise.
1375         (ctf_func_args): Likewise.
1376
1377 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1378
1379         * ctf-decl.c: New file.
1380         * ctf-types.c: Likewise.
1381         * ctf-impl.h: New declarations.
1382
1383 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1384
1385         * ctf-open-bfd.c: New file.
1386         * ctf-open.c (ctf_close): New.
1387         * ctf-impl.h: Include bfd.h.
1388         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1389         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1390         ctfi_bfd_close.
1391         (ctf_bfdopen_ctfsect): New declaration.
1392         (_CTF_SECTION): likewise.
1393
1394 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1395
1396         * ctf-archive.c: New.
1397         * ctf-impl.h (ctf_archive_internal): New type.
1398         (ctf_arc_open_internal): New declaration.
1399         (ctf_arc_bufopen): Likewise.
1400         (ctf_arc_close_internal): Likewise.
1401
1402 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1403
1404         * ctf-open.c: New file.
1405         * swap.h: Likewise.
1406
1407 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1408
1409         * ctf-create.c: New file.
1410         * ctf-lookup.c: New file.
1411
1412 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1413
1414         * ctf-impl.h: New definitions and declarations for type creation
1415         and lookup.
1416
1417 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1418
1419         * ctf-hash.c: New file.
1420         * ctf-impl.h: New declarations.
1421
1422 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1423
1424         * ctf-error.c: New file.
1425
1426 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1427
1428         * ctf-util.c: New file.
1429         * elf.h: Likewise.
1430         * ctf-impl.h: Include it, and add declarations.
1431
1432 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1433
1434         * ctf-impl.h: New file.
1435         * ctf-subr.c: New file.
1436
1437 \f
1438 Local Variables:
1439 mode: change-log
1440 left-margin: 8
1441 fill-column: 76
1442 version-control: never
1443 End: