1 2020-02-05 Joel Brobecker <brobecker@adacore.com>
4 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
5 * configure, config.h.in: Regenerate.
7 2020-01-01 Alan Modra <amodra@gmail.com>
9 Update year range in copyright notice of all files.
11 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
13 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
15 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
17 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
18 * ctf-types.c (ctf_type_lname): Likewise.
20 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
22 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
23 ctf_import after the first for a given file.
25 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
27 * ctf-impl.h (ctf_str_append_noerr): Declare.
28 * ctf-util.c (ctf_str_append_noerr): Define in terms of
30 * ctf-dump.c (str_append): New, call it.
31 (ctf_dump_format_type): Use str_append, not ctf_str_append.
32 (ctf_dump_label): Likewise.
33 (ctf_dump_objts): Likewise.
34 (ctf_dump_funcs): Likewise.
35 (ctf_dump_var): Likewise.
36 (ctf_dump_member): Likewise.
37 (ctf_dump_type): Likewise.
40 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
42 * ctf-impl.h (ctf_alloc): Remove.
44 (ctf_strdup): Likewise.
45 * ctf-subr.c (ctf_alloc): Remove.
47 * ctf-util.c (ctf_strdup): Remove.
49 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
50 ctf_free; strdup, not ctf_strdup.
51 (ctf_dtd_delete): Likewise.
52 (ctf_dvd_delete): Likewise.
53 (ctf_add_generic): Likewise.
54 (ctf_add_function): Likewise.
55 (ctf_add_enumerator): Likewise.
56 (ctf_add_member_offset): Likewise.
57 (ctf_add_variable): Likewise.
59 (ctf_compress_write): Likewise.
60 (ctf_write_mem): Likewise.
61 * ctf-decl.c (ctf_decl_push): Likewise.
62 (ctf_decl_fini): Likewise.
63 (ctf_decl_sprintf): Likewise. Check for OOM.
64 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
65 ctf_free; strdup, not ctf_strdup.
66 (ctf_dump_free): Likewise.
68 * ctf-open.c (upgrade_types_v1): Likewise.
69 (init_types): Likewise.
70 (ctf_file_close): Likewise.
71 (ctf_bufopen_internal): Likewise. Check for OOM.
72 (ctf_parent_name_set): Likewise: report the OOM to the caller.
73 (ctf_cuname_set): Likewise.
74 (ctf_import): Likewise.
75 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
76 free, not ctf_free; strdup, not ctf_strdup.
77 (ctf_str_free_atom): Likewise.
78 (ctf_str_create_atoms): Likewise.
79 (ctf_str_add_ref_internal): Likewise.
80 (ctf_str_remove_ref): Likewise.
81 (ctf_str_write_strtab): Likewise.
83 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
85 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
86 work right for non-int/fps.
88 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
90 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
93 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
95 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
96 * ctf-open.c (ctf_file_close): Free it.
97 * ctf-create.c (ctf_serialize): Adjust.
98 (membcmp): When reporting a conflict due to an error, report the
100 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
101 (ctf_add_type_internal): ... this. Hand back types we are already
102 in the middle of adding immediately. Hand back structs/unions with
103 the same number of members immediately. Do not walk the dynamic
104 list. Call ctf_add_type_internal, not ctf_add_type. Handle
105 forwards promoted to other types and the inverse case identically.
106 Add structs to the mapping as soon as we intern them, before they
109 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
111 * ctf-impl.h (ctf_names_t): New.
112 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
113 (ctf_file_t) <ctf_structs>: Likewise.
114 <ctf_unions>: Likewise.
115 <ctf_enums>: Likewise.
116 <ctf_names>: Likewise.
117 <ctf_lookups>: Improve comment.
118 <ctf_ptrtab_len>: New.
119 <ctf_prov_strtab>: New.
120 <ctf_str_prov_offset>: New.
121 <ctf_dtbyname>: Remove, redundant to the names hashes.
122 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
123 (ctf_dtdef_t) <dtd_name>: Remove.
124 <dtd_data>: Note that the ctt_name is now populated.
125 (ctf_str_atom_t) <csa_offset>: This is now the strtab
126 offset for internal strings too.
127 <csa_external_offset>: New, the external strtab offset.
128 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
129 (ctf_name_table): New declaration.
130 (ctf_lookup_by_rawname): Likewise.
131 (ctf_lookup_by_rawhash): Likewise.
132 (ctf_set_ctl_hashes): Likewise.
133 (ctf_serialize): Likewise.
134 (ctf_dtd_insert): Adjust.
135 (ctf_simple_open_internal): Likewise.
136 (ctf_bufopen_internal): Likewise.
137 (ctf_list_empty_p): Likewise.
138 (ctf_str_remove_ref): Likewise.
139 (ctf_str_add): Returns uint32_t now.
140 (ctf_str_add_ref): Likewise.
141 (ctf_str_add_external): Now returns a boolean (int).
142 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
143 for strings in the appropriate range.
144 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
145 when adding the null string to the new strtab.
146 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
147 (ctf_str_add_ref_internal): Add make_provisional argument. If
148 make_provisional, populate the offset and fill in the
149 ctf_prov_strtab accordingly.
150 (ctf_str_add): Return the offset, not the string.
151 (ctf_str_add_ref): Likewise.
152 (ctf_str_add_external): Return a success integer.
153 (ctf_str_remove_ref): New, remove a single ref.
154 (ctf_str_count_strtab): Do not count the initial null string's
155 length or the existence or length of any unreferenced internal
157 (ctf_str_populate_sorttab): Skip atoms with no refs.
158 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
159 to the cts_len for the null string, since it is no longer done
160 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
161 Populate the csa_offset for both internal and external cases.
162 Flush the ctf_prov_strtab afterwards, and reset the
164 * ctf-create.c (ctf_grow_ptrtab): New.
165 (ctf_create): Call it. Initialize new fields rather than old
166 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
167 Set the ctl hashes and data model.
168 (ctf_update): Rename to...
169 (ctf_serialize): ... this. Leave a compatibility function behind.
170 Tell ctf_simple_open_internal that this is a writable dictionary.
171 Pass the new fields along from the old dictionary. Drop
172 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
173 Do not zero out the DTD's ctt_name.
174 (ctf_prefixed_name): Rename to...
175 (ctf_name_table): ... this. No longer return a prefixed name: return
176 the applicable name table instead.
177 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
178 kind we're adding. Migrate away from dtd_name.
179 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
181 (ctf_dtd_lookup_type_by_name): Remove.
182 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
183 No longer check ctf_dtnextid: check ctf_typemax instead.
184 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
185 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
186 ctf_name_table and the right name table, and migrate away from
187 dtd_name as in ctf_dtd_delete.
188 (ctf_add_generic): Pass in the kind explicitly and pass it to
189 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
190 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
191 Grow the ptrtab if needed.
192 (ctf_add_encoded): Pass in the kind.
193 (ctf_add_slice): Likewise.
194 (ctf_add_array): Likewise.
195 (ctf_add_function): Likewise.
196 (ctf_add_typedef): Likewise.
197 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
198 ctt_name rather than dtd_name.
199 (ctf_add_struct_sized): Pass in the kind. Use
200 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
201 ctf_dtd_lookup_type_by_name.
202 (ctf_add_union_sized): Likewise.
203 (ctf_add_enum): Likewise.
204 (ctf_add_enum_encoded): Likewise.
205 (ctf_add_forward): Likewise.
206 (ctf_add_type): Likewise.
207 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
208 being initialized until after the call.
209 (ctf_write_mem): Likewise.
210 (ctf_write): Likewise.
211 * ctf-archive.c (arc_write_one_ctf): Likewise.
212 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
213 ctf_hash_lookup_type.
214 (ctf_lookup_by_id): No longer check the readonly types if the
215 dictionary is writable.
216 * ctf-open.c (init_types): Assert that this dictionary is not
217 writable. Adjust to use the new name hashes, ctf_name_table,
218 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
219 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
220 if set. Drop out early when dictionary is writable. Split the
221 ctf_lookups initialization into...
222 (ctf_set_cth_hashes): ... this new function.
223 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
224 (ctf_simple_open): Adjust accordingly.
225 (ctf_bufopen): Likewise.
226 (ctf_file_close): Destroy the appropriate name hashes. No longer
227 destroy ctf_dtbyname, which is gone.
228 (ctf_getdatasect): Remove spurious "extern".
229 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
230 specified name table, given a kind.
231 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
232 (ctf_member_iter): Add support for iterating over the
234 (ctf_enum_iter): Likewise.
235 (ctf_variable_iter): Likewise.
236 (ctf_type_rvisit): Likewise.
237 (ctf_member_info): Add support for types in the dynamic type list.
238 (ctf_enum_name): Likewise.
239 (ctf_enum_value): Likewise.
240 (ctf_func_type_info): Likewise.
241 (ctf_func_type_args): Likewise.
242 * ctf-link.c (ctf_accumulate_archive_names): No longer call
244 (ctf_link_write): Likewise.
245 (ctf_link_intern_extern_string): Adjust for new
246 ctf_str_add_external return value.
247 (ctf_link_add_strtab): Likewise.
248 * ctf-util.c (ctf_list_empty_p): New.
250 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
252 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
254 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
256 (ctf_add_variable): Likewise for variables pointing to them.
257 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
258 type link failure, but do warn for others.
259 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
261 (ctf_dump_member): Likewise.
262 (ctf_dump_type): Likewise.
263 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
264 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
265 (ctf_dump_header): Likewise.
266 (ctf_dump_label): likewise.
267 (ctf_dump_objts): likewise.
268 (ctf_dump_funcs): likewise.
269 (ctf_dump_var): likewise.
270 (ctf_dump_str): Likewise.
272 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
274 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
276 (AM_INSTALL_LIBBFD): Likewise.
277 (dlopen): Note why this is necessary in a comment.
278 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
280 (SHARED_LDFLAGS): Likewise.
281 (BFD_LIBADD): Likewise, for libbfd.
282 (BFD_DEPENDENCIES): Likewise.
283 (VERSION_FLAGS): Initialize, using a version script if ld supports
284 one, or libtool -export-symbols-regex otherwise.
285 (AC_CONFIG_MACRO_DIR): Add ../BFD.
286 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
288 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
289 (noinst_LIBRARIES): Replace with...
290 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
291 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
292 libctf-nobfd.la as well.
293 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
294 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
295 (libctf_a_SOURCES): Rename to...
296 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
298 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
299 with ctf-open-bfd.c added.
300 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
301 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
302 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
303 * Makefile.am [INSTALL_LIBCTF]: Use it.
304 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
306 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
307 the unstable components).
308 * Makefile.in: Regenerated.
309 * config.h.in: Likewise.
310 * configure: Likewise.
312 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
314 * configure.ac (INSTALL_LIBCTF): New, controlled by
315 --enable-install-libctf.
316 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
317 * Makefile.in: Regenerated.
318 * configure: Regenerated.
320 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
322 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
323 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
325 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
327 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
329 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
331 * ctf-impl.h (includes): Include <sys/param.h> here.
333 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
335 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
336 (flip_objts): Likewise.
337 (flip_vars): Likewise.
338 (flip_types): Likewise.
340 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
342 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
343 freeing functions: if set, free the key and value if the slot
344 already exists. Always reassign the key.
345 (ctf_dynhash_insert): Adjust call appropriately.
346 (ctf_hash_insert_type): Likewise.
348 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
350 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
351 type kind. Allow forwards to unify with pre-existing structs/
354 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
356 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
357 <ctf_link_memb_name_changer>: Likewise.
358 <ctf_link_memb_name_changer_arg>: Likewise.
359 * ctf-create.c (ctf_update): Update accordingly.
360 * ctf-open.c (ctf_file_close): Likewise.
361 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
362 (ctf_link_add_cu_mapping): New.
363 (ctf_link_set_memb_name_changer): Likewise.
364 (ctf_change_parent_name): New.
365 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
366 allocated by the caller's ctf_link_memb_name_changer.
367 <ndynames>: Likewise.
368 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
369 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
370 ctf_change_parent_name. Free any resulting names.
372 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
374 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
375 (ctf_link_one_type): ... here, with parent-name setting added.
376 (check_variable): New.
377 (ctf_link_one_variable): Likewise.
378 (ctf_link_one_input_archive_member): Call it.
379 * ctf-error.c (_ctf_errlist): Updated with new errors.
381 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
383 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
384 (struct ctf_link_type_mapping_key): New.
385 (ctf_hash_type_mapping_key): Likewise.
386 (ctf_hash_eq_type_mapping_key): Likewise.
387 (ctf_add_type_mapping): Likewise.
388 (ctf_type_mapping): Likewise.
389 (ctf_dynhash_empty): Likewise.
390 * ctf-open.c (ctf_file_close): Update accordingly.
391 * ctf-create.c (ctf_update): Likewise.
392 (ctf_add_type): Populate the mapping.
393 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
394 (ctf_hash_eq_type_mapping_key): Check the key for equality.
395 (ctf_dynhash_insert): Fix comment typo.
396 (ctf_dynhash_empty): New.
397 * ctf-link.c (ctf_add_type_mapping): New.
398 (ctf_type_mapping): Likewise.
399 (empty_link_type_mapping): New.
400 (ctf_link_one_input_archive): Call it.
402 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
404 * ctf-link.c: New file, linking of the string and type sections.
405 * Makefile.am (libctf_a_SOURCES): Add it.
406 * Makefile.in: Regenerate.
408 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
410 * ctf-create.c (ctf_update): Update accordingly.
411 * ctf-open.c (ctf_file_close): Likewise.
412 * ctf-error.c (_ctf_errlist): Updated with new errors.
414 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
416 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
418 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
420 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
422 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
423 (ctf_dump_format_type): Add non-root-type { } notation.
424 Add root flag to prototype.
425 (ctf_dump_label): Adjust accordingly.
426 (ctf_dump_objts): Likewise.
427 (ctf_dump_var): Likewise.
429 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
431 * ctf-create.c (ctf_compress_write): Fix double-free.
433 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
435 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
437 (ctf_arc_write_fd): ... this new function.
438 * ctf-create.c (ctf_write_mem): New.
440 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
442 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
443 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
444 (ctf_str_add_ref): Name the last arg.
445 (ctf_str_add_external) New.
446 (ctf_str_add_strraw_explicit): Likewise.
447 (ctf_simple_open_internal): Likewise.
448 (ctf_bufopen_internal): Likewise.
450 * ctf-string.c (ctf_strraw_explicit): Split from...
451 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
452 (ctf_str_add_ref_internal): Return the atom, not the
454 (ctf_str_add): Adjust accordingly.
455 (ctf_str_add_ref): Likewise. Move up in the file.
456 (ctf_str_add_external): New: update the csa_offset.
457 (ctf_str_count_strtab): Only account for strings with no csa_offset
458 in the internal strtab length.
459 (ctf_str_write_strtab): If the csa_offset is set, update the
460 string's refs without writing the string out, and update the
461 ctf_syn_ext_strtab. Make OOM handling less ugly.
462 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
463 (ctf_update): Handle failure to populate the strtab. Pass in the
464 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
465 Call ctf_simple_open_internal, not ctf_simple_open.
466 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
468 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
469 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
470 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
471 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
472 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
473 (ctf_simple_open_internal): ... this new function, which calls
474 ctf_bufopen_internal.
475 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
476 (ctf_bufopen_internal): ... this new function, which sets
479 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
481 * ctf_types.c (ctf_type_iter_all): New.
483 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
485 * ctf-open.c (init_symtab): Check for overflow against the right
487 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
488 (upgrade_types_v1): Note that these sections are not checked.
489 (flip_header): Endian-swap the header fields.
490 (flip_ctf): Endian-swap the sections.
491 (flip_objts): Update comment.
492 (ctf_bufopen): Check header offsets and alignment for validity.
494 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
496 * ctf-open-bfd.c: Add <assert.h>.
497 (ctf_bfdopen_ctfsect): Open string and symbol tables using
498 techniques borrowed from bfd_elf_sym_name.
499 (ctf_new_archive_internal): Improve comment.
500 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
501 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
502 no symbol section, but not vice versa.
504 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
506 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
507 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
508 * ctf-dump.c (dump_header): New function, dump the CTF header.
510 (ctf_dump_header_strfield): New function.
511 (ctf_dump_header_sectfield): Likewise.
513 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
515 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
516 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
517 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
518 ctf_base: do not assume that it is always sizeof (ctf_header_t).
519 Print out ctf_cuname: only print out ctf_parname if set.
520 (ctf_free_base): Removed, ctf_base is no longer freed: free
522 (ctf_set_version): Fix spacing.
523 (upgrade_header): New, in-place header upgrading.
524 (upgrade_types): Rename to...
525 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
526 longer track old and new headers separately. No longer allow for
527 header sizes explicitly: squeeze the headers out on upgrade (they
528 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
529 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
530 (upgrade_types): New, also handle ctf_parmax updating.
531 (flip_header): Flip ctf_cuname.
532 (flip_types): Flip BUF explicitly rather than deriving BUF from
534 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
535 required alignment of objtoff and funcoff. No longer store it in
536 the ctf_buf unless that buf is derived unmodified from the input.
537 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
538 that duplicate fields in ctf_file: move allocation of ctf_file
539 further up instead. Call upgrade_header as needed. Move
540 version-specific ctf_parmax initialization into upgrade_types. More
541 concise error handling.
542 (ctf_file_close): No longer test for null pointers before freeing.
543 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
546 (ctf_cuname_set): New.
547 * ctf-create.c (ctf_update): Populate ctf_cuname.
548 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
550 (ctf_write): Likewise.
551 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
552 Fix the compression length: fp->ctf_size never counted the CTF
553 header. Simplify the compress call accordingly.
555 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
557 * ctf-endian.h: Don't assume htole64 and le64toh are always
558 present if HAVE_ENDIAN_H; also check if htole64 is defined.
559 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
560 not bswap_identity_64.
562 2019-09-18 Alan Modra <amodra@gmail.com>
564 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
566 2019-09-09 Phil Blundell <pb@pbcl.net>
568 binutils 2.33 branch created.
570 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
572 * ctf-types.c (ctf_type_aname_raw): New.
573 (ctf_func_type_info): Likewise.
574 (ctf_func_type_args): Likewise.
575 * ctf-error.c (_ctf_errlist): Fix description.
576 * ctf-lookup.c: Fix file description.
578 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
580 * ctf-create.c (ctf_create): Fix off-by-one error.
582 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
584 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
586 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
587 (struct ctf_str_atom): New, disambiguated single string.
588 (struct ctf_str_atom_ref): New, points to some other location that
589 references this string's offset.
590 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
591 Remove member ctf_dtvstrlen: we no longer track the total strlen
593 (ctf_str_create_atoms): Declare new function in ctf-string.c.
594 (ctf_str_free_atoms): Likewise.
595 (ctf_str_add): Likewise.
596 (ctf_str_add_ref): Likewise.
597 (ctf_str_rollback): Likewise.
598 (ctf_str_purge_refs): Likewise.
599 (ctf_str_write_strtab): Likewise.
600 (ctf_realloc): Declare new function in ctf-util.c.
602 * ctf-open.c (ctf_bufopen): Create the atoms table.
603 (ctf_file_close): Destroy it.
604 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
605 special-case the position of the parname string. Construct the
606 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
607 rest of each buffer element is constructed, not via open-coding:
608 realloc the CTF buffer and append the strtab to it. No longer
609 maintain ctf_dtvstrlen. Sort the variable entry table later, after
611 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
612 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
613 after buffer element construction instead.
614 (ctf_copy_lmembers): Likewise.
615 (ctf_copy_emembers): Likewise.
616 (ctf_create): No longer maintain the ctf_dtvstrlen.
617 (ctf_dtd_delete): Likewise.
618 (ctf_dvd_delete): Likewise.
619 (ctf_add_generic): Likewise.
620 (ctf_add_enumerator): Likewise.
621 (ctf_add_member_offset): Likewise.
622 (ctf_add_variable): Likewise.
624 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
625 if there are active ctf_str_num_refs.
626 (ctf_strraw): Move to ctf-string.c.
627 (ctf_strptr): Likewise.
628 * ctf-string.c: New file, strtab manipulation.
630 * Makefile.am (libctf_a_SOURCES): Add it.
631 * Makefile.in: Regenerate.
633 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
635 * ctf-impl.h (ctf_hash_iter_f): New.
636 (ctf_dynhash_iter): New declaration.
637 (ctf_dynhash_iter_remove): New declaration.
638 * ctf-hash.c (ctf_dynhash_iter): Define.
639 (ctf_dynhash_iter_remove): Likewise.
640 (ctf_hashtab_traverse): New.
641 (ctf_hashtab_traverse_remove): Likewise.
642 (struct ctf_traverse_cb_arg): Likewise.
643 (struct ctf_traverse_remove_cb_arg): Likewise.
645 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
647 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
649 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
651 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
652 (ctf_dump_funcs): Likewise.
654 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
656 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
657 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
658 little-endian CTF archive magic. Do not check the CTF version:
659 ctf_simple_open does that in endian-safe ways. Do not dereference
660 null pointers on open failure.
662 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
664 * ctf-open.c (get_vbytes_common): Return the new slice size.
665 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
666 Remember to copy in the CTF data when opening an uncompressed
667 foreign-endian CTF file. Prune useless variable manipulation.
669 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
671 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
674 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
676 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
679 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
681 * ctf-subr.c (_PAGESIZE): Remove.
682 (ctf_data_alloc): Likewise.
683 (ctf_data_free): Likewise.
684 (ctf_data_protect): Likewise.
685 * ctf-impl.h: Remove declarations.
686 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
687 ctf_free, not ctf_data_free.
688 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
689 the buffer again on compression error.
690 * ctf-open.c (ctf_set_base): No longer track the size: call
691 ctf_free, not ctf_data_free.
692 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
693 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
695 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
697 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
699 (ctf_dvd_insert): Likewise.
700 (ctf_add_generic): Likewise.
701 (ctf_add_variable): Likewise.
702 * ctf-impl.h: Adjust declarations.
704 2019-06-14 Alan Modra <amodra@gmail.com>
706 * configure: Regenerate.
708 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
710 * ctf-decls.h: Include <libiberty.h>.
711 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
713 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
715 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
716 (ctf_dump_objts): Likewise.
717 (ctf_dump_funcs): Likewise.
718 (ctf_dump_member): Likewise.
719 (ctf_dump_str): Likewise.
721 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
723 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
724 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
726 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
728 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
729 (ctf_arc_open_by_offset): Likewise.
730 * ctf-create.c (ctf_add_type): Likewise.
732 2019-06-04 Tom Tromey <tromey@adacore.com>
734 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
735 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
737 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
739 * configure.ac: Check for O_CLOEXEC.
740 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
741 * config.h.in: Regenerate.
742 * configure: Likewise.
744 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
746 * qsort_r.c: Rename to...
747 * ctf-qsort_r.c: ... this.
748 (_quicksort): Define to ctf_qsort_r.
749 * ctf-decls.h (qsort_r): Remove.
751 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
752 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
753 * Makefile.am (libctf_a_LIBADD): Remove.
754 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
755 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
756 * ctf-create.c (ctf_update): Likewise.
757 * configure.ac: Check for BSD versus GNU qsort_r signature.
758 * Makefile.in: Regenerate.
759 * config.h.in: Likewise.
760 * configure: Likewise.
762 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
764 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
766 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
768 * Makefile.am (ZLIB): New.
770 (AM_CFLAGS): Use them.
771 (libctf_a_LIBADD): New, for LIBOBJS.
772 * configure.ac: Check for zlib, endian.h, and qsort_r.
773 * ctf-endian.h: New, providing htole64 and le64toh.
774 * swap.h: Code style fixes.
775 (bswap_identity_64): New.
776 * qsort_r.c: New, from gnulib (with one added #include).
777 * ctf-decls.h: New, providing a conditional qsort_r declaration,
778 and unconditional definitions of MIN and MAX.
779 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
780 (ctf_set_errno): Now returns unsigned long.
781 * ctf-util.c (ctf_set_errno): Adjust here too.
782 * ctf-archive.c: Use ctf-endian.h.
783 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
784 cts_flags and cts_offset.
785 (ctf_arc_write): Drop debugging dependent on the size of off_t.
786 * ctf-create.c: Provide a definition of roundup if not defined.
787 (ctf_create): Drop cts_type, cts_flags and cts_offset.
788 (ctf_add_reftype): Do not check if type IDs are below zero.
789 (ctf_add_slice): Likewise.
790 (ctf_add_typedef): Likewise.
791 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
792 when known error-free. Drop CTF_ERR usage for functions returning
794 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
796 (ctf_add_variable): Likewise.
800 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
801 when known error-free.
802 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
803 returning int: use CTF_ERR for functions returning ctf_type_id.
804 (ctf_dump_label): Likewise.
805 (ctf_dump_objts): Likewise.
806 * ctf-labels.c (ctf_label_topmost): Likewise.
807 (ctf_label_iter): Likewise.
808 (ctf_label_info): Likewise.
809 * ctf-lookup.c (ctf_func_args): Likewise.
810 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
811 (ctf_bufopen): Likewise. Use zlib types as needed.
812 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
814 (ctf_enum_iter): Likewise.
815 (ctf_type_size): Likewise.
816 (ctf_type_align): Likewise. Cast to size_t where appropriate.
817 (ctf_type_kind_unsliced): Likewise.
818 (ctf_type_kind): Likewise.
819 (ctf_type_encoding): Likewise.
820 (ctf_member_info): Likewise.
821 (ctf_array_info): Likewise.
822 (ctf_enum_value): Likewise.
823 (ctf_type_rvisit): Likewise.
824 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
826 (ctf_simple_open): Likewise.
827 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
828 * Makefile.in: Regenerate.
829 * aclocal.m4: Likewise.
830 * config.h: Likewise.
831 * configure: Likewise.
833 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
835 * configure.in: Check for bfd_section_from_elf_index.
836 * configure: Regenerate.
837 * config.h.in [HAVE_BFD_ELF]: Likewise.
838 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
839 abfd is potentially unused now.
841 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
844 * Makefile.in: Regenerated.
845 * config.h.in: Likewise.
846 * aclocal.m4: Likewise.
847 * configure: Likewise.
849 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
853 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
857 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
859 * ctf-impl.h (_libctf_version): New declaration.
860 * ctf-subr.c (_libctf_version): Define it.
863 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
865 * ctf-create.c (enumcmp): New.
869 (ctf_add_type): Likewise.
871 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
873 * ctf-lookup.c (isqualifier): New.
874 (ctf_lookup_by_name): Likewise.
875 (struct ctf_lookup_var_key): Likewise.
876 (ctf_lookup_var): Likewise.
877 (ctf_lookup_variable): Likewise.
878 (ctf_lookup_symbol_name): Likewise.
879 (ctf_lookup_by_symbol): Likewise.
880 (ctf_func_info): Likewise.
881 (ctf_func_args): Likewise.
883 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
885 * ctf-decl.c: New file.
886 * ctf-types.c: Likewise.
887 * ctf-impl.h: New declarations.
889 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
891 * ctf-open-bfd.c: New file.
892 * ctf-open.c (ctf_close): New.
893 * ctf-impl.h: Include bfd.h.
894 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
895 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
897 (ctf_bfdopen_ctfsect): New declaration.
898 (_CTF_SECTION): likewise.
900 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
902 * ctf-archive.c: New.
903 * ctf-impl.h (ctf_archive_internal): New type.
904 (ctf_arc_open_internal): New declaration.
905 (ctf_arc_bufopen): Likewise.
906 (ctf_arc_close_internal): Likewise.
908 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
910 * ctf-open.c: New file.
913 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
915 * ctf-create.c: New file.
916 * ctf-lookup.c: New file.
918 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
920 * ctf-impl.h: New definitions and declarations for type creation
923 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
925 * ctf-hash.c: New file.
926 * ctf-impl.h: New declarations.
928 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
930 * ctf-error.c: New file.
932 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
934 * ctf-util.c: New file.
936 * ctf-impl.h: Include it, and add declarations.
938 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
940 * ctf-impl.h: New file.
941 * ctf-subr.c: New file.
948 version-control: never