2 * Copyright © 2018 Valve Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
33 void perfwarn(bool cond
, const char *msg
, Instruction
*instr
)
36 fprintf(stderr
, "ACO performance warning: %s\n", msg
);
38 fprintf(stderr
, "instruction: ");
39 aco_print_instr(instr
, stderr
);
40 fprintf(stderr
, "\n");
43 if (debug_flags
& DEBUG_PERFWARN
)
49 void validate(Program
* program
, FILE * output
)
51 if (!(debug_flags
& DEBUG_VALIDATE
))
55 auto check
= [&output
, &is_valid
](bool check
, const char * msg
, aco::Instruction
* instr
) -> void {
57 fprintf(output
, "%s: ", msg
);
58 aco_print_instr(instr
, output
);
59 fprintf(output
, "\n");
63 auto check_block
= [&output
, &is_valid
](bool check
, const char * msg
, aco::Block
* block
) -> void {
65 fprintf(output
, "%s: BB%u\n", msg
, block
->index
);
70 for (Block
& block
: program
->blocks
) {
71 for (aco_ptr
<Instruction
>& instr
: block
.instructions
) {
73 /* check base format */
74 Format base_format
= instr
->format
;
75 base_format
= (Format
)((uint32_t)base_format
& ~(uint32_t)Format::SDWA
);
76 base_format
= (Format
)((uint32_t)base_format
& ~(uint32_t)Format::DPP
);
77 if ((uint32_t)base_format
& (uint32_t)Format::VOP1
)
78 base_format
= Format::VOP1
;
79 else if ((uint32_t)base_format
& (uint32_t)Format::VOP2
)
80 base_format
= Format::VOP2
;
81 else if ((uint32_t)base_format
& (uint32_t)Format::VOPC
)
82 base_format
= Format::VOPC
;
83 else if ((uint32_t)base_format
& (uint32_t)Format::VINTRP
)
84 base_format
= Format::VINTRP
;
85 check(base_format
== instr_info
.format
[(int)instr
->opcode
], "Wrong base format for instruction", instr
.get());
87 /* check VOP3 modifiers */
88 if (((uint32_t)instr
->format
& (uint32_t)Format::VOP3
) && instr
->format
!= Format::VOP3
) {
89 check(base_format
== Format::VOP2
||
90 base_format
== Format::VOP1
||
91 base_format
== Format::VOPC
||
92 base_format
== Format::VINTRP
,
93 "Format cannot have VOP3A/VOP3B applied", instr
.get());
97 if (instr
->isSDWA()) {
98 check(base_format
== Format::VOP2
||
99 base_format
== Format::VOP1
||
100 base_format
== Format::VOPC
,
101 "Format cannot have SDWA applied", instr
.get());
103 check(program
->chip_class
>= GFX8
, "SDWA is GFX8+ only", instr
.get());
105 SDWA_instruction
*sdwa
= static_cast<SDWA_instruction
*>(instr
.get());
106 check(sdwa
->omod
== 0 || program
->chip_class
>= GFX9
, "SDWA omod only supported on GFX9+", instr
.get());
107 if (base_format
== Format::VOPC
) {
108 check(sdwa
->clamp
== false || program
->chip_class
== GFX8
, "SDWA VOPC clamp only supported on GFX8", instr
.get());
109 check((instr
->definitions
[0].isFixed() && instr
->definitions
[0].physReg() == vcc
) ||
110 program
->chip_class
>= GFX9
,
111 "SDWA+VOPC definition must be fixed to vcc on GFX8", instr
.get());
114 if (instr
->operands
.size() >= 3) {
115 check(instr
->operands
[2].isFixed() && instr
->operands
[2].physReg() == vcc
,
116 "3rd operand must be fixed to vcc with SDWA", instr
.get());
118 if (instr
->definitions
.size() >= 2) {
119 check(instr
->definitions
[1].isFixed() && instr
->definitions
[1].physReg() == vcc
,
120 "2nd definition must be fixed to vcc with SDWA", instr
.get());
123 check(instr
->opcode
!= aco_opcode::v_madmk_f32
&&
124 instr
->opcode
!= aco_opcode::v_madak_f32
&&
125 instr
->opcode
!= aco_opcode::v_madmk_f16
&&
126 instr
->opcode
!= aco_opcode::v_madak_f16
&&
127 instr
->opcode
!= aco_opcode::v_readfirstlane_b32
&&
128 instr
->opcode
!= aco_opcode::v_clrexcp
&&
129 instr
->opcode
!= aco_opcode::v_swap_b32
,
130 "SDWA can't be used with this opcode", instr
.get());
131 if (program
->chip_class
!= GFX8
) {
132 check(instr
->opcode
!= aco_opcode::v_mac_f32
&&
133 instr
->opcode
!= aco_opcode::v_mac_f16
&&
134 instr
->opcode
!= aco_opcode::v_fmac_f32
&&
135 instr
->opcode
!= aco_opcode::v_fmac_f16
,
136 "SDWA can't be used with this opcode", instr
.get());
141 if (instr
->isVOP3()) {
142 VOP3A_instruction
*vop3
= static_cast<VOP3A_instruction
*>(instr
.get());
143 check(vop3
->opsel
== 0 || program
->chip_class
>= GFX9
, "Opsel is only supported on GFX9+", instr
.get());
144 check((vop3
->opsel
& ~(0x10 | ((1 << instr
->operands
.size()) - 1))) == 0, "Unused bits in opsel must be zeroed out", instr
.get());
147 /* check for undefs */
148 for (unsigned i
= 0; i
< instr
->operands
.size(); i
++) {
149 if (instr
->operands
[i
].isUndefined()) {
150 bool flat
= instr
->format
== Format::FLAT
|| instr
->format
== Format::SCRATCH
|| instr
->format
== Format::GLOBAL
;
151 bool can_be_undef
= is_phi(instr
) || instr
->format
== Format::EXP
||
152 instr
->format
== Format::PSEUDO_REDUCTION
||
153 instr
->opcode
== aco_opcode::p_create_vector
||
154 (flat
&& i
== 1) || (instr
->format
== Format::MIMG
&& i
== 1) ||
155 ((instr
->format
== Format::MUBUF
|| instr
->format
== Format::MTBUF
) && i
== 1);
156 check(can_be_undef
, "Undefs can only be used in certain operands", instr
.get());
160 if (instr
->isSALU() || instr
->isVALU()) {
163 for (unsigned i
= 0; i
< instr
->operands
.size(); i
++)
165 Operand op
= instr
->operands
[i
];
169 check(instr
->format
== Format::SOP1
||
170 instr
->format
== Format::SOP2
||
171 instr
->format
== Format::SOPC
||
172 instr
->format
== Format::VOP1
||
173 instr
->format
== Format::VOP2
||
174 instr
->format
== Format::VOPC
||
175 (instr
->isVOP3() && program
->chip_class
>= GFX10
),
176 "Literal applied on wrong instruction format", instr
.get());
178 check(literal
.isUndefined() || (literal
.size() == op
.size() && literal
.constantValue() == op
.constantValue()), "Only 1 Literal allowed", instr
.get());
180 check(!instr
->isVALU() || instr
->isVOP3() || i
== 0 || i
== 2, "Wrong source position for Literal argument", instr
.get());
183 /* check num sgprs for VALU */
184 if (instr
->isVALU()) {
185 bool is_shift64
= instr
->opcode
== aco_opcode::v_lshlrev_b64
||
186 instr
->opcode
== aco_opcode::v_lshrrev_b64
||
187 instr
->opcode
== aco_opcode::v_ashrrev_i64
;
188 unsigned const_bus_limit
= 1;
189 if (program
->chip_class
>= GFX10
&& !is_shift64
)
192 uint32_t scalar_mask
= instr
->isVOP3() ? 0x7 : 0x5;
194 scalar_mask
= program
->chip_class
>= GFX9
? 0x7 : 0x4;
196 check(instr
->definitions
[0].getTemp().type() == RegType::vgpr
||
197 (int) instr
->format
& (int) Format::VOPC
||
198 instr
->opcode
== aco_opcode::v_readfirstlane_b32
||
199 instr
->opcode
== aco_opcode::v_readlane_b32
||
200 instr
->opcode
== aco_opcode::v_readlane_b32_e64
,
201 "Wrong Definition type for VALU instruction", instr
.get());
202 unsigned num_sgprs
= 0;
203 unsigned sgpr
[] = {0, 0};
204 for (unsigned i
= 0; i
< instr
->operands
.size(); i
++)
206 Operand op
= instr
->operands
[i
];
207 if (instr
->opcode
== aco_opcode::v_readfirstlane_b32
||
208 instr
->opcode
== aco_opcode::v_readlane_b32
||
209 instr
->opcode
== aco_opcode::v_readlane_b32_e64
||
210 instr
->opcode
== aco_opcode::v_writelane_b32
||
211 instr
->opcode
== aco_opcode::v_writelane_b32_e64
) {
212 check(!op
.isLiteral(), "No literal allowed on VALU instruction", instr
.get());
213 check(i
== 1 || (op
.isTemp() && op
.regClass() == v1
), "Wrong Operand type for VALU instruction", instr
.get());
216 if (op
.isTemp() && instr
->operands
[i
].regClass().type() == RegType::sgpr
) {
217 check(scalar_mask
& (1 << i
), "Wrong source position for SGPR argument", instr
.get());
219 if (op
.tempId() != sgpr
[0] && op
.tempId() != sgpr
[1]) {
221 sgpr
[num_sgprs
++] = op
.tempId();
225 if (op
.isConstant() && !op
.isLiteral())
226 check(scalar_mask
& (1 << i
), "Wrong source position for constant argument", instr
.get());
228 check(num_sgprs
+ (literal
.isUndefined() ? 0 : 1) <= const_bus_limit
, "Too many SGPRs/literals", instr
.get());
231 if (instr
->format
== Format::SOP1
|| instr
->format
== Format::SOP2
) {
232 check(instr
->definitions
[0].getTemp().type() == RegType::sgpr
, "Wrong Definition type for SALU instruction", instr
.get());
233 for (const Operand
& op
: instr
->operands
) {
234 check(op
.isConstant() || op
.regClass().type() <= RegType::sgpr
,
235 "Wrong Operand type for SALU instruction", instr
.get());
240 switch (instr
->format
) {
241 case Format::PSEUDO
: {
242 if (instr
->opcode
== aco_opcode::p_create_vector
) {
244 for (const Operand
& op
: instr
->operands
) {
247 check(size
== instr
->definitions
[0].bytes(), "Definition size does not match operand sizes", instr
.get());
248 if (instr
->definitions
[0].getTemp().type() == RegType::sgpr
) {
249 for (const Operand
& op
: instr
->operands
) {
250 check(op
.isConstant() || op
.regClass().type() == RegType::sgpr
,
251 "Wrong Operand type for scalar vector", instr
.get());
254 } else if (instr
->opcode
== aco_opcode::p_extract_vector
) {
255 check((instr
->operands
[0].isTemp()) && instr
->operands
[1].isConstant(), "Wrong Operand types", instr
.get());
256 check(instr
->operands
[1].constantValue() < instr
->operands
[0].size(), "Index out of range", instr
.get());
257 check(instr
->definitions
[0].getTemp().type() == RegType::vgpr
|| instr
->operands
[0].regClass().type() == RegType::sgpr
,
258 "Cannot extract SGPR value from VGPR vector", instr
.get());
259 } else if (instr
->opcode
== aco_opcode::p_parallelcopy
) {
260 check(instr
->definitions
.size() == instr
->operands
.size(), "Number of Operands does not match number of Definitions", instr
.get());
261 for (unsigned i
= 0; i
< instr
->operands
.size(); i
++) {
262 if (instr
->operands
[i
].isTemp())
263 check((instr
->definitions
[i
].getTemp().type() == instr
->operands
[i
].regClass().type()) ||
264 (instr
->definitions
[i
].getTemp().type() == RegType::vgpr
&& instr
->operands
[i
].regClass().type() == RegType::sgpr
),
265 "Operand and Definition types do not match", instr
.get());
267 } else if (instr
->opcode
== aco_opcode::p_phi
) {
268 check(instr
->operands
.size() == block
.logical_preds
.size(), "Number of Operands does not match number of predecessors", instr
.get());
269 check(instr
->definitions
[0].getTemp().type() == RegType::vgpr
|| instr
->definitions
[0].getTemp().regClass() == program
->lane_mask
, "Logical Phi Definition must be vgpr or divergent boolean", instr
.get());
270 } else if (instr
->opcode
== aco_opcode::p_linear_phi
) {
271 for (const Operand
& op
: instr
->operands
)
272 check(!op
.isTemp() || op
.getTemp().is_linear(), "Wrong Operand type", instr
.get());
273 check(instr
->operands
.size() == block
.linear_preds
.size(), "Number of Operands does not match number of predecessors", instr
.get());
278 if (instr
->operands
.size() >= 1)
279 check(instr
->operands
[0].isTemp() && instr
->operands
[0].regClass().type() == RegType::sgpr
, "SMEM operands must be sgpr", instr
.get());
280 if (instr
->operands
.size() >= 2)
281 check(instr
->operands
[1].isConstant() || (instr
->operands
[1].isTemp() && instr
->operands
[1].regClass().type() == RegType::sgpr
),
282 "SMEM offset must be constant or sgpr", instr
.get());
283 if (!instr
->definitions
.empty())
284 check(instr
->definitions
[0].getTemp().type() == RegType::sgpr
, "SMEM result must be sgpr", instr
.get());
288 case Format::MUBUF
: {
289 check(instr
->operands
.size() > 1, "VMEM instructions must have at least one operand", instr
.get());
290 check(instr
->operands
[1].hasRegClass() && instr
->operands
[1].regClass().type() == RegType::vgpr
,
291 "VADDR must be in vgpr for VMEM instructions", instr
.get());
292 check(instr
->operands
[0].isTemp() && instr
->operands
[0].regClass().type() == RegType::sgpr
, "VMEM resource constant must be sgpr", instr
.get());
293 check(instr
->operands
.size() < 4 || (instr
->operands
[3].isTemp() && instr
->operands
[3].regClass().type() == RegType::vgpr
), "VMEM write data must be vgpr", instr
.get());
297 check(instr
->operands
.size() == 3, "MIMG instructions must have exactly 3 operands", instr
.get());
298 check(instr
->operands
[0].hasRegClass() && (instr
->operands
[0].regClass() == s4
|| instr
->operands
[0].regClass() == s8
),
299 "MIMG operands[0] (resource constant) must be in 4 or 8 SGPRs", instr
.get());
300 if (instr
->operands
[1].hasRegClass() && instr
->operands
[1].regClass().type() == RegType::sgpr
)
301 check(instr
->operands
[1].regClass() == s4
, "MIMG operands[1] (sampler constant) must be 4 SGPRs", instr
.get());
302 else if (instr
->operands
[1].hasRegClass() && instr
->operands
[1].regClass().type() == RegType::vgpr
)
303 check((instr
->definitions
.empty() || instr
->definitions
[0].regClass() == instr
->operands
[1].regClass() ||
304 instr
->opcode
== aco_opcode::image_atomic_cmpswap
|| instr
->opcode
== aco_opcode::image_atomic_fcmpswap
),
305 "MIMG operands[1] (VDATA) must be the same as definitions[0] for atomics", instr
.get());
306 check(instr
->operands
[2].hasRegClass() && instr
->operands
[2].regClass().type() == RegType::vgpr
,
307 "MIMG operands[2] (VADDR) must be VGPR", instr
.get());
308 check(instr
->definitions
.empty() || (instr
->definitions
[0].isTemp() && instr
->definitions
[0].regClass().type() == RegType::vgpr
),
309 "MIMG definitions[0] (VDATA) must be VGPR", instr
.get());
313 for (const Operand
& op
: instr
->operands
) {
314 check((op
.isTemp() && op
.regClass().type() == RegType::vgpr
) || op
.physReg() == m0
,
315 "Only VGPRs are valid DS instruction operands", instr
.get());
317 if (!instr
->definitions
.empty())
318 check(instr
->definitions
[0].getTemp().type() == RegType::vgpr
, "DS instruction must return VGPR", instr
.get());
322 for (unsigned i
= 0; i
< 4; i
++)
323 check(instr
->operands
[i
].hasRegClass() && instr
->operands
[i
].regClass().type() == RegType::vgpr
,
324 "Only VGPRs are valid Export arguments", instr
.get());
328 check(instr
->operands
[1].isUndefined(), "Flat instructions don't support SADDR", instr
.get());
331 case Format::SCRATCH
: {
332 check(instr
->operands
[0].isTemp() && instr
->operands
[0].regClass().type() == RegType::vgpr
, "FLAT/GLOBAL/SCRATCH address must be vgpr", instr
.get());
333 check(instr
->operands
[1].hasRegClass() && instr
->operands
[1].regClass().type() == RegType::sgpr
,
334 "FLAT/GLOBAL/SCRATCH sgpr address must be undefined or sgpr", instr
.get());
335 if (!instr
->definitions
.empty())
336 check(instr
->definitions
[0].getTemp().type() == RegType::vgpr
, "FLAT/GLOBAL/SCRATCH result must be vgpr", instr
.get());
338 check(instr
->operands
[2].regClass().type() == RegType::vgpr
, "FLAT/GLOBAL/SCRATCH data must be vgpr", instr
.get());
348 for (unsigned i
= 0; i
< program
->blocks
.size(); i
++) {
349 Block
& block
= program
->blocks
[i
];
350 check_block(block
.index
== i
, "block.index must match actual index", &block
);
352 /* predecessors/successors should be sorted */
353 for (unsigned j
= 0; j
+ 1 < block
.linear_preds
.size(); j
++)
354 check_block(block
.linear_preds
[j
] < block
.linear_preds
[j
+ 1], "linear predecessors must be sorted", &block
);
355 for (unsigned j
= 0; j
+ 1 < block
.logical_preds
.size(); j
++)
356 check_block(block
.logical_preds
[j
] < block
.logical_preds
[j
+ 1], "logical predecessors must be sorted", &block
);
357 for (unsigned j
= 0; j
+ 1 < block
.linear_succs
.size(); j
++)
358 check_block(block
.linear_succs
[j
] < block
.linear_succs
[j
+ 1], "linear successors must be sorted", &block
);
359 for (unsigned j
= 0; j
+ 1 < block
.logical_succs
.size(); j
++)
360 check_block(block
.logical_succs
[j
] < block
.logical_succs
[j
+ 1], "logical successors must be sorted", &block
);
362 /* critical edges are not allowed */
363 if (block
.linear_preds
.size() > 1) {
364 for (unsigned pred
: block
.linear_preds
)
365 check_block(program
->blocks
[pred
].linear_succs
.size() == 1, "linear critical edges are not allowed", &program
->blocks
[pred
]);
366 for (unsigned pred
: block
.logical_preds
)
367 check_block(program
->blocks
[pred
].logical_succs
.size() == 1, "logical critical edges are not allowed", &program
->blocks
[pred
]);
378 Location() : block(NULL
), instr(NULL
) {}
381 Instruction
*instr
; //NULL if it's the block's live-in
390 bool ra_fail(FILE *output
, Location loc
, Location loc2
, const char *fmt
, ...) {
394 vsprintf(msg
, fmt
, args
);
397 fprintf(stderr
, "RA error found at instruction in BB%d:\n", loc
.block
->index
);
399 aco_print_instr(loc
.instr
, stderr
);
400 fprintf(stderr
, "\n%s", msg
);
402 fprintf(stderr
, "%s", msg
);
405 fprintf(stderr
, " in BB%d:\n", loc2
.block
->index
);
406 aco_print_instr(loc2
.instr
, stderr
);
408 fprintf(stderr
, "\n\n");
413 } /* end namespace */
415 bool validate_ra(Program
*program
, const struct radv_nir_compiler_options
*options
, FILE *output
) {
416 if (!(debug_flags
& DEBUG_VALIDATE_RA
))
420 aco::live live_vars
= aco::live_var_analysis(program
, options
);
421 std::vector
<std::vector
<Temp
>> phi_sgpr_ops(program
->blocks
.size());
423 std::map
<unsigned, Assignment
> assignments
;
424 for (Block
& block
: program
->blocks
) {
427 for (aco_ptr
<Instruction
>& instr
: block
.instructions
) {
428 if (instr
->opcode
== aco_opcode::p_phi
) {
429 for (unsigned i
= 0; i
< instr
->operands
.size(); i
++) {
430 if (instr
->operands
[i
].isTemp() &&
431 instr
->operands
[i
].getTemp().type() == RegType::sgpr
&&
432 instr
->operands
[i
].isFirstKill())
433 phi_sgpr_ops
[block
.logical_preds
[i
]].emplace_back(instr
->operands
[i
].getTemp());
437 loc
.instr
= instr
.get();
438 for (unsigned i
= 0; i
< instr
->operands
.size(); i
++) {
439 Operand
& op
= instr
->operands
[i
];
443 err
|= ra_fail(output
, loc
, Location(), "Operand %d is not assigned a register", i
);
444 if (assignments
.count(op
.tempId()) && assignments
[op
.tempId()].reg
!= op
.physReg())
445 err
|= ra_fail(output
, loc
, assignments
.at(op
.tempId()).firstloc
, "Operand %d has an inconsistent register assignment with instruction", i
);
446 if ((op
.getTemp().type() == RegType::vgpr
&& op
.physReg() + op
.size() > 256 + program
->config
->num_vgprs
) ||
447 (op
.getTemp().type() == RegType::sgpr
&& op
.physReg() + op
.size() > program
->config
->num_sgprs
&& op
.physReg() < program
->sgpr_limit
))
448 err
|= ra_fail(output
, loc
, assignments
.at(op
.tempId()).firstloc
, "Operand %d has an out-of-bounds register assignment", i
);
449 if (op
.physReg() == vcc
&& !program
->needs_vcc
)
450 err
|= ra_fail(output
, loc
, Location(), "Operand %d fixed to vcc but needs_vcc=false", i
);
451 if (!assignments
[op
.tempId()].firstloc
.block
)
452 assignments
[op
.tempId()].firstloc
= loc
;
453 if (!assignments
[op
.tempId()].defloc
.block
)
454 assignments
[op
.tempId()].reg
= op
.physReg();
457 for (unsigned i
= 0; i
< instr
->definitions
.size(); i
++) {
458 Definition
& def
= instr
->definitions
[i
];
462 err
|= ra_fail(output
, loc
, Location(), "Definition %d is not assigned a register", i
);
463 if (assignments
[def
.tempId()].defloc
.block
)
464 err
|= ra_fail(output
, loc
, assignments
.at(def
.tempId()).defloc
, "Temporary %%%d also defined by instruction", def
.tempId());
465 if ((def
.getTemp().type() == RegType::vgpr
&& def
.physReg() + def
.size() > 256 + program
->config
->num_vgprs
) ||
466 (def
.getTemp().type() == RegType::sgpr
&& def
.physReg() + def
.size() > program
->config
->num_sgprs
&& def
.physReg() < program
->sgpr_limit
))
467 err
|= ra_fail(output
, loc
, assignments
.at(def
.tempId()).firstloc
, "Definition %d has an out-of-bounds register assignment", i
);
468 if (def
.physReg() == vcc
&& !program
->needs_vcc
)
469 err
|= ra_fail(output
, loc
, Location(), "Definition %d fixed to vcc but needs_vcc=false", i
);
470 if (!assignments
[def
.tempId()].firstloc
.block
)
471 assignments
[def
.tempId()].firstloc
= loc
;
472 assignments
[def
.tempId()].defloc
= loc
;
473 assignments
[def
.tempId()].reg
= def
.physReg();
478 for (Block
& block
: program
->blocks
) {
482 std::array
<unsigned, 512> regs
;
486 live
.insert(live_vars
.live_out
[block
.index
].begin(), live_vars
.live_out
[block
.index
].end());
487 /* remove killed p_phi sgpr operands */
488 for (Temp tmp
: phi_sgpr_ops
[block
.index
])
492 for (Temp tmp
: live
) {
493 PhysReg reg
= assignments
.at(tmp
.id()).reg
;
494 for (unsigned i
= 0; i
< tmp
.size(); i
++) {
496 err
|= ra_fail(output
, loc
, Location(), "Assignment of element %d of %%%d already taken by %%%d in live-out", i
, tmp
.id(), regs
[reg
+ i
]);
498 regs
[reg
+ i
] = tmp
.id();
503 for (auto it
= block
.instructions
.rbegin(); it
!= block
.instructions
.rend(); ++it
) {
504 aco_ptr
<Instruction
>& instr
= *it
;
506 /* check killed p_phi sgpr operands */
507 if (instr
->opcode
== aco_opcode::p_logical_end
) {
508 for (Temp tmp
: phi_sgpr_ops
[block
.index
]) {
509 PhysReg reg
= assignments
.at(tmp
.id()).reg
;
510 for (unsigned i
= 0; i
< tmp
.size(); i
++) {
512 err
|= ra_fail(output
, loc
, Location(), "Assignment of element %d of %%%d already taken by %%%d in live-out", i
, tmp
.id(), regs
[reg
+ i
]);
518 for (const Definition
& def
: instr
->definitions
) {
521 live
.erase(def
.getTemp());
524 /* don't count phi operands as live-in, since they are actually
525 * killed when they are copied at the predecessor */
526 if (instr
->opcode
!= aco_opcode::p_phi
&& instr
->opcode
!= aco_opcode::p_linear_phi
) {
527 for (const Operand
& op
: instr
->operands
) {
530 live
.insert(op
.getTemp());
535 for (Temp tmp
: live
) {
536 PhysReg reg
= assignments
.at(tmp
.id()).reg
;
537 for (unsigned i
= 0; i
< tmp
.size(); i
++)
538 regs
[reg
+ i
] = tmp
.id();
541 for (aco_ptr
<Instruction
>& instr
: block
.instructions
) {
542 loc
.instr
= instr
.get();
544 /* remove killed p_phi operands from regs */
545 if (instr
->opcode
== aco_opcode::p_logical_end
) {
546 for (Temp tmp
: phi_sgpr_ops
[block
.index
]) {
547 PhysReg reg
= assignments
.at(tmp
.id()).reg
;
552 if (instr
->opcode
!= aco_opcode::p_phi
&& instr
->opcode
!= aco_opcode::p_linear_phi
) {
553 for (const Operand
& op
: instr
->operands
) {
556 if (op
.isFirstKillBeforeDef()) {
557 for (unsigned j
= 0; j
< op
.getTemp().size(); j
++)
558 regs
[op
.physReg() + j
] = 0;
563 for (unsigned i
= 0; i
< instr
->definitions
.size(); i
++) {
564 Definition
& def
= instr
->definitions
[i
];
567 Temp tmp
= def
.getTemp();
568 PhysReg reg
= assignments
.at(tmp
.id()).reg
;
569 for (unsigned j
= 0; j
< tmp
.size(); j
++) {
571 err
|= ra_fail(output
, loc
, assignments
.at(regs
[reg
+ i
]).defloc
, "Assignment of element %d of %%%d already taken by %%%d from instruction", i
, tmp
.id(), regs
[reg
+ j
]);
572 regs
[reg
+ j
] = tmp
.id();
576 for (const Definition
& def
: instr
->definitions
) {
580 for (unsigned j
= 0; j
< def
.getTemp().size(); j
++)
581 regs
[def
.physReg() + j
] = 0;
585 if (instr
->opcode
!= aco_opcode::p_phi
&& instr
->opcode
!= aco_opcode::p_linear_phi
) {
586 for (const Operand
& op
: instr
->operands
) {
589 if (op
.isLateKill() && op
.isFirstKill()) {
590 for (unsigned j
= 0; j
< op
.getTemp().size(); j
++)
591 regs
[op
.physReg() + j
] = 0;