src/amd/vulkan/radv_pass.c

   1 /*
   2  * Copyright © 2016 Red Hat.
   3  * Copyright © 2016 Bas Nieuwenhuizen
   4  *
   5  * based in part on anv driver which is:
   6  * Copyright © 2015 Intel Corporation
   7  *
   8  * Permission is hereby granted, free of charge, to any person obtaining a
   9  * copy of this software and associated documentation files (the "Software"),
  10  * to deal in the Software without restriction, including without limitation
  11  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  12  * and/or sell copies of the Software, and to permit persons to whom the
  13  * Software is furnished to do so, subject to the following conditions:
  14  *
  15  * The above copyright notice and this permission notice (including the next
  16  * paragraph) shall be included in all copies or substantial portions of the
  17  * Software.
  18  *
  19  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  20  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  21  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  22  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  23  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  24  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  25  * IN THE SOFTWARE.
  26  */
  27 #include "radv_private.h"
  28
  29 #include "vk_util.h"
  30
  31 static void
  32 radv_render_pass_add_subpass_dep(struct radv_render_pass *pass,
  33                                  const VkSubpassDependency2KHR *dep)
  34 {
  35         uint32_t src = dep->srcSubpass;
  36         uint32_t dst = dep->dstSubpass;
  37
  38         /* Ignore subpass self-dependencies as they allow the app to call
  39          * vkCmdPipelineBarrier() inside the render pass and the driver should
  40          * only do the barrier when called, not when starting the render pass.
  41          */
  42         if (src == dst)
  43                 return;
  44
  45         /* Accumulate all ingoing external dependencies to the first subpass. */
  46         if (src == VK_SUBPASS_EXTERNAL)
  47                 dst = 0;
  48
  49         if (dst == VK_SUBPASS_EXTERNAL) {
  50                 if (dep->dstStageMask != VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT)
  51                         pass->end_barrier.src_stage_mask |= dep->srcStageMask;
  52                 pass->end_barrier.src_access_mask |= dep->srcAccessMask;
  53                 pass->end_barrier.dst_access_mask |= dep->dstAccessMask;
  54         } else {
  55                 if (dep->dstStageMask != VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT)
  56                         pass->subpasses[dst].start_barrier.src_stage_mask |= dep->srcStageMask;
  57                 pass->subpasses[dst].start_barrier.src_access_mask |= dep->srcAccessMask;
  58                 pass->subpasses[dst].start_barrier.dst_access_mask |= dep->dstAccessMask;
  59         }
  60 }
  61
  62 static void
  63 radv_render_pass_compile(struct radv_render_pass *pass)
  64 {
  65         for (uint32_t i = 0; i < pass->subpass_count; i++) {
  66                 struct radv_subpass *subpass = &pass->subpasses[i];
  67
  68                 for (uint32_t j = 0; j < subpass->attachment_count; j++) {
  69                         struct radv_subpass_attachment *subpass_att =
  70                                 &subpass->attachments[j];
  71                         if (subpass_att->attachment == VK_ATTACHMENT_UNUSED)
  72                                 continue;
  73
  74                         struct radv_render_pass_attachment *pass_att =
  75                                 &pass->attachments[subpass_att->attachment];
  76
  77                         pass_att->first_subpass_idx = UINT32_MAX;
  78                 }
  79         }
  80
  81         for (uint32_t i = 0; i < pass->subpass_count; i++) {
  82                 struct radv_subpass *subpass = &pass->subpasses[i];
  83                 uint32_t color_sample_count = 1, depth_sample_count = 1;
  84
  85                 /* We don't allow depth_stencil_attachment to be non-NULL and
  86                  * be VK_ATTACHMENT_UNUSED.  This way something can just check
  87                  * for NULL and be guaranteed that they have a valid
  88                  * attachment.
  89                  */
  90                 if (subpass->depth_stencil_attachment &&
  91                     subpass->depth_stencil_attachment->attachment == VK_ATTACHMENT_UNUSED)
  92                         subpass->depth_stencil_attachment = NULL;
  93
  94                 if (subpass->ds_resolve_attachment &&
  95                     subpass->ds_resolve_attachment->attachment == VK_ATTACHMENT_UNUSED)
  96                         subpass->ds_resolve_attachment = NULL;
  97
  98                 for (uint32_t j = 0; j < subpass->attachment_count; j++) {
  99                         struct radv_subpass_attachment *subpass_att =
 100                                 &subpass->attachments[j];
 101                         if (subpass_att->attachment == VK_ATTACHMENT_UNUSED)
 102                                 continue;
 103
 104                         struct radv_render_pass_attachment *pass_att =
 105                                 &pass->attachments[subpass_att->attachment];
 106
 107                         if (i < pass_att->first_subpass_idx)
 108                                 pass_att->first_subpass_idx = i;
 109                         pass_att->last_subpass_idx = i;
 110                 }
 111
 112                 subpass->has_color_att = false;
 113                 for (uint32_t j = 0; j < subpass->color_count; j++) {
 114                         struct radv_subpass_attachment *subpass_att =
 115                                 &subpass->color_attachments[j];
 116                         if (subpass_att->attachment == VK_ATTACHMENT_UNUSED)
 117                                 continue;
 118
 119                         subpass->has_color_att = true;
 120
 121                         struct radv_render_pass_attachment *pass_att =
 122                                 &pass->attachments[subpass_att->attachment];
 123
 124                         color_sample_count = pass_att->samples;
 125                 }
 126
 127                 if (subpass->depth_stencil_attachment) {
 128                         const uint32_t a =
 129                                 subpass->depth_stencil_attachment->attachment;
 130                         struct radv_render_pass_attachment *pass_att =
 131                                 &pass->attachments[a];
 132                         depth_sample_count = pass_att->samples;
 133                 }
 134
 135                 subpass->max_sample_count = MAX2(color_sample_count,
 136                                                  depth_sample_count);
 137
 138                 /* We have to handle resolve attachments specially */
 139                 subpass->has_color_resolve = false;
 140                 if (subpass->resolve_attachments) {
 141                         for (uint32_t j = 0; j < subpass->color_count; j++) {
 142                                 struct radv_subpass_attachment *resolve_att =
 143                                         &subpass->resolve_attachments[j];
 144
 145                                 if (resolve_att->attachment == VK_ATTACHMENT_UNUSED)
 146                                         continue;
 147
 148                                 subpass->has_color_resolve = true;
 149                         }
 150                 }
 151
 152                 for (uint32_t j = 0; j < subpass->input_count; ++j) {
 153                         if (subpass->input_attachments[j].attachment == VK_ATTACHMENT_UNUSED)
 154                                 continue;
 155
 156                         for (uint32_t k = 0; k < subpass->color_count; ++k) {
 157                                 if (subpass->color_attachments[k].attachment == subpass->input_attachments[j].attachment) {
 158                                         subpass->input_attachments[j].in_render_loop = true;
 159                                         subpass->color_attachments[k].in_render_loop = true;
 160                                 }
 161                         }
 162
 163                         if (subpass->depth_stencil_attachment &&
 164                             subpass->depth_stencil_attachment->attachment == subpass->input_attachments[j].attachment) {
 165                                 subpass->input_attachments[j].in_render_loop = true;
 166                                 subpass->depth_stencil_attachment->in_render_loop = true;
 167                         }
 168                 }
 169         }
 170 }
 171
 172 static unsigned
 173 radv_num_subpass_attachments(const VkSubpassDescription *desc)
 174 {
 175         return desc->inputAttachmentCount +
 176                desc->colorAttachmentCount +
 177                (desc->pResolveAttachments ? desc->colorAttachmentCount : 0) +
 178                (desc->pDepthStencilAttachment != NULL);
 179 }
 180
 181 VkResult radv_CreateRenderPass(
 182         VkDevice                                    _device,
 183         const VkRenderPassCreateInfo*               pCreateInfo,
 184         const VkAllocationCallbacks*                pAllocator,
 185         VkRenderPass*                               pRenderPass)
 186 {
 187         RADV_FROM_HANDLE(radv_device, device, _device);
 188         struct radv_render_pass *pass;
 189         size_t size;
 190         size_t attachments_offset;
 191         VkRenderPassMultiviewCreateInfo *multiview_info = NULL;
 192
 193         assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO);
 194
 195         size = sizeof(*pass);
 196         size += pCreateInfo->subpassCount * sizeof(pass->subpasses[0]);
 197         attachments_offset = size;
 198         size += pCreateInfo->attachmentCount * sizeof(pass->attachments[0]);
 199
 200         pass = vk_alloc2(&device->alloc, pAllocator, size, 8,
 201                            VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 202         if (pass == NULL)
 203                 return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 204
 205         memset(pass, 0, size);
 206         pass->attachment_count = pCreateInfo->attachmentCount;
 207         pass->subpass_count = pCreateInfo->subpassCount;
 208         pass->attachments = (void *) pass + attachments_offset;
 209
 210         vk_foreach_struct(ext, pCreateInfo->pNext) {
 211                 switch(ext->sType) {
 212                 case  VK_STRUCTURE_TYPE_RENDER_PASS_MULTIVIEW_CREATE_INFO:
 213                         multiview_info = (VkRenderPassMultiviewCreateInfo*)ext;
 214                         break;
 215                 default:
 216                         break;
 217                 }
 218         }
 219
 220         for (uint32_t i = 0; i < pCreateInfo->attachmentCount; i++) {
 221                 struct radv_render_pass_attachment *att = &pass->attachments[i];
 222
 223                 att->format = pCreateInfo->pAttachments[i].format;
 224                 att->samples = pCreateInfo->pAttachments[i].samples;
 225                 att->load_op = pCreateInfo->pAttachments[i].loadOp;
 226                 att->stencil_load_op = pCreateInfo->pAttachments[i].stencilLoadOp;
 227                 att->initial_layout =  pCreateInfo->pAttachments[i].initialLayout;
 228                 att->final_layout =  pCreateInfo->pAttachments[i].finalLayout;
 229                 att->stencil_initial_layout = pCreateInfo->pAttachments[i].initialLayout;
 230                 att->stencil_final_layout = pCreateInfo->pAttachments[i].finalLayout;
 231                 // att->store_op = pCreateInfo->pAttachments[i].storeOp;
 232                 // att->stencil_store_op = pCreateInfo->pAttachments[i].stencilStoreOp;
 233         }
 234         uint32_t subpass_attachment_count = 0;
 235         struct radv_subpass_attachment *p;
 236         for (uint32_t i = 0; i < pCreateInfo->subpassCount; i++) {
 237                 subpass_attachment_count +=
 238                         radv_num_subpass_attachments(&pCreateInfo->pSubpasses[i]);
 239         }
 240
 241         if (subpass_attachment_count) {
 242                 pass->subpass_attachments =
 243                         vk_alloc2(&device->alloc, pAllocator,
 244                                     subpass_attachment_count * sizeof(struct radv_subpass_attachment), 8,
 245                                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 246                 if (pass->subpass_attachments == NULL) {
 247                         vk_free2(&device->alloc, pAllocator, pass);
 248                         return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 249                 }
 250         } else
 251                 pass->subpass_attachments = NULL;
 252
 253         p = pass->subpass_attachments;
 254         for (uint32_t i = 0; i < pCreateInfo->subpassCount; i++) {
 255                 const VkSubpassDescription *desc = &pCreateInfo->pSubpasses[i];
 256                 struct radv_subpass *subpass = &pass->subpasses[i];
 257
 258                 subpass->input_count = desc->inputAttachmentCount;
 259                 subpass->color_count = desc->colorAttachmentCount;
 260                 subpass->attachment_count = radv_num_subpass_attachments(desc);
 261                 subpass->attachments = p;
 262
 263                 if (multiview_info)
 264                         subpass->view_mask = multiview_info->pViewMasks[i];
 265
 266                 if (desc->inputAttachmentCount > 0) {
 267                         subpass->input_attachments = p;
 268                         p += desc->inputAttachmentCount;
 269
 270                         for (uint32_t j = 0; j < desc->inputAttachmentCount; j++) {
 271                                 subpass->input_attachments[j] = (struct radv_subpass_attachment) {
 272                                         .attachment = desc->pInputAttachments[j].attachment,
 273                                         .layout = desc->pInputAttachments[j].layout,
 274                                         .stencil_layout = desc->pInputAttachments[j].layout,
 275                                 };
 276                         }
 277                 }
 278
 279                 if (desc->colorAttachmentCount > 0) {
 280                         subpass->color_attachments = p;
 281                         p += desc->colorAttachmentCount;
 282
 283                         for (uint32_t j = 0; j < desc->colorAttachmentCount; j++) {
 284                                 subpass->color_attachments[j] = (struct radv_subpass_attachment) {
 285                                         .attachment = desc->pColorAttachments[j].attachment,
 286                                         .layout = desc->pColorAttachments[j].layout,
 287                                 };
 288                         }
 289                 }
 290
 291                 if (desc->pResolveAttachments) {
 292                         subpass->resolve_attachments = p;
 293                         p += desc->colorAttachmentCount;
 294
 295                         for (uint32_t j = 0; j < desc->colorAttachmentCount; j++) {
 296                                 subpass->resolve_attachments[j] = (struct radv_subpass_attachment) {
 297                                         .attachment = desc->pResolveAttachments[j].attachment,
 298                                         .layout = desc->pResolveAttachments[j].layout,
 299                                         .stencil_layout = desc->pResolveAttachments[j].layout,
 300                                 };
 301                         }
 302                 }
 303
 304                 if (desc->pDepthStencilAttachment) {
 305                         subpass->depth_stencil_attachment = p++;
 306
 307                         *subpass->depth_stencil_attachment = (struct radv_subpass_attachment) {
 308                                 .attachment = desc->pDepthStencilAttachment->attachment,
 309                                 .layout = desc->pDepthStencilAttachment->layout,
 310                                 .stencil_layout = desc->pDepthStencilAttachment->layout,
 311                         };
 312                 }
 313         }
 314
 315         for (unsigned i = 0; i < pCreateInfo->dependencyCount; ++i) {
 316                 /* Convert to a Dependency2KHR */
 317                 struct VkSubpassDependency2KHR dep2 = {
 318                         .srcSubpass       = pCreateInfo->pDependencies[i].srcSubpass,
 319                         .dstSubpass       = pCreateInfo->pDependencies[i].dstSubpass,
 320                         .srcStageMask     = pCreateInfo->pDependencies[i].srcStageMask,
 321                         .dstStageMask     = pCreateInfo->pDependencies[i].dstStageMask,
 322                         .srcAccessMask    = pCreateInfo->pDependencies[i].srcAccessMask,
 323                         .dstAccessMask    = pCreateInfo->pDependencies[i].dstAccessMask,
 324                         .dependencyFlags  = pCreateInfo->pDependencies[i].dependencyFlags,
 325                 };
 326                 radv_render_pass_add_subpass_dep(pass, &dep2);
 327         }
 328
 329         radv_render_pass_compile(pass);
 330
 331         *pRenderPass = radv_render_pass_to_handle(pass);
 332
 333         return VK_SUCCESS;
 334 }
 335
 336 static unsigned
 337 radv_num_subpass_attachments2(const VkSubpassDescription2KHR *desc)
 338 {
 339         const VkSubpassDescriptionDepthStencilResolveKHR *ds_resolve =
 340                 vk_find_struct_const(desc->pNext,
 341                                      SUBPASS_DESCRIPTION_DEPTH_STENCIL_RESOLVE_KHR);
 342
 343         return desc->inputAttachmentCount +
 344                desc->colorAttachmentCount +
 345                (desc->pResolveAttachments ? desc->colorAttachmentCount : 0) +
 346                (desc->pDepthStencilAttachment != NULL) +
 347                (ds_resolve && ds_resolve->pDepthStencilResolveAttachment);
 348 }
 349
 350 VkResult radv_CreateRenderPass2KHR(
 351     VkDevice                                    _device,
 352     const VkRenderPassCreateInfo2KHR*           pCreateInfo,
 353     const VkAllocationCallbacks*                pAllocator,
 354     VkRenderPass*                               pRenderPass)
 355 {
 356         RADV_FROM_HANDLE(radv_device, device, _device);
 357         struct radv_render_pass *pass;
 358         size_t size;
 359         size_t attachments_offset;
 360
 361         assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO_2_KHR);
 362
 363         size = sizeof(*pass);
 364         size += pCreateInfo->subpassCount * sizeof(pass->subpasses[0]);
 365         attachments_offset = size;
 366         size += pCreateInfo->attachmentCount * sizeof(pass->attachments[0]);
 367
 368         pass = vk_alloc2(&device->alloc, pAllocator, size, 8,
 369                            VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 370         if (pass == NULL)
 371                 return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 372
 373         memset(pass, 0, size);
 374         pass->attachment_count = pCreateInfo->attachmentCount;
 375         pass->subpass_count = pCreateInfo->subpassCount;
 376         pass->attachments = (void *) pass + attachments_offset;
 377
 378         for (uint32_t i = 0; i < pCreateInfo->attachmentCount; i++) {
 379                 struct radv_render_pass_attachment *att = &pass->attachments[i];
 380                 const VkAttachmentDescriptionStencilLayoutKHR *stencil_layout =
 381                         vk_find_struct_const(pCreateInfo->pAttachments[i].pNext,
 382                                              ATTACHMENT_DESCRIPTION_STENCIL_LAYOUT_KHR);
 383
 384                 att->format = pCreateInfo->pAttachments[i].format;
 385                 att->samples = pCreateInfo->pAttachments[i].samples;
 386                 att->load_op = pCreateInfo->pAttachments[i].loadOp;
 387                 att->stencil_load_op = pCreateInfo->pAttachments[i].stencilLoadOp;
 388                 att->initial_layout =  pCreateInfo->pAttachments[i].initialLayout;
 389                 att->final_layout =  pCreateInfo->pAttachments[i].finalLayout;
 390                 att->stencil_initial_layout = (stencil_layout ?
 391                                                stencil_layout->stencilInitialLayout :
 392                                                pCreateInfo->pAttachments[i].initialLayout);
 393                 att->stencil_final_layout = (stencil_layout ?
 394                                              stencil_layout->stencilFinalLayout :
 395                                              pCreateInfo->pAttachments[i].finalLayout);
 396                 // att->store_op = pCreateInfo->pAttachments[i].storeOp;
 397                 // att->stencil_store_op = pCreateInfo->pAttachments[i].stencilStoreOp;
 398         }
 399         uint32_t subpass_attachment_count = 0;
 400         struct radv_subpass_attachment *p;
 401         for (uint32_t i = 0; i < pCreateInfo->subpassCount; i++) {
 402                 subpass_attachment_count +=
 403                         radv_num_subpass_attachments2(&pCreateInfo->pSubpasses[i]);
 404         }
 405
 406         if (subpass_attachment_count) {
 407                 pass->subpass_attachments =
 408                         vk_alloc2(&device->alloc, pAllocator,
 409                                     subpass_attachment_count * sizeof(struct radv_subpass_attachment), 8,
 410                                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 411                 if (pass->subpass_attachments == NULL) {
 412                         vk_free2(&device->alloc, pAllocator, pass);
 413                         return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 414                 }
 415         } else
 416                 pass->subpass_attachments = NULL;
 417
 418         p = pass->subpass_attachments;
 419         for (uint32_t i = 0; i < pCreateInfo->subpassCount; i++) {
 420                 const VkSubpassDescription2KHR *desc = &pCreateInfo->pSubpasses[i];
 421                 struct radv_subpass *subpass = &pass->subpasses[i];
 422
 423                 subpass->input_count = desc->inputAttachmentCount;
 424                 subpass->color_count = desc->colorAttachmentCount;
 425                 subpass->attachment_count = radv_num_subpass_attachments2(desc);
 426                 subpass->attachments = p;
 427                 subpass->view_mask = desc->viewMask;
 428
 429                 if (desc->inputAttachmentCount > 0) {
 430                         subpass->input_attachments = p;
 431                         p += desc->inputAttachmentCount;
 432
 433                         for (uint32_t j = 0; j < desc->inputAttachmentCount; j++) {
 434                                 const VkAttachmentReferenceStencilLayoutKHR *stencil_attachment =
 435                                     vk_find_struct_const(desc->pInputAttachments[j].pNext,
 436                                                          ATTACHMENT_REFERENCE_STENCIL_LAYOUT_KHR);
 437
 438                                 subpass->input_attachments[j] = (struct radv_subpass_attachment) {
 439                                         .attachment = desc->pInputAttachments[j].attachment,
 440                                         .layout = desc->pInputAttachments[j].layout,
 441                                         .stencil_layout = (stencil_attachment ?
 442                                                            stencil_attachment->stencilLayout :
 443                                                            desc->pInputAttachments[j].layout),
 444                                 };
 445                         }
 446                 }
 447
 448                 if (desc->colorAttachmentCount > 0) {
 449                         subpass->color_attachments = p;
 450                         p += desc->colorAttachmentCount;
 451
 452                         for (uint32_t j = 0; j < desc->colorAttachmentCount; j++) {
 453                                 subpass->color_attachments[j] = (struct radv_subpass_attachment) {
 454                                         .attachment = desc->pColorAttachments[j].attachment,
 455                                         .layout = desc->pColorAttachments[j].layout,
 456                                 };
 457                         }
 458                 }
 459
 460                 if (desc->pResolveAttachments) {
 461                         subpass->resolve_attachments = p;
 462                         p += desc->colorAttachmentCount;
 463
 464                         for (uint32_t j = 0; j < desc->colorAttachmentCount; j++) {
 465                                 subpass->resolve_attachments[j] = (struct radv_subpass_attachment) {
 466                                         .attachment = desc->pResolveAttachments[j].attachment,
 467                                         .layout = desc->pResolveAttachments[j].layout,
 468                                 };
 469                         }
 470                 }
 471
 472                 if (desc->pDepthStencilAttachment) {
 473                         subpass->depth_stencil_attachment = p++;
 474
 475                         const VkAttachmentReferenceStencilLayoutKHR *stencil_attachment =
 476                             vk_find_struct_const(desc->pDepthStencilAttachment->pNext,
 477                                                  ATTACHMENT_REFERENCE_STENCIL_LAYOUT_KHR);
 478
 479                         *subpass->depth_stencil_attachment = (struct radv_subpass_attachment) {
 480                                 .attachment = desc->pDepthStencilAttachment->attachment,
 481                                 .layout = desc->pDepthStencilAttachment->layout,
 482                                 .stencil_layout = (stencil_attachment ?
 483                                                    stencil_attachment->stencilLayout :
 484                                                    desc->pDepthStencilAttachment->layout),
 485                         };
 486                 }
 487
 488                 const VkSubpassDescriptionDepthStencilResolveKHR *ds_resolve =
 489                         vk_find_struct_const(desc->pNext,
 490                                              SUBPASS_DESCRIPTION_DEPTH_STENCIL_RESOLVE_KHR);
 491
 492                 if (ds_resolve && ds_resolve->pDepthStencilResolveAttachment) {
 493                         subpass->ds_resolve_attachment = p++;
 494
 495                         const VkAttachmentReferenceStencilLayoutKHR *stencil_resolve_attachment =
 496                             vk_find_struct_const(ds_resolve->pDepthStencilResolveAttachment->pNext,
 497                                                  ATTACHMENT_REFERENCE_STENCIL_LAYOUT_KHR);
 498
 499                         *subpass->ds_resolve_attachment = (struct radv_subpass_attachment) {
 500                                 .attachment =  ds_resolve->pDepthStencilResolveAttachment->attachment,
 501                                 .layout =      ds_resolve->pDepthStencilResolveAttachment->layout,
 502                                 .stencil_layout = (stencil_resolve_attachment ?
 503                                                    stencil_resolve_attachment->stencilLayout :
 504                                                    ds_resolve->pDepthStencilResolveAttachment->layout),
 505                         };
 506
 507                         subpass->depth_resolve_mode = ds_resolve->depthResolveMode;
 508                         subpass->stencil_resolve_mode = ds_resolve->stencilResolveMode;
 509                 }
 510         }
 511
 512         for (unsigned i = 0; i < pCreateInfo->dependencyCount; ++i) {
 513                 radv_render_pass_add_subpass_dep(pass,
 514                                                  &pCreateInfo->pDependencies[i]);
 515         }
 516
 517         radv_render_pass_compile(pass);
 518
 519         *pRenderPass = radv_render_pass_to_handle(pass);
 520
 521         return VK_SUCCESS;
 522 }
 523
 524 void radv_DestroyRenderPass(
 525         VkDevice                                    _device,
 526         VkRenderPass                                _pass,
 527         const VkAllocationCallbacks*                pAllocator)
 528 {
 529         RADV_FROM_HANDLE(radv_device, device, _device);
 530         RADV_FROM_HANDLE(radv_render_pass, pass, _pass);
 531
 532         if (!_pass)
 533                 return;
 534         vk_free2(&device->alloc, pAllocator, pass->subpass_attachments);
 535         vk_free2(&device->alloc, pAllocator, pass);
 536 }
 537
 538 void radv_GetRenderAreaGranularity(
 539     VkDevice                                    device,
 540     VkRenderPass                                renderPass,
 541     VkExtent2D*                                 pGranularity)
 542 {
 543         pGranularity->width = 1;
 544         pGranularity->height = 1;
 545 }
 546