2 * Copyright © 2014 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
24 * Connor Abbott (cwabbott0@gmail.com)
32 * This file checks for invalid IR indicating a bug somewhere in the compiler.
35 /* Since this file is just a pile of asserts, don't bother compiling it if
36 * we're not building a debug build.
41 * Per-register validation state.
46 * equivalent to the uses and defs in nir_register, but built up by the
47 * validator. At the end, we verify that the sets have the same entries.
49 struct set
*uses
, *if_uses
, *defs
;
50 nir_function_impl
*where_defined
; /* NULL for global registers */
55 * equivalent to the uses in nir_ssa_def, but built up by the validator.
56 * At the end, we verify that the sets have the same entries.
58 struct set
*uses
, *if_uses
;
59 nir_function_impl
*where_defined
;
60 } ssa_def_validate_state
;
63 /* map of register -> validation state (struct above) */
64 struct hash_table
*regs
;
66 /* the current shader being validated */
69 /* the current instruction being validated */
72 /* the current variable being validated */
75 /* the current basic block being validated */
78 /* the current if statement being validated */
81 /* the current loop being visited */
84 /* the parent of the current cf node being visited */
85 nir_cf_node
*parent_node
;
87 /* the current function implementation being validated */
88 nir_function_impl
*impl
;
90 /* map of SSA value -> function implementation where it is defined */
91 struct hash_table
*ssa_defs
;
93 /* bitset of ssa definitions we have found; used to check uniqueness */
94 BITSET_WORD
*ssa_defs_found
;
96 /* bitset of registers we have currently found; used to check uniqueness */
97 BITSET_WORD
*regs_found
;
99 /* map of local variable -> function implementation where it is defined */
100 struct hash_table
*var_defs
;
102 /* map of instruction/var/etc to failed assert string */
103 struct hash_table
*errors
;
107 log_error(validate_state
*state
, const char *cond
, const char *file
, int line
)
118 char *msg
= ralloc_asprintf(state
->errors
, "error: %s (%s:%d)",
121 _mesa_hash_table_insert(state
->errors
, obj
, msg
);
124 #define validate_assert(state, cond) do { \
126 log_error(state, #cond, __FILE__, __LINE__); \
129 static void validate_src(nir_src
*src
, validate_state
*state
,
130 unsigned bit_size
, unsigned num_components
);
133 validate_reg_src(nir_src
*src
, validate_state
*state
,
134 unsigned bit_size
, unsigned num_components
)
136 validate_assert(state
, src
->reg
.reg
!= NULL
);
138 struct hash_entry
*entry
;
139 entry
= _mesa_hash_table_search(state
->regs
, src
->reg
.reg
);
140 validate_assert(state
, entry
);
142 reg_validate_state
*reg_state
= (reg_validate_state
*) entry
->data
;
145 _mesa_set_add(reg_state
->uses
, src
);
147 validate_assert(state
, state
->if_stmt
);
148 _mesa_set_add(reg_state
->if_uses
, src
);
151 if (!src
->reg
.reg
->is_global
) {
152 validate_assert(state
, reg_state
->where_defined
== state
->impl
&&
153 "using a register declared in a different function");
156 if (!src
->reg
.reg
->is_packed
) {
158 validate_assert(state
, src
->reg
.reg
->bit_size
== bit_size
);
160 validate_assert(state
, src
->reg
.reg
->num_components
== num_components
);
163 validate_assert(state
, (src
->reg
.reg
->num_array_elems
== 0 ||
164 src
->reg
.base_offset
< src
->reg
.reg
->num_array_elems
) &&
165 "definitely out-of-bounds array access");
167 if (src
->reg
.indirect
) {
168 validate_assert(state
, src
->reg
.reg
->num_array_elems
!= 0);
169 validate_assert(state
, (src
->reg
.indirect
->is_ssa
||
170 src
->reg
.indirect
->reg
.indirect
== NULL
) &&
171 "only one level of indirection allowed");
172 validate_src(src
->reg
.indirect
, state
, 32, 1);
177 validate_ssa_src(nir_src
*src
, validate_state
*state
,
178 unsigned bit_size
, unsigned num_components
)
180 validate_assert(state
, src
->ssa
!= NULL
);
182 struct hash_entry
*entry
= _mesa_hash_table_search(state
->ssa_defs
, src
->ssa
);
184 validate_assert(state
, entry
);
189 ssa_def_validate_state
*def_state
= (ssa_def_validate_state
*)entry
->data
;
191 validate_assert(state
, def_state
->where_defined
== state
->impl
&&
192 "using an SSA value defined in a different function");
195 _mesa_set_add(def_state
->uses
, src
);
197 validate_assert(state
, state
->if_stmt
);
198 _mesa_set_add(def_state
->if_uses
, src
);
202 validate_assert(state
, src
->ssa
->bit_size
== bit_size
);
204 validate_assert(state
, src
->ssa
->num_components
== num_components
);
206 /* TODO validate that the use is dominated by the definition */
210 validate_src(nir_src
*src
, validate_state
*state
,
211 unsigned bit_size
, unsigned num_components
)
214 validate_assert(state
, src
->parent_instr
== state
->instr
);
216 validate_assert(state
, src
->parent_if
== state
->if_stmt
);
219 validate_ssa_src(src
, state
, bit_size
, num_components
);
221 validate_reg_src(src
, state
, bit_size
, num_components
);
225 validate_alu_src(nir_alu_instr
*instr
, unsigned index
, validate_state
*state
)
227 nir_alu_src
*src
= &instr
->src
[index
];
229 unsigned num_components
;
230 if (src
->src
.is_ssa
) {
231 num_components
= src
->src
.ssa
->num_components
;
233 if (src
->src
.reg
.reg
->is_packed
)
234 num_components
= 4; /* can't check anything */
236 num_components
= src
->src
.reg
.reg
->num_components
;
238 for (unsigned i
= 0; i
< 4; i
++) {
239 validate_assert(state
, src
->swizzle
[i
] < 4);
241 if (nir_alu_instr_channel_used(instr
, index
, i
))
242 validate_assert(state
, src
->swizzle
[i
] < num_components
);
245 validate_src(&src
->src
, state
, 0, 0);
249 validate_reg_dest(nir_reg_dest
*dest
, validate_state
*state
,
250 unsigned bit_size
, unsigned num_components
)
252 validate_assert(state
, dest
->reg
!= NULL
);
254 validate_assert(state
, dest
->parent_instr
== state
->instr
);
256 struct hash_entry
*entry2
;
257 entry2
= _mesa_hash_table_search(state
->regs
, dest
->reg
);
259 validate_assert(state
, entry2
);
261 reg_validate_state
*reg_state
= (reg_validate_state
*) entry2
->data
;
262 _mesa_set_add(reg_state
->defs
, dest
);
264 if (!dest
->reg
->is_global
) {
265 validate_assert(state
, reg_state
->where_defined
== state
->impl
&&
266 "writing to a register declared in a different function");
269 if (!dest
->reg
->is_packed
) {
271 validate_assert(state
, dest
->reg
->bit_size
== bit_size
);
273 validate_assert(state
, dest
->reg
->num_components
== num_components
);
276 validate_assert(state
, (dest
->reg
->num_array_elems
== 0 ||
277 dest
->base_offset
< dest
->reg
->num_array_elems
) &&
278 "definitely out-of-bounds array access");
280 if (dest
->indirect
) {
281 validate_assert(state
, dest
->reg
->num_array_elems
!= 0);
282 validate_assert(state
, (dest
->indirect
->is_ssa
|| dest
->indirect
->reg
.indirect
== NULL
) &&
283 "only one level of indirection allowed");
284 validate_src(dest
->indirect
, state
, 32, 1);
289 validate_ssa_def(nir_ssa_def
*def
, validate_state
*state
)
291 validate_assert(state
, def
->index
< state
->impl
->ssa_alloc
);
292 validate_assert(state
, !BITSET_TEST(state
->ssa_defs_found
, def
->index
));
293 BITSET_SET(state
->ssa_defs_found
, def
->index
);
295 validate_assert(state
, def
->parent_instr
== state
->instr
);
297 validate_assert(state
, def
->num_components
<= 4);
299 list_validate(&def
->uses
);
300 list_validate(&def
->if_uses
);
302 ssa_def_validate_state
*def_state
= ralloc(state
->ssa_defs
,
303 ssa_def_validate_state
);
304 def_state
->where_defined
= state
->impl
;
305 def_state
->uses
= _mesa_set_create(def_state
, _mesa_hash_pointer
,
306 _mesa_key_pointer_equal
);
307 def_state
->if_uses
= _mesa_set_create(def_state
, _mesa_hash_pointer
,
308 _mesa_key_pointer_equal
);
309 _mesa_hash_table_insert(state
->ssa_defs
, def
, def_state
);
313 validate_dest(nir_dest
*dest
, validate_state
*state
,
314 unsigned bit_size
, unsigned num_components
)
318 validate_assert(state
, dest
->ssa
.bit_size
== bit_size
);
320 validate_assert(state
, dest
->ssa
.num_components
== num_components
);
321 validate_ssa_def(&dest
->ssa
, state
);
323 validate_reg_dest(&dest
->reg
, state
, bit_size
, num_components
);
328 validate_alu_dest(nir_alu_instr
*instr
, validate_state
*state
)
330 nir_alu_dest
*dest
= &instr
->dest
;
333 dest
->dest
.is_ssa
? dest
->dest
.ssa
.num_components
334 : dest
->dest
.reg
.reg
->num_components
;
335 bool is_packed
= !dest
->dest
.is_ssa
&& dest
->dest
.reg
.reg
->is_packed
;
337 * validate that the instruction doesn't write to components not in the
340 validate_assert(state
, is_packed
|| !(dest
->write_mask
& ~((1 << dest_size
) - 1)));
342 /* validate that saturate is only ever used on instructions with
343 * destinations of type float
345 nir_alu_instr
*alu
= nir_instr_as_alu(state
->instr
);
346 validate_assert(state
,
347 (nir_alu_type_get_base_type(nir_op_infos
[alu
->op
].output_type
) ==
351 validate_dest(&dest
->dest
, state
, 0, 0);
355 validate_alu_instr(nir_alu_instr
*instr
, validate_state
*state
)
357 validate_assert(state
, instr
->op
< nir_num_opcodes
);
359 unsigned instr_bit_size
= 0;
360 for (unsigned i
= 0; i
< nir_op_infos
[instr
->op
].num_inputs
; i
++) {
361 nir_alu_type src_type
= nir_op_infos
[instr
->op
].input_types
[i
];
362 unsigned src_bit_size
= nir_src_bit_size(instr
->src
[i
].src
);
363 if (nir_alu_type_get_type_size(src_type
)) {
364 validate_assert(state
, src_bit_size
== nir_alu_type_get_type_size(src_type
));
365 } else if (instr_bit_size
) {
366 validate_assert(state
, src_bit_size
== instr_bit_size
);
368 instr_bit_size
= src_bit_size
;
371 if (nir_alu_type_get_base_type(src_type
) == nir_type_float
) {
372 /* 8-bit float isn't a thing */
373 validate_assert(state
, src_bit_size
== 16 || src_bit_size
== 32 ||
377 validate_alu_src(instr
, i
, state
);
380 nir_alu_type dest_type
= nir_op_infos
[instr
->op
].output_type
;
381 unsigned dest_bit_size
= nir_dest_bit_size(instr
->dest
.dest
);
382 if (nir_alu_type_get_type_size(dest_type
)) {
383 validate_assert(state
, dest_bit_size
== nir_alu_type_get_type_size(dest_type
));
384 } else if (instr_bit_size
) {
385 validate_assert(state
, dest_bit_size
== instr_bit_size
);
387 /* The only unsized thing is the destination so it's vacuously valid */
390 if (nir_alu_type_get_base_type(dest_type
) == nir_type_float
) {
391 /* 8-bit float isn't a thing */
392 validate_assert(state
, dest_bit_size
== 16 || dest_bit_size
== 32 ||
393 dest_bit_size
== 64);
396 validate_alu_dest(instr
, state
);
400 validate_deref_chain(nir_deref
*deref
, nir_variable_mode mode
,
401 validate_state
*state
)
403 validate_assert(state
, deref
->child
== NULL
|| ralloc_parent(deref
->child
) == deref
);
405 nir_deref
*parent
= NULL
;
406 while (deref
!= NULL
) {
407 switch (deref
->deref_type
) {
408 case nir_deref_type_array
:
409 if (mode
== nir_var_shared
) {
410 /* Shared variables have a bit more relaxed rules because we need
411 * to be able to handle array derefs on vectors. Fortunately,
412 * nir_lower_io handles these just fine.
414 validate_assert(state
, glsl_type_is_array(parent
->type
) ||
415 glsl_type_is_matrix(parent
->type
) ||
416 glsl_type_is_vector(parent
->type
));
418 /* Most of NIR cannot handle array derefs on vectors */
419 validate_assert(state
, glsl_type_is_array(parent
->type
) ||
420 glsl_type_is_matrix(parent
->type
));
422 validate_assert(state
, deref
->type
== glsl_get_array_element(parent
->type
));
423 if (nir_deref_as_array(deref
)->deref_array_type
==
424 nir_deref_array_type_indirect
)
425 validate_src(&nir_deref_as_array(deref
)->indirect
, state
, 32, 1);
428 case nir_deref_type_struct
:
429 assume(parent
); /* cannot happen: deref change starts w/ nir_deref_var */
430 validate_assert(state
, deref
->type
==
431 glsl_get_struct_field(parent
->type
,
432 nir_deref_as_struct(deref
)->index
));
435 case nir_deref_type_var
:
439 validate_assert(state
, !"Invalid deref type");
444 deref
= deref
->child
;
449 validate_var_use(nir_variable
*var
, validate_state
*state
)
451 if (var
->data
.mode
== nir_var_local
) {
452 struct hash_entry
*entry
= _mesa_hash_table_search(state
->var_defs
, var
);
454 validate_assert(state
, entry
);
455 validate_assert(state
, (nir_function_impl
*) entry
->data
== state
->impl
);
460 validate_deref_var(void *parent_mem_ctx
, nir_deref_var
*deref
, validate_state
*state
)
462 validate_assert(state
, deref
!= NULL
);
463 validate_assert(state
, ralloc_parent(deref
) == parent_mem_ctx
);
464 validate_assert(state
, deref
->deref
.type
== deref
->var
->type
);
466 validate_var_use(deref
->var
, state
);
468 validate_deref_chain(&deref
->deref
, deref
->var
->data
.mode
, state
);
472 validate_intrinsic_instr(nir_intrinsic_instr
*instr
, validate_state
*state
)
474 unsigned bit_size
= 0;
475 if (instr
->intrinsic
== nir_intrinsic_load_var
||
476 instr
->intrinsic
== nir_intrinsic_store_var
) {
477 const struct glsl_type
*type
=
478 nir_deref_tail(&instr
->variables
[0]->deref
)->type
;
479 bit_size
= glsl_get_bit_size(type
);
482 unsigned num_srcs
= nir_intrinsic_infos
[instr
->intrinsic
].num_srcs
;
483 for (unsigned i
= 0; i
< num_srcs
; i
++) {
484 unsigned components_read
=
485 nir_intrinsic_infos
[instr
->intrinsic
].src_components
[i
];
486 if (components_read
== 0)
487 components_read
= instr
->num_components
;
489 validate_assert(state
, components_read
> 0);
491 validate_src(&instr
->src
[i
], state
, bit_size
, components_read
);
494 unsigned num_vars
= nir_intrinsic_infos
[instr
->intrinsic
].num_variables
;
495 for (unsigned i
= 0; i
< num_vars
; i
++) {
496 validate_deref_var(instr
, instr
->variables
[i
], state
);
499 if (nir_intrinsic_infos
[instr
->intrinsic
].has_dest
) {
500 unsigned components_written
=
501 nir_intrinsic_infos
[instr
->intrinsic
].dest_components
;
502 if (components_written
== 0)
503 components_written
= instr
->num_components
;
505 validate_assert(state
, components_written
> 0);
507 validate_dest(&instr
->dest
, state
, bit_size
, components_written
);
510 switch (instr
->intrinsic
) {
511 case nir_intrinsic_load_var
: {
512 const struct glsl_type
*type
=
513 nir_deref_tail(&instr
->variables
[0]->deref
)->type
;
514 validate_assert(state
, glsl_type_is_vector_or_scalar(type
) ||
515 (instr
->variables
[0]->var
->data
.mode
== nir_var_uniform
&&
516 glsl_get_base_type(type
) == GLSL_TYPE_SUBROUTINE
));
517 validate_assert(state
, instr
->num_components
== glsl_get_vector_elements(type
));
520 case nir_intrinsic_store_var
: {
521 const struct glsl_type
*type
=
522 nir_deref_tail(&instr
->variables
[0]->deref
)->type
;
523 validate_assert(state
, glsl_type_is_vector_or_scalar(type
) ||
524 (instr
->variables
[0]->var
->data
.mode
== nir_var_uniform
&&
525 glsl_get_base_type(type
) == GLSL_TYPE_SUBROUTINE
));
526 validate_assert(state
, instr
->num_components
== glsl_get_vector_elements(type
));
527 validate_assert(state
, instr
->variables
[0]->var
->data
.mode
!= nir_var_shader_in
&&
528 instr
->variables
[0]->var
->data
.mode
!= nir_var_uniform
&&
529 instr
->variables
[0]->var
->data
.mode
!= nir_var_shader_storage
);
530 validate_assert(state
, (nir_intrinsic_write_mask(instr
) & ~((1 << instr
->num_components
) - 1)) == 0);
533 case nir_intrinsic_copy_var
:
534 validate_assert(state
, nir_deref_tail(&instr
->variables
[0]->deref
)->type
==
535 nir_deref_tail(&instr
->variables
[1]->deref
)->type
);
536 validate_assert(state
, instr
->variables
[0]->var
->data
.mode
!= nir_var_shader_in
&&
537 instr
->variables
[0]->var
->data
.mode
!= nir_var_uniform
&&
538 instr
->variables
[0]->var
->data
.mode
!= nir_var_shader_storage
);
546 validate_tex_instr(nir_tex_instr
*instr
, validate_state
*state
)
548 bool src_type_seen
[nir_num_tex_src_types
];
549 for (unsigned i
= 0; i
< nir_num_tex_src_types
; i
++)
550 src_type_seen
[i
] = false;
552 for (unsigned i
= 0; i
< instr
->num_srcs
; i
++) {
553 validate_assert(state
, !src_type_seen
[instr
->src
[i
].src_type
]);
554 src_type_seen
[instr
->src
[i
].src_type
] = true;
555 validate_src(&instr
->src
[i
].src
, state
,
556 0, nir_tex_instr_src_size(instr
, i
));
559 if (instr
->texture
!= NULL
)
560 validate_deref_var(instr
, instr
->texture
, state
);
562 if (instr
->sampler
!= NULL
)
563 validate_deref_var(instr
, instr
->sampler
, state
);
565 validate_dest(&instr
->dest
, state
, 0, nir_tex_instr_dest_size(instr
));
569 validate_call_instr(nir_call_instr
*instr
, validate_state
*state
)
571 if (instr
->return_deref
== NULL
) {
572 validate_assert(state
, glsl_type_is_void(instr
->callee
->return_type
));
574 validate_assert(state
, instr
->return_deref
->deref
.type
== instr
->callee
->return_type
);
575 validate_deref_var(instr
, instr
->return_deref
, state
);
578 validate_assert(state
, instr
->num_params
== instr
->callee
->num_params
);
580 for (unsigned i
= 0; i
< instr
->num_params
; i
++) {
581 validate_assert(state
, instr
->callee
->params
[i
].type
== instr
->params
[i
]->deref
.type
);
582 validate_deref_var(instr
, instr
->params
[i
], state
);
587 validate_load_const_instr(nir_load_const_instr
*instr
, validate_state
*state
)
589 validate_ssa_def(&instr
->def
, state
);
593 validate_ssa_undef_instr(nir_ssa_undef_instr
*instr
, validate_state
*state
)
595 validate_ssa_def(&instr
->def
, state
);
599 validate_phi_instr(nir_phi_instr
*instr
, validate_state
*state
)
602 * don't validate the sources until we get to them from their predecessor
603 * basic blocks, to avoid validating an SSA use before its definition.
606 validate_dest(&instr
->dest
, state
, 0, 0);
608 exec_list_validate(&instr
->srcs
);
609 validate_assert(state
, exec_list_length(&instr
->srcs
) ==
610 state
->block
->predecessors
->entries
);
614 validate_instr(nir_instr
*instr
, validate_state
*state
)
616 validate_assert(state
, instr
->block
== state
->block
);
618 state
->instr
= instr
;
620 switch (instr
->type
) {
621 case nir_instr_type_alu
:
622 validate_alu_instr(nir_instr_as_alu(instr
), state
);
625 case nir_instr_type_call
:
626 validate_call_instr(nir_instr_as_call(instr
), state
);
629 case nir_instr_type_intrinsic
:
630 validate_intrinsic_instr(nir_instr_as_intrinsic(instr
), state
);
633 case nir_instr_type_tex
:
634 validate_tex_instr(nir_instr_as_tex(instr
), state
);
637 case nir_instr_type_load_const
:
638 validate_load_const_instr(nir_instr_as_load_const(instr
), state
);
641 case nir_instr_type_phi
:
642 validate_phi_instr(nir_instr_as_phi(instr
), state
);
645 case nir_instr_type_ssa_undef
:
646 validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr
), state
);
649 case nir_instr_type_jump
:
653 validate_assert(state
, !"Invalid ALU instruction type");
661 validate_phi_src(nir_phi_instr
*instr
, nir_block
*pred
, validate_state
*state
)
663 state
->instr
= &instr
->instr
;
665 validate_assert(state
, instr
->dest
.is_ssa
);
667 exec_list_validate(&instr
->srcs
);
668 nir_foreach_phi_src(src
, instr
) {
669 if (src
->pred
== pred
) {
670 validate_assert(state
, src
->src
.is_ssa
);
671 validate_src(&src
->src
, state
, instr
->dest
.ssa
.bit_size
,
672 instr
->dest
.ssa
.num_components
);
682 validate_phi_srcs(nir_block
*block
, nir_block
*succ
, validate_state
*state
)
684 nir_foreach_instr(instr
, succ
) {
685 if (instr
->type
!= nir_instr_type_phi
)
688 validate_phi_src(nir_instr_as_phi(instr
), block
, state
);
692 static void validate_cf_node(nir_cf_node
*node
, validate_state
*state
);
695 validate_block(nir_block
*block
, validate_state
*state
)
697 validate_assert(state
, block
->cf_node
.parent
== state
->parent_node
);
699 state
->block
= block
;
701 exec_list_validate(&block
->instr_list
);
702 nir_foreach_instr(instr
, block
) {
703 if (instr
->type
== nir_instr_type_phi
) {
704 validate_assert(state
, instr
== nir_block_first_instr(block
) ||
705 nir_instr_prev(instr
)->type
== nir_instr_type_phi
);
708 if (instr
->type
== nir_instr_type_jump
) {
709 validate_assert(state
, instr
== nir_block_last_instr(block
));
712 validate_instr(instr
, state
);
715 validate_assert(state
, block
->successors
[0] != NULL
);
716 validate_assert(state
, block
->successors
[0] != block
->successors
[1]);
718 for (unsigned i
= 0; i
< 2; i
++) {
719 if (block
->successors
[i
] != NULL
) {
720 struct set_entry
*entry
=
721 _mesa_set_search(block
->successors
[i
]->predecessors
, block
);
722 validate_assert(state
, entry
);
724 validate_phi_srcs(block
, block
->successors
[i
], state
);
728 struct set_entry
*entry
;
729 set_foreach(block
->predecessors
, entry
) {
730 const nir_block
*pred
= entry
->key
;
731 validate_assert(state
, pred
->successors
[0] == block
||
732 pred
->successors
[1] == block
);
735 if (!exec_list_is_empty(&block
->instr_list
) &&
736 nir_block_last_instr(block
)->type
== nir_instr_type_jump
) {
737 validate_assert(state
, block
->successors
[1] == NULL
);
738 nir_jump_instr
*jump
= nir_instr_as_jump(nir_block_last_instr(block
));
739 switch (jump
->type
) {
740 case nir_jump_break
: {
742 nir_cf_node_as_block(nir_cf_node_next(&state
->loop
->cf_node
));
743 validate_assert(state
, block
->successors
[0] == after
);
747 case nir_jump_continue
: {
748 nir_block
*first
= nir_loop_first_block(state
->loop
);
749 validate_assert(state
, block
->successors
[0] == first
);
753 case nir_jump_return
:
754 validate_assert(state
, block
->successors
[0] == state
->impl
->end_block
);
758 unreachable("bad jump type");
761 nir_cf_node
*next
= nir_cf_node_next(&block
->cf_node
);
763 switch (state
->parent_node
->type
) {
764 case nir_cf_node_loop
: {
765 nir_block
*first
= nir_loop_first_block(state
->loop
);
766 validate_assert(state
, block
->successors
[0] == first
);
767 /* due to the hack for infinite loops, block->successors[1] may
768 * point to the block after the loop.
773 case nir_cf_node_if
: {
775 nir_cf_node_as_block(nir_cf_node_next(state
->parent_node
));
776 validate_assert(state
, block
->successors
[0] == after
);
777 validate_assert(state
, block
->successors
[1] == NULL
);
781 case nir_cf_node_function
:
782 validate_assert(state
, block
->successors
[0] == state
->impl
->end_block
);
783 validate_assert(state
, block
->successors
[1] == NULL
);
787 unreachable("unknown control flow node type");
790 if (next
->type
== nir_cf_node_if
) {
791 nir_if
*if_stmt
= nir_cf_node_as_if(next
);
792 validate_assert(state
, block
->successors
[0] ==
793 nir_if_first_then_block(if_stmt
));
794 validate_assert(state
, block
->successors
[1] ==
795 nir_if_first_else_block(if_stmt
));
797 validate_assert(state
, next
->type
== nir_cf_node_loop
);
798 nir_loop
*loop
= nir_cf_node_as_loop(next
);
799 validate_assert(state
, block
->successors
[0] ==
800 nir_loop_first_block(loop
));
801 validate_assert(state
, block
->successors
[1] == NULL
);
808 validate_if(nir_if
*if_stmt
, validate_state
*state
)
810 state
->if_stmt
= if_stmt
;
812 validate_assert(state
, !exec_node_is_head_sentinel(if_stmt
->cf_node
.node
.prev
));
813 nir_cf_node
*prev_node
= nir_cf_node_prev(&if_stmt
->cf_node
);
814 validate_assert(state
, prev_node
->type
== nir_cf_node_block
);
816 validate_assert(state
, !exec_node_is_tail_sentinel(if_stmt
->cf_node
.node
.next
));
817 nir_cf_node
*next_node
= nir_cf_node_next(&if_stmt
->cf_node
);
818 validate_assert(state
, next_node
->type
== nir_cf_node_block
);
820 validate_src(&if_stmt
->condition
, state
, 32, 1);
822 validate_assert(state
, !exec_list_is_empty(&if_stmt
->then_list
));
823 validate_assert(state
, !exec_list_is_empty(&if_stmt
->else_list
));
825 nir_cf_node
*old_parent
= state
->parent_node
;
826 state
->parent_node
= &if_stmt
->cf_node
;
828 exec_list_validate(&if_stmt
->then_list
);
829 foreach_list_typed(nir_cf_node
, cf_node
, node
, &if_stmt
->then_list
) {
830 validate_cf_node(cf_node
, state
);
833 exec_list_validate(&if_stmt
->else_list
);
834 foreach_list_typed(nir_cf_node
, cf_node
, node
, &if_stmt
->else_list
) {
835 validate_cf_node(cf_node
, state
);
838 state
->parent_node
= old_parent
;
839 state
->if_stmt
= NULL
;
843 validate_loop(nir_loop
*loop
, validate_state
*state
)
845 validate_assert(state
, !exec_node_is_head_sentinel(loop
->cf_node
.node
.prev
));
846 nir_cf_node
*prev_node
= nir_cf_node_prev(&loop
->cf_node
);
847 validate_assert(state
, prev_node
->type
== nir_cf_node_block
);
849 validate_assert(state
, !exec_node_is_tail_sentinel(loop
->cf_node
.node
.next
));
850 nir_cf_node
*next_node
= nir_cf_node_next(&loop
->cf_node
);
851 validate_assert(state
, next_node
->type
== nir_cf_node_block
);
853 validate_assert(state
, !exec_list_is_empty(&loop
->body
));
855 nir_cf_node
*old_parent
= state
->parent_node
;
856 state
->parent_node
= &loop
->cf_node
;
857 nir_loop
*old_loop
= state
->loop
;
860 exec_list_validate(&loop
->body
);
861 foreach_list_typed(nir_cf_node
, cf_node
, node
, &loop
->body
) {
862 validate_cf_node(cf_node
, state
);
865 state
->parent_node
= old_parent
;
866 state
->loop
= old_loop
;
870 validate_cf_node(nir_cf_node
*node
, validate_state
*state
)
872 validate_assert(state
, node
->parent
== state
->parent_node
);
874 switch (node
->type
) {
875 case nir_cf_node_block
:
876 validate_block(nir_cf_node_as_block(node
), state
);
880 validate_if(nir_cf_node_as_if(node
), state
);
883 case nir_cf_node_loop
:
884 validate_loop(nir_cf_node_as_loop(node
), state
);
888 unreachable("Invalid CF node type");
893 prevalidate_reg_decl(nir_register
*reg
, bool is_global
, validate_state
*state
)
895 validate_assert(state
, reg
->is_global
== is_global
);
898 validate_assert(state
, reg
->index
< state
->shader
->reg_alloc
);
900 validate_assert(state
, reg
->index
< state
->impl
->reg_alloc
);
901 validate_assert(state
, !BITSET_TEST(state
->regs_found
, reg
->index
));
902 BITSET_SET(state
->regs_found
, reg
->index
);
904 list_validate(®
->uses
);
905 list_validate(®
->defs
);
906 list_validate(®
->if_uses
);
908 reg_validate_state
*reg_state
= ralloc(state
->regs
, reg_validate_state
);
909 reg_state
->uses
= _mesa_set_create(reg_state
, _mesa_hash_pointer
,
910 _mesa_key_pointer_equal
);
911 reg_state
->if_uses
= _mesa_set_create(reg_state
, _mesa_hash_pointer
,
912 _mesa_key_pointer_equal
);
913 reg_state
->defs
= _mesa_set_create(reg_state
, _mesa_hash_pointer
,
914 _mesa_key_pointer_equal
);
916 reg_state
->where_defined
= is_global
? NULL
: state
->impl
;
918 _mesa_hash_table_insert(state
->regs
, reg
, reg_state
);
922 postvalidate_reg_decl(nir_register
*reg
, validate_state
*state
)
924 struct hash_entry
*entry
= _mesa_hash_table_search(state
->regs
, reg
);
927 reg_validate_state
*reg_state
= (reg_validate_state
*) entry
->data
;
929 nir_foreach_use(src
, reg
) {
930 struct set_entry
*entry
= _mesa_set_search(reg_state
->uses
, src
);
931 validate_assert(state
, entry
);
932 _mesa_set_remove(reg_state
->uses
, entry
);
935 if (reg_state
->uses
->entries
!= 0) {
936 printf("extra entries in register uses:\n");
937 struct set_entry
*entry
;
938 set_foreach(reg_state
->uses
, entry
)
939 printf("%p\n", entry
->key
);
944 nir_foreach_if_use(src
, reg
) {
945 struct set_entry
*entry
= _mesa_set_search(reg_state
->if_uses
, src
);
946 validate_assert(state
, entry
);
947 _mesa_set_remove(reg_state
->if_uses
, entry
);
950 if (reg_state
->if_uses
->entries
!= 0) {
951 printf("extra entries in register if_uses:\n");
952 struct set_entry
*entry
;
953 set_foreach(reg_state
->if_uses
, entry
)
954 printf("%p\n", entry
->key
);
959 nir_foreach_def(src
, reg
) {
960 struct set_entry
*entry
= _mesa_set_search(reg_state
->defs
, src
);
961 validate_assert(state
, entry
);
962 _mesa_set_remove(reg_state
->defs
, entry
);
965 if (reg_state
->defs
->entries
!= 0) {
966 printf("extra entries in register defs:\n");
967 struct set_entry
*entry
;
968 set_foreach(reg_state
->defs
, entry
)
969 printf("%p\n", entry
->key
);
976 validate_var_decl(nir_variable
*var
, bool is_global
, validate_state
*state
)
980 validate_assert(state
, is_global
== nir_variable_is_global(var
));
982 /* Must have exactly one mode set */
983 validate_assert(state
, util_bitcount(var
->data
.mode
) == 1);
985 if (var
->data
.compact
) {
986 /* The "compact" flag is only valid on arrays of scalars. */
987 assert(glsl_type_is_array(var
->type
));
989 const struct glsl_type
*type
= glsl_get_array_element(var
->type
);
990 if (nir_is_per_vertex_io(var
, state
->shader
->info
.stage
)) {
991 assert(glsl_type_is_array(type
));
992 assert(glsl_type_is_scalar(glsl_get_array_element(type
)));
994 assert(glsl_type_is_scalar(type
));
999 * TODO validate some things ir_validate.cpp does (requires more GLSL type
1004 _mesa_hash_table_insert(state
->var_defs
, var
, state
->impl
);
1011 postvalidate_ssa_def(nir_ssa_def
*def
, void *void_state
)
1013 validate_state
*state
= void_state
;
1015 struct hash_entry
*entry
= _mesa_hash_table_search(state
->ssa_defs
, def
);
1018 ssa_def_validate_state
*def_state
= (ssa_def_validate_state
*)entry
->data
;
1020 nir_foreach_use(src
, def
) {
1021 struct set_entry
*entry
= _mesa_set_search(def_state
->uses
, src
);
1022 validate_assert(state
, entry
);
1023 _mesa_set_remove(def_state
->uses
, entry
);
1026 if (def_state
->uses
->entries
!= 0) {
1027 printf("extra entries in SSA def uses:\n");
1028 struct set_entry
*entry
;
1029 set_foreach(def_state
->uses
, entry
)
1030 printf("%p\n", entry
->key
);
1035 nir_foreach_if_use(src
, def
) {
1036 struct set_entry
*entry
= _mesa_set_search(def_state
->if_uses
, src
);
1037 validate_assert(state
, entry
);
1038 _mesa_set_remove(def_state
->if_uses
, entry
);
1041 if (def_state
->if_uses
->entries
!= 0) {
1042 printf("extra entries in SSA def uses:\n");
1043 struct set_entry
*entry
;
1044 set_foreach(def_state
->if_uses
, entry
)
1045 printf("%p\n", entry
->key
);
1054 validate_function_impl(nir_function_impl
*impl
, validate_state
*state
)
1056 validate_assert(state
, impl
->function
->impl
== impl
);
1057 validate_assert(state
, impl
->cf_node
.parent
== NULL
);
1059 validate_assert(state
, impl
->num_params
== impl
->function
->num_params
);
1060 for (unsigned i
= 0; i
< impl
->num_params
; i
++) {
1061 validate_assert(state
, impl
->params
[i
]->type
== impl
->function
->params
[i
].type
);
1062 validate_assert(state
, impl
->params
[i
]->data
.mode
== nir_var_param
);
1063 validate_assert(state
, impl
->params
[i
]->data
.location
== i
);
1064 validate_var_decl(impl
->params
[i
], false, state
);
1067 if (glsl_type_is_void(impl
->function
->return_type
)) {
1068 validate_assert(state
, impl
->return_var
== NULL
);
1070 validate_assert(state
, impl
->return_var
->type
== impl
->function
->return_type
);
1071 validate_assert(state
, impl
->return_var
->data
.mode
== nir_var_param
);
1072 validate_assert(state
, impl
->return_var
->data
.location
== -1);
1073 validate_var_decl(impl
->return_var
, false, state
);
1076 validate_assert(state
, exec_list_is_empty(&impl
->end_block
->instr_list
));
1077 validate_assert(state
, impl
->end_block
->successors
[0] == NULL
);
1078 validate_assert(state
, impl
->end_block
->successors
[1] == NULL
);
1081 state
->parent_node
= &impl
->cf_node
;
1083 exec_list_validate(&impl
->locals
);
1084 nir_foreach_variable(var
, &impl
->locals
) {
1085 validate_var_decl(var
, false, state
);
1088 state
->regs_found
= realloc(state
->regs_found
,
1089 BITSET_WORDS(impl
->reg_alloc
) *
1090 sizeof(BITSET_WORD
));
1091 memset(state
->regs_found
, 0, BITSET_WORDS(impl
->reg_alloc
) *
1092 sizeof(BITSET_WORD
));
1093 exec_list_validate(&impl
->registers
);
1094 foreach_list_typed(nir_register
, reg
, node
, &impl
->registers
) {
1095 prevalidate_reg_decl(reg
, false, state
);
1098 state
->ssa_defs_found
= realloc(state
->ssa_defs_found
,
1099 BITSET_WORDS(impl
->ssa_alloc
) *
1100 sizeof(BITSET_WORD
));
1101 memset(state
->ssa_defs_found
, 0, BITSET_WORDS(impl
->ssa_alloc
) *
1102 sizeof(BITSET_WORD
));
1103 exec_list_validate(&impl
->body
);
1104 foreach_list_typed(nir_cf_node
, node
, node
, &impl
->body
) {
1105 validate_cf_node(node
, state
);
1108 foreach_list_typed(nir_register
, reg
, node
, &impl
->registers
) {
1109 postvalidate_reg_decl(reg
, state
);
1112 nir_foreach_block(block
, impl
) {
1113 nir_foreach_instr(instr
, block
)
1114 nir_foreach_ssa_def(instr
, postvalidate_ssa_def
, state
);
1119 validate_function(nir_function
*func
, validate_state
*state
)
1121 if (func
->impl
!= NULL
) {
1122 validate_assert(state
, func
->impl
->function
== func
);
1123 validate_function_impl(func
->impl
, state
);
1128 init_validate_state(validate_state
*state
)
1130 state
->regs
= _mesa_hash_table_create(NULL
, _mesa_hash_pointer
,
1131 _mesa_key_pointer_equal
);
1132 state
->ssa_defs
= _mesa_hash_table_create(NULL
, _mesa_hash_pointer
,
1133 _mesa_key_pointer_equal
);
1134 state
->ssa_defs_found
= NULL
;
1135 state
->regs_found
= NULL
;
1136 state
->var_defs
= _mesa_hash_table_create(NULL
, _mesa_hash_pointer
,
1137 _mesa_key_pointer_equal
);
1138 state
->errors
= _mesa_hash_table_create(NULL
, _mesa_hash_pointer
,
1139 _mesa_key_pointer_equal
);
1142 state
->instr
= NULL
;
1147 destroy_validate_state(validate_state
*state
)
1149 _mesa_hash_table_destroy(state
->regs
, NULL
);
1150 _mesa_hash_table_destroy(state
->ssa_defs
, NULL
);
1151 free(state
->ssa_defs_found
);
1152 free(state
->regs_found
);
1153 _mesa_hash_table_destroy(state
->var_defs
, NULL
);
1154 _mesa_hash_table_destroy(state
->errors
, NULL
);
1158 dump_errors(validate_state
*state
)
1160 struct hash_table
*errors
= state
->errors
;
1162 fprintf(stderr
, "%d errors:\n", _mesa_hash_table_num_entries(errors
));
1164 nir_print_shader_annotated(state
->shader
, stderr
, errors
);
1166 if (_mesa_hash_table_num_entries(errors
) > 0) {
1167 fprintf(stderr
, "%d additional errors:\n",
1168 _mesa_hash_table_num_entries(errors
));
1169 struct hash_entry
*entry
;
1170 hash_table_foreach(errors
, entry
) {
1171 fprintf(stderr
, "%s\n", (char *)entry
->data
);
1179 nir_validate_shader(nir_shader
*shader
)
1181 static int should_validate
= -1;
1182 if (should_validate
< 0)
1183 should_validate
= env_var_as_boolean("NIR_VALIDATE", true);
1184 if (!should_validate
)
1187 validate_state state
;
1188 init_validate_state(&state
);
1190 state
.shader
= shader
;
1192 exec_list_validate(&shader
->uniforms
);
1193 nir_foreach_variable(var
, &shader
->uniforms
) {
1194 validate_var_decl(var
, true, &state
);
1197 exec_list_validate(&shader
->inputs
);
1198 nir_foreach_variable(var
, &shader
->inputs
) {
1199 validate_var_decl(var
, true, &state
);
1202 exec_list_validate(&shader
->outputs
);
1203 nir_foreach_variable(var
, &shader
->outputs
) {
1204 validate_var_decl(var
, true, &state
);
1207 exec_list_validate(&shader
->shared
);
1208 nir_foreach_variable(var
, &shader
->shared
) {
1209 validate_var_decl(var
, true, &state
);
1212 exec_list_validate(&shader
->globals
);
1213 nir_foreach_variable(var
, &shader
->globals
) {
1214 validate_var_decl(var
, true, &state
);
1217 exec_list_validate(&shader
->system_values
);
1218 nir_foreach_variable(var
, &shader
->system_values
) {
1219 validate_var_decl(var
, true, &state
);
1222 state
.regs_found
= realloc(state
.regs_found
,
1223 BITSET_WORDS(shader
->reg_alloc
) *
1224 sizeof(BITSET_WORD
));
1225 memset(state
.regs_found
, 0, BITSET_WORDS(shader
->reg_alloc
) *
1226 sizeof(BITSET_WORD
));
1227 exec_list_validate(&shader
->registers
);
1228 foreach_list_typed(nir_register
, reg
, node
, &shader
->registers
) {
1229 prevalidate_reg_decl(reg
, true, &state
);
1232 exec_list_validate(&shader
->functions
);
1233 foreach_list_typed(nir_function
, func
, node
, &shader
->functions
) {
1234 validate_function(func
, &state
);
1237 foreach_list_typed(nir_register
, reg
, node
, &shader
->registers
) {
1238 postvalidate_reg_decl(reg
, &state
);
1241 if (_mesa_hash_table_num_entries(state
.errors
) > 0)
1242 dump_errors(&state
);
1244 destroy_validate_state(&state
);