2 * Copyright © 2014 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
24 * Connor Abbott (cwabbott0@gmail.com)
29 #include "c11/threads.h"
33 * This file checks for invalid IR indicating a bug somewhere in the compiler.
36 /* Since this file is just a pile of asserts, don't bother compiling it if
37 * we're not building a debug build.
42 * Per-register validation state.
47 * equivalent to the uses and defs in nir_register, but built up by the
48 * validator. At the end, we verify that the sets have the same entries.
50 struct set
*uses
, *if_uses
, *defs
;
51 nir_function_impl
*where_defined
; /* NULL for global registers */
57 /* map of register -> validation state (struct above) */
58 struct hash_table
*regs
;
60 /* the current shader being validated */
63 /* the current instruction being validated */
66 /* the current variable being validated */
69 /* the current basic block being validated */
72 /* the current if statement being validated */
75 /* the current loop being visited */
78 /* the parent of the current cf node being visited */
79 nir_cf_node
*parent_node
;
81 /* the current function implementation being validated */
82 nir_function_impl
*impl
;
84 /* Set of seen SSA sources */
87 /* bitset of ssa definitions we have found; used to check uniqueness */
88 BITSET_WORD
*ssa_defs_found
;
90 /* bitset of registers we have currently found; used to check uniqueness */
91 BITSET_WORD
*regs_found
;
93 /* map of variable -> function implementation where it is defined or NULL
94 * if it is a global variable
96 struct hash_table
*var_defs
;
98 /* map of instruction/var/etc to failed assert string */
99 struct hash_table
*errors
;
103 log_error(validate_state
*state
, const char *cond
, const char *file
, int line
)
114 char *msg
= ralloc_asprintf(state
->errors
, "error: %s (%s:%d)",
117 _mesa_hash_table_insert(state
->errors
, obj
, msg
);
120 #define validate_assert(state, cond) do { \
122 log_error(state, #cond, __FILE__, __LINE__); \
125 static void validate_src(nir_src
*src
, validate_state
*state
,
126 unsigned bit_sizes
, unsigned num_components
);
129 validate_num_components(validate_state
*state
, unsigned num_components
)
131 validate_assert(state
, nir_num_components_valid(num_components
));
135 validate_reg_src(nir_src
*src
, validate_state
*state
,
136 unsigned bit_sizes
, unsigned num_components
)
138 validate_assert(state
, src
->reg
.reg
!= NULL
);
140 struct hash_entry
*entry
;
141 entry
= _mesa_hash_table_search(state
->regs
, src
->reg
.reg
);
142 validate_assert(state
, entry
);
144 reg_validate_state
*reg_state
= (reg_validate_state
*) entry
->data
;
147 _mesa_set_add(reg_state
->uses
, src
);
149 validate_assert(state
, state
->if_stmt
);
150 _mesa_set_add(reg_state
->if_uses
, src
);
153 validate_assert(state
, reg_state
->where_defined
== state
->impl
&&
154 "using a register declared in a different function");
157 validate_assert(state
, src
->reg
.reg
->bit_size
& bit_sizes
);
159 validate_assert(state
, src
->reg
.reg
->num_components
== num_components
);
161 validate_assert(state
, (src
->reg
.reg
->num_array_elems
== 0 ||
162 src
->reg
.base_offset
< src
->reg
.reg
->num_array_elems
) &&
163 "definitely out-of-bounds array access");
165 if (src
->reg
.indirect
) {
166 validate_assert(state
, src
->reg
.reg
->num_array_elems
!= 0);
167 validate_assert(state
, (src
->reg
.indirect
->is_ssa
||
168 src
->reg
.indirect
->reg
.indirect
== NULL
) &&
169 "only one level of indirection allowed");
170 validate_src(src
->reg
.indirect
, state
, 32, 1);
174 #define SET_PTR_BIT(ptr, bit) \
175 (void *)(((uintptr_t)(ptr)) | (((uintptr_t)1) << bit))
178 validate_ssa_src(nir_src
*src
, validate_state
*state
,
179 unsigned bit_sizes
, unsigned num_components
)
181 validate_assert(state
, src
->ssa
!= NULL
);
183 /* As we walk SSA defs, we add every use to this set. We need to make sure
184 * our use is seen in a use list.
186 struct set_entry
*entry
;
188 entry
= _mesa_set_search(state
->ssa_srcs
, src
);
190 entry
= _mesa_set_search(state
->ssa_srcs
, SET_PTR_BIT(src
, 0));
192 validate_assert(state
, entry
);
194 /* This will let us prove that we've seen all the sources */
196 _mesa_set_remove(state
->ssa_srcs
, entry
);
199 validate_assert(state
, src
->ssa
->bit_size
& bit_sizes
);
201 validate_assert(state
, src
->ssa
->num_components
== num_components
);
203 /* TODO validate that the use is dominated by the definition */
207 validate_src(nir_src
*src
, validate_state
*state
,
208 unsigned bit_sizes
, unsigned num_components
)
211 validate_assert(state
, src
->parent_instr
== state
->instr
);
213 validate_assert(state
, src
->parent_if
== state
->if_stmt
);
216 validate_ssa_src(src
, state
, bit_sizes
, num_components
);
218 validate_reg_src(src
, state
, bit_sizes
, num_components
);
222 validate_alu_src(nir_alu_instr
*instr
, unsigned index
, validate_state
*state
)
224 nir_alu_src
*src
= &instr
->src
[index
];
226 if (instr
->op
== nir_op_mov
)
227 assert(!src
->abs
&& !src
->negate
);
229 unsigned num_components
= nir_src_num_components(src
->src
);
230 for (unsigned i
= 0; i
< NIR_MAX_VEC_COMPONENTS
; i
++) {
231 validate_assert(state
, src
->swizzle
[i
] < NIR_MAX_VEC_COMPONENTS
);
233 if (nir_alu_instr_channel_used(instr
, index
, i
))
234 validate_assert(state
, src
->swizzle
[i
] < num_components
);
237 validate_src(&src
->src
, state
, 0, 0);
241 validate_reg_dest(nir_reg_dest
*dest
, validate_state
*state
,
242 unsigned bit_sizes
, unsigned num_components
)
244 validate_assert(state
, dest
->reg
!= NULL
);
246 validate_assert(state
, dest
->parent_instr
== state
->instr
);
248 struct hash_entry
*entry2
;
249 entry2
= _mesa_hash_table_search(state
->regs
, dest
->reg
);
251 validate_assert(state
, entry2
);
253 reg_validate_state
*reg_state
= (reg_validate_state
*) entry2
->data
;
254 _mesa_set_add(reg_state
->defs
, dest
);
256 validate_assert(state
, reg_state
->where_defined
== state
->impl
&&
257 "writing to a register declared in a different function");
260 validate_assert(state
, dest
->reg
->bit_size
& bit_sizes
);
262 validate_assert(state
, dest
->reg
->num_components
== num_components
);
264 validate_assert(state
, (dest
->reg
->num_array_elems
== 0 ||
265 dest
->base_offset
< dest
->reg
->num_array_elems
) &&
266 "definitely out-of-bounds array access");
268 if (dest
->indirect
) {
269 validate_assert(state
, dest
->reg
->num_array_elems
!= 0);
270 validate_assert(state
, (dest
->indirect
->is_ssa
|| dest
->indirect
->reg
.indirect
== NULL
) &&
271 "only one level of indirection allowed");
272 validate_src(dest
->indirect
, state
, 32, 1);
277 validate_ssa_def(nir_ssa_def
*def
, validate_state
*state
)
279 validate_assert(state
, def
->index
< state
->impl
->ssa_alloc
);
280 validate_assert(state
, !BITSET_TEST(state
->ssa_defs_found
, def
->index
));
281 BITSET_SET(state
->ssa_defs_found
, def
->index
);
283 validate_assert(state
, def
->parent_instr
== state
->instr
);
284 validate_num_components(state
, def
->num_components
);
286 list_validate(&def
->uses
);
287 nir_foreach_use(src
, def
) {
288 validate_assert(state
, src
->is_ssa
);
289 validate_assert(state
, src
->ssa
== def
);
290 bool already_seen
= false;
291 _mesa_set_search_and_add(state
->ssa_srcs
, src
, &already_seen
);
292 /* A nir_src should only appear once and only in one SSA def use list */
293 validate_assert(state
, !already_seen
);
296 list_validate(&def
->if_uses
);
297 nir_foreach_if_use(src
, def
) {
298 validate_assert(state
, src
->is_ssa
);
299 validate_assert(state
, src
->ssa
== def
);
300 bool already_seen
= false;
301 _mesa_set_search_and_add(state
->ssa_srcs
, SET_PTR_BIT(src
, 0),
303 /* A nir_src should only appear once and only in one SSA def use list */
304 validate_assert(state
, !already_seen
);
309 validate_dest(nir_dest
*dest
, validate_state
*state
,
310 unsigned bit_sizes
, unsigned num_components
)
314 validate_assert(state
, dest
->ssa
.bit_size
& bit_sizes
);
316 validate_assert(state
, dest
->ssa
.num_components
== num_components
);
317 validate_ssa_def(&dest
->ssa
, state
);
319 validate_reg_dest(&dest
->reg
, state
, bit_sizes
, num_components
);
324 validate_alu_dest(nir_alu_instr
*instr
, validate_state
*state
)
326 nir_alu_dest
*dest
= &instr
->dest
;
328 if (instr
->op
== nir_op_mov
)
329 assert(!dest
->saturate
);
331 unsigned dest_size
= nir_dest_num_components(dest
->dest
);
333 * validate that the instruction doesn't write to components not in the
336 validate_assert(state
, !(dest
->write_mask
& ~((1 << dest_size
) - 1)));
338 /* validate that saturate is only ever used on instructions with
339 * destinations of type float
341 nir_alu_instr
*alu
= nir_instr_as_alu(state
->instr
);
342 validate_assert(state
,
343 (nir_alu_type_get_base_type(nir_op_infos
[alu
->op
].output_type
) ==
347 validate_dest(&dest
->dest
, state
, 0, 0);
351 validate_alu_instr(nir_alu_instr
*instr
, validate_state
*state
)
353 validate_assert(state
, instr
->op
< nir_num_opcodes
);
355 unsigned instr_bit_size
= 0;
356 for (unsigned i
= 0; i
< nir_op_infos
[instr
->op
].num_inputs
; i
++) {
357 nir_alu_type src_type
= nir_op_infos
[instr
->op
].input_types
[i
];
358 unsigned src_bit_size
= nir_src_bit_size(instr
->src
[i
].src
);
359 if (nir_alu_type_get_type_size(src_type
)) {
360 validate_assert(state
, src_bit_size
== nir_alu_type_get_type_size(src_type
));
361 } else if (instr_bit_size
) {
362 validate_assert(state
, src_bit_size
== instr_bit_size
);
364 instr_bit_size
= src_bit_size
;
367 if (nir_alu_type_get_base_type(src_type
) == nir_type_float
) {
368 /* 8-bit float isn't a thing */
369 validate_assert(state
, src_bit_size
== 16 || src_bit_size
== 32 ||
373 validate_alu_src(instr
, i
, state
);
376 nir_alu_type dest_type
= nir_op_infos
[instr
->op
].output_type
;
377 unsigned dest_bit_size
= nir_dest_bit_size(instr
->dest
.dest
);
378 if (nir_alu_type_get_type_size(dest_type
)) {
379 validate_assert(state
, dest_bit_size
== nir_alu_type_get_type_size(dest_type
));
380 } else if (instr_bit_size
) {
381 validate_assert(state
, dest_bit_size
== instr_bit_size
);
383 /* The only unsized thing is the destination so it's vacuously valid */
386 if (nir_alu_type_get_base_type(dest_type
) == nir_type_float
) {
387 /* 8-bit float isn't a thing */
388 validate_assert(state
, dest_bit_size
== 16 || dest_bit_size
== 32 ||
389 dest_bit_size
== 64);
392 validate_alu_dest(instr
, state
);
396 validate_var_use(nir_variable
*var
, validate_state
*state
)
398 struct hash_entry
*entry
= _mesa_hash_table_search(state
->var_defs
, var
);
399 validate_assert(state
, entry
);
400 if (entry
&& var
->data
.mode
== nir_var_function_temp
)
401 validate_assert(state
, (nir_function_impl
*) entry
->data
== state
->impl
);
405 validate_deref_instr(nir_deref_instr
*instr
, validate_state
*state
)
407 if (instr
->deref_type
== nir_deref_type_var
) {
408 /* Variable dereferences are stupid simple. */
409 validate_assert(state
, instr
->mode
== instr
->var
->data
.mode
);
410 validate_assert(state
, instr
->type
== instr
->var
->type
);
411 validate_var_use(instr
->var
, state
);
412 } else if (instr
->deref_type
== nir_deref_type_cast
) {
413 /* For cast, we simply have to trust the instruction. It's up to
414 * lowering passes and front/back-ends to make them sane.
416 validate_src(&instr
->parent
, state
, 0, 0);
418 /* We just validate that the type and mode are there */
419 validate_assert(state
, instr
->mode
);
420 validate_assert(state
, instr
->type
);
422 /* We require the parent to be SSA. This may be lifted in the future */
423 validate_assert(state
, instr
->parent
.is_ssa
);
425 /* The parent pointer value must have the same number of components
426 * as the destination.
428 validate_src(&instr
->parent
, state
, nir_dest_bit_size(instr
->dest
),
429 nir_dest_num_components(instr
->dest
));
431 nir_instr
*parent_instr
= instr
->parent
.ssa
->parent_instr
;
433 /* The parent must come from another deref instruction */
434 validate_assert(state
, parent_instr
->type
== nir_instr_type_deref
);
436 nir_deref_instr
*parent
= nir_instr_as_deref(parent_instr
);
438 validate_assert(state
, instr
->mode
== parent
->mode
);
440 switch (instr
->deref_type
) {
441 case nir_deref_type_struct
:
442 validate_assert(state
, glsl_type_is_struct_or_ifc(parent
->type
));
443 validate_assert(state
,
444 instr
->strct
.index
< glsl_get_length(parent
->type
));
445 validate_assert(state
, instr
->type
==
446 glsl_get_struct_field(parent
->type
, instr
->strct
.index
));
449 case nir_deref_type_array
:
450 case nir_deref_type_array_wildcard
:
451 if (instr
->mode
== nir_var_mem_ubo
||
452 instr
->mode
== nir_var_mem_ssbo
||
453 instr
->mode
== nir_var_mem_shared
||
454 instr
->mode
== nir_var_mem_global
) {
455 /* Shared variables and UBO/SSBOs have a bit more relaxed rules
456 * because we need to be able to handle array derefs on vectors.
457 * Fortunately, nir_lower_io handles these just fine.
459 validate_assert(state
, glsl_type_is_array(parent
->type
) ||
460 glsl_type_is_matrix(parent
->type
) ||
461 glsl_type_is_vector(parent
->type
));
463 /* Most of NIR cannot handle array derefs on vectors */
464 validate_assert(state
, glsl_type_is_array(parent
->type
) ||
465 glsl_type_is_matrix(parent
->type
));
467 validate_assert(state
,
468 instr
->type
== glsl_get_array_element(parent
->type
));
470 if (instr
->deref_type
== nir_deref_type_array
) {
471 validate_src(&instr
->arr
.index
, state
,
472 nir_dest_bit_size(instr
->dest
), 1);
476 case nir_deref_type_ptr_as_array
:
477 /* ptr_as_array derefs must have a parent that is either an array,
478 * ptr_as_array, or cast. If the parent is a cast, we get the stride
479 * information (if any) from the cast deref.
481 validate_assert(state
,
482 parent
->deref_type
== nir_deref_type_array
||
483 parent
->deref_type
== nir_deref_type_ptr_as_array
||
484 parent
->deref_type
== nir_deref_type_cast
);
485 validate_src(&instr
->arr
.index
, state
,
486 nir_dest_bit_size(instr
->dest
), 1);
490 unreachable("Invalid deref instruction type");
494 /* We intentionally don't validate the size of the destination because we
495 * want to let other compiler components such as SPIR-V decide how big
496 * pointers should be.
498 validate_dest(&instr
->dest
, state
, 0, 0);
500 /* Deref instructions as if conditions don't make sense because if
501 * conditions expect well-formed Booleans. If you want to compare with
502 * NULL, an explicit comparison operation should be used.
504 validate_assert(state
, list_is_empty(&instr
->dest
.ssa
.if_uses
));
506 /* Only certain modes can be used as sources for phi instructions. */
507 nir_foreach_use(use
, &instr
->dest
.ssa
) {
508 if (use
->parent_instr
->type
== nir_instr_type_phi
) {
509 validate_assert(state
, instr
->mode
== nir_var_mem_ubo
||
510 instr
->mode
== nir_var_mem_ssbo
||
511 instr
->mode
== nir_var_mem_shared
||
512 instr
->mode
== nir_var_mem_global
);
518 validate_intrinsic_instr(nir_intrinsic_instr
*instr
, validate_state
*state
)
520 unsigned dest_bit_size
= 0;
521 unsigned src_bit_sizes
[NIR_INTRINSIC_MAX_INPUTS
] = { 0, };
522 switch (instr
->intrinsic
) {
523 case nir_intrinsic_load_param
: {
524 unsigned param_idx
= nir_intrinsic_param_idx(instr
);
525 validate_assert(state
, param_idx
< state
->impl
->function
->num_params
);
526 nir_parameter
*param
= &state
->impl
->function
->params
[param_idx
];
527 validate_assert(state
, instr
->num_components
== param
->num_components
);
528 dest_bit_size
= param
->bit_size
;
532 case nir_intrinsic_load_deref
: {
533 nir_deref_instr
*src
= nir_src_as_deref(instr
->src
[0]);
535 validate_assert(state
, glsl_type_is_vector_or_scalar(src
->type
) ||
536 (src
->mode
== nir_var_uniform
&&
537 glsl_get_base_type(src
->type
) == GLSL_TYPE_SUBROUTINE
));
538 validate_assert(state
, instr
->num_components
==
539 glsl_get_vector_elements(src
->type
));
540 dest_bit_size
= glsl_get_bit_size(src
->type
);
541 /* Also allow 32-bit boolean load operations */
542 if (glsl_type_is_boolean(src
->type
))
547 case nir_intrinsic_store_deref
: {
548 nir_deref_instr
*dst
= nir_src_as_deref(instr
->src
[0]);
550 validate_assert(state
, glsl_type_is_vector_or_scalar(dst
->type
));
551 validate_assert(state
, instr
->num_components
==
552 glsl_get_vector_elements(dst
->type
));
553 src_bit_sizes
[1] = glsl_get_bit_size(dst
->type
);
554 /* Also allow 32-bit boolean store operations */
555 if (glsl_type_is_boolean(dst
->type
))
556 src_bit_sizes
[1] |= 32;
557 validate_assert(state
, (dst
->mode
& (nir_var_shader_in
|
558 nir_var_uniform
)) == 0);
559 validate_assert(state
, (nir_intrinsic_write_mask(instr
) & ~((1 << instr
->num_components
) - 1)) == 0);
563 case nir_intrinsic_copy_deref
: {
564 nir_deref_instr
*dst
= nir_src_as_deref(instr
->src
[0]);
565 nir_deref_instr
*src
= nir_src_as_deref(instr
->src
[1]);
566 validate_assert(state
, glsl_get_bare_type(dst
->type
) ==
567 glsl_get_bare_type(src
->type
));
568 validate_assert(state
, (dst
->mode
& (nir_var_shader_in
|
569 nir_var_uniform
)) == 0);
577 if (instr
->num_components
> 0)
578 validate_num_components(state
, instr
->num_components
);
580 const nir_intrinsic_info
*info
= &nir_intrinsic_infos
[instr
->intrinsic
];
581 unsigned num_srcs
= info
->num_srcs
;
582 for (unsigned i
= 0; i
< num_srcs
; i
++) {
583 unsigned components_read
= nir_intrinsic_src_components(instr
, i
);
585 validate_num_components(state
, components_read
);
587 validate_src(&instr
->src
[i
], state
, src_bit_sizes
[i
], components_read
);
590 if (nir_intrinsic_infos
[instr
->intrinsic
].has_dest
) {
591 unsigned components_written
= nir_intrinsic_dest_components(instr
);
592 unsigned bit_sizes
= nir_intrinsic_infos
[instr
->intrinsic
].dest_bit_sizes
;
594 validate_num_components(state
, components_written
);
595 if (dest_bit_size
&& bit_sizes
)
596 validate_assert(state
, dest_bit_size
& bit_sizes
);
598 dest_bit_size
= dest_bit_size
? dest_bit_size
: bit_sizes
;
600 validate_dest(&instr
->dest
, state
, dest_bit_size
, components_written
);
605 validate_tex_instr(nir_tex_instr
*instr
, validate_state
*state
)
607 bool src_type_seen
[nir_num_tex_src_types
];
608 for (unsigned i
= 0; i
< nir_num_tex_src_types
; i
++)
609 src_type_seen
[i
] = false;
611 for (unsigned i
= 0; i
< instr
->num_srcs
; i
++) {
612 validate_assert(state
, !src_type_seen
[instr
->src
[i
].src_type
]);
613 src_type_seen
[instr
->src
[i
].src_type
] = true;
614 validate_src(&instr
->src
[i
].src
, state
,
615 0, nir_tex_instr_src_size(instr
, i
));
617 switch (instr
->src
[i
].src_type
) {
618 case nir_tex_src_texture_deref
:
619 case nir_tex_src_sampler_deref
:
620 validate_assert(state
, instr
->src
[i
].src
.is_ssa
);
621 validate_assert(state
,
622 instr
->src
[i
].src
.ssa
->parent_instr
->type
== nir_instr_type_deref
);
629 if (nir_tex_instr_has_explicit_tg4_offsets(instr
)) {
630 validate_assert(state
, instr
->op
== nir_texop_tg4
);
631 validate_assert(state
, !src_type_seen
[nir_tex_src_offset
]);
634 validate_dest(&instr
->dest
, state
, 0, nir_tex_instr_dest_size(instr
));
638 validate_call_instr(nir_call_instr
*instr
, validate_state
*state
)
640 validate_assert(state
, instr
->num_params
== instr
->callee
->num_params
);
642 for (unsigned i
= 0; i
< instr
->num_params
; i
++) {
643 validate_src(&instr
->params
[i
], state
,
644 instr
->callee
->params
[i
].bit_size
,
645 instr
->callee
->params
[i
].num_components
);
650 validate_const_value(nir_const_value
*val
, unsigned bit_size
,
651 validate_state
*state
)
653 /* In order for block copies to work properly for things like instruction
654 * comparisons and [de]serialization, we require the unused bits of the
655 * nir_const_value to be zero.
657 nir_const_value cmp_val
;
658 memset(&cmp_val
, 0, sizeof(cmp_val
));
664 cmp_val
.u8
= val
->u8
;
667 cmp_val
.u16
= val
->u16
;
670 cmp_val
.u32
= val
->u32
;
673 cmp_val
.u64
= val
->u64
;
676 validate_assert(state
, !"Invalid load_const bit size");
678 validate_assert(state
, memcmp(val
, &cmp_val
, sizeof(cmp_val
)) == 0);
682 validate_load_const_instr(nir_load_const_instr
*instr
, validate_state
*state
)
684 validate_ssa_def(&instr
->def
, state
);
686 for (unsigned i
= 0; i
< instr
->def
.num_components
; i
++)
687 validate_const_value(&instr
->value
[i
], instr
->def
.bit_size
, state
);
691 validate_ssa_undef_instr(nir_ssa_undef_instr
*instr
, validate_state
*state
)
693 validate_ssa_def(&instr
->def
, state
);
697 validate_phi_instr(nir_phi_instr
*instr
, validate_state
*state
)
700 * don't validate the sources until we get to them from their predecessor
701 * basic blocks, to avoid validating an SSA use before its definition.
704 validate_dest(&instr
->dest
, state
, 0, 0);
706 exec_list_validate(&instr
->srcs
);
707 validate_assert(state
, exec_list_length(&instr
->srcs
) ==
708 state
->block
->predecessors
->entries
);
712 validate_instr(nir_instr
*instr
, validate_state
*state
)
714 validate_assert(state
, instr
->block
== state
->block
);
716 state
->instr
= instr
;
718 switch (instr
->type
) {
719 case nir_instr_type_alu
:
720 validate_alu_instr(nir_instr_as_alu(instr
), state
);
723 case nir_instr_type_deref
:
724 validate_deref_instr(nir_instr_as_deref(instr
), state
);
727 case nir_instr_type_call
:
728 validate_call_instr(nir_instr_as_call(instr
), state
);
731 case nir_instr_type_intrinsic
:
732 validate_intrinsic_instr(nir_instr_as_intrinsic(instr
), state
);
735 case nir_instr_type_tex
:
736 validate_tex_instr(nir_instr_as_tex(instr
), state
);
739 case nir_instr_type_load_const
:
740 validate_load_const_instr(nir_instr_as_load_const(instr
), state
);
743 case nir_instr_type_phi
:
744 validate_phi_instr(nir_instr_as_phi(instr
), state
);
747 case nir_instr_type_ssa_undef
:
748 validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr
), state
);
751 case nir_instr_type_jump
:
755 validate_assert(state
, !"Invalid ALU instruction type");
763 validate_phi_src(nir_phi_instr
*instr
, nir_block
*pred
, validate_state
*state
)
765 state
->instr
= &instr
->instr
;
767 validate_assert(state
, instr
->dest
.is_ssa
);
769 exec_list_validate(&instr
->srcs
);
770 nir_foreach_phi_src(src
, instr
) {
771 if (src
->pred
== pred
) {
772 validate_assert(state
, src
->src
.is_ssa
);
773 validate_src(&src
->src
, state
, instr
->dest
.ssa
.bit_size
,
774 instr
->dest
.ssa
.num_components
);
784 validate_phi_srcs(nir_block
*block
, nir_block
*succ
, validate_state
*state
)
786 nir_foreach_instr(instr
, succ
) {
787 if (instr
->type
!= nir_instr_type_phi
)
790 validate_phi_src(nir_instr_as_phi(instr
), block
, state
);
794 static void validate_cf_node(nir_cf_node
*node
, validate_state
*state
);
797 validate_block(nir_block
*block
, validate_state
*state
)
799 validate_assert(state
, block
->cf_node
.parent
== state
->parent_node
);
801 state
->block
= block
;
803 exec_list_validate(&block
->instr_list
);
804 nir_foreach_instr(instr
, block
) {
805 if (instr
->type
== nir_instr_type_phi
) {
806 validate_assert(state
, instr
== nir_block_first_instr(block
) ||
807 nir_instr_prev(instr
)->type
== nir_instr_type_phi
);
810 if (instr
->type
== nir_instr_type_jump
) {
811 validate_assert(state
, instr
== nir_block_last_instr(block
));
814 validate_instr(instr
, state
);
817 validate_assert(state
, block
->successors
[0] != NULL
);
818 validate_assert(state
, block
->successors
[0] != block
->successors
[1]);
820 for (unsigned i
= 0; i
< 2; i
++) {
821 if (block
->successors
[i
] != NULL
) {
822 struct set_entry
*entry
=
823 _mesa_set_search(block
->successors
[i
]->predecessors
, block
);
824 validate_assert(state
, entry
);
826 validate_phi_srcs(block
, block
->successors
[i
], state
);
830 set_foreach(block
->predecessors
, entry
) {
831 const nir_block
*pred
= entry
->key
;
832 validate_assert(state
, pred
->successors
[0] == block
||
833 pred
->successors
[1] == block
);
836 if (!exec_list_is_empty(&block
->instr_list
) &&
837 nir_block_last_instr(block
)->type
== nir_instr_type_jump
) {
838 validate_assert(state
, block
->successors
[1] == NULL
);
839 nir_jump_instr
*jump
= nir_instr_as_jump(nir_block_last_instr(block
));
840 switch (jump
->type
) {
841 case nir_jump_break
: {
843 nir_cf_node_as_block(nir_cf_node_next(&state
->loop
->cf_node
));
844 validate_assert(state
, block
->successors
[0] == after
);
848 case nir_jump_continue
: {
849 nir_block
*first
= nir_loop_first_block(state
->loop
);
850 validate_assert(state
, block
->successors
[0] == first
);
854 case nir_jump_return
:
855 validate_assert(state
, block
->successors
[0] == state
->impl
->end_block
);
859 unreachable("bad jump type");
862 nir_cf_node
*next
= nir_cf_node_next(&block
->cf_node
);
864 switch (state
->parent_node
->type
) {
865 case nir_cf_node_loop
: {
866 nir_block
*first
= nir_loop_first_block(state
->loop
);
867 validate_assert(state
, block
->successors
[0] == first
);
868 /* due to the hack for infinite loops, block->successors[1] may
869 * point to the block after the loop.
874 case nir_cf_node_if
: {
876 nir_cf_node_as_block(nir_cf_node_next(state
->parent_node
));
877 validate_assert(state
, block
->successors
[0] == after
);
878 validate_assert(state
, block
->successors
[1] == NULL
);
882 case nir_cf_node_function
:
883 validate_assert(state
, block
->successors
[0] == state
->impl
->end_block
);
884 validate_assert(state
, block
->successors
[1] == NULL
);
888 unreachable("unknown control flow node type");
891 if (next
->type
== nir_cf_node_if
) {
892 nir_if
*if_stmt
= nir_cf_node_as_if(next
);
893 validate_assert(state
, block
->successors
[0] ==
894 nir_if_first_then_block(if_stmt
));
895 validate_assert(state
, block
->successors
[1] ==
896 nir_if_first_else_block(if_stmt
));
898 validate_assert(state
, next
->type
== nir_cf_node_loop
);
899 nir_loop
*loop
= nir_cf_node_as_loop(next
);
900 validate_assert(state
, block
->successors
[0] ==
901 nir_loop_first_block(loop
));
902 validate_assert(state
, block
->successors
[1] == NULL
);
909 validate_if(nir_if
*if_stmt
, validate_state
*state
)
911 state
->if_stmt
= if_stmt
;
913 validate_assert(state
, !exec_node_is_head_sentinel(if_stmt
->cf_node
.node
.prev
));
914 nir_cf_node
*prev_node
= nir_cf_node_prev(&if_stmt
->cf_node
);
915 validate_assert(state
, prev_node
->type
== nir_cf_node_block
);
917 validate_assert(state
, !exec_node_is_tail_sentinel(if_stmt
->cf_node
.node
.next
));
918 nir_cf_node
*next_node
= nir_cf_node_next(&if_stmt
->cf_node
);
919 validate_assert(state
, next_node
->type
== nir_cf_node_block
);
921 validate_src(&if_stmt
->condition
, state
, 0, 1);
923 validate_assert(state
, !exec_list_is_empty(&if_stmt
->then_list
));
924 validate_assert(state
, !exec_list_is_empty(&if_stmt
->else_list
));
926 nir_cf_node
*old_parent
= state
->parent_node
;
927 state
->parent_node
= &if_stmt
->cf_node
;
929 exec_list_validate(&if_stmt
->then_list
);
930 foreach_list_typed(nir_cf_node
, cf_node
, node
, &if_stmt
->then_list
) {
931 validate_cf_node(cf_node
, state
);
934 exec_list_validate(&if_stmt
->else_list
);
935 foreach_list_typed(nir_cf_node
, cf_node
, node
, &if_stmt
->else_list
) {
936 validate_cf_node(cf_node
, state
);
939 state
->parent_node
= old_parent
;
940 state
->if_stmt
= NULL
;
944 validate_loop(nir_loop
*loop
, validate_state
*state
)
946 validate_assert(state
, !exec_node_is_head_sentinel(loop
->cf_node
.node
.prev
));
947 nir_cf_node
*prev_node
= nir_cf_node_prev(&loop
->cf_node
);
948 validate_assert(state
, prev_node
->type
== nir_cf_node_block
);
950 validate_assert(state
, !exec_node_is_tail_sentinel(loop
->cf_node
.node
.next
));
951 nir_cf_node
*next_node
= nir_cf_node_next(&loop
->cf_node
);
952 validate_assert(state
, next_node
->type
== nir_cf_node_block
);
954 validate_assert(state
, !exec_list_is_empty(&loop
->body
));
956 nir_cf_node
*old_parent
= state
->parent_node
;
957 state
->parent_node
= &loop
->cf_node
;
958 nir_loop
*old_loop
= state
->loop
;
961 exec_list_validate(&loop
->body
);
962 foreach_list_typed(nir_cf_node
, cf_node
, node
, &loop
->body
) {
963 validate_cf_node(cf_node
, state
);
966 state
->parent_node
= old_parent
;
967 state
->loop
= old_loop
;
971 validate_cf_node(nir_cf_node
*node
, validate_state
*state
)
973 validate_assert(state
, node
->parent
== state
->parent_node
);
975 switch (node
->type
) {
976 case nir_cf_node_block
:
977 validate_block(nir_cf_node_as_block(node
), state
);
981 validate_if(nir_cf_node_as_if(node
), state
);
984 case nir_cf_node_loop
:
985 validate_loop(nir_cf_node_as_loop(node
), state
);
989 unreachable("Invalid CF node type");
994 prevalidate_reg_decl(nir_register
*reg
, validate_state
*state
)
996 validate_assert(state
, reg
->index
< state
->impl
->reg_alloc
);
997 validate_assert(state
, !BITSET_TEST(state
->regs_found
, reg
->index
));
998 validate_num_components(state
, reg
->num_components
);
999 BITSET_SET(state
->regs_found
, reg
->index
);
1001 list_validate(®
->uses
);
1002 list_validate(®
->defs
);
1003 list_validate(®
->if_uses
);
1005 reg_validate_state
*reg_state
= ralloc(state
->regs
, reg_validate_state
);
1006 reg_state
->uses
= _mesa_pointer_set_create(reg_state
);
1007 reg_state
->if_uses
= _mesa_pointer_set_create(reg_state
);
1008 reg_state
->defs
= _mesa_pointer_set_create(reg_state
);
1010 reg_state
->where_defined
= state
->impl
;
1012 _mesa_hash_table_insert(state
->regs
, reg
, reg_state
);
1016 postvalidate_reg_decl(nir_register
*reg
, validate_state
*state
)
1018 struct hash_entry
*entry
= _mesa_hash_table_search(state
->regs
, reg
);
1021 reg_validate_state
*reg_state
= (reg_validate_state
*) entry
->data
;
1023 nir_foreach_use(src
, reg
) {
1024 struct set_entry
*entry
= _mesa_set_search(reg_state
->uses
, src
);
1025 validate_assert(state
, entry
);
1026 _mesa_set_remove(reg_state
->uses
, entry
);
1029 if (reg_state
->uses
->entries
!= 0) {
1030 printf("extra entries in register uses:\n");
1031 set_foreach(reg_state
->uses
, entry
)
1032 printf("%p\n", entry
->key
);
1037 nir_foreach_if_use(src
, reg
) {
1038 struct set_entry
*entry
= _mesa_set_search(reg_state
->if_uses
, src
);
1039 validate_assert(state
, entry
);
1040 _mesa_set_remove(reg_state
->if_uses
, entry
);
1043 if (reg_state
->if_uses
->entries
!= 0) {
1044 printf("extra entries in register if_uses:\n");
1045 set_foreach(reg_state
->if_uses
, entry
)
1046 printf("%p\n", entry
->key
);
1051 nir_foreach_def(src
, reg
) {
1052 struct set_entry
*entry
= _mesa_set_search(reg_state
->defs
, src
);
1053 validate_assert(state
, entry
);
1054 _mesa_set_remove(reg_state
->defs
, entry
);
1057 if (reg_state
->defs
->entries
!= 0) {
1058 printf("extra entries in register defs:\n");
1059 set_foreach(reg_state
->defs
, entry
)
1060 printf("%p\n", entry
->key
);
1067 validate_var_decl(nir_variable
*var
, nir_variable_mode valid_modes
,
1068 validate_state
*state
)
1072 /* Must have exactly one mode set */
1073 validate_assert(state
, util_is_power_of_two_nonzero(var
->data
.mode
));
1074 validate_assert(state
, var
->data
.mode
& valid_modes
);
1076 if (var
->data
.compact
) {
1077 /* The "compact" flag is only valid on arrays of scalars. */
1078 assert(glsl_type_is_array(var
->type
));
1080 const struct glsl_type
*type
= glsl_get_array_element(var
->type
);
1081 if (nir_is_per_vertex_io(var
, state
->shader
->info
.stage
)) {
1082 assert(glsl_type_is_array(type
));
1083 assert(glsl_type_is_scalar(glsl_get_array_element(type
)));
1085 assert(glsl_type_is_scalar(type
));
1089 if (var
->num_members
> 0) {
1090 const struct glsl_type
*without_array
= glsl_without_array(var
->type
);
1091 validate_assert(state
, glsl_type_is_struct_or_ifc(without_array
));
1092 validate_assert(state
, var
->num_members
== glsl_get_length(without_array
));
1093 validate_assert(state
, var
->members
!= NULL
);
1097 * TODO validate some things ir_validate.cpp does (requires more GLSL type
1101 _mesa_hash_table_insert(state
->var_defs
, var
,
1102 valid_modes
== nir_var_function_temp
?
1103 state
->impl
: NULL
);
1109 validate_function_impl(nir_function_impl
*impl
, validate_state
*state
)
1111 /* Resize the ssa_srcs set. It's likely that the size of this set will
1112 * never actually hit the number of SSA defs because we remove sources from
1113 * the set as we visit them. (It could actually be much larger because
1114 * each SSA def can be used more than once.) However, growing it now costs
1115 * us very little (the extra memory is already dwarfed by the SSA defs
1116 * themselves) and makes collisions much less likely.
1118 _mesa_set_resize(state
->ssa_srcs
, impl
->ssa_alloc
);
1120 validate_assert(state
, impl
->function
->impl
== impl
);
1121 validate_assert(state
, impl
->cf_node
.parent
== NULL
);
1123 validate_assert(state
, exec_list_is_empty(&impl
->end_block
->instr_list
));
1124 validate_assert(state
, impl
->end_block
->successors
[0] == NULL
);
1125 validate_assert(state
, impl
->end_block
->successors
[1] == NULL
);
1128 state
->parent_node
= &impl
->cf_node
;
1130 exec_list_validate(&impl
->locals
);
1131 nir_foreach_variable(var
, &impl
->locals
) {
1132 validate_var_decl(var
, nir_var_function_temp
, state
);
1135 state
->regs_found
= reralloc(state
->mem_ctx
, state
->regs_found
,
1136 BITSET_WORD
, BITSET_WORDS(impl
->reg_alloc
));
1137 memset(state
->regs_found
, 0, BITSET_WORDS(impl
->reg_alloc
) *
1138 sizeof(BITSET_WORD
));
1139 exec_list_validate(&impl
->registers
);
1140 foreach_list_typed(nir_register
, reg
, node
, &impl
->registers
) {
1141 prevalidate_reg_decl(reg
, state
);
1144 state
->ssa_defs_found
= reralloc(state
->mem_ctx
, state
->ssa_defs_found
,
1145 BITSET_WORD
, BITSET_WORDS(impl
->ssa_alloc
));
1146 memset(state
->ssa_defs_found
, 0, BITSET_WORDS(impl
->ssa_alloc
) *
1147 sizeof(BITSET_WORD
));
1148 exec_list_validate(&impl
->body
);
1149 foreach_list_typed(nir_cf_node
, node
, node
, &impl
->body
) {
1150 validate_cf_node(node
, state
);
1153 foreach_list_typed(nir_register
, reg
, node
, &impl
->registers
) {
1154 postvalidate_reg_decl(reg
, state
);
1157 if (state
->ssa_srcs
->entries
!= 0) {
1158 printf("extra dangling SSA sources:\n");
1159 set_foreach(state
->ssa_srcs
, entry
)
1160 printf("%p\n", entry
->key
);
1167 validate_function(nir_function
*func
, validate_state
*state
)
1169 if (func
->impl
!= NULL
) {
1170 validate_assert(state
, func
->impl
->function
== func
);
1171 validate_function_impl(func
->impl
, state
);
1176 init_validate_state(validate_state
*state
)
1178 state
->mem_ctx
= ralloc_context(NULL
);
1179 state
->regs
= _mesa_pointer_hash_table_create(state
->mem_ctx
);
1180 state
->ssa_srcs
= _mesa_pointer_set_create(state
->mem_ctx
);
1181 state
->ssa_defs_found
= NULL
;
1182 state
->regs_found
= NULL
;
1183 state
->var_defs
= _mesa_pointer_hash_table_create(state
->mem_ctx
);
1184 state
->errors
= _mesa_pointer_hash_table_create(state
->mem_ctx
);
1187 state
->instr
= NULL
;
1192 destroy_validate_state(validate_state
*state
)
1194 ralloc_free(state
->mem_ctx
);
1197 mtx_t fail_dump_mutex
= _MTX_INITIALIZER_NP
;
1200 dump_errors(validate_state
*state
, const char *when
)
1202 struct hash_table
*errors
= state
->errors
;
1204 /* Lock around dumping so that we get clean dumps in a multi-threaded
1207 mtx_lock(&fail_dump_mutex
);
1210 fprintf(stderr
, "NIR validation failed %s\n", when
);
1211 fprintf(stderr
, "%d errors:\n", _mesa_hash_table_num_entries(errors
));
1213 fprintf(stderr
, "NIR validation failed with %d errors:\n",
1214 _mesa_hash_table_num_entries(errors
));
1217 nir_print_shader_annotated(state
->shader
, stderr
, errors
);
1219 if (_mesa_hash_table_num_entries(errors
) > 0) {
1220 fprintf(stderr
, "%d additional errors:\n",
1221 _mesa_hash_table_num_entries(errors
));
1222 hash_table_foreach(errors
, entry
) {
1223 fprintf(stderr
, "%s\n", (char *)entry
->data
);
1227 mtx_unlock(&fail_dump_mutex
);
1233 nir_validate_shader(nir_shader
*shader
, const char *when
)
1235 static int should_validate
= -1;
1236 if (should_validate
< 0)
1237 should_validate
= env_var_as_boolean("NIR_VALIDATE", true);
1238 if (!should_validate
)
1241 validate_state state
;
1242 init_validate_state(&state
);
1244 state
.shader
= shader
;
1246 exec_list_validate(&shader
->uniforms
);
1247 nir_foreach_variable(var
, &shader
->uniforms
) {
1248 validate_var_decl(var
, nir_var_uniform
|
1254 exec_list_validate(&shader
->inputs
);
1255 nir_foreach_variable(var
, &shader
->inputs
) {
1256 validate_var_decl(var
, nir_var_shader_in
, &state
);
1259 exec_list_validate(&shader
->outputs
);
1260 nir_foreach_variable(var
, &shader
->outputs
) {
1261 validate_var_decl(var
, nir_var_shader_out
, &state
);
1264 exec_list_validate(&shader
->shared
);
1265 nir_foreach_variable(var
, &shader
->shared
) {
1266 validate_var_decl(var
, nir_var_mem_shared
, &state
);
1269 exec_list_validate(&shader
->globals
);
1270 nir_foreach_variable(var
, &shader
->globals
) {
1271 validate_var_decl(var
, nir_var_shader_temp
, &state
);
1274 exec_list_validate(&shader
->system_values
);
1275 nir_foreach_variable(var
, &shader
->system_values
) {
1276 validate_var_decl(var
, nir_var_system_value
, &state
);
1279 exec_list_validate(&shader
->functions
);
1280 foreach_list_typed(nir_function
, func
, node
, &shader
->functions
) {
1281 validate_function(func
, &state
);
1284 if (_mesa_hash_table_num_entries(state
.errors
) > 0)
1285 dump_errors(&state
, when
);
1287 destroy_validate_state(&state
);