src/freedreno/vulkan/tu_image.c

   1 /*
   2  * Copyright © 2016 Red Hat.
   3  * Copyright © 2016 Bas Nieuwenhuizen
   4  *
   5  * based in part on anv driver which is:
   6  * Copyright © 2015 Intel Corporation
   7  *
   8  * Permission is hereby granted, free of charge, to any person obtaining a
   9  * copy of this software and associated documentation files (the "Software"),
  10  * to deal in the Software without restriction, including without limitation
  11  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  12  * and/or sell copies of the Software, and to permit persons to whom the
  13  * Software is furnished to do so, subject to the following conditions:
  14  *
  15  * The above copyright notice and this permission notice (including the next
  16  * paragraph) shall be included in all copies or substantial portions of the
  17  * Software.
  18  *
  19  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  20  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  21  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  22  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  23  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  24  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  25  * DEALINGS IN THE SOFTWARE.
  26  */
  27
  28 #include "tu_private.h"
  29
  30 #include "util/debug.h"
  31 #include "util/u_atomic.h"
  32 #include "util/format/u_format.h"
  33 #include "vk_format.h"
  34 #include "vk_util.h"
  35 #include "drm-uapi/drm_fourcc.h"
  36
  37 static inline bool
  38 image_level_linear(struct tu_image *image, int level, bool ubwc)
  39 {
  40    unsigned w = u_minify(image->extent.width, level);
  41    /* all levels are tiled/compressed with UBWC */
  42    return ubwc ? false : (w < 16);
  43 }
  44
  45 enum a6xx_tile_mode
  46 tu6_get_image_tile_mode(struct tu_image *image, int level)
  47 {
  48    if (image_level_linear(image, level, !!image->layout.ubwc_layer_size))
  49       return TILE6_LINEAR;
  50    else
  51       return image->layout.tile_mode;
  52 }
  53
  54 VkResult
  55 tu_image_create(VkDevice _device,
  56                 const VkImageCreateInfo *pCreateInfo,
  57                 const VkAllocationCallbacks *alloc,
  58                 VkImage *pImage,
  59                 uint64_t modifier)
  60 {
  61    TU_FROM_HANDLE(tu_device, device, _device);
  62    struct tu_image *image = NULL;
  63    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
  64
  65    tu_assert(pCreateInfo->mipLevels > 0);
  66    tu_assert(pCreateInfo->arrayLayers > 0);
  67    tu_assert(pCreateInfo->samples > 0);
  68    tu_assert(pCreateInfo->extent.width > 0);
  69    tu_assert(pCreateInfo->extent.height > 0);
  70    tu_assert(pCreateInfo->extent.depth > 0);
  71
  72    image = vk_zalloc2(&device->alloc, alloc, sizeof(*image), 8,
  73                       VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
  74    if (!image)
  75       return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
  76
  77    image->type = pCreateInfo->imageType;
  78
  79    image->vk_format = pCreateInfo->format;
  80    image->tiling = pCreateInfo->tiling;
  81    image->usage = pCreateInfo->usage;
  82    image->flags = pCreateInfo->flags;
  83    image->extent = pCreateInfo->extent;
  84    image->level_count = pCreateInfo->mipLevels;
  85    image->layer_count = pCreateInfo->arrayLayers;
  86    image->samples = pCreateInfo->samples;
  87
  88    image->exclusive = pCreateInfo->sharingMode == VK_SHARING_MODE_EXCLUSIVE;
  89    if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
  90       for (uint32_t i = 0; i < pCreateInfo->queueFamilyIndexCount; ++i)
  91          if (pCreateInfo->pQueueFamilyIndices[i] ==
  92              VK_QUEUE_FAMILY_EXTERNAL)
  93             image->queue_family_mask |= (1u << TU_MAX_QUEUE_FAMILIES) - 1u;
  94          else
  95             image->queue_family_mask |=
  96                1u << pCreateInfo->pQueueFamilyIndices[i];
  97    }
  98
  99    image->shareable =
 100       vk_find_struct_const(pCreateInfo->pNext,
 101                            EXTERNAL_MEMORY_IMAGE_CREATE_INFO) != NULL;
 102
 103    image->layout.tile_mode = TILE6_3;
 104    bool ubwc_enabled = true;
 105
 106    /* disable tiling when linear is requested and for compressed formats */
 107    if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR ||
 108        modifier == DRM_FORMAT_MOD_LINEAR ||
 109        vk_format_is_compressed(image->vk_format)) {
 110       image->layout.tile_mode = TILE6_LINEAR;
 111       ubwc_enabled = false;
 112    }
 113
 114    /* UBWC can't be used with E5B9G9R9 */
 115    if (image->vk_format == VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)
 116       ubwc_enabled = false;
 117
 118    if (image->extent.depth > 1) {
 119       tu_finishme("UBWC with 3D textures");
 120       ubwc_enabled = false;
 121    }
 122
 123    /* Disable UBWC for storage images.
 124     *
 125     * The closed GL driver skips UBWC for storage images (and additionally
 126     * uses linear for writeonly images).  We seem to have image tiling working
 127     * in freedreno in general, so turnip matches that.  freedreno also enables
 128     * UBWC on images, but it's not really tested due to the lack of
 129     * UBWC-enabled mipmaps in freedreno currently.  Just match the closed GL
 130     * behavior of no UBWC.
 131    */
 132    if (image->usage & VK_IMAGE_USAGE_STORAGE_BIT)
 133       ubwc_enabled = false;
 134
 135    uint32_t ubwc_blockwidth, ubwc_blockheight;
 136    fdl6_get_ubwc_blockwidth(&image->layout,
 137                             &ubwc_blockwidth, &ubwc_blockheight);
 138    if (!ubwc_blockwidth) {
 139       tu_finishme("UBWC for cpp=%d", image->layout.cpp);
 140       ubwc_enabled = false;
 141    }
 142
 143    /* expect UBWC enabled if we asked for it */
 144    assert(modifier != DRM_FORMAT_MOD_QCOM_COMPRESSED || ubwc_enabled);
 145
 146    image->layout.ubwc = ubwc_enabled;
 147
 148    fdl6_layout(&image->layout, vk_format_to_pipe_format(image->vk_format),
 149                image->samples,
 150                pCreateInfo->extent.width,
 151                pCreateInfo->extent.height,
 152                pCreateInfo->extent.depth,
 153                pCreateInfo->mipLevels,
 154                pCreateInfo->arrayLayers,
 155                pCreateInfo->imageType == VK_IMAGE_TYPE_3D);
 156
 157    *pImage = tu_image_to_handle(image);
 158
 159    return VK_SUCCESS;
 160 }
 161
 162 enum a6xx_tex_fetchsize
 163 tu6_fetchsize(VkFormat format)
 164 {
 165    if (vk_format_description(format)->layout == UTIL_FORMAT_LAYOUT_ASTC)
 166       return TFETCH6_16_BYTE;
 167
 168    switch (vk_format_get_blocksize(format) / vk_format_get_blockwidth(format)) {
 169    case 1: return TFETCH6_1_BYTE;
 170    case 2: return TFETCH6_2_BYTE;
 171    case 4: return TFETCH6_4_BYTE;
 172    case 8: return TFETCH6_8_BYTE;
 173    case 16: return TFETCH6_16_BYTE;
 174    default:
 175       unreachable("bad block size");
 176    }
 177 }
 178
 179 static uint32_t
 180 tu6_texswiz(const VkComponentMapping *comps,
 181             VkFormat format,
 182             VkImageAspectFlagBits aspect_mask)
 183 {
 184    unsigned char swiz[4] = {comps->r, comps->g, comps->b, comps->a};
 185    unsigned char vk_swizzle[] = {
 186       [VK_COMPONENT_SWIZZLE_ZERO] = A6XX_TEX_ZERO,
 187       [VK_COMPONENT_SWIZZLE_ONE]  = A6XX_TEX_ONE,
 188       [VK_COMPONENT_SWIZZLE_R] = A6XX_TEX_X,
 189       [VK_COMPONENT_SWIZZLE_G] = A6XX_TEX_Y,
 190       [VK_COMPONENT_SWIZZLE_B] = A6XX_TEX_Z,
 191       [VK_COMPONENT_SWIZZLE_A] = A6XX_TEX_W,
 192    };
 193    const unsigned char *fmt_swiz = vk_format_description(format)->swizzle;
 194
 195    for (unsigned i = 0; i < 4; i++) {
 196       swiz[i] = (swiz[i] == VK_COMPONENT_SWIZZLE_IDENTITY) ? i : vk_swizzle[swiz[i]];
 197       /* if format has 0/1 in channel, use that (needed for bc1_rgb) */
 198       if (swiz[i] < 4) {
 199          if (aspect_mask == VK_IMAGE_ASPECT_STENCIL_BIT &&
 200              format == VK_FORMAT_D24_UNORM_S8_UINT)
 201             swiz[i] = A6XX_TEX_Y;
 202          switch (fmt_swiz[swiz[i]]) {
 203          case PIPE_SWIZZLE_0: swiz[i] = A6XX_TEX_ZERO; break;
 204          case PIPE_SWIZZLE_1: swiz[i] = A6XX_TEX_ONE;  break;
 205          }
 206       }
 207    }
 208
 209    return A6XX_TEX_CONST_0_SWIZ_X(swiz[0]) |
 210           A6XX_TEX_CONST_0_SWIZ_Y(swiz[1]) |
 211           A6XX_TEX_CONST_0_SWIZ_Z(swiz[2]) |
 212           A6XX_TEX_CONST_0_SWIZ_W(swiz[3]);
 213 }
 214
 215 static enum a6xx_tex_type
 216 tu6_tex_type(VkImageViewType type)
 217 {
 218    switch (type) {
 219    default:
 220    case VK_IMAGE_VIEW_TYPE_1D:
 221    case VK_IMAGE_VIEW_TYPE_1D_ARRAY:
 222       return A6XX_TEX_1D;
 223    case VK_IMAGE_VIEW_TYPE_2D:
 224    case VK_IMAGE_VIEW_TYPE_2D_ARRAY:
 225       return A6XX_TEX_2D;
 226    case VK_IMAGE_VIEW_TYPE_3D:
 227       return A6XX_TEX_3D;
 228    case VK_IMAGE_VIEW_TYPE_CUBE:
 229    case VK_IMAGE_VIEW_TYPE_CUBE_ARRAY:
 230       return A6XX_TEX_CUBE;
 231    }
 232 }
 233
 234 void
 235 tu_image_view_init(struct tu_image_view *iview,
 236                    struct tu_device *device,
 237                    const VkImageViewCreateInfo *pCreateInfo)
 238 {
 239    TU_FROM_HANDLE(tu_image, image, pCreateInfo->image);
 240    const VkImageSubresourceRange *range = &pCreateInfo->subresourceRange;
 241
 242    switch (image->type) {
 243    case VK_IMAGE_TYPE_1D:
 244    case VK_IMAGE_TYPE_2D:
 245       assert(range->baseArrayLayer + tu_get_layerCount(image, range) <=
 246              image->layer_count);
 247       break;
 248    case VK_IMAGE_TYPE_3D:
 249       assert(range->baseArrayLayer + tu_get_layerCount(image, range) <=
 250              tu_minify(image->extent.depth, range->baseMipLevel));
 251       break;
 252    default:
 253       unreachable("bad VkImageType");
 254    }
 255
 256    iview->image = image;
 257    iview->type = pCreateInfo->viewType;
 258    iview->vk_format = pCreateInfo->format;
 259    iview->aspect_mask = pCreateInfo->subresourceRange.aspectMask;
 260
 261    iview->base_layer = range->baseArrayLayer;
 262    iview->layer_count = tu_get_layerCount(image, range);
 263    iview->base_mip = range->baseMipLevel;
 264    iview->level_count = tu_get_levelCount(image, range);
 265
 266    iview->extent.width = u_minify(image->extent.width, iview->base_mip);
 267    iview->extent.height = u_minify(image->extent.height, iview->base_mip);
 268    iview->extent.depth = u_minify(image->extent.depth, iview->base_mip);
 269
 270    memset(iview->descriptor, 0, sizeof(iview->descriptor));
 271
 272    struct tu_native_format fmt =
 273       tu6_format_image_src(image, iview->vk_format, iview->base_mip);
 274    uint64_t base_addr = tu_image_base(image, iview->base_mip, iview->base_layer);
 275    uint64_t ubwc_addr = tu_image_ubwc_base(image, iview->base_mip, iview->base_layer);
 276
 277    uint32_t pitch = tu_image_pitch(image, iview->base_mip);
 278    uint32_t width = iview->extent.width;
 279    uint32_t height = iview->extent.height;
 280    uint32_t depth = pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D ?
 281       iview->extent.depth : iview->layer_count;
 282
 283    unsigned fmt_tex = fmt.fmt;
 284    if (fmt_tex == FMT6_Z24_UNORM_S8_UINT_AS_R8G8B8A8) {
 285       if (iview->aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT)
 286          fmt_tex = FMT6_Z24_UNORM_S8_UINT;
 287       if (iview->aspect_mask == VK_IMAGE_ASPECT_STENCIL_BIT)
 288          fmt_tex = FMT6_S8Z24_UINT;
 289       /* TODO: also use this format with storage descriptor ? */
 290    }
 291
 292    iview->descriptor[0] =
 293       A6XX_TEX_CONST_0_TILE_MODE(fmt.tile_mode) |
 294       COND(vk_format_is_srgb(iview->vk_format), A6XX_TEX_CONST_0_SRGB) |
 295       A6XX_TEX_CONST_0_FMT(fmt_tex) |
 296       A6XX_TEX_CONST_0_SAMPLES(tu_msaa_samples(image->samples)) |
 297       A6XX_TEX_CONST_0_SWAP(fmt.swap) |
 298       tu6_texswiz(&pCreateInfo->components, iview->vk_format, iview->aspect_mask) |
 299       A6XX_TEX_CONST_0_MIPLVLS(iview->level_count - 1);
 300    iview->descriptor[1] = A6XX_TEX_CONST_1_WIDTH(width) | A6XX_TEX_CONST_1_HEIGHT(height);
 301    iview->descriptor[2] =
 302       A6XX_TEX_CONST_2_FETCHSIZE(tu6_fetchsize(iview->vk_format)) |
 303       A6XX_TEX_CONST_2_PITCH(pitch) |
 304       A6XX_TEX_CONST_2_TYPE(tu6_tex_type(pCreateInfo->viewType));
 305    iview->descriptor[3] = A6XX_TEX_CONST_3_ARRAY_PITCH(tu_layer_size(image, iview->base_mip));
 306    iview->descriptor[4] = base_addr;
 307    iview->descriptor[5] = (base_addr >> 32) | A6XX_TEX_CONST_5_DEPTH(depth);
 308
 309    if (image->layout.ubwc_layer_size) {
 310       uint32_t block_width, block_height;
 311       fdl6_get_ubwc_blockwidth(&image->layout,
 312                                &block_width, &block_height);
 313
 314       iview->descriptor[3] |= A6XX_TEX_CONST_3_FLAG | A6XX_TEX_CONST_3_TILE_ALL;
 315       iview->descriptor[7] = ubwc_addr;
 316       iview->descriptor[8] = ubwc_addr >> 32;
 317       iview->descriptor[9] |= A6XX_TEX_CONST_9_FLAG_BUFFER_ARRAY_PITCH(tu_image_ubwc_size(image, iview->base_mip) >> 2);
 318       iview->descriptor[10] |=
 319          A6XX_TEX_CONST_10_FLAG_BUFFER_PITCH(tu_image_ubwc_pitch(image, iview->base_mip)) |
 320          A6XX_TEX_CONST_10_FLAG_BUFFER_LOGW(util_logbase2_ceil(DIV_ROUND_UP(width, block_width))) |
 321          A6XX_TEX_CONST_10_FLAG_BUFFER_LOGH(util_logbase2_ceil(DIV_ROUND_UP(height, block_height)));
 322    }
 323
 324    if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D) {
 325       iview->descriptor[3] |=
 326          A6XX_TEX_CONST_3_MIN_LAYERSZ(image->layout.slices[image->level_count - 1].size0);
 327    }
 328
 329    if (image->usage & VK_IMAGE_USAGE_STORAGE_BIT) {
 330       memset(iview->storage_descriptor, 0, sizeof(iview->storage_descriptor));
 331
 332       iview->storage_descriptor[0] =
 333          A6XX_IBO_0_FMT(fmt.fmt) |
 334          A6XX_IBO_0_TILE_MODE(fmt.tile_mode);
 335       iview->storage_descriptor[1] =
 336          A6XX_IBO_1_WIDTH(width) |
 337          A6XX_IBO_1_HEIGHT(height);
 338       iview->storage_descriptor[2] =
 339          A6XX_IBO_2_PITCH(pitch) |
 340          A6XX_IBO_2_TYPE(tu6_tex_type(pCreateInfo->viewType));
 341       iview->storage_descriptor[3] = A6XX_IBO_3_ARRAY_PITCH(tu_layer_size(image, iview->base_mip));
 342
 343       iview->storage_descriptor[4] = base_addr;
 344       iview->storage_descriptor[5] = (base_addr >> 32) | A6XX_IBO_5_DEPTH(depth);
 345
 346       if (image->layout.ubwc_layer_size) {
 347          iview->storage_descriptor[3] |= A6XX_IBO_3_FLAG | A6XX_IBO_3_UNK27;
 348          iview->storage_descriptor[7] |= ubwc_addr;
 349          iview->storage_descriptor[8] |= ubwc_addr >> 32;
 350          iview->storage_descriptor[9] = A6XX_IBO_9_FLAG_BUFFER_ARRAY_PITCH(tu_image_ubwc_size(image, iview->base_mip) >> 2);
 351          iview->storage_descriptor[10] =
 352             A6XX_IBO_10_FLAG_BUFFER_PITCH(tu_image_ubwc_pitch(image, iview->base_mip));
 353       }
 354    }
 355 }
 356
 357 unsigned
 358 tu_image_queue_family_mask(const struct tu_image *image,
 359                            uint32_t family,
 360                            uint32_t queue_family)
 361 {
 362    if (!image->exclusive)
 363       return image->queue_family_mask;
 364    if (family == VK_QUEUE_FAMILY_EXTERNAL)
 365       return (1u << TU_MAX_QUEUE_FAMILIES) - 1u;
 366    if (family == VK_QUEUE_FAMILY_IGNORED)
 367       return 1u << queue_family;
 368    return 1u << family;
 369 }
 370
 371 VkResult
 372 tu_CreateImage(VkDevice device,
 373                const VkImageCreateInfo *pCreateInfo,
 374                const VkAllocationCallbacks *pAllocator,
 375                VkImage *pImage)
 376 {
 377 #ifdef ANDROID
 378    const VkNativeBufferANDROID *gralloc_info =
 379       vk_find_struct_const(pCreateInfo->pNext, NATIVE_BUFFER_ANDROID);
 380
 381    if (gralloc_info)
 382       return tu_image_from_gralloc(device, pCreateInfo, gralloc_info,
 383                                    pAllocator, pImage);
 384 #endif
 385
 386    uint64_t modifier = DRM_FORMAT_MOD_INVALID;
 387    if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
 388       const VkImageDrmFormatModifierListCreateInfoEXT *mod_info =
 389          vk_find_struct_const(pCreateInfo->pNext,
 390                               IMAGE_DRM_FORMAT_MODIFIER_LIST_CREATE_INFO_EXT);
 391
 392       modifier = DRM_FORMAT_MOD_LINEAR;
 393       for (unsigned i = 0; i < mod_info->drmFormatModifierCount; i++) {
 394          if (mod_info->pDrmFormatModifiers[i] == DRM_FORMAT_MOD_QCOM_COMPRESSED)
 395             modifier = DRM_FORMAT_MOD_QCOM_COMPRESSED;
 396       }
 397    } else {
 398       const struct wsi_image_create_info *wsi_info =
 399          vk_find_struct_const(pCreateInfo->pNext, WSI_IMAGE_CREATE_INFO_MESA);
 400       if (wsi_info && wsi_info->scanout)
 401          modifier = DRM_FORMAT_MOD_LINEAR;
 402    }
 403
 404    return tu_image_create(device, pCreateInfo, pAllocator, pImage, modifier);
 405 }
 406
 407 void
 408 tu_DestroyImage(VkDevice _device,
 409                 VkImage _image,
 410                 const VkAllocationCallbacks *pAllocator)
 411 {
 412    TU_FROM_HANDLE(tu_device, device, _device);
 413    TU_FROM_HANDLE(tu_image, image, _image);
 414
 415    if (!image)
 416       return;
 417
 418    if (image->owned_memory != VK_NULL_HANDLE)
 419       tu_FreeMemory(_device, image->owned_memory, pAllocator);
 420
 421    vk_free2(&device->alloc, pAllocator, image);
 422 }
 423
 424 void
 425 tu_GetImageSubresourceLayout(VkDevice _device,
 426                              VkImage _image,
 427                              const VkImageSubresource *pSubresource,
 428                              VkSubresourceLayout *pLayout)
 429 {
 430    TU_FROM_HANDLE(tu_image, image, _image);
 431
 432    const struct fdl_slice *slice = image->layout.slices + pSubresource->mipLevel;
 433
 434    pLayout->offset = fdl_surface_offset(&image->layout,
 435                                         pSubresource->mipLevel,
 436                                         pSubresource->arrayLayer);
 437    pLayout->size = slice->size0;
 438    pLayout->rowPitch =
 439       slice->pitch * vk_format_get_blocksize(image->vk_format);
 440    pLayout->arrayPitch = image->layout.layer_size;
 441    pLayout->depthPitch = slice->size0;
 442
 443    if (image->layout.ubwc_layer_size) {
 444       /* UBWC starts at offset 0 */
 445       pLayout->offset = 0;
 446       /* UBWC scanout won't match what the kernel wants if we have levels/layers */
 447       assert(image->level_count == 1 && image->layer_count == 1);
 448    }
 449 }
 450
 451 VkResult tu_GetImageDrmFormatModifierPropertiesEXT(
 452     VkDevice                                    device,
 453     VkImage                                     _image,
 454     VkImageDrmFormatModifierPropertiesEXT*      pProperties)
 455 {
 456    TU_FROM_HANDLE(tu_image, image, _image);
 457
 458    assert(pProperties->sType ==
 459           VK_STRUCTURE_TYPE_IMAGE_DRM_FORMAT_MODIFIER_PROPERTIES_EXT);
 460
 461    /* TODO invent a modifier for tiled but not UBWC buffers */
 462
 463    if (!image->layout.tile_mode)
 464       pProperties->drmFormatModifier = DRM_FORMAT_MOD_LINEAR;
 465    else if (image->layout.ubwc_layer_size)
 466       pProperties->drmFormatModifier = DRM_FORMAT_MOD_QCOM_COMPRESSED;
 467    else
 468       pProperties->drmFormatModifier = DRM_FORMAT_MOD_INVALID;
 469
 470    return VK_SUCCESS;
 471 }
 472
 473
 474 VkResult
 475 tu_CreateImageView(VkDevice _device,
 476                    const VkImageViewCreateInfo *pCreateInfo,
 477                    const VkAllocationCallbacks *pAllocator,
 478                    VkImageView *pView)
 479 {
 480    TU_FROM_HANDLE(tu_device, device, _device);
 481    struct tu_image_view *view;
 482
 483    view = vk_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 484                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 485    if (view == NULL)
 486       return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 487
 488    tu_image_view_init(view, device, pCreateInfo);
 489
 490    *pView = tu_image_view_to_handle(view);
 491
 492    return VK_SUCCESS;
 493 }
 494
 495 void
 496 tu_DestroyImageView(VkDevice _device,
 497                     VkImageView _iview,
 498                     const VkAllocationCallbacks *pAllocator)
 499 {
 500    TU_FROM_HANDLE(tu_device, device, _device);
 501    TU_FROM_HANDLE(tu_image_view, iview, _iview);
 502
 503    if (!iview)
 504       return;
 505    vk_free2(&device->alloc, pAllocator, iview);
 506 }
 507
 508 void
 509 tu_buffer_view_init(struct tu_buffer_view *view,
 510                     struct tu_device *device,
 511                     const VkBufferViewCreateInfo *pCreateInfo)
 512 {
 513    TU_FROM_HANDLE(tu_buffer, buffer, pCreateInfo->buffer);
 514
 515    view->buffer = buffer;
 516
 517    enum VkFormat vfmt = pCreateInfo->format;
 518    enum pipe_format pfmt = vk_format_to_pipe_format(vfmt);
 519    const struct tu_native_format fmt = tu6_format_texture(vfmt, TILE6_LINEAR);
 520
 521    uint32_t range;
 522    if (pCreateInfo->range == VK_WHOLE_SIZE)
 523       range = buffer->size - pCreateInfo->offset;
 524    else
 525       range = pCreateInfo->range;
 526    uint32_t elements = range / util_format_get_blocksize(pfmt);
 527
 528    static const VkComponentMapping components = {
 529       .r = VK_COMPONENT_SWIZZLE_R,
 530       .g = VK_COMPONENT_SWIZZLE_G,
 531       .b = VK_COMPONENT_SWIZZLE_B,
 532       .a = VK_COMPONENT_SWIZZLE_A,
 533    };
 534
 535    uint64_t iova = tu_buffer_iova(buffer) + pCreateInfo->offset;
 536
 537    memset(&view->descriptor, 0, sizeof(view->descriptor));
 538
 539    view->descriptor[0] =
 540       A6XX_TEX_CONST_0_TILE_MODE(TILE6_LINEAR) |
 541       A6XX_TEX_CONST_0_SWAP(fmt.swap) |
 542       A6XX_TEX_CONST_0_FMT(fmt.fmt) |
 543       A6XX_TEX_CONST_0_MIPLVLS(0) |
 544       tu6_texswiz(&components, vfmt, VK_IMAGE_ASPECT_COLOR_BIT);
 545       COND(vk_format_is_srgb(vfmt), A6XX_TEX_CONST_0_SRGB);
 546    view->descriptor[1] =
 547       A6XX_TEX_CONST_1_WIDTH(elements & MASK(15)) |
 548       A6XX_TEX_CONST_1_HEIGHT(elements >> 15);
 549    view->descriptor[2] =
 550       A6XX_TEX_CONST_2_UNK4 |
 551       A6XX_TEX_CONST_2_UNK31;
 552    view->descriptor[4] = iova;
 553    view->descriptor[5] = iova >> 32;
 554 }
 555
 556 VkResult
 557 tu_CreateBufferView(VkDevice _device,
 558                     const VkBufferViewCreateInfo *pCreateInfo,
 559                     const VkAllocationCallbacks *pAllocator,
 560                     VkBufferView *pView)
 561 {
 562    TU_FROM_HANDLE(tu_device, device, _device);
 563    struct tu_buffer_view *view;
 564
 565    view = vk_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 566                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 567    if (!view)
 568       return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 569
 570    tu_buffer_view_init(view, device, pCreateInfo);
 571
 572    *pView = tu_buffer_view_to_handle(view);
 573
 574    return VK_SUCCESS;
 575 }
 576
 577 void
 578 tu_DestroyBufferView(VkDevice _device,
 579                      VkBufferView bufferView,
 580                      const VkAllocationCallbacks *pAllocator)
 581 {
 582    TU_FROM_HANDLE(tu_device, device, _device);
 583    TU_FROM_HANDLE(tu_buffer_view, view, bufferView);
 584
 585    if (!view)
 586       return;
 587
 588    vk_free2(&device->alloc, pAllocator, view);
 589 }