src/gallium/drivers/panfrost/pan_mfbd.c

   1 /*
   2  * Copyright 2018-2019 Alyssa Rosenzweig
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  20  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  21  * SOFTWARE.
  22  *
  23  */
  24
  25 #include "pan_bo.h"
  26 #include "pan_context.h"
  27 #include "pan_cmdstream.h"
  28 #include "pan_util.h"
  29 #include "panfrost-quirks.h"
  30
  31 static struct mali_rt_format
  32 panfrost_mfbd_format(struct pipe_surface *surf)
  33 {
  34         /* Explode details on the format */
  35
  36         const struct util_format_description *desc =
  37                 util_format_description(surf->format);
  38
  39         /* The swizzle for rendering is inverted from texturing */
  40
  41         unsigned char swizzle[4];
  42         panfrost_invert_swizzle(desc->swizzle, swizzle);
  43
  44         /* Fill in accordingly, defaulting to 8-bit UNORM */
  45
  46         struct mali_rt_format fmt = {
  47                 .unk1 = 0x4000000,
  48                 .unk2 = 0x1,
  49                 .nr_channels = MALI_POSITIVE(desc->nr_channels),
  50                 .unk3 = 0x4,
  51                 .flags = 0x8,
  52                 .swizzle = panfrost_translate_swizzle_4(swizzle),
  53                 .no_preload = true
  54         };
  55
  56         if (desc->colorspace == UTIL_FORMAT_COLORSPACE_SRGB)
  57                 fmt.flags |= MALI_MFBD_FORMAT_SRGB;
  58
  59         /* sRGB handled as a dedicated flag */
  60         enum pipe_format linearized = util_format_linear(surf->format);
  61
  62         /* If RGB, we're good to go */
  63         if (util_format_is_unorm8(desc))
  64                 return fmt;
  65
  66         /* Set flags for alternative formats */
  67
  68         switch (linearized) {
  69         case PIPE_FORMAT_B5G6R5_UNORM:
  70                 fmt.unk1 = 0x14000000;
  71                 fmt.nr_channels = MALI_POSITIVE(2);
  72                 fmt.unk3 |= 0x1;
  73                 break;
  74
  75         case PIPE_FORMAT_A4B4G4R4_UNORM:
  76         case PIPE_FORMAT_B4G4R4A4_UNORM:
  77                 fmt.unk1 = 0x10000000;
  78                 fmt.unk3 = 0x5;
  79                 fmt.nr_channels = MALI_POSITIVE(1);
  80                 break;
  81
  82         case PIPE_FORMAT_R10G10B10A2_UNORM:
  83         case PIPE_FORMAT_B10G10R10A2_UNORM:
  84         case PIPE_FORMAT_R10G10B10X2_UNORM:
  85         case PIPE_FORMAT_B10G10R10X2_UNORM:
  86                 fmt.unk1 = 0x08000000;
  87                 fmt.unk3 = 0x6;
  88                 fmt.nr_channels = MALI_POSITIVE(1);
  89                 break;
  90
  91         case PIPE_FORMAT_B5G5R5A1_UNORM:
  92         case PIPE_FORMAT_B5G5R5X1_UNORM:
  93                 fmt.unk1 = 0x18000000;
  94                 fmt.unk3 = 0x7;
  95                 fmt.nr_channels = MALI_POSITIVE(2);
  96                 break;
  97
  98         /* Generic 8-bit */
  99         case PIPE_FORMAT_R8_UINT:
 100         case PIPE_FORMAT_R8_SINT:
 101                 fmt.unk1 = 0x80000000;
 102                 fmt.unk3 = 0x0;
 103                 fmt.nr_channels = MALI_POSITIVE(1);
 104                 break;
 105
 106         /* Generic 32-bit */
 107         case PIPE_FORMAT_R11G11B10_FLOAT:
 108         case PIPE_FORMAT_R8G8B8A8_UINT:
 109         case PIPE_FORMAT_R8G8B8A8_SINT:
 110         case PIPE_FORMAT_R16G16_FLOAT:
 111         case PIPE_FORMAT_R16G16_UINT:
 112         case PIPE_FORMAT_R16G16_SINT:
 113         case PIPE_FORMAT_R32_FLOAT:
 114         case PIPE_FORMAT_R32_UINT:
 115         case PIPE_FORMAT_R32_SINT:
 116         case PIPE_FORMAT_R10G10B10A2_UINT:
 117                 fmt.unk1 = 0x88000000;
 118                 fmt.unk3 = 0x0;
 119                 fmt.nr_channels = MALI_POSITIVE(4);
 120                 break;
 121
 122         /* Generic 16-bit */
 123         case PIPE_FORMAT_R8G8_UINT:
 124         case PIPE_FORMAT_R8G8_SINT:
 125         case PIPE_FORMAT_R16_FLOAT:
 126         case PIPE_FORMAT_R16_UINT:
 127         case PIPE_FORMAT_R16_SINT:
 128                 fmt.unk1 = 0x84000000;
 129                 fmt.unk3 = 0x0;
 130                 fmt.nr_channels = MALI_POSITIVE(2);
 131                 break;
 132
 133         /* Generic 64-bit */
 134         case PIPE_FORMAT_R32G32_FLOAT:
 135         case PIPE_FORMAT_R32G32_SINT:
 136         case PIPE_FORMAT_R32G32_UINT:
 137         case PIPE_FORMAT_R16G16B16A16_FLOAT:
 138         case PIPE_FORMAT_R16G16B16A16_SINT:
 139         case PIPE_FORMAT_R16G16B16A16_UINT:
 140                 fmt.unk1 = 0x8c000000;
 141                 fmt.unk3 = 0x1;
 142                 fmt.nr_channels = MALI_POSITIVE(2);
 143                 break;
 144
 145         /* Generic 128-bit */
 146         case PIPE_FORMAT_R32G32B32A32_FLOAT:
 147         case PIPE_FORMAT_R32G32B32A32_SINT:
 148         case PIPE_FORMAT_R32G32B32A32_UINT:
 149                 fmt.unk1 = 0x90000000;
 150                 fmt.unk3 = 0x1;
 151                 fmt.nr_channels = MALI_POSITIVE(4);
 152                 break;
 153
 154         default:
 155                 unreachable("Invalid format rendering");
 156         }
 157
 158         return fmt;
 159 }
 160
 161
 162 static void
 163 panfrost_mfbd_clear(
 164         struct panfrost_batch *batch,
 165         struct mali_framebuffer *fb,
 166         struct mali_framebuffer_extra *fbx,
 167         struct mali_render_target *rts,
 168         unsigned rt_count)
 169 {
 170         struct panfrost_context *ctx = batch->ctx;
 171         struct pipe_context *gallium = (struct pipe_context *) ctx;
 172         struct panfrost_device *dev = pan_device(gallium->screen);
 173
 174         for (unsigned i = 0; i < rt_count; ++i) {
 175                 if (!(batch->clear & (PIPE_CLEAR_COLOR0 << i)))
 176                         continue;
 177
 178                 rts[i].clear_color_1 = batch->clear_color[i][0];
 179                 rts[i].clear_color_2 = batch->clear_color[i][1];
 180                 rts[i].clear_color_3 = batch->clear_color[i][2];
 181                 rts[i].clear_color_4 = batch->clear_color[i][3];
 182         }
 183
 184         if (batch->clear & PIPE_CLEAR_DEPTH) {
 185                 fb->clear_depth = batch->clear_depth;
 186         }
 187
 188         if (batch->clear & PIPE_CLEAR_STENCIL) {
 189                 fb->clear_stencil = batch->clear_stencil;
 190         }
 191
 192         if (dev->quirks & IS_BIFROST) {
 193                 fbx->clear_color_1 = batch->clear_color[0][0];
 194                 fbx->clear_color_2 = 0xc0000000 | (fbx->clear_color_1 & 0xffff); /* WTF? */
 195         }
 196 }
 197
 198 static void
 199 panfrost_mfbd_set_cbuf(
 200         struct mali_render_target *rt,
 201         struct pipe_surface *surf)
 202 {
 203         struct panfrost_resource *rsrc = pan_resource(surf->texture);
 204         struct panfrost_device *dev = pan_device(surf->context->screen);
 205         bool is_bifrost = dev->quirks & IS_BIFROST;
 206
 207         unsigned level = surf->u.tex.level;
 208         unsigned first_layer = surf->u.tex.first_layer;
 209         assert(surf->u.tex.last_layer == first_layer);
 210         int stride = rsrc->slices[level].stride;
 211
 212         mali_ptr base = panfrost_get_texture_address(rsrc, level, first_layer);
 213
 214         rt->format = panfrost_mfbd_format(surf);
 215
 216         /* Now, we set the layout specific pieces */
 217
 218         if (rsrc->layout == MALI_TEXTURE_LINEAR) {
 219                 if (is_bifrost) {
 220                         rt->format.unk4 = 0x1;
 221                 } else {
 222                         rt->format.block = MALI_BLOCK_LINEAR;
 223                 }
 224
 225                 rt->framebuffer = base;
 226                 rt->framebuffer_stride = stride / 16;
 227         } else if (rsrc->layout == MALI_TEXTURE_TILED) {
 228                 if (is_bifrost) {
 229                         rt->format.unk3 |= 0x8;
 230                 } else {
 231                         rt->format.block = MALI_BLOCK_TILED;
 232                 }
 233
 234                 rt->framebuffer = base;
 235                 rt->framebuffer_stride = stride;
 236         } else if (rsrc->layout == MALI_TEXTURE_AFBC) {
 237                 rt->format.block = MALI_BLOCK_AFBC;
 238
 239                 unsigned header_size = rsrc->slices[level].header_size;
 240
 241                 rt->framebuffer = base + header_size;
 242                 rt->afbc.metadata = base;
 243                 rt->afbc.stride = 0;
 244                 rt->afbc.flags = MALI_AFBC_FLAGS | MALI_AFBC_YTR;
 245
 246                 /* TODO: The blob sets this to something nonzero, but it's not
 247                  * clear what/how to calculate/if it matters */
 248                 rt->framebuffer_stride = 0;
 249         } else {
 250                 fprintf(stderr, "Invalid render layout (cbuf)");
 251                 assert(0);
 252         }
 253 }
 254
 255 static void
 256 panfrost_mfbd_set_zsbuf(
 257         struct mali_framebuffer *fb,
 258         struct mali_framebuffer_extra *fbx,
 259         struct pipe_surface *surf)
 260 {
 261         struct panfrost_device *dev = pan_device(surf->context->screen);
 262         bool is_bifrost = dev->quirks & IS_BIFROST;
 263         struct panfrost_resource *rsrc = pan_resource(surf->texture);
 264
 265         unsigned level = surf->u.tex.level;
 266         unsigned first_layer = surf->u.tex.first_layer;
 267         assert(surf->u.tex.last_layer == first_layer);
 268
 269         mali_ptr base = panfrost_get_texture_address(rsrc, level, first_layer);
 270
 271         if (rsrc->layout == MALI_TEXTURE_AFBC) {
 272                 /* The only Z/S format we can compress is Z24S8 or variants
 273                  * thereof (handled by the gallium frontend) */
 274                 assert(panfrost_is_z24s8_variant(surf->format));
 275
 276                 unsigned header_size = rsrc->slices[level].header_size;
 277
 278                 fb->mfbd_flags |= MALI_MFBD_EXTRA;
 279
 280                 fbx->flags_hi |= MALI_EXTRA_PRESENT;
 281                 fbx->flags_lo |= MALI_EXTRA_ZS | 0x1; /* unknown */
 282                 fbx->zs_block = MALI_BLOCK_AFBC;
 283
 284                 fbx->ds_afbc.depth_stencil = base + header_size;
 285                 fbx->ds_afbc.depth_stencil_afbc_metadata = base;
 286                 fbx->ds_afbc.depth_stencil_afbc_stride = 0;
 287
 288                 fbx->ds_afbc.flags = MALI_AFBC_FLAGS;
 289                 fbx->ds_afbc.padding = 0x1000;
 290         } else if (rsrc->layout == MALI_TEXTURE_LINEAR || rsrc->layout == MALI_TEXTURE_TILED) {
 291                 /* TODO: Z32F(S8) support, which is always linear */
 292
 293                 int stride = rsrc->slices[level].stride;
 294
 295                 fb->mfbd_flags |= MALI_MFBD_EXTRA;
 296                 fbx->flags_hi |= MALI_EXTRA_PRESENT;
 297                 fbx->flags_lo |= MALI_EXTRA_ZS;
 298
 299                 fbx->ds_linear.depth = base;
 300
 301                 if (rsrc->layout == MALI_TEXTURE_LINEAR) {
 302                         fbx->zs_block = MALI_BLOCK_LINEAR;
 303                         fbx->ds_linear.depth_stride = stride / 16;
 304                 } else {
 305                         if (is_bifrost) {
 306                                 fbx->zs_block = MALI_BLOCK_UNKNOWN;
 307                                 fbx->flags_hi |= 0x4400;
 308                                 fbx->flags_lo |= 0x1;
 309                         } else {
 310                                 fbx->zs_block = MALI_BLOCK_TILED;
 311                         }
 312
 313                         fbx->ds_linear.depth_stride = stride;
 314                 }
 315
 316                 if (panfrost_is_z24s8_variant(surf->format)) {
 317                         fbx->flags_lo |= 0x1;
 318                 } else if (surf->format == PIPE_FORMAT_Z32_FLOAT) {
 319                         fbx->flags_lo |= 0xA;
 320                         fb->mfbd_flags ^= 0x100;
 321                         fb->mfbd_flags |= 0x200;
 322                 } else if (surf->format == PIPE_FORMAT_Z32_FLOAT_S8X24_UINT) {
 323                         fbx->flags_hi |= 0x400;
 324                         fbx->flags_lo |= 0xA;
 325                         fb->mfbd_flags ^= 0x100;
 326                         fb->mfbd_flags |= 0x201;
 327
 328                         struct panfrost_resource *stencil = rsrc->separate_stencil;
 329                         struct panfrost_slice stencil_slice = stencil->slices[level];
 330
 331                         fbx->ds_linear.stencil = panfrost_get_texture_address(stencil, level, first_layer);
 332                         fbx->ds_linear.stencil_stride = stencil_slice.stride;
 333                 }
 334
 335         } else {
 336                 assert(0);
 337         }
 338 }
 339
 340 /* Helper for sequential uploads used for MFBD */
 341
 342 #define UPLOAD(dest, offset, src, max) { \
 343         size_t sz = sizeof(*src); \
 344         memcpy(dest.cpu + offset, src, sz); \
 345         assert((offset + sz) <= max); \
 346         offset += sz; \
 347 }
 348
 349 static mali_ptr
 350 panfrost_mfbd_upload(struct panfrost_batch *batch,
 351         struct mali_framebuffer *fb,
 352         struct mali_framebuffer_extra *fbx,
 353         struct mali_render_target *rts,
 354         unsigned rt_count)
 355 {
 356         off_t offset = 0;
 357
 358         /* There may be extra data stuck in the middle */
 359         bool has_extra = fb->mfbd_flags & MALI_MFBD_EXTRA;
 360
 361         /* Compute total size for transfer */
 362
 363         size_t total_sz =
 364                 sizeof(struct mali_framebuffer) +
 365                 (has_extra ? sizeof(struct mali_framebuffer_extra) : 0) +
 366                 sizeof(struct mali_render_target) * 4;
 367
 368         struct panfrost_transfer m_f_trans =
 369                 panfrost_allocate_transient(batch, total_sz);
 370
 371         /* Do the transfer */
 372
 373         UPLOAD(m_f_trans, offset, fb, total_sz);
 374
 375         if (has_extra)
 376                 UPLOAD(m_f_trans, offset, fbx, total_sz);
 377
 378         for (unsigned c = 0; c < 4; ++c) {
 379                 UPLOAD(m_f_trans, offset, &rts[c], total_sz);
 380         }
 381
 382         /* Return pointer suitable for the fragment section */
 383         unsigned tag =
 384                 MALI_MFBD |
 385                 (has_extra ? MALI_MFBD_TAG_EXTRA : 0) |
 386                 (MALI_POSITIVE(rt_count) << 2);
 387
 388         return m_f_trans.gpu | tag;
 389 }
 390
 391 #undef UPLOAD
 392
 393 /* Determines whether a framebuffer uses too much tilebuffer space (requiring
 394  * us to scale up the tile at a performance penalty). This is conservative but
 395  * afaict you get 128-bits per pixel normally */
 396
 397 static bool
 398 pan_is_large_tib(struct panfrost_batch *batch)
 399 {
 400         unsigned size = 0;
 401
 402         for (int cb = 0; cb < batch->key.nr_cbufs; ++cb) {
 403                 struct pipe_surface *surf = batch->key.cbufs[cb];
 404                 assert(surf);
 405                 unsigned bpp = util_format_get_blocksize(surf->format);
 406                 size += ALIGN_POT(bpp, 4);
 407         }
 408
 409         return (size > 16);
 410 }
 411
 412 static struct mali_framebuffer
 413 panfrost_emit_mfbd(struct panfrost_batch *batch, unsigned vertex_count)
 414 {
 415         struct panfrost_context *ctx = batch->ctx;
 416         struct pipe_context *gallium = (struct pipe_context *) ctx;
 417         struct panfrost_device *dev = pan_device(gallium->screen);
 418
 419         unsigned width = batch->key.width;
 420         unsigned height = batch->key.height;
 421
 422         struct mali_framebuffer mfbd = {
 423                 .width1 = MALI_POSITIVE(width),
 424                 .height1 = MALI_POSITIVE(height),
 425                 .width2 = MALI_POSITIVE(width),
 426                 .height2 = MALI_POSITIVE(height),
 427
 428                 /* Seems to configure tib size */
 429                 .unk1 = pan_is_large_tib(batch) ? 0xc80 : 0x1080,
 430
 431                 .rt_count_1 = MALI_POSITIVE(batch->key.nr_cbufs),
 432                 .rt_count_2 = 4,
 433         };
 434
 435         if (dev->quirks & IS_BIFROST) {
 436                 mfbd.msaa.sample_locations = panfrost_emit_sample_locations(batch);
 437                 mfbd.tiler_meta = panfrost_batch_get_tiler_meta(batch, vertex_count);
 438         } else {
 439                 unsigned shift = panfrost_get_stack_shift(batch->stack_size);
 440                 struct panfrost_bo *bo = panfrost_batch_get_scratchpad(batch,
 441                                                                        shift,
 442                                                                        dev->thread_tls_alloc,
 443                                                                        dev->core_count);
 444                 mfbd.shared_memory.stack_shift = shift;
 445                 mfbd.shared_memory.scratchpad = bo->gpu;
 446                 mfbd.shared_memory.shared_workgroup_count = ~0;
 447
 448                 mfbd.tiler = panfrost_emit_midg_tiler(batch, vertex_count);
 449         }
 450
 451         return mfbd;
 452 }
 453
 454 void
 455 panfrost_attach_mfbd(struct panfrost_batch *batch, unsigned vertex_count)
 456 {
 457         struct mali_framebuffer mfbd =
 458                 panfrost_emit_mfbd(batch, vertex_count);
 459
 460         memcpy(batch->framebuffer.cpu, &mfbd, sizeof(mfbd));
 461 }
 462
 463 /* Creates an MFBD for the FRAGMENT section of the bound framebuffer */
 464
 465 mali_ptr
 466 panfrost_mfbd_fragment(struct panfrost_batch *batch, bool has_draws)
 467 {
 468         struct panfrost_device *dev = pan_device(batch->ctx->base.screen);
 469         bool is_bifrost = dev->quirks & IS_BIFROST;
 470
 471         struct mali_framebuffer fb = panfrost_emit_mfbd(batch, has_draws);
 472         struct mali_framebuffer_extra fbx = {0};
 473         struct mali_render_target rts[4] = {0};
 474
 475         /* We always upload at least one dummy GL_NONE render target */
 476
 477         unsigned rt_descriptors = MAX2(batch->key.nr_cbufs, 1);
 478
 479         fb.rt_count_1 = MALI_POSITIVE(rt_descriptors);
 480         fb.rt_count_2 = rt_descriptors;
 481         fb.mfbd_flags = 0x100;
 482
 483         /* TODO: MRT clear */
 484         panfrost_mfbd_clear(batch, &fb, &fbx, rts, fb.rt_count_2);
 485
 486
 487         /* Upload either the render target or a dummy GL_NONE target */
 488
 489         for (int cb = 0; cb < rt_descriptors; ++cb) {
 490                 struct pipe_surface *surf = batch->key.cbufs[cb];
 491
 492                 if (surf) {
 493                         panfrost_mfbd_set_cbuf(&rts[cb], surf);
 494
 495                         /* What is this? Looks like some extension of the bpp
 496                          * field. Maybe it establishes how much internal
 497                          * tilebuffer space is reserved? */
 498
 499                         unsigned bpp = util_format_get_blocksize(surf->format);
 500                         fb.rt_count_2 = MAX2(fb.rt_count_2, ALIGN_POT(bpp, 4) / 4);
 501                 } else {
 502                         struct mali_rt_format null_rt = {
 503                                 .unk1 = 0x4000000,
 504                                 .no_preload = true
 505                         };
 506
 507                         if (is_bifrost) {
 508                                 null_rt.flags = 0x8;
 509                                 null_rt.unk3 = 0x8;
 510                         }
 511
 512                         rts[cb].format = null_rt;
 513                         rts[cb].framebuffer = 0;
 514                         rts[cb].framebuffer_stride = 0;
 515                 }
 516
 517                 /* TODO: Break out the field */
 518                 rts[cb].format.unk1 |= (cb * 0x400);
 519         }
 520
 521         if (batch->key.zsbuf) {
 522                 panfrost_mfbd_set_zsbuf(&fb, &fbx, batch->key.zsbuf);
 523         }
 524
 525         /* When scanning out, the depth buffer is immediately invalidated, so
 526          * we don't need to waste bandwidth writing it out. This can improve
 527          * performance substantially (Z24X8_UNORM 1080p @ 60fps is 475 MB/s of
 528          * memory bandwidth!).
 529          *
 530          * The exception is ReadPixels, but this is not supported on GLES so we
 531          * can safely ignore it. */
 532
 533         if (panfrost_batch_is_scanout(batch))
 534                 batch->requirements &= ~PAN_REQ_DEPTH_WRITE;
 535
 536         /* Actualize the requirements */
 537
 538         if (batch->requirements & PAN_REQ_MSAA) {
 539                 rts[0].format.flags |= MALI_MFBD_FORMAT_MSAA;
 540
 541                 /* XXX */
 542                 fb.unk1 |= (1 << 4) | (1 << 1);
 543                 fb.rt_count_2 = 4;
 544         }
 545
 546         if (batch->requirements & PAN_REQ_DEPTH_WRITE)
 547                 fb.mfbd_flags |= MALI_MFBD_DEPTH_WRITE;
 548
 549         /* Checksumming only works with a single render target */
 550
 551         if (batch->key.nr_cbufs == 1) {
 552                 struct pipe_surface *surf = batch->key.cbufs[0];
 553                 struct panfrost_resource *rsrc = pan_resource(surf->texture);
 554
 555                 if (rsrc->checksummed) {
 556                         unsigned level = surf->u.tex.level;
 557                         struct panfrost_slice *slice = &rsrc->slices[level];
 558
 559                         fb.mfbd_flags |= MALI_MFBD_EXTRA;
 560                         fbx.flags_hi |= MALI_EXTRA_PRESENT;
 561                         fbx.checksum_stride = slice->checksum_stride;
 562                         if (slice->checksum_bo)
 563                                 fbx.checksum = slice->checksum_bo->gpu;
 564                         else
 565                                 fbx.checksum = rsrc->bo->gpu + slice->checksum_offset;
 566                 }
 567         }
 568
 569         return panfrost_mfbd_upload(batch, &fb, &fbx, rts, rt_descriptors);
 570 }