src/gallium/drivers/panfrost/pan_mfbd.c

   1 /*
   2  * Copyright 2018-2019 Alyssa Rosenzweig
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  20  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  21  * SOFTWARE.
  22  *
  23  */
  24
  25 #include "pan_bo.h"
  26 #include "pan_context.h"
  27 #include "pan_cmdstream.h"
  28 #include "pan_util.h"
  29 #include "panfrost-quirks.h"
  30
  31 static struct mali_rt_format
  32 panfrost_mfbd_format(struct pipe_surface *surf)
  33 {
  34         /* Explode details on the format */
  35
  36         const struct util_format_description *desc =
  37                 util_format_description(surf->format);
  38
  39         /* The swizzle for rendering is inverted from texturing */
  40
  41         unsigned char swizzle[4];
  42         panfrost_invert_swizzle(desc->swizzle, swizzle);
  43
  44         /* Fill in accordingly, defaulting to 8-bit UNORM */
  45
  46         struct mali_rt_format fmt = {
  47                 .unk1 = 0x4000000,
  48                 .unk2 = 0x1,
  49                 .nr_channels = MALI_POSITIVE(desc->nr_channels),
  50                 .unk3 = 0x4,
  51                 .flags = 0x8,
  52                 .swizzle = panfrost_translate_swizzle_4(swizzle),
  53                 .no_preload = true
  54         };
  55
  56         if (desc->colorspace == UTIL_FORMAT_COLORSPACE_SRGB)
  57                 fmt.flags |= MALI_MFBD_FORMAT_SRGB;
  58
  59         /* sRGB handled as a dedicated flag */
  60         enum pipe_format linearized = util_format_linear(surf->format);
  61
  62         /* If RGB, we're good to go */
  63         if (util_format_is_unorm8(desc))
  64                 return fmt;
  65
  66         /* Set flags for alternative formats */
  67
  68         switch (linearized) {
  69         case PIPE_FORMAT_B5G6R5_UNORM:
  70                 fmt.unk1 = 0x14000000;
  71                 fmt.nr_channels = MALI_POSITIVE(2);
  72                 fmt.unk3 |= 0x1;
  73                 break;
  74
  75         case PIPE_FORMAT_A4B4G4R4_UNORM:
  76         case PIPE_FORMAT_B4G4R4A4_UNORM:
  77         case PIPE_FORMAT_R4G4B4A4_UNORM:
  78                 fmt.unk1 = 0x10000000;
  79                 fmt.unk3 = 0x5;
  80                 fmt.nr_channels = MALI_POSITIVE(1);
  81                 break;
  82
  83         case PIPE_FORMAT_R10G10B10A2_UNORM:
  84         case PIPE_FORMAT_B10G10R10A2_UNORM:
  85         case PIPE_FORMAT_R10G10B10X2_UNORM:
  86         case PIPE_FORMAT_B10G10R10X2_UNORM:
  87                 fmt.unk1 = 0x08000000;
  88                 fmt.unk3 = 0x6;
  89                 fmt.nr_channels = MALI_POSITIVE(1);
  90                 break;
  91
  92         case PIPE_FORMAT_B5G5R5A1_UNORM:
  93         case PIPE_FORMAT_R5G5B5A1_UNORM:
  94         case PIPE_FORMAT_B5G5R5X1_UNORM:
  95                 fmt.unk1 = 0x18000000;
  96                 fmt.unk3 = 0x7;
  97                 fmt.nr_channels = MALI_POSITIVE(2);
  98                 break;
  99
 100         /* Generic 8-bit */
 101         case PIPE_FORMAT_R8_UINT:
 102         case PIPE_FORMAT_R8_SINT:
 103                 fmt.unk1 = 0x80000000;
 104                 fmt.unk3 = 0x0;
 105                 fmt.nr_channels = MALI_POSITIVE(1);
 106                 break;
 107
 108         /* Generic 32-bit */
 109         case PIPE_FORMAT_R11G11B10_FLOAT:
 110         case PIPE_FORMAT_R8G8B8A8_UINT:
 111         case PIPE_FORMAT_R8G8B8A8_SINT:
 112         case PIPE_FORMAT_R16G16_FLOAT:
 113         case PIPE_FORMAT_R16G16_UINT:
 114         case PIPE_FORMAT_R16G16_SINT:
 115         case PIPE_FORMAT_R32_FLOAT:
 116         case PIPE_FORMAT_R32_UINT:
 117         case PIPE_FORMAT_R32_SINT:
 118         case PIPE_FORMAT_R10G10B10A2_UINT:
 119                 fmt.unk1 = 0x88000000;
 120                 fmt.unk3 = 0x0;
 121                 fmt.nr_channels = MALI_POSITIVE(4);
 122                 break;
 123
 124         /* Generic 16-bit */
 125         case PIPE_FORMAT_R8G8_UINT:
 126         case PIPE_FORMAT_R8G8_SINT:
 127         case PIPE_FORMAT_R16_FLOAT:
 128         case PIPE_FORMAT_R16_UINT:
 129         case PIPE_FORMAT_R16_SINT:
 130                 fmt.unk1 = 0x84000000;
 131                 fmt.unk3 = 0x0;
 132                 fmt.nr_channels = MALI_POSITIVE(2);
 133                 break;
 134
 135         /* Generic 64-bit */
 136         case PIPE_FORMAT_R32G32_FLOAT:
 137         case PIPE_FORMAT_R32G32_SINT:
 138         case PIPE_FORMAT_R32G32_UINT:
 139         case PIPE_FORMAT_R16G16B16A16_FLOAT:
 140         case PIPE_FORMAT_R16G16B16A16_SINT:
 141         case PIPE_FORMAT_R16G16B16A16_UINT:
 142                 fmt.unk1 = 0x8c000000;
 143                 fmt.unk3 = 0x1;
 144                 fmt.nr_channels = MALI_POSITIVE(2);
 145                 break;
 146
 147         /* Generic 128-bit */
 148         case PIPE_FORMAT_R32G32B32A32_FLOAT:
 149         case PIPE_FORMAT_R32G32B32A32_SINT:
 150         case PIPE_FORMAT_R32G32B32A32_UINT:
 151                 fmt.unk1 = 0x90000000;
 152                 fmt.unk3 = 0x1;
 153                 fmt.nr_channels = MALI_POSITIVE(4);
 154                 break;
 155
 156         default:
 157                 unreachable("Invalid format rendering");
 158         }
 159
 160         return fmt;
 161 }
 162
 163
 164 static void
 165 panfrost_mfbd_clear(
 166         struct panfrost_batch *batch,
 167         struct mali_framebuffer *fb,
 168         struct mali_framebuffer_extra *fbx,
 169         struct mali_render_target *rts,
 170         unsigned rt_count)
 171 {
 172         struct panfrost_context *ctx = batch->ctx;
 173         struct pipe_context *gallium = (struct pipe_context *) ctx;
 174         struct panfrost_device *dev = pan_device(gallium->screen);
 175
 176         for (unsigned i = 0; i < rt_count; ++i) {
 177                 if (!(batch->clear & (PIPE_CLEAR_COLOR0 << i)))
 178                         continue;
 179
 180                 rts[i].clear_color_1 = batch->clear_color[i][0];
 181                 rts[i].clear_color_2 = batch->clear_color[i][1];
 182                 rts[i].clear_color_3 = batch->clear_color[i][2];
 183                 rts[i].clear_color_4 = batch->clear_color[i][3];
 184         }
 185
 186         if (batch->clear & PIPE_CLEAR_DEPTH) {
 187                 fb->clear_depth = batch->clear_depth;
 188         }
 189
 190         if (batch->clear & PIPE_CLEAR_STENCIL) {
 191                 fb->clear_stencil = batch->clear_stencil;
 192         }
 193
 194         if (dev->quirks & IS_BIFROST) {
 195                 fbx->clear_color_1 = batch->clear_color[0][0];
 196                 fbx->clear_color_2 = 0xc0000000 | (fbx->clear_color_1 & 0xffff); /* WTF? */
 197         }
 198 }
 199
 200 static void
 201 panfrost_mfbd_set_cbuf(
 202         struct mali_render_target *rt,
 203         struct pipe_surface *surf)
 204 {
 205         struct panfrost_resource *rsrc = pan_resource(surf->texture);
 206         struct panfrost_device *dev = pan_device(surf->context->screen);
 207         bool is_bifrost = dev->quirks & IS_BIFROST;
 208
 209         unsigned level = surf->u.tex.level;
 210         unsigned first_layer = surf->u.tex.first_layer;
 211         assert(surf->u.tex.last_layer == first_layer);
 212         int stride = rsrc->slices[level].stride;
 213
 214         /* Only set layer_stride for MSAA rendering */
 215
 216         unsigned nr_samples = surf->nr_samples;
 217
 218         if (!nr_samples)
 219                 nr_samples = surf->texture->nr_samples;
 220
 221         unsigned layer_stride = (nr_samples > 1) ? rsrc->slices[level].size0 : 0;
 222
 223         mali_ptr base = panfrost_get_texture_address(rsrc, level, first_layer, 0);
 224
 225         rt->format = panfrost_mfbd_format(surf);
 226
 227         if (layer_stride)
 228                 rt->format.flags |= MALI_MFBD_FORMAT_MSAA | MALI_MFBD_FORMAT_LAYERED;
 229
 230         /* Now, we set the layout specific pieces */
 231
 232         if (rsrc->layout == MALI_TEXTURE_LINEAR) {
 233                 if (is_bifrost) {
 234                         rt->format.unk4 = 0x1;
 235                 } else {
 236                         rt->format.block = MALI_BLOCK_LINEAR;
 237                 }
 238
 239                 rt->framebuffer = base;
 240                 rt->framebuffer_stride = stride / 16;
 241                 rt->layer_stride = layer_stride;
 242         } else if (rsrc->layout == MALI_TEXTURE_TILED) {
 243                 if (is_bifrost) {
 244                         rt->format.unk3 |= 0x8;
 245                 } else {
 246                         rt->format.block = MALI_BLOCK_TILED;
 247                 }
 248
 249                 rt->framebuffer = base;
 250                 rt->framebuffer_stride = stride;
 251                 rt->layer_stride = layer_stride;
 252         } else if (rsrc->layout == MALI_TEXTURE_AFBC) {
 253                 rt->format.block = MALI_BLOCK_AFBC;
 254
 255                 unsigned header_size = rsrc->slices[level].header_size;
 256
 257                 rt->framebuffer = base + header_size;
 258                 rt->layer_stride = layer_stride;
 259                 rt->afbc.metadata = base;
 260                 rt->afbc.stride = 0;
 261                 rt->afbc.flags = MALI_AFBC_FLAGS;
 262
 263                 unsigned components = util_format_get_nr_components(surf->format);
 264
 265                 /* The "lossless colorspace transform" is lossy for R and RG formats */
 266                 if (components >= 3)
 267                    rt->afbc.flags |= MALI_AFBC_YTR;
 268
 269                 /* TODO: The blob sets this to something nonzero, but it's not
 270                  * clear what/how to calculate/if it matters */
 271                 rt->framebuffer_stride = 0;
 272         } else {
 273                 fprintf(stderr, "Invalid render layout (cbuf)");
 274                 assert(0);
 275         }
 276 }
 277
 278 static void
 279 panfrost_mfbd_set_zsbuf(
 280         struct mali_framebuffer *fb,
 281         struct mali_framebuffer_extra *fbx,
 282         struct pipe_surface *surf)
 283 {
 284         struct panfrost_device *dev = pan_device(surf->context->screen);
 285         bool is_bifrost = dev->quirks & IS_BIFROST;
 286         struct panfrost_resource *rsrc = pan_resource(surf->texture);
 287
 288         unsigned nr_samples = surf->nr_samples;
 289
 290         if (!nr_samples)
 291                 nr_samples = surf->texture->nr_samples;
 292
 293         nr_samples = MAX2(nr_samples, 1);
 294
 295         fbx->zs_samples = MALI_POSITIVE(nr_samples);
 296
 297         unsigned level = surf->u.tex.level;
 298         unsigned first_layer = surf->u.tex.first_layer;
 299         assert(surf->u.tex.last_layer == first_layer);
 300
 301         mali_ptr base = panfrost_get_texture_address(rsrc, level, first_layer, 0);
 302
 303         if (rsrc->layout == MALI_TEXTURE_AFBC) {
 304                 /* The only Z/S format we can compress is Z24S8 or variants
 305                  * thereof (handled by the gallium frontend) */
 306                 assert(panfrost_is_z24s8_variant(surf->format));
 307
 308                 unsigned header_size = rsrc->slices[level].header_size;
 309
 310                 fb->mfbd_flags |= MALI_MFBD_EXTRA | MALI_MFBD_DEPTH_WRITE;
 311
 312                 fbx->flags_hi |= MALI_EXTRA_PRESENT;
 313                 fbx->flags_lo |= MALI_EXTRA_ZS | 0x1; /* unknown */
 314                 fbx->zs_block = MALI_BLOCK_AFBC;
 315
 316                 fbx->ds_afbc.depth_stencil = base + header_size;
 317                 fbx->ds_afbc.depth_stencil_afbc_metadata = base;
 318                 fbx->ds_afbc.depth_stencil_afbc_stride = 0;
 319
 320                 fbx->ds_afbc.flags = MALI_AFBC_FLAGS;
 321                 fbx->ds_afbc.padding = 0x1000;
 322         } else if (rsrc->layout == MALI_TEXTURE_LINEAR || rsrc->layout == MALI_TEXTURE_TILED) {
 323                 /* TODO: Z32F(S8) support, which is always linear */
 324
 325                 int stride = rsrc->slices[level].stride;
 326
 327                 unsigned layer_stride = (nr_samples > 1) ? rsrc->slices[level].size0 : 0;
 328
 329                 fb->mfbd_flags |= MALI_MFBD_EXTRA | MALI_MFBD_DEPTH_WRITE;
 330                 fbx->flags_hi |= MALI_EXTRA_PRESENT;
 331                 fbx->flags_lo |= MALI_EXTRA_ZS;
 332
 333                 fbx->ds_linear.depth = base;
 334
 335                 if (rsrc->layout == MALI_TEXTURE_LINEAR) {
 336                         fbx->zs_block = MALI_BLOCK_LINEAR;
 337                         fbx->ds_linear.depth_stride = stride / 16;
 338                         fbx->ds_linear.depth_layer_stride = layer_stride;
 339                 } else {
 340                         if (is_bifrost) {
 341                                 fbx->zs_block = MALI_BLOCK_UNKNOWN;
 342                                 fbx->flags_hi |= 0x440;
 343                                 fbx->flags_lo |= 0x1;
 344                         } else {
 345                                 fbx->zs_block = MALI_BLOCK_TILED;
 346                         }
 347
 348                         fbx->ds_linear.depth_stride = stride;
 349                         fbx->ds_linear.depth_layer_stride = layer_stride;
 350                 }
 351
 352                 if (panfrost_is_z24s8_variant(surf->format)) {
 353                         fbx->flags_lo |= 0x1;
 354                 } else if (surf->format == PIPE_FORMAT_Z32_FLOAT) {
 355                         fbx->flags_lo |= 0xA;
 356                         fb->mfbd_flags ^= 0x100;
 357                         fb->mfbd_flags |= 0x200;
 358                 } else if (surf->format == PIPE_FORMAT_Z32_FLOAT_S8X24_UINT) {
 359                         fbx->flags_hi |= 0x40;
 360                         fbx->flags_lo |= 0xA;
 361                         fb->mfbd_flags ^= 0x100;
 362                         fb->mfbd_flags |= 0x201;
 363
 364                         struct panfrost_resource *stencil = rsrc->separate_stencil;
 365                         struct panfrost_slice stencil_slice = stencil->slices[level];
 366                         unsigned stencil_layer_stride = (nr_samples > 1) ? stencil_slice.size0 : 0;
 367
 368                         fbx->ds_linear.stencil = panfrost_get_texture_address(stencil, level, first_layer, 0);
 369                         fbx->ds_linear.stencil_stride = stencil_slice.stride;
 370                         fbx->ds_linear.stencil_layer_stride = stencil_layer_stride;
 371                 }
 372
 373         } else {
 374                 assert(0);
 375         }
 376 }
 377
 378 /* Helper for sequential uploads used for MFBD */
 379
 380 #define UPLOAD(dest, offset, src, max) { \
 381         size_t sz = sizeof(*src); \
 382         memcpy(dest.cpu + offset, src, sz); \
 383         assert((offset + sz) <= max); \
 384         offset += sz; \
 385 }
 386
 387 static mali_ptr
 388 panfrost_mfbd_upload(struct panfrost_batch *batch,
 389         struct mali_framebuffer *fb,
 390         struct mali_framebuffer_extra *fbx,
 391         struct mali_render_target *rts,
 392         unsigned rt_count)
 393 {
 394         off_t offset = 0;
 395
 396         /* There may be extra data stuck in the middle */
 397         bool has_extra = fb->mfbd_flags & MALI_MFBD_EXTRA;
 398
 399         /* Compute total size for transfer */
 400
 401         size_t total_sz =
 402                 sizeof(struct mali_framebuffer) +
 403                 (has_extra ? sizeof(struct mali_framebuffer_extra) : 0) +
 404                 sizeof(struct mali_render_target) * 4;
 405
 406         struct panfrost_transfer m_f_trans =
 407                 panfrost_pool_alloc(&batch->pool, total_sz);
 408
 409         /* Do the transfer */
 410
 411         UPLOAD(m_f_trans, offset, fb, total_sz);
 412
 413         if (has_extra)
 414                 UPLOAD(m_f_trans, offset, fbx, total_sz);
 415
 416         for (unsigned c = 0; c < 4; ++c) {
 417                 UPLOAD(m_f_trans, offset, &rts[c], total_sz);
 418         }
 419
 420         /* Return pointer suitable for the fragment section */
 421         unsigned tag =
 422                 MALI_MFBD |
 423                 (has_extra ? MALI_MFBD_TAG_EXTRA : 0) |
 424                 (MALI_POSITIVE(rt_count) << 2);
 425
 426         return m_f_trans.gpu | tag;
 427 }
 428
 429 #undef UPLOAD
 430
 431 /* Determines the # of bytes per pixel we need to reserve for a given format in
 432  * the tilebuffer (compared to 128-bit budget, etc). Usually the same as the
 433  * bytes per pixel of the format itself, but there are some special cases I
 434  * don't understand. */
 435
 436 static unsigned
 437 pan_bytes_per_pixel_tib(enum pipe_format format)
 438 {
 439         const struct util_format_description *desc =
 440                 util_format_description(format);
 441
 442         if (util_format_is_unorm8(desc) || format == PIPE_FORMAT_B5G6R5_UNORM)
 443                 return 4;
 444
 445         return desc->block.bits / 8;
 446 }
 447
 448 /* Determines whether a framebuffer uses too much tilebuffer space (requiring
 449  * us to scale up the tile at a performance penalty). This is conservative but
 450  * afaict you get 128-bits per pixel normally */
 451
 452 static bool
 453 pan_is_large_tib(struct panfrost_batch *batch)
 454 {
 455         unsigned size = 0;
 456
 457         for (int cb = 0; cb < batch->key.nr_cbufs; ++cb) {
 458                 struct pipe_surface *surf = batch->key.cbufs[cb];
 459                 assert(surf);
 460                 size += pan_bytes_per_pixel_tib(surf->format);
 461         }
 462
 463         return (size > 16);
 464 }
 465
 466 static struct mali_framebuffer
 467 panfrost_emit_mfbd(struct panfrost_batch *batch, unsigned vertex_count)
 468 {
 469         struct panfrost_context *ctx = batch->ctx;
 470         struct pipe_context *gallium = (struct pipe_context *) ctx;
 471         struct panfrost_device *dev = pan_device(gallium->screen);
 472
 473         unsigned width = batch->key.width;
 474         unsigned height = batch->key.height;
 475
 476         struct mali_framebuffer mfbd = {
 477                 .width1 = MALI_POSITIVE(width),
 478                 .height1 = MALI_POSITIVE(height),
 479                 .width2 = MALI_POSITIVE(width),
 480                 .height2 = MALI_POSITIVE(height),
 481
 482                 /* Seems to configure tib size */
 483                 .unk1 = pan_is_large_tib(batch) ? 0xc80 : 0x1080,
 484
 485                 .rt_count_1 = MALI_POSITIVE(batch->key.nr_cbufs),
 486                 .rt_count_2 = 4,
 487         };
 488
 489         if (dev->quirks & IS_BIFROST) {
 490                 mfbd.msaa.sample_locations = panfrost_emit_sample_locations(batch);
 491                 mfbd.tiler_meta = panfrost_batch_get_tiler_meta(batch, vertex_count);
 492         } else {
 493                 unsigned shift = panfrost_get_stack_shift(batch->stack_size);
 494                 struct panfrost_bo *bo = panfrost_batch_get_scratchpad(batch,
 495                                                                        shift,
 496                                                                        dev->thread_tls_alloc,
 497                                                                        dev->core_count);
 498                 mfbd.shared_memory.stack_shift = shift;
 499                 mfbd.shared_memory.scratchpad = bo->gpu;
 500                 mfbd.shared_memory.shared_workgroup_count = ~0;
 501
 502                 mfbd.tiler = panfrost_emit_midg_tiler(batch, vertex_count);
 503         }
 504
 505         return mfbd;
 506 }
 507
 508 void
 509 panfrost_attach_mfbd(struct panfrost_batch *batch, unsigned vertex_count)
 510 {
 511         struct mali_framebuffer mfbd =
 512                 panfrost_emit_mfbd(batch, vertex_count);
 513
 514         memcpy(batch->framebuffer.cpu, &mfbd, sizeof(mfbd));
 515 }
 516
 517 /* Creates an MFBD for the FRAGMENT section of the bound framebuffer */
 518
 519 mali_ptr
 520 panfrost_mfbd_fragment(struct panfrost_batch *batch, bool has_draws)
 521 {
 522         struct panfrost_device *dev = pan_device(batch->ctx->base.screen);
 523         bool is_bifrost = dev->quirks & IS_BIFROST;
 524
 525         struct mali_framebuffer fb = panfrost_emit_mfbd(batch, has_draws);
 526         struct mali_framebuffer_extra fbx = {0};
 527         struct mali_render_target rts[4] = {0};
 528
 529         /* We always upload at least one dummy GL_NONE render target */
 530
 531         unsigned rt_descriptors = MAX2(batch->key.nr_cbufs, 1);
 532
 533         fb.rt_count_1 = MALI_POSITIVE(rt_descriptors);
 534         fb.mfbd_flags = 0x100;
 535
 536         panfrost_mfbd_clear(batch, &fb, &fbx, rts, rt_descriptors);
 537
 538         /* Upload either the render target or a dummy GL_NONE target */
 539
 540         unsigned offset = 0;
 541         bool is_large = pan_is_large_tib(batch);
 542
 543         for (int cb = 0; cb < rt_descriptors; ++cb) {
 544                 struct pipe_surface *surf = batch->key.cbufs[cb];
 545                 unsigned rt_offset = offset * 0x100;
 546
 547                 if (surf && ((batch->clear | batch->draws) & (PIPE_CLEAR_COLOR0 << cb))) {
 548                         unsigned nr_samples = surf->nr_samples;
 549
 550                         if (!nr_samples)
 551                                 nr_samples = surf->texture->nr_samples;
 552
 553                         if (nr_samples > 1)
 554                                 batch->requirements |= PAN_REQ_MSAA;
 555
 556                         panfrost_mfbd_set_cbuf(&rts[cb], surf);
 557
 558                         offset += pan_bytes_per_pixel_tib(surf->format);
 559                 } else {
 560                         struct mali_rt_format null_rt = {
 561                                 .unk1 = 0x4000000,
 562                                 .no_preload = true
 563                         };
 564
 565                         if (is_bifrost) {
 566                                 null_rt.flags = 0x8;
 567                                 null_rt.unk3 = 0x8;
 568                         }
 569
 570                         rts[cb].format = null_rt;
 571                         rts[cb].framebuffer = 0;
 572                         rts[cb].framebuffer_stride = 0;
 573                 }
 574
 575                 /* TODO: Break out the field */
 576                 rts[cb].format.unk1 |= is_large ? (rt_offset / 4) : rt_offset;
 577         }
 578
 579         fb.rt_count_2 = MAX2(DIV_ROUND_UP(offset, is_large ? 16 : 4), 1);
 580
 581         if (batch->key.zsbuf && ((batch->clear | batch->draws) & PIPE_CLEAR_DEPTHSTENCIL)) {
 582                 panfrost_mfbd_set_zsbuf(&fb, &fbx, batch->key.zsbuf);
 583         }
 584
 585         /* When scanning out, the depth buffer is immediately invalidated, so
 586          * we don't need to waste bandwidth writing it out. This can improve
 587          * performance substantially (Z24X8_UNORM 1080p @ 60fps is 475 MB/s of
 588          * memory bandwidth!).
 589          *
 590          * The exception is ReadPixels, but this is not supported on GLES so we
 591          * can safely ignore it. */
 592
 593         if (panfrost_batch_is_scanout(batch))
 594                 batch->requirements &= ~PAN_REQ_DEPTH_WRITE;
 595
 596         /* Actualize the requirements */
 597
 598         if (batch->requirements & PAN_REQ_MSAA) {
 599                 rts[0].format.flags |= MALI_MFBD_FORMAT_MSAA;
 600
 601                 /* XXX */
 602                 fb.unk1 |= (1 << 4) | (1 << 1);
 603                 fb.rt_count_2 = 4;
 604         }
 605
 606         if (batch->requirements & PAN_REQ_DEPTH_WRITE)
 607                 fb.mfbd_flags |= MALI_MFBD_DEPTH_WRITE;
 608
 609         /* Checksumming only works with a single render target */
 610
 611         if (batch->key.nr_cbufs == 1) {
 612                 struct pipe_surface *surf = batch->key.cbufs[0];
 613                 struct panfrost_resource *rsrc = pan_resource(surf->texture);
 614
 615                 if (rsrc->checksummed) {
 616                         unsigned level = surf->u.tex.level;
 617                         struct panfrost_slice *slice = &rsrc->slices[level];
 618
 619                         fb.mfbd_flags |= MALI_MFBD_EXTRA;
 620                         fbx.flags_hi |= MALI_EXTRA_PRESENT;
 621                         fbx.checksum_stride = slice->checksum_stride;
 622                         if (slice->checksum_bo)
 623                                 fbx.checksum = slice->checksum_bo->gpu;
 624                         else
 625                                 fbx.checksum = rsrc->bo->gpu + slice->checksum_offset;
 626                 }
 627         }
 628
 629         return panfrost_mfbd_upload(batch, &fb, &fbx, rts, rt_descriptors);
 630 }