src/gallium/drivers/svga/svga_screen_buffer.c

   1 /**********************************************************
   2  * Copyright 2008-2009 VMware, Inc.  All rights reserved.
   3  *
   4  * Permission is hereby granted, free of charge, to any person
   5  * obtaining a copy of this software and associated documentation
   6  * files (the "Software"), to deal in the Software without
   7  * restriction, including without limitation the rights to use, copy,
   8  * modify, merge, publish, distribute, sublicense, and/or sell copies
   9  * of the Software, and to permit persons to whom the Software is
  10  * furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice shall be
  13  * included in all copies or substantial portions of the Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
  16  * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
  17  * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
  18  * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
  19  * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
  20  * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
  21  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  22  * SOFTWARE.
  23  *
  24  **********************************************************/
  25
  26 #include "svga_cmd.h"
  27
  28 #include "pipe/p_state.h"
  29 #include "pipe/p_defines.h"
  30 #include "util/u_inlines.h"
  31 #include "os/os_thread.h"
  32 #include "util/u_math.h"
  33 #include "util/u_memory.h"
  34
  35 #include "svga_context.h"
  36 #include "svga_screen.h"
  37 #include "svga_screen_buffer.h"
  38 #include "svga_winsys.h"
  39 #include "svga_debug.h"
  40
  41
  42 /**
  43  * Vertex and index buffers have to be treated slightly differently from
  44  * regular guest memory regions because the SVGA device sees them as
  45  * surfaces, and the state tracker can create/destroy without the pipe
  46  * driver, therefore we must do the uploads from the vws.
  47  */
  48 static INLINE boolean
  49 svga_buffer_needs_hw_storage(unsigned usage)
  50 {
  51    return usage & (PIPE_BUFFER_USAGE_VERTEX | PIPE_BUFFER_USAGE_INDEX);
  52 }
  53
  54
  55 static INLINE enum pipe_error
  56 svga_buffer_create_host_surface(struct svga_screen *ss,
  57                                 struct svga_buffer *sbuf)
  58 {
  59    if(!sbuf->handle) {
  60       sbuf->key.flags = 0;
  61
  62       sbuf->key.format = SVGA3D_BUFFER;
  63       if(sbuf->base.usage & PIPE_BUFFER_USAGE_VERTEX)
  64          sbuf->key.flags |= SVGA3D_SURFACE_HINT_VERTEXBUFFER;
  65       if(sbuf->base.usage & PIPE_BUFFER_USAGE_INDEX)
  66          sbuf->key.flags |= SVGA3D_SURFACE_HINT_INDEXBUFFER;
  67
  68       sbuf->key.size.width = sbuf->base.size;
  69       sbuf->key.size.height = 1;
  70       sbuf->key.size.depth = 1;
  71
  72       sbuf->key.numFaces = 1;
  73       sbuf->key.numMipLevels = 1;
  74       sbuf->key.cachable = 1;
  75
  76       SVGA_DBG(DEBUG_DMA, "surface_create for buffer sz %d\n", sbuf->base.size);
  77
  78       sbuf->handle = svga_screen_surface_create(ss, &sbuf->key);
  79       if(!sbuf->handle)
  80          return PIPE_ERROR_OUT_OF_MEMORY;
  81
  82       /* Always set the discard flag on the first time the buffer is written
  83        * as svga_screen_surface_create might have passed a recycled host
  84        * buffer.
  85        */
  86       sbuf->dma.flags.discard = TRUE;
  87
  88       SVGA_DBG(DEBUG_DMA, "   --> got sid %p sz %d (buffer)\n", sbuf->handle, sbuf->base.size);
  89    }
  90
  91    return PIPE_OK;
  92 }
  93
  94
  95 static INLINE void
  96 svga_buffer_destroy_host_surface(struct svga_screen *ss,
  97                                  struct svga_buffer *sbuf)
  98 {
  99    if(sbuf->handle) {
 100       SVGA_DBG(DEBUG_DMA, " ungrab sid %p sz %d\n", sbuf->handle, sbuf->base.size);
 101       svga_screen_surface_destroy(ss, &sbuf->key, &sbuf->handle);
 102    }
 103 }
 104
 105
 106 static INLINE void
 107 svga_buffer_destroy_hw_storage(struct svga_screen *ss, struct svga_buffer *sbuf)
 108 {
 109    struct svga_winsys_screen *sws = ss->sws;
 110
 111    assert(!sbuf->map.count);
 112    assert(sbuf->hwbuf);
 113    if(sbuf->hwbuf) {
 114       sws->buffer_destroy(sws, sbuf->hwbuf);
 115       sbuf->hwbuf = NULL;
 116    }
 117 }
 118
 119 struct svga_winsys_buffer *
 120 svga_winsys_buffer_create( struct svga_screen *ss,
 121                            unsigned alignment,
 122                            unsigned usage,
 123                            unsigned size )
 124 {
 125    struct svga_winsys_screen *sws = ss->sws;
 126    struct svga_winsys_buffer *buf;
 127
 128    /* Just try */
 129    buf = sws->buffer_create(sws, alignment, usage, size);
 130    if(!buf) {
 131
 132       SVGA_DBG(DEBUG_DMA|DEBUG_PERF, "flushing screen to find %d bytes GMR\n",
 133                size);
 134
 135       /* Try flushing all pending DMAs */
 136       svga_screen_flush(ss, NULL);
 137       buf = sws->buffer_create(sws, alignment, usage, size);
 138
 139    }
 140
 141    return buf;
 142 }
 143
 144
 145 /**
 146  * Allocate DMA'ble storage for the buffer.
 147  *
 148  * Called before mapping a buffer.
 149  */
 150 static INLINE enum pipe_error
 151 svga_buffer_create_hw_storage(struct svga_screen *ss,
 152                               struct svga_buffer *sbuf)
 153 {
 154    if(!sbuf->hwbuf) {
 155       unsigned alignment = sbuf->base.alignment;
 156       unsigned usage = 0;
 157       unsigned size = sbuf->base.size;
 158
 159       sbuf->hwbuf = svga_winsys_buffer_create(ss, alignment, usage, size);
 160       if(!sbuf->hwbuf)
 161          return PIPE_ERROR_OUT_OF_MEMORY;
 162
 163       assert(!sbuf->dma.pending);
 164    }
 165
 166    return PIPE_OK;
 167 }
 168
 169
 170 /**
 171  * Variant of SVGA3D_BufferDMA which leaves the copy box temporarily in blank.
 172  */
 173 static enum pipe_error
 174 svga_buffer_upload_command(struct svga_context *svga,
 175                            struct svga_buffer *sbuf)
 176 {
 177    struct svga_winsys_context *swc = svga->swc;
 178    struct svga_winsys_buffer *guest = sbuf->hwbuf;
 179    struct svga_winsys_surface *host = sbuf->handle;
 180    SVGA3dTransferType transfer = SVGA3D_WRITE_HOST_VRAM;
 181    SVGA3dSurfaceDMAFlags flags = sbuf->dma.flags;
 182    SVGA3dCmdSurfaceDMA *cmd;
 183    uint32 numBoxes = sbuf->map.num_ranges;
 184    SVGA3dCopyBox *boxes;
 185    SVGA3dCmdSurfaceDMASuffix *pSuffix;
 186    unsigned region_flags;
 187    unsigned surface_flags;
 188    struct pipe_buffer *dummy;
 189
 190    if(transfer == SVGA3D_WRITE_HOST_VRAM) {
 191       region_flags = PIPE_BUFFER_USAGE_GPU_READ;
 192       surface_flags = PIPE_BUFFER_USAGE_GPU_WRITE;
 193    }
 194    else if(transfer == SVGA3D_READ_HOST_VRAM) {
 195       region_flags = PIPE_BUFFER_USAGE_GPU_WRITE;
 196       surface_flags = PIPE_BUFFER_USAGE_GPU_READ;
 197    }
 198    else {
 199       assert(0);
 200       return PIPE_ERROR_BAD_INPUT;
 201    }
 202
 203    assert(numBoxes);
 204
 205    cmd = SVGA3D_FIFOReserve(swc,
 206                             SVGA_3D_CMD_SURFACE_DMA,
 207                             sizeof *cmd + numBoxes * sizeof *boxes + sizeof *pSuffix,
 208                             2);
 209    if(!cmd)
 210       return PIPE_ERROR_OUT_OF_MEMORY;
 211
 212    swc->region_relocation(swc, &cmd->guest.ptr, guest, 0, region_flags);
 213    cmd->guest.pitch = 0;
 214
 215    swc->surface_relocation(swc, &cmd->host.sid, host, surface_flags);
 216    cmd->host.face = 0;
 217    cmd->host.mipmap = 0;
 218
 219    cmd->transfer = transfer;
 220
 221    sbuf->dma.boxes = (SVGA3dCopyBox *)&cmd[1];
 222    sbuf->dma.svga = svga;
 223
 224    /* Increment reference count */
 225    dummy = NULL;
 226    pipe_buffer_reference(&dummy, &sbuf->base);
 227
 228    pSuffix = (SVGA3dCmdSurfaceDMASuffix *)((uint8_t*)cmd + sizeof *cmd + numBoxes * sizeof *boxes);
 229    pSuffix->suffixSize = sizeof *pSuffix;
 230    pSuffix->maximumOffset = sbuf->base.size;
 231    pSuffix->flags = flags;
 232
 233    swc->commit(swc);
 234
 235    return PIPE_OK;
 236 }
 237
 238
 239 /**
 240  * Patch up the upload DMA command reserved by svga_buffer_upload_command
 241  * with the final ranges.
 242  */
 243 static void
 244 svga_buffer_upload_flush(struct svga_context *svga,
 245                          struct svga_buffer *sbuf)
 246 {
 247    SVGA3dCopyBox *boxes;
 248    unsigned i;
 249
 250    assert(sbuf->handle);
 251    assert(sbuf->hwbuf);
 252    assert(sbuf->map.num_ranges);
 253    assert(sbuf->dma.svga == svga);
 254    assert(sbuf->dma.boxes);
 255
 256    /*
 257     * Patch the DMA command with the final copy box.
 258     */
 259
 260    SVGA_DBG(DEBUG_DMA, "dma to sid %p\n", sbuf->handle);
 261
 262    boxes = sbuf->dma.boxes;
 263    for(i = 0; i < sbuf->map.num_ranges; ++i) {
 264       SVGA_DBG(DEBUG_DMA, "  bytes %u - %u\n",
 265                sbuf->map.ranges[i].start, sbuf->map.ranges[i].end);
 266
 267       boxes[i].x = sbuf->map.ranges[i].start;
 268       boxes[i].y = 0;
 269       boxes[i].z = 0;
 270       boxes[i].w = sbuf->map.ranges[i].end - sbuf->map.ranges[i].start;
 271       boxes[i].h = 1;
 272       boxes[i].d = 1;
 273       boxes[i].srcx = sbuf->map.ranges[i].start;
 274       boxes[i].srcy = 0;
 275       boxes[i].srcz = 0;
 276    }
 277
 278    sbuf->map.num_ranges = 0;
 279    memset(&sbuf->dma.flags, 0, sizeof sbuf->dma.flags);
 280
 281    assert(sbuf->head.prev && sbuf->head.next);
 282    LIST_DEL(&sbuf->head);
 283 #ifdef DEBUG
 284    sbuf->head.next = sbuf->head.prev = NULL;
 285 #endif
 286    sbuf->dma.pending = FALSE;
 287
 288    sbuf->dma.svga = NULL;
 289    sbuf->dma.boxes = NULL;
 290
 291    /* Decrement reference count */
 292    pipe_reference(&(sbuf->base.reference), NULL);
 293    sbuf = NULL;
 294 }
 295
 296
 297 /**
 298  * Note a dirty range.
 299  *
 300  * This function only notes the range down. It doesn't actually emit a DMA
 301  * upload command. That only happens when a context tries to refer to this
 302  * buffer, and the DMA upload command is added to that context's command buffer.
 303  *
 304  * We try to lump as many contiguous DMA transfers together as possible.
 305  */
 306 static void
 307 svga_buffer_add_range(struct svga_buffer *sbuf,
 308                       unsigned start,
 309                       unsigned end)
 310 {
 311    unsigned i;
 312    unsigned nearest_range;
 313    unsigned nearest_dist;
 314
 315    assert(sbuf->hwbuf);
 316    assert(end > start);
 317
 318    if (sbuf->map.num_ranges < SVGA_BUFFER_MAX_RANGES) {
 319       nearest_range = sbuf->map.num_ranges;
 320       nearest_dist = ~0;
 321    } else {
 322       nearest_range = SVGA_BUFFER_MAX_RANGES - 1;
 323       nearest_dist = 0;
 324    }
 325
 326    /*
 327     * Try to grow one of the ranges.
 328     *
 329     * Note that it is not this function task to care about overlapping ranges,
 330     * as the GMR was already given so it is too late to do anything. Situations
 331     * where overlapping ranges may pose a problem should be detected via
 332     * pipe_context::is_buffer_referenced and the context that refers to the
 333     * buffer should be flushed.
 334     */
 335
 336    for(i = 0; i < sbuf->map.num_ranges; ++i) {
 337       int left_dist;
 338       int right_dist;
 339       int dist;
 340
 341       left_dist = start - sbuf->map.ranges[i].end;
 342       right_dist = sbuf->map.ranges[i].start - end;
 343       dist = MAX2(left_dist, right_dist);
 344
 345       if (dist <= 0) {
 346          /*
 347           * Ranges are contiguous or overlapping -- extend this one and return.
 348           */
 349
 350          sbuf->map.ranges[i].start = MIN2(sbuf->map.ranges[i].start, start);
 351          sbuf->map.ranges[i].end   = MAX2(sbuf->map.ranges[i].end,   end);
 352          return;
 353       }
 354       else {
 355          /*
 356           * Discontiguous ranges -- keep track of the nearest range.
 357           */
 358
 359          if (dist < nearest_dist) {
 360             nearest_range = i;
 361             nearest_dist = dist;
 362          }
 363       }
 364    }
 365
 366    /*
 367     * We cannot add a new range to an existing DMA command, so patch-up the
 368     * pending DMA upload and start clean.
 369     */
 370
 371    if(sbuf->dma.pending)
 372       svga_buffer_upload_flush(sbuf->dma.svga, sbuf);
 373
 374    assert(!sbuf->dma.pending);
 375    assert(!sbuf->dma.svga);
 376    assert(!sbuf->dma.boxes);
 377
 378    if (sbuf->map.num_ranges < SVGA_BUFFER_MAX_RANGES) {
 379       /*
 380        * Add a new range.
 381        */
 382
 383       sbuf->map.ranges[sbuf->map.num_ranges].start = start;
 384       sbuf->map.ranges[sbuf->map.num_ranges].end = end;
 385       ++sbuf->map.num_ranges;
 386    } else {
 387       /*
 388        * Everything else failed, so just extend the nearest range.
 389        *
 390        * It is OK to do this because we always keep a local copy of the
 391        * host buffer data, for SW TNL, and the host never modifies the buffer.
 392        */
 393
 394       assert(nearest_range < SVGA_BUFFER_MAX_RANGES);
 395       assert(nearest_range < sbuf->map.num_ranges);
 396       sbuf->map.ranges[nearest_range].start = MIN2(sbuf->map.ranges[nearest_range].start, start);
 397       sbuf->map.ranges[nearest_range].end   = MAX2(sbuf->map.ranges[nearest_range].end,   end);
 398    }
 399 }
 400
 401
 402 static void *
 403 svga_buffer_map_range( struct pipe_screen *screen,
 404                        struct pipe_buffer *buf,
 405                        unsigned offset, unsigned length,
 406                        unsigned usage )
 407 {
 408    struct svga_screen *ss = svga_screen(screen);
 409    struct svga_winsys_screen *sws = ss->sws;
 410    struct svga_buffer *sbuf = svga_buffer( buf );
 411    void *map;
 412
 413    if (!sbuf->swbuf && !sbuf->hwbuf) {
 414       if (svga_buffer_create_hw_storage(ss, sbuf) != PIPE_OK) {
 415          /*
 416           * We can't create a hardware buffer big enough, so create a malloc
 417           * buffer instead.
 418           */
 419
 420          debug_printf("%s: failed to allocate %u KB of DMA, splitting DMA transfers\n",
 421                       __FUNCTION__,
 422                       (sbuf->base.size + 1023)/1024);
 423
 424          sbuf->swbuf = align_malloc(sbuf->base.size, sbuf->base.alignment);
 425       }
 426    }
 427
 428    if (sbuf->swbuf) {
 429       /* User/malloc buffer */
 430       map = sbuf->swbuf;
 431    }
 432    else if (sbuf->hwbuf) {
 433       map = sws->buffer_map(sws, sbuf->hwbuf, usage);
 434    }
 435    else {
 436       map = NULL;
 437    }
 438
 439    if(map) {
 440       pipe_mutex_lock(ss->swc_mutex);
 441
 442       ++sbuf->map.count;
 443
 444       if (usage & PIPE_BUFFER_USAGE_CPU_WRITE) {
 445          assert(sbuf->map.count <= 1);
 446          sbuf->map.writing = TRUE;
 447          if (usage & PIPE_BUFFER_USAGE_FLUSH_EXPLICIT)
 448             sbuf->map.flush_explicit = TRUE;
 449       }
 450
 451       pipe_mutex_unlock(ss->swc_mutex);
 452    }
 453
 454    return map;
 455 }
 456
 457 static void
 458 svga_buffer_flush_mapped_range( struct pipe_screen *screen,
 459                                 struct pipe_buffer *buf,
 460                                 unsigned offset, unsigned length)
 461 {
 462    struct svga_buffer *sbuf = svga_buffer( buf );
 463    struct svga_screen *ss = svga_screen(screen);
 464
 465    pipe_mutex_lock(ss->swc_mutex);
 466    assert(sbuf->map.writing);
 467    if(sbuf->map.writing) {
 468       assert(sbuf->map.flush_explicit);
 469       if(sbuf->hwbuf)
 470          svga_buffer_add_range(sbuf, offset, offset + length);
 471    }
 472    pipe_mutex_unlock(ss->swc_mutex);
 473 }
 474
 475 static void
 476 svga_buffer_unmap( struct pipe_screen *screen,
 477                    struct pipe_buffer *buf)
 478 {
 479    struct svga_screen *ss = svga_screen(screen);
 480    struct svga_winsys_screen *sws = ss->sws;
 481    struct svga_buffer *sbuf = svga_buffer( buf );
 482
 483    pipe_mutex_lock(ss->swc_mutex);
 484
 485    assert(sbuf->map.count);
 486    if(sbuf->map.count)
 487       --sbuf->map.count;
 488
 489    if(sbuf->hwbuf)
 490       sws->buffer_unmap(sws, sbuf->hwbuf);
 491
 492    if(sbuf->map.writing) {
 493       if(!sbuf->map.flush_explicit) {
 494          /* No mapped range was flushed -- flush the whole buffer */
 495          SVGA_DBG(DEBUG_DMA, "flushing the whole buffer\n");
 496
 497          if(sbuf->hwbuf)
 498             svga_buffer_add_range(sbuf, 0, sbuf->base.size);
 499       }
 500
 501       sbuf->map.writing = FALSE;
 502       sbuf->map.flush_explicit = FALSE;
 503    }
 504
 505    pipe_mutex_unlock(ss->swc_mutex);
 506 }
 507
 508 static void
 509 svga_buffer_destroy( struct pipe_buffer *buf )
 510 {
 511    struct svga_screen *ss = svga_screen(buf->screen);
 512    struct svga_buffer *sbuf = svga_buffer( buf );
 513
 514    assert(!p_atomic_read(&buf->reference.count));
 515
 516    assert(!sbuf->dma.pending);
 517
 518    if(sbuf->handle)
 519       svga_buffer_destroy_host_surface(ss, sbuf);
 520
 521    if(sbuf->hwbuf)
 522       svga_buffer_destroy_hw_storage(ss, sbuf);
 523
 524    if(sbuf->swbuf && !sbuf->user)
 525       align_free(sbuf->swbuf);
 526
 527    FREE(sbuf);
 528 }
 529
 530 static struct pipe_buffer *
 531 svga_buffer_create(struct pipe_screen *screen,
 532                    unsigned alignment,
 533                    unsigned usage,
 534                    unsigned size)
 535 {
 536    struct svga_screen *ss = svga_screen(screen);
 537    struct svga_buffer *sbuf;
 538
 539    assert(size);
 540    assert(alignment);
 541
 542    sbuf = CALLOC_STRUCT(svga_buffer);
 543    if(!sbuf)
 544       goto error1;
 545
 546    sbuf->magic = SVGA_BUFFER_MAGIC;
 547
 548    pipe_reference_init(&sbuf->base.reference, 1);
 549    sbuf->base.screen = screen;
 550    sbuf->base.alignment = alignment;
 551    sbuf->base.usage = usage;
 552    sbuf->base.size = size;
 553
 554    if(svga_buffer_needs_hw_storage(usage)) {
 555       if(svga_buffer_create_host_surface(ss, sbuf) != PIPE_OK)
 556          goto error2;
 557    }
 558    else {
 559       if(alignment < sizeof(void*))
 560          alignment = sizeof(void*);
 561
 562       usage |= PIPE_BUFFER_USAGE_CPU_READ_WRITE;
 563
 564       sbuf->swbuf = align_malloc(size, alignment);
 565       if(!sbuf->swbuf)
 566          goto error2;
 567    }
 568
 569    return &sbuf->base;
 570
 571 error2:
 572    FREE(sbuf);
 573 error1:
 574    return NULL;
 575 }
 576
 577 static struct pipe_buffer *
 578 svga_user_buffer_create(struct pipe_screen *screen,
 579                         void *ptr,
 580                         unsigned bytes)
 581 {
 582    struct svga_buffer *sbuf;
 583
 584    sbuf = CALLOC_STRUCT(svga_buffer);
 585    if(!sbuf)
 586       goto no_sbuf;
 587
 588    sbuf->magic = SVGA_BUFFER_MAGIC;
 589
 590    sbuf->swbuf = ptr;
 591    sbuf->user = TRUE;
 592
 593    pipe_reference_init(&sbuf->base.reference, 1);
 594    sbuf->base.screen = screen;
 595    sbuf->base.alignment = 1;
 596    sbuf->base.usage = 0;
 597    sbuf->base.size = bytes;
 598
 599    return &sbuf->base;
 600
 601 no_sbuf:
 602    return NULL;
 603 }
 604
 605
 606 void
 607 svga_screen_init_buffer_functions(struct pipe_screen *screen)
 608 {
 609    screen->buffer_create = svga_buffer_create;
 610    screen->user_buffer_create = svga_user_buffer_create;
 611    screen->buffer_map_range = svga_buffer_map_range;
 612    screen->buffer_flush_mapped_range = svga_buffer_flush_mapped_range;
 613    screen->buffer_unmap = svga_buffer_unmap;
 614    screen->buffer_destroy = svga_buffer_destroy;
 615 }
 616
 617
 618 /**
 619  * Copy the contents of the user buffer / malloc buffer to a hardware buffer.
 620  */
 621 static INLINE enum pipe_error
 622 svga_buffer_update_hw(struct svga_screen *ss, struct svga_buffer *sbuf)
 623 {
 624    if(!sbuf->hwbuf) {
 625       enum pipe_error ret;
 626       void *map;
 627
 628       assert(sbuf->swbuf);
 629       if(!sbuf->swbuf)
 630          return PIPE_ERROR;
 631
 632       ret = svga_buffer_create_hw_storage(ss, sbuf);
 633       assert(ret == PIPE_OK);
 634       if(ret != PIPE_OK)
 635          return ret;
 636
 637       pipe_mutex_lock(ss->swc_mutex);
 638       map = ss->sws->buffer_map(ss->sws, sbuf->hwbuf, PIPE_BUFFER_USAGE_CPU_WRITE);
 639       assert(map);
 640       if(!map) {
 641          pipe_mutex_unlock(ss->swc_mutex);
 642          return PIPE_ERROR_OUT_OF_MEMORY;
 643       }
 644
 645       memcpy(map, sbuf->swbuf, sbuf->base.size);
 646       ss->sws->buffer_unmap(ss->sws, sbuf->hwbuf);
 647
 648       /* This user/malloc buffer is now indistinguishable from a gpu buffer */
 649       assert(!sbuf->map.count);
 650       if(!sbuf->map.count) {
 651          if(sbuf->user)
 652             sbuf->user = FALSE;
 653          else
 654             align_free(sbuf->swbuf);
 655          sbuf->swbuf = NULL;
 656       }
 657
 658       svga_buffer_add_range(sbuf, 0, sbuf->base.size);
 659    }
 660
 661    pipe_mutex_unlock(ss->swc_mutex);
 662    return PIPE_OK;
 663 }
 664
 665
 666 struct svga_winsys_surface *
 667 svga_buffer_handle(struct svga_context *svga,
 668                    struct pipe_buffer *buf)
 669 {
 670    struct pipe_screen *screen = svga->pipe.screen;
 671    struct svga_screen *ss = svga_screen(screen);
 672    struct svga_buffer *sbuf;
 673    enum pipe_error ret;
 674
 675    if(!buf)
 676       return NULL;
 677
 678    sbuf = svga_buffer(buf);
 679
 680    assert(!sbuf->map.count);
 681
 682    if(!sbuf->handle) {
 683       ret = svga_buffer_create_host_surface(ss, sbuf);
 684       if(ret != PIPE_OK)
 685          return NULL;
 686
 687       ret = svga_buffer_update_hw(ss, sbuf);
 688       if(ret != PIPE_OK)
 689          return NULL;
 690    }
 691
 692    if(!sbuf->dma.pending && sbuf->map.num_ranges) {
 693       /* Queue the buffer for flushing */
 694       ret = svga_buffer_upload_command(svga, sbuf);
 695       if(ret != PIPE_OK)
 696          /* XXX: Should probably have a richer return value */
 697          return NULL;
 698
 699       assert(sbuf->dma.svga == svga);
 700
 701       sbuf->dma.pending = TRUE;
 702       assert(!sbuf->head.prev && !sbuf->head.next);
 703       LIST_ADDTAIL(&sbuf->head, &svga->dirty_buffers);
 704    }
 705
 706    return sbuf->handle;
 707 }
 708
 709 struct pipe_buffer *
 710 svga_screen_buffer_wrap_surface(struct pipe_screen *screen,
 711                                 enum SVGA3dSurfaceFormat format,
 712                                 struct svga_winsys_surface *srf)
 713 {
 714    struct pipe_buffer *buf;
 715    struct svga_buffer *sbuf;
 716    struct svga_winsys_screen *sws = svga_winsys_screen(screen);
 717
 718    buf = svga_buffer_create(screen, 0, SVGA_BUFFER_USAGE_WRAPPED, 0);
 719    if (!buf)
 720       return NULL;
 721
 722    sbuf = svga_buffer(buf);
 723
 724    /*
 725     * We are not the creator of this surface and therefore we must not
 726     * cache it for reuse. Set the cacheable flag to zero in the key to
 727     * prevent this.
 728     */
 729    sbuf->key.format = format;
 730    sbuf->key.cachable = 0;
 731    sws->surface_reference(sws, &sbuf->handle, srf);
 732
 733    return buf;
 734 }
 735
 736
 737 struct svga_winsys_surface *
 738 svga_screen_buffer_get_winsys_surface(struct pipe_buffer *buffer)
 739 {
 740    struct svga_winsys_screen *sws = svga_winsys_screen(buffer->screen);
 741    struct svga_winsys_surface *vsurf = NULL;
 742
 743    assert(svga_buffer(buffer)->key.cachable == 0);
 744    svga_buffer(buffer)->key.cachable = 0;
 745    sws->surface_reference(sws, &vsurf, svga_buffer(buffer)->handle);
 746    return vsurf;
 747 }
 748
 749 void
 750 svga_context_flush_buffers(struct svga_context *svga)
 751 {
 752    struct list_head *curr, *next;
 753    struct svga_buffer *sbuf;
 754
 755    curr = svga->dirty_buffers.next;
 756    next = curr->next;
 757    while(curr != &svga->dirty_buffers) {
 758       sbuf = LIST_ENTRY(struct svga_buffer, curr, head);
 759
 760       assert(p_atomic_read(&sbuf->base.reference.count) != 0);
 761       assert(sbuf->dma.pending);
 762
 763       svga_buffer_upload_flush(svga, sbuf);
 764
 765       curr = next;
 766       next = curr->next;
 767    }
 768 }