src/glsl/ir_validate.cpp

   1 /*
   2  * Copyright © 2010 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  21  * DEALINGS IN THE SOFTWARE.
  22  */
  23
  24 /**
  25  * \file ir_validate.cpp
  26  *
  27  * Attempts to verify that various invariants of the IR tree are true.
  28  *
  29  * In particular, at the moment it makes sure that no single
  30  * ir_instruction node except for ir_variable appears multiple times
  31  * in the ir tree.  ir_variable does appear multiple times: Once as a
  32  * declaration in an exec_list, and multiple times as the endpoint of
  33  * a dereference chain.
  34  */
  35
  36 #include "ir.h"
  37 #include "ir_hierarchical_visitor.h"
  38 #include "program/hash_table.h"
  39 #include "glsl_types.h"
  40
  41 class ir_validate : public ir_hierarchical_visitor {
  42 public:
  43    ir_validate()
  44    {
  45       this->ht = hash_table_ctor(0, hash_table_pointer_hash,
  46                                  hash_table_pointer_compare);
  47
  48       this->current_function = NULL;
  49
  50       this->callback = ir_validate::validate_ir;
  51       this->data = ht;
  52    }
  53
  54    ~ir_validate()
  55    {
  56       hash_table_dtor(this->ht);
  57    }
  58
  59    virtual ir_visitor_status visit(ir_variable *v);
  60    virtual ir_visitor_status visit(ir_dereference_variable *ir);
  61
  62    virtual ir_visitor_status visit_enter(ir_if *ir);
  63
  64    virtual ir_visitor_status visit_leave(ir_loop *ir);
  65    virtual ir_visitor_status visit_enter(ir_function *ir);
  66    virtual ir_visitor_status visit_leave(ir_function *ir);
  67    virtual ir_visitor_status visit_enter(ir_function_signature *ir);
  68
  69    virtual ir_visitor_status visit_leave(ir_expression *ir);
  70    virtual ir_visitor_status visit_leave(ir_swizzle *ir);
  71
  72    virtual ir_visitor_status visit_enter(ir_assignment *ir);
  73    virtual ir_visitor_status visit_enter(ir_call *ir);
  74
  75    static void validate_ir(ir_instruction *ir, void *data);
  76
  77    ir_function *current_function;
  78
  79    struct hash_table *ht;
  80 };
  81
  82
  83 ir_visitor_status
  84 ir_validate::visit(ir_dereference_variable *ir)
  85 {
  86    if ((ir->var == NULL) || (ir->var->as_variable() == NULL)) {
  87       printf("ir_dereference_variable @ %p does not specify a variable %p\n",
  88              (void *) ir, (void *) ir->var);
  89       abort();
  90    }
  91
  92    if (hash_table_find(ht, ir->var) == NULL) {
  93       printf("ir_dereference_variable @ %p specifies undeclared variable "
  94              "`%s' @ %p\n",
  95              (void *) ir, ir->var->name, (void *) ir->var);
  96       abort();
  97    }
  98
  99    this->validate_ir(ir, this->data);
 100
 101    return visit_continue;
 102 }
 103
 104 ir_visitor_status
 105 ir_validate::visit_enter(ir_if *ir)
 106 {
 107    if (ir->condition->type != glsl_type::bool_type) {
 108       printf("ir_if condition %s type instead of bool.\n",
 109              ir->condition->type->name);
 110       ir->print();
 111       printf("\n");
 112       abort();
 113    }
 114
 115    return visit_continue;
 116 }
 117
 118
 119 ir_visitor_status
 120 ir_validate::visit_leave(ir_loop *ir)
 121 {
 122    if (ir->counter != NULL) {
 123       if ((ir->from == NULL) || (ir->to == NULL) || (ir->increment == NULL)) {
 124          printf("ir_loop has invalid loop controls:\n"
 125                 "    counter:   %p\n"
 126                 "    from:      %p\n"
 127                 "    to:        %p\n"
 128                 "    increment: %p\n",
 129                 (void *) ir->counter, (void *) ir->from, (void *) ir->to,
 130                 (void *) ir->increment);
 131          abort();
 132       }
 133
 134       if ((ir->cmp < ir_binop_less) || (ir->cmp > ir_binop_nequal)) {
 135          printf("ir_loop has invalid comparitor %d\n", ir->cmp);
 136          abort();
 137       }
 138    } else {
 139       if ((ir->from != NULL) || (ir->to != NULL) || (ir->increment != NULL)) {
 140          printf("ir_loop has invalid loop controls:\n"
 141                 "    counter:   %p\n"
 142                 "    from:      %p\n"
 143                 "    to:        %p\n"
 144                 "    increment: %p\n",
 145                 (void *) ir->counter, (void *) ir->from, (void *) ir->to,
 146                 (void *) ir->increment);
 147          abort();
 148       }
 149    }
 150
 151    return visit_continue;
 152 }
 153
 154
 155 ir_visitor_status
 156 ir_validate::visit_enter(ir_function *ir)
 157 {
 158    /* Function definitions cannot be nested.
 159     */
 160    if (this->current_function != NULL) {
 161       printf("Function definition nested inside another function "
 162              "definition:\n");
 163       printf("%s %p inside %s %p\n",
 164              ir->name, (void *) ir,
 165              this->current_function->name, (void *) this->current_function);
 166       abort();
 167    }
 168
 169    /* Store the current function hierarchy being traversed.  This is used
 170     * by the function signature visitor to ensure that the signatures are
 171     * linked with the correct functions.
 172     */
 173    this->current_function = ir;
 174
 175    this->validate_ir(ir, this->data);
 176
 177    /* Verify that all of the things stored in the list of signatures are,
 178     * in fact, function signatures.
 179     */
 180    foreach_list(node, &ir->signatures) {
 181       ir_instruction *sig = (ir_instruction *) node;
 182
 183       if (sig->ir_type != ir_type_function_signature) {
 184          printf("Non-signature in signature list of function `%s'\n",
 185                 ir->name);
 186          abort();
 187       }
 188    }
 189
 190    return visit_continue;
 191 }
 192
 193 ir_visitor_status
 194 ir_validate::visit_leave(ir_function *ir)
 195 {
 196    assert(ralloc_parent(ir->name) == ir);
 197
 198    this->current_function = NULL;
 199    return visit_continue;
 200 }
 201
 202 ir_visitor_status
 203 ir_validate::visit_enter(ir_function_signature *ir)
 204 {
 205    if (this->current_function != ir->function()) {
 206       printf("Function signature nested inside wrong function "
 207              "definition:\n");
 208       printf("%p inside %s %p instead of %s %p\n",
 209              (void *) ir,
 210              this->current_function->name, (void *) this->current_function,
 211              ir->function_name(), (void *) ir->function());
 212       abort();
 213    }
 214
 215    if (ir->return_type == NULL) {
 216       printf("Function signature %p for function %s has NULL return type.\n",
 217              (void *) ir, ir->function_name());
 218       abort();
 219    }
 220
 221    this->validate_ir(ir, this->data);
 222
 223    return visit_continue;
 224 }
 225
 226 ir_visitor_status
 227 ir_validate::visit_leave(ir_expression *ir)
 228 {
 229    switch (ir->operation) {
 230    case ir_unop_bit_not:
 231       assert(ir->operands[0]->type == ir->type);
 232       break;
 233    case ir_unop_logic_not:
 234       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 235       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 236       break;
 237
 238    case ir_unop_neg:
 239    case ir_unop_abs:
 240    case ir_unop_sign:
 241    case ir_unop_rcp:
 242    case ir_unop_rsq:
 243    case ir_unop_sqrt:
 244       assert(ir->type == ir->operands[0]->type);
 245       break;
 246
 247    case ir_unop_exp:
 248    case ir_unop_log:
 249    case ir_unop_exp2:
 250    case ir_unop_log2:
 251       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 252       assert(ir->type == ir->operands[0]->type);
 253       break;
 254
 255    case ir_unop_f2i:
 256       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 257       assert(ir->type->base_type == GLSL_TYPE_INT);
 258       break;
 259    case ir_unop_f2u:
 260       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 261       assert(ir->type->base_type == GLSL_TYPE_UINT);
 262       break;
 263    case ir_unop_i2f:
 264       assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
 265       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 266       break;
 267    case ir_unop_f2b:
 268       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 269       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 270       break;
 271    case ir_unop_b2f:
 272       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 273       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 274       break;
 275    case ir_unop_i2b:
 276       assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
 277       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 278       break;
 279    case ir_unop_b2i:
 280       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 281       assert(ir->type->base_type == GLSL_TYPE_INT);
 282       break;
 283    case ir_unop_u2f:
 284       assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
 285       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 286       break;
 287    case ir_unop_i2u:
 288       assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
 289       assert(ir->type->base_type == GLSL_TYPE_UINT);
 290       break;
 291    case ir_unop_u2i:
 292       assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
 293       assert(ir->type->base_type == GLSL_TYPE_INT);
 294       break;
 295    case ir_unop_bitcast_i2f:
 296       assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
 297       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 298       break;
 299    case ir_unop_bitcast_f2i:
 300       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 301       assert(ir->type->base_type == GLSL_TYPE_INT);
 302       break;
 303    case ir_unop_bitcast_u2f:
 304       assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
 305       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 306       break;
 307    case ir_unop_bitcast_f2u:
 308       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 309       assert(ir->type->base_type == GLSL_TYPE_UINT);
 310       break;
 311
 312    case ir_unop_any:
 313       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 314       assert(ir->type == glsl_type::bool_type);
 315       break;
 316
 317    case ir_unop_trunc:
 318    case ir_unop_round_even:
 319    case ir_unop_ceil:
 320    case ir_unop_floor:
 321    case ir_unop_fract:
 322    case ir_unop_sin:
 323    case ir_unop_cos:
 324    case ir_unop_sin_reduced:
 325    case ir_unop_cos_reduced:
 326    case ir_unop_dFdx:
 327    case ir_unop_dFdy:
 328       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 329       assert(ir->operands[0]->type == ir->type);
 330       break;
 331
 332    case ir_unop_pack_snorm_2x16:
 333    case ir_unop_pack_unorm_2x16:
 334    case ir_unop_pack_half_2x16:
 335       assert(ir->type == glsl_type::uint_type);
 336       assert(ir->operands[0]->type == glsl_type::vec2_type);
 337       break;
 338
 339    case ir_unop_unpack_snorm_2x16:
 340    case ir_unop_unpack_unorm_2x16:
 341    case ir_unop_unpack_half_2x16:
 342       assert(ir->type == glsl_type::vec2_type);
 343       assert(ir->operands[0]->type == glsl_type::uint_type);
 344       break;
 345
 346    case ir_unop_unpack_half_2x16_split_x:
 347    case ir_unop_unpack_half_2x16_split_y:
 348       assert(ir->type == glsl_type::float_type);
 349       assert(ir->operands[0]->type == glsl_type::uint_type);
 350       break;
 351
 352    case ir_unop_noise:
 353       /* XXX what can we assert here? */
 354       break;
 355
 356    case ir_binop_add:
 357    case ir_binop_sub:
 358    case ir_binop_mul:
 359    case ir_binop_div:
 360    case ir_binop_mod:
 361    case ir_binop_min:
 362    case ir_binop_max:
 363    case ir_binop_pow:
 364       if (ir->operands[0]->type->is_scalar())
 365          assert(ir->operands[1]->type == ir->type);
 366       else if (ir->operands[1]->type->is_scalar())
 367          assert(ir->operands[0]->type == ir->type);
 368       else if (ir->operands[0]->type->is_vector() &&
 369                ir->operands[1]->type->is_vector()) {
 370          assert(ir->operands[0]->type == ir->operands[1]->type);
 371          assert(ir->operands[0]->type == ir->type);
 372       }
 373       break;
 374
 375    case ir_binop_less:
 376    case ir_binop_greater:
 377    case ir_binop_lequal:
 378    case ir_binop_gequal:
 379    case ir_binop_equal:
 380    case ir_binop_nequal:
 381       /* The semantics of the IR operators differ from the GLSL <, >, <=, >=,
 382        * ==, and != operators.  The IR operators perform a component-wise
 383        * comparison on scalar or vector types and return a boolean scalar or
 384        * vector type of the same size.
 385        */
 386       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 387       assert(ir->operands[0]->type == ir->operands[1]->type);
 388       assert(ir->operands[0]->type->is_vector()
 389              || ir->operands[0]->type->is_scalar());
 390       assert(ir->operands[0]->type->vector_elements
 391              == ir->type->vector_elements);
 392       break;
 393
 394    case ir_binop_all_equal:
 395    case ir_binop_any_nequal:
 396       /* GLSL == and != operate on scalars, vectors, matrices and arrays, and
 397        * return a scalar boolean.  The IR matches that.
 398        */
 399       assert(ir->type == glsl_type::bool_type);
 400       assert(ir->operands[0]->type == ir->operands[1]->type);
 401       break;
 402
 403    case ir_binop_lshift:
 404    case ir_binop_rshift:
 405       assert(ir->operands[0]->type->is_integer() &&
 406              ir->operands[1]->type->is_integer());
 407       if (ir->operands[0]->type->is_scalar()) {
 408           assert(ir->operands[1]->type->is_scalar());
 409       }
 410       if (ir->operands[0]->type->is_vector() &&
 411           ir->operands[1]->type->is_vector()) {
 412           assert(ir->operands[0]->type->components() ==
 413                  ir->operands[1]->type->components());
 414       }
 415       assert(ir->type == ir->operands[0]->type);
 416       break;
 417
 418    case ir_binop_bit_and:
 419    case ir_binop_bit_xor:
 420    case ir_binop_bit_or:
 421        assert(ir->operands[0]->type->base_type ==
 422               ir->operands[1]->type->base_type);
 423        assert(ir->type->is_integer());
 424        if (ir->operands[0]->type->is_vector() &&
 425            ir->operands[1]->type->is_vector()) {
 426            assert(ir->operands[0]->type->vector_elements ==
 427                   ir->operands[1]->type->vector_elements);
 428        }
 429        break;
 430
 431    case ir_binop_logic_and:
 432    case ir_binop_logic_xor:
 433    case ir_binop_logic_or:
 434       assert(ir->type == glsl_type::bool_type);
 435       assert(ir->operands[0]->type == glsl_type::bool_type);
 436       assert(ir->operands[1]->type == glsl_type::bool_type);
 437       break;
 438
 439    case ir_binop_dot:
 440       assert(ir->type == glsl_type::float_type);
 441       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 442       assert(ir->operands[0]->type->is_vector());
 443       assert(ir->operands[0]->type == ir->operands[1]->type);
 444       break;
 445
 446    case ir_binop_pack_half_2x16_split:
 447       assert(ir->type == glsl_type::uint_type);
 448       assert(ir->operands[0]->type == glsl_type::float_type);
 449       assert(ir->operands[1]->type == glsl_type::float_type);
 450       break;
 451
 452    case ir_binop_ubo_load:
 453       assert(ir->operands[0]->as_constant());
 454       assert(ir->operands[0]->type == glsl_type::uint_type);
 455
 456       assert(ir->operands[1]->type == glsl_type::uint_type);
 457       break;
 458
 459    case ir_quadop_vector:
 460       /* The vector operator collects some number of scalars and generates a
 461        * vector from them.
 462        *
 463        *  - All of the operands must be scalar.
 464        *  - Number of operands must matche the size of the resulting vector.
 465        *  - Base type of the operands must match the base type of the result.
 466        */
 467       assert(ir->type->is_vector());
 468       switch (ir->type->vector_elements) {
 469       case 2:
 470          assert(ir->operands[0]->type->is_scalar());
 471          assert(ir->operands[0]->type->base_type == ir->type->base_type);
 472          assert(ir->operands[1]->type->is_scalar());
 473          assert(ir->operands[1]->type->base_type == ir->type->base_type);
 474          assert(ir->operands[2] == NULL);
 475          assert(ir->operands[3] == NULL);
 476          break;
 477       case 3:
 478          assert(ir->operands[0]->type->is_scalar());
 479          assert(ir->operands[0]->type->base_type == ir->type->base_type);
 480          assert(ir->operands[1]->type->is_scalar());
 481          assert(ir->operands[1]->type->base_type == ir->type->base_type);
 482          assert(ir->operands[2]->type->is_scalar());
 483          assert(ir->operands[2]->type->base_type == ir->type->base_type);
 484          assert(ir->operands[3] == NULL);
 485          break;
 486       case 4:
 487          assert(ir->operands[0]->type->is_scalar());
 488          assert(ir->operands[0]->type->base_type == ir->type->base_type);
 489          assert(ir->operands[1]->type->is_scalar());
 490          assert(ir->operands[1]->type->base_type == ir->type->base_type);
 491          assert(ir->operands[2]->type->is_scalar());
 492          assert(ir->operands[2]->type->base_type == ir->type->base_type);
 493          assert(ir->operands[3]->type->is_scalar());
 494          assert(ir->operands[3]->type->base_type == ir->type->base_type);
 495          break;
 496       default:
 497          /* The is_vector assertion above should prevent execution from ever
 498           * getting here.
 499           */
 500          assert(!"Should not get here.");
 501          break;
 502       }
 503    }
 504
 505    return visit_continue;
 506 }
 507
 508 ir_visitor_status
 509 ir_validate::visit_leave(ir_swizzle *ir)
 510 {
 511    unsigned int chans[4] = {ir->mask.x, ir->mask.y, ir->mask.z, ir->mask.w};
 512
 513    for (unsigned int i = 0; i < ir->type->vector_elements; i++) {
 514       if (chans[i] >= ir->val->type->vector_elements) {
 515          printf("ir_swizzle @ %p specifies a channel not present "
 516                 "in the value.\n", (void *) ir);
 517          ir->print();
 518          abort();
 519       }
 520    }
 521
 522    return visit_continue;
 523 }
 524
 525 ir_visitor_status
 526 ir_validate::visit(ir_variable *ir)
 527 {
 528    /* An ir_variable is the one thing that can (and will) appear multiple times
 529     * in an IR tree.  It is added to the hashtable so that it can be used
 530     * in the ir_dereference_variable handler to ensure that a variable is
 531     * declared before it is dereferenced.
 532     */
 533    if (ir->name)
 534       assert(ralloc_parent(ir->name) == ir);
 535
 536    hash_table_insert(ht, ir, ir);
 537
 538
 539    /* If a variable is an array, verify that the maximum array index is in
 540     * bounds.  There was once an error in AST-to-HIR conversion that set this
 541     * to be out of bounds.
 542     */
 543    if (ir->type->array_size() > 0) {
 544       if (ir->max_array_access >= ir->type->length) {
 545          printf("ir_variable has maximum access out of bounds (%d vs %d)\n",
 546                 ir->max_array_access, ir->type->length - 1);
 547          ir->print();
 548          abort();
 549       }
 550    }
 551
 552    if (ir->constant_initializer != NULL && !ir->has_initializer) {
 553       printf("ir_variable didn't have an initializer, but has a constant "
 554              "initializer value.\n");
 555       ir->print();
 556       abort();
 557    }
 558
 559    return visit_continue;
 560 }
 561
 562 ir_visitor_status
 563 ir_validate::visit_enter(ir_assignment *ir)
 564 {
 565    const ir_dereference *const lhs = ir->lhs;
 566    if (lhs->type->is_scalar() || lhs->type->is_vector()) {
 567       if (ir->write_mask == 0) {
 568          printf("Assignment LHS is %s, but write mask is 0:\n",
 569                 lhs->type->is_scalar() ? "scalar" : "vector");
 570          ir->print();
 571          abort();
 572       }
 573
 574       int lhs_components = 0;
 575       for (int i = 0; i < 4; i++) {
 576          if (ir->write_mask & (1 << i))
 577             lhs_components++;
 578       }
 579
 580       if (lhs_components != ir->rhs->type->vector_elements) {
 581          printf("Assignment count of LHS write mask channels enabled not\n"
 582                 "matching RHS vector size (%d LHS, %d RHS).\n",
 583                 lhs_components, ir->rhs->type->vector_elements);
 584          ir->print();
 585          abort();
 586       }
 587    }
 588
 589    this->validate_ir(ir, this->data);
 590
 591    return visit_continue;
 592 }
 593
 594 ir_visitor_status
 595 ir_validate::visit_enter(ir_call *ir)
 596 {
 597    ir_function_signature *const callee = ir->callee;
 598
 599    if (callee->ir_type != ir_type_function_signature) {
 600       printf("IR called by ir_call is not ir_function_signature!\n");
 601       abort();
 602    }
 603
 604    if (ir->return_deref) {
 605       if (ir->return_deref->type != callee->return_type) {
 606          printf("callee type %s does not match return storage type %s\n",
 607                 callee->return_type->name, ir->return_deref->type->name);
 608          abort();
 609       }
 610    } else if (callee->return_type != glsl_type::void_type) {
 611       printf("ir_call has non-void callee but no return storage\n");
 612       abort();
 613    }
 614
 615    const exec_node *formal_param_node = callee->parameters.head;
 616    const exec_node *actual_param_node = ir->actual_parameters.head;
 617    while (true) {
 618       if (formal_param_node->is_tail_sentinel()
 619           != actual_param_node->is_tail_sentinel()) {
 620          printf("ir_call has the wrong number of parameters:\n");
 621          goto dump_ir;
 622       }
 623       if (formal_param_node->is_tail_sentinel()) {
 624          break;
 625       }
 626       const ir_variable *formal_param
 627          = (const ir_variable *) formal_param_node;
 628       const ir_rvalue *actual_param
 629          = (const ir_rvalue *) actual_param_node;
 630       if (formal_param->type != actual_param->type) {
 631          printf("ir_call parameter type mismatch:\n");
 632          goto dump_ir;
 633       }
 634       if (formal_param->mode == ir_var_function_out
 635           || formal_param->mode == ir_var_function_inout) {
 636          if (!actual_param->is_lvalue()) {
 637             printf("ir_call out/inout parameters must be lvalues:\n");
 638             goto dump_ir;
 639          }
 640       }
 641       formal_param_node = formal_param_node->next;
 642       actual_param_node = actual_param_node->next;
 643    }
 644
 645    return visit_continue;
 646
 647 dump_ir:
 648    ir->print();
 649    printf("callee:\n");
 650    callee->print();
 651    abort();
 652    return visit_stop;
 653 }
 654
 655 void
 656 ir_validate::validate_ir(ir_instruction *ir, void *data)
 657 {
 658    struct hash_table *ht = (struct hash_table *) data;
 659
 660    if (hash_table_find(ht, ir)) {
 661       printf("Instruction node present twice in ir tree:\n");
 662       ir->print();
 663       printf("\n");
 664       abort();
 665    }
 666    hash_table_insert(ht, ir, ir);
 667 }
 668
 669 void
 670 check_node_type(ir_instruction *ir, void *data)
 671 {
 672    (void) data;
 673
 674    if (ir->ir_type <= ir_type_unset || ir->ir_type >= ir_type_max) {
 675       printf("Instruction node with unset type\n");
 676       ir->print(); printf("\n");
 677    }
 678    ir_rvalue *value = ir->as_rvalue();
 679    if (value != NULL)
 680       assert(value->type != glsl_type::error_type);
 681 }
 682
 683 void
 684 validate_ir_tree(exec_list *instructions)
 685 {
 686    ir_validate v;
 687
 688    v.run(instructions);
 689
 690    foreach_iter(exec_list_iterator, iter, *instructions) {
 691       ir_instruction *ir = (ir_instruction *)iter.get();
 692
 693       visit_tree(ir, check_node_type, NULL);
 694    }
 695 }