src/glsl/ir_validate.cpp

   1 /*
   2  * Copyright © 2010 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  21  * DEALINGS IN THE SOFTWARE.
  22  */
  23
  24 /**
  25  * \file ir_validate.cpp
  26  *
  27  * Attempts to verify that various invariants of the IR tree are true.
  28  *
  29  * In particular, at the moment it makes sure that no single
  30  * ir_instruction node except for ir_variable appears multiple times
  31  * in the ir tree.  ir_variable does appear multiple times: Once as a
  32  * declaration in an exec_list, and multiple times as the endpoint of
  33  * a dereference chain.
  34  */
  35
  36 #include <inttypes.h>
  37 #include "ir.h"
  38 #include "ir_hierarchical_visitor.h"
  39 #include "program/hash_table.h"
  40 #include "glsl_types.h"
  41
  42 class ir_validate : public ir_hierarchical_visitor {
  43 public:
  44    ir_validate()
  45    {
  46       this->ht = hash_table_ctor(0, hash_table_pointer_hash,
  47                                  hash_table_pointer_compare);
  48
  49       this->current_function = NULL;
  50
  51       this->callback = ir_validate::validate_ir;
  52       this->data = ht;
  53    }
  54
  55    ~ir_validate()
  56    {
  57       hash_table_dtor(this->ht);
  58    }
  59
  60    virtual ir_visitor_status visit(ir_variable *v);
  61    virtual ir_visitor_status visit(ir_dereference_variable *ir);
  62    virtual ir_visitor_status visit(ir_if *ir);
  63
  64    virtual ir_visitor_status visit_leave(ir_loop *ir);
  65    virtual ir_visitor_status visit_enter(ir_function *ir);
  66    virtual ir_visitor_status visit_leave(ir_function *ir);
  67    virtual ir_visitor_status visit_enter(ir_function_signature *ir);
  68
  69    virtual ir_visitor_status visit_leave(ir_expression *ir);
  70    virtual ir_visitor_status visit_leave(ir_swizzle *ir);
  71
  72    virtual ir_visitor_status visit_enter(ir_assignment *ir);
  73
  74    static void validate_ir(ir_instruction *ir, void *data);
  75
  76    ir_function *current_function;
  77
  78    struct hash_table *ht;
  79 };
  80
  81
  82 ir_visitor_status
  83 ir_validate::visit(ir_dereference_variable *ir)
  84 {
  85    if ((ir->var == NULL) || (ir->var->as_variable() == NULL)) {
  86       printf("ir_dereference_variable @ %p does not specify a variable %p\n",
  87              (void *) ir, (void *) ir->var);
  88       abort();
  89    }
  90
  91    if (hash_table_find(ht, ir->var) == NULL) {
  92       printf("ir_dereference_variable @ %p specifies undeclared variable "
  93              "`%s' @ %p\n",
  94              (void *) ir, ir->var->name, (void *) ir->var);
  95       abort();
  96    }
  97
  98    this->validate_ir(ir, this->data);
  99
 100    return visit_continue;
 101 }
 102
 103 ir_visitor_status
 104 ir_validate::visit(ir_if *ir)
 105 {
 106    if (ir->condition->type != glsl_type::bool_type) {
 107       printf("ir_if condition %s type instead of bool.\n",
 108              ir->condition->type->name);
 109       ir->print();
 110       printf("\n");
 111       abort();
 112    }
 113
 114    return visit_continue;
 115 }
 116
 117
 118 ir_visitor_status
 119 ir_validate::visit_leave(ir_loop *ir)
 120 {
 121    if (ir->counter != NULL) {
 122       if ((ir->from == NULL) || (ir->from == NULL) || (ir->increment == NULL)) {
 123          printf("ir_loop has invalid loop controls:\n"
 124                 "    counter:   %p\n"
 125                 "    from:      %p\n"
 126                 "    to:        %p\n"
 127                 "    increment: %p\n",
 128                 (void *) ir->counter, (void *) ir->from, (void *) ir->to,
 129                 (void *) ir->increment);
 130          abort();
 131       }
 132
 133       if ((ir->cmp < ir_binop_less) || (ir->cmp > ir_binop_nequal)) {
 134          printf("ir_loop has invalid comparitor %d\n", ir->cmp);
 135          abort();
 136       }
 137    } else {
 138       if ((ir->from != NULL) || (ir->from != NULL) || (ir->increment != NULL)) {
 139          printf("ir_loop has invalid loop controls:\n"
 140                 "    counter:   %p\n"
 141                 "    from:      %p\n"
 142                 "    to:        %p\n"
 143                 "    increment: %p\n",
 144                 (void *) ir->counter, (void *) ir->from, (void *) ir->to,
 145                 (void *) ir->increment);
 146          abort();
 147       }
 148    }
 149
 150    return visit_continue;
 151 }
 152
 153
 154 ir_visitor_status
 155 ir_validate::visit_enter(ir_function *ir)
 156 {
 157    /* Function definitions cannot be nested.
 158     */
 159    if (this->current_function != NULL) {
 160       printf("Function definition nested inside another function "
 161              "definition:\n");
 162       printf("%s %p inside %s %p\n",
 163              ir->name, (void *) ir,
 164              this->current_function->name, (void *) this->current_function);
 165       abort();
 166    }
 167
 168    /* Store the current function hierarchy being traversed.  This is used
 169     * by the function signature visitor to ensure that the signatures are
 170     * linked with the correct functions.
 171     */
 172    this->current_function = ir;
 173
 174    this->validate_ir(ir, this->data);
 175
 176    return visit_continue;
 177 }
 178
 179 ir_visitor_status
 180 ir_validate::visit_leave(ir_function *ir)
 181 {
 182    assert(talloc_parent(ir->name) == ir);
 183
 184    this->current_function = NULL;
 185    return visit_continue;
 186 }
 187
 188 ir_visitor_status
 189 ir_validate::visit_enter(ir_function_signature *ir)
 190 {
 191    if (this->current_function != ir->function()) {
 192       printf("Function signature nested inside wrong function "
 193              "definition:\n");
 194       printf("%p inside %s %p instead of %s %p\n",
 195              (void *) ir,
 196              this->current_function->name, (void *) this->current_function,
 197              ir->function_name(), (void *) ir->function());
 198       abort();
 199    }
 200
 201    this->validate_ir(ir, this->data);
 202
 203    return visit_continue;
 204 }
 205
 206 ir_visitor_status
 207 ir_validate::visit_leave(ir_expression *ir)
 208 {
 209    switch (ir->operation) {
 210    case ir_unop_bit_not:
 211       assert(ir->operands[0]->type == ir->type);
 212       break;
 213    case ir_unop_logic_not:
 214       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 215       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 216       break;
 217
 218    case ir_unop_neg:
 219    case ir_unop_abs:
 220    case ir_unop_sign:
 221    case ir_unop_rcp:
 222    case ir_unop_rsq:
 223    case ir_unop_sqrt:
 224       assert(ir->type == ir->operands[0]->type);
 225       break;
 226
 227    case ir_unop_exp:
 228    case ir_unop_log:
 229    case ir_unop_exp2:
 230    case ir_unop_log2:
 231       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 232       assert(ir->type == ir->operands[0]->type);
 233       break;
 234
 235    case ir_unop_f2i:
 236       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 237       assert(ir->type->base_type == GLSL_TYPE_INT);
 238       break;
 239    case ir_unop_i2f:
 240       assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
 241       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 242       break;
 243    case ir_unop_f2b:
 244       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 245       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 246       break;
 247    case ir_unop_b2f:
 248       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 249       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 250       break;
 251    case ir_unop_i2b:
 252       assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
 253       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 254       break;
 255    case ir_unop_b2i:
 256       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 257       assert(ir->type->base_type == GLSL_TYPE_INT);
 258       break;
 259    case ir_unop_u2f:
 260       assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
 261       assert(ir->type->base_type == GLSL_TYPE_FLOAT);
 262       break;
 263
 264    case ir_unop_any:
 265       assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
 266       assert(ir->type == glsl_type::bool_type);
 267       break;
 268
 269    case ir_unop_trunc:
 270    case ir_unop_ceil:
 271    case ir_unop_floor:
 272    case ir_unop_fract:
 273    case ir_unop_sin:
 274    case ir_unop_cos:
 275    case ir_unop_dFdx:
 276    case ir_unop_dFdy:
 277       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 278       assert(ir->operands[0]->type == ir->type);
 279       break;
 280
 281    case ir_unop_noise:
 282       /* XXX what can we assert here? */
 283       break;
 284
 285    case ir_binop_add:
 286    case ir_binop_sub:
 287    case ir_binop_mul:
 288    case ir_binop_div:
 289    case ir_binop_mod:
 290    case ir_binop_min:
 291    case ir_binop_max:
 292    case ir_binop_pow:
 293       if (ir->operands[0]->type->is_scalar())
 294          assert(ir->operands[1]->type == ir->type);
 295       else if (ir->operands[1]->type->is_scalar())
 296          assert(ir->operands[0]->type == ir->type);
 297       else if (ir->operands[0]->type->is_vector() &&
 298                ir->operands[1]->type->is_vector()) {
 299          assert(ir->operands[0]->type == ir->operands[1]->type);
 300          assert(ir->operands[0]->type == ir->type);
 301       }
 302       break;
 303
 304    case ir_binop_less:
 305    case ir_binop_greater:
 306    case ir_binop_lequal:
 307    case ir_binop_gequal:
 308    case ir_binop_equal:
 309    case ir_binop_nequal:
 310       /* The semantics of the IR operators differ from the GLSL <, >, <=, >=,
 311        * ==, and != operators.  The IR operators perform a component-wise
 312        * comparison on scalar or vector types and return a boolean scalar or
 313        * vector type of the same size.
 314        */
 315       assert(ir->type->base_type == GLSL_TYPE_BOOL);
 316       assert(ir->operands[0]->type == ir->operands[1]->type);
 317       assert(ir->operands[0]->type->is_vector()
 318              || ir->operands[0]->type->is_scalar());
 319       assert(ir->operands[0]->type->vector_elements
 320              == ir->type->vector_elements);
 321       break;
 322
 323    case ir_binop_all_equal:
 324    case ir_binop_any_nequal:
 325       /* GLSL == and != operate on scalars, vectors, matrices and arrays, and
 326        * return a scalar boolean.  The IR matches that.
 327        */
 328       assert(ir->type == glsl_type::bool_type);
 329       assert(ir->operands[0]->type == ir->operands[1]->type);
 330       break;
 331
 332    case ir_binop_lshift:
 333    case ir_binop_rshift:
 334       assert(ir->operands[0]->type->is_integer() &&
 335              ir->operands[1]->type->is_integer());
 336       if (ir->operands[0]->type->is_scalar()) {
 337           assert(ir->operands[1]->type->is_scalar());
 338       }
 339       if (ir->operands[0]->type->is_vector() &&
 340           ir->operands[1]->type->is_vector()) {
 341           assert(ir->operands[0]->type->components() ==
 342                  ir->operands[1]->type->components());
 343       }
 344       assert(ir->type == ir->operands[0]->type);
 345       break;
 346
 347    case ir_binop_bit_and:
 348    case ir_binop_bit_xor:
 349    case ir_binop_bit_or:
 350       assert(ir->operands[0]->type == ir->operands[1]->type);
 351       assert(ir->type == ir->operands[0]->type);
 352       assert(ir->type->base_type == GLSL_TYPE_INT ||
 353              ir->type->base_type == GLSL_TYPE_UINT);
 354       break;
 355
 356    case ir_binop_logic_and:
 357    case ir_binop_logic_xor:
 358    case ir_binop_logic_or:
 359       assert(ir->type == glsl_type::bool_type);
 360       assert(ir->operands[0]->type == glsl_type::bool_type);
 361       assert(ir->operands[1]->type == glsl_type::bool_type);
 362       break;
 363
 364    case ir_binop_dot:
 365       assert(ir->type == glsl_type::float_type);
 366       assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
 367       assert(ir->operands[0]->type->is_vector());
 368       assert(ir->operands[0]->type == ir->operands[1]->type);
 369       break;
 370
 371    case ir_binop_cross:
 372       assert(ir->operands[0]->type == glsl_type::vec3_type);
 373       assert(ir->operands[1]->type == glsl_type::vec3_type);
 374       assert(ir->type == glsl_type::vec3_type);
 375       break;
 376    }
 377
 378    return visit_continue;
 379 }
 380
 381 ir_visitor_status
 382 ir_validate::visit_leave(ir_swizzle *ir)
 383 {
 384    int chans[4] = {ir->mask.x, ir->mask.y, ir->mask.z, ir->mask.w};
 385
 386    for (unsigned int i = 0; i < ir->type->vector_elements; i++) {
 387       if (chans[i] >= ir->val->type->vector_elements) {
 388          printf("ir_swizzle @ %p specifies a channel not present "
 389                 "in the value.\n", (void *) ir);
 390          ir->print();
 391          abort();
 392       }
 393    }
 394
 395    return visit_continue;
 396 }
 397
 398 ir_visitor_status
 399 ir_validate::visit(ir_variable *ir)
 400 {
 401    /* An ir_variable is the one thing that can (and will) appear multiple times
 402     * in an IR tree.  It is added to the hashtable so that it can be used
 403     * in the ir_dereference_variable handler to ensure that a variable is
 404     * declared before it is dereferenced.
 405     */
 406    if (ir->name)
 407       assert(talloc_parent(ir->name) == ir);
 408
 409    hash_table_insert(ht, ir, ir);
 410    return visit_continue;
 411 }
 412
 413 ir_visitor_status
 414 ir_validate::visit_enter(ir_assignment *ir)
 415 {
 416    const ir_dereference *const lhs = ir->lhs;
 417    if (lhs->type->is_scalar() || lhs->type->is_vector()) {
 418       if (ir->write_mask == 0) {
 419          printf("Assignment LHS is %s, but write mask is 0:\n",
 420                 lhs->type->is_scalar() ? "scalar" : "vector");
 421          ir->print();
 422          abort();
 423       }
 424
 425       int lhs_components = 0;
 426       for (int i = 0; i < 4; i++) {
 427          if (ir->write_mask & (1 << i))
 428             lhs_components++;
 429       }
 430
 431       if (lhs_components != ir->rhs->type->vector_elements) {
 432          printf("Assignment count of LHS write mask channels enabled not\n"
 433                 "matching RHS vector size (%d LHS, %d RHS).\n",
 434                 lhs_components, ir->rhs->type->vector_elements);
 435          ir->print();
 436          abort();
 437       }
 438    }
 439
 440    this->validate_ir(ir, this->data);
 441
 442    return visit_continue;
 443 }
 444
 445 void
 446 ir_validate::validate_ir(ir_instruction *ir, void *data)
 447 {
 448    struct hash_table *ht = (struct hash_table *) data;
 449
 450    if (hash_table_find(ht, ir)) {
 451       printf("Instruction node present twice in ir tree:\n");
 452       ir->print();
 453       printf("\n");
 454       abort();
 455    }
 456    hash_table_insert(ht, ir, ir);
 457 }
 458
 459 void
 460 check_node_type(ir_instruction *ir, void *data)
 461 {
 462    (void) data;
 463
 464    if (ir->ir_type <= ir_type_unset || ir->ir_type >= ir_type_max) {
 465       printf("Instruction node with unset type\n");
 466       ir->print(); printf("\n");
 467    }
 468    assert(ir->type != glsl_type::error_type);
 469 }
 470
 471 void
 472 validate_ir_tree(exec_list *instructions)
 473 {
 474    ir_validate v;
 475
 476    v.run(instructions);
 477
 478    foreach_iter(exec_list_iterator, iter, *instructions) {
 479       ir_instruction *ir = (ir_instruction *)iter.get();
 480
 481       visit_tree(ir, check_node_type, NULL);
 482    }
 483 }