2 * Copyright © 2012 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
21 * DEALINGS IN THE SOFTWARE.
25 * \file lower_ubo_reference.cpp
27 * IR lower pass to replace dereferences of variables in a uniform
28 * buffer object with usage of ir_binop_ubo_load expressions, each of
29 * which can read data up to the size of a vec4.
31 * This relieves drivers of the responsibility to deal with tricky UBO
32 * layout issues like std140 structures and row_major matrices on
36 #include "lower_buffer_access.h"
37 #include "ir_builder.h"
38 #include "main/macros.h"
39 #include "glsl_parser_extras.h"
41 using namespace ir_builder
;
44 class lower_ubo_reference_visitor
:
45 public lower_buffer_access::lower_buffer_access
{
47 lower_ubo_reference_visitor(struct gl_shader
*shader
)
52 void handle_rvalue(ir_rvalue
**rvalue
);
53 ir_visitor_status
visit_enter(ir_assignment
*ir
);
55 void setup_for_load_or_store(ir_variable
*var
,
58 unsigned *const_offset
,
62 ir_expression
*ubo_load(const struct glsl_type
*type
,
64 ir_call
*ssbo_load(const struct glsl_type
*type
,
67 bool check_for_buffer_array_copy(ir_assignment
*ir
);
68 bool check_for_buffer_struct_copy(ir_assignment
*ir
);
69 void check_for_ssbo_store(ir_assignment
*ir
);
70 void write_to_memory(ir_dereference
*deref
,
72 ir_variable
*write_var
,
74 ir_call
*ssbo_store(ir_rvalue
*deref
, ir_rvalue
*offset
,
81 ssbo_unsized_array_length_access
,
85 void insert_buffer_access(void *mem_ctx
, ir_dereference
*deref
,
86 const glsl_type
*type
, ir_rvalue
*offset
,
87 unsigned mask
, int channel
);
89 ir_visitor_status
visit_enter(class ir_expression
*);
90 ir_expression
*calculate_ssbo_unsized_array_length(ir_expression
*expr
);
91 void check_ssbo_unsized_array_length_expression(class ir_expression
*);
92 void check_ssbo_unsized_array_length_assignment(ir_assignment
*ir
);
94 ir_expression
*process_ssbo_unsized_array_length(ir_rvalue
**,
97 ir_expression
*emit_ssbo_get_buffer_size();
99 unsigned calculate_unsized_array_stride(ir_dereference
*deref
,
102 ir_call
*lower_ssbo_atomic_intrinsic(ir_call
*ir
);
103 ir_call
*check_for_ssbo_atomic_intrinsic(ir_call
*ir
);
104 ir_visitor_status
visit_enter(ir_call
*ir
);
107 struct gl_shader
*shader
;
108 struct gl_uniform_buffer_variable
*ubo_var
;
109 ir_rvalue
*uniform_block
;
114 * Determine the name of the interface block field
116 * This is the name of the specific member as it would appear in the
117 * \c gl_uniform_buffer_variable::Name field in the shader's
118 * \c UniformBlocks array.
121 interface_field_name(void *mem_ctx
, char *base_name
, ir_rvalue
*d
,
122 ir_rvalue
**nonconst_block_index
)
124 *nonconst_block_index
= NULL
;
125 char *name_copy
= NULL
;
126 size_t base_length
= 0;
128 /* Loop back through the IR until we find the uniform block */
131 switch (ir
->ir_type
) {
132 case ir_type_dereference_variable
: {
138 case ir_type_dereference_record
: {
139 ir_dereference_record
*r
= (ir_dereference_record
*) ir
;
140 ir
= r
->record
->as_dereference();
142 /* If we got here it means any previous array subscripts belong to
143 * block members and not the block itself so skip over them in the
150 case ir_type_dereference_array
: {
151 ir_dereference_array
*a
= (ir_dereference_array
*) ir
;
152 ir
= a
->array
->as_dereference();
156 case ir_type_swizzle
: {
157 ir_swizzle
*s
= (ir_swizzle
*) ir
;
158 ir
= s
->val
->as_dereference();
159 /* Skip swizzle in the next pass */
165 assert(!"Should not get here.");
171 switch (d
->ir_type
) {
172 case ir_type_dereference_variable
: {
173 ir_dereference_variable
*v
= (ir_dereference_variable
*) d
;
174 if (name_copy
!= NULL
&&
175 v
->var
->is_interface_instance() &&
176 v
->var
->type
->is_array()) {
179 *nonconst_block_index
= NULL
;
186 case ir_type_dereference_array
: {
187 ir_dereference_array
*a
= (ir_dereference_array
*) d
;
190 if (name_copy
== NULL
) {
191 name_copy
= ralloc_strdup(mem_ctx
, base_name
);
192 base_length
= strlen(name_copy
);
195 /* For arrays of arrays we start at the innermost array and work our
196 * way out so we need to insert the subscript at the base of the
197 * name string rather than just attaching it to the end.
199 new_length
= base_length
;
200 ir_constant
*const_index
= a
->array_index
->as_constant();
201 char *end
= ralloc_strdup(NULL
, &name_copy
[new_length
]);
203 ir_rvalue
*array_index
= a
->array_index
;
204 if (array_index
->type
!= glsl_type::uint_type
)
205 array_index
= i2u(array_index
);
207 if (a
->array
->type
->is_array() &&
208 a
->array
->type
->fields
.array
->is_array()) {
209 ir_constant
*base_size
= new(mem_ctx
)
210 ir_constant(a
->array
->type
->fields
.array
->arrays_of_arrays_size());
211 array_index
= mul(array_index
, base_size
);
214 if (*nonconst_block_index
) {
215 *nonconst_block_index
= add(*nonconst_block_index
, array_index
);
217 *nonconst_block_index
= array_index
;
220 ralloc_asprintf_rewrite_tail(&name_copy
, &new_length
, "[0]%s",
223 ralloc_asprintf_rewrite_tail(&name_copy
, &new_length
, "[%d]%s",
224 const_index
->get_uint_component(0),
229 d
= a
->array
->as_dereference();
235 assert(!"Should not get here.");
240 assert(!"Should not get here.");
245 lower_ubo_reference_visitor::setup_for_load_or_store(ir_variable
*var
,
248 unsigned *const_offset
,
253 /* Determine the name of the interface block */
254 ir_rvalue
*nonconst_block_index
;
255 const char *const field_name
=
256 interface_field_name(mem_ctx
, (char *) var
->get_interface_type()->name
,
257 deref
, &nonconst_block_index
);
259 /* Locate the block by interface name */
261 struct gl_uniform_block
**blocks
;
262 if (this->buffer_access_type
!= ubo_load_access
) {
263 num_blocks
= shader
->NumShaderStorageBlocks
;
264 blocks
= shader
->ShaderStorageBlocks
;
266 num_blocks
= shader
->NumUniformBlocks
;
267 blocks
= shader
->UniformBlocks
;
269 this->uniform_block
= NULL
;
270 for (unsigned i
= 0; i
< num_blocks
; i
++) {
271 if (strcmp(field_name
, blocks
[i
]->Name
) == 0) {
273 ir_constant
*index
= new(mem_ctx
) ir_constant(i
);
275 if (nonconst_block_index
) {
276 this->uniform_block
= add(nonconst_block_index
, index
);
278 this->uniform_block
= index
;
281 this->ubo_var
= var
->is_interface_instance()
282 ? &blocks
[i
]->Uniforms
[0] : &blocks
[i
]->Uniforms
[var
->data
.location
];
288 assert(this->uniform_block
);
290 *const_offset
= ubo_var
->Offset
;
292 setup_buffer_access(mem_ctx
, var
, deref
, offset
, const_offset
, row_major
,
293 matrix_columns
, packing
);
297 lower_ubo_reference_visitor::handle_rvalue(ir_rvalue
**rvalue
)
302 ir_dereference
*deref
= (*rvalue
)->as_dereference();
306 ir_variable
*var
= deref
->variable_referenced();
307 if (!var
|| !var
->is_in_buffer_block())
310 mem_ctx
= ralloc_parent(shader
->ir
);
312 ir_rvalue
*offset
= NULL
;
313 unsigned const_offset
;
316 unsigned packing
= var
->get_interface_type()->interface_packing
;
318 this->buffer_access_type
=
319 var
->is_in_shader_storage_block() ?
320 ssbo_load_access
: ubo_load_access
;
322 /* Compute the offset to the start if the dereference as well as other
323 * information we need to configure the write
325 setup_for_load_or_store(var
, deref
,
326 &offset
, &const_offset
,
327 &row_major
, &matrix_columns
,
331 /* Now that we've calculated the offset to the start of the
332 * dereference, walk over the type and emit loads into a temporary.
334 const glsl_type
*type
= (*rvalue
)->type
;
335 ir_variable
*load_var
= new(mem_ctx
) ir_variable(type
,
338 base_ir
->insert_before(load_var
);
340 ir_variable
*load_offset
= new(mem_ctx
) ir_variable(glsl_type::uint_type
,
341 "ubo_load_temp_offset",
343 base_ir
->insert_before(load_offset
);
344 base_ir
->insert_before(assign(load_offset
, offset
));
346 deref
= new(mem_ctx
) ir_dereference_variable(load_var
);
347 emit_access(mem_ctx
, false, deref
, load_offset
, const_offset
,
348 row_major
, matrix_columns
, packing
, 0);
355 lower_ubo_reference_visitor::ubo_load(const glsl_type
*type
,
358 ir_rvalue
*block_ref
= this->uniform_block
->clone(mem_ctx
, NULL
);
360 ir_expression(ir_binop_ubo_load
,
368 shader_storage_buffer_object(const _mesa_glsl_parse_state
*state
)
370 return state
->ARB_shader_storage_buffer_object_enable
;
374 lower_ubo_reference_visitor::ssbo_store(ir_rvalue
*deref
,
378 exec_list sig_params
;
380 ir_variable
*block_ref
= new(mem_ctx
)
381 ir_variable(glsl_type::uint_type
, "block_ref" , ir_var_function_in
);
382 sig_params
.push_tail(block_ref
);
384 ir_variable
*offset_ref
= new(mem_ctx
)
385 ir_variable(glsl_type::uint_type
, "offset" , ir_var_function_in
);
386 sig_params
.push_tail(offset_ref
);
388 ir_variable
*val_ref
= new(mem_ctx
)
389 ir_variable(deref
->type
, "value" , ir_var_function_in
);
390 sig_params
.push_tail(val_ref
);
392 ir_variable
*writemask_ref
= new(mem_ctx
)
393 ir_variable(glsl_type::uint_type
, "write_mask" , ir_var_function_in
);
394 sig_params
.push_tail(writemask_ref
);
396 ir_function_signature
*sig
= new(mem_ctx
)
397 ir_function_signature(glsl_type::void_type
, shader_storage_buffer_object
);
399 sig
->replace_parameters(&sig_params
);
400 sig
->is_intrinsic
= true;
402 ir_function
*f
= new(mem_ctx
) ir_function("__intrinsic_store_ssbo");
403 f
->add_signature(sig
);
405 exec_list call_params
;
406 call_params
.push_tail(this->uniform_block
->clone(mem_ctx
, NULL
));
407 call_params
.push_tail(offset
->clone(mem_ctx
, NULL
));
408 call_params
.push_tail(deref
->clone(mem_ctx
, NULL
));
409 call_params
.push_tail(new(mem_ctx
) ir_constant(write_mask
));
410 return new(mem_ctx
) ir_call(sig
, NULL
, &call_params
);
414 lower_ubo_reference_visitor::ssbo_load(const struct glsl_type
*type
,
417 exec_list sig_params
;
419 ir_variable
*block_ref
= new(mem_ctx
)
420 ir_variable(glsl_type::uint_type
, "block_ref" , ir_var_function_in
);
421 sig_params
.push_tail(block_ref
);
423 ir_variable
*offset_ref
= new(mem_ctx
)
424 ir_variable(glsl_type::uint_type
, "offset_ref" , ir_var_function_in
);
425 sig_params
.push_tail(offset_ref
);
427 ir_function_signature
*sig
=
428 new(mem_ctx
) ir_function_signature(type
, shader_storage_buffer_object
);
430 sig
->replace_parameters(&sig_params
);
431 sig
->is_intrinsic
= true;
433 ir_function
*f
= new(mem_ctx
) ir_function("__intrinsic_load_ssbo");
434 f
->add_signature(sig
);
436 ir_variable
*result
= new(mem_ctx
)
437 ir_variable(type
, "ssbo_load_result", ir_var_temporary
);
438 base_ir
->insert_before(result
);
439 ir_dereference_variable
*deref_result
= new(mem_ctx
)
440 ir_dereference_variable(result
);
442 exec_list call_params
;
443 call_params
.push_tail(this->uniform_block
->clone(mem_ctx
, NULL
));
444 call_params
.push_tail(offset
->clone(mem_ctx
, NULL
));
446 return new(mem_ctx
) ir_call(sig
, deref_result
, &call_params
);
450 lower_ubo_reference_visitor::insert_buffer_access(void *mem_ctx
,
451 ir_dereference
*deref
,
452 const glsl_type
*type
,
457 switch (this->buffer_access_type
) {
458 case ubo_load_access
:
459 base_ir
->insert_before(assign(deref
->clone(mem_ctx
, NULL
),
460 ubo_load(type
, offset
),
463 case ssbo_load_access
: {
464 ir_call
*load_ssbo
= ssbo_load(type
, offset
);
465 base_ir
->insert_before(load_ssbo
);
466 ir_rvalue
*value
= load_ssbo
->return_deref
->as_rvalue()->clone(mem_ctx
, NULL
);
467 ir_assignment
*assignment
=
468 assign(deref
->clone(mem_ctx
, NULL
), value
, mask
);
469 base_ir
->insert_before(assignment
);
472 case ssbo_store_access
:
474 base_ir
->insert_after(ssbo_store(swizzle(deref
, channel
, 1),
477 base_ir
->insert_after(ssbo_store(deref
, offset
, mask
));
481 unreachable("invalid buffer_access_type in insert_buffer_access");
486 lower_ubo_reference_visitor::write_to_memory(ir_dereference
*deref
,
488 ir_variable
*write_var
,
491 ir_rvalue
*offset
= NULL
;
492 unsigned const_offset
;
495 unsigned packing
= var
->get_interface_type()->interface_packing
;
497 this->buffer_access_type
= ssbo_store_access
;
499 /* Compute the offset to the start if the dereference as well as other
500 * information we need to configure the write
502 setup_for_load_or_store(var
, deref
,
503 &offset
, &const_offset
,
504 &row_major
, &matrix_columns
,
508 /* Now emit writes from the temporary to memory */
509 ir_variable
*write_offset
=
510 new(mem_ctx
) ir_variable(glsl_type::uint_type
,
511 "ssbo_store_temp_offset",
514 base_ir
->insert_before(write_offset
);
515 base_ir
->insert_before(assign(write_offset
, offset
));
517 deref
= new(mem_ctx
) ir_dereference_variable(write_var
);
518 emit_access(mem_ctx
, true, deref
, write_offset
, const_offset
,
519 row_major
, matrix_columns
, packing
, write_mask
);
523 lower_ubo_reference_visitor::visit_enter(ir_expression
*ir
)
525 check_ssbo_unsized_array_length_expression(ir
);
526 return rvalue_visit(ir
);
530 lower_ubo_reference_visitor::calculate_ssbo_unsized_array_length(ir_expression
*expr
)
532 if (expr
->operation
!=
533 ir_expression_operation(ir_unop_ssbo_unsized_array_length
))
536 ir_rvalue
*rvalue
= expr
->operands
[0]->as_rvalue();
538 !rvalue
->type
->is_array() || !rvalue
->type
->is_unsized_array())
541 ir_dereference
*deref
= expr
->operands
[0]->as_dereference();
545 ir_variable
*var
= expr
->operands
[0]->variable_referenced();
546 if (!var
|| !var
->is_in_shader_storage_block())
548 return process_ssbo_unsized_array_length(&rvalue
, deref
, var
);
552 lower_ubo_reference_visitor::check_ssbo_unsized_array_length_expression(ir_expression
*ir
)
555 ir_expression_operation(ir_unop_ssbo_unsized_array_length
)) {
556 /* Don't replace this unop if it is found alone. It is going to be
557 * removed by the optimization passes or replaced if it is part of
558 * an ir_assignment or another ir_expression.
563 for (unsigned i
= 0; i
< ir
->get_num_operands(); i
++) {
564 if (ir
->operands
[i
]->ir_type
!= ir_type_expression
)
566 ir_expression
*expr
= (ir_expression
*) ir
->operands
[i
];
567 ir_expression
*temp
= calculate_ssbo_unsized_array_length(expr
);
572 ir
->operands
[i
] = temp
;
577 lower_ubo_reference_visitor::check_ssbo_unsized_array_length_assignment(ir_assignment
*ir
)
579 if (!ir
->rhs
|| ir
->rhs
->ir_type
!= ir_type_expression
)
582 ir_expression
*expr
= (ir_expression
*) ir
->rhs
;
583 ir_expression
*temp
= calculate_ssbo_unsized_array_length(expr
);
593 lower_ubo_reference_visitor::emit_ssbo_get_buffer_size()
595 ir_rvalue
*block_ref
= this->uniform_block
->clone(mem_ctx
, NULL
);
596 return new(mem_ctx
) ir_expression(ir_unop_get_buffer_size
,
602 lower_ubo_reference_visitor::calculate_unsized_array_stride(ir_dereference
*deref
,
605 unsigned array_stride
= 0;
607 switch (deref
->ir_type
) {
608 case ir_type_dereference_variable
:
610 ir_dereference_variable
*deref_var
= (ir_dereference_variable
*)deref
;
611 const struct glsl_type
*unsized_array_type
= NULL
;
612 /* An unsized array can be sized by other lowering passes, so pick
613 * the first field of the array which has the data type of the unsized
616 unsized_array_type
= deref_var
->var
->type
->fields
.array
;
618 /* Whether or not the field is row-major (because it might be a
619 * bvec2 or something) does not affect the array itself. We need
620 * to know whether an array element in its entirety is row-major.
622 const bool array_row_major
=
623 is_dereferenced_thing_row_major(deref_var
);
625 if (packing
== GLSL_INTERFACE_PACKING_STD430
) {
626 array_stride
= unsized_array_type
->std430_array_stride(array_row_major
);
628 array_stride
= unsized_array_type
->std140_size(array_row_major
);
629 array_stride
= glsl_align(array_stride
, 16);
633 case ir_type_dereference_record
:
635 ir_dereference_record
*deref_record
= (ir_dereference_record
*) deref
;
636 ir_dereference
*interface_deref
=
637 deref_record
->record
->as_dereference();
638 assert(interface_deref
!= NULL
);
639 const struct glsl_type
*interface_type
= interface_deref
->type
;
640 unsigned record_length
= interface_type
->length
;
641 /* Unsized array is always the last element of the interface */
642 const struct glsl_type
*unsized_array_type
=
643 interface_type
->fields
.structure
[record_length
- 1].type
->fields
.array
;
645 const bool array_row_major
=
646 is_dereferenced_thing_row_major(deref_record
);
648 if (packing
== GLSL_INTERFACE_PACKING_STD430
) {
649 array_stride
= unsized_array_type
->std430_array_stride(array_row_major
);
651 array_stride
= unsized_array_type
->std140_size(array_row_major
);
652 array_stride
= glsl_align(array_stride
, 16);
657 unreachable("Unsupported dereference type");
663 lower_ubo_reference_visitor::process_ssbo_unsized_array_length(ir_rvalue
**rvalue
,
664 ir_dereference
*deref
,
667 mem_ctx
= ralloc_parent(*rvalue
);
669 ir_rvalue
*base_offset
= NULL
;
670 unsigned const_offset
;
673 unsigned packing
= var
->get_interface_type()->interface_packing
;
674 int unsized_array_stride
= calculate_unsized_array_stride(deref
, packing
);
676 this->buffer_access_type
= ssbo_unsized_array_length_access
;
678 /* Compute the offset to the start if the dereference as well as other
679 * information we need to calculate the length.
681 setup_for_load_or_store(var
, deref
,
682 &base_offset
, &const_offset
,
683 &row_major
, &matrix_columns
,
686 * max((buffer_object_size - offset_of_array) / stride_of_array, 0)
688 ir_expression
*buffer_size
= emit_ssbo_get_buffer_size();
690 ir_expression
*offset_of_array
= new(mem_ctx
)
691 ir_expression(ir_binop_add
, base_offset
,
692 new(mem_ctx
) ir_constant(const_offset
));
693 ir_expression
*offset_of_array_int
= new(mem_ctx
)
694 ir_expression(ir_unop_u2i
, offset_of_array
);
696 ir_expression
*sub
= new(mem_ctx
)
697 ir_expression(ir_binop_sub
, buffer_size
, offset_of_array_int
);
698 ir_expression
*div
= new(mem_ctx
)
699 ir_expression(ir_binop_div
, sub
,
700 new(mem_ctx
) ir_constant(unsized_array_stride
));
701 ir_expression
*max
= new(mem_ctx
)
702 ir_expression(ir_binop_max
, div
, new(mem_ctx
) ir_constant(0));
708 lower_ubo_reference_visitor::check_for_ssbo_store(ir_assignment
*ir
)
713 ir_rvalue
*rvalue
= ir
->lhs
->as_rvalue();
717 ir_dereference
*deref
= ir
->lhs
->as_dereference();
721 ir_variable
*var
= ir
->lhs
->variable_referenced();
722 if (!var
|| !var
->is_in_buffer_block())
725 /* We have a write to a buffer variable, so declare a temporary and rewrite
726 * the assignment so that the temporary is the LHS.
728 mem_ctx
= ralloc_parent(shader
->ir
);
730 const glsl_type
*type
= rvalue
->type
;
731 ir_variable
*write_var
= new(mem_ctx
) ir_variable(type
,
734 base_ir
->insert_before(write_var
);
735 ir
->lhs
= new(mem_ctx
) ir_dereference_variable(write_var
);
737 /* Now we have to write the value assigned to the temporary back to memory */
738 write_to_memory(deref
, var
, write_var
, ir
->write_mask
);
743 is_buffer_backed_variable(ir_variable
*var
)
745 return var
->is_in_buffer_block() ||
746 var
->data
.mode
== ir_var_shader_shared
;
750 lower_ubo_reference_visitor::check_for_buffer_array_copy(ir_assignment
*ir
)
752 if (!ir
|| !ir
->lhs
|| !ir
->rhs
)
755 /* LHS and RHS must be arrays
756 * FIXME: arrays of arrays?
758 if (!ir
->lhs
->type
->is_array() || !ir
->rhs
->type
->is_array())
761 /* RHS must be a buffer-backed variable. This is what can cause the problem
762 * since it would lead to a series of loads that need to live until we
763 * see the writes to the LHS.
765 ir_variable
*rhs_var
= ir
->rhs
->variable_referenced();
766 if (!rhs_var
|| !is_buffer_backed_variable(rhs_var
))
769 /* Split the array copy into individual element copies to reduce
772 ir_dereference
*rhs_deref
= ir
->rhs
->as_dereference();
776 ir_dereference
*lhs_deref
= ir
->lhs
->as_dereference();
780 assert(lhs_deref
->type
->length
== rhs_deref
->type
->length
);
781 mem_ctx
= ralloc_parent(shader
->ir
);
783 for (unsigned i
= 0; i
< lhs_deref
->type
->length
; i
++) {
784 ir_dereference
*lhs_i
=
785 new(mem_ctx
) ir_dereference_array(lhs_deref
->clone(mem_ctx
, NULL
),
786 new(mem_ctx
) ir_constant(i
));
788 ir_dereference
*rhs_i
=
789 new(mem_ctx
) ir_dereference_array(rhs_deref
->clone(mem_ctx
, NULL
),
790 new(mem_ctx
) ir_constant(i
));
791 ir
->insert_after(assign(lhs_i
, rhs_i
));
800 lower_ubo_reference_visitor::check_for_buffer_struct_copy(ir_assignment
*ir
)
802 if (!ir
|| !ir
->lhs
|| !ir
->rhs
)
805 /* LHS and RHS must be records */
806 if (!ir
->lhs
->type
->is_record() || !ir
->rhs
->type
->is_record())
809 /* RHS must be a buffer-backed variable. This is what can cause the problem
810 * since it would lead to a series of loads that need to live until we
811 * see the writes to the LHS.
813 ir_variable
*rhs_var
= ir
->rhs
->variable_referenced();
814 if (!rhs_var
|| !is_buffer_backed_variable(rhs_var
))
817 /* Split the struct copy into individual element copies to reduce
820 ir_dereference
*rhs_deref
= ir
->rhs
->as_dereference();
824 ir_dereference
*lhs_deref
= ir
->lhs
->as_dereference();
828 assert(lhs_deref
->type
->record_compare(rhs_deref
->type
));
829 mem_ctx
= ralloc_parent(shader
->ir
);
831 for (unsigned i
= 0; i
< lhs_deref
->type
->length
; i
++) {
832 const char *field_name
= lhs_deref
->type
->fields
.structure
[i
].name
;
833 ir_dereference
*lhs_field
=
834 new(mem_ctx
) ir_dereference_record(lhs_deref
->clone(mem_ctx
, NULL
),
836 ir_dereference
*rhs_field
=
837 new(mem_ctx
) ir_dereference_record(rhs_deref
->clone(mem_ctx
, NULL
),
839 ir
->insert_after(assign(lhs_field
, rhs_field
));
848 lower_ubo_reference_visitor::visit_enter(ir_assignment
*ir
)
850 /* Array and struct copies could involve large amounts of load/store
851 * operations. To improve register pressure we want to special-case
852 * these and split them into individual element copies.
853 * This way we avoid emitting all the loads for the RHS first and
854 * all the writes for the LHS second and register usage is more
857 if (check_for_buffer_array_copy(ir
))
858 return visit_continue_with_parent
;
860 if (check_for_buffer_struct_copy(ir
))
861 return visit_continue_with_parent
;
863 check_ssbo_unsized_array_length_assignment(ir
);
864 check_for_ssbo_store(ir
);
865 return rvalue_visit(ir
);
868 /* Lowers the intrinsic call to a new internal intrinsic that swaps the
869 * access to the buffer variable in the first parameter by an offset
870 * and block index. This involves creating the new internal intrinsic
871 * (i.e. the new function signature).
874 lower_ubo_reference_visitor::lower_ssbo_atomic_intrinsic(ir_call
*ir
)
876 /* SSBO atomics usually have 2 parameters, the buffer variable and an
877 * integer argument. The exception is CompSwap, that has an additional
880 int param_count
= ir
->actual_parameters
.length();
881 assert(param_count
== 2 || param_count
== 3);
883 /* First argument must be a scalar integer buffer variable */
884 exec_node
*param
= ir
->actual_parameters
.get_head();
885 ir_instruction
*inst
= (ir_instruction
*) param
;
886 assert(inst
->ir_type
== ir_type_dereference_variable
||
887 inst
->ir_type
== ir_type_dereference_array
||
888 inst
->ir_type
== ir_type_dereference_record
||
889 inst
->ir_type
== ir_type_swizzle
);
891 ir_rvalue
*deref
= (ir_rvalue
*) inst
;
892 assert(deref
->type
->is_scalar() && deref
->type
->is_integer());
894 ir_variable
*var
= deref
->variable_referenced();
897 /* Compute the offset to the start if the dereference and the
900 mem_ctx
= ralloc_parent(shader
->ir
);
902 ir_rvalue
*offset
= NULL
;
903 unsigned const_offset
;
906 unsigned packing
= var
->get_interface_type()->interface_packing
;
908 this->buffer_access_type
= ssbo_atomic_access
;
910 setup_for_load_or_store(var
, deref
,
911 &offset
, &const_offset
,
912 &row_major
, &matrix_columns
,
916 assert(matrix_columns
== 1);
918 ir_rvalue
*deref_offset
=
919 add(offset
, new(mem_ctx
) ir_constant(const_offset
));
920 ir_rvalue
*block_index
= this->uniform_block
->clone(mem_ctx
, NULL
);
922 /* Create the new internal function signature that will take a block
923 * index and offset instead of a buffer variable
925 exec_list sig_params
;
926 ir_variable
*sig_param
= new(mem_ctx
)
927 ir_variable(glsl_type::uint_type
, "block_ref" , ir_var_function_in
);
928 sig_params
.push_tail(sig_param
);
930 sig_param
= new(mem_ctx
)
931 ir_variable(glsl_type::uint_type
, "offset" , ir_var_function_in
);
932 sig_params
.push_tail(sig_param
);
934 const glsl_type
*type
= deref
->type
->base_type
== GLSL_TYPE_INT
?
935 glsl_type::int_type
: glsl_type::uint_type
;
936 sig_param
= new(mem_ctx
)
937 ir_variable(type
, "data1", ir_var_function_in
);
938 sig_params
.push_tail(sig_param
);
940 if (param_count
== 3) {
941 sig_param
= new(mem_ctx
)
942 ir_variable(type
, "data2", ir_var_function_in
);
943 sig_params
.push_tail(sig_param
);
946 ir_function_signature
*sig
=
947 new(mem_ctx
) ir_function_signature(deref
->type
,
948 shader_storage_buffer_object
);
950 sig
->replace_parameters(&sig_params
);
951 sig
->is_intrinsic
= true;
954 sprintf(func_name
, "%s_internal", ir
->callee_name());
955 ir_function
*f
= new(mem_ctx
) ir_function(func_name
);
956 f
->add_signature(sig
);
958 /* Now, create the call to the internal intrinsic */
959 exec_list call_params
;
960 call_params
.push_tail(block_index
);
961 call_params
.push_tail(deref_offset
);
962 param
= ir
->actual_parameters
.get_head()->get_next();
963 ir_rvalue
*param_as_rvalue
= ((ir_instruction
*) param
)->as_rvalue();
964 call_params
.push_tail(param_as_rvalue
->clone(mem_ctx
, NULL
));
965 if (param_count
== 3) {
966 param
= param
->get_next();
967 param_as_rvalue
= ((ir_instruction
*) param
)->as_rvalue();
968 call_params
.push_tail(param_as_rvalue
->clone(mem_ctx
, NULL
));
970 ir_dereference_variable
*return_deref
=
971 ir
->return_deref
->clone(mem_ctx
, NULL
);
972 return new(mem_ctx
) ir_call(sig
, return_deref
, &call_params
);
976 lower_ubo_reference_visitor::check_for_ssbo_atomic_intrinsic(ir_call
*ir
)
978 const char *callee
= ir
->callee_name();
979 if (!strcmp("__intrinsic_ssbo_atomic_add", callee
) ||
980 !strcmp("__intrinsic_ssbo_atomic_min", callee
) ||
981 !strcmp("__intrinsic_ssbo_atomic_max", callee
) ||
982 !strcmp("__intrinsic_ssbo_atomic_and", callee
) ||
983 !strcmp("__intrinsic_ssbo_atomic_or", callee
) ||
984 !strcmp("__intrinsic_ssbo_atomic_xor", callee
) ||
985 !strcmp("__intrinsic_ssbo_atomic_exchange", callee
) ||
986 !strcmp("__intrinsic_ssbo_atomic_comp_swap", callee
)) {
987 return lower_ssbo_atomic_intrinsic(ir
);
995 lower_ubo_reference_visitor::visit_enter(ir_call
*ir
)
997 ir_call
*new_ir
= check_for_ssbo_atomic_intrinsic(ir
);
1000 base_ir
->replace_with(new_ir
);
1001 return visit_continue_with_parent
;
1004 return rvalue_visit(ir
);
1008 } /* unnamed namespace */
1011 lower_ubo_reference(struct gl_shader
*shader
)
1013 lower_ubo_reference_visitor
v(shader
);
1015 /* Loop over the instructions lowering references, because we take
1016 * a deref of a UBO array using a UBO dereference as the index will
1017 * produce a collection of instructions all of which have cloned
1018 * UBO dereferences for that array index.
1022 visit_list_elements(&v
, shader
->ir
);
1023 } while (v
.progress
);