src/glsl/nir/nir_validate.c

   1 /*
   2  * Copyright © 2014 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *    Connor Abbott (cwabbott0@gmail.com)
  25  *
  26  */
  27
  28 #include "nir.h"
  29 #include <assert.h>
  30
  31 /*
  32  * This file checks for invalid IR indicating a bug somewhere in the compiler.
  33  */
  34
  35 /*
  36  * Per-register validation state.
  37  */
  38
  39 typedef struct {
  40    /*
  41     * equivalent to the uses and defs in nir_register, but built up by the
  42     * validator. At the end, we verify that the sets have the same entries.
  43     */
  44    struct set *uses, *defs;
  45    nir_function_impl *where_defined; /* NULL for global registers */
  46 } reg_validate_state;
  47
  48 typedef struct {
  49    /* map of register -> validation state (struct above) */
  50    struct hash_table *regs;
  51
  52    /* the current shader being validated */
  53    nir_shader *shader;
  54
  55    /* the current instruction being validated */
  56    nir_instr *instr;
  57
  58    /* the current basic block being validated */
  59    nir_block *block;
  60
  61    /* the current if statement being validated */
  62    nir_if *if_stmt;
  63
  64    /* the parent of the current cf node being visited */
  65    nir_cf_node *parent_node;
  66
  67    /* the current function implementation being validated */
  68    nir_function_impl *impl;
  69
  70    /* map of SSA value -> function implementation where it is defined */
  71    struct hash_table *ssa_defs;
  72
  73    /* bitset of ssa definitions we have found; used to check uniqueness */
  74    BITSET_WORD *ssa_defs_found;
  75
  76    /* bitset of registers we have currently found; used to check uniqueness */
  77    BITSET_WORD *regs_found;
  78
  79    /* map of local variable -> function implementation where it is defined */
  80    struct hash_table *var_defs;
  81 } validate_state;
  82
  83 static void validate_src(nir_src *src, validate_state *state);
  84
  85 static void
  86 validate_reg_src(nir_reg_src *src, validate_state *state)
  87 {
  88    assert(src->reg != NULL);
  89
  90    struct set_entry *entry =
  91       _mesa_set_search(src->reg->uses, _mesa_hash_pointer(state->instr),
  92                        state->instr);
  93    assert(entry && "use not in nir_register.uses");
  94
  95    struct hash_entry *entry2;
  96    entry2 = _mesa_hash_table_search(state->regs, src->reg);
  97
  98    assert(entry2);
  99
 100    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 101    _mesa_set_add(reg_state->uses, _mesa_hash_pointer(state->instr),
 102                  state->instr);
 103
 104    if (!src->reg->is_global) {
 105       assert(reg_state->where_defined == state->impl &&
 106              "using a register declared in a different function");
 107    }
 108
 109    assert((src->reg->num_array_elems == 0 ||
 110           src->base_offset < src->reg->num_array_elems) &&
 111           "definitely out-of-bounds array access");
 112
 113    if (src->indirect) {
 114       assert(src->reg->num_array_elems != 0);
 115       assert((src->indirect->is_ssa || src->indirect->reg.indirect == NULL) &&
 116              "only one level of indirection allowed");
 117       validate_src(src->indirect, state);
 118    }
 119 }
 120
 121 static void
 122 validate_ssa_src(nir_ssa_def *def, validate_state *state)
 123 {
 124    assert(def != NULL);
 125
 126    struct hash_entry *entry = _mesa_hash_table_search(state->ssa_defs, def);
 127
 128    assert(entry);
 129
 130    assert((nir_function_impl *) entry->data == state->impl &&
 131           "using an SSA value defined in a different function");
 132
 133    struct set_entry *entry2;
 134
 135    entry2 = _mesa_set_search(def->uses, _mesa_hash_pointer(state->instr),
 136                               state->instr);
 137
 138    assert(entry2 && "SSA use missing");
 139
 140    /* TODO validate that the use is dominated by the definition */
 141 }
 142
 143 static void
 144 validate_src(nir_src *src, validate_state *state)
 145 {
 146    if (src->is_ssa)
 147       validate_ssa_src(src->ssa, state);
 148    else
 149       validate_reg_src(&src->reg, state);
 150 }
 151
 152 static void
 153 validate_alu_src(nir_alu_instr *instr, unsigned index, validate_state *state)
 154 {
 155    nir_alu_src *src = &instr->src[index];
 156
 157    unsigned num_components;
 158    if (src->src.is_ssa)
 159       num_components = src->src.ssa->num_components;
 160    else {
 161       if (src->src.reg.reg->is_packed)
 162          num_components = 4; /* can't check anything */
 163       else
 164          num_components = src->src.reg.reg->num_components;
 165    }
 166    for (unsigned i = 0; i < 4; i++) {
 167       assert(src->swizzle[i] < 4);
 168
 169       if (nir_alu_instr_channel_used(instr, index, i))
 170          assert(src->swizzle[i] < num_components);
 171    }
 172
 173    validate_src(&src->src, state);
 174 }
 175
 176 static void
 177 validate_reg_dest(nir_reg_dest *dest, validate_state *state)
 178 {
 179    assert(dest->reg != NULL);
 180
 181    struct set_entry *entry =
 182       _mesa_set_search(dest->reg->defs, _mesa_hash_pointer(state->instr),
 183                        state->instr);
 184    assert(entry && "definition not in nir_register.defs");
 185
 186    struct hash_entry *entry2;
 187    entry2 = _mesa_hash_table_search(state->regs, dest->reg);
 188
 189    assert(entry2);
 190
 191    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 192    _mesa_set_add(reg_state->defs, _mesa_hash_pointer(state->instr),
 193                  state->instr);
 194
 195    if (!dest->reg->is_global) {
 196       assert(reg_state->where_defined == state->impl &&
 197              "writing to a register declared in a different function");
 198    }
 199
 200    assert((dest->reg->num_array_elems == 0 ||
 201           dest->base_offset < dest->reg->num_array_elems) &&
 202           "definitely out-of-bounds array access");
 203
 204    if (dest->indirect) {
 205       assert(dest->reg->num_array_elems != 0);
 206       assert((dest->indirect->is_ssa || dest->indirect->reg.indirect == NULL) &&
 207              "only one level of indirection allowed");
 208       validate_src(dest->indirect, state);
 209    }
 210 }
 211
 212 static void
 213 validate_ssa_def(nir_ssa_def *def, validate_state *state)
 214 {
 215    assert(def->index < state->impl->ssa_alloc);
 216    assert(!BITSET_TEST(state->ssa_defs_found, def->index));
 217    BITSET_SET(state->ssa_defs_found, def->index);
 218
 219    assert(def->num_components <= 4);
 220    _mesa_hash_table_insert(state->ssa_defs, def, state->impl);
 221 }
 222
 223 static void
 224 validate_dest(nir_dest *dest, validate_state *state)
 225 {
 226    if (dest->is_ssa)
 227       validate_ssa_def(&dest->ssa, state);
 228    else
 229       validate_reg_dest(&dest->reg, state);
 230 }
 231
 232 static void
 233 validate_alu_dest(nir_alu_dest *dest, validate_state *state)
 234 {
 235    unsigned dest_size =
 236       dest->dest.is_ssa ? dest->dest.ssa.num_components
 237                         : dest->dest.reg.reg->num_components;
 238    bool is_packed = !dest->dest.is_ssa && dest->dest.reg.reg->is_packed;
 239    /*
 240     * validate that the instruction doesn't write to components not in the
 241     * register/SSA value
 242     */
 243    assert(is_packed || !(dest->write_mask & ~((1 << dest_size) - 1)));
 244    validate_dest(&dest->dest, state);
 245 }
 246
 247 static void
 248 validate_alu_instr(nir_alu_instr *instr, validate_state *state)
 249 {
 250    assert(instr->op < nir_num_opcodes);
 251
 252    validate_alu_dest(&instr->dest, state);
 253
 254    for (unsigned i = 0; i < nir_op_infos[instr->op].num_inputs; i++) {
 255       validate_alu_src(instr, i, state);
 256    }
 257
 258    if (instr->has_predicate)
 259       validate_src(&instr->predicate, state);
 260 }
 261
 262 static void
 263 validate_deref_chain(nir_deref *deref, validate_state *state)
 264 {
 265    nir_deref *parent = NULL;
 266    while (deref != NULL) {
 267       switch (deref->deref_type) {
 268       case nir_deref_type_array:
 269          assert(deref->type == glsl_get_array_element(parent->type));
 270          if (nir_deref_as_array(deref)->deref_array_type ==
 271              nir_deref_array_type_indirect)
 272             validate_src(&nir_deref_as_array(deref)->indirect, state);
 273          break;
 274
 275       case nir_deref_type_struct:
 276          assert(deref->type ==
 277                 glsl_get_struct_field(parent->type,
 278                                       nir_deref_as_struct(deref)->index));
 279          break;
 280
 281       case nir_deref_type_var:
 282          break;
 283
 284       default:
 285          assert(!"Invalid deref type");
 286          break;
 287       }
 288
 289       parent = deref;
 290       deref = deref->child;
 291    }
 292 }
 293
 294 static void
 295 validate_var_use(nir_variable *var, validate_state *state)
 296 {
 297    if (var->data.mode == nir_var_local) {
 298       struct hash_entry *entry = _mesa_hash_table_search(state->var_defs, var);
 299
 300       assert(entry);
 301       assert((nir_function_impl *) entry->data == state->impl);
 302    }
 303 }
 304
 305 static void
 306 validate_deref_var(nir_deref_var *deref, validate_state *state)
 307 {
 308    assert(deref != NULL);
 309    assert(deref->deref.type == deref->var->type);
 310
 311    validate_var_use(deref->var, state);
 312
 313    validate_deref_chain(&deref->deref, state);
 314 }
 315
 316 static void
 317 validate_intrinsic_instr(nir_intrinsic_instr *instr, validate_state *state)
 318 {
 319    unsigned num_srcs = nir_intrinsic_infos[instr->intrinsic].num_srcs;
 320    for (unsigned i = 0; i < num_srcs; i++) {
 321       validate_src(&instr->src[i], state);
 322    }
 323
 324    if (nir_intrinsic_infos[instr->intrinsic].has_dest) {
 325       validate_dest(&instr->dest, state);
 326    }
 327
 328    unsigned num_vars = nir_intrinsic_infos[instr->intrinsic].num_variables;
 329    for (unsigned i = 0; i < num_vars; i++) {
 330       validate_deref_var(instr->variables[i], state);
 331    }
 332
 333    switch (instr->intrinsic) {
 334    case nir_intrinsic_load_var_vec1:
 335    case nir_intrinsic_load_var_vec2:
 336    case nir_intrinsic_load_var_vec3:
 337    case nir_intrinsic_load_var_vec4:
 338       assert(instr->variables[0]->var->data.mode != nir_var_shader_out);
 339       break;
 340    case nir_intrinsic_store_var_vec1:
 341    case nir_intrinsic_store_var_vec2:
 342    case nir_intrinsic_store_var_vec3:
 343    case nir_intrinsic_store_var_vec4:
 344       assert(instr->variables[0]->var->data.mode != nir_var_shader_in &&
 345              instr->variables[0]->var->data.mode != nir_var_uniform);
 346       break;
 347    case nir_intrinsic_copy_var:
 348       assert(instr->variables[0]->var->data.mode != nir_var_shader_in &&
 349              instr->variables[0]->var->data.mode != nir_var_uniform);
 350       assert(instr->variables[1]->var->data.mode != nir_var_shader_out);
 351       break;
 352    default:
 353       break;
 354    }
 355
 356    if (instr->has_predicate)
 357       validate_src(&instr->predicate, state);
 358 }
 359
 360 static void
 361 validate_tex_instr(nir_tex_instr *instr, validate_state *state)
 362 {
 363    validate_dest(&instr->dest, state);
 364
 365    bool src_type_seen[nir_num_texinput_types];
 366    for (unsigned i = 0; i < nir_num_texinput_types; i++)
 367       src_type_seen[i] = false;
 368
 369    for (unsigned i = 0; i < instr->num_srcs; i++) {
 370       assert(!src_type_seen[instr->src_type[i]]);
 371       src_type_seen[instr->src_type[i]] = true;
 372       validate_src(&instr->src[i], state);
 373    }
 374
 375    if (instr->sampler != NULL)
 376       validate_deref_var(instr->sampler, state);
 377 }
 378
 379 static void
 380 validate_call_instr(nir_call_instr *instr, validate_state *state)
 381 {
 382    if (instr->return_deref == NULL)
 383       assert(glsl_type_is_void(instr->callee->return_type));
 384    else
 385       assert(instr->return_deref->deref.type == instr->callee->return_type);
 386
 387    assert(instr->num_params == instr->callee->num_params);
 388
 389    for (unsigned i = 0; i < instr->num_params; i++) {
 390       assert(instr->callee->params[i].type == instr->params[i]->deref.type);
 391       validate_deref_var(instr->params[i], state);
 392    }
 393
 394    validate_deref_var(instr->return_deref, state);
 395
 396    if (instr->has_predicate)
 397       validate_src(&instr->predicate, state);
 398 }
 399
 400 static void
 401 validate_load_const_instr(nir_load_const_instr *instr, validate_state *state)
 402 {
 403    validate_dest(&instr->dest, state);
 404
 405    if (instr->array_elems != 0) {
 406       assert(!instr->dest.is_ssa);
 407       assert(instr->dest.reg.base_offset + instr->array_elems <=
 408              instr->dest.reg.reg->num_array_elems);
 409    }
 410
 411    if (instr->has_predicate)
 412       validate_src(&instr->predicate, state);
 413 }
 414
 415 static void
 416 validate_ssa_undef_instr(nir_ssa_undef_instr *instr, validate_state *state)
 417 {
 418    validate_ssa_def(&instr->def, state);
 419 }
 420
 421 static void
 422 validate_phi_instr(nir_phi_instr *instr, validate_state *state)
 423 {
 424    /*
 425     * don't validate the sources until we get to them from their predecessor
 426     * basic blocks, to avoid validating an SSA use before its definition.
 427     */
 428
 429    validate_dest(&instr->dest, state);
 430
 431    exec_list_validate(&instr->srcs);
 432    assert(exec_list_length(&instr->srcs) ==
 433           state->block->predecessors->entries);
 434 }
 435
 436 static void
 437 validate_instr(nir_instr *instr, validate_state *state)
 438 {
 439    assert(instr->block == state->block);
 440
 441    state->instr = instr;
 442
 443    switch (instr->type) {
 444    case nir_instr_type_alu:
 445       validate_alu_instr(nir_instr_as_alu(instr), state);
 446       break;
 447
 448    case nir_instr_type_call:
 449       validate_call_instr(nir_instr_as_call(instr), state);
 450       break;
 451
 452    case nir_instr_type_intrinsic:
 453       validate_intrinsic_instr(nir_instr_as_intrinsic(instr), state);
 454       break;
 455
 456    case nir_instr_type_texture:
 457       validate_tex_instr(nir_instr_as_texture(instr), state);
 458       break;
 459
 460    case nir_instr_type_load_const:
 461       validate_load_const_instr(nir_instr_as_load_const(instr), state);
 462       break;
 463
 464    case nir_instr_type_phi:
 465       validate_phi_instr(nir_instr_as_phi(instr), state);
 466       break;
 467
 468    case nir_instr_type_ssa_undef:
 469       validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr), state);
 470       break;
 471
 472    case nir_instr_type_jump:
 473       break;
 474
 475    default:
 476       assert(!"Invalid ALU instruction type");
 477       break;
 478    }
 479 }
 480
 481 static void
 482 validate_phi_src(nir_phi_instr *instr, nir_block *pred, validate_state *state)
 483 {
 484    state->instr = &instr->instr;
 485
 486    assert(instr->dest.is_ssa);
 487
 488    exec_list_validate(&instr->srcs);
 489    foreach_list_typed(nir_phi_src, src, node, &instr->srcs) {
 490       if (src->pred == pred) {
 491          unsigned num_components;
 492          if (src->src.is_ssa)
 493             num_components = src->src.ssa->num_components;
 494          else {
 495             if (src->src.reg.reg->is_packed)
 496                num_components = 4; /* can't check anything */
 497             else
 498                num_components = src->src.reg.reg->num_components;
 499          }
 500          assert(num_components == instr->dest.ssa.num_components);
 501
 502          validate_src(&src->src, state);
 503          return;
 504       }
 505    }
 506
 507    abort();
 508 }
 509
 510 static void
 511 validate_phi_srcs(nir_block *block, nir_block *succ, validate_state *state)
 512 {
 513    nir_foreach_instr(succ, instr) {
 514       if (instr->type != nir_instr_type_phi)
 515          break;
 516
 517       validate_phi_src(nir_instr_as_phi(instr), block, state);
 518    }
 519 }
 520
 521 static void validate_cf_node(nir_cf_node *node, validate_state *state);
 522
 523 static void
 524 validate_block(nir_block *block, validate_state *state)
 525 {
 526    assert(block->cf_node.parent == state->parent_node);
 527
 528    state->block = block;
 529
 530    exec_list_validate(&block->instr_list);
 531    nir_foreach_instr(block, instr) {
 532       if (instr->type == nir_instr_type_phi) {
 533          assert(instr == nir_block_first_instr(block) ||
 534                 nir_instr_prev(instr)->type == nir_instr_type_phi);
 535       }
 536
 537       if (instr->type == nir_instr_type_jump) {
 538          assert(instr == nir_block_last_instr(block));
 539       }
 540
 541       validate_instr(instr, state);
 542    }
 543
 544    assert(block->successors[0] != NULL);
 545
 546    for (unsigned i = 0; i < 2; i++) {
 547       if (block->successors[i] != NULL) {
 548          struct set_entry *entry =
 549             _mesa_set_search(block->successors[i]->predecessors,
 550                              _mesa_hash_pointer(block), block);
 551          assert(entry);
 552
 553          validate_phi_srcs(block, block->successors[i], state);
 554       }
 555    }
 556
 557    if (!exec_list_is_empty(&block->instr_list) &&
 558        nir_block_last_instr(block)->type == nir_instr_type_jump)
 559       assert(block->successors[1] == NULL);
 560 }
 561
 562 static void
 563 validate_if(nir_if *if_stmt, validate_state *state)
 564 {
 565    assert(!exec_node_is_head_sentinel(if_stmt->cf_node.node.prev));
 566    nir_cf_node *prev_node = nir_cf_node_prev(&if_stmt->cf_node);
 567    assert(prev_node->type == nir_cf_node_block);
 568
 569    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 570    assert(&prev_block->successors[0]->cf_node ==
 571           nir_if_first_then_node(if_stmt));
 572    assert(&prev_block->successors[1]->cf_node ==
 573           nir_if_first_else_node(if_stmt));
 574
 575    assert(!exec_node_is_tail_sentinel(if_stmt->cf_node.node.next));
 576    nir_cf_node *next_node = nir_cf_node_next(&if_stmt->cf_node);
 577    assert(next_node->type == nir_cf_node_block);
 578
 579    if (!if_stmt->condition.is_ssa) {
 580       nir_register *reg = if_stmt->condition.reg.reg;
 581       struct set_entry *entry =
 582          _mesa_set_search(reg->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 583       assert(entry);
 584    } else {
 585       nir_ssa_def *def = if_stmt->condition.ssa;
 586       struct set_entry *entry =
 587          _mesa_set_search(def->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 588       assert(entry);
 589    }
 590
 591    assert(!exec_list_is_empty(&if_stmt->then_list));
 592    assert(!exec_list_is_empty(&if_stmt->else_list));
 593
 594    nir_cf_node *old_parent = state->parent_node;
 595    state->parent_node = &if_stmt->cf_node;
 596
 597    exec_list_validate(&if_stmt->then_list);
 598    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->then_list) {
 599       validate_cf_node(cf_node, state);
 600    }
 601
 602    exec_list_validate(&if_stmt->else_list);
 603    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->else_list) {
 604       validate_cf_node(cf_node, state);
 605    }
 606
 607    state->parent_node = old_parent;
 608 }
 609
 610 static void
 611 validate_loop(nir_loop *loop, validate_state *state)
 612 {
 613    assert(!exec_node_is_head_sentinel(loop->cf_node.node.prev));
 614    nir_cf_node *prev_node = nir_cf_node_prev(&loop->cf_node);
 615    assert(prev_node->type == nir_cf_node_block);
 616
 617    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 618    assert(&prev_block->successors[0]->cf_node == nir_loop_first_cf_node(loop));
 619    assert(prev_block->successors[1] == NULL);
 620
 621    assert(!exec_node_is_tail_sentinel(loop->cf_node.node.next));
 622    nir_cf_node *next_node = nir_cf_node_next(&loop->cf_node);
 623    assert(next_node->type == nir_cf_node_block);
 624
 625    assert(!exec_list_is_empty(&loop->body));
 626
 627    nir_cf_node *old_parent = state->parent_node;
 628    state->parent_node = &loop->cf_node;
 629
 630    exec_list_validate(&loop->body);
 631    foreach_list_typed(nir_cf_node, cf_node, node, &loop->body) {
 632       validate_cf_node(cf_node, state);
 633    }
 634
 635    state->parent_node = old_parent;
 636 }
 637
 638 static void
 639 validate_cf_node(nir_cf_node *node, validate_state *state)
 640 {
 641    assert(node->parent == state->parent_node);
 642
 643    switch (node->type) {
 644    case nir_cf_node_block:
 645       validate_block(nir_cf_node_as_block(node), state);
 646       break;
 647
 648    case nir_cf_node_if:
 649       validate_if(nir_cf_node_as_if(node), state);
 650       break;
 651
 652    case nir_cf_node_loop:
 653       validate_loop(nir_cf_node_as_loop(node), state);
 654       break;
 655
 656    default:
 657       assert(!"Invalid ALU instruction type");
 658       break;
 659    }
 660 }
 661
 662 static void
 663 prevalidate_reg_decl(nir_register *reg, bool is_global, validate_state *state)
 664 {
 665    assert(reg->is_global == is_global);
 666
 667    if (is_global)
 668       assert(reg->index < state->shader->reg_alloc);
 669    else
 670       assert(reg->index < state->impl->reg_alloc);
 671    assert(!BITSET_TEST(state->regs_found, reg->index));
 672    BITSET_SET(state->regs_found, reg->index);
 673
 674    reg_validate_state *reg_state = ralloc(state->regs, reg_validate_state);
 675    reg_state->uses = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 676    reg_state->defs = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 677
 678    reg_state->where_defined = is_global ? NULL : state->impl;
 679
 680    _mesa_hash_table_insert(state->regs, reg, reg_state);
 681 }
 682
 683 static void
 684 postvalidate_reg_decl(nir_register *reg, validate_state *state)
 685 {
 686    struct hash_entry *entry = _mesa_hash_table_search(state->regs, reg);
 687
 688    reg_validate_state *reg_state = (reg_validate_state *) entry->data;
 689
 690    if (reg_state->uses->entries != reg->uses->entries) {
 691       printf("extra entries in register uses:\n");
 692       struct set_entry *entry;
 693       set_foreach(reg->uses, entry) {
 694          struct set_entry *entry2 =
 695             _mesa_set_search(reg_state->uses, _mesa_hash_pointer(entry->key),
 696                              entry->key);
 697
 698          if (entry2 == NULL) {
 699             printf("%p\n", entry->key);
 700          }
 701       }
 702
 703       abort();
 704    }
 705
 706    if (reg_state->defs->entries != reg->defs->entries) {
 707       printf("extra entries in register defs:\n");
 708       struct set_entry *entry;
 709       set_foreach(reg->defs, entry) {
 710          struct set_entry *entry2 =
 711             _mesa_set_search(reg_state->defs, _mesa_hash_pointer(entry->key),
 712                              entry->key);
 713
 714          if (entry2 == NULL) {
 715             printf("%p\n", entry->key);
 716          }
 717       }
 718
 719       abort();
 720    }
 721 }
 722
 723 static void
 724 validate_var_decl(nir_variable *var, bool is_global, validate_state *state)
 725 {
 726    assert(is_global != (var->data.mode == nir_var_local));
 727
 728    /*
 729     * TODO validate some things ir_validate.cpp does (requires more GLSL type
 730     * support)
 731     */
 732
 733    if (!is_global) {
 734       _mesa_hash_table_insert(state->var_defs, var, state->impl);
 735    }
 736 }
 737
 738 static void
 739 validate_function_impl(nir_function_impl *impl, validate_state *state)
 740 {
 741    assert(impl->overload->impl == impl);
 742    assert(impl->cf_node.parent == NULL);
 743
 744    assert(impl->num_params == impl->overload->num_params);
 745    for (unsigned i = 0; i < impl->num_params; i++)
 746       assert(impl->params[i]->type == impl->overload->params[i].type);
 747
 748    if (glsl_type_is_void(impl->overload->return_type))
 749       assert(impl->return_var == NULL);
 750    else
 751       assert(impl->return_var->type == impl->overload->return_type);
 752
 753    assert(exec_list_is_empty(&impl->end_block->instr_list));
 754    assert(impl->end_block->successors[0] == NULL);
 755    assert(impl->end_block->successors[1] == NULL);
 756
 757    state->impl = impl;
 758    state->parent_node = &impl->cf_node;
 759
 760    exec_list_validate(&impl->locals);
 761    foreach_list_typed(nir_variable, var, node, &impl->locals) {
 762       validate_var_decl(var, false, state);
 763    }
 764
 765    state->regs_found = realloc(state->regs_found,
 766                                BITSET_WORDS(impl->reg_alloc) *
 767                                sizeof(BITSET_WORD));
 768    memset(state->regs_found, 0, BITSET_WORDS(impl->reg_alloc) *
 769                                 sizeof(BITSET_WORD));
 770    exec_list_validate(&impl->registers);
 771    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 772       prevalidate_reg_decl(reg, false, state);
 773    }
 774
 775    state->ssa_defs_found = realloc(state->ssa_defs_found,
 776                                    BITSET_WORDS(impl->ssa_alloc) *
 777                                    sizeof(BITSET_WORD));
 778    memset(state->ssa_defs_found, 0, BITSET_WORDS(impl->ssa_alloc) *
 779                                     sizeof(BITSET_WORD));
 780    exec_list_validate(&impl->body);
 781    foreach_list_typed(nir_cf_node, node, node, &impl->body) {
 782       validate_cf_node(node, state);
 783    }
 784
 785    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 786       postvalidate_reg_decl(reg, state);
 787    }
 788 }
 789
 790 static void
 791 validate_function_overload(nir_function_overload *overload,
 792                            validate_state *state)
 793 {
 794    if (overload->impl != NULL)
 795       validate_function_impl(overload->impl, state);
 796 }
 797
 798 static void
 799 validate_function(nir_function *func, validate_state *state)
 800 {
 801    exec_list_validate(&func->overload_list);
 802    foreach_list_typed(nir_function_overload, overload, node, &func->overload_list) {
 803       assert(overload->function == func);
 804       validate_function_overload(overload, state);
 805    }
 806 }
 807
 808 static void
 809 init_validate_state(validate_state *state)
 810 {
 811    state->regs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 812                                          _mesa_key_pointer_equal);
 813    state->ssa_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 814                                              _mesa_key_pointer_equal);
 815    state->ssa_defs_found = NULL;
 816    state->regs_found = NULL;
 817    state->var_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 818                                              _mesa_key_pointer_equal);
 819 }
 820
 821 static void
 822 destroy_validate_state(validate_state *state)
 823 {
 824    _mesa_hash_table_destroy(state->regs, NULL);
 825    _mesa_hash_table_destroy(state->ssa_defs, NULL);
 826    free(state->ssa_defs_found);
 827    free(state->regs_found);
 828    _mesa_hash_table_destroy(state->var_defs, NULL);
 829 }
 830
 831 void
 832 nir_validate_shader(nir_shader *shader)
 833 {
 834    validate_state state;
 835    init_validate_state(&state);
 836
 837    state.shader = shader;
 838
 839    struct hash_entry *entry;
 840    hash_table_foreach(shader->uniforms, entry) {
 841       validate_var_decl((nir_variable *) entry->data, true, &state);
 842    }
 843
 844    hash_table_foreach(shader->inputs, entry) {
 845      validate_var_decl((nir_variable *) entry->data, true, &state);
 846    }
 847
 848    hash_table_foreach(shader->outputs, entry) {
 849       validate_var_decl((nir_variable *) entry->data, true, &state);
 850    }
 851
 852    exec_list_validate(&shader->globals);
 853    foreach_list_typed(nir_variable, var, node, &shader->globals) {
 854      validate_var_decl(var, true, &state);
 855    }
 856
 857    exec_list_validate(&shader->system_values);
 858    foreach_list_typed(nir_variable, var, node, &shader->system_values) {
 859      validate_var_decl(var, true, &state);
 860    }
 861
 862    state.regs_found = realloc(state.regs_found,
 863                               BITSET_WORDS(shader->reg_alloc) *
 864                               sizeof(BITSET_WORD));
 865    memset(state.regs_found, 0, BITSET_WORDS(shader->reg_alloc) *
 866                                sizeof(BITSET_WORD));
 867    exec_list_validate(&shader->registers);
 868    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 869       prevalidate_reg_decl(reg, true, &state);
 870    }
 871
 872    exec_list_validate(&shader->functions);
 873    foreach_list_typed(nir_function, func, node, &shader->functions) {
 874       validate_function(func, &state);
 875    }
 876
 877    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 878       postvalidate_reg_decl(reg, &state);
 879    }
 880
 881    destroy_validate_state(&state);
 882 }