src/glsl/nir/nir_validate.c

   1 /*
   2  * Copyright © 2014 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *    Connor Abbott (cwabbott0@gmail.com)
  25  *
  26  */
  27
  28 #include "nir.h"
  29 #include <assert.h>
  30
  31 /*
  32  * This file checks for invalid IR indicating a bug somewhere in the compiler.
  33  */
  34
  35 /*
  36  * Per-register validation state.
  37  */
  38
  39 typedef struct {
  40    /*
  41     * equivalent to the uses and defs in nir_register, but built up by the
  42     * validator. At the end, we verify that the sets have the same entries.
  43     */
  44    struct set *uses, *defs;
  45    nir_function_impl *where_defined; /* NULL for global registers */
  46 } reg_validate_state;
  47
  48 typedef struct {
  49    /* map of register -> validation state (struct above) */
  50    struct hash_table *regs;
  51
  52    /* the current shader being validated */
  53    nir_shader *shader;
  54
  55    /* the current instruction being validated */
  56    nir_instr *instr;
  57
  58    /* the current basic block being validated */
  59    nir_block *block;
  60
  61    /* the current if statement being validated */
  62    nir_if *if_stmt;
  63
  64    /* the parent of the current cf node being visited */
  65    nir_cf_node *parent_node;
  66
  67    /* the current function implementation being validated */
  68    nir_function_impl *impl;
  69
  70    /* map of SSA value -> function implementation where it is defined */
  71    struct hash_table *ssa_defs;
  72
  73    /* bitset of ssa definitions we have found; used to check uniqueness */
  74    BITSET_WORD *ssa_defs_found;
  75
  76    /* bitset of registers we have currently found; used to check uniqueness */
  77    BITSET_WORD *regs_found;
  78
  79    /* map of local variable -> function implementation where it is defined */
  80    struct hash_table *var_defs;
  81 } validate_state;
  82
  83 static void validate_src(nir_src *src, validate_state *state);
  84
  85 static void
  86 validate_reg_src(nir_reg_src *src, validate_state *state)
  87 {
  88    assert(src->reg != NULL);
  89
  90    struct set_entry *entry =
  91       _mesa_set_search(src->reg->uses, _mesa_hash_pointer(state->instr),
  92                        state->instr);
  93    assert(entry && "use not in nir_register.uses");
  94
  95    struct hash_entry *entry2;
  96    entry2 = _mesa_hash_table_search(state->regs, src->reg);
  97
  98    assert(entry2);
  99
 100    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 101    _mesa_set_add(reg_state->uses, _mesa_hash_pointer(state->instr),
 102                  state->instr);
 103
 104    if (!src->reg->is_global) {
 105       assert(reg_state->where_defined == state->impl &&
 106              "using a register declared in a different function");
 107    }
 108
 109    assert((src->reg->num_array_elems == 0 ||
 110           src->base_offset < src->reg->num_array_elems) &&
 111           "definitely out-of-bounds array access");
 112
 113    if (src->indirect) {
 114       assert(src->reg->num_array_elems != 0);
 115       assert((src->indirect->is_ssa || src->indirect->reg.indirect == NULL) &&
 116              "only one level of indirection allowed");
 117       validate_src(src->indirect, state);
 118    }
 119 }
 120
 121 static void
 122 validate_ssa_src(nir_ssa_def *def, validate_state *state)
 123 {
 124    assert(def != NULL);
 125
 126    struct hash_entry *entry = _mesa_hash_table_search(state->ssa_defs, def);
 127
 128    assert(entry);
 129
 130    assert((nir_function_impl *) entry->data == state->impl &&
 131           "using an SSA value defined in a different function");
 132
 133    struct set_entry *entry2;
 134
 135    entry2 = _mesa_set_search(def->uses, _mesa_hash_pointer(state->instr),
 136                               state->instr);
 137
 138    assert(entry2 && "SSA use missing");
 139
 140    /* TODO validate that the use is dominated by the definition */
 141 }
 142
 143 static void
 144 validate_src(nir_src *src, validate_state *state)
 145 {
 146    if (src->is_ssa)
 147       validate_ssa_src(src->ssa, state);
 148    else
 149       validate_reg_src(&src->reg, state);
 150 }
 151
 152 static void
 153 validate_alu_src(nir_alu_instr *instr, unsigned index, validate_state *state)
 154 {
 155    nir_alu_src *src = &instr->src[index];
 156
 157    unsigned num_components;
 158    if (src->src.is_ssa)
 159       num_components = src->src.ssa->num_components;
 160    else {
 161       if (src->src.reg.reg->is_packed)
 162          num_components = 4; /* can't check anything */
 163       else
 164          num_components = src->src.reg.reg->num_components;
 165    }
 166    for (unsigned i = 0; i < 4; i++) {
 167       assert(src->swizzle[i] < 4);
 168
 169       if (nir_alu_instr_channel_used(instr, index, i))
 170          assert(src->swizzle[i] < num_components);
 171    }
 172
 173    validate_src(&src->src, state);
 174 }
 175
 176 static void
 177 validate_reg_dest(nir_reg_dest *dest, validate_state *state)
 178 {
 179    assert(dest->reg != NULL);
 180
 181    struct set_entry *entry =
 182       _mesa_set_search(dest->reg->defs, _mesa_hash_pointer(state->instr),
 183                        state->instr);
 184    assert(entry && "definition not in nir_register.defs");
 185
 186    struct hash_entry *entry2;
 187    entry2 = _mesa_hash_table_search(state->regs, dest->reg);
 188
 189    assert(entry2);
 190
 191    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 192    _mesa_set_add(reg_state->defs, _mesa_hash_pointer(state->instr),
 193                  state->instr);
 194
 195    if (!dest->reg->is_global) {
 196       assert(reg_state->where_defined == state->impl &&
 197              "writing to a register declared in a different function");
 198    }
 199
 200    assert((dest->reg->num_array_elems == 0 ||
 201           dest->base_offset < dest->reg->num_array_elems) &&
 202           "definitely out-of-bounds array access");
 203
 204    if (dest->indirect) {
 205       assert(dest->reg->num_array_elems != 0);
 206       assert((dest->indirect->is_ssa || dest->indirect->reg.indirect == NULL) &&
 207              "only one level of indirection allowed");
 208       validate_src(dest->indirect, state);
 209    }
 210 }
 211
 212 static void
 213 validate_ssa_def(nir_ssa_def *def, validate_state *state)
 214 {
 215    assert(def->index < state->impl->ssa_alloc);
 216    assert(!BITSET_TEST(state->ssa_defs_found, def->index));
 217    BITSET_SET(state->ssa_defs_found, def->index);
 218
 219    assert(def->num_components <= 4);
 220    _mesa_hash_table_insert(state->ssa_defs, def, state->impl);
 221 }
 222
 223 static void
 224 validate_dest(nir_dest *dest, validate_state *state)
 225 {
 226    if (dest->is_ssa)
 227       validate_ssa_def(&dest->ssa, state);
 228    else
 229       validate_reg_dest(&dest->reg, state);
 230 }
 231
 232 static void
 233 validate_alu_dest(nir_alu_dest *dest, validate_state *state)
 234 {
 235    unsigned dest_size =
 236       dest->dest.is_ssa ? dest->dest.ssa.num_components
 237                         : dest->dest.reg.reg->num_components;
 238    bool is_packed = !dest->dest.is_ssa && dest->dest.reg.reg->is_packed;
 239    /*
 240     * validate that the instruction doesn't write to components not in the
 241     * register/SSA value
 242     */
 243    assert(is_packed || !(dest->write_mask & ~((1 << dest_size) - 1)));
 244    validate_dest(&dest->dest, state);
 245 }
 246
 247 static void
 248 validate_alu_instr(nir_alu_instr *instr, validate_state *state)
 249 {
 250    assert(instr->op < nir_num_opcodes);
 251
 252    validate_alu_dest(&instr->dest, state);
 253
 254    for (unsigned i = 0; i < nir_op_infos[instr->op].num_inputs; i++) {
 255       validate_alu_src(instr, i, state);
 256    }
 257
 258    if (instr->has_predicate)
 259       validate_src(&instr->predicate, state);
 260 }
 261
 262 static void
 263 validate_deref_chain(nir_deref *deref, validate_state *state)
 264 {
 265    nir_deref *parent = NULL;
 266    while (deref != NULL) {
 267       switch (deref->deref_type) {
 268       case nir_deref_type_array:
 269          assert(deref->type == glsl_get_array_element(parent->type));
 270          if (nir_deref_as_array(deref)->has_indirect)
 271             validate_src(&nir_deref_as_array(deref)->indirect, state);
 272          break;
 273
 274       case nir_deref_type_struct:
 275          assert(deref->type ==
 276                 glsl_get_struct_field(parent->type,
 277                                       nir_deref_as_struct(deref)->elem));
 278          break;
 279
 280       case nir_deref_type_var:
 281          break;
 282
 283       default:
 284          assert(!"Invalid deref type");
 285          break;
 286       }
 287
 288       parent = deref;
 289       deref = deref->child;
 290    }
 291 }
 292
 293 static void
 294 validate_var_use(nir_variable *var, validate_state *state)
 295 {
 296    if (var->data.mode == nir_var_local) {
 297       struct hash_entry *entry = _mesa_hash_table_search(state->var_defs, var);
 298
 299       assert(entry);
 300       assert((nir_function_impl *) entry->data == state->impl);
 301    }
 302 }
 303
 304 static void
 305 validate_deref_var(nir_deref_var *deref, validate_state *state)
 306 {
 307    assert(deref != NULL);
 308    assert(deref->deref.type == deref->var->type);
 309
 310    validate_var_use(deref->var, state);
 311
 312    validate_deref_chain(&deref->deref, state);
 313 }
 314
 315 static void
 316 validate_intrinsic_instr(nir_intrinsic_instr *instr, validate_state *state)
 317 {
 318    unsigned num_srcs = nir_intrinsic_infos[instr->intrinsic].num_srcs;
 319    for (unsigned i = 0; i < num_srcs; i++) {
 320       validate_src(&instr->src[i], state);
 321    }
 322
 323    if (nir_intrinsic_infos[instr->intrinsic].has_dest) {
 324       validate_dest(&instr->dest, state);
 325    }
 326
 327    unsigned num_vars = nir_intrinsic_infos[instr->intrinsic].num_variables;
 328    for (unsigned i = 0; i < num_vars; i++) {
 329       validate_deref_var(instr->variables[i], state);
 330    }
 331
 332    if (instr->has_predicate)
 333       validate_src(&instr->predicate, state);
 334 }
 335
 336 static void
 337 validate_tex_instr(nir_tex_instr *instr, validate_state *state)
 338 {
 339    validate_dest(&instr->dest, state);
 340
 341    bool src_type_seen[nir_num_texinput_types];
 342    for (unsigned i = 0; i < nir_num_texinput_types; i++)
 343       src_type_seen[i] = false;
 344
 345    for (unsigned i = 0; i < instr->num_srcs; i++) {
 346       assert(!src_type_seen[instr->src_type[i]]);
 347       src_type_seen[instr->src_type[i]] = true;
 348       validate_src(&instr->src[i], state);
 349    }
 350
 351    if (instr->sampler != NULL)
 352       validate_deref_var(instr->sampler, state);
 353 }
 354
 355 static void
 356 validate_call_instr(nir_call_instr *instr, validate_state *state)
 357 {
 358    if (instr->return_deref == NULL)
 359       assert(glsl_type_is_void(instr->callee->return_type));
 360    else
 361       assert(instr->return_deref->deref.type == instr->callee->return_type);
 362
 363    assert(instr->num_params == instr->callee->num_params);
 364
 365    for (unsigned i = 0; i < instr->num_params; i++) {
 366       assert(instr->callee->params[i].type == instr->params[i]->deref.type);
 367       validate_deref_var(instr->params[i], state);
 368    }
 369
 370    validate_deref_var(instr->return_deref, state);
 371
 372    if (instr->has_predicate)
 373       validate_src(&instr->predicate, state);
 374 }
 375
 376 static void
 377 validate_load_const_instr(nir_load_const_instr *instr, validate_state *state)
 378 {
 379    validate_dest(&instr->dest, state);
 380
 381    if (instr->array_elems != 0) {
 382       assert(!instr->dest.is_ssa);
 383       assert(instr->dest.reg.base_offset + instr->array_elems <=
 384              instr->dest.reg.reg->num_array_elems);
 385    }
 386
 387    if (instr->has_predicate)
 388       validate_src(&instr->predicate, state);
 389 }
 390
 391 static void
 392 validate_ssa_undef_instr(nir_ssa_undef_instr *instr, validate_state *state)
 393 {
 394    validate_ssa_def(&instr->def, state);
 395 }
 396
 397 static void
 398 validate_phi_instr(nir_phi_instr *instr, validate_state *state)
 399 {
 400    /*
 401     * don't validate the sources until we get to them from their predecessor
 402     * basic blocks, to avoid validating an SSA use before its definition.
 403     */
 404
 405    validate_dest(&instr->dest, state);
 406
 407    exec_list_validate(&instr->srcs);
 408    assert(exec_list_length(&instr->srcs) ==
 409           state->block->predecessors->entries);
 410 }
 411
 412 static void
 413 validate_instr(nir_instr *instr, validate_state *state)
 414 {
 415    assert(instr->block == state->block);
 416
 417    state->instr = instr;
 418
 419    switch (instr->type) {
 420    case nir_instr_type_alu:
 421       validate_alu_instr(nir_instr_as_alu(instr), state);
 422       break;
 423
 424    case nir_instr_type_call:
 425       validate_call_instr(nir_instr_as_call(instr), state);
 426       break;
 427
 428    case nir_instr_type_intrinsic:
 429       validate_intrinsic_instr(nir_instr_as_intrinsic(instr), state);
 430       break;
 431
 432    case nir_instr_type_texture:
 433       validate_tex_instr(nir_instr_as_texture(instr), state);
 434       break;
 435
 436    case nir_instr_type_load_const:
 437       validate_load_const_instr(nir_instr_as_load_const(instr), state);
 438       break;
 439
 440    case nir_instr_type_phi:
 441       validate_phi_instr(nir_instr_as_phi(instr), state);
 442       break;
 443
 444    case nir_instr_type_ssa_undef:
 445       validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr), state);
 446       break;
 447
 448    case nir_instr_type_jump:
 449       break;
 450
 451    default:
 452       assert(!"Invalid ALU instruction type");
 453       break;
 454    }
 455 }
 456
 457 static void
 458 validate_phi_src(nir_phi_instr *instr, nir_block *pred, validate_state *state)
 459 {
 460    state->instr = &instr->instr;
 461
 462    exec_list_validate(&instr->srcs);
 463    foreach_list_typed(nir_phi_src, src, node, &instr->srcs) {
 464       if (src->pred == pred) {
 465          validate_src(&src->src, state);
 466          return;
 467       }
 468    }
 469
 470    abort();
 471 }
 472
 473 static void
 474 validate_phi_srcs(nir_block *block, nir_block *succ, validate_state *state)
 475 {
 476    nir_foreach_instr(succ, instr) {
 477       if (instr->type != nir_instr_type_phi)
 478          break;
 479
 480       validate_phi_src(nir_instr_as_phi(instr), block, state);
 481    }
 482 }
 483
 484 static void validate_cf_node(nir_cf_node *node, validate_state *state);
 485
 486 static void
 487 validate_block(nir_block *block, validate_state *state)
 488 {
 489    assert(block->cf_node.parent == state->parent_node);
 490
 491    state->block = block;
 492
 493    exec_list_validate(&block->instr_list);
 494    nir_foreach_instr(block, instr) {
 495       if (instr->type == nir_instr_type_phi) {
 496          assert(instr == nir_block_first_instr(block) ||
 497                 nir_instr_prev(instr)->type == nir_instr_type_phi);
 498       }
 499
 500       if (instr->type == nir_instr_type_jump) {
 501          assert(instr == nir_block_last_instr(block));
 502       }
 503
 504       validate_instr(instr, state);
 505    }
 506
 507    assert(block->successors[0] != NULL);
 508
 509    for (unsigned i = 0; i < 2; i++) {
 510       if (block->successors[i] != NULL) {
 511          struct set_entry *entry =
 512             _mesa_set_search(block->successors[i]->predecessors,
 513                              _mesa_hash_pointer(block), block);
 514          assert(entry);
 515
 516          validate_phi_srcs(block, block->successors[i], state);
 517       }
 518    }
 519
 520    if (!exec_list_is_empty(&block->instr_list) &&
 521        nir_block_last_instr(block)->type == nir_instr_type_jump)
 522       assert(block->successors[1] == NULL);
 523 }
 524
 525 static void
 526 validate_if(nir_if *if_stmt, validate_state *state)
 527 {
 528    assert(!exec_node_is_head_sentinel(if_stmt->cf_node.node.prev));
 529    nir_cf_node *prev_node = nir_cf_node_prev(&if_stmt->cf_node);
 530    assert(prev_node->type == nir_cf_node_block);
 531
 532    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 533    assert(&prev_block->successors[0]->cf_node ==
 534           nir_if_first_then_node(if_stmt));
 535    assert(&prev_block->successors[1]->cf_node ==
 536           nir_if_first_else_node(if_stmt));
 537
 538    assert(!exec_node_is_tail_sentinel(if_stmt->cf_node.node.next));
 539    nir_cf_node *next_node = nir_cf_node_next(&if_stmt->cf_node);
 540    assert(next_node->type == nir_cf_node_block);
 541
 542    if (!if_stmt->condition.is_ssa) {
 543       nir_register *reg = if_stmt->condition.reg.reg;
 544       struct set_entry *entry =
 545          _mesa_set_search(reg->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 546       assert(entry);
 547    } else {
 548       nir_ssa_def *def = if_stmt->condition.ssa;
 549       struct set_entry *entry =
 550          _mesa_set_search(def->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 551       assert(entry);
 552    }
 553
 554    assert(!exec_list_is_empty(&if_stmt->then_list));
 555    assert(!exec_list_is_empty(&if_stmt->else_list));
 556
 557    nir_cf_node *old_parent = state->parent_node;
 558    state->parent_node = &if_stmt->cf_node;
 559
 560    exec_list_validate(&if_stmt->then_list);
 561    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->then_list) {
 562       validate_cf_node(cf_node, state);
 563    }
 564
 565    exec_list_validate(&if_stmt->else_list);
 566    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->else_list) {
 567       validate_cf_node(cf_node, state);
 568    }
 569
 570    state->parent_node = old_parent;
 571 }
 572
 573 static void
 574 validate_loop(nir_loop *loop, validate_state *state)
 575 {
 576    assert(!exec_node_is_head_sentinel(loop->cf_node.node.prev));
 577    nir_cf_node *prev_node = nir_cf_node_prev(&loop->cf_node);
 578    assert(prev_node->type == nir_cf_node_block);
 579
 580    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 581    assert(&prev_block->successors[0]->cf_node == nir_loop_first_cf_node(loop));
 582    assert(prev_block->successors[1] == NULL);
 583
 584    assert(!exec_node_is_tail_sentinel(loop->cf_node.node.next));
 585    nir_cf_node *next_node = nir_cf_node_next(&loop->cf_node);
 586    assert(next_node->type == nir_cf_node_block);
 587
 588    assert(!exec_list_is_empty(&loop->body));
 589
 590    nir_cf_node *old_parent = state->parent_node;
 591    state->parent_node = &loop->cf_node;
 592
 593    exec_list_validate(&loop->body);
 594    foreach_list_typed(nir_cf_node, cf_node, node, &loop->body) {
 595       validate_cf_node(cf_node, state);
 596    }
 597
 598    state->parent_node = old_parent;
 599 }
 600
 601 static void
 602 validate_cf_node(nir_cf_node *node, validate_state *state)
 603 {
 604    assert(node->parent == state->parent_node);
 605
 606    switch (node->type) {
 607    case nir_cf_node_block:
 608       validate_block(nir_cf_node_as_block(node), state);
 609       break;
 610
 611    case nir_cf_node_if:
 612       validate_if(nir_cf_node_as_if(node), state);
 613       break;
 614
 615    case nir_cf_node_loop:
 616       validate_loop(nir_cf_node_as_loop(node), state);
 617       break;
 618
 619    default:
 620       assert(!"Invalid ALU instruction type");
 621       break;
 622    }
 623 }
 624
 625 static void
 626 prevalidate_reg_decl(nir_register *reg, bool is_global, validate_state *state)
 627 {
 628    assert(reg->is_global == is_global);
 629
 630    if (is_global)
 631       assert(reg->index < state->shader->reg_alloc);
 632    else
 633       assert(reg->index < state->impl->reg_alloc);
 634    assert(!BITSET_TEST(state->regs_found, reg->index));
 635    BITSET_SET(state->regs_found, reg->index);
 636
 637    reg_validate_state *reg_state = ralloc(state->regs, reg_validate_state);
 638    reg_state->uses = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 639    reg_state->defs = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 640
 641    reg_state->where_defined = is_global ? NULL : state->impl;
 642
 643    _mesa_hash_table_insert(state->regs, reg, reg_state);
 644 }
 645
 646 static void
 647 postvalidate_reg_decl(nir_register *reg, validate_state *state)
 648 {
 649    struct hash_entry *entry = _mesa_hash_table_search(state->regs, reg);
 650
 651    reg_validate_state *reg_state = (reg_validate_state *) entry->data;
 652
 653    if (reg_state->uses->entries != reg->uses->entries) {
 654       printf("extra entries in register uses:\n");
 655       struct set_entry *entry;
 656       set_foreach(reg->uses, entry) {
 657          struct set_entry *entry2 =
 658             _mesa_set_search(reg_state->uses, _mesa_hash_pointer(entry->key),
 659                              entry->key);
 660
 661          if (entry2 == NULL) {
 662             printf("%p\n", entry->key);
 663          }
 664       }
 665
 666       abort();
 667    }
 668
 669    if (reg_state->defs->entries != reg->defs->entries) {
 670       printf("extra entries in register defs:\n");
 671       struct set_entry *entry;
 672       set_foreach(reg->defs, entry) {
 673          struct set_entry *entry2 =
 674             _mesa_set_search(reg_state->defs, _mesa_hash_pointer(entry->key),
 675                              entry->key);
 676
 677          if (entry2 == NULL) {
 678             printf("%p\n", entry->key);
 679          }
 680       }
 681
 682       abort();
 683    }
 684 }
 685
 686 static void
 687 validate_var_decl(nir_variable *var, bool is_global, validate_state *state)
 688 {
 689    assert(is_global != (var->data.mode == nir_var_local));
 690
 691    /*
 692     * TODO validate some things ir_validate.cpp does (requires more GLSL type
 693     * support)
 694     */
 695
 696    if (!is_global) {
 697       _mesa_hash_table_insert(state->var_defs, var, state->impl);
 698    }
 699 }
 700
 701 static void
 702 validate_function_impl(nir_function_impl *impl, validate_state *state)
 703 {
 704    assert(impl->overload->impl == impl);
 705    assert(impl->cf_node.parent == NULL);
 706
 707    assert(impl->num_params == impl->overload->num_params);
 708    for (unsigned i = 0; i < impl->num_params; i++)
 709       assert(impl->params[i]->type == impl->overload->params[i].type);
 710
 711    if (glsl_type_is_void(impl->overload->return_type))
 712       assert(impl->return_var == NULL);
 713    else
 714       assert(impl->return_var->type == impl->overload->return_type);
 715
 716    assert(exec_list_is_empty(&impl->end_block->instr_list));
 717    assert(impl->end_block->successors[0] == NULL);
 718    assert(impl->end_block->successors[1] == NULL);
 719
 720    state->impl = impl;
 721    state->parent_node = &impl->cf_node;
 722
 723    exec_list_validate(&impl->locals);
 724    foreach_list_typed(nir_variable, var, node, &impl->locals) {
 725       validate_var_decl(var, false, state);
 726    }
 727
 728    state->regs_found = realloc(state->regs_found,
 729                                BITSET_WORDS(impl->reg_alloc) *
 730                                sizeof(BITSET_WORD));
 731    memset(state->regs_found, 0, BITSET_WORDS(impl->reg_alloc) *
 732                                 sizeof(BITSET_WORD));
 733    exec_list_validate(&impl->registers);
 734    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 735       prevalidate_reg_decl(reg, false, state);
 736    }
 737
 738    state->ssa_defs_found = realloc(state->ssa_defs_found,
 739                                    BITSET_WORDS(impl->ssa_alloc) *
 740                                    sizeof(BITSET_WORD));
 741    memset(state->ssa_defs_found, 0, BITSET_WORDS(impl->ssa_alloc) *
 742                                     sizeof(BITSET_WORD));
 743    exec_list_validate(&impl->body);
 744    foreach_list_typed(nir_cf_node, node, node, &impl->body) {
 745       validate_cf_node(node, state);
 746    }
 747
 748    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 749       postvalidate_reg_decl(reg, state);
 750    }
 751 }
 752
 753 static void
 754 validate_function_overload(nir_function_overload *overload,
 755                            validate_state *state)
 756 {
 757    if (overload->impl != NULL)
 758       validate_function_impl(overload->impl, state);
 759 }
 760
 761 static void
 762 validate_function(nir_function *func, validate_state *state)
 763 {
 764    exec_list_validate(&func->overload_list);
 765    foreach_list_typed(nir_function_overload, overload, node, &func->overload_list) {
 766       assert(overload->function == func);
 767       validate_function_overload(overload, state);
 768    }
 769 }
 770
 771 static void
 772 init_validate_state(validate_state *state)
 773 {
 774    state->regs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 775                                          _mesa_key_pointer_equal);
 776    state->ssa_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 777                                              _mesa_key_pointer_equal);
 778    state->ssa_defs_found = NULL;
 779    state->regs_found = NULL;
 780    state->var_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 781                                              _mesa_key_pointer_equal);
 782 }
 783
 784 static void
 785 destroy_validate_state(validate_state *state)
 786 {
 787    _mesa_hash_table_destroy(state->regs, NULL);
 788    _mesa_hash_table_destroy(state->ssa_defs, NULL);
 789    free(state->ssa_defs_found);
 790    free(state->regs_found);
 791    _mesa_hash_table_destroy(state->var_defs, NULL);
 792 }
 793
 794 void
 795 nir_validate_shader(nir_shader *shader)
 796 {
 797    validate_state state;
 798    init_validate_state(&state);
 799
 800    state.shader = shader;
 801
 802    struct hash_entry *entry;
 803    hash_table_foreach(shader->uniforms, entry) {
 804       validate_var_decl((nir_variable *) entry->data, true, &state);
 805    }
 806
 807    hash_table_foreach(shader->inputs, entry) {
 808      validate_var_decl((nir_variable *) entry->data, true, &state);
 809    }
 810
 811    hash_table_foreach(shader->outputs, entry) {
 812       validate_var_decl((nir_variable *) entry->data, true, &state);
 813    }
 814
 815    exec_list_validate(&shader->globals);
 816    foreach_list_typed(nir_variable, var, node, &shader->globals) {
 817      validate_var_decl(var, true, &state);
 818    }
 819
 820    exec_list_validate(&shader->system_values);
 821    foreach_list_typed(nir_variable, var, node, &shader->system_values) {
 822      validate_var_decl(var, true, &state);
 823    }
 824
 825    state.regs_found = realloc(state.regs_found,
 826                               BITSET_WORDS(shader->reg_alloc) *
 827                               sizeof(BITSET_WORD));
 828    memset(state.regs_found, 0, BITSET_WORDS(shader->reg_alloc) *
 829                                sizeof(BITSET_WORD));
 830    exec_list_validate(&shader->registers);
 831    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 832       prevalidate_reg_decl(reg, true, &state);
 833    }
 834
 835    exec_list_validate(&shader->functions);
 836    foreach_list_typed(nir_function, func, node, &shader->functions) {
 837       validate_function(func, &state);
 838    }
 839
 840    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 841       postvalidate_reg_decl(reg, &state);
 842    }
 843
 844    destroy_validate_state(&state);
 845 }