src/glsl/nir/nir_validate.c

   1 /*
   2  * Copyright © 2014 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *    Connor Abbott (cwabbott0@gmail.com)
  25  *
  26  */
  27
  28 #include "nir.h"
  29 #include <assert.h>
  30
  31 /*
  32  * This file checks for invalid IR indicating a bug somewhere in the compiler.
  33  */
  34
  35 /*
  36  * Per-register validation state.
  37  */
  38
  39 typedef struct {
  40    /*
  41     * equivalent to the uses and defs in nir_register, but built up by the
  42     * validator. At the end, we verify that the sets have the same entries.
  43     */
  44    struct set *uses, *defs;
  45    nir_function_impl *where_defined; /* NULL for global registers */
  46 } reg_validate_state;
  47
  48 typedef struct {
  49    /* map of register -> validation state (struct above) */
  50    struct hash_table *regs;
  51
  52    /* the current shader being validated */
  53    nir_shader *shader;
  54
  55    /* the current instruction being validated */
  56    nir_instr *instr;
  57
  58    /* the current basic block being validated */
  59    nir_block *block;
  60
  61    /* the current if statement being validated */
  62    nir_if *if_stmt;
  63
  64    /* the parent of the current cf node being visited */
  65    nir_cf_node *parent_node;
  66
  67    /* the current function implementation being validated */
  68    nir_function_impl *impl;
  69
  70    /* map of SSA value -> function implementation where it is defined */
  71    struct hash_table *ssa_defs;
  72
  73    /* bitset of ssa definitions we have found; used to check uniqueness */
  74    BITSET_WORD *ssa_defs_found;
  75
  76    /* bitset of registers we have currently found; used to check uniqueness */
  77    BITSET_WORD *regs_found;
  78
  79    /* map of local variable -> function implementation where it is defined */
  80    struct hash_table *var_defs;
  81 } validate_state;
  82
  83 static void validate_src(nir_src *src, validate_state *state);
  84
  85 static void
  86 validate_reg_src(nir_reg_src *src, validate_state *state)
  87 {
  88    assert(src->reg != NULL);
  89
  90    struct set_entry *entry =
  91       _mesa_set_search(src->reg->uses, _mesa_hash_pointer(state->instr),
  92                        state->instr);
  93    assert(entry && "use not in nir_register.uses");
  94
  95    struct hash_entry *entry2;
  96    entry2 = _mesa_hash_table_search(state->regs, src->reg);
  97
  98    assert(entry2);
  99
 100    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 101    _mesa_set_add(reg_state->uses, _mesa_hash_pointer(state->instr),
 102                  state->instr);
 103
 104    if (!src->reg->is_global) {
 105       assert(reg_state->where_defined == state->impl &&
 106              "using a register declared in a different function");
 107    }
 108
 109    assert((src->reg->num_array_elems == 0 ||
 110           src->base_offset < src->reg->num_array_elems) &&
 111           "definitely out-of-bounds array access");
 112
 113    if (src->indirect) {
 114       assert(src->reg->num_array_elems != 0);
 115       assert((src->indirect->is_ssa || src->indirect->reg.indirect == NULL) &&
 116              "only one level of indirection allowed");
 117       validate_src(src->indirect, state);
 118    }
 119 }
 120
 121 static void
 122 validate_ssa_src(nir_ssa_def *def, validate_state *state)
 123 {
 124    assert(def != NULL);
 125
 126    struct hash_entry *entry = _mesa_hash_table_search(state->ssa_defs, def);
 127
 128    assert(entry);
 129
 130    assert((nir_function_impl *) entry->data == state->impl &&
 131           "using an SSA value defined in a different function");
 132
 133    struct set_entry *entry2;
 134
 135    entry2 = _mesa_set_search(def->uses, _mesa_hash_pointer(state->instr),
 136                               state->instr);
 137
 138    assert(entry2 && "SSA use missing");
 139
 140    /* TODO validate that the use is dominated by the definition */
 141 }
 142
 143 static void
 144 validate_src(nir_src *src, validate_state *state)
 145 {
 146    if (src->is_ssa)
 147       validate_ssa_src(src->ssa, state);
 148    else
 149       validate_reg_src(&src->reg, state);
 150 }
 151
 152 static void
 153 validate_alu_src(nir_alu_instr *instr, unsigned index, validate_state *state)
 154 {
 155    nir_alu_src *src = &instr->src[index];
 156
 157    unsigned num_components;
 158    if (src->src.is_ssa)
 159       num_components = src->src.ssa->num_components;
 160    else {
 161       if (src->src.reg.reg->is_packed)
 162          num_components = 4; /* can't check anything */
 163       else
 164          num_components = src->src.reg.reg->num_components;
 165    }
 166    for (unsigned i = 0; i < 4; i++) {
 167       assert(src->swizzle[i] < 4);
 168
 169       if (nir_alu_instr_channel_used(instr, index, i))
 170          assert(src->swizzle[i] < num_components);
 171    }
 172
 173    validate_src(&src->src, state);
 174 }
 175
 176 static void
 177 validate_reg_dest(nir_reg_dest *dest, validate_state *state)
 178 {
 179    assert(dest->reg != NULL);
 180
 181    struct set_entry *entry =
 182       _mesa_set_search(dest->reg->defs, _mesa_hash_pointer(state->instr),
 183                        state->instr);
 184    assert(entry && "definition not in nir_register.defs");
 185
 186    struct hash_entry *entry2;
 187    entry2 = _mesa_hash_table_search(state->regs, dest->reg);
 188
 189    assert(entry2);
 190
 191    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 192    _mesa_set_add(reg_state->defs, _mesa_hash_pointer(state->instr),
 193                  state->instr);
 194
 195    if (!dest->reg->is_global) {
 196       assert(reg_state->where_defined == state->impl &&
 197              "writing to a register declared in a different function");
 198    }
 199
 200    assert((dest->reg->num_array_elems == 0 ||
 201           dest->base_offset < dest->reg->num_array_elems) &&
 202           "definitely out-of-bounds array access");
 203
 204    if (dest->indirect) {
 205       assert(dest->reg->num_array_elems != 0);
 206       assert((dest->indirect->is_ssa || dest->indirect->reg.indirect == NULL) &&
 207              "only one level of indirection allowed");
 208       validate_src(dest->indirect, state);
 209    }
 210 }
 211
 212 static void
 213 validate_ssa_def(nir_ssa_def *def, validate_state *state)
 214 {
 215    assert(def->index < state->impl->ssa_alloc);
 216    assert(!BITSET_TEST(state->ssa_defs_found, def->index));
 217    BITSET_SET(state->ssa_defs_found, def->index);
 218
 219    assert(def->num_components <= 4);
 220    _mesa_hash_table_insert(state->ssa_defs, def, state->impl);
 221 }
 222
 223 static void
 224 validate_dest(nir_dest *dest, validate_state *state)
 225 {
 226    if (dest->is_ssa)
 227       validate_ssa_def(&dest->ssa, state);
 228    else
 229       validate_reg_dest(&dest->reg, state);
 230 }
 231
 232 static void
 233 validate_alu_dest(nir_alu_dest *dest, validate_state *state)
 234 {
 235    unsigned dest_size =
 236       dest->dest.is_ssa ? dest->dest.ssa.num_components
 237                         : dest->dest.reg.reg->num_components;
 238    bool is_packed = !dest->dest.is_ssa && dest->dest.reg.reg->is_packed;
 239    /*
 240     * validate that the instruction doesn't write to components not in the
 241     * register/SSA value
 242     */
 243    assert(is_packed || !(dest->write_mask & ~((1 << dest_size) - 1)));
 244    validate_dest(&dest->dest, state);
 245 }
 246
 247 static void
 248 validate_alu_instr(nir_alu_instr *instr, validate_state *state)
 249 {
 250    assert(instr->op < nir_num_opcodes);
 251
 252    validate_alu_dest(&instr->dest, state);
 253
 254    for (unsigned i = 0; i < nir_op_infos[instr->op].num_inputs; i++) {
 255       validate_alu_src(instr, i, state);
 256    }
 257
 258    if (instr->has_predicate)
 259       validate_src(&instr->predicate, state);
 260 }
 261
 262 static void
 263 validate_deref_chain(nir_deref *deref, validate_state *state)
 264 {
 265    nir_deref *parent = NULL;
 266    while (deref != NULL) {
 267       switch (deref->deref_type) {
 268       case nir_deref_type_array:
 269          assert(deref->type == glsl_get_array_element(parent->type));
 270          if (nir_deref_as_array(deref)->deref_array_type ==
 271              nir_deref_array_type_indirect)
 272             validate_src(&nir_deref_as_array(deref)->indirect, state);
 273          break;
 274
 275       case nir_deref_type_struct:
 276          assert(deref->type ==
 277                 glsl_get_struct_field(parent->type,
 278                                       nir_deref_as_struct(deref)->index));
 279          break;
 280
 281       case nir_deref_type_var:
 282          break;
 283
 284       default:
 285          assert(!"Invalid deref type");
 286          break;
 287       }
 288
 289       parent = deref;
 290       deref = deref->child;
 291    }
 292 }
 293
 294 static void
 295 validate_var_use(nir_variable *var, validate_state *state)
 296 {
 297    if (var->data.mode == nir_var_local) {
 298       struct hash_entry *entry = _mesa_hash_table_search(state->var_defs, var);
 299
 300       assert(entry);
 301       assert((nir_function_impl *) entry->data == state->impl);
 302    }
 303 }
 304
 305 static void
 306 validate_deref_var(nir_deref_var *deref, validate_state *state)
 307 {
 308    assert(deref != NULL);
 309    assert(deref->deref.type == deref->var->type);
 310
 311    validate_var_use(deref->var, state);
 312
 313    validate_deref_chain(&deref->deref, state);
 314 }
 315
 316 static void
 317 validate_intrinsic_instr(nir_intrinsic_instr *instr, validate_state *state)
 318 {
 319    unsigned num_srcs = nir_intrinsic_infos[instr->intrinsic].num_srcs;
 320    for (unsigned i = 0; i < num_srcs; i++) {
 321       validate_src(&instr->src[i], state);
 322    }
 323
 324    if (nir_intrinsic_infos[instr->intrinsic].has_dest) {
 325       validate_dest(&instr->dest, state);
 326    }
 327
 328    unsigned num_vars = nir_intrinsic_infos[instr->intrinsic].num_variables;
 329    for (unsigned i = 0; i < num_vars; i++) {
 330       validate_deref_var(instr->variables[i], state);
 331    }
 332
 333    if (instr->has_predicate)
 334       validate_src(&instr->predicate, state);
 335 }
 336
 337 static void
 338 validate_tex_instr(nir_tex_instr *instr, validate_state *state)
 339 {
 340    validate_dest(&instr->dest, state);
 341
 342    bool src_type_seen[nir_num_texinput_types];
 343    for (unsigned i = 0; i < nir_num_texinput_types; i++)
 344       src_type_seen[i] = false;
 345
 346    for (unsigned i = 0; i < instr->num_srcs; i++) {
 347       assert(!src_type_seen[instr->src_type[i]]);
 348       src_type_seen[instr->src_type[i]] = true;
 349       validate_src(&instr->src[i], state);
 350    }
 351
 352    if (instr->sampler != NULL)
 353       validate_deref_var(instr->sampler, state);
 354 }
 355
 356 static void
 357 validate_call_instr(nir_call_instr *instr, validate_state *state)
 358 {
 359    if (instr->return_deref == NULL)
 360       assert(glsl_type_is_void(instr->callee->return_type));
 361    else
 362       assert(instr->return_deref->deref.type == instr->callee->return_type);
 363
 364    assert(instr->num_params == instr->callee->num_params);
 365
 366    for (unsigned i = 0; i < instr->num_params; i++) {
 367       assert(instr->callee->params[i].type == instr->params[i]->deref.type);
 368       validate_deref_var(instr->params[i], state);
 369    }
 370
 371    validate_deref_var(instr->return_deref, state);
 372
 373    if (instr->has_predicate)
 374       validate_src(&instr->predicate, state);
 375 }
 376
 377 static void
 378 validate_load_const_instr(nir_load_const_instr *instr, validate_state *state)
 379 {
 380    validate_dest(&instr->dest, state);
 381
 382    if (instr->array_elems != 0) {
 383       assert(!instr->dest.is_ssa);
 384       assert(instr->dest.reg.base_offset + instr->array_elems <=
 385              instr->dest.reg.reg->num_array_elems);
 386    }
 387
 388    if (instr->has_predicate)
 389       validate_src(&instr->predicate, state);
 390 }
 391
 392 static void
 393 validate_ssa_undef_instr(nir_ssa_undef_instr *instr, validate_state *state)
 394 {
 395    validate_ssa_def(&instr->def, state);
 396 }
 397
 398 static void
 399 validate_phi_instr(nir_phi_instr *instr, validate_state *state)
 400 {
 401    /*
 402     * don't validate the sources until we get to them from their predecessor
 403     * basic blocks, to avoid validating an SSA use before its definition.
 404     */
 405
 406    validate_dest(&instr->dest, state);
 407
 408    exec_list_validate(&instr->srcs);
 409    assert(exec_list_length(&instr->srcs) ==
 410           state->block->predecessors->entries);
 411 }
 412
 413 static void
 414 validate_instr(nir_instr *instr, validate_state *state)
 415 {
 416    assert(instr->block == state->block);
 417
 418    state->instr = instr;
 419
 420    switch (instr->type) {
 421    case nir_instr_type_alu:
 422       validate_alu_instr(nir_instr_as_alu(instr), state);
 423       break;
 424
 425    case nir_instr_type_call:
 426       validate_call_instr(nir_instr_as_call(instr), state);
 427       break;
 428
 429    case nir_instr_type_intrinsic:
 430       validate_intrinsic_instr(nir_instr_as_intrinsic(instr), state);
 431       break;
 432
 433    case nir_instr_type_texture:
 434       validate_tex_instr(nir_instr_as_texture(instr), state);
 435       break;
 436
 437    case nir_instr_type_load_const:
 438       validate_load_const_instr(nir_instr_as_load_const(instr), state);
 439       break;
 440
 441    case nir_instr_type_phi:
 442       validate_phi_instr(nir_instr_as_phi(instr), state);
 443       break;
 444
 445    case nir_instr_type_ssa_undef:
 446       validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr), state);
 447       break;
 448
 449    case nir_instr_type_jump:
 450       break;
 451
 452    default:
 453       assert(!"Invalid ALU instruction type");
 454       break;
 455    }
 456 }
 457
 458 static void
 459 validate_phi_src(nir_phi_instr *instr, nir_block *pred, validate_state *state)
 460 {
 461    state->instr = &instr->instr;
 462
 463    assert(instr->dest.is_ssa);
 464
 465    exec_list_validate(&instr->srcs);
 466    foreach_list_typed(nir_phi_src, src, node, &instr->srcs) {
 467       if (src->pred == pred) {
 468          unsigned num_components;
 469          if (src->src.is_ssa)
 470             num_components = src->src.ssa->num_components;
 471          else {
 472             if (src->src.reg.reg->is_packed)
 473                num_components = 4; /* can't check anything */
 474             else
 475                num_components = src->src.reg.reg->num_components;
 476          }
 477          assert(num_components == instr->dest.ssa.num_components);
 478
 479          validate_src(&src->src, state);
 480          return;
 481       }
 482    }
 483
 484    abort();
 485 }
 486
 487 static void
 488 validate_phi_srcs(nir_block *block, nir_block *succ, validate_state *state)
 489 {
 490    nir_foreach_instr(succ, instr) {
 491       if (instr->type != nir_instr_type_phi)
 492          break;
 493
 494       validate_phi_src(nir_instr_as_phi(instr), block, state);
 495    }
 496 }
 497
 498 static void validate_cf_node(nir_cf_node *node, validate_state *state);
 499
 500 static void
 501 validate_block(nir_block *block, validate_state *state)
 502 {
 503    assert(block->cf_node.parent == state->parent_node);
 504
 505    state->block = block;
 506
 507    exec_list_validate(&block->instr_list);
 508    nir_foreach_instr(block, instr) {
 509       if (instr->type == nir_instr_type_phi) {
 510          assert(instr == nir_block_first_instr(block) ||
 511                 nir_instr_prev(instr)->type == nir_instr_type_phi);
 512       }
 513
 514       if (instr->type == nir_instr_type_jump) {
 515          assert(instr == nir_block_last_instr(block));
 516       }
 517
 518       validate_instr(instr, state);
 519    }
 520
 521    assert(block->successors[0] != NULL);
 522
 523    for (unsigned i = 0; i < 2; i++) {
 524       if (block->successors[i] != NULL) {
 525          struct set_entry *entry =
 526             _mesa_set_search(block->successors[i]->predecessors,
 527                              _mesa_hash_pointer(block), block);
 528          assert(entry);
 529
 530          validate_phi_srcs(block, block->successors[i], state);
 531       }
 532    }
 533
 534    if (!exec_list_is_empty(&block->instr_list) &&
 535        nir_block_last_instr(block)->type == nir_instr_type_jump)
 536       assert(block->successors[1] == NULL);
 537 }
 538
 539 static void
 540 validate_if(nir_if *if_stmt, validate_state *state)
 541 {
 542    assert(!exec_node_is_head_sentinel(if_stmt->cf_node.node.prev));
 543    nir_cf_node *prev_node = nir_cf_node_prev(&if_stmt->cf_node);
 544    assert(prev_node->type == nir_cf_node_block);
 545
 546    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 547    assert(&prev_block->successors[0]->cf_node ==
 548           nir_if_first_then_node(if_stmt));
 549    assert(&prev_block->successors[1]->cf_node ==
 550           nir_if_first_else_node(if_stmt));
 551
 552    assert(!exec_node_is_tail_sentinel(if_stmt->cf_node.node.next));
 553    nir_cf_node *next_node = nir_cf_node_next(&if_stmt->cf_node);
 554    assert(next_node->type == nir_cf_node_block);
 555
 556    if (!if_stmt->condition.is_ssa) {
 557       nir_register *reg = if_stmt->condition.reg.reg;
 558       struct set_entry *entry =
 559          _mesa_set_search(reg->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 560       assert(entry);
 561    } else {
 562       nir_ssa_def *def = if_stmt->condition.ssa;
 563       struct set_entry *entry =
 564          _mesa_set_search(def->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 565       assert(entry);
 566    }
 567
 568    assert(!exec_list_is_empty(&if_stmt->then_list));
 569    assert(!exec_list_is_empty(&if_stmt->else_list));
 570
 571    nir_cf_node *old_parent = state->parent_node;
 572    state->parent_node = &if_stmt->cf_node;
 573
 574    exec_list_validate(&if_stmt->then_list);
 575    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->then_list) {
 576       validate_cf_node(cf_node, state);
 577    }
 578
 579    exec_list_validate(&if_stmt->else_list);
 580    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->else_list) {
 581       validate_cf_node(cf_node, state);
 582    }
 583
 584    state->parent_node = old_parent;
 585 }
 586
 587 static void
 588 validate_loop(nir_loop *loop, validate_state *state)
 589 {
 590    assert(!exec_node_is_head_sentinel(loop->cf_node.node.prev));
 591    nir_cf_node *prev_node = nir_cf_node_prev(&loop->cf_node);
 592    assert(prev_node->type == nir_cf_node_block);
 593
 594    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 595    assert(&prev_block->successors[0]->cf_node == nir_loop_first_cf_node(loop));
 596    assert(prev_block->successors[1] == NULL);
 597
 598    assert(!exec_node_is_tail_sentinel(loop->cf_node.node.next));
 599    nir_cf_node *next_node = nir_cf_node_next(&loop->cf_node);
 600    assert(next_node->type == nir_cf_node_block);
 601
 602    assert(!exec_list_is_empty(&loop->body));
 603
 604    nir_cf_node *old_parent = state->parent_node;
 605    state->parent_node = &loop->cf_node;
 606
 607    exec_list_validate(&loop->body);
 608    foreach_list_typed(nir_cf_node, cf_node, node, &loop->body) {
 609       validate_cf_node(cf_node, state);
 610    }
 611
 612    state->parent_node = old_parent;
 613 }
 614
 615 static void
 616 validate_cf_node(nir_cf_node *node, validate_state *state)
 617 {
 618    assert(node->parent == state->parent_node);
 619
 620    switch (node->type) {
 621    case nir_cf_node_block:
 622       validate_block(nir_cf_node_as_block(node), state);
 623       break;
 624
 625    case nir_cf_node_if:
 626       validate_if(nir_cf_node_as_if(node), state);
 627       break;
 628
 629    case nir_cf_node_loop:
 630       validate_loop(nir_cf_node_as_loop(node), state);
 631       break;
 632
 633    default:
 634       assert(!"Invalid ALU instruction type");
 635       break;
 636    }
 637 }
 638
 639 static void
 640 prevalidate_reg_decl(nir_register *reg, bool is_global, validate_state *state)
 641 {
 642    assert(reg->is_global == is_global);
 643
 644    if (is_global)
 645       assert(reg->index < state->shader->reg_alloc);
 646    else
 647       assert(reg->index < state->impl->reg_alloc);
 648    assert(!BITSET_TEST(state->regs_found, reg->index));
 649    BITSET_SET(state->regs_found, reg->index);
 650
 651    reg_validate_state *reg_state = ralloc(state->regs, reg_validate_state);
 652    reg_state->uses = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 653    reg_state->defs = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 654
 655    reg_state->where_defined = is_global ? NULL : state->impl;
 656
 657    _mesa_hash_table_insert(state->regs, reg, reg_state);
 658 }
 659
 660 static void
 661 postvalidate_reg_decl(nir_register *reg, validate_state *state)
 662 {
 663    struct hash_entry *entry = _mesa_hash_table_search(state->regs, reg);
 664
 665    reg_validate_state *reg_state = (reg_validate_state *) entry->data;
 666
 667    if (reg_state->uses->entries != reg->uses->entries) {
 668       printf("extra entries in register uses:\n");
 669       struct set_entry *entry;
 670       set_foreach(reg->uses, entry) {
 671          struct set_entry *entry2 =
 672             _mesa_set_search(reg_state->uses, _mesa_hash_pointer(entry->key),
 673                              entry->key);
 674
 675          if (entry2 == NULL) {
 676             printf("%p\n", entry->key);
 677          }
 678       }
 679
 680       abort();
 681    }
 682
 683    if (reg_state->defs->entries != reg->defs->entries) {
 684       printf("extra entries in register defs:\n");
 685       struct set_entry *entry;
 686       set_foreach(reg->defs, entry) {
 687          struct set_entry *entry2 =
 688             _mesa_set_search(reg_state->defs, _mesa_hash_pointer(entry->key),
 689                              entry->key);
 690
 691          if (entry2 == NULL) {
 692             printf("%p\n", entry->key);
 693          }
 694       }
 695
 696       abort();
 697    }
 698 }
 699
 700 static void
 701 validate_var_decl(nir_variable *var, bool is_global, validate_state *state)
 702 {
 703    assert(is_global != (var->data.mode == nir_var_local));
 704
 705    /*
 706     * TODO validate some things ir_validate.cpp does (requires more GLSL type
 707     * support)
 708     */
 709
 710    if (!is_global) {
 711       _mesa_hash_table_insert(state->var_defs, var, state->impl);
 712    }
 713 }
 714
 715 static void
 716 validate_function_impl(nir_function_impl *impl, validate_state *state)
 717 {
 718    assert(impl->overload->impl == impl);
 719    assert(impl->cf_node.parent == NULL);
 720
 721    assert(impl->num_params == impl->overload->num_params);
 722    for (unsigned i = 0; i < impl->num_params; i++)
 723       assert(impl->params[i]->type == impl->overload->params[i].type);
 724
 725    if (glsl_type_is_void(impl->overload->return_type))
 726       assert(impl->return_var == NULL);
 727    else
 728       assert(impl->return_var->type == impl->overload->return_type);
 729
 730    assert(exec_list_is_empty(&impl->end_block->instr_list));
 731    assert(impl->end_block->successors[0] == NULL);
 732    assert(impl->end_block->successors[1] == NULL);
 733
 734    state->impl = impl;
 735    state->parent_node = &impl->cf_node;
 736
 737    exec_list_validate(&impl->locals);
 738    foreach_list_typed(nir_variable, var, node, &impl->locals) {
 739       validate_var_decl(var, false, state);
 740    }
 741
 742    state->regs_found = realloc(state->regs_found,
 743                                BITSET_WORDS(impl->reg_alloc) *
 744                                sizeof(BITSET_WORD));
 745    memset(state->regs_found, 0, BITSET_WORDS(impl->reg_alloc) *
 746                                 sizeof(BITSET_WORD));
 747    exec_list_validate(&impl->registers);
 748    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 749       prevalidate_reg_decl(reg, false, state);
 750    }
 751
 752    state->ssa_defs_found = realloc(state->ssa_defs_found,
 753                                    BITSET_WORDS(impl->ssa_alloc) *
 754                                    sizeof(BITSET_WORD));
 755    memset(state->ssa_defs_found, 0, BITSET_WORDS(impl->ssa_alloc) *
 756                                     sizeof(BITSET_WORD));
 757    exec_list_validate(&impl->body);
 758    foreach_list_typed(nir_cf_node, node, node, &impl->body) {
 759       validate_cf_node(node, state);
 760    }
 761
 762    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 763       postvalidate_reg_decl(reg, state);
 764    }
 765 }
 766
 767 static void
 768 validate_function_overload(nir_function_overload *overload,
 769                            validate_state *state)
 770 {
 771    if (overload->impl != NULL)
 772       validate_function_impl(overload->impl, state);
 773 }
 774
 775 static void
 776 validate_function(nir_function *func, validate_state *state)
 777 {
 778    exec_list_validate(&func->overload_list);
 779    foreach_list_typed(nir_function_overload, overload, node, &func->overload_list) {
 780       assert(overload->function == func);
 781       validate_function_overload(overload, state);
 782    }
 783 }
 784
 785 static void
 786 init_validate_state(validate_state *state)
 787 {
 788    state->regs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 789                                          _mesa_key_pointer_equal);
 790    state->ssa_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 791                                              _mesa_key_pointer_equal);
 792    state->ssa_defs_found = NULL;
 793    state->regs_found = NULL;
 794    state->var_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 795                                              _mesa_key_pointer_equal);
 796 }
 797
 798 static void
 799 destroy_validate_state(validate_state *state)
 800 {
 801    _mesa_hash_table_destroy(state->regs, NULL);
 802    _mesa_hash_table_destroy(state->ssa_defs, NULL);
 803    free(state->ssa_defs_found);
 804    free(state->regs_found);
 805    _mesa_hash_table_destroy(state->var_defs, NULL);
 806 }
 807
 808 void
 809 nir_validate_shader(nir_shader *shader)
 810 {
 811    validate_state state;
 812    init_validate_state(&state);
 813
 814    state.shader = shader;
 815
 816    struct hash_entry *entry;
 817    hash_table_foreach(shader->uniforms, entry) {
 818       validate_var_decl((nir_variable *) entry->data, true, &state);
 819    }
 820
 821    hash_table_foreach(shader->inputs, entry) {
 822      validate_var_decl((nir_variable *) entry->data, true, &state);
 823    }
 824
 825    hash_table_foreach(shader->outputs, entry) {
 826       validate_var_decl((nir_variable *) entry->data, true, &state);
 827    }
 828
 829    exec_list_validate(&shader->globals);
 830    foreach_list_typed(nir_variable, var, node, &shader->globals) {
 831      validate_var_decl(var, true, &state);
 832    }
 833
 834    exec_list_validate(&shader->system_values);
 835    foreach_list_typed(nir_variable, var, node, &shader->system_values) {
 836      validate_var_decl(var, true, &state);
 837    }
 838
 839    state.regs_found = realloc(state.regs_found,
 840                               BITSET_WORDS(shader->reg_alloc) *
 841                               sizeof(BITSET_WORD));
 842    memset(state.regs_found, 0, BITSET_WORDS(shader->reg_alloc) *
 843                                sizeof(BITSET_WORD));
 844    exec_list_validate(&shader->registers);
 845    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 846       prevalidate_reg_decl(reg, true, &state);
 847    }
 848
 849    exec_list_validate(&shader->functions);
 850    foreach_list_typed(nir_function, func, node, &shader->functions) {
 851       validate_function(func, &state);
 852    }
 853
 854    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 855       postvalidate_reg_decl(reg, &state);
 856    }
 857
 858    destroy_validate_state(&state);
 859 }