src/glsl/nir/nir_validate.c

   1 /*
   2  * Copyright © 2014 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *    Connor Abbott (cwabbott0@gmail.com)
  25  *
  26  */
  27
  28 #include "nir.h"
  29 #include <assert.h>
  30
  31 /*
  32  * This file checks for invalid IR indicating a bug somewhere in the compiler.
  33  */
  34
  35 /*
  36  * Per-register validation state.
  37  */
  38
  39 typedef struct {
  40    /*
  41     * equivalent to the uses and defs in nir_register, but built up by the
  42     * validator. At the end, we verify that the sets have the same entries.
  43     */
  44    struct set *uses, *defs;
  45    nir_function_impl *where_defined; /* NULL for global registers */
  46 } reg_validate_state;
  47
  48 typedef struct {
  49    /* map of register -> validation state (struct above) */
  50    struct hash_table *regs;
  51
  52    /* the current shader being validated */
  53    nir_shader *shader;
  54
  55    /* the current instruction being validated */
  56    nir_instr *instr;
  57
  58    /* the current basic block being validated */
  59    nir_block *block;
  60
  61    /* the current if statement being validated */
  62    nir_if *if_stmt;
  63
  64    /* the parent of the current cf node being visited */
  65    nir_cf_node *parent_node;
  66
  67    /* the current function implementation being validated */
  68    nir_function_impl *impl;
  69
  70    /* map of SSA value -> function implementation where it is defined */
  71    struct hash_table *ssa_defs;
  72
  73    /* bitset of ssa definitions we have found; used to check uniqueness */
  74    BITSET_WORD *ssa_defs_found;
  75
  76    /* bitset of registers we have currently found; used to check uniqueness */
  77    BITSET_WORD *regs_found;
  78
  79    /* map of local variable -> function implementation where it is defined */
  80    struct hash_table *var_defs;
  81 } validate_state;
  82
  83 static void validate_src(nir_src *src, validate_state *state);
  84
  85 static void
  86 validate_reg_src(nir_reg_src *src, validate_state *state)
  87 {
  88    assert(src->reg != NULL);
  89
  90    struct set_entry *entry =
  91       _mesa_set_search(src->reg->uses, _mesa_hash_pointer(state->instr),
  92                        state->instr);
  93    assert(entry && "use not in nir_register.uses");
  94
  95    struct hash_entry *entry2;
  96    entry2 = _mesa_hash_table_search(state->regs, src->reg);
  97
  98    assert(entry2);
  99
 100    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 101    _mesa_set_add(reg_state->uses, _mesa_hash_pointer(state->instr),
 102                  state->instr);
 103
 104    if (!src->reg->is_global) {
 105       assert(reg_state->where_defined == state->impl &&
 106              "using a register declared in a different function");
 107    }
 108
 109    assert((src->reg->num_array_elems == 0 ||
 110           src->base_offset < src->reg->num_array_elems) &&
 111           "definitely out-of-bounds array access");
 112
 113    if (src->indirect) {
 114       assert(src->reg->num_array_elems != 0);
 115       assert((src->indirect->is_ssa || src->indirect->reg.indirect == NULL) &&
 116              "only one level of indirection allowed");
 117       validate_src(src->indirect, state);
 118    }
 119 }
 120
 121 static void
 122 validate_ssa_src(nir_ssa_def *def, validate_state *state)
 123 {
 124    assert(def != NULL);
 125
 126    struct hash_entry *entry = _mesa_hash_table_search(state->ssa_defs, def);
 127
 128    assert(entry);
 129
 130    assert((nir_function_impl *) entry->data == state->impl &&
 131           "using an SSA value defined in a different function");
 132
 133    struct set_entry *entry2;
 134
 135    entry2 = _mesa_set_search(def->uses, _mesa_hash_pointer(state->instr),
 136                               state->instr);
 137
 138    assert(entry2 && "SSA use missing");
 139
 140    /* TODO validate that the use is dominated by the definition */
 141 }
 142
 143 static void
 144 validate_src(nir_src *src, validate_state *state)
 145 {
 146    if (src->is_ssa)
 147       validate_ssa_src(src->ssa, state);
 148    else
 149       validate_reg_src(&src->reg, state);
 150 }
 151
 152 static void
 153 validate_alu_src(nir_alu_instr *instr, unsigned index, validate_state *state)
 154 {
 155    nir_alu_src *src = &instr->src[index];
 156
 157    unsigned num_components;
 158    if (src->src.is_ssa)
 159       num_components = src->src.ssa->num_components;
 160    else {
 161       if (src->src.reg.reg->is_packed)
 162          num_components = 4; /* can't check anything */
 163       else
 164          num_components = src->src.reg.reg->num_components;
 165    }
 166    for (unsigned i = 0; i < 4; i++) {
 167       assert(src->swizzle[i] < 4);
 168
 169       if (nir_alu_instr_channel_used(instr, index, i))
 170          assert(src->swizzle[i] < num_components);
 171    }
 172
 173    validate_src(&src->src, state);
 174 }
 175
 176 static void
 177 validate_reg_dest(nir_reg_dest *dest, validate_state *state)
 178 {
 179    assert(dest->reg != NULL);
 180
 181    struct set_entry *entry =
 182       _mesa_set_search(dest->reg->defs, _mesa_hash_pointer(state->instr),
 183                        state->instr);
 184    assert(entry && "definition not in nir_register.defs");
 185
 186    struct hash_entry *entry2;
 187    entry2 = _mesa_hash_table_search(state->regs, dest->reg);
 188
 189    assert(entry2);
 190
 191    reg_validate_state *reg_state = (reg_validate_state *) entry2->data;
 192    _mesa_set_add(reg_state->defs, _mesa_hash_pointer(state->instr),
 193                  state->instr);
 194
 195    if (!dest->reg->is_global) {
 196       assert(reg_state->where_defined == state->impl &&
 197              "writing to a register declared in a different function");
 198    }
 199
 200    assert((dest->reg->num_array_elems == 0 ||
 201           dest->base_offset < dest->reg->num_array_elems) &&
 202           "definitely out-of-bounds array access");
 203
 204    if (dest->indirect) {
 205       assert(dest->reg->num_array_elems != 0);
 206       assert((dest->indirect->is_ssa || dest->indirect->reg.indirect == NULL) &&
 207              "only one level of indirection allowed");
 208       validate_src(dest->indirect, state);
 209    }
 210 }
 211
 212 static void
 213 validate_ssa_def(nir_ssa_def *def, validate_state *state)
 214 {
 215    assert(def->index < state->impl->ssa_alloc);
 216    assert(!BITSET_TEST(state->ssa_defs_found, def->index));
 217    BITSET_SET(state->ssa_defs_found, def->index);
 218
 219    assert(def->num_components <= 4);
 220    _mesa_hash_table_insert(state->ssa_defs, def, state->impl);
 221 }
 222
 223 static void
 224 validate_dest(nir_dest *dest, validate_state *state)
 225 {
 226    if (dest->is_ssa)
 227       validate_ssa_def(&dest->ssa, state);
 228    else
 229       validate_reg_dest(&dest->reg, state);
 230 }
 231
 232 static void
 233 validate_alu_dest(nir_alu_dest *dest, validate_state *state)
 234 {
 235    unsigned dest_size =
 236       dest->dest.is_ssa ? dest->dest.ssa.num_components
 237                         : dest->dest.reg.reg->num_components;
 238    bool is_packed = !dest->dest.is_ssa && dest->dest.reg.reg->is_packed;
 239    /*
 240     * validate that the instruction doesn't write to components not in the
 241     * register/SSA value
 242     */
 243    assert(is_packed || !(dest->write_mask & ~((1 << dest_size) - 1)));
 244    validate_dest(&dest->dest, state);
 245 }
 246
 247 static void
 248 validate_alu_instr(nir_alu_instr *instr, validate_state *state)
 249 {
 250    assert(instr->op < nir_num_opcodes);
 251
 252    validate_alu_dest(&instr->dest, state);
 253
 254    for (unsigned i = 0; i < nir_op_infos[instr->op].num_inputs; i++) {
 255       validate_alu_src(instr, i, state);
 256    }
 257 }
 258
 259 static void
 260 validate_deref_chain(nir_deref *deref, validate_state *state)
 261 {
 262    nir_deref *parent = NULL;
 263    while (deref != NULL) {
 264       switch (deref->deref_type) {
 265       case nir_deref_type_array:
 266          assert(deref->type == glsl_get_array_element(parent->type));
 267          if (nir_deref_as_array(deref)->deref_array_type ==
 268              nir_deref_array_type_indirect)
 269             validate_src(&nir_deref_as_array(deref)->indirect, state);
 270          break;
 271
 272       case nir_deref_type_struct:
 273          assert(deref->type ==
 274                 glsl_get_struct_field(parent->type,
 275                                       nir_deref_as_struct(deref)->index));
 276          break;
 277
 278       case nir_deref_type_var:
 279          break;
 280
 281       default:
 282          assert(!"Invalid deref type");
 283          break;
 284       }
 285
 286       parent = deref;
 287       deref = deref->child;
 288    }
 289 }
 290
 291 static void
 292 validate_var_use(nir_variable *var, validate_state *state)
 293 {
 294    if (var->data.mode == nir_var_local) {
 295       struct hash_entry *entry = _mesa_hash_table_search(state->var_defs, var);
 296
 297       assert(entry);
 298       assert((nir_function_impl *) entry->data == state->impl);
 299    }
 300 }
 301
 302 static void
 303 validate_deref_var(nir_deref_var *deref, validate_state *state)
 304 {
 305    assert(deref != NULL);
 306    assert(deref->deref.type == deref->var->type);
 307
 308    validate_var_use(deref->var, state);
 309
 310    validate_deref_chain(&deref->deref, state);
 311 }
 312
 313 static void
 314 validate_intrinsic_instr(nir_intrinsic_instr *instr, validate_state *state)
 315 {
 316    unsigned num_srcs = nir_intrinsic_infos[instr->intrinsic].num_srcs;
 317    for (unsigned i = 0; i < num_srcs; i++) {
 318       unsigned components_read =
 319          nir_intrinsic_infos[instr->intrinsic].src_components[i];
 320       if (components_read == 0)
 321          components_read = instr->num_components;
 322
 323       assert(components_read > 0);
 324
 325       if (instr->src[i].is_ssa) {
 326          assert(components_read <= instr->src[i].ssa->num_components);
 327       } else if (!instr->src[i].reg.reg->is_packed) {
 328          assert(components_read <= instr->src[i].reg.reg->num_components);
 329       }
 330
 331       validate_src(&instr->src[i], state);
 332    }
 333
 334    if (nir_intrinsic_infos[instr->intrinsic].has_dest) {
 335       unsigned components_written =
 336          nir_intrinsic_infos[instr->intrinsic].dest_components;
 337       if (components_written == 0)
 338          components_written = instr->num_components;
 339
 340       assert(components_written > 0);
 341
 342       if (instr->dest.is_ssa) {
 343          assert(components_written <= instr->dest.ssa.num_components);
 344       } else if (!instr->dest.reg.reg->is_packed) {
 345          assert(components_written <= instr->dest.reg.reg->num_components);
 346       }
 347
 348       validate_dest(&instr->dest, state);
 349    }
 350
 351    unsigned num_vars = nir_intrinsic_infos[instr->intrinsic].num_variables;
 352    for (unsigned i = 0; i < num_vars; i++) {
 353       validate_deref_var(instr->variables[i], state);
 354    }
 355
 356    switch (instr->intrinsic) {
 357    case nir_intrinsic_load_var:
 358       assert(instr->variables[0]->var->data.mode != nir_var_shader_out);
 359       break;
 360    case nir_intrinsic_store_var:
 361       assert(instr->variables[0]->var->data.mode != nir_var_shader_in &&
 362              instr->variables[0]->var->data.mode != nir_var_uniform);
 363       break;
 364    case nir_intrinsic_copy_var:
 365       assert(instr->variables[0]->var->data.mode != nir_var_shader_in &&
 366              instr->variables[0]->var->data.mode != nir_var_uniform);
 367       assert(instr->variables[1]->var->data.mode != nir_var_shader_out);
 368       break;
 369    default:
 370       break;
 371    }
 372 }
 373
 374 static void
 375 validate_tex_instr(nir_tex_instr *instr, validate_state *state)
 376 {
 377    validate_dest(&instr->dest, state);
 378
 379    bool src_type_seen[nir_num_texinput_types];
 380    for (unsigned i = 0; i < nir_num_texinput_types; i++)
 381       src_type_seen[i] = false;
 382
 383    for (unsigned i = 0; i < instr->num_srcs; i++) {
 384       assert(!src_type_seen[instr->src_type[i]]);
 385       src_type_seen[instr->src_type[i]] = true;
 386       validate_src(&instr->src[i], state);
 387    }
 388
 389    if (instr->sampler != NULL)
 390       validate_deref_var(instr->sampler, state);
 391 }
 392
 393 static void
 394 validate_call_instr(nir_call_instr *instr, validate_state *state)
 395 {
 396    if (instr->return_deref == NULL)
 397       assert(glsl_type_is_void(instr->callee->return_type));
 398    else
 399       assert(instr->return_deref->deref.type == instr->callee->return_type);
 400
 401    assert(instr->num_params == instr->callee->num_params);
 402
 403    for (unsigned i = 0; i < instr->num_params; i++) {
 404       assert(instr->callee->params[i].type == instr->params[i]->deref.type);
 405       validate_deref_var(instr->params[i], state);
 406    }
 407
 408    validate_deref_var(instr->return_deref, state);
 409 }
 410
 411 static void
 412 validate_load_const_instr(nir_load_const_instr *instr, validate_state *state)
 413 {
 414    validate_dest(&instr->dest, state);
 415
 416    if (instr->array_elems != 0) {
 417       assert(!instr->dest.is_ssa);
 418       assert(instr->dest.reg.base_offset + instr->array_elems <=
 419              instr->dest.reg.reg->num_array_elems);
 420    }
 421 }
 422
 423 static void
 424 validate_ssa_undef_instr(nir_ssa_undef_instr *instr, validate_state *state)
 425 {
 426    validate_ssa_def(&instr->def, state);
 427 }
 428
 429 static void
 430 validate_phi_instr(nir_phi_instr *instr, validate_state *state)
 431 {
 432    /*
 433     * don't validate the sources until we get to them from their predecessor
 434     * basic blocks, to avoid validating an SSA use before its definition.
 435     */
 436
 437    validate_dest(&instr->dest, state);
 438
 439    exec_list_validate(&instr->srcs);
 440    assert(exec_list_length(&instr->srcs) ==
 441           state->block->predecessors->entries);
 442 }
 443
 444 static void
 445 validate_instr(nir_instr *instr, validate_state *state)
 446 {
 447    assert(instr->block == state->block);
 448
 449    state->instr = instr;
 450
 451    switch (instr->type) {
 452    case nir_instr_type_alu:
 453       validate_alu_instr(nir_instr_as_alu(instr), state);
 454       break;
 455
 456    case nir_instr_type_call:
 457       validate_call_instr(nir_instr_as_call(instr), state);
 458       break;
 459
 460    case nir_instr_type_intrinsic:
 461       validate_intrinsic_instr(nir_instr_as_intrinsic(instr), state);
 462       break;
 463
 464    case nir_instr_type_tex:
 465       validate_tex_instr(nir_instr_as_tex(instr), state);
 466       break;
 467
 468    case nir_instr_type_load_const:
 469       validate_load_const_instr(nir_instr_as_load_const(instr), state);
 470       break;
 471
 472    case nir_instr_type_phi:
 473       validate_phi_instr(nir_instr_as_phi(instr), state);
 474       break;
 475
 476    case nir_instr_type_ssa_undef:
 477       validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr), state);
 478       break;
 479
 480    case nir_instr_type_jump:
 481       break;
 482
 483    default:
 484       assert(!"Invalid ALU instruction type");
 485       break;
 486    }
 487 }
 488
 489 static void
 490 validate_phi_src(nir_phi_instr *instr, nir_block *pred, validate_state *state)
 491 {
 492    state->instr = &instr->instr;
 493
 494    assert(instr->dest.is_ssa);
 495
 496    exec_list_validate(&instr->srcs);
 497    foreach_list_typed(nir_phi_src, src, node, &instr->srcs) {
 498       if (src->pred == pred) {
 499          unsigned num_components;
 500          if (src->src.is_ssa)
 501             num_components = src->src.ssa->num_components;
 502          else {
 503             if (src->src.reg.reg->is_packed)
 504                num_components = 4; /* can't check anything */
 505             else
 506                num_components = src->src.reg.reg->num_components;
 507          }
 508          assert(num_components == instr->dest.ssa.num_components);
 509
 510          validate_src(&src->src, state);
 511          return;
 512       }
 513    }
 514
 515    abort();
 516 }
 517
 518 static void
 519 validate_phi_srcs(nir_block *block, nir_block *succ, validate_state *state)
 520 {
 521    nir_foreach_instr(succ, instr) {
 522       if (instr->type != nir_instr_type_phi)
 523          break;
 524
 525       validate_phi_src(nir_instr_as_phi(instr), block, state);
 526    }
 527 }
 528
 529 static void validate_cf_node(nir_cf_node *node, validate_state *state);
 530
 531 static void
 532 validate_block(nir_block *block, validate_state *state)
 533 {
 534    assert(block->cf_node.parent == state->parent_node);
 535
 536    state->block = block;
 537
 538    exec_list_validate(&block->instr_list);
 539    nir_foreach_instr(block, instr) {
 540       if (instr->type == nir_instr_type_phi) {
 541          assert(instr == nir_block_first_instr(block) ||
 542                 nir_instr_prev(instr)->type == nir_instr_type_phi);
 543       }
 544
 545       if (instr->type == nir_instr_type_jump) {
 546          assert(instr == nir_block_last_instr(block));
 547       }
 548
 549       validate_instr(instr, state);
 550    }
 551
 552    assert(block->successors[0] != NULL);
 553
 554    for (unsigned i = 0; i < 2; i++) {
 555       if (block->successors[i] != NULL) {
 556          struct set_entry *entry =
 557             _mesa_set_search(block->successors[i]->predecessors,
 558                              _mesa_hash_pointer(block), block);
 559          assert(entry);
 560
 561          validate_phi_srcs(block, block->successors[i], state);
 562       }
 563    }
 564
 565    if (!exec_list_is_empty(&block->instr_list) &&
 566        nir_block_last_instr(block)->type == nir_instr_type_jump)
 567       assert(block->successors[1] == NULL);
 568 }
 569
 570 static void
 571 validate_if(nir_if *if_stmt, validate_state *state)
 572 {
 573    assert(!exec_node_is_head_sentinel(if_stmt->cf_node.node.prev));
 574    nir_cf_node *prev_node = nir_cf_node_prev(&if_stmt->cf_node);
 575    assert(prev_node->type == nir_cf_node_block);
 576
 577    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 578    assert(&prev_block->successors[0]->cf_node ==
 579           nir_if_first_then_node(if_stmt));
 580    assert(&prev_block->successors[1]->cf_node ==
 581           nir_if_first_else_node(if_stmt));
 582
 583    assert(!exec_node_is_tail_sentinel(if_stmt->cf_node.node.next));
 584    nir_cf_node *next_node = nir_cf_node_next(&if_stmt->cf_node);
 585    assert(next_node->type == nir_cf_node_block);
 586
 587    if (!if_stmt->condition.is_ssa) {
 588       nir_register *reg = if_stmt->condition.reg.reg;
 589       struct set_entry *entry =
 590          _mesa_set_search(reg->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 591       assert(entry);
 592    } else {
 593       nir_ssa_def *def = if_stmt->condition.ssa;
 594       struct set_entry *entry =
 595          _mesa_set_search(def->if_uses, _mesa_hash_pointer(if_stmt), if_stmt);
 596       assert(entry);
 597    }
 598
 599    assert(!exec_list_is_empty(&if_stmt->then_list));
 600    assert(!exec_list_is_empty(&if_stmt->else_list));
 601
 602    nir_cf_node *old_parent = state->parent_node;
 603    state->parent_node = &if_stmt->cf_node;
 604
 605    exec_list_validate(&if_stmt->then_list);
 606    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->then_list) {
 607       validate_cf_node(cf_node, state);
 608    }
 609
 610    exec_list_validate(&if_stmt->else_list);
 611    foreach_list_typed(nir_cf_node, cf_node, node, &if_stmt->else_list) {
 612       validate_cf_node(cf_node, state);
 613    }
 614
 615    state->parent_node = old_parent;
 616 }
 617
 618 static void
 619 validate_loop(nir_loop *loop, validate_state *state)
 620 {
 621    assert(!exec_node_is_head_sentinel(loop->cf_node.node.prev));
 622    nir_cf_node *prev_node = nir_cf_node_prev(&loop->cf_node);
 623    assert(prev_node->type == nir_cf_node_block);
 624
 625    nir_block *prev_block = nir_cf_node_as_block(prev_node);
 626    assert(&prev_block->successors[0]->cf_node == nir_loop_first_cf_node(loop));
 627    assert(prev_block->successors[1] == NULL);
 628
 629    assert(!exec_node_is_tail_sentinel(loop->cf_node.node.next));
 630    nir_cf_node *next_node = nir_cf_node_next(&loop->cf_node);
 631    assert(next_node->type == nir_cf_node_block);
 632
 633    assert(!exec_list_is_empty(&loop->body));
 634
 635    nir_cf_node *old_parent = state->parent_node;
 636    state->parent_node = &loop->cf_node;
 637
 638    exec_list_validate(&loop->body);
 639    foreach_list_typed(nir_cf_node, cf_node, node, &loop->body) {
 640       validate_cf_node(cf_node, state);
 641    }
 642
 643    state->parent_node = old_parent;
 644 }
 645
 646 static void
 647 validate_cf_node(nir_cf_node *node, validate_state *state)
 648 {
 649    assert(node->parent == state->parent_node);
 650
 651    switch (node->type) {
 652    case nir_cf_node_block:
 653       validate_block(nir_cf_node_as_block(node), state);
 654       break;
 655
 656    case nir_cf_node_if:
 657       validate_if(nir_cf_node_as_if(node), state);
 658       break;
 659
 660    case nir_cf_node_loop:
 661       validate_loop(nir_cf_node_as_loop(node), state);
 662       break;
 663
 664    default:
 665       assert(!"Invalid ALU instruction type");
 666       break;
 667    }
 668 }
 669
 670 static void
 671 prevalidate_reg_decl(nir_register *reg, bool is_global, validate_state *state)
 672 {
 673    assert(reg->is_global == is_global);
 674
 675    if (is_global)
 676       assert(reg->index < state->shader->reg_alloc);
 677    else
 678       assert(reg->index < state->impl->reg_alloc);
 679    assert(!BITSET_TEST(state->regs_found, reg->index));
 680    BITSET_SET(state->regs_found, reg->index);
 681
 682    reg_validate_state *reg_state = ralloc(state->regs, reg_validate_state);
 683    reg_state->uses = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 684    reg_state->defs = _mesa_set_create(reg_state, _mesa_key_pointer_equal);
 685
 686    reg_state->where_defined = is_global ? NULL : state->impl;
 687
 688    _mesa_hash_table_insert(state->regs, reg, reg_state);
 689 }
 690
 691 static void
 692 postvalidate_reg_decl(nir_register *reg, validate_state *state)
 693 {
 694    struct hash_entry *entry = _mesa_hash_table_search(state->regs, reg);
 695
 696    reg_validate_state *reg_state = (reg_validate_state *) entry->data;
 697
 698    if (reg_state->uses->entries != reg->uses->entries) {
 699       printf("extra entries in register uses:\n");
 700       struct set_entry *entry;
 701       set_foreach(reg->uses, entry) {
 702          struct set_entry *entry2 =
 703             _mesa_set_search(reg_state->uses, _mesa_hash_pointer(entry->key),
 704                              entry->key);
 705
 706          if (entry2 == NULL) {
 707             printf("%p\n", entry->key);
 708          }
 709       }
 710
 711       abort();
 712    }
 713
 714    if (reg_state->defs->entries != reg->defs->entries) {
 715       printf("extra entries in register defs:\n");
 716       struct set_entry *entry;
 717       set_foreach(reg->defs, entry) {
 718          struct set_entry *entry2 =
 719             _mesa_set_search(reg_state->defs, _mesa_hash_pointer(entry->key),
 720                              entry->key);
 721
 722          if (entry2 == NULL) {
 723             printf("%p\n", entry->key);
 724          }
 725       }
 726
 727       abort();
 728    }
 729 }
 730
 731 static void
 732 validate_var_decl(nir_variable *var, bool is_global, validate_state *state)
 733 {
 734    assert(is_global != (var->data.mode == nir_var_local));
 735
 736    /*
 737     * TODO validate some things ir_validate.cpp does (requires more GLSL type
 738     * support)
 739     */
 740
 741    if (!is_global) {
 742       _mesa_hash_table_insert(state->var_defs, var, state->impl);
 743    }
 744 }
 745
 746 static void
 747 validate_function_impl(nir_function_impl *impl, validate_state *state)
 748 {
 749    assert(impl->overload->impl == impl);
 750    assert(impl->cf_node.parent == NULL);
 751
 752    assert(impl->num_params == impl->overload->num_params);
 753    for (unsigned i = 0; i < impl->num_params; i++)
 754       assert(impl->params[i]->type == impl->overload->params[i].type);
 755
 756    if (glsl_type_is_void(impl->overload->return_type))
 757       assert(impl->return_var == NULL);
 758    else
 759       assert(impl->return_var->type == impl->overload->return_type);
 760
 761    assert(exec_list_is_empty(&impl->end_block->instr_list));
 762    assert(impl->end_block->successors[0] == NULL);
 763    assert(impl->end_block->successors[1] == NULL);
 764
 765    state->impl = impl;
 766    state->parent_node = &impl->cf_node;
 767
 768    exec_list_validate(&impl->locals);
 769    foreach_list_typed(nir_variable, var, node, &impl->locals) {
 770       validate_var_decl(var, false, state);
 771    }
 772
 773    state->regs_found = realloc(state->regs_found,
 774                                BITSET_WORDS(impl->reg_alloc) *
 775                                sizeof(BITSET_WORD));
 776    memset(state->regs_found, 0, BITSET_WORDS(impl->reg_alloc) *
 777                                 sizeof(BITSET_WORD));
 778    exec_list_validate(&impl->registers);
 779    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 780       prevalidate_reg_decl(reg, false, state);
 781    }
 782
 783    state->ssa_defs_found = realloc(state->ssa_defs_found,
 784                                    BITSET_WORDS(impl->ssa_alloc) *
 785                                    sizeof(BITSET_WORD));
 786    memset(state->ssa_defs_found, 0, BITSET_WORDS(impl->ssa_alloc) *
 787                                     sizeof(BITSET_WORD));
 788    exec_list_validate(&impl->body);
 789    foreach_list_typed(nir_cf_node, node, node, &impl->body) {
 790       validate_cf_node(node, state);
 791    }
 792
 793    foreach_list_typed(nir_register, reg, node, &impl->registers) {
 794       postvalidate_reg_decl(reg, state);
 795    }
 796 }
 797
 798 static void
 799 validate_function_overload(nir_function_overload *overload,
 800                            validate_state *state)
 801 {
 802    if (overload->impl != NULL)
 803       validate_function_impl(overload->impl, state);
 804 }
 805
 806 static void
 807 validate_function(nir_function *func, validate_state *state)
 808 {
 809    exec_list_validate(&func->overload_list);
 810    foreach_list_typed(nir_function_overload, overload, node, &func->overload_list) {
 811       assert(overload->function == func);
 812       validate_function_overload(overload, state);
 813    }
 814 }
 815
 816 static void
 817 init_validate_state(validate_state *state)
 818 {
 819    state->regs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 820                                          _mesa_key_pointer_equal);
 821    state->ssa_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 822                                              _mesa_key_pointer_equal);
 823    state->ssa_defs_found = NULL;
 824    state->regs_found = NULL;
 825    state->var_defs = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
 826                                              _mesa_key_pointer_equal);
 827 }
 828
 829 static void
 830 destroy_validate_state(validate_state *state)
 831 {
 832    _mesa_hash_table_destroy(state->regs, NULL);
 833    _mesa_hash_table_destroy(state->ssa_defs, NULL);
 834    free(state->ssa_defs_found);
 835    free(state->regs_found);
 836    _mesa_hash_table_destroy(state->var_defs, NULL);
 837 }
 838
 839 void
 840 nir_validate_shader(nir_shader *shader)
 841 {
 842    validate_state state;
 843    init_validate_state(&state);
 844
 845    state.shader = shader;
 846
 847    struct hash_entry *entry;
 848    hash_table_foreach(shader->uniforms, entry) {
 849       validate_var_decl((nir_variable *) entry->data, true, &state);
 850    }
 851
 852    hash_table_foreach(shader->inputs, entry) {
 853      validate_var_decl((nir_variable *) entry->data, true, &state);
 854    }
 855
 856    hash_table_foreach(shader->outputs, entry) {
 857       validate_var_decl((nir_variable *) entry->data, true, &state);
 858    }
 859
 860    exec_list_validate(&shader->globals);
 861    foreach_list_typed(nir_variable, var, node, &shader->globals) {
 862      validate_var_decl(var, true, &state);
 863    }
 864
 865    exec_list_validate(&shader->system_values);
 866    foreach_list_typed(nir_variable, var, node, &shader->system_values) {
 867      validate_var_decl(var, true, &state);
 868    }
 869
 870    state.regs_found = realloc(state.regs_found,
 871                               BITSET_WORDS(shader->reg_alloc) *
 872                               sizeof(BITSET_WORD));
 873    memset(state.regs_found, 0, BITSET_WORDS(shader->reg_alloc) *
 874                                sizeof(BITSET_WORD));
 875    exec_list_validate(&shader->registers);
 876    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 877       prevalidate_reg_decl(reg, true, &state);
 878    }
 879
 880    exec_list_validate(&shader->functions);
 881    foreach_list_typed(nir_function, func, node, &shader->functions) {
 882       validate_function(func, &state);
 883    }
 884
 885    foreach_list_typed(nir_register, reg, node, &shader->registers) {
 886       postvalidate_reg_decl(reg, &state);
 887    }
 888
 889    destroy_validate_state(&state);
 890 }