src/intel/vulkan/anv_descriptor_set.c

   1 /*
   2  * Copyright © 2015 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  */
  23
  24 #include <assert.h>
  25 #include <stdbool.h>
  26 #include <string.h>
  27 #include <unistd.h>
  28 #include <fcntl.h>
  29
  30 #include "anv_private.h"
  31
  32 /*
  33  * Descriptor set layouts.
  34  */
  35
  36 VkResult anv_CreateDescriptorSetLayout(
  37     VkDevice                                    _device,
  38     const VkDescriptorSetLayoutCreateInfo*      pCreateInfo,
  39     const VkAllocationCallbacks*                pAllocator,
  40     VkDescriptorSetLayout*                      pSetLayout)
  41 {
  42    ANV_FROM_HANDLE(anv_device, device, _device);
  43    struct anv_descriptor_set_layout *set_layout;
  44
  45    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO);
  46
  47    uint32_t max_binding = 0;
  48    uint32_t immutable_sampler_count = 0;
  49    for (uint32_t j = 0; j < pCreateInfo->bindingCount; j++) {
  50       max_binding = MAX2(max_binding, pCreateInfo->pBindings[j].binding);
  51       if (pCreateInfo->pBindings[j].pImmutableSamplers)
  52          immutable_sampler_count += pCreateInfo->pBindings[j].descriptorCount;
  53    }
  54
  55    size_t size = sizeof(struct anv_descriptor_set_layout) +
  56                  (max_binding + 1) * sizeof(set_layout->binding[0]) +
  57                  immutable_sampler_count * sizeof(struct anv_sampler *);
  58
  59    set_layout = anv_alloc2(&device->alloc, pAllocator, size, 8,
  60                            VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
  61    if (!set_layout)
  62       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
  63
  64    /* We just allocate all the samplers at the end of the struct */
  65    struct anv_sampler **samplers =
  66       (struct anv_sampler **)&set_layout->binding[max_binding + 1];
  67
  68    set_layout->binding_count = max_binding + 1;
  69    set_layout->shader_stages = 0;
  70    set_layout->size = 0;
  71
  72    for (uint32_t b = 0; b <= max_binding; b++) {
  73       /* Initialize all binding_layout entries to -1 */
  74       memset(&set_layout->binding[b], -1, sizeof(set_layout->binding[b]));
  75
  76       set_layout->binding[b].immutable_samplers = NULL;
  77    }
  78
  79    /* Initialize all samplers to 0 */
  80    memset(samplers, 0, immutable_sampler_count * sizeof(*samplers));
  81
  82    uint32_t sampler_count[MESA_SHADER_STAGES] = { 0, };
  83    uint32_t surface_count[MESA_SHADER_STAGES] = { 0, };
  84    uint32_t image_count[MESA_SHADER_STAGES] = { 0, };
  85    uint32_t buffer_count = 0;
  86    uint32_t dynamic_offset_count = 0;
  87
  88    for (uint32_t j = 0; j < pCreateInfo->bindingCount; j++) {
  89       const VkDescriptorSetLayoutBinding *binding = &pCreateInfo->pBindings[j];
  90       uint32_t b = binding->binding;
  91
  92       assert(binding->descriptorCount > 0);
  93       set_layout->binding[b].array_size = binding->descriptorCount;
  94       set_layout->binding[b].descriptor_index = set_layout->size;
  95       set_layout->size += binding->descriptorCount;
  96
  97       switch (binding->descriptorType) {
  98       case VK_DESCRIPTOR_TYPE_SAMPLER:
  99       case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
 100          anv_foreach_stage(s, binding->stageFlags) {
 101             set_layout->binding[b].stage[s].sampler_index = sampler_count[s];
 102             sampler_count[s] += binding->descriptorCount;
 103          }
 104          break;
 105       default:
 106          break;
 107       }
 108
 109       switch (binding->descriptorType) {
 110       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
 111       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
 112       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
 113       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
 114          set_layout->binding[b].buffer_index = buffer_count;
 115          buffer_count += binding->descriptorCount;
 116          /* fall through */
 117
 118       case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
 119       case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
 120       case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
 121       case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
 122       case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
 123       case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
 124          anv_foreach_stage(s, binding->stageFlags) {
 125             set_layout->binding[b].stage[s].surface_index = surface_count[s];
 126             surface_count[s] += binding->descriptorCount;
 127          }
 128          break;
 129       default:
 130          break;
 131       }
 132
 133       switch (binding->descriptorType) {
 134       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
 135       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
 136          set_layout->binding[b].dynamic_offset_index = dynamic_offset_count;
 137          dynamic_offset_count += binding->descriptorCount;
 138          break;
 139       default:
 140          break;
 141       }
 142
 143       switch (binding->descriptorType) {
 144       case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
 145       case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
 146          anv_foreach_stage(s, binding->stageFlags) {
 147             set_layout->binding[b].stage[s].image_index = image_count[s];
 148             image_count[s] += binding->descriptorCount;
 149          }
 150          break;
 151       default:
 152          break;
 153       }
 154
 155       if (binding->pImmutableSamplers) {
 156          set_layout->binding[b].immutable_samplers = samplers;
 157          samplers += binding->descriptorCount;
 158
 159          for (uint32_t i = 0; i < binding->descriptorCount; i++)
 160             set_layout->binding[b].immutable_samplers[i] =
 161                anv_sampler_from_handle(binding->pImmutableSamplers[i]);
 162       } else {
 163          set_layout->binding[b].immutable_samplers = NULL;
 164       }
 165
 166       set_layout->shader_stages |= binding->stageFlags;
 167    }
 168
 169    set_layout->buffer_count = buffer_count;
 170    set_layout->dynamic_offset_count = dynamic_offset_count;
 171
 172    *pSetLayout = anv_descriptor_set_layout_to_handle(set_layout);
 173
 174    return VK_SUCCESS;
 175 }
 176
 177 void anv_DestroyDescriptorSetLayout(
 178     VkDevice                                    _device,
 179     VkDescriptorSetLayout                       _set_layout,
 180     const VkAllocationCallbacks*                pAllocator)
 181 {
 182    ANV_FROM_HANDLE(anv_device, device, _device);
 183    ANV_FROM_HANDLE(anv_descriptor_set_layout, set_layout, _set_layout);
 184
 185    anv_free2(&device->alloc, pAllocator, set_layout);
 186 }
 187
 188 /*
 189  * Pipeline layouts.  These have nothing to do with the pipeline.  They are
 190  * just muttiple descriptor set layouts pasted together
 191  */
 192
 193 VkResult anv_CreatePipelineLayout(
 194     VkDevice                                    _device,
 195     const VkPipelineLayoutCreateInfo*           pCreateInfo,
 196     const VkAllocationCallbacks*                pAllocator,
 197     VkPipelineLayout*                           pPipelineLayout)
 198 {
 199    ANV_FROM_HANDLE(anv_device, device, _device);
 200    struct anv_pipeline_layout *layout;
 201
 202    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO);
 203
 204    layout = anv_alloc2(&device->alloc, pAllocator, sizeof(*layout), 8,
 205                        VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 206    if (layout == NULL)
 207       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 208
 209    layout->num_sets = pCreateInfo->setLayoutCount;
 210
 211    unsigned dynamic_offset_count = 0;
 212
 213    memset(layout->stage, 0, sizeof(layout->stage));
 214    for (uint32_t set = 0; set < pCreateInfo->setLayoutCount; set++) {
 215       ANV_FROM_HANDLE(anv_descriptor_set_layout, set_layout,
 216                       pCreateInfo->pSetLayouts[set]);
 217       layout->set[set].layout = set_layout;
 218
 219       layout->set[set].dynamic_offset_start = dynamic_offset_count;
 220       for (uint32_t b = 0; b < set_layout->binding_count; b++) {
 221          if (set_layout->binding[b].dynamic_offset_index >= 0)
 222             dynamic_offset_count += set_layout->binding[b].array_size;
 223          for (gl_shader_stage s = 0; s < MESA_SHADER_STAGES; s++) {
 224             if (set_layout->binding[b].stage[s].surface_index >= 0)
 225                layout->stage[s].has_dynamic_offsets = true;
 226          }
 227       }
 228    }
 229
 230    *pPipelineLayout = anv_pipeline_layout_to_handle(layout);
 231
 232    return VK_SUCCESS;
 233 }
 234
 235 void anv_DestroyPipelineLayout(
 236     VkDevice                                    _device,
 237     VkPipelineLayout                            _pipelineLayout,
 238     const VkAllocationCallbacks*                pAllocator)
 239 {
 240    ANV_FROM_HANDLE(anv_device, device, _device);
 241    ANV_FROM_HANDLE(anv_pipeline_layout, pipeline_layout, _pipelineLayout);
 242
 243    anv_free2(&device->alloc, pAllocator, pipeline_layout);
 244 }
 245
 246 /*
 247  * Descriptor pools.
 248  *
 249  * These are implemented using a big pool of memory and a free-list for the
 250  * host memory allocations and a state_stream and a free list for the buffer
 251  * view surface state. The spec allows us to fail to allocate due to
 252  * fragmentation in all cases but two: 1) after pool reset, allocating up
 253  * until the pool size with no freeing must succeed and 2) allocating and
 254  * freeing only descriptor sets with the same layout. Case 1) is easy enogh,
 255  * and the free lists lets us recycle blocks for case 2).
 256  */
 257
 258 #define EMPTY 1
 259
 260 VkResult anv_CreateDescriptorPool(
 261     VkDevice                                    _device,
 262     const VkDescriptorPoolCreateInfo*           pCreateInfo,
 263     const VkAllocationCallbacks*                pAllocator,
 264     VkDescriptorPool*                           pDescriptorPool)
 265 {
 266    ANV_FROM_HANDLE(anv_device, device, _device);
 267    struct anv_descriptor_pool *pool;
 268
 269    uint32_t descriptor_count = 0;
 270    uint32_t buffer_count = 0;
 271    for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; i++) {
 272       switch (pCreateInfo->pPoolSizes[i].type) {
 273       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
 274       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
 275       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
 276       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
 277          buffer_count += pCreateInfo->pPoolSizes[i].descriptorCount;
 278       default:
 279          descriptor_count += pCreateInfo->pPoolSizes[i].descriptorCount;
 280          break;
 281       }
 282    }
 283
 284    const size_t set_size =
 285       sizeof(struct anv_descriptor_set) +
 286       descriptor_count * sizeof(struct anv_descriptor) +
 287       buffer_count * sizeof(struct anv_buffer_view);
 288
 289    const size_t size =
 290       sizeof(*pool) +
 291       pCreateInfo->maxSets * set_size;
 292
 293    pool = anv_alloc2(&device->alloc, pAllocator, size, 8,
 294                      VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 295    if (!pool)
 296       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 297
 298    pool->size = size;
 299    pool->next = 0;
 300    pool->free_list = EMPTY;
 301
 302    anv_state_stream_init(&pool->surface_state_stream,
 303                          &device->surface_state_block_pool);
 304    pool->surface_state_free_list = NULL;
 305
 306    *pDescriptorPool = anv_descriptor_pool_to_handle(pool);
 307
 308    return VK_SUCCESS;
 309 }
 310
 311 void anv_DestroyDescriptorPool(
 312     VkDevice                                    _device,
 313     VkDescriptorPool                            _pool,
 314     const VkAllocationCallbacks*                pAllocator)
 315 {
 316    ANV_FROM_HANDLE(anv_device, device, _device);
 317    ANV_FROM_HANDLE(anv_descriptor_pool, pool, _pool);
 318
 319    anv_state_stream_finish(&pool->surface_state_stream);
 320    anv_free2(&device->alloc, pAllocator, pool);
 321 }
 322
 323 VkResult anv_ResetDescriptorPool(
 324     VkDevice                                    _device,
 325     VkDescriptorPool                            descriptorPool,
 326     VkDescriptorPoolResetFlags                  flags)
 327 {
 328    ANV_FROM_HANDLE(anv_device, device, _device);
 329    ANV_FROM_HANDLE(anv_descriptor_pool, pool, descriptorPool);
 330
 331    pool->next = 0;
 332    pool->free_list = EMPTY;
 333    anv_state_stream_finish(&pool->surface_state_stream);
 334    anv_state_stream_init(&pool->surface_state_stream,
 335                          &device->surface_state_block_pool);
 336    pool->surface_state_free_list = NULL;
 337
 338    return VK_SUCCESS;
 339 }
 340
 341 struct pool_free_list_entry {
 342    uint32_t next;
 343    uint32_t size;
 344 };
 345
 346 static size_t
 347 layout_size(const struct anv_descriptor_set_layout *layout)
 348 {
 349    return
 350       sizeof(struct anv_descriptor_set) +
 351       layout->size * sizeof(struct anv_descriptor) +
 352       layout->buffer_count * sizeof(struct anv_buffer_view);
 353 }
 354
 355 struct surface_state_free_list_entry {
 356    void *next;
 357    uint32_t offset;
 358 };
 359
 360 VkResult
 361 anv_descriptor_set_create(struct anv_device *device,
 362                           struct anv_descriptor_pool *pool,
 363                           const struct anv_descriptor_set_layout *layout,
 364                           struct anv_descriptor_set **out_set)
 365 {
 366    struct anv_descriptor_set *set;
 367    const size_t size = layout_size(layout);
 368
 369    set = NULL;
 370    if (size <= pool->size - pool->next) {
 371       set = (struct anv_descriptor_set *) (pool->data + pool->next);
 372       pool->next += size;
 373    } else {
 374       struct pool_free_list_entry *entry;
 375       uint32_t *link = &pool->free_list;
 376       for (uint32_t f = pool->free_list; f != EMPTY; f = entry->next) {
 377          entry = (struct pool_free_list_entry *) (pool->data + f);
 378          if (size <= entry->size) {
 379             *link = entry->next;
 380             set = (struct anv_descriptor_set *) entry;
 381             break;
 382          }
 383          link = &entry->next;
 384       }
 385    }
 386
 387    if (set == NULL)
 388       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 389
 390    set->size = size;
 391    set->layout = layout;
 392    set->buffer_views =
 393       (struct anv_buffer_view *) &set->descriptors[layout->size];
 394    set->buffer_count = layout->buffer_count;
 395
 396    /* Go through and fill out immutable samplers if we have any */
 397    struct anv_descriptor *desc = set->descriptors;
 398    for (uint32_t b = 0; b < layout->binding_count; b++) {
 399       if (layout->binding[b].immutable_samplers) {
 400          for (uint32_t i = 0; i < layout->binding[b].array_size; i++)
 401             desc[i].sampler = layout->binding[b].immutable_samplers[i];
 402       }
 403       desc += layout->binding[b].array_size;
 404    }
 405
 406    /* Allocate surface state for the buffer views. */
 407    for (uint32_t b = 0; b < layout->buffer_count; b++) {
 408       struct surface_state_free_list_entry *entry =
 409          pool->surface_state_free_list;
 410       struct anv_state state;
 411
 412       if (entry) {
 413          state.map = entry;
 414          state.offset = entry->offset;
 415          state.alloc_size = 64;
 416          pool->surface_state_free_list = entry->next;
 417       } else {
 418          state = anv_state_stream_alloc(&pool->surface_state_stream, 64, 64);
 419       }
 420
 421       set->buffer_views[b].surface_state = state;
 422    }
 423
 424    *out_set = set;
 425
 426    return VK_SUCCESS;
 427 }
 428
 429 void
 430 anv_descriptor_set_destroy(struct anv_device *device,
 431                            struct anv_descriptor_pool *pool,
 432                            struct anv_descriptor_set *set)
 433 {
 434    /* Put the buffer view surface state back on the free list. */
 435    for (uint32_t b = 0; b < set->buffer_count; b++) {
 436       struct surface_state_free_list_entry *entry =
 437          set->buffer_views[b].surface_state.map;
 438       entry->next = pool->surface_state_free_list;
 439       pool->surface_state_free_list = entry;
 440    }
 441
 442    /* Put the descriptor set allocation back on the free list. */
 443    const uint32_t index = (char *) set - pool->data;
 444    if (index + set->size == pool->next) {
 445       pool->next = index;
 446    } else {
 447       struct pool_free_list_entry *entry = (struct pool_free_list_entry *) set;
 448       entry->next = pool->free_list;
 449       entry->size = set->size;
 450       pool->free_list = (char *) entry - pool->data;
 451    }
 452 }
 453
 454 VkResult anv_AllocateDescriptorSets(
 455     VkDevice                                    _device,
 456     const VkDescriptorSetAllocateInfo*          pAllocateInfo,
 457     VkDescriptorSet*                            pDescriptorSets)
 458 {
 459    ANV_FROM_HANDLE(anv_device, device, _device);
 460    ANV_FROM_HANDLE(anv_descriptor_pool, pool, pAllocateInfo->descriptorPool);
 461
 462    VkResult result = VK_SUCCESS;
 463    struct anv_descriptor_set *set;
 464    uint32_t i;
 465
 466    for (i = 0; i < pAllocateInfo->descriptorSetCount; i++) {
 467       ANV_FROM_HANDLE(anv_descriptor_set_layout, layout,
 468                       pAllocateInfo->pSetLayouts[i]);
 469
 470       result = anv_descriptor_set_create(device, pool, layout, &set);
 471       if (result != VK_SUCCESS)
 472          break;
 473
 474       pDescriptorSets[i] = anv_descriptor_set_to_handle(set);
 475    }
 476
 477    if (result != VK_SUCCESS)
 478       anv_FreeDescriptorSets(_device, pAllocateInfo->descriptorPool,
 479                              i, pDescriptorSets);
 480
 481    return result;
 482 }
 483
 484 VkResult anv_FreeDescriptorSets(
 485     VkDevice                                    _device,
 486     VkDescriptorPool                            descriptorPool,
 487     uint32_t                                    count,
 488     const VkDescriptorSet*                      pDescriptorSets)
 489 {
 490    ANV_FROM_HANDLE(anv_device, device, _device);
 491    ANV_FROM_HANDLE(anv_descriptor_pool, pool, descriptorPool);
 492
 493    for (uint32_t i = 0; i < count; i++) {
 494       ANV_FROM_HANDLE(anv_descriptor_set, set, pDescriptorSets[i]);
 495
 496       anv_descriptor_set_destroy(device, pool, set);
 497    }
 498
 499    return VK_SUCCESS;
 500 }
 501
 502 void anv_UpdateDescriptorSets(
 503     VkDevice                                    _device,
 504     uint32_t                                    descriptorWriteCount,
 505     const VkWriteDescriptorSet*                 pDescriptorWrites,
 506     uint32_t                                    descriptorCopyCount,
 507     const VkCopyDescriptorSet*                  pDescriptorCopies)
 508 {
 509    ANV_FROM_HANDLE(anv_device, device, _device);
 510
 511    for (uint32_t i = 0; i < descriptorWriteCount; i++) {
 512       const VkWriteDescriptorSet *write = &pDescriptorWrites[i];
 513       ANV_FROM_HANDLE(anv_descriptor_set, set, write->dstSet);
 514       const struct anv_descriptor_set_binding_layout *bind_layout =
 515          &set->layout->binding[write->dstBinding];
 516       struct anv_descriptor *desc =
 517          &set->descriptors[bind_layout->descriptor_index];
 518       desc += write->dstArrayElement;
 519
 520       switch (write->descriptorType) {
 521       case VK_DESCRIPTOR_TYPE_SAMPLER:
 522          for (uint32_t j = 0; j < write->descriptorCount; j++) {
 523             ANV_FROM_HANDLE(anv_sampler, sampler,
 524                             write->pImageInfo[j].sampler);
 525
 526             desc[j] = (struct anv_descriptor) {
 527                .type = VK_DESCRIPTOR_TYPE_SAMPLER,
 528                .sampler = sampler,
 529             };
 530          }
 531          break;
 532
 533       case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
 534          for (uint32_t j = 0; j < write->descriptorCount; j++) {
 535             ANV_FROM_HANDLE(anv_image_view, iview,
 536                             write->pImageInfo[j].imageView);
 537             ANV_FROM_HANDLE(anv_sampler, sampler,
 538                             write->pImageInfo[j].sampler);
 539
 540             desc[j].type = VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER;
 541             desc[j].image_view = iview;
 542
 543             /* If this descriptor has an immutable sampler, we don't want
 544              * to stomp on it.
 545              */
 546             if (sampler)
 547                desc[j].sampler = sampler;
 548          }
 549          break;
 550
 551       case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
 552       case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
 553          for (uint32_t j = 0; j < write->descriptorCount; j++) {
 554             ANV_FROM_HANDLE(anv_image_view, iview,
 555                             write->pImageInfo[j].imageView);
 556
 557             desc[j] = (struct anv_descriptor) {
 558                .type = write->descriptorType,
 559                .image_view = iview,
 560             };
 561          }
 562          break;
 563
 564       case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
 565       case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
 566          for (uint32_t j = 0; j < write->descriptorCount; j++) {
 567             ANV_FROM_HANDLE(anv_buffer_view, bview,
 568                             write->pTexelBufferView[j]);
 569
 570             desc[j] = (struct anv_descriptor) {
 571                .type = write->descriptorType,
 572                .buffer_view = bview,
 573             };
 574          }
 575          break;
 576
 577       case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
 578          anv_finishme("input attachments not implemented");
 579          break;
 580
 581       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
 582       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
 583       case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
 584       case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
 585          for (uint32_t j = 0; j < write->descriptorCount; j++) {
 586             assert(write->pBufferInfo[j].buffer);
 587             ANV_FROM_HANDLE(anv_buffer, buffer, write->pBufferInfo[j].buffer);
 588             assert(buffer);
 589
 590             struct anv_buffer_view *view =
 591                &set->buffer_views[bind_layout->buffer_index];
 592             view += write->dstArrayElement + j;
 593
 594             const struct anv_format *format =
 595                anv_format_for_descriptor_type(write->descriptorType);
 596
 597             view->format = format->isl_format;
 598             view->bo = buffer->bo;
 599             view->offset = buffer->offset + write->pBufferInfo[j].offset;
 600
 601             /* For buffers with dynamic offsets, we use the full possible
 602              * range in the surface state and do the actual range-checking
 603              * in the shader.
 604              */
 605             if (bind_layout->dynamic_offset_index >= 0 ||
 606                 write->pBufferInfo[j].range == VK_WHOLE_SIZE)
 607                view->range = buffer->size - write->pBufferInfo[j].offset;
 608             else
 609                view->range = write->pBufferInfo[j].range;
 610
 611             anv_fill_buffer_surface_state(device, view->surface_state,
 612                                           view->format,
 613                                           view->offset, view->range, 1);
 614
 615             desc[j] = (struct anv_descriptor) {
 616                .type = write->descriptorType,
 617                .buffer_view = view,
 618             };
 619
 620          }
 621
 622       default:
 623          break;
 624       }
 625    }
 626
 627    for (uint32_t i = 0; i < descriptorCopyCount; i++) {
 628       const VkCopyDescriptorSet *copy = &pDescriptorCopies[i];
 629       ANV_FROM_HANDLE(anv_descriptor_set, src, copy->dstSet);
 630       ANV_FROM_HANDLE(anv_descriptor_set, dst, copy->dstSet);
 631
 632       const struct anv_descriptor_set_binding_layout *src_layout =
 633          &src->layout->binding[copy->srcBinding];
 634       struct anv_descriptor *src_desc =
 635          &src->descriptors[src_layout->descriptor_index];
 636       src_desc += copy->srcArrayElement;
 637
 638       const struct anv_descriptor_set_binding_layout *dst_layout =
 639          &dst->layout->binding[copy->dstBinding];
 640       struct anv_descriptor *dst_desc =
 641          &dst->descriptors[dst_layout->descriptor_index];
 642       dst_desc += copy->dstArrayElement;
 643
 644       for (uint32_t j = 0; j < copy->descriptorCount; j++)
 645          dst_desc[j] = src_desc[j];
 646    }
 647 }