src/intel/vulkan/anv_image.c

   1 /*
   2  * Copyright © 2015 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  */
  23
  24 #include <assert.h>
  25 #include <stdbool.h>
  26 #include <string.h>
  27 #include <unistd.h>
  28 #include <fcntl.h>
  29
  30 #include "anv_private.h"
  31
  32 /**
  33  * Exactly one bit must be set in \a aspect.
  34  */
  35 static isl_surf_usage_flags_t
  36 choose_isl_surf_usage(VkImageUsageFlags vk_usage,
  37                       VkImageAspectFlags aspect)
  38 {
  39    isl_surf_usage_flags_t isl_usage = 0;
  40
  41    /* FINISHME: Support aux surfaces */
  42    isl_usage |= ISL_SURF_USAGE_DISABLE_AUX_BIT;
  43
  44    if (vk_usage & VK_IMAGE_USAGE_SAMPLED_BIT)
  45       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;
  46
  47    if (vk_usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)
  48       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;
  49
  50    if (vk_usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)
  51       isl_usage |= ISL_SURF_USAGE_RENDER_TARGET_BIT;
  52
  53    if (vk_usage & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT)
  54       isl_usage |= ISL_SURF_USAGE_CUBE_BIT;
  55
  56    if (vk_usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) {
  57       switch (aspect) {
  58       default:
  59          unreachable("bad VkImageAspect");
  60       case VK_IMAGE_ASPECT_DEPTH_BIT:
  61          isl_usage |= ISL_SURF_USAGE_DEPTH_BIT;
  62          break;
  63       case VK_IMAGE_ASPECT_STENCIL_BIT:
  64          isl_usage |= ISL_SURF_USAGE_STENCIL_BIT;
  65          break;
  66       }
  67    }
  68
  69    if (vk_usage & VK_IMAGE_USAGE_TRANSFER_SRC_BIT) {
  70       /* Meta implements transfers by sampling from the source image. */
  71       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;
  72    }
  73
  74    if (vk_usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT) {
  75       /* Meta implements transfers by rendering into the destination image. */
  76       isl_usage |= ISL_SURF_USAGE_RENDER_TARGET_BIT;
  77    }
  78
  79    return isl_usage;
  80 }
  81
  82 /**
  83  * Exactly one bit must be set in \a aspect.
  84  */
  85 static struct anv_surface *
  86 get_surface(struct anv_image *image, VkImageAspectFlags aspect)
  87 {
  88    switch (aspect) {
  89    default:
  90       unreachable("bad VkImageAspect");
  91    case VK_IMAGE_ASPECT_COLOR_BIT:
  92       return &image->color_surface;
  93    case VK_IMAGE_ASPECT_DEPTH_BIT:
  94       return &image->depth_surface;
  95    case VK_IMAGE_ASPECT_STENCIL_BIT:
  96       return &image->stencil_surface;
  97    }
  98 }
  99
 100 /**
 101  * Initialize the anv_image::*_surface selected by \a aspect. Then update the
 102  * image's memory requirements (that is, the image's size and alignment).
 103  *
 104  * Exactly one bit must be set in \a aspect.
 105  */
 106 static VkResult
 107 make_surface(const struct anv_device *dev,
 108              struct anv_image *image,
 109              const struct anv_image_create_info *anv_info,
 110              VkImageAspectFlags aspect)
 111 {
 112    const VkImageCreateInfo *vk_info = anv_info->vk_info;
 113    bool ok UNUSED;
 114
 115    static const enum isl_surf_dim vk_to_isl_surf_dim[] = {
 116       [VK_IMAGE_TYPE_1D] = ISL_SURF_DIM_1D,
 117       [VK_IMAGE_TYPE_2D] = ISL_SURF_DIM_2D,
 118       [VK_IMAGE_TYPE_3D] = ISL_SURF_DIM_3D,
 119    };
 120
 121    isl_tiling_flags_t tiling_flags = anv_info->isl_tiling_flags;
 122    if (vk_info->tiling == VK_IMAGE_TILING_LINEAR)
 123       tiling_flags = ISL_TILING_LINEAR_BIT;
 124
 125    struct anv_surface *anv_surf = get_surface(image, aspect);
 126
 127    image->extent = anv_sanitize_image_extent(vk_info->imageType,
 128                                              vk_info->extent);
 129
 130    ok = isl_surf_init(&dev->isl_dev, &anv_surf->isl,
 131       .dim = vk_to_isl_surf_dim[vk_info->imageType],
 132       .format = anv_get_isl_format(vk_info->format, aspect,
 133                                    vk_info->tiling, NULL),
 134       .width = image->extent.width,
 135       .height = image->extent.height,
 136       .depth = image->extent.depth,
 137       .levels = vk_info->mipLevels,
 138       .array_len = vk_info->arrayLayers,
 139       .samples = vk_info->samples,
 140       .min_alignment = 0,
 141       .min_pitch = anv_info->stride,
 142       .usage = choose_isl_surf_usage(image->usage, aspect),
 143       .tiling_flags = tiling_flags);
 144
 145    /* isl_surf_init() will fail only if provided invalid input. Invalid input
 146     * is illegal in Vulkan.
 147     */
 148    assert(ok);
 149
 150    anv_surf->offset = align_u32(image->size, anv_surf->isl.alignment);
 151    image->size = anv_surf->offset + anv_surf->isl.size;
 152    image->alignment = MAX(image->alignment, anv_surf->isl.alignment);
 153
 154    return VK_SUCCESS;
 155 }
 156
 157 /**
 158  * Parameter @a format is required and overrides VkImageCreateInfo::format.
 159  */
 160 static VkImageUsageFlags
 161 anv_image_get_full_usage(const VkImageCreateInfo *info,
 162                          const struct anv_format *format)
 163 {
 164    VkImageUsageFlags usage = info->usage;
 165
 166    if (info->samples > 1 &&
 167        (usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)) {
 168       /* Meta will resolve the image by binding it as a texture. */
 169       usage |= VK_IMAGE_USAGE_SAMPLED_BIT;
 170    }
 171
 172    if (usage & VK_IMAGE_USAGE_TRANSFER_SRC_BIT) {
 173       /* Meta will transfer from the image by binding it as a texture. */
 174       usage |= VK_IMAGE_USAGE_SAMPLED_BIT;
 175    }
 176
 177    if (usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT) {
 178       /* For non-clear transfer operations, meta will transfer to the image by
 179        * binding it as a color attachment, even if the image format is not
 180        * a color format.
 181        */
 182       usage |= VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
 183
 184       if (anv_format_is_depth_or_stencil(format)) {
 185          /* vkCmdClearDepthStencilImage() only requires that
 186           * VK_IMAGE_USAGE_TRANSFER_SRC_BIT be set. In particular, it does
 187           * not require VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT. Meta
 188           * clears the image, though, by binding it as a depthstencil
 189           * attachment.
 190           */
 191          usage |= VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT;
 192       }
 193    }
 194
 195    return usage;
 196 }
 197
 198 VkResult
 199 anv_image_create(VkDevice _device,
 200                  const struct anv_image_create_info *create_info,
 201                  const VkAllocationCallbacks* alloc,
 202                  VkImage *pImage)
 203 {
 204    ANV_FROM_HANDLE(anv_device, device, _device);
 205    const VkImageCreateInfo *pCreateInfo = create_info->vk_info;
 206    struct anv_image *image = NULL;
 207    const struct anv_format *format = anv_format_for_vk_format(pCreateInfo->format);
 208    VkResult r;
 209
 210    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
 211
 212    anv_assert(pCreateInfo->mipLevels > 0);
 213    anv_assert(pCreateInfo->arrayLayers > 0);
 214    anv_assert(pCreateInfo->samples > 0);
 215    anv_assert(pCreateInfo->extent.width > 0);
 216    anv_assert(pCreateInfo->extent.height > 0);
 217    anv_assert(pCreateInfo->extent.depth > 0);
 218
 219    image = anv_alloc2(&device->alloc, alloc, sizeof(*image), 8,
 220                       VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 221    if (!image)
 222       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 223
 224    memset(image, 0, sizeof(*image));
 225    image->type = pCreateInfo->imageType;
 226    image->extent = pCreateInfo->extent;
 227    image->vk_format = pCreateInfo->format;
 228    image->format = format;
 229    image->levels = pCreateInfo->mipLevels;
 230    image->array_size = pCreateInfo->arrayLayers;
 231    image->samples = pCreateInfo->samples;
 232    image->usage = anv_image_get_full_usage(pCreateInfo, format);
 233    image->tiling = pCreateInfo->tiling;
 234
 235    if (likely(anv_format_is_color(format))) {
 236       r = make_surface(device, image, create_info,
 237                        VK_IMAGE_ASPECT_COLOR_BIT);
 238       if (r != VK_SUCCESS)
 239          goto fail;
 240    } else {
 241       if (image->format->has_depth) {
 242          r = make_surface(device, image, create_info,
 243                           VK_IMAGE_ASPECT_DEPTH_BIT);
 244          if (r != VK_SUCCESS)
 245             goto fail;
 246       }
 247
 248       if (image->format->has_stencil) {
 249          r = make_surface(device, image, create_info,
 250                           VK_IMAGE_ASPECT_STENCIL_BIT);
 251          if (r != VK_SUCCESS)
 252             goto fail;
 253       }
 254    }
 255
 256    *pImage = anv_image_to_handle(image);
 257
 258    return VK_SUCCESS;
 259
 260 fail:
 261    if (image)
 262       anv_free2(&device->alloc, alloc, image);
 263
 264    return r;
 265 }
 266
 267 VkResult
 268 anv_CreateImage(VkDevice device,
 269                 const VkImageCreateInfo *pCreateInfo,
 270                 const VkAllocationCallbacks *pAllocator,
 271                 VkImage *pImage)
 272 {
 273    return anv_image_create(device,
 274       &(struct anv_image_create_info) {
 275          .vk_info = pCreateInfo,
 276          .isl_tiling_flags = ISL_TILING_ANY_MASK,
 277       },
 278       pAllocator,
 279       pImage);
 280 }
 281
 282 void
 283 anv_DestroyImage(VkDevice _device, VkImage _image,
 284                  const VkAllocationCallbacks *pAllocator)
 285 {
 286    ANV_FROM_HANDLE(anv_device, device, _device);
 287
 288    anv_free2(&device->alloc, pAllocator, anv_image_from_handle(_image));
 289 }
 290
 291 static void
 292 anv_surface_get_subresource_layout(struct anv_image *image,
 293                                    struct anv_surface *surface,
 294                                    const VkImageSubresource *subresource,
 295                                    VkSubresourceLayout *layout)
 296 {
 297    /* If we are on a non-zero mip level or array slice, we need to
 298     * calculate a real offset.
 299     */
 300    anv_assert(subresource->mipLevel == 0);
 301    anv_assert(subresource->arrayLayer == 0);
 302
 303    layout->offset = surface->offset;
 304    layout->rowPitch = surface->isl.row_pitch;
 305    layout->depthPitch = isl_surf_get_array_pitch(&surface->isl);
 306    layout->arrayPitch = isl_surf_get_array_pitch(&surface->isl);
 307    layout->size = surface->isl.size;
 308 }
 309
 310 void anv_GetImageSubresourceLayout(
 311     VkDevice                                    device,
 312     VkImage                                     _image,
 313     const VkImageSubresource*                   pSubresource,
 314     VkSubresourceLayout*                        pLayout)
 315 {
 316    ANV_FROM_HANDLE(anv_image, image, _image);
 317
 318    assert(__builtin_popcount(pSubresource->aspectMask) == 1);
 319
 320    switch (pSubresource->aspectMask) {
 321    case VK_IMAGE_ASPECT_COLOR_BIT:
 322       anv_surface_get_subresource_layout(image, &image->color_surface,
 323                                          pSubresource, pLayout);
 324       break;
 325    case VK_IMAGE_ASPECT_DEPTH_BIT:
 326       anv_surface_get_subresource_layout(image, &image->depth_surface,
 327                                          pSubresource, pLayout);
 328       break;
 329    case VK_IMAGE_ASPECT_STENCIL_BIT:
 330       anv_surface_get_subresource_layout(image, &image->stencil_surface,
 331                                          pSubresource, pLayout);
 332       break;
 333    default:
 334       assert(!"Invalid image aspect");
 335    }
 336 }
 337
 338 VkResult
 339 anv_validate_CreateImageView(VkDevice _device,
 340                              const VkImageViewCreateInfo *pCreateInfo,
 341                              const VkAllocationCallbacks *pAllocator,
 342                              VkImageView *pView)
 343 {
 344    ANV_FROM_HANDLE(anv_image, image, pCreateInfo->image);
 345    const VkImageSubresourceRange *subresource;
 346    const struct anv_format *view_format_info;
 347
 348    /* Validate structure type before dereferencing it. */
 349    assert(pCreateInfo);
 350    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO);
 351    subresource = &pCreateInfo->subresourceRange;
 352
 353    /* Validate viewType is in range before using it. */
 354    assert(pCreateInfo->viewType >= VK_IMAGE_VIEW_TYPE_BEGIN_RANGE);
 355    assert(pCreateInfo->viewType <= VK_IMAGE_VIEW_TYPE_END_RANGE);
 356
 357    /* Validate format is in range before using it. */
 358    assert(pCreateInfo->format >= VK_FORMAT_BEGIN_RANGE);
 359    assert(pCreateInfo->format <= VK_FORMAT_END_RANGE);
 360    view_format_info = anv_format_for_vk_format(pCreateInfo->format);
 361
 362    /* Validate channel swizzles. */
 363    assert(pCreateInfo->components.r >= VK_COMPONENT_SWIZZLE_BEGIN_RANGE);
 364    assert(pCreateInfo->components.r <= VK_COMPONENT_SWIZZLE_END_RANGE);
 365    assert(pCreateInfo->components.g >= VK_COMPONENT_SWIZZLE_BEGIN_RANGE);
 366    assert(pCreateInfo->components.g <= VK_COMPONENT_SWIZZLE_END_RANGE);
 367    assert(pCreateInfo->components.b >= VK_COMPONENT_SWIZZLE_BEGIN_RANGE);
 368    assert(pCreateInfo->components.b <= VK_COMPONENT_SWIZZLE_END_RANGE);
 369    assert(pCreateInfo->components.a >= VK_COMPONENT_SWIZZLE_BEGIN_RANGE);
 370    assert(pCreateInfo->components.a <= VK_COMPONENT_SWIZZLE_END_RANGE);
 371
 372    /* Validate subresource. */
 373    assert(subresource->aspectMask != 0);
 374    assert(subresource->levelCount > 0);
 375    assert(subresource->layerCount > 0);
 376    assert(subresource->baseMipLevel < image->levels);
 377    assert(subresource->baseMipLevel + anv_get_levelCount(image, subresource) <= image->levels);
 378    assert(subresource->baseArrayLayer < image->array_size);
 379    assert(subresource->baseArrayLayer + anv_get_layerCount(image, subresource) <= image->array_size);
 380    assert(pView);
 381
 382    const VkImageAspectFlags ds_flags = VK_IMAGE_ASPECT_DEPTH_BIT
 383                                      | VK_IMAGE_ASPECT_STENCIL_BIT;
 384
 385    /* Validate format. */
 386    if (subresource->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
 387       assert(subresource->aspectMask == VK_IMAGE_ASPECT_COLOR_BIT);
 388       assert(!image->format->has_depth);
 389       assert(!image->format->has_stencil);
 390       assert(!view_format_info->has_depth);
 391       assert(!view_format_info->has_stencil);
 392       assert(view_format_info->isl_layout->bs ==
 393              image->format->isl_layout->bs);
 394    } else if (subresource->aspectMask & ds_flags) {
 395       assert((subresource->aspectMask & ~ds_flags) == 0);
 396
 397       if (subresource->aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) {
 398          assert(image->format->has_depth);
 399          assert(view_format_info->has_depth);
 400          assert(view_format_info->isl_layout->bs ==
 401                 image->format->isl_layout->bs);
 402       }
 403
 404       if (subresource->aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) {
 405          /* FINISHME: Is it legal to have an R8 view of S8? */
 406          assert(image->format->has_stencil);
 407          assert(view_format_info->has_stencil);
 408       }
 409    } else {
 410       assert(!"bad VkImageSubresourceRange::aspectFlags");
 411    }
 412
 413    return anv_CreateImageView(_device, pCreateInfo, pAllocator, pView);
 414 }
 415
 416 static struct anv_state
 417 alloc_surface_state(struct anv_device *device,
 418                     struct anv_cmd_buffer *cmd_buffer)
 419 {
 420       if (cmd_buffer) {
 421          return anv_cmd_buffer_alloc_surface_state(cmd_buffer);
 422       } else {
 423          return anv_state_pool_alloc(&device->surface_state_pool, 64, 64);
 424       }
 425 }
 426
 427 static bool
 428 has_matching_storage_typed_format(const struct anv_device *device,
 429                                   enum isl_format format)
 430 {
 431    return (isl_format_get_layout(format)->bs <= 4 ||
 432            (isl_format_get_layout(format)->bs <= 8 &&
 433             (device->info.gen >= 8 || device->info.is_haswell)) ||
 434            device->info.gen >= 9);
 435 }
 436
 437 static enum isl_channel_select
 438 remap_swizzle(VkComponentSwizzle swizzle, VkComponentSwizzle component,
 439               struct anv_format_swizzle format_swizzle)
 440 {
 441    if (swizzle == VK_COMPONENT_SWIZZLE_IDENTITY)
 442       swizzle = component;
 443
 444    switch (swizzle) {
 445    case VK_COMPONENT_SWIZZLE_ZERO:
 446       return ISL_CHANNEL_SELECT_ZERO;
 447    case VK_COMPONENT_SWIZZLE_ONE:
 448       return ISL_CHANNEL_SELECT_ONE;
 449    case VK_COMPONENT_SWIZZLE_R:
 450       return ISL_CHANNEL_SELECT_RED + format_swizzle.r;
 451    case VK_COMPONENT_SWIZZLE_G:
 452       return ISL_CHANNEL_SELECT_RED + format_swizzle.g;
 453    case VK_COMPONENT_SWIZZLE_B:
 454       return ISL_CHANNEL_SELECT_RED + format_swizzle.b;
 455    case VK_COMPONENT_SWIZZLE_A:
 456       return ISL_CHANNEL_SELECT_RED + format_swizzle.a;
 457    default:
 458       unreachable("Invalid swizzle");
 459    }
 460 }
 461
 462 void
 463 anv_image_view_init(struct anv_image_view *iview,
 464                     struct anv_device *device,
 465                     const VkImageViewCreateInfo* pCreateInfo,
 466                     struct anv_cmd_buffer *cmd_buffer,
 467                     uint32_t offset,
 468                     VkImageUsageFlags usage_mask)
 469 {
 470    ANV_FROM_HANDLE(anv_image, image, pCreateInfo->image);
 471    const VkImageSubresourceRange *range = &pCreateInfo->subresourceRange;
 472
 473    assert(range->layerCount > 0);
 474    assert(range->baseMipLevel < image->levels);
 475    assert(image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT |
 476                           VK_IMAGE_USAGE_STORAGE_BIT |
 477                           VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT |
 478                           VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT));
 479
 480    switch (image->type) {
 481    default:
 482       unreachable("bad VkImageType");
 483    case VK_IMAGE_TYPE_1D:
 484    case VK_IMAGE_TYPE_2D:
 485       assert(range->baseArrayLayer + anv_get_layerCount(image, range) - 1 <= image->array_size);
 486       break;
 487    case VK_IMAGE_TYPE_3D:
 488       assert(range->baseArrayLayer + anv_get_layerCount(image, range) - 1
 489              <= anv_minify(image->extent.depth, range->baseMipLevel));
 490       break;
 491    }
 492
 493    struct anv_surface *surface =
 494       anv_image_get_surface_for_aspect_mask(image, range->aspectMask);
 495
 496    iview->image = image;
 497    iview->bo = image->bo;
 498    iview->offset = image->offset + surface->offset + offset;
 499
 500    iview->aspect_mask = pCreateInfo->subresourceRange.aspectMask;
 501    iview->vk_format = pCreateInfo->format;
 502
 503    struct anv_format_swizzle swizzle;
 504    enum isl_format format = anv_get_isl_format(pCreateInfo->format,
 505                                                range->aspectMask,
 506                                                image->tiling, &swizzle);
 507
 508    iview->base_layer = range->baseArrayLayer;
 509    iview->base_mip = range->baseMipLevel;
 510
 511    struct isl_view isl_view = {
 512       .format = format,
 513       .base_level = range->baseMipLevel,
 514       .levels = anv_get_levelCount(image, range),
 515       .base_array_layer = range->baseArrayLayer,
 516       .array_len = anv_get_layerCount(image, range),
 517       .channel_select = {
 518          remap_swizzle(pCreateInfo->components.r,
 519                        VK_COMPONENT_SWIZZLE_R, swizzle),
 520          remap_swizzle(pCreateInfo->components.g,
 521                        VK_COMPONENT_SWIZZLE_G, swizzle),
 522          remap_swizzle(pCreateInfo->components.b,
 523                        VK_COMPONENT_SWIZZLE_B, swizzle),
 524          remap_swizzle(pCreateInfo->components.a,
 525                        VK_COMPONENT_SWIZZLE_A, swizzle),
 526       },
 527    };
 528
 529    iview->extent = (VkExtent3D) {
 530       .width  = anv_minify(image->extent.width , range->baseMipLevel),
 531       .height = anv_minify(image->extent.height, range->baseMipLevel),
 532       .depth  = anv_minify(image->extent.depth , range->baseMipLevel),
 533    };
 534
 535    isl_surf_usage_flags_t cube_usage;
 536    if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE ||
 537        pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) {
 538       cube_usage = ISL_SURF_USAGE_CUBE_BIT;
 539    } else {
 540       cube_usage = 0;
 541    }
 542
 543    if (image->usage & usage_mask & VK_IMAGE_USAGE_SAMPLED_BIT) {
 544       iview->sampler_surface_state = alloc_surface_state(device, cmd_buffer);
 545
 546       isl_view.usage = cube_usage | ISL_SURF_USAGE_TEXTURE_BIT;
 547       isl_surf_fill_state(&device->isl_dev,
 548                           iview->sampler_surface_state.map,
 549                           .surf = &surface->isl,
 550                           .view = &isl_view,
 551                           .mocs = device->default_mocs);
 552
 553       if (!device->info.has_llc)
 554          anv_state_clflush(iview->sampler_surface_state);
 555    } else {
 556       iview->sampler_surface_state.alloc_size = 0;
 557    }
 558
 559    if (image->usage & usage_mask & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) {
 560       iview->color_rt_surface_state = alloc_surface_state(device, cmd_buffer);
 561
 562       isl_view.usage = cube_usage | ISL_SURF_USAGE_RENDER_TARGET_BIT;
 563       isl_surf_fill_state(&device->isl_dev,
 564                           iview->color_rt_surface_state.map,
 565                           .surf = &surface->isl,
 566                           .view = &isl_view,
 567                           .mocs = device->default_mocs);
 568
 569       if (!device->info.has_llc)
 570          anv_state_clflush(iview->color_rt_surface_state);
 571    } else {
 572       iview->color_rt_surface_state.alloc_size = 0;
 573    }
 574
 575    if (image->usage & usage_mask & VK_IMAGE_USAGE_STORAGE_BIT) {
 576       iview->storage_surface_state = alloc_surface_state(device, cmd_buffer);
 577
 578       if (has_matching_storage_typed_format(device, format)) {
 579          isl_view.usage = cube_usage | ISL_SURF_USAGE_STORAGE_BIT;
 580          isl_surf_fill_state(&device->isl_dev,
 581                              iview->storage_surface_state.map,
 582                              .surf = &surface->isl,
 583                              .view = &isl_view,
 584                              .mocs = device->default_mocs);
 585       } else {
 586          anv_fill_buffer_surface_state(device, iview->storage_surface_state,
 587                                        ISL_FORMAT_RAW,
 588                                        iview->offset,
 589                                        iview->bo->size - iview->offset, 1);
 590       }
 591
 592       isl_surf_fill_image_param(&device->isl_dev,
 593                                 &iview->storage_image_param,
 594                                 &surface->isl, &isl_view);
 595
 596       if (!device->info.has_llc)
 597          anv_state_clflush(iview->storage_surface_state);
 598    } else {
 599       iview->storage_surface_state.alloc_size = 0;
 600    }
 601 }
 602
 603 VkResult
 604 anv_CreateImageView(VkDevice _device,
 605                     const VkImageViewCreateInfo *pCreateInfo,
 606                     const VkAllocationCallbacks *pAllocator,
 607                     VkImageView *pView)
 608 {
 609    ANV_FROM_HANDLE(anv_device, device, _device);
 610    struct anv_image_view *view;
 611
 612    view = anv_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 613                      VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 614    if (view == NULL)
 615       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 616
 617    anv_image_view_init(view, device, pCreateInfo, NULL, 0, ~0);
 618
 619    *pView = anv_image_view_to_handle(view);
 620
 621    return VK_SUCCESS;
 622 }
 623
 624 void
 625 anv_DestroyImageView(VkDevice _device, VkImageView _iview,
 626                      const VkAllocationCallbacks *pAllocator)
 627 {
 628    ANV_FROM_HANDLE(anv_device, device, _device);
 629    ANV_FROM_HANDLE(anv_image_view, iview, _iview);
 630
 631    if (iview->color_rt_surface_state.alloc_size > 0) {
 632       anv_state_pool_free(&device->surface_state_pool,
 633                           iview->color_rt_surface_state);
 634    }
 635
 636    if (iview->sampler_surface_state.alloc_size > 0) {
 637       anv_state_pool_free(&device->surface_state_pool,
 638                           iview->sampler_surface_state);
 639    }
 640
 641    if (iview->storage_surface_state.alloc_size > 0) {
 642       anv_state_pool_free(&device->surface_state_pool,
 643                           iview->storage_surface_state);
 644    }
 645
 646    anv_free2(&device->alloc, pAllocator, iview);
 647 }
 648
 649 VkResult
 650 anv_CreateBufferView(VkDevice _device,
 651                      const VkBufferViewCreateInfo *pCreateInfo,
 652                      const VkAllocationCallbacks *pAllocator,
 653                      VkBufferView *pView)
 654 {
 655    ANV_FROM_HANDLE(anv_device, device, _device);
 656    ANV_FROM_HANDLE(anv_buffer, buffer, pCreateInfo->buffer);
 657    struct anv_buffer_view *view;
 658
 659    view = anv_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 660                      VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 661    if (!view)
 662       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 663
 664    const struct anv_format *format =
 665       anv_format_for_vk_format(pCreateInfo->format);
 666
 667    view->format = format->isl_format;
 668    view->bo = buffer->bo;
 669    view->offset = buffer->offset + pCreateInfo->offset;
 670    view->range = pCreateInfo->range == VK_WHOLE_SIZE ?
 671                  buffer->size - view->offset : pCreateInfo->range;
 672
 673    if (buffer->usage & VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT) {
 674       view->surface_state =
 675          anv_state_pool_alloc(&device->surface_state_pool, 64, 64);
 676
 677       anv_fill_buffer_surface_state(device, view->surface_state,
 678                                     view->format,
 679                                     view->offset, view->range,
 680                                     format->isl_layout->bs);
 681    } else {
 682       view->surface_state = (struct anv_state){ 0 };
 683    }
 684
 685    if (buffer->usage & VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT) {
 686       view->storage_surface_state =
 687          anv_state_pool_alloc(&device->surface_state_pool, 64, 64);
 688
 689       enum isl_format storage_format =
 690          has_matching_storage_typed_format(device, view->format) ?
 691          isl_lower_storage_image_format(&device->isl_dev, view->format) :
 692          ISL_FORMAT_RAW;
 693
 694       anv_fill_buffer_surface_state(device, view->storage_surface_state,
 695                                     storage_format,
 696                                     view->offset, view->range,
 697                                     (storage_format == ISL_FORMAT_RAW ? 1 :
 698                                      format->isl_layout->bs));
 699
 700       isl_buffer_fill_image_param(&device->isl_dev,
 701                                   &view->storage_image_param,
 702                                   view->format, view->range);
 703    } else {
 704       view->storage_surface_state = (struct anv_state){ 0 };
 705    }
 706
 707    *pView = anv_buffer_view_to_handle(view);
 708
 709    return VK_SUCCESS;
 710 }
 711
 712 void
 713 anv_DestroyBufferView(VkDevice _device, VkBufferView bufferView,
 714                       const VkAllocationCallbacks *pAllocator)
 715 {
 716    ANV_FROM_HANDLE(anv_device, device, _device);
 717    ANV_FROM_HANDLE(anv_buffer_view, view, bufferView);
 718
 719    if (view->surface_state.alloc_size > 0)
 720       anv_state_pool_free(&device->surface_state_pool,
 721                           view->surface_state);
 722
 723    if (view->storage_surface_state.alloc_size > 0)
 724       anv_state_pool_free(&device->surface_state_pool,
 725                           view->storage_surface_state);
 726
 727    anv_free2(&device->alloc, pAllocator, view);
 728 }
 729
 730 struct anv_surface *
 731 anv_image_get_surface_for_aspect_mask(struct anv_image *image, VkImageAspectFlags aspect_mask)
 732 {
 733    switch (aspect_mask) {
 734    case VK_IMAGE_ASPECT_COLOR_BIT:
 735       /* Dragons will eat you.
 736        *
 737        * Meta attaches all destination surfaces as color render targets. Guess
 738        * what surface the Meta Dragons really want.
 739        */
 740       if (image->format->has_depth && image->format->has_stencil) {
 741          return &image->depth_surface;
 742       } else if (image->format->has_depth) {
 743          return &image->depth_surface;
 744       } else if (image->format->has_stencil) {
 745          return &image->stencil_surface;
 746       } else {
 747          return &image->color_surface;
 748       }
 749       break;
 750    case VK_IMAGE_ASPECT_DEPTH_BIT:
 751       assert(image->format->has_depth);
 752       return &image->depth_surface;
 753    case VK_IMAGE_ASPECT_STENCIL_BIT:
 754       assert(image->format->has_stencil);
 755       return &image->stencil_surface;
 756    case VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT:
 757       if (image->format->has_depth && image->format->has_stencil) {
 758          /* FINISHME: The Vulkan spec (git a511ba2) requires support for
 759           * combined depth stencil formats. Specifically, it states:
 760           *
 761           *    At least one of ename:VK_FORMAT_D24_UNORM_S8_UINT or
 762           *    ename:VK_FORMAT_D32_SFLOAT_S8_UINT must be supported.
 763           *
 764           * Image views with both depth and stencil aspects are only valid for
 765           * render target attachments, in which case
 766           * cmd_buffer_emit_depth_stencil() will pick out both the depth and
 767           * stencil surfaces from the underlying surface.
 768           */
 769          return &image->depth_surface;
 770       } else if (image->format->has_depth) {
 771          return &image->depth_surface;
 772       } else if (image->format->has_stencil) {
 773          return &image->stencil_surface;
 774       }
 775       /* fallthrough */
 776     default:
 777        unreachable("image does not have aspect");
 778        return NULL;
 779    }
 780 }