2 * Copyright © 2015 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
31 #include "anv_private.h"
32 #include "util/debug.h"
35 #include "vk_format_info.h"
37 static isl_surf_usage_flags_t
38 choose_isl_surf_usage(VkImageCreateFlags vk_create_flags
,
39 VkImageUsageFlags vk_usage
,
40 isl_surf_usage_flags_t isl_extra_usage
,
41 VkImageAspectFlagBits aspect
)
43 isl_surf_usage_flags_t isl_usage
= isl_extra_usage
;
45 if (vk_usage
& VK_IMAGE_USAGE_SAMPLED_BIT
)
46 isl_usage
|= ISL_SURF_USAGE_TEXTURE_BIT
;
48 if (vk_usage
& VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
)
49 isl_usage
|= ISL_SURF_USAGE_TEXTURE_BIT
;
51 if (vk_usage
& VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
)
52 isl_usage
|= ISL_SURF_USAGE_RENDER_TARGET_BIT
;
54 if (vk_create_flags
& VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT
)
55 isl_usage
|= ISL_SURF_USAGE_CUBE_BIT
;
57 /* Even if we're only using it for transfer operations, clears to depth and
58 * stencil images happen as depth and stencil so they need the right ISL
59 * usage bits or else things will fall apart.
62 case VK_IMAGE_ASPECT_DEPTH_BIT
:
63 isl_usage
|= ISL_SURF_USAGE_DEPTH_BIT
;
65 case VK_IMAGE_ASPECT_STENCIL_BIT
:
66 isl_usage
|= ISL_SURF_USAGE_STENCIL_BIT
;
68 case VK_IMAGE_ASPECT_COLOR_BIT
:
69 case VK_IMAGE_ASPECT_PLANE_0_BIT_KHR
:
70 case VK_IMAGE_ASPECT_PLANE_1_BIT_KHR
:
71 case VK_IMAGE_ASPECT_PLANE_2_BIT_KHR
:
74 unreachable("bad VkImageAspect");
77 if (vk_usage
& VK_IMAGE_USAGE_TRANSFER_SRC_BIT
) {
78 /* blorp implements transfers by sampling from the source image. */
79 isl_usage
|= ISL_SURF_USAGE_TEXTURE_BIT
;
82 if (vk_usage
& VK_IMAGE_USAGE_TRANSFER_DST_BIT
&&
83 aspect
== VK_IMAGE_ASPECT_COLOR_BIT
) {
84 /* blorp implements transfers by rendering into the destination image.
85 * Only request this with color images, as we deal with depth/stencil
86 * formats differently. */
87 isl_usage
|= ISL_SURF_USAGE_RENDER_TARGET_BIT
;
93 static isl_tiling_flags_t
94 choose_isl_tiling_flags(const struct anv_image_create_info
*anv_info
)
96 const VkImageCreateInfo
*base_info
= anv_info
->vk_info
;
97 isl_tiling_flags_t flags
= 0;
99 switch (base_info
->tiling
) {
101 unreachable("bad VkImageTiling");
102 case VK_IMAGE_TILING_OPTIMAL
:
103 flags
= ISL_TILING_ANY_MASK
;
105 case VK_IMAGE_TILING_LINEAR
:
106 flags
= ISL_TILING_LINEAR_BIT
;
110 if (anv_info
->isl_tiling_flags
)
111 flags
&= anv_info
->isl_tiling_flags
;
118 static struct anv_surface
*
119 get_surface(struct anv_image
*image
, VkImageAspectFlagBits aspect
)
121 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
122 return &image
->planes
[plane
].surface
;
126 add_surface(struct anv_image
*image
, struct anv_surface
*surf
, uint32_t plane
)
128 assert(surf
->isl
.size
> 0); /* isl surface must be initialized */
130 if (image
->disjoint
) {
131 surf
->offset
= align_u32(image
->planes
[plane
].size
, surf
->isl
.alignment
);
132 /* Plane offset is always 0 when it's disjoint. */
134 surf
->offset
= align_u32(image
->size
, surf
->isl
.alignment
);
135 /* Determine plane's offset only once when the first surface is added. */
136 if (image
->planes
[plane
].size
== 0)
137 image
->planes
[plane
].offset
= image
->size
;
140 image
->size
= surf
->offset
+ surf
->isl
.size
;
141 image
->planes
[plane
].size
= (surf
->offset
+ surf
->isl
.size
) - image
->planes
[plane
].offset
;
143 image
->alignment
= MAX2(image
->alignment
, surf
->isl
.alignment
);
144 image
->planes
[plane
].alignment
= MAX2(image
->planes
[plane
].alignment
,
145 surf
->isl
.alignment
);
150 all_formats_ccs_e_compatible(const struct gen_device_info
*devinfo
,
151 const struct VkImageCreateInfo
*vk_info
)
153 enum isl_format format
=
154 anv_get_isl_format(devinfo
, vk_info
->format
,
155 VK_IMAGE_ASPECT_COLOR_BIT
, vk_info
->tiling
);
157 if (!isl_format_supports_ccs_e(devinfo
, format
))
160 if (!(vk_info
->flags
& VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT
))
163 const VkImageFormatListCreateInfoKHR
*fmt_list
=
164 vk_find_struct_const(vk_info
->pNext
, IMAGE_FORMAT_LIST_CREATE_INFO_KHR
);
166 if (!fmt_list
|| fmt_list
->viewFormatCount
== 0)
169 for (uint32_t i
= 0; i
< fmt_list
->viewFormatCount
; i
++) {
170 enum isl_format view_format
=
171 anv_get_isl_format(devinfo
, fmt_list
->pViewFormats
[i
],
172 VK_IMAGE_ASPECT_COLOR_BIT
, vk_info
->tiling
);
174 if (!isl_formats_are_ccs_e_compatible(devinfo
, format
, view_format
))
182 * For color images that have an auxiliary surface, request allocation for an
183 * additional buffer that mainly stores fast-clear values. Use of this buffer
184 * allows us to access the image's subresources while being aware of their
185 * fast-clear values in non-trivial cases (e.g., outside of a render pass in
186 * which a fast clear has occurred).
188 * For the purpose of discoverability, the algorithm used to manage this buffer
189 * is described here. A clear value in this buffer is updated when a fast clear
190 * is performed on a subresource. One of two synchronization operations is
191 * performed in order for a following memory access to use the fast-clear
193 * a. Copy the value from the buffer to the surface state object used for
194 * reading. This is done implicitly when the value is the clear value
195 * predetermined to be the default in other surface state objects. This
196 * is currently only done explicitly for the operation below.
197 * b. Do (a) and use the surface state object to resolve the subresource.
198 * This is only done during layout transitions for decent performance.
200 * With the above scheme, we can fast-clear whenever the hardware allows except
201 * for two cases in which synchronization becomes impossible or undesirable:
202 * * The subresource is in the GENERAL layout and is cleared to a value
203 * other than the special default value.
205 * Performing a synchronization operation in order to read from the
206 * subresource is undesirable in this case. Firstly, b) is not an option
207 * because a layout transition isn't required between a write and read of
208 * an image in the GENERAL layout. Secondly, it's undesirable to do a)
209 * explicitly because it would require large infrastructural changes. The
210 * Vulkan API supports us in deciding not to optimize this layout by
211 * stating that using this layout may cause suboptimal performance. NOTE:
212 * the auxiliary buffer must always be enabled to support a) implicitly.
215 * * For the given miplevel, only some of the layers are cleared at once.
217 * If the user clears each layer to a different value, then tries to
218 * render to multiple layers at once, we have no ability to perform a
219 * synchronization operation in between. a) is not helpful because the
220 * object can only hold one clear value. b) is not an option because a
221 * layout transition isn't required in this case.
224 add_fast_clear_state_buffer(struct anv_image
*image
,
225 VkImageAspectFlagBits aspect
,
227 const struct anv_device
*device
)
229 assert(image
&& device
);
230 assert(image
->planes
[plane
].aux_surface
.isl
.size
> 0 &&
231 image
->aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
);
233 /* The offset to the buffer of clear values must be dword-aligned for GPU
234 * memcpy operations. It is located immediately after the auxiliary surface.
237 /* Tiled images are guaranteed to be 4K aligned, so the image alignment
238 * should also be dword-aligned.
240 assert(image
->alignment
% 4 == 0);
242 /* Auxiliary buffers should be a multiple of 4K, so the start of the clear
243 * values buffer should already be dword-aligned.
245 assert((image
->planes
[plane
].offset
+ image
->planes
[plane
].size
) % 4 == 0);
247 /* This buffer should be at the very end of the plane. */
248 if (image
->disjoint
) {
249 assert(image
->planes
[plane
].size
==
250 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
252 assert(image
->size
==
253 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
256 const unsigned entry_size
= anv_fast_clear_state_entry_size(device
);
257 /* There's no padding between entries, so ensure that they're always a
258 * multiple of 32 bits in order to enable GPU memcpy operations.
260 assert(entry_size
% 4 == 0);
262 const unsigned plane_state_size
=
263 entry_size
* anv_image_aux_levels(image
, aspect
);
265 image
->planes
[plane
].fast_clear_state_offset
=
266 image
->planes
[plane
].offset
+ image
->planes
[plane
].size
;
268 image
->planes
[plane
].size
+= plane_state_size
;
269 image
->size
+= plane_state_size
;
273 * Initialize the anv_image::*_surface selected by \a aspect. Then update the
274 * image's memory requirements (that is, the image's size and alignment).
277 make_surface(const struct anv_device
*dev
,
278 struct anv_image
*image
,
279 const struct anv_image_create_info
*anv_info
,
280 isl_tiling_flags_t tiling_flags
,
281 VkImageAspectFlagBits aspect
)
283 const VkImageCreateInfo
*vk_info
= anv_info
->vk_info
;
286 static const enum isl_surf_dim vk_to_isl_surf_dim
[] = {
287 [VK_IMAGE_TYPE_1D
] = ISL_SURF_DIM_1D
,
288 [VK_IMAGE_TYPE_2D
] = ISL_SURF_DIM_2D
,
289 [VK_IMAGE_TYPE_3D
] = ISL_SURF_DIM_3D
,
292 image
->extent
= anv_sanitize_image_extent(vk_info
->imageType
,
295 const unsigned plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
296 const struct anv_format_plane plane_format
=
297 anv_get_format_plane(&dev
->info
, image
->vk_format
, aspect
, image
->tiling
);
298 struct anv_surface
*anv_surf
= &image
->planes
[plane
].surface
;
300 const isl_surf_usage_flags_t usage
=
301 choose_isl_surf_usage(vk_info
->flags
, image
->usage
,
302 anv_info
->isl_extra_usage_flags
, aspect
);
304 /* If an image is created as BLOCK_TEXEL_VIEW_COMPATIBLE, then we need to
305 * fall back to linear on Broadwell and earlier because we aren't
306 * guaranteed that we can handle offsets correctly. On Sky Lake, the
307 * horizontal and vertical alignments are sufficiently high that we can
308 * just use RENDER_SURFACE_STATE::X/Y Offset.
310 bool needs_shadow
= false;
311 if (dev
->info
.gen
<= 8 &&
312 (vk_info
->flags
& VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR
) &&
313 vk_info
->tiling
== VK_IMAGE_TILING_OPTIMAL
) {
314 assert(isl_format_is_compressed(plane_format
.isl_format
));
315 tiling_flags
= ISL_TILING_LINEAR_BIT
;
319 ok
= isl_surf_init(&dev
->isl_dev
, &anv_surf
->isl
,
320 .dim
= vk_to_isl_surf_dim
[vk_info
->imageType
],
321 .format
= plane_format
.isl_format
,
322 .width
= image
->extent
.width
/ plane_format
.denominator_scales
[0],
323 .height
= image
->extent
.height
/ plane_format
.denominator_scales
[1],
324 .depth
= image
->extent
.depth
,
325 .levels
= vk_info
->mipLevels
,
326 .array_len
= vk_info
->arrayLayers
,
327 .samples
= vk_info
->samples
,
329 .row_pitch
= anv_info
->stride
,
331 .tiling_flags
= tiling_flags
);
333 /* isl_surf_init() will fail only if provided invalid input. Invalid input
334 * is illegal in Vulkan.
338 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_NONE
;
340 add_surface(image
, anv_surf
, plane
);
342 /* If an image is created as BLOCK_TEXEL_VIEW_COMPATIBLE, then we need to
343 * create an identical tiled shadow surface for use while texturing so we
344 * don't get garbage performance.
347 assert(aspect
== VK_IMAGE_ASPECT_COLOR_BIT
);
348 assert(tiling_flags
== ISL_TILING_LINEAR_BIT
);
350 ok
= isl_surf_init(&dev
->isl_dev
, &image
->planes
[plane
].shadow_surface
.isl
,
351 .dim
= vk_to_isl_surf_dim
[vk_info
->imageType
],
352 .format
= plane_format
.isl_format
,
353 .width
= image
->extent
.width
,
354 .height
= image
->extent
.height
,
355 .depth
= image
->extent
.depth
,
356 .levels
= vk_info
->mipLevels
,
357 .array_len
= vk_info
->arrayLayers
,
358 .samples
= vk_info
->samples
,
360 .row_pitch
= anv_info
->stride
,
362 .tiling_flags
= ISL_TILING_ANY_MASK
);
364 /* isl_surf_init() will fail only if provided invalid input. Invalid input
365 * is illegal in Vulkan.
369 add_surface(image
, &image
->planes
[plane
].shadow_surface
, plane
);
372 /* Add a HiZ surface to a depth buffer that will be used for rendering.
374 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
375 /* We don't advertise that depth buffers could be used as storage
378 assert(!(image
->usage
& VK_IMAGE_USAGE_STORAGE_BIT
));
380 /* Allow the user to control HiZ enabling. Disable by default on gen7
381 * because resolves are not currently implemented pre-BDW.
383 if (!(image
->usage
& VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
)) {
384 /* It will never be used as an attachment, HiZ is pointless. */
385 } else if (dev
->info
.gen
== 7) {
386 anv_perf_warn(dev
->instance
, image
, "Implement gen7 HiZ");
387 } else if (vk_info
->mipLevels
> 1) {
388 anv_perf_warn(dev
->instance
, image
, "Enable multi-LOD HiZ");
389 } else if (vk_info
->arrayLayers
> 1) {
390 anv_perf_warn(dev
->instance
, image
,
391 "Implement multi-arrayLayer HiZ clears and resolves");
392 } else if (dev
->info
.gen
== 8 && vk_info
->samples
> 1) {
393 anv_perf_warn(dev
->instance
, image
, "Enable gen8 multisampled HiZ");
394 } else if (!unlikely(INTEL_DEBUG
& DEBUG_NO_HIZ
)) {
395 assert(image
->planes
[plane
].aux_surface
.isl
.size
== 0);
396 ok
= isl_surf_get_hiz_surf(&dev
->isl_dev
,
397 &image
->planes
[plane
].surface
.isl
,
398 &image
->planes
[plane
].aux_surface
.isl
);
400 add_surface(image
, &image
->planes
[plane
].aux_surface
, plane
);
401 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_HIZ
;
403 } else if ((aspect
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) && vk_info
->samples
== 1) {
404 /* TODO: Disallow compression with :
406 * 1) non multiplanar images (We appear to hit a sampler bug with
407 * CCS & R16G16 format. Putting the clear state a page/4096bytes
408 * further fixes the issue).
410 * 2) alias images, because they might be aliases of images
413 * 3) compression disabled by debug
415 const bool allow_compression
=
416 image
->n_planes
== 1 &&
417 (vk_info
->flags
& VK_IMAGE_CREATE_ALIAS_BIT_KHR
) == 0 &&
418 likely((INTEL_DEBUG
& DEBUG_NO_RBC
) == 0);
420 if (allow_compression
) {
421 assert(image
->planes
[plane
].aux_surface
.isl
.size
== 0);
422 ok
= isl_surf_get_ccs_surf(&dev
->isl_dev
,
423 &image
->planes
[plane
].surface
.isl
,
424 &image
->planes
[plane
].aux_surface
.isl
, 0);
427 /* Disable CCS when it is not useful (i.e., when you can't render
428 * to the image with CCS enabled).
430 if (!isl_format_supports_rendering(&dev
->info
,
431 plane_format
.isl_format
)) {
432 /* While it may be technically possible to enable CCS for this
433 * image, we currently don't have things hooked up to get it
436 anv_perf_warn(dev
->instance
, image
,
437 "This image format doesn't support rendering. "
438 "Not allocating an CCS buffer.");
439 image
->planes
[plane
].aux_surface
.isl
.size
= 0;
443 add_surface(image
, &image
->planes
[plane
].aux_surface
, plane
);
444 add_fast_clear_state_buffer(image
, aspect
, plane
, dev
);
446 /* For images created without MUTABLE_FORMAT_BIT set, we know that
447 * they will always be used with the original format. In
448 * particular, they will always be used with a format that
449 * supports color compression. If it's never used as a storage
450 * image, then it will only be used through the sampler or the as
451 * a render target. This means that it's safe to just leave
452 * compression on at all times for these formats.
454 if (!(vk_info
->usage
& VK_IMAGE_USAGE_STORAGE_BIT
) &&
455 all_formats_ccs_e_compatible(&dev
->info
, vk_info
)) {
456 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_CCS_E
;
460 } else if ((aspect
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) && vk_info
->samples
> 1) {
461 assert(!(vk_info
->usage
& VK_IMAGE_USAGE_STORAGE_BIT
));
462 assert(image
->planes
[plane
].aux_surface
.isl
.size
== 0);
463 ok
= isl_surf_get_mcs_surf(&dev
->isl_dev
,
464 &image
->planes
[plane
].surface
.isl
,
465 &image
->planes
[plane
].aux_surface
.isl
);
467 add_surface(image
, &image
->planes
[plane
].aux_surface
, plane
);
468 add_fast_clear_state_buffer(image
, aspect
, plane
, dev
);
469 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_MCS
;
473 assert((image
->planes
[plane
].offset
+ image
->planes
[plane
].size
) == image
->size
);
475 /* Upper bound of the last surface should be smaller than the plane's
478 assert((MAX2(image
->planes
[plane
].surface
.offset
,
479 image
->planes
[plane
].aux_surface
.offset
) +
480 (image
->planes
[plane
].aux_surface
.isl
.size
> 0 ?
481 image
->planes
[plane
].aux_surface
.isl
.size
:
482 image
->planes
[plane
].surface
.isl
.size
)) <=
483 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
485 if (image
->planes
[plane
].aux_surface
.isl
.size
) {
486 /* assert(image->planes[plane].fast_clear_state_offset == */
487 /* (image->planes[plane].aux_surface.offset + image->planes[plane].aux_surface.isl.size)); */
488 assert(image
->planes
[plane
].fast_clear_state_offset
<
489 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
496 anv_image_create(VkDevice _device
,
497 const struct anv_image_create_info
*create_info
,
498 const VkAllocationCallbacks
* alloc
,
501 ANV_FROM_HANDLE(anv_device
, device
, _device
);
502 const VkImageCreateInfo
*pCreateInfo
= create_info
->vk_info
;
503 struct anv_image
*image
= NULL
;
506 assert(pCreateInfo
->sType
== VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO
);
508 anv_assert(pCreateInfo
->mipLevels
> 0);
509 anv_assert(pCreateInfo
->arrayLayers
> 0);
510 anv_assert(pCreateInfo
->samples
> 0);
511 anv_assert(pCreateInfo
->extent
.width
> 0);
512 anv_assert(pCreateInfo
->extent
.height
> 0);
513 anv_assert(pCreateInfo
->extent
.depth
> 0);
515 image
= vk_zalloc2(&device
->alloc
, alloc
, sizeof(*image
), 8,
516 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT
);
518 return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY
);
520 image
->type
= pCreateInfo
->imageType
;
521 image
->extent
= pCreateInfo
->extent
;
522 image
->vk_format
= pCreateInfo
->format
;
523 image
->format
= anv_get_format(pCreateInfo
->format
);
524 image
->aspects
= vk_format_aspects(image
->vk_format
);
525 image
->levels
= pCreateInfo
->mipLevels
;
526 image
->array_size
= pCreateInfo
->arrayLayers
;
527 image
->samples
= pCreateInfo
->samples
;
528 image
->usage
= pCreateInfo
->usage
;
529 image
->tiling
= pCreateInfo
->tiling
;
530 image
->disjoint
= pCreateInfo
->flags
& VK_IMAGE_CREATE_DISJOINT_BIT_KHR
;
532 const struct anv_format
*format
= anv_get_format(image
->vk_format
);
533 assert(format
!= NULL
);
535 const isl_tiling_flags_t isl_tiling_flags
=
536 choose_isl_tiling_flags(create_info
);
538 image
->n_planes
= format
->n_planes
;
541 for_each_bit(b
, image
->aspects
) {
542 r
= make_surface(device
, image
, create_info
, isl_tiling_flags
,
548 *pImage
= anv_image_to_handle(image
);
554 vk_free2(&device
->alloc
, alloc
, image
);
560 anv_CreateImage(VkDevice device
,
561 const VkImageCreateInfo
*pCreateInfo
,
562 const VkAllocationCallbacks
*pAllocator
,
566 const VkNativeBufferANDROID
*gralloc_info
=
567 vk_find_struct_const(pCreateInfo
->pNext
, NATIVE_BUFFER_ANDROID
);
570 return anv_image_from_gralloc(device
, pCreateInfo
, gralloc_info
,
574 return anv_image_create(device
,
575 &(struct anv_image_create_info
) {
576 .vk_info
= pCreateInfo
,
583 anv_DestroyImage(VkDevice _device
, VkImage _image
,
584 const VkAllocationCallbacks
*pAllocator
)
586 ANV_FROM_HANDLE(anv_device
, device
, _device
);
587 ANV_FROM_HANDLE(anv_image
, image
, _image
);
592 for (uint32_t p
= 0; p
< image
->n_planes
; ++p
) {
593 if (image
->planes
[p
].bo_is_owned
) {
594 assert(image
->planes
[p
].bo
!= NULL
);
595 anv_bo_cache_release(device
, &device
->bo_cache
, image
->planes
[p
].bo
);
599 vk_free2(&device
->alloc
, pAllocator
, image
);
602 static void anv_image_bind_memory_plane(struct anv_device
*device
,
603 struct anv_image
*image
,
605 struct anv_device_memory
*memory
,
606 uint32_t memory_offset
)
608 assert(!image
->planes
[plane
].bo_is_owned
);
611 image
->planes
[plane
].bo
= NULL
;
612 image
->planes
[plane
].bo_offset
= 0;
616 image
->planes
[plane
].bo
= memory
->bo
;
617 image
->planes
[plane
].bo_offset
= memory_offset
;
620 VkResult
anv_BindImageMemory(
623 VkDeviceMemory _memory
,
624 VkDeviceSize memoryOffset
)
626 ANV_FROM_HANDLE(anv_device
, device
, _device
);
627 ANV_FROM_HANDLE(anv_device_memory
, mem
, _memory
);
628 ANV_FROM_HANDLE(anv_image
, image
, _image
);
631 anv_foreach_image_aspect_bit(aspect_bit
, image
, image
->aspects
) {
633 anv_image_aspect_to_plane(image
->aspects
, 1UL << aspect_bit
);
634 anv_image_bind_memory_plane(device
, image
, plane
, mem
, memoryOffset
);
640 VkResult
anv_BindImageMemory2KHR(
642 uint32_t bindInfoCount
,
643 const VkBindImageMemoryInfoKHR
* pBindInfos
)
645 ANV_FROM_HANDLE(anv_device
, device
, _device
);
647 for (uint32_t i
= 0; i
< bindInfoCount
; i
++) {
648 const VkBindImageMemoryInfoKHR
*bind_info
= &pBindInfos
[i
];
649 ANV_FROM_HANDLE(anv_device_memory
, mem
, bind_info
->memory
);
650 ANV_FROM_HANDLE(anv_image
, image
, bind_info
->image
);
651 VkImageAspectFlags aspects
= image
->aspects
;
653 vk_foreach_struct_const(s
, bind_info
->pNext
) {
655 case VK_STRUCTURE_TYPE_BIND_IMAGE_PLANE_MEMORY_INFO_KHR
: {
656 const VkBindImagePlaneMemoryInfoKHR
*plane_info
=
657 (const VkBindImagePlaneMemoryInfoKHR
*) s
;
659 aspects
= plane_info
->planeAspect
;
663 anv_debug_ignored_stype(s
->sType
);
669 anv_foreach_image_aspect_bit(aspect_bit
, image
, aspects
) {
671 anv_image_aspect_to_plane(image
->aspects
, 1UL << aspect_bit
);
672 anv_image_bind_memory_plane(device
, image
, plane
,
673 mem
, bind_info
->memoryOffset
);
680 void anv_GetImageSubresourceLayout(
683 const VkImageSubresource
* subresource
,
684 VkSubresourceLayout
* layout
)
686 ANV_FROM_HANDLE(anv_image
, image
, _image
);
687 const struct anv_surface
*surface
=
688 get_surface(image
, subresource
->aspectMask
);
690 assert(__builtin_popcount(subresource
->aspectMask
) == 1);
692 /* If we are on a non-zero mip level or array slice, we need to
693 * calculate a real offset.
695 anv_assert(subresource
->mipLevel
== 0);
696 anv_assert(subresource
->arrayLayer
== 0);
698 layout
->offset
= surface
->offset
;
699 layout
->rowPitch
= surface
->isl
.row_pitch
;
700 layout
->depthPitch
= isl_surf_get_array_pitch(&surface
->isl
);
701 layout
->arrayPitch
= isl_surf_get_array_pitch(&surface
->isl
);
702 layout
->size
= surface
->isl
.size
;
706 * This function determines the optimal buffer to use for a given
707 * VkImageLayout and other pieces of information needed to make that
708 * determination. This does not determine the optimal buffer to use
709 * during a resolve operation.
711 * @param devinfo The device information of the Intel GPU.
712 * @param image The image that may contain a collection of buffers.
713 * @param plane The plane of the image to be accessed.
714 * @param layout The current layout of the image aspect(s).
716 * @return The primary buffer that should be used for the given layout.
719 anv_layout_to_aux_usage(const struct gen_device_info
* const devinfo
,
720 const struct anv_image
* const image
,
721 const VkImageAspectFlagBits aspect
,
722 const VkImageLayout layout
)
724 /* Validate the inputs. */
726 /* The devinfo is needed as the optimal buffer varies across generations. */
727 assert(devinfo
!= NULL
);
729 /* The layout of a NULL image is not properly defined. */
730 assert(image
!= NULL
);
732 /* The aspect must be exactly one of the image aspects. */
733 assert(_mesa_bitcount(aspect
) == 1 && (aspect
& image
->aspects
));
735 /* Determine the optimal buffer. */
737 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
739 /* If there is no auxiliary surface allocated, we must use the one and only
742 if (image
->planes
[plane
].aux_surface
.isl
.size
== 0)
743 return ISL_AUX_USAGE_NONE
;
745 /* All images that use an auxiliary surface are required to be tiled. */
746 assert(image
->tiling
== VK_IMAGE_TILING_OPTIMAL
);
748 /* Stencil has no aux */
749 assert(aspect
!= VK_IMAGE_ASPECT_STENCIL_BIT
);
751 /* The following switch currently only handles depth stencil aspects.
752 * TODO: Handle the color aspect.
754 if (image
->aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
)
755 return image
->planes
[plane
].aux_usage
;
759 /* Invalid Layouts */
760 case VK_IMAGE_LAYOUT_RANGE_SIZE
:
761 case VK_IMAGE_LAYOUT_MAX_ENUM
:
762 unreachable("Invalid image layout.");
766 * The pre-initialized layout is equivalent to the undefined layout for
767 * optimally-tiled images. We can only do color compression (CCS or HiZ)
770 case VK_IMAGE_LAYOUT_UNDEFINED
:
771 case VK_IMAGE_LAYOUT_PREINITIALIZED
:
772 return ISL_AUX_USAGE_NONE
;
777 * This buffer could be a depth buffer used in a transfer operation. BLORP
778 * currently doesn't use HiZ for transfer operations so we must use the main
779 * buffer for this layout. TODO: Enable HiZ in BLORP.
781 case VK_IMAGE_LAYOUT_GENERAL
:
782 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL
:
783 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL
:
784 return ISL_AUX_USAGE_NONE
;
787 /* Sampling Layouts */
788 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
:
789 assert((image
->aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) == 0);
791 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL
:
792 case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL_KHR
:
793 assert(aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
);
794 if (anv_can_sample_with_hiz(devinfo
, image
))
795 return ISL_AUX_USAGE_HIZ
;
797 return ISL_AUX_USAGE_NONE
;
799 case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR
:
800 assert(image
->aspects
== VK_IMAGE_ASPECT_COLOR_BIT
);
802 /* On SKL+, the render buffer can be decompressed by the presentation
803 * engine. Support for this feature has not yet landed in the wider
804 * ecosystem. TODO: Update this code when support lands.
806 * From the BDW PRM, Vol 7, Render Target Resolve:
808 * If the MCS is enabled on a non-multisampled render target, the
809 * render target must be resolved before being used for other
810 * purposes (display, texture, CPU lock) The clear value from
811 * SURFACE_STATE is written into pixels in the render target
812 * indicated as clear in the MCS.
814 * Pre-SKL, the render buffer must be resolved before being used for
815 * presentation. We can infer that the auxiliary buffer is not used.
817 return ISL_AUX_USAGE_NONE
;
820 /* Rendering Layouts */
821 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
:
822 assert(image
->aspects
== VK_IMAGE_ASPECT_COLOR_BIT
);
823 unreachable("Color images are not yet supported.");
825 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
:
826 case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL_KHR
:
827 assert(aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
);
828 return ISL_AUX_USAGE_HIZ
;
830 case VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR
:
831 unreachable("VK_KHR_shared_presentable_image is unsupported");
834 /* If the layout isn't recognized in the exhaustive switch above, the
835 * VkImageLayout value is not defined in vulkan.h.
837 unreachable("layout is not a VkImageLayout enumeration member.");
841 static struct anv_state
842 alloc_surface_state(struct anv_device
*device
)
844 return anv_state_pool_alloc(&device
->surface_state_pool
, 64, 64);
847 static enum isl_channel_select
848 remap_swizzle(VkComponentSwizzle swizzle
, VkComponentSwizzle component
,
849 struct isl_swizzle format_swizzle
)
851 if (swizzle
== VK_COMPONENT_SWIZZLE_IDENTITY
)
855 case VK_COMPONENT_SWIZZLE_ZERO
: return ISL_CHANNEL_SELECT_ZERO
;
856 case VK_COMPONENT_SWIZZLE_ONE
: return ISL_CHANNEL_SELECT_ONE
;
857 case VK_COMPONENT_SWIZZLE_R
: return format_swizzle
.r
;
858 case VK_COMPONENT_SWIZZLE_G
: return format_swizzle
.g
;
859 case VK_COMPONENT_SWIZZLE_B
: return format_swizzle
.b
;
860 case VK_COMPONENT_SWIZZLE_A
: return format_swizzle
.a
;
862 unreachable("Invalid swizzle");
867 anv_image_fill_surface_state(struct anv_device
*device
,
868 const struct anv_image
*image
,
869 VkImageAspectFlagBits aspect
,
870 const struct isl_view
*view_in
,
871 isl_surf_usage_flags_t view_usage
,
872 enum isl_aux_usage aux_usage
,
873 const union isl_color_value
*clear_color
,
874 enum anv_image_view_state_flags flags
,
875 struct anv_surface_state
*state_inout
,
876 struct brw_image_param
*image_param_out
)
878 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
880 const struct anv_surface
*surface
= &image
->planes
[plane
].surface
,
881 *aux_surface
= &image
->planes
[plane
].aux_surface
;
883 struct isl_view view
= *view_in
;
884 view
.usage
|= view_usage
;
886 /* For texturing with VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL from a
887 * compressed surface with a shadow surface, we use the shadow instead of
888 * the primary surface. The shadow surface will be tiled, unlike the main
889 * surface, so it should get significantly better performance.
891 if (image
->planes
[plane
].shadow_surface
.isl
.size
> 0 &&
892 isl_format_is_compressed(view
.format
) &&
893 (flags
& ANV_IMAGE_VIEW_STATE_TEXTURE_OPTIMAL
)) {
894 assert(isl_format_is_compressed(surface
->isl
.format
));
895 assert(surface
->isl
.tiling
== ISL_TILING_LINEAR
);
896 assert(image
->planes
[plane
].shadow_surface
.isl
.tiling
!= ISL_TILING_LINEAR
);
897 surface
= &image
->planes
[plane
].shadow_surface
;
900 if (view_usage
== ISL_SURF_USAGE_RENDER_TARGET_BIT
)
901 view
.swizzle
= anv_swizzle_for_render(view
.swizzle
);
903 /* If this is a HiZ buffer we can sample from with a programmable clear
904 * value (SKL+), define the clear value to the optimal constant.
906 union isl_color_value default_clear_color
= { .u32
= { 0, } };
907 if (device
->info
.gen
>= 9 && aux_usage
== ISL_AUX_USAGE_HIZ
)
908 default_clear_color
.f32
[0] = ANV_HZ_FC_VAL
;
910 clear_color
= &default_clear_color
;
912 const uint64_t address
= image
->planes
[plane
].bo_offset
+ surface
->offset
;
913 const uint64_t aux_address
= aux_usage
== ISL_AUX_USAGE_NONE
?
914 0 : (image
->planes
[plane
].bo_offset
+ aux_surface
->offset
);
916 if (view_usage
== ISL_SURF_USAGE_STORAGE_BIT
&&
917 !(flags
& ANV_IMAGE_VIEW_STATE_STORAGE_WRITE_ONLY
) &&
918 !isl_has_matching_typed_storage_image_format(&device
->info
,
920 /* In this case, we are a writeable storage buffer which needs to be
921 * lowered to linear. All tiling and offset calculations will be done in
924 assert(aux_usage
== ISL_AUX_USAGE_NONE
);
925 isl_buffer_fill_state(&device
->isl_dev
, state_inout
->state
.map
,
927 .size
= surface
->isl
.size
,
928 .format
= ISL_FORMAT_RAW
,
930 .mocs
= device
->default_mocs
);
931 state_inout
->address
= address
,
932 state_inout
->aux_address
= 0;
934 if (view_usage
== ISL_SURF_USAGE_STORAGE_BIT
&&
935 !(flags
& ANV_IMAGE_VIEW_STATE_STORAGE_WRITE_ONLY
)) {
936 /* Typed surface reads support a very limited subset of the shader
937 * image formats. Translate it into the closest format the hardware
940 assert(aux_usage
== ISL_AUX_USAGE_NONE
);
941 view
.format
= isl_lower_storage_image_format(&device
->info
,
945 const struct isl_surf
*isl_surf
= &surface
->isl
;
947 struct isl_surf tmp_surf
;
948 uint32_t offset_B
= 0, tile_x_sa
= 0, tile_y_sa
= 0;
949 if (isl_format_is_compressed(surface
->isl
.format
) &&
950 !isl_format_is_compressed(view
.format
)) {
951 /* We're creating an uncompressed view of a compressed surface. This
952 * is allowed but only for a single level/layer.
954 assert(surface
->isl
.samples
== 1);
955 assert(view
.levels
== 1);
956 assert(view
.array_len
== 1);
958 isl_surf_get_image_surf(&device
->isl_dev
, isl_surf
,
960 surface
->isl
.dim
== ISL_SURF_DIM_3D
?
961 0 : view
.base_array_layer
,
962 surface
->isl
.dim
== ISL_SURF_DIM_3D
?
963 view
.base_array_layer
: 0,
965 &offset_B
, &tile_x_sa
, &tile_y_sa
);
967 /* The newly created image represents the one subimage we're
968 * referencing with this view so it only has one array slice and
971 view
.base_array_layer
= 0;
974 /* We're making an uncompressed view here. The image dimensions need
975 * to be scaled down by the block size.
977 const struct isl_format_layout
*fmtl
=
978 isl_format_get_layout(surface
->isl
.format
);
979 tmp_surf
.format
= view
.format
;
980 tmp_surf
.logical_level0_px
.width
=
981 DIV_ROUND_UP(tmp_surf
.logical_level0_px
.width
, fmtl
->bw
);
982 tmp_surf
.logical_level0_px
.height
=
983 DIV_ROUND_UP(tmp_surf
.logical_level0_px
.height
, fmtl
->bh
);
984 tmp_surf
.phys_level0_sa
.width
/= fmtl
->bw
;
985 tmp_surf
.phys_level0_sa
.height
/= fmtl
->bh
;
986 tile_x_sa
/= fmtl
->bw
;
987 tile_y_sa
/= fmtl
->bh
;
989 isl_surf
= &tmp_surf
;
991 if (device
->info
.gen
<= 8) {
992 assert(surface
->isl
.tiling
== ISL_TILING_LINEAR
);
993 assert(tile_x_sa
== 0);
994 assert(tile_y_sa
== 0);
998 isl_surf_fill_state(&device
->isl_dev
, state_inout
->state
.map
,
1001 .address
= address
+ offset_B
,
1002 .clear_color
= *clear_color
,
1003 .aux_surf
= &aux_surface
->isl
,
1004 .aux_usage
= aux_usage
,
1005 .aux_address
= aux_address
,
1006 .mocs
= device
->default_mocs
,
1007 .x_offset_sa
= tile_x_sa
,
1008 .y_offset_sa
= tile_y_sa
);
1009 state_inout
->address
= address
+ offset_B
;
1010 if (device
->info
.gen
>= 8) {
1011 state_inout
->aux_address
= aux_address
;
1013 /* On gen7 and prior, the bottom 12 bits of the MCS base address are
1014 * used to store other information. This should be ok, however,
1015 * because surface buffer addresses are always 4K page alinged.
1017 uint32_t *aux_addr_dw
= state_inout
->state
.map
+
1018 device
->isl_dev
.ss
.aux_addr_offset
;
1019 assert((aux_address
& 0xfff) == 0);
1020 assert(aux_address
== (*aux_addr_dw
& 0xfffff000));
1021 state_inout
->aux_address
= *aux_addr_dw
;
1025 anv_state_flush(device
, state_inout
->state
);
1027 if (image_param_out
) {
1028 assert(view_usage
== ISL_SURF_USAGE_STORAGE_BIT
);
1029 isl_surf_fill_image_param(&device
->isl_dev
, image_param_out
,
1030 &surface
->isl
, &view
);
1034 static VkImageAspectFlags
1035 remap_aspect_flags(VkImageAspectFlags view_aspects
)
1037 if (view_aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) {
1038 if (_mesa_bitcount(view_aspects
) == 1)
1039 return VK_IMAGE_ASPECT_COLOR_BIT
;
1041 VkImageAspectFlags color_aspects
= 0;
1042 for (uint32_t i
= 0; i
< _mesa_bitcount(view_aspects
); i
++)
1043 color_aspects
|= VK_IMAGE_ASPECT_PLANE_0_BIT_KHR
<< i
;
1044 return color_aspects
;
1046 /* No special remapping needed for depth & stencil aspects. */
1047 return view_aspects
;
1051 anv_CreateImageView(VkDevice _device
,
1052 const VkImageViewCreateInfo
*pCreateInfo
,
1053 const VkAllocationCallbacks
*pAllocator
,
1056 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1057 ANV_FROM_HANDLE(anv_image
, image
, pCreateInfo
->image
);
1058 struct anv_image_view
*iview
;
1060 iview
= vk_zalloc2(&device
->alloc
, pAllocator
, sizeof(*iview
), 8,
1061 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT
);
1063 return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY
);
1065 const VkImageSubresourceRange
*range
= &pCreateInfo
->subresourceRange
;
1067 assert(range
->layerCount
> 0);
1068 assert(range
->baseMipLevel
< image
->levels
);
1070 const VkImageViewUsageCreateInfoKHR
*usage_info
=
1071 vk_find_struct_const(pCreateInfo
, IMAGE_VIEW_USAGE_CREATE_INFO_KHR
);
1072 VkImageUsageFlags view_usage
= usage_info
? usage_info
->usage
: image
->usage
;
1073 /* View usage should be a subset of image usage */
1074 assert((view_usage
& ~image
->usage
) == 0);
1075 assert(view_usage
& (VK_IMAGE_USAGE_SAMPLED_BIT
|
1076 VK_IMAGE_USAGE_STORAGE_BIT
|
1077 VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
|
1078 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
|
1079 VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
));
1081 switch (image
->type
) {
1083 unreachable("bad VkImageType");
1084 case VK_IMAGE_TYPE_1D
:
1085 case VK_IMAGE_TYPE_2D
:
1086 assert(range
->baseArrayLayer
+ anv_get_layerCount(image
, range
) - 1 <= image
->array_size
);
1088 case VK_IMAGE_TYPE_3D
:
1089 assert(range
->baseArrayLayer
+ anv_get_layerCount(image
, range
) - 1
1090 <= anv_minify(image
->extent
.depth
, range
->baseMipLevel
));
1094 /* First expand aspects to the image's ones (for example
1095 * VK_IMAGE_ASPECT_COLOR_BIT will be converted to
1096 * VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR |
1097 * VK_IMAGE_ASPECT_PLANE_2_BIT_KHR for an image of format
1098 * VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM_KHR.
1100 VkImageAspectFlags expanded_aspects
=
1101 anv_image_expand_aspects(image
, range
->aspectMask
);
1103 iview
->image
= image
;
1105 /* Remap the expanded aspects for the image view. For example if only
1106 * VK_IMAGE_ASPECT_PLANE_1_BIT_KHR was given in range->aspectMask, we will
1107 * convert it to VK_IMAGE_ASPECT_COLOR_BIT since from the point of view of
1108 * the image view, it only has a single plane.
1110 iview
->aspect_mask
= remap_aspect_flags(expanded_aspects
);
1111 iview
->n_planes
= anv_image_aspect_get_planes(iview
->aspect_mask
);
1112 iview
->vk_format
= pCreateInfo
->format
;
1114 iview
->extent
= (VkExtent3D
) {
1115 .width
= anv_minify(image
->extent
.width
, range
->baseMipLevel
),
1116 .height
= anv_minify(image
->extent
.height
, range
->baseMipLevel
),
1117 .depth
= anv_minify(image
->extent
.depth
, range
->baseMipLevel
),
1120 /* Now go through the underlying image selected planes (computed in
1121 * expanded_aspects) and map them to planes in the image view.
1123 uint32_t iaspect_bit
, vplane
= 0;
1124 anv_foreach_image_aspect_bit(iaspect_bit
, image
, expanded_aspects
) {
1126 anv_image_aspect_to_plane(expanded_aspects
, 1UL << iaspect_bit
);
1127 VkImageAspectFlags vplane_aspect
=
1128 anv_plane_to_aspect(iview
->aspect_mask
, vplane
);
1129 struct anv_format_plane format
=
1130 anv_get_format_plane(&device
->info
, pCreateInfo
->format
,
1131 vplane_aspect
, image
->tiling
);
1133 iview
->planes
[vplane
].image_plane
= iplane
;
1135 iview
->planes
[vplane
].isl
= (struct isl_view
) {
1136 .format
= format
.isl_format
,
1137 .base_level
= range
->baseMipLevel
,
1138 .levels
= anv_get_levelCount(image
, range
),
1139 .base_array_layer
= range
->baseArrayLayer
,
1140 .array_len
= anv_get_layerCount(image
, range
),
1142 .r
= remap_swizzle(pCreateInfo
->components
.r
,
1143 VK_COMPONENT_SWIZZLE_R
, format
.swizzle
),
1144 .g
= remap_swizzle(pCreateInfo
->components
.g
,
1145 VK_COMPONENT_SWIZZLE_G
, format
.swizzle
),
1146 .b
= remap_swizzle(pCreateInfo
->components
.b
,
1147 VK_COMPONENT_SWIZZLE_B
, format
.swizzle
),
1148 .a
= remap_swizzle(pCreateInfo
->components
.a
,
1149 VK_COMPONENT_SWIZZLE_A
, format
.swizzle
),
1153 if (pCreateInfo
->viewType
== VK_IMAGE_VIEW_TYPE_3D
) {
1154 iview
->planes
[vplane
].isl
.base_array_layer
= 0;
1155 iview
->planes
[vplane
].isl
.array_len
= iview
->extent
.depth
;
1158 if (pCreateInfo
->viewType
== VK_IMAGE_VIEW_TYPE_CUBE
||
1159 pCreateInfo
->viewType
== VK_IMAGE_VIEW_TYPE_CUBE_ARRAY
) {
1160 iview
->planes
[vplane
].isl
.usage
= ISL_SURF_USAGE_CUBE_BIT
;
1162 iview
->planes
[vplane
].isl
.usage
= 0;
1165 if (view_usage
& VK_IMAGE_USAGE_SAMPLED_BIT
||
1166 (view_usage
& VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
&&
1167 !(iview
->aspect_mask
& VK_IMAGE_ASPECT_COLOR_BIT
))) {
1168 iview
->planes
[vplane
].optimal_sampler_surface_state
.state
= alloc_surface_state(device
);
1169 iview
->planes
[vplane
].general_sampler_surface_state
.state
= alloc_surface_state(device
);
1171 enum isl_aux_usage general_aux_usage
=
1172 anv_layout_to_aux_usage(&device
->info
, image
, 1UL << iaspect_bit
,
1173 VK_IMAGE_LAYOUT_GENERAL
);
1174 enum isl_aux_usage optimal_aux_usage
=
1175 anv_layout_to_aux_usage(&device
->info
, image
, 1UL << iaspect_bit
,
1176 VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL
);
1178 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
1179 &iview
->planes
[vplane
].isl
,
1180 ISL_SURF_USAGE_TEXTURE_BIT
,
1181 optimal_aux_usage
, NULL
,
1182 ANV_IMAGE_VIEW_STATE_TEXTURE_OPTIMAL
,
1183 &iview
->planes
[vplane
].optimal_sampler_surface_state
,
1186 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
1187 &iview
->planes
[vplane
].isl
,
1188 ISL_SURF_USAGE_TEXTURE_BIT
,
1189 general_aux_usage
, NULL
,
1191 &iview
->planes
[vplane
].general_sampler_surface_state
,
1195 /* NOTE: This one needs to go last since it may stomp isl_view.format */
1196 if (view_usage
& VK_IMAGE_USAGE_STORAGE_BIT
) {
1197 iview
->planes
[vplane
].storage_surface_state
.state
= alloc_surface_state(device
);
1198 iview
->planes
[vplane
].writeonly_storage_surface_state
.state
= alloc_surface_state(device
);
1200 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
1201 &iview
->planes
[vplane
].isl
,
1202 ISL_SURF_USAGE_STORAGE_BIT
,
1203 ISL_AUX_USAGE_NONE
, NULL
,
1205 &iview
->planes
[vplane
].storage_surface_state
,
1206 &iview
->planes
[vplane
].storage_image_param
);
1208 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
1209 &iview
->planes
[vplane
].isl
,
1210 ISL_SURF_USAGE_STORAGE_BIT
,
1211 ISL_AUX_USAGE_NONE
, NULL
,
1212 ANV_IMAGE_VIEW_STATE_STORAGE_WRITE_ONLY
,
1213 &iview
->planes
[vplane
].writeonly_storage_surface_state
,
1220 *pView
= anv_image_view_to_handle(iview
);
1226 anv_DestroyImageView(VkDevice _device
, VkImageView _iview
,
1227 const VkAllocationCallbacks
*pAllocator
)
1229 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1230 ANV_FROM_HANDLE(anv_image_view
, iview
, _iview
);
1235 for (uint32_t plane
= 0; plane
< iview
->n_planes
; plane
++) {
1236 if (iview
->planes
[plane
].optimal_sampler_surface_state
.state
.alloc_size
> 0) {
1237 anv_state_pool_free(&device
->surface_state_pool
,
1238 iview
->planes
[plane
].optimal_sampler_surface_state
.state
);
1241 if (iview
->planes
[plane
].general_sampler_surface_state
.state
.alloc_size
> 0) {
1242 anv_state_pool_free(&device
->surface_state_pool
,
1243 iview
->planes
[plane
].general_sampler_surface_state
.state
);
1246 if (iview
->planes
[plane
].storage_surface_state
.state
.alloc_size
> 0) {
1247 anv_state_pool_free(&device
->surface_state_pool
,
1248 iview
->planes
[plane
].storage_surface_state
.state
);
1251 if (iview
->planes
[plane
].writeonly_storage_surface_state
.state
.alloc_size
> 0) {
1252 anv_state_pool_free(&device
->surface_state_pool
,
1253 iview
->planes
[plane
].writeonly_storage_surface_state
.state
);
1257 vk_free2(&device
->alloc
, pAllocator
, iview
);
1262 anv_CreateBufferView(VkDevice _device
,
1263 const VkBufferViewCreateInfo
*pCreateInfo
,
1264 const VkAllocationCallbacks
*pAllocator
,
1265 VkBufferView
*pView
)
1267 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1268 ANV_FROM_HANDLE(anv_buffer
, buffer
, pCreateInfo
->buffer
);
1269 struct anv_buffer_view
*view
;
1271 view
= vk_alloc2(&device
->alloc
, pAllocator
, sizeof(*view
), 8,
1272 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT
);
1274 return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY
);
1276 /* TODO: Handle the format swizzle? */
1278 view
->format
= anv_get_isl_format(&device
->info
, pCreateInfo
->format
,
1279 VK_IMAGE_ASPECT_COLOR_BIT
,
1280 VK_IMAGE_TILING_LINEAR
);
1281 const uint32_t format_bs
= isl_format_get_layout(view
->format
)->bpb
/ 8;
1282 view
->bo
= buffer
->bo
;
1283 view
->offset
= buffer
->offset
+ pCreateInfo
->offset
;
1284 view
->range
= anv_buffer_get_range(buffer
, pCreateInfo
->offset
,
1285 pCreateInfo
->range
);
1286 view
->range
= align_down_npot_u32(view
->range
, format_bs
);
1288 if (buffer
->usage
& VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT
) {
1289 view
->surface_state
= alloc_surface_state(device
);
1291 anv_fill_buffer_surface_state(device
, view
->surface_state
,
1293 view
->offset
, view
->range
, format_bs
);
1295 view
->surface_state
= (struct anv_state
){ 0 };
1298 if (buffer
->usage
& VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT
) {
1299 view
->storage_surface_state
= alloc_surface_state(device
);
1300 view
->writeonly_storage_surface_state
= alloc_surface_state(device
);
1302 enum isl_format storage_format
=
1303 isl_has_matching_typed_storage_image_format(&device
->info
,
1305 isl_lower_storage_image_format(&device
->info
, view
->format
) :
1308 anv_fill_buffer_surface_state(device
, view
->storage_surface_state
,
1310 view
->offset
, view
->range
,
1311 (storage_format
== ISL_FORMAT_RAW
? 1 :
1312 isl_format_get_layout(storage_format
)->bpb
/ 8));
1314 /* Write-only accesses should use the original format. */
1315 anv_fill_buffer_surface_state(device
, view
->writeonly_storage_surface_state
,
1317 view
->offset
, view
->range
,
1318 isl_format_get_layout(view
->format
)->bpb
/ 8);
1320 isl_buffer_fill_image_param(&device
->isl_dev
,
1321 &view
->storage_image_param
,
1322 view
->format
, view
->range
);
1324 view
->storage_surface_state
= (struct anv_state
){ 0 };
1325 view
->writeonly_storage_surface_state
= (struct anv_state
){ 0 };
1328 *pView
= anv_buffer_view_to_handle(view
);
1334 anv_DestroyBufferView(VkDevice _device
, VkBufferView bufferView
,
1335 const VkAllocationCallbacks
*pAllocator
)
1337 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1338 ANV_FROM_HANDLE(anv_buffer_view
, view
, bufferView
);
1343 if (view
->surface_state
.alloc_size
> 0)
1344 anv_state_pool_free(&device
->surface_state_pool
,
1345 view
->surface_state
);
1347 if (view
->storage_surface_state
.alloc_size
> 0)
1348 anv_state_pool_free(&device
->surface_state_pool
,
1349 view
->storage_surface_state
);
1351 if (view
->writeonly_storage_surface_state
.alloc_size
> 0)
1352 anv_state_pool_free(&device
->surface_state_pool
,
1353 view
->writeonly_storage_surface_state
);
1355 vk_free2(&device
->alloc
, pAllocator
, view
);
1358 const struct anv_surface
*
1359 anv_image_get_surface_for_aspect_mask(const struct anv_image
*image
,
1360 VkImageAspectFlags aspect_mask
)
1362 VkImageAspectFlags sanitized_mask
;
1364 switch (aspect_mask
) {
1365 case VK_IMAGE_ASPECT_COLOR_BIT
:
1366 assert(image
->aspects
== VK_IMAGE_ASPECT_COLOR_BIT
);
1367 sanitized_mask
= VK_IMAGE_ASPECT_COLOR_BIT
;
1369 case VK_IMAGE_ASPECT_DEPTH_BIT
:
1370 assert(image
->aspects
& VK_IMAGE_ASPECT_DEPTH_BIT
);
1371 sanitized_mask
= VK_IMAGE_ASPECT_DEPTH_BIT
;
1373 case VK_IMAGE_ASPECT_STENCIL_BIT
:
1374 assert(image
->aspects
& VK_IMAGE_ASPECT_STENCIL_BIT
);
1375 sanitized_mask
= VK_IMAGE_ASPECT_STENCIL_BIT
;
1377 case VK_IMAGE_ASPECT_DEPTH_BIT
| VK_IMAGE_ASPECT_STENCIL_BIT
:
1378 /* FINISHME: The Vulkan spec (git a511ba2) requires support for
1379 * combined depth stencil formats. Specifically, it states:
1381 * At least one of ename:VK_FORMAT_D24_UNORM_S8_UINT or
1382 * ename:VK_FORMAT_D32_SFLOAT_S8_UINT must be supported.
1384 * Image views with both depth and stencil aspects are only valid for
1385 * render target attachments, in which case
1386 * cmd_buffer_emit_depth_stencil() will pick out both the depth and
1387 * stencil surfaces from the underlying surface.
1389 if (image
->aspects
& VK_IMAGE_ASPECT_DEPTH_BIT
) {
1390 sanitized_mask
= VK_IMAGE_ASPECT_DEPTH_BIT
;
1392 assert(image
->aspects
== VK_IMAGE_ASPECT_STENCIL_BIT
);
1393 sanitized_mask
= VK_IMAGE_ASPECT_STENCIL_BIT
;
1396 case VK_IMAGE_ASPECT_PLANE_0_BIT_KHR
:
1397 assert((image
->aspects
& ~VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) == 0);
1398 sanitized_mask
= VK_IMAGE_ASPECT_PLANE_0_BIT_KHR
;
1400 case VK_IMAGE_ASPECT_PLANE_1_BIT_KHR
:
1401 assert((image
->aspects
& ~VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) == 0);
1402 sanitized_mask
= VK_IMAGE_ASPECT_PLANE_1_BIT_KHR
;
1404 case VK_IMAGE_ASPECT_PLANE_2_BIT_KHR
:
1405 assert((image
->aspects
& ~VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) == 0);
1406 sanitized_mask
= VK_IMAGE_ASPECT_PLANE_2_BIT_KHR
;
1409 unreachable("image does not have aspect");
1413 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, sanitized_mask
);
1414 return &image
->planes
[plane
].surface
;