2 * Copyright © 2015 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
30 #include "drm-uapi/drm_fourcc.h"
32 #include "anv_private.h"
33 #include "util/debug.h"
35 #include "util/u_math.h"
37 #include "vk_format_info.h"
39 static isl_surf_usage_flags_t
40 choose_isl_surf_usage(VkImageCreateFlags vk_create_flags
,
41 VkImageUsageFlags vk_usage
,
42 isl_surf_usage_flags_t isl_extra_usage
,
43 VkImageAspectFlagBits aspect
)
45 isl_surf_usage_flags_t isl_usage
= isl_extra_usage
;
47 if (vk_usage
& VK_IMAGE_USAGE_SAMPLED_BIT
)
48 isl_usage
|= ISL_SURF_USAGE_TEXTURE_BIT
;
50 if (vk_usage
& VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
)
51 isl_usage
|= ISL_SURF_USAGE_TEXTURE_BIT
;
53 if (vk_usage
& VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
)
54 isl_usage
|= ISL_SURF_USAGE_RENDER_TARGET_BIT
;
56 if (vk_create_flags
& VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT
)
57 isl_usage
|= ISL_SURF_USAGE_CUBE_BIT
;
59 /* Even if we're only using it for transfer operations, clears to depth and
60 * stencil images happen as depth and stencil so they need the right ISL
61 * usage bits or else things will fall apart.
64 case VK_IMAGE_ASPECT_DEPTH_BIT
:
65 isl_usage
|= ISL_SURF_USAGE_DEPTH_BIT
;
67 case VK_IMAGE_ASPECT_STENCIL_BIT
:
68 isl_usage
|= ISL_SURF_USAGE_STENCIL_BIT
;
70 case VK_IMAGE_ASPECT_COLOR_BIT
:
71 case VK_IMAGE_ASPECT_PLANE_0_BIT
:
72 case VK_IMAGE_ASPECT_PLANE_1_BIT
:
73 case VK_IMAGE_ASPECT_PLANE_2_BIT
:
76 unreachable("bad VkImageAspect");
79 if (vk_usage
& VK_IMAGE_USAGE_TRANSFER_SRC_BIT
) {
80 /* blorp implements transfers by sampling from the source image. */
81 isl_usage
|= ISL_SURF_USAGE_TEXTURE_BIT
;
84 if (vk_usage
& VK_IMAGE_USAGE_TRANSFER_DST_BIT
&&
85 aspect
== VK_IMAGE_ASPECT_COLOR_BIT
) {
86 /* blorp implements transfers by rendering into the destination image.
87 * Only request this with color images, as we deal with depth/stencil
88 * formats differently. */
89 isl_usage
|= ISL_SURF_USAGE_RENDER_TARGET_BIT
;
95 static isl_tiling_flags_t
96 choose_isl_tiling_flags(const struct gen_device_info
*devinfo
,
97 const struct anv_image_create_info
*anv_info
,
98 const struct isl_drm_modifier_info
*isl_mod_info
,
101 const VkImageCreateInfo
*base_info
= anv_info
->vk_info
;
102 isl_tiling_flags_t flags
= 0;
104 switch (base_info
->tiling
) {
106 unreachable("bad VkImageTiling");
107 case VK_IMAGE_TILING_OPTIMAL
:
108 flags
= ISL_TILING_ANY_MASK
;
110 case VK_IMAGE_TILING_LINEAR
:
111 flags
= ISL_TILING_LINEAR_BIT
;
113 case VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT
:
114 assert(isl_mod_info
);
115 flags
= 1 << isl_mod_info
->tiling
;
118 if (anv_info
->isl_tiling_flags
)
119 flags
&= anv_info
->isl_tiling_flags
;
121 if (legacy_scanout
) {
122 isl_tiling_flags_t legacy_mask
= ISL_TILING_LINEAR_BIT
;
123 if (devinfo
->has_tiling_uapi
)
124 legacy_mask
|= ISL_TILING_X_BIT
;
125 flags
&= legacy_mask
;
134 add_surface(struct anv_image
*image
, struct anv_surface
*surf
, uint32_t plane
)
136 assert(surf
->isl
.size_B
> 0); /* isl surface must be initialized */
138 if (image
->disjoint
) {
139 surf
->offset
= align_u32(image
->planes
[plane
].size
,
140 surf
->isl
.alignment_B
);
141 /* Plane offset is always 0 when it's disjoint. */
143 surf
->offset
= align_u32(image
->size
, surf
->isl
.alignment_B
);
144 /* Determine plane's offset only once when the first surface is added. */
145 if (image
->planes
[plane
].size
== 0)
146 image
->planes
[plane
].offset
= image
->size
;
149 image
->size
= surf
->offset
+ surf
->isl
.size_B
;
150 image
->planes
[plane
].size
= (surf
->offset
+ surf
->isl
.size_B
) - image
->planes
[plane
].offset
;
152 image
->alignment
= MAX2(image
->alignment
, surf
->isl
.alignment_B
);
153 image
->planes
[plane
].alignment
= MAX2(image
->planes
[plane
].alignment
,
154 surf
->isl
.alignment_B
);
158 * Do hardware limitations require the image plane to use a shadow surface?
160 * If hardware limitations force us to use a shadow surface, then the same
161 * limitations may also constrain the tiling of the primary surface; therefore
162 * paramater @a inout_primary_tiling_flags.
164 * If the image plane is a separate stencil plane and if the user provided
165 * VkImageStencilUsageCreateInfoEXT, then @a usage must be stencilUsage.
167 * @see anv_image::planes[]::shadow_surface
170 anv_image_plane_needs_shadow_surface(const struct gen_device_info
*devinfo
,
171 struct anv_format_plane plane_format
,
172 VkImageTiling vk_tiling
,
173 VkImageUsageFlags vk_plane_usage
,
174 VkImageCreateFlags vk_create_flags
,
175 isl_tiling_flags_t
*inout_primary_tiling_flags
)
177 if (devinfo
->gen
<= 8 &&
178 (vk_create_flags
& VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT
) &&
179 vk_tiling
== VK_IMAGE_TILING_OPTIMAL
) {
180 /* We must fallback to a linear surface because we may not be able to
181 * correctly handle the offsets if tiled. (On gen9,
182 * RENDER_SURFACE_STATE::X/Y Offset are sufficient). To prevent garbage
183 * performance while texturing, we maintain a tiled shadow surface.
185 assert(isl_format_is_compressed(plane_format
.isl_format
));
187 if (inout_primary_tiling_flags
) {
188 *inout_primary_tiling_flags
= ISL_TILING_LINEAR_BIT
;
194 if (devinfo
->gen
<= 7 &&
195 plane_format
.aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
&&
196 (vk_plane_usage
& VK_IMAGE_USAGE_SAMPLED_BIT
)) {
197 /* gen7 can't sample from W-tiled surfaces. */
205 anv_formats_ccs_e_compatible(const struct gen_device_info
*devinfo
,
206 VkImageCreateFlags create_flags
,
208 VkImageTiling vk_tiling
,
209 const VkImageFormatListCreateInfoKHR
*fmt_list
)
211 enum isl_format format
=
212 anv_get_isl_format(devinfo
, vk_format
,
213 VK_IMAGE_ASPECT_COLOR_BIT
, vk_tiling
);
215 if (!isl_format_supports_ccs_e(devinfo
, format
))
218 if (!(create_flags
& VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT
))
221 if (!fmt_list
|| fmt_list
->viewFormatCount
== 0)
224 for (uint32_t i
= 0; i
< fmt_list
->viewFormatCount
; i
++) {
225 enum isl_format view_format
=
226 anv_get_isl_format(devinfo
, fmt_list
->pViewFormats
[i
],
227 VK_IMAGE_ASPECT_COLOR_BIT
, vk_tiling
);
229 if (!isl_formats_are_ccs_e_compatible(devinfo
, format
, view_format
))
237 * For color images that have an auxiliary surface, request allocation for an
238 * additional buffer that mainly stores fast-clear values. Use of this buffer
239 * allows us to access the image's subresources while being aware of their
240 * fast-clear values in non-trivial cases (e.g., outside of a render pass in
241 * which a fast clear has occurred).
243 * In order to avoid having multiple clear colors for a single plane of an
244 * image (hence a single RENDER_SURFACE_STATE), we only allow fast-clears on
245 * the first slice (level 0, layer 0). At the time of our testing (Jan 17,
246 * 2018), there were no known applications which would benefit from fast-
247 * clearing more than just the first slice.
249 * The fast clear portion of the image is laid out in the following order:
251 * * 1 or 4 dwords (depending on hardware generation) for the clear color
252 * * 1 dword for the anv_fast_clear_type of the clear color
253 * * On gen9+, 1 dword per level and layer of the image (3D levels count
254 * multiple layers) in level-major order for compression state.
256 * For the purpose of discoverability, the algorithm used to manage
257 * compression and fast-clears is described here:
259 * * On a transition from UNDEFINED or PREINITIALIZED to a defined layout,
260 * all of the values in the fast clear portion of the image are initialized
263 * * On fast-clear, the clear value is written into surface state and also
264 * into the buffer and the fast clear type is set appropriately. Both
265 * setting the fast-clear value in the buffer and setting the fast-clear
266 * type happen from the GPU using MI commands.
268 * * Whenever a render or blorp operation is performed with CCS_E, we call
269 * genX(cmd_buffer_mark_image_written) to set the compression state to
270 * true (which is represented by UINT32_MAX).
272 * * On pipeline barrier transitions, the worst-case transition is computed
273 * from the image layouts. The command streamer inspects the fast clear
274 * type and compression state dwords and constructs a predicate. The
275 * worst-case resolve is performed with the given predicate and the fast
276 * clear and compression state is set accordingly.
278 * See anv_layout_to_aux_usage and anv_layout_to_fast_clear_type functions for
279 * details on exactly what is allowed in what layouts.
281 * On gen7-9, we do not have a concept of indirect clear colors in hardware.
282 * In order to deal with this, we have to do some clear color management.
284 * * For LOAD_OP_LOAD at the top of a renderpass, we have to copy the clear
285 * value from the buffer into the surface state with MI commands.
287 * * For any blorp operations, we pass the address to the clear value into
288 * blorp and it knows to copy the clear color.
291 add_aux_state_tracking_buffer(struct anv_image
*image
,
293 const struct anv_device
*device
)
295 assert(image
&& device
);
296 assert(image
->planes
[plane
].aux_usage
!= ISL_AUX_USAGE_NONE
&&
297 image
->aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
);
299 /* Compressed images must be tiled and therefore everything should be 4K
300 * aligned. The CCS has the same alignment requirements. This is good
301 * because we need at least dword-alignment for MI_LOAD/STORE operations.
303 assert(image
->alignment
% 4 == 0);
304 assert((image
->planes
[plane
].offset
+ image
->planes
[plane
].size
) % 4 == 0);
306 /* This buffer should be at the very end of the plane. */
307 if (image
->disjoint
) {
308 assert(image
->planes
[plane
].size
==
309 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
311 assert(image
->size
==
312 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
315 const unsigned clear_color_state_size
= device
->info
.gen
>= 10 ?
316 device
->isl_dev
.ss
.clear_color_state_size
:
317 device
->isl_dev
.ss
.clear_value_size
;
319 /* Clear color and fast clear type */
320 unsigned state_size
= clear_color_state_size
+ 4;
322 /* We only need to track compression on CCS_E surfaces. */
323 if (image
->planes
[plane
].aux_usage
== ISL_AUX_USAGE_CCS_E
) {
324 if (image
->type
== VK_IMAGE_TYPE_3D
) {
325 for (uint32_t l
= 0; l
< image
->levels
; l
++)
326 state_size
+= anv_minify(image
->extent
.depth
, l
) * 4;
328 state_size
+= image
->levels
* image
->array_size
* 4;
332 /* Add some padding to make sure the fast clear color state buffer starts at
333 * a 4K alignment. We believe that 256B might be enough, but due to lack of
334 * testing we will leave this as 4K for now.
336 image
->planes
[plane
].size
= align_u64(image
->planes
[plane
].size
, 4096);
337 image
->size
= align_u64(image
->size
, 4096);
339 assert(image
->planes
[plane
].offset
% 4096 == 0);
341 image
->planes
[plane
].fast_clear_state_offset
=
342 image
->planes
[plane
].offset
+ image
->planes
[plane
].size
;
344 image
->planes
[plane
].size
+= state_size
;
345 image
->size
+= state_size
;
349 * The return code indicates whether creation of the VkImage should continue
350 * or fail, not whether the creation of the aux surface succeeded. If the aux
351 * surface is not required (for example, by neither hardware nor DRM format
352 * modifier), then this may return VK_SUCCESS when creation of the aux surface
356 add_aux_surface_if_supported(struct anv_device
*device
,
357 struct anv_image
*image
,
359 struct anv_format_plane plane_format
,
360 const VkImageFormatListCreateInfoKHR
*fmt_list
,
361 isl_surf_usage_flags_t isl_extra_usage_flags
)
363 VkImageAspectFlags aspect
= plane_format
.aspect
;
366 /* The aux surface must not be already added. */
367 assert(image
->planes
[plane
].aux_surface
.isl
.size_B
== 0);
369 if ((isl_extra_usage_flags
& ISL_SURF_USAGE_DISABLE_AUX_BIT
))
372 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
373 /* We don't advertise that depth buffers could be used as storage
376 assert(!(image
->usage
& VK_IMAGE_USAGE_STORAGE_BIT
));
378 /* Allow the user to control HiZ enabling. Disable by default on gen7
379 * because resolves are not currently implemented pre-BDW.
381 if (!(image
->usage
& VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
)) {
382 /* It will never be used as an attachment, HiZ is pointless. */
386 if (device
->info
.gen
== 7) {
387 anv_perf_warn(device
, image
, "Implement gen7 HiZ");
391 if (image
->levels
> 1) {
392 anv_perf_warn(device
, image
, "Enable multi-LOD HiZ");
396 if (device
->info
.gen
== 8 && image
->samples
> 1) {
397 anv_perf_warn(device
, image
, "Enable gen8 multisampled HiZ");
401 if (unlikely(INTEL_DEBUG
& DEBUG_NO_HIZ
))
404 ok
= isl_surf_get_hiz_surf(&device
->isl_dev
,
405 &image
->planes
[plane
].surface
.isl
,
406 &image
->planes
[plane
].aux_surface
.isl
);
408 if (!isl_surf_supports_ccs(&device
->isl_dev
,
409 &image
->planes
[plane
].surface
.isl
)) {
410 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_HIZ
;
411 } else if (image
->usage
& (VK_IMAGE_USAGE_SAMPLED_BIT
|
412 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
) &&
413 image
->samples
== 1) {
414 /* If it's used as an input attachment or a texture and it's
415 * single-sampled (this is a requirement for HiZ+CCS write-through
416 * mode), use write-through mode so that we don't need to resolve
417 * before texturing. This will make depth testing a bit slower but
420 * TODO: This is a heuristic trade-off; we haven't tuned it at all.
422 assert(device
->info
.gen
>= 12);
423 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_HIZ_CCS_WT
;
425 assert(device
->info
.gen
>= 12);
426 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_HIZ_CCS
;
428 add_surface(image
, &image
->planes
[plane
].aux_surface
, plane
);
429 } else if ((aspect
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) && image
->samples
== 1) {
430 if (image
->n_planes
!= 1) {
431 /* Multiplanar images seem to hit a sampler bug with CCS and R16G16
432 * format. (Putting the clear state a page/4096bytes further fixes
438 if ((image
->create_flags
& VK_IMAGE_CREATE_ALIAS_BIT
)) {
439 /* The image may alias a plane of a multiplanar image. Above we ban
440 * CCS on multiplanar images.
445 if (!isl_format_supports_rendering(&device
->info
,
446 plane_format
.isl_format
)) {
447 /* Disable CCS because it is not useful (we can't render to the image
448 * with CCS enabled). While it may be technically possible to enable
449 * CCS for this case, we currently don't have things hooked up to get
452 anv_perf_warn(device
, image
,
453 "This image format doesn't support rendering. "
454 "Not allocating an CCS buffer.");
458 if (unlikely(INTEL_DEBUG
& DEBUG_NO_RBC
))
461 ok
= isl_surf_get_ccs_surf(&device
->isl_dev
,
462 &image
->planes
[plane
].surface
.isl
,
463 &image
->planes
[plane
].aux_surface
.isl
,
468 /* Choose aux usage */
469 if (!(image
->usage
& VK_IMAGE_USAGE_STORAGE_BIT
) &&
470 anv_formats_ccs_e_compatible(&device
->info
,
475 /* For images created without MUTABLE_FORMAT_BIT set, we know that
476 * they will always be used with the original format. In particular,
477 * they will always be used with a format that supports color
478 * compression. If it's never used as a storage image, then it will
479 * only be used through the sampler or the as a render target. This
480 * means that it's safe to just leave compression on at all times for
483 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_CCS_E
;
484 } else if (device
->info
.gen
>= 12) {
485 anv_perf_warn(device
, image
,
486 "The CCS_D aux mode is not yet handled on "
487 "Gen12+. Not allocating a CCS buffer.");
488 image
->planes
[plane
].aux_surface
.isl
.size_B
= 0;
491 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_CCS_D
;
494 if (!device
->physical
->has_implicit_ccs
)
495 add_surface(image
, &image
->planes
[plane
].aux_surface
, plane
);
497 add_aux_state_tracking_buffer(image
, plane
, device
);
498 } else if ((aspect
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) && image
->samples
> 1) {
499 assert(!(image
->usage
& VK_IMAGE_USAGE_STORAGE_BIT
));
500 ok
= isl_surf_get_mcs_surf(&device
->isl_dev
,
501 &image
->planes
[plane
].surface
.isl
,
502 &image
->planes
[plane
].aux_surface
.isl
);
506 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_MCS
;
507 add_surface(image
, &image
->planes
[plane
].aux_surface
, plane
);
508 add_aux_state_tracking_buffer(image
, plane
, device
);
515 * Initialize the anv_image::*_surface selected by \a aspect. Then update the
516 * image's memory requirements (that is, the image's size and alignment).
519 make_surface(struct anv_device
*device
,
520 struct anv_image
*image
,
521 const VkImageFormatListCreateInfoKHR
*fmt_list
,
523 isl_tiling_flags_t tiling_flags
,
524 isl_surf_usage_flags_t isl_extra_usage_flags
,
525 VkImageAspectFlagBits aspect
)
530 static const enum isl_surf_dim vk_to_isl_surf_dim
[] = {
531 [VK_IMAGE_TYPE_1D
] = ISL_SURF_DIM_1D
,
532 [VK_IMAGE_TYPE_2D
] = ISL_SURF_DIM_2D
,
533 [VK_IMAGE_TYPE_3D
] = ISL_SURF_DIM_3D
,
536 image
->extent
= anv_sanitize_image_extent(image
->type
, image
->extent
);
538 const unsigned plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
539 const struct anv_format_plane plane_format
=
540 anv_get_format_plane(&device
->info
, image
->vk_format
, aspect
, image
->tiling
);
541 struct anv_surface
*anv_surf
= &image
->planes
[plane
].surface
;
543 const isl_surf_usage_flags_t usage
=
544 choose_isl_surf_usage(image
->create_flags
, image
->usage
,
545 isl_extra_usage_flags
, aspect
);
547 VkImageUsageFlags plane_vk_usage
=
548 aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
?
549 image
->stencil_usage
: image
->usage
;
552 anv_image_plane_needs_shadow_surface(&device
->info
,
559 ok
= isl_surf_init(&device
->isl_dev
, &anv_surf
->isl
,
560 .dim
= vk_to_isl_surf_dim
[image
->type
],
561 .format
= plane_format
.isl_format
,
562 .width
= image
->extent
.width
/ plane_format
.denominator_scales
[0],
563 .height
= image
->extent
.height
/ plane_format
.denominator_scales
[1],
564 .depth
= image
->extent
.depth
,
565 .levels
= image
->levels
,
566 .array_len
= image
->array_size
,
567 .samples
= image
->samples
,
568 .min_alignment_B
= 0,
569 .row_pitch_B
= stride
,
571 .tiling_flags
= tiling_flags
);
574 return VK_ERROR_OUT_OF_DEVICE_MEMORY
;
576 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_NONE
;
578 add_surface(image
, anv_surf
, plane
);
581 ok
= isl_surf_init(&device
->isl_dev
, &image
->planes
[plane
].shadow_surface
.isl
,
582 .dim
= vk_to_isl_surf_dim
[image
->type
],
583 .format
= plane_format
.isl_format
,
584 .width
= image
->extent
.width
,
585 .height
= image
->extent
.height
,
586 .depth
= image
->extent
.depth
,
587 .levels
= image
->levels
,
588 .array_len
= image
->array_size
,
589 .samples
= image
->samples
,
590 .min_alignment_B
= 0,
591 .row_pitch_B
= stride
,
592 .usage
= ISL_SURF_USAGE_TEXTURE_BIT
|
593 (usage
& ISL_SURF_USAGE_CUBE_BIT
),
594 .tiling_flags
= ISL_TILING_ANY_MASK
);
596 /* isl_surf_init() will fail only if provided invalid input. Invalid input
597 * is illegal in Vulkan.
601 add_surface(image
, &image
->planes
[plane
].shadow_surface
, plane
);
604 result
= add_aux_surface_if_supported(device
, image
, plane
, plane_format
,
605 fmt_list
, isl_extra_usage_flags
);
606 if (result
!= VK_SUCCESS
)
609 assert((image
->planes
[plane
].offset
+ image
->planes
[plane
].size
) == image
->size
);
611 /* Upper bound of the last surface should be smaller than the plane's
614 assert((MAX2(image
->planes
[plane
].surface
.offset
,
615 image
->planes
[plane
].aux_surface
.offset
) +
616 (image
->planes
[plane
].aux_surface
.isl
.size_B
> 0 ?
617 image
->planes
[plane
].aux_surface
.isl
.size_B
:
618 image
->planes
[plane
].surface
.isl
.size_B
)) <=
619 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
621 if (image
->planes
[plane
].aux_usage
!= ISL_AUX_USAGE_NONE
) {
622 /* assert(image->planes[plane].fast_clear_state_offset == */
623 /* (image->planes[plane].aux_surface.offset + image->planes[plane].aux_surface.isl.size_B)); */
624 assert(image
->planes
[plane
].fast_clear_state_offset
<
625 (image
->planes
[plane
].offset
+ image
->planes
[plane
].size
));
632 score_drm_format_mod(uint64_t modifier
)
635 case DRM_FORMAT_MOD_LINEAR
: return 1;
636 case I915_FORMAT_MOD_X_TILED
: return 2;
637 case I915_FORMAT_MOD_Y_TILED
: return 3;
638 case I915_FORMAT_MOD_Y_TILED_CCS
: return 4;
639 default: unreachable("bad DRM format modifier");
643 static const struct isl_drm_modifier_info
*
644 choose_drm_format_mod(const struct anv_physical_device
*device
,
645 uint32_t modifier_count
, const uint64_t *modifiers
)
647 uint64_t best_mod
= UINT64_MAX
;
648 uint32_t best_score
= 0;
650 for (uint32_t i
= 0; i
< modifier_count
; ++i
) {
651 uint32_t score
= score_drm_format_mod(modifiers
[i
]);
652 if (score
> best_score
) {
653 best_mod
= modifiers
[i
];
659 return isl_drm_modifier_get_info(best_mod
);
665 anv_image_create(VkDevice _device
,
666 const struct anv_image_create_info
*create_info
,
667 const VkAllocationCallbacks
* alloc
,
670 ANV_FROM_HANDLE(anv_device
, device
, _device
);
671 const VkImageCreateInfo
*pCreateInfo
= create_info
->vk_info
;
672 const struct isl_drm_modifier_info
*isl_mod_info
= NULL
;
673 struct anv_image
*image
= NULL
;
676 assert(pCreateInfo
->sType
== VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO
);
678 const struct wsi_image_create_info
*wsi_info
=
679 vk_find_struct_const(pCreateInfo
->pNext
, WSI_IMAGE_CREATE_INFO_MESA
);
681 if (pCreateInfo
->tiling
== VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT
) {
682 const VkImageDrmFormatModifierListCreateInfoEXT
*mod_info
=
683 vk_find_struct_const(pCreateInfo
->pNext
,
684 IMAGE_DRM_FORMAT_MODIFIER_LIST_CREATE_INFO_EXT
);
685 isl_mod_info
= choose_drm_format_mod(device
->physical
,
686 mod_info
->drmFormatModifierCount
,
687 mod_info
->pDrmFormatModifiers
);
688 assert(isl_mod_info
);
691 anv_assert(pCreateInfo
->mipLevels
> 0);
692 anv_assert(pCreateInfo
->arrayLayers
> 0);
693 anv_assert(pCreateInfo
->samples
> 0);
694 anv_assert(pCreateInfo
->extent
.width
> 0);
695 anv_assert(pCreateInfo
->extent
.height
> 0);
696 anv_assert(pCreateInfo
->extent
.depth
> 0);
698 image
= vk_zalloc2(&device
->vk
.alloc
, alloc
, sizeof(*image
), 8,
699 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT
);
701 return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY
);
703 vk_object_base_init(&device
->vk
, &image
->base
, VK_OBJECT_TYPE_IMAGE
);
704 image
->type
= pCreateInfo
->imageType
;
705 image
->extent
= pCreateInfo
->extent
;
706 image
->vk_format
= pCreateInfo
->format
;
707 image
->format
= anv_get_format(pCreateInfo
->format
);
708 image
->aspects
= vk_format_aspects(image
->vk_format
);
709 image
->levels
= pCreateInfo
->mipLevels
;
710 image
->array_size
= pCreateInfo
->arrayLayers
;
711 image
->samples
= pCreateInfo
->samples
;
712 image
->usage
= pCreateInfo
->usage
;
713 image
->create_flags
= pCreateInfo
->flags
;
714 image
->tiling
= pCreateInfo
->tiling
;
715 image
->disjoint
= pCreateInfo
->flags
& VK_IMAGE_CREATE_DISJOINT_BIT
;
716 image
->needs_set_tiling
= wsi_info
&& wsi_info
->scanout
;
717 image
->drm_format_mod
= isl_mod_info
? isl_mod_info
->modifier
:
718 DRM_FORMAT_MOD_INVALID
;
720 if (image
->aspects
& VK_IMAGE_ASPECT_STENCIL_BIT
) {
721 image
->stencil_usage
= pCreateInfo
->usage
;
722 const VkImageStencilUsageCreateInfoEXT
*stencil_usage_info
=
723 vk_find_struct_const(pCreateInfo
->pNext
,
724 IMAGE_STENCIL_USAGE_CREATE_INFO_EXT
);
725 if (stencil_usage_info
)
726 image
->stencil_usage
= stencil_usage_info
->stencilUsage
;
729 /* In case of external format, We don't know format yet,
730 * so skip the rest for now.
732 if (create_info
->external_format
) {
733 image
->external_format
= true;
734 *pImage
= anv_image_to_handle(image
);
738 const struct anv_format
*format
= anv_get_format(image
->vk_format
);
739 assert(format
!= NULL
);
741 const isl_tiling_flags_t isl_tiling_flags
=
742 choose_isl_tiling_flags(&device
->info
, create_info
, isl_mod_info
,
743 image
->needs_set_tiling
);
745 image
->n_planes
= format
->n_planes
;
747 const VkImageFormatListCreateInfoKHR
*fmt_list
=
748 vk_find_struct_const(pCreateInfo
->pNext
,
749 IMAGE_FORMAT_LIST_CREATE_INFO_KHR
);
752 for_each_bit(b
, image
->aspects
) {
753 r
= make_surface(device
, image
, fmt_list
, create_info
->stride
,
754 isl_tiling_flags
, create_info
->isl_extra_usage_flags
,
760 *pImage
= anv_image_to_handle(image
);
766 vk_free2(&device
->vk
.alloc
, alloc
, image
);
771 static struct anv_image
*
772 anv_swapchain_get_image(VkSwapchainKHR swapchain
,
775 uint32_t n_images
= index
+ 1;
776 VkImage
*images
= malloc(sizeof(*images
) * n_images
);
777 VkResult result
= wsi_common_get_images(swapchain
, &n_images
, images
);
779 if (result
!= VK_SUCCESS
&& result
!= VK_INCOMPLETE
) {
784 ANV_FROM_HANDLE(anv_image
, image
, images
[index
]);
791 anv_image_from_swapchain(VkDevice device
,
792 const VkImageCreateInfo
*pCreateInfo
,
793 const VkImageSwapchainCreateInfoKHR
*swapchain_info
,
794 const VkAllocationCallbacks
*pAllocator
,
797 struct anv_image
*swapchain_image
= anv_swapchain_get_image(swapchain_info
->swapchain
, 0);
798 assert(swapchain_image
);
800 assert(swapchain_image
->type
== pCreateInfo
->imageType
);
801 assert(swapchain_image
->vk_format
== pCreateInfo
->format
);
802 assert(swapchain_image
->extent
.width
== pCreateInfo
->extent
.width
);
803 assert(swapchain_image
->extent
.height
== pCreateInfo
->extent
.height
);
804 assert(swapchain_image
->extent
.depth
== pCreateInfo
->extent
.depth
);
805 assert(swapchain_image
->array_size
== pCreateInfo
->arrayLayers
);
806 /* Color attachment is added by the wsi code. */
807 assert(swapchain_image
->usage
== (pCreateInfo
->usage
| VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
));
809 VkImageCreateInfo local_create_info
;
810 local_create_info
= *pCreateInfo
;
811 local_create_info
.pNext
= NULL
;
812 /* The following parameters are implictly selected by the wsi code. */
813 local_create_info
.tiling
= VK_IMAGE_TILING_OPTIMAL
;
814 local_create_info
.samples
= VK_SAMPLE_COUNT_1_BIT
;
815 local_create_info
.usage
|= VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
;
817 /* If the image has a particular modifier, specify that modifier. */
818 VkImageDrmFormatModifierListCreateInfoEXT local_modifier_info
= {
819 .sType
= VK_STRUCTURE_TYPE_IMAGE_DRM_FORMAT_MODIFIER_LIST_CREATE_INFO_EXT
,
820 .drmFormatModifierCount
= 1,
821 .pDrmFormatModifiers
= &swapchain_image
->drm_format_mod
,
823 if (swapchain_image
->drm_format_mod
!= DRM_FORMAT_MOD_INVALID
)
824 __vk_append_struct(&local_create_info
, &local_modifier_info
);
826 return anv_image_create(device
,
827 &(struct anv_image_create_info
) {
828 .vk_info
= &local_create_info
,
829 .external_format
= swapchain_image
->external_format
,
836 anv_CreateImage(VkDevice device
,
837 const VkImageCreateInfo
*pCreateInfo
,
838 const VkAllocationCallbacks
*pAllocator
,
841 const VkExternalMemoryImageCreateInfo
*create_info
=
842 vk_find_struct_const(pCreateInfo
->pNext
, EXTERNAL_MEMORY_IMAGE_CREATE_INFO
);
844 if (create_info
&& (create_info
->handleTypes
&
845 VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID
))
846 return anv_image_from_external(device
, pCreateInfo
, create_info
,
849 bool use_external_format
= false;
850 const VkExternalFormatANDROID
*ext_format
=
851 vk_find_struct_const(pCreateInfo
->pNext
, EXTERNAL_FORMAT_ANDROID
);
853 /* "If externalFormat is zero, the effect is as if the
854 * VkExternalFormatANDROID structure was not present. Otherwise, the image
855 * will have the specified external format."
857 if (ext_format
&& ext_format
->externalFormat
!= 0)
858 use_external_format
= true;
860 const VkNativeBufferANDROID
*gralloc_info
=
861 vk_find_struct_const(pCreateInfo
->pNext
, NATIVE_BUFFER_ANDROID
);
863 return anv_image_from_gralloc(device
, pCreateInfo
, gralloc_info
,
866 const VkImageSwapchainCreateInfoKHR
*swapchain_info
=
867 vk_find_struct_const(pCreateInfo
->pNext
, IMAGE_SWAPCHAIN_CREATE_INFO_KHR
);
868 if (swapchain_info
&& swapchain_info
->swapchain
!= VK_NULL_HANDLE
)
869 return anv_image_from_swapchain(device
, pCreateInfo
, swapchain_info
,
872 return anv_image_create(device
,
873 &(struct anv_image_create_info
) {
874 .vk_info
= pCreateInfo
,
875 .external_format
= use_external_format
,
882 anv_DestroyImage(VkDevice _device
, VkImage _image
,
883 const VkAllocationCallbacks
*pAllocator
)
885 ANV_FROM_HANDLE(anv_device
, device
, _device
);
886 ANV_FROM_HANDLE(anv_image
, image
, _image
);
891 for (uint32_t p
= 0; p
< image
->n_planes
; ++p
) {
892 if (image
->planes
[p
].bo_is_owned
) {
893 assert(image
->planes
[p
].address
.bo
!= NULL
);
894 anv_device_release_bo(device
, image
->planes
[p
].address
.bo
);
898 vk_object_base_finish(&image
->base
);
899 vk_free2(&device
->vk
.alloc
, pAllocator
, image
);
902 static void anv_image_bind_memory_plane(struct anv_device
*device
,
903 struct anv_image
*image
,
905 struct anv_device_memory
*memory
,
906 uint32_t memory_offset
)
908 assert(!image
->planes
[plane
].bo_is_owned
);
911 image
->planes
[plane
].address
= ANV_NULL_ADDRESS
;
915 image
->planes
[plane
].address
= (struct anv_address
) {
917 .offset
= memory_offset
,
920 /* If we're on a platform that uses implicit CCS and our buffer does not
921 * have any implicit CCS data, disable compression on that image.
923 if (device
->physical
->has_implicit_ccs
&& !memory
->bo
->has_implicit_ccs
)
924 image
->planes
[plane
].aux_usage
= ISL_AUX_USAGE_NONE
;
927 /* We are binding AHardwareBuffer. Get a description, resolve the
928 * format and prepare anv_image properly.
931 resolve_ahw_image(struct anv_device
*device
,
932 struct anv_image
*image
,
933 struct anv_device_memory
*mem
)
935 #if defined(ANDROID) && ANDROID_API_LEVEL >= 26
937 AHardwareBuffer_Desc desc
;
938 AHardwareBuffer_describe(mem
->ahw
, &desc
);
941 int i915_tiling
= anv_gem_get_tiling(device
, mem
->bo
->gem_handle
);
942 VkImageTiling vk_tiling
;
943 isl_tiling_flags_t isl_tiling_flags
= 0;
945 switch (i915_tiling
) {
946 case I915_TILING_NONE
:
947 vk_tiling
= VK_IMAGE_TILING_LINEAR
;
948 isl_tiling_flags
= ISL_TILING_LINEAR_BIT
;
951 vk_tiling
= VK_IMAGE_TILING_OPTIMAL
;
952 isl_tiling_flags
= ISL_TILING_X_BIT
;
955 vk_tiling
= VK_IMAGE_TILING_OPTIMAL
;
956 isl_tiling_flags
= ISL_TILING_Y0_BIT
;
960 unreachable("Invalid tiling flags.");
963 assert(vk_tiling
== VK_IMAGE_TILING_LINEAR
||
964 vk_tiling
== VK_IMAGE_TILING_OPTIMAL
);
967 VkFormat vk_format
= vk_format_from_android(desc
.format
, desc
.usage
);
968 enum isl_format isl_fmt
= anv_get_isl_format(&device
->info
,
970 VK_IMAGE_ASPECT_COLOR_BIT
,
972 assert(isl_fmt
!= ISL_FORMAT_UNSUPPORTED
);
974 /* Handle RGB(X)->RGBA fallback. */
975 switch (desc
.format
) {
976 case AHARDWAREBUFFER_FORMAT_R8G8B8_UNORM
:
977 case AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM
:
978 if (isl_format_is_rgb(isl_fmt
))
979 isl_fmt
= isl_format_rgb_to_rgba(isl_fmt
);
983 /* Now we are able to fill anv_image fields properly and create
984 * isl_surface for it.
986 image
->vk_format
= vk_format
;
987 image
->format
= anv_get_format(vk_format
);
988 image
->aspects
= vk_format_aspects(image
->vk_format
);
989 image
->n_planes
= image
->format
->n_planes
;
991 uint32_t stride
= desc
.stride
*
992 (isl_format_get_layout(isl_fmt
)->bpb
/ 8);
995 for_each_bit(b
, image
->aspects
) {
996 VkResult r
= make_surface(device
, image
, NULL
, stride
, isl_tiling_flags
,
997 ISL_SURF_USAGE_DISABLE_AUX_BIT
, (1 << b
));
998 assert(r
== VK_SUCCESS
);
1003 VkResult
anv_BindImageMemory(
1006 VkDeviceMemory _memory
,
1007 VkDeviceSize memoryOffset
)
1009 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1010 ANV_FROM_HANDLE(anv_device_memory
, mem
, _memory
);
1011 ANV_FROM_HANDLE(anv_image
, image
, _image
);
1014 resolve_ahw_image(device
, image
, mem
);
1016 uint32_t aspect_bit
;
1017 anv_foreach_image_aspect_bit(aspect_bit
, image
, image
->aspects
) {
1019 anv_image_aspect_to_plane(image
->aspects
, 1UL << aspect_bit
);
1020 anv_image_bind_memory_plane(device
, image
, plane
, mem
, memoryOffset
);
1026 VkResult
anv_BindImageMemory2(
1028 uint32_t bindInfoCount
,
1029 const VkBindImageMemoryInfo
* pBindInfos
)
1031 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1033 for (uint32_t i
= 0; i
< bindInfoCount
; i
++) {
1034 const VkBindImageMemoryInfo
*bind_info
= &pBindInfos
[i
];
1035 ANV_FROM_HANDLE(anv_device_memory
, mem
, bind_info
->memory
);
1036 ANV_FROM_HANDLE(anv_image
, image
, bind_info
->image
);
1038 /* Resolve will alter the image's aspects, do this first. */
1039 if (mem
&& mem
->ahw
)
1040 resolve_ahw_image(device
, image
, mem
);
1042 VkImageAspectFlags aspects
= image
->aspects
;
1043 vk_foreach_struct_const(s
, bind_info
->pNext
) {
1045 case VK_STRUCTURE_TYPE_BIND_IMAGE_PLANE_MEMORY_INFO
: {
1046 const VkBindImagePlaneMemoryInfo
*plane_info
=
1047 (const VkBindImagePlaneMemoryInfo
*) s
;
1049 aspects
= plane_info
->planeAspect
;
1052 case VK_STRUCTURE_TYPE_BIND_IMAGE_MEMORY_SWAPCHAIN_INFO_KHR
: {
1053 const VkBindImageMemorySwapchainInfoKHR
*swapchain_info
=
1054 (const VkBindImageMemorySwapchainInfoKHR
*) s
;
1055 struct anv_image
*swapchain_image
=
1056 anv_swapchain_get_image(swapchain_info
->swapchain
,
1057 swapchain_info
->imageIndex
);
1058 assert(swapchain_image
);
1059 assert(image
->aspects
== swapchain_image
->aspects
);
1060 assert(mem
== NULL
);
1062 uint32_t aspect_bit
;
1063 anv_foreach_image_aspect_bit(aspect_bit
, image
, aspects
) {
1065 anv_image_aspect_to_plane(image
->aspects
, 1UL << aspect_bit
);
1066 struct anv_device_memory mem
= {
1067 .bo
= swapchain_image
->planes
[plane
].address
.bo
,
1069 anv_image_bind_memory_plane(device
, image
, plane
,
1070 &mem
, bind_info
->memoryOffset
);
1075 anv_debug_ignored_stype(s
->sType
);
1080 /* VkBindImageMemorySwapchainInfoKHR requires memory to be
1081 * VK_NULL_HANDLE. In such case, just carry one with the next bind
1087 uint32_t aspect_bit
;
1088 anv_foreach_image_aspect_bit(aspect_bit
, image
, aspects
) {
1090 anv_image_aspect_to_plane(image
->aspects
, 1UL << aspect_bit
);
1091 anv_image_bind_memory_plane(device
, image
, plane
,
1092 mem
, bind_info
->memoryOffset
);
1099 void anv_GetImageSubresourceLayout(
1102 const VkImageSubresource
* subresource
,
1103 VkSubresourceLayout
* layout
)
1105 ANV_FROM_HANDLE(anv_image
, image
, _image
);
1107 const struct anv_surface
*surface
;
1108 if (subresource
->aspectMask
== VK_IMAGE_ASPECT_PLANE_1_BIT
&&
1109 image
->drm_format_mod
!= DRM_FORMAT_MOD_INVALID
&&
1110 isl_drm_modifier_has_aux(image
->drm_format_mod
)) {
1111 surface
= &image
->planes
[0].aux_surface
;
1113 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
,
1114 subresource
->aspectMask
);
1115 surface
= &image
->planes
[plane
].surface
;
1118 assert(__builtin_popcount(subresource
->aspectMask
) == 1);
1120 layout
->offset
= surface
->offset
;
1121 layout
->rowPitch
= surface
->isl
.row_pitch_B
;
1122 layout
->depthPitch
= isl_surf_get_array_pitch(&surface
->isl
);
1123 layout
->arrayPitch
= isl_surf_get_array_pitch(&surface
->isl
);
1125 if (subresource
->mipLevel
> 0 || subresource
->arrayLayer
> 0) {
1126 assert(surface
->isl
.tiling
== ISL_TILING_LINEAR
);
1129 isl_surf_get_image_offset_B_tile_sa(&surface
->isl
,
1130 subresource
->mipLevel
,
1131 subresource
->arrayLayer
,
1132 0 /* logical_z_offset_px */,
1133 &offset_B
, NULL
, NULL
);
1134 layout
->offset
+= offset_B
;
1135 layout
->size
= layout
->rowPitch
* anv_minify(image
->extent
.height
,
1136 subresource
->mipLevel
) *
1137 image
->extent
.depth
;
1139 layout
->size
= surface
->isl
.size_B
;
1143 VkResult
anv_GetImageDrmFormatModifierPropertiesEXT(
1146 VkImageDrmFormatModifierPropertiesEXT
* pProperties
)
1148 ANV_FROM_HANDLE(anv_image
, image
, _image
);
1150 assert(pProperties
->sType
==
1151 VK_STRUCTURE_TYPE_IMAGE_DRM_FORMAT_MODIFIER_PROPERTIES_EXT
);
1153 pProperties
->drmFormatModifier
= image
->drm_format_mod
;
1158 static VkImageUsageFlags
1159 vk_image_layout_to_usage_flags(VkImageLayout layout
,
1160 VkImageAspectFlagBits aspect
)
1162 assert(util_bitcount(aspect
) == 1);
1165 case VK_IMAGE_LAYOUT_UNDEFINED
:
1166 case VK_IMAGE_LAYOUT_PREINITIALIZED
:
1169 case VK_IMAGE_LAYOUT_GENERAL
:
1172 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
:
1173 assert(aspect
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
);
1174 return VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
;
1176 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
:
1177 assert(aspect
& (VK_IMAGE_ASPECT_DEPTH_BIT
|
1178 VK_IMAGE_ASPECT_STENCIL_BIT
));
1179 return VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
;
1181 case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL
:
1182 assert(aspect
& VK_IMAGE_ASPECT_DEPTH_BIT
);
1183 return vk_image_layout_to_usage_flags(
1184 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
, aspect
);
1186 case VK_IMAGE_LAYOUT_STENCIL_ATTACHMENT_OPTIMAL
:
1187 assert(aspect
& VK_IMAGE_ASPECT_STENCIL_BIT
);
1188 return vk_image_layout_to_usage_flags(
1189 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
, aspect
);
1191 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
:
1192 assert(aspect
& (VK_IMAGE_ASPECT_DEPTH_BIT
|
1193 VK_IMAGE_ASPECT_STENCIL_BIT
));
1194 return VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
|
1195 VK_IMAGE_USAGE_SAMPLED_BIT
|
1196 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
;
1198 case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL
:
1199 assert(aspect
& VK_IMAGE_ASPECT_DEPTH_BIT
);
1200 return vk_image_layout_to_usage_flags(
1201 VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
, aspect
);
1203 case VK_IMAGE_LAYOUT_STENCIL_READ_ONLY_OPTIMAL
:
1204 assert(aspect
& VK_IMAGE_ASPECT_STENCIL_BIT
);
1205 return vk_image_layout_to_usage_flags(
1206 VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
, aspect
);
1208 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL
:
1209 return VK_IMAGE_USAGE_SAMPLED_BIT
|
1210 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
;
1212 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL
:
1213 return VK_IMAGE_USAGE_TRANSFER_SRC_BIT
;
1215 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL
:
1216 return VK_IMAGE_USAGE_TRANSFER_DST_BIT
;
1218 case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL
:
1219 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
1220 return vk_image_layout_to_usage_flags(
1221 VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
, aspect
);
1222 } else if (aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
) {
1223 return vk_image_layout_to_usage_flags(
1224 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
, aspect
);
1226 assert(!"Must be a depth/stencil aspect");
1230 case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL
:
1231 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
1232 return vk_image_layout_to_usage_flags(
1233 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
, aspect
);
1234 } else if (aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
) {
1235 return vk_image_layout_to_usage_flags(
1236 VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
, aspect
);
1238 assert(!"Must be a depth/stencil aspect");
1242 case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR
:
1243 assert(aspect
== VK_IMAGE_ASPECT_COLOR_BIT
);
1244 /* This needs to be handled specially by the caller */
1247 case VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR
:
1248 assert(aspect
== VK_IMAGE_ASPECT_COLOR_BIT
);
1249 return vk_image_layout_to_usage_flags(VK_IMAGE_LAYOUT_GENERAL
, aspect
);
1251 case VK_IMAGE_LAYOUT_SHADING_RATE_OPTIMAL_NV
:
1252 assert(aspect
== VK_IMAGE_ASPECT_COLOR_BIT
);
1253 return VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV
;
1255 case VK_IMAGE_LAYOUT_FRAGMENT_DENSITY_MAP_OPTIMAL_EXT
:
1256 assert(aspect
== VK_IMAGE_ASPECT_COLOR_BIT
);
1257 return VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT
;
1259 case VK_IMAGE_LAYOUT_MAX_ENUM
:
1260 unreachable("Invalid image layout.");
1263 unreachable("Invalid image layout.");
1267 vk_image_layout_is_read_only(VkImageLayout layout
,
1268 VkImageAspectFlagBits aspect
)
1270 assert(util_bitcount(aspect
) == 1);
1273 case VK_IMAGE_LAYOUT_UNDEFINED
:
1274 case VK_IMAGE_LAYOUT_PREINITIALIZED
:
1275 return true; /* These are only used for layout transitions */
1277 case VK_IMAGE_LAYOUT_GENERAL
:
1278 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
:
1279 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL
:
1280 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL
:
1281 case VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR
:
1282 case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_OPTIMAL
:
1283 case VK_IMAGE_LAYOUT_STENCIL_ATTACHMENT_OPTIMAL
:
1286 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL
:
1287 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL
:
1288 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL
:
1289 case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR
:
1290 case VK_IMAGE_LAYOUT_SHADING_RATE_OPTIMAL_NV
:
1291 case VK_IMAGE_LAYOUT_FRAGMENT_DENSITY_MAP_OPTIMAL_EXT
:
1292 case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL
:
1293 case VK_IMAGE_LAYOUT_STENCIL_READ_ONLY_OPTIMAL
:
1296 case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL
:
1297 return aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
;
1299 case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL
:
1300 return aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
;
1302 case VK_IMAGE_LAYOUT_MAX_ENUM
:
1303 unreachable("Invalid image layout.");
1306 unreachable("Invalid image layout.");
1310 * This function returns the assumed isl_aux_state for a given VkImageLayout.
1311 * Because Vulkan image layouts don't map directly to isl_aux_state enums, the
1312 * returned enum is the assumed worst case.
1314 * @param devinfo The device information of the Intel GPU.
1315 * @param image The image that may contain a collection of buffers.
1316 * @param aspect The aspect of the image to be accessed.
1317 * @param layout The current layout of the image aspect(s).
1319 * @return The primary buffer that should be used for the given layout.
1322 anv_layout_to_aux_state(const struct gen_device_info
* const devinfo
,
1323 const struct anv_image
* const image
,
1324 const VkImageAspectFlagBits aspect
,
1325 const VkImageLayout layout
)
1327 /* Validate the inputs. */
1329 /* The devinfo is needed as the optimal buffer varies across generations. */
1330 assert(devinfo
!= NULL
);
1332 /* The layout of a NULL image is not properly defined. */
1333 assert(image
!= NULL
);
1335 /* The aspect must be exactly one of the image aspects. */
1336 assert(util_bitcount(aspect
) == 1 && (aspect
& image
->aspects
));
1338 /* Determine the optimal buffer. */
1340 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
1342 /* If we don't have an aux buffer then aux state makes no sense */
1343 const enum isl_aux_usage aux_usage
= image
->planes
[plane
].aux_usage
;
1344 assert(aux_usage
!= ISL_AUX_USAGE_NONE
);
1346 /* All images that use an auxiliary surface are required to be tiled. */
1347 assert(image
->planes
[plane
].surface
.isl
.tiling
!= ISL_TILING_LINEAR
);
1349 /* Stencil has no aux */
1350 assert(aspect
!= VK_IMAGE_ASPECT_STENCIL_BIT
);
1352 /* Handle a few special cases */
1354 /* Invalid layouts */
1355 case VK_IMAGE_LAYOUT_MAX_ENUM
:
1356 unreachable("Invalid image layout.");
1358 /* Undefined layouts
1360 * The pre-initialized layout is equivalent to the undefined layout for
1361 * optimally-tiled images. We can only do color compression (CCS or HiZ)
1364 case VK_IMAGE_LAYOUT_UNDEFINED
:
1365 case VK_IMAGE_LAYOUT_PREINITIALIZED
:
1366 return ISL_AUX_STATE_AUX_INVALID
;
1368 case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR
: {
1369 assert(image
->aspects
== VK_IMAGE_ASPECT_COLOR_BIT
);
1371 enum isl_aux_state aux_state
=
1372 isl_drm_modifier_get_default_aux_state(image
->drm_format_mod
);
1374 switch (aux_state
) {
1376 assert(!"unexpected isl_aux_state");
1377 case ISL_AUX_STATE_AUX_INVALID
:
1378 /* The modifier does not support compression. But, if we arrived
1379 * here, then we have enabled compression on it anyway, in which case
1380 * we must resolve the aux surface before we release ownership to the
1381 * presentation engine (because, having no modifier, the presentation
1382 * engine will not be aware of the aux surface). The presentation
1383 * engine will not access the aux surface (because it is unware of
1384 * it), and so the aux surface will still be resolved when we
1385 * re-acquire ownership.
1387 * Therefore, at ownership transfers in either direction, there does
1388 * exist an aux surface despite the lack of modifier and its state is
1391 return ISL_AUX_STATE_PASS_THROUGH
;
1392 case ISL_AUX_STATE_COMPRESSED_NO_CLEAR
:
1393 return ISL_AUX_STATE_COMPRESSED_NO_CLEAR
;
1401 const bool read_only
= vk_image_layout_is_read_only(layout
, aspect
);
1403 const VkImageUsageFlags image_aspect_usage
=
1404 aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
? image
->stencil_usage
:
1406 const VkImageUsageFlags usage
=
1407 vk_image_layout_to_usage_flags(layout
, aspect
) & image_aspect_usage
;
1409 bool aux_supported
= true;
1411 if ((usage
& VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
) && !read_only
) {
1412 /* This image could be used as both an input attachment and a render
1413 * target (depth, stencil, or color) at the same time and this can cause
1416 * We currently only disable aux in this way for depth even though we
1417 * disable it for color in GL.
1419 * TODO: Should we be disabling this in more cases?
1421 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
)
1422 aux_supported
= false;
1425 if (usage
& VK_IMAGE_USAGE_STORAGE_BIT
)
1426 aux_supported
= false;
1428 if (usage
& (VK_IMAGE_USAGE_TRANSFER_SRC_BIT
|
1429 VK_IMAGE_USAGE_SAMPLED_BIT
|
1430 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
)) {
1431 switch (aux_usage
) {
1432 case ISL_AUX_USAGE_HIZ
:
1433 if (!anv_can_sample_with_hiz(devinfo
, image
))
1434 aux_supported
= false;
1437 case ISL_AUX_USAGE_HIZ_CCS
:
1438 aux_supported
= false;
1441 case ISL_AUX_USAGE_HIZ_CCS_WT
:
1444 case ISL_AUX_USAGE_CCS_D
:
1445 aux_supported
= false;
1448 case ISL_AUX_USAGE_CCS_E
:
1449 case ISL_AUX_USAGE_MCS
:
1453 unreachable("Unsupported aux usage");
1457 switch (aux_usage
) {
1458 case ISL_AUX_USAGE_HIZ
:
1459 case ISL_AUX_USAGE_HIZ_CCS
:
1460 case ISL_AUX_USAGE_HIZ_CCS_WT
:
1461 if (aux_supported
) {
1462 return ISL_AUX_STATE_COMPRESSED_CLEAR
;
1463 } else if (read_only
) {
1464 return ISL_AUX_STATE_RESOLVED
;
1466 return ISL_AUX_STATE_AUX_INVALID
;
1469 case ISL_AUX_USAGE_CCS_D
:
1470 /* We only support clear in exactly one state */
1471 if (layout
== VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
) {
1472 assert(aux_supported
);
1473 return ISL_AUX_STATE_PARTIAL_CLEAR
;
1475 return ISL_AUX_STATE_PASS_THROUGH
;
1478 case ISL_AUX_USAGE_CCS_E
:
1479 case ISL_AUX_USAGE_MCS
:
1480 if (aux_supported
) {
1481 return ISL_AUX_STATE_COMPRESSED_CLEAR
;
1483 return ISL_AUX_STATE_PASS_THROUGH
;
1487 unreachable("Unsupported aux usage");
1492 * This function determines the optimal buffer to use for a given
1493 * VkImageLayout and other pieces of information needed to make that
1494 * determination. This does not determine the optimal buffer to use
1495 * during a resolve operation.
1497 * @param devinfo The device information of the Intel GPU.
1498 * @param image The image that may contain a collection of buffers.
1499 * @param aspect The aspect of the image to be accessed.
1500 * @param usage The usage which describes how the image will be accessed.
1501 * @param layout The current layout of the image aspect(s).
1503 * @return The primary buffer that should be used for the given layout.
1506 anv_layout_to_aux_usage(const struct gen_device_info
* const devinfo
,
1507 const struct anv_image
* const image
,
1508 const VkImageAspectFlagBits aspect
,
1509 const VkImageUsageFlagBits usage
,
1510 const VkImageLayout layout
)
1512 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
1514 /* If there is no auxiliary surface allocated, we must use the one and only
1517 if (image
->planes
[plane
].aux_usage
== ISL_AUX_USAGE_NONE
)
1518 return ISL_AUX_USAGE_NONE
;
1520 enum isl_aux_state aux_state
=
1521 anv_layout_to_aux_state(devinfo
, image
, aspect
, layout
);
1523 switch (aux_state
) {
1524 case ISL_AUX_STATE_CLEAR
:
1525 unreachable("We never use this state");
1527 case ISL_AUX_STATE_PARTIAL_CLEAR
:
1528 assert(image
->aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
);
1529 assert(image
->planes
[plane
].aux_usage
== ISL_AUX_USAGE_CCS_D
);
1530 assert(image
->samples
== 1);
1531 return ISL_AUX_USAGE_CCS_D
;
1533 case ISL_AUX_STATE_COMPRESSED_CLEAR
:
1534 case ISL_AUX_STATE_COMPRESSED_NO_CLEAR
:
1535 return image
->planes
[plane
].aux_usage
;
1537 case ISL_AUX_STATE_RESOLVED
:
1538 /* We can only use RESOLVED in read-only layouts because any write will
1539 * either land us in AUX_INVALID or COMPRESSED_NO_CLEAR. We can do
1540 * writes in PASS_THROUGH without destroying it so that is allowed.
1542 assert(vk_image_layout_is_read_only(layout
, aspect
));
1543 assert(util_is_power_of_two_or_zero(usage
));
1544 if (usage
== VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
) {
1545 /* If we have valid HiZ data and are using the image as a read-only
1546 * depth/stencil attachment, we should enable HiZ so that we can get
1547 * faster depth testing.
1549 return image
->planes
[plane
].aux_usage
;
1551 return ISL_AUX_USAGE_NONE
;
1554 case ISL_AUX_STATE_PASS_THROUGH
:
1555 case ISL_AUX_STATE_AUX_INVALID
:
1556 return ISL_AUX_USAGE_NONE
;
1559 unreachable("Invalid isl_aux_state");
1563 * This function returns the level of unresolved fast-clear support of the
1564 * given image in the given VkImageLayout.
1566 * @param devinfo The device information of the Intel GPU.
1567 * @param image The image that may contain a collection of buffers.
1568 * @param aspect The aspect of the image to be accessed.
1569 * @param usage The usage which describes how the image will be accessed.
1570 * @param layout The current layout of the image aspect(s).
1572 enum anv_fast_clear_type
1573 anv_layout_to_fast_clear_type(const struct gen_device_info
* const devinfo
,
1574 const struct anv_image
* const image
,
1575 const VkImageAspectFlagBits aspect
,
1576 const VkImageLayout layout
)
1578 if (INTEL_DEBUG
& DEBUG_NO_FAST_CLEAR
)
1579 return ANV_FAST_CLEAR_NONE
;
1581 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
1583 /* If there is no auxiliary surface allocated, there are no fast-clears */
1584 if (image
->planes
[plane
].aux_usage
== ISL_AUX_USAGE_NONE
)
1585 return ANV_FAST_CLEAR_NONE
;
1587 /* We don't support MSAA fast-clears on Ivybridge or Bay Trail because they
1588 * lack the MI ALU which we need to determine the predicates.
1590 if (devinfo
->gen
== 7 && !devinfo
->is_haswell
&& image
->samples
> 1)
1591 return ANV_FAST_CLEAR_NONE
;
1593 enum isl_aux_state aux_state
=
1594 anv_layout_to_aux_state(devinfo
, image
, aspect
, layout
);
1596 switch (aux_state
) {
1597 case ISL_AUX_STATE_CLEAR
:
1598 unreachable("We never use this state");
1600 case ISL_AUX_STATE_PARTIAL_CLEAR
:
1601 case ISL_AUX_STATE_COMPRESSED_CLEAR
:
1602 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
1603 return ANV_FAST_CLEAR_DEFAULT_VALUE
;
1604 } else if (layout
== VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
) {
1605 /* When we're in a render pass we have the clear color data from the
1606 * VkRenderPassBeginInfo and we can use arbitrary clear colors. They
1607 * must get partially resolved before we leave the render pass.
1609 return ANV_FAST_CLEAR_ANY
;
1610 } else if (image
->planes
[plane
].aux_usage
== ISL_AUX_USAGE_MCS
||
1611 image
->planes
[plane
].aux_usage
== ISL_AUX_USAGE_CCS_E
) {
1612 if (devinfo
->gen
>= 11) {
1613 /* On ICL and later, the sampler hardware uses a copy of the clear
1614 * value that is encoded as a pixel value. Therefore, we can use
1615 * any clear color we like for sampling.
1617 return ANV_FAST_CLEAR_ANY
;
1619 /* If the image has MCS or CCS_E enabled all the time then we can
1620 * use fast-clear as long as the clear color is the default value
1621 * of zero since this is the default value we program into every
1622 * surface state used for texturing.
1624 return ANV_FAST_CLEAR_DEFAULT_VALUE
;
1627 return ANV_FAST_CLEAR_NONE
;
1630 case ISL_AUX_STATE_COMPRESSED_NO_CLEAR
:
1631 case ISL_AUX_STATE_RESOLVED
:
1632 case ISL_AUX_STATE_PASS_THROUGH
:
1633 case ISL_AUX_STATE_AUX_INVALID
:
1634 return ANV_FAST_CLEAR_NONE
;
1637 unreachable("Invalid isl_aux_state");
1641 static struct anv_state
1642 alloc_surface_state(struct anv_device
*device
)
1644 return anv_state_pool_alloc(&device
->surface_state_pool
, 64, 64);
1647 static enum isl_channel_select
1648 remap_swizzle(VkComponentSwizzle swizzle
, VkComponentSwizzle component
,
1649 struct isl_swizzle format_swizzle
)
1651 if (swizzle
== VK_COMPONENT_SWIZZLE_IDENTITY
)
1652 swizzle
= component
;
1655 case VK_COMPONENT_SWIZZLE_ZERO
: return ISL_CHANNEL_SELECT_ZERO
;
1656 case VK_COMPONENT_SWIZZLE_ONE
: return ISL_CHANNEL_SELECT_ONE
;
1657 case VK_COMPONENT_SWIZZLE_R
: return format_swizzle
.r
;
1658 case VK_COMPONENT_SWIZZLE_G
: return format_swizzle
.g
;
1659 case VK_COMPONENT_SWIZZLE_B
: return format_swizzle
.b
;
1660 case VK_COMPONENT_SWIZZLE_A
: return format_swizzle
.a
;
1662 unreachable("Invalid swizzle");
1667 anv_image_fill_surface_state(struct anv_device
*device
,
1668 const struct anv_image
*image
,
1669 VkImageAspectFlagBits aspect
,
1670 const struct isl_view
*view_in
,
1671 isl_surf_usage_flags_t view_usage
,
1672 enum isl_aux_usage aux_usage
,
1673 const union isl_color_value
*clear_color
,
1674 enum anv_image_view_state_flags flags
,
1675 struct anv_surface_state
*state_inout
,
1676 struct brw_image_param
*image_param_out
)
1678 uint32_t plane
= anv_image_aspect_to_plane(image
->aspects
, aspect
);
1680 const struct anv_surface
*surface
= &image
->planes
[plane
].surface
,
1681 *aux_surface
= &image
->planes
[plane
].aux_surface
;
1683 struct isl_view view
= *view_in
;
1684 view
.usage
|= view_usage
;
1686 /* For texturing with VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL from a
1687 * compressed surface with a shadow surface, we use the shadow instead of
1688 * the primary surface. The shadow surface will be tiled, unlike the main
1689 * surface, so it should get significantly better performance.
1691 if (image
->planes
[plane
].shadow_surface
.isl
.size_B
> 0 &&
1692 isl_format_is_compressed(view
.format
) &&
1693 (flags
& ANV_IMAGE_VIEW_STATE_TEXTURE_OPTIMAL
)) {
1694 assert(isl_format_is_compressed(surface
->isl
.format
));
1695 assert(surface
->isl
.tiling
== ISL_TILING_LINEAR
);
1696 assert(image
->planes
[plane
].shadow_surface
.isl
.tiling
!= ISL_TILING_LINEAR
);
1697 surface
= &image
->planes
[plane
].shadow_surface
;
1700 /* For texturing from stencil on gen7, we have to sample from a shadow
1701 * surface because we don't support W-tiling in the sampler.
1703 if (image
->planes
[plane
].shadow_surface
.isl
.size_B
> 0 &&
1704 aspect
== VK_IMAGE_ASPECT_STENCIL_BIT
) {
1705 assert(device
->info
.gen
== 7);
1706 assert(view_usage
& ISL_SURF_USAGE_TEXTURE_BIT
);
1707 surface
= &image
->planes
[plane
].shadow_surface
;
1710 if (view_usage
== ISL_SURF_USAGE_RENDER_TARGET_BIT
)
1711 view
.swizzle
= anv_swizzle_for_render(view
.swizzle
);
1713 /* On Ivy Bridge and Bay Trail we do the swizzle in the shader */
1714 if (device
->info
.gen
== 7 && !device
->info
.is_haswell
)
1715 view
.swizzle
= ISL_SWIZZLE_IDENTITY
;
1717 /* If this is a HiZ buffer we can sample from with a programmable clear
1718 * value (SKL+), define the clear value to the optimal constant.
1720 union isl_color_value default_clear_color
= { .u32
= { 0, } };
1721 if (device
->info
.gen
>= 9 && aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
)
1722 default_clear_color
.f32
[0] = ANV_HZ_FC_VAL
;
1724 clear_color
= &default_clear_color
;
1726 const struct anv_address address
=
1727 anv_address_add(image
->planes
[plane
].address
, surface
->offset
);
1729 if (view_usage
== ISL_SURF_USAGE_STORAGE_BIT
&&
1730 !(flags
& ANV_IMAGE_VIEW_STATE_STORAGE_WRITE_ONLY
) &&
1731 !isl_has_matching_typed_storage_image_format(&device
->info
,
1733 /* In this case, we are a writeable storage buffer which needs to be
1734 * lowered to linear. All tiling and offset calculations will be done in
1737 assert(aux_usage
== ISL_AUX_USAGE_NONE
);
1738 isl_buffer_fill_state(&device
->isl_dev
, state_inout
->state
.map
,
1739 .address
= anv_address_physical(address
),
1740 .size_B
= surface
->isl
.size_B
,
1741 .format
= ISL_FORMAT_RAW
,
1742 .swizzle
= ISL_SWIZZLE_IDENTITY
,
1744 .mocs
= anv_mocs_for_bo(device
, address
.bo
));
1745 state_inout
->address
= address
,
1746 state_inout
->aux_address
= ANV_NULL_ADDRESS
;
1747 state_inout
->clear_address
= ANV_NULL_ADDRESS
;
1749 if (view_usage
== ISL_SURF_USAGE_STORAGE_BIT
&&
1750 !(flags
& ANV_IMAGE_VIEW_STATE_STORAGE_WRITE_ONLY
)) {
1751 /* Typed surface reads support a very limited subset of the shader
1752 * image formats. Translate it into the closest format the hardware
1755 assert(aux_usage
== ISL_AUX_USAGE_NONE
);
1756 view
.format
= isl_lower_storage_image_format(&device
->info
,
1760 const struct isl_surf
*isl_surf
= &surface
->isl
;
1762 struct isl_surf tmp_surf
;
1763 uint32_t offset_B
= 0, tile_x_sa
= 0, tile_y_sa
= 0;
1764 if (isl_format_is_compressed(surface
->isl
.format
) &&
1765 !isl_format_is_compressed(view
.format
)) {
1766 /* We're creating an uncompressed view of a compressed surface. This
1767 * is allowed but only for a single level/layer.
1769 assert(surface
->isl
.samples
== 1);
1770 assert(view
.levels
== 1);
1771 assert(view
.array_len
== 1);
1773 isl_surf_get_image_surf(&device
->isl_dev
, isl_surf
,
1775 surface
->isl
.dim
== ISL_SURF_DIM_3D
?
1776 0 : view
.base_array_layer
,
1777 surface
->isl
.dim
== ISL_SURF_DIM_3D
?
1778 view
.base_array_layer
: 0,
1780 &offset_B
, &tile_x_sa
, &tile_y_sa
);
1782 /* The newly created image represents the one subimage we're
1783 * referencing with this view so it only has one array slice and
1786 view
.base_array_layer
= 0;
1787 view
.base_level
= 0;
1789 /* We're making an uncompressed view here. The image dimensions need
1790 * to be scaled down by the block size.
1792 const struct isl_format_layout
*fmtl
=
1793 isl_format_get_layout(surface
->isl
.format
);
1794 tmp_surf
.logical_level0_px
=
1795 isl_surf_get_logical_level0_el(&tmp_surf
);
1796 tmp_surf
.phys_level0_sa
= isl_surf_get_phys_level0_el(&tmp_surf
);
1797 tmp_surf
.format
= view
.format
;
1798 tile_x_sa
/= fmtl
->bw
;
1799 tile_y_sa
/= fmtl
->bh
;
1801 isl_surf
= &tmp_surf
;
1803 if (device
->info
.gen
<= 8) {
1804 assert(surface
->isl
.tiling
== ISL_TILING_LINEAR
);
1805 assert(tile_x_sa
== 0);
1806 assert(tile_y_sa
== 0);
1810 state_inout
->address
= anv_address_add(address
, offset_B
);
1812 struct anv_address aux_address
= ANV_NULL_ADDRESS
;
1813 if (aux_usage
!= ISL_AUX_USAGE_NONE
) {
1814 aux_address
= anv_address_add(image
->planes
[plane
].address
,
1815 aux_surface
->offset
);
1817 state_inout
->aux_address
= aux_address
;
1819 struct anv_address clear_address
= ANV_NULL_ADDRESS
;
1820 if (device
->info
.gen
>= 10 && aux_usage
!= ISL_AUX_USAGE_NONE
) {
1821 if (aspect
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
1822 clear_address
= (struct anv_address
) {
1823 .bo
= device
->hiz_clear_bo
,
1827 clear_address
= anv_image_get_clear_color_addr(device
, image
, aspect
);
1830 state_inout
->clear_address
= clear_address
;
1832 isl_surf_fill_state(&device
->isl_dev
, state_inout
->state
.map
,
1835 .address
= anv_address_physical(state_inout
->address
),
1836 .clear_color
= *clear_color
,
1837 .aux_surf
= &aux_surface
->isl
,
1838 .aux_usage
= aux_usage
,
1839 .aux_address
= anv_address_physical(aux_address
),
1840 .clear_address
= anv_address_physical(clear_address
),
1841 .use_clear_address
= !anv_address_is_null(clear_address
),
1842 .mocs
= anv_mocs_for_bo(device
,
1843 state_inout
->address
.bo
),
1844 .x_offset_sa
= tile_x_sa
,
1845 .y_offset_sa
= tile_y_sa
);
1847 /* With the exception of gen8, the bottom 12 bits of the MCS base address
1848 * are used to store other information. This should be ok, however,
1849 * because the surface buffer addresses are always 4K page aligned.
1851 uint32_t *aux_addr_dw
= state_inout
->state
.map
+
1852 device
->isl_dev
.ss
.aux_addr_offset
;
1853 assert((aux_address
.offset
& 0xfff) == 0);
1854 state_inout
->aux_address
.offset
|= *aux_addr_dw
& 0xfff;
1856 if (device
->info
.gen
>= 10 && clear_address
.bo
) {
1857 uint32_t *clear_addr_dw
= state_inout
->state
.map
+
1858 device
->isl_dev
.ss
.clear_color_state_offset
;
1859 assert((clear_address
.offset
& 0x3f) == 0);
1860 state_inout
->clear_address
.offset
|= *clear_addr_dw
& 0x3f;
1864 if (image_param_out
) {
1865 assert(view_usage
== ISL_SURF_USAGE_STORAGE_BIT
);
1866 isl_surf_fill_image_param(&device
->isl_dev
, image_param_out
,
1867 &surface
->isl
, &view
);
1871 static VkImageAspectFlags
1872 remap_aspect_flags(VkImageAspectFlags view_aspects
)
1874 if (view_aspects
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
) {
1875 if (util_bitcount(view_aspects
) == 1)
1876 return VK_IMAGE_ASPECT_COLOR_BIT
;
1878 VkImageAspectFlags color_aspects
= 0;
1879 for (uint32_t i
= 0; i
< util_bitcount(view_aspects
); i
++)
1880 color_aspects
|= VK_IMAGE_ASPECT_PLANE_0_BIT
<< i
;
1881 return color_aspects
;
1883 /* No special remapping needed for depth & stencil aspects. */
1884 return view_aspects
;
1888 anv_image_aspect_get_planes(VkImageAspectFlags aspect_mask
)
1890 uint32_t planes
= 0;
1892 if (aspect_mask
& (VK_IMAGE_ASPECT_COLOR_BIT
|
1893 VK_IMAGE_ASPECT_DEPTH_BIT
|
1894 VK_IMAGE_ASPECT_STENCIL_BIT
|
1895 VK_IMAGE_ASPECT_PLANE_0_BIT
))
1897 if (aspect_mask
& VK_IMAGE_ASPECT_PLANE_1_BIT
)
1899 if (aspect_mask
& VK_IMAGE_ASPECT_PLANE_2_BIT
)
1902 if ((aspect_mask
& VK_IMAGE_ASPECT_DEPTH_BIT
) != 0 &&
1903 (aspect_mask
& VK_IMAGE_ASPECT_STENCIL_BIT
) != 0)
1910 anv_CreateImageView(VkDevice _device
,
1911 const VkImageViewCreateInfo
*pCreateInfo
,
1912 const VkAllocationCallbacks
*pAllocator
,
1915 ANV_FROM_HANDLE(anv_device
, device
, _device
);
1916 ANV_FROM_HANDLE(anv_image
, image
, pCreateInfo
->image
);
1917 struct anv_image_view
*iview
;
1919 iview
= vk_zalloc2(&device
->vk
.alloc
, pAllocator
, sizeof(*iview
), 8,
1920 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT
);
1922 return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY
);
1924 vk_object_base_init(&device
->vk
, &iview
->base
, VK_OBJECT_TYPE_IMAGE_VIEW
);
1926 const VkImageSubresourceRange
*range
= &pCreateInfo
->subresourceRange
;
1928 assert(range
->layerCount
> 0);
1929 assert(range
->baseMipLevel
< image
->levels
);
1931 /* Check if a conversion info was passed. */
1932 const struct anv_format
*conv_format
= NULL
;
1933 const VkSamplerYcbcrConversionInfo
*conv_info
=
1934 vk_find_struct_const(pCreateInfo
->pNext
, SAMPLER_YCBCR_CONVERSION_INFO
);
1936 /* If image has an external format, the pNext chain must contain an instance of
1937 * VKSamplerYcbcrConversionInfo with a conversion object created with the same
1938 * external format as image."
1940 assert(!image
->external_format
|| conv_info
);
1943 ANV_FROM_HANDLE(anv_ycbcr_conversion
, conversion
, conv_info
->conversion
);
1944 conv_format
= conversion
->format
;
1947 VkImageUsageFlags image_usage
= image
->usage
;
1948 if (range
->aspectMask
& (VK_IMAGE_ASPECT_DEPTH_BIT
|
1949 VK_IMAGE_ASPECT_STENCIL_BIT
)) {
1950 assert(!(range
->aspectMask
& VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV
));
1951 /* From the Vulkan 1.2.131 spec:
1953 * "If the image was has a depth-stencil format and was created with
1954 * a VkImageStencilUsageCreateInfo structure included in the pNext
1955 * chain of VkImageCreateInfo, the usage is calculated based on the
1956 * subresource.aspectMask provided:
1958 * - If aspectMask includes only VK_IMAGE_ASPECT_STENCIL_BIT, the
1959 * implicit usage is equal to
1960 * VkImageStencilUsageCreateInfo::stencilUsage.
1962 * - If aspectMask includes only VK_IMAGE_ASPECT_DEPTH_BIT, the
1963 * implicit usage is equal to VkImageCreateInfo::usage.
1965 * - If both aspects are included in aspectMask, the implicit usage
1966 * is equal to the intersection of VkImageCreateInfo::usage and
1967 * VkImageStencilUsageCreateInfo::stencilUsage.
1969 if (range
->aspectMask
== VK_IMAGE_ASPECT_STENCIL_BIT
) {
1970 image_usage
= image
->stencil_usage
;
1971 } else if (range
->aspectMask
== VK_IMAGE_ASPECT_DEPTH_BIT
) {
1972 image_usage
= image
->usage
;
1974 assert(range
->aspectMask
== (VK_IMAGE_ASPECT_DEPTH_BIT
|
1975 VK_IMAGE_ASPECT_STENCIL_BIT
));
1976 image_usage
= image
->usage
& image
->stencil_usage
;
1980 const VkImageViewUsageCreateInfo
*usage_info
=
1981 vk_find_struct_const(pCreateInfo
, IMAGE_VIEW_USAGE_CREATE_INFO
);
1982 VkImageUsageFlags view_usage
= usage_info
? usage_info
->usage
: image_usage
;
1984 /* View usage should be a subset of image usage */
1985 assert((view_usage
& ~image_usage
) == 0);
1986 assert(view_usage
& (VK_IMAGE_USAGE_SAMPLED_BIT
|
1987 VK_IMAGE_USAGE_STORAGE_BIT
|
1988 VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
|
1989 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
|
1990 VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
));
1992 switch (image
->type
) {
1994 unreachable("bad VkImageType");
1995 case VK_IMAGE_TYPE_1D
:
1996 case VK_IMAGE_TYPE_2D
:
1997 assert(range
->baseArrayLayer
+ anv_get_layerCount(image
, range
) - 1 <= image
->array_size
);
1999 case VK_IMAGE_TYPE_3D
:
2000 assert(range
->baseArrayLayer
+ anv_get_layerCount(image
, range
) - 1
2001 <= anv_minify(image
->extent
.depth
, range
->baseMipLevel
));
2005 /* First expand aspects to the image's ones (for example
2006 * VK_IMAGE_ASPECT_COLOR_BIT will be converted to
2007 * VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT |
2008 * VK_IMAGE_ASPECT_PLANE_2_BIT for an image of format
2009 * VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM.
2011 VkImageAspectFlags expanded_aspects
=
2012 anv_image_expand_aspects(image
, range
->aspectMask
);
2014 iview
->image
= image
;
2016 /* Remap the expanded aspects for the image view. For example if only
2017 * VK_IMAGE_ASPECT_PLANE_1_BIT was given in range->aspectMask, we will
2018 * convert it to VK_IMAGE_ASPECT_COLOR_BIT since from the point of view of
2019 * the image view, it only has a single plane.
2021 iview
->aspect_mask
= remap_aspect_flags(expanded_aspects
);
2022 iview
->n_planes
= anv_image_aspect_get_planes(iview
->aspect_mask
);
2023 iview
->vk_format
= pCreateInfo
->format
;
2025 /* "If image has an external format, format must be VK_FORMAT_UNDEFINED." */
2026 assert(!image
->external_format
|| pCreateInfo
->format
== VK_FORMAT_UNDEFINED
);
2028 /* Format is undefined, this can happen when using external formats. Set
2029 * view format from the passed conversion info.
2031 if (iview
->vk_format
== VK_FORMAT_UNDEFINED
&& conv_format
)
2032 iview
->vk_format
= conv_format
->vk_format
;
2034 iview
->extent
= (VkExtent3D
) {
2035 .width
= anv_minify(image
->extent
.width
, range
->baseMipLevel
),
2036 .height
= anv_minify(image
->extent
.height
, range
->baseMipLevel
),
2037 .depth
= anv_minify(image
->extent
.depth
, range
->baseMipLevel
),
2040 /* Now go through the underlying image selected planes (computed in
2041 * expanded_aspects) and map them to planes in the image view.
2043 uint32_t iaspect_bit
, vplane
= 0;
2044 anv_foreach_image_aspect_bit(iaspect_bit
, image
, expanded_aspects
) {
2046 anv_image_aspect_to_plane(image
->aspects
, 1UL << iaspect_bit
);
2047 VkImageAspectFlags vplane_aspect
=
2048 anv_plane_to_aspect(iview
->aspect_mask
, vplane
);
2049 struct anv_format_plane format
=
2050 anv_get_format_plane(&device
->info
, iview
->vk_format
,
2051 vplane_aspect
, image
->tiling
);
2053 iview
->planes
[vplane
].image_plane
= iplane
;
2055 iview
->planes
[vplane
].isl
= (struct isl_view
) {
2056 .format
= format
.isl_format
,
2057 .base_level
= range
->baseMipLevel
,
2058 .levels
= anv_get_levelCount(image
, range
),
2059 .base_array_layer
= range
->baseArrayLayer
,
2060 .array_len
= anv_get_layerCount(image
, range
),
2062 .r
= remap_swizzle(pCreateInfo
->components
.r
,
2063 VK_COMPONENT_SWIZZLE_R
, format
.swizzle
),
2064 .g
= remap_swizzle(pCreateInfo
->components
.g
,
2065 VK_COMPONENT_SWIZZLE_G
, format
.swizzle
),
2066 .b
= remap_swizzle(pCreateInfo
->components
.b
,
2067 VK_COMPONENT_SWIZZLE_B
, format
.swizzle
),
2068 .a
= remap_swizzle(pCreateInfo
->components
.a
,
2069 VK_COMPONENT_SWIZZLE_A
, format
.swizzle
),
2073 if (pCreateInfo
->viewType
== VK_IMAGE_VIEW_TYPE_3D
) {
2074 iview
->planes
[vplane
].isl
.base_array_layer
= 0;
2075 iview
->planes
[vplane
].isl
.array_len
= iview
->extent
.depth
;
2078 if (pCreateInfo
->viewType
== VK_IMAGE_VIEW_TYPE_CUBE
||
2079 pCreateInfo
->viewType
== VK_IMAGE_VIEW_TYPE_CUBE_ARRAY
) {
2080 iview
->planes
[vplane
].isl
.usage
= ISL_SURF_USAGE_CUBE_BIT
;
2082 iview
->planes
[vplane
].isl
.usage
= 0;
2085 if (view_usage
& VK_IMAGE_USAGE_SAMPLED_BIT
||
2086 (view_usage
& VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
&&
2087 !(iview
->aspect_mask
& VK_IMAGE_ASPECT_COLOR_BIT
))) {
2088 iview
->planes
[vplane
].optimal_sampler_surface_state
.state
= alloc_surface_state(device
);
2089 iview
->planes
[vplane
].general_sampler_surface_state
.state
= alloc_surface_state(device
);
2091 enum isl_aux_usage general_aux_usage
=
2092 anv_layout_to_aux_usage(&device
->info
, image
, 1UL << iaspect_bit
,
2093 VK_IMAGE_USAGE_SAMPLED_BIT
,
2094 VK_IMAGE_LAYOUT_GENERAL
);
2095 enum isl_aux_usage optimal_aux_usage
=
2096 anv_layout_to_aux_usage(&device
->info
, image
, 1UL << iaspect_bit
,
2097 VK_IMAGE_USAGE_SAMPLED_BIT
,
2098 VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL
);
2100 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
2101 &iview
->planes
[vplane
].isl
,
2102 ISL_SURF_USAGE_TEXTURE_BIT
,
2103 optimal_aux_usage
, NULL
,
2104 ANV_IMAGE_VIEW_STATE_TEXTURE_OPTIMAL
,
2105 &iview
->planes
[vplane
].optimal_sampler_surface_state
,
2108 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
2109 &iview
->planes
[vplane
].isl
,
2110 ISL_SURF_USAGE_TEXTURE_BIT
,
2111 general_aux_usage
, NULL
,
2113 &iview
->planes
[vplane
].general_sampler_surface_state
,
2117 /* NOTE: This one needs to go last since it may stomp isl_view.format */
2118 if (view_usage
& VK_IMAGE_USAGE_STORAGE_BIT
) {
2119 iview
->planes
[vplane
].storage_surface_state
.state
= alloc_surface_state(device
);
2120 iview
->planes
[vplane
].writeonly_storage_surface_state
.state
= alloc_surface_state(device
);
2122 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
2123 &iview
->planes
[vplane
].isl
,
2124 ISL_SURF_USAGE_STORAGE_BIT
,
2125 ISL_AUX_USAGE_NONE
, NULL
,
2127 &iview
->planes
[vplane
].storage_surface_state
,
2128 &iview
->planes
[vplane
].storage_image_param
);
2130 anv_image_fill_surface_state(device
, image
, 1ULL << iaspect_bit
,
2131 &iview
->planes
[vplane
].isl
,
2132 ISL_SURF_USAGE_STORAGE_BIT
,
2133 ISL_AUX_USAGE_NONE
, NULL
,
2134 ANV_IMAGE_VIEW_STATE_STORAGE_WRITE_ONLY
,
2135 &iview
->planes
[vplane
].writeonly_storage_surface_state
,
2142 *pView
= anv_image_view_to_handle(iview
);
2148 anv_DestroyImageView(VkDevice _device
, VkImageView _iview
,
2149 const VkAllocationCallbacks
*pAllocator
)
2151 ANV_FROM_HANDLE(anv_device
, device
, _device
);
2152 ANV_FROM_HANDLE(anv_image_view
, iview
, _iview
);
2157 for (uint32_t plane
= 0; plane
< iview
->n_planes
; plane
++) {
2158 if (iview
->planes
[plane
].optimal_sampler_surface_state
.state
.alloc_size
> 0) {
2159 anv_state_pool_free(&device
->surface_state_pool
,
2160 iview
->planes
[plane
].optimal_sampler_surface_state
.state
);
2163 if (iview
->planes
[plane
].general_sampler_surface_state
.state
.alloc_size
> 0) {
2164 anv_state_pool_free(&device
->surface_state_pool
,
2165 iview
->planes
[plane
].general_sampler_surface_state
.state
);
2168 if (iview
->planes
[plane
].storage_surface_state
.state
.alloc_size
> 0) {
2169 anv_state_pool_free(&device
->surface_state_pool
,
2170 iview
->planes
[plane
].storage_surface_state
.state
);
2173 if (iview
->planes
[plane
].writeonly_storage_surface_state
.state
.alloc_size
> 0) {
2174 anv_state_pool_free(&device
->surface_state_pool
,
2175 iview
->planes
[plane
].writeonly_storage_surface_state
.state
);
2179 vk_object_base_finish(&iview
->base
);
2180 vk_free2(&device
->vk
.alloc
, pAllocator
, iview
);
2185 anv_CreateBufferView(VkDevice _device
,
2186 const VkBufferViewCreateInfo
*pCreateInfo
,
2187 const VkAllocationCallbacks
*pAllocator
,
2188 VkBufferView
*pView
)
2190 ANV_FROM_HANDLE(anv_device
, device
, _device
);
2191 ANV_FROM_HANDLE(anv_buffer
, buffer
, pCreateInfo
->buffer
);
2192 struct anv_buffer_view
*view
;
2194 view
= vk_alloc2(&device
->vk
.alloc
, pAllocator
, sizeof(*view
), 8,
2195 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT
);
2197 return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY
);
2199 /* TODO: Handle the format swizzle? */
2201 vk_object_base_init(&device
->vk
, &view
->base
, VK_OBJECT_TYPE_BUFFER_VIEW
);
2202 view
->format
= anv_get_isl_format(&device
->info
, pCreateInfo
->format
,
2203 VK_IMAGE_ASPECT_COLOR_BIT
,
2204 VK_IMAGE_TILING_LINEAR
);
2205 const uint32_t format_bs
= isl_format_get_layout(view
->format
)->bpb
/ 8;
2206 view
->range
= anv_buffer_get_range(buffer
, pCreateInfo
->offset
,
2207 pCreateInfo
->range
);
2208 view
->range
= align_down_npot_u32(view
->range
, format_bs
);
2210 view
->address
= anv_address_add(buffer
->address
, pCreateInfo
->offset
);
2212 if (buffer
->usage
& VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT
) {
2213 view
->surface_state
= alloc_surface_state(device
);
2215 anv_fill_buffer_surface_state(device
, view
->surface_state
,
2217 view
->address
, view
->range
, format_bs
);
2219 view
->surface_state
= (struct anv_state
){ 0 };
2222 if (buffer
->usage
& VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT
) {
2223 view
->storage_surface_state
= alloc_surface_state(device
);
2224 view
->writeonly_storage_surface_state
= alloc_surface_state(device
);
2226 enum isl_format storage_format
=
2227 isl_has_matching_typed_storage_image_format(&device
->info
,
2229 isl_lower_storage_image_format(&device
->info
, view
->format
) :
2232 anv_fill_buffer_surface_state(device
, view
->storage_surface_state
,
2234 view
->address
, view
->range
,
2235 (storage_format
== ISL_FORMAT_RAW
? 1 :
2236 isl_format_get_layout(storage_format
)->bpb
/ 8));
2238 /* Write-only accesses should use the original format. */
2239 anv_fill_buffer_surface_state(device
, view
->writeonly_storage_surface_state
,
2241 view
->address
, view
->range
,
2242 isl_format_get_layout(view
->format
)->bpb
/ 8);
2244 isl_buffer_fill_image_param(&device
->isl_dev
,
2245 &view
->storage_image_param
,
2246 view
->format
, view
->range
);
2248 view
->storage_surface_state
= (struct anv_state
){ 0 };
2249 view
->writeonly_storage_surface_state
= (struct anv_state
){ 0 };
2252 *pView
= anv_buffer_view_to_handle(view
);
2258 anv_DestroyBufferView(VkDevice _device
, VkBufferView bufferView
,
2259 const VkAllocationCallbacks
*pAllocator
)
2261 ANV_FROM_HANDLE(anv_device
, device
, _device
);
2262 ANV_FROM_HANDLE(anv_buffer_view
, view
, bufferView
);
2267 if (view
->surface_state
.alloc_size
> 0)
2268 anv_state_pool_free(&device
->surface_state_pool
,
2269 view
->surface_state
);
2271 if (view
->storage_surface_state
.alloc_size
> 0)
2272 anv_state_pool_free(&device
->surface_state_pool
,
2273 view
->storage_surface_state
);
2275 if (view
->writeonly_storage_surface_state
.alloc_size
> 0)
2276 anv_state_pool_free(&device
->surface_state_pool
,
2277 view
->writeonly_storage_surface_state
);
2279 vk_object_base_finish(&view
->base
);
2280 vk_free2(&device
->vk
.alloc
, pAllocator
, view
);