src/intel/vulkan/anv_image.c

   1 /*
   2  * Copyright © 2015 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  */
  23
  24 #include <assert.h>
  25 #include <stdbool.h>
  26 #include <string.h>
  27 #include <unistd.h>
  28 #include <fcntl.h>
  29
  30 #include "anv_private.h"
  31 #include "util/debug.h"
  32
  33 #include "vk_format_info.h"
  34
  35 /**
  36  * Exactly one bit must be set in \a aspect.
  37  */
  38 static isl_surf_usage_flags_t
  39 choose_isl_surf_usage(VkImageUsageFlags vk_usage,
  40                       VkImageAspectFlags aspect)
  41 {
  42    isl_surf_usage_flags_t isl_usage = 0;
  43
  44    /* FINISHME: Support aux surfaces */
  45    isl_usage |= ISL_SURF_USAGE_DISABLE_AUX_BIT;
  46
  47    if (vk_usage & VK_IMAGE_USAGE_SAMPLED_BIT)
  48       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;
  49
  50    if (vk_usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)
  51       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;
  52
  53    if (vk_usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)
  54       isl_usage |= ISL_SURF_USAGE_RENDER_TARGET_BIT;
  55
  56    if (vk_usage & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT)
  57       isl_usage |= ISL_SURF_USAGE_CUBE_BIT;
  58
  59    if (vk_usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) {
  60       switch (aspect) {
  61       default:
  62          unreachable("bad VkImageAspect");
  63       case VK_IMAGE_ASPECT_DEPTH_BIT:
  64          isl_usage &= ~ISL_SURF_USAGE_DISABLE_AUX_BIT;
  65          isl_usage |= ISL_SURF_USAGE_DEPTH_BIT;
  66          break;
  67       case VK_IMAGE_ASPECT_STENCIL_BIT:
  68          isl_usage |= ISL_SURF_USAGE_STENCIL_BIT;
  69          break;
  70       }
  71    }
  72
  73    if (vk_usage & VK_IMAGE_USAGE_TRANSFER_SRC_BIT) {
  74       /* Meta implements transfers by sampling from the source image. */
  75       isl_usage |= ISL_SURF_USAGE_TEXTURE_BIT;
  76    }
  77
  78    if (vk_usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT) {
  79       /* Meta implements transfers by rendering into the destination image. */
  80       isl_usage |= ISL_SURF_USAGE_RENDER_TARGET_BIT;
  81    }
  82
  83    return isl_usage;
  84 }
  85
  86 /**
  87  * Exactly one bit must be set in \a aspect.
  88  */
  89 static struct anv_surface *
  90 get_surface(struct anv_image *image, VkImageAspectFlags aspect)
  91 {
  92    switch (aspect) {
  93    default:
  94       unreachable("bad VkImageAspect");
  95    case VK_IMAGE_ASPECT_COLOR_BIT:
  96       return &image->color_surface;
  97    case VK_IMAGE_ASPECT_DEPTH_BIT:
  98       return &image->depth_surface;
  99    case VK_IMAGE_ASPECT_STENCIL_BIT:
 100       return &image->stencil_surface;
 101    }
 102 }
 103
 104 static void
 105 add_surface(struct anv_image *image, struct anv_surface *surf)
 106 {
 107    assert(surf->isl.size > 0); /* isl surface must be initialized */
 108
 109    surf->offset = align_u32(image->size, surf->isl.alignment);
 110    image->size = surf->offset + surf->isl.size;
 111    image->alignment = MAX(image->alignment, surf->isl.alignment);
 112 }
 113
 114 /**
 115  * Initialize the anv_image::*_surface selected by \a aspect. Then update the
 116  * image's memory requirements (that is, the image's size and alignment).
 117  *
 118  * Exactly one bit must be set in \a aspect.
 119  */
 120 static VkResult
 121 make_surface(const struct anv_device *dev,
 122              struct anv_image *image,
 123              const struct anv_image_create_info *anv_info,
 124              VkImageAspectFlags aspect)
 125 {
 126    const VkImageCreateInfo *vk_info = anv_info->vk_info;
 127    bool ok UNUSED;
 128
 129    static const enum isl_surf_dim vk_to_isl_surf_dim[] = {
 130       [VK_IMAGE_TYPE_1D] = ISL_SURF_DIM_1D,
 131       [VK_IMAGE_TYPE_2D] = ISL_SURF_DIM_2D,
 132       [VK_IMAGE_TYPE_3D] = ISL_SURF_DIM_3D,
 133    };
 134
 135    /* Translate the Vulkan tiling to an equivalent ISL tiling, then filter the
 136     * result with an optionally provided ISL tiling argument.
 137     */
 138    isl_tiling_flags_t tiling_flags =
 139       (vk_info->tiling == VK_IMAGE_TILING_LINEAR) ?
 140       ISL_TILING_LINEAR_BIT : ISL_TILING_ANY_MASK;
 141
 142    if (anv_info->isl_tiling_flags)
 143       tiling_flags &= anv_info->isl_tiling_flags;
 144
 145    assert(tiling_flags);
 146
 147    struct anv_surface *anv_surf = get_surface(image, aspect);
 148
 149    image->extent = anv_sanitize_image_extent(vk_info->imageType,
 150                                              vk_info->extent);
 151
 152    enum isl_format format = anv_get_isl_format(&dev->info, vk_info->format,
 153                                                aspect, vk_info->tiling);
 154    assert(format != ISL_FORMAT_UNSUPPORTED);
 155
 156    ok = isl_surf_init(&dev->isl_dev, &anv_surf->isl,
 157       .dim = vk_to_isl_surf_dim[vk_info->imageType],
 158       .format = format,
 159       .width = image->extent.width,
 160       .height = image->extent.height,
 161       .depth = image->extent.depth,
 162       .levels = vk_info->mipLevels,
 163       .array_len = vk_info->arrayLayers,
 164       .samples = vk_info->samples,
 165       .min_alignment = 0,
 166       .min_pitch = anv_info->stride,
 167       .usage = choose_isl_surf_usage(image->usage, aspect),
 168       .tiling_flags = tiling_flags);
 169
 170    /* isl_surf_init() will fail only if provided invalid input. Invalid input
 171     * is illegal in Vulkan.
 172     */
 173    assert(ok);
 174
 175    add_surface(image, anv_surf);
 176
 177    /* Add a HiZ surface to a depth buffer that will be used for rendering.
 178     */
 179    if (aspect == VK_IMAGE_ASPECT_DEPTH_BIT &&
 180        (image->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) {
 181
 182       /* Allow the user to control HiZ enabling. Disable by default on gen7
 183        * because resolves are not currently implemented pre-BDW.
 184        */
 185       if (!env_var_as_boolean("INTEL_VK_HIZ", dev->info.gen >= 8)) {
 186          anv_finishme("Implement gen7 HiZ");
 187       } else if (vk_info->mipLevels > 1) {
 188          anv_finishme("Test multi-LOD HiZ");
 189       } else if (dev->info.gen == 8 && vk_info->samples > 1) {
 190          anv_finishme("Test gen8 multisampled HiZ");
 191       } else {
 192          isl_surf_get_hiz_surf(&dev->isl_dev, &image->depth_surface.isl,
 193                                &image->hiz_surface.isl);
 194          add_surface(image, &image->hiz_surface);
 195       }
 196    }
 197
 198    return VK_SUCCESS;
 199 }
 200
 201 /**
 202  * Parameter @a format is required and overrides VkImageCreateInfo::format.
 203  */
 204 static VkImageUsageFlags
 205 anv_image_get_full_usage(const VkImageCreateInfo *info,
 206                          VkImageAspectFlags aspects)
 207 {
 208    VkImageUsageFlags usage = info->usage;
 209
 210    if (info->samples > 1 &&
 211        (usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)) {
 212       /* Meta will resolve the image by binding it as a texture. */
 213       usage |= VK_IMAGE_USAGE_SAMPLED_BIT;
 214    }
 215
 216    if (usage & VK_IMAGE_USAGE_TRANSFER_SRC_BIT) {
 217       /* Meta will transfer from the image by binding it as a texture. */
 218       usage |= VK_IMAGE_USAGE_SAMPLED_BIT;
 219    }
 220
 221    if (usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT) {
 222       /* For non-clear transfer operations, meta will transfer to the image by
 223        * binding it as a color attachment, even if the image format is not
 224        * a color format.
 225        */
 226       usage |= VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
 227
 228       if (aspects & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) {
 229          /* vkCmdClearDepthStencilImage() only requires that
 230           * VK_IMAGE_USAGE_TRANSFER_SRC_BIT be set. In particular, it does
 231           * not require VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT. Meta
 232           * clears the image, though, by binding it as a depthstencil
 233           * attachment.
 234           */
 235          usage |= VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT;
 236       }
 237    }
 238
 239    return usage;
 240 }
 241
 242 VkResult
 243 anv_image_create(VkDevice _device,
 244                  const struct anv_image_create_info *create_info,
 245                  const VkAllocationCallbacks* alloc,
 246                  VkImage *pImage)
 247 {
 248    ANV_FROM_HANDLE(anv_device, device, _device);
 249    const VkImageCreateInfo *pCreateInfo = create_info->vk_info;
 250    struct anv_image *image = NULL;
 251    VkResult r;
 252
 253    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
 254
 255    anv_assert(pCreateInfo->mipLevels > 0);
 256    anv_assert(pCreateInfo->arrayLayers > 0);
 257    anv_assert(pCreateInfo->samples > 0);
 258    anv_assert(pCreateInfo->extent.width > 0);
 259    anv_assert(pCreateInfo->extent.height > 0);
 260    anv_assert(pCreateInfo->extent.depth > 0);
 261
 262    image = anv_alloc2(&device->alloc, alloc, sizeof(*image), 8,
 263                       VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 264    if (!image)
 265       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 266
 267    memset(image, 0, sizeof(*image));
 268    image->type = pCreateInfo->imageType;
 269    image->extent = pCreateInfo->extent;
 270    image->vk_format = pCreateInfo->format;
 271    image->aspects = vk_format_aspects(image->vk_format);
 272    image->levels = pCreateInfo->mipLevels;
 273    image->array_size = pCreateInfo->arrayLayers;
 274    image->samples = pCreateInfo->samples;
 275    image->usage = anv_image_get_full_usage(pCreateInfo, image->aspects);
 276    image->tiling = pCreateInfo->tiling;
 277
 278    uint32_t b;
 279    for_each_bit(b, image->aspects) {
 280       r = make_surface(device, image, create_info, (1 << b));
 281       if (r != VK_SUCCESS)
 282          goto fail;
 283    }
 284
 285    *pImage = anv_image_to_handle(image);
 286
 287    return VK_SUCCESS;
 288
 289 fail:
 290    if (image)
 291       anv_free2(&device->alloc, alloc, image);
 292
 293    return r;
 294 }
 295
 296 VkResult
 297 anv_CreateImage(VkDevice device,
 298                 const VkImageCreateInfo *pCreateInfo,
 299                 const VkAllocationCallbacks *pAllocator,
 300                 VkImage *pImage)
 301 {
 302    return anv_image_create(device,
 303       &(struct anv_image_create_info) {
 304          .vk_info = pCreateInfo,
 305       },
 306       pAllocator,
 307       pImage);
 308 }
 309
 310 void
 311 anv_DestroyImage(VkDevice _device, VkImage _image,
 312                  const VkAllocationCallbacks *pAllocator)
 313 {
 314    ANV_FROM_HANDLE(anv_device, device, _device);
 315
 316    anv_free2(&device->alloc, pAllocator, anv_image_from_handle(_image));
 317 }
 318
 319 VkResult anv_BindImageMemory(
 320     VkDevice                                    device,
 321     VkImage                                     _image,
 322     VkDeviceMemory                              _memory,
 323     VkDeviceSize                                memoryOffset)
 324 {
 325    ANV_FROM_HANDLE(anv_device_memory, mem, _memory);
 326    ANV_FROM_HANDLE(anv_image, image, _image);
 327
 328    if (mem) {
 329       image->bo = &mem->bo;
 330       image->offset = memoryOffset;
 331    } else {
 332       image->bo = NULL;
 333       image->offset = 0;
 334    }
 335
 336    return VK_SUCCESS;
 337 }
 338
 339 static void
 340 anv_surface_get_subresource_layout(struct anv_image *image,
 341                                    struct anv_surface *surface,
 342                                    const VkImageSubresource *subresource,
 343                                    VkSubresourceLayout *layout)
 344 {
 345    /* If we are on a non-zero mip level or array slice, we need to
 346     * calculate a real offset.
 347     */
 348    anv_assert(subresource->mipLevel == 0);
 349    anv_assert(subresource->arrayLayer == 0);
 350
 351    layout->offset = surface->offset;
 352    layout->rowPitch = surface->isl.row_pitch;
 353    layout->depthPitch = isl_surf_get_array_pitch(&surface->isl);
 354    layout->arrayPitch = isl_surf_get_array_pitch(&surface->isl);
 355    layout->size = surface->isl.size;
 356 }
 357
 358 void anv_GetImageSubresourceLayout(
 359     VkDevice                                    device,
 360     VkImage                                     _image,
 361     const VkImageSubresource*                   pSubresource,
 362     VkSubresourceLayout*                        pLayout)
 363 {
 364    ANV_FROM_HANDLE(anv_image, image, _image);
 365
 366    assert(__builtin_popcount(pSubresource->aspectMask) == 1);
 367
 368    switch (pSubresource->aspectMask) {
 369    case VK_IMAGE_ASPECT_COLOR_BIT:
 370       anv_surface_get_subresource_layout(image, &image->color_surface,
 371                                          pSubresource, pLayout);
 372       break;
 373    case VK_IMAGE_ASPECT_DEPTH_BIT:
 374       anv_surface_get_subresource_layout(image, &image->depth_surface,
 375                                          pSubresource, pLayout);
 376       break;
 377    case VK_IMAGE_ASPECT_STENCIL_BIT:
 378       anv_surface_get_subresource_layout(image, &image->stencil_surface,
 379                                          pSubresource, pLayout);
 380       break;
 381    default:
 382       assert(!"Invalid image aspect");
 383    }
 384 }
 385
 386 static struct anv_state
 387 alloc_surface_state(struct anv_device *device,
 388                     struct anv_cmd_buffer *cmd_buffer)
 389 {
 390       if (cmd_buffer) {
 391          return anv_cmd_buffer_alloc_surface_state(cmd_buffer);
 392       } else {
 393          return anv_state_pool_alloc(&device->surface_state_pool, 64, 64);
 394       }
 395 }
 396
 397 static enum isl_channel_select
 398 remap_swizzle(VkComponentSwizzle swizzle, VkComponentSwizzle component,
 399               struct isl_swizzle format_swizzle)
 400 {
 401    if (swizzle == VK_COMPONENT_SWIZZLE_IDENTITY)
 402       swizzle = component;
 403
 404    switch (swizzle) {
 405    case VK_COMPONENT_SWIZZLE_ZERO:  return ISL_CHANNEL_SELECT_ZERO;
 406    case VK_COMPONENT_SWIZZLE_ONE:   return ISL_CHANNEL_SELECT_ONE;
 407    case VK_COMPONENT_SWIZZLE_R:     return format_swizzle.r;
 408    case VK_COMPONENT_SWIZZLE_G:     return format_swizzle.g;
 409    case VK_COMPONENT_SWIZZLE_B:     return format_swizzle.b;
 410    case VK_COMPONENT_SWIZZLE_A:     return format_swizzle.a;
 411    default:
 412       unreachable("Invalid swizzle");
 413    }
 414 }
 415
 416 void
 417 anv_image_view_init(struct anv_image_view *iview,
 418                     struct anv_device *device,
 419                     const VkImageViewCreateInfo* pCreateInfo,
 420                     struct anv_cmd_buffer *cmd_buffer,
 421                     VkImageUsageFlags usage_mask)
 422 {
 423    ANV_FROM_HANDLE(anv_image, image, pCreateInfo->image);
 424    const VkImageSubresourceRange *range = &pCreateInfo->subresourceRange;
 425
 426    assert(range->layerCount > 0);
 427    assert(range->baseMipLevel < image->levels);
 428    assert(image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT |
 429                           VK_IMAGE_USAGE_STORAGE_BIT |
 430                           VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT |
 431                           VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT));
 432
 433    switch (image->type) {
 434    default:
 435       unreachable("bad VkImageType");
 436    case VK_IMAGE_TYPE_1D:
 437    case VK_IMAGE_TYPE_2D:
 438       assert(range->baseArrayLayer + anv_get_layerCount(image, range) - 1 <= image->array_size);
 439       break;
 440    case VK_IMAGE_TYPE_3D:
 441       assert(range->baseArrayLayer + anv_get_layerCount(image, range) - 1
 442              <= anv_minify(image->extent.depth, range->baseMipLevel));
 443       break;
 444    }
 445
 446    const struct anv_surface *surface =
 447       anv_image_get_surface_for_aspect_mask(image, range->aspectMask);
 448
 449    iview->image = image;
 450    iview->bo = image->bo;
 451    iview->offset = image->offset + surface->offset;
 452
 453    iview->aspect_mask = pCreateInfo->subresourceRange.aspectMask;
 454    iview->vk_format = pCreateInfo->format;
 455
 456    struct anv_format format = anv_get_format(&device->info, pCreateInfo->format,
 457                                              range->aspectMask, image->tiling);
 458
 459    iview->base_layer = range->baseArrayLayer;
 460    iview->base_mip = range->baseMipLevel;
 461
 462    struct isl_view isl_view = {
 463       .format = format.isl_format,
 464       .base_level = range->baseMipLevel,
 465       .levels = anv_get_levelCount(image, range),
 466       .base_array_layer = range->baseArrayLayer,
 467       .array_len = anv_get_layerCount(image, range),
 468       .swizzle = {
 469          .r = remap_swizzle(pCreateInfo->components.r,
 470                             VK_COMPONENT_SWIZZLE_R, format.swizzle),
 471          .g = remap_swizzle(pCreateInfo->components.g,
 472                             VK_COMPONENT_SWIZZLE_G, format.swizzle),
 473          .b = remap_swizzle(pCreateInfo->components.b,
 474                             VK_COMPONENT_SWIZZLE_B, format.swizzle),
 475          .a = remap_swizzle(pCreateInfo->components.a,
 476                             VK_COMPONENT_SWIZZLE_A, format.swizzle),
 477       },
 478    };
 479
 480    iview->extent = (VkExtent3D) {
 481       .width  = anv_minify(image->extent.width , range->baseMipLevel),
 482       .height = anv_minify(image->extent.height, range->baseMipLevel),
 483       .depth  = anv_minify(image->extent.depth , range->baseMipLevel),
 484    };
 485
 486    isl_surf_usage_flags_t cube_usage;
 487    if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE ||
 488        pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) {
 489       cube_usage = ISL_SURF_USAGE_CUBE_BIT;
 490    } else {
 491       cube_usage = 0;
 492    }
 493
 494    if (image->usage & usage_mask & VK_IMAGE_USAGE_SAMPLED_BIT) {
 495       iview->sampler_surface_state = alloc_surface_state(device, cmd_buffer);
 496
 497       isl_view.usage = cube_usage | ISL_SURF_USAGE_TEXTURE_BIT;
 498       isl_surf_fill_state(&device->isl_dev,
 499                           iview->sampler_surface_state.map,
 500                           .surf = &surface->isl,
 501                           .view = &isl_view,
 502                           .mocs = device->default_mocs);
 503
 504       if (!device->info.has_llc)
 505          anv_state_clflush(iview->sampler_surface_state);
 506    } else {
 507       iview->sampler_surface_state.alloc_size = 0;
 508    }
 509
 510    /* This is kind-of hackish.  It is possible, due to get_full_usage above,
 511     * to get a surface state with a non-renderable format but with
 512     * VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT.  This happens in particular for
 513     * formats which aren't renderable but where we want to use Vulkan copy
 514     * commands so VK_IMAGE_USAGE_TRANSFER_DST_BIT is set.  In the case of a
 515     * copy, meta will use a format that we can render to, but most of the rest
 516     * of the time, we don't want to create those surface states.  Once we
 517     * start using blorp for copies, this problem will go away and we can
 518     * remove a lot of hacks.
 519     */
 520    if ((image->usage & usage_mask & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) &&
 521        isl_format_supports_rendering(&device->info, isl_view.format)) {
 522       iview->color_rt_surface_state = alloc_surface_state(device, cmd_buffer);
 523
 524       isl_view.usage = cube_usage | ISL_SURF_USAGE_RENDER_TARGET_BIT;
 525       isl_surf_fill_state(&device->isl_dev,
 526                           iview->color_rt_surface_state.map,
 527                           .surf = &surface->isl,
 528                           .view = &isl_view,
 529                           .mocs = device->default_mocs);
 530
 531       if (!device->info.has_llc)
 532          anv_state_clflush(iview->color_rt_surface_state);
 533    } else {
 534       iview->color_rt_surface_state.alloc_size = 0;
 535    }
 536
 537    /* NOTE: This one needs to go last since it may stomp isl_view.format */
 538    if (image->usage & usage_mask & VK_IMAGE_USAGE_STORAGE_BIT) {
 539       iview->storage_surface_state = alloc_surface_state(device, cmd_buffer);
 540
 541       if (isl_has_matching_typed_storage_image_format(&device->info,
 542                                                       format.isl_format)) {
 543          isl_view.usage = cube_usage | ISL_SURF_USAGE_STORAGE_BIT;
 544          isl_view.format = isl_lower_storage_image_format(&device->info,
 545                                                           isl_view.format);
 546          if (image->type == VK_IMAGE_TYPE_3D) {
 547             isl_view.base_array_layer = 0;
 548             isl_view.array_len = iview->extent.depth;
 549          }
 550          isl_surf_fill_state(&device->isl_dev,
 551                              iview->storage_surface_state.map,
 552                              .surf = &surface->isl,
 553                              .view = &isl_view,
 554                              .mocs = device->default_mocs);
 555       } else {
 556          anv_fill_buffer_surface_state(device, iview->storage_surface_state,
 557                                        ISL_FORMAT_RAW,
 558                                        iview->offset,
 559                                        iview->bo->size - iview->offset, 1);
 560       }
 561
 562       isl_surf_fill_image_param(&device->isl_dev,
 563                                 &iview->storage_image_param,
 564                                 &surface->isl, &isl_view);
 565
 566       if (!device->info.has_llc)
 567          anv_state_clflush(iview->storage_surface_state);
 568    } else {
 569       iview->storage_surface_state.alloc_size = 0;
 570    }
 571 }
 572
 573 VkResult
 574 anv_CreateImageView(VkDevice _device,
 575                     const VkImageViewCreateInfo *pCreateInfo,
 576                     const VkAllocationCallbacks *pAllocator,
 577                     VkImageView *pView)
 578 {
 579    ANV_FROM_HANDLE(anv_device, device, _device);
 580    struct anv_image_view *view;
 581
 582    view = anv_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 583                      VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 584    if (view == NULL)
 585       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 586
 587    anv_image_view_init(view, device, pCreateInfo, NULL, ~0);
 588
 589    *pView = anv_image_view_to_handle(view);
 590
 591    return VK_SUCCESS;
 592 }
 593
 594 void
 595 anv_DestroyImageView(VkDevice _device, VkImageView _iview,
 596                      const VkAllocationCallbacks *pAllocator)
 597 {
 598    ANV_FROM_HANDLE(anv_device, device, _device);
 599    ANV_FROM_HANDLE(anv_image_view, iview, _iview);
 600
 601    if (iview->color_rt_surface_state.alloc_size > 0) {
 602       anv_state_pool_free(&device->surface_state_pool,
 603                           iview->color_rt_surface_state);
 604    }
 605
 606    if (iview->sampler_surface_state.alloc_size > 0) {
 607       anv_state_pool_free(&device->surface_state_pool,
 608                           iview->sampler_surface_state);
 609    }
 610
 611    if (iview->storage_surface_state.alloc_size > 0) {
 612       anv_state_pool_free(&device->surface_state_pool,
 613                           iview->storage_surface_state);
 614    }
 615
 616    anv_free2(&device->alloc, pAllocator, iview);
 617 }
 618
 619
 620 void anv_buffer_view_init(struct anv_buffer_view *view,
 621                           struct anv_device *device,
 622                           const VkBufferViewCreateInfo* pCreateInfo,
 623                           struct anv_cmd_buffer *cmd_buffer)
 624 {
 625    ANV_FROM_HANDLE(anv_buffer, buffer, pCreateInfo->buffer);
 626
 627    /* TODO: Handle the format swizzle? */
 628
 629    view->format = anv_get_isl_format(&device->info, pCreateInfo->format,
 630                                      VK_IMAGE_ASPECT_COLOR_BIT,
 631                                      VK_IMAGE_TILING_LINEAR);
 632    const uint32_t format_bs = isl_format_get_layout(view->format)->bpb / 8;
 633    view->bo = buffer->bo;
 634    view->offset = buffer->offset + pCreateInfo->offset;
 635    view->range = pCreateInfo->range == VK_WHOLE_SIZE ?
 636                  buffer->size - pCreateInfo->offset : pCreateInfo->range;
 637    view->range = align_down_npot_u32(view->range, format_bs);
 638
 639    if (buffer->usage & VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT) {
 640       view->surface_state = alloc_surface_state(device, cmd_buffer);
 641
 642       anv_fill_buffer_surface_state(device, view->surface_state,
 643                                     view->format,
 644                                     view->offset, view->range, format_bs);
 645    } else {
 646       view->surface_state = (struct anv_state){ 0 };
 647    }
 648
 649    if (buffer->usage & VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT) {
 650       view->storage_surface_state = alloc_surface_state(device, cmd_buffer);
 651
 652       enum isl_format storage_format =
 653          isl_has_matching_typed_storage_image_format(&device->info,
 654                                                      view->format) ?
 655          isl_lower_storage_image_format(&device->info, view->format) :
 656          ISL_FORMAT_RAW;
 657
 658       anv_fill_buffer_surface_state(device, view->storage_surface_state,
 659                                     storage_format,
 660                                     view->offset, view->range,
 661                                     (storage_format == ISL_FORMAT_RAW ? 1 :
 662                                      isl_format_get_layout(storage_format)->bpb / 8));
 663
 664       isl_buffer_fill_image_param(&device->isl_dev,
 665                                   &view->storage_image_param,
 666                                   view->format, view->range);
 667    } else {
 668       view->storage_surface_state = (struct anv_state){ 0 };
 669    }
 670 }
 671
 672 VkResult
 673 anv_CreateBufferView(VkDevice _device,
 674                      const VkBufferViewCreateInfo *pCreateInfo,
 675                      const VkAllocationCallbacks *pAllocator,
 676                      VkBufferView *pView)
 677 {
 678    ANV_FROM_HANDLE(anv_device, device, _device);
 679    struct anv_buffer_view *view;
 680
 681    view = anv_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 682                      VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 683    if (!view)
 684       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 685
 686    anv_buffer_view_init(view, device, pCreateInfo, NULL);
 687
 688    *pView = anv_buffer_view_to_handle(view);
 689
 690    return VK_SUCCESS;
 691 }
 692
 693 void
 694 anv_DestroyBufferView(VkDevice _device, VkBufferView bufferView,
 695                       const VkAllocationCallbacks *pAllocator)
 696 {
 697    ANV_FROM_HANDLE(anv_device, device, _device);
 698    ANV_FROM_HANDLE(anv_buffer_view, view, bufferView);
 699
 700    if (view->surface_state.alloc_size > 0)
 701       anv_state_pool_free(&device->surface_state_pool,
 702                           view->surface_state);
 703
 704    if (view->storage_surface_state.alloc_size > 0)
 705       anv_state_pool_free(&device->surface_state_pool,
 706                           view->storage_surface_state);
 707
 708    anv_free2(&device->alloc, pAllocator, view);
 709 }
 710
 711 const struct anv_surface *
 712 anv_image_get_surface_for_aspect_mask(const struct anv_image *image,
 713                                       VkImageAspectFlags aspect_mask)
 714 {
 715    switch (aspect_mask) {
 716    case VK_IMAGE_ASPECT_COLOR_BIT:
 717       /* Dragons will eat you.
 718        *
 719        * Meta attaches all destination surfaces as color render targets. Guess
 720        * what surface the Meta Dragons really want.
 721        */
 722       if (image->aspects & VK_IMAGE_ASPECT_DEPTH_BIT) {
 723          return &image->depth_surface;
 724       } else if (image->aspects & VK_IMAGE_ASPECT_STENCIL_BIT) {
 725          return &image->stencil_surface;
 726       } else {
 727          assert(image->aspects == VK_IMAGE_ASPECT_COLOR_BIT);
 728          return &image->color_surface;
 729       }
 730       break;
 731    case VK_IMAGE_ASPECT_DEPTH_BIT:
 732       assert(image->aspects & VK_IMAGE_ASPECT_DEPTH_BIT);
 733       return &image->depth_surface;
 734    case VK_IMAGE_ASPECT_STENCIL_BIT:
 735       assert(image->aspects & VK_IMAGE_ASPECT_STENCIL_BIT);
 736       return &image->stencil_surface;
 737    case VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT:
 738       /* FINISHME: The Vulkan spec (git a511ba2) requires support for
 739        * combined depth stencil formats. Specifically, it states:
 740        *
 741        *    At least one of ename:VK_FORMAT_D24_UNORM_S8_UINT or
 742        *    ename:VK_FORMAT_D32_SFLOAT_S8_UINT must be supported.
 743        *
 744        * Image views with both depth and stencil aspects are only valid for
 745        * render target attachments, in which case
 746        * cmd_buffer_emit_depth_stencil() will pick out both the depth and
 747        * stencil surfaces from the underlying surface.
 748        */
 749       if (image->aspects & VK_IMAGE_ASPECT_DEPTH_BIT) {
 750          return &image->depth_surface;
 751       } else {
 752          assert(image->aspects == VK_IMAGE_ASPECT_STENCIL_BIT);
 753          return &image->stencil_surface;
 754       }
 755     default:
 756        unreachable("image does not have aspect");
 757        return NULL;
 758    }
 759 }