2 * Mesa 3-D graphics library
4 * Copyright (C) 1999-2007 Brian Paul All Rights Reserved.
6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"),
8 * to deal in the Software without restriction, including without limitation
9 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10 * and/or sell copies of the Software, and to permit persons to whom the
11 * Software is furnished to do so, subject to the following conditions:
13 * The above copyright notice and this permission notice shall be included
14 * in all copies or substantial portions of the Software.
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
17 * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
20 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
21 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
22 * OTHER DEALINGS IN THE SOFTWARE.
27 #include "api_validate.h"
28 #include "bufferobj.h"
34 #include "transformfeedback.h"
39 * Check if OK to draw arrays/elements.
42 check_valid_to_render(struct gl_context
*ctx
, const char *function
)
44 if (!_mesa_valid_to_render(ctx
, function
)) {
50 /* For ES2, we can draw if we have a vertex program/shader). */
51 return ctx
->VertexProgram
._Current
!= NULL
;
54 /* For OpenGL ES, only draw if we have vertex positions
56 if (!ctx
->Array
.VAO
->VertexAttrib
[VERT_ATTRIB_POS
].Enabled
)
61 /* Section 10.4 (Drawing Commands Using Vertex Arrays) of the OpenGL 4.5
62 * Core Profile spec says:
64 * "An INVALID_OPERATION error is generated if no vertex array
65 * object is bound (see section 10.3.1)."
67 if (ctx
->Array
.VAO
== ctx
->Array
.DefaultVAO
) {
68 _mesa_error(ctx
, GL_INVALID_OPERATION
, "%s(no VAO bound)", function
);
72 /* The spec argues that this is allowed because a tess ctrl shader
73 * without a tess eval shader can be used with transform feedback.
74 * However, glBeginTransformFeedback doesn't allow GL_PATCHES and
75 * therefore doesn't allow tessellation.
77 * Further investigation showed that this is indeed a spec bug and
78 * a tess ctrl shader without a tess eval shader shouldn't have been
79 * allowed, because there is no API in GL 4.0 that can make use this
80 * to produce something useful.
82 * Also, all vendors except one don't support a tess ctrl shader without
83 * a tess eval shader anyway.
85 if (ctx
->TessCtrlProgram
._Current
&& !ctx
->TessEvalProgram
._Current
) {
86 _mesa_error(ctx
, GL_INVALID_OPERATION
,
87 "%s(tess eval shader is missing)", function
);
91 /* Section 7.3 (Program Objects) of the OpenGL 4.5 Core Profile spec
94 * "If there is no active program for the vertex or fragment shader
95 * stages, the results of vertex and/or fragment processing will be
96 * undefined. However, this is not an error."
98 * The fragment shader is not tested here because other state (e.g.,
99 * GL_RASTERIZER_DISCARD) affects whether or not we actually care.
101 return ctx
->VertexProgram
._Current
!= NULL
;
103 case API_OPENGL_COMPAT
:
104 if (ctx
->VertexProgram
._Current
!= NULL
) {
105 /* Draw regardless of whether or not we have any vertex arrays.
106 * (Ex: could draw a point using a constant vertex pos)
110 /* Draw if we have vertex positions (GL_VERTEX_ARRAY or generic
113 return (ctx
->Array
.VAO
->VertexAttrib
[VERT_ATTRIB_POS
].Enabled
||
114 ctx
->Array
.VAO
->VertexAttrib
[VERT_ATTRIB_GENERIC0
].Enabled
);
119 unreachable("Invalid API value in check_valid_to_render()");
127 * Is 'mode' a valid value for glBegin(), glDrawArrays(), glDrawElements(),
128 * etc? The set of legal values depends on whether geometry shaders/programs
130 * Note: This may be called during display list compilation.
133 _mesa_is_valid_prim_mode(struct gl_context
*ctx
, GLenum mode
)
135 /* The overwhelmingly common case is (mode <= GL_TRIANGLE_FAN). Test that
136 * first and exit. You would think that a switch-statement would be the
137 * right approach, but at least GCC 4.7.2 generates some pretty dire code
138 * for the common case.
140 if (likely(mode
<= GL_TRIANGLE_FAN
))
143 if (mode
<= GL_POLYGON
)
144 return (ctx
->API
== API_OPENGL_COMPAT
);
146 if (mode
<= GL_TRIANGLE_STRIP_ADJACENCY
)
147 return _mesa_has_geometry_shaders(ctx
);
149 if (mode
== GL_PATCHES
)
150 return _mesa_has_tessellation(ctx
);
157 * Is 'mode' a valid value for glBegin(), glDrawArrays(), glDrawElements(),
158 * etc? Also, do additional checking related to transformation feedback.
159 * Note: this function cannot be called during glNewList(GL_COMPILE) because
160 * this code depends on current transform feedback state.
161 * Also, do additional checking related to tessellation shaders.
164 _mesa_valid_prim_mode(struct gl_context
*ctx
, GLenum mode
, const char *name
)
166 bool valid_enum
= _mesa_is_valid_prim_mode(ctx
, mode
);
169 _mesa_error(ctx
, GL_INVALID_ENUM
, "%s(mode=%x)", name
, mode
);
173 /* From the OpenGL 4.5 specification, section 11.3.1:
175 * The error INVALID_OPERATION is generated if Begin, or any command that
176 * implicitly calls Begin, is called when a geometry shader is active and:
178 * * the input primitive type of the current geometry shader is
179 * POINTS and <mode> is not POINTS,
181 * * the input primitive type of the current geometry shader is
182 * LINES and <mode> is not LINES, LINE_STRIP, or LINE_LOOP,
184 * * the input primitive type of the current geometry shader is
185 * TRIANGLES and <mode> is not TRIANGLES, TRIANGLE_STRIP or
188 * * the input primitive type of the current geometry shader is
189 * LINES_ADJACENCY_ARB and <mode> is not LINES_ADJACENCY_ARB or
190 * LINE_STRIP_ADJACENCY_ARB, or
192 * * the input primitive type of the current geometry shader is
193 * TRIANGLES_ADJACENCY_ARB and <mode> is not
194 * TRIANGLES_ADJACENCY_ARB or TRIANGLE_STRIP_ADJACENCY_ARB.
196 * The GL spec doesn't mention any interaction with tessellation, which
197 * is clearly a spec bug. The same rule should apply, but instead of
198 * the draw primitive mode, the tessellation evaluation shader primitive
199 * mode should be used for the checking.
201 if (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]) {
202 const GLenum geom_mode
=
203 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]->Geom
.InputType
;
204 struct gl_shader_program
*tes
=
205 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
];
206 GLenum mode_before_gs
= mode
;
209 struct gl_shader
*tes_sh
= tes
->_LinkedShaders
[MESA_SHADER_TESS_EVAL
];
210 if (tes_sh
->TessEval
.PointMode
)
211 mode_before_gs
= GL_POINTS
;
212 else if (tes_sh
->TessEval
.PrimitiveMode
== GL_ISOLINES
)
213 mode_before_gs
= GL_LINES
;
215 /* the GL_QUADS mode generates triangles too */
216 mode_before_gs
= GL_TRIANGLES
;
219 switch (mode_before_gs
) {
221 valid_enum
= (geom_mode
== GL_POINTS
);
226 valid_enum
= (geom_mode
== GL_LINES
);
229 case GL_TRIANGLE_STRIP
:
230 case GL_TRIANGLE_FAN
:
231 valid_enum
= (geom_mode
== GL_TRIANGLES
);
238 case GL_LINES_ADJACENCY
:
239 case GL_LINE_STRIP_ADJACENCY
:
240 valid_enum
= (geom_mode
== GL_LINES_ADJACENCY
);
242 case GL_TRIANGLES_ADJACENCY
:
243 case GL_TRIANGLE_STRIP_ADJACENCY
:
244 valid_enum
= (geom_mode
== GL_TRIANGLES_ADJACENCY
);
251 _mesa_error(ctx
, GL_INVALID_OPERATION
,
252 "%s(mode=%s vs geometry shader input %s)",
254 _mesa_lookup_prim_by_nr(mode_before_gs
),
255 _mesa_lookup_prim_by_nr(geom_mode
));
260 /* From the OpenGL 4.0 (Core Profile) spec (section 2.12):
262 * "Tessellation operates only on patch primitives. If tessellation is
263 * active, any command that transfers vertices to the GL will
264 * generate an INVALID_OPERATION error if the primitive mode is not
266 * Patch primitives are not supported by pipeline stages below the
267 * tessellation evaluation shader. If there is no active program
268 * object or the active program object does not contain a tessellation
269 * evaluation shader, the error INVALID_OPERATION is generated by any
270 * command that transfers vertices to the GL if the primitive mode is
274 if (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
] ||
275 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_CTRL
]) {
276 if (mode
!= GL_PATCHES
) {
277 _mesa_error(ctx
, GL_INVALID_OPERATION
,
278 "only GL_PATCHES valid with tessellation");
283 if (mode
== GL_PATCHES
) {
284 _mesa_error(ctx
, GL_INVALID_OPERATION
,
285 "GL_PATCHES only valid with tessellation");
290 /* From the GL_EXT_transform_feedback spec:
292 * "The error INVALID_OPERATION is generated if Begin, or any command
293 * that performs an explicit Begin, is called when:
295 * * a geometry shader is not active and <mode> does not match the
296 * allowed begin modes for the current transform feedback state as
297 * given by table X.1.
299 * * a geometry shader is active and the output primitive type of the
300 * geometry shader does not match the allowed begin modes for the
301 * current transform feedback state as given by table X.1.
304 if (_mesa_is_xfb_active_and_unpaused(ctx
)) {
305 GLboolean pass
= GL_TRUE
;
307 if(ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]) {
308 switch (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]->Geom
.OutputType
) {
310 pass
= ctx
->TransformFeedback
.Mode
== GL_POINTS
;
313 pass
= ctx
->TransformFeedback
.Mode
== GL_LINES
;
315 case GL_TRIANGLE_STRIP
:
316 pass
= ctx
->TransformFeedback
.Mode
== GL_TRIANGLES
;
322 else if (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
]) {
323 struct gl_shader_program
*tes
=
324 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
];
325 struct gl_shader
*tes_sh
= tes
->_LinkedShaders
[MESA_SHADER_TESS_EVAL
];
326 if (tes_sh
->TessEval
.PointMode
)
327 pass
= ctx
->TransformFeedback
.Mode
== GL_POINTS
;
328 else if (tes_sh
->TessEval
.PrimitiveMode
== GL_ISOLINES
)
329 pass
= ctx
->TransformFeedback
.Mode
== GL_LINES
;
331 pass
= ctx
->TransformFeedback
.Mode
== GL_TRIANGLES
;
336 pass
= ctx
->TransformFeedback
.Mode
== GL_POINTS
;
341 pass
= ctx
->TransformFeedback
.Mode
== GL_LINES
;
344 pass
= ctx
->TransformFeedback
.Mode
== GL_TRIANGLES
;
349 _mesa_error(ctx
, GL_INVALID_OPERATION
,
350 "%s(mode=%s vs transform feedback %s)",
352 _mesa_lookup_prim_by_nr(mode
),
353 _mesa_lookup_prim_by_nr(ctx
->TransformFeedback
.Mode
));
362 * Verify that the element type is valid.
364 * Generates \c GL_INVALID_ENUM and returns \c false if it is not.
367 valid_elements_type(struct gl_context
*ctx
, GLenum type
, const char *name
)
370 case GL_UNSIGNED_BYTE
:
371 case GL_UNSIGNED_SHORT
:
372 case GL_UNSIGNED_INT
:
376 _mesa_error(ctx
, GL_INVALID_ENUM
, "%s(type = %s)", name
,
377 _mesa_enum_to_string(type
));
383 validate_DrawElements_common(struct gl_context
*ctx
,
384 GLenum mode
, GLsizei count
, GLenum type
,
385 const GLvoid
*indices
,
388 /* From the GLES3 specification, section 2.14.2 (Transform Feedback
389 * Primitive Capture):
391 * The error INVALID_OPERATION is also generated by DrawElements,
392 * DrawElementsInstanced, and DrawRangeElements while transform feedback
393 * is active and not paused, regardless of mode.
395 if (_mesa_is_gles3(ctx
) && !ctx
->Extensions
.OES_geometry_shader
&&
396 _mesa_is_xfb_active_and_unpaused(ctx
)) {
397 _mesa_error(ctx
, GL_INVALID_OPERATION
,
398 "%s(transform feedback active)", caller
);
403 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(count)", caller
);
407 if (!_mesa_valid_prim_mode(ctx
, mode
, caller
)) {
411 if (!valid_elements_type(ctx
, type
, caller
))
414 if (!check_valid_to_render(ctx
, caller
))
417 /* Not using a VBO for indices, so avoid NULL pointer derefs later.
419 if (!_mesa_is_bufferobj(ctx
->Array
.VAO
->IndexBufferObj
) && indices
== NULL
)
429 * Error checking for glDrawElements(). Includes parameter checking
430 * and VBO bounds checking.
431 * \return GL_TRUE if OK to render, GL_FALSE if error found
434 _mesa_validate_DrawElements(struct gl_context
*ctx
,
435 GLenum mode
, GLsizei count
, GLenum type
,
436 const GLvoid
*indices
)
438 FLUSH_CURRENT(ctx
, 0);
440 return validate_DrawElements_common(ctx
, mode
, count
, type
, indices
,
446 * Error checking for glMultiDrawElements(). Includes parameter checking
447 * and VBO bounds checking.
448 * \return GL_TRUE if OK to render, GL_FALSE if error found
451 _mesa_validate_MultiDrawElements(struct gl_context
*ctx
,
452 GLenum mode
, const GLsizei
*count
,
453 GLenum type
, const GLvoid
* const *indices
,
458 FLUSH_CURRENT(ctx
, 0);
460 for (i
= 0; i
< primcount
; i
++) {
462 _mesa_error(ctx
, GL_INVALID_VALUE
,
463 "glMultiDrawElements(count)" );
468 if (!_mesa_valid_prim_mode(ctx
, mode
, "glMultiDrawElements")) {
472 if (!valid_elements_type(ctx
, type
, "glMultiDrawElements"))
475 if (!check_valid_to_render(ctx
, "glMultiDrawElements"))
478 /* Not using a VBO for indices, so avoid NULL pointer derefs later.
480 if (!_mesa_is_bufferobj(ctx
->Array
.VAO
->IndexBufferObj
)) {
481 for (i
= 0; i
< primcount
; i
++) {
492 * Error checking for glDrawRangeElements(). Includes parameter checking
493 * and VBO bounds checking.
494 * \return GL_TRUE if OK to render, GL_FALSE if error found
497 _mesa_validate_DrawRangeElements(struct gl_context
*ctx
, GLenum mode
,
498 GLuint start
, GLuint end
,
499 GLsizei count
, GLenum type
,
500 const GLvoid
*indices
)
502 FLUSH_CURRENT(ctx
, 0);
505 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawRangeElements(end<start)");
509 return validate_DrawElements_common(ctx
, mode
, count
, type
, indices
,
510 "glDrawRangeElements");
515 * Called from the tnl module to error check the function parameters and
516 * verify that we really can draw something.
517 * \return GL_TRUE if OK to render, GL_FALSE if error found
520 _mesa_validate_DrawArrays(struct gl_context
*ctx
, GLenum mode
, GLsizei count
)
522 struct gl_transform_feedback_object
*xfb_obj
523 = ctx
->TransformFeedback
.CurrentObject
;
524 FLUSH_CURRENT(ctx
, 0);
527 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawArrays(count)" );
531 if (!_mesa_valid_prim_mode(ctx
, mode
, "glDrawArrays")) {
535 if (!check_valid_to_render(ctx
, "glDrawArrays"))
538 /* From the GLES3 specification, section 2.14.2 (Transform Feedback
539 * Primitive Capture):
541 * The error INVALID_OPERATION is generated by DrawArrays and
542 * DrawArraysInstanced if recording the vertices of a primitive to the
543 * buffer objects being used for transform feedback purposes would result
544 * in either exceeding the limits of any buffer object’s size, or in
545 * exceeding the end position offset + size − 1, as set by
548 * This is in contrast to the behaviour of desktop GL, where the extra
549 * primitives are silently dropped from the transform feedback buffer.
551 if (_mesa_is_gles3(ctx
) && _mesa_is_xfb_active_and_unpaused(ctx
)) {
552 size_t prim_count
= vbo_count_tessellated_primitives(mode
, count
, 1);
553 if (xfb_obj
->GlesRemainingPrims
< prim_count
) {
554 _mesa_error(ctx
, GL_INVALID_OPERATION
,
555 "glDrawArrays(exceeds transform feedback size)");
558 xfb_obj
->GlesRemainingPrims
-= prim_count
;
569 _mesa_validate_DrawArraysInstanced(struct gl_context
*ctx
, GLenum mode
, GLint first
,
570 GLsizei count
, GLsizei numInstances
)
572 struct gl_transform_feedback_object
*xfb_obj
573 = ctx
->TransformFeedback
.CurrentObject
;
574 FLUSH_CURRENT(ctx
, 0);
577 _mesa_error(ctx
, GL_INVALID_VALUE
,
578 "glDrawArraysInstanced(count=%d)", count
);
583 _mesa_error(ctx
, GL_INVALID_VALUE
,
584 "glDrawArraysInstanced(start=%d)", first
);
588 if (!_mesa_valid_prim_mode(ctx
, mode
, "glDrawArraysInstanced")) {
592 if (numInstances
<= 0) {
593 if (numInstances
< 0)
594 _mesa_error(ctx
, GL_INVALID_VALUE
,
595 "glDrawArraysInstanced(numInstances=%d)", numInstances
);
599 if (!check_valid_to_render(ctx
, "glDrawArraysInstanced(invalid to render)"))
602 /* From the GLES3 specification, section 2.14.2 (Transform Feedback
603 * Primitive Capture):
605 * The error INVALID_OPERATION is generated by DrawArrays and
606 * DrawArraysInstanced if recording the vertices of a primitive to the
607 * buffer objects being used for transform feedback purposes would result
608 * in either exceeding the limits of any buffer object’s size, or in
609 * exceeding the end position offset + size − 1, as set by
612 * This is in contrast to the behaviour of desktop GL, where the extra
613 * primitives are silently dropped from the transform feedback buffer.
615 if (_mesa_is_gles3(ctx
) && _mesa_is_xfb_active_and_unpaused(ctx
)) {
617 = vbo_count_tessellated_primitives(mode
, count
, numInstances
);
618 if (xfb_obj
->GlesRemainingPrims
< prim_count
) {
619 _mesa_error(ctx
, GL_INVALID_OPERATION
,
620 "glDrawArraysInstanced(exceeds transform feedback size)");
623 xfb_obj
->GlesRemainingPrims
-= prim_count
;
634 _mesa_validate_DrawElementsInstanced(struct gl_context
*ctx
,
635 GLenum mode
, GLsizei count
, GLenum type
,
636 const GLvoid
*indices
, GLsizei numInstances
)
638 FLUSH_CURRENT(ctx
, 0);
640 if (numInstances
< 0) {
641 _mesa_error(ctx
, GL_INVALID_VALUE
,
642 "glDrawElementsInstanced(numInstances=%d)", numInstances
);
646 return validate_DrawElements_common(ctx
, mode
, count
, type
, indices
,
647 "glDrawElementsInstanced")
648 && (numInstances
> 0);
653 _mesa_validate_DrawTransformFeedback(struct gl_context
*ctx
,
655 struct gl_transform_feedback_object
*obj
,
657 GLsizei numInstances
)
659 FLUSH_CURRENT(ctx
, 0);
661 if (!_mesa_valid_prim_mode(ctx
, mode
, "glDrawTransformFeedback*(mode)")) {
666 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawTransformFeedback*(name)");
670 /* From the GL 4.5 specification, page 429:
671 * "An INVALID_VALUE error is generated if id is not the name of a
672 * transform feedback object."
674 if (!obj
->EverBound
) {
675 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawTransformFeedback*(name)");
679 if (stream
>= ctx
->Const
.MaxVertexStreams
) {
680 _mesa_error(ctx
, GL_INVALID_VALUE
,
681 "glDrawTransformFeedbackStream*(index>=MaxVertexStream)");
685 if (!obj
->EndedAnytime
) {
686 _mesa_error(ctx
, GL_INVALID_OPERATION
, "glDrawTransformFeedback*");
690 if (numInstances
<= 0) {
691 if (numInstances
< 0)
692 _mesa_error(ctx
, GL_INVALID_VALUE
,
693 "glDrawTransformFeedback*Instanced(numInstances=%d)",
698 if (!check_valid_to_render(ctx
, "glDrawTransformFeedback*")) {
706 valid_draw_indirect(struct gl_context
*ctx
,
707 GLenum mode
, const GLvoid
*indirect
,
708 GLsizei size
, const char *name
)
710 const uint64_t end
= (uint64_t) (uintptr_t) indirect
+ size
;
712 /* OpenGL ES 3.1 spec. section 10.5:
714 * "DrawArraysIndirect requires that all data sourced for the
715 * command, including the DrawArraysIndirectCommand
716 * structure, be in buffer objects, and may not be called when
717 * the default vertex array object is bound."
719 if (ctx
->Array
.VAO
== ctx
->Array
.DefaultVAO
) {
720 _mesa_error(ctx
, GL_INVALID_OPERATION
, "(no VAO bound)");
724 /* From OpenGL ES 3.1 spec. section 10.5:
725 * "An INVALID_OPERATION error is generated if zero is bound to
726 * VERTEX_ARRAY_BINDING, DRAW_INDIRECT_BUFFER or to any enabled
729 * Here we check that for each enabled vertex array we have a vertex
732 if (_mesa_is_gles31(ctx
) &&
733 ctx
->Array
.VAO
->_Enabled
!= ctx
->Array
.VAO
->VertexAttribBufferMask
) {
734 _mesa_error(ctx
, GL_INVALID_OPERATION
, "%s(No VBO bound)", name
);
738 if (!_mesa_valid_prim_mode(ctx
, mode
, name
))
741 /* OpenGL ES 3.1 specification, section 10.5:
743 * "An INVALID_OPERATION error is generated if
744 * transform feedback is active and not paused."
746 if (_mesa_is_gles31(ctx
) && !ctx
->Extensions
.OES_geometry_shader
&&
747 _mesa_is_xfb_active_and_unpaused(ctx
)) {
748 _mesa_error(ctx
, GL_INVALID_OPERATION
,
749 "%s(TransformFeedback is active and not paused)", name
);
752 /* From OpenGL version 4.4. section 10.5
753 * and OpenGL ES 3.1, section 10.6:
755 * "An INVALID_VALUE error is generated if indirect is not a
756 * multiple of the size, in basic machine units, of uint."
758 if ((GLsizeiptr
)indirect
& (sizeof(GLuint
) - 1)) {
759 _mesa_error(ctx
, GL_INVALID_VALUE
,
760 "%s(indirect is not aligned)", name
);
764 if (!_mesa_is_bufferobj(ctx
->DrawIndirectBuffer
)) {
765 _mesa_error(ctx
, GL_INVALID_OPERATION
,
766 "%s: no buffer bound to DRAW_INDIRECT_BUFFER", name
);
770 if (_mesa_check_disallowed_mapping(ctx
->DrawIndirectBuffer
)) {
771 _mesa_error(ctx
, GL_INVALID_OPERATION
,
772 "%s(DRAW_INDIRECT_BUFFER is mapped)", name
);
776 /* From the ARB_draw_indirect specification:
777 * "An INVALID_OPERATION error is generated if the commands source data
778 * beyond the end of the buffer object [...]"
780 if (ctx
->DrawIndirectBuffer
->Size
< end
) {
781 _mesa_error(ctx
, GL_INVALID_OPERATION
,
782 "%s(DRAW_INDIRECT_BUFFER too small)", name
);
786 if (!check_valid_to_render(ctx
, name
))
792 static inline GLboolean
793 valid_draw_indirect_elements(struct gl_context
*ctx
,
794 GLenum mode
, GLenum type
, const GLvoid
*indirect
,
795 GLsizeiptr size
, const char *name
)
797 if (!valid_elements_type(ctx
, type
, name
))
801 * Unlike regular DrawElementsInstancedBaseVertex commands, the indices
802 * may not come from a client array and must come from an index buffer.
803 * If no element array buffer is bound, an INVALID_OPERATION error is
806 if (!_mesa_is_bufferobj(ctx
->Array
.VAO
->IndexBufferObj
)) {
807 _mesa_error(ctx
, GL_INVALID_OPERATION
,
808 "%s(no buffer bound to GL_ELEMENT_ARRAY_BUFFER)", name
);
812 return valid_draw_indirect(ctx
, mode
, indirect
, size
, name
);
815 static inline GLboolean
816 valid_draw_indirect_multi(struct gl_context
*ctx
,
817 GLsizei primcount
, GLsizei stride
,
821 /* From the ARB_multi_draw_indirect specification:
822 * "INVALID_VALUE is generated by MultiDrawArraysIndirect or
823 * MultiDrawElementsIndirect if <primcount> is negative."
825 * "<primcount> must be positive, otherwise an INVALID_VALUE error will
829 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(primcount < 0)", name
);
834 /* From the ARB_multi_draw_indirect specification:
835 * "<stride> must be a multiple of four, otherwise an INVALID_VALUE
836 * error is generated."
839 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(stride %% 4)", name
);
847 _mesa_validate_DrawArraysIndirect(struct gl_context
*ctx
,
849 const GLvoid
*indirect
)
851 const unsigned drawArraysNumParams
= 4;
853 FLUSH_CURRENT(ctx
, 0);
855 return valid_draw_indirect(ctx
, mode
,
856 indirect
, drawArraysNumParams
* sizeof(GLuint
),
857 "glDrawArraysIndirect");
861 _mesa_validate_DrawElementsIndirect(struct gl_context
*ctx
,
862 GLenum mode
, GLenum type
,
863 const GLvoid
*indirect
)
865 const unsigned drawElementsNumParams
= 5;
867 FLUSH_CURRENT(ctx
, 0);
869 return valid_draw_indirect_elements(ctx
, mode
, type
,
870 indirect
, drawElementsNumParams
* sizeof(GLuint
),
871 "glDrawElementsIndirect");
875 _mesa_validate_MultiDrawArraysIndirect(struct gl_context
*ctx
,
877 const GLvoid
*indirect
,
878 GLsizei primcount
, GLsizei stride
)
881 const unsigned drawArraysNumParams
= 4;
883 FLUSH_CURRENT(ctx
, 0);
885 /* caller has converted stride==0 to drawArraysNumParams * sizeof(GLuint) */
888 if (!valid_draw_indirect_multi(ctx
, primcount
, stride
,
889 "glMultiDrawArraysIndirect"))
892 /* number of bytes of the indirect buffer which will be read */
894 ? (primcount
- 1) * stride
+ drawArraysNumParams
* sizeof(GLuint
)
897 if (!valid_draw_indirect(ctx
, mode
, indirect
, size
,
898 "glMultiDrawArraysIndirect"))
905 _mesa_validate_MultiDrawElementsIndirect(struct gl_context
*ctx
,
906 GLenum mode
, GLenum type
,
907 const GLvoid
*indirect
,
908 GLsizei primcount
, GLsizei stride
)
911 const unsigned drawElementsNumParams
= 5;
913 FLUSH_CURRENT(ctx
, 0);
915 /* caller has converted stride==0 to drawElementsNumParams * sizeof(GLuint) */
918 if (!valid_draw_indirect_multi(ctx
, primcount
, stride
,
919 "glMultiDrawElementsIndirect"))
922 /* number of bytes of the indirect buffer which will be read */
924 ? (primcount
- 1) * stride
+ drawElementsNumParams
* sizeof(GLuint
)
927 if (!valid_draw_indirect_elements(ctx
, mode
, type
,
929 "glMultiDrawElementsIndirect"))
936 valid_draw_indirect_parameters(struct gl_context
*ctx
,
940 /* From the ARB_indirect_parameters specification:
941 * "INVALID_VALUE is generated by MultiDrawArraysIndirectCountARB or
942 * MultiDrawElementsIndirectCountARB if <drawcount> is not a multiple of
946 _mesa_error(ctx
, GL_INVALID_VALUE
,
947 "%s(drawcount is not a multiple of 4)", name
);
951 /* From the ARB_indirect_parameters specification:
952 * "INVALID_OPERATION is generated by MultiDrawArraysIndirectCountARB or
953 * MultiDrawElementsIndirectCountARB if no buffer is bound to the
954 * PARAMETER_BUFFER_ARB binding point."
956 if (!_mesa_is_bufferobj(ctx
->ParameterBuffer
)) {
957 _mesa_error(ctx
, GL_INVALID_OPERATION
,
958 "%s: no buffer bound to PARAMETER_BUFFER", name
);
962 if (_mesa_check_disallowed_mapping(ctx
->ParameterBuffer
)) {
963 _mesa_error(ctx
, GL_INVALID_OPERATION
,
964 "%s(PARAMETER_BUFFER is mapped)", name
);
968 /* From the ARB_indirect_parameters specification:
969 * "INVALID_OPERATION is generated by MultiDrawArraysIndirectCountARB or
970 * MultiDrawElementsIndirectCountARB if reading a <sizei> typed value
971 * from the buffer bound to the PARAMETER_BUFFER_ARB target at the offset
972 * specified by <drawcount> would result in an out-of-bounds access."
974 if (ctx
->ParameterBuffer
->Size
< drawcount
+ sizeof(GLsizei
)) {
975 _mesa_error(ctx
, GL_INVALID_OPERATION
,
976 "%s(PARAMETER_BUFFER too small)", name
);
984 _mesa_validate_MultiDrawArraysIndirectCount(struct gl_context
*ctx
,
988 GLsizei maxdrawcount
,
992 const unsigned drawArraysNumParams
= 4;
994 FLUSH_CURRENT(ctx
, 0);
996 /* caller has converted stride==0 to drawArraysNumParams * sizeof(GLuint) */
999 if (!valid_draw_indirect_multi(ctx
, maxdrawcount
, stride
,
1000 "glMultiDrawArraysIndirectCountARB"))
1003 /* number of bytes of the indirect buffer which will be read */
1005 ? (maxdrawcount
- 1) * stride
+ drawArraysNumParams
* sizeof(GLuint
)
1008 if (!valid_draw_indirect(ctx
, mode
, (void *)indirect
, size
,
1009 "glMultiDrawArraysIndirectCountARB"))
1012 return valid_draw_indirect_parameters(
1013 ctx
, "glMultiDrawArraysIndirectCountARB", drawcount
);
1017 _mesa_validate_MultiDrawElementsIndirectCount(struct gl_context
*ctx
,
1018 GLenum mode
, GLenum type
,
1021 GLsizei maxdrawcount
,
1024 GLsizeiptr size
= 0;
1025 const unsigned drawElementsNumParams
= 5;
1027 FLUSH_CURRENT(ctx
, 0);
1029 /* caller has converted stride==0 to drawElementsNumParams * sizeof(GLuint) */
1030 assert(stride
!= 0);
1032 if (!valid_draw_indirect_multi(ctx
, maxdrawcount
, stride
,
1033 "glMultiDrawElementsIndirectCountARB"))
1036 /* number of bytes of the indirect buffer which will be read */
1038 ? (maxdrawcount
- 1) * stride
+ drawElementsNumParams
* sizeof(GLuint
)
1041 if (!valid_draw_indirect_elements(ctx
, mode
, type
,
1042 (void *)indirect
, size
,
1043 "glMultiDrawElementsIndirectCountARB"))
1046 return valid_draw_indirect_parameters(
1047 ctx
, "glMultiDrawElementsIndirectCountARB", drawcount
);
1051 check_valid_to_compute(struct gl_context
*ctx
, const char *function
)
1053 struct gl_shader_program
*prog
;
1055 if (!_mesa_has_compute_shaders(ctx
)) {
1056 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1057 "unsupported function (%s) called",
1062 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1064 * "An INVALID_OPERATION error is generated if there is no active program
1065 * for the compute shader stage."
1067 prog
= ctx
->_Shader
->CurrentProgram
[MESA_SHADER_COMPUTE
];
1068 if (prog
== NULL
|| prog
->_LinkedShaders
[MESA_SHADER_COMPUTE
] == NULL
) {
1069 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1070 "%s(no active compute shader)",
1079 _mesa_validate_DispatchCompute(struct gl_context
*ctx
,
1080 const GLuint
*num_groups
)
1083 FLUSH_CURRENT(ctx
, 0);
1085 if (!check_valid_to_compute(ctx
, "glDispatchCompute"))
1088 for (i
= 0; i
< 3; i
++) {
1089 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1091 * "An INVALID_VALUE error is generated if any of num_groups_x,
1092 * num_groups_y and num_groups_z are greater than or equal to the
1093 * maximum work group count for the corresponding dimension."
1095 * However, the "or equal to" portions appears to be a specification
1096 * bug. In all other areas, the specification appears to indicate that
1097 * the number of workgroups can match the MAX_COMPUTE_WORK_GROUP_COUNT
1098 * value. For example, under DispatchComputeIndirect:
1100 * "If any of num_groups_x, num_groups_y or num_groups_z is greater than
1101 * the value of MAX_COMPUTE_WORK_GROUP_COUNT for the corresponding
1102 * dimension then the results are undefined."
1104 * Additionally, the OpenGLES 3.1 specification does not contain "or
1105 * equal to" as an error condition.
1107 if (num_groups
[i
] > ctx
->Const
.MaxComputeWorkGroupCount
[i
]) {
1108 _mesa_error(ctx
, GL_INVALID_VALUE
,
1109 "glDispatchCompute(num_groups_%c)", 'x' + i
);
1118 valid_dispatch_indirect(struct gl_context
*ctx
,
1120 GLsizei size
, const char *name
)
1122 const uint64_t end
= (uint64_t) indirect
+ size
;
1124 if (!check_valid_to_compute(ctx
, name
))
1127 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1129 * "An INVALID_VALUE error is generated if indirect is negative or is not a
1130 * multiple of four."
1132 if (indirect
& (sizeof(GLuint
) - 1)) {
1133 _mesa_error(ctx
, GL_INVALID_VALUE
,
1134 "%s(indirect is not aligned)", name
);
1139 _mesa_error(ctx
, GL_INVALID_VALUE
,
1140 "%s(indirect is less than zero)", name
);
1144 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1146 * "An INVALID_OPERATION error is generated if no buffer is bound to the
1147 * DRAW_INDIRECT_BUFFER binding, or if the command would source data
1148 * beyond the end of the buffer object."
1150 if (!_mesa_is_bufferobj(ctx
->DispatchIndirectBuffer
)) {
1151 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1152 "%s: no buffer bound to DISPATCH_INDIRECT_BUFFER", name
);
1156 if (_mesa_check_disallowed_mapping(ctx
->DispatchIndirectBuffer
)) {
1157 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1158 "%s(DISPATCH_INDIRECT_BUFFER is mapped)", name
);
1162 if (ctx
->DispatchIndirectBuffer
->Size
< end
) {
1163 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1164 "%s(DISPATCH_INDIRECT_BUFFER too small)", name
);
1172 _mesa_validate_DispatchComputeIndirect(struct gl_context
*ctx
,
1175 FLUSH_CURRENT(ctx
, 0);
1177 return valid_dispatch_indirect(ctx
, indirect
, 3 * sizeof(GLuint
),
1178 "glDispatchComputeIndirect");