Fix an error in _mesa_validate_DrawElements
[mesa.git] / src / mesa / main / api_validate.c
1 /*
2 * Mesa 3-D graphics library
3 * Version: 7.0.1
4 *
5 * Copyright (C) 1999-2007 Brian Paul All Rights Reserved.
6 *
7 * Permission is hereby granted, free of charge, to any person obtaining a
8 * copy of this software and associated documentation files (the "Software"),
9 * to deal in the Software without restriction, including without limitation
10 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
11 * and/or sell copies of the Software, and to permit persons to whom the
12 * Software is furnished to do so, subject to the following conditions:
13 *
14 * The above copyright notice and this permission notice shall be included
15 * in all copies or substantial portions of the Software.
16 *
17 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
18 * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
20 * BRIAN PAUL BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
21 * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
22 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
23 */
24
25 #include "glheader.h"
26 #include "api_validate.h"
27 #include "context.h"
28 #include "imports.h"
29 #include "mtypes.h"
30 #include "state.h"
31
32
33 GLboolean
34 _mesa_validate_DrawElements(GLcontext *ctx,
35 GLenum mode, GLsizei count, GLenum type,
36 const GLvoid *indices)
37 {
38 GLboolean mapped = GL_FALSE;
39 ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE);
40
41 if (count <= 0) {
42 if (count < 0)
43 _mesa_error(ctx, GL_INVALID_VALUE, "glDrawElements(count)" );
44 return GL_FALSE;
45 }
46
47 if (mode > GL_POLYGON) {
48 _mesa_error(ctx, GL_INVALID_ENUM, "glDrawElements(mode)" );
49 return GL_FALSE;
50 }
51
52 if (type != GL_UNSIGNED_INT &&
53 type != GL_UNSIGNED_BYTE &&
54 type != GL_UNSIGNED_SHORT)
55 {
56 _mesa_error(ctx, GL_INVALID_ENUM, "glDrawElements(type)" );
57 return GL_FALSE;
58 }
59
60 if (ctx->NewState)
61 _mesa_update_state(ctx);
62
63 /* Always need vertex positions */
64 if (!ctx->Array.ArrayObj->Vertex.Enabled
65 && !(ctx->VertexProgram._Enabled && ctx->Array.ArrayObj->VertexAttrib[0].Enabled))
66 return GL_FALSE;
67
68 /* Vertex buffer object tests */
69 if (ctx->Array.ElementArrayBufferObj->Name) {
70 GLuint indexBytes;
71 const GLvoid *map = ctx->Driver.MapBuffer(ctx,
72 GL_ELEMENT_ARRAY_BUFFER_ARB,
73 GL_READ_ONLY,
74 ctx->Array.ElementArrayBufferObj);
75
76 /* use indices in the buffer object */
77 if (!map) {
78 _mesa_warning(ctx, "DrawElements with empty vertex elements buffer!");
79 return GL_FALSE;
80 }
81
82 mapped = GL_TRUE;
83
84 /* make sure count doesn't go outside buffer bounds */
85 if (type == GL_UNSIGNED_INT) {
86 indexBytes = count * sizeof(GLuint);
87 }
88 else if (type == GL_UNSIGNED_BYTE) {
89 indexBytes = count * sizeof(GLubyte);
90 }
91 else {
92 ASSERT(type == GL_UNSIGNED_SHORT);
93 indexBytes = count * sizeof(GLushort);
94 }
95
96 if (ADD_POINTERS(map, indices) + indexBytes >
97 (GLubyte *)map + ctx->Array.ElementArrayBufferObj->Size) {
98 _mesa_warning(ctx, "glDrawElements index out of buffer bounds");
99 ctx->Driver.UnmapBuffer(ctx,
100 GL_ELEMENT_ARRAY_BUFFER_ARB,
101 ctx->Array.ElementArrayBufferObj);
102 return GL_FALSE;
103 }
104
105 /* Actual address is the sum of pointers. Indices may be used below. */
106 if (ctx->Const.CheckArrayBounds) {
107 indices = ADD_POINTERS(map, indices);
108 }
109 }
110 else {
111 /* not using a VBO */
112 if (!indices)
113 return GL_FALSE;
114 }
115
116 if (ctx->Const.CheckArrayBounds) {
117 /* find max array index */
118 GLuint max = 0;
119 GLint i;
120 if (type == GL_UNSIGNED_INT) {
121 for (i = 0; i < count; i++)
122 if (((GLuint *) indices)[i] > max)
123 max = ((GLuint *) indices)[i];
124 }
125 else if (type == GL_UNSIGNED_SHORT) {
126 for (i = 0; i < count; i++)
127 if (((GLushort *) indices)[i] > max)
128 max = ((GLushort *) indices)[i];
129 }
130 else {
131 ASSERT(type == GL_UNSIGNED_BYTE);
132 for (i = 0; i < count; i++)
133 if (((GLubyte *) indices)[i] > max)
134 max = ((GLubyte *) indices)[i];
135 }
136
137 if (max >= ctx->Array._MaxElement) {
138 /* the max element is out of bounds of one or more enabled arrays */
139 if (mapped) {
140 ctx->Driver.UnmapBuffer(ctx,
141 GL_ELEMENT_ARRAY_BUFFER_ARB,
142 ctx->Array.ElementArrayBufferObj);
143 }
144
145 return GL_FALSE;
146 }
147 }
148
149 if (mapped) {
150 ctx->Driver.UnmapBuffer(ctx,
151 GL_ELEMENT_ARRAY_BUFFER_ARB,
152 ctx->Array.ElementArrayBufferObj);
153 }
154
155 return GL_TRUE;
156 }
157
158
159 GLboolean
160 _mesa_validate_DrawRangeElements(GLcontext *ctx, GLenum mode,
161 GLuint start, GLuint end,
162 GLsizei count, GLenum type,
163 const GLvoid *indices)
164 {
165 ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE);
166
167 if (count <= 0) {
168 if (count < 0)
169 _mesa_error(ctx, GL_INVALID_VALUE, "glDrawRangeElements(count)" );
170 return GL_FALSE;
171 }
172
173 if (mode > GL_POLYGON) {
174 _mesa_error(ctx, GL_INVALID_ENUM, "glDrawRangeElements(mode)" );
175 return GL_FALSE;
176 }
177
178 if (end < start) {
179 _mesa_error(ctx, GL_INVALID_VALUE, "glDrawRangeElements(end<start)");
180 return GL_FALSE;
181 }
182
183 if (type != GL_UNSIGNED_INT &&
184 type != GL_UNSIGNED_BYTE &&
185 type != GL_UNSIGNED_SHORT) {
186 _mesa_error(ctx, GL_INVALID_ENUM, "glDrawRangeElements(type)" );
187 return GL_FALSE;
188 }
189
190 if (ctx->NewState)
191 _mesa_update_state(ctx);
192
193 /* Always need vertex positions */
194 if (!ctx->Array.ArrayObj->Vertex.Enabled
195 && !(ctx->VertexProgram._Enabled && ctx->Array.ArrayObj->VertexAttrib[0].Enabled))
196 return GL_FALSE;
197
198 /* Vertex buffer object tests */
199 if (ctx->Array.ElementArrayBufferObj->Name) {
200 /* XXX re-use code from above? */
201 }
202 else {
203 /* not using VBO */
204 if (!indices)
205 return GL_FALSE;
206 }
207
208 if (ctx->Const.CheckArrayBounds) {
209 /* Find max array index.
210 * We don't trust the user's start and end values.
211 */
212 GLuint max = 0;
213 GLint i;
214 if (type == GL_UNSIGNED_INT) {
215 for (i = 0; i < count; i++)
216 if (((GLuint *) indices)[i] > max)
217 max = ((GLuint *) indices)[i];
218 }
219 else if (type == GL_UNSIGNED_SHORT) {
220 for (i = 0; i < count; i++)
221 if (((GLushort *) indices)[i] > max)
222 max = ((GLushort *) indices)[i];
223 }
224 else {
225 ASSERT(type == GL_UNSIGNED_BYTE);
226 for (i = 0; i < count; i++)
227 if (((GLubyte *) indices)[i] > max)
228 max = ((GLubyte *) indices)[i];
229 }
230 if (max >= ctx->Array._MaxElement) {
231 /* the max element is out of bounds of one or more enabled arrays */
232 return GL_FALSE;
233 }
234 }
235
236 return GL_TRUE;
237 }
238
239
240 /**
241 * Called from the tnl module to error check the function parameters and
242 * verify that we really can draw something.
243 */
244 GLboolean
245 _mesa_validate_DrawArrays(GLcontext *ctx,
246 GLenum mode, GLint start, GLsizei count)
247 {
248 ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE);
249
250 if (count < 0) {
251 _mesa_error(ctx, GL_INVALID_VALUE, "glDrawArrays(count)" );
252 return GL_FALSE;
253 }
254
255 if (mode > GL_POLYGON) {
256 _mesa_error(ctx, GL_INVALID_ENUM, "glDrawArrays(mode)" );
257 return GL_FALSE;
258 }
259
260 if (ctx->NewState)
261 _mesa_update_state(ctx);
262
263 /* Always need vertex positions */
264 if (!ctx->Array.ArrayObj->Vertex.Enabled && !ctx->Array.ArrayObj->VertexAttrib[0].Enabled)
265 return GL_FALSE;
266
267 if (ctx->Const.CheckArrayBounds) {
268 if (start + count > (GLint) ctx->Array._MaxElement)
269 return GL_FALSE;
270 }
271
272 return GL_TRUE;
273 }