2 * Mesa 3-D graphics library
4 * Copyright (C) 1999-2007 Brian Paul All Rights Reserved.
6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"),
8 * to deal in the Software without restriction, including without limitation
9 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10 * and/or sell copies of the Software, and to permit persons to whom the
11 * Software is furnished to do so, subject to the following conditions:
13 * The above copyright notice and this permission notice shall be included
14 * in all copies or substantial portions of the Software.
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
17 * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
20 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
21 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
22 * OTHER DEALINGS IN THE SOFTWARE.
27 #include "api_validate.h"
29 #include "bufferobj.h"
35 #include "transformfeedback.h"
39 * Check if OK to draw arrays/elements.
42 check_valid_to_render(struct gl_context
*ctx
, const char *function
)
44 if (!_mesa_valid_to_render(ctx
, function
)) {
48 if (!_mesa_all_buffers_are_unmapped(ctx
->Array
.VAO
)) {
49 _mesa_error(ctx
, GL_INVALID_OPERATION
,
50 "%s(vertex buffers are mapped)", function
);
56 /* For ES2, we can draw if we have a vertex program/shader). */
57 return ctx
->VertexProgram
._Current
!= NULL
;
60 /* For OpenGL ES, only draw if we have vertex positions
62 if (!ctx
->Array
.VAO
->VertexAttrib
[VERT_ATTRIB_POS
].Enabled
)
67 /* Section 10.4 (Drawing Commands Using Vertex Arrays) of the OpenGL 4.5
68 * Core Profile spec says:
70 * "An INVALID_OPERATION error is generated if no vertex array
71 * object is bound (see section 10.3.1)."
73 if (ctx
->Array
.VAO
== ctx
->Array
.DefaultVAO
) {
74 _mesa_error(ctx
, GL_INVALID_OPERATION
, "%s(no VAO bound)", function
);
78 /* The spec argues that this is allowed because a tess ctrl shader
79 * without a tess eval shader can be used with transform feedback.
80 * However, glBeginTransformFeedback doesn't allow GL_PATCHES and
81 * therefore doesn't allow tessellation.
83 * Further investigation showed that this is indeed a spec bug and
84 * a tess ctrl shader without a tess eval shader shouldn't have been
85 * allowed, because there is no API in GL 4.0 that can make use this
86 * to produce something useful.
88 * Also, all vendors except one don't support a tess ctrl shader without
89 * a tess eval shader anyway.
91 if (ctx
->TessCtrlProgram
._Current
&& !ctx
->TessEvalProgram
._Current
) {
92 _mesa_error(ctx
, GL_INVALID_OPERATION
,
93 "%s(tess eval shader is missing)", function
);
97 /* Section 7.3 (Program Objects) of the OpenGL 4.5 Core Profile spec
100 * "If there is no active program for the vertex or fragment shader
101 * stages, the results of vertex and/or fragment processing will be
102 * undefined. However, this is not an error."
104 * The fragment shader is not tested here because other state (e.g.,
105 * GL_RASTERIZER_DISCARD) affects whether or not we actually care.
107 return ctx
->VertexProgram
._Current
!= NULL
;
109 case API_OPENGL_COMPAT
:
110 if (ctx
->VertexProgram
._Current
!= NULL
) {
111 /* Draw regardless of whether or not we have any vertex arrays.
112 * (Ex: could draw a point using a constant vertex pos)
116 /* Draw if we have vertex positions (GL_VERTEX_ARRAY or generic
119 return (ctx
->Array
.VAO
->VertexAttrib
[VERT_ATTRIB_POS
].Enabled
||
120 ctx
->Array
.VAO
->VertexAttrib
[VERT_ATTRIB_GENERIC0
].Enabled
);
125 unreachable("Invalid API value in check_valid_to_render()");
133 * Is 'mode' a valid value for glBegin(), glDrawArrays(), glDrawElements(),
134 * etc? The set of legal values depends on whether geometry shaders/programs
136 * Note: This may be called during display list compilation.
139 _mesa_is_valid_prim_mode(struct gl_context
*ctx
, GLenum mode
)
141 /* The overwhelmingly common case is (mode <= GL_TRIANGLE_FAN). Test that
142 * first and exit. You would think that a switch-statement would be the
143 * right approach, but at least GCC 4.7.2 generates some pretty dire code
144 * for the common case.
146 if (likely(mode
<= GL_TRIANGLE_FAN
))
149 if (mode
<= GL_POLYGON
)
150 return (ctx
->API
== API_OPENGL_COMPAT
);
152 if (mode
<= GL_TRIANGLE_STRIP_ADJACENCY
)
153 return _mesa_has_geometry_shaders(ctx
);
155 if (mode
== GL_PATCHES
)
156 return _mesa_has_tessellation(ctx
);
163 * Is 'mode' a valid value for glBegin(), glDrawArrays(), glDrawElements(),
164 * etc? Also, do additional checking related to transformation feedback.
165 * Note: this function cannot be called during glNewList(GL_COMPILE) because
166 * this code depends on current transform feedback state.
167 * Also, do additional checking related to tessellation shaders.
170 _mesa_valid_prim_mode(struct gl_context
*ctx
, GLenum mode
, const char *name
)
172 bool valid_enum
= _mesa_is_valid_prim_mode(ctx
, mode
);
175 _mesa_error(ctx
, GL_INVALID_ENUM
, "%s(mode=%x)", name
, mode
);
179 /* From the OpenGL 4.5 specification, section 11.3.1:
181 * The error INVALID_OPERATION is generated if Begin, or any command that
182 * implicitly calls Begin, is called when a geometry shader is active and:
184 * * the input primitive type of the current geometry shader is
185 * POINTS and <mode> is not POINTS,
187 * * the input primitive type of the current geometry shader is
188 * LINES and <mode> is not LINES, LINE_STRIP, or LINE_LOOP,
190 * * the input primitive type of the current geometry shader is
191 * TRIANGLES and <mode> is not TRIANGLES, TRIANGLE_STRIP or
194 * * the input primitive type of the current geometry shader is
195 * LINES_ADJACENCY_ARB and <mode> is not LINES_ADJACENCY_ARB or
196 * LINE_STRIP_ADJACENCY_ARB, or
198 * * the input primitive type of the current geometry shader is
199 * TRIANGLES_ADJACENCY_ARB and <mode> is not
200 * TRIANGLES_ADJACENCY_ARB or TRIANGLE_STRIP_ADJACENCY_ARB.
202 * The GL spec doesn't mention any interaction with tessellation, which
203 * is clearly a spec bug. The same rule should apply, but instead of
204 * the draw primitive mode, the tessellation evaluation shader primitive
205 * mode should be used for the checking.
207 if (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]) {
208 const GLenum geom_mode
=
209 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]->
210 _LinkedShaders
[MESA_SHADER_GEOMETRY
]->info
.Geom
.InputType
;
211 struct gl_shader_program
*tes
=
212 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
];
213 GLenum mode_before_gs
= mode
;
216 struct gl_linked_shader
*tes_sh
=
217 tes
->_LinkedShaders
[MESA_SHADER_TESS_EVAL
];
218 if (tes_sh
->info
.TessEval
.PointMode
)
219 mode_before_gs
= GL_POINTS
;
220 else if (tes_sh
->info
.TessEval
.PrimitiveMode
== GL_ISOLINES
)
221 mode_before_gs
= GL_LINES
;
223 /* the GL_QUADS mode generates triangles too */
224 mode_before_gs
= GL_TRIANGLES
;
227 switch (mode_before_gs
) {
229 valid_enum
= (geom_mode
== GL_POINTS
);
234 valid_enum
= (geom_mode
== GL_LINES
);
237 case GL_TRIANGLE_STRIP
:
238 case GL_TRIANGLE_FAN
:
239 valid_enum
= (geom_mode
== GL_TRIANGLES
);
246 case GL_LINES_ADJACENCY
:
247 case GL_LINE_STRIP_ADJACENCY
:
248 valid_enum
= (geom_mode
== GL_LINES_ADJACENCY
);
250 case GL_TRIANGLES_ADJACENCY
:
251 case GL_TRIANGLE_STRIP_ADJACENCY
:
252 valid_enum
= (geom_mode
== GL_TRIANGLES_ADJACENCY
);
259 _mesa_error(ctx
, GL_INVALID_OPERATION
,
260 "%s(mode=%s vs geometry shader input %s)",
262 _mesa_lookup_prim_by_nr(mode_before_gs
),
263 _mesa_lookup_prim_by_nr(geom_mode
));
268 /* From the OpenGL 4.0 (Core Profile) spec (section 2.12):
270 * "Tessellation operates only on patch primitives. If tessellation is
271 * active, any command that transfers vertices to the GL will
272 * generate an INVALID_OPERATION error if the primitive mode is not
274 * Patch primitives are not supported by pipeline stages below the
275 * tessellation evaluation shader. If there is no active program
276 * object or the active program object does not contain a tessellation
277 * evaluation shader, the error INVALID_OPERATION is generated by any
278 * command that transfers vertices to the GL if the primitive mode is
282 if (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
] ||
283 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_CTRL
]) {
284 if (mode
!= GL_PATCHES
) {
285 _mesa_error(ctx
, GL_INVALID_OPERATION
,
286 "only GL_PATCHES valid with tessellation");
291 if (mode
== GL_PATCHES
) {
292 _mesa_error(ctx
, GL_INVALID_OPERATION
,
293 "GL_PATCHES only valid with tessellation");
298 /* From the GL_EXT_transform_feedback spec:
300 * "The error INVALID_OPERATION is generated if Begin, or any command
301 * that performs an explicit Begin, is called when:
303 * * a geometry shader is not active and <mode> does not match the
304 * allowed begin modes for the current transform feedback state as
305 * given by table X.1.
307 * * a geometry shader is active and the output primitive type of the
308 * geometry shader does not match the allowed begin modes for the
309 * current transform feedback state as given by table X.1.
312 if (_mesa_is_xfb_active_and_unpaused(ctx
)) {
313 GLboolean pass
= GL_TRUE
;
315 if(ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]) {
316 switch (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_GEOMETRY
]->
317 _LinkedShaders
[MESA_SHADER_GEOMETRY
]->
318 info
.Geom
.OutputType
) {
320 pass
= ctx
->TransformFeedback
.Mode
== GL_POINTS
;
323 pass
= ctx
->TransformFeedback
.Mode
== GL_LINES
;
325 case GL_TRIANGLE_STRIP
:
326 pass
= ctx
->TransformFeedback
.Mode
== GL_TRIANGLES
;
332 else if (ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
]) {
333 struct gl_shader_program
*tes
=
334 ctx
->_Shader
->CurrentProgram
[MESA_SHADER_TESS_EVAL
];
335 struct gl_linked_shader
*tes_sh
=
336 tes
->_LinkedShaders
[MESA_SHADER_TESS_EVAL
];
337 if (tes_sh
->info
.TessEval
.PointMode
)
338 pass
= ctx
->TransformFeedback
.Mode
== GL_POINTS
;
339 else if (tes_sh
->info
.TessEval
.PrimitiveMode
== GL_ISOLINES
)
340 pass
= ctx
->TransformFeedback
.Mode
== GL_LINES
;
342 pass
= ctx
->TransformFeedback
.Mode
== GL_TRIANGLES
;
347 pass
= ctx
->TransformFeedback
.Mode
== GL_POINTS
;
352 pass
= ctx
->TransformFeedback
.Mode
== GL_LINES
;
355 pass
= ctx
->TransformFeedback
.Mode
== GL_TRIANGLES
;
360 _mesa_error(ctx
, GL_INVALID_OPERATION
,
361 "%s(mode=%s vs transform feedback %s)",
363 _mesa_lookup_prim_by_nr(mode
),
364 _mesa_lookup_prim_by_nr(ctx
->TransformFeedback
.Mode
));
373 * Verify that the element type is valid.
375 * Generates \c GL_INVALID_ENUM and returns \c false if it is not.
378 valid_elements_type(struct gl_context
*ctx
, GLenum type
, const char *name
)
381 case GL_UNSIGNED_BYTE
:
382 case GL_UNSIGNED_SHORT
:
383 case GL_UNSIGNED_INT
:
387 _mesa_error(ctx
, GL_INVALID_ENUM
, "%s(type = %s)", name
,
388 _mesa_enum_to_string(type
));
394 validate_DrawElements_common(struct gl_context
*ctx
,
395 GLenum mode
, GLsizei count
, GLenum type
,
396 const GLvoid
*indices
,
399 /* Section 2.14.2 (Transform Feedback Primitive Capture) of the OpenGL ES
402 * The error INVALID_OPERATION is also generated by DrawElements,
403 * DrawElementsInstanced, and DrawRangeElements while transform feedback
404 * is active and not paused, regardless of mode.
406 * The OES_geometry_shader_spec says:
412 * (13) Does this extension change how transform feedback operates
413 * compared to unextended OpenGL ES 3.0 or 3.1?
415 * RESOLVED: Yes... Since we no longer require being able to predict how
416 * much geometry will be generated, we also lift the restriction that
417 * only DrawArray* commands are supported and also support the
418 * DrawElements* commands for transform feedback.
420 * This should also be reflected in the body of the spec, but that appears
421 * to have been overlooked. The body of the spec only explicitly allows
422 * the indirect versions.
424 if (_mesa_is_gles3(ctx
) && !ctx
->Extensions
.OES_geometry_shader
&&
425 _mesa_is_xfb_active_and_unpaused(ctx
)) {
426 _mesa_error(ctx
, GL_INVALID_OPERATION
,
427 "%s(transform feedback active)", caller
);
432 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(count)", caller
);
436 if (!_mesa_valid_prim_mode(ctx
, mode
, caller
)) {
440 if (!valid_elements_type(ctx
, type
, caller
))
443 if (!check_valid_to_render(ctx
, caller
))
446 /* Not using a VBO for indices, so avoid NULL pointer derefs later.
448 if (!_mesa_is_bufferobj(ctx
->Array
.VAO
->IndexBufferObj
) && indices
== NULL
)
458 * Error checking for glDrawElements(). Includes parameter checking
459 * and VBO bounds checking.
460 * \return GL_TRUE if OK to render, GL_FALSE if error found
463 _mesa_validate_DrawElements(struct gl_context
*ctx
,
464 GLenum mode
, GLsizei count
, GLenum type
,
465 const GLvoid
*indices
)
467 FLUSH_CURRENT(ctx
, 0);
469 return validate_DrawElements_common(ctx
, mode
, count
, type
, indices
,
475 * Error checking for glMultiDrawElements(). Includes parameter checking
476 * and VBO bounds checking.
477 * \return GL_TRUE if OK to render, GL_FALSE if error found
480 _mesa_validate_MultiDrawElements(struct gl_context
*ctx
,
481 GLenum mode
, const GLsizei
*count
,
482 GLenum type
, const GLvoid
* const *indices
,
487 FLUSH_CURRENT(ctx
, 0);
489 for (i
= 0; i
< primcount
; i
++) {
491 _mesa_error(ctx
, GL_INVALID_VALUE
,
492 "glMultiDrawElements(count)" );
497 if (!_mesa_valid_prim_mode(ctx
, mode
, "glMultiDrawElements")) {
501 if (!valid_elements_type(ctx
, type
, "glMultiDrawElements"))
504 if (!check_valid_to_render(ctx
, "glMultiDrawElements"))
507 /* Not using a VBO for indices, so avoid NULL pointer derefs later.
509 if (!_mesa_is_bufferobj(ctx
->Array
.VAO
->IndexBufferObj
)) {
510 for (i
= 0; i
< primcount
; i
++) {
521 * Error checking for glDrawRangeElements(). Includes parameter checking
522 * and VBO bounds checking.
523 * \return GL_TRUE if OK to render, GL_FALSE if error found
526 _mesa_validate_DrawRangeElements(struct gl_context
*ctx
, GLenum mode
,
527 GLuint start
, GLuint end
,
528 GLsizei count
, GLenum type
,
529 const GLvoid
*indices
)
531 FLUSH_CURRENT(ctx
, 0);
534 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawRangeElements(end<start)");
538 return validate_DrawElements_common(ctx
, mode
, count
, type
, indices
,
539 "glDrawRangeElements");
543 validate_draw_arrays(struct gl_context
*ctx
, const char *func
,
544 GLenum mode
, GLsizei count
, GLsizei numInstances
)
546 struct gl_transform_feedback_object
*xfb_obj
547 = ctx
->TransformFeedback
.CurrentObject
;
548 FLUSH_CURRENT(ctx
, 0);
551 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(count)", func
);
555 if (!_mesa_valid_prim_mode(ctx
, mode
, func
))
558 if (!check_valid_to_render(ctx
, func
))
561 /* From the GLES3 specification, section 2.14.2 (Transform Feedback
562 * Primitive Capture):
564 * The error INVALID_OPERATION is generated by DrawArrays and
565 * DrawArraysInstanced if recording the vertices of a primitive to the
566 * buffer objects being used for transform feedback purposes would result
567 * in either exceeding the limits of any buffer object’s size, or in
568 * exceeding the end position offset + size − 1, as set by
571 * This is in contrast to the behaviour of desktop GL, where the extra
572 * primitives are silently dropped from the transform feedback buffer.
574 * This text is removed in ES 3.2, presumably because it's not really
575 * implementable with geometry and tessellation shaders. In fact,
576 * the OES_geometry_shader spec says:
578 * "(13) Does this extension change how transform feedback operates
579 * compared to unextended OpenGL ES 3.0 or 3.1?
581 * RESOLVED: Yes. Because dynamic geometry amplification in a geometry
582 * shader can make it difficult if not impossible to predict the amount
583 * of geometry that may be generated in advance of executing the shader,
584 * the draw-time error for transform feedback buffer overflow conditions
585 * is removed and replaced with the GL behavior (primitives are not
586 * written and the corresponding counter is not updated)..."
588 if (_mesa_is_gles3(ctx
) && _mesa_is_xfb_active_and_unpaused(ctx
) &&
589 !_mesa_has_OES_geometry_shader(ctx
) &&
590 !_mesa_has_OES_tessellation_shader(ctx
)) {
591 size_t prim_count
= vbo_count_tessellated_primitives(mode
, count
, 1);
592 if (xfb_obj
->GlesRemainingPrims
< prim_count
) {
593 _mesa_error(ctx
, GL_INVALID_OPERATION
,
594 "%s(exceeds transform feedback size)", func
);
597 xfb_obj
->GlesRemainingPrims
-= prim_count
;
607 * Called from the tnl module to error check the function parameters and
608 * verify that we really can draw something.
609 * \return GL_TRUE if OK to render, GL_FALSE if error found
612 _mesa_validate_DrawArrays(struct gl_context
*ctx
, GLenum mode
, GLsizei count
)
614 return validate_draw_arrays(ctx
, "glDrawArrays", mode
, count
, 1);
619 _mesa_validate_DrawArraysInstanced(struct gl_context
*ctx
, GLenum mode
, GLint first
,
620 GLsizei count
, GLsizei numInstances
)
623 _mesa_error(ctx
, GL_INVALID_VALUE
,
624 "glDrawArraysInstanced(start=%d)", first
);
628 if (numInstances
<= 0) {
629 if (numInstances
< 0)
630 _mesa_error(ctx
, GL_INVALID_VALUE
,
631 "glDrawArraysInstanced(numInstances=%d)", numInstances
);
635 return validate_draw_arrays(ctx
, "glDrawArraysInstanced", mode
, count
, 1);
640 _mesa_validate_DrawElementsInstanced(struct gl_context
*ctx
,
641 GLenum mode
, GLsizei count
, GLenum type
,
642 const GLvoid
*indices
, GLsizei numInstances
)
644 FLUSH_CURRENT(ctx
, 0);
646 if (numInstances
< 0) {
647 _mesa_error(ctx
, GL_INVALID_VALUE
,
648 "glDrawElementsInstanced(numInstances=%d)", numInstances
);
652 return validate_DrawElements_common(ctx
, mode
, count
, type
, indices
,
653 "glDrawElementsInstanced")
654 && (numInstances
> 0);
659 _mesa_validate_DrawTransformFeedback(struct gl_context
*ctx
,
661 struct gl_transform_feedback_object
*obj
,
663 GLsizei numInstances
)
665 FLUSH_CURRENT(ctx
, 0);
667 if (!_mesa_valid_prim_mode(ctx
, mode
, "glDrawTransformFeedback*(mode)")) {
672 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawTransformFeedback*(name)");
676 /* From the GL 4.5 specification, page 429:
677 * "An INVALID_VALUE error is generated if id is not the name of a
678 * transform feedback object."
680 if (!obj
->EverBound
) {
681 _mesa_error(ctx
, GL_INVALID_VALUE
, "glDrawTransformFeedback*(name)");
685 if (stream
>= ctx
->Const
.MaxVertexStreams
) {
686 _mesa_error(ctx
, GL_INVALID_VALUE
,
687 "glDrawTransformFeedbackStream*(index>=MaxVertexStream)");
691 if (!obj
->EndedAnytime
) {
692 _mesa_error(ctx
, GL_INVALID_OPERATION
, "glDrawTransformFeedback*");
696 if (numInstances
<= 0) {
697 if (numInstances
< 0)
698 _mesa_error(ctx
, GL_INVALID_VALUE
,
699 "glDrawTransformFeedback*Instanced(numInstances=%d)",
704 if (!check_valid_to_render(ctx
, "glDrawTransformFeedback*")) {
712 valid_draw_indirect(struct gl_context
*ctx
,
713 GLenum mode
, const GLvoid
*indirect
,
714 GLsizei size
, const char *name
)
716 const uint64_t end
= (uint64_t) (uintptr_t) indirect
+ size
;
718 /* OpenGL ES 3.1 spec. section 10.5:
720 * "DrawArraysIndirect requires that all data sourced for the
721 * command, including the DrawArraysIndirectCommand
722 * structure, be in buffer objects, and may not be called when
723 * the default vertex array object is bound."
725 if (ctx
->Array
.VAO
== ctx
->Array
.DefaultVAO
) {
726 _mesa_error(ctx
, GL_INVALID_OPERATION
, "(no VAO bound)");
730 /* From OpenGL ES 3.1 spec. section 10.5:
731 * "An INVALID_OPERATION error is generated if zero is bound to
732 * VERTEX_ARRAY_BINDING, DRAW_INDIRECT_BUFFER or to any enabled
735 * Here we check that for each enabled vertex array we have a vertex
738 if (_mesa_is_gles31(ctx
) &&
739 ctx
->Array
.VAO
->_Enabled
!= ctx
->Array
.VAO
->VertexAttribBufferMask
) {
740 _mesa_error(ctx
, GL_INVALID_OPERATION
, "%s(No VBO bound)", name
);
744 if (!_mesa_valid_prim_mode(ctx
, mode
, name
))
747 /* OpenGL ES 3.1 specification, section 10.5:
749 * "An INVALID_OPERATION error is generated if
750 * transform feedback is active and not paused."
752 * The OES_geometry_shader spec says:
754 * On p. 250 in the errors section for the DrawArraysIndirect command,
755 * and on p. 254 in the errors section for the DrawElementsIndirect
756 * command, delete the errors which state:
758 * "An INVALID_OPERATION error is generated if transform feedback is
759 * active and not paused."
761 * (thus allowing transform feedback to work with indirect draw commands).
763 if (_mesa_is_gles31(ctx
) && !ctx
->Extensions
.OES_geometry_shader
&&
764 _mesa_is_xfb_active_and_unpaused(ctx
)) {
765 _mesa_error(ctx
, GL_INVALID_OPERATION
,
766 "%s(TransformFeedback is active and not paused)", name
);
769 /* From OpenGL version 4.4. section 10.5
770 * and OpenGL ES 3.1, section 10.6:
772 * "An INVALID_VALUE error is generated if indirect is not a
773 * multiple of the size, in basic machine units, of uint."
775 if ((GLsizeiptr
)indirect
& (sizeof(GLuint
) - 1)) {
776 _mesa_error(ctx
, GL_INVALID_VALUE
,
777 "%s(indirect is not aligned)", name
);
781 if (!_mesa_is_bufferobj(ctx
->DrawIndirectBuffer
)) {
782 _mesa_error(ctx
, GL_INVALID_OPERATION
,
783 "%s: no buffer bound to DRAW_INDIRECT_BUFFER", name
);
787 if (_mesa_check_disallowed_mapping(ctx
->DrawIndirectBuffer
)) {
788 _mesa_error(ctx
, GL_INVALID_OPERATION
,
789 "%s(DRAW_INDIRECT_BUFFER is mapped)", name
);
793 /* From the ARB_draw_indirect specification:
794 * "An INVALID_OPERATION error is generated if the commands source data
795 * beyond the end of the buffer object [...]"
797 if (ctx
->DrawIndirectBuffer
->Size
< end
) {
798 _mesa_error(ctx
, GL_INVALID_OPERATION
,
799 "%s(DRAW_INDIRECT_BUFFER too small)", name
);
803 if (!check_valid_to_render(ctx
, name
))
809 static inline GLboolean
810 valid_draw_indirect_elements(struct gl_context
*ctx
,
811 GLenum mode
, GLenum type
, const GLvoid
*indirect
,
812 GLsizeiptr size
, const char *name
)
814 if (!valid_elements_type(ctx
, type
, name
))
818 * Unlike regular DrawElementsInstancedBaseVertex commands, the indices
819 * may not come from a client array and must come from an index buffer.
820 * If no element array buffer is bound, an INVALID_OPERATION error is
823 if (!_mesa_is_bufferobj(ctx
->Array
.VAO
->IndexBufferObj
)) {
824 _mesa_error(ctx
, GL_INVALID_OPERATION
,
825 "%s(no buffer bound to GL_ELEMENT_ARRAY_BUFFER)", name
);
829 return valid_draw_indirect(ctx
, mode
, indirect
, size
, name
);
832 static inline GLboolean
833 valid_draw_indirect_multi(struct gl_context
*ctx
,
834 GLsizei primcount
, GLsizei stride
,
838 /* From the ARB_multi_draw_indirect specification:
839 * "INVALID_VALUE is generated by MultiDrawArraysIndirect or
840 * MultiDrawElementsIndirect if <primcount> is negative."
842 * "<primcount> must be positive, otherwise an INVALID_VALUE error will
846 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(primcount < 0)", name
);
851 /* From the ARB_multi_draw_indirect specification:
852 * "<stride> must be a multiple of four, otherwise an INVALID_VALUE
853 * error is generated."
856 _mesa_error(ctx
, GL_INVALID_VALUE
, "%s(stride %% 4)", name
);
864 _mesa_validate_DrawArraysIndirect(struct gl_context
*ctx
,
866 const GLvoid
*indirect
)
868 const unsigned drawArraysNumParams
= 4;
870 FLUSH_CURRENT(ctx
, 0);
872 return valid_draw_indirect(ctx
, mode
,
873 indirect
, drawArraysNumParams
* sizeof(GLuint
),
874 "glDrawArraysIndirect");
878 _mesa_validate_DrawElementsIndirect(struct gl_context
*ctx
,
879 GLenum mode
, GLenum type
,
880 const GLvoid
*indirect
)
882 const unsigned drawElementsNumParams
= 5;
884 FLUSH_CURRENT(ctx
, 0);
886 return valid_draw_indirect_elements(ctx
, mode
, type
,
887 indirect
, drawElementsNumParams
* sizeof(GLuint
),
888 "glDrawElementsIndirect");
892 _mesa_validate_MultiDrawArraysIndirect(struct gl_context
*ctx
,
894 const GLvoid
*indirect
,
895 GLsizei primcount
, GLsizei stride
)
898 const unsigned drawArraysNumParams
= 4;
900 FLUSH_CURRENT(ctx
, 0);
902 /* caller has converted stride==0 to drawArraysNumParams * sizeof(GLuint) */
905 if (!valid_draw_indirect_multi(ctx
, primcount
, stride
,
906 "glMultiDrawArraysIndirect"))
909 /* number of bytes of the indirect buffer which will be read */
911 ? (primcount
- 1) * stride
+ drawArraysNumParams
* sizeof(GLuint
)
914 if (!valid_draw_indirect(ctx
, mode
, indirect
, size
,
915 "glMultiDrawArraysIndirect"))
922 _mesa_validate_MultiDrawElementsIndirect(struct gl_context
*ctx
,
923 GLenum mode
, GLenum type
,
924 const GLvoid
*indirect
,
925 GLsizei primcount
, GLsizei stride
)
928 const unsigned drawElementsNumParams
= 5;
930 FLUSH_CURRENT(ctx
, 0);
932 /* caller has converted stride==0 to drawElementsNumParams * sizeof(GLuint) */
935 if (!valid_draw_indirect_multi(ctx
, primcount
, stride
,
936 "glMultiDrawElementsIndirect"))
939 /* number of bytes of the indirect buffer which will be read */
941 ? (primcount
- 1) * stride
+ drawElementsNumParams
* sizeof(GLuint
)
944 if (!valid_draw_indirect_elements(ctx
, mode
, type
,
946 "glMultiDrawElementsIndirect"))
953 valid_draw_indirect_parameters(struct gl_context
*ctx
,
957 /* From the ARB_indirect_parameters specification:
958 * "INVALID_VALUE is generated by MultiDrawArraysIndirectCountARB or
959 * MultiDrawElementsIndirectCountARB if <drawcount> is not a multiple of
963 _mesa_error(ctx
, GL_INVALID_VALUE
,
964 "%s(drawcount is not a multiple of 4)", name
);
968 /* From the ARB_indirect_parameters specification:
969 * "INVALID_OPERATION is generated by MultiDrawArraysIndirectCountARB or
970 * MultiDrawElementsIndirectCountARB if no buffer is bound to the
971 * PARAMETER_BUFFER_ARB binding point."
973 if (!_mesa_is_bufferobj(ctx
->ParameterBuffer
)) {
974 _mesa_error(ctx
, GL_INVALID_OPERATION
,
975 "%s: no buffer bound to PARAMETER_BUFFER", name
);
979 if (_mesa_check_disallowed_mapping(ctx
->ParameterBuffer
)) {
980 _mesa_error(ctx
, GL_INVALID_OPERATION
,
981 "%s(PARAMETER_BUFFER is mapped)", name
);
985 /* From the ARB_indirect_parameters specification:
986 * "INVALID_OPERATION is generated by MultiDrawArraysIndirectCountARB or
987 * MultiDrawElementsIndirectCountARB if reading a <sizei> typed value
988 * from the buffer bound to the PARAMETER_BUFFER_ARB target at the offset
989 * specified by <drawcount> would result in an out-of-bounds access."
991 if (ctx
->ParameterBuffer
->Size
< drawcount
+ sizeof(GLsizei
)) {
992 _mesa_error(ctx
, GL_INVALID_OPERATION
,
993 "%s(PARAMETER_BUFFER too small)", name
);
1001 _mesa_validate_MultiDrawArraysIndirectCount(struct gl_context
*ctx
,
1005 GLsizei maxdrawcount
,
1008 GLsizeiptr size
= 0;
1009 const unsigned drawArraysNumParams
= 4;
1011 FLUSH_CURRENT(ctx
, 0);
1013 /* caller has converted stride==0 to drawArraysNumParams * sizeof(GLuint) */
1014 assert(stride
!= 0);
1016 if (!valid_draw_indirect_multi(ctx
, maxdrawcount
, stride
,
1017 "glMultiDrawArraysIndirectCountARB"))
1020 /* number of bytes of the indirect buffer which will be read */
1022 ? (maxdrawcount
- 1) * stride
+ drawArraysNumParams
* sizeof(GLuint
)
1025 if (!valid_draw_indirect(ctx
, mode
, (void *)indirect
, size
,
1026 "glMultiDrawArraysIndirectCountARB"))
1029 return valid_draw_indirect_parameters(
1030 ctx
, "glMultiDrawArraysIndirectCountARB", drawcount
);
1034 _mesa_validate_MultiDrawElementsIndirectCount(struct gl_context
*ctx
,
1035 GLenum mode
, GLenum type
,
1038 GLsizei maxdrawcount
,
1041 GLsizeiptr size
= 0;
1042 const unsigned drawElementsNumParams
= 5;
1044 FLUSH_CURRENT(ctx
, 0);
1046 /* caller has converted stride==0 to drawElementsNumParams * sizeof(GLuint) */
1047 assert(stride
!= 0);
1049 if (!valid_draw_indirect_multi(ctx
, maxdrawcount
, stride
,
1050 "glMultiDrawElementsIndirectCountARB"))
1053 /* number of bytes of the indirect buffer which will be read */
1055 ? (maxdrawcount
- 1) * stride
+ drawElementsNumParams
* sizeof(GLuint
)
1058 if (!valid_draw_indirect_elements(ctx
, mode
, type
,
1059 (void *)indirect
, size
,
1060 "glMultiDrawElementsIndirectCountARB"))
1063 return valid_draw_indirect_parameters(
1064 ctx
, "glMultiDrawElementsIndirectCountARB", drawcount
);
1068 check_valid_to_compute(struct gl_context
*ctx
, const char *function
)
1070 struct gl_shader_program
*prog
;
1072 if (!_mesa_has_compute_shaders(ctx
)) {
1073 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1074 "unsupported function (%s) called",
1079 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1081 * "An INVALID_OPERATION error is generated if there is no active program
1082 * for the compute shader stage."
1084 prog
= ctx
->_Shader
->CurrentProgram
[MESA_SHADER_COMPUTE
];
1085 if (prog
== NULL
|| prog
->_LinkedShaders
[MESA_SHADER_COMPUTE
] == NULL
) {
1086 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1087 "%s(no active compute shader)",
1096 _mesa_validate_DispatchCompute(struct gl_context
*ctx
,
1097 const GLuint
*num_groups
)
1100 FLUSH_CURRENT(ctx
, 0);
1102 if (!check_valid_to_compute(ctx
, "glDispatchCompute"))
1105 for (i
= 0; i
< 3; i
++) {
1106 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1108 * "An INVALID_VALUE error is generated if any of num_groups_x,
1109 * num_groups_y and num_groups_z are greater than or equal to the
1110 * maximum work group count for the corresponding dimension."
1112 * However, the "or equal to" portions appears to be a specification
1113 * bug. In all other areas, the specification appears to indicate that
1114 * the number of workgroups can match the MAX_COMPUTE_WORK_GROUP_COUNT
1115 * value. For example, under DispatchComputeIndirect:
1117 * "If any of num_groups_x, num_groups_y or num_groups_z is greater than
1118 * the value of MAX_COMPUTE_WORK_GROUP_COUNT for the corresponding
1119 * dimension then the results are undefined."
1121 * Additionally, the OpenGLES 3.1 specification does not contain "or
1122 * equal to" as an error condition.
1124 if (num_groups
[i
] > ctx
->Const
.MaxComputeWorkGroupCount
[i
]) {
1125 _mesa_error(ctx
, GL_INVALID_VALUE
,
1126 "glDispatchCompute(num_groups_%c)", 'x' + i
);
1135 valid_dispatch_indirect(struct gl_context
*ctx
,
1137 GLsizei size
, const char *name
)
1139 const uint64_t end
= (uint64_t) indirect
+ size
;
1141 if (!check_valid_to_compute(ctx
, name
))
1144 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1146 * "An INVALID_VALUE error is generated if indirect is negative or is not a
1147 * multiple of four."
1149 if (indirect
& (sizeof(GLuint
) - 1)) {
1150 _mesa_error(ctx
, GL_INVALID_VALUE
,
1151 "%s(indirect is not aligned)", name
);
1156 _mesa_error(ctx
, GL_INVALID_VALUE
,
1157 "%s(indirect is less than zero)", name
);
1161 /* From the OpenGL 4.3 Core Specification, Chapter 19, Compute Shaders:
1163 * "An INVALID_OPERATION error is generated if no buffer is bound to the
1164 * DRAW_INDIRECT_BUFFER binding, or if the command would source data
1165 * beyond the end of the buffer object."
1167 if (!_mesa_is_bufferobj(ctx
->DispatchIndirectBuffer
)) {
1168 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1169 "%s: no buffer bound to DISPATCH_INDIRECT_BUFFER", name
);
1173 if (_mesa_check_disallowed_mapping(ctx
->DispatchIndirectBuffer
)) {
1174 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1175 "%s(DISPATCH_INDIRECT_BUFFER is mapped)", name
);
1179 if (ctx
->DispatchIndirectBuffer
->Size
< end
) {
1180 _mesa_error(ctx
, GL_INVALID_OPERATION
,
1181 "%s(DISPATCH_INDIRECT_BUFFER too small)", name
);
1189 _mesa_validate_DispatchComputeIndirect(struct gl_context
*ctx
,
1192 FLUSH_CURRENT(ctx
, 0);
1194 return valid_dispatch_indirect(ctx
, indirect
, 3 * sizeof(GLuint
),
1195 "glDispatchComputeIndirect");