src/mesa/main/shaderimage.c

   1 /*
   2  * Copyright 2013 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  21  * DEALINGS IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *    Francisco Jerez <currojerez@riseup.net>
  25  */
  26
  27 #include <assert.h>
  28
  29 #include "shaderimage.h"
  30 #include "mtypes.h"
  31 #include "formats.h"
  32 #include "errors.h"
  33 #include "context.h"
  34 #include "texobj.h"
  35 #include "teximage.h"
  36 #include "enums.h"
  37
  38 /*
  39  * Define endian-invariant aliases for some mesa formats that are
  40  * defined in terms of their channel layout from LSB to MSB in a
  41  * 32-bit word.  The actual byte offsets matter here because the user
  42  * is allowed to bit-cast one format into another and get predictable
  43  * results.
  44  */
  45 #ifdef MESA_BIG_ENDIAN
  46 # define MESA_FORMAT_RGBA_8 MESA_FORMAT_A8B8G8R8_UNORM
  47 # define MESA_FORMAT_RG_16 MESA_FORMAT_G16R16_UNORM
  48 # define MESA_FORMAT_RG_8 MESA_FORMAT_G8R8_UNORM
  49 # define MESA_FORMAT_SIGNED_RGBA_8 MESA_FORMAT_A8B8G8R8_SNORM
  50 # define MESA_FORMAT_SIGNED_RG_16 MESA_FORMAT_G16R16_SNORM
  51 # define MESA_FORMAT_SIGNED_RG_8 MESA_FORMAT_G8R8_SNORM
  52 #else
  53 # define MESA_FORMAT_RGBA_8 MESA_FORMAT_R8G8B8A8_UNORM
  54 # define MESA_FORMAT_RG_16 MESA_FORMAT_R16G16_UNORM
  55 # define MESA_FORMAT_RG_8 MESA_FORMAT_R8G8_UNORM
  56 # define MESA_FORMAT_SIGNED_RGBA_8 MESA_FORMAT_R8G8B8A8_SNORM
  57 # define MESA_FORMAT_SIGNED_RG_16 MESA_FORMAT_R16G16_SNORM
  58 # define MESA_FORMAT_SIGNED_RG_8 MESA_FORMAT_R8G8_SNORM
  59 #endif
  60
  61 mesa_format
  62 _mesa_get_shader_image_format(GLenum format)
  63 {
  64    switch (format) {
  65    case GL_RGBA32F:
  66       return MESA_FORMAT_RGBA_FLOAT32;
  67
  68    case GL_RGBA16F:
  69       return MESA_FORMAT_RGBA_FLOAT16;
  70
  71    case GL_RG32F:
  72       return MESA_FORMAT_RG_FLOAT32;
  73
  74    case GL_RG16F:
  75       return MESA_FORMAT_RG_FLOAT16;
  76
  77    case GL_R11F_G11F_B10F:
  78       return MESA_FORMAT_R11G11B10_FLOAT;
  79
  80    case GL_R32F:
  81       return MESA_FORMAT_R_FLOAT32;
  82
  83    case GL_R16F:
  84       return MESA_FORMAT_R_FLOAT16;
  85
  86    case GL_RGBA32UI:
  87       return MESA_FORMAT_RGBA_UINT32;
  88
  89    case GL_RGBA16UI:
  90       return MESA_FORMAT_RGBA_UINT16;
  91
  92    case GL_RGB10_A2UI:
  93       return MESA_FORMAT_R10G10B10A2_UINT;
  94
  95    case GL_RGBA8UI:
  96       return MESA_FORMAT_RGBA_UINT8;
  97
  98    case GL_RG32UI:
  99       return MESA_FORMAT_RG_UINT32;
 100
 101    case GL_RG16UI:
 102       return MESA_FORMAT_RG_UINT16;
 103
 104    case GL_RG8UI:
 105       return MESA_FORMAT_RG_UINT8;
 106
 107    case GL_R32UI:
 108       return MESA_FORMAT_R_UINT32;
 109
 110    case GL_R16UI:
 111       return MESA_FORMAT_R_UINT16;
 112
 113    case GL_R8UI:
 114       return MESA_FORMAT_R_UINT8;
 115
 116    case GL_RGBA32I:
 117       return MESA_FORMAT_RGBA_SINT32;
 118
 119    case GL_RGBA16I:
 120       return MESA_FORMAT_RGBA_SINT16;
 121
 122    case GL_RGBA8I:
 123       return MESA_FORMAT_RGBA_SINT8;
 124
 125    case GL_RG32I:
 126       return MESA_FORMAT_RG_SINT32;
 127
 128    case GL_RG16I:
 129       return MESA_FORMAT_RG_SINT16;
 130
 131    case GL_RG8I:
 132       return MESA_FORMAT_RG_SINT8;
 133
 134    case GL_R32I:
 135       return MESA_FORMAT_R_SINT32;
 136
 137    case GL_R16I:
 138       return MESA_FORMAT_R_SINT16;
 139
 140    case GL_R8I:
 141       return MESA_FORMAT_R_SINT8;
 142
 143    case GL_RGBA16:
 144       return MESA_FORMAT_RGBA_UNORM16;
 145
 146    case GL_RGB10_A2:
 147       return MESA_FORMAT_R10G10B10A2_UNORM;
 148
 149    case GL_RGBA8:
 150       return MESA_FORMAT_RGBA_8;
 151
 152    case GL_RG16:
 153       return MESA_FORMAT_RG_16;
 154
 155    case GL_RG8:
 156       return MESA_FORMAT_RG_8;
 157
 158    case GL_R16:
 159       return MESA_FORMAT_R_UNORM16;
 160
 161    case GL_R8:
 162       return MESA_FORMAT_R_UNORM8;
 163
 164    case GL_RGBA16_SNORM:
 165       return MESA_FORMAT_RGBA_SNORM16;
 166
 167    case GL_RGBA8_SNORM:
 168       return MESA_FORMAT_SIGNED_RGBA_8;
 169
 170    case GL_RG16_SNORM:
 171       return MESA_FORMAT_SIGNED_RG_16;
 172
 173    case GL_RG8_SNORM:
 174       return MESA_FORMAT_SIGNED_RG_8;
 175
 176    case GL_R16_SNORM:
 177       return MESA_FORMAT_R_SNORM16;
 178
 179    case GL_R8_SNORM:
 180       return MESA_FORMAT_R_SNORM8;
 181
 182    default:
 183       return MESA_FORMAT_NONE;
 184    }
 185 }
 186
 187 enum image_format_class
 188 {
 189    /** Not a valid image format. */
 190    IMAGE_FORMAT_CLASS_NONE = 0,
 191
 192    /** Classes of image formats you can cast into each other. */
 193    /** \{ */
 194    IMAGE_FORMAT_CLASS_1X8,
 195    IMAGE_FORMAT_CLASS_1X16,
 196    IMAGE_FORMAT_CLASS_1X32,
 197    IMAGE_FORMAT_CLASS_2X8,
 198    IMAGE_FORMAT_CLASS_2X16,
 199    IMAGE_FORMAT_CLASS_2X32,
 200    IMAGE_FORMAT_CLASS_10_11_11,
 201    IMAGE_FORMAT_CLASS_4X8,
 202    IMAGE_FORMAT_CLASS_4X16,
 203    IMAGE_FORMAT_CLASS_4X32,
 204    IMAGE_FORMAT_CLASS_2_10_10_10
 205    /** \} */
 206 };
 207
 208 static enum image_format_class
 209 get_image_format_class(mesa_format format)
 210 {
 211    switch (format) {
 212    case MESA_FORMAT_RGBA_FLOAT32:
 213       return IMAGE_FORMAT_CLASS_4X32;
 214
 215    case MESA_FORMAT_RGBA_FLOAT16:
 216       return IMAGE_FORMAT_CLASS_4X16;
 217
 218    case MESA_FORMAT_RG_FLOAT32:
 219       return IMAGE_FORMAT_CLASS_2X32;
 220
 221    case MESA_FORMAT_RG_FLOAT16:
 222       return IMAGE_FORMAT_CLASS_2X16;
 223
 224    case MESA_FORMAT_R11G11B10_FLOAT:
 225       return IMAGE_FORMAT_CLASS_10_11_11;
 226
 227    case MESA_FORMAT_R_FLOAT32:
 228       return IMAGE_FORMAT_CLASS_1X32;
 229
 230    case MESA_FORMAT_R_FLOAT16:
 231       return IMAGE_FORMAT_CLASS_1X16;
 232
 233    case MESA_FORMAT_RGBA_UINT32:
 234       return IMAGE_FORMAT_CLASS_4X32;
 235
 236    case MESA_FORMAT_RGBA_UINT16:
 237       return IMAGE_FORMAT_CLASS_4X16;
 238
 239    case MESA_FORMAT_R10G10B10A2_UINT:
 240       return IMAGE_FORMAT_CLASS_2_10_10_10;
 241
 242    case MESA_FORMAT_RGBA_UINT8:
 243       return IMAGE_FORMAT_CLASS_4X8;
 244
 245    case MESA_FORMAT_RG_UINT32:
 246       return IMAGE_FORMAT_CLASS_2X32;
 247
 248    case MESA_FORMAT_RG_UINT16:
 249       return IMAGE_FORMAT_CLASS_2X16;
 250
 251    case MESA_FORMAT_RG_UINT8:
 252       return IMAGE_FORMAT_CLASS_2X8;
 253
 254    case MESA_FORMAT_R_UINT32:
 255       return IMAGE_FORMAT_CLASS_1X32;
 256
 257    case MESA_FORMAT_R_UINT16:
 258       return IMAGE_FORMAT_CLASS_1X16;
 259
 260    case MESA_FORMAT_R_UINT8:
 261       return IMAGE_FORMAT_CLASS_1X8;
 262
 263    case MESA_FORMAT_RGBA_SINT32:
 264       return IMAGE_FORMAT_CLASS_4X32;
 265
 266    case MESA_FORMAT_RGBA_SINT16:
 267       return IMAGE_FORMAT_CLASS_4X16;
 268
 269    case MESA_FORMAT_RGBA_SINT8:
 270       return IMAGE_FORMAT_CLASS_4X8;
 271
 272    case MESA_FORMAT_RG_SINT32:
 273       return IMAGE_FORMAT_CLASS_2X32;
 274
 275    case MESA_FORMAT_RG_SINT16:
 276       return IMAGE_FORMAT_CLASS_2X16;
 277
 278    case MESA_FORMAT_RG_SINT8:
 279       return IMAGE_FORMAT_CLASS_2X8;
 280
 281    case MESA_FORMAT_R_SINT32:
 282       return IMAGE_FORMAT_CLASS_1X32;
 283
 284    case MESA_FORMAT_R_SINT16:
 285       return IMAGE_FORMAT_CLASS_1X16;
 286
 287    case MESA_FORMAT_R_SINT8:
 288       return IMAGE_FORMAT_CLASS_1X8;
 289
 290    case MESA_FORMAT_RGBA_UNORM16:
 291       return IMAGE_FORMAT_CLASS_4X16;
 292
 293    case MESA_FORMAT_R10G10B10A2_UNORM:
 294       return IMAGE_FORMAT_CLASS_2_10_10_10;
 295
 296    case MESA_FORMAT_RGBA_8:
 297       return IMAGE_FORMAT_CLASS_4X8;
 298
 299    case MESA_FORMAT_RG_16:
 300       return IMAGE_FORMAT_CLASS_2X16;
 301
 302    case MESA_FORMAT_RG_8:
 303       return IMAGE_FORMAT_CLASS_2X8;
 304
 305    case MESA_FORMAT_R_UNORM16:
 306       return IMAGE_FORMAT_CLASS_1X16;
 307
 308    case MESA_FORMAT_R_UNORM8:
 309       return IMAGE_FORMAT_CLASS_1X8;
 310
 311    case MESA_FORMAT_RGBA_SNORM16:
 312       return IMAGE_FORMAT_CLASS_4X16;
 313
 314    case MESA_FORMAT_SIGNED_RGBA_8:
 315       return IMAGE_FORMAT_CLASS_4X8;
 316
 317    case MESA_FORMAT_SIGNED_RG_16:
 318       return IMAGE_FORMAT_CLASS_2X16;
 319
 320    case MESA_FORMAT_SIGNED_RG_8:
 321       return IMAGE_FORMAT_CLASS_2X8;
 322
 323    case MESA_FORMAT_R_SNORM16:
 324       return IMAGE_FORMAT_CLASS_1X16;
 325
 326    case MESA_FORMAT_R_SNORM8:
 327       return IMAGE_FORMAT_CLASS_1X8;
 328
 329    default:
 330       return IMAGE_FORMAT_CLASS_NONE;
 331    }
 332 }
 333
 334 /**
 335  * Return whether an image format should be supported based on the current API
 336  * version of the context.
 337  */
 338 static bool
 339 is_image_format_supported(const struct gl_context *ctx, GLenum format)
 340 {
 341    switch (format) {
 342    /* Formats supported on both desktop and ES GL, c.f. table 8.27 of the
 343     * OpenGL ES 3.1 specification.
 344     */
 345    case GL_RGBA32F:
 346    case GL_RGBA16F:
 347    case GL_R32F:
 348    case GL_RGBA32UI:
 349    case GL_RGBA16UI:
 350    case GL_RGBA8UI:
 351    case GL_R32UI:
 352    case GL_RGBA32I:
 353    case GL_RGBA16I:
 354    case GL_RGBA8I:
 355    case GL_R32I:
 356    case GL_RGBA8:
 357    case GL_RGBA8_SNORM:
 358       return true;
 359
 360    /* Formats supported on unextended desktop GL and the original
 361     * ARB_shader_image_load_store extension, c.f. table 3.21 of the OpenGL 4.2
 362     * specification.
 363     */
 364    case GL_RG32F:
 365    case GL_RG16F:
 366    case GL_R11F_G11F_B10F:
 367    case GL_R16F:
 368    case GL_RGB10_A2UI:
 369    case GL_RG32UI:
 370    case GL_RG16UI:
 371    case GL_RG8UI:
 372    case GL_R16UI:
 373    case GL_R8UI:
 374    case GL_RG32I:
 375    case GL_RG16I:
 376    case GL_RG8I:
 377    case GL_R16I:
 378    case GL_R8I:
 379    case GL_RGBA16:
 380    case GL_RGB10_A2:
 381    case GL_RG16:
 382    case GL_RG8:
 383    case GL_R16:
 384    case GL_R8:
 385    case GL_RGBA16_SNORM:
 386    case GL_RG16_SNORM:
 387    case GL_RG8_SNORM:
 388    case GL_R16_SNORM:
 389    case GL_R8_SNORM:
 390       return _mesa_is_desktop_gl(ctx);
 391
 392    default:
 393       return false;
 394    }
 395 }
 396
 397 struct gl_image_unit
 398 _mesa_default_image_unit(struct gl_context *ctx)
 399 {
 400    const GLenum format = _mesa_is_desktop_gl(ctx) ? GL_R8 : GL_R32UI;
 401    const struct gl_image_unit u = {
 402       .Access = GL_READ_ONLY,
 403       .Format = format,
 404       ._ActualFormat = _mesa_get_shader_image_format(format)
 405    };
 406    return u;
 407 }
 408
 409 void
 410 _mesa_init_image_units(struct gl_context *ctx)
 411 {
 412    unsigned i;
 413
 414    for (i = 0; i < ARRAY_SIZE(ctx->ImageUnits); ++i)
 415       ctx->ImageUnits[i] = _mesa_default_image_unit(ctx);
 416 }
 417
 418 GLboolean
 419 _mesa_is_image_unit_valid(struct gl_context *ctx, struct gl_image_unit *u)
 420 {
 421    struct gl_texture_object *t = u->TexObj;
 422    mesa_format tex_format;
 423
 424    if (!t)
 425       return GL_FALSE;
 426
 427    if (!t->_BaseComplete && !t->_MipmapComplete)
 428        _mesa_test_texobj_completeness(ctx, t);
 429
 430    if (u->Level < t->BaseLevel ||
 431        u->Level > t->_MaxLevel ||
 432        (u->Level == t->BaseLevel && !t->_BaseComplete) ||
 433        (u->Level != t->BaseLevel && !t->_MipmapComplete))
 434       return GL_FALSE;
 435
 436    if (_mesa_tex_target_is_layered(t->Target) &&
 437        u->_Layer >= _mesa_get_texture_layers(t, u->Level))
 438       return GL_FALSE;
 439
 440    if (t->Target == GL_TEXTURE_BUFFER) {
 441       tex_format = _mesa_get_shader_image_format(t->BufferObjectFormat);
 442
 443    } else {
 444       struct gl_texture_image *img = (t->Target == GL_TEXTURE_CUBE_MAP ?
 445                                       t->Image[u->_Layer][u->Level] :
 446                                       t->Image[0][u->Level]);
 447
 448       if (!img || img->Border || img->NumSamples > ctx->Const.MaxImageSamples)
 449          return GL_FALSE;
 450
 451       tex_format = _mesa_get_shader_image_format(img->InternalFormat);
 452    }
 453
 454    if (!tex_format)
 455       return GL_FALSE;
 456
 457    switch (t->ImageFormatCompatibilityType) {
 458    case GL_IMAGE_FORMAT_COMPATIBILITY_BY_SIZE:
 459       if (_mesa_get_format_bytes(tex_format) !=
 460           _mesa_get_format_bytes(u->_ActualFormat))
 461          return GL_FALSE;
 462       break;
 463
 464    case GL_IMAGE_FORMAT_COMPATIBILITY_BY_CLASS:
 465       if (get_image_format_class(tex_format) !=
 466           get_image_format_class(u->_ActualFormat))
 467          return GL_FALSE;
 468       break;
 469
 470    default:
 471       assert(!"Unexpected image format compatibility type");
 472    }
 473
 474    return GL_TRUE;
 475 }
 476
 477 static GLboolean
 478 validate_bind_image_texture(struct gl_context *ctx, GLuint unit,
 479                             GLuint texture, GLint level, GLboolean layered,
 480                             GLint layer, GLenum access, GLenum format)
 481 {
 482    assert(ctx->Const.MaxImageUnits <= MAX_IMAGE_UNITS);
 483
 484    if (unit >= ctx->Const.MaxImageUnits) {
 485       _mesa_error(ctx, GL_INVALID_VALUE, "glBindImageTexture(unit)");
 486       return GL_FALSE;
 487    }
 488
 489    if (level < 0) {
 490       _mesa_error(ctx, GL_INVALID_VALUE, "glBindImageTexture(level)");
 491       return GL_FALSE;
 492    }
 493
 494    if (layer < 0) {
 495       _mesa_error(ctx, GL_INVALID_VALUE, "glBindImageTexture(layer)");
 496       return GL_FALSE;
 497    }
 498
 499    if (access != GL_READ_ONLY &&
 500        access != GL_WRITE_ONLY &&
 501        access != GL_READ_WRITE) {
 502       _mesa_error(ctx, GL_INVALID_VALUE, "glBindImageTexture(access)");
 503       return GL_FALSE;
 504    }
 505
 506    if (!is_image_format_supported(ctx, format)) {
 507       _mesa_error(ctx, GL_INVALID_VALUE, "glBindImageTexture(format)");
 508       return GL_FALSE;
 509    }
 510
 511    return GL_TRUE;
 512 }
 513
 514 void GLAPIENTRY
 515 _mesa_BindImageTexture(GLuint unit, GLuint texture, GLint level,
 516                        GLboolean layered, GLint layer, GLenum access,
 517                        GLenum format)
 518 {
 519    GET_CURRENT_CONTEXT(ctx);
 520    struct gl_image_unit *u;
 521
 522    if (!validate_bind_image_texture(ctx, unit, texture, level,
 523                                     layered, layer, access, format))
 524       return;
 525
 526    u = &ctx->ImageUnits[unit];
 527
 528    FLUSH_VERTICES(ctx, 0);
 529    ctx->NewDriverState |= ctx->DriverFlags.NewImageUnits;
 530
 531    if (texture) {
 532       struct gl_texture_object *t = _mesa_lookup_texture(ctx, texture);
 533
 534       if (!t) {
 535          _mesa_error(ctx, GL_INVALID_VALUE, "glBindImageTexture(texture)");
 536          return;
 537       }
 538
 539       /* From section 8.22 "Texture Image Loads and Stores" of the OpenGL ES
 540        * 3.1 spec:
 541        *
 542        * "An INVALID_OPERATION error is generated if texture is not the name
 543        *  of an immutable texture object."
 544        */
 545       if (_mesa_is_gles(ctx) && !t->Immutable) {
 546          _mesa_error(ctx, GL_INVALID_OPERATION,
 547                      "glBindImageTexture(!immutable)");
 548          return;
 549       }
 550
 551       _mesa_reference_texobj(&u->TexObj, t);
 552    } else {
 553       _mesa_reference_texobj(&u->TexObj, NULL);
 554    }
 555
 556    u->Level = level;
 557    u->Access = access;
 558    u->Format = format;
 559    u->_ActualFormat = _mesa_get_shader_image_format(format);
 560
 561    if (u->TexObj && _mesa_tex_target_is_layered(u->TexObj->Target)) {
 562       u->Layered = layered;
 563       u->Layer = layer;
 564       u->_Layer = (u->Layered ? 0 : u->Layer);
 565    } else {
 566       u->Layered = GL_FALSE;
 567       u->Layer = 0;
 568    }
 569 }
 570
 571 void GLAPIENTRY
 572 _mesa_BindImageTextures(GLuint first, GLsizei count, const GLuint *textures)
 573 {
 574    GET_CURRENT_CONTEXT(ctx);
 575    int i;
 576
 577    if (!ctx->Extensions.ARB_shader_image_load_store) {
 578       _mesa_error(ctx, GL_INVALID_OPERATION, "glBindImageTextures()");
 579       return;
 580    }
 581
 582    if (first + count > ctx->Const.MaxImageUnits) {
 583       /* The ARB_multi_bind spec says:
 584        *
 585        *    "An INVALID_OPERATION error is generated if <first> + <count>
 586        *     is greater than the number of image units supported by
 587        *     the implementation."
 588        */
 589       _mesa_error(ctx, GL_INVALID_OPERATION,
 590                   "glBindImageTextures(first=%u + count=%d > the value of "
 591                   "GL_MAX_IMAGE_UNITS=%u)",
 592                   first, count, ctx->Const.MaxImageUnits);
 593       return;
 594    }
 595
 596    /* Assume that at least one binding will be changed */
 597    FLUSH_VERTICES(ctx, 0);
 598    ctx->NewDriverState |= ctx->DriverFlags.NewImageUnits;
 599
 600    /* Note that the error semantics for multi-bind commands differ from
 601     * those of other GL commands.
 602     *
 603     * The Issues section in the ARB_multi_bind spec says:
 604     *
 605     *    "(11) Typically, OpenGL specifies that if an error is generated by
 606     *          a command, that command has no effect.  This is somewhat
 607     *          unfortunate for multi-bind commands, because it would require
 608     *          a first pass to scan the entire list of bound objects for
 609     *          errors and then a second pass to actually perform the
 610     *          bindings.  Should we have different error semantics?
 611     *
 612     *       RESOLVED:  Yes.  In this specification, when the parameters for
 613     *       one of the <count> binding points are invalid, that binding
 614     *       point is not updated and an error will be generated.  However,
 615     *       other binding points in the same command will be updated if
 616     *       their parameters are valid and no other error occurs."
 617     */
 618
 619    _mesa_begin_texture_lookups(ctx);
 620
 621    for (i = 0; i < count; i++) {
 622       struct gl_image_unit *u = &ctx->ImageUnits[first + i];
 623       const GLuint texture = textures ? textures[i] : 0;
 624
 625       if (texture != 0) {
 626          struct gl_texture_object *texObj;
 627          GLenum tex_format;
 628
 629          if (!u->TexObj || u->TexObj->Name != texture) {
 630             texObj = _mesa_lookup_texture_locked(ctx, texture);
 631             if (!texObj) {
 632                /* The ARB_multi_bind spec says:
 633                 *
 634                 *    "An INVALID_OPERATION error is generated if any value
 635                 *     in <textures> is not zero or the name of an existing
 636                 *     texture object (per binding)."
 637                 */
 638                _mesa_error(ctx, GL_INVALID_OPERATION,
 639                            "glBindImageTextures(textures[%d]=%u "
 640                            "is not zero or the name of an existing texture "
 641                            "object)", i, texture);
 642                continue;
 643             }
 644          } else {
 645             texObj = u->TexObj;
 646          }
 647
 648          if (texObj->Target == GL_TEXTURE_BUFFER) {
 649             tex_format = texObj->BufferObjectFormat;
 650          } else {
 651             struct gl_texture_image *image = texObj->Image[0][0];
 652
 653             if (!image || image->Width == 0 || image->Height == 0 ||
 654                 image->Depth == 0) {
 655                /* The ARB_multi_bind spec says:
 656                 *
 657                 *    "An INVALID_OPERATION error is generated if the width,
 658                 *     height, or depth of the level zero texture image of
 659                 *     any texture in <textures> is zero (per binding)."
 660                 */
 661                _mesa_error(ctx, GL_INVALID_OPERATION,
 662                            "glBindImageTextures(the width, height or depth "
 663                            "of the level zero texture image of "
 664                            "textures[%d]=%u is zero)", i, texture);
 665                continue;
 666             }
 667
 668             tex_format = image->InternalFormat;
 669          }
 670
 671          if (!is_image_format_supported(ctx, tex_format)) {
 672             /* The ARB_multi_bind spec says:
 673              *
 674              *   "An INVALID_OPERATION error is generated if the internal
 675              *    format of the level zero texture image of any texture
 676              *    in <textures> is not found in table 8.33 (per binding)."
 677              */
 678             _mesa_error(ctx, GL_INVALID_OPERATION,
 679                         "glBindImageTextures(the internal format %s of "
 680                         "the level zero texture image of textures[%d]=%u "
 681                         "is not supported)",
 682                         _mesa_enum_to_string(tex_format),
 683                         i, texture);
 684             continue;
 685          }
 686
 687          /* Update the texture binding */
 688          _mesa_reference_texobj(&u->TexObj, texObj);
 689          u->Level = 0;
 690          u->Layered = _mesa_tex_target_is_layered(texObj->Target);
 691          u->_Layer = u->Layer = 0;
 692          u->Access = GL_READ_WRITE;
 693          u->Format = tex_format;
 694          u->_ActualFormat = _mesa_get_shader_image_format(tex_format);
 695       } else {
 696          /* Unbind the texture from the unit */
 697          _mesa_reference_texobj(&u->TexObj, NULL);
 698          u->Level = 0;
 699          u->Layered = GL_FALSE;
 700          u->_Layer = u->Layer = 0;
 701          u->Access = GL_READ_ONLY;
 702          u->Format = GL_R8;
 703          u->_ActualFormat = MESA_FORMAT_R_UNORM8;
 704       }
 705    }
 706
 707    _mesa_end_texture_lookups(ctx);
 708 }
 709
 710 void GLAPIENTRY
 711 _mesa_MemoryBarrier(GLbitfield barriers)
 712 {
 713    GET_CURRENT_CONTEXT(ctx);
 714
 715    if (ctx->Driver.MemoryBarrier)
 716       ctx->Driver.MemoryBarrier(ctx, barriers);
 717 }
 718
 719 void GLAPIENTRY
 720 _mesa_MemoryBarrierByRegion(GLbitfield barriers)
 721 {
 722    GET_CURRENT_CONTEXT(ctx);
 723
 724    GLbitfield all_allowed_bits = GL_ATOMIC_COUNTER_BARRIER_BIT |
 725                                  GL_FRAMEBUFFER_BARRIER_BIT |
 726                                  GL_SHADER_IMAGE_ACCESS_BARRIER_BIT |
 727                                  GL_SHADER_STORAGE_BARRIER_BIT |
 728                                  GL_TEXTURE_FETCH_BARRIER_BIT |
 729                                  GL_UNIFORM_BARRIER_BIT;
 730
 731    if (ctx->Driver.MemoryBarrier) {
 732       /* From section 7.11.2 of the OpenGL ES 3.1 specification:
 733        *
 734        *    "When barriers is ALL_BARRIER_BITS, shader memory accesses will be
 735        *     synchronized relative to all these barrier bits, but not to other
 736        *     barrier bits specific to MemoryBarrier."
 737        *
 738        * That is, if barriers is the special value GL_ALL_BARRIER_BITS, then all
 739        * barriers allowed by glMemoryBarrierByRegion should be activated."
 740        */
 741       if (barriers == GL_ALL_BARRIER_BITS)
 742          return ctx->Driver.MemoryBarrier(ctx, all_allowed_bits);
 743
 744       /* From section 7.11.2 of the OpenGL ES 3.1 specification:
 745        *
 746        *    "An INVALID_VALUE error is generated if barriers is not the special
 747        *     value ALL_BARRIER_BITS, and has any bits set other than those
 748        *     described above."
 749        */
 750       if ((barriers & ~all_allowed_bits) != 0) {
 751          _mesa_error(ctx, GL_INVALID_VALUE,
 752                      "glMemoryBarrierByRegion(unsupported barrier bit");
 753       }
 754
 755       ctx->Driver.MemoryBarrier(ctx, barriers);
 756    }
 757 }