1 /******************************************************************************
2 * Top contributors (to current version):
3 * Andrew Reynolds, Haniel Barbosa, Aina Niemetz
5 * This file is part of the cvc5 project.
7 * Copyright (c) 2009-2021 by the authors listed in the file AUTHORS
8 * in the top-level source directory and their institutional affiliations.
9 * All rights reserved. See the file COPYING in the top-level source
10 * directory for licensing information.
11 * ****************************************************************************
13 * Implementation of module for processing proof nodes.
16 #include "smt/proof_post_processor.h"
18 #include "expr/proof_node_manager.h"
19 #include "expr/skolem_manager.h"
20 #include "options/proof_options.h"
21 #include "options/smt_options.h"
22 #include "preprocessing/assertion_pipeline.h"
23 #include "smt/smt_engine.h"
24 #include "smt/smt_statistics_registry.h"
25 #include "theory/builtin/proof_checker.h"
26 #include "theory/rewriter.h"
27 #include "theory/theory.h"
29 using namespace cvc5::kind
;
30 using namespace cvc5::theory
;
35 ProofPostprocessCallback::ProofPostprocessCallback(ProofNodeManager
* pnm
,
38 bool updateScopedAssumptions
)
43 d_updateScopedAssumptions(updateScopedAssumptions
)
45 d_true
= NodeManager::currentNM()->mkConst(true);
48 void ProofPostprocessCallback::initializeUpdate()
50 d_assumpToProof
.clear();
51 d_wfAssumptions
.clear();
54 void ProofPostprocessCallback::setEliminateRule(PfRule rule
)
56 d_elimRules
.insert(rule
);
59 bool ProofPostprocessCallback::shouldUpdate(std::shared_ptr
<ProofNode
> pn
,
60 const std::vector
<Node
>& fa
,
63 PfRule id
= pn
->getRule();
64 if (d_elimRules
.find(id
) != d_elimRules
.end())
68 // other than elimination rules, we always update assumptions as long as
69 // d_updateScopedAssumptions is true or they are *not* in scope, i.e., not in
71 if (id
!= PfRule::ASSUME
72 || (!d_updateScopedAssumptions
73 && std::find(fa
.begin(), fa
.end(), pn
->getResult()) != fa
.end()))
75 Trace("smt-proof-pp-debug")
76 << "... not updating in-scope assumption " << pn
->getResult() << "\n";
82 bool ProofPostprocessCallback::update(Node res
,
84 const std::vector
<Node
>& children
,
85 const std::vector
<Node
>& args
,
89 Trace("smt-proof-pp-debug") << "- Post process " << id
<< " " << children
90 << " / " << args
<< std::endl
;
92 if (id
== PfRule::ASSUME
)
94 // we cache based on the assumption node, not the proof node, since there
95 // may be multiple occurrences of the same node.
97 std::shared_ptr
<ProofNode
> pfn
;
98 std::map
<Node
, std::shared_ptr
<ProofNode
>>::iterator it
=
99 d_assumpToProof
.find(f
);
100 if (it
!= d_assumpToProof
.end())
102 Trace("smt-proof-pp-debug") << "...already computed" << std::endl
;
107 Trace("smt-proof-pp-debug") << "...get proof" << std::endl
;
108 Assert(d_pppg
!= nullptr);
109 // get proof from preprocess proof generator
110 pfn
= d_pppg
->getProofFor(f
);
111 Trace("smt-proof-pp-debug") << "...finished get proof" << std::endl
;
112 // print for debugging
115 Trace("smt-proof-pp-debug")
116 << "...no proof, possibly an input assumption" << std::endl
;
120 Assert(pfn
->getResult() == f
);
121 if (Trace
.isOn("smt-proof-pp"))
123 Trace("smt-proof-pp")
124 << "=== Connect proof for preprocessing: " << f
<< std::endl
;
125 Trace("smt-proof-pp") << *pfn
.get() << std::endl
;
128 d_assumpToProof
[f
] = pfn
;
130 if (pfn
== nullptr || pfn
->getRule() == PfRule::ASSUME
)
132 Trace("smt-proof-pp-debug") << "...do not add proof" << std::endl
;
136 Trace("smt-proof-pp-debug") << "...add proof" << std::endl
;
141 Node ret
= expandMacros(id
, children
, args
, cdp
);
142 Trace("smt-proof-pp-debug") << "...expanded = " << !ret
.isNull() << std::endl
;
143 return !ret
.isNull();
146 bool ProofPostprocessCallback::updateInternal(Node res
,
148 const std::vector
<Node
>& children
,
149 const std::vector
<Node
>& args
,
152 bool continueUpdate
= true;
153 return update(res
, id
, children
, args
, cdp
, continueUpdate
);
156 Node
ProofPostprocessCallback::eliminateCrowdingLits(
157 const std::vector
<Node
>& clauseLits
,
158 const std::vector
<Node
>& targetClauseLits
,
159 const std::vector
<Node
>& children
,
160 const std::vector
<Node
>& args
,
163 Trace("smt-proof-pp-debug2") << push
;
164 NodeManager
* nm
= NodeManager::currentNM();
165 Node trueNode
= nm
->mkConst(true);
166 // get crowding lits and the position of the last clause that includes
167 // them. The factoring step must be added after the last inclusion and before
169 std::unordered_set
<TNode
> crowding
;
170 std::vector
<std::pair
<Node
, size_t>> lastInclusion
;
171 // positions of eliminators of crowding literals, which are the positions of
172 // the clauses that eliminate crowding literals *after* their last inclusion
173 std::vector
<size_t> eliminators
;
174 for (size_t i
= 0, size
= clauseLits
.size(); i
< size
; ++i
)
176 if (!crowding
.count(clauseLits
[i
])
178 targetClauseLits
.begin(), targetClauseLits
.end(), clauseLits
[i
])
179 == targetClauseLits
.end())
181 Node crowdLit
= clauseLits
[i
];
182 crowding
.insert(crowdLit
);
183 Trace("smt-proof-pp-debug2") << "crowding lit " << crowdLit
<< "\n";
184 // found crowding lit, now get its last inclusion position, which is the
185 // position of the last resolution link that introduces the crowding
186 // literal. Note that this position has to be *before* the last link, as a
187 // link *after* the last inclusion must eliminate the crowding literal.
189 for (j
= children
.size() - 1; j
> 0; --j
)
191 // notice that only non-singleton clauses may be introducing the
192 // crowding literal, so we only care about non-singleton OR nodes. We
193 // check then against the kind and whether the whole OR node occurs as a
194 // pivot of the respective resolution
195 if (children
[j
- 1].getKind() != kind::OR
)
199 uint64_t pivotIndex
= 2 * (j
- 1);
200 if (args
[pivotIndex
] == children
[j
- 1]
201 || args
[pivotIndex
].notNode() == children
[j
- 1])
205 if (std::find(children
[j
- 1].begin(), children
[j
- 1].end(), crowdLit
)
206 != children
[j
- 1].end())
212 lastInclusion
.emplace_back(crowdLit
, j
- 1);
214 Trace("smt-proof-pp-debug2") << "last inc " << j
- 1 << "\n";
215 // get elimination position, starting from the following link as the last
216 // inclusion one. The result is the last (in the chain, but first from
217 // this point on) resolution link that eliminates the crowding literal. A
218 // literal l is eliminated by a link if it contains a literal l' with
219 // opposite polarity to l.
220 for (; j
< children
.size(); ++j
)
222 bool posFirst
= args
[(2 * j
) - 1] == trueNode
;
223 Node pivot
= args
[(2 * j
)];
224 Trace("smt-proof-pp-debug2")
225 << "\tcheck w/ args " << posFirst
<< " / " << pivot
<< "\n";
226 // To eliminate the crowding literal (crowdLit), the clause must contain
227 // it with opposite polarity. There are three successful cases,
228 // according to the pivot and its sign
230 // - crowdLit is the same as the pivot and posFirst is true, which means
231 // that the clause contains its negation and eliminates it
233 // - crowdLit is the negation of the pivot and posFirst is false, so the
234 // clause contains the node whose negation is crowdLit. Note that this
235 // case may either be crowdLit.notNode() == pivot or crowdLit ==
237 if ((crowdLit
== pivot
&& posFirst
)
238 || (crowdLit
.notNode() == pivot
&& !posFirst
)
239 || (pivot
.notNode() == crowdLit
&& !posFirst
))
241 Trace("smt-proof-pp-debug2") << "\t\tfound it!\n";
242 eliminators
.push_back(j
);
246 AlwaysAssert(j
< children
.size());
249 Assert(!lastInclusion
.empty());
250 // order map so that we process crowding literals in the order of the clauses
251 // that last introduce them
252 auto cmp
= [](std::pair
<Node
, size_t>& a
, std::pair
<Node
, size_t>& b
) {
253 return a
.second
< b
.second
;
255 std::sort(lastInclusion
.begin(), lastInclusion
.end(), cmp
);
257 std::sort(eliminators
.begin(), eliminators
.end());
258 if (Trace
.isOn("smt-proof-pp-debug"))
260 Trace("smt-proof-pp-debug") << "crowding lits last inclusion:\n";
261 for (const auto& pair
: lastInclusion
)
263 Trace("smt-proof-pp-debug")
264 << "\t- [" << pair
.second
<< "] : " << pair
.first
<< "\n";
266 Trace("smt-proof-pp-debug") << "eliminators:";
267 for (size_t elim
: eliminators
)
269 Trace("smt-proof-pp-debug") << " " << elim
;
271 Trace("smt-proof-pp-debug") << "\n";
273 // TODO (cvc4-wishues/issues/77): implement also simpler version and compare
275 // We now start to break the chain, one step at a time. Naively this breaking
276 // down would be one resolution/factoring to each crowding literal, but we can
277 // merge some of the cases. Effectively we do the following:
280 // lastClause children[start] ... children[end]
281 // ---------------------------------------------- CHAIN_RES
283 // ----------- FACTORING
284 // lastClause' children[start'] ... children[end']
285 // -------------------------------------------------------------- CHAIN_RES
289 // lastClause_0 = children[0]
291 // end_0 = eliminators[0] - 1
292 // start_i+1 = nextGuardedElimPos - 1
294 // The important point is how end_i+1 is computed. It is based on what we call
295 // the "nextGuardedElimPos", i.e., the next elimination position that requires
296 // removal of duplicates. The intuition is that a factoring step may eliminate
297 // the duplicates of crowding literals l1 and l2. If the last inclusion of l2
298 // is before the elimination of l1, then we can go ahead and also perform the
299 // elimination of l2 without another factoring. However if another literal l3
300 // has its last inclusion after the elimination of l2, then the elimination of
301 // l3 is the next guarded elimination.
303 // To do the above computation then we determine, after a resolution/factoring
304 // step, the first crowded literal to have its last inclusion after "end". The
305 // first elimination position to be bigger than the position of that crowded
306 // literal is the next guarded elimination position.
308 Node lastClause
= children
[0];
309 std::vector
<Node
> childrenRes
;
310 std::vector
<Node
> childrenResArgs
;
312 size_t nextGuardedElimPos
= eliminators
[0];
315 size_t start
= lastElim
+ 1;
316 size_t end
= nextGuardedElimPos
- 1;
317 Trace("smt-proof-pp-debug2")
318 << "res with:\n\tlastClause: " << lastClause
<< "\n\tstart: " << start
319 << "\n\tend: " << end
<< "\n";
320 childrenRes
.push_back(lastClause
);
321 // note that the interval of insert is exclusive in the end, so we add 1
322 childrenRes
.insert(childrenRes
.end(),
323 children
.begin() + start
,
324 children
.begin() + end
+ 1);
325 childrenResArgs
.insert(childrenResArgs
.end(),
326 args
.begin() + (2 * start
) - 1,
327 args
.begin() + (2 * end
) + 1);
328 Trace("smt-proof-pp-debug2") << "res children: " << childrenRes
<< "\n";
329 Trace("smt-proof-pp-debug2") << "res args: " << childrenResArgs
<< "\n";
330 resPlaceHolder
= d_pnm
->getChecker()->checkDebug(PfRule::CHAIN_RESOLUTION
,
335 Trace("smt-proof-pp-debug2")
336 << "resPlaceHorder: " << resPlaceHolder
<< "\n";
338 resPlaceHolder
, PfRule::CHAIN_RESOLUTION
, childrenRes
, childrenResArgs
);
339 // I need to add factoring if end < children.size(). Otherwise, this is
340 // to be handled by the caller
341 if (end
< children
.size() - 1)
343 lastClause
= d_pnm
->getChecker()->checkDebug(
344 PfRule::FACTORING
, {resPlaceHolder
}, {}, Node::null(), "");
345 if (!lastClause
.isNull())
347 cdp
->addStep(lastClause
, PfRule::FACTORING
, {resPlaceHolder
}, {});
351 lastClause
= resPlaceHolder
;
353 Trace("smt-proof-pp-debug2") << "lastClause: " << lastClause
<< "\n";
357 lastClause
= resPlaceHolder
;
360 // update for next round
362 childrenResArgs
.clear();
365 // find the position of the last inclusion of the next crowded literal
366 size_t nextCrowdedInclusionPos
= lastInclusion
.size();
367 for (size_t i
= 0, size
= lastInclusion
.size(); i
< size
; ++i
)
369 if (lastInclusion
[i
].second
> lastElim
)
371 nextCrowdedInclusionPos
= i
;
375 Trace("smt-proof-pp-debug2")
376 << "nextCrowdedInclusion/Pos: "
377 << lastInclusion
[nextCrowdedInclusionPos
].second
<< "/"
378 << nextCrowdedInclusionPos
<< "\n";
379 // if there is none, then the remaining literals will be used in the next
381 if (nextCrowdedInclusionPos
== lastInclusion
.size())
383 nextGuardedElimPos
= children
.size();
387 nextGuardedElimPos
= children
.size();
388 for (size_t i
= 0, size
= eliminators
.size(); i
< size
; ++i
)
390 // nextGuardedElimPos is the largest element of
391 // eliminators bigger the next crowded literal's last inclusion
392 if (eliminators
[i
] > lastInclusion
[nextCrowdedInclusionPos
].second
)
394 nextGuardedElimPos
= eliminators
[i
];
398 Assert(nextGuardedElimPos
< children
.size());
400 Trace("smt-proof-pp-debug2")
401 << "nextGuardedElimPos: " << nextGuardedElimPos
<< "\n";
403 Trace("smt-proof-pp-debug2") << pop
;
407 Node
ProofPostprocessCallback::expandMacros(PfRule id
,
408 const std::vector
<Node
>& children
,
409 const std::vector
<Node
>& args
,
412 if (d_elimRules
.find(id
) == d_elimRules
.end())
418 if (id
== PfRule::MACRO_SR_EQ_INTRO
)
421 // (SUBS <children> :args args[0:1])
422 // (REWRITE :args <t.substitute(x1,t1). ... .substitute(xn,tn)> args[2]))
423 std::vector
<Node
> tchildren
;
426 if (!children
.empty())
428 std::vector
<Node
> sargs
;
430 MethodId ids
= MethodId::SB_DEFAULT
;
431 if (args
.size() >= 2)
433 if (builtin::BuiltinProofRuleChecker::getMethodId(args
[1], ids
))
435 sargs
.push_back(args
[1]);
438 MethodId ida
= MethodId::SBA_SEQUENTIAL
;
439 if (args
.size() >= 3)
441 if (builtin::BuiltinProofRuleChecker::getMethodId(args
[2], ida
))
443 sargs
.push_back(args
[2]);
446 ts
= builtin::BuiltinProofRuleChecker::applySubstitution(
447 t
, children
, ids
, ida
);
448 Trace("smt-proof-pp-debug")
449 << "...eq intro subs equality is " << t
<< " == " << ts
<< ", from "
450 << ids
<< " " << ida
<< std::endl
;
453 Node eq
= t
.eqNode(ts
);
454 // apply SUBS proof rule if necessary
455 if (!updateInternal(eq
, PfRule::SUBS
, children
, sargs
, cdp
))
457 // if we specified that we did not want to eliminate, add as step
458 cdp
->addStep(eq
, PfRule::SUBS
, children
, sargs
);
460 tchildren
.push_back(eq
);
468 std::vector
<Node
> rargs
;
470 MethodId idr
= MethodId::RW_REWRITE
;
471 if (args
.size() >= 4)
473 if (builtin::BuiltinProofRuleChecker::getMethodId(args
[3], idr
))
475 rargs
.push_back(args
[3]);
478 builtin::BuiltinProofRuleChecker
* builtinPfC
=
479 static_cast<builtin::BuiltinProofRuleChecker
*>(
480 d_pnm
->getChecker()->getCheckerFor(PfRule::MACRO_SR_EQ_INTRO
));
481 Node tr
= builtinPfC
->applyRewrite(ts
, idr
);
482 Trace("smt-proof-pp-debug")
483 << "...eq intro rewrite equality is " << ts
<< " == " << tr
<< ", from "
487 Node eq
= ts
.eqNode(tr
);
488 // apply REWRITE proof rule
489 if (!updateInternal(eq
, PfRule::REWRITE
, {}, rargs
, cdp
))
491 // if not elimianted, add as step
492 cdp
->addStep(eq
, PfRule::REWRITE
, {}, rargs
);
494 tchildren
.push_back(eq
);
498 // typically not necessary, but done to be robust
499 cdp
->addStep(t
.eqNode(tr
), PfRule::REFL
, {}, {t
});
502 // must add TRANS if two step
503 return addProofForTrans(tchildren
, cdp
);
505 else if (id
== PfRule::MACRO_SR_PRED_INTRO
)
507 std::vector
<Node
> tchildren
;
508 std::vector
<Node
> sargs
= args
;
509 // take into account witness form, if necessary
510 bool reqWitness
= d_wfpm
.requiresWitnessFormIntro(args
[0]);
511 Trace("smt-proof-pp-debug")
512 << "...pred intro reqWitness=" << reqWitness
<< std::endl
;
515 // (MACRO_SR_EQ_INTRO <children> :args (t args[1:]))
516 // ... proof of apply_SR(t) = toWitness(apply_SR(t)) ...
517 // (MACRO_SR_EQ_INTRO {} {toWitness(apply_SR(t))})
519 // Notice this is an optimized, one sided version of the expansion of
520 // MACRO_SR_PRED_TRANSFORM below.
521 // We call the expandMacros method on MACRO_SR_EQ_INTRO, where notice
522 // that this rule application is immediately expanded in the recursive
523 // call and not added to the proof.
524 Node conc
= expandMacros(PfRule::MACRO_SR_EQ_INTRO
, children
, sargs
, cdp
);
525 Trace("smt-proof-pp-debug")
526 << "...pred intro conclusion is " << conc
<< std::endl
;
527 Assert(!conc
.isNull());
528 Assert(conc
.getKind() == EQUAL
);
529 Assert(conc
[0] == args
[0]);
530 tchildren
.push_back(conc
);
533 Node weq
= addProofForWitnessForm(conc
[1], cdp
);
534 Trace("smt-proof-pp-debug") << "...weq is " << weq
<< std::endl
;
535 if (addToTransChildren(weq
, tchildren
))
537 // toWitness(apply_SR(t)) = apply_SR(toWitness(apply_SR(t)))
538 // rewrite again, don't need substitution. Also we always use the
539 // default rewriter, due to the definition of MACRO_SR_PRED_INTRO.
540 Node weqr
= expandMacros(PfRule::MACRO_SR_EQ_INTRO
, {}, {weq
[1]}, cdp
);
541 addToTransChildren(weqr
, tchildren
);
544 // apply transitivity if necessary
545 Node eq
= addProofForTrans(tchildren
, cdp
);
546 Assert(!eq
.isNull());
547 Assert(eq
.getKind() == EQUAL
);
548 Assert(eq
[0] == args
[0]);
549 Assert(eq
[1] == d_true
);
551 cdp
->addStep(eq
[0], PfRule::TRUE_ELIM
, {eq
}, {});
554 else if (id
== PfRule::MACRO_SR_PRED_ELIM
)
558 // (MACRO_SR_EQ_INTRO children[1:] :args children[0] ++ args))
559 std::vector
<Node
> schildren(children
.begin() + 1, children
.end());
560 std::vector
<Node
> srargs
;
561 srargs
.push_back(children
[0]);
562 srargs
.insert(srargs
.end(), args
.begin(), args
.end());
563 Node conc
= expandMacros(PfRule::MACRO_SR_EQ_INTRO
, schildren
, srargs
, cdp
);
564 Assert(!conc
.isNull());
565 Assert(conc
.getKind() == EQUAL
);
566 Assert(conc
[0] == children
[0]);
567 // apply equality resolve
568 cdp
->addStep(conc
[1], PfRule::EQ_RESOLVE
, {children
[0], conc
}, {});
571 else if (id
== PfRule::MACRO_SR_PRED_TRANSFORM
)
576 // (MACRO_SR_EQ_INTRO children[1:] :args (children[0] args[1:]))
577 // ... proof of c = wc
578 // (MACRO_SR_EQ_INTRO {} wc)
580 // (MACRO_SR_EQ_INTRO children[1:] :args <args>)
581 // ... proof of a = wa
582 // (MACRO_SR_EQ_INTRO {} wa))))
584 // wa = toWitness(apply_SR(args[0])) and
585 // wc = toWitness(apply_SR(children[0])).
586 Trace("smt-proof-pp-debug")
587 << "Transform " << children
[0] << " == " << args
[0] << std::endl
;
588 if (CDProof::isSame(children
[0], args
[0]))
590 Trace("smt-proof-pp-debug") << "...nothing to do" << std::endl
;
594 std::vector
<Node
> tchildren
;
595 std::vector
<Node
> schildren(children
.begin() + 1, children
.end());
596 std::vector
<Node
> sargs
= args
;
597 // first, compute if we need
598 bool reqWitness
= d_wfpm
.requiresWitnessFormTransform(children
[0], args
[0]);
599 Trace("smt-proof-pp-debug") << "...reqWitness=" << reqWitness
<< std::endl
;
600 // convert both sides, in three steps, take symmetry of second chain
601 for (unsigned r
= 0; r
< 2; r
++)
603 std::vector
<Node
> tchildrenr
;
604 // first rewrite children[0], then args[0]
605 sargs
[0] = r
== 0 ? children
[0] : args
[0];
607 Node eq
= expandMacros(PfRule::MACRO_SR_EQ_INTRO
, schildren
, sargs
, cdp
);
608 Trace("smt-proof-pp-debug")
609 << "transform subs_rewrite (" << r
<< "): " << eq
<< std::endl
;
610 Assert(!eq
.isNull() && eq
.getKind() == EQUAL
&& eq
[0] == sargs
[0]);
611 addToTransChildren(eq
, tchildrenr
);
612 // apply_SR(t) = toWitness(apply_SR(t))
615 Node weq
= addProofForWitnessForm(eq
[1], cdp
);
616 Trace("smt-proof-pp-debug")
617 << "transform toWitness (" << r
<< "): " << weq
<< std::endl
;
618 if (addToTransChildren(weq
, tchildrenr
))
620 // toWitness(apply_SR(t)) = apply_SR(toWitness(apply_SR(t)))
621 // rewrite again, don't need substitution. Also, we always use the
622 // default rewriter, due to the definition of MACRO_SR_PRED_TRANSFORM.
624 expandMacros(PfRule::MACRO_SR_EQ_INTRO
, {}, {weq
[1]}, cdp
);
625 Trace("smt-proof-pp-debug") << "transform rewrite_witness (" << r
626 << "): " << weqr
<< std::endl
;
627 addToTransChildren(weqr
, tchildrenr
);
630 Trace("smt-proof-pp-debug")
631 << "transform connect (" << r
<< ")" << std::endl
;
632 // add to overall chain
635 // add the current chain to the overall chain
636 tchildren
.insert(tchildren
.end(), tchildrenr
.begin(), tchildrenr
.end());
640 // add the current chain to cdp
641 Node eqr
= addProofForTrans(tchildrenr
, cdp
);
644 Trace("smt-proof-pp-debug") << "transform connect sym " << tchildren
645 << " " << eqr
<< std::endl
;
646 // take symmetry of above and add it to the overall chain
647 addToTransChildren(eqr
, tchildren
, true);
650 Trace("smt-proof-pp-debug")
651 << "transform finish (" << r
<< ")" << std::endl
;
654 // apply transitivity if necessary
655 Node eq
= addProofForTrans(tchildren
, cdp
);
657 cdp
->addStep(args
[0], PfRule::EQ_RESOLVE
, {children
[0], eq
}, {});
660 else if (id
== PfRule::MACRO_RESOLUTION
661 || id
== PfRule::MACRO_RESOLUTION_TRUST
)
663 // first generate the naive chain_resolution
664 std::vector
<Node
> chainResArgs
{args
.begin() + 1, args
.end()};
665 Node chainConclusion
= d_pnm
->getChecker()->checkDebug(
666 PfRule::CHAIN_RESOLUTION
, children
, chainResArgs
, Node::null(), "");
667 Trace("smt-proof-pp-debug") << "Original conclusion: " << args
[0] << "\n";
668 Trace("smt-proof-pp-debug")
669 << "chainRes conclusion: " << chainConclusion
<< "\n";
670 // There are n cases:
671 // - if the conclusion is the same, just replace
672 // - if they have the same literals but in different quantity, add a
674 // - if the order is not the same, add a REORDERING step
675 // - if there are literals in chainConclusion that are not in the original
676 // conclusion, we need to transform the MACRO_RESOLUTION into a series of
677 // CHAIN_RESOLUTION + FACTORING steps, so that we explicitly eliminate all
678 // these "crowding" literals. We do this via FACTORING so we avoid adding
679 // an exponential number of premises, which would happen if we just
680 // repeated in the premises the clauses needed for eliminating crowding
681 // literals, which could themselves add crowding literals.
682 if (chainConclusion
== args
[0])
685 chainConclusion
, PfRule::CHAIN_RESOLUTION
, children
, chainResArgs
);
686 return chainConclusion
;
688 NodeManager
* nm
= NodeManager::currentNM();
689 // If we got here, then chainConclusion is NECESSARILY an OR node
690 Assert(chainConclusion
.getKind() == kind::OR
);
691 // get the literals in the chain conclusion
692 std::vector
<Node
> chainConclusionLits
{chainConclusion
.begin(),
693 chainConclusion
.end()};
694 std::set
<Node
> chainConclusionLitsSet
{chainConclusion
.begin(),
695 chainConclusion
.end()};
696 // is args[0] a singleton clause? If it's not an OR node, then yes.
697 // Otherwise, it's only a singleton if it occurs in chainConclusionLitsSet
698 std::vector
<Node
> conclusionLits
;
699 // whether conclusion is singleton
700 if (chainConclusionLitsSet
.count(args
[0]))
702 conclusionLits
.push_back(args
[0]);
706 Assert(args
[0].getKind() == kind::OR
);
707 conclusionLits
.insert(
708 conclusionLits
.end(), args
[0].begin(), args
[0].end());
710 std::set
<Node
> conclusionLitsSet
{conclusionLits
.begin(),
711 conclusionLits
.end()};
712 // If the sets are different, there are "crowding" literals, i.e. literals
713 // that were removed by implicit multi-usage of premises in the resolution
715 if (chainConclusionLitsSet
!= conclusionLitsSet
)
717 chainConclusion
= eliminateCrowdingLits(
718 chainConclusionLits
, conclusionLits
, children
, args
, cdp
);
719 // update vector of lits. Note that the set is no longer used, so we don't
722 // We need again to check whether chainConclusion is a singleton
723 // clause. As above, it's a singleton if it's in the original
724 // chainConclusionLitsSet.
725 chainConclusionLits
.clear();
726 if (chainConclusionLitsSet
.count(chainConclusion
))
728 chainConclusionLits
.push_back(chainConclusion
);
732 Assert(chainConclusion
.getKind() == kind::OR
);
733 chainConclusionLits
.insert(chainConclusionLits
.end(),
734 chainConclusion
.begin(),
735 chainConclusion
.end());
741 chainConclusion
, PfRule::CHAIN_RESOLUTION
, children
, chainResArgs
);
743 Trace("smt-proof-pp-debug")
744 << "Conclusion after chain_res/elimCrowd: " << chainConclusion
<< "\n";
745 Trace("smt-proof-pp-debug")
746 << "Conclusion lits: " << chainConclusionLits
<< "\n";
747 // Placeholder for running conclusion
748 Node n
= chainConclusion
;
750 if (chainConclusionLits
.size() != conclusionLits
.size())
752 // We build it rather than taking conclusionLits because the order may be
754 std::vector
<Node
> factoredLits
;
755 std::unordered_set
<TNode
> clauseSet
;
756 for (size_t i
= 0, size
= chainConclusionLits
.size(); i
< size
; ++i
)
758 if (clauseSet
.count(chainConclusionLits
[i
]))
762 factoredLits
.push_back(n
[i
]);
763 clauseSet
.insert(n
[i
]);
765 Node factored
= factoredLits
.empty()
767 : factoredLits
.size() == 1
769 : nm
->mkNode(kind::OR
, factoredLits
);
770 cdp
->addStep(factored
, PfRule::FACTORING
, {n
}, {});
773 // either same node or n as a clause
774 Assert(n
== args
[0] || n
.getKind() == kind::OR
);
778 cdp
->addStep(args
[0], PfRule::REORDERING
, {n
}, {args
[0]});
782 else if (id
== PfRule::SUBS
)
784 NodeManager
* nm
= NodeManager::currentNM();
785 // Notice that a naive way to reconstruct SUBS is to do a term conversion
786 // proof for each substitution.
787 // The proof of f(a) * { a -> g(b) } * { b -> c } = f(g(c)) is:
788 // TRANS( CONG{f}( a=g(b) ), CONG{f}( CONG{g}( b=c ) ) )
789 // Notice that more optimal proofs are possible that do a single traversal
790 // over t. This is done by applying later substitutions to the range of
791 // previous substitutions, until a final simultaneous substitution is
792 // applied to t. For instance, in the above example, we first prove:
794 // by applying the second substitution { b -> c } to the range of the first,
795 // giving us a proof of g(b)=g(c). We then construct the updated proof
797 // TRANS( a=g(b), CONG{g}( b=c ) )
798 // We then apply the substitution { a -> g(c), b -> c } to f(a), to obtain:
799 // CONG{f}( TRANS( a=g(b), CONG{g}( b=c ) ) )
800 // which notice is more compact than the proof above.
802 // get the kind of substitution
803 MethodId ids
= MethodId::SB_DEFAULT
;
804 if (args
.size() >= 2)
806 builtin::BuiltinProofRuleChecker::getMethodId(args
[1], ids
);
808 MethodId ida
= MethodId::SBA_SEQUENTIAL
;
809 if (args
.size() >= 3)
811 builtin::BuiltinProofRuleChecker::getMethodId(args
[2], ida
);
813 std::vector
<std::shared_ptr
<CDProof
>> pfs
;
814 std::vector
<TNode
> vsList
;
815 std::vector
<TNode
> ssList
;
816 std::vector
<TNode
> fromList
;
817 std::vector
<ProofGenerator
*> pgs
;
818 // first, compute the entire substitution
819 for (size_t i
= 0, nchild
= children
.size(); i
< nchild
; i
++)
821 // get the substitution
822 builtin::BuiltinProofRuleChecker::getSubstitutionFor(
823 children
[i
], vsList
, ssList
, fromList
, ids
);
824 // ensure proofs for each formula in fromList
825 if (children
[i
].getKind() == AND
&& ids
== MethodId::SB_DEFAULT
)
827 for (size_t j
= 0, nchildi
= children
[i
].getNumChildren(); j
< nchildi
;
830 Node nodej
= nm
->mkConst(Rational(j
));
832 children
[i
][j
], PfRule::AND_ELIM
, {children
[i
]}, {nodej
});
836 std::vector
<Node
> vvec
;
837 std::vector
<Node
> svec
;
838 for (size_t i
= 0, nvs
= vsList
.size(); i
< nvs
; i
++)
840 // Note we process in forward order, since later substitution should be
841 // applied to earlier ones, and the last child of a SUBS is processed
843 TNode var
= vsList
[i
];
844 TNode subs
= ssList
[i
];
845 TNode childFrom
= fromList
[i
];
846 Trace("smt-proof-pp-debug")
847 << "...process " << var
<< " -> " << subs
<< " (" << childFrom
<< ", "
848 << ids
<< ")" << std::endl
;
849 // apply the current substitution to the range
850 if (!vvec
.empty() && ida
== MethodId::SBA_SEQUENTIAL
)
853 subs
.substitute(vvec
.begin(), vvec
.end(), svec
.begin(), svec
.end());
856 Trace("smt-proof-pp-debug")
857 << "......updated to " << var
<< " -> " << ss
858 << " based on previous substitution" << std::endl
;
859 // make the proof for the tranitivity step
860 std::shared_ptr
<CDProof
> pf
= std::make_shared
<CDProof
>(d_pnm
);
862 // prove the updated substitution
863 TConvProofGenerator
tcg(d_pnm
,
866 TConvCachePolicy::NEVER
,
867 "nested_SUBS_TConvProofGenerator",
870 // add previous rewrite steps
871 for (unsigned j
= 0, nvars
= vvec
.size(); j
< nvars
; j
++)
873 // substitutions are pre-rewrites
874 tcg
.addRewriteStep(vvec
[j
], svec
[j
], pgs
[j
], true);
876 // get the proof for the update to the current substitution
877 Node seqss
= subs
.eqNode(ss
);
878 std::shared_ptr
<ProofNode
> pfn
= tcg
.getProofFor(seqss
);
879 Assert(pfn
!= nullptr);
882 // get proof for childFrom from cdp
883 pfn
= cdp
->getProofFor(childFrom
);
885 // ensure we have a proof of var = subs
886 Node veqs
= addProofForSubsStep(var
, subs
, childFrom
, pf
.get());
888 pf
->addStep(var
.eqNode(ss
), PfRule::TRANS
, {veqs
, seqss
}, {});
889 // add to the substitution
892 pgs
.push_back(pf
.get());
896 // Just use equality from CDProof, but ensure we have a proof in cdp.
897 // This may involve a TRUE_INTRO/FALSE_INTRO if the substitution step
898 // uses the assumption childFrom as a Boolean assignment (e.g.
899 // childFrom = true if we are using MethodId::SB_LITERAL).
900 addProofForSubsStep(var
, subs
, childFrom
, cdp
);
902 svec
.push_back(subs
);
905 // should be implied by the substitution now
906 TConvPolicy tcpolicy
= ida
== MethodId::SBA_FIXPOINT
? TConvPolicy::FIXPOINT
908 TConvProofGenerator
tcpg(d_pnm
,
911 TConvCachePolicy::NEVER
,
912 "SUBS_TConvProofGenerator",
915 for (unsigned j
= 0, nvars
= vvec
.size(); j
< nvars
; j
++)
917 // substitutions are pre-rewrites
918 tcpg
.addRewriteStep(vvec
[j
], svec
[j
], pgs
[j
], true);
920 // add the proof constructed by the term conversion utility
921 std::shared_ptr
<ProofNode
> pfn
= tcpg
.getProofForRewriting(t
);
922 Node eq
= pfn
->getResult();
923 Node ts
= builtin::BuiltinProofRuleChecker::applySubstitution(
924 t
, children
, ids
, ida
);
925 Node eqq
= t
.eqNode(ts
);
930 // should give a proof, if not, then tcpg does not agree with the
932 Assert(pfn
!= nullptr);
935 AlwaysAssert(false) << "resort to TRUST_SUBS" << std::endl
938 << "from " << children
<< " applied to " << t
;
939 cdp
->addStep(eqq
, PfRule::TRUST_SUBS
, {}, {eqq
});
947 else if (id
== PfRule::REWRITE
)
949 // get the kind of rewrite
950 MethodId idr
= MethodId::RW_REWRITE
;
951 if (args
.size() >= 2)
953 builtin::BuiltinProofRuleChecker::getMethodId(args
[1], idr
);
955 builtin::BuiltinProofRuleChecker
* builtinPfC
=
956 static_cast<builtin::BuiltinProofRuleChecker
*>(
957 d_pnm
->getChecker()->getCheckerFor(PfRule::REWRITE
));
958 Node ret
= builtinPfC
->applyRewrite(args
[0], idr
);
959 Node eq
= args
[0].eqNode(ret
);
960 if (idr
== MethodId::RW_REWRITE
|| idr
== MethodId::RW_REWRITE_EQ_EXT
)
962 // rewrites from theory::Rewriter
963 bool isExtEq
= (idr
== MethodId::RW_REWRITE_EQ_EXT
);
964 // use rewrite with proof interface
965 Rewriter
* rr
= d_smte
->getRewriter();
966 TrustNode trn
= rr
->rewriteWithProof(args
[0], isExtEq
);
967 std::shared_ptr
<ProofNode
> pfn
= trn
.toProofNode();
970 Trace("smt-proof-pp-debug")
971 << "Use TRUST_REWRITE for " << eq
<< std::endl
;
972 // did not have a proof of rewriting, probably isExtEq is true
975 // update to THEORY_REWRITE with idr
976 Assert(args
.size() >= 1);
977 TheoryId theoryId
= Theory::theoryOf(args
[0].getType());
978 Node tid
= builtin::BuiltinProofRuleChecker::mkTheoryIdNode(theoryId
);
979 cdp
->addStep(eq
, PfRule::THEORY_REWRITE
, {}, {eq
, tid
, args
[1]});
983 // this should never be applied
984 cdp
->addStep(eq
, PfRule::TRUST_REWRITE
, {}, {eq
});
991 Assert(trn
.getNode() == ret
)
992 << "Unexpected rewrite " << args
[0] << std::endl
993 << "Got: " << trn
.getNode() << std::endl
994 << "Expected: " << ret
;
996 else if (idr
== MethodId::RW_EVALUATE
)
998 // change to evaluate, which is never eliminated
999 cdp
->addStep(eq
, PfRule::EVALUATE
, {}, {args
[0]});
1003 // don't know how to eliminate
1004 return Node::null();
1008 // should not be necessary typically
1009 cdp
->addStep(eq
, PfRule::REFL
, {}, {args
[0]});
1013 else if (id
== PfRule::THEORY_REWRITE
)
1015 Assert(!args
.empty());
1017 Assert(eq
.getKind() == EQUAL
);
1018 // try to replay theory rewrite
1019 // first, check that maybe its just an evaluation step
1020 ProofChecker
* pc
= d_pnm
->getChecker();
1022 pc
->checkDebug(PfRule::EVALUATE
, {}, {eq
[0]}, eq
, "smt-proof-pp-debug");
1023 if (!ceval
.isNull() && ceval
== eq
)
1025 cdp
->addStep(eq
, PfRule::EVALUATE
, {}, {eq
[0]});
1028 // otherwise no update
1029 Trace("final-pf-hole") << "hole: " << id
<< " : " << eq
<< std::endl
;
1031 else if (id
== PfRule::MACRO_ARITH_SCALE_SUM_UB
)
1033 Debug("macro::arith") << "Expand MACRO_ARITH_SCALE_SUM_UB" << std::endl
;
1034 if (Debug
.isOn("macro::arith"))
1036 for (const auto& child
: children
)
1038 Debug("macro::arith") << " child: " << child
<< std::endl
;
1040 Debug("macro::arith") << " args: " << args
<< std::endl
;
1042 Assert(args
.size() == children
.size());
1043 NodeManager
* nm
= NodeManager::currentNM();
1044 ProofStepBuffer steps
{d_pnm
->getChecker()};
1046 // Scale all children, accumulating
1047 std::vector
<Node
> scaledRels
;
1048 for (size_t i
= 0; i
< children
.size(); ++i
)
1050 TNode child
= children
[i
];
1051 TNode scalar
= args
[i
];
1052 bool isPos
= scalar
.getConst
<Rational
>() > 0;
1054 nm
->mkNode(isPos
? GT
: LT
, scalar
, nm
->mkConst(Rational(0)));
1055 // (= scalarCmp true)
1056 Node scalarCmpOrTrue
= steps
.tryStep(PfRule::EVALUATE
, {}, {scalarCmp
});
1057 Assert(!scalarCmpOrTrue
.isNull());
1059 steps
.addStep(PfRule::TRUE_ELIM
, {scalarCmpOrTrue
}, {}, scalarCmp
);
1060 // (and scalarCmp relation)
1061 Node scalarCmpAndRel
=
1062 steps
.tryStep(PfRule::AND_INTRO
, {scalarCmp
, child
}, {});
1063 Assert(!scalarCmpAndRel
.isNull());
1064 // (=> (and scalarCmp relation) scaled)
1066 steps
.tryStep(isPos
? PfRule::ARITH_MULT_POS
: PfRule::ARITH_MULT_NEG
,
1069 Assert(!impl
.isNull());
1072 steps
.tryStep(PfRule::MODUS_PONENS
, {scalarCmpAndRel
, impl
}, {});
1073 Assert(!scaled
.isNull());
1074 scaledRels
.emplace_back(scaled
);
1077 Node sumBounds
= steps
.tryStep(PfRule::ARITH_SUM_UB
, scaledRels
, {});
1078 cdp
->addSteps(steps
);
1079 Debug("macro::arith") << "Expansion done. Proved: " << sumBounds
1084 // TRUST, PREPROCESS, THEORY_LEMMA, THEORY_PREPROCESS?
1086 return Node::null();
1089 Node
ProofPostprocessCallback::addProofForWitnessForm(Node t
, CDProof
* cdp
)
1091 Node tw
= SkolemManager::getOriginalForm(t
);
1092 Node eq
= t
.eqNode(tw
);
1095 // not necessary, add REFL step
1096 cdp
->addStep(eq
, PfRule::REFL
, {}, {t
});
1099 std::shared_ptr
<ProofNode
> pn
= d_wfpm
.getProofFor(eq
);
1107 Assert(false) << "ProofPostprocessCallback::addProofForWitnessForm: failed "
1108 "to add proof for witness form of "
1114 Node
ProofPostprocessCallback::addProofForTrans(
1115 const std::vector
<Node
>& tchildren
, CDProof
* cdp
)
1117 size_t tsize
= tchildren
.size();
1120 Node lhs
= tchildren
[0][0];
1121 Node rhs
= tchildren
[tsize
- 1][1];
1122 Node eq
= lhs
.eqNode(rhs
);
1123 cdp
->addStep(eq
, PfRule::TRANS
, tchildren
, {});
1126 else if (tsize
== 1)
1128 return tchildren
[0];
1130 return Node::null();
1133 Node
ProofPostprocessCallback::addProofForSubsStep(Node var
,
1138 // ensure we have a proof of var = subs
1139 Node veqs
= var
.eqNode(subs
);
1142 // should be true intro or false intro
1143 Assert(subs
.isConst());
1146 subs
.getConst
<bool>() ? PfRule::TRUE_INTRO
: PfRule::FALSE_INTRO
,
1153 bool ProofPostprocessCallback::addToTransChildren(Node eq
,
1154 std::vector
<Node
>& tchildren
,
1157 Assert(!eq
.isNull());
1158 Assert(eq
.getKind() == kind::EQUAL
);
1163 Node equ
= isSymm
? eq
[1].eqNode(eq
[0]) : eq
;
1164 Assert(tchildren
.empty()
1165 || (tchildren
[tchildren
.size() - 1].getKind() == kind::EQUAL
1166 && tchildren
[tchildren
.size() - 1][1] == equ
[0]));
1167 tchildren
.push_back(equ
);
1171 ProofPostprocessFinalCallback::ProofPostprocessFinalCallback(
1172 ProofNodeManager
* pnm
)
1173 : d_ruleCount(smtStatisticsRegistry().registerHistogram
<PfRule
>(
1174 "finalProof::ruleCount")),
1176 smtStatisticsRegistry().registerInt("finalProof::totalRuleCount")),
1178 smtStatisticsRegistry().registerInt("finalProof::minPedanticLevel")),
1180 smtStatisticsRegistry().registerInt("finalProofs::numFinalProofs")),
1182 d_pedanticFailure(false)
1184 d_minPedanticLevel
+= 10;
1187 void ProofPostprocessFinalCallback::initializeUpdate()
1189 d_pedanticFailure
= false;
1190 d_pedanticFailureOut
.str("");
1194 bool ProofPostprocessFinalCallback::shouldUpdate(std::shared_ptr
<ProofNode
> pn
,
1195 const std::vector
<Node
>& fa
,
1196 bool& continueUpdate
)
1198 PfRule r
= pn
->getRule();
1199 // if not doing eager pedantic checking, fail if below threshold
1200 if (!options::proofEagerChecking())
1202 if (!d_pedanticFailure
)
1204 Assert(d_pedanticFailureOut
.str().empty());
1205 if (d_pnm
->getChecker()->isPedanticFailure(r
, d_pedanticFailureOut
))
1207 d_pedanticFailure
= true;
1211 uint32_t plevel
= d_pnm
->getChecker()->getPedanticLevel(r
);
1214 d_minPedanticLevel
.minAssign(plevel
);
1216 // record stats for the rule
1222 bool ProofPostprocessFinalCallback::wasPedanticFailure(std::ostream
& out
) const
1224 if (d_pedanticFailure
)
1226 out
<< d_pedanticFailureOut
.str();
1232 ProofPostproccess::ProofPostproccess(ProofNodeManager
* pnm
,
1234 ProofGenerator
* pppg
,
1235 bool updateScopedAssumptions
)
1237 d_cb(pnm
, smte
, pppg
, updateScopedAssumptions
),
1238 // the update merges subproofs
1239 d_updater(d_pnm
, d_cb
, true),
1241 d_finalizer(d_pnm
, d_finalCb
)
1245 ProofPostproccess::~ProofPostproccess() {}
1247 void ProofPostproccess::process(std::shared_ptr
<ProofNode
> pf
)
1249 // Initialize the callback, which computes necessary static information about
1250 // how to process, including how to process assumptions in pf.
1251 d_cb
.initializeUpdate();
1253 d_updater
.process(pf
);
1254 // take stats and check pedantic
1255 d_finalCb
.initializeUpdate();
1256 d_finalizer
.process(pf
);
1258 std::stringstream serr
;
1259 bool wasPedanticFailure
= d_finalCb
.wasPedanticFailure(serr
);
1260 if (wasPedanticFailure
)
1262 AlwaysAssert(!wasPedanticFailure
)
1263 << "ProofPostproccess::process: pedantic failure:" << std::endl
1268 void ProofPostproccess::setEliminateRule(PfRule rule
)
1270 d_cb
.setEliminateRule(rule
);