git.libre-soc.org Git - buildroot.git/blob

   1 From 24ba28680abe868e8db3442a9bf523ad3af1febd Mon Sep 17 00:00:00 2001
   2 From: Fabio Estevam <fabio.estevam@nxp.com>
   3 Date: Fri, 9 Mar 2018 08:25:00 -0300
   4 Subject: [PATCH] imximage: Remove failure when no IVT offset is found
   5
   6 Sometimes imximage throws the following error:
   7
   8   CFGS    board/freescale/vf610twr/imximage.cfg.cfgtmp
   9   CFGS    board/freescale/vf610twr/imximage.cfg.cfgtmp
  10   MKIMAGE u-boot-dtb.imx
  11 Error: No BOOT_FROM tag in board/freescale/vf610twr/imximage.cfg.cfgtmp
  12 arch/arm/mach-imx/Makefile:100: recipe for target 'u-boot-dtb.imx' failed
  13
  14 Later on, when running mkimage for the u-boot.imx it will succeed in
  15 finding the IVT offset.
  16
  17 Looks like some race condition happening during parallel build when
  18 processing mkimage for u-boot-dtb.imx and u-boot.imx.
  19
  20 A proper fix still needs to be implemented, but as a workaround let's
  21 remove the error when the IVT offset is not found.
  22
  23 It is useful to have such message, especially during bring-up phase,
  24 but the build error that it causes is severe, so better avoid the
  25 build error for now.
  26
  27 The error checking can be re-implemented later when we have a proper
  28 fix.
  29
  30 Reported-by: Breno Lima <breno.lima@nxp.com>
  31 Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
  32 Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
  33 ---
  34  tools/imximage.c | 5 -----
  35  1 file changed, 5 deletions(-)
  36
  37 diff --git a/tools/imximage.c b/tools/imximage.c
  38 index 0c43196..bef56f8 100644
  39 --- a/tools/imximage.c
  40 +++ b/tools/imximage.c
  41 @@ -765,11 +765,6 @@ static uint32_t parse_cfg_file(struct imx_header *imxhdr, char *name)
  42         (*set_dcd_rst)(imxhdr, dcd_len, name, lineno);
  43         fclose(fd);
  44
  45 -       /* Exit if there is no BOOT_FROM field specifying the flash_offset */
  46 -       if (imximage_ivt_offset == FLASH_OFFSET_UNDEFINED) {
  47 -               fprintf(stderr, "Error: No BOOT_FROM tag in %s\n", name);
  48 -               exit(EXIT_FAILURE);
  49 -       }
  50         return dcd_len;
  51  }
  52
  53 --
  54 2.7.4
  55