/* arsup.c - Archive support for MRI compatibility
- Copyright 1992-2013 2008 Free Software Foundation, Inc.
+ Copyright (C) 1992-2021 Free Software Foundation, Inc.
This file is part of GNU Binutils.
static bfd *obfd;
static char *real_name;
+static char *temp_name;
+static int temp_fd;
static FILE *outfile;
static void
want to hack multiple references. */
for (ptr = list; ptr; ptr = ptr->next)
{
- bfd_boolean found = FALSE;
+ bool found = false;
bfd *prev = arch;
for (head = arch->archive_next; head; head = head->archive_next)
{
- if (head->filename != NULL
- && FILENAME_CMP (ptr->name, head->filename) == 0)
+ if (bfd_get_filename (head) != NULL
+ && FILENAME_CMP (ptr->name, bfd_get_filename (head)) == 0)
{
- found = TRUE;
+ found = true;
function (head, prev);
}
prev = head;
static void
ar_directory_doer (bfd *abfd, bfd *ignore ATTRIBUTE_UNUSED)
{
- print_arelt_descr(outfile, abfd, verbose);
+ print_arelt_descr(outfile, abfd, verbose, false);
}
void
void
ar_open (char *name, int t)
{
- char *tname = (char *) xmalloc (strlen (name) + 10);
- const char *bname = lbasename (name);
- real_name = name;
+ real_name = xstrdup (name);
+ temp_name = make_tempname (real_name, &temp_fd);
- /* Prepend tmp- to the beginning, to avoid file-name clashes after
- truncation on filesystems with limited namespaces (DOS). */
- sprintf (tname, "%.*stmp-%s", (int) (bname - name), name, bname);
- obfd = bfd_openw (tname, NULL);
+ if (temp_name == NULL)
+ {
+ fprintf (stderr, _("%s: Can't open temporary file (%s)\n"),
+ program_name, strerror(errno));
+ maybequit ();
+ return;
+ }
+
+ obfd = bfd_fdopenw (temp_name, NULL, temp_fd);
if (!obfd)
{
fprintf (stderr,
_("%s: Can't open output archive %s\n"),
- program_name, tname);
+ program_name, temp_name);
maybequit ();
}
bfd *element;
bfd *ibfd;
+#if BFD_SUPPORTS_PLUGINS
+ ibfd = bfd_openr (name, "plugin");
+#else
ibfd = bfd_openr (name, NULL);
+#endif
if (!ibfd)
{
{
while (list)
{
- bfd *abfd = bfd_openr (list->name, NULL);
+ bfd *abfd;
+#if BFD_SUPPORTS_PLUGINS
+ abfd = bfd_openr (list->name, "plugin");
+#else
+ abfd = bfd_openr (list->name, NULL);
+#endif
if (!abfd)
{
fprintf (stderr, _("%s: can't open file %s\n"),
while (member)
{
- if (FILENAME_CMP(member->filename, list->name) == 0)
+ if (FILENAME_CMP (bfd_get_filename (member), list->name) == 0)
{
*prev = member->archive_next;
found = 1;
}
else
{
- char *ofilename = xstrdup (bfd_get_filename (obfd));
+ struct stat target_stat;
if (deterministic > 0)
obfd->flags |= BFD_DETERMINISTIC_OUTPUT;
+ temp_fd = dup (temp_fd);
bfd_close (obfd);
- smart_rename (ofilename, real_name, 0);
+ if (stat (real_name, &target_stat) != 0)
+ {
+ /* The temp file created in ar_open has mode 0600 as per mkstemp.
+ Create the real empty output file here so smart_rename will
+ update the mode according to the process umask. */
+ obfd = bfd_openw (real_name, NULL);
+ if (obfd != NULL)
+ {
+ bfd_set_format (obfd, bfd_archive);
+ bfd_close (obfd);
+ }
+ }
+
+ smart_rename (temp_name, real_name, temp_fd, NULL, false);
obfd = 0;
- free (ofilename);
+ free (temp_name);
+ free (real_name);
}
}
while (member)
{
- if (FILENAME_CMP (member->filename, list->name) == 0)
+ if (FILENAME_CMP (bfd_get_filename (member), list->name) == 0)
{
/* Found the one to replace. */
- bfd *abfd = bfd_openr (list->name, 0);
+ bfd *abfd = bfd_openr (list->name, NULL);
if (!abfd)
{
if (!found)
{
- bfd *abfd = bfd_openr (list->name, 0);
+ bfd *abfd = bfd_openr (list->name, NULL);
fprintf (stderr,_("%s: can't find module file %s\n"),
program_name, list->name);
while (member && !found)
{
- if (FILENAME_CMP (member->filename, list->name) == 0)
+ if (FILENAME_CMP (bfd_get_filename (member), list->name) == 0)
{
extract_file (member);
found = 1;
if (!found)
{
- bfd_openr (list->name, 0);
+ bfd_openr (list->name, NULL);
fprintf (stderr, _("%s: can't find module file %s\n"),
program_name, list->name);
}