Fix formatting of some dynamic tag fields to match readelf

[pyelftools.git] / examples / elf_relocations.py

diff --git a/examples/elf_relocations.py b/examples/elf_relocations.py
index a09f014706c297d013fda07ad6da01e4f4c4aa61..fd65541954c70119a2621a11f3bf244d61ea5e1b 100644 (file)
--- a/examples/elf_relocations.py
+++ b/examples/elf_relocations.py
@@ -9,38 +9,43 @@
 #-------------------------------------------------------------------------------
 from __future__ import print_function
 import sys
+
+# If elftools is not installed, maybe we're running from the root or examples
+# dir of the source distribution
+try:
+    import elftools
+except ImportError:
+    sys.path.extend(['.', '..'])
+
+from elftools.common.py3compat import bytes2str
 from elftools.elf.elffile import ELFFile
 from elftools.elf.relocation import RelocationSection
 
 
 def process_file(filename):
     print('Processing file:', filename)
-    with open(filename) as f:
+    with open(filename, 'rb') as f:
         elffile = ELFFile(f)
 
         # Read the .rela.dyn section from the file, by explicitly asking
         # ELFFile for this section
-        reladyn_name = '.rela.dyn'
+        # Recall that section names are bytes objects
+        reladyn_name = b'.rela.dyn'
         reladyn = elffile.get_section_by_name(reladyn_name)
 
         if not isinstance(reladyn, RelocationSection):
-            print('  The file has no %s section' % reladyn_name)
+            print('  The file has no %s section' % bytes2str(reladyn_name))
 
         print('  %s section with %s relocations' % (
-            reladyn_name, reladyn.num_relocations()))
+            bytes2str(reladyn_name), reladyn.num_relocations()))
 
         for reloc in reladyn.iter_relocations():
-            # Use the Relocation's object ability to pretty-print itself to a
-            # string to examine it
-            print('    ', reloc)
-
+            print('    Relocation (%s)' % 'RELA' if reloc.is_RELA() else 'REL')
             # Relocation entry attributes are available through item lookup
-            print('    offset = %s' % reloc['r_offset'])
+            print('      offset = %s' % reloc['r_offset'])
 
 
 if __name__ == '__main__':
     for filename in sys.argv[1:]:
         process_file(filename)
 
-
-