/* messages.c - error reporter -
- Copyright (C) 1987-2014 Free Software Foundation, Inc.
+ Copyright (C) 1987-2022 Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
GAS is free software; you can redistribute it and/or modify
02110-1301, USA. */
#include "as.h"
+#include <signal.h>
-static void identify (char *);
+/* If the system doesn't provide strsignal, we get it defined in
+ libiberty but no declaration is supplied. Because, reasons. */
+#if !defined (HAVE_STRSIGNAL) && !defined (strsignal)
+extern const char *strsignal (int);
+#endif
+
+static void identify (const char *);
static void as_show_where (void);
-static void as_warn_internal (char *, unsigned int, char *);
-static void as_bad_internal (char *, unsigned int, char *);
+static void as_warn_internal (const char *, unsigned int, char *);
+static void as_bad_internal (const char *, unsigned int, char *);
+static void signal_crash (int) ATTRIBUTE_NORETURN;
/* Despite the rest of the comments in this file, (FIXME-SOON),
here is the current scheme for error messages etc:
as_tsktsk() is used when we see a minor error for which
our error recovery action is almost certainly correct.
In this case, we print a message and then assembly
- continues as though no error occurred. */
+ continues as though no error occurred.
+
+ as_abort () is used for logic failure (assert or abort, signal).
+*/
static void
-identify (char *file)
+identify (const char *file)
{
static int identified;
if (!file)
{
unsigned int x;
- as_where (&file, &x);
+ file = as_where (&x);
}
if (file)
static void
as_show_where (void)
{
- char *file;
+ const char *file;
unsigned int line;
- as_where (&file, &line);
+ file = as_where (&line);
identify (file);
if (file)
{
/* The common portion of as_warn and as_warn_where. */
static void
-as_warn_internal (char *file, unsigned int line, char *buffer)
+as_warn_internal (const char *file, unsigned int line, char *buffer)
{
++warning_count;
if (file == NULL)
- as_where (&file, &line);
+ file = as_where (&line);
identify (file);
if (file)
{
if (line != 0)
- fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning:"), buffer);
+ fprintf (stderr, "%s:%u: %s%s\n", file, line, _("Warning: "), buffer);
else
- fprintf (stderr, "%s: %s %s\n", file, _("Warning:"), buffer);
+ fprintf (stderr, "%s: %s%s\n", file, _("Warning: "), buffer);
}
else
- fprintf (stderr, "%s %s\n", _("Warning:"), buffer);
+ fprintf (stderr, "%s%s\n", _("Warning: "), buffer);
#ifndef NO_LISTING
listing_warning (buffer);
#endif
the varargs correctly and portably. */
void
-as_warn_where (char *file, unsigned int line, const char *format, ...)
+as_warn_where (const char *file, unsigned int line, const char *format, ...)
{
va_list args;
char buffer[2000];
/* The common portion of as_bad and as_bad_where. */
static void
-as_bad_internal (char *file, unsigned int line, char *buffer)
+as_bad_internal (const char *file, unsigned int line, char *buffer)
{
++error_count;
if (file == NULL)
- as_where (&file, &line);
+ file = as_where (&line);
identify (file);
if (file)
{
if (line != 0)
- fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Error:"), buffer);
+ fprintf (stderr, "%s:%u: %s%s\n", file, line, _("Error: "), buffer);
else
- fprintf (stderr, "%s: %s %s\n", file, _("Error:"), buffer);
+ fprintf (stderr, "%s: %s%s\n", file, _("Error: "), buffer);
}
else
- fprintf (stderr, "%s %s\n", _("Error:"), buffer);
+ fprintf (stderr, "%s%s\n", _("Error: "), buffer);
#ifndef NO_LISTING
listing_error (buffer);
#endif
}
/* Send to stderr a string as a warning, and locate warning in input
- file(s). Please us when there is no recovery, but we want to
+ file(s). Please use when there is no recovery, but we want to
continue processing but not produce an object file.
Please explain in string (which may have '\n's) what recovery was
done. */
the varargs correctly and portably. */
void
-as_bad_where (char *file, unsigned int line, const char *format, ...)
+as_bad_where (const char *file, unsigned int line, const char *format, ...)
{
va_list args;
char buffer[2000];
xexit (EXIT_FAILURE);
}
-/* Indicate assertion failure.
- Arguments: Filename, line number, optional function name. */
+/* Indicate internal constency error.
+ Arguments: Filename, line number, optional function name.
+ FILENAME may be NULL, which we use for crash-via-signal. */
void
-as_assert (const char *file, int line, const char *fn)
+as_abort (const char *file, int line, const char *fn)
{
as_show_where ();
- fprintf (stderr, _("Internal error!\n"));
- if (fn)
- fprintf (stderr, _("Assertion failure in %s at %s line %d.\n"),
- fn, file, line);
+
+ if (!file)
+ fprintf (stderr, _("Internal error (%s).\n"), fn ? fn : "unknown");
+ else if (fn)
+ fprintf (stderr, _("Internal error in %s at %s:%d.\n"), fn, file, line);
else
- fprintf (stderr, _("Assertion failure at %s line %d.\n"), file, line);
+ fprintf (stderr, _("Internal error at %s:%d.\n"), file, line);
+
fprintf (stderr, _("Please report this bug.\n"));
+
xexit (EXIT_FAILURE);
}
-/* as_abort: Print a friendly message saying how totally hosed we are,
- and exit without producing a core file. */
+/* Handler for fatal signals, such as SIGSEGV. */
-void
-as_abort (const char *file, int line, const char *fn)
+static void
+signal_crash (int signo)
{
- as_show_where ();
- if (fn)
- fprintf (stderr, _("Internal error, aborting at %s line %d in %s\n"),
- file, line, fn);
- else
- fprintf (stderr, _("Internal error, aborting at %s line %d\n"),
- file, line);
- fprintf (stderr, _("Please report this bug.\n"));
- xexit (EXIT_FAILURE);
+ /* Reset, to prevent unbounded recursion. */
+ signal (signo, SIG_DFL);
+
+ as_abort (NULL, 0, strsignal (signo));
}
-/* Support routines. */
+/* Register signal handlers, for less abrubt crashes. */
void
-sprint_value (char *buf, valueT val)
+signal_init (void)
{
- if (sizeof (val) <= sizeof (long))
- {
- sprintf (buf, "%ld", (long) val);
- return;
- }
- if (sizeof (val) <= sizeof (bfd_vma))
- {
- sprintf_vma (buf, val);
- return;
- }
- abort ();
+#ifdef SIGSEGV
+ signal (SIGSEGV, signal_crash);
+#endif
+#ifdef SIGILL
+ signal (SIGILL, signal_crash);
+#endif
+#ifdef SIGBUS
+ signal (SIGBUS, signal_crash);
+#endif
+#ifdef SIGABRT
+ signal (SIGABRT, signal_crash);
+#endif
+#if defined SIGIOT && (!defined SIGABRT || SIGABRT != SIGIOT)
+ signal (SIGIOT, signal_crash);
+#endif
+#ifdef SIGFPE
+ signal (SIGFPE, signal_crash);
+#endif
}
+/* Support routines. */
+
#define HEX_MAX_THRESHOLD 1024
#define HEX_MIN_THRESHOLD -(HEX_MAX_THRESHOLD)
static void
-as_internal_value_out_of_range (char * prefix,
- offsetT val,
- offsetT min,
- offsetT max,
- char * file,
- unsigned line,
- int bad)
+as_internal_value_out_of_range (const char *prefix,
+ offsetT val,
+ offsetT min,
+ offsetT max,
+ const char *file,
+ unsigned line,
+ bool bad)
{
const char * err;
abort ();
/* xgettext:c-format */
- err = _("%s out of domain (%d is not a multiple of %d)");
+ err = _("%s out of domain (%" PRId64
+ " is not a multiple of %" PRId64 ")");
+
if (bad)
- as_bad_where (file, line, err,
- prefix, (int) val, (int) right);
+ as_bad_where (file, line, err, prefix, (int64_t) val, (int64_t) right);
else
- as_warn_where (file, line, err,
- prefix, (int) val, (int) right);
- return;
+ as_warn_where (file, line, err, prefix, (int64_t) val, (int64_t) right);
}
-
- if ( val < HEX_MAX_THRESHOLD
- && min < HEX_MAX_THRESHOLD
- && max < HEX_MAX_THRESHOLD
- && val > HEX_MIN_THRESHOLD
- && min > HEX_MIN_THRESHOLD
- && max > HEX_MIN_THRESHOLD)
+ else if ( val < HEX_MAX_THRESHOLD
+ && min < HEX_MAX_THRESHOLD
+ && max < HEX_MAX_THRESHOLD
+ && val > HEX_MIN_THRESHOLD
+ && min > HEX_MIN_THRESHOLD
+ && max > HEX_MIN_THRESHOLD)
{
- /* xgettext:c-format */
- err = _("%s out of range (%d is not between %d and %d)");
+ /* xgettext:c-format. */
+ err = _("%s out of range (%" PRId64
+ " is not between %" PRId64 " and %" PRId64 ")");
if (bad)
- as_bad_where (file, line, err,
- prefix, (int) val, (int) min, (int) max);
+ as_bad_where (file, line, err, prefix,
+ (int64_t) val, (int64_t) min, (int64_t) max);
else
- as_warn_where (file, line, err,
- prefix, (int) val, (int) min, (int) max);
+ as_warn_where (file, line, err, prefix,
+ (int64_t) val, (int64_t) min, (int64_t) max);
}
else
{
- char val_buf [sizeof (val) * 3 + 2];
- char min_buf [sizeof (val) * 3 + 2];
- char max_buf [sizeof (val) * 3 + 2];
-
- if (sizeof (val) > sizeof (bfd_vma))
- abort ();
-
- sprintf_vma (val_buf, (bfd_vma) val);
- sprintf_vma (min_buf, (bfd_vma) min);
- sprintf_vma (max_buf, (bfd_vma) max);
-
/* xgettext:c-format. */
- err = _("%s out of range (0x%s is not between 0x%s and 0x%s)");
+ err = _("%s out of range (0x%" PRIx64
+ " is not between 0x%" PRIx64 " and 0x%" PRIx64 ")");
if (bad)
- as_bad_where (file, line, err, prefix, val_buf, min_buf, max_buf);
+ as_bad_where (file, line, err, prefix,
+ (int64_t) val, (int64_t) min, (int64_t) max);
else
- as_warn_where (file, line, err, prefix, val_buf, min_buf, max_buf);
+ as_warn_where (file, line, err, prefix,
+ (int64_t) val, (int64_t) min, (int64_t) max);
}
}
void
-as_warn_value_out_of_range (char * prefix,
- offsetT value,
- offsetT min,
- offsetT max,
- char * file,
+as_warn_value_out_of_range (const char *prefix,
+ offsetT value,
+ offsetT min,
+ offsetT max,
+ const char *file,
unsigned line)
{
- as_internal_value_out_of_range (prefix, value, min, max, file, line, 0);
+ as_internal_value_out_of_range (prefix, value, min, max, file, line, false);
}
void
-as_bad_value_out_of_range (char * prefix,
- offsetT value,
- offsetT min,
- offsetT max,
- char * file,
+as_bad_value_out_of_range (const char *prefix,
+ offsetT value,
+ offsetT min,
+ offsetT max,
+ const char *file,
unsigned line)
{
- as_internal_value_out_of_range (prefix, value, min, max, file, line, 1);
+ as_internal_value_out_of_range (prefix, value, min, max, file, line, true);
}