fix PR 86484 and PR 84543
[gcc.git] / gcc / fortran / trans-stmt.c
index 1bd131e7f8b2af6425f4e51bdd397a9598805cb5..795d3cc0a13c2033a3ca2e2a5e5eb971179d568d 100644 (file)
@@ -1,5 +1,5 @@
 /* Statement translation -- generate GCC trees from gfc_code.
-   Copyright (C) 2002-2015 Free Software Foundation, Inc.
+   Copyright (C) 2002-2018 Free Software Foundation, Inc.
    Contributed by Paul Brook <paul@nowt.org>
    and Steven Bosscher <s.bosscher@student.tudelft.nl>
 
@@ -23,19 +23,16 @@ along with GCC; see the file COPYING3.  If not see
 #include "config.h"
 #include "system.h"
 #include "coretypes.h"
-#include "alias.h"
-#include "tree.h"
 #include "options.h"
-#include "fold-const.h"
-#include "stringpool.h"
+#include "tree.h"
 #include "gfortran.h"
-#include "flags.h"
 #include "trans.h"
+#include "stringpool.h"
+#include "fold-const.h"
 #include "trans-stmt.h"
 #include "trans-types.h"
 #include "trans-array.h"
 #include "trans-const.h"
-#include "arith.h"
 #include "dependency.h"
 
 typedef struct iter_info
@@ -115,7 +112,7 @@ gfc_trans_label_assign (gfc_code * code)
       || code->label1->defined == ST_LABEL_DO_TARGET)
     {
       label_tree = gfc_build_addr_expr (pvoid_type_node, label_tree);
-      len_tree = integer_minus_one_node;
+      len_tree = build_int_cst (gfc_charlen_type_node, -1);
     }
   else
     {
@@ -128,7 +125,7 @@ gfc_trans_label_assign (gfc_code * code)
       label_tree = gfc_build_addr_expr (pvoid_type_node, label_tree);
     }
 
-  gfc_add_modify (&se.pre, len, len_tree);
+  gfc_add_modify (&se.pre, len, fold_convert (TREE_TYPE (len), len_tree));
   gfc_add_modify (&se.pre, addr, label_tree);
 
   return gfc_finish_block (&se.pre);
@@ -153,7 +150,7 @@ gfc_trans_goto (gfc_code * code)
   gfc_start_block (&se.pre);
   gfc_conv_label_variable (&se, code->expr1);
   tmp = GFC_DECL_STRING_LEN (se.expr);
-  tmp = fold_build2_loc (input_location, NE_EXPR, boolean_type_node, tmp,
+  tmp = fold_build2_loc (input_location, NE_EXPR, logical_type_node, tmp,
                         build_int_cst (TREE_TYPE (tmp), -1));
   gfc_trans_runtime_check (true, false, tmp, &se.pre, &loc,
                           "Assigned label is not a target label");
@@ -455,7 +452,11 @@ gfc_trans_call (gfc_code * code, bool dependency_check,
         subscripts.  This could be prevented in the elemental case
         as temporaries are handled separatedly
         (below in gfc_conv_elemental_dependencies).  */
-      gfc_conv_loop_setup (&loop, &code->expr1->where);
+      if (code->expr1)
+       gfc_conv_loop_setup (&loop, &code->expr1->where);
+      else
+       gfc_conv_loop_setup (&loop, &code->loc);
+
       gfc_mark_ss_chain_used (ss, 1);
 
       /* Convert the arguments, checking for dependencies.  */
@@ -577,7 +578,7 @@ gfc_trans_return (gfc_code * code)
 tree
 gfc_trans_pause (gfc_code * code)
 {
-  tree gfc_int4_type_node = gfc_get_int_type (4);
+  tree gfc_int8_type_node = gfc_get_int_type (8);
   gfc_se se;
   tree tmp;
 
@@ -588,7 +589,7 @@ gfc_trans_pause (gfc_code * code)
 
   if (code->expr1 == NULL)
     {
-      tmp = build_int_cst (gfc_int4_type_node, 0);
+      tmp = build_int_cst (size_type_node, 0);
       tmp = build_call_expr_loc (input_location,
                                 gfor_fndecl_pause_string, 2,
                                 build_int_cst (pchar_type_node, 0), tmp);
@@ -598,14 +599,15 @@ gfc_trans_pause (gfc_code * code)
       gfc_conv_expr (&se, code->expr1);
       tmp = build_call_expr_loc (input_location,
                                 gfor_fndecl_pause_numeric, 1,
-                                fold_convert (gfc_int4_type_node, se.expr));
+                                fold_convert (gfc_int8_type_node, se.expr));
     }
   else
     {
       gfc_conv_expr_reference (&se, code->expr1);
       tmp = build_call_expr_loc (input_location,
                             gfor_fndecl_pause_string, 2,
-                            se.expr, se.string_length);
+                                se.expr, fold_convert (size_type_node,
+                                                       se.string_length));
     }
 
   gfc_add_expr_to_block (&se.pre, tmp);
@@ -622,7 +624,6 @@ gfc_trans_pause (gfc_code * code)
 tree
 gfc_trans_stop (gfc_code *code, bool error_stop)
 {
-  tree gfc_int4_type_node = gfc_get_int_type (4);
   gfc_se se;
   tree tmp;
 
@@ -632,14 +633,17 @@ gfc_trans_stop (gfc_code *code, bool error_stop)
 
   if (code->expr1 == NULL)
     {
-      tmp = build_int_cst (gfc_int4_type_node, 0);
+      tmp = build_int_cst (size_type_node, 0);
       tmp = build_call_expr_loc (input_location,
                                 error_stop
                                 ? (flag_coarray == GFC_FCOARRAY_LIB
                                    ? gfor_fndecl_caf_error_stop_str
                                    : gfor_fndecl_error_stop_string)
-                                : gfor_fndecl_stop_string,
-                                2, build_int_cst (pchar_type_node, 0), tmp);
+                                : (flag_coarray == GFC_FCOARRAY_LIB
+                                   ? gfor_fndecl_caf_stop_str
+                                   : gfor_fndecl_stop_string),
+                                3, build_int_cst (pchar_type_node, 0), tmp,
+                                boolean_false_node);
     }
   else if (code->expr1->ts.type == BT_INTEGER)
     {
@@ -649,8 +653,11 @@ gfc_trans_stop (gfc_code *code, bool error_stop)
                                 ? (flag_coarray == GFC_FCOARRAY_LIB
                                    ? gfor_fndecl_caf_error_stop
                                    : gfor_fndecl_error_stop_numeric)
-                                : gfor_fndecl_stop_numeric_f08, 1,
-                                fold_convert (gfc_int4_type_node, se.expr));
+                                : (flag_coarray == GFC_FCOARRAY_LIB
+                                   ? gfor_fndecl_caf_stop_numeric
+                                   : gfor_fndecl_stop_numeric), 2,
+                                fold_convert (integer_type_node, se.expr),
+                                boolean_false_node);
     }
   else
     {
@@ -660,8 +667,12 @@ gfc_trans_stop (gfc_code *code, bool error_stop)
                                 ? (flag_coarray == GFC_FCOARRAY_LIB
                                    ? gfor_fndecl_caf_error_stop_str
                                    : gfor_fndecl_error_stop_string)
-                                : gfor_fndecl_stop_string,
-                                2, se.expr, se.string_length);
+                                : (flag_coarray == GFC_FCOARRAY_LIB
+                                   ? gfor_fndecl_caf_stop_str
+                                   : gfor_fndecl_stop_string),
+                                3, se.expr, fold_convert (size_type_node,
+                                                          se.string_length),
+                                boolean_false_node);
     }
 
   gfc_add_expr_to_block (&se.pre, tmp);
@@ -671,6 +682,128 @@ gfc_trans_stop (gfc_code *code, bool error_stop)
   return gfc_finish_block (&se.pre);
 }
 
+/* Translate the FAIL IMAGE statement.  */
+
+tree
+gfc_trans_fail_image (gfc_code *code ATTRIBUTE_UNUSED)
+{
+  if (flag_coarray == GFC_FCOARRAY_LIB)
+    return build_call_expr_loc (input_location,
+                               gfor_fndecl_caf_fail_image, 1,
+                               build_int_cst (pchar_type_node, 0));
+  else
+    {
+      const char *name = gfc_get_string (PREFIX ("exit_i%d"), 4);
+      gfc_symbol *exsym = gfc_get_intrinsic_sub_symbol (name);
+      tree tmp = gfc_get_symbol_decl (exsym);
+      return build_call_expr_loc (input_location, tmp, 1, integer_zero_node);
+    }
+}
+
+/* Translate the FORM TEAM statement.  */
+
+tree
+gfc_trans_form_team (gfc_code *code)
+{
+  if (flag_coarray == GFC_FCOARRAY_LIB)
+    {
+      gfc_se argse;
+      tree team_id,team_type;
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr1);
+      team_id = fold_convert (integer_type_node, argse.expr);
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr2);
+      team_type = gfc_build_addr_expr (ppvoid_type_node, argse.expr);
+
+      return build_call_expr_loc (input_location,
+                                 gfor_fndecl_caf_form_team, 3,
+                                 team_id, team_type,
+                                 build_int_cst (integer_type_node, 0));
+    }
+  else
+    {
+      const char *name = gfc_get_string (PREFIX ("exit_i%d"), 4);
+      gfc_symbol *exsym = gfc_get_intrinsic_sub_symbol (name);
+      tree tmp = gfc_get_symbol_decl (exsym);
+      return build_call_expr_loc (input_location, tmp, 1, integer_zero_node);
+    }
+}
+
+/* Translate the CHANGE TEAM statement.  */
+
+tree
+gfc_trans_change_team (gfc_code *code)
+{
+  if (flag_coarray == GFC_FCOARRAY_LIB)
+    {
+      gfc_se argse;
+      tree team_type;
+
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr1);
+      team_type = gfc_build_addr_expr (ppvoid_type_node, argse.expr);
+
+      return build_call_expr_loc (input_location,
+                                 gfor_fndecl_caf_change_team, 2, team_type,
+                                 build_int_cst (integer_type_node, 0));
+    }
+  else
+    {
+      const char *name = gfc_get_string (PREFIX ("exit_i%d"), 4);
+      gfc_symbol *exsym = gfc_get_intrinsic_sub_symbol (name);
+      tree tmp = gfc_get_symbol_decl (exsym);
+      return build_call_expr_loc (input_location, tmp, 1, integer_zero_node);
+    }
+}
+
+/* Translate the END TEAM statement.  */
+
+tree
+gfc_trans_end_team (gfc_code *code ATTRIBUTE_UNUSED)
+{
+  if (flag_coarray == GFC_FCOARRAY_LIB)
+    {
+      return build_call_expr_loc (input_location,
+                                 gfor_fndecl_caf_end_team, 1,
+                                 build_int_cst (pchar_type_node, 0));
+    }
+  else
+    {
+      const char *name = gfc_get_string (PREFIX ("exit_i%d"), 4);
+      gfc_symbol *exsym = gfc_get_intrinsic_sub_symbol (name);
+      tree tmp = gfc_get_symbol_decl (exsym);
+      return build_call_expr_loc (input_location, tmp, 1, integer_zero_node);
+    }
+}
+
+/* Translate the SYNC TEAM statement.  */
+
+tree
+gfc_trans_sync_team (gfc_code *code)
+{
+  if (flag_coarray == GFC_FCOARRAY_LIB)
+    {
+      gfc_se argse;
+      tree team_type;
+
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr1);
+      team_type = gfc_build_addr_expr (ppvoid_type_node, argse.expr);
+
+      return build_call_expr_loc (input_location,
+                                 gfor_fndecl_caf_sync_team, 2,
+                                 team_type,
+                                 build_int_cst (integer_type_node, 0));
+    }
+  else
+    {
+      const char *name = gfc_get_string (PREFIX ("exit_i%d"), 4);
+      gfc_symbol *exsym = gfc_get_intrinsic_sub_symbol (name);
+      tree tmp = gfc_get_symbol_decl (exsym);
+      return build_call_expr_loc (input_location, tmp, 1, integer_zero_node);
+    }
+}
 
 tree
 gfc_trans_lock_unlock (gfc_code *code, gfc_exec_op op)
@@ -722,7 +855,8 @@ gfc_trans_lock_unlock (gfc_code *code, gfc_exec_op op)
          return NULL_TREE;
        }
 
-      gfc_get_caf_token_offset (&token, NULL, caf_decl, NULL_TREE, code->expr1);
+      gfc_get_caf_token_offset (&se, &token, NULL, caf_decl, NULL_TREE,
+                               code->expr1);
 
       if (gfc_is_coindexed (code->expr1))
        image_index = gfc_caf_get_image_index (&se.pre, code->expr1, caf_decl);
@@ -779,15 +913,16 @@ gfc_trans_lock_unlock (gfc_code *code, gfc_exec_op op)
       if (code->expr3)
        {
          gfc_init_se (&argse, NULL);
+         argse.want_pointer = 1;
          gfc_conv_expr (&argse, code->expr3);
          gfc_add_block_to_block (&se.pre, &argse.pre);
          errmsg = argse.expr;
-         errmsg_len = fold_convert (integer_type_node, argse.string_length);
+         errmsg_len = fold_convert (size_type_node, argse.string_length);
        }
       else
        {
          errmsg = null_pointer_node;
-         errmsg_len = integer_zero_node;
+         errmsg_len = build_zero_cst (size_type_node);
        }
 
       if (stat != null_pointer_node && TREE_TYPE (stat) != integer_type_node)
@@ -820,6 +955,15 @@ gfc_trans_lock_unlock (gfc_code *code, gfc_exec_op op)
                                   errmsg, errmsg_len);
       gfc_add_expr_to_block (&se.pre, tmp);
 
+      /* It guarantees memory consistency within the same segment */
+      tmp = gfc_build_string_const (strlen ("memory")+1, "memory"),
+      tmp = build5_loc (input_location, ASM_EXPR, void_type_node,
+                       gfc_build_string_const (1, ""), NULL_TREE, NULL_TREE,
+                       tree_cons (NULL_TREE, tmp, NULL_TREE), NULL_TREE);
+      ASM_VOLATILE_P (tmp) = 1;
+
+      gfc_add_expr_to_block (&se.pre, tmp);
+
       if (stat2 != NULL_TREE)
        gfc_add_modify (&se.pre, stat2,
                        fold_convert (TREE_TYPE (stat2), stat));
@@ -843,6 +987,176 @@ gfc_trans_lock_unlock (gfc_code *code, gfc_exec_op op)
   return gfc_finish_block (&se.pre);
 }
 
+tree
+gfc_trans_event_post_wait (gfc_code *code, gfc_exec_op op)
+{
+  gfc_se se, argse;
+  tree stat = NULL_TREE, stat2 = NULL_TREE;
+  tree until_count = NULL_TREE;
+
+  if (code->expr2)
+    {
+      gcc_assert (code->expr2->expr_type == EXPR_VARIABLE);
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr2);
+      stat = argse.expr;
+    }
+  else if (flag_coarray == GFC_FCOARRAY_LIB)
+    stat = null_pointer_node;
+
+  if (code->expr4)
+    {
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr4);
+      until_count = fold_convert (integer_type_node, argse.expr);
+    }
+  else
+    until_count = integer_one_node;
+
+  if (flag_coarray != GFC_FCOARRAY_LIB)
+    {
+      gfc_start_block (&se.pre);
+      gfc_init_se (&argse, NULL);
+      gfc_conv_expr_val (&argse, code->expr1);
+
+      if (op == EXEC_EVENT_POST)
+       gfc_add_modify (&se.pre, argse.expr,
+                       fold_build2_loc (input_location, PLUS_EXPR,
+                               TREE_TYPE (argse.expr), argse.expr,
+                               build_int_cst (TREE_TYPE (argse.expr), 1)));
+      else
+       gfc_add_modify (&se.pre, argse.expr,
+                       fold_build2_loc (input_location, MINUS_EXPR,
+                               TREE_TYPE (argse.expr), argse.expr,
+                               fold_convert (TREE_TYPE (argse.expr),
+                                             until_count)));
+      if (stat != NULL_TREE)
+       gfc_add_modify (&se.pre, stat, build_int_cst (TREE_TYPE (stat), 0));
+
+      return gfc_finish_block (&se.pre);
+    }
+
+  gfc_start_block (&se.pre);
+  tree tmp, token, image_index, errmsg, errmsg_len;
+  tree index = size_zero_node;
+  tree caf_decl = gfc_get_tree_for_caf_expr (code->expr1);
+
+  if (code->expr1->symtree->n.sym->ts.type != BT_DERIVED
+      || code->expr1->symtree->n.sym->ts.u.derived->from_intmod
+        != INTMOD_ISO_FORTRAN_ENV
+      || code->expr1->symtree->n.sym->ts.u.derived->intmod_sym_id
+        != ISOFORTRAN_EVENT_TYPE)
+    {
+      gfc_error ("Sorry, the event component of derived type at %L is not "
+                "yet supported", &code->expr1->where);
+      return NULL_TREE;
+    }
+
+  gfc_init_se (&argse, NULL);
+  gfc_get_caf_token_offset (&argse, &token, NULL, caf_decl, NULL_TREE,
+                           code->expr1);
+  gfc_add_block_to_block (&se.pre, &argse.pre);
+
+  if (gfc_is_coindexed (code->expr1))
+    image_index = gfc_caf_get_image_index (&se.pre, code->expr1, caf_decl);
+  else
+    image_index = integer_zero_node;
+
+  /* For arrays, obtain the array index.  */
+  if (gfc_expr_attr (code->expr1).dimension)
+    {
+      tree desc, tmp, extent, lbound, ubound;
+      gfc_array_ref *ar, ar2;
+      int i;
+
+      /* TODO: Extend this, once DT components are supported.  */
+      ar = &code->expr1->ref->u.ar;
+      ar2 = *ar;
+      memset (ar, '\0', sizeof (*ar));
+      ar->as = ar2.as;
+      ar->type = AR_FULL;
+
+      gfc_init_se (&argse, NULL);
+      argse.descriptor_only = 1;
+      gfc_conv_expr_descriptor (&argse, code->expr1);
+      gfc_add_block_to_block (&se.pre, &argse.pre);
+      desc = argse.expr;
+      *ar = ar2;
+
+      extent = integer_one_node;
+      for (i = 0; i < ar->dimen; i++)
+       {
+         gfc_init_se (&argse, NULL);
+         gfc_conv_expr_type (&argse, ar->start[i], integer_type_node);
+         gfc_add_block_to_block (&argse.pre, &argse.pre);
+         lbound = gfc_conv_descriptor_lbound_get (desc, gfc_rank_cst[i]);
+         tmp = fold_build2_loc (input_location, MINUS_EXPR,
+                                integer_type_node, argse.expr,
+                                fold_convert(integer_type_node, lbound));
+         tmp = fold_build2_loc (input_location, MULT_EXPR,
+                                integer_type_node, extent, tmp);
+         index = fold_build2_loc (input_location, PLUS_EXPR,
+                                  integer_type_node, index, tmp);
+         if (i < ar->dimen - 1)
+           {
+             ubound = gfc_conv_descriptor_ubound_get (desc, gfc_rank_cst[i]);
+             tmp = gfc_conv_array_extent_dim (lbound, ubound, NULL);
+             tmp = fold_convert (integer_type_node, tmp);
+             extent = fold_build2_loc (input_location, MULT_EXPR,
+                                       integer_type_node, extent, tmp);
+           }
+       }
+    }
+
+  /* errmsg.  */
+  if (code->expr3)
+    {
+      gfc_init_se (&argse, NULL);
+      argse.want_pointer = 1;
+      gfc_conv_expr (&argse, code->expr3);
+      gfc_add_block_to_block (&se.pre, &argse.pre);
+      errmsg = argse.expr;
+      errmsg_len = fold_convert (size_type_node, argse.string_length);
+    }
+  else
+    {
+      errmsg = null_pointer_node;
+      errmsg_len = build_zero_cst (size_type_node);
+    }
+
+  if (stat != null_pointer_node && TREE_TYPE (stat) != integer_type_node)
+    {
+      stat2 = stat;
+      stat = gfc_create_var (integer_type_node, "stat");
+    }
+
+  if (op == EXEC_EVENT_POST)
+    tmp = build_call_expr_loc (input_location, gfor_fndecl_caf_event_post, 6,
+                              token, index, image_index,
+                              stat != null_pointer_node
+                              ? gfc_build_addr_expr (NULL, stat) : stat,
+                              errmsg, errmsg_len);
+  else
+    tmp = build_call_expr_loc (input_location, gfor_fndecl_caf_event_wait, 6,
+                              token, index, until_count,
+                              stat != null_pointer_node
+                              ? gfc_build_addr_expr (NULL, stat) : stat,
+                              errmsg, errmsg_len);
+  gfc_add_expr_to_block (&se.pre, tmp);
+
+  /* It guarantees memory consistency within the same segment */
+  tmp = gfc_build_string_const (strlen ("memory")+1, "memory"),
+  tmp = build5_loc (input_location, ASM_EXPR, void_type_node,
+                   gfc_build_string_const (1, ""), NULL_TREE, NULL_TREE,
+                   tree_cons (NULL_TREE, tmp, NULL_TREE), NULL_TREE);
+  ASM_VOLATILE_P (tmp) = 1;
+  gfc_add_expr_to_block (&se.pre, tmp);
+
+  if (stat2 != NULL_TREE)
+    gfc_add_modify (&se.pre, stat2, fold_convert (TREE_TYPE (stat2), stat));
+
+  return gfc_finish_block (&se.pre);
+}
 
 tree
 gfc_trans_sync (gfc_code *code, gfc_exec_op type)
@@ -882,15 +1196,16 @@ gfc_trans_sync (gfc_code *code, gfc_exec_op type)
     {
       gcc_assert (code->expr3->expr_type == EXPR_VARIABLE);
       gfc_init_se (&argse, NULL);
+      argse.want_pointer = 1;
       gfc_conv_expr (&argse, code->expr3);
       gfc_conv_string_parameter (&argse);
       errmsg = gfc_build_addr_expr (NULL, argse.expr);
-      errmsglen = argse.string_length;
+      errmsglen = fold_convert (size_type_node, argse.string_length);
     }
   else if (flag_coarray == GFC_FCOARRAY_LIB)
     {
       errmsg = null_pointer_node;
-      errmsglen = build_int_cst (integer_type_node, 0);
+      errmsglen = build_int_cst (size_type_node, 0);
     }
 
   /* Check SYNC IMAGES(imageset) for valid image index.
@@ -900,7 +1215,7 @@ gfc_trans_sync (gfc_code *code, gfc_exec_op type)
     {
       tree cond;
       if (flag_coarray != GFC_FCOARRAY_LIB)
-       cond = fold_build2_loc (input_location, NE_EXPR, boolean_type_node,
+       cond = fold_build2_loc (input_location, NE_EXPR, logical_type_node,
                                images, build_int_cst (TREE_TYPE (images), 1));
       else
        {
@@ -908,13 +1223,13 @@ gfc_trans_sync (gfc_code *code, gfc_exec_op type)
          tmp = build_call_expr_loc (input_location, gfor_fndecl_caf_num_images,
                                     2, integer_zero_node,
                                     build_int_cst (integer_type_node, -1));
-         cond = fold_build2_loc (input_location, GT_EXPR, boolean_type_node,
+         cond = fold_build2_loc (input_location, GT_EXPR, logical_type_node,
                                  images, tmp);
-         cond2 = fold_build2_loc (input_location, LT_EXPR, boolean_type_node,
+         cond2 = fold_build2_loc (input_location, LT_EXPR, logical_type_node,
                                   images,
                                   build_int_cst (TREE_TYPE (images), 1));
          cond = fold_build2_loc (input_location, TRUTH_OR_EXPR,
-                                 boolean_type_node, cond, cond2);
+                                 logical_type_node, cond, cond2);
        }
       gfc_trans_runtime_check (true, false, cond, &se.pre,
                               &code->expr1->where, "Invalid image number "
@@ -922,6 +1237,18 @@ gfc_trans_sync (gfc_code *code, gfc_exec_op type)
                               fold_convert (integer_type_node, images));
     }
 
+  /* Per F2008, 8.5.1, a SYNC MEMORY is implied by calling the
+     image control statements SYNC IMAGES and SYNC ALL.  */
+  if (flag_coarray == GFC_FCOARRAY_LIB)
+    {
+      tmp = gfc_build_string_const (strlen ("memory")+1, "memory"),
+      tmp = build5_loc (input_location, ASM_EXPR, void_type_node,
+                       gfc_build_string_const (1, ""), NULL_TREE, NULL_TREE,
+                       tree_cons (NULL_TREE, tmp, NULL_TREE), NULL_TREE);
+      ASM_VOLATILE_P (tmp) = 1;
+      gfc_add_expr_to_block (&se.pre, tmp);
+    }
+
   if (flag_coarray != GFC_FCOARRAY_LIB)
     {
       /* Set STAT to zero.  */
@@ -1194,10 +1521,10 @@ gfc_trans_arithmetic_if (gfc_code * code)
       branch2 = build1_v (GOTO_EXPR, gfc_get_label_decl (code->label2));
 
       if (code->label1->value != code->label3->value)
-        tmp = fold_build2_loc (input_location, LT_EXPR, boolean_type_node,
+        tmp = fold_build2_loc (input_location, LT_EXPR, logical_type_node,
                               se.expr, zero);
       else
-        tmp = fold_build2_loc (input_location, NE_EXPR, boolean_type_node,
+        tmp = fold_build2_loc (input_location, NE_EXPR, logical_type_node,
                               se.expr, zero);
 
       branch1 = fold_build3_loc (input_location, COND_EXPR, void_type_node,
@@ -1211,7 +1538,7 @@ gfc_trans_arithmetic_if (gfc_code * code)
     {
       /* if (cond <= 0) take branch1 else take branch2.  */
       branch2 = build1_v (GOTO_EXPR, gfc_get_label_decl (code->label3));
-      tmp = fold_build2_loc (input_location, LE_EXPR, boolean_type_node,
+      tmp = fold_build2_loc (input_location, LE_EXPR, logical_type_node,
                             se.expr, zero);
       branch1 = fold_build3_loc (input_location, COND_EXPR, void_type_node,
                                 tmp, branch1, branch2);
@@ -1241,6 +1568,17 @@ gfc_trans_critical (gfc_code *code)
                                 null_pointer_node, null_pointer_node,
                                 null_pointer_node, integer_zero_node);
       gfc_add_expr_to_block (&block, tmp);
+
+      /* It guarantees memory consistency within the same segment */
+      tmp = gfc_build_string_const (strlen ("memory")+1, "memory"),
+       tmp = build5_loc (input_location, ASM_EXPR, void_type_node,
+                         gfc_build_string_const (1, ""),
+                         NULL_TREE, NULL_TREE,
+                         tree_cons (NULL_TREE, tmp, NULL_TREE),
+                         NULL_TREE);
+      ASM_VOLATILE_P (tmp) = 1;
+
+      gfc_add_expr_to_block (&block, tmp);
     }
 
   tmp = gfc_trans_code (code->block->next);
@@ -1253,8 +1591,18 @@ gfc_trans_critical (gfc_code *code)
                                 null_pointer_node, null_pointer_node,
                                 integer_zero_node);
       gfc_add_expr_to_block (&block, tmp);
-    }
 
+      /* It guarantees memory consistency within the same segment */
+      tmp = gfc_build_string_const (strlen ("memory")+1, "memory"),
+       tmp = build5_loc (input_location, ASM_EXPR, void_type_node,
+                         gfc_build_string_const (1, ""),
+                         NULL_TREE, NULL_TREE,
+                         tree_cons (NULL_TREE, tmp, NULL_TREE),
+                         NULL_TREE);
+      ASM_VOLATILE_P (tmp) = 1;
+
+      gfc_add_expr_to_block (&block, tmp);
+    }
 
   return gfc_finish_block (&block);
 }
@@ -1291,6 +1639,9 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
   int n;
   tree charlen;
   bool need_len_assign;
+  bool whole_array = true;
+  gfc_ref *ref;
+  symbol_attribute attr;
 
   gcc_assert (sym->assoc);
   e = sym->assoc->target;
@@ -1301,6 +1652,15 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
 
   unlimited = UNLIMITED_POLY (e);
 
+  for (ref = e->ref; ref; ref = ref->next)
+    if (ref->type == REF_ARRAY
+       && ref->u.ar.type == AR_FULL
+       && ref->next)
+      {
+       whole_array =  false;
+       break;
+      }
+
   /* Assignments to the string length need to be generated, when
      ( sym is a char array or
        sym has a _len component)
@@ -1327,7 +1687,8 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
 
       desc = sym->backend_decl;
       cst_array_ctor = e->expr_type == EXPR_ARRAY
-             && gfc_constant_array_constructor_p (e->value.constructor);
+             && gfc_constant_array_constructor_p (e->value.constructor)
+             && e->ts.type != BT_CHARACTER;
 
       /* If association is to an expression, evaluate it and create temporary.
         Otherwise, get descriptor of target for pointer assignment.  */
@@ -1341,13 +1702,26 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
 
       gfc_conv_expr_descriptor (&se, e);
 
+      if (sym->ts.type == BT_CHARACTER
+         && sym->ts.deferred
+         && !sym->attr.select_type_temporary
+         && VAR_P (sym->ts.u.cl->backend_decl)
+         && se.string_length != sym->ts.u.cl->backend_decl)
+       {
+         gfc_add_modify (&se.pre, sym->ts.u.cl->backend_decl,
+                         fold_convert (TREE_TYPE (sym->ts.u.cl->backend_decl),
+                                       se.string_length));
+       }
+
       /* If we didn't already do the pointer assignment, set associate-name
         descriptor to the one generated for the temporary.  */
-      if (!sym->assoc->variable && !cst_array_ctor)
+      if ((!sym->assoc->variable && !cst_array_ctor)
+         || !whole_array)
        {
          int dim;
 
-         gfc_add_modify (&se.pre, desc, se.expr);
+         if (whole_array)
+           gfc_add_modify (&se.pre, desc, se.expr);
 
          /* The generated descriptor has lower bound zero (as array
             temporary), shift bounds so we get lower bounds of 1.  */
@@ -1361,10 +1735,19 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
       if (sym->attr.subref_array_pointer)
        {
          gcc_assert (e->expr_type == EXPR_VARIABLE);
-         tmp = e->symtree->n.sym->backend_decl;
-         tmp = gfc_get_element_type (TREE_TYPE (tmp));
-         tmp = fold_convert (gfc_array_index_type, size_in_bytes (tmp));
-         gfc_add_modify (&se.pre, GFC_DECL_SPAN(desc), tmp);
+         tmp = gfc_get_array_span (se.expr, e);
+
+         gfc_conv_descriptor_span_set (&se.pre, desc, tmp);
+       }
+
+      if (e->expr_type == EXPR_FUNCTION
+         && sym->ts.type == BT_DERIVED
+         && sym->ts.u.derived
+         && sym->ts.u.derived->attr.pdt_type)
+       {
+         tmp = gfc_deallocate_pdt_comp (sym->ts.u.derived, se.expr,
+                                        sym->as->rank);
+         gfc_add_expr_to_block (&se.post, tmp);
        }
 
       /* Done, register stuff as init / cleanup code.  */
@@ -1503,8 +1886,36 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
          need_len_assign = need_len_assign && sym->ts.type == BT_CHARACTER;
        }
 
-      tmp = TREE_TYPE (sym->backend_decl);
-      tmp = gfc_build_addr_expr (tmp, se.expr);
+      if (sym->ts.type == BT_CHARACTER
+         && sym->ts.deferred
+         && !sym->attr.select_type_temporary
+         && VAR_P (sym->ts.u.cl->backend_decl)
+         && se.string_length != sym->ts.u.cl->backend_decl)
+       {
+         gfc_add_modify (&se.pre, sym->ts.u.cl->backend_decl,
+                         fold_convert (TREE_TYPE (sym->ts.u.cl->backend_decl),
+                                       se.string_length));
+         if (e->expr_type == EXPR_FUNCTION)
+           {
+             tmp = gfc_call_free (sym->backend_decl);
+             gfc_add_expr_to_block (&se.post, tmp);
+           }
+       }
+
+      attr = gfc_expr_attr (e);
+      if (sym->ts.type == BT_CHARACTER && e->ts.type == BT_CHARACTER
+         && (attr.allocatable || attr.pointer || attr.dummy)
+         && POINTER_TYPE_P (TREE_TYPE (se.expr)))
+       {
+         /* These are pointer types already.  */
+         tmp = fold_convert (TREE_TYPE (sym->backend_decl), se.expr);
+       }
+      else
+       {
+          tmp = TREE_TYPE (sym->backend_decl);
+          tmp = gfc_build_addr_expr (tmp, se.expr);
+       }
+
       gfc_add_modify (&se.pre, sym->backend_decl, tmp);
 
       gfc_add_init_cleanup (block, gfc_finish_block( &se.pre),
@@ -1516,10 +1927,65 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
   else
     {
       gfc_expr *lhs;
+      tree res;
+      gfc_se se;
+
+      gfc_init_se (&se, NULL);
+
+      /* resolve.c converts some associate names to allocatable so that
+        allocation can take place automatically in gfc_trans_assignment.
+        The frontend prevents them from being either allocated,
+        deallocated or reallocated.  */
+      if (sym->attr.allocatable)
+       {
+         tmp = sym->backend_decl;
+         if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)))
+           tmp = gfc_conv_descriptor_data_get (tmp);
+         gfc_add_modify (&se.pre, tmp, fold_convert (TREE_TYPE (tmp),
+                                                   null_pointer_node));
+       }
 
       lhs = gfc_lval_expr_from_sym (sym);
-      tmp = gfc_trans_assignment (lhs, e, false, true);
-      gfc_add_init_cleanup (block, tmp, NULL_TREE);
+      res = gfc_trans_assignment (lhs, e, false, true);
+      gfc_add_expr_to_block (&se.pre, res);
+
+      tmp = sym->backend_decl;
+      if (e->expr_type == EXPR_FUNCTION
+         && sym->ts.type == BT_DERIVED
+         && sym->ts.u.derived
+         && sym->ts.u.derived->attr.pdt_type)
+       {
+         tmp = gfc_deallocate_pdt_comp (sym->ts.u.derived, tmp,
+                                        0);
+       }
+      else if (e->expr_type == EXPR_FUNCTION
+              && sym->ts.type == BT_CLASS
+              && CLASS_DATA (sym)->ts.u.derived
+              && CLASS_DATA (sym)->ts.u.derived->attr.pdt_type)
+       {
+         tmp = gfc_class_data_get (tmp);
+         tmp = gfc_deallocate_pdt_comp (CLASS_DATA (sym)->ts.u.derived,
+                                        tmp, 0);
+       }
+      else if (sym->attr.allocatable)
+       {
+         tmp = sym->backend_decl;
+
+         if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)))
+           tmp = gfc_conv_descriptor_data_get (tmp);
+
+         /* A simple call to free suffices here.  */
+         tmp = gfc_call_free (tmp);
+
+         /* Make sure that reallocation on assignment cannot occur.  */
+         sym->attr.allocatable = 0;
+       }
+      else
+       tmp = NULL_TREE;
+
+      res = gfc_finish_block (&se.pre);
+      gfc_add_init_cleanup (block, res, tmp);
+      gfc_free_expr (lhs);
     }
 
   /* Set the stringlength, when needed.  */
@@ -1529,10 +1995,16 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block)
       gfc_init_se (&se, NULL);
       if (e->symtree->n.sym->ts.type == BT_CHARACTER)
        {
-         /* What about deferred strings?  */
+         /* Deferred strings are dealt with in the preceeding.  */
          gcc_assert (!e->symtree->n.sym->ts.deferred);
          tmp = e->symtree->n.sym->ts.u.cl->backend_decl;
        }
+      else if (e->symtree->n.sym->attr.function
+              && e->symtree->n.sym == e->symtree->n.sym->result)
+       {
+         tmp = gfc_get_fake_result_decl (e->symtree->n.sym, 0);
+         tmp = gfc_class_len_get (tmp);
+       }
       else
        tmp = gfc_class_len_get (gfc_get_symbol_decl (e->symtree->n.sym));
       gfc_get_symbol_decl (sym);
@@ -1578,12 +2050,7 @@ gfc_trans_block_construct (gfc_code* code)
   exit_label = gfc_build_label_decl (NULL_TREE);
   code->exit_label = exit_label;
 
-  /* Generate !$ACC DECLARE directive. */
-  if (ns->oacc_declare_clauses)
-    {
-      tree tmp = gfc_trans_oacc_declare (&body, ns);
-      gfc_add_expr_to_block (&body, tmp);
-    }
+  finish_oacc_declare (ns, sym, true);
 
   gfc_add_expr_to_block (&body, gfc_trans_code (ns->code));
   gfc_add_expr_to_block (&body, build1_v (LABEL_EXPR, exit_label));
@@ -1597,11 +2064,11 @@ gfc_trans_block_construct (gfc_code* code)
   return gfc_finish_wrapped_block (&block);
 }
 
+/* Translate the simple DO construct in a C-style manner.
+   This is where the loop variable has integer type and step +-1.
+   Following code will generate infinite loop in case where TO is INT_MAX
+   (for +1 step) or INT_MIN (for -1 step)
 
-/* Translate the simple DO construct.  This is where the loop variable has
-   integer type and step +-1.  We can't use this in the general case
-   because integer overflow and floating point errors could give incorrect
-   results.
    We translate a do loop from:
 
    DO dovar = from, to, step
@@ -1611,22 +2078,20 @@ gfc_trans_block_construct (gfc_code* code)
    to:
 
    [Evaluate loop bounds and step]
-   dovar = from;
-   if ((step > 0) ? (dovar <= to) : (dovar => to))
-    {
-      for (;;)
-        {
-         body;
-   cycle_label:
-         cond = (dovar == to);
-         dovar += step;
-         if (cond) goto end_label;
-       }
+    dovar = from;
+    for (;;)
+      {
+       if (dovar > to)
+         goto end_label;
+       body;
+       cycle_label:
+       dovar += step;
       }
-   end_label:
+    end_label:
 
-   This helps the optimizers by avoiding the extra induction variable
-   used in the general case.  */
+   This helps the optimizers by avoiding the extra pre-header condition and
+   we save a register as we just compare the updated IV (not a value in
+   previous step).  */
 
 static tree
 gfc_trans_simple_do (gfc_code * code, stmtblock_t *pblock, tree dovar,
@@ -1640,14 +2105,14 @@ gfc_trans_simple_do (gfc_code * code, stmtblock_t *pblock, tree dovar,
   tree cycle_label;
   tree exit_label;
   location_t loc;
-
   type = TREE_TYPE (dovar);
+  bool is_step_positive = tree_int_cst_sgn (step) > 0;
 
   loc = code->ext.iterator->start->where.lb->location;
 
   /* Initialize the DO variable: dovar = from.  */
   gfc_add_modify_loc (loc, pblock, dovar,
-                     fold_convert (TREE_TYPE(dovar), from));
+                     fold_convert (TREE_TYPE (dovar), from));
 
   /* Save value for do-tinkering checking.  */
   if (gfc_option.rtcheck & GFC_RTCHECK_DO)
@@ -1660,13 +2125,58 @@ gfc_trans_simple_do (gfc_code * code, stmtblock_t *pblock, tree dovar,
   cycle_label = gfc_build_label_decl (NULL_TREE);
   exit_label = gfc_build_label_decl (NULL_TREE);
 
-  /* Put the labels where they can be found later. See gfc_trans_do().  */
+  /* Put the labels where they can be found later.  See gfc_trans_do().  */
   code->cycle_label = cycle_label;
   code->exit_label = exit_label;
 
   /* Loop body.  */
   gfc_start_block (&body);
 
+  /* Exit the loop if there is an I/O result condition or error.  */
+  if (exit_cond)
+    {
+      tmp = build1_v (GOTO_EXPR, exit_label);
+      tmp = fold_build3_loc (loc, COND_EXPR, void_type_node,
+                            exit_cond, tmp,
+                            build_empty_stmt (loc));
+      gfc_add_expr_to_block (&body, tmp);
+    }
+
+  /* Evaluate the loop condition.  */
+  if (is_step_positive)
+    cond = fold_build2_loc (loc, GT_EXPR, logical_type_node, dovar,
+                           fold_convert (type, to));
+  else
+    cond = fold_build2_loc (loc, LT_EXPR, logical_type_node, dovar,
+                           fold_convert (type, to));
+
+  cond = gfc_evaluate_now_loc (loc, cond, &body);
+  if (code->ext.iterator->unroll && cond != error_mark_node)
+    cond
+      = build3 (ANNOTATE_EXPR, TREE_TYPE (cond), cond,
+               build_int_cst (integer_type_node, annot_expr_unroll_kind),
+               build_int_cst (integer_type_node, code->ext.iterator->unroll));
+
+  /* The loop exit.  */
+  tmp = fold_build1_loc (loc, GOTO_EXPR, void_type_node, exit_label);
+  TREE_USED (exit_label) = 1;
+  tmp = fold_build3_loc (loc, COND_EXPR, void_type_node,
+                        cond, tmp, build_empty_stmt (loc));
+  gfc_add_expr_to_block (&body, tmp);
+
+  /* Check whether the induction variable is equal to INT_MAX
+     (respectively to INT_MIN).  */
+  if (gfc_option.rtcheck & GFC_RTCHECK_DO)
+    {
+      tree boundary = is_step_positive ? TYPE_MAX_VALUE (type)
+       : TYPE_MIN_VALUE (type);
+
+      tmp = fold_build2_loc (loc, EQ_EXPR, logical_type_node,
+                            dovar, boundary);
+      gfc_trans_runtime_check (true, false, tmp, &body, &code->loc,
+                              "Loop iterates infinitely");
+    }
+
   /* Main loop body.  */
   tmp = gfc_trans_code_cond (code->block->next, exit_cond);
   gfc_add_expr_to_block (&body, tmp);
@@ -1681,27 +2191,12 @@ gfc_trans_simple_do (gfc_code * code, stmtblock_t *pblock, tree dovar,
   /* Check whether someone has modified the loop variable.  */
   if (gfc_option.rtcheck & GFC_RTCHECK_DO)
     {
-      tmp = fold_build2_loc (loc, NE_EXPR, boolean_type_node,
+      tmp = fold_build2_loc (loc, NE_EXPR, logical_type_node,
                             dovar, saved_dovar);
       gfc_trans_runtime_check (true, false, tmp, &body, &code->loc,
                               "Loop variable has been modified");
     }
 
-  /* Exit the loop if there is an I/O result condition or error.  */
-  if (exit_cond)
-    {
-      tmp = build1_v (GOTO_EXPR, exit_label);
-      tmp = fold_build3_loc (loc, COND_EXPR, void_type_node,
-                            exit_cond, tmp,
-                            build_empty_stmt (loc));
-      gfc_add_expr_to_block (&body, tmp);
-    }
-
-  /* Evaluate the loop condition.  */
-  cond = fold_build2_loc (loc, EQ_EXPR, boolean_type_node, dovar,
-                         to);
-  cond = gfc_evaluate_now_loc (loc, cond, &body);
-
   /* Increment the loop variable.  */
   tmp = fold_build2_loc (loc, PLUS_EXPR, type, dovar, step);
   gfc_add_modify_loc (loc, &body, dovar, tmp);
@@ -1709,26 +2204,10 @@ gfc_trans_simple_do (gfc_code * code, stmtblock_t *pblock, tree dovar,
   if (gfc_option.rtcheck & GFC_RTCHECK_DO)
     gfc_add_modify_loc (loc, &body, saved_dovar, dovar);
 
-  /* The loop exit.  */
-  tmp = fold_build1_loc (loc, GOTO_EXPR, void_type_node, exit_label);
-  TREE_USED (exit_label) = 1;
-  tmp = fold_build3_loc (loc, COND_EXPR, void_type_node,
-                        cond, tmp, build_empty_stmt (loc));
-  gfc_add_expr_to_block (&body, tmp);
-
   /* Finish the loop body.  */
   tmp = gfc_finish_block (&body);
   tmp = fold_build1_loc (loc, LOOP_EXPR, void_type_node, tmp);
 
-  /* Only execute the loop if the number of iterations is positive.  */
-  if (tree_int_cst_sgn (step) > 0)
-    cond = fold_build2_loc (loc, LE_EXPR, boolean_type_node, dovar,
-                           to);
-  else
-    cond = fold_build2_loc (loc, GE_EXPR, boolean_type_node, dovar,
-                           to);
-  tmp = fold_build3_loc (loc, COND_EXPR, void_type_node, cond, tmp,
-                        build_empty_stmt (loc));
   gfc_add_expr_to_block (pblock, tmp);
 
   /* Add the exit label.  */
@@ -1821,7 +2300,7 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
 
   if (gfc_option.rtcheck & GFC_RTCHECK_DO)
     {
-      tmp = fold_build2_loc (input_location, EQ_EXPR, boolean_type_node, step,
+      tmp = fold_build2_loc (input_location, EQ_EXPR, logical_type_node, step,
                             build_zero_cst (type));
       gfc_trans_runtime_check (true, false, tmp, &block, &code->loc,
                               "DO step value is zero");
@@ -1831,8 +2310,8 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
   if (TREE_CODE (type) == INTEGER_TYPE
       && (integer_onep (step)
        || tree_int_cst_equal (step, integer_minus_one_node)))
-    return gfc_trans_simple_do (code, &block, dovar, from, to, step, exit_cond);
-
+    return gfc_trans_simple_do (code, &block, dovar, from, to, step,
+                               exit_cond);
 
   if (TREE_CODE (type) == INTEGER_TYPE)
     utype = unsigned_type_for (type);
@@ -1888,7 +2367,7 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
 
       /* For a positive step, when to < from, exit, otherwise compute
          countm1 = ((unsigned)to - (unsigned)from) / (unsigned)step  */
-      tmp = fold_build2_loc (loc, LT_EXPR, boolean_type_node, to, from);
+      tmp = fold_build2_loc (loc, LT_EXPR, logical_type_node, to, from);
       tmp2 = fold_build2_loc (loc, TRUNC_DIV_EXPR, utype,
                              fold_build2_loc (loc, MINUS_EXPR, utype,
                                               tou, fromu),
@@ -1896,13 +2375,14 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
       pos = build2 (COMPOUND_EXPR, void_type_node,
                    fold_build2 (MODIFY_EXPR, void_type_node,
                                 countm1, tmp2),
-                   build3_loc (loc, COND_EXPR, void_type_node, tmp,
+                   build3_loc (loc, COND_EXPR, void_type_node,
+                               gfc_unlikely (tmp, PRED_FORTRAN_LOOP_PREHEADER),
                                build1_loc (loc, GOTO_EXPR, void_type_node,
                                            exit_label), NULL_TREE));
 
       /* For a negative step, when to > from, exit, otherwise compute
          countm1 = ((unsigned)from - (unsigned)to) / -(unsigned)step  */
-      tmp = fold_build2_loc (loc, GT_EXPR, boolean_type_node, to, from);
+      tmp = fold_build2_loc (loc, GT_EXPR, logical_type_node, to, from);
       tmp2 = fold_build2_loc (loc, TRUNC_DIV_EXPR, utype,
                              fold_build2_loc (loc, MINUS_EXPR, utype,
                                               fromu, tou),
@@ -1910,11 +2390,12 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
       neg = build2 (COMPOUND_EXPR, void_type_node,
                    fold_build2 (MODIFY_EXPR, void_type_node,
                                 countm1, tmp2),
-                   build3_loc (loc, COND_EXPR, void_type_node, tmp,
+                   build3_loc (loc, COND_EXPR, void_type_node,
+                               gfc_unlikely (tmp, PRED_FORTRAN_LOOP_PREHEADER),
                                build1_loc (loc, GOTO_EXPR, void_type_node,
                                            exit_label), NULL_TREE));
 
-      tmp = fold_build2_loc (loc, LT_EXPR, boolean_type_node, step,
+      tmp = fold_build2_loc (loc, LT_EXPR, logical_type_node, step,
                             build_int_cst (TREE_TYPE (step), 0));
       tmp = fold_build3_loc (loc, COND_EXPR, void_type_node, tmp, neg, pos);
 
@@ -1935,13 +2416,13 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
 
       /* We need a special check for empty loops:
         empty = (step > 0 ? to < from : to > from);  */
-      pos_step = fold_build2_loc (loc, GT_EXPR, boolean_type_node, step,
+      pos_step = fold_build2_loc (loc, GT_EXPR, logical_type_node, step,
                                  build_zero_cst (type));
-      tmp = fold_build3_loc (loc, COND_EXPR, boolean_type_node, pos_step,
+      tmp = fold_build3_loc (loc, COND_EXPR, logical_type_node, pos_step,
                             fold_build2_loc (loc, LT_EXPR,
-                                             boolean_type_node, to, from),
+                                             logical_type_node, to, from),
                             fold_build2_loc (loc, GT_EXPR,
-                                             boolean_type_node, to, from));
+                                             logical_type_node, to, from));
       /* If the loop is empty, go directly to the exit label.  */
       tmp = fold_build3_loc (loc, COND_EXPR, void_type_node, tmp,
                         build1_v (GOTO_EXPR, exit_label),
@@ -1966,7 +2447,7 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
   /* Check whether someone has modified the loop variable.  */
   if (gfc_option.rtcheck & GFC_RTCHECK_DO)
     {
-      tmp = fold_build2_loc (loc, NE_EXPR, boolean_type_node, dovar,
+      tmp = fold_build2_loc (loc, NE_EXPR, logical_type_node, dovar,
                             saved_dovar);
       gfc_trans_runtime_check (true, false, tmp, &body, &code->loc,
                               "Loop variable has been modified");
@@ -1999,8 +2480,13 @@ gfc_trans_do (gfc_code * code, tree exit_cond)
   gfc_add_modify_loc (loc, &body, countm1, tmp);
 
   /* End with the loop condition.  Loop until countm1t == 0.  */
-  cond = fold_build2_loc (loc, EQ_EXPR, boolean_type_node, countm1t,
+  cond = fold_build2_loc (loc, EQ_EXPR, logical_type_node, countm1t,
                          build_int_cst (utype, 0));
+  if (code->ext.iterator->unroll && cond != error_mark_node)
+    cond
+      = build3 (ANNOTATE_EXPR, TREE_TYPE (cond), cond,
+               build_int_cst (integer_type_node, annot_expr_unroll_kind),
+               build_int_cst (integer_type_node, code->ext.iterator->unroll));
   tmp = fold_build1_loc (loc, GOTO_EXPR, void_type_node, exit_label);
   tmp = fold_build3_loc (loc, COND_EXPR, void_type_node,
                         cond, tmp, build_empty_stmt (loc));
@@ -2107,6 +2593,125 @@ gfc_trans_do_while (gfc_code * code)
 }
 
 
+/* Deal with the particular case of SELECT_TYPE, where the vtable
+   addresses are used for the selection. Since these are not sorted,
+   the selection has to be made by a series of if statements.  */
+
+static tree
+gfc_trans_select_type_cases (gfc_code * code)
+{
+  gfc_code *c;
+  gfc_case *cp;
+  tree tmp;
+  tree cond;
+  tree low;
+  tree high;
+  gfc_se se;
+  gfc_se cse;
+  stmtblock_t block;
+  stmtblock_t body;
+  bool def = false;
+  gfc_expr *e;
+  gfc_start_block (&block);
+
+  /* Calculate the switch expression.  */
+  gfc_init_se (&se, NULL);
+  gfc_conv_expr_val (&se, code->expr1);
+  gfc_add_block_to_block (&block, &se.pre);
+
+  /* Generate an expression for the selector hash value, for
+     use to resolve character cases.  */
+  e = gfc_copy_expr (code->expr1->value.function.actual->expr);
+  gfc_add_hash_component (e);
+
+  TREE_USED (code->exit_label) = 0;
+
+repeat:
+  for (c = code->block; c; c = c->block)
+    {
+      cp = c->ext.block.case_list;
+
+      /* Assume it's the default case.  */
+      low = NULL_TREE;
+      high = NULL_TREE;
+      tmp = NULL_TREE;
+
+      /* Put the default case at the end.  */
+      if ((!def && !cp->low) || (def && cp->low))
+       continue;
+
+      if (cp->low && (cp->ts.type == BT_CLASS
+                     || cp->ts.type == BT_DERIVED))
+       {
+         gfc_init_se (&cse, NULL);
+         gfc_conv_expr_val (&cse, cp->low);
+         gfc_add_block_to_block (&block, &cse.pre);
+         low = cse.expr;
+       }
+      else if (cp->ts.type != BT_UNKNOWN)
+       {
+         gcc_assert (cp->high);
+         gfc_init_se (&cse, NULL);
+         gfc_conv_expr_val (&cse, cp->high);
+         gfc_add_block_to_block (&block, &cse.pre);
+         high = cse.expr;
+       }
+
+      gfc_init_block (&body);
+
+      /* Add the statements for this case.  */
+      tmp = gfc_trans_code (c->next);
+      gfc_add_expr_to_block (&body, tmp);
+
+      /* Break to the end of the SELECT TYPE construct.  The default
+        case just falls through.  */
+      if (!def)
+       {
+         TREE_USED (code->exit_label) = 1;
+         tmp = build1_v (GOTO_EXPR, code->exit_label);
+         gfc_add_expr_to_block (&body, tmp);
+       }
+
+      tmp = gfc_finish_block (&body);
+
+      if (low != NULL_TREE)
+       {
+         /* Compare vtable pointers.  */
+         cond = fold_build2_loc (input_location, EQ_EXPR,
+                                 TREE_TYPE (se.expr), se.expr, low);
+         tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
+                                cond, tmp,
+                                build_empty_stmt (input_location));
+       }
+      else if (high != NULL_TREE)
+       {
+         /* Compare hash values for character cases.  */
+         gfc_init_se (&cse, NULL);
+         gfc_conv_expr_val (&cse, e);
+         gfc_add_block_to_block (&block, &cse.pre);
+
+         cond = fold_build2_loc (input_location, EQ_EXPR,
+                                 TREE_TYPE (se.expr), high, cse.expr);
+         tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
+                                cond, tmp,
+                                build_empty_stmt (input_location));
+       }
+
+      gfc_add_expr_to_block (&block, tmp);
+    }
+
+  if (!def)
+    {
+      def = true;
+      goto repeat;
+    }
+
+  gfc_free_expr (e);
+
+  return gfc_finish_block (&block);
+}
+
+
 /* Translate the SELECT CASE construct for INTEGER case expressions,
    without killing all potential optimizations.  The problem is that
    Fortran allows unbounded cases, but the back-end does not, so we
@@ -2214,9 +2819,8 @@ gfc_trans_integer_select (gfc_code * code)
                 to represent unbounded cases.  */
 
              if (!cp->low
-                 || (cp->low
-                     && mpz_cmp (cp->low->value.integer,
-                                 cp->high->value.integer) != 0))
+                 || (mpz_cmp (cp->low->value.integer,
+                               cp->high->value.integer) != 0))
                high = gfc_conv_mpz_to_tree (cp->high->value.integer,
                                             cp->high->ts.kind);
 
@@ -2244,8 +2848,7 @@ gfc_trans_integer_select (gfc_code * code)
     }
 
   tmp = gfc_finish_block (&body);
-  tmp = fold_build3_loc (input_location, SWITCH_EXPR, NULL_TREE,
-                        se.expr, tmp, NULL_TREE);
+  tmp = fold_build2_loc (input_location, SWITCH_EXPR, NULL_TREE, se.expr, tmp);
   gfc_add_expr_to_block (&block, tmp);
 
   tmp = build1_v (LABEL_EXPR, end_label);
@@ -2407,7 +3010,7 @@ gfc_trans_character_select (gfc_code *code)
     {
       for (d = cp; d; d = d->right)
        {
-         int i;
+         gfc_charlen_t i;
          if (d->low)
            {
              gcc_assert (d->low->expr_type == EXPR_CONSTANT
@@ -2530,8 +3133,8 @@ gfc_trans_character_select (gfc_code *code)
          gfc_add_block_to_block (&block, &expr1se.post);
 
          tmp = gfc_finish_block (&body);
-         tmp = fold_build3_loc (input_location, SWITCH_EXPR, NULL_TREE,
-                                case_num, tmp, NULL_TREE);
+         tmp = fold_build2_loc (input_location, SWITCH_EXPR, NULL_TREE,
+                                case_num, tmp);
          gfc_add_expr_to_block (&block, tmp);
 
          tmp = build1_v (LABEL_EXPR, end_label);
@@ -2612,7 +3215,7 @@ gfc_trans_character_select (gfc_code *code)
       if (d->low == NULL)
         {
           CONSTRUCTOR_APPEND_ELT (node, ss_string1[k], null_pointer_node);
-          CONSTRUCTOR_APPEND_ELT (node, ss_string1_len[k], integer_zero_node);
+          CONSTRUCTOR_APPEND_ELT (node, ss_string1_len[k], build_zero_cst (gfc_charlen_type_node));
         }
       else
         {
@@ -2625,7 +3228,7 @@ gfc_trans_character_select (gfc_code *code)
       if (d->high == NULL)
         {
           CONSTRUCTOR_APPEND_ELT (node, ss_string2[k], null_pointer_node);
-          CONSTRUCTOR_APPEND_ELT (node, ss_string2_len[k], integer_zero_node);
+          CONSTRUCTOR_APPEND_ELT (node, ss_string2_len[k], build_zero_cst (gfc_charlen_type_node));
         }
       else
         {
@@ -2677,8 +3280,8 @@ gfc_trans_character_select (gfc_code *code)
   gfc_add_block_to_block (&block, &expr1se.post);
 
   tmp = gfc_finish_block (&body);
-  tmp = fold_build3_loc (input_location, SWITCH_EXPR, NULL_TREE,
-                        case_num, tmp, NULL_TREE);
+  tmp = fold_build2_loc (input_location, SWITCH_EXPR, NULL_TREE,
+                        case_num, tmp);
   gfc_add_expr_to_block (&block, tmp);
 
   tmp = build1_v (LABEL_EXPR, end_label);
@@ -2728,22 +3331,51 @@ gfc_trans_select (gfc_code * code)
        body = gfc_trans_logical_select (code);
        break;
 
-      case BT_INTEGER:
-       body = gfc_trans_integer_select (code);
-       break;
+      case BT_INTEGER:
+       body = gfc_trans_integer_select (code);
+       break;
+
+      case BT_CHARACTER:
+       body = gfc_trans_character_select (code);
+       break;
+
+      default:
+       gfc_internal_error ("gfc_trans_select(): Bad type for case expr.");
+       /* Not reached */
+      }
+
+  /* Build everything together.  */
+  gfc_add_expr_to_block (&block, body);
+  gfc_add_expr_to_block (&block, build1_v (LABEL_EXPR, exit_label));
+
+  return gfc_finish_block (&block);
+}
+
+tree
+gfc_trans_select_type (gfc_code * code)
+{
+  stmtblock_t block;
+  tree body;
+  tree exit_label;
+
+  gcc_assert (code && code->expr1);
+  gfc_init_block (&block);
 
-      case BT_CHARACTER:
-       body = gfc_trans_character_select (code);
-       break;
+  /* Build the exit label and hang it in.  */
+  exit_label = gfc_build_label_decl (NULL_TREE);
+  code->exit_label = exit_label;
 
-      default:
-       gfc_internal_error ("gfc_trans_select(): Bad type for case expr.");
-       /* Not reached */
-      }
+  /* Empty SELECT constructs are legal.  */
+  if (code->block == NULL)
+    body = build_empty_stmt (input_location);
+  else
+    body = gfc_trans_select_type_cases (code);
 
   /* Build everything together.  */
   gfc_add_expr_to_block (&block, body);
-  gfc_add_expr_to_block (&block, build1_v (LABEL_EXPR, exit_label));
+
+  if (TREE_USED (exit_label))
+    gfc_add_expr_to_block (&block, build1_v (LABEL_EXPR, exit_label));
 
   return gfc_finish_block (&block);
 }
@@ -2824,7 +3456,7 @@ forall_make_variable_temp (gfc_code *c, stmtblock_t *pre, stmtblock_t *post)
       gfc_add_block_to_block (post, &tse.post);
       tse.expr = build_fold_indirect_ref_loc (input_location, tse.expr);
 
-      if (e->ts.type != BT_CHARACTER)
+      if (c->expr1->ref->u.ar.type != AR_SECTION)
        {
          /* Use the variable offset for the temporary.  */
          tmp = gfc_conv_array_offset (old_sym->backend_decl);
@@ -3005,12 +3637,16 @@ gfc_trans_forall_loop (forall_info *forall_tmp, tree body,
       gfc_init_block (&block);
 
       /* The exit condition.  */
-      cond = fold_build2_loc (input_location, LE_EXPR, boolean_type_node,
+      cond = fold_build2_loc (input_location, LE_EXPR, logical_type_node,
                              count, build_int_cst (TREE_TYPE (count), 0));
+
+      /* PR 83064 means that we cannot use annot_expr_parallel_kind until
+       the autoparallelizer can hande this.  */
       if (forall_tmp->do_concurrent)
-       cond = build2 (ANNOTATE_EXPR, TREE_TYPE (cond), cond,
+       cond = build3 (ANNOTATE_EXPR, TREE_TYPE (cond), cond,
                       build_int_cst (integer_type_node,
-                                     annot_expr_ivdep_kind));
+                                     annot_expr_ivdep_kind),
+                      integer_zero_node);
 
       tmp = build1_v (GOTO_EXPR, exit_label);
       tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
@@ -3133,9 +3769,8 @@ gfc_do_allocate (tree bytesize, tree size, tree * pdata, stmtblock_t * pblock,
 
   type = build_range_type (gfc_array_index_type, gfc_index_zero_node, tmp);
   type = build_array_type (elem_type, type);
-  if (gfc_can_put_var_on_stack (bytesize))
+  if (gfc_can_put_var_on_stack (bytesize) && INTEGER_CST_P (size))
     {
-      gcc_assert (INTEGER_CST_P (size));
       tmpvar = gfc_create_var (type, "temp");
       *pdata = NULL_TREE;
     }
@@ -3155,114 +3790,103 @@ gfc_do_allocate (tree bytesize, tree size, tree * pdata, stmtblock_t * pblock,
 
 static tree
 generate_loop_for_temp_to_lhs (gfc_expr *expr, tree tmp1, tree count3,
-                              tree count1, tree wheremask, bool invert)
+                              tree count1,
+                              gfc_ss *lss, gfc_ss *rss,
+                              tree wheremask, bool invert)
 {
-  gfc_ss *lss;
-  gfc_se lse, rse;
-  stmtblock_t block, body;
-  gfc_loopinfo loop1;
+  stmtblock_t block, body1;
+  gfc_loopinfo loop;
+  gfc_se lse;
+  gfc_se rse;
   tree tmp;
   tree wheremaskexpr;
 
-  /* Walk the lhs.  */
-  lss = gfc_walk_expr (expr);
+  (void) rss; /* TODO: unused.  */
 
-  if (lss == gfc_ss_terminator)
-    {
-      gfc_start_block (&block);
+  gfc_start_block (&block);
 
-      gfc_init_se (&lse, NULL);
+  gfc_init_se (&rse, NULL);
+  gfc_init_se (&lse, NULL);
 
-      /* Translate the expression.  */
+  if (lss == gfc_ss_terminator)
+    {
+      gfc_init_block (&body1);
       gfc_conv_expr (&lse, expr);
-
-      /* Form the expression for the temporary.  */
-      tmp = gfc_build_array_ref (tmp1, count1, NULL);
-
-      /* Use the scalar assignment as is.  */
-      gfc_add_block_to_block (&block, &lse.pre);
-      gfc_add_modify (&block, lse.expr, tmp);
-      gfc_add_block_to_block (&block, &lse.post);
-
-      /* Increment the count1.  */
-      tmp = fold_build2_loc (input_location, PLUS_EXPR, TREE_TYPE (count1),
-                            count1, gfc_index_one_node);
-      gfc_add_modify (&block, count1, tmp);
-
-      tmp = gfc_finish_block (&block);
+      rse.expr = gfc_build_array_ref (tmp1, count1, NULL);
     }
   else
     {
-      gfc_start_block (&block);
-
-      gfc_init_loopinfo (&loop1);
-      gfc_init_se (&rse, NULL);
-      gfc_init_se (&lse, NULL);
+      /* Initialize the loop.  */
+      gfc_init_loopinfo (&loop);
 
-      /* Associate the lss with the loop.  */
-      gfc_add_ss_to_loop (&loop1, lss);
+      /* We may need LSS to determine the shape of the expression.  */
+      gfc_add_ss_to_loop (&loop, lss);
 
-      /* Calculate the bounds of the scalarization.  */
-      gfc_conv_ss_startstride (&loop1);
-      /* Setup the scalarizing loops.  */
-      gfc_conv_loop_setup (&loop1, &expr->where);
+      gfc_conv_ss_startstride (&loop);
+      gfc_conv_loop_setup (&loop, &expr->where);
 
       gfc_mark_ss_chain_used (lss, 1);
+      /* Start the loop body.  */
+      gfc_start_scalarized_body (&loop, &body1);
 
-      /* Start the scalarized loop body.  */
-      gfc_start_scalarized_body (&loop1, &body);
-
-      /* Setup the gfc_se structures.  */
-      gfc_copy_loopinfo_to_se (&lse, &loop1);
+      /* Translate the expression.  */
+      gfc_copy_loopinfo_to_se (&lse, &loop);
       lse.ss = lss;
+      gfc_conv_expr (&lse, expr);
 
       /* Form the expression of the temporary.  */
-      if (lss != gfc_ss_terminator)
-       rse.expr = gfc_build_array_ref (tmp1, count1, NULL);
-      /* Translate expr.  */
-      gfc_conv_expr (&lse, expr);
+      rse.expr = gfc_build_array_ref (tmp1, count1, NULL);
+    }
 
-      /* Use the scalar assignment.  */
-      rse.string_length = lse.string_length;
-      tmp = gfc_trans_scalar_assign (&lse, &rse, expr->ts, true, true);
+  /* Use the scalar assignment.  */
+  rse.string_length = lse.string_length;
+  tmp = gfc_trans_scalar_assign (&lse, &rse, expr->ts,
+                                expr->expr_type == EXPR_VARIABLE, false);
 
-      /* Form the mask expression according to the mask tree list.  */
-      if (wheremask)
-       {
-         wheremaskexpr = gfc_build_array_ref (wheremask, count3, NULL);
-         if (invert)
-           wheremaskexpr = fold_build1_loc (input_location, TRUTH_NOT_EXPR,
-                                            TREE_TYPE (wheremaskexpr),
-                                            wheremaskexpr);
-         tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
-                                wheremaskexpr, tmp,
-                                build_empty_stmt (input_location));
-       }
+  /* Form the mask expression according to the mask tree list.  */
+  if (wheremask)
+    {
+      wheremaskexpr = gfc_build_array_ref (wheremask, count3, NULL);
+      if (invert)
+       wheremaskexpr = fold_build1_loc (input_location, TRUTH_NOT_EXPR,
+                                        TREE_TYPE (wheremaskexpr),
+                                        wheremaskexpr);
+      tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
+                            wheremaskexpr, tmp,
+                            build_empty_stmt (input_location));
+    }
 
-      gfc_add_expr_to_block (&body, tmp);
+  gfc_add_expr_to_block (&body1, tmp);
 
-      /* Increment count1.  */
-      tmp = fold_build2_loc (input_location, PLUS_EXPR, gfc_array_index_type,
-                            count1, gfc_index_one_node);
-      gfc_add_modify (&body, count1, tmp);
+  tmp = fold_build2_loc (input_location, PLUS_EXPR, TREE_TYPE (count1),
+                        count1, gfc_index_one_node);
+  gfc_add_modify (&body1, count1, tmp);
 
+  if (lss == gfc_ss_terminator)
+      gfc_add_block_to_block (&block, &body1);
+  else
+    {
       /* Increment count3.  */
       if (count3)
        {
          tmp = fold_build2_loc (input_location, PLUS_EXPR,
-                                gfc_array_index_type, count3,
-                                gfc_index_one_node);
-         gfc_add_modify (&body, count3, tmp);
+                                gfc_array_index_type,
+                                count3, gfc_index_one_node);
+         gfc_add_modify (&body1, count3, tmp);
        }
 
       /* Generate the copying loops.  */
-      gfc_trans_scalarizing_loops (&loop1, &body);
-      gfc_add_block_to_block (&block, &loop1.pre);
-      gfc_add_block_to_block (&block, &loop1.post);
-      gfc_cleanup_loop (&loop1);
+      gfc_trans_scalarizing_loops (&loop, &body1);
+
+      gfc_add_block_to_block (&block, &loop.pre);
+      gfc_add_block_to_block (&block, &loop.post);
 
-      tmp = gfc_finish_block (&block);
+      gfc_cleanup_loop (&loop);
+      /* TODO: Reuse lss and rss when copying temp->lhs.  Need to be careful
+        as tree nodes in SS may not be valid in different scope.  */
     }
+
+  tmp = gfc_finish_block (&block);
   return tmp;
 }
 
@@ -3618,26 +4242,39 @@ gfc_trans_assign_need_temp (gfc_expr * expr1, gfc_expr * expr2,
 
   /* Calculate the size of temporary needed in the assignment. Return loop, lss
      and rss which are used in function generate_loop_for_rhs_to_temp().  */
-  gfc_init_block (&inner_size_body);
-  inner_size = compute_inner_temp_size (expr1, expr2, &inner_size_body,
-                                       &lss, &rss);
-
   /* The type of LHS. Used in function allocate_temp_for_forall_nest */
-  if (expr1->ts.type == BT_CHARACTER && expr1->ts.u.cl->length)
+  if (expr1->ts.type == BT_CHARACTER)
     {
-      if (!expr1->ts.u.cl->backend_decl)
+      type = NULL;
+      if (expr1->ref && expr1->ref->type == REF_SUBSTRING)
+       {
+         gfc_se ssse;
+         gfc_init_se (&ssse, NULL);
+         gfc_conv_expr (&ssse, expr1);
+         type = gfc_get_character_type_len (gfc_default_character_kind,
+                                            ssse.string_length);
+       }
+      else
        {
-         gfc_se tse;
-         gfc_init_se (&tse, NULL);
-         gfc_conv_expr (&tse, expr1->ts.u.cl->length);
-         expr1->ts.u.cl->backend_decl = tse.expr;
+         if (!expr1->ts.u.cl->backend_decl)
+           {
+             gfc_se tse;
+             gcc_assert (expr1->ts.u.cl->length);
+             gfc_init_se (&tse, NULL);
+             gfc_conv_expr (&tse, expr1->ts.u.cl->length);
+             expr1->ts.u.cl->backend_decl = tse.expr;
+           }
+         type = gfc_get_character_type_len (gfc_default_character_kind,
+                                            expr1->ts.u.cl->backend_decl);
        }
-      type = gfc_get_character_type_len (gfc_default_character_kind,
-                                        expr1->ts.u.cl->backend_decl);
     }
   else
     type = gfc_typenode_for_spec (&expr1->ts);
 
+  gfc_init_block (&inner_size_body);
+  inner_size = compute_inner_temp_size (expr1, expr2, &inner_size_body,
+                                       &lss, &rss);
+
   /* Allocate temporary for nested forall construct according to the
      information in nested_forall_info and inner_size.  */
   tmp1 = allocate_temp_for_forall_nest (nested_forall_info, type, inner_size,
@@ -3659,8 +4296,14 @@ gfc_trans_assign_need_temp (gfc_expr * expr1, gfc_expr * expr2,
   if (wheremask)
     gfc_add_modify (block, count, gfc_index_zero_node);
 
+  /* TODO: Second call to compute_inner_temp_size to initialize lss and
+     rss;  there must be a better way.  */
+  inner_size = compute_inner_temp_size (expr1, expr2, &inner_size_body,
+                                       &lss, &rss);
+
   /* Generate codes to copy the temporary to lhs.  */
   tmp = generate_loop_for_temp_to_lhs (expr1, tmp1, count, count1,
+                                      lss, rss,
                                       wheremask, invert);
 
   /* Generate body and loops according to the information in
@@ -4117,8 +4760,8 @@ gfc_trans_forall_1 (gfc_code * code, forall_info * nested_forall_info)
 
           /* Temporaries due to array assignment data dependencies introduce
              no end of problems.  */
-         if (need_temp)
-            gfc_trans_assign_need_temp (c->expr1, c->expr2, NULL, false,
+         if (need_temp || flag_test_forall_temp)
+           gfc_trans_assign_need_temp (c->expr1, c->expr2, NULL, false,
                                         nested_forall_info, &block);
           else
             {
@@ -4146,7 +4789,12 @@ gfc_trans_forall_1 (gfc_code * code, forall_info * nested_forall_info)
         /* Pointer assignment inside FORALL.  */
        case EXEC_POINTER_ASSIGN:
           need_temp = gfc_check_dependency (c->expr1, c->expr2, 0);
-          if (need_temp)
+         /* Avoid cases where a temporary would never be needed and where
+            the temp code is guaranteed to fail.  */
+         if (need_temp
+             || (flag_test_forall_temp
+                 && c->expr2->expr_type != EXPR_CONSTANT
+                 && c->expr2->expr_type != EXPR_NULL))
             gfc_trans_pointer_assign_need_temp (c->expr1, c->expr2,
                                                 nested_forall_info, &block);
           else
@@ -4671,7 +5319,7 @@ gfc_trans_where_2 (gfc_code * code, tree mask, bool invert,
                                          &inner_size_body, block);
 
       /* Check whether the size is negative.  */
-      cond = fold_build2_loc (input_location, LE_EXPR, boolean_type_node, size,
+      cond = fold_build2_loc (input_location, LE_EXPR, logical_type_node, size,
                              gfc_index_zero_node);
       size = fold_build3_loc (input_location, COND_EXPR, gfc_array_index_type,
                              cond, gfc_index_zero_node, size);
@@ -4754,7 +5402,8 @@ gfc_trans_where_2 (gfc_code * code, tree mask, bool invert,
               if (nested_forall_info != NULL)
                 {
                   need_temp = gfc_check_dependency (expr1, expr2, 0);
-                  if (need_temp && cnext->op != EXEC_ASSIGN_CALL)
+                 if ((need_temp || flag_test_forall_temp)
+                   && cnext->op != EXEC_ASSIGN_CALL)
                     gfc_trans_assign_need_temp (expr1, expr2,
                                                cmask, invert,
                                                 nested_forall_info, block);
@@ -4855,10 +5504,15 @@ gfc_trans_where_3 (gfc_code * cblock, gfc_code * eblock)
   gfc_loopinfo loop;
   gfc_ss *edss = 0;
   gfc_ss *esss = 0;
+  bool maybe_workshare = false;
 
   /* Allow the scalarizer to workshare simple where loops.  */
-  if (ompws_flags & OMPWS_WORKSHARE_FLAG)
-    ompws_flags |= OMPWS_SCALARIZER_WS;
+  if ((ompws_flags & (OMPWS_WORKSHARE_FLAG | OMPWS_SCALARIZER_BODY))
+      == OMPWS_WORKSHARE_FLAG)
+    {
+      maybe_workshare = true;
+      ompws_flags |= OMPWS_SCALARIZER_WS | OMPWS_SCALARIZER_BODY;
+    }
 
   cond = cblock->expr1;
   tdst = cblock->next->expr1;
@@ -4958,6 +5612,8 @@ gfc_trans_where_3 (gfc_code * cblock, gfc_code * eblock)
   gfc_add_expr_to_block (&body, tmp);
   gfc_add_block_to_block (&body, &cse.post);
 
+  if (maybe_workshare)
+    ompws_flags &= ~OMPWS_SCALARIZER_BODY;
   gfc_trans_scalarizing_loops (&loop, &body);
   gfc_add_block_to_block (&block, &loop.pre);
   gfc_add_block_to_block (&block, &loop.post);
@@ -5072,13 +5728,41 @@ gfc_trans_exit (gfc_code * code)
 }
 
 
+/* Get the initializer expression for the code and expr of an allocate.
+   When no initializer is needed return NULL.  */
+
+static gfc_expr *
+allocate_get_initializer (gfc_code * code, gfc_expr * expr)
+{
+  if (!gfc_bt_struct (expr->ts.type) && expr->ts.type != BT_CLASS)
+    return NULL;
+
+  /* An explicit type was given in allocate ( T:: object).  */
+  if (code->ext.alloc.ts.type == BT_DERIVED
+      && (code->ext.alloc.ts.u.derived->attr.alloc_comp
+         || gfc_has_default_initializer (code->ext.alloc.ts.u.derived)))
+    return gfc_default_initializer (&code->ext.alloc.ts);
+
+  if (gfc_bt_struct (expr->ts.type)
+      && (expr->ts.u.derived->attr.alloc_comp
+         || gfc_has_default_initializer (expr->ts.u.derived)))
+    return gfc_default_initializer (&expr->ts);
+
+  if (expr->ts.type == BT_CLASS
+      && (CLASS_DATA (expr)->ts.u.derived->attr.alloc_comp
+         || gfc_has_default_initializer (CLASS_DATA (expr)->ts.u.derived)))
+    return gfc_default_initializer (&CLASS_DATA (expr)->ts);
+
+  return NULL;
+}
+
 /* Translate the ALLOCATE statement.  */
 
 tree
 gfc_trans_allocate (gfc_code * code)
 {
   gfc_alloc *al;
-  gfc_expr *expr, *e3rhs = NULL;
+  gfc_expr *expr, *e3rhs = NULL, *init_expr;
   gfc_se se, se_sz;
   tree tmp;
   tree parm;
@@ -5099,9 +5783,13 @@ gfc_trans_allocate (gfc_code * code)
   enum { E3_UNSET = 0, E3_SOURCE, E3_MOLD, E3_DESC } e3_is;
   stmtblock_t block;
   stmtblock_t post;
+  stmtblock_t final_block;
   tree nelems;
-  bool upoly_expr, tmp_expr3_len_flag = false, al_len_needs_set;
+  bool upoly_expr, tmp_expr3_len_flag = false, al_len_needs_set, is_coarray;
+  bool needs_caf_sync, caf_refs_comp;
   gfc_symtree *newsym = NULL;
+  symbol_attribute caf_attr;
+  gfc_actual_arglist *param_list;
 
   if (!code->ext.alloc.list)
     return NULL_TREE;
@@ -5110,9 +5798,11 @@ gfc_trans_allocate (gfc_code * code)
   expr3 = expr3_vptr = expr3_len = expr3_esize = NULL_TREE;
   label_errmsg = label_finish = errmsg = errlen = NULL_TREE;
   e3_is = E3_UNSET;
+  is_coarray = needs_caf_sync = false;
 
   gfc_init_block (&block);
   gfc_init_block (&post);
+  gfc_init_block (&final_block);
 
   /* STAT= (and maybe ERRMSG=) is present.  */
   if (code->expr1)
@@ -5149,7 +5839,15 @@ gfc_trans_allocate (gfc_code * code)
      expression.  */
   if (code->expr3)
     {
-      bool vtab_needed = false, temp_var_needed = false;
+      bool vtab_needed = false, temp_var_needed = false,
+         temp_obj_created = false;
+
+      is_coarray = gfc_is_coarray (code->expr3);
+
+      if (code->expr3->expr_type == EXPR_FUNCTION && !code->expr3->mold
+         && (gfc_is_class_array_function (code->expr3)
+             || gfc_is_alloc_class_scalar_function (code->expr3)))
+       code->expr3->must_finalize = 1;
 
       /* Figure whether we need the vtab from expr3.  */
       for (al = code->ext.alloc.list; !vtab_needed && al != NULL;
@@ -5174,7 +5872,20 @@ gfc_trans_allocate (gfc_code * code)
              if (code->ext.alloc.arr_spec_from_expr3 || code->expr3->rank != 0)
                gfc_conv_expr_descriptor (&se, code->expr3);
              else
-               gfc_conv_expr_reference (&se, code->expr3);
+               {
+                 gfc_conv_expr_reference (&se, code->expr3);
+
+                 /* gfc_conv_expr_reference wraps POINTER_PLUS_EXPR in a
+                    NOP_EXPR, which prevents gfortran from getting the vptr
+                    from the source=-expression.  Remove the NOP_EXPR and go
+                    with the POINTER_PLUS_EXPR in this case.  */
+                 if (code->expr3->ts.type == BT_CLASS
+                     && TREE_CODE (se.expr) == NOP_EXPR
+                     && (TREE_CODE (TREE_OPERAND (se.expr, 0))
+                                                           == POINTER_PLUS_EXPR
+                         || is_coarray))
+                   se.expr = TREE_OPERAND (se.expr, 0);
+               }
              /* Create a temp variable only for component refs to prevent
                 having to go through the full deref-chain each time and to
                 simplfy computation of array properties.  */
@@ -5195,7 +5906,10 @@ gfc_trans_allocate (gfc_code * code)
          if (code->expr3->rank != 0
              && ((!attr.allocatable && !attr.pointer)
                  || (code->expr3->expr_type == EXPR_FUNCTION
-                     && code->expr3->ts.type != BT_CLASS)))
+                     && (code->expr3->ts.type != BT_CLASS
+                         || (code->expr3->value.function.isym
+                             && code->expr3->value.function.isym
+                                                        ->transformational)))))
            gfc_conv_expr_descriptor (&se, code->expr3);
          else
            gfc_conv_expr_reference (&se, code->expr3);
@@ -5204,16 +5918,29 @@ gfc_trans_allocate (gfc_code * code)
                                     code->expr3->ts,
                                     false, true,
                                     false, false);
-         temp_var_needed = !VAR_P (se.expr);
+         temp_obj_created = temp_var_needed = !VAR_P (se.expr);
        }
       gfc_add_block_to_block (&block, &se.pre);
-      gfc_add_block_to_block (&post, &se.post);
+      if (code->expr3->must_finalize)
+       gfc_add_block_to_block (&final_block, &se.post);
+      else
+       gfc_add_block_to_block (&post, &se.post);
+
+      /* Special case when string in expr3 is zero.  */
+      if (code->expr3->ts.type == BT_CHARACTER
+         && integer_zerop (se.string_length))
+       {
+         gfc_init_se (&se, NULL);
+         temp_var_needed = false;
+         expr3_len = build_zero_cst (gfc_charlen_type_node);
+         e3_is = E3_MOLD;
+       }
       /* Prevent aliasing, i.e., se.expr may be already a
             variable declaration.  */
-      if (se.expr != NULL_TREE && temp_var_needed)
+      else if (se.expr != NULL_TREE && temp_var_needed)
        {
          tree var, desc;
-         tmp = GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (se.expr)) ?
+         tmp = GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (se.expr)) || is_coarray ?
                se.expr
              : build_fold_indirect_ref_loc (input_location, se.expr);
 
@@ -5226,7 +5953,7 @@ gfc_trans_allocate (gfc_code * code)
            {
              /* When an array_ref was in expr3, then the descriptor is the
                 first operand.  */
-             if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)))
+             if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)) || is_coarray)
                {
                  desc = TREE_OPERAND (tmp, 0);
                }
@@ -5235,31 +5962,22 @@ gfc_trans_allocate (gfc_code * code)
                  desc = tmp;
                  tmp = gfc_class_data_get (tmp);
                }
-             e3_is = E3_DESC;
+             if (code->ext.alloc.arr_spec_from_expr3)
+               e3_is = E3_DESC;
            }
          else
-           desc = se.expr;
+           desc = !is_coarray ? se.expr
+                              : TREE_OPERAND (TREE_OPERAND (se.expr, 0), 0);
          /* We need a regular (non-UID) symbol here, therefore give a
             prefix.  */
          var = gfc_create_var (TREE_TYPE (tmp), "source");
-         if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)))
+         if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)) || is_coarray)
            {
              gfc_allocate_lang_decl (var);
              GFC_DECL_SAVED_DESCRIPTOR (var) = desc;
            }
          gfc_add_modify_loc (input_location, &block, var, tmp);
 
-         /* Deallocate any allocatable components after all the allocations
-            and assignments of expr3 have been completed.  */
-         if (code->expr3->ts.type == BT_DERIVED
-             && code->expr3->rank == 0
-             && code->expr3->ts.u.derived->attr.alloc_comp)
-           {
-             tmp = gfc_deallocate_alloc_comp (code->expr3->ts.u.derived,
-                                              var, 0);
-             gfc_add_expr_to_block (&post, tmp);
-           }
-
          expr3 = var;
          if (se.string_length)
            /* Evaluate it assuming that it also is complicated like expr3.  */
@@ -5270,6 +5988,21 @@ gfc_trans_allocate (gfc_code * code)
          expr3 = se.expr;
          expr3_len = se.string_length;
        }
+
+      /* Deallocate any allocatable components in expressions that use a
+        temporary object, i.e. are not a simple alias of to an EXPR_VARIABLE.
+        E.g. temporaries of a function call need freeing of their components
+        here.  */
+      if ((code->expr3->ts.type == BT_DERIVED
+          || code->expr3->ts.type == BT_CLASS)
+         && (code->expr3->expr_type != EXPR_VARIABLE || temp_obj_created)
+         && code->expr3->ts.u.derived->attr.alloc_comp)
+       {
+         tmp = gfc_deallocate_alloc_comp (code->expr3->ts.u.derived,
+                                          expr3, code->expr3->rank);
+         gfc_prepend_expr_to_block (&post, tmp);
+       }
+
       /* Store what the expr3 is to be used for.  */
       if (e3_is == E3_UNSET)
        e3_is = expr3 != NULL_TREE ?
@@ -5291,7 +6024,6 @@ gfc_trans_allocate (gfc_code * code)
             expr3 may be a temporary array declaration, therefore check for
             GFC_CLASS_TYPE_P before trying to get the _vptr component.  */
          if (tmp != NULL_TREE
-             && TREE_CODE (tmp) != POINTER_PLUS_EXPR
              && (e3_is == E3_DESC
                  || (GFC_CLASS_TYPE_P (TREE_TYPE (tmp))
                      && (VAR_P (tmp) || !code->expr3->ref))
@@ -5368,77 +6100,12 @@ gfc_trans_allocate (gfc_code * code)
          else
            expr3_esize = TYPE_SIZE_UNIT (
                  gfc_typenode_for_spec (&code->expr3->ts));
-
-         /* The routine gfc_trans_assignment () already implements all
-            techniques needed.  Unfortunately we may have a temporary
-            variable for the source= expression here.  When that is the
-            case convert this variable into a temporary gfc_expr of type
-            EXPR_VARIABLE and used it as rhs for the assignment.  The
-            advantage is, that we get scalarizer support for free,
-            don't have to take care about scalar to array treatment and
-            will benefit of every enhancements gfc_trans_assignment ()
-            gets.
-            No need to check whether e3_is is E3_UNSET, because that is
-            done by expr3 != NULL_TREE.  */
-         if (e3_is != E3_MOLD && expr3 != NULL_TREE
-             && DECL_P (expr3) && DECL_ARTIFICIAL (expr3))
-           {
-             /* Build a temporary symtree and symbol.  Do not add it to
-                the current namespace to prevent accidently modifying
-                a colliding symbol's as.  */
-             newsym = XCNEW (gfc_symtree);
-             /* The name of the symtree should be unique, because
-                gfc_create_var () took care about generating the
-                identifier.  */
-             newsym->name = gfc_get_string (IDENTIFIER_POINTER (
-                                              DECL_NAME (expr3)));
-             newsym->n.sym = gfc_new_symbol (newsym->name, NULL);
-             /* The backend_decl is known.  It is expr3, which is inserted
-                here.  */
-             newsym->n.sym->backend_decl = expr3;
-             e3rhs = gfc_get_expr ();
-             e3rhs->ts = code->expr3->ts;
-             e3rhs->rank = code->expr3->rank;
-             e3rhs->symtree = newsym;
-             /* Mark the symbol referenced or gfc_trans_assignment will
-                bug.  */
-             newsym->n.sym->attr.referenced = 1;
-             e3rhs->expr_type = EXPR_VARIABLE;
-             e3rhs->where = code->expr3->where;
-             /* Set the symbols type, upto it was BT_UNKNOWN.  */
-             newsym->n.sym->ts = e3rhs->ts;
-             /* Check whether the expr3 is array valued.  */
-             if (e3rhs->rank)
-               {
-                 gfc_array_spec *arr;
-                 arr = gfc_get_array_spec ();
-                 arr->rank = e3rhs->rank;
-                 arr->type = AS_DEFERRED;
-                 /* Set the dimension and pointer attribute for arrays
-                    to be on the safe side.  */
-                 newsym->n.sym->attr.dimension = 1;
-                 newsym->n.sym->attr.pointer = 1;
-                 newsym->n.sym->as = arr;
-                 gfc_add_full_array_ref (e3rhs, arr);
-               }
-             else if (POINTER_TYPE_P (TREE_TYPE (expr3)))
-               newsym->n.sym->attr.pointer = 1;
-             /* The string length is known to.  Set it for char arrays.  */
-             if (e3rhs->ts.type == BT_CHARACTER)
-               newsym->n.sym->ts.u.cl->backend_decl = expr3_len;
-             gfc_commit_symbol (newsym->n.sym);
-           }
-         else
-           e3rhs = gfc_copy_expr (code->expr3);
        }
       gcc_assert (expr3_esize);
       expr3_esize = fold_convert (sizetype, expr3_esize);
       if (e3_is == E3_MOLD)
-       {
-         /* The expr3 is no longer valid after this point.  */
-         expr3 = NULL_TREE;
-         e3_is = E3_UNSET;
-       }
+       /* The expr3 is no longer valid after this point.  */
+       expr3 = NULL_TREE;
     }
   else if (code->ext.alloc.ts.type != BT_UNKNOWN)
     {
@@ -5447,10 +6114,9 @@ gfc_trans_allocate (gfc_code * code)
       if (code->ext.alloc.ts.type != BT_CHARACTER)
        expr3_esize = TYPE_SIZE_UNIT (
              gfc_typenode_for_spec (&code->ext.alloc.ts));
-      else
+      else if (code->ext.alloc.ts.u.cl->length != NULL)
        {
          gfc_expr *sz;
-         gcc_assert (code->ext.alloc.ts.u.cl->length != NULL);
          sz = gfc_copy_expr (code->ext.alloc.ts.u.cl->length);
          gfc_init_se (&se_sz, NULL);
          gfc_conv_expr (&se_sz, sz);
@@ -5458,10 +6124,103 @@ gfc_trans_allocate (gfc_code * code)
          tmp = gfc_get_char_type (code->ext.alloc.ts.kind);
          tmp = TYPE_SIZE_UNIT (tmp);
          tmp = fold_convert (TREE_TYPE (se_sz.expr), tmp);
+         gfc_add_block_to_block (&block, &se_sz.pre);
          expr3_esize = fold_build2_loc (input_location, MULT_EXPR,
                                         TREE_TYPE (se_sz.expr),
                                         tmp, se_sz.expr);
+         expr3_esize = gfc_evaluate_now (expr3_esize, &block);
+       }
+      else
+       expr3_esize = NULL_TREE;
+    }
+
+  /* The routine gfc_trans_assignment () already implements all
+     techniques needed.  Unfortunately we may have a temporary
+     variable for the source= expression here.  When that is the
+     case convert this variable into a temporary gfc_expr of type
+     EXPR_VARIABLE and used it as rhs for the assignment.  The
+     advantage is, that we get scalarizer support for free,
+     don't have to take care about scalar to array treatment and
+     will benefit of every enhancements gfc_trans_assignment ()
+     gets.
+     No need to check whether e3_is is E3_UNSET, because that is
+     done by expr3 != NULL_TREE.
+     Exclude variables since the following block does not handle
+     array sections.  In any case, there is no harm in sending
+     variables to gfc_trans_assignment because there is no
+     evaluation of variables.  */
+  if (code->expr3)
+    {
+      if (code->expr3->expr_type != EXPR_VARIABLE
+         && e3_is != E3_MOLD && expr3 != NULL_TREE
+         && DECL_P (expr3) && DECL_ARTIFICIAL (expr3))
+       {
+         /* Build a temporary symtree and symbol.  Do not add it to the current
+            namespace to prevent accidently modifying a colliding
+            symbol's as.  */
+         newsym = XCNEW (gfc_symtree);
+         /* The name of the symtree should be unique, because gfc_create_var ()
+            took care about generating the identifier.  */
+         newsym->name
+           = gfc_get_string ("%s", IDENTIFIER_POINTER (DECL_NAME (expr3)));
+         newsym->n.sym = gfc_new_symbol (newsym->name, NULL);
+         /* The backend_decl is known.  It is expr3, which is inserted
+            here.  */
+         newsym->n.sym->backend_decl = expr3;
+         e3rhs = gfc_get_expr ();
+         e3rhs->rank = code->expr3->rank;
+         e3rhs->symtree = newsym;
+         /* Mark the symbol referenced or gfc_trans_assignment will bug.  */
+         newsym->n.sym->attr.referenced = 1;
+         e3rhs->expr_type = EXPR_VARIABLE;
+         e3rhs->where = code->expr3->where;
+         /* Set the symbols type, upto it was BT_UNKNOWN.  */
+         if (IS_CLASS_ARRAY (code->expr3)
+             && code->expr3->expr_type == EXPR_FUNCTION
+             && code->expr3->value.function.isym
+             && code->expr3->value.function.isym->transformational)
+           {
+             e3rhs->ts = CLASS_DATA (code->expr3)->ts;
+           }
+         else if (code->expr3->ts.type == BT_CLASS
+                  && !GFC_CLASS_TYPE_P (TREE_TYPE (expr3)))
+           e3rhs->ts = CLASS_DATA (code->expr3)->ts;
+         else
+           e3rhs->ts = code->expr3->ts;
+         newsym->n.sym->ts = e3rhs->ts;
+         /* Check whether the expr3 is array valued.  */
+         if (e3rhs->rank)
+           {
+             gfc_array_spec *arr;
+             arr = gfc_get_array_spec ();
+             arr->rank = e3rhs->rank;
+             arr->type = AS_DEFERRED;
+             /* Set the dimension and pointer attribute for arrays
+            to be on the safe side.  */
+             newsym->n.sym->attr.dimension = 1;
+             newsym->n.sym->attr.pointer = 1;
+             newsym->n.sym->as = arr;
+             if (IS_CLASS_ARRAY (code->expr3)
+                 && code->expr3->expr_type == EXPR_FUNCTION
+                 && code->expr3->value.function.isym
+                 && code->expr3->value.function.isym->transformational)
+               {
+                 gfc_array_spec *tarr;
+                 tarr = gfc_get_array_spec ();
+                 *tarr = *arr;
+                 e3rhs->ts.u.derived->as = tarr;
+               }
+             gfc_add_full_array_ref (e3rhs, arr);
+           }
+         else if (POINTER_TYPE_P (TREE_TYPE (expr3)))
+           newsym->n.sym->attr.pointer = 1;
+         /* The string length is known, too.  Set it for char arrays.  */
+         if (e3rhs->ts.type == BT_CHARACTER)
+           newsym->n.sym->ts.u.cl->backend_decl = expr3_len;
+         gfc_commit_symbol (newsym->n.sym);
        }
+      else
+       e3rhs = gfc_copy_expr (code->expr3);
     }
 
   /* Loop over all objects to allocate.  */
@@ -5512,6 +6271,7 @@ gfc_trans_allocate (gfc_code * code)
 
       se.want_pointer = 1;
       se.descriptor_only = 1;
+
       gfc_conv_expr (&se, expr);
       if (expr->ts.type == BT_CHARACTER && expr->ts.deferred)
        /* se.string_length now stores the .string_length variable of expr
@@ -5527,14 +6287,21 @@ gfc_trans_allocate (gfc_code * code)
         needs to be provided, which is done most of the time by the
         pre-evaluation step.  */
       nelems = NULL_TREE;
-      if (expr3_len && code->expr3->ts.type == BT_CHARACTER)
-       /* When al is an array, then the element size for each element
-          in the array is needed, which is the product of the len and
-          esize for char arrays.  */
-       tmp = fold_build2_loc (input_location, MULT_EXPR,
-                              TREE_TYPE (expr3_esize), expr3_esize,
-                              fold_convert (TREE_TYPE (expr3_esize),
-                                            expr3_len));
+      if (expr3_len && (code->expr3->ts.type == BT_CHARACTER
+                       || code->expr3->ts.type == BT_CLASS))
+       {
+         /* When al is an array, then the element size for each element
+            in the array is needed, which is the product of the len and
+            esize for char arrays.  For unlimited polymorphics len can be
+            zero, therefore take the maximum of len and one.  */
+         tmp = fold_build2_loc (input_location, MAX_EXPR,
+                                TREE_TYPE (expr3_len),
+                                expr3_len, fold_convert (TREE_TYPE (expr3_len),
+                                                         integer_one_node));
+         tmp = fold_build2_loc (input_location, MULT_EXPR,
+                                TREE_TYPE (expr3_esize), expr3_esize,
+                                fold_convert (TREE_TYPE (expr3_esize), tmp));
+       }
       else
        tmp = expr3_esize;
       if (!gfc_array_allocate (&se, expr, stat, errmsg, errlen,
@@ -5569,8 +6336,9 @@ gfc_trans_allocate (gfc_code * code)
                     polymorphic and stores a _len dependent object,
                     e.g., a string.  */
                  memsz = fold_build2_loc (input_location, GT_EXPR,
-                                          boolean_type_node, expr3_len,
-                                          integer_zero_node);
+                                          logical_type_node, expr3_len,
+                                          build_zero_cst
+                                          (TREE_TYPE (expr3_len)));
                  memsz = fold_build3_loc (input_location, COND_EXPR,
                                         TREE_TYPE (expr3_esize),
                                         memsz, tmp, expr3_esize);
@@ -5621,24 +6389,53 @@ gfc_trans_allocate (gfc_code * code)
            /* Handle size computation of the type declared to alloc.  */
            memsz = TYPE_SIZE_UNIT (TREE_TYPE (TREE_TYPE (se.expr)));
 
+         /* Store the caf-attributes for latter use.  */
+         if (flag_coarray == GFC_FCOARRAY_LIB
+             && (caf_attr = gfc_caf_attr (expr, true, &caf_refs_comp))
+                .codimension)
+           {
+             /* Scalar allocatable components in coarray'ed derived types make
+                it here and are treated now.  */
+             tree caf_decl, token;
+             gfc_se caf_se;
+
+             is_coarray = true;
+             /* Set flag, to add synchronize after the allocate.  */
+             needs_caf_sync = needs_caf_sync
+                 || caf_attr.coarray_comp || !caf_refs_comp;
+
+             gfc_init_se (&caf_se, NULL);
+
+             caf_decl = gfc_get_tree_for_caf_expr (expr);
+             gfc_get_caf_token_offset (&caf_se, &token, NULL, caf_decl,
+                                       NULL_TREE, NULL);
+             gfc_add_block_to_block (&se.pre, &caf_se.pre);
+             gfc_allocate_allocatable (&se.pre, se.expr, memsz,
+                                       gfc_build_addr_expr (NULL_TREE, token),
+                                       NULL_TREE, NULL_TREE, NULL_TREE,
+                                       label_finish, expr, 1);
+           }
          /* Allocate - for non-pointers with re-alloc checking.  */
-         if (gfc_expr_attr (expr).allocatable)
-           gfc_allocate_allocatable (&se.pre, se.expr, memsz, NULL_TREE,
-                                     stat, errmsg, errlen, label_finish,
-                                     expr);
+         else if (gfc_expr_attr (expr).allocatable)
+           gfc_allocate_allocatable (&se.pre, se.expr, memsz,
+                                     NULL_TREE, stat, errmsg, errlen,
+                                     label_finish, expr, 0);
          else
            gfc_allocate_using_malloc (&se.pre, se.expr, memsz, stat);
-
-         if (al->expr->ts.type == BT_DERIVED
-             && expr->ts.u.derived->attr.alloc_comp)
-           {
-             tmp = build_fold_indirect_ref_loc (input_location, se.expr);
-             tmp = gfc_nullify_alloc_comp (expr->ts.u.derived, tmp, 0);
-             gfc_add_expr_to_block (&se.pre, tmp);
-           }
        }
       else
        {
+         /* Allocating coarrays needs a sync after the allocate executed.
+            Set the flag to add the sync after all objects are allocated.  */
+         if (flag_coarray == GFC_FCOARRAY_LIB
+             && (caf_attr = gfc_caf_attr (expr, true, &caf_refs_comp))
+                .codimension)
+           {
+             is_coarray = true;
+             needs_caf_sync = needs_caf_sync
+                 || caf_attr.coarray_comp || !caf_refs_comp;
+           }
+
          if (expr->ts.type == BT_CHARACTER && al_len != NULL_TREE
              && expr3_len != NULL_TREE)
            {
@@ -5649,6 +6446,21 @@ gfc_trans_allocate (gfc_code * code)
              /* Prevent setting the length twice.  */
              al_len_needs_set = false;
            }
+         else if (expr->ts.type == BT_CHARACTER && al_len != NULL_TREE
+             && code->ext.alloc.ts.u.cl->length)
+           {
+             /* Cover the cases where a string length is explicitly
+                specified by a type spec for deferred length character
+                arrays or unlimited polymorphic objects without a
+                source= or mold= expression.  */
+             gfc_init_se (&se_sz, NULL);
+             gfc_conv_expr (&se_sz, code->ext.alloc.ts.u.cl->length);
+             gfc_add_block_to_block (&block, &se_sz.pre);
+             gfc_add_modify (&block, al_len,
+                             fold_convert (TREE_TYPE (al_len),
+                                           se_sz.expr));
+             al_len_needs_set = false;
+           }
        }
 
       gfc_add_block_to_block (&block, &se.pre);
@@ -5658,7 +6470,7 @@ gfc_trans_allocate (gfc_code * code)
        {
          tmp = build1_v (GOTO_EXPR, label_errmsg);
          parm = fold_build2_loc (input_location, NE_EXPR,
-                                 boolean_type_node, stat,
+                                 logical_type_node, stat,
                                  build_int_cst (TREE_TYPE (stat), 0));
          tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
                                 gfc_unlikely (parm, PRED_FORTRAN_FAIL_ALLOC),
@@ -5666,8 +6478,9 @@ gfc_trans_allocate (gfc_code * code)
          gfc_add_expr_to_block (&block, tmp);
        }
 
-      /* Set the vptr.  */
-      if (al_vptr != NULL_TREE)
+      /* Set the vptr only when no source= is set.  When source= is set, then
+        the trans_assignment below will set the vptr.  */
+      if (al_vptr != NULL_TREE && (!code->expr3 || code->expr3->mold))
        {
          if (expr3_vptr != NULL_TREE)
            /* The vtab is already known, so just assign it.  */
@@ -5722,17 +6535,25 @@ gfc_trans_allocate (gfc_code * code)
                expr3_len = NULL_TREE;
            }
          else if (code->ext.alloc.ts.type == BT_CHARACTER
-                  && code->ext.alloc.ts.u.cl->length)
+             && code->ext.alloc.ts.u.cl->length)
            {
              /* Cover the cases where a string length is explicitly
                 specified by a type spec for deferred length character
                 arrays or unlimited polymorphic objects without a
                 source= or mold= expression.  */
-             gfc_init_se (&se_sz, NULL);
-             gfc_conv_expr (&se_sz, code->ext.alloc.ts.u.cl->length);
-             gfc_add_modify (&block, al_len,
-                             fold_convert (TREE_TYPE (al_len),
-                                           se_sz.expr));
+             if (expr3_esize == NULL_TREE || code->ext.alloc.ts.kind != 1)
+               {
+                 gfc_init_se (&se_sz, NULL);
+                 gfc_conv_expr (&se_sz, code->ext.alloc.ts.u.cl->length);
+                 gfc_add_block_to_block (&block, &se_sz.pre);
+                 gfc_add_modify (&block, al_len,
+                                 fold_convert (TREE_TYPE (al_len),
+                                               se_sz.expr));
+               }
+             else
+               gfc_add_modify (&block, al_len,
+                               fold_convert (TREE_TYPE (al_len),
+                                             expr3_esize));
            }
          else
            /* No length information needed, because type to allocate
@@ -5741,154 +6562,119 @@ gfc_trans_allocate (gfc_code * code)
                            fold_convert (TREE_TYPE (al_len),
                                          integer_zero_node));
        }
-      if (code->expr3 && !code->expr3->mold)
+
+      init_expr = NULL;
+      if (code->expr3 && !code->expr3->mold && e3_is != E3_MOLD)
        {
          /* Initialization via SOURCE block (or static default initializer).
-            Classes need some special handling, so catch them first.  */
-         if (expr3 != NULL_TREE
-             && TREE_CODE (expr3) != POINTER_PLUS_EXPR
-             && code->expr3->ts.type == BT_CLASS
-             && (expr->ts.type == BT_CLASS
-                 || expr->ts.type == BT_DERIVED))
+            Switch off automatic reallocation since we have just done the
+            ALLOCATE.  */
+         int realloc_lhs = flag_realloc_lhs;
+         gfc_expr *init_expr = gfc_expr_to_initialize (expr);
+         gfc_expr *rhs = e3rhs ? e3rhs : gfc_copy_expr (code->expr3);
+         flag_realloc_lhs = 0;
+         tmp = gfc_trans_assignment (init_expr, rhs, false, false, true,
+                                     false);
+         flag_realloc_lhs = realloc_lhs;
+         /* Free the expression allocated for init_expr.  */
+         gfc_free_expr (init_expr);
+         if (rhs != e3rhs)
+           gfc_free_expr (rhs);
+         gfc_add_expr_to_block (&block, tmp);
+       }
+      /* Set KIND and LEN PDT components and allocate those that are
+         parameterized.  */
+      else if (expr->ts.type == BT_DERIVED
+              && expr->ts.u.derived->attr.pdt_type)
+       {
+         if (code->expr3 && code->expr3->param_list)
+           param_list = code->expr3->param_list;
+         else if (expr->param_list)
+           param_list = expr->param_list;
+         else
+           param_list = expr->symtree->n.sym->param_list;
+         tmp = gfc_allocate_pdt_comp (expr->ts.u.derived, se.expr,
+                                      expr->rank, param_list);
+         gfc_add_expr_to_block (&block, tmp);
+       }
+      /* Ditto for CLASS expressions.  */
+      else if (expr->ts.type == BT_CLASS
+              && CLASS_DATA (expr)->ts.u.derived->attr.pdt_type)
+       {
+         if (code->expr3 && code->expr3->param_list)
+           param_list = code->expr3->param_list;
+         else if (expr->param_list)
+           param_list = expr->param_list;
+         else
+           param_list = expr->symtree->n.sym->param_list;
+         tmp = gfc_allocate_pdt_comp (CLASS_DATA (expr)->ts.u.derived,
+                                      se.expr, expr->rank, param_list);
+         gfc_add_expr_to_block (&block, tmp);
+       }
+      else if (code->expr3 && code->expr3->mold
+              && code->expr3->ts.type == BT_CLASS)
+       {
+         /* Use class_init_assign to initialize expr.  */
+         gfc_code *ini;
+         ini = gfc_get_code (EXEC_INIT_ASSIGN);
+         ini->expr1 = gfc_find_and_cut_at_last_class_ref (expr);
+         tmp = gfc_trans_class_init_assign (ini);
+         gfc_free_statements (ini);
+         gfc_add_expr_to_block (&block, tmp);
+       }
+      else if ((init_expr = allocate_get_initializer (code, expr)))
+       {
+         /* Use class_init_assign to initialize expr.  */
+         gfc_code *ini;
+         int realloc_lhs = flag_realloc_lhs;
+         ini = gfc_get_code (EXEC_INIT_ASSIGN);
+         ini->expr1 = gfc_expr_to_initialize (expr);
+         ini->expr2 = init_expr;
+         flag_realloc_lhs = 0;
+         tmp= gfc_trans_init_assign (ini);
+         flag_realloc_lhs = realloc_lhs;
+         gfc_free_statements (ini);
+         /* Init_expr is freeed by above free_statements, just need to null
+            it here.  */
+         init_expr = NULL;
+         gfc_add_expr_to_block (&block, tmp);
+       }
+
+      /* Nullify all pointers in derived type coarrays.  This registers a
+        token for them which allows their allocation.  */
+      if (is_coarray)
+       {
+         gfc_symbol *type = NULL;
+         symbol_attribute caf_attr;
+         int rank = 0;
+         if (code->ext.alloc.ts.type == BT_DERIVED
+             && code->ext.alloc.ts.u.derived->attr.pointer_comp)
            {
-             /* copy_class_to_class can be used for class arrays, too.
-                It just needs to be ensured, that the decl_saved_descriptor
-                has a way to get to the vptr.  */
-             tree to;
-             to = VAR_P (se.expr) ? se.expr : TREE_OPERAND (se.expr, 0);
-             tmp = gfc_copy_class_to_class (expr3, to,
-                                            nelems, upoly_expr);
+             type = code->ext.alloc.ts.u.derived;
+             rank = type->attr.dimension ? type->as->rank : 0;
+             gfc_clear_attr (&caf_attr);
            }
-         else if (al->expr->ts.type == BT_CLASS)
+         else if (expr->ts.type == BT_DERIVED
+                  && expr->ts.u.derived->attr.pointer_comp)
            {
-             gfc_actual_arglist *actual, *last_arg;
-             gfc_expr *ppc;
-             gfc_code *ppc_code;
-             gfc_ref *ref, *dataref;
-             gfc_expr *rhs = e3rhs ? e3rhs : gfc_copy_expr (code->expr3);
-
-             /* Do a polymorphic deep copy.  */
-             actual = gfc_get_actual_arglist ();
-             actual->expr = gfc_copy_expr (rhs);
-             if (rhs->ts.type == BT_CLASS)
-               gfc_add_data_component (actual->expr);
-             last_arg = actual->next = gfc_get_actual_arglist ();
-             last_arg->expr = gfc_copy_expr (al->expr);
-             last_arg->expr->ts.type = BT_CLASS;
-             gfc_add_data_component (last_arg->expr);
-
-             dataref = NULL;
-             /* Make sure we go up through the reference chain to
-                the _data reference, where the arrayspec is found.  */
-             for (ref = last_arg->expr->ref; ref; ref = ref->next)
-               if (ref->type == REF_COMPONENT
-                   && strcmp (ref->u.c.component->name, "_data") == 0)
-                 dataref = ref;
-
-             if (dataref && dataref->u.c.component->as)
-               {
-                 gfc_array_spec *as = dataref->u.c.component->as;
-                 gfc_free_ref_list (dataref->next);
-                 dataref->next = NULL;
-                 gfc_add_full_array_ref (last_arg->expr, as);
-                 gfc_resolve_expr (last_arg->expr);
-                 gcc_assert (last_arg->expr->ts.type == BT_CLASS
-                             || last_arg->expr->ts.type == BT_DERIVED);
-                 last_arg->expr->ts.type = BT_CLASS;
-               }
-             if (rhs->ts.type == BT_CLASS)
-               {
-                 if (rhs->ref)
-                   ppc = gfc_find_and_cut_at_last_class_ref (rhs);
-                 else
-                   ppc = gfc_copy_expr (rhs);
-                 gfc_add_vptr_component (ppc);
-               }
-             else
-               ppc = gfc_lval_expr_from_sym (gfc_find_vtab (&rhs->ts));
-             gfc_add_component_ref (ppc, "_copy");
-
-             ppc_code = gfc_get_code (EXEC_CALL);
-             ppc_code->resolved_sym = ppc->symtree->n.sym;
-             ppc_code->loc = al->expr->where;
-             /* Although '_copy' is set to be elemental in class.c, it is
-                not staying that way.  Find out why, sometime....  */
-             ppc_code->resolved_sym->attr.elemental = 1;
-             ppc_code->ext.actual = actual;
-             ppc_code->expr1 = ppc;
-             /* Since '_copy' is elemental, the scalarizer will take care
-                of arrays in gfc_trans_call.  */
-             tmp = gfc_trans_call (ppc_code, true, NULL, NULL, false);
-             /* We need to add the
-                  if (al_len > 0)
-                    al_vptr->copy (expr3_data, al_data, expr3_len, al_len);
-                  else
-                    al_vptr->copy (expr3_data, al_data);
-                block, because al is unlimited polymorphic or a deferred
-                length char array, whose copy routine needs the array lengths
-                as third and fourth arguments.  */
-             if (al_len && UNLIMITED_POLY (code->expr3))
-               {
-                 tree stdcopy, extcopy;
-                 /* Add al%_len.  */
-                 last_arg->next = gfc_get_actual_arglist ();
-                 last_arg = last_arg->next;
-                 last_arg->expr = gfc_find_and_cut_at_last_class_ref (
-                       al->expr);
-                 gfc_add_len_component (last_arg->expr);
-                 /* Add expr3's length.  */
-                 last_arg->next = gfc_get_actual_arglist ();
-                 last_arg = last_arg->next;
-                 if (code->expr3->ts.type == BT_CLASS)
-                   {
-                     last_arg->expr =
-                         gfc_find_and_cut_at_last_class_ref (code->expr3);
-                     gfc_add_len_component (last_arg->expr);
-                   }
-                 else if (code->expr3->ts.type == BT_CHARACTER)
-                   last_arg->expr =
-                       gfc_copy_expr (code->expr3->ts.u.cl->length);
-                 else
-                   gcc_unreachable ();
-
-                 stdcopy = tmp;
-                 extcopy = gfc_trans_call (ppc_code, true, NULL, NULL, false);
-
-                 tmp = fold_build2_loc (input_location, GT_EXPR,
-                                        boolean_type_node, expr3_len,
-                                        integer_zero_node);
-                 tmp = fold_build3_loc (input_location, COND_EXPR,
-                                        void_type_node, tmp, extcopy, stdcopy);
-               }
-             gfc_free_statements (ppc_code);
-             if (rhs != e3rhs)
-               gfc_free_expr (rhs);
+             type = expr->ts.u.derived;
+             rank = expr->rank;
+             caf_attr = gfc_caf_attr (expr, true);
            }
-         else
+
+         /* Initialize the tokens of pointer components in derived type
+            coarrays.  */
+         if (type)
            {
-             /* Switch off automatic reallocation since we have just
-                done the ALLOCATE.  */
-             int realloc_lhs = flag_realloc_lhs;
-             flag_realloc_lhs = 0;
-             tmp = gfc_trans_assignment (gfc_expr_to_initialize (expr),
-                                         e3rhs, false, false);
-             flag_realloc_lhs = realloc_lhs;
+             tmp = (caf_attr.codimension && !caf_attr.dimension)
+                 ? gfc_conv_descriptor_data_get (se.expr) : se.expr;
+             tmp = gfc_nullify_alloc_comp (type, tmp, rank,
+                                           GFC_STRUCTURE_CAF_MODE_IN_COARRAY);
+             gfc_add_expr_to_block (&block, tmp);
            }
-         gfc_add_expr_to_block (&block, tmp);
-       }
-     else if (code->expr3 && code->expr3->mold
-             && code->expr3->ts.type == BT_CLASS)
-       {
-         /* Since the _vptr has already been assigned to the allocate
-            object, we can use gfc_copy_class_to_class in its
-            initialization mode.  */
-         tmp = TREE_OPERAND (se.expr, 0);
-         tmp = gfc_copy_class_to_class (NULL_TREE, tmp, nelems,
-                                        upoly_expr);
-         gfc_add_expr_to_block (&block, tmp);
        }
 
-       gfc_free_expr (expr);
+      gfc_free_expr (expr);
     } // for-loop
 
   if (e3rhs)
@@ -5921,7 +6707,7 @@ gfc_trans_allocate (gfc_code * code)
                gfc_build_addr_expr (pchar_type_node,
                        gfc_build_localized_cstring_const (msg)));
 
-      slen = build_int_cst (gfc_charlen_type_node, ((int) strlen (msg)));
+      slen = build_int_cst (gfc_charlen_type_node, strlen (msg));
       dlen = gfc_get_expr_charlen (code->expr2);
       slen = fold_build2_loc (input_location, MIN_EXPR,
                              TREE_TYPE (slen), dlen, slen);
@@ -5932,7 +6718,7 @@ gfc_trans_allocate (gfc_code * code)
                             gfc_default_character_kind);
       dlen = gfc_finish_block (&errmsg_block);
 
-      tmp = fold_build2_loc (input_location, NE_EXPR, boolean_type_node,
+      tmp = fold_build2_loc (input_location, NE_EXPR, logical_type_node,
                             stat, build_int_cst (TREE_TYPE (stat), 0));
 
       tmp = build3_v (COND_EXPR, tmp,
@@ -5956,8 +6742,19 @@ gfc_trans_allocate (gfc_code * code)
       gfc_add_modify (&block, se.expr, tmp);
     }
 
+  if (needs_caf_sync)
+    {
+      /* Add a sync all after the allocation has been executed.  */
+      tmp = build_call_expr_loc (input_location, gfor_fndecl_caf_sync_all,
+                                3, null_pointer_node, null_pointer_node,
+                                integer_zero_node);
+      gfc_add_expr_to_block (&post, tmp);
+    }
+
   gfc_add_block_to_block (&block, &se.post);
   gfc_add_block_to_block (&block, &post);
+  if (code->expr3 && code->expr3->must_finalize)
+    gfc_add_block_to_block (&block, &final_block);
 
   return gfc_finish_block (&block);
 }
@@ -6008,6 +6805,9 @@ gfc_trans_deallocate (gfc_code *code)
   for (al = code->ext.alloc.list; al != NULL; al = al->next)
     {
       gfc_expr *expr = gfc_copy_expr (al->expr);
+      bool is_coarray = false, is_coarray_array = false;
+      int caf_mode = 0;
+
       gcc_assert (expr->expr_type == EXPR_VARIABLE);
 
       if (expr->ts.type == BT_CLASS)
@@ -6020,11 +6820,48 @@ gfc_trans_deallocate (gfc_code *code)
       se.descriptor_only = 1;
       gfc_conv_expr (&se, expr);
 
-      if (expr->rank || gfc_is_coarray (expr))
+      /* Deallocate PDT components that are parameterized.  */
+      tmp = NULL;
+      if (expr->ts.type == BT_DERIVED
+         && expr->ts.u.derived->attr.pdt_type
+         && expr->symtree->n.sym->param_list)
+       tmp = gfc_deallocate_pdt_comp (expr->ts.u.derived, se.expr, expr->rank);
+      else if (expr->ts.type == BT_CLASS
+              && CLASS_DATA (expr)->ts.u.derived->attr.pdt_type
+              && expr->symtree->n.sym->param_list)
+       tmp = gfc_deallocate_pdt_comp (CLASS_DATA (expr)->ts.u.derived,
+                                      se.expr, expr->rank);
+
+      if (tmp)
+       gfc_add_expr_to_block (&block, tmp);
+
+      if (flag_coarray == GFC_FCOARRAY_LIB
+         || flag_coarray == GFC_FCOARRAY_SINGLE)
+       {
+         bool comp_ref;
+         symbol_attribute caf_attr = gfc_caf_attr (expr, false, &comp_ref);
+         if (caf_attr.codimension)
+           {
+             is_coarray = true;
+             is_coarray_array = caf_attr.dimension || !comp_ref
+                 || caf_attr.coarray_comp;
+
+             if (flag_coarray == GFC_FCOARRAY_LIB)
+               /* When the expression to deallocate is referencing a
+                  component, then only deallocate it, but do not
+                  deregister.  */
+               caf_mode = GFC_STRUCTURE_CAF_MODE_IN_COARRAY
+                   | (comp_ref && !caf_attr.coarray_comp
+                      ? GFC_STRUCTURE_CAF_MODE_DEALLOC_ONLY : 0);
+           }
+       }
+
+      if (expr->rank || is_coarray_array)
        {
          gfc_ref *ref;
 
-         if (expr->ts.type == BT_DERIVED && expr->ts.u.derived->attr.alloc_comp
+         if (gfc_bt_struct (expr->ts.type)
+             && expr->ts.u.derived->attr.alloc_comp
              && !gfc_is_finalizable (expr->ts.u.derived, NULL))
            {
              gfc_ref *last = NULL;
@@ -6038,16 +6875,36 @@ gfc_trans_deallocate (gfc_code *code)
              if (!(last && last->u.c.component->attr.pointer)
                    && !(!last && expr->symtree->n.sym->attr.pointer))
                {
-                 tmp = gfc_deallocate_alloc_comp (expr->ts.u.derived, se.expr,
-                                                  expr->rank);
+                 if (is_coarray && expr->rank == 0
+                     && (!last || !last->u.c.component->attr.dimension)
+                     && GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (se.expr)))
+                   {
+                     /* Add the ref to the data member only, when this is not
+                        a regular array or deallocate_alloc_comp will try to
+                        add another one.  */
+                     tmp = gfc_conv_descriptor_data_get (se.expr);
+                   }
+                 else
+                   tmp = se.expr;
+                 tmp = gfc_deallocate_alloc_comp (expr->ts.u.derived, tmp,
+                                                  expr->rank, caf_mode);
                  gfc_add_expr_to_block (&se.pre, tmp);
                }
            }
 
          if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (se.expr)))
            {
-             tmp = gfc_array_deallocate (se.expr, pstat, errmsg, errlen,
-                                         label_finish, expr);
+             gfc_coarray_deregtype caf_dtype;
+
+             if (is_coarray)
+               caf_dtype = gfc_caf_is_dealloc_only (caf_mode)
+                   ? GFC_CAF_COARRAY_DEALLOCATE_ONLY
+                   : GFC_CAF_COARRAY_DEREGISTER;
+             else
+               caf_dtype = GFC_CAF_COARRAY_NOCOARRAY;
+             tmp = gfc_deallocate_with_status (se.expr, pstat, errmsg, errlen,
+                                               label_finish, false, expr,
+                                               caf_dtype);
              gfc_add_expr_to_block (&se.pre, tmp);
            }
          else if (TREE_CODE (se.expr) == COMPONENT_REF
@@ -6090,8 +6947,9 @@ gfc_trans_deallocate (gfc_code *code)
        }
       else
        {
-         tmp = gfc_deallocate_scalar_with_status (se.expr, pstat, false,
-                                                  al->expr, al->expr->ts);
+         tmp = gfc_deallocate_scalar_with_status (se.expr, pstat, label_finish,
+                                                  false, al->expr,
+                                                  al->expr->ts, is_coarray);
          gfc_add_expr_to_block (&se.pre, tmp);
 
          /* Set to zero after deallocation.  */
@@ -6115,7 +6973,7 @@ gfc_trans_deallocate (gfc_code *code)
        {
           tree cond;
 
-         cond = fold_build2_loc (input_location, NE_EXPR, boolean_type_node, stat,
+         cond = fold_build2_loc (input_location, NE_EXPR, logical_type_node, stat,
                                  build_int_cst (TREE_TYPE (stat), 0));
          tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
                                 gfc_unlikely (cond, PRED_FORTRAN_FAIL_ALLOC),
@@ -6148,14 +7006,14 @@ gfc_trans_deallocate (gfc_code *code)
       gfc_add_modify (&errmsg_block, errmsg_str,
                gfc_build_addr_expr (pchar_type_node,
                         gfc_build_localized_cstring_const (msg)));
-      slen = build_int_cst (gfc_charlen_type_node, ((int) strlen (msg)));
+      slen = build_int_cst (gfc_charlen_type_node, strlen (msg));
       dlen = gfc_get_expr_charlen (code->expr2);
 
       gfc_trans_string_copy (&errmsg_block, dlen, errmsg, code->expr2->ts.kind,
                             slen, errmsg_str, gfc_default_character_kind);
       tmp = gfc_finish_block (&errmsg_block);
 
-      cond = fold_build2_loc (input_location, NE_EXPR, boolean_type_node, stat,
+      cond = fold_build2_loc (input_location, NE_EXPR, logical_type_node, stat,
                             build_int_cst (TREE_TYPE (stat), 0));
       tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node,
                             gfc_unlikely (cond, PRED_FORTRAN_FAIL_ALLOC), tmp,