x86/Intel: adjust representation of embedded rounding / SAE
[binutils-gdb.git] / gdb / psymtab.c
index 3f3b55968642b8f6c2d9ceae064f07b842f66cd6..e6c9526cc4f63306e459c1846cade86a45cf6afd 100644 (file)
@@ -1,6 +1,6 @@
 /* Partial symbol tables.
 
-   Copyright (C) 2009-2021 Free Software Foundation, Inc.
+   Copyright (C) 2009-2022 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
 #include "ui-out.h"
 #include "command.h"
 #include "readline/tilde.h"
-#include "gdb_regex.h"
+#include "gdbsupport/gdb_regex.h"
 #include "dictionary.h"
 #include "language.h"
 #include "cp-support.h"
 #include "gdbcmd.h"
 #include <algorithm>
 #include <set>
+#include "gdbsupport/buildargv.h"
 
 static struct partial_symbol *lookup_partial_symbol (struct objfile *,
                                                     struct partial_symtab *,
@@ -75,108 +76,15 @@ psymtab_storage::install_psymtab (partial_symtab *pst)
 
 \f
 
-/* Ensure that the partial symbols for OBJFILE have been loaded.  This
-   will print a message when symbols are loaded.  This function
-   returns a range adapter suitable for iterating over the psymtabs of
-   OBJFILE.  */
+/* See psympriv.h.  */
 
 psymtab_storage::partial_symtab_range
-psymbol_functions::require_partial_symbols (struct objfile *objfile)
+psymbol_functions::partial_symbols (struct objfile *objfile)
 {
-  objfile->require_partial_symbols (true);
+  gdb_assert ((objfile->flags & OBJF_PSYMTABS_READ) != 0);
   return m_partial_symtabs->range ();
 }
 
-/* Helper function for psym_map_symtabs_matching_filename that
-   expands the symtabs and calls the iterator.  */
-
-static bool
-partial_map_expand_apply (struct objfile *objfile,
-                         const char *name,
-                         const char *real_path,
-                         struct partial_symtab *pst,
-                         gdb::function_view<bool (symtab *)> callback)
-{
-  struct compunit_symtab *last_made = objfile->compunit_symtabs;
-
-  /* Shared psymtabs should never be seen here.  Instead they should
-     be handled properly by the caller.  */
-  gdb_assert (pst->user == NULL);
-
-  /* Don't visit already-expanded psymtabs.  */
-  if (pst->readin_p (objfile))
-    return 0;
-
-  /* This may expand more than one symtab, and we want to iterate over
-     all of them.  */
-  psymtab_to_symtab (objfile, pst);
-
-  return iterate_over_some_symtabs (name, real_path, objfile->compunit_symtabs,
-                                   last_made, callback);
-}
-
-/*  Psymtab version of map_symtabs_matching_filename.  See its definition in
-    the definition of quick_symbol_functions in symfile.h.  */
-
-bool
-psymbol_functions::map_symtabs_matching_filename
-  (struct objfile *objfile,
-   const char *name,
-   const char *real_path,
-   gdb::function_view<bool (symtab *)> callback)
-{
-  const char *name_basename = lbasename (name);
-
-  for (partial_symtab *pst : require_partial_symbols (objfile))
-    {
-      /* Anonymous psymtabs don't have a file name.  */
-      if (pst->anonymous)
-       continue;
-
-      if (compare_filenames_for_search (pst->filename, name))
-       {
-         while (pst->user)
-           pst = pst->user;
-
-         if (partial_map_expand_apply (objfile, name, real_path,
-                                       pst, callback))
-           return true;
-         continue;
-       }
-
-      /* Before we invoke realpath, which can get expensive when many
-        files are involved, do a quick comparison of the basenames.  */
-      if (! basenames_may_differ
-         && FILENAME_CMP (name_basename, lbasename (pst->filename)) != 0)
-       continue;
-
-      if (compare_filenames_for_search (psymtab_to_fullname (pst), name))
-       {
-         if (partial_map_expand_apply (objfile, name, real_path,
-                                       pst, callback))
-           return true;
-         continue;
-       }
-
-      /* If the user gave us an absolute path, try to find the file in
-        this symtab and use its absolute path.  */
-      if (real_path != NULL)
-       {
-         gdb_assert (IS_ABSOLUTE_PATH (real_path));
-         gdb_assert (IS_ABSOLUTE_PATH (name));
-         if (filename_cmp (psymtab_to_fullname (pst), real_path) == 0)
-           {
-             if (partial_map_expand_apply (objfile, name, real_path,
-                                           pst, callback))
-               return true;
-             continue;
-           }
-       }
-    }
-
-  return false;
-}
-
 /* Find which partial symtab contains PC and SECTION starting at psymtab PST.
    We may find a different psymtab than PST.  See FIND_PC_SECT_PSYMTAB.  */
 
@@ -223,7 +131,7 @@ find_pc_sect_psymtab_closer (struct objfile *objfile,
             object's symbol table.  */
          p = find_pc_sect_psymbol (objfile, tpst, pc, section);
          if (p != NULL
-             && (p->address (objfile) == BMSYMBOL_VALUE_ADDRESS (msymbol)))
+             && (p->address (objfile) == msymbol.value_address ()))
            return tpst;
 
          /* Also accept the textlow value of a psymtab as a
@@ -300,7 +208,7 @@ psymbol_functions::find_pc_sect_psymtab (struct objfile *objfile,
              p = find_pc_sect_psymbol (objfile, pst, pc, section);
              if (p == NULL
                  || (p->address (objfile)
-                     != BMSYMBOL_VALUE_ADDRESS (msymbol)))
+                     != msymbol.value_address ()))
                goto next;
            }
 
@@ -325,7 +233,7 @@ psymbol_functions::find_pc_sect_psymtab (struct objfile *objfile,
      its CUs may be missing in PSYMTABS_ADDRMAP as they may be varying
      debug info type in single OBJFILE.  */
 
-  for (partial_symtab *pst : require_partial_symbols (objfile))
+  for (partial_symtab *pst : partial_symbols (objfile))
     if (!pst->psymtabs_addrmap_supported
        && pc >= pst->text_low (objfile) && pc < pst->text_high (objfile))
       {
@@ -432,57 +340,6 @@ find_pc_sect_psymbol (struct objfile *objfile,
   return best;
 }
 
-/* Psymtab version of lookup_symbol.  See its definition in
-   the definition of quick_symbol_functions in symfile.h.  */
-
-struct compunit_symtab *
-psymbol_functions::lookup_symbol (struct objfile *objfile,
-                                 block_enum block_index, const char *name,
-                                 const domain_enum domain)
-{
-  const int psymtab_index = (block_index == GLOBAL_BLOCK ? 1 : 0);
-  struct compunit_symtab *stab_best = NULL;
-
-  lookup_name_info lookup_name (name, symbol_name_match_type::FULL);
-
-  lookup_name_info psym_lookup_name = lookup_name.make_ignore_params ();
-
-  for (partial_symtab *ps : require_partial_symbols (objfile))
-    {
-      if (!ps->readin_p (objfile)
-         && lookup_partial_symbol (objfile, ps, psym_lookup_name,
-                                   psymtab_index, domain))
-       {
-         struct symbol *sym, *with_opaque = NULL;
-         struct compunit_symtab *stab = psymtab_to_symtab (objfile, ps);
-         /* Note: While psymtab_to_symtab can return NULL if the
-            partial symtab is empty, we can assume it won't here
-            because lookup_partial_symbol succeeded.  */
-         const struct blockvector *bv = COMPUNIT_BLOCKVECTOR (stab);
-         const struct block *block = BLOCKVECTOR_BLOCK (bv, block_index);
-
-         sym = block_find_symbol (block, name, domain,
-                                  block_find_non_opaque_type_preferred,
-                                  &with_opaque);
-
-         /* Some caution must be observed with overloaded functions
-            and methods, since the index will not contain any overload
-            information (but NAME might contain it).  */
-
-         if (sym != NULL
-             && SYMBOL_MATCHES_SEARCH_NAME (sym, lookup_name))
-           return stab;
-         if (with_opaque != NULL
-             && SYMBOL_MATCHES_SEARCH_NAME (with_opaque, lookup_name))
-           stab_best = stab;
-
-         /* Keep looking through other psymtabs.  */
-       }
-    }
-
-  return stab_best;
-}
-
 /* Psymtab version of lookup_global_symbol_language.  See its definition in
    the definition of quick_symbol_functions in symfile.h.  */
 
@@ -498,7 +355,7 @@ psymbol_functions::lookup_global_symbol_language (struct objfile *objfile,
 
   lookup_name_info lookup_name (name, symbol_name_match_type::FULL);
 
-  for (partial_symtab *ps : require_partial_symbols (objfile))
+  for (partial_symtab *ps : partial_symbols (objfile))
     {
       struct partial_symbol *psym;
       if (ps->readin_p (objfile))
@@ -728,8 +585,8 @@ psymtab_to_symtab (struct objfile *objfile, struct partial_symtab *pst)
 
       if (info_verbose)
        {
-         printf_filtered (_("Reading in symbols for %s...\n"),
-                          pst->filename);
+         gdb_printf (_("Reading in symbols for %s...\n"),
+                     pst->filename);
          gdb_flush (gdb_stdout);
        }
 
@@ -747,7 +604,7 @@ psymbol_functions::find_last_source_symtab (struct objfile *ofp)
 {
   struct partial_symtab *cs_pst = NULL;
 
-  for (partial_symtab *ps : require_partial_symbols (ofp))
+  for (partial_symtab *ps : partial_symbols (ofp))
     {
       const char *name = ps->filename;
       int len = strlen (name);
@@ -771,7 +628,7 @@ psymbol_functions::find_last_source_symtab (struct objfile *ofp)
 
          if (cust == NULL)
            return NULL;
-         return compunit_primary_filetab (cust);
+         return cust->primary_filetab ();
        }
     }
   return NULL;
@@ -783,7 +640,7 @@ psymbol_functions::find_last_source_symtab (struct objfile *ofp)
 void
 psymbol_functions::forget_cached_source_info (struct objfile *objfile)
 {
-  for (partial_symtab *pst : require_partial_symbols (objfile))
+  for (partial_symtab *pst : partial_symbols (objfile))
     {
       if (pst->fullname != NULL)
        {
@@ -798,95 +655,95 @@ print_partial_symbols (struct gdbarch *gdbarch, struct objfile *objfile,
                       const std::vector<partial_symbol *> &symbols,
                       const char *what, struct ui_file *outfile)
 {
-  fprintf_filtered (outfile, "  %s partial symbols:\n", what);
+  gdb_printf (outfile, "  %s partial symbols:\n", what);
   for (partial_symbol *p : symbols)
     {
       QUIT;
-      fprintf_filtered (outfile, "    `%s'", p->ginfo.linkage_name ());
+      gdb_printf (outfile, "    `%s'", p->ginfo.linkage_name ());
       if (p->ginfo.demangled_name () != NULL)
        {
-         fprintf_filtered (outfile, "  `%s'",
-                           p->ginfo.demangled_name ());
+         gdb_printf (outfile, "  `%s'",
+                     p->ginfo.demangled_name ());
        }
-      fputs_filtered (", ", outfile);
+      gdb_puts (", ", outfile);
       switch (p->domain)
        {
        case UNDEF_DOMAIN:
-         fputs_filtered ("undefined domain, ", outfile);
+         gdb_puts ("undefined domain, ", outfile);
          break;
        case VAR_DOMAIN:
          /* This is the usual thing -- don't print it.  */
          break;
        case STRUCT_DOMAIN:
-         fputs_filtered ("struct domain, ", outfile);
+         gdb_puts ("struct domain, ", outfile);
          break;
        case MODULE_DOMAIN:
-         fputs_filtered ("module domain, ", outfile);
+         gdb_puts ("module domain, ", outfile);
          break;
        case LABEL_DOMAIN:
-         fputs_filtered ("label domain, ", outfile);
+         gdb_puts ("label domain, ", outfile);
          break;
        case COMMON_BLOCK_DOMAIN:
-         fputs_filtered ("common block domain, ", outfile);
+         gdb_puts ("common block domain, ", outfile);
          break;
        default:
-         fputs_filtered ("<invalid domain>, ", outfile);
+         gdb_puts ("<invalid domain>, ", outfile);
          break;
        }
       switch (p->aclass)
        {
        case LOC_UNDEF:
-         fputs_filtered ("undefined", outfile);
+         gdb_puts ("undefined", outfile);
          break;
        case LOC_CONST:
-         fputs_filtered ("constant int", outfile);
+         gdb_puts ("constant int", outfile);
          break;
        case LOC_STATIC:
-         fputs_filtered ("static", outfile);
+         gdb_puts ("static", outfile);
          break;
        case LOC_REGISTER:
-         fputs_filtered ("register", outfile);
+         gdb_puts ("register", outfile);
          break;
        case LOC_ARG:
-         fputs_filtered ("pass by value", outfile);
+         gdb_puts ("pass by value", outfile);
          break;
        case LOC_REF_ARG:
-         fputs_filtered ("pass by reference", outfile);
+         gdb_puts ("pass by reference", outfile);
          break;
        case LOC_REGPARM_ADDR:
-         fputs_filtered ("register address parameter", outfile);
+         gdb_puts ("register address parameter", outfile);
          break;
        case LOC_LOCAL:
-         fputs_filtered ("stack parameter", outfile);
+         gdb_puts ("stack parameter", outfile);
          break;
        case LOC_TYPEDEF:
-         fputs_filtered ("type", outfile);
+         gdb_puts ("type", outfile);
          break;
        case LOC_LABEL:
-         fputs_filtered ("label", outfile);
+         gdb_puts ("label", outfile);
          break;
        case LOC_BLOCK:
-         fputs_filtered ("function", outfile);
+         gdb_puts ("function", outfile);
          break;
        case LOC_CONST_BYTES:
-         fputs_filtered ("constant bytes", outfile);
+         gdb_puts ("constant bytes", outfile);
          break;
        case LOC_UNRESOLVED:
-         fputs_filtered ("unresolved", outfile);
+         gdb_puts ("unresolved", outfile);
          break;
        case LOC_OPTIMIZED_OUT:
-         fputs_filtered ("optimized out", outfile);
+         gdb_puts ("optimized out", outfile);
          break;
        case LOC_COMPUTED:
-         fputs_filtered ("computed at runtime", outfile);
+         gdb_puts ("computed at runtime", outfile);
          break;
        default:
-         fputs_filtered ("<invalid location>", outfile);
+         gdb_puts ("<invalid location>", outfile);
          break;
        }
-      fputs_filtered (", ", outfile);
-      fputs_filtered (paddress (gdbarch, p->unrelocated_address ()), outfile);
-      fprintf_filtered (outfile, "\n");
+      gdb_puts (", ", outfile);
+      gdb_puts (paddress (gdbarch, p->unrelocated_address ()), outfile);
+      gdb_printf (outfile, "\n");
     }
 }
 
@@ -899,52 +756,41 @@ dump_psymtab (struct objfile *objfile, struct partial_symtab *psymtab,
 
   if (psymtab->anonymous)
     {
-      fprintf_filtered (outfile, "\nAnonymous partial symtab (%s) ",
-                       psymtab->filename);
+      gdb_printf (outfile, "\nAnonymous partial symtab (%s) ",
+                 psymtab->filename);
     }
   else
     {
-      fprintf_filtered (outfile, "\nPartial symtab for source file %s ",
-                       psymtab->filename);
+      gdb_printf (outfile, "\nPartial symtab for source file %s ",
+                 psymtab->filename);
     }
-  fprintf_filtered (outfile, "(object ");
-  gdb_print_host_address (psymtab, outfile);
-  fprintf_filtered (outfile, ")\n\n");
-  fprintf_filtered (outfile, "  Read from object file %s (",
-                   objfile_name (objfile));
-  gdb_print_host_address (objfile, outfile);
-  fprintf_filtered (outfile, ")\n");
+  gdb_printf (outfile, "(object %s)\n\n",
+             host_address_to_string (psymtab));
+  gdb_printf (outfile, "  Read from object file %s (%s)\n",
+             objfile_name (objfile),
+             host_address_to_string (objfile));
 
   if (psymtab->readin_p (objfile))
-    {
-      fprintf_filtered (outfile,
-                       "  Full symtab was read (at ");
-      gdb_print_host_address (psymtab->get_compunit_symtab (objfile), outfile);
-      fprintf_filtered (outfile, ")\n");
-    }
-
-  fprintf_filtered (outfile, "  Symbols cover text addresses ");
-  fputs_filtered (paddress (gdbarch, psymtab->text_low (objfile)), outfile);
-  fprintf_filtered (outfile, "-");
-  fputs_filtered (paddress (gdbarch, psymtab->text_high (objfile)), outfile);
-  fprintf_filtered (outfile, "\n");
-  fprintf_filtered (outfile, "  Address map supported - %s.\n",
-                   psymtab->psymtabs_addrmap_supported ? "yes" : "no");
-  fprintf_filtered (outfile, "  Depends on %d other partial symtabs.\n",
-                   psymtab->number_of_dependencies);
+    gdb_printf
+      (outfile,
+       "  Full symtab was read (at %s)\n",
+       host_address_to_string (psymtab->get_compunit_symtab (objfile)));
+
+  gdb_printf (outfile, "  Symbols cover text addresses ");
+  gdb_puts (paddress (gdbarch, psymtab->text_low (objfile)), outfile);
+  gdb_printf (outfile, "-");
+  gdb_puts (paddress (gdbarch, psymtab->text_high (objfile)), outfile);
+  gdb_printf (outfile, "\n");
+  gdb_printf (outfile, "  Address map supported - %s.\n",
+             psymtab->psymtabs_addrmap_supported ? "yes" : "no");
+  gdb_printf (outfile, "  Depends on %d other partial symtabs.\n",
+             psymtab->number_of_dependencies);
   for (i = 0; i < psymtab->number_of_dependencies; i++)
-    {
-      fprintf_filtered (outfile, "    %d ", i);
-      gdb_print_host_address (psymtab->dependencies[i], outfile);
-      fprintf_filtered (outfile, " %s\n",
-                       psymtab->dependencies[i]->filename);
-    }
+    gdb_printf (outfile, "    %d %s\n", i,
+               host_address_to_string (psymtab->dependencies[i]));
   if (psymtab->user != NULL)
-    {
-      fprintf_filtered (outfile, "  Shared partial symtab with user ");
-      gdb_print_host_address (psymtab->user, outfile);
-      fprintf_filtered (outfile, "\n");
-    }
+    gdb_printf (outfile, "  Shared partial symtab with user %s\n",
+               host_address_to_string (psymtab->user));
   if (!psymtab->global_psymbols.empty ())
     {
       print_partial_symbols
@@ -957,7 +803,7 @@ dump_psymtab (struct objfile *objfile, struct partial_symtab *psymtab,
        (gdbarch, objfile, psymtab->static_psymbols,
         "Static", outfile);
     }
-  fprintf_filtered (outfile, "\n");
+  gdb_printf (outfile, "\n");
 }
 
 /* Count the number of partial symbols in OBJFILE.  */
@@ -986,23 +832,23 @@ psymbol_functions::print_stats (struct objfile *objfile, bool print_bcache)
     {
       int n_psyms = count_psyms ();
       if (n_psyms > 0)
-       printf_filtered (_("  Number of \"partial\" symbols read: %d\n"),
-                        n_psyms);
+       gdb_printf (_("  Number of \"partial\" symbols read: %d\n"),
+                   n_psyms);
 
       i = 0;
-      for (partial_symtab *ps : require_partial_symbols (objfile))
+      for (partial_symtab *ps : partial_symbols (objfile))
        {
          if (!ps->readin_p (objfile))
            i++;
        }
-      printf_filtered (_("  Number of psym tables (not yet expanded): %d\n"),
-                      i);
-      printf_filtered (_("  Total memory used for psymbol cache: %d\n"),
-                      m_partial_symtabs->psymbol_cache.memory_used ());
+      gdb_printf (_("  Number of psym tables (not yet expanded): %d\n"),
+                 i);
+      gdb_printf (_("  Total memory used for psymbol cache: %d\n"),
+                 m_partial_symtabs->psymbol_cache.memory_used ());
     }
   else
     {
-      printf_filtered (_("Psymbol byte cache statistics:\n"));
+      gdb_printf (_("Psymbol byte cache statistics:\n"));
       m_partial_symtabs->psymbol_cache.print_statistics
        ("partial symbol cache");
     }
@@ -1018,41 +864,14 @@ psymbol_functions::dump (struct objfile *objfile)
 
   if (m_partial_symtabs->psymtabs)
     {
-      printf_filtered ("Psymtabs:\n");
+      gdb_printf ("Psymtabs:\n");
       for (psymtab = m_partial_symtabs->psymtabs;
           psymtab != NULL;
           psymtab = psymtab->next)
-       {
-         printf_filtered ("%s at ",
-                          psymtab->filename);
-         gdb_print_host_address (psymtab, gdb_stdout);
-         printf_filtered (", ");
-         wrap_here ("  ");
-       }
-      printf_filtered ("\n\n");
-    }
-}
-
-/* Psymtab version of expand_symtabs_for_function.  See its definition in
-   the definition of quick_symbol_functions in symfile.h.  */
-
-void
-psymbol_functions::expand_symtabs_for_function (struct objfile *objfile,
-                                               const char *func_name)
-{
-  lookup_name_info base_lookup (func_name, symbol_name_match_type::FULL);
-  lookup_name_info lookup_name = base_lookup.make_ignore_params ();
-
-  for (partial_symtab *ps : require_partial_symbols (objfile))
-    {
-      if (ps->readin_p (objfile))
-       continue;
-
-      if ((lookup_partial_symbol (objfile, ps, lookup_name, 1, VAR_DOMAIN)
-          != NULL)
-         || (lookup_partial_symbol (objfile, ps, lookup_name, 0, VAR_DOMAIN)
-             != NULL))
-       psymtab_to_symtab (objfile, ps);
+       gdb_printf ("%s at %s\n",
+                   psymtab->filename,
+                   host_address_to_string (psymtab));
+      gdb_printf ("\n\n");
     }
 }
 
@@ -1062,42 +881,20 @@ psymbol_functions::expand_symtabs_for_function (struct objfile *objfile,
 void
 psymbol_functions::expand_all_symtabs (struct objfile *objfile)
 {
-  for (partial_symtab *psymtab : require_partial_symbols (objfile))
+  for (partial_symtab *psymtab : partial_symbols (objfile))
     psymtab_to_symtab (objfile, psymtab);
 }
 
-/* Psymtab version of expand_symtabs_with_fullname.  See its definition in
-   the definition of quick_symbol_functions in symfile.h.  */
-
-void
-psymbol_functions::expand_symtabs_with_fullname (struct objfile *objfile,
-                                                const char *fullname)
-{
-  for (partial_symtab *p : require_partial_symbols (objfile))
-    {
-      /* Anonymous psymtabs don't have a name of a source file.  */
-      if (p->anonymous)
-       continue;
-
-      /* psymtab_to_fullname tries to open the file which is slow.
-        Don't call it if we know the basenames don't match.  */
-      if ((basenames_may_differ
-          || filename_cmp (lbasename (fullname), lbasename (p->filename)) == 0)
-         && filename_cmp (fullname, psymtab_to_fullname (p)) == 0)
-       psymtab_to_symtab (objfile, p);
-    }
-}
-
 /* Psymtab version of map_symbol_filenames.  See its definition in
    the definition of quick_symbol_functions in symfile.h.  */
 
 void
-psymbol_functions::map_symbol_filenames (struct objfile *objfile,
-                                        symbol_filename_ftype *fun,
-                                        void *data,
-                                        int need_fullname)
+psymbol_functions::map_symbol_filenames
+     (struct objfile *objfile,
+      gdb::function_view<symbol_filename_ftype> fun,
+      bool need_fullname)
 {
-  for (partial_symtab *ps : require_partial_symbols (objfile))
+  for (partial_symtab *ps : partial_symbols (objfile))
     {
       const char *fullname;
 
@@ -1118,7 +915,7 @@ psymbol_functions::map_symbol_filenames (struct objfile *objfile,
        fullname = psymtab_to_fullname (ps);
       else
        fullname = NULL;
-      (*fun) (ps->filename, fullname, data);
+      fun (ps->filename, fullname);
     }
 }
 
@@ -1140,61 +937,31 @@ psymtab_to_fullname (struct partial_symtab *ps)
      to handle cases like the file being moved.  */
   if (ps->fullname == NULL)
     {
-      gdb::unique_xmalloc_ptr<char> fullname;
-      scoped_fd fd = find_and_open_source (ps->filename, ps->dirname,
-                                          &fullname);
+      gdb::unique_xmalloc_ptr<char> fullname
+       = find_source_or_rewrite (ps->filename, ps->dirname);
       ps->fullname = fullname.release ();
-
-      if (fd.get () < 0)
-       {
-         /* rewrite_source_path would be applied by find_and_open_source, we
-            should report the pathname where GDB tried to find the file.  */
-
-         if (ps->dirname == NULL || IS_ABSOLUTE_PATH (ps->filename))
-           fullname.reset (xstrdup (ps->filename));
-         else
-           fullname.reset (concat (ps->dirname, SLASH_STRING,
-                                   ps->filename, (char *) NULL));
-
-         ps->fullname = rewrite_source_path (fullname.get ()).release ();
-         if (ps->fullname == NULL)
-           ps->fullname = fullname.release ();
-       }
     }
 
   return ps->fullname;
 }
 
-/* Psymtab version of map_matching_symbols.  See its definition in
+/* Psymtab version of expand_matching_symbols.  See its definition in
    the definition of quick_symbol_functions in symfile.h.  */
 
 void
-psymbol_functions::map_matching_symbols
+psymbol_functions::expand_matching_symbols
   (struct objfile *objfile,
    const lookup_name_info &name, domain_enum domain,
    int global,
-   gdb::function_view<symbol_found_callback_ftype> callback,
    symbol_compare_ftype *ordered_compare)
 {
-  const int block_kind = global ? GLOBAL_BLOCK : STATIC_BLOCK;
-
-  for (partial_symtab *ps : require_partial_symbols (objfile))
+  for (partial_symtab *ps : partial_symbols (objfile))
     {
       QUIT;
-      if (ps->readin_p (objfile)
-         || match_partial_symbol (objfile, ps, global, name, domain,
+      if (!ps->readin_p (objfile)
+         && match_partial_symbol (objfile, ps, global, name, domain,
                                   ordered_compare))
-       {
-         struct compunit_symtab *cust = psymtab_to_symtab (objfile, ps);
-         const struct block *block;
-
-         if (cust == NULL)
-           continue;
-         block = BLOCKVECTOR_BLOCK (COMPUNIT_BLOCKVECTOR (cust), block_kind);
-         if (!iterate_over_symbols_terminated (block, name,
-                                               domain, callback))
-           return;
-       }
+       psymtab_to_symtab (objfile, ps);
     }
 }
 
@@ -1207,7 +974,9 @@ static bool
 recursively_search_psymtabs
   (struct partial_symtab *ps,
    struct objfile *objfile,
-   enum search_domain domain,
+   block_search_flags search_flags,
+   domain_enum domain,
+   enum search_domain search,
    const lookup_name_info &lookup_name,
    gdb::function_view<expand_symtabs_symbol_matcher_ftype> sym_matcher)
 {
@@ -1229,8 +998,8 @@ recursively_search_psymtabs
        continue;
 
       r = recursively_search_psymtabs (ps->dependencies[i],
-                                      objfile, domain, lookup_name,
-                                      sym_matcher);
+                                      objfile, search_flags, domain, search,
+                                      lookup_name, sym_matcher);
       if (r != 0)
        {
          ps->searched_flag = PST_SEARCHED_AND_FOUND;
@@ -1247,11 +1016,24 @@ recursively_search_psymtabs
   /* Go through all of the symbols stored in a partial
      symtab in one loop.  */
   partial_symbol **psym = ps->global_psymbols.data ();
+
+  if ((search_flags & SEARCH_GLOBAL_BLOCK) == 0)
+    {
+      if (ps->static_psymbols.empty ())
+       keep_going = 0;
+      else
+       {
+         psym = ps->static_psymbols.data ();
+         bound = sbound;
+       }
+    }
+
   while (keep_going)
     {
       if (psym >= bound)
        {
-         if (bound == gbound && !ps->static_psymbols.empty ())
+         if (bound == gbound && !ps->static_psymbols.empty ()
+             && (search_flags & SEARCH_STATIC_BLOCK) != 0)
            {
              psym = ps->static_psymbols.data ();
              bound = sbound;
@@ -1264,16 +1046,19 @@ recursively_search_psymtabs
        {
          QUIT;
 
-         if ((domain == ALL_DOMAIN
-              || (domain == MODULES_DOMAIN
-                  && (*psym)->domain == MODULE_DOMAIN)
-              || (domain == VARIABLES_DOMAIN
-                  && (*psym)->aclass != LOC_TYPEDEF
-                  && (*psym)->aclass != LOC_BLOCK)
-              || (domain == FUNCTIONS_DOMAIN
-                  && (*psym)->aclass == LOC_BLOCK)
-              || (domain == TYPES_DOMAIN
-                  && (*psym)->aclass == LOC_TYPEDEF))
+         if ((domain == UNDEF_DOMAIN
+              || symbol_matches_domain ((*psym)->ginfo.language (),
+                                        (*psym)->domain, domain))
+             && (search == ALL_DOMAIN
+                 || (search == MODULES_DOMAIN
+                     && (*psym)->domain == MODULE_DOMAIN)
+                 || (search == VARIABLES_DOMAIN
+                     && (*psym)->aclass != LOC_TYPEDEF
+                     && (*psym)->aclass != LOC_BLOCK)
+                 || (search == FUNCTIONS_DOMAIN
+                     && (*psym)->aclass == LOC_BLOCK)
+                 || (search == TYPES_DOMAIN
+                     && (*psym)->aclass == LOC_TYPEDEF))
              && psymbol_name_matches (*psym, lookup_name)
              && (sym_matcher == NULL
                  || sym_matcher ((*psym)->ginfo.search_name ())))
@@ -1293,19 +1078,28 @@ recursively_search_psymtabs
 /* Psymtab version of expand_symtabs_matching.  See its definition in
    the definition of quick_symbol_functions in symfile.h.  */
 
-void
+bool
 psymbol_functions::expand_symtabs_matching
   (struct objfile *objfile,
    gdb::function_view<expand_symtabs_file_matcher_ftype> file_matcher,
    const lookup_name_info *lookup_name,
    gdb::function_view<expand_symtabs_symbol_matcher_ftype> symbol_matcher,
    gdb::function_view<expand_symtabs_exp_notify_ftype> expansion_notify,
-   enum search_domain domain)
+   block_search_flags search_flags,
+   domain_enum domain,
+   enum search_domain search)
 {
   /* Clear the search flags.  */
-  for (partial_symtab *ps : require_partial_symbols (objfile))
+  for (partial_symtab *ps : partial_symbols (objfile))
     ps->searched_flag = PST_NOT_SEARCHED;
 
+  gdb::optional<lookup_name_info> psym_lookup_name;
+  if (lookup_name != nullptr)
+    psym_lookup_name = lookup_name->make_ignore_params ();
+
+  /* This invariant is documented in quick-functions.h.  */
+  gdb_assert (lookup_name != nullptr || symbol_matcher == nullptr);
+
   for (partial_symtab *ps : m_partial_symtabs->range ())
     {
       QUIT;
@@ -1313,11 +1107,6 @@ psymbol_functions::expand_symtabs_matching
       if (ps->readin_p (objfile))
        continue;
 
-      /* We skip shared psymtabs because file-matching doesn't apply
-        to them; but we search them later in the loop.  */
-      if (ps->user != NULL)
-       continue;
-
       if (file_matcher)
        {
          bool match;
@@ -1338,18 +1127,21 @@ psymbol_functions::expand_symtabs_matching
            continue;
        }
 
-      if ((symbol_matcher == NULL && lookup_name == NULL)
-         || recursively_search_psymtabs (ps, objfile, domain,
-                                         lookup_name->make_ignore_params (),
+      if (lookup_name == nullptr
+         || recursively_search_psymtabs (ps, objfile, search_flags,
+                                         domain, search,
+                                         *psym_lookup_name,
                                          symbol_matcher))
        {
-         struct compunit_symtab *symtab =
-           psymtab_to_symtab (objfile, ps);
+         compunit_symtab *cust = psymtab_to_symtab (objfile, ps);
 
-         if (expansion_notify != NULL)
-           expansion_notify (symtab);
+         if (cust != nullptr && expansion_notify != nullptr)
+           if (!expansion_notify (cust))
+             return false;
        }
     }
+
+  return true;
 }
 
 /* Psymtab version of has_symbols.  See its definition in
@@ -1361,6 +1153,24 @@ psymbol_functions::has_symbols (struct objfile *objfile)
   return m_partial_symtabs->psymtabs != NULL;
 }
 
+/* See quick_symbol_functions::has_unexpanded_symtabs in quick-symbol.h.  */
+
+bool
+psymbol_functions::has_unexpanded_symtabs (struct objfile *objfile)
+{
+  for (partial_symtab *psymtab : partial_symbols (objfile))
+    {
+      /* Is this already expanded?  */
+      if (psymtab->readin_p (objfile))
+       continue;
+
+      /* It has not yet been expanded.  */
+      return true;
+    }
+
+  return false;
+}
+
 /* Helper function for psym_find_compunit_symtab_by_address that fills
    in m_psymbol_map for a given range of psymbols.  */
 
@@ -1396,7 +1206,7 @@ psymbol_functions::find_compunit_symtab_by_address (struct objfile *objfile,
     {
       std::set<CORE_ADDR> seen_addrs;
 
-      for (partial_symtab *pst : require_partial_symbols (objfile))
+      for (partial_symtab *pst : partial_symbols (objfile))
        {
          fill_psymbol_map (objfile, pst,
                            &seen_addrs,
@@ -1430,12 +1240,6 @@ psymbol_functions::find_compunit_symtab_by_address (struct objfile *objfile,
   return psymtab_to_symtab (objfile, iter->second);
 }
 
-quick_symbol_functions_up
-make_psymbol_functions (const std::shared_ptr<psymtab_storage> &storage)
-{
-  return quick_symbol_functions_up (new psymbol_functions (storage));
-}
-
 \f
 
 /* Partially fill a partial symtab.  It will be completely filled at
@@ -1443,9 +1247,9 @@ make_psymbol_functions (const std::shared_ptr<psymtab_storage> &storage)
 
 partial_symtab::partial_symtab (const char *filename,
                                psymtab_storage *partial_symtabs,
-                               struct objfile *objfile,
+                               objfile_per_bfd_storage *objfile_per_bfd,
                                CORE_ADDR textlow)
-  : partial_symtab (filename, partial_symtabs, objfile)
+  : partial_symtab (filename, partial_symtabs, objfile_per_bfd)
 {
   set_text_low (textlow);
   set_text_high (raw_text_low ()); /* default */
@@ -1480,7 +1284,7 @@ psymbol_bcache::hash (const void *addr, int length)
   unsigned int domain = psymbol->domain;
   unsigned int theclass = psymbol->aclass;
 
-  h = fast_hash (&psymbol->ginfo.value, sizeof (psymbol->ginfo.value), h);
+  h = fast_hash (&psymbol->ginfo.m_value, sizeof (psymbol->ginfo.m_value), h);
   h = fast_hash (&lang, sizeof (unsigned int), h);
   h = fast_hash (&domain, sizeof (unsigned int), h);
   h = fast_hash (&theclass, sizeof (unsigned int), h);
@@ -1499,8 +1303,8 @@ psymbol_bcache::compare (const void *addr1, const void *addr2, int length)
   struct partial_symbol *sym1 = (struct partial_symbol *) addr1;
   struct partial_symbol *sym2 = (struct partial_symbol *) addr2;
 
-  return (memcmp (&sym1->ginfo.value, &sym2->ginfo.value,
-                 sizeof (sym1->ginfo.value)) == 0
+  return (memcmp (&sym1->ginfo.m_value, &sym2->ginfo.m_value,
+                 sizeof (sym1->ginfo.m_value)) == 0
          && sym1->ginfo.language () == sym2->ginfo.language ()
          && sym1->domain == sym2->domain
          && sym1->aclass == sym2->aclass
@@ -1568,33 +1372,33 @@ partial_symtab::add_psymbol (gdb::string_view name, bool copy_name,
 
 partial_symtab::partial_symtab (const char *filename_,
                                psymtab_storage *partial_symtabs,
-                               struct objfile *objfile)
+                               objfile_per_bfd_storage *objfile_per_bfd)
   : searched_flag (PST_NOT_SEARCHED),
     text_low_valid (0),
     text_high_valid (0)
 {
   partial_symtabs->install_psymtab (this);
 
-  filename = objfile->intern (filename_);
+  filename = objfile_per_bfd->intern (filename_);
 
   if (symtab_create_debug)
     {
       /* Be a bit clever with debugging messages, and don't print objfile
         every time, only when it changes.  */
-      static char *last_objfile_name = NULL;
+      static std::string last_bfd_name;
+      const char *this_bfd_name
+       = bfd_get_filename (objfile_per_bfd->get_bfd ());
 
-      if (last_objfile_name == NULL
-         || strcmp (last_objfile_name, objfile_name (objfile)) != 0)
+      if (last_bfd_name.empty () || last_bfd_name != this_bfd_name)
        {
-         xfree (last_objfile_name);
-         last_objfile_name = xstrdup (objfile_name (objfile));
-         fprintf_filtered (gdb_stdlog,
-                           "Creating one or more psymtabs for objfile %s ...\n",
-                           last_objfile_name);
+         last_bfd_name = this_bfd_name;
+         gdb_printf (gdb_stdlog,
+                     "Creating one or more psymtabs for %s ...\n",
+                     this_bfd_name);
        }
-      fprintf_filtered (gdb_stdlog,
-                       "Created psymtab %s for module %s.\n",
-                       host_address_to_string (this), filename);
+      gdb_printf (gdb_stdlog,
+                 "Created psymtab %s for module %s.\n",
+                 host_address_to_string (this), filename);
     }
 }
 
@@ -1611,12 +1415,11 @@ partial_symtab::expand_dependencies (struct objfile *objfile)
          /* Inform about additional files to be read in.  */
          if (info_verbose)
            {
-             fputs_filtered (" ", gdb_stdout);
-             wrap_here ("");
-             fputs_filtered ("and ", gdb_stdout);
-             wrap_here ("");
-             printf_filtered ("%s...", dependencies[i]->filename);
-             wrap_here ("");   /* Flush output */
+             gdb_puts (" ");
+             gdb_stdout->wrap_here (0);
+             gdb_puts ("and ");
+             gdb_stdout->wrap_here (0);
+             gdb_printf ("%s...", dependencies[i]->filename);
              gdb_flush (gdb_stdout);
            }
          dependencies[i]->expand_psymtab (objfile);
@@ -1648,56 +1451,6 @@ psymtab_storage::discard_psymtab (struct partial_symtab *pst)
 
 \f
 
-/* We need to pass a couple of items to the addrmap_foreach function,
-   so use a struct.  */
-
-struct dump_psymtab_addrmap_data
-{
-  struct objfile *objfile;
-  struct partial_symtab *psymtab;
-  struct ui_file *outfile;
-
-  /* Non-zero if the previously printed addrmap entry was for PSYMTAB.
-     If so, we want to print the next one as well (since the next addrmap
-     entry defines the end of the range).  */
-  int previous_matched;
-};
-
-/* Helper function for dump_psymtab_addrmap to print an addrmap entry.  */
-
-static int
-dump_psymtab_addrmap_1 (void *datap, CORE_ADDR start_addr, void *obj)
-{
-  struct dump_psymtab_addrmap_data *data
-    = (struct dump_psymtab_addrmap_data *) datap;
-  struct gdbarch *gdbarch = data->objfile->arch ();
-  struct partial_symtab *addrmap_psymtab = (struct partial_symtab *) obj;
-  const char *psymtab_address_or_end = NULL;
-
-  QUIT;
-
-  if (data->psymtab == NULL
-      || data->psymtab == addrmap_psymtab)
-    psymtab_address_or_end = host_address_to_string (addrmap_psymtab);
-  else if (data->previous_matched)
-    psymtab_address_or_end = "<ends here>";
-
-  if (data->psymtab == NULL
-      || data->psymtab == addrmap_psymtab
-      || data->previous_matched)
-    {
-      fprintf_filtered (data->outfile, "  %s%s %s\n",
-                       data->psymtab != NULL ? "  " : "",
-                       paddress (gdbarch, start_addr),
-                       psymtab_address_or_end);
-    }
-
-  data->previous_matched = (data->psymtab == NULL
-                           || data->psymtab == addrmap_psymtab);
-
-  return 0;
-}
-
 /* Helper function for maintenance_print_psymbols to print the addrmap
    of PSYMTAB.  If PSYMTAB is NULL print the entire addrmap.  */
 
@@ -1707,20 +1460,15 @@ dump_psymtab_addrmap (struct objfile *objfile,
                      struct partial_symtab *psymtab,
                      struct ui_file *outfile)
 {
-  struct dump_psymtab_addrmap_data addrmap_dump_data;
-
   if ((psymtab == NULL
        || psymtab->psymtabs_addrmap_supported)
       && partial_symtabs->psymtabs_addrmap != NULL)
     {
-      addrmap_dump_data.objfile = objfile;
-      addrmap_dump_data.psymtab = psymtab;
-      addrmap_dump_data.outfile = outfile;
-      addrmap_dump_data.previous_matched = 0;
-      fprintf_filtered (outfile, "%sddress map:\n",
-                       psymtab == NULL ? "Entire a" : "  A");
-      addrmap_foreach (partial_symtabs->psymtabs_addrmap,
-                      dump_psymtab_addrmap_1, &addrmap_dump_data);
+      if (psymtab == nullptr)
+       gdb_printf (outfile, _("Entire address map:\n"));
+      else
+       gdb_printf (outfile, _("Address map:\n"));
+      addrmap_dump (partial_symtabs->psymtabs_addrmap, outfile, psymtab);
     }
 }
 
@@ -1810,49 +1558,25 @@ maintenance_print_psymbols (const char *args, int from_tty)
       if (!print_for_objfile)
        continue;
 
-      psymbol_functions *psf
-       = dynamic_cast<psymbol_functions *> (objfile->qf.get ());
-      if (psf == nullptr)
-       continue;
-
-      psymtab_storage *partial_symtabs = psf->get_partial_symtabs ().get ();
-
-      if (address_arg != NULL)
+      for (const auto &iter : objfile->qf)
        {
-         struct bound_minimal_symbol msymbol = { NULL, NULL };
+         psymbol_functions *psf
+           = dynamic_cast<psymbol_functions *> (iter.get ());
+         if (psf == nullptr)
+           continue;
 
-         /* We don't assume each pc has a unique objfile (this is for
-            debugging).  */
-         struct partial_symtab *ps
-           = psf->find_pc_sect_psymtab (objfile, pc, section, msymbol);
-         if (ps != NULL)
-           {
-             if (!printed_objfile_header)
-               {
-                 outfile->printf ("\nPartial symtabs for objfile %s\n",
-                                 objfile_name (objfile));
-                 printed_objfile_header = 1;
-               }
-             dump_psymtab (objfile, ps, outfile);
-             dump_psymtab_addrmap (objfile, partial_symtabs, ps, outfile);
-             found = 1;
-           }
-       }
-      else
-       {
-         for (partial_symtab *ps : psf->require_partial_symbols (objfile))
+         psymtab_storage *partial_symtabs
+           = psf->get_partial_symtabs ().get ();
+
+         if (address_arg != NULL)
            {
-             int print_for_source = 0;
+             struct bound_minimal_symbol msymbol;
 
-             QUIT;
-             if (source_arg != NULL)
-               {
-                 print_for_source
-                   = compare_filenames_for_search (ps->filename, source_arg);
-                 found = 1;
-               }
-             if (source_arg == NULL
-                 || print_for_source)
+             /* We don't assume each pc has a unique objfile (this is for
+                debugging).  */
+             struct partial_symtab *ps
+               = psf->find_pc_sect_psymtab (objfile, pc, section, msymbol);
+             if (ps != NULL)
                {
                  if (!printed_objfile_header)
                    {
@@ -1861,20 +1585,48 @@ maintenance_print_psymbols (const char *args, int from_tty)
                      printed_objfile_header = 1;
                    }
                  dump_psymtab (objfile, ps, outfile);
-                 dump_psymtab_addrmap (objfile, partial_symtabs, ps,
-                                       outfile);
+                 dump_psymtab_addrmap (objfile, partial_symtabs, ps, outfile);
+                 found = 1;
+               }
+           }
+         else
+           {
+             for (partial_symtab *ps : psf->partial_symbols (objfile))
+               {
+                 int print_for_source = 0;
+
+                 QUIT;
+                 if (source_arg != NULL)
+                   {
+                     print_for_source
+                       = compare_filenames_for_search (ps->filename, source_arg);
+                     found = 1;
+                   }
+                 if (source_arg == NULL
+                     || print_for_source)
+                   {
+                     if (!printed_objfile_header)
+                       {
+                         outfile->printf ("\nPartial symtabs for objfile %s\n",
+                                          objfile_name (objfile));
+                         printed_objfile_header = 1;
+                       }
+                     dump_psymtab (objfile, ps, outfile);
+                     dump_psymtab_addrmap (objfile, partial_symtabs, ps,
+                                           outfile);
+                   }
                }
            }
-       }
 
-      /* If we're printing all the objfile's symbols dump the full addrmap.  */
+         /* If we're printing all the objfile's symbols dump the full addrmap.  */
 
-      if (address_arg == NULL
-         && source_arg == NULL
-         && partial_symtabs->psymtabs_addrmap != NULL)
-       {
-         outfile->puts ("\n");
-         dump_psymtab_addrmap (objfile, partial_symtabs, NULL, outfile);
+         if (address_arg == NULL
+             && source_arg == NULL
+             && partial_symtabs->psymtabs_addrmap != NULL)
+           {
+             outfile->puts ("\n");
+             dump_psymtab_addrmap (objfile, partial_symtabs, NULL, outfile);
+           }
        }
     }
 
@@ -1904,96 +1656,97 @@ maintenance_info_psymtabs (const char *regexp, int from_tty)
           actually find a symtab whose name matches.  */
        int printed_objfile_start = 0;
 
-       psymbol_functions *psf
-         = dynamic_cast<psymbol_functions *> (objfile->qf.get ());
-       if (psf == nullptr)
-         continue;
-       for (partial_symtab *psymtab : psf->require_partial_symbols (objfile))
+       for (const auto &iter : objfile->qf)
          {
-           QUIT;
-
-           if (! regexp
-               || re_exec (psymtab->filename))
+           psymbol_functions *psf
+             = dynamic_cast<psymbol_functions *> (iter.get ());
+           if (psf == nullptr)
+             continue;
+           for (partial_symtab *psymtab : psf->partial_symbols (objfile))
              {
-               if (! printed_objfile_start)
-                 {
-                   printf_filtered ("{ objfile %s ", objfile_name (objfile));
-                   wrap_here ("  ");
-                   printf_filtered ("((struct objfile *) %s)\n",
-                                    host_address_to_string (objfile));
-                   printed_objfile_start = 1;
-                 }
+               QUIT;
 
-               printf_filtered ("  { psymtab %s ", psymtab->filename);
-               wrap_here ("    ");
-               printf_filtered ("((struct partial_symtab *) %s)\n",
-                                host_address_to_string (psymtab));
-
-               printf_filtered ("    readin %s\n",
-                                psymtab->readin_p (objfile) ? "yes" : "no");
-               printf_filtered ("    fullname %s\n",
-                                psymtab->fullname
-                                ? psymtab->fullname : "(null)");
-               printf_filtered ("    text addresses ");
-               fputs_filtered (paddress (gdbarch,
-                                         psymtab->text_low (objfile)),
-                               gdb_stdout);
-               printf_filtered (" -- ");
-               fputs_filtered (paddress (gdbarch,
-                                         psymtab->text_high (objfile)),
-                               gdb_stdout);
-               printf_filtered ("\n");
-               printf_filtered ("    psymtabs_addrmap_supported %s\n",
-                                (psymtab->psymtabs_addrmap_supported
-                                 ? "yes" : "no"));
-               printf_filtered ("    globals ");
-               if (!psymtab->global_psymbols.empty ())
-                 printf_filtered
-                   ("(* (struct partial_symbol **) %s @ %d)\n",
-                    host_address_to_string (psymtab->global_psymbols.data ()),
-                    (int) psymtab->global_psymbols.size ());
-               else
-                 printf_filtered ("(none)\n");
-               printf_filtered ("    statics ");
-               if (!psymtab->static_psymbols.empty ())
-                 printf_filtered
-                   ("(* (struct partial_symbol **) %s @ %d)\n",
-                    host_address_to_string (psymtab->static_psymbols.data ()),
-                    (int) psymtab->static_psymbols.size ());
-               else
-                 printf_filtered ("(none)\n");
-               if (psymtab->user)
-                 printf_filtered ("    user %s "
-                                  "((struct partial_symtab *) %s)\n",
-                                  psymtab->user->filename,
-                                  host_address_to_string (psymtab->user));
-               printf_filtered ("    dependencies ");
-               if (psymtab->number_of_dependencies)
+               if (! regexp
+                   || re_exec (psymtab->filename))
                  {
-                   int i;
+                   if (! printed_objfile_start)
+                     {
+                       gdb_printf ("{ objfile %s ", objfile_name (objfile));
+                       gdb_stdout->wrap_here (2);
+                       gdb_printf ("((struct objfile *) %s)\n",
+                                   host_address_to_string (objfile));
+                       printed_objfile_start = 1;
+                     }
 
-                   printf_filtered ("{\n");
-                   for (i = 0; i < psymtab->number_of_dependencies; i++)
+                   gdb_printf ("  { psymtab %s ", psymtab->filename);
+                   gdb_stdout->wrap_here (4);
+                   gdb_printf ("((struct partial_symtab *) %s)\n",
+                               host_address_to_string (psymtab));
+
+                   gdb_printf ("    readin %s\n",
+                               psymtab->readin_p (objfile) ? "yes" : "no");
+                   gdb_printf ("    fullname %s\n",
+                               psymtab->fullname
+                               ? psymtab->fullname : "(null)");
+                   gdb_printf ("    text addresses ");
+                   gdb_puts (paddress (gdbarch,
+                                       psymtab->text_low (objfile)));
+                   gdb_printf (" -- ");
+                   gdb_puts (paddress (gdbarch,
+                                       psymtab->text_high (objfile)));
+                   gdb_printf ("\n");
+                   gdb_printf ("    psymtabs_addrmap_supported %s\n",
+                               (psymtab->psymtabs_addrmap_supported
+                                ? "yes" : "no"));
+                   gdb_printf ("    globals ");
+                   if (!psymtab->global_psymbols.empty ())
+                     gdb_printf
+                       ("(* (struct partial_symbol **) %s @ %d)\n",
+                        host_address_to_string (psymtab->global_psymbols.data ()),
+                        (int) psymtab->global_psymbols.size ());
+                   else
+                     gdb_printf ("(none)\n");
+                   gdb_printf ("    statics ");
+                   if (!psymtab->static_psymbols.empty ())
+                     gdb_printf
+                       ("(* (struct partial_symbol **) %s @ %d)\n",
+                        host_address_to_string (psymtab->static_psymbols.data ()),
+                        (int) psymtab->static_psymbols.size ());
+                   else
+                     gdb_printf ("(none)\n");
+                   if (psymtab->user)
+                     gdb_printf ("    user %s "
+                                 "((struct partial_symtab *) %s)\n",
+                                 psymtab->user->filename,
+                                 host_address_to_string (psymtab->user));
+                   gdb_printf ("    dependencies ");
+                   if (psymtab->number_of_dependencies)
                      {
-                       struct partial_symtab *dep = psymtab->dependencies[i];
-
-                       /* Note the string concatenation there --- no
-                          comma.  */
-                       printf_filtered ("      psymtab %s "
-                                        "((struct partial_symtab *) %s)\n",
-                                        dep->filename,
-                                        host_address_to_string (dep));
+                       int i;
+
+                       gdb_printf ("{\n");
+                       for (i = 0; i < psymtab->number_of_dependencies; i++)
+                         {
+                           struct partial_symtab *dep = psymtab->dependencies[i];
+
+                           /* Note the string concatenation there --- no
+                              comma.  */
+                           gdb_printf ("      psymtab %s "
+                                       "((struct partial_symtab *) %s)\n",
+                                       dep->filename,
+                                       host_address_to_string (dep));
+                         }
+                       gdb_printf ("    }\n");
                      }
-                   printf_filtered ("    }\n");
+                   else
+                     gdb_printf ("(none)\n");
+                   gdb_printf ("  }\n");
                  }
-               else
-                 printf_filtered ("(none)\n");
-               printf_filtered ("  }\n");
              }
          }
 
        if (printed_objfile_start)
-         printf_filtered ("}\n");
+         gdb_printf ("}\n");
       }
 }
 
@@ -2009,92 +1762,91 @@ maintenance_check_psymtabs (const char *ignore, int from_tty)
 
   for (objfile *objfile : current_program_space->objfiles ())
     {
-      psymbol_functions *psf
-       = dynamic_cast<psymbol_functions *> (objfile->qf.get ());
-      if (psf == nullptr)
-       continue;
-
-      for (partial_symtab *ps : psf->require_partial_symbols (objfile))
+      for (const auto &iter : objfile->qf)
        {
-         struct gdbarch *gdbarch = objfile->arch ();
-
-         /* We don't call psymtab_to_symtab here because that may cause symtab
-            expansion.  When debugging a problem it helps if checkers leave
-            things unchanged.  */
-         cust = ps->get_compunit_symtab (objfile);
+         psymbol_functions *psf
+           = dynamic_cast<psymbol_functions *> (iter.get ());
+         if (psf == nullptr)
+           continue;
 
-         /* First do some checks that don't require the associated symtab.  */
-         if (ps->text_high (objfile) < ps->text_low (objfile))
+         for (partial_symtab *ps : psf->partial_symbols (objfile))
            {
-             printf_filtered ("Psymtab ");
-             puts_filtered (ps->filename);
-             printf_filtered (" covers bad range ");
-             fputs_filtered (paddress (gdbarch, ps->text_low (objfile)),
-                             gdb_stdout);
-             printf_filtered (" - ");
-             fputs_filtered (paddress (gdbarch, ps->text_high (objfile)),
-                             gdb_stdout);
-             printf_filtered ("\n");
-             continue;
-           }
+             struct gdbarch *gdbarch = objfile->arch ();
 
-         /* Now do checks requiring the associated symtab.  */
-         if (cust == NULL)
-           continue;
-         bv = COMPUNIT_BLOCKVECTOR (cust);
-         b = BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK);
-         for (partial_symbol *psym : ps->static_psymbols)
-           {
-             /* Skip symbols for inlined functions without address.  These may
-                or may not have a match in the full symtab.  */
-             if (psym->aclass == LOC_BLOCK
-                 && psym->ginfo.value.address == 0)
-               continue;
+             /* We don't call psymtab_to_symtab here because that may cause symtab
+                expansion.  When debugging a problem it helps if checkers leave
+                things unchanged.  */
+             cust = ps->get_compunit_symtab (objfile);
 
-             sym = block_lookup_symbol (b, psym->ginfo.search_name (),
-                                        symbol_name_match_type::SEARCH_NAME,
-                                        psym->domain);
-             if (!sym)
+             /* First do some checks that don't require the associated symtab.  */
+             if (ps->text_high (objfile) < ps->text_low (objfile))
                {
-                 printf_filtered ("Static symbol `");
-                 puts_filtered (psym->ginfo.linkage_name ());
-                 printf_filtered ("' only found in ");
-                 puts_filtered (ps->filename);
-                 printf_filtered (" psymtab\n");
+                 gdb_printf ("Psymtab ");
+                 gdb_puts (ps->filename);
+                 gdb_printf (" covers bad range ");
+                 gdb_puts (paddress (gdbarch, ps->text_low (objfile)));
+                 gdb_printf (" - ");
+                 gdb_puts (paddress (gdbarch, ps->text_high (objfile)));
+                 gdb_printf ("\n");
+                 continue;
                }
-           }
-         b = BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK);
-         for (partial_symbol *psym : ps->global_psymbols)
-           {
-             sym = block_lookup_symbol (b, psym->ginfo.search_name (),
-                                        symbol_name_match_type::SEARCH_NAME,
-                                        psym->domain);
-             if (!sym)
+
+             /* Now do checks requiring the associated symtab.  */
+             if (cust == NULL)
+               continue;
+             bv = cust->blockvector ();
+             b = bv->static_block ();
+             for (partial_symbol *psym : ps->static_psymbols)
                {
-                 printf_filtered ("Global symbol `");
-                 puts_filtered (psym->ginfo.linkage_name ());
-                 printf_filtered ("' only found in ");
-                 puts_filtered (ps->filename);
-                 printf_filtered (" psymtab\n");
+                 /* Skip symbols for inlined functions without address.  These may
+                    or may not have a match in the full symtab.  */
+                 if (psym->aclass == LOC_BLOCK
+                     && psym->ginfo.value_address () == 0)
+                   continue;
+
+                 sym = block_lookup_symbol (b, psym->ginfo.search_name (),
+                                            symbol_name_match_type::SEARCH_NAME,
+                                            psym->domain);
+                 if (!sym)
+                   {
+                     gdb_printf ("Static symbol `");
+                     gdb_puts (psym->ginfo.linkage_name ());
+                     gdb_printf ("' only found in ");
+                     gdb_puts (ps->filename);
+                     gdb_printf (" psymtab\n");
+                   }
+               }
+             b = bv->global_block ();
+             for (partial_symbol *psym : ps->global_psymbols)
+               {
+                 sym = block_lookup_symbol (b, psym->ginfo.search_name (),
+                                            symbol_name_match_type::SEARCH_NAME,
+                                            psym->domain);
+                 if (!sym)
+                   {
+                     gdb_printf ("Global symbol `");
+                     gdb_puts (psym->ginfo.linkage_name ());
+                     gdb_printf ("' only found in ");
+                     gdb_puts (ps->filename);
+                     gdb_printf (" psymtab\n");
+                   }
+               }
+             if (ps->raw_text_high () != 0
+                 && (ps->text_low (objfile) < b->start ()
+                     || ps->text_high (objfile) > b->end ()))
+               {
+                 gdb_printf ("Psymtab ");
+                 gdb_puts (ps->filename);
+                 gdb_printf (" covers ");
+                 gdb_puts (paddress (gdbarch, ps->text_low (objfile)));
+                 gdb_printf (" - ");
+                 gdb_puts (paddress (gdbarch, ps->text_high (objfile)));
+                 gdb_printf (" but symtab covers only ");
+                 gdb_puts (paddress (gdbarch, b->start ()));
+                 gdb_printf (" - ");
+                 gdb_puts (paddress (gdbarch, b->end ()));
+                 gdb_printf ("\n");
                }
-           }
-         if (ps->raw_text_high () != 0
-             && (ps->text_low (objfile) < BLOCK_START (b)
-                 || ps->text_high (objfile) > BLOCK_END (b)))
-           {
-             printf_filtered ("Psymtab ");
-             puts_filtered (ps->filename);
-             printf_filtered (" covers ");
-             fputs_filtered (paddress (gdbarch, ps->text_low (objfile)),
-                             gdb_stdout);
-             printf_filtered (" - ");
-             fputs_filtered (paddress (gdbarch, ps->text_high (objfile)),
-                             gdb_stdout);
-             printf_filtered (" but symtab covers only ");
-             fputs_filtered (paddress (gdbarch, BLOCK_START (b)), gdb_stdout);
-             printf_filtered (" - ");
-             fputs_filtered (paddress (gdbarch, BLOCK_END (b)), gdb_stdout);
-             printf_filtered ("\n");
            }
        }
     }