Add some new subclasses of breakpoint
[binutils-gdb.git] / gdb / windows-nat.c
index c85f7c0d652cf0d48de88d54e45e2efd34cd592d..1068558cd2111ebd06d99d136e240e5bf32fa83f 100644 (file)
@@ -48,7 +48,7 @@
 #include "symfile.h"
 #include "objfiles.h"
 #include "gdb_bfd.h"
-#include "gdb_obstack.h"
+#include "gdbsupport/gdb_obstack.h"
 #include "gdbthread.h"
 #include "gdbcmd.h"
 #include <unistd.h>
@@ -74,6 +74,9 @@
 
 using namespace windows_nat;
 
+/* The current process.  */
+static windows_process_info windows_process;
+
 #undef STARTUPINFO
 #undef CreateProcess
 #undef GetModuleFileNameEx
@@ -152,7 +155,7 @@ static CORE_ADDR cygwin_get_dr (int i);
 static unsigned long cygwin_get_dr6 (void);
 static unsigned long cygwin_get_dr7 (void);
 
-static std::vector<windows_thread_info *> thread_list;
+static std::vector<std::unique_ptr<windows_thread_info>> thread_list;
 
 /* Counts of things.  */
 static int saw_create;
@@ -242,7 +245,7 @@ struct windows_nat_target final : public x86_nat_target<inf_child_target>
   bool stopped_by_sw_breakpoint () override
   {
     windows_thread_info *th
-      = thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT);
+      = windows_process.thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT);
     return th->stopped_at_software_breakpoint;
   }
 
@@ -310,16 +313,17 @@ static void
 check (BOOL ok, const char *file, int line)
 {
   if (!ok)
-    printf_filtered ("error return %s:%d was %u\n", file, line,
-                    (unsigned) GetLastError ());
+    gdb_printf ("error return %s:%d was %u\n", file, line,
+               (unsigned) GetLastError ());
 }
 
 /* See nat/windows-nat.h.  */
 
 windows_thread_info *
-windows_nat::thread_rec (ptid_t ptid, thread_disposition_type disposition)
+windows_nat::windows_process_info::thread_rec
+     (ptid_t ptid, thread_disposition_type disposition)
 {
-  for (windows_thread_info *th : thread_list)
+  for (auto &th : thread_list)
     if (th->tid == ptid.lwp ())
       {
        if (!th->suspended)
@@ -340,7 +344,7 @@ windows_nat::thread_rec (ptid_t ptid, thread_disposition_type disposition)
                break;
              }
          }
-       return th;
+       return th.get ();
       }
 
   return NULL;
@@ -361,18 +365,18 @@ windows_add_thread (ptid_t ptid, HANDLE h, void *tlb, bool main_thread_p)
 
   gdb_assert (ptid.lwp () != 0);
 
-  if ((th = thread_rec (ptid, DONT_INVALIDATE_CONTEXT)))
+  if ((th = windows_process.thread_rec (ptid, DONT_INVALIDATE_CONTEXT)))
     return th;
 
   CORE_ADDR base = (CORE_ADDR) (uintptr_t) tlb;
 #ifdef __x86_64__
   /* For WOW64 processes, this is actually the pointer to the 64bit TIB,
      and the 32bit TIB is exactly 2 pages after it.  */
-  if (wow64_process)
+  if (windows_process.wow64_process)
     base += 0x2000;
 #endif
   th = new windows_thread_info (ptid.lwp (), h, base);
-  thread_list.push_back (th);
+  thread_list.emplace_back (th);
 
   /* Add this new thread to the list of threads.
 
@@ -397,11 +401,6 @@ static void
 windows_init_thread_list (void)
 {
   DEBUG_EVENTS ("called");
-  init_thread_list ();
-
-  for (windows_thread_info *here : thread_list)
-    delete here;
-
   thread_list.clear ();
 }
 
@@ -429,25 +428,22 @@ windows_delete_thread (ptid_t ptid, DWORD exit_code, bool main_thread_p)
      here as well.  */
 
   if (info_verbose)
-    printf_unfiltered ("[Deleting %s]\n", target_pid_to_str (ptid).c_str ());
+    gdb_printf ("[Deleting %s]\n", target_pid_to_str (ptid).c_str ());
   else if (print_thread_events && !main_thread_p)
-    printf_unfiltered (_("[%s exited with code %u]\n"),
-                      target_pid_to_str (ptid).c_str (),
-                      (unsigned) exit_code);
+    gdb_printf (_("[%s exited with code %u]\n"),
+               target_pid_to_str (ptid).c_str (),
+               (unsigned) exit_code);
 
   delete_thread (find_thread_ptid (&the_windows_nat_target, ptid));
 
   auto iter = std::find_if (thread_list.begin (), thread_list.end (),
-                           [=] (windows_thread_info *th)
+                           [=] (auto &th)
                            {
                              return th->tid == id;
                            });
 
   if (iter != thread_list.end ())
-    {
-      delete *iter;
-      thread_list.erase (iter);
-    }
+    thread_list.erase (iter);
 }
 
 /* Fetches register number R from the given windows_thread_info,
@@ -469,7 +465,7 @@ windows_fetch_one_register (struct regcache *regcache,
 
   char *context_ptr = (char *) &th->context;
 #ifdef __x86_64__
-  if (wow64_process)
+  if (windows_process.wow64_process)
     context_ptr = (char *) &th->wow64_context;
 #endif
 
@@ -531,7 +527,8 @@ windows_fetch_one_register (struct regcache *regcache,
 void
 windows_nat_target::fetch_registers (struct regcache *regcache, int r)
 {
-  windows_thread_info *th = thread_rec (regcache->ptid (), INVALIDATE_CONTEXT);
+  windows_thread_info *th
+    = windows_process.thread_rec (regcache->ptid (), INVALIDATE_CONTEXT);
 
   /* Check if TH exists.  Windows sometimes uses a non-existent
      thread id in its events.  */
@@ -554,7 +551,7 @@ windows_nat_target::fetch_registers (struct regcache *regcache, int r)
       else
 #endif
 #ifdef __x86_64__
-      if (wow64_process)
+      if (windows_process.wow64_process)
        {
          th->wow64_context.ContextFlags = CONTEXT_DEBUGGER_DR;
          CHECK (Wow64GetThreadContext (th->h, &th->wow64_context));
@@ -613,7 +610,7 @@ windows_store_one_register (const struct regcache *regcache,
 
   char *context_ptr = (char *) &th->context;
 #ifdef __x86_64__
-  if (wow64_process)
+  if (windows_process.wow64_process)
     context_ptr = (char *) &th->wow64_context;
 #endif
 
@@ -626,7 +623,8 @@ windows_store_one_register (const struct regcache *regcache,
 void
 windows_nat_target::store_registers (struct regcache *regcache, int r)
 {
-  windows_thread_info *th = thread_rec (regcache->ptid (), INVALIDATE_CONTEXT);
+  windows_thread_info *th
+    = windows_process.thread_rec (regcache->ptid (), INVALIDATE_CONTEXT);
 
   /* Check if TH exists.  Windows sometimes uses a non-existent
      thread id in its events.  */
@@ -641,18 +639,24 @@ windows_nat_target::store_registers (struct regcache *regcache, int r)
 }
 
 /* Maintain a linked list of "so" information.  */
-struct lm_info_windows : public lm_info_base
+struct windows_solib
 {
   LPVOID load_addr = 0;
   CORE_ADDR text_offset = 0;
+
+  /* Original name.  */
+  std::string original_name;
+  /* Expanded form of the name.  */
+  std::string name;
 };
 
-static struct so_list solib_start, *solib_end;
+static std::vector<windows_solib> solibs;
+
+/* See nat/windows-nat.h.  */
 
-static struct so_list *
+static windows_solib *
 windows_make_so (const char *name, LPVOID load_addr)
 {
-  struct so_list *so;
   char *p;
 #ifndef __CYGWIN__
   char buf[__PMAX];
@@ -701,38 +705,43 @@ windows_make_so (const char *name, LPVOID load_addr)
 #endif
     }
 #endif
-  so = XCNEW (struct so_list);
-  lm_info_windows *li = new lm_info_windows;
-  so->lm_info = li;
-  li->load_addr = load_addr;
-  strcpy (so->so_original_name, name);
+  solibs.emplace_back ();
+  windows_solib *so = &solibs.back ();
+  so->load_addr = load_addr;
+  so->original_name = name;
 #ifndef __CYGWIN__
-  strcpy (so->so_name, buf);
+  so->name = buf;
 #else
   if (buf[0])
-    cygwin_conv_path (CCP_WIN_W_TO_POSIX, buf, so->so_name,
-                     SO_NAME_MAX_PATH_SIZE);
+    {
+      char name[SO_NAME_MAX_PATH_SIZE];
+      cygwin_conv_path (CCP_WIN_W_TO_POSIX, buf, name,
+                       SO_NAME_MAX_PATH_SIZE);
+      so->name = name;
+    }
   else
     {
       char *rname = realpath (name, NULL);
       if (rname && strlen (rname) < SO_NAME_MAX_PATH_SIZE)
        {
-         strcpy (so->so_name, rname);
+         so->name = rname;
          free (rname);
        }
       else
        {
          warning (_("dll path for \"%s\" too long or inaccessible"), name);
-         strcpy (so->so_name, so->so_original_name);
+         so->name = so->original_name;
        }
     }
   /* Record cygwin1.dll .text start/end.  */
-  p = strchr (so->so_name, '\0') - (sizeof ("/cygwin1.dll") - 1);
-  if (p >= so->so_name && strcasecmp (p, "/cygwin1.dll") == 0)
+  size_t len = sizeof ("/cygwin1.dll") - 1;
+  if (so->name.size () >= len
+      && strcasecmp (so->name.c_str () + so->name.size () - len,
+                    "/cygwin1.dll") == 0)
     {
       asection *text = NULL;
 
-      gdb_bfd_ref_ptr abfd (gdb_bfd_open (so->so_name, "pei-i386"));
+      gdb_bfd_ref_ptr abfd (gdb_bfd_open (so->name, "pei-i386"));
 
       if (abfd == NULL)
        return so;
@@ -758,50 +767,36 @@ windows_make_so (const char *name, LPVOID load_addr)
 /* See nat/windows-nat.h.  */
 
 void
-windows_nat::handle_load_dll (const char *dll_name, LPVOID base)
-{
-  solib_end->next = windows_make_so (dll_name, base);
-  solib_end = solib_end->next;
-
-  lm_info_windows *li = (lm_info_windows *) solib_end->lm_info;
-
-  DEBUG_EVENTS ("Loading dll \"%s\" at %s.", solib_end->so_name,
-               host_address_to_string (li->load_addr));
-}
-
-static void
-windows_free_so (struct so_list *so)
+windows_nat::windows_process_info::handle_load_dll (const char *dll_name,
+                                                   LPVOID base)
 {
-  lm_info_windows *li = (lm_info_windows *) so->lm_info;
-
-  delete li;
-  xfree (so);
+  windows_solib *solib = windows_make_so (dll_name, base);
+  DEBUG_EVENTS ("Loading dll \"%s\" at %s.", solib->name.c_str (),
+               host_address_to_string (solib->load_addr));
 }
 
 /* See nat/windows-nat.h.  */
 
 void
-windows_nat::handle_unload_dll ()
+windows_nat::windows_process_info::handle_unload_dll ()
 {
   LPVOID lpBaseOfDll = current_event.u.UnloadDll.lpBaseOfDll;
-  struct so_list *so;
 
-  for (so = &solib_start; so->next != NULL; so = so->next)
+  auto iter = std::remove_if (solibs.begin (), solibs.end (),
+                             [&] (windows_solib &lib)
     {
-      lm_info_windows *li_next = (lm_info_windows *) so->next->lm_info;
-
-      if (li_next->load_addr == lpBaseOfDll)
+      if (lib.load_addr == lpBaseOfDll)
        {
-         struct so_list *sodel = so->next;
-
-         so->next = sodel->next;
-         if (!so->next)
-           solib_end = so;
-         DEBUG_EVENTS ("Unloading dll \"%s\".", sodel->so_name);
-
-         windows_free_so (sodel);
-         return;
+         DEBUG_EVENTS ("Unloading dll \"%s\".", lib.name.c_str ());
+         return true;
        }
+      return false;
+    });
+
+  if (iter != solibs.end ())
+    {
+      solibs.erase (iter, solibs.end ());
+      return;
     }
 
   /* We did not find any DLL that was previously loaded at this address,
@@ -815,35 +810,11 @@ windows_nat::handle_unload_dll ()
             host_address_to_string (lpBaseOfDll));
 }
 
-/* Call FUNC wrapped in a TRY/CATCH that swallows all GDB
-   exceptions.  */
-
-static void
-catch_errors (void (*func) ())
-{
-  try
-    {
-      func ();
-    }
-  catch (const gdb_exception &ex)
-    {
-      exception_print (gdb_stderr, ex);
-    }
-}
-
 /* Clear list of loaded DLLs.  */
 static void
 windows_clear_solib (void)
 {
-  struct so_list *so;
-
-  for (so = solib_start.next; so; so = solib_start.next)
-    {
-      solib_start.next = so->next;
-      windows_free_so (so);
-    }
-
-  solib_end = &solib_start;
+  solibs.clear ();
 }
 
 static void
@@ -868,7 +839,8 @@ signal_event_command (const char *args, int from_tty)
 /* See nat/windows-nat.h.  */
 
 int
-windows_nat::handle_output_debug_string (struct target_waitstatus *ourstatus)
+windows_nat::windows_process_info::handle_output_debug_string
+     (struct target_waitstatus *ourstatus)
 {
   int retval = 0;
 
@@ -933,7 +905,7 @@ display_selector (HANDLE thread, DWORD sel)
   LDT_ENTRY info;
   BOOL ret;
 #ifdef __x86_64__
-  if (wow64_process)
+  if (windows_process.wow64_process)
     ret = Wow64GetThreadSelectorEntry (thread, sel, &info);
   else
 #endif
@@ -941,10 +913,10 @@ display_selector (HANDLE thread, DWORD sel)
   if (ret)
     {
       int base, limit;
-      printf_filtered ("0x%03x: ", (unsigned) sel);
+      gdb_printf ("0x%03x: ", (unsigned) sel);
       if (!info.HighWord.Bits.Pres)
        {
-         puts_filtered ("Segment not present\n");
+         gdb_puts ("Segment not present\n");
          return 0;
        }
       base = (info.HighWord.Bits.BaseHi << 24) +
@@ -953,61 +925,61 @@ display_selector (HANDLE thread, DWORD sel)
       limit = (info.HighWord.Bits.LimitHi << 16) + info.LimitLow;
       if (info.HighWord.Bits.Granularity)
        limit = (limit << 12) | 0xfff;
-      printf_filtered ("base=0x%08x limit=0x%08x", base, limit);
+      gdb_printf ("base=0x%08x limit=0x%08x", base, limit);
       if (info.HighWord.Bits.Default_Big)
-       puts_filtered(" 32-bit ");
+       gdb_puts(" 32-bit ");
       else
-       puts_filtered(" 16-bit ");
+       gdb_puts(" 16-bit ");
       switch ((info.HighWord.Bits.Type & 0xf) >> 1)
        {
        case 0:
-         puts_filtered ("Data (Read-Only, Exp-up");
+         gdb_puts ("Data (Read-Only, Exp-up");
          break;
        case 1:
-         puts_filtered ("Data (Read/Write, Exp-up");
+         gdb_puts ("Data (Read/Write, Exp-up");
          break;
        case 2:
-         puts_filtered ("Unused segment (");
+         gdb_puts ("Unused segment (");
          break;
        case 3:
-         puts_filtered ("Data (Read/Write, Exp-down");
+         gdb_puts ("Data (Read/Write, Exp-down");
          break;
        case 4:
-         puts_filtered ("Code (Exec-Only, N.Conf");
+         gdb_puts ("Code (Exec-Only, N.Conf");
          break;
        case 5:
-         puts_filtered ("Code (Exec/Read, N.Conf");
+         gdb_puts ("Code (Exec/Read, N.Conf");
          break;
        case 6:
-         puts_filtered ("Code (Exec-Only, Conf");
+         gdb_puts ("Code (Exec-Only, Conf");
          break;
        case 7:
-         puts_filtered ("Code (Exec/Read, Conf");
+         gdb_puts ("Code (Exec/Read, Conf");
          break;
        default:
-         printf_filtered ("Unknown type 0x%lx",
-                          (unsigned long) info.HighWord.Bits.Type);
+         gdb_printf ("Unknown type 0x%lx",
+                     (unsigned long) info.HighWord.Bits.Type);
        }
       if ((info.HighWord.Bits.Type & 0x1) == 0)
-       puts_filtered(", N.Acc");
-      puts_filtered (")\n");
+       gdb_puts(", N.Acc");
+      gdb_puts (")\n");
       if ((info.HighWord.Bits.Type & 0x10) == 0)
-       puts_filtered("System selector ");
-      printf_filtered ("Priviledge level = %ld. ",
-                      (unsigned long) info.HighWord.Bits.Dpl);
+       gdb_puts("System selector ");
+      gdb_printf ("Priviledge level = %ld. ",
+                 (unsigned long) info.HighWord.Bits.Dpl);
       if (info.HighWord.Bits.Granularity)
-       puts_filtered ("Page granular.\n");
+       gdb_puts ("Page granular.\n");
       else
-       puts_filtered ("Byte granular.\n");
+       gdb_puts ("Byte granular.\n");
       return 1;
     }
   else
     {
       DWORD err = GetLastError ();
       if (err == ERROR_NOT_SUPPORTED)
-       printf_filtered ("Function not supported\n");
+       gdb_printf ("Function not supported\n");
       else
-       printf_filtered ("Invalid selector 0x%x.\n", (unsigned) sel);
+       gdb_printf ("Invalid selector 0x%x.\n", (unsigned) sel);
       return 0;
     }
 }
@@ -1017,56 +989,56 @@ display_selectors (const char * args, int from_tty)
 {
   if (inferior_ptid == null_ptid)
     {
-      puts_filtered ("Impossible to display selectors now.\n");
+      gdb_puts ("Impossible to display selectors now.\n");
       return;
     }
 
   windows_thread_info *current_windows_thread
-    = thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT);
+    = windows_process.thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT);
 
   if (!args)
     {
 #ifdef __x86_64__
-      if (wow64_process)
+      if (windows_process.wow64_process)
        {
-         puts_filtered ("Selector $cs\n");
+         gdb_puts ("Selector $cs\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->wow64_context.SegCs);
-         puts_filtered ("Selector $ds\n");
+         gdb_puts ("Selector $ds\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->wow64_context.SegDs);
-         puts_filtered ("Selector $es\n");
+         gdb_puts ("Selector $es\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->wow64_context.SegEs);
-         puts_filtered ("Selector $ss\n");
+         gdb_puts ("Selector $ss\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->wow64_context.SegSs);
-         puts_filtered ("Selector $fs\n");
+         gdb_puts ("Selector $fs\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->wow64_context.SegFs);
-         puts_filtered ("Selector $gs\n");
+         gdb_puts ("Selector $gs\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->wow64_context.SegGs);
        }
       else
 #endif
        {
-         puts_filtered ("Selector $cs\n");
+         gdb_puts ("Selector $cs\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->context.SegCs);
-         puts_filtered ("Selector $ds\n");
+         gdb_puts ("Selector $ds\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->context.SegDs);
-         puts_filtered ("Selector $es\n");
+         gdb_puts ("Selector $es\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->context.SegEs);
-         puts_filtered ("Selector $ss\n");
+         gdb_puts ("Selector $ss\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->context.SegSs);
-         puts_filtered ("Selector $fs\n");
+         gdb_puts ("Selector $fs\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->context.SegFs);
-         puts_filtered ("Selector $gs\n");
+         gdb_puts ("Selector $gs\n");
          display_selector (current_windows_thread->h,
                            current_windows_thread->context.SegGs);
        }
@@ -1075,7 +1047,7 @@ display_selectors (const char * args, int from_tty)
     {
       int sel;
       sel = parse_and_eval_long (args);
-      printf_filtered ("Selector \"%s\"\n",args);
+      gdb_printf ("Selector \"%s\"\n",args);
       display_selector (current_windows_thread->h, sel);
     }
 }
@@ -1083,46 +1055,8 @@ display_selectors (const char * args, int from_tty)
 /* See nat/windows-nat.h.  */
 
 bool
-windows_nat::handle_ms_vc_exception (const EXCEPTION_RECORD *rec)
-{
-  if (rec->NumberParameters >= 3
-      && (rec->ExceptionInformation[0] & 0xffffffff) == 0x1000)
-    {
-      DWORD named_thread_id;
-      windows_thread_info *named_thread;
-      CORE_ADDR thread_name_target;
-
-      thread_name_target = rec->ExceptionInformation[1];
-      named_thread_id = (DWORD) (0xffffffff & rec->ExceptionInformation[2]);
-
-      if (named_thread_id == (DWORD) -1)
-       named_thread_id = current_event.dwThreadId;
-
-      named_thread = thread_rec (ptid_t (current_event.dwProcessId,
-                                        named_thread_id, 0),
-                                DONT_INVALIDATE_CONTEXT);
-      if (named_thread != NULL)
-       {
-         int thread_name_len;
-         gdb::unique_xmalloc_ptr<char> thread_name
-           = target_read_string (thread_name_target, 1025, &thread_name_len);
-         if (thread_name_len > 0)
-           {
-             thread_name.get ()[thread_name_len - 1] = '\0';
-             named_thread->name = std::move (thread_name);
-           }
-       }
-
-      return true;
-    }
-
-  return false;
-}
-
-/* See nat/windows-nat.h.  */
-
-bool
-windows_nat::handle_access_violation (const EXCEPTION_RECORD *rec)
+windows_nat::windows_process_info::handle_access_violation
+     (const EXCEPTION_RECORD *rec)
 {
 #ifdef __CYGWIN__
   /* See if the access violation happened within the cygwin DLL
@@ -1153,16 +1087,16 @@ windows_continue (DWORD continue_status, int id, int killed)
 {
   BOOL res;
 
-  desired_stop_thread_id = id;
+  windows_process.desired_stop_thread_id = id;
 
-  if (matching_pending_stop (debug_events))
+  if (windows_process.matching_pending_stop (debug_events))
     return TRUE;
 
-  for (windows_thread_info *th : thread_list)
+  for (auto &th : thread_list)
     if (id == -1 || id == (int) th->tid)
       {
 #ifdef __x86_64__
-       if (wow64_process)
+       if (windows_process.wow64_process)
          {
            if (th->debug_registers_changed)
              {
@@ -1244,9 +1178,10 @@ windows_continue (DWORD continue_status, int id, int killed)
 static DWORD
 fake_create_process (void)
 {
-  current_process_handle = OpenProcess (PROCESS_ALL_ACCESS, FALSE,
-                                       current_event.dwProcessId);
-  if (current_process_handle != NULL)
+  windows_process.handle
+    = OpenProcess (PROCESS_ALL_ACCESS, FALSE,
+                  windows_process.current_event.dwProcessId);
+  if (windows_process.handle != NULL)
     open_process_used = 1;
   else
     {
@@ -1254,12 +1189,12 @@ fake_create_process (void)
        (unsigned) GetLastError ());
       /*  We can not debug anything in that case.  */
     }
-  windows_add_thread (ptid_t (current_event.dwProcessId, 0,
-                             current_event.dwThreadId),
-                     current_event.u.CreateThread.hThread,
-                     current_event.u.CreateThread.lpThreadLocalBase,
+  windows_add_thread (ptid_t (windows_process.current_event.dwProcessId, 0,
+                             windows_process.current_event.dwThreadId),
+                     windows_process.current_event.u.CreateThread.hThread,
+                     windows_process.current_event.u.CreateThread.lpThreadLocalBase,
                      true /* main_thread_p */);
-  return current_event.dwThreadId;
+  return windows_process.current_event.dwThreadId;
 }
 
 void
@@ -1278,11 +1213,12 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig)
 
   if (sig != GDB_SIGNAL_0)
     {
-      if (current_event.dwDebugEventCode != EXCEPTION_DEBUG_EVENT)
+      if (windows_process.current_event.dwDebugEventCode
+         != EXCEPTION_DEBUG_EVENT)
        {
          DEBUG_EXCEPT ("Cannot continue with signal %d here.", sig);
        }
-      else if (sig == last_sig)
+      else if (sig == windows_process.last_sig)
        continue_status = DBG_EXCEPTION_NOT_HANDLED;
       else
 #if 0
@@ -1306,20 +1242,20 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig)
        }
 #endif
       DEBUG_EXCEPT ("Can only continue with received signal %d.",
-                   last_sig);
+                   windows_process.last_sig);
     }
 
-  last_sig = GDB_SIGNAL_0;
+  windows_process.last_sig = GDB_SIGNAL_0;
 
   DEBUG_EXEC ("pid=%d, tid=0x%x, step=%d, sig=%d",
              ptid.pid (), (unsigned) ptid.lwp (), step, sig);
 
   /* Get context for currently selected thread.  */
-  th = thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT);
+  th = windows_process.thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT);
   if (th)
     {
 #ifdef __x86_64__
-      if (wow64_process)
+      if (windows_process.wow64_process)
        {
          if (step)
            {
@@ -1404,7 +1340,7 @@ ctrl_c_handler (DWORD event_type)
     return TRUE;
 
 #ifdef __x86_64__
-  if (wow64_process)
+  if (windows_process.wow64_process)
     {
       /* Call DbgUiRemoteBreakin of the 32bit ntdll.dll in the target process.
         DebugBreakProcess would call the one of the 64bit ntdll.dll, which
@@ -1419,7 +1355,7 @@ ctrl_c_handler (DWORD event_type)
 
       if (wow64_dbgbreak != nullptr)
        {
-         HANDLE thread = CreateRemoteThread (current_process_handle, NULL,
+         HANDLE thread = CreateRemoteThread (windows_process.handle, NULL,
                                              0, (LPTHREAD_START_ROUTINE)
                                              wow64_dbgbreak, NULL, 0, NULL);
          if (thread)
@@ -1429,7 +1365,7 @@ ctrl_c_handler (DWORD event_type)
   else
 #endif
     {
-      if (!DebugBreakProcess (current_process_handle))
+      if (!DebugBreakProcess (windows_process.handle))
        warning (_("Could not interrupt program.  "
                   "Press Ctrl-c in the program console."));
     }
@@ -1452,27 +1388,31 @@ windows_nat_target::get_windows_debug_event (int pid,
   /* If there is a relevant pending stop, report it now.  See the
      comment by the definition of "pending_stops" for details on why
      this is needed.  */
-  gdb::optional<pending_stop> stop = fetch_pending_stop (debug_events);
+  gdb::optional<pending_stop> stop
+    = windows_process.fetch_pending_stop (debug_events);
   if (stop.has_value ())
     {
       thread_id = stop->thread_id;
       *ourstatus = stop->status;
 
-      ptid_t ptid (current_event.dwProcessId, thread_id);
-      windows_thread_info *th = thread_rec (ptid, INVALIDATE_CONTEXT);
+      ptid_t ptid (windows_process.current_event.dwProcessId, thread_id);
+      windows_thread_info *th
+       = windows_process.thread_rec (ptid, INVALIDATE_CONTEXT);
       th->reload_context = true;
 
       return thread_id;
     }
 
-  last_sig = GDB_SIGNAL_0;
+  windows_process.last_sig = GDB_SIGNAL_0;
+  DEBUG_EVENT *current_event = &windows_process.current_event;
 
-  if (!(debug_event = wait_for_debug_event (&current_event, 1000)))
+  if (!(debug_event = wait_for_debug_event (&windows_process.current_event,
+                                           1000)))
     goto out;
 
   continue_status = DBG_CONTINUE;
 
-  event_code = current_event.dwDebugEventCode;
+  event_code = windows_process.current_event.dwDebugEventCode;
   ourstatus->set_spurious ();
   have_saved_context = 0;
 
@@ -1480,12 +1420,12 @@ windows_nat_target::get_windows_debug_event (int pid,
     {
     case CREATE_THREAD_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "CREATE_THREAD_DEBUG_EVENT");
       if (saw_create != 1)
        {
-         inferior *inf = find_inferior_pid (this, current_event.dwProcessId);
+         inferior *inf = find_inferior_pid (this, current_event->dwProcessId);
          if (!saw_create && inf->attach_flag)
            {
              /* Kludge around a Windows bug where first event is a create
@@ -1498,64 +1438,64 @@ windows_nat_target::get_windows_debug_event (int pid,
          break;
        }
       /* Record the existence of this thread.  */
-      thread_id = current_event.dwThreadId;
+      thread_id = current_event->dwThreadId;
       windows_add_thread
-       (ptid_t (current_event.dwProcessId, current_event.dwThreadId, 0),
-        current_event.u.CreateThread.hThread,
-        current_event.u.CreateThread.lpThreadLocalBase,
+       (ptid_t (current_event->dwProcessId, current_event->dwThreadId, 0),
+        current_event->u.CreateThread.hThread,
+        current_event->u.CreateThread.lpThreadLocalBase,
         false /* main_thread_p */);
 
       break;
 
     case EXIT_THREAD_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "EXIT_THREAD_DEBUG_EVENT");
-      windows_delete_thread (ptid_t (current_event.dwProcessId,
-                                    current_event.dwThreadId, 0),
-                            current_event.u.ExitThread.dwExitCode,
+      windows_delete_thread (ptid_t (current_event->dwProcessId,
+                                    current_event->dwThreadId, 0),
+                            current_event->u.ExitThread.dwExitCode,
                             false /* main_thread_p */);
       break;
 
     case CREATE_PROCESS_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "CREATE_PROCESS_DEBUG_EVENT");
-      CloseHandle (current_event.u.CreateProcessInfo.hFile);
+      CloseHandle (current_event->u.CreateProcessInfo.hFile);
       if (++saw_create != 1)
        break;
 
-      current_process_handle = current_event.u.CreateProcessInfo.hProcess;
+      windows_process.handle = current_event->u.CreateProcessInfo.hProcess;
       /* Add the main thread.  */
       windows_add_thread
-       (ptid_t (current_event.dwProcessId,
-                current_event.dwThreadId, 0),
-        current_event.u.CreateProcessInfo.hThread,
-        current_event.u.CreateProcessInfo.lpThreadLocalBase,
+       (ptid_t (current_event->dwProcessId,
+                current_event->dwThreadId, 0),
+        current_event->u.CreateProcessInfo.hThread,
+        current_event->u.CreateProcessInfo.lpThreadLocalBase,
         true /* main_thread_p */);
-      thread_id = current_event.dwThreadId;
+      thread_id = current_event->dwThreadId;
       break;
 
     case EXIT_PROCESS_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "EXIT_PROCESS_DEBUG_EVENT");
       if (!windows_initialization_done)
        {
          target_terminal::ours ();
          target_mourn_inferior (inferior_ptid);
          error (_("During startup program exited with code 0x%x."),
-                (unsigned int) current_event.u.ExitProcess.dwExitCode);
+                (unsigned int) current_event->u.ExitProcess.dwExitCode);
        }
       else if (saw_create == 1)
        {
-         windows_delete_thread (ptid_t (current_event.dwProcessId,
-                                        current_event.dwThreadId, 0),
+         windows_delete_thread (ptid_t (current_event->dwProcessId,
+                                        current_event->dwThreadId, 0),
                                 0, true /* main_thread_p */);
-         DWORD exit_status = current_event.u.ExitProcess.dwExitCode;
+         DWORD exit_status = current_event->u.ExitProcess.dwExitCode;
          /* If the exit status looks like a fatal exception, but we
             don't recognize the exception's code, make the original
             exit status value available, to avoid losing
@@ -1567,50 +1507,64 @@ windows_nat_target::get_windows_debug_event (int pid,
          else
            ourstatus->set_signalled (gdb_signal_from_host (exit_signal));
 
-         thread_id = current_event.dwThreadId;
+         thread_id = current_event->dwThreadId;
        }
       break;
 
     case LOAD_DLL_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "LOAD_DLL_DEBUG_EVENT");
-      CloseHandle (current_event.u.LoadDll.hFile);
+      CloseHandle (current_event->u.LoadDll.hFile);
       if (saw_create != 1 || ! windows_initialization_done)
        break;
-      catch_errors (dll_loaded_event);
+      try
+       {
+         windows_process.dll_loaded_event ();
+       }
+      catch (const gdb_exception &ex)
+       {
+         exception_print (gdb_stderr, ex);
+       }
       ourstatus->set_loaded ();
-      thread_id = current_event.dwThreadId;
+      thread_id = current_event->dwThreadId;
       break;
 
     case UNLOAD_DLL_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "UNLOAD_DLL_DEBUG_EVENT");
       if (saw_create != 1 || ! windows_initialization_done)
        break;
-      catch_errors (handle_unload_dll);
+      try
+       {
+         windows_process.handle_unload_dll ();
+       }
+      catch (const gdb_exception &ex)
+       {
+         exception_print (gdb_stderr, ex);
+       }
       ourstatus->set_loaded ();
-      thread_id = current_event.dwThreadId;
+      thread_id = current_event->dwThreadId;
       break;
 
     case EXCEPTION_DEBUG_EVENT:
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "EXCEPTION_DEBUG_EVENT");
       if (saw_create != 1)
        break;
-      switch (handle_exception (ourstatus, debug_exceptions))
+      switch (windows_process.handle_exception (ourstatus, debug_exceptions))
        {
        case HANDLE_EXCEPTION_UNHANDLED:
        default:
          continue_status = DBG_EXCEPTION_NOT_HANDLED;
          break;
        case HANDLE_EXCEPTION_HANDLED:
-         thread_id = current_event.dwThreadId;
+         thread_id = current_event->dwThreadId;
          break;
        case HANDLE_EXCEPTION_IGNORED:
          continue_status = DBG_CONTINUE;
@@ -1620,52 +1574,57 @@ windows_nat_target::get_windows_debug_event (int pid,
 
     case OUTPUT_DEBUG_STRING_EVENT:    /* Message from the kernel.  */
       DEBUG_EVENTS ("kernel event for pid=%u tid=0x%x code=%s",
-                   (unsigned) current_event.dwProcessId,
-                   (unsigned) current_event.dwThreadId,
+                   (unsigned) current_event->dwProcessId,
+                   (unsigned) current_event->dwThreadId,
                    "OUTPUT_DEBUG_STRING_EVENT");
       if (saw_create != 1)
        break;
-      thread_id = handle_output_debug_string (ourstatus);
+      thread_id = windows_process.handle_output_debug_string (ourstatus);
       break;
 
     default:
       if (saw_create != 1)
        break;
-      printf_unfiltered ("gdb: kernel event for pid=%u tid=0x%x\n",
-                        (unsigned) current_event.dwProcessId,
-                        (unsigned) current_event.dwThreadId);
-      printf_unfiltered ("                 unknown event code %u\n",
-                        (unsigned) current_event.dwDebugEventCode);
+      gdb_printf ("gdb: kernel event for pid=%u tid=0x%x\n",
+                 (unsigned) current_event->dwProcessId,
+                 (unsigned) current_event->dwThreadId);
+      gdb_printf ("                 unknown event code %u\n",
+                 (unsigned) current_event->dwDebugEventCode);
       break;
     }
 
   if (!thread_id || saw_create != 1)
     {
-      CHECK (windows_continue (continue_status, desired_stop_thread_id, 0));
+      CHECK (windows_continue (continue_status,
+                              windows_process.desired_stop_thread_id, 0));
     }
-  else if (desired_stop_thread_id != -1 && desired_stop_thread_id != thread_id)
+  else if (windows_process.desired_stop_thread_id != -1
+          && windows_process.desired_stop_thread_id != thread_id)
     {
       /* Pending stop.  See the comment by the definition of
         "pending_stops" for details on why this is needed.  */
       DEBUG_EVENTS ("get_windows_debug_event - "
                    "unexpected stop in 0x%x (expecting 0x%x)",
-                   thread_id, desired_stop_thread_id);
+                   thread_id, windows_process.desired_stop_thread_id);
 
-      if (current_event.dwDebugEventCode == EXCEPTION_DEBUG_EVENT
-         && ((current_event.u.Exception.ExceptionRecord.ExceptionCode
+      if (current_event->dwDebugEventCode == EXCEPTION_DEBUG_EVENT
+         && ((current_event->u.Exception.ExceptionRecord.ExceptionCode
               == EXCEPTION_BREAKPOINT)
-             || (current_event.u.Exception.ExceptionRecord.ExceptionCode
+             || (current_event->u.Exception.ExceptionRecord.ExceptionCode
                  == STATUS_WX86_BREAKPOINT))
          && windows_initialization_done)
        {
-         ptid_t ptid = ptid_t (current_event.dwProcessId, thread_id, 0);
-         windows_thread_info *th = thread_rec (ptid, INVALIDATE_CONTEXT);
+         ptid_t ptid = ptid_t (current_event->dwProcessId, thread_id, 0);
+         windows_thread_info *th
+           = windows_process.thread_rec (ptid, INVALIDATE_CONTEXT);
          th->stopped_at_software_breakpoint = true;
          th->pc_adjusted = false;
        }
-      pending_stops.push_back ({thread_id, *ourstatus, current_event});
+      windows_process.pending_stops.push_back
+       ({thread_id, *ourstatus, windows_process.current_event});
       thread_id = 0;
-      CHECK (windows_continue (continue_status, desired_stop_thread_id, 0));
+      CHECK (windows_continue (continue_status,
+                              windows_process.desired_stop_thread_id, 0));
     }
 
 out:
@@ -1721,20 +1680,23 @@ windows_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus,
 
       if (retval)
        {
-         ptid_t result = ptid_t (current_event.dwProcessId, retval, 0);
+         ptid_t result = ptid_t (windows_process.current_event.dwProcessId,
+                                 retval, 0);
 
          if (ourstatus->kind () != TARGET_WAITKIND_EXITED
              && ourstatus->kind () !=  TARGET_WAITKIND_SIGNALLED)
            {
-             windows_thread_info *th = thread_rec (result, INVALIDATE_CONTEXT);
+             windows_thread_info *th
+               = windows_process.thread_rec (result, INVALIDATE_CONTEXT);
 
              if (th != nullptr)
                {
                  th->stopped_at_software_breakpoint = false;
-                 if (current_event.dwDebugEventCode == EXCEPTION_DEBUG_EVENT
-                     && ((current_event.u.Exception.ExceptionRecord.ExceptionCode
+                 if (windows_process.current_event.dwDebugEventCode
+                     == EXCEPTION_DEBUG_EVENT
+                     && ((windows_process.current_event.u.Exception.ExceptionRecord.ExceptionCode
                           == EXCEPTION_BREAKPOINT)
-                         || (current_event.u.Exception.ExceptionRecord.ExceptionCode
+                         || (windows_process.current_event.u.Exception.ExceptionRecord.ExceptionCode
                              == STATUS_WX86_BREAKPOINT))
                      && windows_initialization_done)
                    {
@@ -1765,15 +1727,16 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
   int i;
   struct inferior *inf;
 
-  last_sig = GDB_SIGNAL_0;
+  windows_process.last_sig = GDB_SIGNAL_0;
   open_process_used = 0;
   for (i = 0; i < sizeof (dr) / sizeof (dr[0]); i++)
     dr[i] = 0;
 #ifdef __CYGWIN__
   cygwin_load_start = cygwin_load_end = 0;
 #endif
-  current_event.dwProcessId = pid;
-  memset (&current_event, 0, sizeof (current_event));
+  windows_process.current_event.dwProcessId = pid;
+  memset (&windows_process.current_event, 0,
+         sizeof (windows_process.current_event));
   inf = current_inferior ();
   if (!inf->target_is_pushed (this))
     inf->push_target (this);
@@ -1783,9 +1746,10 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
   init_wait_for_inferior ();
 
 #ifdef __x86_64__
-  ignore_first_breakpoint = !attaching && wow64_process;
+  windows_process.ignore_first_breakpoint
+    = !attaching && windows_process.wow64_process;
 
-  if (!wow64_process)
+  if (!windows_process.wow64_process)
     {
       windows_set_context_register_offsets (amd64_mappings);
       windows_set_segment_register_p (amd64_windows_segment_register_p);
@@ -1839,7 +1803,7 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
      Rather than try to work around this sort of issue, it is much
      simpler to just ignore DLL load/unload events during the startup
      phase, and then process them all in one batch now.  */
-  windows_add_all_dlls ();
+  windows_process.add_all_dlls ();
 
   windows_initialization_done = 1;
   return;
@@ -1937,7 +1901,7 @@ windows_nat_target::attach (const char *args, int from_tty)
     {
       BOOL wow64;
       if (IsWow64Process (h, &wow64))
-       wow64_process = wow64;
+       windows_process.wow64_process = wow64;
       CloseHandle (h);
     }
 #endif
@@ -1954,22 +1918,17 @@ windows_nat_target::detach (inferior *inf, int from_tty)
   ptid_t ptid = minus_one_ptid;
   resume (ptid, 0, GDB_SIGNAL_0);
 
-  if (!DebugActiveProcessStop (current_event.dwProcessId))
+  if (!DebugActiveProcessStop (windows_process.current_event.dwProcessId))
     {
       error (_("Can't detach process %u (error %u)"),
-            (unsigned) current_event.dwProcessId, (unsigned) GetLastError ());
+            (unsigned) windows_process.current_event.dwProcessId,
+            (unsigned) GetLastError ());
       detached = 0;
     }
   DebugSetProcessKillOnExit (FALSE);
 
-  if (detached && from_tty)
-    {
-      const char *exec_file = get_exec_file (0);
-      if (exec_file == 0)
-       exec_file = "";
-      printf_unfiltered ("Detaching from program: %s, Pid %u\n", exec_file,
-                        (unsigned) current_event.dwProcessId);
-    }
+  if (detached)
+    target_announce_detach (from_tty);
 
   x86_cleanup_dregs ();
   switch_to_no_thread ();
@@ -1997,18 +1956,20 @@ windows_get_exec_module_filename (char *exe_name_ret, size_t exe_name_max_len)
 
   cbNeeded = 0;
 #ifdef __x86_64__
-  if (wow64_process)
+  if (windows_process.wow64_process)
     {
-      if (!EnumProcessModulesEx (current_process_handle, &dh_buf,
-                                sizeof (HMODULE), &cbNeeded,
-                                LIST_MODULES_32BIT) || !cbNeeded)
+      if (!EnumProcessModulesEx (windows_process.handle,
+                                &dh_buf, sizeof (HMODULE), &cbNeeded,
+                                LIST_MODULES_32BIT)
+         || !cbNeeded)
        return 0;
     }
   else
 #endif
     {
-      if (!EnumProcessModules (current_process_handle, &dh_buf,
-                              sizeof (HMODULE), &cbNeeded) || !cbNeeded)
+      if (!EnumProcessModules (windows_process.handle,
+                              &dh_buf, sizeof (HMODULE), &cbNeeded)
+         || !cbNeeded)
        return 0;
     }
 
@@ -2032,7 +1993,7 @@ windows_get_exec_module_filename (char *exe_name_ret, size_t exe_name_max_len)
       error (_("Error converting executable filename to POSIX: %d."), errno);
   }
 #else
-  len = GetModuleFileNameEx (current_process_handle,
+  len = GetModuleFileNameEx (windows_process.handle,
                             dh_buf, exe_name_ret, exe_name_max_len);
   if (len == 0)
     error (_("Error getting executable filename: %u."),
@@ -2077,9 +2038,9 @@ windows_nat_target::files_info ()
 {
   struct inferior *inf = current_inferior ();
 
-  printf_filtered ("\tUsing the running image of %s %s.\n",
-                  inf->attach_flag ? "attached" : "child",
-                  target_pid_to_str (inferior_ptid).c_str ());
+  gdb_printf ("\tUsing the running image of %s %s.\n",
+             inf->attach_flag ? "attached" : "child",
+             target_pid_to_str (inferior_ptid).c_str ());
 }
 
 /* Modify CreateProcess parameters for use of a new separate console.
@@ -2773,7 +2734,7 @@ windows_nat_target::create_inferior (const char *exec_file,
 #ifdef __x86_64__
   BOOL wow64;
   if (IsWow64Process (pi.hProcess, &wow64))
-    wow64_process = wow64;
+    windows_process.wow64_process = wow64;
 #endif
 
   CloseHandle (pi.hThread);
@@ -2796,10 +2757,10 @@ windows_nat_target::mourn_inferior ()
   x86_cleanup_dregs();
   if (open_process_used)
     {
-      CHECK (CloseHandle (current_process_handle));
+      CHECK (CloseHandle (windows_process.handle));
       open_process_used = 0;
     }
-  siginfo_er.ExceptionCode = 0;
+  windows_process.siginfo_er.ExceptionCode = 0;
   inf_child_target::mourn_inferior ();
 }
 
@@ -2810,7 +2771,8 @@ void
 windows_nat_target::interrupt ()
 {
   DEBUG_EVENTS ("GenerateConsoleCtrlEvent (CTRLC_EVENT, 0)");
-  CHECK (GenerateConsoleCtrlEvent (CTRL_C_EVENT, current_event.dwProcessId));
+  CHECK (GenerateConsoleCtrlEvent (CTRL_C_EVENT,
+                                  windows_process.current_event.dwProcessId));
   registers_changed ();                /* refresh register state */
 }
 
@@ -2829,19 +2791,19 @@ windows_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
     {
       DEBUG_MEM ("write target memory, %s bytes at %s",
                 pulongest (len), core_addr_to_string (memaddr));
-      success = WriteProcessMemory (current_process_handle,
+      success = WriteProcessMemory (windows_process.handle,
                                    (LPVOID) (uintptr_t) memaddr, writebuf,
                                    len, &done);
       if (!success)
        lasterror = GetLastError ();
-      FlushInstructionCache (current_process_handle,
+      FlushInstructionCache (windows_process.handle,
                             (LPCVOID) (uintptr_t) memaddr, len);
     }
   else
     {
       DEBUG_MEM ("read target memory, %s bytes at %s",
                 pulongest (len), core_addr_to_string (memaddr));
-      success = ReadProcessMemory (current_process_handle,
+      success = ReadProcessMemory (windows_process.handle,
                                   (LPCVOID) (uintptr_t) memaddr, readbuf,
                                   len, &done);
       if (!success)
@@ -2857,15 +2819,16 @@ windows_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
 void
 windows_nat_target::kill ()
 {
-  CHECK (TerminateProcess (current_process_handle, 0));
+  CHECK (TerminateProcess (windows_process.handle, 0));
 
   for (;;)
     {
       if (!windows_continue (DBG_CONTINUE, -1, 1))
        break;
-      if (!wait_for_debug_event (&current_event, INFINITE))
+      if (!wait_for_debug_event (&windows_process.current_event, INFINITE))
        break;
-      if (current_event.dwDebugEventCode == EXIT_PROCESS_DEBUG_EVENT)
+      if (windows_process.current_event.dwDebugEventCode
+         == EXIT_PROCESS_DEBUG_EVENT)
        break;
     }
 
@@ -2895,25 +2858,19 @@ windows_xfer_shared_libraries (struct target_ops *ops,
                               ULONGEST offset, ULONGEST len,
                               ULONGEST *xfered_len)
 {
-  struct obstack obstack;
+  auto_obstack obstack;
   const char *buf;
   LONGEST len_avail;
-  struct so_list *so;
 
   if (writebuf)
     return TARGET_XFER_E_IO;
 
-  obstack_init (&obstack);
   obstack_grow_str (&obstack, "<library-list>\n");
-  for (so = solib_start.next; so; so = so->next)
-    {
-      lm_info_windows *li = (lm_info_windows *) so->lm_info;
-
-      windows_xfer_shared_library (so->so_name, (CORE_ADDR)
-                                  (uintptr_t) li->load_addr,
-                                  &li->text_offset,
-                                  target_gdbarch (), &obstack);
-    }
+  for (windows_solib &so : solibs)
+    windows_xfer_shared_library (so.name.c_str (),
+                                (CORE_ADDR) (uintptr_t) so.load_addr,
+                                &so.text_offset,
+                                target_gdbarch (), &obstack);
   obstack_grow_str0 (&obstack, "</library-list>\n");
 
   buf = (const char *) obstack_finish (&obstack);
@@ -2927,7 +2884,6 @@ windows_xfer_shared_libraries (struct target_ops *ops,
       memcpy (readbuf, buf + offset, len);
     }
 
-  obstack_free (&obstack, NULL);
   *xfered_len = (ULONGEST) len;
   return len != 0 ? TARGET_XFER_OK : TARGET_XFER_EOF;
 }
@@ -2938,28 +2894,31 @@ static enum target_xfer_status
 windows_xfer_siginfo (gdb_byte *readbuf, ULONGEST offset, ULONGEST len,
                      ULONGEST *xfered_len)
 {
-  char *buf = (char *) &siginfo_er;
-  size_t bufsize = sizeof (siginfo_er);
+  char *buf = (char *) &windows_process.siginfo_er;
+  size_t bufsize = sizeof (windows_process.siginfo_er);
 
 #ifdef __x86_64__
   EXCEPTION_RECORD32 er32;
-  if (wow64_process)
+  if (windows_process.wow64_process)
     {
       buf = (char *) &er32;
       bufsize = sizeof (er32);
 
-      er32.ExceptionCode = siginfo_er.ExceptionCode;
-      er32.ExceptionFlags = siginfo_er.ExceptionFlags;
-      er32.ExceptionRecord = (uintptr_t) siginfo_er.ExceptionRecord;
-      er32.ExceptionAddress = (uintptr_t) siginfo_er.ExceptionAddress;
-      er32.NumberParameters = siginfo_er.NumberParameters;
+      er32.ExceptionCode = windows_process.siginfo_er.ExceptionCode;
+      er32.ExceptionFlags = windows_process.siginfo_er.ExceptionFlags;
+      er32.ExceptionRecord
+       = (uintptr_t) windows_process.siginfo_er.ExceptionRecord;
+      er32.ExceptionAddress
+       = (uintptr_t) windows_process.siginfo_er.ExceptionAddress;
+      er32.NumberParameters = windows_process.siginfo_er.NumberParameters;
       int i;
       for (i = 0; i < EXCEPTION_MAXIMUM_PARAMETERS; i++)
-       er32.ExceptionInformation[i] = siginfo_er.ExceptionInformation[i];
+       er32.ExceptionInformation[i]
+         = windows_process.siginfo_er.ExceptionInformation[i];
     }
 #endif
 
-  if (siginfo_er.ExceptionCode == 0)
+  if (windows_process.siginfo_er.ExceptionCode == 0)
     return TARGET_XFER_E_IO;
 
   if (readbuf == nullptr)
@@ -3017,7 +2976,7 @@ windows_nat_target::get_tib_address (ptid_t ptid, CORE_ADDR *addr)
 {
   windows_thread_info *th;
 
-  th = thread_rec (ptid, DONT_INVALIDATE_CONTEXT);
+  th = windows_process.thread_rec (ptid, DONT_INVALIDATE_CONTEXT);
   if (th == NULL)
     return false;
 
@@ -3038,7 +2997,10 @@ windows_nat_target::get_ada_task_ptid (long lwp, ULONGEST thread)
 const char *
 windows_nat_target::thread_name (struct thread_info *thr)
 {
-  return thread_rec (thr->ptid, DONT_INVALIDATE_CONTEXT)->name.get ();
+  windows_thread_info *th
+    = windows_process.thread_rec (thr->ptid,
+                                 DONT_INVALIDATE_CONTEXT);
+  return th->thread_name ();
 }
 
 
@@ -3158,7 +3120,7 @@ cygwin_set_dr (int i, CORE_ADDR addr)
                    _("Invalid register %d in cygwin_set_dr.\n"), i);
   dr[i] = addr;
 
-  for (windows_thread_info *th : thread_list)
+  for (auto &th : thread_list)
     th->debug_registers_changed = true;
 }
 
@@ -3170,7 +3132,7 @@ cygwin_set_dr7 (unsigned long val)
 {
   dr[7] = (CORE_ADDR) val;
 
-  for (windows_thread_info *th : thread_list)
+  for (auto &th : thread_list)
     th->debug_registers_changed = true;
 }
 
@@ -3210,8 +3172,9 @@ windows_nat_target::thread_alive (ptid_t ptid)
 {
   gdb_assert (ptid.lwp () != 0);
 
-  return (WaitForSingleObject (thread_rec (ptid, DONT_INVALIDATE_CONTEXT)->h, 0)
-         != WAIT_OBJECT_0);
+  windows_thread_info *th
+    = windows_process.thread_rec (ptid, DONT_INVALIDATE_CONTEXT);
+  return WaitForSingleObject (th->h, 0) != WAIT_OBJECT_0;
 }
 
 void _initialize_check_for_gdb_ini ();