radv: Enable tessellation shaders for GFX9.
[mesa.git] / src / amd / vulkan / radv_device.c
index ae0a76137e74512b254478dbbf46e2e6857fb21a..125498809ecbafe3d4254eef6c5526cc6856a772 100644 (file)
@@ -31,6 +31,7 @@
 #include <fcntl.h>
 #include "radv_debug.h"
 #include "radv_private.h"
+#include "radv_shader.h"
 #include "radv_cs.h"
 #include "util/disk_cache.h"
 #include "util/strtod.h"
@@ -75,174 +76,6 @@ radv_get_device_uuid(struct radeon_info *info, void *uuid)
        ac_compute_device_uuid(info, uuid, VK_UUID_SIZE);
 }
 
-static const VkExtensionProperties instance_extensions[] = {
-       {
-               .extensionName = VK_KHR_SURFACE_EXTENSION_NAME,
-               .specVersion = 25,
-       },
-#ifdef VK_USE_PLATFORM_XCB_KHR
-       {
-               .extensionName = VK_KHR_XCB_SURFACE_EXTENSION_NAME,
-               .specVersion = 6,
-       },
-#endif
-#ifdef VK_USE_PLATFORM_XLIB_KHR
-       {
-               .extensionName = VK_KHR_XLIB_SURFACE_EXTENSION_NAME,
-               .specVersion = 6,
-       },
-#endif
-#ifdef VK_USE_PLATFORM_WAYLAND_KHR
-       {
-               .extensionName = VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME,
-               .specVersion = 6,
-       },
-#endif
-       {
-               .extensionName = VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_EXTERNAL_MEMORY_CAPABILITIES_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_EXTERNAL_SEMAPHORE_CAPABILITIES_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-};
-
-static const VkExtensionProperties common_device_extensions[] = {
-       {
-               .extensionName = VK_KHR_DESCRIPTOR_UPDATE_TEMPLATE_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_MAINTENANCE1_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_SAMPLER_MIRROR_CLAMP_TO_EDGE_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_SWAPCHAIN_EXTENSION_NAME,
-               .specVersion = 68,
-       },
-       {
-               .extensionName = VK_AMD_DRAW_INDIRECT_COUNT_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_GET_MEMORY_REQUIREMENTS_2_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_DEDICATED_ALLOCATION_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_EXTERNAL_MEMORY_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_EXTERNAL_MEMORY_FD_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_STORAGE_BUFFER_STORAGE_CLASS_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_VARIABLE_POINTERS_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-};
-static const VkExtensionProperties ext_sema_device_extensions[] = {
-       {
-               .extensionName = VK_KHR_EXTERNAL_SEMAPHORE_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHR_EXTERNAL_SEMAPHORE_FD_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-       {
-               .extensionName = VK_KHX_MULTIVIEW_EXTENSION_NAME,
-               .specVersion = 1,
-       },
-};
-
-static VkResult
-radv_extensions_register(struct radv_instance *instance,
-                       struct radv_extensions *extensions,
-                       const VkExtensionProperties *new_ext,
-                       uint32_t num_ext)
-{
-       size_t new_size;
-       VkExtensionProperties *new_ptr;
-
-       assert(new_ext && num_ext > 0);
-
-       if (!new_ext)
-               return VK_ERROR_INITIALIZATION_FAILED;
-
-       new_size = (extensions->num_ext + num_ext) * sizeof(VkExtensionProperties);
-       new_ptr = vk_realloc(&instance->alloc, extensions->ext_array,
-                               new_size, 8, VK_SYSTEM_ALLOCATION_SCOPE_INSTANCE);
-
-       /* Old array continues to be valid, update nothing */
-       if (!new_ptr)
-               return VK_ERROR_OUT_OF_HOST_MEMORY;
-
-       memcpy(&new_ptr[extensions->num_ext], new_ext,
-               num_ext * sizeof(VkExtensionProperties));
-       extensions->ext_array = new_ptr;
-       extensions->num_ext += num_ext;
-
-       return VK_SUCCESS;
-}
-
-static void
-radv_extensions_finish(struct radv_instance *instance,
-                       struct radv_extensions *extensions)
-{
-       assert(extensions);
-
-       if (!extensions)
-               radv_loge("Attemted to free invalid extension struct\n");
-
-       if (extensions->ext_array)
-               vk_free(&instance->alloc, extensions->ext_array);
-}
-
-static bool
-is_extension_enabled(const VkExtensionProperties *extensions,
-                       size_t num_ext,
-                       const char *name)
-{
-       assert(extensions && name);
-
-       for (uint32_t i = 0; i < num_ext; i++) {
-               if (strcmp(name, extensions[i].extensionName) == 0)
-                       return true;
-       }
-
-       return false;
-}
-
 static const char *
 get_chip_name(enum radeon_family family)
 {
@@ -327,21 +160,17 @@ radv_physical_device_init(struct radv_physical_device *device,
                goto fail;
        }
 
-       result = radv_extensions_register(instance,
-                                       &device->extensions,
-                                       common_device_extensions,
-                                       ARRAY_SIZE(common_device_extensions));
-       if (result != VK_SUCCESS)
-               goto fail;
+       /* These flags affect shader compilation. */
+       uint64_t shader_env_flags =
+               (device->instance->perftest_flags & RADV_PERFTEST_SISCHED ? 0x1 : 0) |
+               (device->instance->debug_flags & RADV_DEBUG_UNSAFE_MATH ? 0x2 : 0);
 
-       if (device->rad_info.has_syncobj) {
-               result = radv_extensions_register(instance,
-                                                 &device->extensions,
-                                                 ext_sema_device_extensions,
-                                                 ARRAY_SIZE(ext_sema_device_extensions));
-               if (result != VK_SUCCESS)
-                       goto fail;
-       }
+       /* The gpu id is already embeded in the uuid so we just pass "radv"
+        * when creating the cache.
+        */
+       char buf[VK_UUID_SIZE + 1];
+       disk_cache_format_hex_id(buf, device->cache_uuid, VK_UUID_SIZE);
+       device->disk_cache = disk_cache_create("radv", buf, shader_env_flags);
 
        fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n");
        device->name = get_chip_name(device->rad_info.family);
@@ -355,6 +184,11 @@ radv_physical_device_init(struct radv_physical_device *device,
                device->rbplus_allowed = device->rad_info.family == CHIP_STONEY;
        }
 
+       /* The mere presense of CLEAR_STATE in the IB causes random GPU hangs
+        * on SI.
+        */
+       device->has_clear_state = device->rad_info.chip_class >= CIK;
+
        return VK_SUCCESS;
 
 fail:
@@ -365,9 +199,9 @@ fail:
 static void
 radv_physical_device_finish(struct radv_physical_device *device)
 {
-       radv_extensions_finish(device->instance, &device->extensions);
        radv_finish_wsi(device);
        device->ws->destroy(device->ws);
+       disk_cache_destroy(device->disk_cache);
        close(device->local_fd);
 }
 
@@ -410,15 +244,32 @@ static const struct debug_control radv_debug_options[] = {
        {"allbos", RADV_DEBUG_ALL_BOS},
        {"noibs", RADV_DEBUG_NO_IBS},
        {"spirv", RADV_DEBUG_DUMP_SPIRV},
+       {"vmfaults", RADV_DEBUG_VM_FAULTS},
+       {"zerovram", RADV_DEBUG_ZERO_VRAM},
+       {"syncshaders", RADV_DEBUG_SYNC_SHADERS},
        {NULL, 0}
 };
 
+const char *
+radv_get_debug_option_name(int id)
+{
+       assert(id < ARRAY_SIZE(radv_debug_options) - 1);
+       return radv_debug_options[id].string;
+}
+
 static const struct debug_control radv_perftest_options[] = {
        {"nobatchchain", RADV_PERFTEST_NO_BATCHCHAIN},
        {"sisched", RADV_PERFTEST_SISCHED},
        {NULL, 0}
 };
 
+const char *
+radv_get_perftest_option_name(int id)
+{
+       assert(id < ARRAY_SIZE(radv_debug_options) - 1);
+       return radv_perftest_options[id].string;
+}
+
 VkResult radv_CreateInstance(
        const VkInstanceCreateInfo*                 pCreateInfo,
        const VkAllocationCallbacks*                pAllocator,
@@ -446,9 +297,8 @@ VkResult radv_CreateInstance(
        }
 
        for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
-               if (!is_extension_enabled(instance_extensions,
-                                       ARRAY_SIZE(instance_extensions),
-                                       pCreateInfo->ppEnabledExtensionNames[i]))
+               const char *ext_name = pCreateInfo->ppEnabledExtensionNames[i];
+               if (!radv_instance_extension_supported(ext_name))
                        return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
        }
 
@@ -521,7 +371,7 @@ radv_enumerate_devices(struct radv_instance *instance)
        for (unsigned i = 0; i < (unsigned)max_devices; i++) {
                if (devices[i]->available_nodes & 1 << DRM_NODE_RENDER &&
                    devices[i]->bustype == DRM_BUS_PCI &&
-                   devices[i]->deviceinfo.pci->vendor_id == 0x1002) {
+                   devices[i]->deviceinfo.pci->vendor_id == ATI_VENDOR_ID) {
 
                        result = radv_physical_device_init(instance->physicalDevices +
                                                           instance->physicalDeviceCount,
@@ -579,7 +429,7 @@ void radv_GetPhysicalDeviceFeatures(
                .imageCubeArray                           = true,
                .independentBlend                         = true,
                .geometryShader                           = !is_gfx9,
-               .tessellationShader                       = !is_gfx9,
+               .tessellationShader                       = true,
                .sampleRateShading                        = true,
                .dualSrcBlend                             = true,
                .logicOp                                  = true,
@@ -782,9 +632,9 @@ void radv_GetPhysicalDeviceProperties(
        };
 
        *pProperties = (VkPhysicalDeviceProperties) {
-               .apiVersion = VK_MAKE_VERSION(1, 0, 42),
+               .apiVersion = radv_physical_device_api_version(pdevice),
                .driverVersion = vk_get_driver_version(),
-               .vendorID = 0x1002,
+               .vendorID = ATI_VENDOR_ID,
                .deviceID = pdevice->rad_info.pci_id,
                .deviceType = pdevice->rad_info.has_dedicated_vram ? VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU : VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU,
                .limits = limits,
@@ -823,6 +673,12 @@ void radv_GetPhysicalDeviceProperties2KHR(
                        properties->maxMultiviewInstanceIndex = INT_MAX;
                        break;
                }
+               case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_POINT_CLIPPING_PROPERTIES_KHR: {
+                       VkPhysicalDevicePointClippingPropertiesKHR *properties =
+                           (VkPhysicalDevicePointClippingPropertiesKHR*)ext;
+                       properties->pointClippingBehavior = VK_POINT_CLIPPING_BEHAVIOR_ALL_CLIP_PLANES_KHR;
+                       break;
+               }
                default:
                        break;
                }
@@ -1066,9 +922,8 @@ VkResult radv_CreateDevice(
        struct radv_device *device;
 
        for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
-               if (!is_extension_enabled(physical_device->extensions.ext_array,
-                                       physical_device->extensions.num_ext,
-                                       pCreateInfo->ppEnabledExtensionNames[i]))
+               const char *ext_name = pCreateInfo->ppEnabledExtensionNames[i];
+               if (!radv_physical_device_extension_supported(physical_device, ext_name))
                        return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
        }
 
@@ -1097,8 +952,6 @@ VkResult radv_CreateDevice(
        device->instance = physical_device->instance;
        device->physical_device = physical_device;
 
-       device->debug_flags = device->instance->debug_flags;
-
        device->ws = physical_device->ws;
        if (pAllocator)
                device->alloc = *pAllocator;
@@ -1160,6 +1013,11 @@ VkResult radv_CreateDevice(
                device->physical_device->rad_info.chip_class >= VI &&
                device->physical_device->rad_info.max_se >= 2;
 
+       if (getenv("RADV_TRACE_FILE")) {
+               if (!radv_init_trace(device))
+                       goto fail;
+       }
+
        result = radv_device_init_meta(device);
        if (result != VK_SUCCESS)
                goto fail;
@@ -1182,11 +1040,6 @@ VkResult radv_CreateDevice(
                device->ws->cs_finalize(device->empty_cs[family]);
        }
 
-       if (getenv("RADV_TRACE_FILE")) {
-               if (!radv_init_trace(device))
-                       goto fail;
-       }
-
        if (device->physical_device->rad_info.chip_class >= CIK)
                cik_create_gfx_config(device);
 
@@ -1258,47 +1111,6 @@ void radv_DestroyDevice(
        vk_free(&device->alloc, device);
 }
 
-VkResult radv_EnumerateInstanceExtensionProperties(
-       const char*                                 pLayerName,
-       uint32_t*                                   pPropertyCount,
-       VkExtensionProperties*                      pProperties)
-{
-       if (pProperties == NULL) {
-               *pPropertyCount = ARRAY_SIZE(instance_extensions);
-               return VK_SUCCESS;
-       }
-
-       *pPropertyCount = MIN2(*pPropertyCount, ARRAY_SIZE(instance_extensions));
-       typed_memcpy(pProperties, instance_extensions, *pPropertyCount);
-
-       if (*pPropertyCount < ARRAY_SIZE(instance_extensions))
-               return VK_INCOMPLETE;
-
-       return VK_SUCCESS;
-}
-
-VkResult radv_EnumerateDeviceExtensionProperties(
-       VkPhysicalDevice                            physicalDevice,
-       const char*                                 pLayerName,
-       uint32_t*                                   pPropertyCount,
-       VkExtensionProperties*                      pProperties)
-{
-       RADV_FROM_HANDLE(radv_physical_device, pdevice, physicalDevice);
-
-       if (pProperties == NULL) {
-               *pPropertyCount = pdevice->extensions.num_ext;
-               return VK_SUCCESS;
-       }
-
-       *pPropertyCount = MIN2(*pPropertyCount, pdevice->extensions.num_ext);
-       typed_memcpy(pProperties, pdevice->extensions.ext_array, *pPropertyCount);
-
-       if (*pPropertyCount < pdevice->extensions.num_ext)
-               return VK_INCOMPLETE;
-
-       return VK_SUCCESS;
-}
-
 VkResult radv_EnumerateInstanceLayerProperties(
        uint32_t*                                   pPropertyCount,
        VkLayerProperties*                          pProperties)
@@ -1355,13 +1167,13 @@ fill_geom_tess_rings(struct radv_queue *queue,
        uint32_t *desc = &map[4];
 
        if (esgs_ring_bo)
-               esgs_va = queue->device->ws->buffer_get_va(esgs_ring_bo);
+               esgs_va = radv_buffer_get_va(esgs_ring_bo);
        if (gsvs_ring_bo)
-               gsvs_va = queue->device->ws->buffer_get_va(gsvs_ring_bo);
+               gsvs_va = radv_buffer_get_va(gsvs_ring_bo);
        if (tess_factor_ring_bo)
-               tess_factor_va = queue->device->ws->buffer_get_va(tess_factor_ring_bo);
+               tess_factor_va = radv_buffer_get_va(tess_factor_ring_bo);
        if (tess_offchip_ring_bo)
-               tess_offchip_va = queue->device->ws->buffer_get_va(tess_offchip_ring_bo);
+               tess_offchip_va = radv_buffer_get_va(tess_offchip_ring_bo);
 
        /* stride 0, num records - size, add tid, swizzle, elsize4,
           index stride 64 */
@@ -1708,7 +1520,7 @@ radv_get_preamble_cs(struct radv_queue *queue,
                        uint32_t *map = (uint32_t*)queue->device->ws->buffer_map(descriptor_bo);
 
                        if (scratch_bo) {
-                               uint64_t scratch_va = queue->device->ws->buffer_get_va(scratch_bo);
+                               uint64_t scratch_va = radv_buffer_get_va(scratch_bo);
                                uint32_t rsrc1 = S_008F04_BASE_ADDRESS_HI(scratch_va >> 32) |
                                                 S_008F04_SWIZZLE_ENABLE(1);
                                map[0] = scratch_va;
@@ -1746,7 +1558,7 @@ radv_get_preamble_cs(struct radv_queue *queue,
                }
 
                if (tess_factor_ring_bo) {
-                       uint64_t tf_va = queue->device->ws->buffer_get_va(tess_factor_ring_bo);
+                       uint64_t tf_va = radv_buffer_get_va(tess_factor_ring_bo);
                        if (queue->device->physical_device->rad_info.chip_class >= CIK) {
                                radeon_set_uconfig_reg(cs, R_030938_VGT_TF_RING_SIZE,
                                                       S_030938_SIZE(tess_factor_ring_size / 4));
@@ -1768,24 +1580,36 @@ radv_get_preamble_cs(struct radv_queue *queue,
                }
 
                if (descriptor_bo) {
-                       uint32_t regs[] = {R_00B030_SPI_SHADER_USER_DATA_PS_0,
-                                          R_00B130_SPI_SHADER_USER_DATA_VS_0,
-                                          R_00B230_SPI_SHADER_USER_DATA_GS_0,
-                                          R_00B330_SPI_SHADER_USER_DATA_ES_0,
-                                          R_00B430_SPI_SHADER_USER_DATA_HS_0,
-                                          R_00B530_SPI_SHADER_USER_DATA_LS_0};
-
-                       uint64_t va = queue->device->ws->buffer_get_va(descriptor_bo);
-
-                       for (int i = 0; i < ARRAY_SIZE(regs); ++i) {
-                               radeon_set_sh_reg_seq(cs, regs[i], 2);
-                               radeon_emit(cs, va);
-                               radeon_emit(cs, va >> 32);
+                       uint64_t va = radv_buffer_get_va(descriptor_bo);
+                       if (queue->device->physical_device->rad_info.chip_class >= GFX9) {
+                               uint32_t regs[] = {R_00B030_SPI_SHADER_USER_DATA_PS_0,
+                                               R_00B130_SPI_SHADER_USER_DATA_VS_0,
+                                               R_00B208_SPI_SHADER_USER_DATA_ADDR_LO_GS,
+                                               R_00B408_SPI_SHADER_USER_DATA_ADDR_LO_HS};
+
+                               for (int i = 0; i < ARRAY_SIZE(regs); ++i) {
+                                       radeon_set_sh_reg_seq(cs, regs[i], 2);
+                                       radeon_emit(cs, va);
+                                       radeon_emit(cs, va >> 32);
+                               }
+                       } else {
+                               uint32_t regs[] = {R_00B030_SPI_SHADER_USER_DATA_PS_0,
+                                               R_00B130_SPI_SHADER_USER_DATA_VS_0,
+                                               R_00B230_SPI_SHADER_USER_DATA_GS_0,
+                                               R_00B330_SPI_SHADER_USER_DATA_ES_0,
+                                               R_00B430_SPI_SHADER_USER_DATA_HS_0,
+                                               R_00B530_SPI_SHADER_USER_DATA_LS_0};
+
+                               for (int i = 0; i < ARRAY_SIZE(regs); ++i) {
+                                       radeon_set_sh_reg_seq(cs, regs[i], 2);
+                                       radeon_emit(cs, va);
+                                       radeon_emit(cs, va >> 32);
+                               }
                        }
                }
 
                if (compute_scratch_bo) {
-                       uint64_t scratch_va = queue->device->ws->buffer_get_va(compute_scratch_bo);
+                       uint64_t scratch_va = radv_buffer_get_va(compute_scratch_bo);
                        uint32_t rsrc1 = S_008F04_BASE_ADDRESS_HI(scratch_va >> 32) |
                                         S_008F04_SWIZZLE_ENABLE(1);
 
@@ -2459,44 +2283,74 @@ void radv_GetDeviceMemoryCommitment(
        *pCommittedMemoryInBytes = 0;
 }
 
+VkResult radv_BindBufferMemory2KHR(VkDevice device,
+                                   uint32_t bindInfoCount,
+                                   const VkBindBufferMemoryInfoKHR *pBindInfos)
+{
+       for (uint32_t i = 0; i < bindInfoCount; ++i) {
+               RADV_FROM_HANDLE(radv_device_memory, mem, pBindInfos[i].memory);
+               RADV_FROM_HANDLE(radv_buffer, buffer, pBindInfos[i].buffer);
+
+               if (mem) {
+                       buffer->bo = mem->bo;
+                       buffer->offset = pBindInfos[i].memoryOffset;
+               } else {
+                       buffer->bo = NULL;
+               }
+       }
+       return VK_SUCCESS;
+}
+
 VkResult radv_BindBufferMemory(
        VkDevice                                    device,
-       VkBuffer                                    _buffer,
-       VkDeviceMemory                              _memory,
+       VkBuffer                                    buffer,
+       VkDeviceMemory                              memory,
        VkDeviceSize                                memoryOffset)
 {
-       RADV_FROM_HANDLE(radv_device_memory, mem, _memory);
-       RADV_FROM_HANDLE(radv_buffer, buffer, _buffer);
+       const VkBindBufferMemoryInfoKHR info = {
+               .sType = VK_STRUCTURE_TYPE_BIND_BUFFER_MEMORY_INFO_KHR,
+               .buffer = buffer,
+               .memory = memory,
+               .memoryOffset = memoryOffset
+       };
 
-       if (mem) {
-               buffer->bo = mem->bo;
-               buffer->offset = memoryOffset;
-       } else {
-               buffer->bo = NULL;
-               buffer->offset = 0;
-       }
+       return radv_BindBufferMemory2KHR(device, 1, &info);
+}
+
+VkResult radv_BindImageMemory2KHR(VkDevice device,
+                                  uint32_t bindInfoCount,
+                                  const VkBindImageMemoryInfoKHR *pBindInfos)
+{
+       for (uint32_t i = 0; i < bindInfoCount; ++i) {
+               RADV_FROM_HANDLE(radv_device_memory, mem, pBindInfos[i].memory);
+               RADV_FROM_HANDLE(radv_image, image, pBindInfos[i].image);
 
+               if (mem) {
+                       image->bo = mem->bo;
+                       image->offset = pBindInfos[i].memoryOffset;
+               } else {
+                       image->bo = NULL;
+                       image->offset = 0;
+               }
+       }
        return VK_SUCCESS;
 }
 
+
 VkResult radv_BindImageMemory(
        VkDevice                                    device,
-       VkImage                                     _image,
-       VkDeviceMemory                              _memory,
+       VkImage                                     image,
+       VkDeviceMemory                              memory,
        VkDeviceSize                                memoryOffset)
 {
-       RADV_FROM_HANDLE(radv_device_memory, mem, _memory);
-       RADV_FROM_HANDLE(radv_image, image, _image);
-
-       if (mem) {
-               image->bo = mem->bo;
-               image->offset = memoryOffset;
-       } else {
-               image->bo = NULL;
-               image->offset = 0;
-       }
+       const VkBindImageMemoryInfoKHR info = {
+               .sType = VK_STRUCTURE_TYPE_BIND_BUFFER_MEMORY_INFO_KHR,
+               .image = image,
+               .memory = memory,
+               .memoryOffset = memoryOffset
+       };
 
-       return VK_SUCCESS;
+       return radv_BindImageMemory2KHR(device, 1, &info);
 }
 
 
@@ -2933,7 +2787,7 @@ radv_initialise_color_surface(struct radv_device *device,
        /* Intensity is implemented as Red, so treat it that way. */
        cb->cb_color_attrib = S_028C74_FORCE_DST_ALPHA_1(desc->swizzle[3] == VK_SWIZZLE_1);
 
-       va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+       va = radv_buffer_get_va(iview->bo) + iview->image->offset;
 
        cb->cb_color_base = va >> 8;
 
@@ -2985,11 +2839,11 @@ radv_initialise_color_surface(struct radv_device *device,
        }
 
        /* CMASK variables */
-       va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+       va = radv_buffer_get_va(iview->bo) + iview->image->offset;
        va += iview->image->cmask.offset;
        cb->cb_color_cmask = va >> 8;
 
-       va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+       va = radv_buffer_get_va(iview->bo) + iview->image->offset;
        va += iview->image->dcc_offset;
        cb->cb_dcc_base = va >> 8;
        cb->cb_dcc_base |= iview->image->surface.tile_swizzle;
@@ -3006,7 +2860,7 @@ radv_initialise_color_surface(struct radv_device *device,
        }
 
        if (iview->image->fmask.size) {
-               va = device->ws->buffer_get_va(iview->bo) + iview->image->offset + iview->image->fmask.offset;
+               va = radv_buffer_get_va(iview->bo) + iview->image->offset + iview->image->fmask.offset;
                cb->cb_color_fmask = va >> 8;
                cb->cb_color_fmask |= iview->image->fmask.tile_swizzle;
        } else {
@@ -3064,10 +2918,10 @@ radv_initialise_color_surface(struct radv_device *device,
        }
 
        if (iview->image->cmask.size &&
-           !(device->debug_flags & RADV_DEBUG_NO_FAST_CLEARS))
+           !(device->instance->debug_flags & RADV_DEBUG_NO_FAST_CLEARS))
                cb->cb_color_info |= S_028C70_FAST_CLEAR(1);
 
-       if (iview->image->surface.dcc_size && iview->base_mip < surf->num_dcc_levels)
+       if (radv_vi_dcc_enabled(iview->image, iview->base_mip))
                cb->cb_color_info |= S_028C70_DCC_ENABLE(1);
 
        if (device->physical_device->rad_info.chip_class >= VI) {
@@ -3091,8 +2945,8 @@ radv_initialise_color_surface(struct radv_device *device,
        }
 
        if (device->physical_device->rad_info.chip_class >= GFX9) {
-               uint32_t max_slice = radv_surface_layer_count(iview);
-               unsigned mip0_depth = iview->base_layer + max_slice - 1;
+               unsigned mip0_depth = iview->image->type == VK_IMAGE_TYPE_3D ?
+                 (iview->extent.depth - 1) : (iview->image->info.array_size - 1);
 
                cb->cb_color_view |= S_028C6C_MIP_LEVEL(iview->base_mip);
                cb->cb_color_attrib |= S_028C74_MIP0_DEPTH(mip0_depth) |
@@ -3151,7 +3005,7 @@ radv_initialise_ds_surface(struct radv_device *device,
        ds->db_htile_data_base = 0;
        ds->db_htile_surface = 0;
 
-       va = device->ws->buffer_get_va(iview->bo) + iview->image->offset;
+       va = radv_buffer_get_va(iview->bo) + iview->image->offset;
        s_offs = z_offs = va;
 
        if (device->physical_device->rad_info.chip_class >= GFX9) {
@@ -3172,14 +3026,25 @@ radv_initialise_ds_surface(struct radv_device *device,
                ds->db_depth_size = S_02801C_X_MAX(iview->image->info.width - 1) |
                        S_02801C_Y_MAX(iview->image->info.height - 1);
 
-               /* Only use HTILE for the first level. */
-               if (iview->image->surface.htile_size && !level) {
+               if (radv_htile_enabled(iview->image, level)) {
                        ds->db_z_info |= S_028038_TILE_SURFACE_ENABLE(1);
 
+                       if (iview->image->tc_compatible_htile) {
+                               unsigned max_zplanes = 4;
+
+                               if (iview->vk_format == VK_FORMAT_D16_UNORM  &&
+                                   iview->image->info.samples > 1)
+                                       max_zplanes = 2;
+
+                               ds->db_z_info |= S_028038_DECOMPRESS_ON_N_ZPLANES(max_zplanes + 1) |
+                                         S_028038_ITERATE_FLUSH(1);
+                               ds->db_stencil_info |= S_02803C_ITERATE_FLUSH(1);
+                       }
+
                        if (!iview->image->surface.has_stencil)
                                /* Use all of the htile_buffer for depth if there's no stencil. */
                                ds->db_stencil_info |= S_02803C_TILE_STENCIL_DISABLE(1);
-                       va = device->ws->buffer_get_va(iview->bo) + iview->image->offset +
+                       va = radv_buffer_get_va(iview->bo) + iview->image->offset +
                                iview->image->htile_offset;
                        ds->db_htile_data_base = va >> 8;
                        ds->db_htile_surface = S_028ABC_FULL_CACHE(1) |
@@ -3195,7 +3060,7 @@ radv_initialise_ds_surface(struct radv_device *device,
                z_offs += iview->image->surface.u.legacy.level[level].offset;
                s_offs += iview->image->surface.u.legacy.stencil_level[level].offset;
 
-               ds->db_depth_info = S_02803C_ADDR5_SWIZZLE_MASK(1);
+               ds->db_depth_info = S_02803C_ADDR5_SWIZZLE_MASK(!iview->image->tc_compatible_htile);
                ds->db_z_info = S_028040_FORMAT(format) | S_028040_ZRANGE_PRECISION(1);
                ds->db_stencil_info = S_028044_FORMAT(stencil_format);
 
@@ -3236,17 +3101,29 @@ radv_initialise_ds_surface(struct radv_device *device,
                        S_028058_HEIGHT_TILE_MAX((level_info->nblk_y / 8) - 1);
                ds->db_depth_slice = S_02805C_SLICE_TILE_MAX((level_info->nblk_x * level_info->nblk_y) / 64 - 1);
 
-               if (iview->image->surface.htile_size && !level) {
+               if (radv_htile_enabled(iview->image, level)) {
                        ds->db_z_info |= S_028040_TILE_SURFACE_ENABLE(1);
 
-                       if (!iview->image->surface.has_stencil)
+                       if (!iview->image->surface.has_stencil &&
+                           !iview->image->tc_compatible_htile)
                                /* Use all of the htile_buffer for depth if there's no stencil. */
                                ds->db_stencil_info |= S_028044_TILE_STENCIL_DISABLE(1);
 
-                       va = device->ws->buffer_get_va(iview->bo) + iview->image->offset +
+                       va = radv_buffer_get_va(iview->bo) + iview->image->offset +
                                iview->image->htile_offset;
                        ds->db_htile_data_base = va >> 8;
                        ds->db_htile_surface = S_028ABC_FULL_CACHE(1);
+
+                       if (iview->image->tc_compatible_htile) {
+                               ds->db_htile_surface |= S_028ABC_TC_COMPATIBLE(1);
+
+                               if (iview->image->info.samples <= 1)
+                                       ds->db_z_info |= S_028040_DECOMPRESS_ON_N_ZPLANES(5);
+                               else if (iview->image->info.samples <= 4)
+                                       ds->db_z_info |= S_028040_DECOMPRESS_ON_N_ZPLANES(3);
+                               else
+                                       ds->db_z_info|= S_028040_DECOMPRESS_ON_N_ZPLANES(2);
+                       }
                }
        }