radv/gfx10: add radv_device::use_ngg
[mesa.git] / src / amd / vulkan / radv_device.c
index 7786a71afc8d18f4563af0923f1fe859029dc3bc..d3c412558baa804cfabdfaca38d5e740847cba88 100644 (file)
@@ -86,41 +86,41 @@ radv_get_device_uuid(struct radeon_info *info, void *uuid)
 }
 
 static void
-radv_get_device_name(enum radeon_family family, char *name, size_t name_len)
+radv_get_device_name(enum radeon_family family, char *name, size_t name_len, bool aco)
 {
        const char *chip_string;
 
        switch (family) {
-       case CHIP_TAHITI: chip_string = "AMD RADV TAHITI"; break;
-       case CHIP_PITCAIRN: chip_string = "AMD RADV PITCAIRN"; break;
-       case CHIP_VERDE: chip_string = "AMD RADV CAPE VERDE"; break;
-       case CHIP_OLAND: chip_string = "AMD RADV OLAND"; break;
-       case CHIP_HAINAN: chip_string = "AMD RADV HAINAN"; break;
-       case CHIP_BONAIRE: chip_string = "AMD RADV BONAIRE"; break;
-       case CHIP_KAVERI: chip_string = "AMD RADV KAVERI"; break;
-       case CHIP_KABINI: chip_string = "AMD RADV KABINI"; break;
-       case CHIP_HAWAII: chip_string = "AMD RADV HAWAII"; break;
-       case CHIP_TONGA: chip_string = "AMD RADV TONGA"; break;
-       case CHIP_ICELAND: chip_string = "AMD RADV ICELAND"; break;
-       case CHIP_CARRIZO: chip_string = "AMD RADV CARRIZO"; break;
-       case CHIP_FIJI: chip_string = "AMD RADV FIJI"; break;
-       case CHIP_POLARIS10: chip_string = "AMD RADV POLARIS10"; break;
-       case CHIP_POLARIS11: chip_string = "AMD RADV POLARIS11"; break;
-       case CHIP_POLARIS12: chip_string = "AMD RADV POLARIS12"; break;
-       case CHIP_STONEY: chip_string = "AMD RADV STONEY"; break;
-       case CHIP_VEGAM: chip_string = "AMD RADV VEGA M"; break;
-       case CHIP_VEGA10: chip_string = "AMD RADV VEGA10"; break;
-       case CHIP_VEGA12: chip_string = "AMD RADV VEGA12"; break;
-       case CHIP_VEGA20: chip_string = "AMD RADV VEGA20"; break;
-       case CHIP_RAVEN: chip_string = "AMD RADV RAVEN"; break;
-       case CHIP_RAVEN2: chip_string = "AMD RADV RAVEN2"; break;
-       case CHIP_NAVI10: chip_string = "AMD RADV NAVI10"; break;
-       case CHIP_NAVI12: chip_string = "AMD RADV NAVI12"; break;
-       case CHIP_NAVI14: chip_string = "AMD RADV NAVI14"; break;
-       default: chip_string = "AMD RADV unknown"; break;
-       }
-
-       snprintf(name, name_len, "%s (LLVM " MESA_LLVM_VERSION_STRING ")", chip_string);
+       case CHIP_TAHITI: chip_string = "TAHITI"; break;
+       case CHIP_PITCAIRN: chip_string = "PITCAIRN"; break;
+       case CHIP_VERDE: chip_string = "CAPE VERDE"; break;
+       case CHIP_OLAND: chip_string = "OLAND"; break;
+       case CHIP_HAINAN: chip_string = "HAINAN"; break;
+       case CHIP_BONAIRE: chip_string = "BONAIRE"; break;
+       case CHIP_KAVERI: chip_string = "KAVERI"; break;
+       case CHIP_KABINI: chip_string = "KABINI"; break;
+       case CHIP_HAWAII: chip_string = "HAWAII"; break;
+       case CHIP_TONGA: chip_string = "TONGA"; break;
+       case CHIP_ICELAND: chip_string = "ICELAND"; break;
+       case CHIP_CARRIZO: chip_string = "CARRIZO"; break;
+       case CHIP_FIJI: chip_string = "FIJI"; break;
+       case CHIP_POLARIS10: chip_string = "POLARIS10"; break;
+       case CHIP_POLARIS11: chip_string = "POLARIS11"; break;
+       case CHIP_POLARIS12: chip_string = "POLARIS12"; break;
+       case CHIP_STONEY: chip_string = "STONEY"; break;
+       case CHIP_VEGAM: chip_string = "VEGA M"; break;
+       case CHIP_VEGA10: chip_string = "VEGA10"; break;
+       case CHIP_VEGA12: chip_string = "VEGA12"; break;
+       case CHIP_VEGA20: chip_string = "VEGA20"; break;
+       case CHIP_RAVEN: chip_string = "RAVEN"; break;
+       case CHIP_RAVEN2: chip_string = "RAVEN2"; break;
+       case CHIP_NAVI10: chip_string = "NAVI10"; break;
+       case CHIP_NAVI12: chip_string = "NAVI12"; break;
+       case CHIP_NAVI14: chip_string = "NAVI14"; break;
+       default: chip_string = "unknown"; break;
+       }
+
+       snprintf(name, name_len, "AMD RADV%s %s (LLVM " MESA_LLVM_VERSION_STRING ")", aco ? "/ACO" : "", chip_string);
 }
 
 static uint64_t
@@ -327,7 +327,14 @@ radv_physical_device_init(struct radv_physical_device *device,
 
        radv_handle_env_var_force_family(device);
 
-       radv_get_device_name(device->rad_info.family, device->name, sizeof(device->name));
+       device->use_aco = instance->perftest_flags & RADV_PERFTEST_ACO;
+       if ((device->rad_info.chip_class < GFX8 ||
+            device->rad_info.chip_class > GFX9) && device->use_aco) {
+               fprintf(stderr, "WARNING: disabling ACO on unsupported GPUs.\n");
+               device->use_aco = false;
+       }
+
+       radv_get_device_name(device->rad_info.family, device->name, sizeof(device->name), device->use_aco);
 
        if (radv_device_get_cache_uuid(device->rad_info.family, device->cache_uuid)) {
                device->ws->destroy(device->ws);
@@ -339,7 +346,8 @@ radv_physical_device_init(struct radv_physical_device *device,
        /* These flags affect shader compilation. */
        uint64_t shader_env_flags =
                (device->instance->perftest_flags & RADV_PERFTEST_SISCHED ? 0x1 : 0) |
-               (device->instance->debug_flags & RADV_DEBUG_UNSAFE_MATH ? 0x2 : 0);
+               (device->instance->debug_flags & RADV_DEBUG_UNSAFE_MATH ? 0x2 : 0) |
+               (device->use_aco ? 0x4 : 0);
 
        /* The gpu id is already embedded in the uuid so we just pass "radv"
         * when creating the cache.
@@ -362,7 +370,11 @@ radv_physical_device_init(struct radv_physical_device *device,
                (device->instance->perftest_flags & RADV_PERFTEST_DCC_MSAA);
 
        device->use_shader_ballot = device->rad_info.chip_class >= GFX8 &&
-                                   device->instance->perftest_flags & RADV_PERFTEST_SHADER_BALLOT;
+                                   (device->use_aco || device->instance->perftest_flags & RADV_PERFTEST_SHADER_BALLOT);
+
+       device->use_ngg = device->rad_info.chip_class >= GFX10 &&
+                         device->rad_info.family != CHIP_NAVI14 &&
+                         !(device->instance->debug_flags & RADV_DEBUG_NO_NGG);
 
        device->use_ngg_streamout = false;
 
@@ -478,6 +490,7 @@ static const struct debug_control radv_debug_options[] = {
        {"nongg", RADV_DEBUG_NO_NGG},
        {"noshaderballot", RADV_DEBUG_NO_SHADER_BALLOT},
        {"allentrypoints", RADV_DEBUG_ALL_ENTRYPOINTS},
+       {"metashaders", RADV_DEBUG_DUMP_META_SHADERS},
        {NULL, 0}
 };
 
@@ -499,6 +512,8 @@ static const struct debug_control radv_perftest_options[] = {
        {"cswave32", RADV_PERFTEST_CS_WAVE_32},
        {"pswave32", RADV_PERFTEST_PS_WAVE_32},
        {"gewave32", RADV_PERFTEST_GE_WAVE_32},
+       {"dfsm", RADV_PERFTEST_DFSM},
+       {"aco", RADV_PERFTEST_ACO},
        {NULL, 0}
 };
 
@@ -544,6 +559,14 @@ radv_handle_per_app_options(struct radv_instance *instance,
                         */
                        instance->perftest_flags |= RADV_PERFTEST_SHADER_BALLOT;
                }
+       } else if (!strcmp(name, "Fledge")) {
+               /*
+                * Zero VRAM for "The Surge 2"
+                *
+                * This avoid a hang when when rendering any level. Likely
+                * uninitialized data in an indirect draw.
+                */
+               instance->debug_flags |= RADV_DEBUG_ZERO_VRAM;
        }
 }
 
@@ -621,6 +644,8 @@ VkResult radv_CreateInstance(
        instance->perftest_flags = parse_debug_string(getenv("RADV_PERFTEST"),
                                                   radv_perftest_options);
 
+       if (instance->perftest_flags & RADV_PERFTEST_ACO)
+               fprintf(stderr, "WARNING: Experimental compiler backend enabled. Here be dragons! Incorrect rendering, GPU hangs and/or resets are likely\n");
 
        if (instance->debug_flags & RADV_DEBUG_STARTUP)
                radv_logi("Created an instance");
@@ -831,7 +856,7 @@ void radv_GetPhysicalDeviceFeatures(
                .shaderCullDistance                       = true,
                .shaderFloat64                            = true,
                .shaderInt64                              = true,
-               .shaderInt16                              = pdevice->rad_info.chip_class >= GFX9,
+               .shaderInt16                              = pdevice->rad_info.chip_class >= GFX9 && !pdevice->use_aco,
                .sparseBinding                            = true,
                .variableMultisampleRate                  = true,
                .inheritedQueries                         = true,
@@ -873,7 +898,7 @@ void radv_GetPhysicalDeviceFeatures2(
                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES: {
                        VkPhysicalDevice16BitStorageFeatures *features =
                            (VkPhysicalDevice16BitStorageFeatures*)ext;
-                       bool enabled = pdevice->rad_info.chip_class >= GFX8;
+                       bool enabled = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco;
                        features->storageBuffer16BitAccess = enabled;
                        features->uniformAndStorageBuffer16BitAccess = enabled;
                        features->storagePushConstant16 = enabled;
@@ -929,7 +954,7 @@ void radv_GetPhysicalDeviceFeatures2(
                        VkPhysicalDeviceTransformFeedbackFeaturesEXT *features =
                                (VkPhysicalDeviceTransformFeedbackFeaturesEXT*)ext;
                        features->transformFeedback = true;
-                       features->geometryStreams = true;
+                       features->geometryStreams = !pdevice->use_ngg_streamout;
                        break;
                }
                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES_EXT: {
@@ -967,7 +992,7 @@ void radv_GetPhysicalDeviceFeatures2(
                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES_KHR: {
                        VkPhysicalDevice8BitStorageFeaturesKHR *features =
                            (VkPhysicalDevice8BitStorageFeaturesKHR*)ext;
-                       bool enabled = pdevice->rad_info.chip_class >= GFX8;
+                       bool enabled = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco;
                        features->storageBuffer8BitAccess = enabled;
                        features->uniformAndStorageBuffer8BitAccess = enabled;
                        features->storagePushConstant8 = enabled;
@@ -976,8 +1001,8 @@ void radv_GetPhysicalDeviceFeatures2(
                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FLOAT16_INT8_FEATURES_KHR: {
                        VkPhysicalDeviceFloat16Int8FeaturesKHR *features =
                                (VkPhysicalDeviceFloat16Int8FeaturesKHR*)ext;
-                       features->shaderFloat16 = pdevice->rad_info.chip_class >= GFX8;
-                       features->shaderInt8 = true;
+                       features->shaderFloat16 = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco;
+                       features->shaderInt8 = !pdevice->use_aco;
                        break;
                }
                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES_KHR: {
@@ -987,6 +1012,12 @@ void radv_GetPhysicalDeviceFeatures2(
                        features->shaderSharedInt64Atomics = LLVM_VERSION_MAJOR >= 9;
                        break;
                }
+               case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DEMOTE_TO_HELPER_INVOCATION_FEATURES_EXT: {
+                       VkPhysicalDeviceShaderDemoteToHelperInvocationFeaturesEXT *features =
+                               (VkPhysicalDeviceShaderDemoteToHelperInvocationFeaturesEXT *)ext;
+                       features->shaderDemoteToHelperInvocation = pdevice->use_aco;
+                       break;
+               }
                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_INLINE_UNIFORM_BLOCK_FEATURES_EXT: {
                        VkPhysicalDeviceInlineUniformBlockFeaturesEXT *features =
                                (VkPhysicalDeviceInlineUniformBlockFeaturesEXT *)ext;
@@ -1245,6 +1276,7 @@ void radv_GetPhysicalDeviceProperties2(
                        if (pdevice->rad_info.chip_class >= GFX8) {
                                properties->supportedOperations |=
                                                        VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |
+                                                       VK_SUBGROUP_FEATURE_CLUSTERED_BIT |
                                                        VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
                                                        VK_SUBGROUP_FEATURE_SHUFFLE_RELATIVE_BIT;
                        }
@@ -1292,7 +1324,7 @@ void radv_GetPhysicalDeviceProperties2(
 
                        /* SGPR. */
                        properties->sgprsPerSimd =
-                               ac_get_num_physical_sgprs(&pdevice->rad_info);
+                               pdevice->rad_info.num_physical_sgprs_per_simd;
                        properties->minSgprAllocation =
                                pdevice->rad_info.chip_class >= GFX8 ? 16 : 8;
                        properties->maxSgprAllocation =
@@ -1415,8 +1447,8 @@ void radv_GetPhysicalDeviceProperties2(
                        properties->maxTransformFeedbackStreamDataSize = 512;
                        properties->maxTransformFeedbackBufferDataSize = UINT32_MAX;
                        properties->maxTransformFeedbackBufferDataStride = 512;
-                       properties->transformFeedbackQueries = true;
-                       properties->transformFeedbackStreamsLinesTriangles = true;
+                       properties->transformFeedbackQueries = !pdevice->use_ngg_streamout;
+                       properties->transformFeedbackStreamsLinesTriangles = !pdevice->use_ngg_streamout;
                        properties->transformFeedbackRasterizationStreamSelect = false;
                        properties->transformFeedbackDraw = true;
                        break;
@@ -1960,10 +1992,9 @@ VkResult radv_CreateDevice(
        device->pbb_allowed = device->physical_device->rad_info.chip_class >= GFX9 &&
                              !(device->instance->debug_flags & RADV_DEBUG_NOBINNING);
 
+       /* Disable DFSM by default. As of 2019-09-15 Talos on Low is still 3% slower on Raven. */
        device->dfsm_allowed = device->pbb_allowed &&
-                              (device->physical_device->rad_info.family == CHIP_RAVEN ||
-                               device->physical_device->rad_info.family == CHIP_RAVEN2 ||
-                               device->physical_device->rad_info.family == CHIP_RENOIR);
+                              (device->instance->perftest_flags & RADV_PERFTEST_DFSM);
 
 #ifdef ANDROID
        device->always_use_syncobj = device->physical_device->rad_info.has_syncobj_wait_for_submit;