radv: remove useless checks around radv_CmdBindPipeline()
[mesa.git] / src / amd / vulkan / radv_meta_bufimage.c
index 4cdd070354785edbee0150f39cbb17675c3978c7..f5bbf3cb90f59c5f78e68a30f84a16abc2ac3286 100644 (file)
@@ -42,10 +42,10 @@ build_nir_itob_compute_shader(struct radv_device *dev)
                                                             false,
                                                             GLSL_TYPE_FLOAT);
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_COMPUTE, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, "meta_itob_cs");
-       b.shader->info->cs.local_size[0] = 16;
-       b.shader->info->cs.local_size[1] = 16;
-       b.shader->info->cs.local_size[2] = 1;
+       b.shader->info.name = ralloc_strdup(b.shader, "meta_itob_cs");
+       b.shader->info.cs.local_size[0] = 16;
+       b.shader->info.cs.local_size[1] = 16;
+       b.shader->info.cs.local_size[2] = 1;
        nir_variable *input_img = nir_variable_create(b.shader, nir_var_uniform,
                                                      sampler_type, "s_tex");
        input_img->data.descriptor_set = 0;
@@ -59,21 +59,25 @@ build_nir_itob_compute_shader(struct radv_device *dev)
        nir_ssa_def *invoc_id = nir_load_system_value(&b, nir_intrinsic_load_local_invocation_id, 0);
        nir_ssa_def *wg_id = nir_load_system_value(&b, nir_intrinsic_load_work_group_id, 0);
        nir_ssa_def *block_size = nir_imm_ivec4(&b,
-                                               b.shader->info->cs.local_size[0],
-                                               b.shader->info->cs.local_size[1],
-                                               b.shader->info->cs.local_size[2], 0);
+                                               b.shader->info.cs.local_size[0],
+                                               b.shader->info.cs.local_size[1],
+                                               b.shader->info.cs.local_size[2], 0);
 
        nir_ssa_def *global_id = nir_iadd(&b, nir_imul(&b, wg_id, block_size), invoc_id);
 
 
 
        nir_intrinsic_instr *offset = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(offset, 0);
+       nir_intrinsic_set_range(offset, 12);
        offset->src[0] = nir_src_for_ssa(nir_imm_int(&b, 0));
        offset->num_components = 2;
        nir_ssa_dest_init(&offset->instr, &offset->dest, 2, 32, "offset");
        nir_builder_instr_insert(&b, &offset->instr);
 
        nir_intrinsic_instr *stride = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(stride, 0);
+       nir_intrinsic_set_range(stride, 12);
        stride->src[0] = nir_src_for_ssa(nir_imm_int(&b, 8));
        stride->num_components = 1;
        nir_ssa_dest_init(&stride->instr, &stride->dest, 1, 32, "stride");
@@ -123,8 +127,6 @@ radv_device_init_meta_itob_state(struct radv_device *device)
        VkResult result;
        struct radv_shader_module cs = { .nir = NULL };
 
-       zero(device->meta_state.itob);
-
        cs.nir = build_nir_itob_compute_shader(device);
 
        /*
@@ -133,6 +135,7 @@ radv_device_init_meta_itob_state(struct radv_device *device)
         */
        VkDescriptorSetLayoutCreateInfo ds_create_info = {
                .sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO,
+               .flags = VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR,
                .bindingCount = 2,
                .pBindings = (VkDescriptorSetLayoutBinding[]) {
                        {
@@ -209,21 +212,15 @@ fail:
 static void
 radv_device_finish_meta_itob_state(struct radv_device *device)
 {
-       if (device->meta_state.itob.img_p_layout) {
-               radv_DestroyPipelineLayout(radv_device_to_handle(device),
-                                          device->meta_state.itob.img_p_layout,
-                                          &device->meta_state.alloc);
-       }
-       if (device->meta_state.itob.img_ds_layout) {
-               radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
-                                               device->meta_state.itob.img_ds_layout,
-                                               &device->meta_state.alloc);
-       }
-       if (device->meta_state.itob.pipeline) {
-               radv_DestroyPipeline(radv_device_to_handle(device),
-                                    device->meta_state.itob.pipeline,
-                                    &device->meta_state.alloc);
-       }
+       struct radv_meta_state *state = &device->meta_state;
+
+       radv_DestroyPipelineLayout(radv_device_to_handle(device),
+                                  state->itob.img_p_layout, &state->alloc);
+       radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
+                                       state->itob.img_ds_layout,
+                                       &state->alloc);
+       radv_DestroyPipeline(radv_device_to_handle(device),
+                            state->itob.pipeline, &state->alloc);
 }
 
 static nir_shader *
@@ -239,10 +236,10 @@ build_nir_btoi_compute_shader(struct radv_device *dev)
                                                             false,
                                                             GLSL_TYPE_FLOAT);
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_COMPUTE, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, "meta_btoi_cs");
-       b.shader->info->cs.local_size[0] = 16;
-       b.shader->info->cs.local_size[1] = 16;
-       b.shader->info->cs.local_size[2] = 1;
+       b.shader->info.name = ralloc_strdup(b.shader, "meta_btoi_cs");
+       b.shader->info.cs.local_size[0] = 16;
+       b.shader->info.cs.local_size[1] = 16;
+       b.shader->info.cs.local_size[2] = 1;
        nir_variable *input_img = nir_variable_create(b.shader, nir_var_uniform,
                                                      buf_type, "s_tex");
        input_img->data.descriptor_set = 0;
@@ -256,19 +253,23 @@ build_nir_btoi_compute_shader(struct radv_device *dev)
        nir_ssa_def *invoc_id = nir_load_system_value(&b, nir_intrinsic_load_local_invocation_id, 0);
        nir_ssa_def *wg_id = nir_load_system_value(&b, nir_intrinsic_load_work_group_id, 0);
        nir_ssa_def *block_size = nir_imm_ivec4(&b,
-                                               b.shader->info->cs.local_size[0],
-                                               b.shader->info->cs.local_size[1],
-                                               b.shader->info->cs.local_size[2], 0);
+                                               b.shader->info.cs.local_size[0],
+                                               b.shader->info.cs.local_size[1],
+                                               b.shader->info.cs.local_size[2], 0);
 
        nir_ssa_def *global_id = nir_iadd(&b, nir_imul(&b, wg_id, block_size), invoc_id);
 
        nir_intrinsic_instr *offset = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(offset, 0);
+       nir_intrinsic_set_range(offset, 12);
        offset->src[0] = nir_src_for_ssa(nir_imm_int(&b, 0));
        offset->num_components = 2;
        nir_ssa_dest_init(&offset->instr, &offset->dest, 2, 32, "offset");
        nir_builder_instr_insert(&b, &offset->instr);
 
        nir_intrinsic_instr *stride = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(stride, 0);
+       nir_intrinsic_set_range(stride, 12);
        stride->src[0] = nir_src_for_ssa(nir_imm_int(&b, 8));
        stride->num_components = 1;
        nir_ssa_dest_init(&stride->instr, &stride->dest, 1, 32, "stride");
@@ -318,8 +319,6 @@ radv_device_init_meta_btoi_state(struct radv_device *device)
        VkResult result;
        struct radv_shader_module cs = { .nir = NULL };
 
-       zero(device->meta_state.btoi);
-
        cs.nir = build_nir_btoi_compute_shader(device);
 
        /*
@@ -328,6 +327,7 @@ radv_device_init_meta_btoi_state(struct radv_device *device)
         */
        VkDescriptorSetLayoutCreateInfo ds_create_info = {
                .sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO,
+               .flags = VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR,
                .bindingCount = 2,
                .pBindings = (VkDescriptorSetLayoutBinding[]) {
                        {
@@ -404,21 +404,15 @@ fail:
 static void
 radv_device_finish_meta_btoi_state(struct radv_device *device)
 {
-       if (device->meta_state.btoi.img_p_layout) {
-               radv_DestroyPipelineLayout(radv_device_to_handle(device),
-                                          device->meta_state.btoi.img_p_layout,
-                                          &device->meta_state.alloc);
-       }
-       if (device->meta_state.btoi.img_ds_layout) {
-               radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
-                                               device->meta_state.btoi.img_ds_layout,
-                                               &device->meta_state.alloc);
-       }
-       if (device->meta_state.btoi.pipeline) {
-               radv_DestroyPipeline(radv_device_to_handle(device),
-                                    device->meta_state.btoi.pipeline,
-                                    &device->meta_state.alloc);
-       }
+       struct radv_meta_state *state = &device->meta_state;
+
+       radv_DestroyPipelineLayout(radv_device_to_handle(device),
+                                  state->btoi.img_p_layout, &state->alloc);
+       radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
+                                       state->btoi.img_ds_layout,
+                                       &state->alloc);
+       radv_DestroyPipeline(radv_device_to_handle(device),
+                            state->btoi.pipeline, &state->alloc);
 }
 
 static nir_shader *
@@ -434,10 +428,10 @@ build_nir_itoi_compute_shader(struct radv_device *dev)
                                                             false,
                                                             GLSL_TYPE_FLOAT);
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_COMPUTE, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, "meta_itoi_cs");
-       b.shader->info->cs.local_size[0] = 16;
-       b.shader->info->cs.local_size[1] = 16;
-       b.shader->info->cs.local_size[2] = 1;
+       b.shader->info.name = ralloc_strdup(b.shader, "meta_itoi_cs");
+       b.shader->info.cs.local_size[0] = 16;
+       b.shader->info.cs.local_size[1] = 16;
+       b.shader->info.cs.local_size[2] = 1;
        nir_variable *input_img = nir_variable_create(b.shader, nir_var_uniform,
                                                      buf_type, "s_tex");
        input_img->data.descriptor_set = 0;
@@ -451,19 +445,23 @@ build_nir_itoi_compute_shader(struct radv_device *dev)
        nir_ssa_def *invoc_id = nir_load_system_value(&b, nir_intrinsic_load_local_invocation_id, 0);
        nir_ssa_def *wg_id = nir_load_system_value(&b, nir_intrinsic_load_work_group_id, 0);
        nir_ssa_def *block_size = nir_imm_ivec4(&b,
-                                               b.shader->info->cs.local_size[0],
-                                               b.shader->info->cs.local_size[1],
-                                               b.shader->info->cs.local_size[2], 0);
+                                               b.shader->info.cs.local_size[0],
+                                               b.shader->info.cs.local_size[1],
+                                               b.shader->info.cs.local_size[2], 0);
 
        nir_ssa_def *global_id = nir_iadd(&b, nir_imul(&b, wg_id, block_size), invoc_id);
 
        nir_intrinsic_instr *src_offset = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(src_offset, 0);
+       nir_intrinsic_set_range(src_offset, 16);
        src_offset->src[0] = nir_src_for_ssa(nir_imm_int(&b, 0));
        src_offset->num_components = 2;
        nir_ssa_dest_init(&src_offset->instr, &src_offset->dest, 2, 32, "src_offset");
        nir_builder_instr_insert(&b, &src_offset->instr);
 
        nir_intrinsic_instr *dst_offset = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(dst_offset, 0);
+       nir_intrinsic_set_range(dst_offset, 16);
        dst_offset->src[0] = nir_src_for_ssa(nir_imm_int(&b, 8));
        dst_offset->num_components = 2;
        nir_ssa_dest_init(&dst_offset->instr, &dst_offset->dest, 2, 32, "dst_offset");
@@ -507,8 +505,6 @@ radv_device_init_meta_itoi_state(struct radv_device *device)
        VkResult result;
        struct radv_shader_module cs = { .nir = NULL };
 
-       zero(device->meta_state.itoi);
-
        cs.nir = build_nir_itoi_compute_shader(device);
 
        /*
@@ -517,6 +513,7 @@ radv_device_init_meta_itoi_state(struct radv_device *device)
         */
        VkDescriptorSetLayoutCreateInfo ds_create_info = {
                .sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO,
+               .flags = VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR,
                .bindingCount = 2,
                .pBindings = (VkDescriptorSetLayoutBinding[]) {
                        {
@@ -593,21 +590,15 @@ fail:
 static void
 radv_device_finish_meta_itoi_state(struct radv_device *device)
 {
-       if (device->meta_state.itoi.img_p_layout) {
-               radv_DestroyPipelineLayout(radv_device_to_handle(device),
-                                          device->meta_state.itoi.img_p_layout,
-                                          &device->meta_state.alloc);
-       }
-       if (device->meta_state.itoi.img_ds_layout) {
-               radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
-                                               device->meta_state.itoi.img_ds_layout,
-                                               &device->meta_state.alloc);
-       }
-       if (device->meta_state.itoi.pipeline) {
-               radv_DestroyPipeline(radv_device_to_handle(device),
-                                    device->meta_state.itoi.pipeline,
-                                    &device->meta_state.alloc);
-       }
+       struct radv_meta_state *state = &device->meta_state;
+
+       radv_DestroyPipelineLayout(radv_device_to_handle(device),
+                                  state->itoi.img_p_layout, &state->alloc);
+       radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
+                                       state->itoi.img_ds_layout,
+                                       &state->alloc);
+       radv_DestroyPipeline(radv_device_to_handle(device),
+                            state->itoi.pipeline, &state->alloc);
 }
 
 static nir_shader *
@@ -619,10 +610,10 @@ build_nir_cleari_compute_shader(struct radv_device *dev)
                                                             false,
                                                             GLSL_TYPE_FLOAT);
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_COMPUTE, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, "meta_cleari_cs");
-       b.shader->info->cs.local_size[0] = 16;
-       b.shader->info->cs.local_size[1] = 16;
-       b.shader->info->cs.local_size[2] = 1;
+       b.shader->info.name = ralloc_strdup(b.shader, "meta_cleari_cs");
+       b.shader->info.cs.local_size[0] = 16;
+       b.shader->info.cs.local_size[1] = 16;
+       b.shader->info.cs.local_size[2] = 1;
 
        nir_variable *output_img = nir_variable_create(b.shader, nir_var_uniform,
                                                       img_type, "out_img");
@@ -632,13 +623,15 @@ build_nir_cleari_compute_shader(struct radv_device *dev)
        nir_ssa_def *invoc_id = nir_load_system_value(&b, nir_intrinsic_load_local_invocation_id, 0);
        nir_ssa_def *wg_id = nir_load_system_value(&b, nir_intrinsic_load_work_group_id, 0);
        nir_ssa_def *block_size = nir_imm_ivec4(&b,
-                                               b.shader->info->cs.local_size[0],
-                                               b.shader->info->cs.local_size[1],
-                                               b.shader->info->cs.local_size[2], 0);
+                                               b.shader->info.cs.local_size[0],
+                                               b.shader->info.cs.local_size[1],
+                                               b.shader->info.cs.local_size[2], 0);
 
        nir_ssa_def *global_id = nir_iadd(&b, nir_imul(&b, wg_id, block_size), invoc_id);
 
        nir_intrinsic_instr *clear_val = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(clear_val, 0);
+       nir_intrinsic_set_range(clear_val, 16);
        clear_val->src[0] = nir_src_for_ssa(nir_imm_int(&b, 0));
        clear_val->num_components = 4;
        nir_ssa_dest_init(&clear_val->instr, &clear_val->dest, 4, 32, "clear_value");
@@ -660,8 +653,6 @@ radv_device_init_meta_cleari_state(struct radv_device *device)
        VkResult result;
        struct radv_shader_module cs = { .nir = NULL };
 
-       zero(device->meta_state.cleari);
-
        cs.nir = build_nir_cleari_compute_shader(device);
 
        /*
@@ -670,6 +661,7 @@ radv_device_init_meta_cleari_state(struct radv_device *device)
         */
        VkDescriptorSetLayoutCreateInfo ds_create_info = {
                .sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO,
+               .flags = VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR,
                .bindingCount = 1,
                .pBindings = (VkDescriptorSetLayoutBinding[]) {
                        {
@@ -739,21 +731,15 @@ fail:
 static void
 radv_device_finish_meta_cleari_state(struct radv_device *device)
 {
-       if (device->meta_state.cleari.img_p_layout) {
-               radv_DestroyPipelineLayout(radv_device_to_handle(device),
-                                          device->meta_state.cleari.img_p_layout,
-                                          &device->meta_state.alloc);
-       }
-       if (device->meta_state.cleari.img_ds_layout) {
-               radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
-                                               device->meta_state.cleari.img_ds_layout,
-                                               &device->meta_state.alloc);
-       }
-       if (device->meta_state.cleari.pipeline) {
-               radv_DestroyPipeline(radv_device_to_handle(device),
-                                    device->meta_state.cleari.pipeline,
-                                    &device->meta_state.alloc);
-       }
+       struct radv_meta_state *state = &device->meta_state;
+
+       radv_DestroyPipelineLayout(radv_device_to_handle(device),
+                                  state->cleari.img_p_layout, &state->alloc);
+       radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
+                                       state->cleari.img_ds_layout,
+                                       &state->alloc);
+       radv_DestroyPipeline(radv_device_to_handle(device),
+                            state->cleari.pipeline, &state->alloc);
 }
 
 void
@@ -796,52 +782,9 @@ fail_itob:
        return result;
 }
 
-void
-radv_meta_begin_itoi(struct radv_cmd_buffer *cmd_buffer,
-                    struct radv_meta_saved_compute_state *save)
-{
-       radv_meta_save_compute(save, cmd_buffer, 16);
-}
-
-void
-radv_meta_end_itoi(struct radv_cmd_buffer *cmd_buffer,
-                  struct radv_meta_saved_compute_state *save)
-{
-       radv_meta_restore_compute(save, cmd_buffer, 16);
-}
-
-void
-radv_meta_begin_bufimage(struct radv_cmd_buffer *cmd_buffer,
-                        struct radv_meta_saved_compute_state *save)
-{
-       radv_meta_save_compute(save, cmd_buffer, 12);
-}
-
-void
-radv_meta_end_bufimage(struct radv_cmd_buffer *cmd_buffer,
-                      struct radv_meta_saved_compute_state *save)
-{
-       radv_meta_restore_compute(save, cmd_buffer, 12);
-}
-
-void
-radv_meta_begin_cleari(struct radv_cmd_buffer *cmd_buffer,
-                      struct radv_meta_saved_compute_state *save)
-{
-       radv_meta_save_compute(save, cmd_buffer, 16);
-}
-
-void
-radv_meta_end_cleari(struct radv_cmd_buffer *cmd_buffer,
-                    struct radv_meta_saved_compute_state *save)
-{
-       radv_meta_restore_compute(save, cmd_buffer, 16);
-}
-
 static void
 create_iview(struct radv_cmd_buffer *cmd_buffer,
              struct radv_meta_blit2d_surf *surf,
-             VkImageUsageFlags usage,
              struct radv_image_view *iview)
 {
 
@@ -858,7 +801,7 @@ create_iview(struct radv_cmd_buffer *cmd_buffer,
                                             .baseArrayLayer = surf->layer,
                                             .layerCount = 1
                                     },
-                                            }, cmd_buffer, usage);
+                            });
 }
 
 static void
@@ -876,14 +819,13 @@ create_bview(struct radv_cmd_buffer *cmd_buffer,
                                      .format = format,
                                      .offset = offset,
                                      .range = VK_WHOLE_SIZE,
-                             }, cmd_buffer);
+                             });
 
 }
 
 struct itob_temps {
        struct radv_image_view src_iview;
        struct radv_buffer_view dst_bview;
-       VkDescriptorSet set;
 };
 
 static void
@@ -891,57 +833,36 @@ itob_bind_descriptors(struct radv_cmd_buffer *cmd_buffer,
                      struct itob_temps *tmp)
 {
        struct radv_device *device = cmd_buffer->device;
-       VkDevice vk_device = radv_device_to_handle(cmd_buffer->device);
-
-       radv_temp_descriptor_set_create(device, cmd_buffer,
-                                       device->meta_state.itob.img_ds_layout,
-                                       &tmp->set);
-
-       radv_UpdateDescriptorSets(vk_device,
-                                 2, /* writeCount */
-                                 (VkWriteDescriptorSet[]) {
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 0,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
-                                                 .pImageInfo = (VkDescriptorImageInfo[]) {
-                                                         {
-                                                                 .sampler = VK_NULL_HANDLE,
-                                                                 .imageView = radv_image_view_to_handle(&tmp->src_iview),
-                                                                 .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
-                                                         },
-                                                 }
-                                         },
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 1,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
-                                                 .pTexelBufferView = (VkBufferView[])  { radv_buffer_view_to_handle(&tmp->dst_bview) },
-                                         }
-                                 }, 0, NULL);
-
-       radv_CmdBindDescriptorSets(radv_cmd_buffer_to_handle(cmd_buffer),
-                                  VK_PIPELINE_BIND_POINT_COMPUTE,
-                                  device->meta_state.itob.img_p_layout, 0, 1,
-                                  &tmp->set, 0, NULL);
-}
 
-static void
-itob_bind_pipeline(struct radv_cmd_buffer *cmd_buffer)
-{
-       VkPipeline pipeline =
-               cmd_buffer->device->meta_state.itob.pipeline;
-
-       if (cmd_buffer->state.compute_pipeline != radv_pipeline_from_handle(pipeline)) {
-               radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
-                                    VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
-       }
+       radv_meta_push_descriptor_set(cmd_buffer,
+                                     VK_PIPELINE_BIND_POINT_COMPUTE,
+                                     device->meta_state.itob.img_p_layout,
+                                     0, /* set */
+                                     2, /* descriptorWriteCount */
+                                     (VkWriteDescriptorSet[]) {
+                                             {
+                                                     .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                     .dstBinding = 0,
+                                                     .dstArrayElement = 0,
+                                                     .descriptorCount = 1,
+                                                     .descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
+                                                     .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                             {
+                                                                     .sampler = VK_NULL_HANDLE,
+                                                                     .imageView = radv_image_view_to_handle(&tmp->src_iview),
+                                                                     .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                             },
+                                                     }
+                                             },
+                                             {
+                                                     .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                     .dstBinding = 1,
+                                                     .dstArrayElement = 0,
+                                                     .descriptorCount = 1,
+                                                     .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
+                                                     .pTexelBufferView = (VkBufferView[])  { radv_buffer_view_to_handle(&tmp->dst_bview) },
+                                             }
+                                     });
 }
 
 void
@@ -951,14 +872,17 @@ radv_meta_image_to_buffer(struct radv_cmd_buffer *cmd_buffer,
                          unsigned num_rects,
                          struct radv_meta_blit2d_rect *rects)
 {
+       VkPipeline pipeline = cmd_buffer->device->meta_state.itob.pipeline;
        struct radv_device *device = cmd_buffer->device;
        struct itob_temps temps;
 
-       create_iview(cmd_buffer, src, VK_IMAGE_USAGE_SAMPLED_BIT, &temps.src_iview);
+       create_iview(cmd_buffer, src, &temps.src_iview);
        create_bview(cmd_buffer, dst->buffer, dst->offset, dst->format, &temps.dst_bview);
        itob_bind_descriptors(cmd_buffer, &temps);
 
-       itob_bind_pipeline(cmd_buffer);
+
+       radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
+                            VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
 
        for (unsigned r = 0; r < num_rects; ++r) {
                unsigned push_constants[3] = {
@@ -973,13 +897,11 @@ radv_meta_image_to_buffer(struct radv_cmd_buffer *cmd_buffer,
 
                radv_unaligned_dispatch(cmd_buffer, rects[r].width, rects[r].height, 1);
        }
-       radv_temp_descriptor_set_destroy(cmd_buffer->device, temps.set);
 }
 
 struct btoi_temps {
        struct radv_buffer_view src_bview;
        struct radv_image_view dst_iview;
-       VkDescriptorSet set;
 };
 
 static void
@@ -987,57 +909,36 @@ btoi_bind_descriptors(struct radv_cmd_buffer *cmd_buffer,
                      struct btoi_temps *tmp)
 {
        struct radv_device *device = cmd_buffer->device;
-       VkDevice vk_device = radv_device_to_handle(cmd_buffer->device);
-
-       radv_temp_descriptor_set_create(device, cmd_buffer,
-                                       device->meta_state.btoi.img_ds_layout,
-                                       &tmp->set);
-
-       radv_UpdateDescriptorSets(vk_device,
-                                 2, /* writeCount */
-                                 (VkWriteDescriptorSet[]) {
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 0,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
-                                                 .pTexelBufferView = (VkBufferView[])  { radv_buffer_view_to_handle(&tmp->src_bview) },
-                                         },
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 1,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
-                                                 .pImageInfo = (VkDescriptorImageInfo[]) {
-                                                         {
-                                                                 .sampler = VK_NULL_HANDLE,
-                                                                 .imageView = radv_image_view_to_handle(&tmp->dst_iview),
-                                                                 .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
-                                                         },
-                                                 }
-                                         }
-                                 }, 0, NULL);
-
-       radv_CmdBindDescriptorSets(radv_cmd_buffer_to_handle(cmd_buffer),
-                                  VK_PIPELINE_BIND_POINT_COMPUTE,
-                                  device->meta_state.btoi.img_p_layout, 0, 1,
-                                  &tmp->set, 0, NULL);
-}
-
-static void
-btoi_bind_pipeline(struct radv_cmd_buffer *cmd_buffer)
-{
-       VkPipeline pipeline =
-               cmd_buffer->device->meta_state.btoi.pipeline;
 
-       if (cmd_buffer->state.compute_pipeline != radv_pipeline_from_handle(pipeline)) {
-               radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
-                                    VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
-       }
+       radv_meta_push_descriptor_set(cmd_buffer,
+                                     VK_PIPELINE_BIND_POINT_COMPUTE,
+                                     device->meta_state.btoi.img_p_layout,
+                                     0, /* set */
+                                     2, /* descriptorWriteCount */
+                                     (VkWriteDescriptorSet[]) {
+                                             {
+                                                     .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                     .dstBinding = 0,
+                                                     .dstArrayElement = 0,
+                                                     .descriptorCount = 1,
+                                                     .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
+                                                     .pTexelBufferView = (VkBufferView[])  { radv_buffer_view_to_handle(&tmp->src_bview) },
+                                             },
+                                             {
+                                                     .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                     .dstBinding = 1,
+                                                     .dstArrayElement = 0,
+                                                     .descriptorCount = 1,
+                                                     .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+                                                     .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                             {
+                                                                     .sampler = VK_NULL_HANDLE,
+                                                                     .imageView = radv_image_view_to_handle(&tmp->dst_iview),
+                                                                     .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                             },
+                                                     }
+                                             }
+                                     });
 }
 
 void
@@ -1047,14 +948,16 @@ radv_meta_buffer_to_image_cs(struct radv_cmd_buffer *cmd_buffer,
                             unsigned num_rects,
                             struct radv_meta_blit2d_rect *rects)
 {
+       VkPipeline pipeline = cmd_buffer->device->meta_state.btoi.pipeline;
        struct radv_device *device = cmd_buffer->device;
        struct btoi_temps temps;
 
        create_bview(cmd_buffer, src->buffer, src->offset, src->format, &temps.src_bview);
-       create_iview(cmd_buffer, dst, VK_IMAGE_USAGE_STORAGE_BIT, &temps.dst_iview);
+       create_iview(cmd_buffer, dst, &temps.dst_iview);
        btoi_bind_descriptors(cmd_buffer, &temps);
 
-       btoi_bind_pipeline(cmd_buffer);
+       radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
+                            VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
 
        for (unsigned r = 0; r < num_rects; ++r) {
                unsigned push_constants[3] = {
@@ -1069,13 +972,11 @@ radv_meta_buffer_to_image_cs(struct radv_cmd_buffer *cmd_buffer,
 
                radv_unaligned_dispatch(cmd_buffer, rects[r].width, rects[r].height, 1);
        }
-       radv_temp_descriptor_set_destroy(cmd_buffer->device, temps.set);
 }
 
 struct itoi_temps {
        struct radv_image_view src_iview;
        struct radv_image_view dst_iview;
-       VkDescriptorSet set;
 };
 
 static void
@@ -1083,63 +984,42 @@ itoi_bind_descriptors(struct radv_cmd_buffer *cmd_buffer,
                      struct itoi_temps *tmp)
 {
        struct radv_device *device = cmd_buffer->device;
-       VkDevice vk_device = radv_device_to_handle(cmd_buffer->device);
-
-       radv_temp_descriptor_set_create(device, cmd_buffer,
-                                       device->meta_state.itoi.img_ds_layout,
-                                       &tmp->set);
-
-       radv_UpdateDescriptorSets(vk_device,
-                                 2, /* writeCount */
-                                 (VkWriteDescriptorSet[]) {
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 0,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
-                                                 .pImageInfo = (VkDescriptorImageInfo[]) {
-                                                         {
-                                                                 .sampler = VK_NULL_HANDLE,
-                                                                 .imageView = radv_image_view_to_handle(&tmp->src_iview),
-                                                                 .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
-                                                         },
-                                                 }
-                                         },
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 1,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
-                                                 .pImageInfo = (VkDescriptorImageInfo[]) {
-                                                         {
-                                                                 .sampler = VK_NULL_HANDLE,
-                                                                 .imageView = radv_image_view_to_handle(&tmp->dst_iview),
-                                                                 .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
-                                                         },
-                                                 }
-                                         }
-                                 }, 0, NULL);
-
-       radv_CmdBindDescriptorSets(radv_cmd_buffer_to_handle(cmd_buffer),
-                                  VK_PIPELINE_BIND_POINT_COMPUTE,
-                                  device->meta_state.itoi.img_p_layout, 0, 1,
-                                  &tmp->set, 0, NULL);
-}
 
-static void
-itoi_bind_pipeline(struct radv_cmd_buffer *cmd_buffer)
-{
-       VkPipeline pipeline =
-               cmd_buffer->device->meta_state.itoi.pipeline;
-
-       if (cmd_buffer->state.compute_pipeline != radv_pipeline_from_handle(pipeline)) {
-               radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
-                                    VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
-       }
+       radv_meta_push_descriptor_set(cmd_buffer,
+                                     VK_PIPELINE_BIND_POINT_COMPUTE,
+                                     device->meta_state.itoi.img_p_layout,
+                                     0, /* set */
+                                     2, /* descriptorWriteCount */
+                                     (VkWriteDescriptorSet[]) {
+                                             {
+                                                      .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                      .dstBinding = 0,
+                                                      .dstArrayElement = 0,
+                                                      .descriptorCount = 1,
+                                                      .descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
+                                                      .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                              {
+                                                                      .sampler = VK_NULL_HANDLE,
+                                                                      .imageView = radv_image_view_to_handle(&tmp->src_iview),
+                                                                      .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                              },
+                                                      }
+                                             },
+                                             {
+                                                      .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                      .dstBinding = 1,
+                                                      .dstArrayElement = 0,
+                                                      .descriptorCount = 1,
+                                                      .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+                                                      .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                              {
+                                                                      .sampler = VK_NULL_HANDLE,
+                                                                      .imageView = radv_image_view_to_handle(&tmp->dst_iview),
+                                                                      .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                              },
+                                                      }
+                                             }
+                                     });
 }
 
 void
@@ -1149,15 +1029,17 @@ radv_meta_image_to_image_cs(struct radv_cmd_buffer *cmd_buffer,
                            unsigned num_rects,
                            struct radv_meta_blit2d_rect *rects)
 {
+       VkPipeline pipeline = cmd_buffer->device->meta_state.itoi.pipeline;
        struct radv_device *device = cmd_buffer->device;
        struct itoi_temps temps;
 
-       create_iview(cmd_buffer, src, VK_IMAGE_USAGE_SAMPLED_BIT, &temps.src_iview);
-       create_iview(cmd_buffer, dst, VK_IMAGE_USAGE_STORAGE_BIT, &temps.dst_iview);
+       create_iview(cmd_buffer, src, &temps.src_iview);
+       create_iview(cmd_buffer, dst, &temps.dst_iview);
 
        itoi_bind_descriptors(cmd_buffer, &temps);
 
-       itoi_bind_pipeline(cmd_buffer);
+       radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
+                            VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
 
        for (unsigned r = 0; r < num_rects; ++r) {
                unsigned push_constants[4] = {
@@ -1173,61 +1055,35 @@ radv_meta_image_to_image_cs(struct radv_cmd_buffer *cmd_buffer,
 
                radv_unaligned_dispatch(cmd_buffer, rects[r].width, rects[r].height, 1);
        }
-       radv_temp_descriptor_set_destroy(cmd_buffer->device, temps.set);
 }
 
-struct cleari_temps {
-       struct radv_image_view dst_iview;
-       VkDescriptorSet set;
-};
-
 static void
 cleari_bind_descriptors(struct radv_cmd_buffer *cmd_buffer,
-                       struct cleari_temps *tmp)
+                       struct radv_image_view *dst_iview)
 {
        struct radv_device *device = cmd_buffer->device;
-       VkDevice vk_device = radv_device_to_handle(cmd_buffer->device);
-
-       radv_temp_descriptor_set_create(device, cmd_buffer,
-                                       device->meta_state.cleari.img_ds_layout,
-                                       &tmp->set);
-
-       radv_UpdateDescriptorSets(vk_device,
-                                 1, /* writeCount */
-                                 (VkWriteDescriptorSet[]) {
-                                         {
-                                                 .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
-                                                 .dstSet = tmp->set,
-                                                 .dstBinding = 0,
-                                                 .dstArrayElement = 0,
-                                                 .descriptorCount = 1,
-                                                 .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
-                                                 .pImageInfo = (VkDescriptorImageInfo[]) {
-                                                         {
-                                                                 .sampler = VK_NULL_HANDLE,
-                                                                 .imageView = radv_image_view_to_handle(&tmp->dst_iview),
-                                                                 .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
-                                                         },
-                                                 }
-                                         },
-                                 }, 0, NULL);
-
-       radv_CmdBindDescriptorSets(radv_cmd_buffer_to_handle(cmd_buffer),
-                                  VK_PIPELINE_BIND_POINT_COMPUTE,
-                                  device->meta_state.cleari.img_p_layout, 0, 1,
-                                  &tmp->set, 0, NULL);
-}
-
-static void
-cleari_bind_pipeline(struct radv_cmd_buffer *cmd_buffer)
-{
-       VkPipeline pipeline =
-               cmd_buffer->device->meta_state.cleari.pipeline;
 
-       if (cmd_buffer->state.compute_pipeline != radv_pipeline_from_handle(pipeline)) {
-               radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
-                                    VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
-       }
+       radv_meta_push_descriptor_set(cmd_buffer,
+                                     VK_PIPELINE_BIND_POINT_COMPUTE,
+                                     device->meta_state.cleari.img_p_layout,
+                                     0, /* set */
+                                     1, /* descriptorWriteCount */
+                                     (VkWriteDescriptorSet[]) {
+                                             {
+                                                     .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                     .dstBinding = 0,
+                                                     .dstArrayElement = 0,
+                                                     .descriptorCount = 1,
+                                                     .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+                                                     .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                              {
+                                                                     .sampler = VK_NULL_HANDLE,
+                                                                     .imageView = radv_image_view_to_handle(dst_iview),
+                                                                     .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                              },
+                                                     }
+                                              },
+                                     });
 }
 
 void
@@ -1235,13 +1091,15 @@ radv_meta_clear_image_cs(struct radv_cmd_buffer *cmd_buffer,
                         struct radv_meta_blit2d_surf *dst,
                         const VkClearColorValue *clear_color)
 {
+       VkPipeline pipeline = cmd_buffer->device->meta_state.cleari.pipeline;
        struct radv_device *device = cmd_buffer->device;
-       struct cleari_temps temps;
+       struct radv_image_view dst_iview;
 
-       create_iview(cmd_buffer, dst, VK_IMAGE_USAGE_STORAGE_BIT, &temps.dst_iview);
-       cleari_bind_descriptors(cmd_buffer, &temps);
+       create_iview(cmd_buffer, dst, &dst_iview);
+       cleari_bind_descriptors(cmd_buffer, &dst_iview);
 
-       cleari_bind_pipeline(cmd_buffer);
+       radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
+                            VK_PIPELINE_BIND_POINT_COMPUTE, pipeline);
 
        unsigned push_constants[4] = {
                clear_color->uint32[0],
@@ -1255,6 +1113,5 @@ radv_meta_clear_image_cs(struct radv_cmd_buffer *cmd_buffer,
                              VK_SHADER_STAGE_COMPUTE_BIT, 0, 16,
                              push_constants);
 
-       radv_unaligned_dispatch(cmd_buffer, dst->image->extent.width, dst->image->extent.height, 1);
-       radv_temp_descriptor_set_destroy(cmd_buffer->device, temps.set);
+       radv_unaligned_dispatch(cmd_buffer, dst->image->info.width, dst->image->info.height, 1);
 }