radv/meta: don't need vertex info for resolve shader.
[mesa.git] / src / amd / vulkan / radv_meta_decompress.c
index 498cc239bdeb05bd10180695338ca18661f77ba5..5a34863690762b16b6eae2ea64b639a0e273de8d 100644 (file)
 
 #include "radv_meta.h"
 #include "radv_private.h"
-#include "nir/nir_builder.h"
 #include "sid.h"
-/**
- * Vertex attributes used by all pipelines.
- */
-struct vertex_attrs {
-       float position[2]; /**< 3DPRIM_RECTLIST */
-};
-
-/* passthrough vertex shader */
-static nir_shader *
-build_nir_vs(void)
-{
-       const struct glsl_type *vec4 = glsl_vec4_type();
-
-       nir_builder b;
-       nir_variable *a_position;
-       nir_variable *v_position;
-
-       nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_VERTEX, NULL);
-       b.shader->info.name = ralloc_strdup(b.shader, "meta_depth_decomp_vs");
-
-       a_position = nir_variable_create(b.shader, nir_var_shader_in, vec4,
-                                        "a_position");
-       a_position->data.location = VERT_ATTRIB_GENERIC0;
-
-       v_position = nir_variable_create(b.shader, nir_var_shader_out, vec4,
-                                        "gl_Position");
-       v_position->data.location = VARYING_SLOT_POS;
-
-       nir_copy_var(&b, v_position, a_position);
-
-       return b.shader;
-}
-
-/* simple passthrough shader */
-static nir_shader *
-build_nir_fs(void)
-{
-       nir_builder b;
-
-       nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_FRAGMENT, NULL);
-       b.shader->info.name = ralloc_asprintf(b.shader,
-                                             "meta_depth_decomp_noop_fs");
-
-       return b.shader;
-}
 
 static VkResult
 create_pass(struct radv_device *device)
@@ -124,7 +78,7 @@ create_pipeline(struct radv_device *device,
        VkDevice device_h = radv_device_to_handle(device);
 
        struct radv_shader_module fs_module = {
-               .nir = build_nir_fs(),
+               .nir = radv_meta_build_nir_fs_noop(),
        };
 
        if (!fs_module.nir) {
@@ -152,24 +106,8 @@ create_pipeline(struct radv_device *device,
                },
                .pVertexInputState = &(VkPipelineVertexInputStateCreateInfo) {
                        .sType = VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO,
-                       .vertexBindingDescriptionCount = 1,
-                       .pVertexBindingDescriptions = (VkVertexInputBindingDescription[]) {
-                               {
-                                       .binding = 0,
-                                       .stride = sizeof(struct vertex_attrs),
-                                       .inputRate = VK_VERTEX_INPUT_RATE_VERTEX
-                               },
-                       },
-                       .vertexAttributeDescriptionCount = 1,
-                       .pVertexAttributeDescriptions = (VkVertexInputAttributeDescription[]) {
-                               {
-                                       /* Position */
-                                       .location = 0,
-                                       .binding = 0,
-                                       .format = VK_FORMAT_R32G32_SFLOAT,
-                                       .offset = offsetof(struct vertex_attrs, position),
-                               },
-                       },
+                       .vertexBindingDescriptionCount = 0,
+                       .vertexAttributeDescriptionCount = 0,
                },
                .pInputAssemblyState = &(VkPipelineInputAssemblyStateCreateInfo) {
                        .sType = VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO,
@@ -178,8 +116,8 @@ create_pipeline(struct radv_device *device,
                },
                .pViewportState = &(VkPipelineViewportStateCreateInfo) {
                        .sType = VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO,
-                       .viewportCount = 0,
-                       .scissorCount = 0,
+                       .viewportCount = 1,
+                       .scissorCount = 1,
                },
                .pRasterizationState = &(VkPipelineRasterizationStateCreateInfo) {
                        .sType = VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO,
@@ -210,7 +148,14 @@ create_pipeline(struct radv_device *device,
                        .depthBoundsTestEnable = false,
                        .stencilTestEnable = false,
                },
-               .pDynamicState = NULL,
+               .pDynamicState = &(VkPipelineDynamicStateCreateInfo) {
+                       .sType = VK_STRUCTURE_TYPE_PIPELINE_DYNAMIC_STATE_CREATE_INFO,
+                       .dynamicStateCount = 2,
+                       .pDynamicStates = (VkDynamicState[]) {
+                               VK_DYNAMIC_STATE_VIEWPORT,
+                               VK_DYNAMIC_STATE_SCISSOR,
+                       },
+               },
                .renderPass = device->meta_state.depth_decomp.pass,
                .subpass = 0,
        };
@@ -258,16 +203,16 @@ radv_device_finish_meta_depth_decomp_state(struct radv_device *device)
        const VkAllocationCallbacks *alloc = &device->meta_state.alloc;
 
        if (pass_h)
-               RADV_CALL(DestroyRenderPass)(device_h, pass_h,
+               radv_DestroyRenderPass(device_h, pass_h,
                                             &device->meta_state.alloc);
 
        VkPipeline pipeline_h = state->depth_decomp.decompress_pipeline;
        if (pipeline_h) {
-               RADV_CALL(DestroyPipeline)(device_h, pipeline_h, alloc);
+               radv_DestroyPipeline(device_h, pipeline_h, alloc);
        }
        pipeline_h = state->depth_decomp.resummarize_pipeline;
        if (pipeline_h) {
-               RADV_CALL(DestroyPipeline)(device_h, pipeline_h, alloc);
+               radv_DestroyPipeline(device_h, pipeline_h, alloc);
        }
 }
 
@@ -278,7 +223,7 @@ radv_device_init_meta_depth_decomp_state(struct radv_device *device)
 
        zero(device->meta_state.depth_decomp);
 
-       struct radv_shader_module vs_module = { .nir = build_nir_vs() };
+       struct radv_shader_module vs_module = { .nir = radv_meta_build_nir_vs_generate_vertices() };
        if (!vs_module.nir) {
                /* XXX: Need more accurate error */
                res = VK_ERROR_OUT_OF_HOST_MEMORY;
@@ -311,45 +256,7 @@ emit_depth_decomp(struct radv_cmd_buffer *cmd_buffer,
                  const VkExtent2D *depth_decomp_extent,
                  VkPipeline pipeline_h)
 {
-       struct radv_device *device = cmd_buffer->device;
        VkCommandBuffer cmd_buffer_h = radv_cmd_buffer_to_handle(cmd_buffer);
-       uint32_t offset;
-       const struct vertex_attrs vertex_data[3] = {
-               {
-                       .position = {
-                               dest_offset->x,
-                               dest_offset->y,
-                       },
-               },
-               {
-                       .position = {
-                               dest_offset->x,
-                               dest_offset->y + depth_decomp_extent->height,
-                       },
-               },
-               {
-                       .position = {
-                               dest_offset->x + depth_decomp_extent->width,
-                               dest_offset->y,
-                       },
-               },
-       };
-
-       radv_cmd_buffer_upload_data(cmd_buffer, sizeof(vertex_data), 16, vertex_data, &offset);
-       struct radv_buffer vertex_buffer = {
-               .device = device,
-               .size = sizeof(vertex_data),
-               .bo = cmd_buffer->upload.upload_bo,
-               .offset = offset,
-       };
-
-       VkBuffer vertex_buffer_h = radv_buffer_to_handle(&vertex_buffer);
-
-       radv_CmdBindVertexBuffers(cmd_buffer_h,
-                                 /*firstBinding*/ 0,
-                                 /*bindingCount*/ 1,
-                                 (VkBuffer[]) { vertex_buffer_h },
-                                 (VkDeviceSize[]) { 0 });
 
        RADV_FROM_HANDLE(radv_pipeline, pipeline, pipeline_h);
 
@@ -358,7 +265,21 @@ emit_depth_decomp(struct radv_cmd_buffer *cmd_buffer,
                                     pipeline_h);
        }
 
-       RADV_CALL(CmdDraw)(cmd_buffer_h, 3, 1, 0, 0);
+       radv_CmdSetViewport(radv_cmd_buffer_to_handle(cmd_buffer), 0, 1, &(VkViewport) {
+               .x = dest_offset->x,
+               .y = dest_offset->y,
+               .width = depth_decomp_extent->width,
+               .height = depth_decomp_extent->height,
+               .minDepth = 0.0f,
+               .maxDepth = 1.0f
+       });
+
+       radv_CmdSetScissor(radv_cmd_buffer_to_handle(cmd_buffer), 0, 1, &(VkRect2D) {
+               .offset = *dest_offset,
+               .extent = *depth_decomp_extent,
+       });
+
+       radv_CmdDraw(cmd_buffer_h, 3, 1, 0, 0);
 }
 
 
@@ -371,18 +292,18 @@ static void radv_process_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
        struct radv_meta_saved_pass_state saved_pass_state;
        VkDevice device_h = radv_device_to_handle(cmd_buffer->device);
        VkCommandBuffer cmd_buffer_h = radv_cmd_buffer_to_handle(cmd_buffer);
-       uint32_t width = radv_minify(image->extent.width,
+       uint32_t width = radv_minify(image->info.width,
                                     subresourceRange->baseMipLevel);
-       uint32_t height = radv_minify(image->extent.height,
+       uint32_t height = radv_minify(image->info.height,
                                     subresourceRange->baseMipLevel);
 
-       if (!image->htile.size)
+       if (!image->surface.htile_size)
                return;
        radv_meta_save_pass(&saved_pass_state, cmd_buffer);
 
-       radv_meta_save_graphics_reset_vport_scissor(&saved_state, cmd_buffer);
+       radv_meta_save_graphics_reset_vport_scissor_novertex(&saved_state, cmd_buffer);
 
-       for (uint32_t layer = 0; layer < subresourceRange->layerCount; layer++) {
+       for (uint32_t layer = 0; layer < radv_get_layerCount(image, subresourceRange); layer++) {
                struct radv_image_view iview;
 
                radv_image_view_init(&iview, cmd_buffer->device,
@@ -397,8 +318,7 @@ static void radv_process_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
                                                     .baseArrayLayer = subresourceRange->baseArrayLayer + layer,
                                                     .layerCount = 1,
                                             },
-                                    },
-                                    cmd_buffer, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT);
+                                    });
 
 
                VkFramebuffer fb_h;
@@ -416,7 +336,7 @@ static void radv_process_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
                                       &cmd_buffer->pool->alloc,
                                       &fb_h);
 
-               RADV_CALL(CmdBeginRenderPass)(cmd_buffer_h,
+               radv_CmdBeginRenderPass(cmd_buffer_h,
                                              &(VkRenderPassBeginInfo) {
                                                      .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO,
                                                              .renderPass = cmd_buffer->device->meta_state.depth_decomp.pass,
@@ -437,7 +357,7 @@ static void radv_process_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
                                           VK_SUBPASS_CONTENTS_INLINE);
 
                emit_depth_decomp(cmd_buffer, &(VkOffset2D){0, 0 }, &(VkExtent2D){width, height}, pipeline_h);
-               RADV_CALL(CmdEndRenderPass)(cmd_buffer_h);
+               radv_CmdEndRenderPass(cmd_buffer_h);
 
                radv_DestroyFramebuffer(device_h, fb_h,
                                        &cmd_buffer->pool->alloc);
@@ -450,6 +370,7 @@ void radv_decompress_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
                                         struct radv_image *image,
                                         VkImageSubresourceRange *subresourceRange)
 {
+       assert(cmd_buffer->queue_family_index == RADV_QUEUE_GENERAL);
        radv_process_depth_image_inplace(cmd_buffer, image, subresourceRange,
                                         cmd_buffer->device->meta_state.depth_decomp.decompress_pipeline);
 }
@@ -458,6 +379,7 @@ void radv_resummarize_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,
                                         struct radv_image *image,
                                         VkImageSubresourceRange *subresourceRange)
 {
+       assert(cmd_buffer->queue_family_index == RADV_QUEUE_GENERAL);
        radv_process_depth_image_inplace(cmd_buffer, image, subresourceRange,
                                         cmd_buffer->device->meta_state.depth_decomp.resummarize_pipeline);
 }