radv: remove semicolon in if(...);
[mesa.git] / src / amd / vulkan / radv_meta_resolve_fs.c
index c0345cf22fda05cb068651d2c1a0958fbb77a2a5..2f745f0ea09f2023a499ba0cb1863973034e302a 100644 (file)
@@ -38,7 +38,7 @@ build_nir_vertex_shader(void)
        nir_builder b;
 
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_VERTEX, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, "meta_resolve_vs");
+       b.shader->info.name = ralloc_strdup(b.shader, "meta_resolve_vs");
 
        nir_variable *pos_out = nir_variable_create(b.shader, nir_var_shader_out,
                                                    vec4, "gl_Position");
@@ -51,7 +51,7 @@ build_nir_vertex_shader(void)
 }
 
 static nir_shader *
-build_resolve_fragment_shader(struct radv_device *dev, bool is_integer, bool is_srgb, int samples)
+build_resolve_fragment_shader(struct radv_device *dev, bool is_integer, int samples)
 {
        nir_builder b;
        char name[64];
@@ -62,9 +62,9 @@ build_resolve_fragment_shader(struct radv_device *dev, bool is_integer, bool is_
                                                                 false,
                                                                 GLSL_TYPE_FLOAT);
 
-       snprintf(name, 64, "meta_resolve_fs-%d-%s", samples, is_integer ? "int" : (is_srgb ? "srgb" : "float"));
+       snprintf(name, 64, "meta_resolve_fs-%d-%s", samples, is_integer ? "int" : "float");
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_FRAGMENT, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, name);
+       b.shader->info.name = ralloc_strdup(b.shader, name);
 
        nir_variable *input_img = nir_variable_create(b.shader, nir_var_uniform,
                                                      sampler_type, "s_tex");
@@ -92,8 +92,8 @@ build_resolve_fragment_shader(struct radv_device *dev, bool is_integer, bool is_
        nir_ssa_def *img_coord = nir_channels(&b, nir_iadd(&b, pos_int, &src_offset->dest.ssa), 0x3);
        nir_variable *color = nir_local_variable_create(b.impl, glsl_vec4_type(), "color");
 
-       radv_meta_build_resolve_shader_core(&b, is_integer, is_srgb,samples,
-                                           input_img, color, img_coord);
+       radv_meta_build_resolve_shader_core(&b, is_integer, samples, input_img,
+                                           color, img_coord);
 
        nir_ssa_def *outval = nir_load_var(&b, color);
        nir_store_var(&b, color_out, outval, 0xf);
@@ -152,31 +152,16 @@ fail:
 
 static const VkPipelineVertexInputStateCreateInfo normal_vi_create_info = {
        .sType = VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO,
-       .vertexBindingDescriptionCount = 1,
-       .pVertexBindingDescriptions = (VkVertexInputBindingDescription[]) {
-               {
-                       .binding = 0,
-                       .stride = 2 * sizeof(float),
-                       .inputRate = VK_VERTEX_INPUT_RATE_VERTEX
-               },
-       },
-       .vertexAttributeDescriptionCount = 1,
-       .pVertexAttributeDescriptions = (VkVertexInputAttributeDescription[]) {
-               {
-                       /* Texture Coordinate */
-                       .location = 0,
-                       .binding = 0,
-                       .format = VK_FORMAT_R32G32_SFLOAT,
-                       .offset = 0
-               },
-       },
+       .vertexBindingDescriptionCount = 0,
+       .vertexAttributeDescriptionCount = 0,
 };
 
 static VkFormat pipeline_formats[] = {
    VK_FORMAT_R8G8B8A8_UNORM,
    VK_FORMAT_R8G8B8A8_UINT,
    VK_FORMAT_R8G8B8A8_SINT,
-   VK_FORMAT_R8G8B8A8_SRGB,
+   VK_FORMAT_A2R10G10B10_UINT_PACK32,
+   VK_FORMAT_A2R10G10B10_SINT_PACK32,
    VK_FORMAT_R16G16B16A16_UNORM,
    VK_FORMAT_R16G16B16A16_SNORM,
    VK_FORMAT_R16G16B16A16_UINT,
@@ -192,23 +177,26 @@ create_resolve_pipeline(struct radv_device *device,
                        VkFormat format)
 {
        VkResult result;
-       bool is_integer = false, is_srgb = false;
+       bool is_integer = false;
        uint32_t samples = 1 << samples_log2;
        unsigned fs_key = radv_format_meta_fs_key(format);
        const VkPipelineVertexInputStateCreateInfo *vi_create_info;
        vi_create_info = &normal_vi_create_info;
        if (vk_format_is_int(format))
                is_integer = true;
-       else if (vk_format_is_srgb(format))
-               is_srgb = true;
 
        struct radv_shader_module fs = { .nir = NULL };
-       fs.nir = build_resolve_fragment_shader(device, is_integer, is_srgb, samples);
+       fs.nir = build_resolve_fragment_shader(device, is_integer, samples);
        struct radv_shader_module vs = {
                .nir = build_nir_vertex_shader(),
        };
 
-       /* compute shader */
+       VkRenderPass *rp = &device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key];
+
+       assert(!*rp);
+
+       VkPipeline *pipeline = &device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key];
+       assert(!*pipeline);
 
        VkPipelineShaderStageCreateInfo pipeline_shader_stages[] = {
                {
@@ -226,6 +214,7 @@ create_resolve_pipeline(struct radv_device *device,
                },
        };
 
+
        result = radv_CreateRenderPass(radv_device_to_handle(device),
                                       &(VkRenderPassCreateInfo) {
                                               .sType = VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO,
@@ -255,7 +244,7 @@ create_resolve_pipeline(struct radv_device *device,
                                               .pPreserveAttachments = (uint32_t[]) { 0 },
                                       },
                                       .dependencyCount = 0,
-                                               }, &device->meta_state.alloc, &device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key]);
+                                               }, &device->meta_state.alloc, rp);
 
 
        const VkGraphicsPipelineCreateInfo vk_pipeline_info = {
@@ -314,7 +303,7 @@ create_resolve_pipeline(struct radv_device *device,
                },
                .flags = 0,
                .layout = device->meta_state.resolve_fragment.p_layout,
-               .renderPass = device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key],
+               .renderPass = *rp,
                .subpass = 0,
        };
 
@@ -326,8 +315,7 @@ create_resolve_pipeline(struct radv_device *device,
                                               radv_pipeline_cache_to_handle(&device->meta_state.cache),
                                               &vk_pipeline_info, &radv_pipeline_info,
                                               &device->meta_state.alloc,
-                                              &device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key]);
-
+                                              pipeline);
 
        ralloc_free(vs.nir);
        ralloc_free(fs.nir);
@@ -374,7 +362,6 @@ radv_device_finish_meta_resolve_fragment_state(struct radv_device *device)
                                             state->resolve_fragment.rc[i].pipeline[j],
                                             &state->alloc);
                }
-
        }
 
        radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
@@ -388,6 +375,7 @@ radv_device_finish_meta_resolve_fragment_state(struct radv_device *device)
 static void
 emit_resolve(struct radv_cmd_buffer *cmd_buffer,
             struct radv_image_view *src_iview,
+            struct radv_image_view *dest_iview,
             const VkOffset2D *src_offset,
              const VkOffset2D *dest_offset,
              const VkExtent2D *resolve_extent)
@@ -429,7 +417,7 @@ emit_resolve(struct radv_cmd_buffer *cmd_buffer,
                              VK_SHADER_STAGE_FRAGMENT_BIT, 0, 8,
                              push_constants);
 
-       unsigned fs_key = radv_format_meta_fs_key(src_iview->vk_format);
+       unsigned fs_key = radv_format_meta_fs_key(dest_iview->vk_format);
        VkPipeline pipeline_h = device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key];
 
        radv_CmdBindPipeline(cmd_buffer_h, VK_PIPELINE_BIND_POINT_GRAPHICS,
@@ -466,6 +454,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
        const uint32_t samples = src_image->info.samples;
        const uint32_t samples_log2 = ffs(samples) - 1;
        unsigned fs_key = radv_format_meta_fs_key(dest_image->vk_format);
+       VkRenderPass rp;
        for (uint32_t r = 0; r < region_count; ++r) {
                const VkImageResolve *region = &regions[r];
                const uint32_t src_base_layer =
@@ -480,6 +469,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                radv_fast_clear_flush_image_inplace(cmd_buffer, src_image, &range);
        }
 
+       rp = device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key];
        radv_meta_save_graphics_reset_vport_scissor_novertex(&saved_state, cmd_buffer);
 
        for (uint32_t r = 0; r < region_count; ++r) {
@@ -521,8 +511,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                                                             .baseArrayLayer = src_base_layer + layer,
                                                             .layerCount = 1,
                                                     },
-                                            },
-                                            cmd_buffer, VK_IMAGE_USAGE_SAMPLED_BIT);
+                                            });
 
                        struct radv_image_view dest_iview;
                        radv_image_view_init(&dest_iview, cmd_buffer->device,
@@ -538,8 +527,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                                                             .baseArrayLayer = dest_base_layer + layer,
                                                             .layerCount = 1,
                                                     },
-                                                            },
-                                            cmd_buffer, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT);
+                                            });
 
 
                        VkFramebuffer fb;
@@ -558,7 +546,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                        radv_CmdBeginRenderPass(radv_cmd_buffer_to_handle(cmd_buffer),
                                                &(VkRenderPassBeginInfo) {
                                                        .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO,
-                                                               .renderPass = device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key],
+                                                               .renderPass = rp,
                                                                .framebuffer = fb,
                                                                .renderArea = {
                                                                .offset = { dstOffset.x, dstOffset.y, },
@@ -572,6 +560,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
 
                        emit_resolve(cmd_buffer,
                                     &src_iview,
+                                    &dest_iview,
                                     &(VkOffset2D) { srcOffset.x, srcOffset.y },
                                     &(VkOffset2D) { dstOffset.x, dstOffset.y },
                                     &(VkExtent2D) { extent.width, extent.height });
@@ -613,11 +602,15 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
        for (uint32_t i = 0; i < subpass->color_count; ++i) {
                VkAttachmentReference src_att = subpass->color_attachments[i];
                VkAttachmentReference dest_att = subpass->resolve_attachments[i];
-               struct radv_image *dst_img = cmd_buffer->state.framebuffer->attachments[dest_att.attachment].attachment->image;
-               struct radv_image_view *src_iview = cmd_buffer->state.framebuffer->attachments[src_att.attachment].attachment;
-               if (dest_att.attachment == VK_ATTACHMENT_UNUSED)
+
+               if (src_att.attachment == VK_ATTACHMENT_UNUSED ||
+                   dest_att.attachment == VK_ATTACHMENT_UNUSED)
                        continue;
 
+               struct radv_image_view *dest_iview = cmd_buffer->state.framebuffer->attachments[dest_att.attachment].attachment;
+               struct radv_image *dst_img = dest_iview->image;
+               struct radv_image_view *src_iview = cmd_buffer->state.framebuffer->attachments[src_att.attachment].attachment;
+
                if (dst_img->surface.dcc_size) {
                        radv_initialize_dcc(cmd_buffer, dst_img, 0xffffffff);
                        cmd_buffer->state.attachments[dest_att.attachment].current_layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL;
@@ -649,6 +642,7 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
                 */
                emit_resolve(cmd_buffer,
                             src_iview,
+                            dest_iview,
                             &(VkOffset2D) { 0, 0 },
                             &(VkOffset2D) { 0, 0 },
                             &(VkExtent2D) { fb->width, fb->height });